[jira] [Updated] (PHOENIX-6717) Remove Hbase 2.1 and 2.2 from post-commit Jenkins job
[ https://issues.apache.org/jira/browse/PHOENIX-6717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Istvan Toth updated PHOENIX-6717: - Summary: Remove Hbase 2.1 and 2.2 from post-commit Jenkins job (was: Remove Hbase 2.1 and 2.1 from post-commit Jenkins job) > Remove Hbase 2.1 and 2.2 from post-commit Jenkins job > - > > Key: PHOENIX-6717 > URL: https://issues.apache.org/jira/browse/PHOENIX-6717 > Project: Phoenix > Issue Type: Bug > Components: core >Affects Versions: 5.2.0 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > > I forgot to do it when I removed the support. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (PHOENIX-6717) Remove Hbase 2.1 and 2.1 from post-commit Jenkins job
Istvan Toth created PHOENIX-6717: Summary: Remove Hbase 2.1 and 2.1 from post-commit Jenkins job Key: PHOENIX-6717 URL: https://issues.apache.org/jira/browse/PHOENIX-6717 Project: Phoenix Issue Type: Bug Components: core Affects Versions: 5.2.0 Reporter: Istvan Toth Assignee: Istvan Toth I forgot to do it when I removed the support. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [phoenix-omid] stoty commented on a diff in pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4
stoty commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875445938
##
pom.xml:
##
@@ -612,20 +570,28 @@
hbase-1
-
-
-
-
-hbase-2
-
-${shims2.artifactId}
-hbase-2
-1.8
-${hadoop2.version}
-${hbase2.version}
-
${hbase2.artifactId.suffix}
-2.11.0
-
+
+
+
+org.apache.maven.plugins
+maven-enforcer-plugin
+
+
+enforce
+
+ enforce
+
+
+
+
Review Comment:
We can add the same AlwaysFail for hbase-2 too, or just remove both
profiles, I'm fine either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [phoenix-omid] stoty commented on a diff in pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4
stoty commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875445600
##
pom.xml:
##
@@ -147,33 +146,19 @@
-
-hbase1.x
-hbase2.x
-
-
omid-hbase-shims-${hbase1.artifactId.suffix}
-
omid-hbase-shims-${hbase2.artifactId.suffix}
-
-
-${shims1.artifactId}
-1.7
-${hadoop1.version}
-${hbase1.version}
-hbase-1
-
${hbase1.artifactId.suffix}
+1.8
+2.11.0
UTF-8
-1.3.1
-2.0.1
-2.7.5
-3.0.0
+2.4.12
+2.10.0
2.0.0
3.0
6.10
-1.7.7
+1.7.30
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [phoenix-omid] stoty commented on a diff in pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4
stoty commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875445204
##
pom.xml:
##
@@ -147,33 +146,19 @@
-
-hbase1.x
-hbase2.x
-
-
omid-hbase-shims-${hbase1.artifactId.suffix}
-
omid-hbase-shims-${hbase2.artifactId.suffix}
-
-
-${shims1.artifactId}
-1.7
-${hadoop1.version}
-${hbase1.version}
-hbase-1
-
${hbase1.artifactId.suffix}
+1.8
+2.11.0
UTF-8
-1.3.1
-2.0.1
-2.7.5
-3.0.0
+2.4.12
+2.10.0
2.0.0
3.0
6.10
-1.7.7
+1.7.30
Review Comment:
This will mess the classpath up, as the slf4j backend pulls in relad4j, and
we still pull log4j12.
I won't clean that up, as I plan to switch to log4j2 before 1.1 is released
anayway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [phoenix-omid] stoty commented on a diff in pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4
stoty commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875444085
##
pom.xml:
##
@@ -147,33 +146,19 @@
-
-hbase1.x
-hbase2.x
-
-
omid-hbase-shims-${hbase1.artifactId.suffix}
-
omid-hbase-shims-${hbase2.artifactId.suffix}
-
-
-${shims1.artifactId}
-1.7
-${hadoop1.version}
-${hbase1.version}
-hbase-1
-
${hbase1.artifactId.suffix}
+1.8
+2.11.0
UTF-8
-1.3.1
-2.0.1
-2.7.5
-3.0.0
+2.4.12
+2.10.0
2.0.0
3.0
6.10
-1.7.7
+1.7.30
Review Comment:
OK, I will update.
(edited to remove false statement about using log4j2)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [phoenix-omid] stoty commented on a diff in pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4
stoty commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875444085
##
pom.xml:
##
@@ -147,33 +146,19 @@
-
-hbase1.x
-hbase2.x
-
-
omid-hbase-shims-${hbase1.artifactId.suffix}
-
omid-hbase-shims-${hbase2.artifactId.suffix}
-
-
-${shims1.artifactId}
-1.7
-${hadoop1.version}
-${hbase1.version}
-hbase-1
-
${hbase1.artifactId.suffix}
+1.8
+2.11.0
UTF-8
-1.3.1
-2.0.1
-2.7.5
-3.0.0
+2.4.12
+2.10.0
2.0.0
3.0
6.10
-1.7.7
+1.7.30
Review Comment:
OK, I will update.
(Note that omid uses log4j2 already)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [phoenix-omid] stoty commented on a diff in pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4
stoty commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875443116
##
hbase-client/src/test/java/org/apache/omid/transaction/TestCellUtils.java:
##
@@ -137,7 +136,7 @@ public void testCorrectMapingOfCellsToShadowCells() throws
IOException {
"Should be equal");
// Modify dup shadow cell to have a greater MVCC and check that is
replaced
-HBaseShims.setKeyValueSequenceId((KeyValue) dupCell1WithAnotherValue,
1);
+((KeyValue)dupCell1WithAnotherValue).setSequenceId(1);
Review Comment:
As that would be an effective code change, I think that we should track that
in a separate ticket, if you think that we should have that for 1.1. (it's only
used in tests)
I originally tried to refactor all the deprecated HBase 1.x APIs as part of
this change, but I postponed that to OMID-223 , as it's a lot of work and there
are some hairy cases, and I want to get Omid released 1.1 ASAP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [phoenix-omid] stoty commented on a diff in pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4
stoty commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875439934
##
pom.xml:
##
@@ -612,20 +570,28 @@
hbase-1
-
-
-
-
-hbase-2
-
-${shims2.artifactId}
-hbase-2
-1.8
-${hadoop2.version}
-${hbase2.version}
-
${hbase2.artifactId.suffix}
-2.11.0
-
+
+
+
+org.apache.maven.plugins
+maven-enforcer-plugin
+
+
+enforce
+
+ enforce
+
+
+
+
Review Comment:
I've meant this as a courtesy to let people who try to update to 1.1 without
checking the release notes know early that it won't work.
If I removed this, the old build command for HBase 1.x would sill work, even
though HBase 1.x is no longer supported.
It is not essential, as we've also changed the artifact names, so they would
figure out when the expected artifacts are not present at the latest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [phoenix-omid] stoty commented on a diff in pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4
stoty commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875438343
##
pom.xml:
##
@@ -147,33 +146,19 @@
-
-hbase1.x
-hbase2.x
-
-
omid-hbase-shims-${hbase1.artifactId.suffix}
-
omid-hbase-shims-${hbase2.artifactId.suffix}
-
-
-${shims1.artifactId}
-1.7
-${hadoop1.version}
-${hbase1.version}
-hbase-1
-
${hbase1.artifactId.suffix}
+1.8
+2.11.0
UTF-8
-1.3.1
-2.0.1
-2.7.5
-3.0.0
+2.4.12
+2.10.0
Review Comment:
We've never used hadoop2.version in the old build, it was just copy-paste
remainder.
As Omid doesn't create shaded artifacts with Hbase bits, the Haodop we build
with has no impact on the end product, only on what we run the tests with.
I'm tracking this in OMID-163, but as this would require that we rebuild
HBase for Hadoop3 for testing the same way that we do for Phoenix, I have
decided against doing this.
If you feel that this is important, I can work on OMID-163, but it's out of
scope for this JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [phoenix-omid] gjacoby126 commented on a diff in pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4
gjacoby126 commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875233006
##
pom.xml:
##
@@ -147,33 +146,19 @@
-
-hbase1.x
-hbase2.x
-
-
omid-hbase-shims-${hbase1.artifactId.suffix}
-
omid-hbase-shims-${hbase2.artifactId.suffix}
-
-
-${shims1.artifactId}
-1.7
-${hadoop1.version}
-${hbase1.version}
-hbase-1
-
${hbase1.artifactId.suffix}
+1.8
+2.11.0
UTF-8
-1.3.1
-2.0.1
-2.7.5
-3.0.0
+2.4.12
+2.10.0
2.0.0
3.0
6.10
-1.7.7
+1.7.30
Review Comment:
Let's go all the way up to slf4j.version 1.7.36, the latest, which
transparently uses reload4j where necessary if any slf4j dependency tries to
pull in log4j 1.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [phoenix-omid] gjacoby126 commented on a diff in pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4
gjacoby126 commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875216816
##
hbase-client/src/test/java/org/apache/omid/transaction/TestCellUtils.java:
##
@@ -137,7 +136,7 @@ public void testCorrectMapingOfCellsToShadowCells() throws
IOException {
"Should be equal");
// Modify dup shadow cell to have a greater MVCC and check that is
replaced
-HBaseShims.setKeyValueSequenceId((KeyValue) dupCell1WithAnotherValue,
1);
+((KeyValue)dupCell1WithAnotherValue).setSequenceId(1);
Review Comment:
Should we be using ExtendedCell rather than KeyValue? (Technically they're
both IA.Private, but it at least doesn't couple us to KeyValue's on-heap
array-backed implementation)
##
pom.xml:
##
@@ -147,33 +146,19 @@
-
-hbase1.x
-hbase2.x
-
-
omid-hbase-shims-${hbase1.artifactId.suffix}
-
omid-hbase-shims-${hbase2.artifactId.suffix}
-
-
-${shims1.artifactId}
-1.7
-${hadoop1.version}
-${hbase1.version}
-hbase-1
-
${hbase1.artifactId.suffix}
+1.8
+2.11.0
UTF-8
-1.3.1
-2.0.1
-2.7.5
-3.0.0
+2.4.12
+2.10.0
Review Comment:
We only support Hadoop 3 in Phoenix but only 2.10 in Omid? Seems like an odd
inconsistency, esp since the old hadoop2.version here is actually 3.0.0
##
pom.xml:
##
@@ -147,33 +146,19 @@
-
-hbase1.x
-hbase2.x
-
-
omid-hbase-shims-${hbase1.artifactId.suffix}
-
omid-hbase-shims-${hbase2.artifactId.suffix}
-
-
-${shims1.artifactId}
-1.7
-${hadoop1.version}
-${hbase1.version}
-hbase-1
-
${hbase1.artifactId.suffix}
+1.8
+2.11.0
UTF-8
-1.3.1
-2.0.1
-2.7.5
-3.0.0
+2.4.12
+2.10.0
2.0.0
3.0
6.10
-1.7.7
+1.7.30
Review Comment:
Let's go all the way up to slf4j.version 1.7.36, the latest, which
transparently uses reload4j where necessary if anything slf4j dependency tries
to pull in log4j 1.x.
##
pom.xml:
##
@@ -612,20 +570,28 @@
hbase-1
-
-
-
-
-hbase-2
-
-${shims2.artifactId}
-hbase-2
-1.8
-${hadoop2.version}
-${hbase2.version}
-
${hbase2.artifactId.suffix}
-2.11.0
-
+
+
+
+org.apache.maven.plugins
+maven-enforcer-plugin
+
+
+enforce
+
+ enforce
+
+
+
+
Review Comment:
Even if this is just a draft, why AlwaysFail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [phoenix-omid] stoty commented on pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4
stoty commented on PR #105: URL: https://github.com/apache/phoenix-omid/pull/105#issuecomment-1129271715 The failure with hbase-1 profile is intentional, as it is no longer supported. I'm going to update the test job. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-omid] gjacoby126 commented on pull request #105: OMID-222 Remove HBase1 support and update HBase 2 version to 2.4
gjacoby126 commented on PR #105: URL: https://github.com/apache/phoenix-omid/pull/105#issuecomment-1129262892 Build fails with an enforcer rule to always fail? `[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce) @ omid --- [WARNING] Rule 0: org.apache.maven.plugins.enforcer.AlwaysFail failed with message: Always fails!` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (PHOENIX-6716) pherf tests fail with Hbase 2.4
Istvan Toth created PHOENIX-6716:
Summary: pherf tests fail with Hbase 2.4
Key: PHOENIX-6716
URL: https://issues.apache.org/jira/browse/PHOENIX-6716
Project: Phoenix
Issue Type: Bug
Components: core
Affects Versions: 5.2.0
Reporter: Istvan Toth
But pass with HBase 2.3
{noformat}
[ERROR] Failures:
[ERROR]
DataIngestIT.testColumnRulesApplied:112->assertExpectedNumberOfRecordsWritten:240
Expected 100 rows to have been inserted expected:<30> but was:<31>
[ERROR] Errors:
[ERROR] PherfMainIT.testNoQueryTimeout:128 » FileNotFound
/tmp/RESULTS/RESULT_COMBINED...
[ERROR] PherfMainIT.testQueryTimeout:84 » FileNotFound
/tmp/RESULTS/RESULT_COMBINED_20...{noformat}
This is possibly another symptom of PHOENIX-6702.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Assigned] (PHOENIX-6715) Update Omid to 1.1.0
[ https://issues.apache.org/jira/browse/PHOENIX-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Istvan Toth reassigned PHOENIX-6715: Assignee: Istvan Toth > Update Omid to 1.1.0 > > > Key: PHOENIX-6715 > URL: https://issues.apache.org/jira/browse/PHOENIX-6715 > Project: Phoenix > Issue Type: Task > Components: core >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > > We should release Omid 1.1.0 , and update Phoenix to it for 5.2 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (PHOENIX-6715) Update Omid to 1.1.0
Istvan Toth created PHOENIX-6715: Summary: Update Omid to 1.1.0 Key: PHOENIX-6715 URL: https://issues.apache.org/jira/browse/PHOENIX-6715 Project: Phoenix Issue Type: Task Components: core Reporter: Istvan Toth We should release Omid 1.1.0 , and update Phoenix to it for 5.2 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Resolved] (PHOENIX-6713) Adjust impersonation in phoinixdb to be able to to use principal_username
[ https://issues.apache.org/jira/browse/PHOENIX-6713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Richárd Antal resolved PHOENIX-6713. Resolution: Won't Fix This issue will be handled in hue: [https://github.com/cloudera/hue/issues/2850] > Adjust impersonation in phoinixdb to be able to to use principal_username > - > > Key: PHOENIX-6713 > URL: https://issues.apache.org/jira/browse/PHOENIX-6713 > Project: Phoenix > Issue Type: Bug > Components: python >Reporter: Richárd Antal >Assignee: Richárd Antal >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (OMID-223) Refactor Omid to use HBase 2 APIs internally.
[ https://issues.apache.org/jira/browse/OMID-223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Istvan Toth updated OMID-223: - Attachment: OMID-223-wip.patch > Refactor Omid to use HBase 2 APIs internally. > - > > Key: OMID-223 > URL: https://issues.apache.org/jira/browse/OMID-223 > Project: Phoenix Omid > Issue Type: Improvement >Reporter: Istvan Toth >Priority: Major > Attachments: OMID-223-wip.patch > > > Omid currently uses HBase APIs everywhere. > This made sense when HBase 1 and 2 had to be supported from the same codebase. > However, as we're dropping HBase 1 support, this is a liability now. > Doing this is also going to eventually make supporting HBase 3 much easier. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (OMID-223) Refactor Omid to use HBase 2 APIs internally.
Istvan Toth created OMID-223: Summary: Refactor Omid to use HBase 2 APIs internally. Key: OMID-223 URL: https://issues.apache.org/jira/browse/OMID-223 Project: Phoenix Omid Issue Type: Improvement Reporter: Istvan Toth Omid currently uses HBase APIs everywhere. This made sense when HBase 1 and 2 had to be supported from the same codebase. However, as we're dropping HBase 1 support, this is a liability now. Doing this is also going to eventually make supporting HBase 3 much easier. -- This message was sent by Atlassian Jira (v8.20.7#820007)
