Re: Format code in XSSFSheetXMLHandler.SheetContentsHandler

2018-05-06 Thread Greg Woolsey
Don't know the history, but the value is not that straightforward.  If the
cell has a specifically assigned format, it is used.  However, format may
also be derived from conditional formatting, which may not be evaluated in
that context.  In fact, conditional formatting evaluation is quite a recent
addition to POI.  I haven't checked, but since the same or similar
formatting constructs are used, it could also come from theme or table
styles.

On Sun, May 6, 2018, 20:55 Wilson de Carvalho  wrote:

> Hi, everyone.
>
> I've been working in a solution with an implementation
> of XSSFSheetXMLHandler.SheetContentsHandler interface and struggled with
> date-formatted cells. I wonder why the format code that is present in the
> style file is not provided in method
>
> public void cell(String cellReference, String formattedValue, XSSFComment
> comment),
>
> thus making it something like:
>
> public void cell(String cellReference, String formattedValue, XSSFComment
> comment, String formatString)
>
>
> It would greatly improve user code flexibility if the format string that is
> used to define a cell was also provided in this method. It would avoid the
> need of extending org.xml.sax.helpers.DefaultHandler when the sole purpouse
> is to have access to the cell format string.
>
> Any thoughts or considerations?
>
>
> Regards,
>
> --
> Wilson de Carvalho.
>


Format code in XSSFSheetXMLHandler.SheetContentsHandler

2018-05-06 Thread Wilson de Carvalho
Hi, everyone.

I've been working in a solution with an implementation
of XSSFSheetXMLHandler.SheetContentsHandler interface and struggled with
date-formatted cells. I wonder why the format code that is present in the
style file is not provided in method

public void cell(String cellReference, String formattedValue, XSSFComment
comment),

thus making it something like:

public void cell(String cellReference, String formattedValue, XSSFComment
comment, String formatString)


It would greatly improve user code flexibility if the format string that is
used to define a cell was also provided in this method. It would avoid the
need of extending org.xml.sax.helpers.DefaultHandler when the sole purpouse
is to have access to the cell format string.

Any thoughts or considerations?


Regards,

-- 
Wilson de Carvalho.


Re: 3.18? Or push for 4?

2018-05-06 Thread Tim Allison
I’m somewhat inclined towards a 3.18 sooner, but I defer to those more
active on the project.

There’s one trivial issue I need to look into based on some Tika work; I’ll
have time to take care of that on Monday.

Cheers,

Tim

On Fri, May 4, 2018 at 12:49 PM Andreas Beeker  wrote:

> Hi *,
>
> my plan was to wait for commons-compress 1.17 and then release poi 4.0.0.
>
> I'm currently trying to use jigsaw modules and would like rather push
> module refactoring for jigsaw
> than backporting stuff, but if you list the bugzilla issue for a 3.X
> maintenance release I'm happy to merge those.
>
> I'm not really into android development, but I guess providing android /
> Java 9+ compatibility [1] are diametrically opposed goals, right? So we
> might need to backport stuff anyways for a while ...
>
> Andi
>
>
> [1]
>
> https://stackoverflow.com/questions/47627499/does-android-studio-3-support-java-9-for-android-development
> https://developer.android.com/studio/write/java8-support
>
>
> On 5/4/18 11:23 AM, Nick Burch wrote:
> > Hi All
> >
> > We released 3.17 back in September, which is over 6 months ago. The
> changelog  says we've done quite a bit
> > since then
> >
> > What do we think about another release? Do a 3.18, then breaking changes
> for 4.0 afterwards to release that in the summer? Or just finish stuff up
> and push 4.0 out soon?
> >
> > Nick
> >
>
>
>


[Bug 62355] New: Unsplit packages to conform Jigsaw (Java 9) module standard

2018-05-06 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62355

Bug ID: 62355
   Summary: Unsplit packages to conform Jigsaw (Java 9) module
standard
   Product: POI
   Version: 4.0-dev
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P2
 Component: POI Overall
  Assignee: dev@poi.apache.org
  Reporter: kiwiwi...@apache.org
  Target Milestone: ---

Currently it's not possible to include POI as an automatic module [3], i.e.
users can't use module-info to depend on POI [1][2].

Although a real module would be nice, we should at least unsplit the packages.

I'm currently working on it and would like to provide it in 4.0.0.
Of course there will be breaking changes, but mostly in some base classes,
which I guess, users code would hardly use.


[1] http://poi.apache.org/faq.html#faq-N102B0
[2] https://stackoverflow.com/questions/44463552
[3] http://blog.joda.org/2017/05/java-se-9-jpms-automatic-modules.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



Build failed in Jenkins: POI-DSL-1.10 #11

2018-05-06 Thread Apache Jenkins Server
See 


Changes:

[kiwiwings] add convenience method for files to FileMagic

[kiwiwings] add additional exception info to failing IOUtils.toByteArray

[kiwiwings] add license header

--
[...truncated 348.48 KB...]
[junit] Reading spreadsheet/duprich1.xls with HPSFFileHandler
[junit] Reading spreadsheet/duprich2.xls with HSSFFileHandler
[junit] Reading spreadsheet/duprich2.xls with HPSFFileHandler
[junit] Reading spreadsheet/dvEmpty.xls with HSSFFileHandler
[junit] Reading spreadsheet/dvEmpty.xls with HPSFFileHandler
[junit] Reading spreadsheet/empty.xls with HSSFFileHandler
[junit] Reading spreadsheet/empty.xls with HPSFFileHandler
[junit] Reading 
spreadsheet/evaluate_formula_with_structured_table_references.xlsx with 
XSSFFileHandler
[junit] Reading 
spreadsheet/evaluate_formula_with_structured_table_references.xlsx with 
OPCFileHandler
[junit] Reading spreadsheet/evencontinuation.txt with NullFileHandler
[junit] Reading spreadsheet/ex41187-19267.xls with HSSFFileHandler
[junit] Reading spreadsheet/ex41187-19267.xls with HPSFFileHandler
[junit] Reading spreadsheet/ex42564-21435.xls with HSSFFileHandler
[junit] Reading spreadsheet/ex42564-21435.xls with HPSFFileHandler
[junit] Reading spreadsheet/ex42564-21503.xls with HSSFFileHandler
[junit] Reading spreadsheet/ex42564-21503.xls with HPSFFileHandler
[junit] Reading spreadsheet/ex42564-elementOrder.xls with HSSFFileHandler
[junit] Reading spreadsheet/ex42564-elementOrder.xls with HPSFFileHandler
[junit] Reading spreadsheet/ex42570-20305.xls with HSSFFileHandler
[junit] Reading spreadsheet/ex42570-20305.xls with HPSFFileHandler
[junit] Reading spreadsheet/ex44921-21902.xls with HSSFFileHandler
[junit] Reading spreadsheet/ex44921-21902.xls with HPSFFileHandler
[junit] Reading spreadsheet/ex45046-21984.xls with HSSFFileHandler
[junit] Reading spreadsheet/ex45046-21984.xls with HPSFFileHandler
[junit] Reading spreadsheet/ex45582-22397.xls with HSSFFileHandler
[junit] Reading spreadsheet/ex45582-22397.xls with HPSFFileHandler
[junit] Reading spreadsheet/ex45672.xls with HSSFFileHandler
[junit] Reading spreadsheet/ex45672.xls with HPSFFileHandler
[junit] Reading spreadsheet/ex45698-22488.xls with HSSFFileHandler
[junit] Reading spreadsheet/ex45698-22488.xls with HPSFFileHandler
[junit] Reading spreadsheet/ex45978-extraLinkTableSheets.xls with 
HSSFFileHandler
[junit] Reading spreadsheet/ex45978-extraLinkTableSheets.xls with 
HPSFFileHandler
[junit] Reading spreadsheet/ex46548-23133.xls with HSSFFileHandler
[junit] Reading spreadsheet/ex46548-23133.xls with HPSFFileHandler
[junit] Reading spreadsheet/ex47747-sharedFormula.xls with HSSFFileHandler
[junit] Reading spreadsheet/ex47747-sharedFormula.xls with HPSFFileHandler
[junit] Reading spreadsheet/excel_with_embeded.xls with HSSFFileHandler
[junit] Reading spreadsheet/excel_with_embeded.xls with HPSFFileHandler
[junit] Reading spreadsheet/excelant.xls with HSSFFileHandler
[junit] Reading spreadsheet/excelant.xls with HPSFFileHandler
[junit] Reading spreadsheet/extendedtextstrings.txt with NullFileHandler
[junit] Reading spreadsheet/externalFunctionExample.xls with HSSFFileHandler
[junit] Reading spreadsheet/externalFunctionExample.xls with HPSFFileHandler
[junit] Reading spreadsheet/external_image.xls with HSSFFileHandler
[junit] Reading spreadsheet/external_image.xls with HPSFFileHandler
[junit] Reading spreadsheet/finance.xls with HSSFFileHandler
[junit] Reading spreadsheet/finance.xls with HPSFFileHandler
[junit] Reading spreadsheet/florida_data.ashx.xls with HSSFFileHandler
[junit] Reading spreadsheet/florida_data.ashx.xls with HPSFFileHandler
[junit] Reading spreadsheet/headerFooterTest.xlsx with XSSFFileHandler
[junit] Reading spreadsheet/headerFooterTest.xlsx with OPCFileHandler
[junit] Reading spreadsheet/hyperlink.xlsb with XSSFBFileHandler
[junit] Reading spreadsheet/intercept.xls with HSSFFileHandler
[junit] Reading spreadsheet/intercept.xls with HPSFFileHandler
[junit] Reading spreadsheet/logoKarmokar4.png with NullFileHandler
[junit] Reading spreadsheet/maxindextest.xls with HSSFFileHandler
[junit] Reading spreadsheet/maxindextest.xls with HPSFFileHandler
[junit] Reading spreadsheet/mirrTest.xls with HSSFFileHandler
[junit] Reading spreadsheet/mirrTest.xls with HPSFFileHandler
[junit] Reading spreadsheet/missingFuncs44675.xls with HSSFFileHandler
[junit] Reading spreadsheet/missingFuncs44675.xls with HPSFFileHandler
[junit] Reading spreadsheet/mortgage-calculation.xls with HSSFFileHandler
[junit] Reading spreadsheet/mortgage-calculation.xls with HPSFFileHandler
[junit] Reading spreadsheet/multibookFormulaA.xls with HSSFFileHandler