[Attention] We need everybody's co-operation to comply with the licensing requirements

[Rajith Attapattu]

Hi All,

Yet again I had to fix a number of files for licensing header.  I
undertook a similar effort for 0.5 release and it's not a pleasant job
:)
I know we are all guilty of forgetting to add the licensing header
sometimes, but please lets make an effort to be a bit more mindful
going forward.
It certainly wasted yet another RC and pushed our release date
further. We should also make it a point to run the RAT tool from the
very first RC.


Regards,

Rajith Attapattu
Red Hat
http://rajith.2rlabs.com/

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Commented: (QPID-2404) The following files does not have the ASL license header

[Rajith Attapattu (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832835#action_12832835
 ] 

Rajith Attapattu commented on QPID-2404:


I will fix trunk with the same tomorrow.

> The following files does not have the ASL license header
> 
>
> Key: QPID-2404
> URL: https://issues.apache.org/jira/browse/QPID-2404
> Project: Qpid
>  Issue Type: Improvement
>  Components: Licensing
>Reporter: Rajith Attapattu
>Assignee: Rajith Attapattu
>Priority: Blocker
> Fix For: 0.6
>
> Attachments: rat_feb_11_2005_06_branch
>
>
> ./cpp/examples/README.verify
> ./cpp/src/qpid/framing/Blob.h
> ./cpp/src/qpid/framing/BodyHolder.cpp
> ./cpp/src/qpid/framing/BodyHolder.h
> ./cpp/src/tests/Blob.cpp
> ./cpp/src/tests/cluster_python_tests
> ./cpp/src/tests/cluster_test_scripts/cluster_check
> ./cpp/src/tests/cluster_test_scripts/cluster_start
> ./cpp/src/tests/cluster_test_scripts/cluster_stop
> ./cpp/src/tests/cluster_test_scripts/config_example.sh
> ./cpp/src/tests/cluster_test_scripts/perftest
> ./java/broker/scripts/resetAlerting.sh
> ./java/broker/src/main/java/org/apache/qpid/server/protocol/AMQProtocolEngineFactory.java
> ./java/broker/src/main/java/org/apache/qpid/server/queue/SubFlushRunner.java
> ./java/broker/src/main/java/org/apache/qpid/server/security/access/AuthorizationManager.java
> ./java/broker/src/main/java/org/apache/qpid/server/txn/LocalTransaction.java
> ./java/client/src/test/java/org/apache/qpid/client/message/AbstractJMSMessageTest.java
> ./java/client/test/bin/IBM-README.txt
> ./java/common/src/main/java/org/apache/qpid/thread/DefaultThreadFactory.java
> ./java/common/src/main/java/org/apache/qpid/thread/RealtimeThreadFactory.java
> ./java/common/src/main/java/org/apache/qpid/thread/ThreadFactory.java
> ./java/common/src/main/java/org/apache/qpid/thread/Threading.java
> ./java/common/src/test/java/org/apache/qpid/codec/AMQDecoderTest.java
> ./java/common/src/test/java/org/apache/qpid/codec/MockAMQVersionAwareProtocolSession.java
> ./java/common/src/test/java/org/apache/qpid/thread/ThreadFactoryTest.java
> ./java/integrationtests/docs/RunningSustainedTests.txt
> ./java/management/agent/src/main/java/org/apache/qpid/agent/EventSeverity.java
> ./java/management/client/web.xml
> ./java/management/client/console/brokers_management.jsp
> ./java/management/client/console/console.jsp
> ./java/management/client/console/error_page.jsp
> ./java/management/client/console/jmx_perspective.jsp
> ./java/management/client/console/logging_configuration.jsp
> ./java/management/client/console/resources_management.jsp
> ./java/management/client/console/tbd.jsp
> ./java/management/client/console/wsdm_operations_perspective.jsp
> ./java/management/client/console/wsdm_properties_perspective.jsp
> ./java/management/client/console/wsdm_rmd_perspective.jsp
> ./java/management/client/console/wsdm_wsdl_perspective.jsp
> ./java/management/client/console/fragments/header.jsp
> ./java/management/client/console/fragments/menu.jsp
> ./java/management/client/console/images/style.css
> ./java/management/client/etc/jetty.xml
> ./java/management/client/etc/log4j.xml
> ./java/management/client/src/main/java/muse.xml
> ./java/management/client/src/main/java/org/apache/qpid/management/domain/model/QpidEntity.java
> ./java/management/client/src/main/java/org/apache/qpid/management/wsdm/muse/engine/WSDMAdapterEnvironment.java
> ./java/management/client/src/main/java/org/apache/qpid/management/wsdm/muse/engine/WSDMAdapterIsolationLayer.java
> ./java/management/client/src/main/java/router-entries/adapter/resource-instance-1.xml
> ./java/management/client/src/main/java/router-entries/consumer/resource-instance-1.xml
> ./java/management/client/src/main/java/wsdl/QManAdapter.rmd
> ./java/management/client/src/main/java/wsdl/QManAdapter.wsdl
> ./java/management/client/src/main/java/wsdl/QManWsResource.rmd
> ./java/management/client/src/main/java/wsdl/QManWsResource.wsdl
> ./java/management/client/src/main/java/wsdl/SOAP-Envelope-1_2.xsd
> ./java/management/client/src/main/java/wsdl/WS-Addressing-2005_08.xsd
> ./java/management/client/src/main/java/wsdl/WS-MetadataExchange-2004_09.xsd
> ./java/management/client/src/main/java/wsdl/WS-ServiceGroup-1_2.wsdl
> ./java/management/client/src/main/java/wsdl/WS-ServiceGroupEntry-1_2.wsdl
> ./java/management/client/src/main/java/wsdl/WSDM-MUWS-Part1-1_1.xsd
> ./java/management/client/src/main/java/wsdl/WSDM-MUWS-Part2-1_1.xsd
> ./java/management/client/src/main/java/wsdl/WsResource.rmd
> ./java/management/client/src/main/java/wsdl/WsResourceFactory.wsdl
> ./java/management/client/src/main/java/wsdl/XML-Namespace-1998.xsd
> ./java/management/client/src/test/java/log4j.xml
> ./java/management/client/src/test/java/org/apache/qp

[jira] Updated: (QPID-2404) The following files does not have the ASL license header

[Rajith Attapattu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajith Attapattu updated QPID-2404:
---

Attachment: rat_feb_11_2005_06_branch

I have checked in the license headers for the missing files at rev 909229 in 
the 0.6 release branch.
Attached is the RAT output after the license headers are fixed.

> The following files does not have the ASL license header
> 
>
> Key: QPID-2404
> URL: https://issues.apache.org/jira/browse/QPID-2404
> Project: Qpid
>  Issue Type: Improvement
>  Components: Licensing
>Reporter: Rajith Attapattu
>Assignee: Rajith Attapattu
>Priority: Blocker
> Fix For: 0.6
>
> Attachments: rat_feb_11_2005_06_branch
>
>
> ./cpp/examples/README.verify
> ./cpp/src/qpid/framing/Blob.h
> ./cpp/src/qpid/framing/BodyHolder.cpp
> ./cpp/src/qpid/framing/BodyHolder.h
> ./cpp/src/tests/Blob.cpp
> ./cpp/src/tests/cluster_python_tests
> ./cpp/src/tests/cluster_test_scripts/cluster_check
> ./cpp/src/tests/cluster_test_scripts/cluster_start
> ./cpp/src/tests/cluster_test_scripts/cluster_stop
> ./cpp/src/tests/cluster_test_scripts/config_example.sh
> ./cpp/src/tests/cluster_test_scripts/perftest
> ./java/broker/scripts/resetAlerting.sh
> ./java/broker/src/main/java/org/apache/qpid/server/protocol/AMQProtocolEngineFactory.java
> ./java/broker/src/main/java/org/apache/qpid/server/queue/SubFlushRunner.java
> ./java/broker/src/main/java/org/apache/qpid/server/security/access/AuthorizationManager.java
> ./java/broker/src/main/java/org/apache/qpid/server/txn/LocalTransaction.java
> ./java/client/src/test/java/org/apache/qpid/client/message/AbstractJMSMessageTest.java
> ./java/client/test/bin/IBM-README.txt
> ./java/common/src/main/java/org/apache/qpid/thread/DefaultThreadFactory.java
> ./java/common/src/main/java/org/apache/qpid/thread/RealtimeThreadFactory.java
> ./java/common/src/main/java/org/apache/qpid/thread/ThreadFactory.java
> ./java/common/src/main/java/org/apache/qpid/thread/Threading.java
> ./java/common/src/test/java/org/apache/qpid/codec/AMQDecoderTest.java
> ./java/common/src/test/java/org/apache/qpid/codec/MockAMQVersionAwareProtocolSession.java
> ./java/common/src/test/java/org/apache/qpid/thread/ThreadFactoryTest.java
> ./java/integrationtests/docs/RunningSustainedTests.txt
> ./java/management/agent/src/main/java/org/apache/qpid/agent/EventSeverity.java
> ./java/management/client/web.xml
> ./java/management/client/console/brokers_management.jsp
> ./java/management/client/console/console.jsp
> ./java/management/client/console/error_page.jsp
> ./java/management/client/console/jmx_perspective.jsp
> ./java/management/client/console/logging_configuration.jsp
> ./java/management/client/console/resources_management.jsp
> ./java/management/client/console/tbd.jsp
> ./java/management/client/console/wsdm_operations_perspective.jsp
> ./java/management/client/console/wsdm_properties_perspective.jsp
> ./java/management/client/console/wsdm_rmd_perspective.jsp
> ./java/management/client/console/wsdm_wsdl_perspective.jsp
> ./java/management/client/console/fragments/header.jsp
> ./java/management/client/console/fragments/menu.jsp
> ./java/management/client/console/images/style.css
> ./java/management/client/etc/jetty.xml
> ./java/management/client/etc/log4j.xml
> ./java/management/client/src/main/java/muse.xml
> ./java/management/client/src/main/java/org/apache/qpid/management/domain/model/QpidEntity.java
> ./java/management/client/src/main/java/org/apache/qpid/management/wsdm/muse/engine/WSDMAdapterEnvironment.java
> ./java/management/client/src/main/java/org/apache/qpid/management/wsdm/muse/engine/WSDMAdapterIsolationLayer.java
> ./java/management/client/src/main/java/router-entries/adapter/resource-instance-1.xml
> ./java/management/client/src/main/java/router-entries/consumer/resource-instance-1.xml
> ./java/management/client/src/main/java/wsdl/QManAdapter.rmd
> ./java/management/client/src/main/java/wsdl/QManAdapter.wsdl
> ./java/management/client/src/main/java/wsdl/QManWsResource.rmd
> ./java/management/client/src/main/java/wsdl/QManWsResource.wsdl
> ./java/management/client/src/main/java/wsdl/SOAP-Envelope-1_2.xsd
> ./java/management/client/src/main/java/wsdl/WS-Addressing-2005_08.xsd
> ./java/management/client/src/main/java/wsdl/WS-MetadataExchange-2004_09.xsd
> ./java/management/client/src/main/java/wsdl/WS-ServiceGroup-1_2.wsdl
> ./java/management/client/src/main/java/wsdl/WS-ServiceGroupEntry-1_2.wsdl
> ./java/management/client/src/main/java/wsdl/WSDM-MUWS-Part1-1_1.xsd
> ./java/management/client/src/main/java/wsdl/WSDM-MUWS-Part2-1_1.xsd
> ./java/management/client/src/main/java/wsdl/WsResource.rmd
> ./java/management/client/src/main/java/wsdl/WsResourceFactory.wsdl
> ./java/management/client/src/main/java/wsdl/XML-Namespace-19

[jira] Commented: (QPID-2404) The following files does not have the ASL license header

[Rajith Attapattu (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832834#action_12832834
 ] 

Rajith Attapattu commented on QPID-2404:


@Steve
I also noticed that these files were empty, but was curious why they weren't 
removed from svn.
So I just left them as it is and added the license txt

> The following files does not have the ASL license header
> 
>
> Key: QPID-2404
> URL: https://issues.apache.org/jira/browse/QPID-2404
> Project: Qpid
>  Issue Type: Improvement
>  Components: Licensing
>Reporter: Rajith Attapattu
>Assignee: Rajith Attapattu
>Priority: Blocker
> Fix For: 0.6
>
> Attachments: rat_feb_11_2005_06_branch
>
>
> ./cpp/examples/README.verify
> ./cpp/src/qpid/framing/Blob.h
> ./cpp/src/qpid/framing/BodyHolder.cpp
> ./cpp/src/qpid/framing/BodyHolder.h
> ./cpp/src/tests/Blob.cpp
> ./cpp/src/tests/cluster_python_tests
> ./cpp/src/tests/cluster_test_scripts/cluster_check
> ./cpp/src/tests/cluster_test_scripts/cluster_start
> ./cpp/src/tests/cluster_test_scripts/cluster_stop
> ./cpp/src/tests/cluster_test_scripts/config_example.sh
> ./cpp/src/tests/cluster_test_scripts/perftest
> ./java/broker/scripts/resetAlerting.sh
> ./java/broker/src/main/java/org/apache/qpid/server/protocol/AMQProtocolEngineFactory.java
> ./java/broker/src/main/java/org/apache/qpid/server/queue/SubFlushRunner.java
> ./java/broker/src/main/java/org/apache/qpid/server/security/access/AuthorizationManager.java
> ./java/broker/src/main/java/org/apache/qpid/server/txn/LocalTransaction.java
> ./java/client/src/test/java/org/apache/qpid/client/message/AbstractJMSMessageTest.java
> ./java/client/test/bin/IBM-README.txt
> ./java/common/src/main/java/org/apache/qpid/thread/DefaultThreadFactory.java
> ./java/common/src/main/java/org/apache/qpid/thread/RealtimeThreadFactory.java
> ./java/common/src/main/java/org/apache/qpid/thread/ThreadFactory.java
> ./java/common/src/main/java/org/apache/qpid/thread/Threading.java
> ./java/common/src/test/java/org/apache/qpid/codec/AMQDecoderTest.java
> ./java/common/src/test/java/org/apache/qpid/codec/MockAMQVersionAwareProtocolSession.java
> ./java/common/src/test/java/org/apache/qpid/thread/ThreadFactoryTest.java
> ./java/integrationtests/docs/RunningSustainedTests.txt
> ./java/management/agent/src/main/java/org/apache/qpid/agent/EventSeverity.java
> ./java/management/client/web.xml
> ./java/management/client/console/brokers_management.jsp
> ./java/management/client/console/console.jsp
> ./java/management/client/console/error_page.jsp
> ./java/management/client/console/jmx_perspective.jsp
> ./java/management/client/console/logging_configuration.jsp
> ./java/management/client/console/resources_management.jsp
> ./java/management/client/console/tbd.jsp
> ./java/management/client/console/wsdm_operations_perspective.jsp
> ./java/management/client/console/wsdm_properties_perspective.jsp
> ./java/management/client/console/wsdm_rmd_perspective.jsp
> ./java/management/client/console/wsdm_wsdl_perspective.jsp
> ./java/management/client/console/fragments/header.jsp
> ./java/management/client/console/fragments/menu.jsp
> ./java/management/client/console/images/style.css
> ./java/management/client/etc/jetty.xml
> ./java/management/client/etc/log4j.xml
> ./java/management/client/src/main/java/muse.xml
> ./java/management/client/src/main/java/org/apache/qpid/management/domain/model/QpidEntity.java
> ./java/management/client/src/main/java/org/apache/qpid/management/wsdm/muse/engine/WSDMAdapterEnvironment.java
> ./java/management/client/src/main/java/org/apache/qpid/management/wsdm/muse/engine/WSDMAdapterIsolationLayer.java
> ./java/management/client/src/main/java/router-entries/adapter/resource-instance-1.xml
> ./java/management/client/src/main/java/router-entries/consumer/resource-instance-1.xml
> ./java/management/client/src/main/java/wsdl/QManAdapter.rmd
> ./java/management/client/src/main/java/wsdl/QManAdapter.wsdl
> ./java/management/client/src/main/java/wsdl/QManWsResource.rmd
> ./java/management/client/src/main/java/wsdl/QManWsResource.wsdl
> ./java/management/client/src/main/java/wsdl/SOAP-Envelope-1_2.xsd
> ./java/management/client/src/main/java/wsdl/WS-Addressing-2005_08.xsd
> ./java/management/client/src/main/java/wsdl/WS-MetadataExchange-2004_09.xsd
> ./java/management/client/src/main/java/wsdl/WS-ServiceGroup-1_2.wsdl
> ./java/management/client/src/main/java/wsdl/WS-ServiceGroupEntry-1_2.wsdl
> ./java/management/client/src/main/java/wsdl/WSDM-MUWS-Part1-1_1.xsd
> ./java/management/client/src/main/java/wsdl/WSDM-MUWS-Part2-1_1.xsd
> ./java/management/client/src/main/java/wsdl/WsResource.rmd
> ./java/management/client/src/main/java/wsdl/WsResourceFactory.wsdl
> ./java/management/client/src/main/java/wsdl/XML-Namespa

[jira] Commented: (QPID-2404) The following files does not have the ASL license header

[Steve Huston (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832732#action_12832732
 ] 

Steve Huston commented on QPID-2404:


FYI, these files:

./cpp/src/qpid/framing/Blob.h
./cpp/src/qpid/framing/BodyHolder.cpp
./cpp/src/qpid/framing/BodyHolder.h
./cpp/src/tests/Blob.cpp

do not appear in the CMake files and probably are not needed. I faintly recall 
questioning this a while back and got no response.

If nobody corrects this, they can be removed.


> The following files does not have the ASL license header
> 
>
> Key: QPID-2404
> URL: https://issues.apache.org/jira/browse/QPID-2404
> Project: Qpid
>  Issue Type: Improvement
>  Components: Licensing
>Reporter: Rajith Attapattu
>Assignee: Rajith Attapattu
>Priority: Blocker
> Fix For: 0.6
>
>
> ./cpp/examples/README.verify
> ./cpp/src/qpid/framing/Blob.h
> ./cpp/src/qpid/framing/BodyHolder.cpp
> ./cpp/src/qpid/framing/BodyHolder.h
> ./cpp/src/tests/Blob.cpp
> ./cpp/src/tests/cluster_python_tests
> ./cpp/src/tests/cluster_test_scripts/cluster_check
> ./cpp/src/tests/cluster_test_scripts/cluster_start
> ./cpp/src/tests/cluster_test_scripts/cluster_stop
> ./cpp/src/tests/cluster_test_scripts/config_example.sh
> ./cpp/src/tests/cluster_test_scripts/perftest
> ./java/broker/scripts/resetAlerting.sh
> ./java/broker/src/main/java/org/apache/qpid/server/protocol/AMQProtocolEngineFactory.java
> ./java/broker/src/main/java/org/apache/qpid/server/queue/SubFlushRunner.java
> ./java/broker/src/main/java/org/apache/qpid/server/security/access/AuthorizationManager.java
> ./java/broker/src/main/java/org/apache/qpid/server/txn/LocalTransaction.java
> ./java/client/src/test/java/org/apache/qpid/client/message/AbstractJMSMessageTest.java
> ./java/client/test/bin/IBM-README.txt
> ./java/common/src/main/java/org/apache/qpid/thread/DefaultThreadFactory.java
> ./java/common/src/main/java/org/apache/qpid/thread/RealtimeThreadFactory.java
> ./java/common/src/main/java/org/apache/qpid/thread/ThreadFactory.java
> ./java/common/src/main/java/org/apache/qpid/thread/Threading.java
> ./java/common/src/test/java/org/apache/qpid/codec/AMQDecoderTest.java
> ./java/common/src/test/java/org/apache/qpid/codec/MockAMQVersionAwareProtocolSession.java
> ./java/common/src/test/java/org/apache/qpid/thread/ThreadFactoryTest.java
> ./java/integrationtests/docs/RunningSustainedTests.txt
> ./java/management/agent/src/main/java/org/apache/qpid/agent/EventSeverity.java
> ./java/management/client/web.xml
> ./java/management/client/console/brokers_management.jsp
> ./java/management/client/console/console.jsp
> ./java/management/client/console/error_page.jsp
> ./java/management/client/console/jmx_perspective.jsp
> ./java/management/client/console/logging_configuration.jsp
> ./java/management/client/console/resources_management.jsp
> ./java/management/client/console/tbd.jsp
> ./java/management/client/console/wsdm_operations_perspective.jsp
> ./java/management/client/console/wsdm_properties_perspective.jsp
> ./java/management/client/console/wsdm_rmd_perspective.jsp
> ./java/management/client/console/wsdm_wsdl_perspective.jsp
> ./java/management/client/console/fragments/header.jsp
> ./java/management/client/console/fragments/menu.jsp
> ./java/management/client/console/images/style.css
> ./java/management/client/etc/jetty.xml
> ./java/management/client/etc/log4j.xml
> ./java/management/client/src/main/java/muse.xml
> ./java/management/client/src/main/java/org/apache/qpid/management/domain/model/QpidEntity.java
> ./java/management/client/src/main/java/org/apache/qpid/management/wsdm/muse/engine/WSDMAdapterEnvironment.java
> ./java/management/client/src/main/java/org/apache/qpid/management/wsdm/muse/engine/WSDMAdapterIsolationLayer.java
> ./java/management/client/src/main/java/router-entries/adapter/resource-instance-1.xml
> ./java/management/client/src/main/java/router-entries/consumer/resource-instance-1.xml
> ./java/management/client/src/main/java/wsdl/QManAdapter.rmd
> ./java/management/client/src/main/java/wsdl/QManAdapter.wsdl
> ./java/management/client/src/main/java/wsdl/QManWsResource.rmd
> ./java/management/client/src/main/java/wsdl/QManWsResource.wsdl
> ./java/management/client/src/main/java/wsdl/SOAP-Envelope-1_2.xsd
> ./java/management/client/src/main/java/wsdl/WS-Addressing-2005_08.xsd
> ./java/management/client/src/main/java/wsdl/WS-MetadataExchange-2004_09.xsd
> ./java/management/client/src/main/java/wsdl/WS-ServiceGroup-1_2.wsdl
> ./java/management/client/src/main/java/wsdl/WS-ServiceGroupEntry-1_2.wsdl
> ./java/management/client/src/main/java/wsdl/WSDM-MUWS-Part1-1_1.xsd
> ./java/management/client/src/main/java/wsdl/WSDM-MUWS-Part2-1_1.xsd
> ./java/management/client/src/main/java/wsdl/WsResource.rmd
> ./java/manage

[jira] Assigned: (QPID-2404) The following files does not have the ASL license header

[Rajith Attapattu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rajith Attapattu reassigned QPID-2404:
--

Assignee: Rajith Attapattu

> The following files does not have the ASL license header
> 
>
> Key: QPID-2404
> URL: https://issues.apache.org/jira/browse/QPID-2404
> Project: Qpid
>  Issue Type: Improvement
>  Components: Licensing
>Reporter: Rajith Attapattu
>Assignee: Rajith Attapattu
>Priority: Blocker
> Fix For: 0.6
>
>
> ./cpp/examples/README.verify
> ./cpp/src/qpid/framing/Blob.h
> ./cpp/src/qpid/framing/BodyHolder.cpp
> ./cpp/src/qpid/framing/BodyHolder.h
> ./cpp/src/tests/Blob.cpp
> ./cpp/src/tests/cluster_python_tests
> ./cpp/src/tests/cluster_test_scripts/cluster_check
> ./cpp/src/tests/cluster_test_scripts/cluster_start
> ./cpp/src/tests/cluster_test_scripts/cluster_stop
> ./cpp/src/tests/cluster_test_scripts/config_example.sh
> ./cpp/src/tests/cluster_test_scripts/perftest
> ./java/broker/scripts/resetAlerting.sh
> ./java/broker/src/main/java/org/apache/qpid/server/protocol/AMQProtocolEngineFactory.java
> ./java/broker/src/main/java/org/apache/qpid/server/queue/SubFlushRunner.java
> ./java/broker/src/main/java/org/apache/qpid/server/security/access/AuthorizationManager.java
> ./java/broker/src/main/java/org/apache/qpid/server/txn/LocalTransaction.java
> ./java/client/src/test/java/org/apache/qpid/client/message/AbstractJMSMessageTest.java
> ./java/client/test/bin/IBM-README.txt
> ./java/common/src/main/java/org/apache/qpid/thread/DefaultThreadFactory.java
> ./java/common/src/main/java/org/apache/qpid/thread/RealtimeThreadFactory.java
> ./java/common/src/main/java/org/apache/qpid/thread/ThreadFactory.java
> ./java/common/src/main/java/org/apache/qpid/thread/Threading.java
> ./java/common/src/test/java/org/apache/qpid/codec/AMQDecoderTest.java
> ./java/common/src/test/java/org/apache/qpid/codec/MockAMQVersionAwareProtocolSession.java
> ./java/common/src/test/java/org/apache/qpid/thread/ThreadFactoryTest.java
> ./java/integrationtests/docs/RunningSustainedTests.txt
> ./java/management/agent/src/main/java/org/apache/qpid/agent/EventSeverity.java
> ./java/management/client/web.xml
> ./java/management/client/console/brokers_management.jsp
> ./java/management/client/console/console.jsp
> ./java/management/client/console/error_page.jsp
> ./java/management/client/console/jmx_perspective.jsp
> ./java/management/client/console/logging_configuration.jsp
> ./java/management/client/console/resources_management.jsp
> ./java/management/client/console/tbd.jsp
> ./java/management/client/console/wsdm_operations_perspective.jsp
> ./java/management/client/console/wsdm_properties_perspective.jsp
> ./java/management/client/console/wsdm_rmd_perspective.jsp
> ./java/management/client/console/wsdm_wsdl_perspective.jsp
> ./java/management/client/console/fragments/header.jsp
> ./java/management/client/console/fragments/menu.jsp
> ./java/management/client/console/images/style.css
> ./java/management/client/etc/jetty.xml
> ./java/management/client/etc/log4j.xml
> ./java/management/client/src/main/java/muse.xml
> ./java/management/client/src/main/java/org/apache/qpid/management/domain/model/QpidEntity.java
> ./java/management/client/src/main/java/org/apache/qpid/management/wsdm/muse/engine/WSDMAdapterEnvironment.java
> ./java/management/client/src/main/java/org/apache/qpid/management/wsdm/muse/engine/WSDMAdapterIsolationLayer.java
> ./java/management/client/src/main/java/router-entries/adapter/resource-instance-1.xml
> ./java/management/client/src/main/java/router-entries/consumer/resource-instance-1.xml
> ./java/management/client/src/main/java/wsdl/QManAdapter.rmd
> ./java/management/client/src/main/java/wsdl/QManAdapter.wsdl
> ./java/management/client/src/main/java/wsdl/QManWsResource.rmd
> ./java/management/client/src/main/java/wsdl/QManWsResource.wsdl
> ./java/management/client/src/main/java/wsdl/SOAP-Envelope-1_2.xsd
> ./java/management/client/src/main/java/wsdl/WS-Addressing-2005_08.xsd
> ./java/management/client/src/main/java/wsdl/WS-MetadataExchange-2004_09.xsd
> ./java/management/client/src/main/java/wsdl/WS-ServiceGroup-1_2.wsdl
> ./java/management/client/src/main/java/wsdl/WS-ServiceGroupEntry-1_2.wsdl
> ./java/management/client/src/main/java/wsdl/WSDM-MUWS-Part1-1_1.xsd
> ./java/management/client/src/main/java/wsdl/WSDM-MUWS-Part2-1_1.xsd
> ./java/management/client/src/main/java/wsdl/WsResource.rmd
> ./java/management/client/src/main/java/wsdl/WsResourceFactory.wsdl
> ./java/management/client/src/main/java/wsdl/XML-Namespace-1998.xsd
> ./java/management/client/src/test/java/log4j.xml
> ./java/management/client/src/test/java/org/apache/qpid/management/wsdm/web.xml
> ./java/management/console/src/main/java/org/apache/qpid/console/XMLUtil.java
> ./j

[jira] Created: (QPID-2404) The following files does not have the ASL license header

[Rajith Attapattu (JIRA)]

The following files does not have the ASL license header


 Key: QPID-2404
 URL: https://issues.apache.org/jira/browse/QPID-2404
 Project: Qpid
  Issue Type: Improvement
  Components: Licensing
Reporter: Rajith Attapattu
Priority: Blocker
 Fix For: 0.6


./cpp/examples/README.verify
./cpp/src/qpid/framing/Blob.h
./cpp/src/qpid/framing/BodyHolder.cpp
./cpp/src/qpid/framing/BodyHolder.h
./cpp/src/tests/Blob.cpp
./cpp/src/tests/cluster_python_tests
./cpp/src/tests/cluster_test_scripts/cluster_check
./cpp/src/tests/cluster_test_scripts/cluster_start
./cpp/src/tests/cluster_test_scripts/cluster_stop
./cpp/src/tests/cluster_test_scripts/config_example.sh
./cpp/src/tests/cluster_test_scripts/perftest

./java/broker/scripts/resetAlerting.sh
./java/broker/src/main/java/org/apache/qpid/server/protocol/AMQProtocolEngineFactory.java
./java/broker/src/main/java/org/apache/qpid/server/queue/SubFlushRunner.java
./java/broker/src/main/java/org/apache/qpid/server/security/access/AuthorizationManager.java
./java/broker/src/main/java/org/apache/qpid/server/txn/LocalTransaction.java
./java/client/src/test/java/org/apache/qpid/client/message/AbstractJMSMessageTest.java
./java/client/test/bin/IBM-README.txt
./java/common/src/main/java/org/apache/qpid/thread/DefaultThreadFactory.java
./java/common/src/main/java/org/apache/qpid/thread/RealtimeThreadFactory.java
./java/common/src/main/java/org/apache/qpid/thread/ThreadFactory.java
./java/common/src/main/java/org/apache/qpid/thread/Threading.java
./java/common/src/test/java/org/apache/qpid/codec/AMQDecoderTest.java
./java/common/src/test/java/org/apache/qpid/codec/MockAMQVersionAwareProtocolSession.java
./java/common/src/test/java/org/apache/qpid/thread/ThreadFactoryTest.java
./java/integrationtests/docs/RunningSustainedTests.txt
./java/management/agent/src/main/java/org/apache/qpid/agent/EventSeverity.java
./java/management/client/web.xml
./java/management/client/console/brokers_management.jsp
./java/management/client/console/console.jsp
./java/management/client/console/error_page.jsp
./java/management/client/console/jmx_perspective.jsp
./java/management/client/console/logging_configuration.jsp
./java/management/client/console/resources_management.jsp
./java/management/client/console/tbd.jsp
./java/management/client/console/wsdm_operations_perspective.jsp
./java/management/client/console/wsdm_properties_perspective.jsp
./java/management/client/console/wsdm_rmd_perspective.jsp
./java/management/client/console/wsdm_wsdl_perspective.jsp
./java/management/client/console/fragments/header.jsp
./java/management/client/console/fragments/menu.jsp
./java/management/client/console/images/style.css
./java/management/client/etc/jetty.xml
./java/management/client/etc/log4j.xml
./java/management/client/src/main/java/muse.xml
./java/management/client/src/main/java/org/apache/qpid/management/domain/model/QpidEntity.java
./java/management/client/src/main/java/org/apache/qpid/management/wsdm/muse/engine/WSDMAdapterEnvironment.java
./java/management/client/src/main/java/org/apache/qpid/management/wsdm/muse/engine/WSDMAdapterIsolationLayer.java
./java/management/client/src/main/java/router-entries/adapter/resource-instance-1.xml
./java/management/client/src/main/java/router-entries/consumer/resource-instance-1.xml
./java/management/client/src/main/java/wsdl/QManAdapter.rmd
./java/management/client/src/main/java/wsdl/QManAdapter.wsdl
./java/management/client/src/main/java/wsdl/QManWsResource.rmd
./java/management/client/src/main/java/wsdl/QManWsResource.wsdl
./java/management/client/src/main/java/wsdl/SOAP-Envelope-1_2.xsd
./java/management/client/src/main/java/wsdl/WS-Addressing-2005_08.xsd
./java/management/client/src/main/java/wsdl/WS-MetadataExchange-2004_09.xsd
./java/management/client/src/main/java/wsdl/WS-ServiceGroup-1_2.wsdl
./java/management/client/src/main/java/wsdl/WS-ServiceGroupEntry-1_2.wsdl
./java/management/client/src/main/java/wsdl/WSDM-MUWS-Part1-1_1.xsd
./java/management/client/src/main/java/wsdl/WSDM-MUWS-Part2-1_1.xsd
./java/management/client/src/main/java/wsdl/WsResource.rmd
./java/management/client/src/main/java/wsdl/WsResourceFactory.wsdl
./java/management/client/src/main/java/wsdl/XML-Namespace-1998.xsd
./java/management/client/src/test/java/log4j.xml
./java/management/client/src/test/java/org/apache/qpid/management/wsdm/web.xml
./java/management/console/src/main/java/org/apache/qpid/console/XMLUtil.java
./java/management/tools/qpid-cli/Guide.txt
./java/perftests/RunningPerformanceTests.txt
./java/perftests/bin/monitoring/monitor-broker.sh
./java/perftests/bin/monitoring/runTests.sh
./java/perftests/bin/monitoring/stop-monitored-broker.sh
./java/perftests/bin/processing/process.sh
./java/perftests/bin/processing/processAll.sh
./java/perftests/etc/scripts/extractResults.sh
./java/perftests/etc/scripts/extractThroughputResults.sh

Re: Is anyone working on C++ broker TTL ?

[Rajith Attapattu]

On Thu, Feb 11, 2010 at 4:51 PM, Kerry Bonin  wrote:
> I can understand if messages live some reasonable interval past their TTL
> expiration, especially if it is a broker configurable argument.  In our
> case, some developers wanted to set the TTL explicitly to 30 seconds, then
> saw their messages persist overnight, which meant something wasn't working
> as expected, hence my JIRA...
>
> On the subject of default settings (and those broker config settings, thanks
> for them, btw, hadn't seen that option yet) is we are experiencing quite a
> challenge with the 'state' of the documentation.  Other areas of concern
> include the JSON dictionary like arguments on queue creation.  I've seen
> docs appearing in the 'book' folder, need to look there more, but as a
> developer I wish there was a consistent place I could find accurate docs,
> and point my team to.  If this was a wiki I'd be happy to contribute myself,
> as I discover things in the code that I think should be in the docs...

Kerry I understand and share you concerns about the documentation.
Currently it's all over the wiki and most often than not out of sync
with the code.
**We are addressing this on a priority basis**.
The first step is to get the documentation living in svn alongside
code, which we have already started.
Jonathan is working on getting our existing wiki based docs ported
into doc book format.
This will go a long way in ensuring we have proper documentation for
each release.
Our goal is to release documentation along with bits and host them in
our website indexed by release version.
We hope to have this in place before the next release.

I really appreciate your desire to contribute documentation.
I would encourage you to wait bit, until Jonathan gets a chance to
port all the existing docs into documentation (which should be soon).
Then you could have a look at the docs and any updates, improvements
could be attached to the JIRA as a patch.
This process allows us to accept contributions in a legal way and also
make it more easy for folks to contribute and the developers to
incorporate them.

Rajith

> On Thu, Feb 11, 2010 at 11:59 AM, Alan Conway  wrote:
>
>> On 02/10/2010 02:54 PM, Kerry Bonin wrote:
>>
>>> I just validated a report from a few of my developers that TTL doesn't
>>> seem
>>> to be working with the 0.6 broker, is anyone working on this ?  If not I
>>> can
>>> have a look.  If it does work I'd like to compare notes to see what we're
>>> doing wrong...  Thx!
>>>
>>> (may be QPID-1418, QPID-1575 ?)
>>>
>>> This has been seen by my Python developer using 0.5 api w/ 0.6 broker, and
>>> I
>>> just saw in 0.6 trunk C++ using Messaging.  In the C++ I'm creating w/
>>> type:topic, calling qpid::messaging::Message.setTTL( TIME_SEC * 2 ), and
>>> never see the events go away.  Not sure if this is a broker issue or a
>>> messaging issue...
>>>
>>>
>> Messages are not deleted immediately when their TTL expires. There are two
>> ways TTL messages can get dropped on the broker. If a consumer is looking
>> for the next message on a queue, any stale messages at the front of the
>> queue are dropped. There is also a periodic cleanup operation that removes
>> stale messages from the queue but the default interval is 10 minutes. You
>> can set a smaller interval in seconds with the --queue-purge-interval option
>> or config file setting.
>>
>> If your main concern with TTL is ensuring stale messages don't reach
>> consumers then the default settings are fine. If your main concern is
>> limiting the size of queues in memory you probably want a smaller interval.
>> The periodic cleanup operation currently involves a linear sweep of all
>> queues with TTL messages so there may be some impact on performance during
>> the sweep if you have a lot of deep queues.
>>
>>
>



-- 
Regards,

Rajith Attapattu
Red Hat
http://rajith.2rlabs.com/

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Re: Is anyone working on C++ broker TTL ?

[Kerry Bonin]

I can understand if messages live some reasonable interval past their TTL
expiration, especially if it is a broker configurable argument.  In our
case, some developers wanted to set the TTL explicitly to 30 seconds, then
saw their messages persist overnight, which meant something wasn't working
as expected, hence my JIRA...

On the subject of default settings (and those broker config settings, thanks
for them, btw, hadn't seen that option yet) is we are experiencing quite a
challenge with the 'state' of the documentation.  Other areas of concern
include the JSON dictionary like arguments on queue creation.  I've seen
docs appearing in the 'book' folder, need to look there more, but as a
developer I wish there was a consistent place I could find accurate docs,
and point my team to.  If this was a wiki I'd be happy to contribute myself,
as I discover things in the code that I think should be in the docs...

On Thu, Feb 11, 2010 at 11:59 AM, Alan Conway  wrote:

> On 02/10/2010 02:54 PM, Kerry Bonin wrote:
>
>> I just validated a report from a few of my developers that TTL doesn't
>> seem
>> to be working with the 0.6 broker, is anyone working on this ?  If not I
>> can
>> have a look.  If it does work I'd like to compare notes to see what we're
>> doing wrong...  Thx!
>>
>> (may be QPID-1418, QPID-1575 ?)
>>
>> This has been seen by my Python developer using 0.5 api w/ 0.6 broker, and
>> I
>> just saw in 0.6 trunk C++ using Messaging.  In the C++ I'm creating w/
>> type:topic, calling qpid::messaging::Message.setTTL( TIME_SEC * 2 ), and
>> never see the events go away.  Not sure if this is a broker issue or a
>> messaging issue...
>>
>>
> Messages are not deleted immediately when their TTL expires. There are two
> ways TTL messages can get dropped on the broker. If a consumer is looking
> for the next message on a queue, any stale messages at the front of the
> queue are dropped. There is also a periodic cleanup operation that removes
> stale messages from the queue but the default interval is 10 minutes. You
> can set a smaller interval in seconds with the --queue-purge-interval option
> or config file setting.
>
> If your main concern with TTL is ensuring stale messages don't reach
> consumers then the default settings are fine. If your main concern is
> limiting the size of queues in memory you probably want a smaller interval.
> The periodic cleanup operation currently involves a linear sweep of all
> queues with TTL messages so there may be some impact on performance during
> the sweep if you have a lot of deep queues.
>
>

[jira] Updated: (QPID-2328) Querying for 500 objects causes C++ based ruby console to hang

[Ian Main (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ian Main updated QPID-2328:
---

Attachment: qmf_race_fixes_try_2.patch

This is still not fixed in trunk.  Attached is another patch that applies to 
trunk.

> Querying for 500 objects causes C++ based ruby console to hang
> --
>
> Key: QPID-2328
> URL: https://issues.apache.org/jira/browse/QPID-2328
> Project: Qpid
>  Issue Type: Bug
>  Components: Qpid Managment Framework
> Environment: Version:
> qmf-0.5.829175-3
>Reporter: Ian Main
>Assignee: Ted Ross
> Attachments: qmf_race_fixes.patch, qmf_race_fixes_try_2.patch
>
>
> Using the test framework at http://github.com/movitto/qmf/ we were able to 
> cause the console to hang and require a SIGKILL to stop it by querying for > 
> 450 or so objects.
> To reproduce:
> in project_stress/stress_agent/src run:
> ./stress_agent -n 500
> And in project_stress/ruby/bin run:
> ./console.rb -t testobject -s
> If you try rerunning the agent with fewer objects you will see what normal 
> output looks like.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Re: Vote for 0.6 Release

[Rajith Attapattu]

On Thu, Feb 11, 2010 at 11:53 AM, Carl Trieloff  wrote:
> On 02/11/2010 09:51 AM, Andrew Stitcher wrote:
>>
>> On Thu, 2010-02-04 at 10:33 +, Andrew Stitcher wrote:
>>
>>>
>>> ...
>>>
>>
>>
>>>
>>> I also propose to run the vote until Tue 9 Feb 2010. At that point I
>>> will total the votes.
>>>
>>
>> Well it's now, Thurs 11 Feb, and I've had only +2. So the vote is not
>> passed.
>>
>> I don't think this could have been released in any case as there appear
>> to be a very large number of files without the correct licensing text in
>> them. The output from the RAT tool is really too voluminous at present
>> for me to go through it file by file and figure out what's going on.
>> There must be 200-300 files highlighted there.
>>
>> At this point I'm loosing the will to carry out the release manager job.
>> So I'll take suggestions/analysis how to understand/fix the licensing
>> issue.
>>
>> I especially think it's extremely poor that we could have even accepted
>> this number of files into qpid without licenses - how are we going to
>> ensure that it doesn't remain an ongoing problem?
>>
>> RAT output:
>>
>> http://people.apache.org/~robbie/qpid/0.6/0.6rc5_rat_output.txt
>>
>>
>
>
>
> I don't believe .in & verify flies etc are an issues, and can be ignored.
> However files like

We can ignore the verify files.

>
>  ./java/client/src/test/java/org/apache/qpid/client/message/AbstractJMSMessageTest.java
>  ./java/common/src/main/java/org/apache/qpid/thread/DefaultThreadFactory.java
>  ./java/common/src/main/java/org/apache/qpid/thread/RealtimeThreadFactory.java
>  ./java/common/src/main/java/org/apache/qpid/thread/ThreadFactory.java
>  ./java/common/src/main/java/org/apache/qpid/thread/Threading.java
>  ./java/common/src/test/java/org/apache/qpid/codec/AMQDecoderTest.java
>  ./java/common/src/test/java/org/apache/qpid/codec/MockAMQVersionAwareProtocolSession.java
>  ./java/common/src/test/java/org/apache/qpid/thread/ThreadFactoryTest.java
>
I will fix the java files today.

>  ./cpp/src/qpid/framing/Blob.h
>  ./cpp/src/qpid/framing/BodyHolder.cpp
>  ./cpp/src/qpid/framing/BodyHolder.h
>  ./cpp/src/tests/Blob.cpp
>
>
> are most likely an issue...   I see about 20 or so files in the list that
> needs to be fixed.
>
>
> Can Everyone please take some time and scrup this a bit so we can get 0.6
> out.
>
> Let's try put the effort in over the next two days and get this out.
> Carl.
>
>
>
>
>
>
>
>
>
> -
> Apache Qpid - AMQP Messaging Implementation
> Project:      http://qpid.apache.org
> Use/Interact: mailto:dev-subscr...@qpid.apache.org
>
>



-- 
Regards,

Rajith Attapattu
Red Hat
http://rajith.2rlabs.com/

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Re: 0.6 Feature Matrix

[Robert Godfrey]

On 11 February 2010 20:11, Rafael Schloming  wrote:
> Robert Godfrey wrote:
>>
>> On a related note what does Priority Delivery in "Client Features" mean?
>
> This is the ability for the client to reorder messages in its prefetch queue
> based on message priority. It's not the same as server-side priority queues,
> although obviously it is a complimentary feature.

Indeed ... do any of our clients actually do this ? :-)

>
> I really just suggested this to help fill out the matrix as an example of a
> feature that is entirely client related and independent of both the protocol
> and broker.
>
> I guess automatic encode/decode of map messages would be another one in this
> category.

That would be another good one...

I guess I should go through and start adding features that are in the
Java Broker but not the C++ (server side selectors, etc...)

-- Rob

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Re: 0.6 Feature Matrix

[Rafael Schloming]

Robert Godfrey wrote:

On a related note what does Priority Delivery in "Client Features" mean?


This is the ability for the client to reorder messages in its prefetch 
queue based on message priority. It's not the same as server-side 
priority queues, although obviously it is a complimentary feature.


I really just suggested this to help fill out the matrix as an example 
of a feature that is entirely client related and independent of both the 
protocol and broker.


I guess automatic encode/decode of map messages would be another one in 
this category.


--Rafael


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Re: 0.6 Feature Matrix

[Rafael Schloming]

Robert Godfrey wrote:

On a related note what does Priority Delivery in "Client Features" mean?


This is the ability for the client to reorder messages in its prefetch 
queue based on message priority. It's not the same as server-side 
priority queues, although obviously it is a complimentary feature.


I really just suggested this to help fill out the matrix as an example 
of a feature that is entirely client related and independent of both the 
protocol and broker.


I guess automatic encode/decode of map messages would be another one in 
this category.


--Rafael


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Re: svn commit: r907123 - in /qpid/trunk/qpid: cpp/src/qpid/broker/ cpp/src/qpid/cluster/ cpp/xml/ python/commands/ specs/]

[Robert Godfrey]

On 11 February 2010 19:36, Alan Conway  wrote:
> Apologies for late reply, accident with mail filters and I missed the mail.
>
>> This commit broke the Java Build by altering the management-schema.xml
>> which is used commonly between the two brokers to generate QMF
>> classes.
>>
>> Moreover, prior to this commit there was no JIRA or discussion on the
>> list about a possible change... nor does the commit itself do much to
>> explain what the change means (although since it relates to clusters,
>> I can take a fair stab at guessing the answer to "is a connection on
>> the Java Broker a shadow connection?" is false.)
>
> Mea culpa, I simply did not think about the Java broker. This change did
> deserve more explanation in form of JIRA.
>
>> As I discussed in e-mails at the beginning of the year, I think we
>> should be aiming at keeping the broker functionality as close a
>> possible between the two brokers.  This requires all of us to discuss
>> upcoming proposed changes to things like management-schema.xml before
>> we commit them so that both communities can have there say, and we can
>> co-ordinate changes so neither community breaks the other's build.
>
> Agreed. Oversight on my part.
>
>> it is designed around the limitations of the C++ broker wrt Virtual
>> Hosts (there can be only one) and transports/ports (similarly
>> restricted).  However, while I would like to rectify this before our
>> next release... I will be raising a JIRA and expect to discuss the
>> impact and co-ordinate timing through the list... That is unless
>> people would rather I just commit the change... and let the C++ guys
>> work out how to fix their build after I break it ;-)
>>
>> BTW thanks to Rajith for putting in an emergency fix to the Java
>> codebase to make it compile again...
>>
>
> If its still a serious problem for the Java builds then we can revert my
> commit - let me know.

No problem - Rajith's commit stopped the build from failing though
querying the connection object via QMF on the Java Broker may make the
QMF client unwell right now :-)

> Lets discuss the right approach on:
> https://issues.apache.org/jira/browse/QPID-2403
>
> I'm on vacation from tomorrow for a week so feel free to revert my commit if
> that's necessary and I haven't done so before I go.
>

No need to revert... the change was a relatively minor one :-) I'm
(notionally) fine with having the attribute there and just having the
Java Broker always report false... It does seem to me though more of a
generic issue with managing a broker which is part of a cluster...
objects which are present in the logical "clustered" broker, but
aren't actually resident on the broker you are querying...

BTW I'm also out next week..

-- Rob

>>
>> -- Forwarded message --
>> From:  
>> Date: 6 February 2010 00:02
>> Subject: svn commit: r907123 - in /qpid/trunk/qpid:
>> cpp/src/qpid/broker/ cpp/src/qpid/cluster/ cpp/xml/ python/commands/
>> specs/
>> To: comm...@qpid.apache.org
>>
>>
>> Author: aconway
>> Date: Fri Feb  5 23:02:45 2010
>> New Revision: 907123
>>
>> URL: http://svn.apache.org/viewvc?rev=907123&view=rev
>> Log:
>> Consistent connection names across a cluster.
>>
>> - use the same host:port for connections and their shadows.
>> - add shadow property to managment connection to identify shadows.
>> - updated qpid-stat and qpid-cluster to filter on shadow property.
>>
>> Modified:
>>   qpid/trunk/qpid/cpp/src/qpid/broker/Connection.cpp
>>   qpid/trunk/qpid/cpp/src/qpid/broker/Connection.h
>>   qpid/trunk/qpid/cpp/src/qpid/cluster/Cluster.cpp
>>   qpid/trunk/qpid/cpp/src/qpid/cluster/Connection.cpp
>>   qpid/trunk/qpid/cpp/src/qpid/cluster/Connection.h
>>   qpid/trunk/qpid/cpp/src/qpid/cluster/UpdateClient.cpp
>>   qpid/trunk/qpid/cpp/src/qpid/cluster/UpdateReceiver.h
>>   qpid/trunk/qpid/cpp/xml/cluster.xml
>>   qpid/trunk/qpid/python/commands/qpid-cluster
>>   qpid/trunk/qpid/python/commands/qpid-stat
>>   qpid/trunk/qpid/specs/management-schema.xml
>>
>> Modified: qpid/trunk/qpid/cpp/src/qpid/broker/Connection.cpp
>> URL:
>> http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/broker/Connection.cpp?rev=907123&r1=907122&r2=907123&view=diff
>>
>> ==
>> --- qpid/trunk/qpid/cpp/src/qpid/broker/Connection.cpp (original)
>> +++ qpid/trunk/qpid/cpp/src/qpid/broker/Connection.cpp Fri Feb  5 23:02:45
>> 2010
>> @@ -72,7 +72,7 @@
>>    }
>>  };
>>
>> -Connection::Connection(ConnectionOutputHandler* out_, Broker&
>> broker_, const std::string& mgmtId_, unsigned int ssf, bool isLink_,
>> uint64_t objectId) :
>> +Connection::Connection(ConnectionOutputHandler* out_, Broker&
>> broker_, const std::string& mgmtId_, unsigned int ssf, bool isLink_,
>> uint64_t objectId, bool shadow_) :
>>    ConnectionState(out_, broker_),
>>    ssf(ssf),
>>    adapter(*this, isLink_),
>> @@ -84,7 +84,7 @@
>>    agent(0),
>>    timer(broker_.getTimer()),
>>    errorListener(0),
>> -    s

Re: svn commit: r907123 - in /qpid/trunk/qpid: cpp/src/qpid/broker/ cpp/src/qpid/cluster/ cpp/xml/ python/commands/ specs/]

[Alan Conway]

Apologies for late reply, accident with mail filters and I missed the mail.


This commit broke the Java Build by altering the management-schema.xml
which is used commonly between the two brokers to generate QMF
classes.

Moreover, prior to this commit there was no JIRA or discussion on the
list about a possible change... nor does the commit itself do much to
explain what the change means (although since it relates to clusters,
I can take a fair stab at guessing the answer to "is a connection on
the Java Broker a shadow connection?" is false.)


Mea culpa, I simply did not think about the Java broker. This change did deserve 
more explanation in form of JIRA.



As I discussed in e-mails at the beginning of the year, I think we
should be aiming at keeping the broker functionality as close a
possible between the two brokers.  This requires all of us to discuss
upcoming proposed changes to things like management-schema.xml before
we commit them so that both communities can have there say, and we can
co-ordinate changes so neither community breaks the other's build.


Agreed. Oversight on my part.


it is designed around the limitations of the C++ broker wrt Virtual
Hosts (there can be only one) and transports/ports (similarly
restricted).  However, while I would like to rectify this before our
next release... I will be raising a JIRA and expect to discuss the
impact and co-ordinate timing through the list... That is unless
people would rather I just commit the change... and let the C++ guys
work out how to fix their build after I break it ;-)

BTW thanks to Rajith for putting in an emergency fix to the Java
codebase to make it compile again...



If its still a serious problem for the Java builds then we can revert my commit 
- let me know.

Lets discuss the right approach on: 
https://issues.apache.org/jira/browse/QPID-2403

I'm on vacation from tomorrow for a week so feel free to revert my commit if 
that's necessary and I haven't done so before I go.




-- Rob

-- Forwarded message --
From:  
Date: 6 February 2010 00:02
Subject: svn commit: r907123 - in /qpid/trunk/qpid:
cpp/src/qpid/broker/ cpp/src/qpid/cluster/ cpp/xml/ python/commands/
specs/
To: comm...@qpid.apache.org


Author: aconway
Date: Fri Feb  5 23:02:45 2010
New Revision: 907123

URL: http://svn.apache.org/viewvc?rev=907123&view=rev
Log:
Consistent connection names across a cluster.

- use the same host:port for connections and their shadows.
- add shadow property to managment connection to identify shadows.
- updated qpid-stat and qpid-cluster to filter on shadow property.

Modified:
   qpid/trunk/qpid/cpp/src/qpid/broker/Connection.cpp
   qpid/trunk/qpid/cpp/src/qpid/broker/Connection.h
   qpid/trunk/qpid/cpp/src/qpid/cluster/Cluster.cpp
   qpid/trunk/qpid/cpp/src/qpid/cluster/Connection.cpp
   qpid/trunk/qpid/cpp/src/qpid/cluster/Connection.h
   qpid/trunk/qpid/cpp/src/qpid/cluster/UpdateClient.cpp
   qpid/trunk/qpid/cpp/src/qpid/cluster/UpdateReceiver.h
   qpid/trunk/qpid/cpp/xml/cluster.xml
   qpid/trunk/qpid/python/commands/qpid-cluster
   qpid/trunk/qpid/python/commands/qpid-stat
   qpid/trunk/qpid/specs/management-schema.xml

Modified: qpid/trunk/qpid/cpp/src/qpid/broker/Connection.cpp
URL: 
http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/broker/Connection.cpp?rev=907123&r1=907122&r2=907123&view=diff
==
--- qpid/trunk/qpid/cpp/src/qpid/broker/Connection.cpp (original)
+++ qpid/trunk/qpid/cpp/src/qpid/broker/Connection.cpp Fri Feb  5 23:02:45 2010
@@ -72,7 +72,7 @@
}
 };

-Connection::Connection(ConnectionOutputHandler* out_, Broker&
broker_, const std::string& mgmtId_, unsigned int ssf, bool isLink_,
uint64_t objectId) :
+Connection::Connection(ConnectionOutputHandler* out_, Broker&
broker_, const std::string& mgmtId_, unsigned int ssf, bool isLink_,
uint64_t objectId, bool shadow_) :
ConnectionState(out_, broker_),
ssf(ssf),
adapter(*this, isLink_),
@@ -84,7 +84,7 @@
agent(0),
timer(broker_.getTimer()),
errorListener(0),
-shadow(false)
+shadow(shadow_)
 {
Manageable* parent = broker.GetVhostObject();

@@ -95,10 +95,10 @@
{
agent = broker_.getManagementAgent();

-
// TODO set last bool true if system connection
if (agent != 0) {
mgmtObject = new _qmf::Connection(agent, this, parent,
mgmtId, !isLink, false);
+mgmtObject->set_shadow(shadow);
agent->addObject(mgmtObject, objectId, true);
}
ConnectionState::setUrl(mgmtId);

Modified: qpid/trunk/qpid/cpp/src/qpid/broker/Connection.h
URL: 
http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/broker/Connection.h?rev=907123&r1=907122&r2=907123&view=diff
==
--- qpid/trunk/qpid/cpp/src/qpid/broker/Connection.h (original)
+++ qpid/trunk/qpid/cpp/src/qpid/broker/Connection.h Fri Feb  5 23:02:45 20

[jira] Created: (QPID-2403) Consistent management names for connections in a cluster.

[Alan Conway (JIRA)]

Consistent management names for connections in a cluster.
-

 Key: QPID-2403
 URL: https://issues.apache.org/jira/browse/QPID-2403
 Project: Qpid
  Issue Type: Bug
  Components: C++ Broker, C++ Clustering, Qpid Managment Framework
Affects Versions: 0.6
Reporter: Alan Conway
Assignee: Alan Conway


Management objects representing connections in a broker are named for the 
remote end of the socket ip:port. In a cluster, a broker has normal connections 
and "shadow" connections representing a connection on another broker. The 
shadow connections are named "[shadow]ip:port" Management tools use this 
convention to ignore shadow connections and display only the local connections 
to a broker.

This is inconsistent with other management objects which are named identically 
in all brokers, and the problem is compounded because connections are 
containers for other objects (sessions, consumers) so inconsistency in the 
connection name makes the names of all the children inconsistent.

Commit r907123 fixed this by making the connection names consistent and adding 
a "shadow" property to the qmf Connection object. However this broke the Java 
builds. This JIRA is to discuss what the correct solution should be that works 
for both brokers.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Re: Is anyone working on C++ broker TTL ?

[Alan Conway]

On 02/10/2010 02:54 PM, Kerry Bonin wrote:

I just validated a report from a few of my developers that TTL doesn't seem
to be working with the 0.6 broker, is anyone working on this ?  If not I can
have a look.  If it does work I'd like to compare notes to see what we're
doing wrong...  Thx!

(may be QPID-1418, QPID-1575 ?)

This has been seen by my Python developer using 0.5 api w/ 0.6 broker, and I
just saw in 0.6 trunk C++ using Messaging.  In the C++ I'm creating w/
type:topic, calling qpid::messaging::Message.setTTL( TIME_SEC * 2 ), and
never see the events go away.  Not sure if this is a broker issue or a
messaging issue...



Messages are not deleted immediately when their TTL expires. There are two ways 
TTL messages can get dropped on the broker. If a consumer is looking for the 
next message on a queue, any stale messages at the front of the queue are 
dropped. There is also a periodic cleanup operation that removes stale messages 
from the queue but the default interval is 10 minutes. You can set a smaller 
interval in seconds with the --queue-purge-interval option or config file setting.


If your main concern with TTL is ensuring stale messages don't reach consumers 
then the default settings are fine. If your main concern is limiting the size of 
queues in memory you probably want a smaller interval. The periodic cleanup 
operation currently involves a linear sweep of all queues with TTL messages so 
there may be some impact on performance during the sweep if you have a lot of 
deep queues.



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Re: Is anyone working on C++ broker TTL ?

[Kerry Bonin]

(sorry for the double post there, had a gmail UI problem...)

On Thu, Feb 11, 2010 at 11:11 AM, Andrew Stitcher wrote:

> On Thu, 2010-02-11 at 11:26 -0500, Steve Huston wrote:
> > I'm not Gordon or Rafi, but I thought we were trying to keep boost out
> > of the API as well.
>
> Absolutely, sorry not to mention it!
>
> Ideally the client API should export no other classes/interfaces at all.
>
> Essentially the reasoning here is:
>
> 1. "Accidentally" exporting other interfaces from your header files can
> lead to symbol conflict and confusion.
> 2. Leaking eg. boost leaks an API which has no stability guarantee.
> 3. Requiring the use of boost limits the client programmer.
> 4. The more we include in the API that isn't truly necessary the harder
> it gets to maintain the API.
> 5. Equally if we leak internal classes into the API then we have to be
> careful to change their interfaces as someone external may be relying on
> them.
>
> etc. etc.
>
> Andrew
>
>
>
> -
> Apache Qpid - AMQP Messaging Implementation
> Project:  http://qpid.apache.org
> Use/Interact: mailto:dev-subscr...@qpid.apache.org
>
>

RE: Is anyone working on C++ broker TTL ?

[Andrew Stitcher]

On Thu, 2010-02-11 at 11:26 -0500, Steve Huston wrote:
> I'm not Gordon or Rafi, but I thought we were trying to keep boost out
> of the API as well. 

Absolutely, sorry not to mention it!

Ideally the client API should export no other classes/interfaces at all.

Essentially the reasoning here is:

1. "Accidentally" exporting other interfaces from your header files can
lead to symbol conflict and confusion.
2. Leaking eg. boost leaks an API which has no stability guarantee.
3. Requiring the use of boost limits the client programmer.
4. The more we include in the API that isn't truly necessary the harder
it gets to maintain the API.
5. Equally if we leak internal classes into the API then we have to be
careful to change their interfaces as someone external may be relying on
them.

etc. etc.

Andrew



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Re: qmfengine on windows.

[Timothy St. Clair]

Duly noted. 

Is there a wiki which outlines practices/standards in case we run across
anything else?

Cheers,
Tim

On Thu, 2010-02-11 at 10:02 -0500, Andrew Stitcher wrote:
> On Wed, 2010-02-10 at 13:49 -0600, Timothy St. Clair wrote:
> > Ken - 
> > 
> > Attached is a patch I used to fix a qmfengine build issue I was having
> > on windows.  Probably want to validate it.
> > 
> > patch -p2 -i 
> 
> Two points:
> 
> 1. [procedural] This patch needs to be attached to an upstream qpid 
> Jira for it to be considered by all the relevant qpid devs.
> 
> 2. Please don't do it this way. We have absolutely avoided using #ifdef
> when not essential. And I think you'll find that they are very rarely
> essential. The way we do this in the qpid C++ code is to have entirely
> separate Unix and Win32 implementations in different files and only link
> one of the files for a given platform.
> 
> Whatever you think of this strategy, and it has some downsides, that is
> the way we do it.
> 
> Offending part of the patch below.
> 
> [Sent to qpid dev list, to make this last point there]
> 
> Andrew
> 
> 
> --- a/qpid-cpp-mrg-0.7.904602/cpp/src/qmf/engine/ResilientConnection.cpp
> +++ b/qpid-cpp-mrg-0.7.904602/cpp/src/qmf/engine/ResilientConnection.cpp
> @@ -39,8 +39,15 @@
>  #include 
>  #include 
>  #include 
> -#include 
>  #include 
> +#ifndef WIN32
> +   #include 
> +#else 
> +   #include 
> +   #include 
> +   #define write _write
> +#endif
> +
>  
>  using namespace std;
>  using namespace qmf::engine;
> @@ -333,8 +340,13 @@ void ResilientConnectionImpl::setNotifyFd(int fd)
>  {
>  notifyFd = fd;
>  if (notifyFd > 0) {
> +#ifndef WIN32
>  int original = fcntl(notifyFd, F_GETFL);
>  fcntl(notifyFd, F_SETFL, O_NONBLOCK | original);
> +#else
> +   u_long iMode=1;
> +   ioctlsocket(notifyFd, FIONBIO, &iMode);
> +#endif
>  }
>  }
>  
> 
> 


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Re: Vote for 0.6 Release

[Carl Trieloff]

On 02/11/2010 09:51 AM, Andrew Stitcher wrote:

On Thu, 2010-02-04 at 10:33 +, Andrew Stitcher wrote:
   

...
 
   

I also propose to run the vote until Tue 9 Feb 2010. At that point I
will total the votes.
 

Well it's now, Thurs 11 Feb, and I've had only +2. So the vote is not
passed.

I don't think this could have been released in any case as there appear
to be a very large number of files without the correct licensing text in
them. The output from the RAT tool is really too voluminous at present
for me to go through it file by file and figure out what's going on.
There must be 200-300 files highlighted there.

At this point I'm loosing the will to carry out the release manager job.
So I'll take suggestions/analysis how to understand/fix the licensing
issue.

I especially think it's extremely poor that we could have even accepted
this number of files into qpid without licenses - how are we going to
ensure that it doesn't remain an ongoing problem?

RAT output:

http://people.apache.org/~robbie/qpid/0.6/0.6rc5_rat_output.txt

   




I don't believe .in & verify flies etc are an issues, and can be 
ignored. However files like


 
./java/client/src/test/java/org/apache/qpid/client/message/AbstractJMSMessageTest.java
  ./java/common/src/main/java/org/apache/qpid/thread/DefaultThreadFactory.java
  ./java/common/src/main/java/org/apache/qpid/thread/RealtimeThreadFactory.java
  ./java/common/src/main/java/org/apache/qpid/thread/ThreadFactory.java
  ./java/common/src/main/java/org/apache/qpid/thread/Threading.java
  ./java/common/src/test/java/org/apache/qpid/codec/AMQDecoderTest.java
  
./java/common/src/test/java/org/apache/qpid/codec/MockAMQVersionAwareProtocolSession.java
  ./java/common/src/test/java/org/apache/qpid/thread/ThreadFactoryTest.java


  ./cpp/src/qpid/framing/Blob.h
  ./cpp/src/qpid/framing/BodyHolder.cpp
  ./cpp/src/qpid/framing/BodyHolder.h
  ./cpp/src/tests/Blob.cpp


are most likely an issue...   I see about 20 or so files in the list 
that needs to be fixed.



Can Everyone please take some time and scrup this a bit so we can get 
0.6 out.


Let's try put the effort in over the next two days and get this out.
Carl.









-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Re: Is anyone working on C++ broker TTL ?

[Kerry Bonin]

Created QPID-2402 to capture the API ambiguity and behavior, called a "bug"
as I can use the API in the way it appears to be appropriate, and see "A
problem which impairs or prevents the functions of the product."

On Thu, Feb 11, 2010 at 10:26 AM, Steve Huston  wrote:

> I'm not Gordon or Rafi, but I thought we were trying to keep boost out
> of the API as well.
>
> I do agree that qpid::sys::Duration should not be exposed; something
> like qpid::messaging::Duration (which may just be a typedef for
> uint64_t) would be better.
>
> -Steve
>
> > -Original Message-
> > From: Andrew Stitcher [mailto:astitc...@redhat.com]
> > Sent: Thursday, February 11, 2010 9:44 AM
> > To: dev@qpid.apache.org
> > Cc: Gordon Sim; Rafael Schloming
> > Subject: Re: Is anyone working on C++ broker TTL ?
> >
> >
> > On Wed, 2010-02-10 at 16:51 -0600, Kerry Bonin wrote:
> > > OK...  (for the C++ code)
> > >
> > > qpid::messaging.Message::setTTL( boost::uint64_t ttl );
> > > I was using this with a qpid::sys::Duration() object, which stores
> > > time in a boost::posix_time::ptime object. This is
> > documented to store
> > > in units of nanoseconds.
> >
> > The Duration object (as several others) is meant to be
> > entirely internal to the qpid code and not to "leak" to the
> > client API. At least we should have explicitly decided it was
> > part of the API if we want it there.
> >
> > It may look convenient, but it's really not been designed to
> > be useful for any more than the internals of qpid.
> >
> > >
> > > According to /cpp/src/qpid/broker/Message # 351-2, TTL is
> > supposed to
> > > be set in milliseconds.  When I manually send ms, it works fine.
> > >
> > > I would recommend:
> > > - document Message.setTTL units clearly - pick ms or ns
> > >   - if ms, then overload setTTL to take a Duration object so we can
> > > use without error by converting in setTTL
> >
> > If we decided to keep the qpid time objects in the client API
> > then we need to recast all times in the API to take (only)
> > the qpid Duration and AbsTime types.
> >
> > >   - if ns, then somewhere downstream (OutgoingMessage#351 ?) the ns
> > > needs to get converted to ms
> >
> > This does raise  the interesting issue of specifying time in
> > the client API and doing it consistently - Gordon/Rafi do you
> > have any thoughts WRT the new API?
> >
> > Andrew
> >
> >
> >
> > -
> > Apache Qpid - AMQP Messaging Implementation
> > Project:  http://qpid.apache.org
> > Use/Interact: mailto:dev-subscr...@qpid.apache.org
> >
> >
>
>
> -
> Apache Qpid - AMQP Messaging Implementation
> Project:  http://qpid.apache.org
> Use/Interact: mailto:dev-subscr...@qpid.apache.org
>
>

Re: Is anyone working on C++ broker TTL ?

[Kerry Bonin]

Created QPID-2402 to capture the API ambiguity and behavior, called a "bug"
as I can use the API in the way it appears to be appropriate, and see "A
problem which impairs or prevents the functions of the product."

On Thu, Feb 11, 2010 at 10:26 AM, Steve Huston  wrote:

> I'm not Gordon or Rafi, but I thought we were trying to keep boost out
> of the API as well.
>
> I do agree that qpid::sys::Duration should not be exposed; something
> like qpid::messaging::Duration (which may just be a typedef for
> uint64_t) would be better.
>
> -Steve
>
> > -Original Message-
> > From: Andrew Stitcher [mailto:astitc...@redhat.com]
> > Sent: Thursday, February 11, 2010 9:44 AM
> > To: dev@qpid.apache.org
> > Cc: Gordon Sim; Rafael Schloming
> > Subject: Re: Is anyone working on C++ broker TTL ?
> >
> >
> > On Wed, 2010-02-10 at 16:51 -0600, Kerry Bonin wrote:
> > > OK...  (for the C++ code)
> > >
> > > qpid::messaging.Message::setTTL( boost::uint64_t ttl );
> > > I was using this with a qpid::sys::Duration() object, which stores
> > > time in a boost::posix_time::ptime object. This is
> > documented to store
> > > in units of nanoseconds.
> >
> > The Duration object (as several others) is meant to be
> > entirely internal to the qpid code and not to "leak" to the
> > client API. At least we should have explicitly decided it was
> > part of the API if we want it there.
> >
> > It may look convenient, but it's really not been designed to
> > be useful for any more than the internals of qpid.
> >
> > >
> > > According to /cpp/src/qpid/broker/Message # 351-2, TTL is
> > supposed to
> > > be set in milliseconds.  When I manually send ms, it works fine.
> > >
> > > I would recommend:
> > > - document Message.setTTL units clearly - pick ms or ns
> > >   - if ms, then overload setTTL to take a Duration object so we can
> > > use without error by converting in setTTL
> >
> > If we decided to keep the qpid time objects in the client API
> > then we need to recast all times in the API to take (only)
> > the qpid Duration and AbsTime types.
> >
> > >   - if ns, then somewhere downstream (OutgoingMessage#351 ?) the ns
> > > needs to get converted to ms
> >
> > This does raise  the interesting issue of specifying time in
> > the client API and doing it consistently - Gordon/Rafi do you
> > have any thoughts WRT the new API?
> >
> > Andrew
> >
> >
> >
> > -
> > Apache Qpid - AMQP Messaging Implementation
> > Project:  http://qpid.apache.org
> > Use/Interact: mailto:dev-subscr...@qpid.apache.org
> >
> >
>
>
> -
> Apache Qpid - AMQP Messaging Implementation
> Project:  http://qpid.apache.org
> Use/Interact: mailto:dev-subscr...@qpid.apache.org
>
>

[jira] Created: (QPID-2402) qpid::messaging.Message::setTTL() unit ambiguity can cause unexpectected behavior

[Kerry Bonin (JIRA)]

qpid::messaging.Message::setTTL() unit ambiguity can cause unexpectected 
behavior
-

 Key: QPID-2402
 URL: https://issues.apache.org/jira/browse/QPID-2402
 Project: Qpid
  Issue Type: Bug
  Components: C++ Broker, C++ Client
Reporter: Kerry Bonin


qpid::messaging.Message::setTTL( boost::uint64_t ttl ) - does not declare its 
units.

The currently exposed time types are AbsTime and Duration, which seems to imply 
they should be used for encapsulating time.

When a Duration object is passed to setTTL, the inline operator int64_t() 
returns the member variable nanoseconds.

When this value is propagated to the broker, it is interpreted around  
/cpp/src/qpid/broker/Message # 353 to be in millisecond units.

I would recommend:
- document Message.setTTL units clearly - pick ms or ns
  - if ms, then overload setTTL to take a Duration object so we can use without 
error by converting in setTTL
  - if ns, then somewhere downstream (OutgoingMessage#351 ?) the ns needs to 
get converted to ms



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

RE: Is anyone working on C++ broker TTL ?

[Steve Huston]

I'm not Gordon or Rafi, but I thought we were trying to keep boost out
of the API as well. 

I do agree that qpid::sys::Duration should not be exposed; something
like qpid::messaging::Duration (which may just be a typedef for
uint64_t) would be better.

-Steve

> -Original Message-
> From: Andrew Stitcher [mailto:astitc...@redhat.com] 
> Sent: Thursday, February 11, 2010 9:44 AM
> To: dev@qpid.apache.org
> Cc: Gordon Sim; Rafael Schloming
> Subject: Re: Is anyone working on C++ broker TTL ?
> 
> 
> On Wed, 2010-02-10 at 16:51 -0600, Kerry Bonin wrote:
> > OK...  (for the C++ code)
> > 
> > qpid::messaging.Message::setTTL( boost::uint64_t ttl );
> > I was using this with a qpid::sys::Duration() object, which stores 
> > time in a boost::posix_time::ptime object. This is 
> documented to store 
> > in units of nanoseconds.
> 
> The Duration object (as several others) is meant to be 
> entirely internal to the qpid code and not to "leak" to the 
> client API. At least we should have explicitly decided it was 
> part of the API if we want it there.
> 
> It may look convenient, but it's really not been designed to 
> be useful for any more than the internals of qpid.
> 
> > 
> > According to /cpp/src/qpid/broker/Message # 351-2, TTL is 
> supposed to 
> > be set in milliseconds.  When I manually send ms, it works fine.
> > 
> > I would recommend:
> > - document Message.setTTL units clearly - pick ms or ns
> >   - if ms, then overload setTTL to take a Duration object so we can 
> > use without error by converting in setTTL
> 
> If we decided to keep the qpid time objects in the client API 
> then we need to recast all times in the API to take (only) 
> the qpid Duration and AbsTime types.
> 
> >   - if ns, then somewhere downstream (OutgoingMessage#351 ?) the ns 
> > needs to get converted to ms
> 
> This does raise  the interesting issue of specifying time in 
> the client API and doing it consistently - Gordon/Rafi do you 
> have any thoughts WRT the new API?
> 
> Andrew
> 
> 
> 
> -
> Apache Qpid - AMQP Messaging Implementation
> Project:  http://qpid.apache.org
> Use/Interact: mailto:dev-subscr...@qpid.apache.org
> 
> 


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Commented: (QPID-2401) c++ qmfengine fails to build on windows

[Steve Huston (JIRA)]

[ 
https://issues.apache.org/jira/browse/QPID-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832540#action_12832540
 ] 

Steve Huston commented on QPID-2401:


I did apply the CmakeLists.txt patch from tim-qmfengine.patch to add missing 
files to the build. Thanks.

> c++ qmfengine fails to build on windows
> ---
>
> Key: QPID-2401
> URL: https://issues.apache.org/jira/browse/QPID-2401
> Project: Qpid
>  Issue Type: Bug
>  Components: Qpid Managment Framework
> Environment: Windows build
>Reporter: Ken Giusti
> Attachments: tim-qmfengine.patch
>
>
> Bug reported by Timothy St. Clair - he was unable to build qmf engine under 
> windows.   Proposed patch from Tim attached for review.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Closed: (QPID-2401) c++ qmfengine fails to build on windows

[Steve Huston (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Huston closed QPID-2401.
--

Resolution: Duplicate

This issue is a duplicate of QPID-1982 where ways to address it are being 
discussed.

As Andrew mentioned on the dev list, the platform-specific change to get 
write() isn't a good way to go about this. Please read QPID-1982 and join in 
the conversation there.

> c++ qmfengine fails to build on windows
> ---
>
> Key: QPID-2401
> URL: https://issues.apache.org/jira/browse/QPID-2401
> Project: Qpid
>  Issue Type: Bug
>  Components: Qpid Managment Framework
> Environment: Windows build
>Reporter: Ken Giusti
> Attachments: tim-qmfengine.patch
>
>
> Bug reported by Timothy St. Clair - he was unable to build qmf engine under 
> windows.   Proposed patch from Tim attached for review.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Re: qmfengine on windows.

[Ken Giusti]

Thanks Andrew - points noted.

I created a Jira on behalf of Tim containing his patch.  

https://issues.apache.org/jira/browse/QPID-2401

As noted, I didn't grant license for inclusion, as I did not originate the 
patch, and it cannot be included as is.

I don't have immediate access to a windows build env, so I cannot investigate 
the issue right now.


-K

- "Andrew Stitcher"  wrote:

> On Wed, 2010-02-10 at 13:49 -0600, Timothy St. Clair wrote:
> > Ken - 
> > 
> > Attached is a patch I used to fix a qmfengine build issue I was
> having
> > on windows.  Probably want to validate it.
> > 
> > patch -p2 -i 
> 
> Two points:
> 
> 1. [procedural] This patch needs to be attached to an upstream qpid 
> Jira for it to be considered by all the relevant qpid devs.
> 
> 2. Please don't do it this way. We have absolutely avoided using
> #ifdef
> when not essential. And I think you'll find that they are very rarely
> essential. The way we do this in the qpid C++ code is to have
> entirely
> separate Unix and Win32 implementations in different files and only
> link
> one of the files for a given platform.
> 
> Whatever you think of this strategy, and it has some downsides, that
> is
> the way we do it.
> 
> Offending part of the patch below.
> 
> [Sent to qpid dev list, to make this last point there]
> 
> Andrew
> 
> 
> ---
> a/qpid-cpp-mrg-0.7.904602/cpp/src/qmf/engine/ResilientConnection.cpp
> +++
> b/qpid-cpp-mrg-0.7.904602/cpp/src/qmf/engine/ResilientConnection.cpp
> @@ -39,8 +39,15 @@
>  #include 
>  #include 
>  #include 
> -#include 
>  #include 
> +#ifndef WIN32
> +   #include 
> +#else 
> +   #include 
> +   #include 
> +   #define write _write
> +#endif
> +
>  
>  using namespace std;
>  using namespace qmf::engine;
> @@ -333,8 +340,13 @@ void ResilientConnectionImpl::setNotifyFd(int
> fd)
>  {
>  notifyFd = fd;
>  if (notifyFd > 0) {
> +#ifndef WIN32
>  int original = fcntl(notifyFd, F_GETFL);
>  fcntl(notifyFd, F_SETFL, O_NONBLOCK | original);
> +#else
> +   u_long iMode=1;
> +   ioctlsocket(notifyFd, FIONBIO, &iMode);
> +#endif
>  }
>  }
>  
> 
> 
> 
> -
> Apache Qpid - AMQP Messaging Implementation
> Project:  http://qpid.apache.org
> Use/Interact: mailto:dev-subscr...@qpid.apache.org

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Updated: (QPID-2401) c++ qmfengine fails to build on windows

[Ken Giusti (JIRA)]

 [ 
https://issues.apache.org/jira/browse/QPID-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ken Giusti updated QPID-2401:
-

Attachment: tim-qmfengine.patch

Patch from Tim that fixed his compilation problem.

> c++ qmfengine fails to build on windows
> ---
>
> Key: QPID-2401
> URL: https://issues.apache.org/jira/browse/QPID-2401
> Project: Qpid
>  Issue Type: Bug
>  Components: Qpid Managment Framework
> Environment: Windows build
>Reporter: Ken Giusti
> Attachments: tim-qmfengine.patch
>
>
> Bug reported by Timothy St. Clair - he was unable to build qmf engine under 
> windows.   Proposed patch from Tim attached for review.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Created: (QPID-2401) c++ qmfengine fails to build on windows

[Ken Giusti (JIRA)]

c++ qmfengine fails to build on windows
---

 Key: QPID-2401
 URL: https://issues.apache.org/jira/browse/QPID-2401
 Project: Qpid
  Issue Type: Bug
  Components: Qpid Managment Framework
 Environment: Windows build
Reporter: Ken Giusti


Bug reported by Timothy St. Clair - he was unable to build qmf engine under 
windows.   Proposed patch from Tim attached for review.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Re: qmfengine on windows.

[Andrew Stitcher]

On Wed, 2010-02-10 at 13:49 -0600, Timothy St. Clair wrote:
> Ken - 
> 
> Attached is a patch I used to fix a qmfengine build issue I was having
> on windows.  Probably want to validate it.
> 
> patch -p2 -i 

Two points:

1. [procedural] This patch needs to be attached to an upstream qpid 
Jira for it to be considered by all the relevant qpid devs.

2. Please don't do it this way. We have absolutely avoided using #ifdef
when not essential. And I think you'll find that they are very rarely
essential. The way we do this in the qpid C++ code is to have entirely
separate Unix and Win32 implementations in different files and only link
one of the files for a given platform.

Whatever you think of this strategy, and it has some downsides, that is
the way we do it.

Offending part of the patch below.

[Sent to qpid dev list, to make this last point there]

Andrew


--- a/qpid-cpp-mrg-0.7.904602/cpp/src/qmf/engine/ResilientConnection.cpp
+++ b/qpid-cpp-mrg-0.7.904602/cpp/src/qmf/engine/ResilientConnection.cpp
@@ -39,8 +39,15 @@
 #include 
 #include 
 #include 
-#include 
 #include 
+#ifndef WIN32
+   #include 
+#else 
+   #include 
+   #include 
+   #define write _write
+#endif
+
 
 using namespace std;
 using namespace qmf::engine;
@@ -333,8 +340,13 @@ void ResilientConnectionImpl::setNotifyFd(int fd)
 {
 notifyFd = fd;
 if (notifyFd > 0) {
+#ifndef WIN32
 int original = fcntl(notifyFd, F_GETFL);
 fcntl(notifyFd, F_SETFL, O_NONBLOCK | original);
+#else
+   u_long iMode=1;
+   ioctlsocket(notifyFd, FIONBIO, &iMode);
+#endif
 }
 }
 



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Re: Vote for 0.6 Release

[Andrew Stitcher]

On Thu, 2010-02-04 at 10:33 +, Andrew Stitcher wrote:
> ...

> I also propose to run the vote until Tue 9 Feb 2010. At that point I
> will total the votes.

Well it's now, Thurs 11 Feb, and I've had only +2. So the vote is not
passed.

I don't think this could have been released in any case as there appear
to be a very large number of files without the correct licensing text in
them. The output from the RAT tool is really too voluminous at present
for me to go through it file by file and figure out what's going on.
There must be 200-300 files highlighted there.

At this point I'm loosing the will to carry out the release manager job.
So I'll take suggestions/analysis how to understand/fix the licensing
issue.

I especially think it's extremely poor that we could have even accepted
this number of files into qpid without licenses - how are we going to
ensure that it doesn't remain an ongoing problem?

RAT output:

http://people.apache.org/~robbie/qpid/0.6/0.6rc5_rat_output.txt


Andrew



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Re: Is anyone working on C++ broker TTL ?

[Andrew Stitcher]

On Wed, 2010-02-10 at 16:51 -0600, Kerry Bonin wrote:
> OK...  (for the C++ code)
> 
> qpid::messaging.Message::setTTL( boost::uint64_t ttl );
> I was using this with a qpid::sys::Duration() object, which stores time in a
> boost::posix_time::ptime object.
> This is documented to store in units of nanoseconds.

The Duration object (as several others) is meant to be entirely internal
to the qpid code and not to "leak" to the client API. At least we should
have explicitly decided it was part of the API if we want it there.

It may look convenient, but it's really not been designed to be useful
for any more than the internals of qpid.

> 
> According to /cpp/src/qpid/broker/Message # 351-2, TTL is supposed to be set
> in milliseconds.  When I manually send ms, it works fine.
> 
> I would recommend:
> - document Message.setTTL units clearly - pick ms or ns
>   - if ms, then overload setTTL to take a Duration object so we can use
> without error by converting in setTTL

If we decided to keep the qpid time objects in the client API then we
need to recast all times in the API to take (only) the qpid Duration and
AbsTime types.

>   - if ns, then somewhere downstream (OutgoingMessage#351 ?) the ns needs to
> get converted to ms

This does raise  the interesting issue of specifying time in the client
API and doing it consistently - Gordon/Rafi do you have any thoughts WRT
the new API?

Andrew



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Re: GSoC Projects & Mentors ?

[Marnie McCormack]

Sure - be glad to see some suggestions from people on things they would be
actively willing to mentor.
All - please do add anything you'd have time to take on.

Bye for now,
Marnie
On Tue, Feb 9, 2010 at 9:19 PM, Carl Trieloff  wrote:

>
>
> It would be good to see if others want to put up additional topic. I'm
> not comfortable mentored any of the listed ones
>
> Carl.
>
>
>
>
> On 02/09/2010 04:14 PM, Marnie McCormack wrote:
>
>> Thanks to Aidan&  Robbie - great to have you on this.
>>
>> Anyone else ? Please reply asap so we can co-operate on the project
>> outlines
>> together (probably on jabber).
>>
>> Thanks,
>> Marnie
>>
>> On Thu, Feb 4, 2010 at 9:33 AM, Robbie Gemmell> >wrote:
>>
>>
>>
>>> Id be happy to mentor someone + be Aidans backup.
>>>
>>> Robbie
>>>
>>> On 31 January 2010 21:47, Aidan Skinner  wrote:
>>>
>>>
 On Fri, Jan 29, 2010 at 9:02 AM, Marnie McCormack
   wrote:



> Can those willing/able to act as mentors this year please also reply on
>
>
 this
>>>
>>>
 thread ? Every project outline needs at least one mentor, preferably 1 +
> backup.
>
>
 I'll happily mentor again this year, it's been a blast before. :)

 - Aidan

 --
 Apache Qpid - AMQP, JMS, other messaging love http://qpid.apache.org
 "A witty saying proves nothing" - Voltaire

 -
 Apache Qpid - AMQP Messaging Implementation
 Project:  http://qpid.apache.org
 Use/Interact: mailto:dev-subscr...@qpid.apache.org




>>> -
>>> Apache Qpid - AMQP Messaging Implementation
>>> Project:  http://qpid.apache.org
>>> Use/Interact: mailto:dev-subscr...@qpid.apache.org
>>>
>>>
>>>
>>>
>>
>>
>
>
> -
> Apache Qpid - AMQP Messaging Implementation
> Project:  http://qpid.apache.org
> Use/Interact: mailto:dev-subscr...@qpid.apache.org
>
>