Re: Size of the Java client

2010-03-30 Thread Emmanuel Bourg

Rafael Schloming a écrit :

I'm generally in favor of examining and reducing our dependencies where 
possible. We haven't done this in a long time, so I wouldn't be 
surprised if they could be trimmed a bit. Do you have a specific 
size/configuration in mind? Are you looking at embedded usage or something?


I'm not specifically looking at an embedded usage, that will be for a 
desktop application, but I generally pay attention to the size of the 
dependencies. I would expect a message queue client to be not bigger 
than ~500KB (dependencies included and fully compressed with pack200+lzma)


Also less dependencies helps avoiding dependency hell. For example I 
also use backport-util-concurrent on my project, but at version 3.1. I'm 
not confident the Qpid Java client would work fine since it depends on 
the 2.2 version.


Emmanuel Bourg

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: Many Mb of doc related tools checked in

2010-03-30 Thread Emmanuel Bourg

Emmanuel Bourg a écrit :

I attached the Maven descriptor to this mail. It uses the Maven Docbkx 
plugin (http://code.google.com/p/docbkx-tools).


I should also have mentioned how you actually use it. The file is meant 
to be copied in the qpid/doc/book directory, and the documentation is 
generated by typing 'mvn package'.


Emmanuel Bourg


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: Many Mb of doc related tools checked in

2010-03-30 Thread Emmanuel Bourg

Jonathan Robie a écrit :


Could you send it to me? I'm interested!


I attached the Maven descriptor to this mail. It uses the Maven Docbkx 
plugin (http://code.google.com/p/docbkx-tools).


I know the Maven topic is sensitive on this list and I'm sorry if I woke 
some old daemons. I've used Ant, Ivy and Maven on different projects, 
I'm not really fond of the constrained environments imposed by Maven, 
but it has an advantage I can't deny: it makes it really easy to apply 
external tools to the code (like test coverage analysis, code style 
checking, code auditing or generating documentation). I tend to use 
Maven on my projects just for these tasks, the main build/packaging 
being still managed by Ant+Ivy.


Emmanuel Bourg

http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";>
  4.0.0
  org.apache
  qpid-doc
  1.0
  pom
  Apache Qpid

  

  
com.agilejava.docbkx
docbkx-maven-plugin
2.0.10

  
package

  generate-pdf
  generate-html

  



  src
  Book.xml
  true
  

  


  




-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

[jira] Resolved: (QPID-2475) qpid/messaging/Session.h r928855 breaks Windows build - macro conflict

2010-03-30 Thread Steve Huston (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Huston resolved QPID-2475.


   Resolution: Fixed
Fix Version/s: 0.7

Fixed on trunk r929240.

> qpid/messaging/Session.h r928855 breaks Windows build - macro conflict
> --
>
> Key: QPID-2475
> URL: https://issues.apache.org/jira/browse/QPID-2475
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Client
>Affects Versions: 0.7
> Environment: Windows
>Reporter: Steve Huston
>Assignee: Steve Huston
> Fix For: 0.7
>
>
> this change broke on Windows:
> Index: C:/qpid/trunk/qpid/cpp/include/qpid/messaging/Session.h
> ===
> --- C:/qpid/trunk/qpid/cpp/include/qpid/messaging/Session.h   (revision 
> 928854)
> +++ C:/qpid/trunk/qpid/cpp/include/qpid/messaging/Session.h   (revision 
> 928855)
> @@ -102,7 +102,7 @@
>   * which case the passed in receiver reference will be set to the
>   * receiver for that message or false if no message was available.
>   */
> -QPID_CLIENT_EXTERN bool nextReceiver(Receiver&, Duration 
> timeout=INFINITE_DURATION);
> +QPID_CLIENT_EXTERN bool nextReceiver(Receiver&, Duration 
> timeout=Duration::INFINITE);
>  /**
>   * Returns the receiver for the next available message. If there
>   * are no available messages at present the call will block for up
> @@ -111,7 +111,7 @@
>   *...@exception Receiver::NoMessageAvailable if no message became 
> available in
>   * time.
>   */
> -QPID_CLIENT_EXTERN Receiver nextReceiver(Duration 
> timeout=INFINITE_DURATION);
> +QPID_CLIENT_EXTERN Receiver nextReceiver(Duration 
> timeout=Duration::INFINITE);
>  
>  /**
>   * Create a new sender through which messages can be sent to the
> These errors occur during compile:
> C:\qpid\trunk\qpid\cpp\include\qpid/messaging/Session.h(105) : error C2589: 
> 'constant' : illegal token on right side of '::'
> C:\qpid\trunk\qpid\cpp\include\qpid/messaging/Session.h(114) : error C2589: 
> 'constant' : illegal token on right side of '::'
> Because of this definition in the Windows SDK:
> #define INFINITE0x  // Infinite timeout
> Can Duration::INFINITE, although a very good name, change to something like 
> BOUNDLESS?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: Many Mb of doc related tools checked in

2010-03-30 Thread Rafael Schloming

Jonathan Robie wrote:

On 03/30/2010 03:20 PM, Rafael Schloming wrote:
I'm +1 on the -1 on maven. We've had many bad experiences with maven 
in the past. It's basically impossible to produce repeatable builds 
with maven for many well documented reasons that I won't recount.


In general I would prefer to avoid adding more build technologies into 
the mix for qpid unless it is *absolutely* necessary. We already have 
ant, nant, autotools, cmake, make, rake, distutils, and various shell 
scripts already required to actually produce something useful from our 
source code. Let's not make this picture any worse.


I imagine using xmllint for xinclude is the bit that doesn't work on 
Windows.


The Saxon + FOP approach works well on Windows, I'd probably support 
that with an ant file that downloads everything it needs into 
subdirectories if not present.


Any objections to that approach?


I think that's fine as long as the build is capable of using locally 
installed tools as well, and the download option is provided as a 
separate convenience.


In general formal build environments won't allow arbitrary access to the 
internet when building pristine versions of things, so it would be 
problematic if the build system required this.


--Rafael


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] Assigned: (QPID-2475) qpid/messaging/Session.h r928855 breaks Windows build - macro conflict

2010-03-30 Thread Steve Huston (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Huston reassigned QPID-2475:
--

Assignee: Steve Huston

> qpid/messaging/Session.h r928855 breaks Windows build - macro conflict
> --
>
> Key: QPID-2475
> URL: https://issues.apache.org/jira/browse/QPID-2475
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Client
>Affects Versions: 0.7
> Environment: Windows
>Reporter: Steve Huston
>Assignee: Steve Huston
>
> this change broke on Windows:
> Index: C:/qpid/trunk/qpid/cpp/include/qpid/messaging/Session.h
> ===
> --- C:/qpid/trunk/qpid/cpp/include/qpid/messaging/Session.h   (revision 
> 928854)
> +++ C:/qpid/trunk/qpid/cpp/include/qpid/messaging/Session.h   (revision 
> 928855)
> @@ -102,7 +102,7 @@
>   * which case the passed in receiver reference will be set to the
>   * receiver for that message or false if no message was available.
>   */
> -QPID_CLIENT_EXTERN bool nextReceiver(Receiver&, Duration 
> timeout=INFINITE_DURATION);
> +QPID_CLIENT_EXTERN bool nextReceiver(Receiver&, Duration 
> timeout=Duration::INFINITE);
>  /**
>   * Returns the receiver for the next available message. If there
>   * are no available messages at present the call will block for up
> @@ -111,7 +111,7 @@
>   *...@exception Receiver::NoMessageAvailable if no message became 
> available in
>   * time.
>   */
> -QPID_CLIENT_EXTERN Receiver nextReceiver(Duration 
> timeout=INFINITE_DURATION);
> +QPID_CLIENT_EXTERN Receiver nextReceiver(Duration 
> timeout=Duration::INFINITE);
>  
>  /**
>   * Create a new sender through which messages can be sent to the
> These errors occur during compile:
> C:\qpid\trunk\qpid\cpp\include\qpid/messaging/Session.h(105) : error C2589: 
> 'constant' : illegal token on right side of '::'
> C:\qpid\trunk\qpid\cpp\include\qpid/messaging/Session.h(114) : error C2589: 
> 'constant' : illegal token on right side of '::'
> Because of this definition in the Windows SDK:
> #define INFINITE0x  // Infinite timeout
> Can Duration::INFINITE, although a very good name, change to something like 
> BOUNDLESS?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] Commented: (QPID-2475) qpid/messaging/Session.h r928855 breaks Windows build - macro conflict

2010-03-30 Thread Steve Huston (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-2475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851538#action_12851538
 ] 

Steve Huston commented on QPID-2475:


I like FOREVER better too. I'll change it. Thanks Gordon!


> qpid/messaging/Session.h r928855 breaks Windows build - macro conflict
> --
>
> Key: QPID-2475
> URL: https://issues.apache.org/jira/browse/QPID-2475
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Client
>Affects Versions: 0.7
> Environment: Windows
>Reporter: Steve Huston
>
> this change broke on Windows:
> Index: C:/qpid/trunk/qpid/cpp/include/qpid/messaging/Session.h
> ===
> --- C:/qpid/trunk/qpid/cpp/include/qpid/messaging/Session.h   (revision 
> 928854)
> +++ C:/qpid/trunk/qpid/cpp/include/qpid/messaging/Session.h   (revision 
> 928855)
> @@ -102,7 +102,7 @@
>   * which case the passed in receiver reference will be set to the
>   * receiver for that message or false if no message was available.
>   */
> -QPID_CLIENT_EXTERN bool nextReceiver(Receiver&, Duration 
> timeout=INFINITE_DURATION);
> +QPID_CLIENT_EXTERN bool nextReceiver(Receiver&, Duration 
> timeout=Duration::INFINITE);
>  /**
>   * Returns the receiver for the next available message. If there
>   * are no available messages at present the call will block for up
> @@ -111,7 +111,7 @@
>   *...@exception Receiver::NoMessageAvailable if no message became 
> available in
>   * time.
>   */
> -QPID_CLIENT_EXTERN Receiver nextReceiver(Duration 
> timeout=INFINITE_DURATION);
> +QPID_CLIENT_EXTERN Receiver nextReceiver(Duration 
> timeout=Duration::INFINITE);
>  
>  /**
>   * Create a new sender through which messages can be sent to the
> These errors occur during compile:
> C:\qpid\trunk\qpid\cpp\include\qpid/messaging/Session.h(105) : error C2589: 
> 'constant' : illegal token on right side of '::'
> C:\qpid\trunk\qpid\cpp\include\qpid/messaging/Session.h(114) : error C2589: 
> 'constant' : illegal token on right side of '::'
> Because of this definition in the Windows SDK:
> #define INFINITE0x  // Infinite timeout
> Can Duration::INFINITE, although a very good name, change to something like 
> BOUNDLESS?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: Many Mb of doc related tools checked in

2010-03-30 Thread Jonathan Robie

On 03/30/2010 03:20 PM, Rafael Schloming wrote:
I'm +1 on the -1 on maven. We've had many bad experiences with maven 
in the past. It's basically impossible to produce repeatable builds 
with maven for many well documented reasons that I won't recount.


In general I would prefer to avoid adding more build technologies into 
the mix for qpid unless it is *absolutely* necessary. We already have 
ant, nant, autotools, cmake, make, rake, distutils, and various shell 
scripts already required to actually produce something useful from our 
source code. Let's not make this picture any worse.


I imagine using xmllint for xinclude is the bit that doesn't work on 
Windows.


The Saxon + FOP approach works well on Windows, I'd probably support 
that with an ant file that downloads everything it needs into 
subdirectories if not present.


Any objections to that approach?

Jonathan


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: Many Mb of doc related tools checked in

2010-03-30 Thread Rafael Schloming
I'm +1 on the -1 on maven. We've had many bad experiences with maven in 
the past. It's basically impossible to produce repeatable builds with 
maven for many well documented reasons that I won't recount.


In general I would prefer to avoid adding more build technologies into 
the mix for qpid unless it is *absolutely* necessary. We already have 
ant, nant, autotools, cmake, make, rake, distutils, and various shell 
scripts already required to actually produce something useful from our 
source code. Let's not make this picture any worse.


--Rafael

Rajith Attapattu wrote:

I really don't like to use Maven.
The problem is it will download the whole world into my computer.
I believe in order to do a build you needed to be connected to the
internet as well (pls correct me if I am wrong).

Having said that we need something that works well on every OS. The
current solution is not quite there.
But I don't think the answer is Maven.
All though the tool chain is downloaded outside of the checkout, it
still does download a whole lot more.

Regards,

Rajith

On Tue, Mar 30, 2010 at 1:28 PM, Emmanuel Bourg  wrote:

Jonathan Robie a écrit :


I wanted to make it easy for anyone to build the documentation, which
requires a certain version of docbook, docbook-xsl, and Apache FOP version
0.95 (earlier versions were not anywhere near as good).

Building the documentation was the first thing I tried as I dived into Qpid,
and the current build is not really friendly for a Windows user.

If anyone is interested I wrote a short Maven descriptor to build the PDF
and HTML documentation from the Docbook files. It weights less than 3KB and
downloads automatically the complete tool chain (Docbook DTD & stylesheets,
FOP, Saxon, etc)

Emmanuel Bourg

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org








-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: Many Mb of doc related tools checked in

2010-03-30 Thread Jonathan Robie

On 03/30/2010 02:52 PM, Rajith Attapattu wrote:

I really don't like to use Maven.
The problem is it will download the whole world into my computer.
I believe in order to do a build you needed to be connected to the
internet as well (pls correct me if I am wrong).

Having said that we need something that works well on every OS. The
current solution is not quite there.
But I don't think the answer is Maven.
All though the tool chain is downloaded outside of the checkout, it
still does download a whole lot more.
   


I can do the same thing with ant, though.

Suppose I used the same tools I used before, but my ant task checked to 
see if the tools are there, installing them into subdirectories if they 
are not.


If you're offline, and the tool chain is already installed, this still 
works. If you're offline, and the tool chain is not already installed, 
you wouldn't have been able to install anyway.


Jonathan

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: Many Mb of doc related tools checked in

2010-03-30 Thread Rajith Attapattu
I really don't like to use Maven.
The problem is it will download the whole world into my computer.
I believe in order to do a build you needed to be connected to the
internet as well (pls correct me if I am wrong).

Having said that we need something that works well on every OS. The
current solution is not quite there.
But I don't think the answer is Maven.
All though the tool chain is downloaded outside of the checkout, it
still does download a whole lot more.

Regards,

Rajith

On Tue, Mar 30, 2010 at 1:28 PM, Emmanuel Bourg  wrote:
> Jonathan Robie a écrit :
>
>> I wanted to make it easy for anyone to build the documentation, which
>> requires a certain version of docbook, docbook-xsl, and Apache FOP version
>> 0.95 (earlier versions were not anywhere near as good).
>
> Building the documentation was the first thing I tried as I dived into Qpid,
> and the current build is not really friendly for a Windows user.
>
> If anyone is interested I wrote a short Maven descriptor to build the PDF
> and HTML documentation from the Docbook files. It weights less than 3KB and
> downloads automatically the complete tool chain (Docbook DTD & stylesheets,
> FOP, Saxon, etc)
>
> Emmanuel Bourg
>
> -
> Apache Qpid - AMQP Messaging Implementation
> Project:      http://qpid.apache.org
> Use/Interact: mailto:dev-subscr...@qpid.apache.org
>
>



-- 
Regards,

Rajith Attapattu
Red Hat
http://rajith.2rlabs.com/

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: Many Mb of doc related tools checked in

2010-03-30 Thread Alan Conway

On 03/30/2010 02:42 PM, Jonathan Robie wrote:

On 03/30/2010 01:28 PM, Emmanuel Bourg wrote:

Jonathan Robie a écrit :


I wanted to make it easy for anyone to build the documentation, which
requires a certain version of docbook, docbook-xsl, and Apache FOP
version 0.95 (earlier versions were not anywhere near as good).


Building the documentation was the first thing I tried as I dived into
Qpid, and the current build is not really friendly for a Windows user.

If anyone is interested I wrote a short Maven descriptor to build the
PDF and HTML documentation from the Docbook files. It weights less
than 3KB and downloads automatically the complete tool chain (Docbook
DTD & stylesheets, FOP, Saxon, etc)


Could you send it to me? I'm interested!

Question for the list: Is it OK to set this up so that a document build
downloads the tool chain and installs it to a local subdirectory if it's
not already there?



I don't see why not.

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: Many Mb of doc related tools checked in

2010-03-30 Thread Jonathan Robie

On 03/30/2010 01:28 PM, Emmanuel Bourg wrote:

Jonathan Robie a écrit :

I wanted to make it easy for anyone to build the documentation, which 
requires a certain version of docbook, docbook-xsl, and Apache FOP 
version 0.95 (earlier versions were not anywhere near as good).


Building the documentation was the first thing I tried as I dived into 
Qpid, and the current build is not really friendly for a Windows user.


If anyone is interested I wrote a short Maven descriptor to build the 
PDF and HTML documentation from the Docbook files. It weights less 
than 3KB and downloads automatically the complete tool chain (Docbook 
DTD & stylesheets, FOP, Saxon, etc)


Could you send it to me? I'm interested!

Question for the list: Is it OK to set this up so that a document build 
downloads the tool chain and installs it to a local subdirectory if it's 
not already there?


Jonathan

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



RE: Size of the Java client

2010-03-30 Thread Robbie Gemmell
I have already trimmed all the completely unused commons- jars out of
the client, it's just that it was done after 0.6 was branched 3 months ago
so they were not removed from the release itself.

The others are still ripe for removal as noted :)

Robbie

> -Original Message-
> From: Rafael Schloming [mailto:rafa...@redhat.com]
> Sent: 30 March 2010 18:49
> To: dev@qpid.apache.org
> Subject: Re: Size of the Java client
> 
> Emmanuel Bourg wrote:
> > Hi,
> >
> > I started playing with Qpid recently, I'm mostly interested in the
> Java
> > side of the project. I noticed that the Java client was quite big
> > compared to the other clients. It weights about 4.3MB whereas the
> .NET
> > client for example is less that 1MB.
> >
> > It looks like the dependencies could be reduced:
> >
> > - Commons Lang is only used once in AMQProtocolSession to perform a
> > replace char. This could be replaced by a basic String.replace() or a
> > regexp.
> >
> > - Commons Configuration seems to be only used by the broker, it's
> never
> > used in the common and client packages.
> >
> > - Commons Digester and Commons BeanUtils are in the binary package
> but
> > don't seem to be used. I guess they are there as transitive
> dependencies
> > of Commons Configuration?
> >
> > - Commons Collections is only used for the ReferenceMap, if this
> class
> > can't be replaced by a WeakHashMap it could probably be copied into
> the
> > source tree to save 500KB.
> >
> > - Commons Codec, not sure if it's actually used by the client but its
> > size is quite small.
> >
> > - backport-util-concurrent should be easy to remove since the client
> > already requires Java 5. As I understand this dependency is required
> by
> > the Mina jar that was specifically tweaked for Qpid. I can volunteer
> to
> > repackage Mina without the backport-util dependency.
> >
> > - qpid-all.jar, I'm not sure to understand its intent since this
> package
> > doesn't contain any code or resource.
> 
> This is just for convenience. It has a manifest-classpath that
> references all the other jars. We want to kill this at some point, but
> right now most of our scripts reference it.
> 
> > - qpid-common.jar is the biggest part of the client. Maybe the
> > implementations of the various AMQP versions could be split into
> > different jars so one can pick the version relevant to its usage
> > (qpid-amqp-0.8.jar, qpid-amqp-0.9.jar, etc) ?
> >
> >
> > These changes could bring the size of the client to less than 2MB.
> >
> > What do you think?
> 
> I'm generally in favor of examining and reducing our dependencies where
> possible. We haven't done this in a long time, so I wouldn't be
> surprised if they could be trimmed a bit. Do you have a specific
> size/configuration in mind? Are you looking at embedded usage or
> something?
> 
> --Rafael
> 
> 
> -
> Apache Qpid - AMQP Messaging Implementation
> Project:  http://qpid.apache.org
> Use/Interact: mailto:dev-subscr...@qpid.apache.org



-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: Size of the Java client

2010-03-30 Thread Rafael Schloming

Emmanuel Bourg wrote:

Hi,

I started playing with Qpid recently, I'm mostly interested in the Java 
side of the project. I noticed that the Java client was quite big 
compared to the other clients. It weights about 4.3MB whereas the .NET 
client for example is less that 1MB.


It looks like the dependencies could be reduced:

- Commons Lang is only used once in AMQProtocolSession to perform a 
replace char. This could be replaced by a basic String.replace() or a 
regexp.


- Commons Configuration seems to be only used by the broker, it's never 
used in the common and client packages.


- Commons Digester and Commons BeanUtils are in the binary package but 
don't seem to be used. I guess they are there as transitive dependencies 
of Commons Configuration?


- Commons Collections is only used for the ReferenceMap, if this class 
can't be replaced by a WeakHashMap it could probably be copied into the 
source tree to save 500KB.


- Commons Codec, not sure if it's actually used by the client but its 
size is quite small.


- backport-util-concurrent should be easy to remove since the client 
already requires Java 5. As I understand this dependency is required by 
the Mina jar that was specifically tweaked for Qpid. I can volunteer to 
repackage Mina without the backport-util dependency.


- qpid-all.jar, I'm not sure to understand its intent since this package 
doesn't contain any code or resource.


This is just for convenience. It has a manifest-classpath that 
references all the other jars. We want to kill this at some point, but 
right now most of our scripts reference it.


- qpid-common.jar is the biggest part of the client. Maybe the 
implementations of the various AMQP versions could be split into 
different jars so one can pick the version relevant to its usage 
(qpid-amqp-0.8.jar, qpid-amqp-0.9.jar, etc) ?



These changes could bring the size of the client to less than 2MB.

What do you think?


I'm generally in favor of examining and reducing our dependencies where 
possible. We haven't done this in a long time, so I wouldn't be 
surprised if they could be trimmed a bit. Do you have a specific 
size/configuration in mind? Are you looking at embedded usage or something?


--Rafael


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: Many Mb of doc related tools checked in

2010-03-30 Thread Emmanuel Bourg

Jonathan Robie a écrit :

I wanted to make it easy for anyone to build the documentation, which 
requires a certain version of docbook, docbook-xsl, and Apache FOP 
version 0.95 (earlier versions were not anywhere near as good).


Building the documentation was the first thing I tried as I dived into 
Qpid, and the current build is not really friendly for a Windows user.


If anyone is interested I wrote a short Maven descriptor to build the 
PDF and HTML documentation from the Docbook files. It weights less than 
3KB and downloads automatically the complete tool chain (Docbook DTD & 
stylesheets, FOP, Saxon, etc)


Emmanuel Bourg

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] Updated: (QPID-2418) Existing durable subscription with selector is not unsubscribed during change to new subscription

2010-03-30 Thread Andrew Kennedy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-2418:
-

Attachment: (was: 0001-QPID-2418-branch.patch)

>  Existing durable subscription with selector is not unsubscribed during 
> change to new subscription
> --
>
> Key: QPID-2418
> URL: https://issues.apache.org/jira/browse/QPID-2418
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Client
>Affects Versions: M4, 0.5, 0.6
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: 0001-QPID-2418-trunk.patch
>
>
> AMQSession.createDurableSubscriber(topic, name, messageSelector, noLocal) 
> does not unsubscribe existing durable subscriptions. Whilst it does check for 
> existing durable subscriptions in use by the client with the same name, it 
> instead simply closes the subscriptions then creates a new one. As a result 
> of not unsubscribing, the queue backing the subscription is not deleted 
> before being used by the updated subscription as it should be (and as happens 
> in the 0_8 and 0_10 subclasses when using durable subscriptions without 
> selectors).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] Commented: (QPID-2475) qpid/messaging/Session.h r928855 breaks Windows build - macro conflict

2010-03-30 Thread Gordon Sim (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-2475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851467#action_12851467
 ] 

Gordon Sim commented on QPID-2475:
--

Sorry! We can certainly change it. I'm not mad on BOUNDLESS - how about 
FOREVER? Or could we use camel case rather than pure caps for these constants?

> qpid/messaging/Session.h r928855 breaks Windows build - macro conflict
> --
>
> Key: QPID-2475
> URL: https://issues.apache.org/jira/browse/QPID-2475
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Client
>Affects Versions: 0.7
> Environment: Windows
>Reporter: Steve Huston
>
> this change broke on Windows:
> Index: C:/qpid/trunk/qpid/cpp/include/qpid/messaging/Session.h
> ===
> --- C:/qpid/trunk/qpid/cpp/include/qpid/messaging/Session.h   (revision 
> 928854)
> +++ C:/qpid/trunk/qpid/cpp/include/qpid/messaging/Session.h   (revision 
> 928855)
> @@ -102,7 +102,7 @@
>   * which case the passed in receiver reference will be set to the
>   * receiver for that message or false if no message was available.
>   */
> -QPID_CLIENT_EXTERN bool nextReceiver(Receiver&, Duration 
> timeout=INFINITE_DURATION);
> +QPID_CLIENT_EXTERN bool nextReceiver(Receiver&, Duration 
> timeout=Duration::INFINITE);
>  /**
>   * Returns the receiver for the next available message. If there
>   * are no available messages at present the call will block for up
> @@ -111,7 +111,7 @@
>   *...@exception Receiver::NoMessageAvailable if no message became 
> available in
>   * time.
>   */
> -QPID_CLIENT_EXTERN Receiver nextReceiver(Duration 
> timeout=INFINITE_DURATION);
> +QPID_CLIENT_EXTERN Receiver nextReceiver(Duration 
> timeout=Duration::INFINITE);
>  
>  /**
>   * Create a new sender through which messages can be sent to the
> These errors occur during compile:
> C:\qpid\trunk\qpid\cpp\include\qpid/messaging/Session.h(105) : error C2589: 
> 'constant' : illegal token on right side of '::'
> C:\qpid\trunk\qpid\cpp\include\qpid/messaging/Session.h(114) : error C2589: 
> 'constant' : illegal token on right side of '::'
> Because of this definition in the Windows SDK:
> #define INFINITE0x  // Infinite timeout
> Can Duration::INFINITE, although a very good name, change to something like 
> BOUNDLESS?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: Access to qpidd original arg list from {platform specific}QpiddBroker.cpp ?

2010-03-30 Thread Kerry Bonin
Hello Steve!  I'll take a look at fixing QPID-1423 next, hadn't seen it
before...

Kerry

On Tue, Mar 30, 2010 at 11:52 AM, Steve Huston  wrote:

> Hi Kerry,
>
> > Hello, and thanks for the comments!
>
> You're welcome - thanks for working on a very useful addition!
>
> > On the event log, I hadn't seen that option yet, I'll look
> > for it and not add another one...
>
> Great - also please note QPID-1423 if you wish to make some improvement
> there:
> https://issues.apache.org/jira/browse/QPID-1423
>
> Thanks,
> -Steve
>
> > On Mon, Mar 29, 2010 at 4:15 PM, Steve Huston
> >  wrote:
> >
> > > Looks nice, Kerry!
> > >
> > > I don't have many answers for you at this point, but one note...
> > >
> > > >   Use of event log
> > >
> > > There is already a logging option to put stuff in the windows event
> > > log.
> > >
> > > > As a side note, if anyone has any other suggestions
> > related to this
> > > > or other service features, please let me know and I'll
> > see if I can
> > > > add it.
> > >
> > > The installer build is going to be checked in sometime soon. This
> > > builds a WiX-based installer; it may be nice to add the ability to
> > > install the broker as a service during the install.
> > >
> > > -Steve
> > >
> > >
> > >
> > -
> > > Apache Qpid - AMQP Messaging Implementation
> > > Project:  http://qpid.apache.org
> > > Use/Interact: mailto:dev-subscr...@qpid.apache.org
> > >
> > >
> >
>
>
> -
> Apache Qpid - AMQP Messaging Implementation
> Project:  http://qpid.apache.org
> Use/Interact: mailto:dev-subscr...@qpid.apache.org
>
>


RE: CMake compilation failure

2010-03-30 Thread Steve Huston
Hi Ján,

> Hello!
> 
> So I tried CMake on r928878...
> 
> - - - - - - - - - - - - - - - - - - - - - -
> $ cd cpp
> $ cmake .
> $ make
> ...
> [ 79%] Built target ssl
> [ 79%] Built target sslconnector
> [ 80%] Built target watchdog
> [ 80%] Building CXX object 
> src/CMakeFiles/xml.dir/qpid/xml/XmlExchange.o
> /var/tmp/jasan/qpid-20100330/cpp/src/qpid/xml/XmlExchange.cpp:
>  In member function ‘bool 
> qpid::broker::XmlExchange::matches(boost::shared_ptr&
> , qpid::broker::Deliverable&, const 
> qpid::framing::FieldTable*, bool)’:
> /var/tmp/jasan/qpid-20100330/cpp/src/qpid/xml/XmlExchange.cpp:
> 192: error: ‘class ResultImpl’ has no member named 
> ‘getEffectiveBooleanValue’
> make[2]: *** [src/CMakeFiles/xml.dir/qpid/xml/XmlExchange.o] Error 1
> make[1]: *** [src/CMakeFiles/xml.dir/all] Error 2
> make: *** [all] Error 2
> - - - - - - - - - - - - - - - - - - - - - -

This smells like some mismatch between Makefile.am and CMakeFiles.txt
but I don't regularly build XmlExchange.

> And if I build without XML, I am getting following:
> 
> [ 99%] Building CXX object 
> src/tests/CMakeFiles/cluster_test.dir/PartialFailure.o
> Linking CXX executable unit_test
> [100%] Building CXX object 
> src/tests/CMakeFiles/cluster_test.dir/ClusterFailover.o
> [100%] Built target unit_test
> [100%] Building CXX object 
> src/tests/CMakeFiles/cluster_test.dir/InitialStatusMap.o
> [100%] Building CXX object 
> src/tests/CMakeFiles/cluster_test.dir/StoreStatus.o
> Linking CXX executable cluster_test
> /usr/bin/ld: CMakeFiles/cluster_test.dir/StoreStatus.o: 
> undefined reference to symbol 'boost::system::get_system_category()'
> /usr/bin/ld: note: 'boost::system::get_system_category()' is 
> defined in DSO /usr/lib64/libboost_system-mt.so.1.41.0 so try 
> adding it to the linker command line
> /usr/lib64/libboost_system-mt.so.1.41.0: could not read 
> symbols: Invalid operation
> collect2: ld returned 1 exit status
> make[2]: *** [src/tests/cluster_test] Error 1
> make[1]: *** [src/tests/CMakeFiles/cluster_test.dir/all] Error 2
> make: *** [all] Error 2

It looks like this is missing the boost system reference; again, not one
I regularly build so I haven't seen it.

-Steve


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



RE: Access to qpidd original arg list from {platform specific}QpiddBroker.cpp ?

2010-03-30 Thread Steve Huston
Hi Kerry,

> Hello, and thanks for the comments!

You're welcome - thanks for working on a very useful addition!

> On the event log, I hadn't seen that option yet, I'll look 
> for it and not add another one...

Great - also please note QPID-1423 if you wish to make some improvement
there:
https://issues.apache.org/jira/browse/QPID-1423

Thanks,
-Steve

> On Mon, Mar 29, 2010 at 4:15 PM, Steve Huston 
>  wrote:
> 
> > Looks nice, Kerry!
> >
> > I don't have many answers for you at this point, but one note...
> >
> > >   Use of event log
> >
> > There is already a logging option to put stuff in the windows event 
> > log.
> >
> > > As a side note, if anyone has any other suggestions 
> related to this 
> > > or other service features, please let me know and I'll 
> see if I can 
> > > add it.
> >
> > The installer build is going to be checked in sometime soon. This 
> > builds a WiX-based installer; it may be nice to add the ability to 
> > install the broker as a service during the install.
> >
> > -Steve
> >
> >
> > 
> -
> > Apache Qpid - AMQP Messaging Implementation
> > Project:  http://qpid.apache.org
> > Use/Interact: mailto:dev-subscr...@qpid.apache.org
> >
> >
> 


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Size of the Java client

2010-03-30 Thread Emmanuel Bourg

Hi,

I started playing with Qpid recently, I'm mostly interested in the Java 
side of the project. I noticed that the Java client was quite big 
compared to the other clients. It weights about 4.3MB whereas the .NET 
client for example is less that 1MB.


It looks like the dependencies could be reduced:

- Commons Lang is only used once in AMQProtocolSession to perform a 
replace char. This could be replaced by a basic String.replace() or a 
regexp.


- Commons Configuration seems to be only used by the broker, it's never 
used in the common and client packages.


- Commons Digester and Commons BeanUtils are in the binary package but 
don't seem to be used. I guess they are there as transitive dependencies 
of Commons Configuration?


- Commons Collections is only used for the ReferenceMap, if this class 
can't be replaced by a WeakHashMap it could probably be copied into the 
source tree to save 500KB.


- Commons Codec, not sure if it's actually used by the client but its 
size is quite small.


- backport-util-concurrent should be easy to remove since the client 
already requires Java 5. As I understand this dependency is required by 
the Mina jar that was specifically tweaked for Qpid. I can volunteer to 
repackage Mina without the backport-util dependency.


- qpid-all.jar, I'm not sure to understand its intent since this package 
doesn't contain any code or resource.


- qpid-common.jar is the biggest part of the client. Maybe the 
implementations of the various AMQP versions could be split into 
different jars so one can pick the version relevant to its usage 
(qpid-amqp-0.8.jar, qpid-amqp-0.9.jar, etc) ?



These changes could bring the size of the client to less than 2MB.

What do you think?

Emmanuel Bourg

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: Access to qpidd original arg list from {platform specific}QpiddBroker.cpp ?

2010-03-30 Thread Kerry Bonin
Hello, and thanks for the comments!

First, thank you Andrew for GetCommandLine() - 20 something years on
Windows, and I don't remember seeing that one before, certainly made this
simpler.

On the subject of the command line in general for a service - I agree that
under most normal use a config file should be used, I just wanted to make
sure the command line was usable...

On the security of self-installing services - if the service is doing much
more than installing itself, especially if it contains baked in credentials,
ect., that would be a very bad thing.  What I've done is essentially the
equivalent of sc create|start|stop|delete wrap as a convenience function,
nothing more, and the calls execute with the same privilege level a user has
available to them at the command line.

On the account / password arguments for the service - these are NOT retained
by the service in any way - they are merely passed to the SCM as part of
service creation in the exact same way the sc command lets you specify the
obj and password arguments - they are then used by the SCM to create a
security token which is placed in the registry along with the service data,
and used when the service is started.

On the event log, I hadn't seen that option yet, I'll look for it and not
add another one...

Kerry


On Mon, Mar 29, 2010 at 4:15 PM, Steve Huston  wrote:

> Looks nice, Kerry!
>
> I don't have many answers for you at this point, but one note...
>
> >   Use of event log
>
> There is already a logging option to put stuff in the windows event log.
>
> > As a side note, if anyone has any other suggestions related
> > to this or other service features, please let me know and
> > I'll see if I can add it.
>
> The installer build is going to be checked in sometime soon. This builds
> a WiX-based installer; it may be nice to add the ability to install the
> broker as a service during the install.
>
> -Steve
>
>
> -
> Apache Qpid - AMQP Messaging Implementation
> Project:  http://qpid.apache.org
> Use/Interact: mailto:dev-subscr...@qpid.apache.org
>
>


[jira] Updated: (QPID-2475) qpid/messaging/Session.h r928855 breaks Windows build - macro conflict

2010-03-30 Thread Steve Huston (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Huston updated QPID-2475:
---

Description: 
this change broke on Windows:

Index: C:/qpid/trunk/qpid/cpp/include/qpid/messaging/Session.h
===
--- C:/qpid/trunk/qpid/cpp/include/qpid/messaging/Session.h (revision 
928854)
+++ C:/qpid/trunk/qpid/cpp/include/qpid/messaging/Session.h (revision 
928855)
@@ -102,7 +102,7 @@
  * which case the passed in receiver reference will be set to the
  * receiver for that message or false if no message was available.
  */
-QPID_CLIENT_EXTERN bool nextReceiver(Receiver&, Duration 
timeout=INFINITE_DURATION);
+QPID_CLIENT_EXTERN bool nextReceiver(Receiver&, Duration 
timeout=Duration::INFINITE);
 /**
  * Returns the receiver for the next available message. If there
  * are no available messages at present the call will block for up
@@ -111,7 +111,7 @@
  *...@exception Receiver::NoMessageAvailable if no message became 
available in
  * time.
  */
-QPID_CLIENT_EXTERN Receiver nextReceiver(Duration 
timeout=INFINITE_DURATION);
+QPID_CLIENT_EXTERN Receiver nextReceiver(Duration 
timeout=Duration::INFINITE);
 
 /**
  * Create a new sender through which messages can be sent to the

These errors occur during compile:

C:\qpid\trunk\qpid\cpp\include\qpid/messaging/Session.h(105) : error C2589: 
'constant' : illegal token on right side of '::'
C:\qpid\trunk\qpid\cpp\include\qpid/messaging/Session.h(114) : error C2589: 
'constant' : illegal token on right side of '::'

Because of this definition in the Windows SDK:

#define INFINITE0x  // Infinite timeout


Can Duration::INFINITE, although a very good name, change to something like 
BOUNDLESS?

  was:
this change broke on Windows:

Index: C:/qpid/trunk/qpid/cpp/include/qpid/messaging/Session.h
===
--- C:/qpid/trunk/qpid/cpp/include/qpid/messaging/Session.h (revision 
928854)
+++ C:/qpid/trunk/qpid/cpp/include/qpid/messaging/Session.h (revision 
928855)
@@ -102,7 +102,7 @@
  * which case the passed in receiver reference will be set to the
  * receiver for that message or false if no message was available.
  */
-QPID_CLIENT_EXTERN bool nextReceiver(Receiver&, Duration 
timeout=INFINITE_DURATION);
+QPID_CLIENT_EXTERN bool nextReceiver(Receiver&, Duration 
timeout=Duration::INFINITE);
 /**
  * Returns the receiver for the next available message. If there
  * are no available messages at present the call will block for up
@@ -111,7 +111,7 @@
  *...@exception Receiver::NoMessageAvailable if no message became 
available in
  * time.
  */
-QPID_CLIENT_EXTERN Receiver nextReceiver(Duration 
timeout=INFINITE_DURATION);
+QPID_CLIENT_EXTERN Receiver nextReceiver(Duration 
timeout=Duration::INFINITE);
 
 /**
  * Create a new sender through which messages can be sent to the

Apparantly INFINITE is a macro brought in somewhere in Windows:

C:\qpid\trunk\qpid\cpp\include\qpid/messaging/Session.h(105) : error C2589: 
'constant' : illegal token on right side of '::'
C:\qpid\trunk\qpid\cpp\include\qpid/messaging/Session.h(114) : error C2589: 
'constant' : illegal token on right side of '::'



> qpid/messaging/Session.h r928855 breaks Windows build - macro conflict
> --
>
> Key: QPID-2475
> URL: https://issues.apache.org/jira/browse/QPID-2475
> Project: Qpid
>  Issue Type: Bug
>  Components: C++ Client
>Affects Versions: 0.7
> Environment: Windows
>Reporter: Steve Huston
>
> this change broke on Windows:
> Index: C:/qpid/trunk/qpid/cpp/include/qpid/messaging/Session.h
> ===
> --- C:/qpid/trunk/qpid/cpp/include/qpid/messaging/Session.h   (revision 
> 928854)
> +++ C:/qpid/trunk/qpid/cpp/include/qpid/messaging/Session.h   (revision 
> 928855)
> @@ -102,7 +102,7 @@
>   * which case the passed in receiver reference will be set to the
>   * receiver for that message or false if no message was available.
>   */
> -QPID_CLIENT_EXTERN bool nextReceiver(Receiver&, Duration 
> timeout=INFINITE_DURATION);
> +QPID_CLIENT_EXTERN bool nextReceiver(Receiver&, Duration 
> timeout=Duration::INFINITE);
>  /**
>   * Returns the receiver for the next available message. If there
>   * are no available messages at present the call will block for up
> @@ -111,7 +111,7 @@
>   *...@exception Receiver::NoMessageAvailable if no message became 
> available in
>   * time.
>   */
> -QPID_CLIENT_EXTERN Receiver nextReceiver(Duration 
> timeout=INFINITE_DURATION);
> +QPID_

[jira] Created: (QPID-2475) qpid/messaging/Session.h r928855 breaks Windows build - macro conflict

2010-03-30 Thread Steve Huston (JIRA)
qpid/messaging/Session.h r928855 breaks Windows build - macro conflict
--

 Key: QPID-2475
 URL: https://issues.apache.org/jira/browse/QPID-2475
 Project: Qpid
  Issue Type: Bug
  Components: C++ Client
Affects Versions: 0.7
 Environment: Windows
Reporter: Steve Huston


this change broke on Windows:

Index: C:/qpid/trunk/qpid/cpp/include/qpid/messaging/Session.h
===
--- C:/qpid/trunk/qpid/cpp/include/qpid/messaging/Session.h (revision 
928854)
+++ C:/qpid/trunk/qpid/cpp/include/qpid/messaging/Session.h (revision 
928855)
@@ -102,7 +102,7 @@
  * which case the passed in receiver reference will be set to the
  * receiver for that message or false if no message was available.
  */
-QPID_CLIENT_EXTERN bool nextReceiver(Receiver&, Duration 
timeout=INFINITE_DURATION);
+QPID_CLIENT_EXTERN bool nextReceiver(Receiver&, Duration 
timeout=Duration::INFINITE);
 /**
  * Returns the receiver for the next available message. If there
  * are no available messages at present the call will block for up
@@ -111,7 +111,7 @@
  *...@exception Receiver::NoMessageAvailable if no message became 
available in
  * time.
  */
-QPID_CLIENT_EXTERN Receiver nextReceiver(Duration 
timeout=INFINITE_DURATION);
+QPID_CLIENT_EXTERN Receiver nextReceiver(Duration 
timeout=Duration::INFINITE);
 
 /**
  * Create a new sender through which messages can be sent to the

Apparantly INFINITE is a macro brought in somewhere in Windows:

C:\qpid\trunk\qpid\cpp\include\qpid/messaging/Session.h(105) : error C2589: 
'constant' : illegal token on right side of '::'
C:\qpid\trunk\qpid\cpp\include\qpid/messaging/Session.h(114) : error C2589: 
'constant' : illegal token on right side of '::'


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: Unresolved issues but marked 0.6

2010-03-30 Thread Marnie McCormack
Hi Rajith,

That's corect - they will have done. I've been reviewing them when time
permits, but happy for other devs to review too to aid progress. Hoping
we'll have more time for review in the 0.8 cycle.

Regards,
Marnie

On Fri, Mar 26, 2010 at 6:00 PM, Rajith Attapattu wrote:

> On Fri, Mar 26, 2010 at 11:57 AM, Andrew Stitcher 
> wrote:
> > On Fri, 2010-03-26 at 10:59 -0400, Rajith Attapattu wrote:
> >> Hi All,
> >>
> >> The following JIRA are unresolved, but are marked 0.6
> >>
> https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&mode=hide&pid=12310520&fixfor=12313728&resolution=-1
> >>
> >> Could interested parties please have a look at them and update
> accordingly ?
> >
> > Note that the majority of these unresolved issues are actually in the
> > "ready to review" state. I think this means that the code has been
> > incorporated but no one has actually okayed it, perhaps the review
> > process isn't really working out?
>
> I'd think most of the "ready-to-review" JIRA's probably made it into
> the release.
> IMO they should go throw the review process and get marked resolved
> rather than me just removing the version.
>
> > There are only 4 issues still marked open, and 1 marked in progress, if
> > these states are still true then the issues should just be punted to a
> > 0.8 target.
> >
> >> I am planning to do mine today.
> >> I hope to update the 0.6 version to "released" status in JIRA on next
> >> Tuesday morning  and will move any unresolved JIRA to 0.7.
> >>
> >> Regards,
> >>
> >> Rajith Attapattu
> >> Red Hat
> >> http://rajith.2rlabs.com/
> >>
> >> -
> >> Apache Qpid - AMQP Messaging Implementation
> >> Project:  http://qpid.apache.org
> >> Use/Interact: mailto:dev-subscr...@qpid.apache.org
> >>
> >
> >
> >
>
>
>
> --
> Regards,
>
> Rajith Attapattu
> Red Hat
> http://rajith.2rlabs.com/
>
> -
> Apache Qpid - AMQP Messaging Implementation
> Project:  http://qpid.apache.org
> Use/Interact: mailto:dev-subscr...@qpid.apache.org
>
>


[jira] Commented: (QPID-2466) Replace WeakReference use with SoftReference for enhanced message caching

2010-03-30 Thread Robbie Gemmell (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-2466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851431#action_12851431
 ] 

Robbie Gemmell commented on QPID-2466:
--

Changes commited 0.5.x-dev branch only for now. 

Patch still to be added to trunk.

> Replace WeakReference use with SoftReference for enhanced message caching
> -
>
> Key: QPID-2466
> URL: https://issues.apache.org/jira/browse/QPID-2466
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Affects Versions: 0.6
> Environment: JVM 1.6.0_18
>Reporter: Andrew Kennedy
>Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: 
> 0001-QPID-2466-Replace-WeakReference-use-with-SoftRefere.patch
>
>
> Replace use of WeakReference with SoftReference in the message handles in the 
> broker to improve message cache performance when using a persistent store. 
> Also tuning the eviction policy for soft references and evaluation of other 
> GC settings.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] Assigned: (QPID-2466) Replace WeakReference use with SoftReference for enhanced message caching

2010-03-30 Thread Robbie Gemmell (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell reassigned QPID-2466:


Assignee: Robbie Gemmell

> Replace WeakReference use with SoftReference for enhanced message caching
> -
>
> Key: QPID-2466
> URL: https://issues.apache.org/jira/browse/QPID-2466
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Affects Versions: 0.6
> Environment: JVM 1.6.0_18
>Reporter: Andrew Kennedy
>Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: 
> 0001-QPID-2466-Replace-WeakReference-use-with-SoftRefere.patch
>
>
> Replace use of WeakReference with SoftReference in the message handles in the 
> broker to improve message cache performance when using a persistent store. 
> Also tuning the eviction policy for soft references and evaluation of other 
> GC settings.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] Updated: (QPID-2466) Replace WeakReference use with SoftReference for enhanced message caching

2010-03-30 Thread Andrew Kennedy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-2466:
-

Attachment: (was: 
0001-QPID-2466-Replace-use-of-WeakReference-with-SoftRef.patch)

> Replace WeakReference use with SoftReference for enhanced message caching
> -
>
> Key: QPID-2466
> URL: https://issues.apache.org/jira/browse/QPID-2466
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Affects Versions: 0.6
> Environment: JVM 1.6.0_18
>Reporter: Andrew Kennedy
> Fix For: 0.7
>
> Attachments: 
> 0001-QPID-2466-Replace-WeakReference-use-with-SoftRefere.patch
>
>
> Replace use of WeakReference with SoftReference in the message handles in the 
> broker to improve message cache performance when using a persistent store. 
> Also tuning the eviction policy for soft references and evaluation of other 
> GC settings.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] Updated: (QPID-2466) Replace WeakReference use with SoftReference for enhanced message caching

2010-03-30 Thread Andrew Kennedy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-2466:
-

Attachment: 0001-QPID-2466-Replace-WeakReference-use-with-SoftRefere.patch

> Replace WeakReference use with SoftReference for enhanced message caching
> -
>
> Key: QPID-2466
> URL: https://issues.apache.org/jira/browse/QPID-2466
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Affects Versions: 0.6
> Environment: JVM 1.6.0_18
>Reporter: Andrew Kennedy
> Fix For: 0.7
>
> Attachments: 
> 0001-QPID-2466-Replace-WeakReference-use-with-SoftRefere.patch
>
>
> Replace use of WeakReference with SoftReference in the message handles in the 
> broker to improve message cache performance when using a persistent store. 
> Also tuning the eviction policy for soft references and evaluation of other 
> GC settings.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] Commented: (QPID-2360) declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup

2010-03-30 Thread Robbie Gemmell (JIRA)

[ 
https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851397#action_12851397
 ] 

Robbie Gemmell commented on QPID-2360:
--

Patches commited

> declaring virtualhost level firewall configuration in virtualhosts.xml leads 
> to NPE on startup
> --
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.6
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: 0001-QPID-2630-QPID-2631-branch.patch, 
> 0001-QPID-2630-QPID-2631-trunk.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads 
> to NPE on startup. 
> After moving the same configuration into config.xml the broker then loads ok 
> and the configuration works as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] Updated: (QPID-2361) exchange configuration attributes are ignored when configuration is placed in virtualhosts.xml

2010-03-30 Thread Robbie Gemmell (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated QPID-2361:
-

Status: Ready To Review  (was: In Progress)

> exchange configuration attributes are ignored when configuration is placed in 
> virtualhosts.xml
> --
>
> Key: QPID-2361
> URL: https://issues.apache.org/jira/browse/QPID-2361
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.5, 0.6
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: 0.7
>
>
> When configuring exchanges in virtualhosts.xml, only the name is picked up. 
> The type element is ignored and the default "direct" is used. Similarly, the 
> durable element is ignored and the default "false" is used. As such it is 
> impossible to define anything other than a transient direct exchange within 
> virtualhosts.xml.
> When configured within the main config.xml file, the configuration is picked 
> up and used as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] Updated: (QPID-2360) declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup

2010-03-30 Thread Robbie Gemmell (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell updated QPID-2360:
-

Status: Ready To Review  (was: In Progress)

> declaring virtualhost level firewall configuration in virtualhosts.xml leads 
> to NPE on startup
> --
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.6
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: 0001-QPID-2630-QPID-2631-branch.patch, 
> 0001-QPID-2630-QPID-2631-trunk.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads 
> to NPE on startup. 
> After moving the same configuration into config.xml the broker then loads ok 
> and the configuration works as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] Updated: (QPID-2466) Replace WeakReference use with SoftReference for enhanced message caching

2010-03-30 Thread Andrew Kennedy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-2466:
-

Attachment: 0001-QPID-2466-Replace-use-of-WeakReference-with-SoftRef.patch

Patch is for branch, and requires the following commands to be run afterwards 
to move the files correctly with subversion:

$ mv 
qpid/java/broker/src/main/java/org/apache/qpid/server/queue/SoftReferenceMessageHandle.java
 
qpid/java/broker/src/main/java/org/apache/qpid/server/queue/WeakReferenceMessageHandle.java
$ svn mv 
qpid/java/broker/src/main/java/org/apache/qpid/server/queue/WeakReferenceMessageHandle.java
 
qpid/java/broker/src/main/java/org/apache/qpid/server/queue/SoftReferenceMessageHandle.java


> Replace WeakReference use with SoftReference for enhanced message caching
> -
>
> Key: QPID-2466
> URL: https://issues.apache.org/jira/browse/QPID-2466
> Project: Qpid
>  Issue Type: Improvement
>  Components: Java Broker
>Affects Versions: 0.6
> Environment: JVM 1.6.0_18
>Reporter: Andrew Kennedy
> Fix For: 0.7
>
> Attachments: 
> 0001-QPID-2466-Replace-use-of-WeakReference-with-SoftRef.patch
>
>
> Replace use of WeakReference with SoftReference in the message handles in the 
> broker to improve message cache performance when using a persistent store. 
> Also tuning the eviction policy for soft references and evaluation of other 
> GC settings.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] Updated: (QPID-2418) Existing durable subscription with selector is not unsubscribed during change to new subscription

2010-03-30 Thread Andrew Kennedy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-2418:
-

Attachment: 0001-QPID-2418-trunk.patch
0001-QPID-2418-branch.patch

>  Existing durable subscription with selector is not unsubscribed during 
> change to new subscription
> --
>
> Key: QPID-2418
> URL: https://issues.apache.org/jira/browse/QPID-2418
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Client
>Affects Versions: M4, 0.5, 0.6
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: 0001-QPID-2418-branch.patch, 0001-QPID-2418-trunk.patch
>
>
> AMQSession.createDurableSubscriber(topic, name, messageSelector, noLocal) 
> does not unsubscribe existing durable subscriptions. Whilst it does check for 
> existing durable subscriptions in use by the client with the same name, it 
> instead simply closes the subscriptions then creates a new one. As a result 
> of not unsubscribing, the queue backing the subscription is not deleted 
> before being used by the updated subscription as it should be (and as happens 
> in the 0_8 and 0_10 subclasses when using durable subscriptions without 
> selectors).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] Updated: (QPID-2360) declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup

2010-03-30 Thread Andrew Kennedy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-2360:
-

Attachment: 0001-QPID-2630-QPID-2631-trunk.patch
0001-QPID-2630-QPID-2631-branch.patch

> declaring virtualhost level firewall configuration in virtualhosts.xml leads 
> to NPE on startup
> --
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.6
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: 0001-QPID-2630-QPID-2631-branch.patch, 
> 0001-QPID-2630-QPID-2631-trunk.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads 
> to NPE on startup. 
> After moving the same configuration into config.xml the broker then loads ok 
> and the configuration works as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] Updated: (QPID-2360) declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup

2010-03-30 Thread Andrew Kennedy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-2360:
-

Attachment: (was: 0001-QPID-2630-QPID-2631-trunk.patch)

> declaring virtualhost level firewall configuration in virtualhosts.xml leads 
> to NPE on startup
> --
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.6
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: 0.7
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads 
> to NPE on startup. 
> After moving the same configuration into config.xml the broker then loads ok 
> and the configuration works as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] Updated: (QPID-2418) Existing durable subscription with selector is not unsubscribed during change to new subscription

2010-03-30 Thread Andrew Kennedy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-2418:
-

Attachment: (was: 0001-QPID-2418-trunk.patch)

>  Existing durable subscription with selector is not unsubscribed during 
> change to new subscription
> --
>
> Key: QPID-2418
> URL: https://issues.apache.org/jira/browse/QPID-2418
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Client
>Affects Versions: M4, 0.5, 0.6
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: 0.7
>
>
> AMQSession.createDurableSubscriber(topic, name, messageSelector, noLocal) 
> does not unsubscribe existing durable subscriptions. Whilst it does check for 
> existing durable subscriptions in use by the client with the same name, it 
> instead simply closes the subscriptions then creates a new one. As a result 
> of not unsubscribing, the queue backing the subscription is not deleted 
> before being used by the updated subscription as it should be (and as happens 
> in the 0_8 and 0_10 subclasses when using durable subscriptions without 
> selectors).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] Updated: (QPID-2360) declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup

2010-03-30 Thread Andrew Kennedy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-2360:
-

Attachment: (was: 0001-QPID-2630-QPID-2631-branch.patch)

> declaring virtualhost level firewall configuration in virtualhosts.xml leads 
> to NPE on startup
> --
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.6
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: 0001-QPID-2630-QPID-2631-trunk.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads 
> to NPE on startup. 
> After moving the same configuration into config.xml the broker then loads ok 
> and the configuration works as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] Updated: (QPID-2418) Existing durable subscription with selector is not unsubscribed during change to new subscription

2010-03-30 Thread Andrew Kennedy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-2418:
-

Attachment: (was: 0001-QPID-2418-branch.patch)

>  Existing durable subscription with selector is not unsubscribed during 
> change to new subscription
> --
>
> Key: QPID-2418
> URL: https://issues.apache.org/jira/browse/QPID-2418
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Client
>Affects Versions: M4, 0.5, 0.6
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: 0001-QPID-2418-trunk.patch
>
>
> AMQSession.createDurableSubscriber(topic, name, messageSelector, noLocal) 
> does not unsubscribe existing durable subscriptions. Whilst it does check for 
> existing durable subscriptions in use by the client with the same name, it 
> instead simply closes the subscriptions then creates a new one. As a result 
> of not unsubscribing, the queue backing the subscription is not deleted 
> before being used by the updated subscription as it should be (and as happens 
> in the 0_8 and 0_10 subclasses when using durable subscriptions without 
> selectors).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] Updated: (QPID-2360) declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup

2010-03-30 Thread Andrew Kennedy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-2360:
-

Attachment: 0001-QPID-2630-QPID-2631-trunk.patch
0001-QPID-2630-QPID-2631-branch.patch

Removed unused tests

> declaring virtualhost level firewall configuration in virtualhosts.xml leads 
> to NPE on startup
> --
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.6
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: 0001-QPID-2630-QPID-2631-branch.patch, 
> 0001-QPID-2630-QPID-2631-trunk.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads 
> to NPE on startup. 
> After moving the same configuration into config.xml the broker then loads ok 
> and the configuration works as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] Updated: (QPID-2360) declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup

2010-03-30 Thread Andrew Kennedy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-2360:
-

Attachment: (was: 0001-QPID-2630-QPID-2631-branch.patch)

> declaring virtualhost level firewall configuration in virtualhosts.xml leads 
> to NPE on startup
> --
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.6
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: 0.7
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads 
> to NPE on startup. 
> After moving the same configuration into config.xml the broker then loads ok 
> and the configuration works as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] Updated: (QPID-2360) declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup

2010-03-30 Thread Andrew Kennedy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-2360:
-

Attachment: (was: 0001-QPID-2630-QPID-2631-trunk.patch)

> declaring virtualhost level firewall configuration in virtualhosts.xml leads 
> to NPE on startup
> --
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.6
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: 0.7
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads 
> to NPE on startup. 
> After moving the same configuration into config.xml the broker then loads ok 
> and the configuration works as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] Updated: (QPID-2360) declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup

2010-03-30 Thread Andrew Kennedy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-2360:
-

Attachment: (was: 0001-QPID-2630-QPID-2631-trunk.patch)

> declaring virtualhost level firewall configuration in virtualhosts.xml leads 
> to NPE on startup
> --
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.6
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: 0001-QPID-2630-QPID-2631-branch.patch, 
> 0001-QPID-2630-QPID-2631-trunk.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads 
> to NPE on startup. 
> After moving the same configuration into config.xml the broker then loads ok 
> and the configuration works as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] Updated: (QPID-2360) declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup

2010-03-30 Thread Andrew Kennedy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-2360:
-

Attachment: 0001-QPID-2630-QPID-2631-trunk.patch
0001-QPID-2630-QPID-2631-branch.patch

> declaring virtualhost level firewall configuration in virtualhosts.xml leads 
> to NPE on startup
> --
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.6
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: 0001-QPID-2630-QPID-2631-branch.patch, 
> 0001-QPID-2630-QPID-2631-trunk.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads 
> to NPE on startup. 
> After moving the same configuration into config.xml the broker then loads ok 
> and the configuration works as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] Updated: (QPID-2360) declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup

2010-03-30 Thread Andrew Kennedy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-2360:
-

Attachment: (was: 0001-QPID-2630-QPID-2631-branch.patch)

> declaring virtualhost level firewall configuration in virtualhosts.xml leads 
> to NPE on startup
> --
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.6
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: 0001-QPID-2630-QPID-2631-trunk.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads 
> to NPE on startup. 
> After moving the same configuration into config.xml the broker then loads ok 
> and the configuration works as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] Updated: (QPID-2418) Existing durable subscription with selector is not unsubscribed during change to new subscription

2010-03-30 Thread Andrew Kennedy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-2418:
-

Attachment: 0001-QPID-2418-trunk.patch
0001-QPID-2418-branch.patch

Updated patches for branch and trunk

>  Existing durable subscription with selector is not unsubscribed during 
> change to new subscription
> --
>
> Key: QPID-2418
> URL: https://issues.apache.org/jira/browse/QPID-2418
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Client
>Affects Versions: M4, 0.5, 0.6
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: 0001-QPID-2418-branch.patch, 0001-QPID-2418-trunk.patch
>
>
> AMQSession.createDurableSubscriber(topic, name, messageSelector, noLocal) 
> does not unsubscribe existing durable subscriptions. Whilst it does check for 
> existing durable subscriptions in use by the client with the same name, it 
> instead simply closes the subscriptions then creates a new one. As a result 
> of not unsubscribing, the queue backing the subscription is not deleted 
> before being used by the updated subscription as it should be (and as happens 
> in the 0_8 and 0_10 subclasses when using durable subscriptions without 
> selectors).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



Re: CMake compilation failure

2010-03-30 Thread Ján Sáreník
And if I build without XML, I am getting following:

[ 99%] Building CXX object 
src/tests/CMakeFiles/cluster_test.dir/PartialFailure.o
Linking CXX executable unit_test
[100%] Building CXX object 
src/tests/CMakeFiles/cluster_test.dir/ClusterFailover.o
[100%] Built target unit_test
[100%] Building CXX object 
src/tests/CMakeFiles/cluster_test.dir/InitialStatusMap.o
[100%] Building CXX object src/tests/CMakeFiles/cluster_test.dir/StoreStatus.o
Linking CXX executable cluster_test
/usr/bin/ld: CMakeFiles/cluster_test.dir/StoreStatus.o: undefined reference to 
symbol 'boost::system::get_system_category()'
/usr/bin/ld: note: 'boost::system::get_system_category()' is defined in DSO 
/usr/lib64/libboost_system-mt.so.1.41.0 so try adding it to the linker command 
line
/usr/lib64/libboost_system-mt.so.1.41.0: could not read symbols: Invalid 
operation
collect2: ld returned 1 exit status
make[2]: *** [src/tests/cluster_test] Error 1
make[1]: *** [src/tests/CMakeFiles/cluster_test.dir/all] Error 2
make: *** [all] Error 2

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



CMake compilation failure

2010-03-30 Thread Ján Sáreník
Hello!

So I tried CMake on r928878...

- - - - - - - - - - - - - - - - - - - - - -
$ cd cpp
$ cmake .
$ make
...
[ 79%] Built target ssl
[ 79%] Built target sslconnector
[ 80%] Built target watchdog
[ 80%] Building CXX object src/CMakeFiles/xml.dir/qpid/xml/XmlExchange.o
/var/tmp/jasan/qpid-20100330/cpp/src/qpid/xml/XmlExchange.cpp: In member 
function ‘bool qpid::broker::XmlExchange::matches(boost::shared_ptr&, 
qpid::broker::Deliverable&, const qpid::framing::FieldTable*, bool)’:
/var/tmp/jasan/qpid-20100330/cpp/src/qpid/xml/XmlExchange.cpp:192: error: 
‘class ResultImpl’ has no member named ‘getEffectiveBooleanValue’
make[2]: *** [src/CMakeFiles/xml.dir/qpid/xml/XmlExchange.o] Error 1
make[1]: *** [src/CMakeFiles/xml.dir/all] Error 2
make: *** [all] Error 2
- - - - - - - - - - - - - - - - - - - - - -

fedora-release-14-0.4.noarch
cmake-2.8.1-0.2.rc5.fc14.x86_64
xqilla-devel-2.2.3-7.fc14.x86_64
xerces-c-devel-3.0.1-16.fc13.x86_64

   Best regards, Ján
-- 
Red Hat Czech, MRG Quality Assurance Associate

-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] Updated: (QPID-2360) declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup

2010-03-30 Thread Andrew Kennedy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-2360:
-

Attachment: (was: 0001-QPID-2630-QPID-2631-trunk.patch)

> declaring virtualhost level firewall configuration in virtualhosts.xml leads 
> to NPE on startup
> --
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.6
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: 0001-QPID-2630-QPID-2631-branch.patch, 
> 0001-QPID-2630-QPID-2631-trunk.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads 
> to NPE on startup. 
> After moving the same configuration into config.xml the broker then loads ok 
> and the configuration works as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] Updated: (QPID-2360) declaring virtualhost level firewall configuration in virtualhosts.xml leads to NPE on startup

2010-03-30 Thread Andrew Kennedy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-2360:
-

Attachment: 0001-QPID-2630-QPID-2631-trunk.patch

> declaring virtualhost level firewall configuration in virtualhosts.xml leads 
> to NPE on startup
> --
>
> Key: QPID-2360
> URL: https://issues.apache.org/jira/browse/QPID-2360
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.6
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: 0001-QPID-2630-QPID-2631-branch.patch, 
> 0001-QPID-2630-QPID-2631-trunk.patch
>
>
> Declaring virtualhost level firewall configuration in virtualhosts.xml leads 
> to NPE on startup. 
> After moving the same configuration into config.xml the broker then loads ok 
> and the configuration works as expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] Updated: (QPID-2472) QpidCompositeRollingAppender log4j configuration is misleading

2010-03-30 Thread Andrew Kennedy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-2472:
-

Attachment: 0003-QPID-2472-Correct-log4j-XML-configuration-comments.patch

Updated patch with comments changed, for branch and trunk

> QpidCompositeRollingAppender log4j configuration is misleading
> --
>
> Key: QPID-2472
> URL: https://issues.apache.org/jira/browse/QPID-2472
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.5, 0.6
>Reporter: Andrew Kennedy
>Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: 
> 0003-QPID-2472-Correct-log4j-XML-configuration-comments.patch
>
>
> The QpidCompositeRollingAppender logging appender configuration is 
> misleading. The configuration file states that the default rollover size is 
> 1MB, wheras the actual default in the code is 10 MB. Additionally, the 
> 'CompressBackupFiles' flag controls both the creation of backups in a 
> separate directory on rollover, and the compression of these files. This 
> property should either be renamed or backing up of files to a separate 
> location should be enabled based on the presence of the 'backupFilesToPath' 
> property instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] Updated: (QPID-2418) Existing durable subscription with selector is not unsubscribed during change to new subscription

2010-03-30 Thread Andrew Kennedy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-2418:
-

Attachment: (was: 
0001-QPID-2418-Unsubscribe-existing-durable-subscription.patch)

>  Existing durable subscription with selector is not unsubscribed during 
> change to new subscription
> --
>
> Key: QPID-2418
> URL: https://issues.apache.org/jira/browse/QPID-2418
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Client
>Affects Versions: M4, 0.5, 0.6
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
> Fix For: 0.7
>
>
> AMQSession.createDurableSubscriber(topic, name, messageSelector, noLocal) 
> does not unsubscribe existing durable subscriptions. Whilst it does check for 
> existing durable subscriptions in use by the client with the same name, it 
> instead simply closes the subscriptions then creates a new one. As a result 
> of not unsubscribing, the queue backing the subscription is not deleted 
> before being used by the updated subscription as it should be (and as happens 
> in the 0_8 and 0_10 subclasses when using durable subscriptions without 
> selectors).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org



[jira] Updated: (QPID-2472) QpidCompositeRollingAppender log4j configuration is misleading

2010-03-30 Thread Andrew Kennedy (JIRA)

 [ 
https://issues.apache.org/jira/browse/QPID-2472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kennedy updated QPID-2472:
-

Attachment: (was: 
0001-QPID-2472-Correct-log4j-XML-configuration-comments.patch)

> QpidCompositeRollingAppender log4j configuration is misleading
> --
>
> Key: QPID-2472
> URL: https://issues.apache.org/jira/browse/QPID-2472
> Project: Qpid
>  Issue Type: Bug
>  Components: Java Broker
>Affects Versions: 0.5, 0.6
>Reporter: Andrew Kennedy
>Assignee: Robbie Gemmell
> Fix For: 0.7
>
> Attachments: 
> 0003-QPID-2472-Correct-log4j-XML-configuration-comments.patch
>
>
> The QpidCompositeRollingAppender logging appender configuration is 
> misleading. The configuration file states that the default rollover size is 
> 1MB, wheras the actual default in the code is 10 MB. Additionally, the 
> 'CompressBackupFiles' flag controls both the creation of backups in a 
> separate directory on rollover, and the compression of these files. This 
> property should either be renamed or backing up of files to a separate 
> location should be enabled based on the presence of the 'backupFilesToPath' 
> property instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


-
Apache Qpid - AMQP Messaging Implementation
Project:  http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org