[jira] [Commented] (PROTON-1626) Incompatibilty of fdlimit test on RHEL 6 x64
[ https://issues.apache.org/jira/browse/PROTON-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211883#comment-16211883 ] Andrew Stitcher commented on PROTON-1626: - A backward compatible skiptest has benn added for RHEL6 in the C++ binding tests. > Incompatibilty of fdlimit test on RHEL 6 x64 > > > Key: PROTON-1626 > URL: https://issues.apache.org/jira/browse/PROTON-1626 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: proton-c-0.18.0 > Environment: RHEL 6 x64 >Reporter: Radim Kubis >Priority: Minor > > Test > [fdlimit|https://github.com/apache/qpid-proton/blob/master/proton-c/src/tests/fdlimit.py] > uses RHEL 6 x64 incompatible things: > * _skipTest_ (added in Python 2.7, but RHEL 6 has Python 2.6.6) > * _prlimit_ utility (unavailable on RHEL 6) -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-1646) Proactor API needs a way to use an existing socket.
Andrew Stitcher created PROTON-1646: --- Summary: Proactor API needs a way to use an existing socket. Key: PROTON-1646 URL: https://issues.apache.org/jira/browse/PROTON-1646 Project: Qpid Proton Issue Type: Improvement Components: cpp-binding, proton-c Affects Versions: proton-c-0.18.0 Reporter: Andrew Stitcher Assignee: Cliff Jansen There are various times when it is necessary to take an existing socket and use it to communicate. * The most obvious is when we are started by systemd or inetd and passed the listening socket that they have accepted on our behalf. * Another case is in tests when we might want to open a port using a random port number and then atomically hand that to test code. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1644) [FreeBSD] Scheme for reusing ports in testing does not work for FreeBSD
[
https://issues.apache.org/jira/browse/PROTON-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211877#comment-16211877
]
Andrew Stitcher commented on PROTON-1644:
-
SO_REUSEADDR doesn't mean the same on BSDs.
You might think to use SO_REUSEPORT and this could be made to work. However all
the sockets need to be opened with this option, not just the first one, so this
particular version of the scheme can't work - there would have to be some way
for the test code to open the socket and pass it into the proactor.
Actually this is a functionality that is needed for some sorts of servers
anyway, so we should probably figure out a way to do this with our API.
> [FreeBSD] Scheme for reusing ports in testing does not work for FreeBSD
> ---
>
> Key: PROTON-1644
> URL: https://issues.apache.org/jira/browse/PROTON-1644
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c, ruby-binding
>Affects Versions: proton-c-0.18.0
> Environment: FreeBSD 10.3-RELEASE-p20
>Reporter: Andrew Stitcher
>Assignee: Alan Conway
>
> The scheme for picking ports using SO_REUSEPORT does not seem to work on
> FreeBSD producing a bunch of errors like
> {noformat}
> listen error: proton:io: address already in use - listening on localhost:51439
> broker shutdown: proton:io: address already in use - listening on
> localhost:51439
> {noformat}
> This happens in the tests:
> - 12:ruby-test-container
> - 31:c-proactor-tests
> - 34:cpp-example-container
> - 35:cpp-example-container-ssl
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Closed] (PROTON-1645) Building go binding with libuv fails
[
https://issues.apache.org/jira/browse/PROTON-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Stitcher closed PROTON-1645.
---
Resolution: Cannot Reproduce
It looks like this might have been caused by some oddity in my go source tree.
The problem went away when I deleted the pkg sub directory in the go binding
tree. It does seem to me that building inside the source tree and not the build
tree is a problem, and caused this issue, but this problem seems to have gone
away.
> Building go binding with libuv fails
>
>
> Key: PROTON-1645
> URL: https://issues.apache.org/jira/browse/PROTON-1645
> Project: Qpid Proton
> Issue Type: Bug
> Components: go-binding
>Affects Versions: proton-c-0.18.0
> Environment: Fedora 25, go 1.7.6, libuv 1.10.2
>Reporter: Andrew Stitcher
>Assignee: Alan Conway
>
> When proton-c is built with the libuv proactor the go binding build fails to
> link with:
> {noformat}
> [3/7] cd /home/andrew/Work/proton/bld-libuv &&
> /...rew/Work/proton/src/examples/go/proton/broker.go
> FAILED: examples/go/CMakeFiles/go_example_proton_broker
> cd /home/andrew/Work/proton/bld-libuv && /usr/bin/python
> /home/andrew/Work/proton/src/proton-c/env.py --
> GOPATH=/home/andrew/Work/proton/src/proton-c/bindings/go
> CGO_CFLAGS=-I/home/andrew/Work/proton/src/proton-c/include\
> -I/home/andrew/Work/proton/bld-libuv/proton-c/include
> CGO_LDFLAGS=-L/home/andrew/Work/proton/bld-libuv/proton-c
> PN_INTEROP_DIR=/home/andrew/Work/proton/src/tests/interop /usr/bin/go build
> -ldflags -r\ /home/andrew/Work/proton/bld-libuv/proton-c -o
> /home/andrew/Work/proton/bld-libuv/examples/go/proton/broker
> /home/andrew/Work/proton/src/examples/go/proton/broker.go
> # command-line-arguments
> /usr/lib/golang/pkg/tool/linux_amd64/link: running gcc failed: exit status 1
> /usr/bin/ld: cannot find -lqpid-proton-core
> /usr/bin/ld: cannot find -lqpid-proton-core
> /usr/bin/ld: cannot find -lqpid-proton-core
> collect2: error: ld returned 1 exit status
> {noformat}
> From the error message it looks like go should have been passed the absolute
> path to {{libqpid-proton-core.so}} rather than just -lqpid-proton-core.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1620) TLS / SSL thread safety with proactor
[ https://issues.apache.org/jira/browse/PROTON-1620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211851#comment-16211851 ] ASF subversion and git services commented on PROTON-1620: - Commit 63b8528294d9431f46fc61b0b515c45b70645c4c in qpid-proton's branch refs/heads/master from Clifford Jansen [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=63b8528 ] PROTON-1620: Windows schannel thread safety for use with proactor > TLS / SSL thread safety with proactor > - > > Key: PROTON-1620 > URL: https://issues.apache.org/jira/browse/PROTON-1620 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: proton-c-0.18.0 >Reporter: Cliff Jansen >Assignee: Alan Conway >Priority: Critical > Fix For: proton-c-0.19.0 > > > ssl_domain objects are semi-global. > For example two connections simultaneously creating or releasing their own > private pn_ssl_t objects may mess up the refcount of the shared > pn_ssl_domain_t object leading to memory corruption or leaks. > Windows schannel is further complicated by the OS internal refcounting of its > security context thingies. That may get automatically solved by the above, > or may require a separate JIRA to track. The same may apply to openssl. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPID-7980) [Java Broker] Queue delete (or routeToAlternate) leaves message instance records in the store
Keith Wall created QPID-7980:
Summary: [Java Broker] Queue delete (or routeToAlternate) leaves
message instance records in the store
Key: QPID-7980
URL: https://issues.apache.org/jira/browse/QPID-7980
Project: Qpid
Issue Type: Bug
Components: Java Broker
Affects Versions: qpid-java-broker-7.0.0
Reporter: Keith Wall
Fix For: qpid-java-broker-7.0.0
Reproduction as follows:
# Create a durable queue
# Send a single persistent message to the queue(I'm using the Qpid JMS Client,
but it is not important).
# Use management to delete queue. The queue is deleted from the configuration
and the message record removed from the store, but the message instance is left
behind.
On Broker restart, the fact the message instance is left behind is reported to
the logs as a WARN.
The regression appears to have been caused by QPID-6028. Specifically, the
change to the QueueEntryImpl#routeToAlternate method. The change removed the
{{txn#dequeue()}}. I think this was probably an error.
This change is only on master.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-1645) Building go binding with libuv fails
[
https://issues.apache.org/jira/browse/PROTON-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Stitcher updated PROTON-1645:
Description:
When proton-c is built with the libuv proactor the go binding build fails to
link with:
{noformat}
[3/7] cd /home/andrew/Work/proton/bld-libuv &&
/...rew/Work/proton/src/examples/go/proton/broker.go
FAILED: examples/go/CMakeFiles/go_example_proton_broker
cd /home/andrew/Work/proton/bld-libuv && /usr/bin/python
/home/andrew/Work/proton/src/proton-c/env.py --
GOPATH=/home/andrew/Work/proton/src/proton-c/bindings/go
CGO_CFLAGS=-I/home/andrew/Work/proton/src/proton-c/include\
-I/home/andrew/Work/proton/bld-libuv/proton-c/include
CGO_LDFLAGS=-L/home/andrew/Work/proton/bld-libuv/proton-c
PN_INTEROP_DIR=/home/andrew/Work/proton/src/tests/interop /usr/bin/go build
-ldflags -r\ /home/andrew/Work/proton/bld-libuv/proton-c -o
/home/andrew/Work/proton/bld-libuv/examples/go/proton/broker
/home/andrew/Work/proton/src/examples/go/proton/broker.go
# command-line-arguments
/usr/lib/golang/pkg/tool/linux_amd64/link: running gcc failed: exit status 1
/usr/bin/ld: cannot find -lqpid-proton-core
/usr/bin/ld: cannot find -lqpid-proton-core
/usr/bin/ld: cannot find -lqpid-proton-core
collect2: error: ld returned 1 exit status
{noformat}
>From the error message it looks like go should have been passed the absolute
>path to {{libqpid-proton-core.so}} rather than just -lqpid-proton-core.
was:
When proton-c is built with the libuv proactor the go binding build fails to
link with:
{noformat}
[3/7] cd /home/andrew/Work/proton/bld-libuv &&
/...rew/Work/proton/src/examples/go/proton/broker.go
FAILED: examples/go/CMakeFiles/go_example_proton_broker
cd /home/andrew/Work/proton/bld-libuv && /usr/bin/python
/home/andrew/Work/proton/src/proton-c/env.py --
GOPATH=/home/andrew/Work/proton/src/proton-c/bindings/go
CGO_CFLAGS=-I/home/andrew/Work/proton/src/proton-c/include\
-I/home/andrew/Work/proton/bld-libuv/proton-c/include
CGO_LDFLAGS=-L/home/andrew/Work/proton/bld-libuv/proton-c
PN_INTEROP_DIR=/home/andrew/Work/proton/src/tests/interop /usr/bin/go build
-ldflags -r\ /home/andrew/Work/proton/bld-libuv/proton-c -o
/home/andrew/Work/proton/bld-libuv/examples/go/proton/broker
/home/andrew/Work/proton/src/examples/go/proton/broker.go
# command-line-arguments
/usr/lib/golang/pkg/tool/linux_amd64/link: running gcc failed: exit status 1
/usr/bin/ld: cannot find -lqpid-proton-core
/usr/bin/ld: cannot find -lqpid-proton-core
/usr/bin/ld: cannot find -lqpid-proton-core
collect2: error: ld returned 1 exit status
{noformat}
>From the error message it looks like go should have been passed the absolut
>path to libqpid-proton-core.so rather than just -lqpid-proton-core.
> Building go binding with libuv fails
>
>
> Key: PROTON-1645
> URL: https://issues.apache.org/jira/browse/PROTON-1645
> Project: Qpid Proton
> Issue Type: Bug
> Components: go-binding
>Affects Versions: proton-c-0.18.0
> Environment: Fedora 25, go 1.7.6, libuv 1.10.2
>Reporter: Andrew Stitcher
>Assignee: Alan Conway
>
> When proton-c is built with the libuv proactor the go binding build fails to
> link with:
> {noformat}
> [3/7] cd /home/andrew/Work/proton/bld-libuv &&
> /...rew/Work/proton/src/examples/go/proton/broker.go
> FAILED: examples/go/CMakeFiles/go_example_proton_broker
> cd /home/andrew/Work/proton/bld-libuv && /usr/bin/python
> /home/andrew/Work/proton/src/proton-c/env.py --
> GOPATH=/home/andrew/Work/proton/src/proton-c/bindings/go
> CGO_CFLAGS=-I/home/andrew/Work/proton/src/proton-c/include\
> -I/home/andrew/Work/proton/bld-libuv/proton-c/include
> CGO_LDFLAGS=-L/home/andrew/Work/proton/bld-libuv/proton-c
> PN_INTEROP_DIR=/home/andrew/Work/proton/src/tests/interop /usr/bin/go build
> -ldflags -r\ /home/andrew/Work/proton/bld-libuv/proton-c -o
> /home/andrew/Work/proton/bld-libuv/examples/go/proton/broker
> /home/andrew/Work/proton/src/examples/go/proton/broker.go
> # command-line-arguments
> /usr/lib/golang/pkg/tool/linux_amd64/link: running gcc failed: exit status 1
> /usr/bin/ld: cannot find -lqpid-proton-core
> /usr/bin/ld: cannot find -lqpid-proton-core
> /usr/bin/ld: cannot find -lqpid-proton-core
> collect2: error: ld returned 1 exit status
> {noformat}
> From the error message it looks like go should have been passed the absolute
> path to {{libqpid-proton-core.so}} rather than just -lqpid-proton-core.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (PROTON-1645) Building go binding with libuv fails
[
https://issues.apache.org/jira/browse/PROTON-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Stitcher updated PROTON-1645:
Description:
When proton-c is built with the libuv proactor the go binding build fails to
link with:
{noformat}
[3/7] cd /home/andrew/Work/proton/bld-libuv &&
/...rew/Work/proton/src/examples/go/proton/broker.go
FAILED: examples/go/CMakeFiles/go_example_proton_broker
cd /home/andrew/Work/proton/bld-libuv && /usr/bin/python
/home/andrew/Work/proton/src/proton-c/env.py --
GOPATH=/home/andrew/Work/proton/src/proton-c/bindings/go
CGO_CFLAGS=-I/home/andrew/Work/proton/src/proton-c/include\
-I/home/andrew/Work/proton/bld-libuv/proton-c/include
CGO_LDFLAGS=-L/home/andrew/Work/proton/bld-libuv/proton-c
PN_INTEROP_DIR=/home/andrew/Work/proton/src/tests/interop /usr/bin/go build
-ldflags -r\ /home/andrew/Work/proton/bld-libuv/proton-c -o
/home/andrew/Work/proton/bld-libuv/examples/go/proton/broker
/home/andrew/Work/proton/src/examples/go/proton/broker.go
# command-line-arguments
/usr/lib/golang/pkg/tool/linux_amd64/link: running gcc failed: exit status 1
/usr/bin/ld: cannot find -lqpid-proton-core
/usr/bin/ld: cannot find -lqpid-proton-core
/usr/bin/ld: cannot find -lqpid-proton-core
collect2: error: ld returned 1 exit status
{noformat}
>From the error message it looks like go should have been passed the absolut
>path to libqpid-proton-core.so rather than just -lqpid-proton-core.
was:
When proton-c is built with the libuv proactor the go binding build fails to
link with:
{noformat}
[3/7] cd /home/andrew/Work/proton/bld-libuv &&
/...rew/Work/proton/src/examples/go/proton/broker.go
FAILED: examples/go/CMakeFiles/go_example_proton_broker
cd /home/andrew/Work/proton/bld-libuv && /usr/bin/python
/home/andrew/Work/proton/src/proton-c/env.py --
GOPATH=/home/andrew/Work/proton/src/proton-c/bindings/go
CGO_CFLAGS=-I/home/andrew/Work/proton/src/proton-c/include\
-I/home/andrew/Work/proton/bld-libuv/proton-c/include
CGO_LDFLAGS=-L/home/andrew/Work/proton/bld-libuv/proton-c
PN_INTEROP_DIR=/home/andrew/Work/proton/src/tests/interop /usr/bin/go build
-ldflags -r\ /home/andrew/Work/proton/bld-libuv/proton-c -o
/home/andrew/Work/proton/bld-libuv/examples/go/proton/broker
/home/andrew/Work/proton/src/examples/go/proton/broker.go
# command-line-arguments
/usr/lib/golang/pkg/tool/linux_amd64/link: running gcc failed: exit status 1
/usr/bin/ld: cannot find -lqpid-proton-core
/usr/bin/ld: cannot find -lqpid-proton-core
/usr/bin/ld: cannot find -lqpid-proton-core
collect2: error: ld returned 1 exit status
{noformat}
> Building go binding with libuv fails
>
>
> Key: PROTON-1645
> URL: https://issues.apache.org/jira/browse/PROTON-1645
> Project: Qpid Proton
> Issue Type: Bug
> Components: go-binding
>Affects Versions: proton-c-0.18.0
> Environment: Fedora 25, go 1.7.6, libuv 1.10.2
>Reporter: Andrew Stitcher
>Assignee: Alan Conway
>
> When proton-c is built with the libuv proactor the go binding build fails to
> link with:
> {noformat}
> [3/7] cd /home/andrew/Work/proton/bld-libuv &&
> /...rew/Work/proton/src/examples/go/proton/broker.go
> FAILED: examples/go/CMakeFiles/go_example_proton_broker
> cd /home/andrew/Work/proton/bld-libuv && /usr/bin/python
> /home/andrew/Work/proton/src/proton-c/env.py --
> GOPATH=/home/andrew/Work/proton/src/proton-c/bindings/go
> CGO_CFLAGS=-I/home/andrew/Work/proton/src/proton-c/include\
> -I/home/andrew/Work/proton/bld-libuv/proton-c/include
> CGO_LDFLAGS=-L/home/andrew/Work/proton/bld-libuv/proton-c
> PN_INTEROP_DIR=/home/andrew/Work/proton/src/tests/interop /usr/bin/go build
> -ldflags -r\ /home/andrew/Work/proton/bld-libuv/proton-c -o
> /home/andrew/Work/proton/bld-libuv/examples/go/proton/broker
> /home/andrew/Work/proton/src/examples/go/proton/broker.go
> # command-line-arguments
> /usr/lib/golang/pkg/tool/linux_amd64/link: running gcc failed: exit status 1
> /usr/bin/ld: cannot find -lqpid-proton-core
> /usr/bin/ld: cannot find -lqpid-proton-core
> /usr/bin/ld: cannot find -lqpid-proton-core
> collect2: error: ld returned 1 exit status
> {noformat}
> From the error message it looks like go should have been passed the absolut
> path to libqpid-proton-core.so rather than just -lqpid-proton-core.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-1645) Building go binding with libuv fails
Andrew Stitcher created PROTON-1645:
---
Summary: Building go binding with libuv fails
Key: PROTON-1645
URL: https://issues.apache.org/jira/browse/PROTON-1645
Project: Qpid Proton
Issue Type: Bug
Components: go-binding
Affects Versions: proton-c-0.18.0
Environment: Fedora 25, go 1.7.6, libuv 1.10.2
Reporter: Andrew Stitcher
Assignee: Alan Conway
When proton-c is built with the libuv proactor the go binding build fails to
link with:
{noformat}
[3/7] cd /home/andrew/Work/proton/bld-libuv &&
/...rew/Work/proton/src/examples/go/proton/broker.go
FAILED: examples/go/CMakeFiles/go_example_proton_broker
cd /home/andrew/Work/proton/bld-libuv && /usr/bin/python
/home/andrew/Work/proton/src/proton-c/env.py --
GOPATH=/home/andrew/Work/proton/src/proton-c/bindings/go
CGO_CFLAGS=-I/home/andrew/Work/proton/src/proton-c/include\
-I/home/andrew/Work/proton/bld-libuv/proton-c/include
CGO_LDFLAGS=-L/home/andrew/Work/proton/bld-libuv/proton-c
PN_INTEROP_DIR=/home/andrew/Work/proton/src/tests/interop /usr/bin/go build
-ldflags -r\ /home/andrew/Work/proton/bld-libuv/proton-c -o
/home/andrew/Work/proton/bld-libuv/examples/go/proton/broker
/home/andrew/Work/proton/src/examples/go/proton/broker.go
# command-line-arguments
/usr/lib/golang/pkg/tool/linux_amd64/link: running gcc failed: exit status 1
/usr/bin/ld: cannot find -lqpid-proton-core
/usr/bin/ld: cannot find -lqpid-proton-core
/usr/bin/ld: cannot find -lqpid-proton-core
collect2: error: ld returned 1 exit status
{noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-1644) [FreeBSD] Scheme for reusing ports in testing does not work for FreeBSD
Andrew Stitcher created PROTON-1644:
---
Summary: [FreeBSD] Scheme for reusing ports in testing does not
work for FreeBSD
Key: PROTON-1644
URL: https://issues.apache.org/jira/browse/PROTON-1644
Project: Qpid Proton
Issue Type: Bug
Components: proton-c, ruby-binding
Affects Versions: proton-c-0.18.0
Environment: FreeBSD 10.3-RELEASE-p20
Reporter: Andrew Stitcher
Assignee: Alan Conway
The scheme for picking ports using SO_REUSEPORT does not seem to work on
FreeBSD producing a bunch of errors like
{noformat}
listen error: proton:io: address already in use - listening on localhost:51439
broker shutdown: proton:io: address already in use - listening on
localhost:51439
{noformat}
This happens in the tests:
- 12:ruby-test-container
- 31:c-proactor-tests
- 34:cpp-example-container
- 35:cpp-example-container-ssl
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-1643) [FreeBSD] ruby-example-test hangs
Andrew Stitcher created PROTON-1643:
---
Summary: [FreeBSD] ruby-example-test hangs
Key: PROTON-1643
URL: https://issues.apache.org/jira/browse/PROTON-1643
Project: Qpid Proton
Issue Type: Bug
Components: ruby-binding
Affects Versions: proton-c-0.18.0
Environment: FreeBSD 10.3-RELEASE-p20
Reporter: Andrew Stitcher
Assignee: Alan Conway
When running ctest ruby-example-test hangs.
If you examine the process list there is a process {{/usr/local/bin/ruby23
reactor/broker.rb -a :26780}} that has not exited. If you kill that process the
test fails but the test run carries on.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (PROTON-1641) Windows proactor hang on incoming connections
[ https://issues.apache.org/jira/browse/PROTON-1641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cliff Jansen resolved PROTON-1641. -- Resolution: Fixed > Windows proactor hang on incoming connections > - > > Key: PROTON-1641 > URL: https://issues.apache.org/jira/browse/PROTON-1641 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: proton-c-0.18.0, proton-c-0.19.0 > Environment: Windows >Reporter: Cliff Jansen >Assignee: Cliff Jansen > Fix For: proton-c-0.19.0 > > > Missing lock. Critical section guard required even though system call entry > and exit separate the memory accesses by the two threads. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-1642) [Freebsd] C++ container_test hangs in test_container_stop()
Andrew Stitcher created PROTON-1642: --- Summary: [Freebsd] C++ container_test hangs in test_container_stop() Key: PROTON-1642 URL: https://issues.apache.org/jira/browse/PROTON-1642 Project: Qpid Proton Issue Type: Bug Components: cpp-binding Affects Versions: proton-c-0.18.0 Environment: Freebsd 10.3-RELEASE-p20 libuv 1.14 Reporter: Andrew Stitcher Assignee: Cliff Jansen Running ctest on a default build on FreeBSD 10 hangs. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1641) Windows proactor hang on incoming connections
[ https://issues.apache.org/jira/browse/PROTON-1641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211657#comment-16211657 ] ASF subversion and git services commented on PROTON-1641: - Commit 686a400c907c5f03d9ce5ec542752ec9d1651812 in qpid-proton's branch refs/heads/master from Clifford Jansen [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=686a400 ] PROTON-1641: Windows proactor hang on inbound connections > Windows proactor hang on incoming connections > - > > Key: PROTON-1641 > URL: https://issues.apache.org/jira/browse/PROTON-1641 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: proton-c-0.18.0, proton-c-0.19.0 > Environment: Windows >Reporter: Cliff Jansen >Assignee: Cliff Jansen > Fix For: proton-c-0.19.0 > > > Missing lock. Critical section guard required even though system call entry > and exit separate the memory accesses by the two threads. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-1641) Windows proactor hang on incoming connections
Cliff Jansen created PROTON-1641: Summary: Windows proactor hang on incoming connections Key: PROTON-1641 URL: https://issues.apache.org/jira/browse/PROTON-1641 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: proton-c-0.18.0, proton-c-0.19.0 Environment: Windows Reporter: Cliff Jansen Assignee: Cliff Jansen Fix For: proton-c-0.19.0 Missing lock. Critical section guard required even though system call entry and exit separate the memory accesses by the two threads. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-858) Simplify hard to follow LICENSE file
[ https://issues.apache.org/jira/browse/DISPATCH-858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211567#comment-16211567 ] ASF GitHub Bot commented on DISPATCH-858: - Github user ganeshmurthy commented on the issue: https://github.com/apache/qpid-dispatch/pull/212 @gemmellr please take a look at this PR and critique it. Thanks. > Simplify hard to follow LICENSE file > > > Key: DISPATCH-858 > URL: https://issues.apache.org/jira/browse/DISPATCH-858 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Documentation >Affects Versions: 0.8.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Minor > > The LICENSE file is pretty large and not as clear as it could be when trying > to figure out which > bits apply to what and whether certain statements are sub-parts of > licence text referring to bits of their respective projects (that we > might not even include) as opposed to general statements about > Dispatch files. > Move third party text into files and point to these files from the LICENSE > file. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] qpid-dispatch pull request #212: DISPATCH-858 - Moved third party text into ...
GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/212 DISPATCH-858 - Moved third party text into files and point to these f⦠â¦iles from the LICENSE file. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-858 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/212.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #212 commit 14829e570a570824049dca91038b3b83ef74e350 Author: Ganesh Murthy Date: 2017-10-19T19:08:10Z DISPATCH-858 - Moved third party text into files and point to these files from the LICENSE file. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-858) Simplify hard to follow LICENSE file
[ https://issues.apache.org/jira/browse/DISPATCH-858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211563#comment-16211563 ] ASF GitHub Bot commented on DISPATCH-858: - GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/212 DISPATCH-858 - Moved third party text into files and point to these f… …iles from the LICENSE file. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-858 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/212.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #212 commit 14829e570a570824049dca91038b3b83ef74e350 Author: Ganesh Murthy Date: 2017-10-19T19:08:10Z DISPATCH-858 - Moved third party text into files and point to these files from the LICENSE file. > Simplify hard to follow LICENSE file > > > Key: DISPATCH-858 > URL: https://issues.apache.org/jira/browse/DISPATCH-858 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Documentation >Affects Versions: 0.8.0 >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Minor > > The LICENSE file is pretty large and not as clear as it could be when trying > to figure out which > bits apply to what and whether certain statements are sub-parts of > licence text referring to bits of their respective projects (that we > might not even include) as opposed to general statements about > Dispatch files. > Move third party text into files and point to these files from the LICENSE > file. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-1640) ruby-data-spec test fails on Raspbian Stretch
Andrew Stitcher created PROTON-1640:
---
Summary: ruby-data-spec test fails on Raspbian Stretch
Key: PROTON-1640
URL: https://issues.apache.org/jira/browse/PROTON-1640
Project: Qpid Proton
Issue Type: Bug
Components: ruby-binding
Affects Versions: proton-c-0.18.0
Environment: Raspberry Pi 3
Raspbian Stretch
Reporter: Andrew Stitcher
Assignee: Alan Conway
Building/Testing 0.18 RC1:
The only problem is this failure in the ruby tests:
{noformat}
Start 19: ruby-data-spec
19: Test command: /usr/bin/ruby
"/home/andrew/Source/qpid-proton/qpid-proton-0.18.0
proton-c/bindings/ruby/spec/data_spec.rb" "-v"
19: Environment variables:
19:
PATH=/home/andrew/.cargo/bin:/home/andrew/.local/bin:/home/andrew/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/local/games:/usr/games:/home/andrew/Source/qpid-proton/qpid-proton-0.18.0/BLD/proton-c/bindings/ruby:/home/andrew/Source/qpid-proton/qpid-proton-0.18.0/BLD/proton-c
19:
RUBYLIB=:/home/andrew/Source/qpid-proton/qpid-proton-0.18.0/proton-c/bindings/ruby/lib:/home/andrew/Source/qpid-proton/qpid-proton-0.18.0/proton-c/bindings/ruby/tests:/home/andrew/Source/qpid-proton/qpid-proton-0.18.0/proton-c/bindings/ruby/spec:/home/andrew/Source/qpid-proton/qpid-proton-0.18.0/BLD/proton-c/bindings/ruby:/home/andrew/Source/qpid-proton/qpid-proton-0.18.0/BLD/proton-c
19: Test timeout computed to be: 1500
19: Run options: -v --seed 49451
19:
19: # Running:
19:
19: A data object#test_0028_raises an error on a negative ulong = 0.00 s = .
19: A data object#test_0031_raises an error on a null long = 0.00 s = .
19: A data object#test_0053_can hold a zero decimal128 = 0.00 s = .
19: A data object#test_0003_can hold a true boolean = 0.00 s = .
19: A data object#test_0056_raises an error on a malformed UUID = 0.00 s = .
19: A data object#test_0010_raises an error on a negative ushort = 0.00 s = .
19: A data object#test_0047_can hold a zero decimal32 = 0.00 s = .
19: A data object#test_0052_raises an error on a null decimal128 = 0.00 s = .
19: A data object#test_0065_can hold a described value = 0.00 s = .
19: A data object#test_0012_can hold a zero unsigned short = 0.00 s = .
19: A data object#test_0021_can hold a zero unsigned integer = 0.00 s = .
19: A data object#test_0035_can handle a negative timestamp = 0.00 s = .
19: A data object#test_0040_can hold a zero float = 0.00 s = .
19: A data object#test_0042_raise an error on a null double = 0.00 s = .
19: A data object#test_0069_can hold a list = 0.04 s = .
19: A data object#test_0037_can hold a timestamp = 0.00 s = .
19: A data object#test_0050_can hold a zero decimal64 = 0.00 s = .
19: A data object#test_0070_can hold a map = 0.09 s = .
19: A data object#test_0032_can have a zero long = 0.00 s = .
19: A data object#test_0007_can hold an unsigned byte = 0.00 s = .
19: A data object#test_0018_raises an error on a nil uint = 0.00 s = .
19: A data object#test_0067_can hold an array = 0.00 s = .
19: A data object#test_0054_can hold a decimal128 = 0.00 s = .
19: A data object#test_0026_can hold a character = 0.00 s = .
19: A data object#test_0017_can hold a negative short = 0.00 s = .
19: A data object#test_0036_can handle a zero timestamp = 0.00 s = .
19: A data object#test_0059_can hold a null binary = 0.00 s = .
19: A data object#test_0068_can hold a described array = 0.03 s = .
19: A data object#test_0015_can hold a short = 0.00 s = .
19: A data object#test_0048_can hold a decimal32 = 0.00 s = F
19: A data object#test_0011_raises an error on a nil ushort = 0.00 s = .
19: A data object#test_0063_can hold a null symbol = 0.00 s = .
19: A data object#test_0020_can hold an unsigned integer = 0.00 s = .
19: A data object#test_0004_can hold a false boolean = 0.00 s = .
19: A data object#test_0014_raises an error on a nil short = 0.00 s = .
19: A data object#test_0058_can hold a UUID = 0.00 s = .
19: A data object#test_0045_can hold a double = 0.00 s = .
19: A data object#test_0013_can hold an unsigned short = 0.00 s = .
19: A data object#test_0005_raises an error on a negative ubyte = 0.00 s = .
19: A data object#test_0055_raises an error on a null UUID = 0.00 s = .
19: A data object#test_0046_raises an error on a null decimal32 = 0.00 s = F
19: A data object#test_0019_raises an error on a negative uint = 0.00 s = .
19: A data object#test_0025_raises an error on a null characte
[GitHub] qpid-dispatch issue #212: DISPATCH-858 - Moved third party text into files a...
Github user ganeshmurthy commented on the issue: https://github.com/apache/qpid-dispatch/pull/212 @gemmellr please take a look at this PR and critique it. Thanks. --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (DISPATCH-858) Simplify hard to follow LICENSE file
Ganesh Murthy created DISPATCH-858: -- Summary: Simplify hard to follow LICENSE file Key: DISPATCH-858 URL: https://issues.apache.org/jira/browse/DISPATCH-858 Project: Qpid Dispatch Issue Type: Improvement Components: Documentation Affects Versions: 0.8.0 Reporter: Ganesh Murthy Assignee: Ganesh Murthy Priority: Minor The LICENSE file is pretty large and not as clear as it could be when trying to figure out which bits apply to what and whether certain statements are sub-parts of licence text referring to bits of their respective projects (that we might not even include) as opposed to general statements about Dispatch files. Move third party text into files and point to these files from the LICENSE file. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-209) Three+ router test is needed in the system test suite.
[ https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211486#comment-16211486 ] ASF subversion and git services commented on DISPATCH-209: -- Commit c895d1c440e9ad24d1ae4415f27e5f26ee26357e in qpid-dispatch's branch refs/heads/master from [~mgoulish] [ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=c895d1c ] DISPATCH-209 : parallel waypoint test > Three+ router test is needed in the system test suite. > -- > > Key: DISPATCH-209 > URL: https://issues.apache.org/jira/browse/DISPATCH-209 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Tests >Reporter: Ted Ross >Assignee: michael goulish > Fix For: 1.0.0 > > > There have arisen some issues that would have been caught had there been a > three-router test in the regression suite. This test should be added. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (DISPATCH-781) Tie end-to-end flow control of message-routed deliveries to outgoing capacity
[ https://issues.apache.org/jira/browse/DISPATCH-781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Ross updated DISPATCH-781: -- Fix Version/s: 1.1.0 > Tie end-to-end flow control of message-routed deliveries to outgoing capacity > - > > Key: DISPATCH-781 > URL: https://issues.apache.org/jira/browse/DISPATCH-781 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node, Routing Engine >Reporter: Ted Ross >Assignee: Ted Ross > Fix For: 1.1.0 > > > This feature reverses the management of incoming credit for message-routed > deliveries. > The current mechanism is based on the the capacity of the incoming > (sender-client) links. Each attached sender is given credit equal to the > configured link capacity regardless of the capacity of outgoing > (receiver-client) links for the same address. This means that even under > congestion, a newly attached sender will get full capacity credit to send. > The proposed mechanism is based not on incoming capacity but on outgoing > capacity. In this case, the senders are provided a share of the total > outgoing capacity for an address. As the number of incoming links (senders) > for an address changes and the total capacity for outgoing links changes, the > credit window of the senders shall be adjusted. > The proposal is a heuristic approach. It does not revoke credit from senders > (but will limit the number of credits that are replenished). It will also > not deny credit if there are more incoming links than outgoing capacity. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1639) proton.c ipv6 test does not detect lack of ipv6 support
[ https://issues.apache.org/jira/browse/PROTON-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211382#comment-16211382 ] Alan Conway commented on PROTON-1639: - This is an error handling bug in the epoll proatctor, in a release build there is an assertion triggered. > proton.c ipv6 test does not detect lack of ipv6 support > --- > > Key: PROTON-1639 > URL: https://issues.apache.org/jira/browse/PROTON-1639 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.17.0 >Reporter: Alan Conway >Assignee: Alan Conway > Fix For: proton-c-0.18.0 > > > This test tries to listen on the ipv6 "::" undefined address, and expects > that to fail if ipv6 is not supported, in which case it skips the remaining > ipv6 tests. However this has been broken at some point as the listen attempt > claims to succeed even if ipv6 has been disabled. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (PROTON-1639) proton.c ipv6 test does not detect lack of ipv6 support
Alan Conway created PROTON-1639: --- Summary: proton.c ipv6 test does not detect lack of ipv6 support Key: PROTON-1639 URL: https://issues.apache.org/jira/browse/PROTON-1639 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.17.0 Reporter: Alan Conway Assignee: Alan Conway Fix For: proton-c-0.18.0 This test tries to listen on the ipv6 "::" undefined address, and expects that to fail if ipv6 is not supported, in which case it skips the remaining ipv6 tests. However this has been broken at some point as the listen attempt claims to succeed even if ipv6 has been disabled. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
proton-c release and Go binding updates
I've come to realise that people using the proton-c Go binding via 'go get' can be making direct use of the content from the "go1" branch of the proton repository. Some updates were just pushed to the branch bringing it up to date with master, effectively 0.18.0 rc1 from yesterday plus some cosmetic changes like comments and clarified parameter names. Since 0.18.0 is still under vote this shouldnt be the case if the go1 branch contents are so directly related to what a regular Go user ends up using (i.e not someone following development and deliberately aiming to use development content). If thats the case, then the branch needs to hold the content of a release and only be updated after an associated release vote has passed. Robbie - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPID-7974) JdbcUtils.TableExists is very slow on big databases such as Oracle
[ https://issues.apache.org/jira/browse/QPID-7974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy resolved QPID-7974. -- Resolution: Fixed Changes look reasonable to me > JdbcUtils.TableExists is very slow on big databases such as Oracle > -- > > Key: QPID-7974 > URL: https://issues.apache.org/jira/browse/QPID-7974 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Affects Versions: qpid-java-6.1.4 >Reporter: Adel Boutros >Assignee: Rob Godfrey > Fix For: qpid-java-broker-7.0.0 > > > The problem is that JdbcUtils.tableExists will actually load all tables and > then iterate to find the correct one. On Oracle, this can be around 40 000 > tables. So it will take 12 minutes for the broker to start. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7799) Broker should be able to write a periodic dump of statistics
[ https://issues.apache.org/jira/browse/QPID-7799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210960#comment-16210960 ] Keith Wall commented on QPID-7799: -- Additional look okay to me. > Broker should be able to write a periodic dump of statistics > > > Key: QPID-7799 > URL: https://issues.apache.org/jira/browse/QPID-7799 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-broker-7.0.0 > > Attachments: > 0001-QPID-7799-Java-Broker-Improve-statistics-reporting.patch > > > To assist those running a service, the Broker should have the ability to > write a periodic dump of ConiguredObject statistics to the log file. It > should be possible to configure the statistics dumped at runtime and be > configured on a per-category or per-object instance basis. Within a HA > group, the configuration applied to objects belonging to a virtualhost must > survive a mastership change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPID-7799) Broker should be able to write a periodic dump of statistics
[ https://issues.apache.org/jira/browse/QPID-7799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall resolved QPID-7799. -- Resolution: Fixed > Broker should be able to write a periodic dump of statistics > > > Key: QPID-7799 > URL: https://issues.apache.org/jira/browse/QPID-7799 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Assignee: Keith Wall > Fix For: qpid-java-broker-7.0.0 > > Attachments: > 0001-QPID-7799-Java-Broker-Improve-statistics-reporting.patch > > > To assist those running a service, the Broker should have the ability to > write a periodic dump of ConiguredObject statistics to the log file. It > should be possible to configure the statistics dumped at runtime and be > configured on a per-category or per-object instance basis. Within a HA > group, the configuration applied to objects belonging to a virtualhost must > survive a mastership change. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1611) cmake fails if g++ not installed
[ https://issues.apache.org/jira/browse/PROTON-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210946#comment-16210946 ] ASF subversion and git services commented on PROTON-1611: - Commit ab97f488a3690afa36852602f3b91da7752ea56f in qpid-proton's branch refs/heads/go1 from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=ab97f48 ] PROTON-1611: Always enable building C++ binding - There is no proper way to discover if there is a C++ compiler except enable_language(CXX) which has no way to fail and allow the rest of the build to carry on. > cmake fails if g++ not installed > > > Key: PROTON-1611 > URL: https://issues.apache.org/jira/browse/PROTON-1611 > Project: Qpid Proton > Issue Type: Bug > Components: build, cpp-binding >Affects Versions: proton-c-0.18.0 > Environment: "clean" centos docker image docker.io/centos:latest >Reporter: Ken Giusti >Assignee: Andrew Stitcher > Fix For: proton-c-0.18.0 > > > While testing the 0.18 proton beta I created a stock centos docker container > and followed the instructions in the INSTALL.md file, installing all the > documented dependencies. > cmake failed with: > cmake .. -DCMAKE_INSTALL_PREFIX=/usr > CMake Error at /usr/share/cmake/Modules/CMakeDetermineCompilerId.cmake:446 > (execute_process): > execute_process given COMMAND argument with no value. > Call Stack (most recent call first): > /usr/share/cmake/Modules/CMakeDetermineCompilerId.cmake:48 > (CMAKE_DETERMINE_COMPILER_ID_VENDOR) > /usr/share/cmake/Modules/CMakeDetermineCXXCompiler.cmake:127 > (CMAKE_DETERMINE_COMPILER_ID) > CMakeLists.txt:24 (enable_language) > -- The CXX compiler identification is unknown > -- Build type is "RelWithDebInfo" (has debug symbols) > -- PN_VERSION: 0.18.0 (beta) > -- Can't locate the valgrind command; no run-time error detection > -- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) > -- Building the epoll proactor > -- Node.js (http://nodejs.org) is not installed: can't build JavaScript > binding > -- Could NOT find Ruby (missing: RUBY_EXECUTABLE RUBY_INCLUDE_DIR > RUBY_LIBRARY) > -- Could NOT find Perl (missing: PERL_EXECUTABLE) > -- Could NOT find Perl (missing: PERL_EXECUTABLE) > -- Could NOT find PerlLibs (missing: PERL_LIBRARY PERL_INCLUDE_PATH) > -- Trying alternative search for Perl > -- Looking for > -- No Perl devel environment found - skipping Perl bindings > -- The tox tool is not available; skipping the python-tox-tests > -- Configuring incomplete, errors occurred! > See also "/root/qpid-proton-0.18.0-beta/BUILD/CMakeFiles/CMakeOutput.log". > See also "/root/qpid-proton-0.18.0-beta/BUILD/CMakeFiles/CMakeError.log". > Had to ' yum install gcc-c++' in order to get cmake generation to succeed. > Either the INSTALL.md needs to list gcc-c++ for a required dep, or the cmake > scripts need to avoid building the c++ binding if no c++ compiler is > installed. > Did not test but suspect ubuntu build may fail in a similar fashion. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1635) Does not build with gcc 4.4.7
[ https://issues.apache.org/jira/browse/PROTON-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210948#comment-16210948 ] ASF subversion and git services commented on PROTON-1635: - Commit c7f593e5774309e0d62caf647dda977eb0c6417c in qpid-proton's branch refs/heads/go1 from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=c7f593e ] PROTON-1635: [C++ binding] Building with gcc 4.4.7 Gcc 4.4.7 is not a full C++11 compiler, but does have some features - in particular threads and mutex. The following fixes were needed: - new-style C++ loops - lack of std::thread move ctor - lack of copy ctor on proton::03::work - deprecated attribute can't have a message > Does not build with gcc 4.4.7 > - > > Key: PROTON-1635 > URL: https://issues.apache.org/jira/browse/PROTON-1635 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding >Affects Versions: proton-c-0.18.0 >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > Fix For: proton-c-0.18.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1611) cmake fails if g++ not installed
[ https://issues.apache.org/jira/browse/PROTON-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210947#comment-16210947 ] ASF subversion and git services commented on PROTON-1611: - Commit 2e9412ca5dfd4393e16928c882680b0ed92d0c7a in qpid-proton's branch refs/heads/go1 from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=2e9412c ] PROTON-1611: Enable C++ at top level of build - Change installation to say that C++ is actually required for build > cmake fails if g++ not installed > > > Key: PROTON-1611 > URL: https://issues.apache.org/jira/browse/PROTON-1611 > Project: Qpid Proton > Issue Type: Bug > Components: build, cpp-binding >Affects Versions: proton-c-0.18.0 > Environment: "clean" centos docker image docker.io/centos:latest >Reporter: Ken Giusti >Assignee: Andrew Stitcher > Fix For: proton-c-0.18.0 > > > While testing the 0.18 proton beta I created a stock centos docker container > and followed the instructions in the INSTALL.md file, installing all the > documented dependencies. > cmake failed with: > cmake .. -DCMAKE_INSTALL_PREFIX=/usr > CMake Error at /usr/share/cmake/Modules/CMakeDetermineCompilerId.cmake:446 > (execute_process): > execute_process given COMMAND argument with no value. > Call Stack (most recent call first): > /usr/share/cmake/Modules/CMakeDetermineCompilerId.cmake:48 > (CMAKE_DETERMINE_COMPILER_ID_VENDOR) > /usr/share/cmake/Modules/CMakeDetermineCXXCompiler.cmake:127 > (CMAKE_DETERMINE_COMPILER_ID) > CMakeLists.txt:24 (enable_language) > -- The CXX compiler identification is unknown > -- Build type is "RelWithDebInfo" (has debug symbols) > -- PN_VERSION: 0.18.0 (beta) > -- Can't locate the valgrind command; no run-time error detection > -- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) > -- Building the epoll proactor > -- Node.js (http://nodejs.org) is not installed: can't build JavaScript > binding > -- Could NOT find Ruby (missing: RUBY_EXECUTABLE RUBY_INCLUDE_DIR > RUBY_LIBRARY) > -- Could NOT find Perl (missing: PERL_EXECUTABLE) > -- Could NOT find Perl (missing: PERL_EXECUTABLE) > -- Could NOT find PerlLibs (missing: PERL_LIBRARY PERL_INCLUDE_PATH) > -- Trying alternative search for Perl > -- Looking for > -- No Perl devel environment found - skipping Perl bindings > -- The tox tool is not available; skipping the python-tox-tests > -- Configuring incomplete, errors occurred! > See also "/root/qpid-proton-0.18.0-beta/BUILD/CMakeFiles/CMakeOutput.log". > See also "/root/qpid-proton-0.18.0-beta/BUILD/CMakeFiles/CMakeError.log". > Had to ' yum install gcc-c++' in order to get cmake generation to succeed. > Either the INSTALL.md needs to list gcc-c++ for a required dep, or the cmake > scripts need to avoid building the c++ binding if no c++ compiler is > installed. > Did not test but suspect ubuntu build may fail in a similar fashion. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1633) Windows Link warnings due to unnecessary command line flags
[ https://issues.apache.org/jira/browse/PROTON-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210945#comment-16210945 ] ASF subversion and git services commented on PROTON-1633: - Commit 0c992c98409e7dca8533b55649a866a9e9429781 in qpid-proton's branch refs/heads/go1 from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=0c992c9 ] PROTON-1633: Get rid of incorrect link flags > Windows Link warnings due to unnecessary command line flags > --- > > Key: PROTON-1633 > URL: https://issues.apache.org/jira/browse/PROTON-1633 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: proton-c-0.18.0 > Environment: Visual Studio >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > Fix For: proton-c-0.18.0 > > > We are explicitly putting compile flags on the link line and this is > generating pointless and distracting warnings. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1625) [c, examples] receiver does not dispose of aborted message data
[ https://issues.apache.org/jira/browse/PROTON-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210950#comment-16210950 ] ASF subversion and git services commented on PROTON-1625: - Commit 8d062b75376d350543a2ba0bc3b581c7f75757db in qpid-proton's branch refs/heads/go1 from [~chug] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=8d062b7 ] Revert "PROTON-1625: flush received data from aborted messages" This reverts commit b9d64d66c2851e005279fa78f770eed75407536d. > [c, examples] receiver does not dispose of aborted message data > --- > > Key: PROTON-1625 > URL: https://issues.apache.org/jira/browse/PROTON-1625 > Project: Qpid Proton > Issue Type: Bug > Components: examples, proton-c >Affects Versions: proton-c-0.18.0 >Reporter: Chuck Rolke >Assignee: Chuck Rolke > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-1633) Windows Link warnings due to unnecessary command line flags
[ https://issues.apache.org/jira/browse/PROTON-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210949#comment-16210949 ] ASF subversion and git services commented on PROTON-1633: - Commit 89c8b5fa0b4f529b3e2c27434c02f29a7afdaac0 in qpid-proton's branch refs/heads/go1 from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=89c8b5f ] PROTON-1633: Need to allow examples to link with special flags to get sanitizers to work > Windows Link warnings due to unnecessary command line flags > --- > > Key: PROTON-1633 > URL: https://issues.apache.org/jira/browse/PROTON-1633 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: proton-c-0.18.0 > Environment: Visual Studio >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > Fix For: proton-c-0.18.0 > > > We are explicitly putting compile flags on the link line and this is > generating pointless and distracting warnings. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7832) Refactor store/protocol API using Collection
[ https://issues.apache.org/jira/browse/QPID-7832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210939#comment-16210939 ] ASF subversion and git services commented on QPID-7832: --- Commit e9e0e74e7b23587fbc384aaf03250a3c3e0c7624 in qpid-broker-j's branch refs/heads/master from [~k-wall] [ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=e9e0e74 ] QPID-7832: Fix infinite recursion when handling an AMQP1.0 message encoded in the version 0 format. Fixes regression introduced by 660c206deb352aca3694a6b31f5f7cf6fca70533 End to end test added. > Refactor store/protocol API using Collection > - > > Key: QPID-7832 > URL: https://issues.apache.org/jira/browse/QPID-7832 > Project: Qpid > Issue Type: Improvement > Components: Java Broker >Reporter: Keith Wall >Priority: Minor > Fix For: qpid-java-broker-7.0.0 > > Attachments: > 0001-QPID-7832-Java-Broker-Refactor-store-protocol-API-us.patch > > > Store/protocol APIs have gradually been evolving to accept/return message > content/message metadata in terms of an ordered list of QBBs. This has lead > to use of helper methods such as those in QBBUtils which read from a list of > buffers rather than a single one. > This would be better refactored. QpidByteBuffer should be an interface. > This would allow a concrete implementation CompositeQpidByteBuffer which is > backed by a list produced by the store or network IO. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPID-7979) [Java Broker] [JDBCMessageStore] Some exception causes are hidden
[ https://issues.apache.org/jira/browse/QPID-7979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy resolved QPID-7979. -- Resolution: Fixed Changes look good to me > [Java Broker] [JDBCMessageStore] Some exception causes are hidden > - > > Key: QPID-7979 > URL: https://issues.apache.org/jira/browse/QPID-7979 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Reporter: Keith Wall >Priority: Minor > Fix For: qpid-java-broker-7.0.0 > > > As reported in this thread, there is one place in the the JDBC code that, > when wrapping a SQLException, fails to include the original exception as an > initial cause. > http://qpid.2158936.n2.nabble.com/Qpid-Java-Broker-6-1-4-Some-expections-are-hidden-td7668030.html -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPID-7965) [Java Broker] Centralise setting of connection properties, and allow pluggable enrichment
[
https://issues.apache.org/jira/browse/QPID-7965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy resolved QPID-7965.
--
Resolution: Fixed
The changes look good to me, though, in
{{StandardConnectionPropertyEnricher#addConnectionProperties}} for switch
default case I would log warning or throw an exception. Taking that new
protocol support will not be added anytime soon, I am fine with the code in its
current state
> [Java Broker] Centralise setting of connection properties, and allow
> pluggable enrichment
> -
>
> Key: QPID-7965
> URL: https://issues.apache.org/jira/browse/QPID-7965
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
>Reporter: Rob Godfrey
>Assignee: Rob Godfrey
> Attachments: QPID-7965.diff
>
>
> Currently the setting of connection properties is done differently for each
> protocol version, with much overlap. We could centralise these into a common
> service; and also allow for the configuration of pluggable property
> enrichment (to allow users to set custom properties for their broker which
> will be meaningful for their clients).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-7910) [Java Broker] Improve qpid.stop script
[
https://issues.apache.org/jira/browse/QPID-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy updated QPID-7910:
-
Status: Reviewable (was: In Progress)
> [Java Broker] Improve qpid.stop script
> --
>
> Key: QPID-7910
> URL: https://issues.apache.org/jira/browse/QPID-7910
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Minor
> Fix For: qpid-java-broker-7.0.0
>
> Attachments: qpid-stop, qpid-stop
>
>
> Java Broker qpid.stop needs improvements:
> * it currently tries to send SIGTERM and SIGKILL commands twice. It is
> superfluous. Sending event once should be sufficient.
> * we can use {{kill -0}} to verify the process instead of using ps
> * make {{$SLEEP_DELAY}} overridable from command line
> * script should be able to wait until Qpid processes are killed before exiting
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7910) [Java Broker] Improve qpid.stop script
[
https://issues.apache.org/jira/browse/QPID-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210873#comment-16210873
]
ASF subversion and git services commented on QPID-7910:
---
Commit 331c7276aadae28ae046ca0b5165934d47d72720 in qpid-broker-j's branch
refs/heads/master from [~alex.rufous]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=331c727 ]
QPID-7910: [Java Broker] Improve qpid stop script
> [Java Broker] Improve qpid.stop script
> --
>
> Key: QPID-7910
> URL: https://issues.apache.org/jira/browse/QPID-7910
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Minor
> Fix For: qpid-java-broker-7.0.0
>
> Attachments: qpid-stop, qpid-stop
>
>
> Java Broker qpid.stop needs improvements:
> * it currently tries to send SIGTERM and SIGKILL commands twice. It is
> superfluous. Sending event once should be sufficient.
> * we can use {{kill -0}} to verify the process instead of using ps
> * make {{$SLEEP_DELAY}} overridable from command line
> * script should be able to wait until Qpid processes are killed before exiting
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (QPID-7910) [Java Broker] Improve qpid.stop script
[
https://issues.apache.org/jira/browse/QPID-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy reassigned QPID-7910:
Assignee: Alex Rudyy
> [Java Broker] Improve qpid.stop script
> --
>
> Key: QPID-7910
> URL: https://issues.apache.org/jira/browse/QPID-7910
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
>Reporter: Alex Rudyy
>Assignee: Alex Rudyy
>Priority: Minor
> Fix For: qpid-java-broker-7.0.0
>
> Attachments: qpid-stop, qpid-stop
>
>
> Java Broker qpid.stop needs improvements:
> * it currently tries to send SIGTERM and SIGKILL commands twice. It is
> superfluous. Sending event once should be sufficient.
> * we can use {{kill -0}} to verify the process instead of using ps
> * make {{$SLEEP_DELAY}} overridable from command line
> * script should be able to wait until Qpid processes are killed before exiting
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7910) [Java Broker] Improve qpid.stop script
[
https://issues.apache.org/jira/browse/QPID-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210864#comment-16210864
]
Alex Rudyy commented on QPID-7910:
--
Attached final script version which I am going to commit.
The changes include:
* only current user processes are killed
* waiting for terminated processes is limited to 1hour
> [Java Broker] Improve qpid.stop script
> --
>
> Key: QPID-7910
> URL: https://issues.apache.org/jira/browse/QPID-7910
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
>Reporter: Alex Rudyy
>Priority: Minor
> Fix For: qpid-java-broker-7.0.0
>
> Attachments: qpid-stop, qpid-stop
>
>
> Java Broker qpid.stop needs improvements:
> * it currently tries to send SIGTERM and SIGKILL commands twice. It is
> superfluous. Sending event once should be sufficient.
> * we can use {{kill -0}} to verify the process instead of using ps
> * make {{$SLEEP_DELAY}} overridable from command line
> * script should be able to wait until Qpid processes are killed before exiting
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-7910) [Java Broker] Improve qpid.stop script
[
https://issues.apache.org/jira/browse/QPID-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy updated QPID-7910:
-
Attachment: qpid-stop
> [Java Broker] Improve qpid.stop script
> --
>
> Key: QPID-7910
> URL: https://issues.apache.org/jira/browse/QPID-7910
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
>Reporter: Alex Rudyy
>Priority: Minor
> Fix For: qpid-java-broker-7.0.0
>
> Attachments: qpid-stop, qpid-stop
>
>
> Java Broker qpid.stop needs improvements:
> * it currently tries to send SIGTERM and SIGKILL commands twice. It is
> superfluous. Sending event once should be sufficient.
> * we can use {{kill -0}} to verify the process instead of using ps
> * make {{$SLEEP_DELAY}} overridable from command line
> * script should be able to wait until Qpid processes are killed before exiting
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7910) [Java Broker] Improve qpid.stop script
[
https://issues.apache.org/jira/browse/QPID-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210856#comment-16210856
]
Adel Boutros commented on QPID-7910:
Sounds reasonable to me :)
> [Java Broker] Improve qpid.stop script
> --
>
> Key: QPID-7910
> URL: https://issues.apache.org/jira/browse/QPID-7910
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
>Reporter: Alex Rudyy
>Priority: Minor
> Fix For: qpid-java-broker-7.0.0
>
> Attachments: qpid-stop
>
>
> Java Broker qpid.stop needs improvements:
> * it currently tries to send SIGTERM and SIGKILL commands twice. It is
> superfluous. Sending event once should be sufficient.
> * we can use {{kill -0}} to verify the process instead of using ps
> * make {{$SLEEP_DELAY}} overridable from command line
> * script should be able to wait until Qpid processes are killed before exiting
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7910) [Java Broker] Improve qpid.stop script
[
https://issues.apache.org/jira/browse/QPID-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210830#comment-16210830
]
Alex Rudyy commented on QPID-7910:
--
Adel,
I uploaded a new version of the script allowing to specify multiple pids from
command line.
I also removed references to "org.apache.qpid.server.Main" and replaced them
with old style PNAME search string for backward compatibility. The search
string can be set via environment variable in similar way as in older script.
I am going to make further changes to restricts broker process to current user.
Though, I think it is not necessary, as attempt to kill the process without
permissions would end-up in kill returning non-zero exit code. The script only
waits for processes if kill TERM is successful.
If kill TERM will not terminate the process, the script would be looping
indefinitely. Potentially, I can modify the script to wait for some arbitrary
timeout like 1hour if it is required. Though, if script takes long time to
execute, that might require operator intervention anyway. Operator would need
to investigate and kill broker and stop script. What do you think?
> [Java Broker] Improve qpid.stop script
> --
>
> Key: QPID-7910
> URL: https://issues.apache.org/jira/browse/QPID-7910
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
>Reporter: Alex Rudyy
>Priority: Minor
> Fix For: qpid-java-broker-7.0.0
>
> Attachments: qpid-stop
>
>
> Java Broker qpid.stop needs improvements:
> * it currently tries to send SIGTERM and SIGKILL commands twice. It is
> superfluous. Sending event once should be sufficient.
> * we can use {{kill -0}} to verify the process instead of using ps
> * make {{$SLEEP_DELAY}} overridable from command line
> * script should be able to wait until Qpid processes are killed before exiting
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-7910) [Java Broker] Improve qpid.stop script
[
https://issues.apache.org/jira/browse/QPID-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy updated QPID-7910:
-
Attachment: (was: qpid-stop)
> [Java Broker] Improve qpid.stop script
> --
>
> Key: QPID-7910
> URL: https://issues.apache.org/jira/browse/QPID-7910
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
>Reporter: Alex Rudyy
>Priority: Minor
> Fix For: qpid-java-broker-7.0.0
>
> Attachments: qpid-stop
>
>
> Java Broker qpid.stop needs improvements:
> * it currently tries to send SIGTERM and SIGKILL commands twice. It is
> superfluous. Sending event once should be sufficient.
> * we can use {{kill -0}} to verify the process instead of using ps
> * make {{$SLEEP_DELAY}} overridable from command line
> * script should be able to wait until Qpid processes are killed before exiting
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-7910) [Java Broker] Improve qpid.stop script
[
https://issues.apache.org/jira/browse/QPID-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Rudyy updated QPID-7910:
-
Attachment: qpid-stop
> [Java Broker] Improve qpid.stop script
> --
>
> Key: QPID-7910
> URL: https://issues.apache.org/jira/browse/QPID-7910
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
>Reporter: Alex Rudyy
>Priority: Minor
> Fix For: qpid-java-broker-7.0.0
>
> Attachments: qpid-stop, qpid-stop
>
>
> Java Broker qpid.stop needs improvements:
> * it currently tries to send SIGTERM and SIGKILL commands twice. It is
> superfluous. Sending event once should be sufficient.
> * we can use {{kill -0}} to verify the process instead of using ps
> * make {{$SLEEP_DELAY}} overridable from command line
> * script should be able to wait until Qpid processes are killed before exiting
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7910) [Java Broker] Improve qpid.stop script
[
https://issues.apache.org/jira/browse/QPID-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210784#comment-16210784
]
Adel Boutros commented on QPID-7910:
Thanks [~alex.rufous],
I have some questions, remarks:
# Shouldn't we limit the stop to the current user's processes? (What would
happen if he tries to kill a broker which he cannot kill due to lack of
permissions?)
# I don't think we need to distinguish between single process or multiple ones
(lines 31 and 32 can be grouped with the one on line 34)
# Can you please refactor the duplicated "org.apache.qpid.server.Main" and
store it in a variable?
# If kill never succeeds in killing the broker, the script will be looping
indefinitely. Is this the expected behavior?
Regards,
Adel
> [Java Broker] Improve qpid.stop script
> --
>
> Key: QPID-7910
> URL: https://issues.apache.org/jira/browse/QPID-7910
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
>Reporter: Alex Rudyy
>Priority: Minor
> Fix For: qpid-java-broker-7.0.0
>
> Attachments: qpid-stop
>
>
> Java Broker qpid.stop needs improvements:
> * it currently tries to send SIGTERM and SIGKILL commands twice. It is
> superfluous. Sending event once should be sufficient.
> * we can use {{kill -0}} to verify the process instead of using ps
> * make {{$SLEEP_DELAY}} overridable from command line
> * script should be able to wait until Qpid processes are killed before exiting
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPID-7973) Table Name Prefix is set to NULL if no prefix is provided instead of empty String
[ https://issues.apache.org/jira/browse/QPID-7973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall resolved QPID-7973. -- Resolution: Fixed > Table Name Prefix is set to NULL if no prefix is provided instead of empty > String > - > > Key: QPID-7973 > URL: https://issues.apache.org/jira/browse/QPID-7973 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: qpid-java-6.1.4 >Reporter: Adel Boutros >Assignee: Rob Godfrey > Fix For: qpid-java-broker-7.0.0 > > > If the user provides no TableNamePrefix, then it is set to null whereas it > should be set to empty string -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7973) Table Name Prefix is set to NULL if no prefix is provided instead of empty String
[ https://issues.apache.org/jira/browse/QPID-7973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210706#comment-16210706 ] Keith Wall commented on QPID-7973: -- Okay I understand now, thanks for the explanation. > Table Name Prefix is set to NULL if no prefix is provided instead of empty > String > - > > Key: QPID-7973 > URL: https://issues.apache.org/jira/browse/QPID-7973 > Project: Qpid > Issue Type: Bug > Components: Java Broker >Affects Versions: qpid-java-6.1.4 >Reporter: Adel Boutros >Assignee: Rob Godfrey > Fix For: qpid-java-broker-7.0.0 > > > If the user provides no TableNamePrefix, then it is set to null whereas it > should be set to empty string -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (QPID-7979) [Java Broker] [JDBCMessageStore] Some exception causes are hidden
[
https://issues.apache.org/jira/browse/QPID-7979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210693#comment-16210693
]
Keith Wall edited comment on QPID-7979 at 10/19/17 7:30 AM:
For the record, I also took a look at all {{catch(SQLException)}} on master at
the moment. This was the only offender.
was (Author: k-wall):
For the record, I also took a look at all {catch (SQLException..}s on master at
the moment. This was the only one offender.
> [Java Broker] [JDBCMessageStore] Some exception causes are hidden
> -
>
> Key: QPID-7979
> URL: https://issues.apache.org/jira/browse/QPID-7979
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
>Reporter: Keith Wall
>Priority: Minor
> Fix For: qpid-java-broker-7.0.0
>
>
> As reported in this thread, there is one place in the the JDBC code that,
> when wrapping a SQLException, fails to include the original exception as an
> initial cause.
> http://qpid.2158936.n2.nabble.com/Qpid-Java-Broker-6-1-4-Some-expections-are-hidden-td7668030.html
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Comment Edited] (QPID-7979) [Java Broker] [JDBCMessageStore] Some exception causes are hidden
[
https://issues.apache.org/jira/browse/QPID-7979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210693#comment-16210693
]
Keith Wall edited comment on QPID-7979 at 10/19/17 7:29 AM:
For the record, I also took a look at all {catch (SQLException..}s on master at
the moment. This was the only one offender.
was (Author: k-wall):
For the record, I also took a look at all {{catch (SQLException..}}s on master
at the moment. This was the only one offender.
> [Java Broker] [JDBCMessageStore] Some exception causes are hidden
> -
>
> Key: QPID-7979
> URL: https://issues.apache.org/jira/browse/QPID-7979
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
>Reporter: Keith Wall
>Priority: Minor
> Fix For: qpid-java-broker-7.0.0
>
>
> As reported in this thread, there is one place in the the JDBC code that,
> when wrapping a SQLException, fails to include the original exception as an
> initial cause.
> http://qpid.2158936.n2.nabble.com/Qpid-Java-Broker-6-1-4-Some-expections-are-hidden-td7668030.html
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPID-7979) [Java Broker] [JDBCMessageStore] Some exception causes are hidden
[
https://issues.apache.org/jira/browse/QPID-7979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210693#comment-16210693
]
Keith Wall commented on QPID-7979:
--
For the record, I also took a look at all {{catch (SQLException..}}s on master
at the moment. This was the only one offender.
> [Java Broker] [JDBCMessageStore] Some exception causes are hidden
> -
>
> Key: QPID-7979
> URL: https://issues.apache.org/jira/browse/QPID-7979
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
>Reporter: Keith Wall
>Priority: Minor
> Fix For: qpid-java-broker-7.0.0
>
>
> As reported in this thread, there is one place in the the JDBC code that,
> when wrapping a SQLException, fails to include the original exception as an
> initial cause.
> http://qpid.2158936.n2.nabble.com/Qpid-Java-Broker-6-1-4-Some-expections-are-hidden-td7668030.html
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
