[RESULT] [VOTE] Release 0.22 RC6 as 0.22 final
This vote is now closed. There were eight +1 votes, and no other votes. The vote has passed. Robbie (For anyone wondering in future, I am closing the vote as per Justin's request in: http://mail-archives.apache.org/mod_mbox/qpid-dev/201305.mbox/%3CCANVjZ_RUOzOf8WvBXbcGn7%3DthBmae96hY5%3D_SUWi%3D-GBqyncwA%40mail.gmail.com%3E) On 26 May 2013 11:35, Justin Ross wrote: > RC6 contains the proposed final bits for Qpid 0.22. > > If you favor making the RC6 bits into our official release, vote +1. > If you have reason to believe RC6 is not ready for release, vote -1. > > Thanks! > Justin > > - > To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org > For additional commands, e-mail: dev-h...@qpid.apache.org > >
Re: [VOTE] Release 0.22 RC6 as 0.22 final
+1 On 26 May 2013 11:35, Justin Ross wrote: > RC6 contains the proposed final bits for Qpid 0.22. > > If you favor making the RC6 bits into our official release, vote +1. > If you have reason to believe RC6 is not ready for release, vote -1. > > Thanks! > Justin > > - > To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org > For additional commands, e-mail: dev-h...@qpid.apache.org > >
Re: [VOTE] Release 0.22 RC6 as 0.22 final
On Sun, May 26, 2013 at 06:35:29AM -0400, Justin Ross wrote: > RC6 contains the proposed final bits for Qpid 0.22. > > If you favor making the RC6 bits into our official release, vote +1. > If you have reason to believe RC6 is not ready for release, vote -1. +1 Tested all packages (qpid-cpp, python-qpid, perl-qpid, rubygem-qpid_messaging), made sure all languages can exchange messages. -- Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc. Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/ pgpVy5LcXQ74Z.pgp Description: PGP signature
Re: [VOTE] Release 0.22 RC6 as 0.22 final
+1 On Sun, May 26, 2013 at 3:35 AM, Justin Ross wrote: > RC6 contains the proposed final bits for Qpid 0.22. > > If you favor making the RC6 bits into our official release, vote +1. > If you have reason to believe RC6 is not ready for release, vote -1. > > Thanks! > Justin > > - > To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org > For additional commands, e-mail: dev-h...@qpid.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: [VOTE] Release 0.22 RC6 as 0.22 final
+1 - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: [VOTE] Release 0.22 RC6 as 0.22 final
+1 On 26 May 2013 11:35, Justin Ross wrote: > RC6 contains the proposed final bits for Qpid 0.22. > > If you favor making the RC6 bits into our official release, vote +1. > If you have reason to believe RC6 is not ready for release, vote -1. > > Thanks! > Justin > > - > To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org > For additional commands, e-mail: dev-h...@qpid.apache.org > >
Re: [VOTE] Release 0.22 RC6 as 0.22 final
On Thu, May 30, 2013 at 11:00:15AM -0400, Andrew Stitcher wrote:
> On Thu, 2013-05-30 at 09:32 -0400, Darryl L. Pierce wrote:
> > ...
> > Ah, I see what you mean. This is how it's supposed to work. When
> > installing the bindings, those directories are determined by where the
> > language's site directories are located and not by the install prefix
> > set during the Cmake generation phase. This same case applies to Proton
> > as well.
>
> What you say is how proton works, and is arguably the "correct" way to
> do it - but unless we've changed something qpid does it (and has done
> it) the way Gordon expects.
>
> If you've changed all the bindings to consistently behave in the proton
> way this needs to be release noted as it will cause confusion, if it's
> not consistent then it's even worse!
The Python bindings are installed based on the ${PYTHON_SITEARCH_PACKAGES}
directory, which is defined by the CMakeLists.txt file in
$repo/qpid/cpp/bindings as:
execute_process(COMMAND ${PYTHON_EXECUTABLE}
-c "from distutils.sysconfig import g
OUTPUT_VARIABLE PYTHON_SITEARCH_PACKA
OUTPUT_STRIP_TRAILING_WHITESPACE)
This was added in QPID-3633:
QPID-3633: Make cmake the primary build tool for the cpp tree
Get Swigged bindings to install in the correct place
In the managementgen/CMakeLists.txt file it previously had its Python files
installing to /usr/local/managementgen, added by Stephen Huston on 23
April 2009 (merged from a different source). I changed those in April to
be the same as the Qpid Python bindings in April this year.
> DESTDIR does not perform the same function as CMAKE_INSTALL_PREFIX. The
> point of setting a local install directory for qpid and having the build
> not fail is so that you can build all the modules you need in the
> correct place for the server and client without having to mess around.
> If the install fails due to bindings not being installed this really
> messes this up, and The qpid build currently has no way of turning the
> bindings builds off.
Sorry, but I'm not suggesting that the two are the same. I was only
pointing out that, to install everything under one location, DESTDIR
can do that for a person.
--
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
pgpBxY36BuIe8.pgp
Description: PGP signature
Re: [VOTE] Release 0.22 RC6 as 0.22 final
On Thu, 2013-05-30 at 09:32 -0400, Darryl L. Pierce wrote: > ... > Ah, I see what you mean. This is how it's supposed to work. When > installing the bindings, those directories are determined by where the > language's site directories are located and not by the install prefix > set during the Cmake generation phase. This same case applies to Proton > as well. > What you say is how proton works, and is arguably the "correct" way to do it - but unless we've changed something qpid does it (and has done it) the way Gordon expects. If you've changed all the bindings to consistently behave in the proton way this needs to be release noted as it will cause confusion, if it's not consistent then it's even worse! DESTDIR does not perform the same function as CMAKE_INSTALL_PREFIX. The point of setting a local install directory for qpid and having the build not fail is so that you can build all the modules you need in the correct place for the server and client without having to mess around. If the install fails due to bindings not being installed this really messes this up, and The qpid build currently has no way of turning the bindings builds off. Andrew - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: [VOTE] Release 0.22 RC6 as 0.22 final
On 05/30/2013 02:32 PM, Darryl L. Pierce wrote: On Thu, May 30, 2013 at 01:57:48PM +0100, Gordon Sim wrote: Do you mean with using DESTDIR=$somedir ? Using CMAKE_INSTALL_PREFIX. I'm not seeing any install failures during packaging. The RPM packaging system uses a non-standard location to install the bits before generating the RPMs. I see: Install the project... -- Install configuration: "" -- Installing: /home/gordon/qpid-releases/0.22rc6/TEST_INSTALL/share/doc/qpid-cpp-0.22/LICENSE -- Installing: /home/gordon/qpid-releases/0.22rc6/TEST_INSTALL/share/doc/qpid-cpp-0.22/NOTICE -- Installing: /home/gordon/qpid-releases/0.22rc6/TEST_INSTALL/share/qpid/qpid/qpid.i -- Installing: /home/gordon/qpid-releases/0.22rc6/TEST_INSTALL/share/qpid/qpid/swig_perl_typemaps.i -- Installing: /home/gordon/qpid-releases/0.22rc6/TEST_INSTALL/share/qpid/qpid/swig_python_typemaps.i -- Installing: /home/gordon/qpid-releases/0.22rc6/TEST_INSTALL/share/qpid/qpid/swig_ruby_typemaps.i -- Installing: /home/gordon/qpid-releases/0.22rc6/TEST_INSTALL/include/qmf/qmfengine.i -- Installing: /home/gordon/qpid-releases/0.22rc6/TEST_INSTALL/include/qmf/qmf2.i -- Installing: /home/gordon/qpid-releases/0.22rc6/TEST_INSTALL/bin/qmf-gen CMake Error at managementgen/cmake_install.cmake:48 (FILE): file cannot create directory: /usr/lib/python2.7/site-packages/qmfgen. These seem not to get installed into my required location as are the earlier artefacts above. Maybe need administrative privileges. Call Stack (most recent call first): cmake_install.cmake:60 (INCLUDE) Ah, I see what you mean. This is how it's supposed to work. When installing the bindings, those directories are determined by where the language's site directories are located and not by the install prefix set during the Cmake generation phase. This same case applies to Proton as well. To control where the files are installed, it's not recommended to use the CMAKE_INSTALL_PREFIX but instead use DESTDIR=$someplace, which installs everything relative to that directory. Ok, I will do that. Thanks for the clarification! - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: [VOTE] Release 0.22 RC6 as 0.22 final
On Thu, May 30, 2013 at 01:57:48PM +0100, Gordon Sim wrote: > >Do you mean with using DESTDIR=$somedir ? > > Using CMAKE_INSTALL_PREFIX. > > >I'm not seeing any install failures during packaging. The RPM packaging > >system uses a non-standard location to install the bits before > >generating the RPMs. > > I see: > > >Install the project... > >-- Install configuration: "" > >-- Installing: > >/home/gordon/qpid-releases/0.22rc6/TEST_INSTALL/share/doc/qpid-cpp-0.22/LICENSE > >-- Installing: > >/home/gordon/qpid-releases/0.22rc6/TEST_INSTALL/share/doc/qpid-cpp-0.22/NOTICE > >-- Installing: > >/home/gordon/qpid-releases/0.22rc6/TEST_INSTALL/share/qpid/qpid/qpid.i > >-- Installing: > >/home/gordon/qpid-releases/0.22rc6/TEST_INSTALL/share/qpid/qpid/swig_perl_typemaps.i > >-- Installing: > >/home/gordon/qpid-releases/0.22rc6/TEST_INSTALL/share/qpid/qpid/swig_python_typemaps.i > >-- Installing: > >/home/gordon/qpid-releases/0.22rc6/TEST_INSTALL/share/qpid/qpid/swig_ruby_typemaps.i > >-- Installing: > >/home/gordon/qpid-releases/0.22rc6/TEST_INSTALL/include/qmf/qmfengine.i > >-- Installing: > >/home/gordon/qpid-releases/0.22rc6/TEST_INSTALL/include/qmf/qmf2.i > >-- Installing: /home/gordon/qpid-releases/0.22rc6/TEST_INSTALL/bin/qmf-gen > >CMake Error at managementgen/cmake_install.cmake:48 (FILE): > > file cannot create directory: /usr/lib/python2.7/site-packages/qmfgen. > > These seem not to get installed into my required location as are the > earlier artefacts above. > > > Maybe need administrative privileges. > >Call Stack (most recent call first): > > cmake_install.cmake:60 (INCLUDE) Ah, I see what you mean. This is how it's supposed to work. When installing the bindings, those directories are determined by where the language's site directories are located and not by the install prefix set during the Cmake generation phase. This same case applies to Proton as well. To control where the files are installed, it's not recommended to use the CMAKE_INSTALL_PREFIX but instead use DESTDIR=$someplace, which installs everything relative to that directory. -- Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc. Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/ pgpeW2jvPDZA9.pgp Description: PGP signature
Re: [VOTE] Release 0.22 RC6 as 0.22 final
On 05/30/2013 01:42 PM, Darryl L. Pierce wrote: On Thu, May 30, 2013 at 01:35:52PM +0100, Gordon Sim wrote: On 05/26/2013 11:35 AM, Justin Ross wrote: RC6 contains the proposed final bits for Qpid 0.22. If you favor making the RC6 bits into our official release, vote +1. If you have reason to believe RC6 is not ready for release, vote -1. +1 However using the cmake build, I hit an install failure when using a non-standard install location because the qmfgen libraries do not seem to honour the specified prefix. Is this a known issue? Do you mean with using DESTDIR=$somedir ? Using CMAKE_INSTALL_PREFIX. I'm not seeing any install failures during packaging. The RPM packaging system uses a non-standard location to install the bits before generating the RPMs. I see: Install the project... -- Install configuration: "" -- Installing: /home/gordon/qpid-releases/0.22rc6/TEST_INSTALL/share/doc/qpid-cpp-0.22/LICENSE -- Installing: /home/gordon/qpid-releases/0.22rc6/TEST_INSTALL/share/doc/qpid-cpp-0.22/NOTICE -- Installing: /home/gordon/qpid-releases/0.22rc6/TEST_INSTALL/share/qpid/qpid/qpid.i -- Installing: /home/gordon/qpid-releases/0.22rc6/TEST_INSTALL/share/qpid/qpid/swig_perl_typemaps.i -- Installing: /home/gordon/qpid-releases/0.22rc6/TEST_INSTALL/share/qpid/qpid/swig_python_typemaps.i -- Installing: /home/gordon/qpid-releases/0.22rc6/TEST_INSTALL/share/qpid/qpid/swig_ruby_typemaps.i -- Installing: /home/gordon/qpid-releases/0.22rc6/TEST_INSTALL/include/qmf/qmfengine.i -- Installing: /home/gordon/qpid-releases/0.22rc6/TEST_INSTALL/include/qmf/qmf2.i -- Installing: /home/gordon/qpid-releases/0.22rc6/TEST_INSTALL/bin/qmf-gen CMake Error at managementgen/cmake_install.cmake:48 (FILE): file cannot create directory: /usr/lib/python2.7/site-packages/qmfgen. These seem not to get installed into my required location as are the earlier artefacts above. Maybe need administrative privileges. Call Stack (most recent call first): cmake_install.cmake:60 (INCLUDE) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: [VOTE] Release 0.22 RC6 as 0.22 final
On Thu, May 30, 2013 at 01:35:52PM +0100, Gordon Sim wrote: > On 05/26/2013 11:35 AM, Justin Ross wrote: > >RC6 contains the proposed final bits for Qpid 0.22. > > > >If you favor making the RC6 bits into our official release, vote +1. > >If you have reason to believe RC6 is not ready for release, vote -1. > > +1 > > However using the cmake build, I hit an install failure when using a > non-standard install location because the qmfgen libraries do not > seem to honour the specified prefix. Is this a known issue? Do you mean with using DESTDIR=$somedir ? I'm not seeing any install failures during packaging. The RPM packaging system uses a non-standard location to install the bits before generating the RPMs. -- Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc. Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/ pgpQY38YmGxAB.pgp Description: PGP signature
Re: [VOTE] Release 0.22 RC6 as 0.22 final
On 05/26/2013 11:35 AM, Justin Ross wrote: RC6 contains the proposed final bits for Qpid 0.22. If you favor making the RC6 bits into our official release, vote +1. If you have reason to believe RC6 is not ready for release, vote -1. +1 However using the cmake build, I hit an install failure when using a non-standard install location because the qmfgen libraries do not seem to honour the specified prefix. Is this a known issue? - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: [VOTE] Release 0.22 RC6 as 0.22 final
+1 ship it ! 100 consecutive runs of autotools 'make check' returned ZERO reported failures ! ( after applying the kernel change that Ken Giusti found -- this was on a Xeon system ) - Original Message - RC6 contains the proposed final bits for Qpid 0.22. If you favor making the RC6 bits into our official release, vote +1. If you have reason to believe RC6 is not ready for release, vote -1. Thanks! Justin - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: [VOTE] Release 0.22 RC6 as 0.22 final
+1 following the rebuild of RC6 Robbie On 26 May 2013 11:35, Justin Ross wrote: > RC6 contains the proposed final bits for Qpid 0.22. > > If you favor making the RC6 bits into our official release, vote +1. > If you have reason to believe RC6 is not ready for release, vote -1. > > Thanks! > Justin > > - > To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org > For additional commands, e-mail: dev-h...@qpid.apache.org > >
[VOTE] Release 0.22 RC6 as 0.22 final
RC6 contains the proposed final bits for Qpid 0.22. If you favor making the RC6 bits into our official release, vote +1. If you have reason to believe RC6 is not ready for release, vote -1. Thanks! Justin - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: [VOTE] Release 0.22
The batch and doc/hep changes have been merged into 0.22 branch. On 24 May 2013 12:40, Robbie Gemmell wrote: > I had a look and it seems reasonable, fixing the issue to the extent > possible without substantial change and no apparent impact in other usage > of the script which was tested. Windows users will need to quote the value, > so I have committed another tiny change to update the docs/help to reflect > that. > > Robbie > > On 24 May 2013 11:40, Justin Ross wrote: > > > I don't really object to including this. Can we have someone with > > batch script skills take a quick look at it? > > > > Justin > > > > On Thu, May 23, 2013 at 6:28 PM, Oleksandr Rudyy > wrote: > > > Justin, > > > > > > I hope it is still not too late to request the inclusion into 0.22 of > a > > > minor fix for Windows batch script to start Java Broker ( > > > http://svn.apache.org/r1485859 QPID-4881). > > > > > > We introduced new command line arguments requiring to pass an equal > > > character as part of the argument but the batch script splits the > command > > > line argument with 'equal' into two arguments and removes equal > > character. > > > Such arguments have to be quoted but processing of quoted arguments > > > resulted in the errors. > > > > > > The changes fixed the processing of quoted arguments. It is a minor > issue > > > and there are some workarounds but I would like to request the > inclusion > > of > > > the fix as it is quite trivial. > > > > > > Kind Regards, > > > Alex > > > > > > > > > > > > On 23 May 2013 22:40, Ken Giusti wrote: > > > > > >> Justin, > > >> > > >> A new RC, you say? > > >> > > >> Well, I'll just leave this little tidbit here, ya know, just in case: > > >> > > >> https://issues.apache.org/jira/browse/QPID-4883 > > >> > > >> /backs slowly away from my keyboard > > >> > > >> > > >> > > >> - Original Message - > > >> > From: "Justin Ross" > > >> > To: dev@qpid.apache.org > > >> > Sent: Thursday, May 23, 2013 10:34:58 AM > > >> > Subject: Re: [VOTE] Release 0.22 > > >> > > > >> > This vote is withdrawn. We'll have a new RC later today. The only > > >> > new change will be the cmake build fix. Once that's available, I'll > > >> > start a new vote thread. > > >> > > > >> > Justin > > >> > > > >> > On Wed, May 22, 2013 at 5:14 PM, Justin Ross > > wrote: > > >> > > Okay, we'll fix it tomorrow. > > >> > > > > >> > > On May 22, 2013 4:09 PM, "Darryl L. Pierce" > > >> wrote: > > >> > >> > > >> > >> On Wed, May 22, 2013 at 01:54:50PM -0400, Justin Ross wrote: > > >> > >> > RC5 contains the proposed final bits for Qpid 0.22. > > >> > >> > > > >> > >> > If you favor making the RC5 bits into our official release, > vote > > +1. > > >> > >> > If you have reason to believe RC5 is not ready for release, > vote > > -1. > > >> > >> > > > >> > >> > I will close this vote on Monday, 22 May. I know that's a > little > > >> > >> > brief, but I have some vacation time coming up soon, and I'm > > hoping > > >> to > > >> > >> > finish the release before I leave. > > >> > >> > > >> > >> The patches for 4344 were applied in reverse on this branch and, > > with > > >> > >> the last cherry-pick, the bindings/CMakeLists.txt broke the CMake > > >> > >> changes. The conditional check for Swig < 1.3.32 is still in the > > file > > >> > >> and needs to be deleted to fix CMake. > > >> > >> > > >> > >> This is totally my fault. > > >> > >> > > >> > >> -- > > >> > >> Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc. > > >> > >> Delivering value year after year. > > >> > >> Red Hat ranks #1 in value among software vendors. > > >> > >> http://www.redhat.com/promo/vendor/ > > >> > >> > > >> > > > > >> > > > >> > > - > > >> > To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org > > >> > For additional commands, e-mail: dev-h...@qpid.apache.org > > >> > > > >> > > > >> > > >> -- > > >> -K > > >> > > >> - > > >> To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org > > >> For additional commands, e-mail: dev-h...@qpid.apache.org > > >> > > >> > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org > > For additional commands, e-mail: dev-h...@qpid.apache.org > > > > >
Re: [VOTE] Release 0.22
I had a look and it seems reasonable, fixing the issue to the extent possible without substantial change and no apparent impact in other usage of the script which was tested. Windows users will need to quote the value, so I have committed another tiny change to update the docs/help to reflect that. Robbie On 24 May 2013 11:40, Justin Ross wrote: > I don't really object to including this. Can we have someone with > batch script skills take a quick look at it? > > Justin > > On Thu, May 23, 2013 at 6:28 PM, Oleksandr Rudyy wrote: > > Justin, > > > > I hope it is still not too late to request the inclusion into 0.22 of a > > minor fix for Windows batch script to start Java Broker ( > > http://svn.apache.org/r1485859 QPID-4881). > > > > We introduced new command line arguments requiring to pass an equal > > character as part of the argument but the batch script splits the command > > line argument with 'equal' into two arguments and removes equal > character. > > Such arguments have to be quoted but processing of quoted arguments > > resulted in the errors. > > > > The changes fixed the processing of quoted arguments. It is a minor issue > > and there are some workarounds but I would like to request the inclusion > of > > the fix as it is quite trivial. > > > > Kind Regards, > > Alex > > > > > > > > On 23 May 2013 22:40, Ken Giusti wrote: > > > >> Justin, > >> > >> A new RC, you say? > >> > >> Well, I'll just leave this little tidbit here, ya know, just in case: > >> > >> https://issues.apache.org/jira/browse/QPID-4883 > >> > >> /backs slowly away from my keyboard > >> > >> > >> > >> - Original Message - > >> > From: "Justin Ross" > >> > To: dev@qpid.apache.org > >> > Sent: Thursday, May 23, 2013 10:34:58 AM > >> > Subject: Re: [VOTE] Release 0.22 > >> > > >> > This vote is withdrawn. We'll have a new RC later today. The only > >> > new change will be the cmake build fix. Once that's available, I'll > >> > start a new vote thread. > >> > > >> > Justin > >> > > >> > On Wed, May 22, 2013 at 5:14 PM, Justin Ross > wrote: > >> > > Okay, we'll fix it tomorrow. > >> > > > >> > > On May 22, 2013 4:09 PM, "Darryl L. Pierce" > >> wrote: > >> > >> > >> > >> On Wed, May 22, 2013 at 01:54:50PM -0400, Justin Ross wrote: > >> > >> > RC5 contains the proposed final bits for Qpid 0.22. > >> > >> > > >> > >> > If you favor making the RC5 bits into our official release, vote > +1. > >> > >> > If you have reason to believe RC5 is not ready for release, vote > -1. > >> > >> > > >> > >> > I will close this vote on Monday, 22 May. I know that's a little > >> > >> > brief, but I have some vacation time coming up soon, and I'm > hoping > >> to > >> > >> > finish the release before I leave. > >> > >> > >> > >> The patches for 4344 were applied in reverse on this branch and, > with > >> > >> the last cherry-pick, the bindings/CMakeLists.txt broke the CMake > >> > >> changes. The conditional check for Swig < 1.3.32 is still in the > file > >> > >> and needs to be deleted to fix CMake. > >> > >> > >> > >> This is totally my fault. > >> > >> > >> > >> -- > >> > >> Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc. > >> > >> Delivering value year after year. > >> > >> Red Hat ranks #1 in value among software vendors. > >> > >> http://www.redhat.com/promo/vendor/ > >> > >> > >> > > > >> > > >> > - > >> > To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org > >> > For additional commands, e-mail: dev-h...@qpid.apache.org > >> > > >> > > >> > >> -- > >> -K > >> > >> - > >> To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org > >> For additional commands, e-mail: dev-h...@qpid.apache.org > >> > >> > > - > To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org > For additional commands, e-mail: dev-h...@qpid.apache.org > >
Re: [VOTE] Release 0.22
I don't really object to including this. Can we have someone with batch script skills take a quick look at it? Justin On Thu, May 23, 2013 at 6:28 PM, Oleksandr Rudyy wrote: > Justin, > > I hope it is still not too late to request the inclusion into 0.22 of a > minor fix for Windows batch script to start Java Broker ( > http://svn.apache.org/r1485859 QPID-4881). > > We introduced new command line arguments requiring to pass an equal > character as part of the argument but the batch script splits the command > line argument with 'equal' into two arguments and removes equal character. > Such arguments have to be quoted but processing of quoted arguments > resulted in the errors. > > The changes fixed the processing of quoted arguments. It is a minor issue > and there are some workarounds but I would like to request the inclusion of > the fix as it is quite trivial. > > Kind Regards, > Alex > > > > On 23 May 2013 22:40, Ken Giusti wrote: > >> Justin, >> >> A new RC, you say? >> >> Well, I'll just leave this little tidbit here, ya know, just in case: >> >> https://issues.apache.org/jira/browse/QPID-4883 >> >> /backs slowly away from my keyboard >> >> >> >> - Original Message - >> > From: "Justin Ross" >> > To: dev@qpid.apache.org >> > Sent: Thursday, May 23, 2013 10:34:58 AM >> > Subject: Re: [VOTE] Release 0.22 >> > >> > This vote is withdrawn. We'll have a new RC later today. The only >> > new change will be the cmake build fix. Once that's available, I'll >> > start a new vote thread. >> > >> > Justin >> > >> > On Wed, May 22, 2013 at 5:14 PM, Justin Ross wrote: >> > > Okay, we'll fix it tomorrow. >> > > >> > > On May 22, 2013 4:09 PM, "Darryl L. Pierce" >> wrote: >> > >> >> > >> On Wed, May 22, 2013 at 01:54:50PM -0400, Justin Ross wrote: >> > >> > RC5 contains the proposed final bits for Qpid 0.22. >> > >> > >> > >> > If you favor making the RC5 bits into our official release, vote +1. >> > >> > If you have reason to believe RC5 is not ready for release, vote -1. >> > >> > >> > >> > I will close this vote on Monday, 22 May. I know that's a little >> > >> > brief, but I have some vacation time coming up soon, and I'm hoping >> to >> > >> > finish the release before I leave. >> > >> >> > >> The patches for 4344 were applied in reverse on this branch and, with >> > >> the last cherry-pick, the bindings/CMakeLists.txt broke the CMake >> > >> changes. The conditional check for Swig < 1.3.32 is still in the file >> > >> and needs to be deleted to fix CMake. >> > >> >> > >> This is totally my fault. >> > >> >> > >> -- >> > >> Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc. >> > >> Delivering value year after year. >> > >> Red Hat ranks #1 in value among software vendors. >> > >> http://www.redhat.com/promo/vendor/ >> > >> >> > > >> > >> > - >> > To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org >> > For additional commands, e-mail: dev-h...@qpid.apache.org >> > >> > >> >> -- >> -K >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org >> For additional commands, e-mail: dev-h...@qpid.apache.org >> >> - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: [VOTE] Release 0.22
Justin, I hope it is still not too late to request the inclusion into 0.22 of a minor fix for Windows batch script to start Java Broker ( http://svn.apache.org/r1485859 QPID-4881). We introduced new command line arguments requiring to pass an equal character as part of the argument but the batch script splits the command line argument with 'equal' into two arguments and removes equal character. Such arguments have to be quoted but processing of quoted arguments resulted in the errors. The changes fixed the processing of quoted arguments. It is a minor issue and there are some workarounds but I would like to request the inclusion of the fix as it is quite trivial. Kind Regards, Alex On 23 May 2013 22:40, Ken Giusti wrote: > Justin, > > A new RC, you say? > > Well, I'll just leave this little tidbit here, ya know, just in case: > > https://issues.apache.org/jira/browse/QPID-4883 > > /backs slowly away from my keyboard > > > > - Original Message - > > From: "Justin Ross" > > To: dev@qpid.apache.org > > Sent: Thursday, May 23, 2013 10:34:58 AM > > Subject: Re: [VOTE] Release 0.22 > > > > This vote is withdrawn. We'll have a new RC later today. The only > > new change will be the cmake build fix. Once that's available, I'll > > start a new vote thread. > > > > Justin > > > > On Wed, May 22, 2013 at 5:14 PM, Justin Ross wrote: > > > Okay, we'll fix it tomorrow. > > > > > > On May 22, 2013 4:09 PM, "Darryl L. Pierce" > wrote: > > >> > > >> On Wed, May 22, 2013 at 01:54:50PM -0400, Justin Ross wrote: > > >> > RC5 contains the proposed final bits for Qpid 0.22. > > >> > > > >> > If you favor making the RC5 bits into our official release, vote +1. > > >> > If you have reason to believe RC5 is not ready for release, vote -1. > > >> > > > >> > I will close this vote on Monday, 22 May. I know that's a little > > >> > brief, but I have some vacation time coming up soon, and I'm hoping > to > > >> > finish the release before I leave. > > >> > > >> The patches for 4344 were applied in reverse on this branch and, with > > >> the last cherry-pick, the bindings/CMakeLists.txt broke the CMake > > >> changes. The conditional check for Swig < 1.3.32 is still in the file > > >> and needs to be deleted to fix CMake. > > >> > > >> This is totally my fault. > > >> > > >> -- > > >> Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc. > > >> Delivering value year after year. > > >> Red Hat ranks #1 in value among software vendors. > > >> http://www.redhat.com/promo/vendor/ > > >> > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org > > For additional commands, e-mail: dev-h...@qpid.apache.org > > > > > > -- > -K > > - > To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org > For additional commands, e-mail: dev-h...@qpid.apache.org > >
Re: [VOTE] Release 0.22
Justin, A new RC, you say? Well, I'll just leave this little tidbit here, ya know, just in case: https://issues.apache.org/jira/browse/QPID-4883 /backs slowly away from my keyboard - Original Message - > From: "Justin Ross" > To: dev@qpid.apache.org > Sent: Thursday, May 23, 2013 10:34:58 AM > Subject: Re: [VOTE] Release 0.22 > > This vote is withdrawn. We'll have a new RC later today. The only > new change will be the cmake build fix. Once that's available, I'll > start a new vote thread. > > Justin > > On Wed, May 22, 2013 at 5:14 PM, Justin Ross wrote: > > Okay, we'll fix it tomorrow. > > > > On May 22, 2013 4:09 PM, "Darryl L. Pierce" wrote: > >> > >> On Wed, May 22, 2013 at 01:54:50PM -0400, Justin Ross wrote: > >> > RC5 contains the proposed final bits for Qpid 0.22. > >> > > >> > If you favor making the RC5 bits into our official release, vote +1. > >> > If you have reason to believe RC5 is not ready for release, vote -1. > >> > > >> > I will close this vote on Monday, 22 May. I know that's a little > >> > brief, but I have some vacation time coming up soon, and I'm hoping to > >> > finish the release before I leave. > >> > >> The patches for 4344 were applied in reverse on this branch and, with > >> the last cherry-pick, the bindings/CMakeLists.txt broke the CMake > >> changes. The conditional check for Swig < 1.3.32 is still in the file > >> and needs to be deleted to fix CMake. > >> > >> This is totally my fault. > >> > >> -- > >> Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc. > >> Delivering value year after year. > >> Red Hat ranks #1 in value among software vendors. > >> http://www.redhat.com/promo/vendor/ > >> > > > > - > To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org > For additional commands, e-mail: dev-h...@qpid.apache.org > > -- -K - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: [VOTE] Release 0.22
This vote is withdrawn. We'll have a new RC later today. The only new change will be the cmake build fix. Once that's available, I'll start a new vote thread. Justin On Wed, May 22, 2013 at 5:14 PM, Justin Ross wrote: > Okay, we'll fix it tomorrow. > > On May 22, 2013 4:09 PM, "Darryl L. Pierce" wrote: >> >> On Wed, May 22, 2013 at 01:54:50PM -0400, Justin Ross wrote: >> > RC5 contains the proposed final bits for Qpid 0.22. >> > >> > If you favor making the RC5 bits into our official release, vote +1. >> > If you have reason to believe RC5 is not ready for release, vote -1. >> > >> > I will close this vote on Monday, 22 May. I know that's a little >> > brief, but I have some vacation time coming up soon, and I'm hoping to >> > finish the release before I leave. >> >> The patches for 4344 were applied in reverse on this branch and, with >> the last cherry-pick, the bindings/CMakeLists.txt broke the CMake >> changes. The conditional check for Swig < 1.3.32 is still in the file >> and needs to be deleted to fix CMake. >> >> This is totally my fault. >> >> -- >> Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc. >> Delivering value year after year. >> Red Hat ranks #1 in value among software vendors. >> http://www.redhat.com/promo/vendor/ >> > - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
Re: [VOTE] Release 0.22
Okay, we'll fix it tomorrow. On May 22, 2013 4:09 PM, "Darryl L. Pierce" wrote: > On Wed, May 22, 2013 at 01:54:50PM -0400, Justin Ross wrote: > > RC5 contains the proposed final bits for Qpid 0.22. > > > > If you favor making the RC5 bits into our official release, vote +1. > > If you have reason to believe RC5 is not ready for release, vote -1. > > > > I will close this vote on Monday, 22 May. I know that's a little > > brief, but I have some vacation time coming up soon, and I'm hoping to > > finish the release before I leave. > > The patches for 4344 were applied in reverse on this branch and, with > the last cherry-pick, the bindings/CMakeLists.txt broke the CMake > changes. The conditional check for Swig < 1.3.32 is still in the file > and needs to be deleted to fix CMake. > > This is totally my fault. > > -- > Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc. > Delivering value year after year. > Red Hat ranks #1 in value among software vendors. > http://www.redhat.com/promo/vendor/ > >
Re: [VOTE] Release 0.22
On Wed, May 22, 2013 at 01:54:50PM -0400, Justin Ross wrote: > RC5 contains the proposed final bits for Qpid 0.22. > > If you favor making the RC5 bits into our official release, vote +1. > If you have reason to believe RC5 is not ready for release, vote -1. > > I will close this vote on Monday, 22 May. I know that's a little > brief, but I have some vacation time coming up soon, and I'm hoping to > finish the release before I leave. The patches for 4344 were applied in reverse on this branch and, with the last cherry-pick, the bindings/CMakeLists.txt broke the CMake changes. The conditional check for Swig < 1.3.32 is still in the file and needs to be deleted to fix CMake. This is totally my fault. -- Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc. Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/ pgplHrstRn2hT.pgp Description: PGP signature
[VOTE] Release 0.22
RC5 contains the proposed final bits for Qpid 0.22. If you favor making the RC5 bits into our official release, vote +1. If you have reason to believe RC5 is not ready for release, vote -1. I will close this vote on Monday, 22 May. I know that's a little brief, but I have some vacation time coming up soon, and I'm hoping to finish the release before I leave. Thanks! Justin - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
