[jira] [Commented] (DISPATCH-1155) dueling httpRootDirs
[ https://issues.apache.org/jira/browse/DISPATCH-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16783516#comment-16783516 ] ASF GitHub Bot commented on DISPATCH-1155: -- jdanekrh commented on pull request #451: NO-JIRA - Update doc for httpRootDir default value removal (DISPATCH-1155) URL: https://github.com/apache/qpid-dispatch/pull/451 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > dueling httpRootDirs > > > Key: DISPATCH-1155 > URL: https://issues.apache.org/jira/browse/DISPATCH-1155 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: michael goulish >Assignee: michael goulish >Priority: Major > Fix For: 1.5.0 > > > New version of qpid-dispatch-router uses > "/usr/share/qpid-dispatch/console/stand-alone" as the default httpRootDir. > But when installing new qpid-dispatch-console package, the pages are > available at "/usr/share/qpid-dispatch/console". > This forces the user to define httpRootDir on the listener to bypass this > issue. > Ted suggests this fix: > > Remove the default behavior for httpRootDir. If it is not specified in the > configuration for a listener, then HTTP requests shall be rejected on > connections to that listener. Such a listener would only be usable for AMQP > over websockets. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1155) dueling httpRootDirs
[ https://issues.apache.org/jira/browse/DISPATCH-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16783517#comment-16783517 ] ASF subversion and git services commented on DISPATCH-1155: --- Commit 9be7ca00286eef2adc42c56f429784db1f684967 in qpid-dispatch's branch refs/heads/master from Jiří Daněk [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=9be7ca0 ] NO-JIRA - Update doc for httpRootDir default value removal (DISPATCH-1155) (#451) > dueling httpRootDirs > > > Key: DISPATCH-1155 > URL: https://issues.apache.org/jira/browse/DISPATCH-1155 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: michael goulish >Assignee: michael goulish >Priority: Major > Fix For: 1.5.0 > > > New version of qpid-dispatch-router uses > "/usr/share/qpid-dispatch/console/stand-alone" as the default httpRootDir. > But when installing new qpid-dispatch-console package, the pages are > available at "/usr/share/qpid-dispatch/console". > This forces the user to define httpRootDir on the listener to bypass this > issue. > Ted suggests this fix: > > Remove the default behavior for httpRootDir. If it is not specified in the > configuration for a listener, then HTTP requests shall be rejected on > connections to that listener. Such a listener would only be usable for AMQP > over websockets. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1155) dueling httpRootDirs
[ https://issues.apache.org/jira/browse/DISPATCH-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16783143#comment-16783143 ] ASF GitHub Bot commented on DISPATCH-1155: -- jdanekrh commented on issue #451: NO-JIRA - Update doc for httpRootDir default value removal (DISPATCH-1155) URL: https://github.com/apache/qpid-dispatch/pull/451#issuecomment-469175953 Found one more doc file to update. I'll squash and merge this later today if there are no further comments. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > dueling httpRootDirs > > > Key: DISPATCH-1155 > URL: https://issues.apache.org/jira/browse/DISPATCH-1155 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: michael goulish >Assignee: michael goulish >Priority: Major > Fix For: 1.5.0 > > > New version of qpid-dispatch-router uses > "/usr/share/qpid-dispatch/console/stand-alone" as the default httpRootDir. > But when installing new qpid-dispatch-console package, the pages are > available at "/usr/share/qpid-dispatch/console". > This forces the user to define httpRootDir on the listener to bypass this > issue. > Ted suggests this fix: > > Remove the default behavior for httpRootDir. If it is not specified in the > configuration for a listener, then HTTP requests shall be rejected on > connections to that listener. Such a listener would only be usable for AMQP > over websockets. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1155) dueling httpRootDirs
[ https://issues.apache.org/jira/browse/DISPATCH-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776724#comment-16776724 ] ASF GitHub Bot commented on DISPATCH-1155: -- codecov-io commented on issue #451: NO-JIRA - Update doc for httpRootDir default value removal (DISPATCH-1155) URL: https://github.com/apache/qpid-dispatch/pull/451#issuecomment-466954539 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=h1) Report > Merging [#451](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/8e4bd11915963354e106e654a48891c468dbbf27?src=pr&el=desc) will **decrease** coverage by `0.04%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #451 +/- ## == - Coverage 86.81% 86.77% -0.05% == Files 85 85 Lines 1875418754 == - Hits1628216274 -8 - Misses 2472 2480 +8 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...c/router\_core/modules/test\_hooks/core\_test\_hooks.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvdGVzdF9ob29rcy9jb3JlX3Rlc3RfaG9va3MuYw==) | `92.67% <0%> (-1.28%)` | :arrow_down: | | [src/remote\_sasl.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3JlbW90ZV9zYXNsLmM=) | `82.77% <0%> (-1.12%)` | :arrow_down: | | [src/router\_core/core\_client\_api.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfY2xpZW50X2FwaS5j) | `91.57% <0%> (-0.37%)` | :arrow_down: | | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `88.29% <0%> (-0.26%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.96% <0%> (-0.13%)` | :arrow_down: | | [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `76.92% <0%> (+0.24%)` | :arrow_up: | | [...re/modules/edge\_addr\_tracking/edge\_addr\_tracking.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9hZGRyX3RyYWNraW5nL2VkZ2VfYWRkcl90cmFja2luZy5j) | `84.21% <0%> (+1.16%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=footer). Last update [8e4bd11...7c7db02](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > dueling httpRootDirs > > > Key: DISPATCH-1155 > URL: https://issues.apache.org/jira/browse/DISPATCH-1155 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: michael goulish >Assignee: michael goulish >Priority: Major > Fix For: 1.5.0 > > > New version of qpid-dispatch-router uses > "/usr/share/qpid-dispatch/console/stand-alone" as the default httpRootDir. > But when installing new qpid-dispatch-console package, the pages are > available at "/usr/share/qpid-dispatch/console". > This forces the user to define httpRootDir on the listener to bypass this > issue. > Ted suggests this fix: > > Remove the default behavior for httpRootDir. If it is not specified in the > configuration for a listener, then HTTP requests shall be rejected on > connections to that listener. Such a listener would only be usable for AMQP > over websockets. -- Th
[jira] [Commented] (DISPATCH-1155) dueling httpRootDirs
[ https://issues.apache.org/jira/browse/DISPATCH-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776713#comment-16776713 ] ASF GitHub Bot commented on DISPATCH-1155: -- codecov-io commented on issue #451: NO-JIRA - Update doc for httpRootDir default value removal (DISPATCH-1155) URL: https://github.com/apache/qpid-dispatch/pull/451#issuecomment-466954539 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=h1) Report > Merging [#451](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/8e4bd11915963354e106e654a48891c468dbbf27?src=pr&el=desc) will **increase** coverage by `0.02%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #451 +/- ## == + Coverage 86.81% 86.84% +0.02% == Files 85 85 Lines 1875418754 == + Hits1628216286 +4 + Misses 2472 2468 -4 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `63.84% <0%> (-0.57%)` | :arrow_down: | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.92% <0%> (+0.7%)` | :arrow_up: | | [...re/modules/edge\_addr\_tracking/edge\_addr\_tracking.c](https://codecov.io/gh/apache/qpid-dispatch/pull/451/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9hZGRyX3RyYWNraW5nL2VkZ2VfYWRkcl90cmFja2luZy5j) | `84.21% <0%> (+1.16%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=footer). Last update [8e4bd11...7c7db02](https://codecov.io/gh/apache/qpid-dispatch/pull/451?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > dueling httpRootDirs > > > Key: DISPATCH-1155 > URL: https://issues.apache.org/jira/browse/DISPATCH-1155 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: michael goulish >Assignee: michael goulish >Priority: Major > Fix For: 1.5.0 > > > New version of qpid-dispatch-router uses > "/usr/share/qpid-dispatch/console/stand-alone" as the default httpRootDir. > But when installing new qpid-dispatch-console package, the pages are > available at "/usr/share/qpid-dispatch/console". > This forces the user to define httpRootDir on the listener to bypass this > issue. > Ted suggests this fix: > > Remove the default behavior for httpRootDir. If it is not specified in the > configuration for a listener, then HTTP requests shall be rejected on > connections to that listener. Such a listener would only be usable for AMQP > over websockets. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1155) dueling httpRootDirs
[ https://issues.apache.org/jira/browse/DISPATCH-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776700#comment-16776700 ] ASF GitHub Bot commented on DISPATCH-1155: -- jdanekrh commented on pull request #451: NO-JIRA - Update doc for httpRootDir default value removal (DISPATCH-1155) URL: https://github.com/apache/qpid-dispatch/pull/451 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > dueling httpRootDirs > > > Key: DISPATCH-1155 > URL: https://issues.apache.org/jira/browse/DISPATCH-1155 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: michael goulish >Assignee: michael goulish >Priority: Major > Fix For: 1.5.0 > > > New version of qpid-dispatch-router uses > "/usr/share/qpid-dispatch/console/stand-alone" as the default httpRootDir. > But when installing new qpid-dispatch-console package, the pages are > available at "/usr/share/qpid-dispatch/console". > This forces the user to define httpRootDir on the listener to bypass this > issue. > Ted suggests this fix: > > Remove the default behavior for httpRootDir. If it is not specified in the > configuration for a listener, then HTTP requests shall be rejected on > connections to that listener. Such a listener would only be usable for AMQP > over websockets. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1155) dueling httpRootDirs
[ https://issues.apache.org/jira/browse/DISPATCH-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16671860#comment-16671860 ] ASF GitHub Bot commented on DISPATCH-1155: -- Github user asfgit closed the pull request at: https://github.com/apache/qpid-dispatch/pull/409 > dueling httpRootDirs > > > Key: DISPATCH-1155 > URL: https://issues.apache.org/jira/browse/DISPATCH-1155 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: michael goulish >Assignee: michael goulish >Priority: Major > > New version of qpid-dispatch-router uses > "/usr/share/qpid-dispatch/console/stand-alone" as the default httpRootDir. > But when installing new qpid-dispatch-console package, the pages are > available at "/usr/share/qpid-dispatch/console". > This forces the user to define httpRootDir on the listener to bypass this > issue. > Ted suggests this fix: > > Remove the default behavior for httpRootDir. If it is not specified in the > configuration for a listener, then HTTP requests shall be rejected on > connections to that listener. Such a listener would only be usable for AMQP > over websockets. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1155) dueling httpRootDirs
[ https://issues.apache.org/jira/browse/DISPATCH-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16671859#comment-16671859 ] ASF subversion and git services commented on DISPATCH-1155: --- Commit 7fb0156a528cbb9ca590ea3b947709dff2589b20 in qpid-dispatch's branch refs/heads/master from Michael Goulish [ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=7fb0156 ] DISPATCH-1155 : force explicit config of http root dir This closes #409 > dueling httpRootDirs > > > Key: DISPATCH-1155 > URL: https://issues.apache.org/jira/browse/DISPATCH-1155 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: michael goulish >Assignee: michael goulish >Priority: Major > > New version of qpid-dispatch-router uses > "/usr/share/qpid-dispatch/console/stand-alone" as the default httpRootDir. > But when installing new qpid-dispatch-console package, the pages are > available at "/usr/share/qpid-dispatch/console". > This forces the user to define httpRootDir on the listener to bypass this > issue. > Ted suggests this fix: > > Remove the default behavior for httpRootDir. If it is not specified in the > configuration for a listener, then HTTP requests shall be rejected on > connections to that listener. Such a listener would only be usable for AMQP > over websockets. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1155) dueling httpRootDirs
[
https://issues.apache.org/jira/browse/DISPATCH-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16670412#comment-16670412
]
ASF GitHub Bot commented on DISPATCH-1155:
--
Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/409#discussion_r229792589
--- Diff: src/connection_manager.c ---
@@ -314,7 +314,15 @@ static qd_error_t load_server_config(qd_dispatch_t
*qd, qd_server_config_t *conf
config->protocol_family = qd_entity_opt_string(entity,
"protocolFamily", 0); CHECK();
config->http = qd_entity_opt_bool(entity, "http",
false); CHECK();
config->http_root_dir= qd_entity_opt_string(entity,
"httpRootDir", false); CHECK();
-config->http = config->http || config->http_root_dir; /* httpRoot
implies http */
+
+// Because of a potential conflict when console is installed or not
installed,
+// we now want to require that the config file explicitly specify HTTP
root
+// if HTTP service is requested.
+if (config->http && ! config->http_root_dir) {
+qd_log(qd->connection_manager->log_source, QD_LOG_WARNING, "Both
http and http_root_dir must be set in router config to enable http support." );
--- End diff --
This is actually not true. It is valid to configure a listener with http
on and no httpRootDir. Such a listener would only be useful for
AMQP-over-websockets. It would not serve any static content.
> dueling httpRootDirs
>
>
> Key: DISPATCH-1155
> URL: https://issues.apache.org/jira/browse/DISPATCH-1155
> Project: Qpid Dispatch
> Issue Type: Bug
>Reporter: michael goulish
>Assignee: michael goulish
>Priority: Major
>
> New version of qpid-dispatch-router uses
> "/usr/share/qpid-dispatch/console/stand-alone" as the default httpRootDir.
> But when installing new qpid-dispatch-console package, the pages are
> available at "/usr/share/qpid-dispatch/console".
> This forces the user to define httpRootDir on the listener to bypass this
> issue.
> Ted suggests this fix:
>
> Remove the default behavior for httpRootDir. If it is not specified in the
> configuration for a listener, then HTTP requests shall be rejected on
> connections to that listener. Such a listener would only be usable for AMQP
> over websockets.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1155) dueling httpRootDirs
[ https://issues.apache.org/jira/browse/DISPATCH-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668743#comment-16668743 ] ASF GitHub Bot commented on DISPATCH-1155: -- Github user codecov-io commented on the issue: https://github.com/apache/qpid-dispatch/pull/409 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/409?src=pr&el=h1) Report > Merging [#409](https://codecov.io/gh/apache/qpid-dispatch/pull/409?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/fcf457c981c262d5648d6c1a944059a3c3b47458?src=pr&el=desc) will **increase** coverage by `0.02%`. > The diff coverage is `66.66%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/409?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #409 +/- ## == + Coverage 85.16% 85.19% +0.02% == Files 78 78 Lines 1742917430 +1 == + Hits1484314849 +6 + Misses 2586 2581 -5 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/409?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/connection\_manager.c](https://codecov.io/gh/apache/qpid-dispatch/pull/409/diff?src=pr&el=tree#diff-c3JjL2Nvbm5lY3Rpb25fbWFuYWdlci5j) | `76.44% <66.66%> (-0.11%)` | :arrow_down: | | [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/409/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `76.8% <0%> (-0.26%)` | :arrow_down: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/409/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.65% <0%> (ø)` | :arrow_up: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/409/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `93.66% <0%> (+0.21%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/409/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `95.48% <0%> (+0.21%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/409/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `90.31% <0%> (+0.44%)` | :arrow_up: | | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/409/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `63.84% <0%> (+0.56%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/409?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/409?src=pr&el=footer). Last update [fcf457c...61564b9](https://codecov.io/gh/apache/qpid-dispatch/pull/409?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). > dueling httpRootDirs > > > Key: DISPATCH-1155 > URL: https://issues.apache.org/jira/browse/DISPATCH-1155 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: michael goulish >Assignee: michael goulish >Priority: Major > > New version of qpid-dispatch-router uses > "/usr/share/qpid-dispatch/console/stand-alone" as the default httpRootDir. > But when installing new qpid-dispatch-console package, the pages are > available at "/usr/share/qpid-dispatch/console". > This forces the user to define httpRootDir on the listener to bypass this > issue. > Ted suggests this fix: > > Remove the default behavior for httpRootDir. If it is not specified in the > configuration for a listener, then HTTP requests shall be rejected on > connections to that listener. Such a listener would only be usable for AMQP > over websockets. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1155) dueling httpRootDirs
[ https://issues.apache.org/jira/browse/DISPATCH-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668706#comment-16668706 ] ASF GitHub Bot commented on DISPATCH-1155: -- GitHub user mgoulish opened a pull request: https://github.com/apache/qpid-dispatch/pull/409 DISPATCH-1155 : force explicit config of http root dir Force the user to explicit specify HTTP root dir when requesting http support on a listener. Issue a warning log message if HTTP service is requested, but root dir not specified. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mgoulish/qpid-dispatch DISPATCH-1155 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/409.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #409 commit 61564b930f25859702cce2b355d78c30ee3e75cd Author: Michael Goulish Date: 2018-10-30T13:40:23Z DISPATCH-1155 : force explicit config of http root dir > dueling httpRootDirs > > > Key: DISPATCH-1155 > URL: https://issues.apache.org/jira/browse/DISPATCH-1155 > Project: Qpid Dispatch > Issue Type: Bug >Reporter: michael goulish >Assignee: michael goulish >Priority: Major > > New version of qpid-dispatch-router uses > "/usr/share/qpid-dispatch/console/stand-alone" as the default httpRootDir. > But when installing new qpid-dispatch-console package, the pages are > available at "/usr/share/qpid-dispatch/console". > This forces the user to define httpRootDir on the listener to bypass this > issue. > Ted suggests this fix: > > Remove the default behavior for httpRootDir. If it is not specified in the > configuration for a listener, then HTTP requests shall be rejected on > connections to that listener. Such a listener would only be usable for AMQP > over websockets. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
