[jira] [Commented] (DISPATCH-802) refuse transaction coordination links if they can't be routed to a coordinator
[ https://issues.apache.org/jira/browse/DISPATCH-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16149614#comment-16149614 ] ASF GitHub Bot commented on DISPATCH-802: - Github user ganeshmurthy closed the pull request at: https://github.com/apache/qpid-dispatch/pull/187 > refuse transaction coordination links if they can't be routed to a coordinator > -- > > Key: DISPATCH-802 > URL: https://issues.apache.org/jira/browse/DISPATCH-802 > Project: Qpid Dispatch > Issue Type: Bug >Affects Versions: 0.8.0 >Reporter: Robbie Gemmell >Assignee: Ganesh Murthy > Fix For: 1.0.0 > > > The router is accepting transaction coordinator links even if the support > from DISPATCH-195 is not being used to link-route them somewhere that can > handle coordination. If the router can't link-route to a coordinator, and > knows it can't coordinate transactions itself, it shouldn't accept the links > to begin with but rather refuse them so clients know they will never work and > why. > Prior to 0.8.0, credit was also given on these links, allowing attempt to > declare transactions. From 0.8.0 no credit is given since there is no > receiver, so clients have no way to use the accepted link and no indication > why. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-802) refuse transaction coordination links if they can't be routed to a coordinator
[ https://issues.apache.org/jira/browse/DISPATCH-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16140097#comment-16140097 ] ASF GitHub Bot commented on DISPATCH-802: - Github user asfgit closed the pull request at: https://github.com/apache/qpid-dispatch/pull/190 > refuse transaction coordination links if they can't be routed to a coordinator > -- > > Key: DISPATCH-802 > URL: https://issues.apache.org/jira/browse/DISPATCH-802 > Project: Qpid Dispatch > Issue Type: Bug >Affects Versions: 0.8.0 >Reporter: Robbie Gemmell >Assignee: Ganesh Murthy > Fix For: 1.0.0 > > > The router is accepting transaction coordinator links even if the support > from DISPATCH-195 is not being used to link-route them somewhere that can > handle coordination. If the router can't link-route to a coordinator, and > knows it can't coordinate transactions itself, it shouldn't accept the links > to begin with but rather refuse them so clients know they will never work and > why. > Prior to 0.8.0, credit was also given on these links, allowing attempt to > declare transactions. From 0.8.0 no credit is given since there is no > receiver, so clients have no way to use the accepted link and no indication > why. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-802) refuse transaction coordination links if they can't be routed to a coordinator
[ https://issues.apache.org/jira/browse/DISPATCH-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16140096#comment-16140096 ] ASF subversion and git services commented on DISPATCH-802: -- Commit 667fab3282a20c96e2a741914b8cbfedd075d041 in qpid-dispatch's branch refs/heads/master from [~ganeshmurthy] [ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=667fab3 ] DISPATCH-802 - Additional fixes - 1. Modified error name to amqp:precondition-failed. 2. Modified error description 3. Prevented from setting the target on the return attach > refuse transaction coordination links if they can't be routed to a coordinator > -- > > Key: DISPATCH-802 > URL: https://issues.apache.org/jira/browse/DISPATCH-802 > Project: Qpid Dispatch > Issue Type: Bug >Affects Versions: 0.8.0 >Reporter: Robbie Gemmell >Assignee: Ganesh Murthy > Fix For: 1.0.0 > > > The router is accepting transaction coordinator links even if the support > from DISPATCH-195 is not being used to link-route them somewhere that can > handle coordination. If the router can't link-route to a coordinator, and > knows it can't coordinate transactions itself, it shouldn't accept the links > to begin with but rather refuse them so clients know they will never work and > why. > Prior to 0.8.0, credit was also given on these links, allowing attempt to > declare transactions. From 0.8.0 no credit is given since there is no > receiver, so clients have no way to use the accepted link and no indication > why. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-802) refuse transaction coordination links if they can't be routed to a coordinator
[ https://issues.apache.org/jira/browse/DISPATCH-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16140079#comment-16140079 ] ASF GitHub Bot commented on DISPATCH-802: - Github user gemmellr commented on the issue: https://github.com/apache/qpid-dispatch/pull/190 Tested the latest version and the attach target is now null as needed to indicate refusal, and the updated error details look good. > refuse transaction coordination links if they can't be routed to a coordinator > -- > > Key: DISPATCH-802 > URL: https://issues.apache.org/jira/browse/DISPATCH-802 > Project: Qpid Dispatch > Issue Type: Bug >Affects Versions: 0.8.0 >Reporter: Robbie Gemmell >Assignee: Ganesh Murthy > Fix For: 1.0.0 > > > The router is accepting transaction coordinator links even if the support > from DISPATCH-195 is not being used to link-route them somewhere that can > handle coordination. If the router can't link-route to a coordinator, and > knows it can't coordinate transactions itself, it shouldn't accept the links > to begin with but rather refuse them so clients know they will never work and > why. > Prior to 0.8.0, credit was also given on these links, allowing attempt to > declare transactions. From 0.8.0 no credit is given since there is no > receiver, so clients have no way to use the accepted link and no indication > why. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-802) refuse transaction coordination links if they can't be routed to a coordinator
[ https://issues.apache.org/jira/browse/DISPATCH-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138692#comment-16138692 ] ASF GitHub Bot commented on DISPATCH-802: - GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/190 DISPATCH-802 - Additional fixes - 1. Modified error name to amqp:prec… …ondition-failed. 2. Modified error description 3. Prevented from setting the target on the return attach You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-802-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/190.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #190 commit 667fab3282a20c96e2a741914b8cbfedd075d041 Author: Ganesh Murthy Date: 2017-08-23T17:23:41Z DISPATCH-802 - Additional fixes - 1. Modified error name to amqp:precondition-failed. 2. Modified error description 3. Prevented from setting the target on the return attach > refuse transaction coordination links if they can't be routed to a coordinator > -- > > Key: DISPATCH-802 > URL: https://issues.apache.org/jira/browse/DISPATCH-802 > Project: Qpid Dispatch > Issue Type: Bug >Affects Versions: 0.8.0 >Reporter: Robbie Gemmell >Assignee: Ganesh Murthy > Fix For: 1.0.0 > > > The router is accepting transaction coordinator links even if the support > from DISPATCH-195 is not being used to link-route them somewhere that can > handle coordination. If the router can't link-route to a coordinator, and > knows it can't coordinate transactions itself, it shouldn't accept the links > to begin with but rather refuse them so clients know they will never work and > why. > Prior to 0.8.0, credit was also given on these links, allowing attempt to > declare transactions. From 0.8.0 no credit is given since there is no > receiver, so clients have no way to use the accepted link and no indication > why. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-802) refuse transaction coordination links if they can't be routed to a coordinator
[
https://issues.apache.org/jira/browse/DISPATCH-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138332#comment-16138332
]
Robbie Gemmell commented on DISPATCH-802:
-
{quote}
but instead should look like this (target=null)
{quote}
Yep, thats how you signal to peers that the attach really failed and a detach
will follow immediately to indicate why.
> refuse transaction coordination links if they can't be routed to a coordinator
> --
>
> Key: DISPATCH-802
> URL: https://issues.apache.org/jira/browse/DISPATCH-802
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 0.8.0
>Reporter: Robbie Gemmell
>Assignee: Ganesh Murthy
> Fix For: 1.0.0
>
>
> The router is accepting transaction coordinator links even if the support
> from DISPATCH-195 is not being used to link-route them somewhere that can
> handle coordination. If the router can't link-route to a coordinator, and
> knows it can't coordinate transactions itself, it shouldn't accept the links
> to begin with but rather refuse them so clients know they will never work and
> why.
> Prior to 0.8.0, credit was also given on these links, allowing attempt to
> declare transactions. From 0.8.0 no credit is given since there is no
> receiver, so clients have no way to use the accepted link and no indication
> why.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-802) refuse transaction coordination links if they can't be routed to a coordinator
[
https://issues.apache.org/jira/browse/DISPATCH-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138307#comment-16138307
]
Ganesh Murthy commented on DISPATCH-802:
Currently the return attach looks like this -
{noformat}
[2016906257:1] <-
Attach{name='qpid-jms:coordinator:ID:db8ca07c-92cf-4f9f-a1eb-492b220709dc:1:1',
handle=0, role=RECEIVER, sndSettleMode=MIXED, rcvSettleMode=FIRST,
source=Source{address='null', durable=NONE, expiryPolicy=SESSION_END,
timeout=0, dynamic=false, dynamicNodeProperties=null, distributionMode=null,
filter=null, defaultOutcome=null, outcomes=null, capabilities=null},
target=Target{address='null', durable=NONE, expiryPolicy=SESSION_END,
timeout=0, dynamic=false, dynamicNodeProperties=null, capabilities=null},
unsettled=null, incompleteUnsettled=false, initialDeliveryCount=0,
maxMessageSize=0, offeredCapabilities=null, desiredCapabilities=null,
properties=null}
{noformat}
but instead should look like this (target=null)
{noformat}
[2016906257:1] <-
Attach{name='qpid-jms:coordinator:ID:db8ca07c-92cf-4f9f-a1eb-492b220709dc:1:1',
handle=0, role=RECEIVER, sndSettleMode=MIXED, rcvSettleMode=FIRST,
source=Source{address='null', durable=NONE, expiryPolicy=SESSION_END,
timeout=0, dynamic=false, dynamicNodeProperties=null, distributionMode=null,
filter=null, defaultOutcome=null, outcomes=null, capabilities=null},
target=null, unsettled=null, incompleteUnsettled=false, initialDeliveryCount=0,
maxMessageSize=0, offeredCapabilities=null, desiredCapabilities=null,
properties=null}
{noformat}
[~gemmellr] is that correct?
I also saw your other comment about amqp:precondition-failed and I will modify
the code to do the same.
> refuse transaction coordination links if they can't be routed to a coordinator
> --
>
> Key: DISPATCH-802
> URL: https://issues.apache.org/jira/browse/DISPATCH-802
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 0.8.0
>Reporter: Robbie Gemmell
>Assignee: Ganesh Murthy
> Fix For: 1.0.0
>
>
> The router is accepting transaction coordinator links even if the support
> from DISPATCH-195 is not being used to link-route them somewhere that can
> handle coordination. If the router can't link-route to a coordinator, and
> knows it can't coordinate transactions itself, it shouldn't accept the links
> to begin with but rather refuse them so clients know they will never work and
> why.
> Prior to 0.8.0, credit was also given on these links, allowing attempt to
> declare transactions. From 0.8.0 no credit is given since there is no
> receiver, so clients have no way to use the accepted link and no indication
> why.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-802) refuse transaction coordination links if they can't be routed to a coordinator
[ https://issues.apache.org/jira/browse/DISPATCH-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16126013#comment-16126013 ] ASF subversion and git services commented on DISPATCH-802: -- Commit 098ec7d13744bbbd31fce173bc9a76daab945e9c in qpid-dispatch's branch refs/heads/master from [~ganeshmurthy] [ https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;h=098ec7d ] DISPATCH-802 - Refuse transaction coordination links if they can't be routed to a coordinator since the router by itself cannot coordinate transactions. (cherry picked from commit d17f7b58b95886ca4ee03aac7deba4eb5cad679d) > refuse transaction coordination links if they can't be routed to a coordinator > -- > > Key: DISPATCH-802 > URL: https://issues.apache.org/jira/browse/DISPATCH-802 > Project: Qpid Dispatch > Issue Type: Bug >Affects Versions: 0.8.0 >Reporter: Robbie Gemmell >Assignee: Ganesh Murthy > > The router is accepting transaction coordinator links even if the support > from DISPATCH-195 is not being used to link-route them somewhere that can > handle coordination. If the router can't link-route to a coordinator, and > knows it can't coordinate transactions itself, it shouldn't accept the links > to begin with but rather refuse them so clients know they will never work and > why. > Prior to 0.8.0, credit was also given on these links, allowing attempt to > declare transactions. From 0.8.0 no credit is given since there is no > receiver, so clients have no way to use the accepted link and no indication > why. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-802) refuse transaction coordination links if they can't be routed to a coordinator
[ https://issues.apache.org/jira/browse/DISPATCH-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123343#comment-16123343 ] ASF GitHub Bot commented on DISPATCH-802: - GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/187 DISPATCH-802 - Refuse transaction coordination links if they can't be… … routed to a coordinator since the router by itself cannot coordinate transactions. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-802-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/187.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #187 commit dccf0d25bf64da85b64889f98cbbb35da32c2af6 Author: Ganesh Murthy Date: 2017-08-04T19:19:15Z DISPATCH-802 - Refuse transaction coordination links if they can't be routed to a coordinator since the router by itself cannot coordinate transactions. > refuse transaction coordination links if they can't be routed to a coordinator > -- > > Key: DISPATCH-802 > URL: https://issues.apache.org/jira/browse/DISPATCH-802 > Project: Qpid Dispatch > Issue Type: Bug >Affects Versions: 0.8.0 >Reporter: Robbie Gemmell >Assignee: Ganesh Murthy > > The router is accepting transaction coordinator links even if the support > from DISPATCH-195 is not being used to link-route them somewhere that can > handle coordination. If the router can't link-route to a coordinator, and > knows it can't coordinate transactions itself, it shouldn't accept the links > to begin with but rather refuse them so clients know they will never work and > why. > Prior to 0.8.0, credit was also given on these links, allowing attempt to > declare transactions. From 0.8.0 no credit is given since there is no > receiver, so clients have no way to use the accepted link and no indication > why. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-802) refuse transaction coordination links if they can't be routed to a coordinator
[ https://issues.apache.org/jira/browse/DISPATCH-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123330#comment-16123330 ] ASF GitHub Bot commented on DISPATCH-802: - Github user ganeshmurthy closed the pull request at: https://github.com/apache/qpid-dispatch/pull/184 > refuse transaction coordination links if they can't be routed to a coordinator > -- > > Key: DISPATCH-802 > URL: https://issues.apache.org/jira/browse/DISPATCH-802 > Project: Qpid Dispatch > Issue Type: Bug >Affects Versions: 0.8.0 >Reporter: Robbie Gemmell >Assignee: Ganesh Murthy > > The router is accepting transaction coordinator links even if the support > from DISPATCH-195 is not being used to link-route them somewhere that can > handle coordination. If the router can't link-route to a coordinator, and > knows it can't coordinate transactions itself, it shouldn't accept the links > to begin with but rather refuse them so clients know they will never work and > why. > Prior to 0.8.0, credit was also given on these links, allowing attempt to > declare transactions. From 0.8.0 no credit is given since there is no > receiver, so clients have no way to use the accepted link and no indication > why. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-802) refuse transaction coordination links if they can't be routed to a coordinator
[ https://issues.apache.org/jira/browse/DISPATCH-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114860#comment-16114860 ] ASF GitHub Bot commented on DISPATCH-802: - GitHub user ganeshmurthy opened a pull request: https://github.com/apache/qpid-dispatch/pull/184 DISPATCH-802 - Refuse transaction coordination links if they can't be… … routed to a coordinator You can merge this pull request into a Git repository by running: $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-802 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-dispatch/pull/184.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #184 commit a61f631cc2706d7c6f3869522489469cbc6b54c3 Author: Ganesh Murthy Date: 2017-08-04T19:19:15Z DISPATCH-802 - Refuse transaction coordination links if they can't be routed to a coordinator > refuse transaction coordination links if they can't be routed to a coordinator > -- > > Key: DISPATCH-802 > URL: https://issues.apache.org/jira/browse/DISPATCH-802 > Project: Qpid Dispatch > Issue Type: Bug >Affects Versions: 0.8.0 >Reporter: Robbie Gemmell >Assignee: Ganesh Murthy > > The router is accepting transaction coordinator links even if the support > from DISPATCH-195 is not being used to link-route them somewhere that can > handle coordination. If the router can't link-route to a coordinator, and > knows it can't coordinate transactions itself, it shouldn't accept the links > to begin with but rather refuse them so clients know they will never work and > why. > Prior to 0.8.0, credit was also given on these links, allowing attempt to > declare transactions. From 0.8.0 no credit is given since there is no > receiver, so clients have no way to use the accepted link and no indication > why. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-802) refuse transaction coordination links if they can't be routed to a coordinator
[ https://issues.apache.org/jira/browse/DISPATCH-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114180#comment-16114180 ] Robbie Gemmell commented on DISPATCH-802: - That seems good. One key thing is that the attach response which gets sent before the detach should have a null target to indicate refusal and the immediately coming detach. I'd probably go for one of amqp:precondition-failed, amqp:not-found, amqp:not-implemented, or amqp:illegal-state on the detach error. > refuse transaction coordination links if they can't be routed to a coordinator > -- > > Key: DISPATCH-802 > URL: https://issues.apache.org/jira/browse/DISPATCH-802 > Project: Qpid Dispatch > Issue Type: Bug >Affects Versions: 0.8.0 >Reporter: Robbie Gemmell >Assignee: Ganesh Murthy > > The router is accepting transaction coordinator links even if the support > from DISPATCH-195 is not being used to link-route them somewhere that can > handle coordination. If the router can't link-route to a coordinator, and > knows it can't coordinate transactions itself, it shouldn't accept the links > to begin with but rather refuse them so clients know they will never work and > why. > Prior to 0.8.0, credit was also given on these links, allowing attempt to > declare transactions. From 0.8.0 no credit is given since there is no > receiver, so clients have no way to use the accepted link and no indication > why. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-802) refuse transaction coordination links if they can't be routed to a coordinator
[ https://issues.apache.org/jira/browse/DISPATCH-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113755#comment-16113755 ] Ganesh Murthy commented on DISPATCH-802: I agree that the $coordinator pseudo address cannot be considered a regular address. The router should do the following when it receives an attach to the transaction coordinator target (the transaction coordinator has own own target, it has no address) 1. Try to link route this attach. This link routing becomes possible due to two reasons a. Because the router already sets the terminus address to $coordinator if terminus type is PN_COORDINATOR. (https://github.com/apache/qpid-dispatch/blob/master/src/router_core/terminus.c#L56) b. The router has a linkRoute entity (with address $coordinator) setup in its config file pointing it to a broker connection thus enabling the router to forward the attach to the broker 2. If the link routing the attach from step 1 fails, simply send back a detach as the router should not accept this link because the router cannot coordinate transactions itself. (What should the error be in the detach that is sent back?) What do you think [~gemmellr] > refuse transaction coordination links if they can't be routed to a coordinator > -- > > Key: DISPATCH-802 > URL: https://issues.apache.org/jira/browse/DISPATCH-802 > Project: Qpid Dispatch > Issue Type: Bug >Affects Versions: 0.8.0 >Reporter: Robbie Gemmell >Assignee: Ganesh Murthy > > The router is accepting transaction coordinator links even if the support > from DISPATCH-195 is not being used to link-route them somewhere that can > handle coordination. If the router can't link-route to a coordinator, and > knows it can't coordinate transactions itself, it shouldn't accept the links > to begin with but rather refuse them so clients know they will never work and > why. > Prior to 0.8.0, credit was also given on these links, allowing attempt to > declare transactions. From 0.8.0 no credit is given since there is no > receiver, so clients have no way to use the accepted link and no indication > why. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-802) refuse transaction coordination links if they can't be routed to a coordinator
[
https://issues.apache.org/jira/browse/DISPATCH-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113442#comment-16113442
]
Robbie Gemmell commented on DISPATCH-802:
-
It feels a little strange that it would ever be possible to consider the
$coordinator pseudo address as a regular address at this point, but even if it
was I don't think a link established to the coordinator target should be
considered to match it, so I'd still expect the link to be refused if such
config wasn't present.
In any case, I'm not sure the above doesn't quite works correctly, at least not
with 0.8.0 (I haven't tried master, need to get it building), as the router
still accepts the link rather than refuse it, just somewhat unexpectedly
replacing the original 'coordinator target' with a 'regular target' that has no
address set (i.e what we use for the anonymous relay node), and then later
detaching it with an error. It should set the target field entirely null to
signal to the client that it is actually refusing the link.
{noformat}
[99802697:1] ->
Attach{name='qpid-jms:coordinator:ID:672640c9-5477-4ed5-89d9-81c867561a54:1:1',
handle=0, role=SENDER, sndSettleMode=UNSETTLED, rcvSettleMode=FIRST,
source=Source{address='null', durable=NONE, expiryPolicy=SESSION_END,
timeout=0, dynamic=false, dynamicNodeProperties=null, distributionMode=null,
filter=null, defaultOutcome=null, outcomes=[amqp:accepted:list,
amqp:rejected:list, amqp:released:list, amqp:modified:list],
capabilities=null}, target=Coordinator{capabilities=[amqp:local-transactions]},
unsettled=null, incompleteUnsettled=false, initialDeliveryCount=0,
maxMessageSize=null, offeredCapabilities=null, desiredCapabilities=null,
properties=null}
[99802697:1] <-
Attach{name='qpid-jms:coordinator:ID:672640c9-5477-4ed5-89d9-81c867561a54:1:1',
handle=0, role=RECEIVER, sndSettleMode=MIXED, rcvSettleMode=FIRST,
source=Source{address='null', durable=NONE, expiryPolicy=SESSION_END,
timeout=0, dynamic=false, dynamicNodeProperties=null, distributionMode=null,
filter=null, defaultOutcome=null, outcomes=null, capabilities=null},
target=Target{address='null', durable=NONE, expiryPolicy=SESSION_END,
timeout=0, dynamic=false, dynamicNodeProperties=null, capabilities=null},
unsettled=null, incompleteUnsettled=false, initialDeliveryCount=0,
maxMessageSize=0, offeredCapabilities=null, desiredCapabilities=null,
properties=null}
[99802697:1] <- Detach{handle=0, closed=true,
error=Error{condition=qd:no-route-to-dest, description='No route to the
destination node', info=null}}
{noformat}
> refuse transaction coordination links if they can't be routed to a coordinator
> --
>
> Key: DISPATCH-802
> URL: https://issues.apache.org/jira/browse/DISPATCH-802
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 0.8.0
>Reporter: Robbie Gemmell
>Assignee: Ganesh Murthy
>
> The router is accepting transaction coordinator links even if the support
> from DISPATCH-195 is not being used to link-route them somewhere that can
> handle coordination. If the router can't link-route to a coordinator, and
> knows it can't coordinate transactions itself, it shouldn't accept the links
> to begin with but rather refuse them so clients know they will never work and
> why.
> Prior to 0.8.0, credit was also given on these links, allowing attempt to
> declare transactions. From 0.8.0 no credit is given since there is no
> receiver, so clients have no way to use the accepted link and no indication
> why.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-802) refuse transaction coordination links if they can't be routed to a coordinator
[
https://issues.apache.org/jira/browse/DISPATCH-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113383#comment-16113383
]
Ganesh Murthy commented on DISPATCH-802:
[~tr...@redhat.com] thinks that just adding the following link route to the
default config file should be a sufficient enough solution to this problem
{noformat}
linkRoute {
prefix: $coordinator
dir: in
connection: broker
}
{noformat}
> refuse transaction coordination links if they can't be routed to a coordinator
> --
>
> Key: DISPATCH-802
> URL: https://issues.apache.org/jira/browse/DISPATCH-802
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 0.8.0
>Reporter: Robbie Gemmell
>Assignee: Ganesh Murthy
>
> The router is accepting transaction coordinator links even if the support
> from DISPATCH-195 is not being used to link-route them somewhere that can
> handle coordination. If the router can't link-route to a coordinator, and
> knows it can't coordinate transactions itself, it shouldn't accept the links
> to begin with but rather refuse them so clients know they will never work and
> why.
> Prior to 0.8.0, credit was also given on these links, allowing attempt to
> declare transactions. From 0.8.0 no credit is given since there is no
> receiver, so clients have no way to use the accepted link and no indication
> why.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
