[jira] [Commented] (QPID-2498) Upgrade Mina to 1.1.7
[ https://issues.apache.org/jira/browse/QPID-2498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025277#comment-13025277 ] Emmanuel Bourg commented on QPID-2498: -- Thank you Robbie. I don't use the patch, I use a trimmed down client that doesn't rely on Mina. > Upgrade Mina to 1.1.7 > - > > Key: QPID-2498 > URL: https://issues.apache.org/jira/browse/QPID-2498 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Affects Versions: 0.6 >Reporter: Emmanuel Bourg >Assignee: Andrew Kennedy > Fix For: 0.11 > > Attachments: mina-update.patch, mina-upgrade.patch > > > Upgrading Mina to 1.1.7 would allow the removal of > backport-util-concurrent.jar from the dependencies. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Commented] (QPID-2498) Upgrade Mina to 1.1.7
[ https://issues.apache.org/jira/browse/QPID-2498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025272#comment-13025272 ] Robbie Gemmell commented on QPID-2498: -- Hi Emmanuel, I hope to incorporate this upgrade into some upcoming work I will be doing. Can I ask if you are already using the patched source with this change in place? Robbie > Upgrade Mina to 1.1.7 > - > > Key: QPID-2498 > URL: https://issues.apache.org/jira/browse/QPID-2498 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Affects Versions: 0.6 >Reporter: Emmanuel Bourg >Assignee: Andrew Kennedy > Fix For: 0.11 > > Attachments: mina-update.patch, mina-upgrade.patch > > > Upgrading Mina to 1.1.7 would allow the removal of > backport-util-concurrent.jar from the dependencies. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] [Commented] (QPID-2498) Upgrade Mina to 1.1.7
[ https://issues.apache.org/jira/browse/QPID-2498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022792#comment-13022792 ] Emmanuel Bourg commented on QPID-2498: -- I refreshed the patch on Github: https://github.com/ebourg/qpid/commits/mina-upgrade2 https://github.com/ebourg/qpid/commit/48422d45fb99baa89ef8de8aaa91cf0f417871af > Upgrade Mina to 1.1.7 > - > > Key: QPID-2498 > URL: https://issues.apache.org/jira/browse/QPID-2498 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Affects Versions: 0.6 >Reporter: Emmanuel Bourg >Assignee: Andrew Kennedy > Fix For: 0.11 > > Attachments: mina-update.patch, mina-upgrade.patch > > > Upgrading Mina to 1.1.7 would allow the removal of > backport-util-concurrent.jar from the dependencies. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
Re: [jira] Commented: (QPID-2498) Upgrade Mina to 1.1.7
Le 19/10/2010 15:26, Rajith Attapattu a écrit : IIRC you also had a patch for removing MINA ByteBuffers from the client/common code. If you don't mind could you please post the JIRA number and the patch (attached to JIRA with license box checked). I started working on this but the patch is incomplete. I didn't address the auto growing buffer for the JMS messages. I got lost in the messages life cycle and I didn't have enough tests to ensure nothing was getting broken. The patch is attached to QPID-2627. I have already filed a CLA with the ASF, so feel free to use my contributions :) Emmanuel Bourg smime.p7s Description: S/MIME Cryptographic Signature
Re: [jira] Commented: (QPID-2498) Upgrade Mina to 1.1.7
Emmanuel, IIRC you also had a patch for removing MINA ByteBuffers from the client/common code. If you don't mind could you please post the JIRA number and the patch (attached to JIRA with license box checked). One of my goals for the next release is to get rid of MINA deps from the client and common code. If you have already done some work I would like to use that as a base. Andrew have you done any work in this area at all ? I'd like to coordinate with you on this. Regards, Rajith On Tue, Oct 19, 2010 at 9:10 AM, Rajith Attapattu wrote: > > > On Tue, Oct 19, 2010 at 6:04 AM, Emmanuel Bourg wrote: > >> Thank you for taking care of this Andrew. Do you know if it will make it >> into the 0.8 release? >> >> I attached a diff to JIRA. >> >> > All though I would like to see this in the 0.8 release, I think given the > timelines it may not be possible. > It's a shame as you have worked on this for a while now. But I think you > agree that stability is very important here. > > However we are planning to have more frequent releases. So I hope that you > don't have to wait for long for this to be included. > Perhaps we should have another release in Feb/March time frame. > > Since Andrew is already working on the MINA stuff, it's best to get > everything into trunk along with his work. > > Regards, > > Rajith. > > P.S Emmanuel, I really appreciate the work you have done. This is one item > that I wanted to tackle for a while. > > >> Emmanuel Bourg >> >> >> Le 19/10/2010 09:18, Andrew Kennedy a écrit : >> >> >> Thanks for that. I hadn't seen some of the changes you made there, so I >>> have added them to the branch code I am working on, which contains an >>> independently arrived at MINA 1.1.7 upgrade. (see QPID-2811 for the >>> rest, not yet completed.) >>> >>> I'll credit you for the upgrade patch when I commit my changes to TRUNK, >>> since they are identical and you implemented it first. However, I think >>> you need to attach a physical patch file to the JIRA, in order to >>> fulfill ASF copyright requirements. >>> >>> Andrew. >>> >> >> >> > > > -- > Regards, > > Rajith Attapattu > Red Hat > http://rajith.2rlabs.com/ > -- Regards, Rajith Attapattu Red Hat http://rajith.2rlabs.com/
Re: [jira] Commented: (QPID-2498) Upgrade Mina to 1.1.7
On Tue, Oct 19, 2010 at 6:04 AM, Emmanuel Bourg wrote: > Thank you for taking care of this Andrew. Do you know if it will make it > into the 0.8 release? > > I attached a diff to JIRA. > > All though I would like to see this in the 0.8 release, I think given the timelines it may not be possible. It's a shame as you have worked on this for a while now. But I think you agree that stability is very important here. However we are planning to have more frequent releases. So I hope that you don't have to wait for long for this to be included. Perhaps we should have another release in Feb/March time frame. Since Andrew is already working on the MINA stuff, it's best to get everything into trunk along with his work. Regards, Rajith. P.S Emmanuel, I really appreciate the work you have done. This is one item that I wanted to tackle for a while. > Emmanuel Bourg > > > Le 19/10/2010 09:18, Andrew Kennedy a écrit : > > > Thanks for that. I hadn't seen some of the changes you made there, so I >> have added them to the branch code I am working on, which contains an >> independently arrived at MINA 1.1.7 upgrade. (see QPID-2811 for the >> rest, not yet completed.) >> >> I'll credit you for the upgrade patch when I commit my changes to TRUNK, >> since they are identical and you implemented it first. However, I think >> you need to attach a physical patch file to the JIRA, in order to >> fulfill ASF copyright requirements. >> >> Andrew. >> > > > -- Regards, Rajith Attapattu Red Hat http://rajith.2rlabs.com/
Re: [jira] Commented: (QPID-2498) Upgrade Mina to 1.1.7
Thank you for taking care of this Andrew. Do you know if it will make it into the 0.8 release? I attached a diff to JIRA. Emmanuel Bourg Le 19/10/2010 09:18, Andrew Kennedy a écrit : Thanks for that. I hadn't seen some of the changes you made there, so I have added them to the branch code I am working on, which contains an independently arrived at MINA 1.1.7 upgrade. (see QPID-2811 for the rest, not yet completed.) I'll credit you for the upgrade patch when I commit my changes to TRUNK, since they are identical and you implemented it first. However, I think you need to attach a physical patch file to the JIRA, in order to fulfill ASF copyright requirements. Andrew. smime.p7s Description: S/MIME Cryptographic Signature
Re: [jira] Commented: (QPID-2498) Upgrade Mina to 1.1.7
Emmanuel, Thanks for that. I hadn't seen some of the changes you made there, so I have added them to the branch code I am working on, which contains an independently arrived at MINA 1.1.7 upgrade. (see QPID-2811 for the rest, not yet completed.) I'll credit you for the upgrade patch when I commit my changes to TRUNK, since they are identical and you implemented it first. However, I think you need to attach a physical patch file to the JIRA, in order to fulfill ASF copyright requirements. Andrew. -- -- andrew d kennedy ? do not fold, bend, spindle, or mutilate ; -- http://grkvlt.blogspot.com/ ? edinburgh : +44 7941 197 134 ; On 19 Oct 2010, at 00:42, Emmanuel Bourg (JIRA) wrote: [ https://issues.apache.org/jira/browse/QPID-2498? page=com.atlassian.jira.plugin.system.issuetabpanels:comment- tabpanel&focusedCommentId=12922357#action_12922357 ] Emmanuel Bourg commented on QPID-2498: -- I updated the patch, it's now available as a branch on Github. Please let me know if this format is not suitable. http://github.com/ebourg/qpid/tree/mina-upgrade http://github.com/ebourg/qpid/commit/ 7c4f9e87788261c36ed804f3a13e8ae0c1891205 Upgrade Mina to 1.1.7 - Key: QPID-2498 URL: https://issues.apache.org/jira/browse/QPID-2498 Project: Qpid Issue Type: Improvement Components: Java Broker, Java Client Affects Versions: 0.6 Reporter: Emmanuel Bourg Assignee: Martin Ritchie Fix For: 0.7 Attachments: mina-update.patch Upgrading Mina to 1.1.7 would allow the removal of backport-util- concurrent.jar from the dependencies. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-2498) Upgrade Mina to 1.1.7
[ https://issues.apache.org/jira/browse/QPID-2498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922357#action_12922357 ] Emmanuel Bourg commented on QPID-2498: -- I updated the patch, it's now available as a branch on Github. Please let me know if this format is not suitable. http://github.com/ebourg/qpid/tree/mina-upgrade http://github.com/ebourg/qpid/commit/7c4f9e87788261c36ed804f3a13e8ae0c1891205 > Upgrade Mina to 1.1.7 > - > > Key: QPID-2498 > URL: https://issues.apache.org/jira/browse/QPID-2498 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Affects Versions: 0.6 >Reporter: Emmanuel Bourg >Assignee: Martin Ritchie > Fix For: 0.7 > > Attachments: mina-update.patch > > > Upgrading Mina to 1.1.7 would allow the removal of > backport-util-concurrent.jar from the dependencies. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
Re: [jira] Commented: (QPID-2498) Upgrade Mina to 1.1.7
Hi, I've also been working on this as part of my attempts to streamline the network transport layers. I have updated Mina to 1.1.7 in pretty much the same way as part of this. Currently I have an almost working version of this, but there are still issues, particularly around in-vm communication. Although this may not be ready for 0.8, I would be happy to create a branch and check it in there if people are interested? Andrew. -- -- andrew d kennedy ? edinburgh : +44 7941 197 134 On 28 September 2010 13:14, Emmanuel Bourg (JIRA) wrote: > >[ > https://issues.apache.org/jira/browse/QPID-2498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915719#action_12915719 > ] > > Emmanuel Bourg commented on QPID-2498: > -- > > Is there any chance to get this into the 0.8 release? If someone can review > this issue I'll happily update my patch. > >> Upgrade Mina to 1.1.7 >> - >> >> Key: QPID-2498 >> URL: https://issues.apache.org/jira/browse/QPID-2498 >> Project: Qpid >> Issue Type: Improvement >> Components: Java Broker, Java Client >>Affects Versions: 0.6 >>Reporter: Emmanuel Bourg >>Assignee: Martin Ritchie >> Fix For: 0.7 >> >> Attachments: mina-update.patch >> >> >> Upgrading Mina to 1.1.7 would allow the removal of >> backport-util-concurrent.jar from the dependencies. > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > > > - > Apache Qpid - AMQP Messaging Implementation > Project: http://qpid.apache.org > Use/Interact: mailto:dev-subscr...@qpid.apache.org > > - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-2498) Upgrade Mina to 1.1.7
[ https://issues.apache.org/jira/browse/QPID-2498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915719#action_12915719 ] Emmanuel Bourg commented on QPID-2498: -- Is there any chance to get this into the 0.8 release? If someone can review this issue I'll happily update my patch. > Upgrade Mina to 1.1.7 > - > > Key: QPID-2498 > URL: https://issues.apache.org/jira/browse/QPID-2498 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Affects Versions: 0.6 >Reporter: Emmanuel Bourg >Assignee: Martin Ritchie > Fix For: 0.7 > > Attachments: mina-update.patch > > > Upgrading Mina to 1.1.7 would allow the removal of > backport-util-concurrent.jar from the dependencies. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-2498) Upgrade Mina to 1.1.7
[ https://issues.apache.org/jira/browse/QPID-2498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871085#action_12871085 ] Emmanuel Bourg commented on QPID-2498: -- Martin, let me know if you need an updated patch when you are ready to review this change, I'll provide one. > Upgrade Mina to 1.1.7 > - > > Key: QPID-2498 > URL: https://issues.apache.org/jira/browse/QPID-2498 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Affects Versions: 0.6 >Reporter: Emmanuel Bourg >Assignee: Martin Ritchie > Fix For: 0.7 > > Attachments: mina-poms.patch, mina.patch, mina2.patch > > > Upgrading Mina to 1.1.7 would allow the removal of > backport-util-concurrent.jar from the dependencies. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-2498) Upgrade Mina to 1.1.7
[ https://issues.apache.org/jira/browse/QPID-2498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859710#action_12859710 ] Martin Ritchie commented on QPID-2498: -- Hi Emmanuel, Thanks for the patches I'll take a look at these over the next few days. Cheers Martin > Upgrade Mina to 1.1.7 > - > > Key: QPID-2498 > URL: https://issues.apache.org/jira/browse/QPID-2498 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Affects Versions: 0.6 >Reporter: Emmanuel Bourg >Assignee: Martin Ritchie > Fix For: 0.7 > > Attachments: mina-poms.patch, mina.patch, mina2.patch > > > Upgrading Mina to 1.1.7 would allow the removal of > backport-util-concurrent.jar from the dependencies. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
[jira] Commented: (QPID-2498) Upgrade Mina to 1.1.7
[ https://issues.apache.org/jira/browse/QPID-2498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857250#action_12857250 ] Emmanuel Bourg commented on QPID-2498: -- There are some unused classes in the mina package that could also be removed: org.apache.mina.common.FixedSizeByteBufferAllocator org.apache.mina.common.support.DefaultIoFuture org.apache.mina.filter.codec.OurCumulativeProtocolDecoder org.apache.mina.filter.codec.QpidProtocolCodecFilter > Upgrade Mina to 1.1.7 > - > > Key: QPID-2498 > URL: https://issues.apache.org/jira/browse/QPID-2498 > Project: Qpid > Issue Type: Improvement > Components: Java Broker, Java Client >Affects Versions: 0.6 >Reporter: Emmanuel Bourg > Fix For: 0.7 > > Attachments: mina.patch > > > Upgrading Mina to 1.1.7 would allow the removal of > backport-util-concurrent.jar from the dependencies. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
