Re: Review Request 36546: PROTON-930: extract numeric default values from AMQP xml at build-time.

[michael goulish]

> On July 16, 2015, 2:51 p.m., Andrew Stitcher wrote:
> > proton-c/src/protocol.h.py, line 32
> > 
> >
> > Perhaps the constants should have a prefix like AMQP_ ? It would make 
> > them a bit long though, and I don't remember if that is consistent with the 
> > other definitions output here or not.
> > 
> > Perhaps ping Rafi and ask him for an opinion too.

I do think the AMQP_ should be prepended to make it clear that these constants 
are extracted from the spec xml.   But I am asking Rafi to take a glance.


- michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36546/#review91888
---


On July 16, 2015, 1:52 p.m., michael goulish wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36546/
> ---
> 
> (Updated July 16, 2015, 1:52 p.m.)
> 
> 
> Review request for qpid and Andrew Stitcher.
> 
> 
> Repository: qpid-proton-git
> 
> 
> Description
> ---
> 
> PROTON-930: extract numeric default values from AMQP xml at build-time.
> 
> 
> Diffs
> -
> 
>   proton-c/src/protocol.h.py bbc0dfe 
>   proton-c/src/transport/transport.c 7bce3b5 
> 
> Diff: https://reviews.apache.org/r/36546/diff/
> 
> 
> Testing
> ---
> 
> build
> ctest -VV
> 
> 
> Thanks,
> 
> michael goulish
> 
>

Re: Review Request 36546: PROTON-930: extract numeric default values from AMQP xml at build-time.

[michael goulish]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36546/
---

(Updated July 17, 2015, 9:09 a.m.)


Review request for qpid, Andrew Stitcher and Rafael Schloming.


Changes
---

prepend AMQP to spec-mandated default constants.  (I meant to do this before.)  
The names are as long as they need to be for clarity.


Repository: qpid-proton-git


Description
---

PROTON-930: extract numeric default values from AMQP xml at build-time.


Diffs (updated)
-

  proton-c/src/protocol.h.py bbc0dfe 
  proton-c/src/transport/transport.c 7bce3b5 

Diff: https://reviews.apache.org/r/36546/diff/


Testing (updated)
---

build
ctest -VV

This code creates the following new code near the top of protocol.h

/* Numeric default values */
#define AMQP_OPEN_MAX_FRAME_SIZE_DEFAULT 4294967295
#define AMQP_OPEN_CHANNEL_MAX_DEFAULT 65535
#define AMQP_BEGIN_HANDLE_MAX_DEFAULT 4294967295
#define AMQP_SOURCE_TIMEOUT_DEFAULT 0
#define AMQP_TARGET_TIMEOUT_DEFAULT 0


Thanks,

michael goulish

Re: Review Request 36546: PROTON-930: extract numeric default values from AMQP xml at build-time.

[Andrew Stitcher]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36546/#review91888
---



proton-c/src/protocol.h.py (line 32)


Perhaps the constants should have a prefix like AMQP_ ? It would make them 
a bit long though, and I don't remember if that is consistent with the other 
definitions output here or not.

Perhaps ping Rafi and ask him for an opinion too.



proton-c/src/transport/transport.c (line 408)


Hey, look at all those space errors!


- Andrew Stitcher


On July 16, 2015, 1:52 p.m., michael goulish wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36546/
> ---
> 
> (Updated July 16, 2015, 1:52 p.m.)
> 
> 
> Review request for qpid and Andrew Stitcher.
> 
> 
> Repository: qpid-proton-git
> 
> 
> Description
> ---
> 
> PROTON-930: extract numeric default values from AMQP xml at build-time.
> 
> 
> Diffs
> -
> 
>   proton-c/src/protocol.h.py bbc0dfe 
>   proton-c/src/transport/transport.c 7bce3b5 
> 
> Diff: https://reviews.apache.org/r/36546/diff/
> 
> 
> Testing
> ---
> 
> build
> ctest -VV
> 
> 
> Thanks,
> 
> michael goulish
> 
>

Review Request 36546: PROTON-930: extract numeric default values from AMQP xml at build-time.

[michael goulish]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36546/
---

Review request for qpid and Andrew Stitcher.


Repository: qpid-proton-git


Description
---

PROTON-930: extract numeric default values from AMQP xml at build-time.


Diffs
-

  proton-c/src/protocol.h.py bbc0dfe 
  proton-c/src/transport/transport.c 7bce3b5 

Diff: https://reviews.apache.org/r/36546/diff/


Testing
---

build
ctest -VV


Thanks,

michael goulish