[GitHub] liubao68 closed pull request #662: [SCB-507] avoid rest publisher get NaN values when there is no period publisher

[GitBox]

liubao68 closed pull request #662: [SCB-507] avoid rest publisher get NaN 
values when there is no period publisher
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/662
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/foundations/foundation-metrics/src/main/java/org/apache/servicecomb/foundation/metrics/MetricsBootstrap.java
 
b/foundations/foundation-metrics/src/main/java/org/apache/servicecomb/foundation/metrics/MetricsBootstrap.java
index 335d7c56a..1a6c0d132 100644
--- 
a/foundations/foundation-metrics/src/main/java/org/apache/servicecomb/foundation/metrics/MetricsBootstrap.java
+++ 
b/foundations/foundation-metrics/src/main/java/org/apache/servicecomb/foundation/metrics/MetricsBootstrap.java
@@ -29,6 +29,7 @@
 import com.google.common.eventbus.EventBus;
 import com.google.common.util.concurrent.ThreadFactoryBuilder;
 import com.netflix.spectator.api.CompositeRegistry;
+import com.netflix.spectator.api.Measurement;
 import com.netflix.spectator.api.Meter;
 
 public class MetricsBootstrap {
@@ -77,7 +78,13 @@ protected void startPoll() {
 
   protected void pollMeters() {
 List meters = Lists.newArrayList(globalRegistry.iterator());
-PolledEvent event = new PolledEvent(meters);
+// must collect measurements
+// otherwise if there is no any period publisher, normal publisher maybe 
get NaN values 
+List measurements = new ArrayList<>();
+for (Meter meter : meters) {
+  meter.measure().forEach(measurements::add);
+}
+PolledEvent event = new PolledEvent(meters, measurements);
 
 eventBus.post(event);
   }
diff --git 
a/foundations/foundation-metrics/src/main/java/org/apache/servicecomb/foundation/metrics/PolledEvent.java
 
b/foundations/foundation-metrics/src/main/java/org/apache/servicecomb/foundation/metrics/PolledEvent.java
index b2aa0709b..6b7c3018c 100644
--- 
a/foundations/foundation-metrics/src/main/java/org/apache/servicecomb/foundation/metrics/PolledEvent.java
+++ 
b/foundations/foundation-metrics/src/main/java/org/apache/servicecomb/foundation/metrics/PolledEvent.java
@@ -18,13 +18,17 @@
 
 import java.util.List;
 
+import com.netflix.spectator.api.Measurement;
 import com.netflix.spectator.api.Meter;
 
 public class PolledEvent {
   private List meters;
 
-  public PolledEvent(List meters) {
+  private List measurements;
+
+  public PolledEvent(List meters, List measurements) {
 this.meters = meters;
+this.measurements = measurements;
   }
 
   public List getMeters() {
@@ -34,4 +38,12 @@ public PolledEvent(List meters) {
   public void setMeters(List meters) {
 this.meters = meters;
   }
+
+  public List getMeasurements() {
+return measurements;
+  }
+
+  public void setMeasurements(List measurements) {
+this.measurements = measurements;
+  }
 }
diff --git 
a/foundations/foundation-metrics/src/test/java/org/apache/servicecomb/foundation/metrics/TestMetricsBootstrap.java
 
b/foundations/foundation-metrics/src/test/java/org/apache/servicecomb/foundation/metrics/TestMetricsBootstrap.java
index a8fd7ecd2..b73834b7f 100644
--- 
a/foundations/foundation-metrics/src/test/java/org/apache/servicecomb/foundation/metrics/TestMetricsBootstrap.java
+++ 
b/foundations/foundation-metrics/src/test/java/org/apache/servicecomb/foundation/metrics/TestMetricsBootstrap.java
@@ -19,7 +19,9 @@
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
+import java.util.concurrent.Executors;
 import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.ThreadFactory;
 
 import org.apache.servicecomb.foundation.common.utils.SPIServiceUtils;
 import org.hamcrest.Matchers;
@@ -29,6 +31,7 @@
 import com.google.common.eventbus.EventBus;
 import com.google.common.eventbus.Subscribe;
 import com.netflix.spectator.api.CompositeRegistry;
+import com.netflix.spectator.api.Measurement;
 import com.netflix.spectator.api.Meter;
 
 import mockit.Deencapsulation;
@@ -66,22 +69,27 @@ public void init(CompositeRegistry globalRegistry, EventBus 
eventBus, MetricsBoo
   }
 
   @Test
-  public void pollMeters() {
-bootstrap.start(globalRegistry, eventBus);
-
-List meters = new ArrayList<>();
-new Expectations() {
+  public void pollMeters(@Mocked Meter meter, @Mocked Measurement measurement,
+  @Mocked ScheduledExecutorService executor) {
+List meters = Arrays.asList(meter);
+new Expectations(Executors.class) {
   {
+Executors.newScheduledThreadPool(1, (ThreadFactory) any);
+result = executor;
 globalRegistry.iterator();
 result = meters.iterator();
+meter.measure();
+result = Arrays.asList(measurement);
   }
 };
+bootstrap.start(globalRegistry, eventBus);
 
-PolledEvent result = new 

[GitHub] xuyiyun0929 opened a new pull request #663: Upgrade jackson

[GitBox]

xuyiyun0929 opened a new pull request #663: Upgrade jackson
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/663
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #662: [SCB-507] avoid rest publisher get NaN values when there is no period publisher

[GitBox]

coveralls commented on issue #662: [SCB-507] avoid rest publisher get NaN 
values when there is no period publisher
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/662#issuecomment-382971337
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16612108/badge)](https://coveralls.io/builds/16612108)
   
   Coverage increased (+0.006%) to 87.496% when pulling 
**953b94c71c4c349f2a7abf0ecf2ad653bc4ba026 on wujimin:fix-metrics-poll-task** 
into **94f034ac5de9c64993b25db119be3aa8e69d435f on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] liubao68 closed pull request #661: [SCB-494] Delete temp file after download

[GitBox]

liubao68 closed pull request #661: [SCB-494] Delete temp file after download
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/661
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/server/DownloadSchema.java
 
b/demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/server/DownloadSchema.java
index 0fbd6ee69..712551189 100644
--- 
a/demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/server/DownloadSchema.java
+++ 
b/demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/server/DownloadSchema.java
@@ -21,12 +21,16 @@
 import java.io.IOException;
 import java.io.InputStream;
 import java.nio.charset.StandardCharsets;
+import java.util.UUID;
 
+import javax.servlet.http.Part;
+
+import org.apache.commons.io.FileUtils;
+import org.apache.servicecomb.foundation.common.part.FilePart;
 import org.apache.servicecomb.provider.rest.common.RestSchema;
 import org.springframework.core.io.ByteArrayResource;
 import org.springframework.core.io.Resource;
 import org.springframework.http.HttpHeaders;
-import org.springframework.http.MediaType;
 import org.springframework.http.ResponseEntity;
 import org.springframework.web.bind.annotation.GetMapping;
 import org.springframework.web.bind.annotation.RequestMapping;
@@ -35,8 +39,44 @@
 import io.swagger.annotations.ApiResponses;
 
 @RestSchema(schemaId = "download")
-@RequestMapping(path = "/download", produces = 
MediaType.APPLICATION_OCTET_STREAM_VALUE)
+@RequestMapping(path = "/download")
 public class DownloadSchema {
+  File tempDir = new File("downloadTemp");
+
+  public DownloadSchema() throws IOException {
+FileUtils.forceMkdir(tempDir);
+  }
+
+  // content is file name
+  protected File createTempFile() throws IOException {
+String name = "download-" + UUID.randomUUID().toString() + ".txt";
+File file = new File(tempDir, name);
+FileUtils.write(file, name);
+return file;
+  }
+
+  // customize HttpHeaders.CONTENT_DISPOSITION to be 
"attachment;filename=tempFileEntity.txt"
+  @GetMapping(path = "/tempFileEntity")
+  public ResponseEntity downloadTempFileEntity() throws IOException {
+File file = createTempFile();
+
+return ResponseEntity
+.ok()
+.header(HttpHeaders.CONTENT_DISPOSITION, 
"attachment;filename=tempFileEntity.txt")
+.body(new FilePart(null, file)
+.setDeleteAfterFinished(true));
+  }
+
+  // generate HttpHeaders.CONTENT_DISPOSITION to be 
"attachment;filename=tempFilePart.txt" automatically
+  @GetMapping(path = "/tempFilePart")
+  public Part downloadTempFilePart() throws IOException {
+File file = createTempFile();
+
+return new FilePart(null, file)
+.setDeleteAfterFinished(true)
+.setSubmittedFileName("tempFilePart.txt");
+  }
+
   @GetMapping(path = "/file")
   public File downloadFile() throws IOException {
 return new 
File(this.getClass().getClassLoader().getResource("microservice.yaml").getFile());
diff --git 
a/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/part/AbstractPart.java
 
b/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/part/AbstractPart.java
index 4027f8f88..653d0f909 100644
--- 
a/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/part/AbstractPart.java
+++ 
b/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/part/AbstractPart.java
@@ -60,9 +60,10 @@ public String getSubmittedFileName() {
 return submittedFileName;
   }
 
-  public void setSubmittedFileName(String submittedFileName) {
+  public AbstractPart setSubmittedFileName(String submittedFileName) {
 this.submittedFileName = submittedFileName;
 updateContentType();
+return this;
   }
 
   private void updateContentType() {
diff --git 
a/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/part/FilePart.java
 
b/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/part/FilePart.java
index 2b2a4da62..ef2904797 100644
--- 
a/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/part/FilePart.java
+++ 
b/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/part/FilePart.java
@@ -24,9 +24,11 @@
 
 import org.apache.commons.io.FileUtils;
 
-public class FilePart extends AbstractPart {
+public class FilePart extends AbstractPart implements FilePartForSend {
   private File file;
 
+  private boolean deleteAfterFinished;
+
   public FilePart(String name, String 

[GitHub] liubao68 closed pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration

[GitBox]

liubao68 closed pull request #658: [SCB-474] add endpoint filter (only rest 
endpoints) for zuul integration
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/658
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/demo/demo-spring-boot-discovery/demo-spring-boot-discovery-server/src/main/resources/microservice.yaml
 
b/demo/demo-spring-boot-discovery/demo-spring-boot-discovery-server/src/main/resources/microservice.yaml
index 95d89ae36..1be593db4 100644
--- 
a/demo/demo-spring-boot-discovery/demo-spring-boot-discovery-server/src/main/resources/microservice.yaml
+++ 
b/demo/demo-spring-boot-discovery/demo-spring-boot-discovery-server/src/main/resources/microservice.yaml
@@ -25,6 +25,9 @@ cse:
   address: http://127.0.0.1:30100
   rest:
 address: 0.0.0.0:8080
+  #add highway for test filter
+  highway:
+address: 0.0.0.0:7070
   handler:
 chain:
   Provider:
diff --git 
a/demo/demo-spring-boot-discovery/demo-spring-boot-zuul-proxy/src/test/java/org/apache/servicecomb/demo/discovery/zuul/DiscoveryZuulProxyIT.java
 
b/demo/demo-spring-boot-discovery/demo-spring-boot-zuul-proxy/src/test/java/org/apache/servicecomb/demo/discovery/zuul/DiscoveryZuulProxyIT.java
index 7de82872f..ed3a9631a 100644
--- 
a/demo/demo-spring-boot-discovery/demo-spring-boot-zuul-proxy/src/test/java/org/apache/servicecomb/demo/discovery/zuul/DiscoveryZuulProxyIT.java
+++ 
b/demo/demo-spring-boot-discovery/demo-spring-boot-zuul-proxy/src/test/java/org/apache/servicecomb/demo/discovery/zuul/DiscoveryZuulProxyIT.java
@@ -40,13 +40,16 @@
   private TestRestTemplate restTemplate;
 
   @Test
-  public void getsRemoteServiceThroughGateway() throws Exception {
-String response = restTemplate.getForObject(
-"/gateway/greeting/sayhello/{name}",
-String.class,
-"Mike");
+  public void getsRemoteServiceThroughGateway() {
+//loop three time to insure only rest endpoint get
+for (int i = 0; i < 3; i++) {
+  String response = restTemplate.getForObject(
+  "/gateway/greeting/sayhello/{name}",
+  String.class,
+  "Mike");
 
-assertThat(response).isEqualTo("hello Mike");
+  assertThat(response).isEqualTo("hello Mike");
+}
   }
 
   @SpringBootApplication
@@ -55,7 +58,7 @@ public void getsRemoteServiceThroughGateway() throws 
Exception {
   @EnableServiceComb
   static class DiscoveryZuulProxy {
 
-public static void main(String[] args) throws Exception {
+public static void main(String[] args) {
   SpringApplication.run(DiscoveryZuulProxy.class, args);
 }
   }
diff --git a/samples/bmi/webapp/pom.xml b/samples/bmi/webapp/pom.xml
index 4581ea358..23ae4fab2 100644
--- a/samples/bmi/webapp/pom.xml
+++ b/samples/bmi/webapp/pom.xml
@@ -33,6 +33,11 @@
   org.springframework.boot
   spring-boot-starter
 
+
+
+  org.apache.servicecomb
+  transport-rest-vertx
+
 
   org.apache.servicecomb
   spring-boot-starter-servicecomb
diff --git 
a/spring-boot-starter/spring-boot-starter-discovery/src/main/java/org/apache/servicecomb/springboot/starter/discovery/CseRibbonEndpointDiscoveryFilter.java
 
b/spring-boot-starter/spring-boot-starter-discovery/src/main/java/org/apache/servicecomb/springboot/starter/discovery/CseRibbonEndpointDiscoveryFilter.java
new file mode 100644
index 0..65f72d7a3
--- /dev/null
+++ 
b/spring-boot-starter/spring-boot-starter-discovery/src/main/java/org/apache/servicecomb/springboot/starter/discovery/CseRibbonEndpointDiscoveryFilter.java
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.springboot.starter.discovery;
+
+import org.apache.servicecomb.foundation.common.net.URIEndpointObject;
+import 
org.apache.servicecomb.serviceregistry.api.registry.MicroserviceInstance;
+import 
org.apache.servicecomb.serviceregistry.discovery.AbstractEndpointDiscoveryFilter;
+import 

[GitHub] little-cui commented on issue #328: [SCB-479] Add proxy to service-center in frontend

[GitBox]

little-cui commented on issue #328: [SCB-479] Add proxy to service-center in 
frontend
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/328#issuecomment-382956261
 
 
   Why do not use the standard package httputil.ReverseProxy ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration

[GitBox]

coveralls commented on issue #658: [SCB-474] add endpoint filter (only rest 
endpoints) for zuul integration
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/658#issuecomment-382350160
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16611492/badge)](https://coveralls.io/builds/16611492)
   
   Coverage increased (+0.04%) to 87.478% when pulling 
**8ad68fea89b144e856fef47e40dfd611c64360b3 on zhengyangyong:SCB-474** into 
**41049be9d9b41d32fbdf4e12f613d6e85ab21301 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #661: [SCB-494] Delete temp file after download

[GitBox]

coveralls commented on issue #661: [SCB-494] Delete temp file after download
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/661#issuecomment-382950841
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16611419/badge)](https://coveralls.io/builds/16611419)
   
   Coverage decreased (-0.09%) to 87.376% when pulling 
**4fd6d197b6206ad8544f35d65b2a3a16fe910781 on 
wujimin:delete-temp-file-after-download** into 
**719a079592fa3dabd1f251599462df88ef7f68e5 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin opened a new pull request #662: [SCB-507] avoid rest publisher get NaN values when there is no period publisher

[GitBox]

wujimin opened a new pull request #662: [SCB-507] avoid rest publisher get NaN 
values when there is no period publisher
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/662
 
 
   
![image](https://user-images.githubusercontent.com/16874843/39027943-e5198206-4486-11e8-967a-1f95d17c0718.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zhengyangyong commented on a change in pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration

[GitBox]

zhengyangyong commented on a change in pull request #658: [SCB-474] add 
endpoint filter (only rest endpoints) for zuul integration
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/658#discussion_r182931277
 
 

 ##
 File path: 
spring-boot-starter/spring-boot-starter-discovery/src/main/java/org/apache/servicecomb/springboot/starter/discovery/CseRibbonEndpointDiscoveryFilter.java
 ##
 @@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.springboot.starter.discovery;
+
+import org.apache.servicecomb.core.filter.EndpointDiscoveryFilter;
+import org.apache.servicecomb.serviceregistry.discovery.DiscoveryContext;
+import org.apache.servicecomb.serviceregistry.discovery.DiscoveryTreeNode;
+
+public class CseRibbonEndpointDiscoveryFilter extends EndpointDiscoveryFilter {
 
 Review comment:
   Done


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zhengyangyong commented on a change in pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration

[GitBox]

zhengyangyong commented on a change in pull request #658: [SCB-474] add 
endpoint filter (only rest endpoints) for zuul integration
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/658#discussion_r182931334
 
 

 ##
 File path: spring-boot-starter/spring-boot-starter-discovery/pom.xml
 ##
 @@ -73,7 +73,7 @@


org.apache.servicecomb
-   service-registry
+   java-chassis-core
 
 Review comment:
   Done,now CseRibbonEndpointDiscoveryFilter extend from 
AbstractEndpointDiscoveryFilter


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zhengyangyong commented on a change in pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration

[GitBox]

zhengyangyong commented on a change in pull request #658: [SCB-474] add 
endpoint filter (only rest endpoints) for zuul integration
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/658#discussion_r182931282
 
 

 ##
 File path: 
spring-boot-starter/spring-boot-starter-discovery/src/main/java/org/apache/servicecomb/springboot/starter/discovery/ServiceCombServerList.java
 ##
 @@ -49,13 +49,11 @@ public ServiceCombServerList() {
 RegistryUtils.getAppId(),
 serviceId,
 DefinitionConst.VERSION_RULE_ALL);
-Map servers = serversVersionedCache.data();
-List instances = new ArrayList<>(servers.size());
-for (MicroserviceInstance s : servers.values()) {
-  for (String endpoint : s.getEndpoints()) {
-URIEndpointObject uri = new URIEndpointObject(endpoint);
-instances.add(new Server(uri.getHostOrIp(), uri.getPort()));
-  }
+ArrayList endpoints = serversVersionedCache.data();
 
 Review comment:
   Done


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] liubao68 commented on issue #618: Any example for using this micro-service framework without Spring?

[GitBox]

liubao68 commented on issue #618: Any example for using this micro-service 
framework without Spring?
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/issues/618#issuecomment-382944848
 
 
   Some of the core components use spring features, and most important part 
like Spring MVC programming feature. Thus java-chassis can not run without 
spring yet. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] liubao68 commented on issue #654: java-chassis依赖的springboot版本过低

[GitBox]

liubao68 commented on issue #654: java-chassis依赖的springboot版本过低
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/issues/654#issuecomment-382944214
 
 
   java-chassis和spring boot的依赖关系是很松的，是作为它的一个组件使用。 应该你很容易使用spring 
boot的高版本集成和使用java-chassis。 
说明参考：https://java.huaweicse.com/using-cse-in-spring-boot.html


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin opened a new pull request #661: [SCB-494] Delete temp file after download

[GitBox]

wujimin opened a new pull request #661: [SCB-494] Delete temp file after 
download
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/661
 
 
   
![image](https://user-images.githubusercontent.com/16874843/39027017-8b75dc58-4482-11e8-8a5b-5bf267dbc755.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #651: [SCB-498] Configuration Center ip address need to config default port

[GitBox]

coveralls commented on issue #651: [SCB-498] Configuration Center ip address 
need to config default port
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/651#issuecomment-381932927
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/1665/badge)](https://coveralls.io/builds/1665)
   
   Coverage increased (+0.02%) to 87.465% when pulling 
**2166c248e2338418337a51b8c73394e2ad836dad on weichao666:addDefaultPort** into 
**41049be9d9b41d32fbdf4e12f613d6e85ab21301 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] liubao68 closed pull request #653: [SCB-483] Springmvc rest vertx file download

[GitBox]

liubao68 closed pull request #653: [SCB-483] Springmvc rest vertx file download
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/653
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/common/common-javassist/src/test/java/org/apache/servicecomb/common/javassist/TestJavassistUtils.java
 
b/common/common-javassist/src/test/java/org/apache/servicecomb/common/javassist/TestJavassistUtils.java
index 73c4c7ff1..a69eb0fd7 100644
--- 
a/common/common-javassist/src/test/java/org/apache/servicecomb/common/javassist/TestJavassistUtils.java
+++ 
b/common/common-javassist/src/test/java/org/apache/servicecomb/common/javassist/TestJavassistUtils.java
@@ -152,7 +152,7 @@ public void singleWrapperInt() throws Exception {
   public void multiWrapper() throws Exception {
 ClassConfig classConfig = new ClassConfig();
 classConfig.setClassName("cse.ut.multi.Wrapper");
-classConfig.addField("intField", (Type) int.class);
+classConfig.addField("intField", int.class);
 classConfig.addField("strField", String.class);
 
 JavassistUtils.genMultiWrapperInterface(classConfig);
@@ -161,7 +161,7 @@ public void multiWrapper() throws Exception {
 
 MultiWrapper instance = (MultiWrapper) wrapperClass.newInstance();
 instance.writeFields(new Object[] {100, "test"});
-Object[] fieldValues = (Object[]) instance.readFields();
+Object[] fieldValues = instance.readFields();
 Assert.assertEquals(100, fieldValues[0]);
 Assert.assertEquals("test", fieldValues[1]);
   }
diff --git 
a/common/common-protobuf/src/main/java/org/apache/servicecomb/codec/protobuf/utils/ProtobufSchemaUtils.java
 
b/common/common-protobuf/src/main/java/org/apache/servicecomb/codec/protobuf/utils/ProtobufSchemaUtils.java
index f1c985fed..8fd1e89dd 100644
--- 
a/common/common-protobuf/src/main/java/org/apache/servicecomb/codec/protobuf/utils/ProtobufSchemaUtils.java
+++ 
b/common/common-protobuf/src/main/java/org/apache/servicecomb/codec/protobuf/utils/ProtobufSchemaUtils.java
@@ -178,7 +178,7 @@ public static WrapSchema 
getOrCreateArgsSchema(OperationMeta operationMeta) {
 return getOrCreateSchema(type, () -> {
   if (!isArgsNeedWrap(method)) {
 // 可以直接使用
-Class cls = (Class) method.getParameterTypes()[0];
+Class cls = method.getParameterTypes()[0];
 Schema schema = RuntimeSchema.createFrom(cls);
 return WrapSchemaFactory.createSchema(schema, WrapType.ARGS_NOT_WRAP);
   }
diff --git 
a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/AbstractRestInvocation.java
 
b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/AbstractRestInvocation.java
index 3dfb5cc62..9a3769b88 100644
--- 
a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/AbstractRestInvocation.java
+++ 
b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/AbstractRestInvocation.java
@@ -17,11 +17,13 @@
 
 package org.apache.servicecomb.common.rest;
 
+import java.io.IOException;
 import java.nio.charset.StandardCharsets;
 import java.util.Collections;
 import java.util.List;
 import java.util.Map;
 import java.util.Map.Entry;
+import java.util.concurrent.CompletableFuture;
 
 import javax.ws.rs.core.HttpHeaders;
 import javax.ws.rs.core.Response.Status;
@@ -31,6 +33,7 @@
 import 
org.apache.servicecomb.common.rest.codec.produce.ProduceProcessorManager;
 import org.apache.servicecomb.common.rest.definition.RestOperationMeta;
 import org.apache.servicecomb.common.rest.filter.HttpServerFilter;
+import 
org.apache.servicecomb.common.rest.filter.HttpServerFilterBeforeSendResponseExecutor;
 import org.apache.servicecomb.common.rest.locator.OperationLocator;
 import org.apache.servicecomb.common.rest.locator.ServicePathManager;
 import org.apache.servicecomb.core.Const;
@@ -194,18 +197,11 @@ protected void sendResponseQuietly(Response response) {
   LOGGER.error("Failed to send rest response, operation:{}.",
   invocation.getMicroserviceQualifiedName(),
   e);
-} finally {
-  requestEx.getAsyncContext().complete();
-  // if failed to locate path, then will not create invocation
-  // TODO: statistics this case
-  if (invocation != null) {
-invocation.onFinish(response);
-  }
 }
   }
 
   @SuppressWarnings("deprecation")
-  protected void sendResponse(Response response) throws Exception {
+  protected void sendResponse(Response response) {
 if (response.getHeaders().getHeaderMap() != null) {
   for (Entry entry : 
response.getHeaders().getHeaderMap().entrySet()) {
 for (Object value : entry.getValue()) {
@@ -216,14 +212,41 @@ protected void sendResponse(Response response) throws 
Exception {
   }
 }

[GitHub] coveralls commented on issue #651: [SCB-498] Configuration Center ip address need to config default port

[GitBox]

coveralls commented on issue #651: [SCB-498] Configuration Center ip address 
need to config default port
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/651#issuecomment-381932927
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16611017/badge)](https://coveralls.io/builds/16611017)
   
   Coverage increased (+0.02%) to 87.459% when pulling 
**2166c248e2338418337a51b8c73394e2ad836dad on weichao666:addDefaultPort** into 
**41049be9d9b41d32fbdf4e12f613d6e85ab21301 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] liubao68 commented on issue #655: rpc模式下生成swagger-ui文档

[GitBox]

liubao68 commented on issue #655: rpc模式下生成swagger-ui文档
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/issues/655#issuecomment-382937830
 
 
   rpc模式下也是会生成契约的，契约可以在service-center查询，也会打印在日志中。 你说的swagger-ui和契约是什么关系？


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] liubao68 commented on issue #659: 是否考虑支持函数重载

[GitBox]

liubao68 commented on issue #659: 是否考虑支持函数重载
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/issues/659#issuecomment-382937182
 
 
   目前是支持函数重载的， 加上@ApiOperation标签即可。每个接口必须有唯一的operation id


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] weichao666 commented on a change in pull request #651: [SCB-498] Configuration Center ip address need to config default port

[GitBox]

weichao666 commented on a change in pull request #651: [SCB-498] Configuration 
Center ip address need to config default port
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/651#discussion_r182926768
 
 

 ##
 File path: 
foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/net/TestNetUtils.java
 ##
 @@ -49,6 +49,10 @@ public void testNetutils() {
 Assert.assertEquals(NetUtils.parseIpPortFromURI(null), null);
 Assert.assertEquals(NetUtils.parseIpPortFromURI("ss"), null);
 
Assert.assertEquals(NetUtils.parseIpPortFromURI("rest://127.0.0.1:8080").getHostOrIp(),
 "127.0.0.1");
+
Assert.assertEquals(NetUtils.parseIpPortFromURI("http://127.0.0.1:8080;).getPort(),
 8080);
 
 Review comment:
   done


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on a change in pull request #648: [SCB-482] Http2 support for java-chassis

[GitBox]

wujimin commented on a change in pull request #648: [SCB-482] Http2 support for 
java-chassis
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#discussion_r182782090
 
 

 ##
 File path: 
transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/RestTransportClient.java
 ##
 @@ -62,7 +77,16 @@ private static HttpClientOptions createHttpClientOptions() {
   }
 
   public void send(Invocation invocation, AsyncResponse asyncResp) throws 
Exception {
-HttpClientWithContext httpClientWithContext = 
clientMgr.findClientPool(invocation.isSync());
+URIEndpointObject endpoint = (URIEndpointObject) 
invocation.getEndpoint().getAddress();
+HttpClientWithContext httpClientWithContext;
+if (endpoint.isHttp2Enabled()) {
+  httpClientWithContext = 
clientMgrHttp2.findClientPool(invocation.isSync());
+  if (!endpoint.isSslEnabled()) {
+((HttpClientImpl) 
httpClientWithContext.getHttpClient()).getOptions().setHttp2ClearTextUpgrade(false);
 
 Review comment:
   invoke a h2c endpoint
   and then for this httpclient instance http2ClearTextUpgrade always be false
   is this expected?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on a change in pull request #648: [SCB-482] Http2 support for java-chassis

[GitBox]

wujimin commented on a change in pull request #648: [SCB-482] Http2 support for 
java-chassis
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#discussion_r182782090
 
 

 ##
 File path: 
transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/RestTransportClient.java
 ##
 @@ -62,7 +77,16 @@ private static HttpClientOptions createHttpClientOptions() {
   }
 
   public void send(Invocation invocation, AsyncResponse asyncResp) throws 
Exception {
-HttpClientWithContext httpClientWithContext = 
clientMgr.findClientPool(invocation.isSync());
+URIEndpointObject endpoint = (URIEndpointObject) 
invocation.getEndpoint().getAddress();
+HttpClientWithContext httpClientWithContext;
+if (endpoint.isHttp2Enabled()) {
+  httpClientWithContext = 
clientMgrHttp2.findClientPool(invocation.isSync());
+  if (!endpoint.isSslEnabled()) {
+((HttpClientImpl) 
httpClientWithContext.getHttpClient()).getOptions().setHttp2ClearTextUpgrade(false);
 
 Review comment:
   multi invocation will share the same httpClient instance when use http2
   so there is concurrence problem here, right?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on a change in pull request #648: [SCB-482] Http2 support for java-chassis

[GitBox]

wujimin commented on a change in pull request #648: [SCB-482] Http2 support for 
java-chassis
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#discussion_r182780365
 
 

 ##
 File path: 
foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/net/URIEndpointObject.java
 ##
 @@ -47,6 +53,10 @@ public URIEndpointObject(String endpoint) {
 setPort(uri.getPort());
 querys = splitQuery(uri);
 sslEnabled = Boolean.parseBoolean(getFirst(SSL_ENABLED_KEY));
+String httpversion = getFirst(HTTP2_ENABLED_KEY);
+if (httpversion != null && httpversion.compareTo(HTTP2) == 0) {
 
 Review comment:
   http2Enabled  = HTTP2.equals(httpVersion)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on a change in pull request #651: [SCB-498] Configuration Center ip address need to config default port

[GitBox]

wujimin commented on a change in pull request #651: [SCB-498] Configuration 
Center ip address need to config default port
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/651#discussion_r182779209
 
 

 ##
 File path: 
foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/net/TestNetUtils.java
 ##
 @@ -49,6 +49,10 @@ public void testNetutils() {
 Assert.assertEquals(NetUtils.parseIpPortFromURI(null), null);
 Assert.assertEquals(NetUtils.parseIpPortFromURI("ss"), null);
 
Assert.assertEquals(NetUtils.parseIpPortFromURI("rest://127.0.0.1:8080").getHostOrIp(),
 "127.0.0.1");
+
Assert.assertEquals(NetUtils.parseIpPortFromURI("http://127.0.0.1:8080;).getPort(),
 8080);
 
 Review comment:
   expect value is the first parameter


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on a change in pull request #651: [SCB-498] Configuration Center ip address need to config default port

[GitBox]

wujimin commented on a change in pull request #651: [SCB-498] Configuration 
Center ip address need to config default port
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/651#discussion_r182778910
 
 

 ##
 File path: sh.exe.stackdump
 ##
 @@ -0,0 +1,11 @@
+Stack trace:
 
 Review comment:
   why we need this file?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin closed pull request #652: [SCB 456]Remove warning

[GitBox]

wujimin closed pull request #652: [SCB 456]Remove warning
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/652
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/foundations/foundation-config/src/test/java/org/apache/servicecomb/config/TestConfigUtil.java
 
b/foundations/foundation-config/src/test/java/org/apache/servicecomb/config/TestConfigUtil.java
index a61555a0e..d5265315e 100644
--- 
a/foundations/foundation-config/src/test/java/org/apache/servicecomb/config/TestConfigUtil.java
+++ 
b/foundations/foundation-config/src/test/java/org/apache/servicecomb/config/TestConfigUtil.java
@@ -79,7 +79,7 @@ public static void tearDown() throws Exception {
 
   @Test
   public void testAddConfig() {
-Map config = new HashMap();
+Map config = new HashMap<>();
 config.put("service_description.name", "service_name_test");
 ConfigUtil.setConfigs(config);
 ConfigUtil.addConfig("service_description.version", "1.0.2");


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on issue #652: [SCB 456]Remove warning

[GitBox]

wujimin commented on issue #652: [SCB 456]Remove warning
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/652#issuecomment-382768277
 
 
   fixed by 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/660
   but reviews have no any response, sigh..


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #660: [SCB-453] Read config from application yaml properties

[GitBox]

coveralls commented on issue #660: [SCB-453] Read config from application yaml 
properties
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/660#issuecomment-382766643
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16599973/badge)](https://coveralls.io/builds/16599973)
   
   Coverage increased (+0.04%) to 87.482% when pulling 
**5977c321f1d8f58dfb1fc5a975ef5c2916736db2 on 
yhs0092:read_config_from_application_yaml_properties** into 
**41049be9d9b41d32fbdf4e12f613d6e85ab21301 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] yhs0092 opened a new pull request #660: [SCB-453] Read config from application yaml properties

[GitBox]

yhs0092 opened a new pull request #660: [SCB-453] Read config from application 
yaml properties
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/660
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   Support reading ServiceComb configurations from 
application.yaml/application.properties
   See [SCB-453](https://issues.apache.org/jira/browse/SCB-453)
   
![compile_warning](https://issues.apache.org/jira/secure/attachment/12919814/Compile_Warning.PNG
 "compile warning")


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zhengyangyong commented on a change in pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration

[GitBox]

zhengyangyong commented on a change in pull request #658: [SCB-474] add 
endpoint filter (only rest endpoints) for zuul integration
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/658#discussion_r182739600
 
 

 ##
 File path: 
spring-boot-starter/spring-boot-starter-discovery/src/main/java/org/apache/servicecomb/springboot/starter/discovery/CseRibbonEndpointDiscoveryFilter.java
 ##
 @@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.springboot.starter.discovery;
+
+import org.apache.servicecomb.core.filter.EndpointDiscoveryFilter;
+import org.apache.servicecomb.serviceregistry.discovery.DiscoveryContext;
+import org.apache.servicecomb.serviceregistry.discovery.DiscoveryTreeNode;
+
+public class CseRibbonEndpointDiscoveryFilter extends EndpointDiscoveryFilter {
 
 Review comment:
   this package also have a set of "Cse.java" in it ,we may rename them by 
the way？


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zhengyangyong commented on a change in pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration

[GitBox]

zhengyangyong commented on a change in pull request #658: [SCB-474] add 
endpoint filter (only rest endpoints) for zuul integration
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/658#discussion_r182740480
 
 

 ##
 File path: 
spring-boot-starter/spring-boot-starter-discovery/src/main/java/org/apache/servicecomb/springboot/starter/discovery/ServiceCombServerList.java
 ##
 @@ -49,13 +49,11 @@ public ServiceCombServerList() {
 RegistryUtils.getAppId(),
 serviceId,
 DefinitionConst.VERSION_RULE_ALL);
-Map servers = serversVersionedCache.data();
-List instances = new ArrayList<>(servers.size());
-for (MicroserviceInstance s : servers.values()) {
-  for (String endpoint : s.getEndpoints()) {
-URIEndpointObject uri = new URIEndpointObject(endpoint);
-instances.add(new Server(uri.getHostOrIp(), uri.getPort()));
-  }
+ArrayList endpoints = serversVersionedCache.data();
 
 Review comment:
   got it


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #651: [SCB-498] Configuration Center ip address need to config default port

[GitBox]

coveralls commented on issue #651: [SCB-498] Configuration Center ip address 
need to config default port
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/651#issuecomment-381932927
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16597412/badge)](https://coveralls.io/builds/16597412)
   
   Coverage increased (+0.007%) to 87.448% when pulling 
**0ed7f69933ddd2ba065570cc4ea90215f9115df1 on weichao666:addDefaultPort** into 
**41049be9d9b41d32fbdf4e12f613d6e85ab21301 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] weichao666 commented on a change in pull request #651: [SCB-498] Configuration Center ip address need to config default port

[GitBox]

weichao666 commented on a change in pull request #651: [SCB-498] Configuration 
Center ip address need to config default port
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/651#discussion_r182720412
 
 

 ##
 File path: 
foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/net/NetUtils.java
 ##
 @@ -145,12 +145,25 @@ public static IpPort parseIpPortFromURI(String 
uriAddress) {
 try {
   URI uri = new URI(uriAddress);
   String authority = uri.getAuthority();
-  return parseIpPort(authority);
+  return parseIpPort(uri.getScheme(), authority);
 } catch (URISyntaxException e) {
   return null;
 }
   }
 
+  private static IpPort parseIpPort(String scheme, String authority) {
+if (authority == null)
+  return null;
+int idx = authority.indexOf(':');
+if (idx != -1)
+  return parseIpPort(authority);
+if (scheme.equals("http"))
+  return parseIpPort(new StringBuffer(authority).append(":80").toString());
+if (scheme.equals("https"))
+  return parseIpPort(new 
StringBuffer(authority).append(":443").toString());
+return parseIpPort(authority);
 
 Review comment:
   done


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] weichao666 commented on a change in pull request #651: [SCB-498] Configuration Center ip address need to config default port

[GitBox]

weichao666 commented on a change in pull request #651: [SCB-498] Configuration 
Center ip address need to config default port
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/651#discussion_r182673233
 
 

 ##
 File path: 
foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/net/NetUtils.java
 ##
 @@ -145,12 +145,25 @@ public static IpPort parseIpPortFromURI(String 
uriAddress) {
 try {
   URI uri = new URI(uriAddress);
   String authority = uri.getAuthority();
-  return parseIpPort(authority);
+  return parseIpPort(uri.getScheme(), authority);
 } catch (URISyntaxException e) {
   return null;
 }
   }
 
+  private static IpPort parseIpPort(String scheme, String authority) {
+if (authority == null)
+  return null;
+int idx = authority.indexOf(':');
+if (idx != -1)
+  return parseIpPort(authority);
+if (scheme.equals("http"))
+  return parseIpPort(new StringBuffer(authority).append(":80").toString());
+if (scheme.equals("https"))
+  return parseIpPort(new 
StringBuffer(authority).append(":443").toString());
+return parseIpPort(authority);
 
 Review comment:
   only http and https was deal with here, if it's starts with others, e.g 
"rest://",shouldn't return null


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] weichao666 commented on a change in pull request #651: [SCB-498] Configuration Center ip address need to config default port

[GitBox]

weichao666 commented on a change in pull request #651: [SCB-498] Configuration 
Center ip address need to config default port
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/651#discussion_r182673233
 
 

 ##
 File path: 
foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/net/NetUtils.java
 ##
 @@ -145,12 +145,25 @@ public static IpPort parseIpPortFromURI(String 
uriAddress) {
 try {
   URI uri = new URI(uriAddress);
   String authority = uri.getAuthority();
-  return parseIpPort(authority);
+  return parseIpPort(uri.getScheme(), authority);
 } catch (URISyntaxException e) {
   return null;
 }
   }
 
+  private static IpPort parseIpPort(String scheme, String authority) {
+if (authority == null)
+  return null;
+int idx = authority.indexOf(':');
+if (idx != -1)
+  return parseIpPort(authority);
+if (scheme.equals("http"))
+  return parseIpPort(new StringBuffer(authority).append(":80").toString());
+if (scheme.equals("https"))
+  return parseIpPort(new 
StringBuffer(authority).append(":443").toString());
+return parseIpPort(authority);
 
 Review comment:
   only http and https was deal with here, if it's starts with others, e.g 
"rest://",shouldn't return null


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] liubao68 commented on a change in pull request #651: [SCB-498] Configuration Center ip address need to config default port

[GitBox]

liubao68 commented on a change in pull request #651: [SCB-498] Configuration 
Center ip address need to config default port
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/651#discussion_r182670564
 
 

 ##
 File path: 
foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/net/NetUtils.java
 ##
 @@ -145,12 +145,25 @@ public static IpPort parseIpPortFromURI(String 
uriAddress) {
 try {
   URI uri = new URI(uriAddress);
   String authority = uri.getAuthority();
-  return parseIpPort(authority);
+  return parseIpPort(uri.getScheme(), authority);
 } catch (URISyntaxException e) {
   return null;
 }
   }
 
+  private static IpPort parseIpPort(String scheme, String authority) {
+if (authority == null)
+  return null;
+int idx = authority.indexOf(':');
+if (idx != -1)
+  return parseIpPort(authority);
+if (scheme.equals("http"))
+  return parseIpPort(new StringBuffer(authority).append(":80").toString());
 
 Review comment:
   return new IpPort(authority, 80)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on a change in pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration

[GitBox]

wujimin commented on a change in pull request #658: [SCB-474] add endpoint 
filter (only rest endpoints) for zuul integration
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/658#discussion_r182439746
 
 

 ##
 File path: 
spring-boot-starter/spring-boot-starter-discovery/src/main/java/org/apache/servicecomb/springboot/starter/discovery/ServiceCombServerList.java
 ##
 @@ -49,13 +49,11 @@ public ServiceCombServerList() {
 RegistryUtils.getAppId(),
 serviceId,
 DefinitionConst.VERSION_RULE_ALL);
-Map servers = serversVersionedCache.data();
-List instances = new ArrayList<>(servers.size());
-for (MicroserviceInstance s : servers.values()) {
-  for (String endpoint : s.getEndpoints()) {
-URIEndpointObject uri = new URIEndpointObject(endpoint);
-instances.add(new Server(uri.getHostOrIp(), uri.getPort()));
-  }
+ArrayList endpoints = serversVersionedCache.data();
 
 Review comment:
   by previous comment, here will got `List`, not `List`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jeho0815 commented on a change in pull request #648: [SCB-482] Http2 support for java-chassis

[GitBox]

jeho0815 commented on a change in pull request #648: [SCB-482] Http2 support 
for java-chassis
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#discussion_r182653130
 
 

 ##
 File path: 
transports/transport-rest/transport-rest-vertx/src/test/java/org/apache/servicecomb/transport/rest/vertx/TestRestServerVerticle.java
 ##
 @@ -109,6 +109,38 @@ public void testRestServerVerticleWithRouterSSL(@Mocked 
Transport transport, @Mo
 server.start(startFuture);
   }
 
+  @Test
+  public void testRestServerVerticleWithHttp2(@Mocked Transport transport, 
@Mocked Vertx vertx,
+  @Mocked Context context,
+  @Mocked JsonObject jsonObject, @Mocked Future startFuture) throws 
Exception {
+URIEndpointObject endpointObject = new 
URIEndpointObject("http://127.0.0.1:8080?protocol=h2;);
+new Expectations() {
+  {
+transport.parseAddress("http://127.0.0.1:8080?protocol=h2;);
 
 Review comment:
   h2 can use over http, SPDY has to run with https


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asifdxtreme commented on issue #328: [SCB-479] Add proxy to service-center in frontend

[GitBox]

asifdxtreme commented on issue #328: [SCB-479] Add proxy to service-center in 
frontend
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/328#issuecomment-382634015
 
 
   @yangbor Does the current implementation holds if service-center and 
frontend is running in the same docker image?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #653: [SCB-483] Springmvc rest vertx file download

[GitBox]

coveralls commented on issue #653: [SCB-483] Springmvc rest vertx file download
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#issuecomment-382072555
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16592696/badge)](https://coveralls.io/builds/16592696)
   
   Coverage increased (+0.04%) to 87.485% when pulling 
**d1c97633a8a37ab88d8254b5f85a8de53caef186 on 
wujimin:springmvc-rest-vertx-file-download** into 
**41049be9d9b41d32fbdf4e12f613d6e85ab21301 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on a change in pull request #653: [SCB-483] Springmvc rest vertx file download

[GitBox]

wujimin commented on a change in pull request #653: [SCB-483] Springmvc rest 
vertx file download
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#discussion_r182644564
 
 

 ##
 File path: 
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/filter/inner/ServerRestArgsFilter.java
 ##
 @@ -50,7 +54,7 @@ public Response afterReceiveRequest(Invocation invocation, 
HttpServletRequestEx
   }
 
   @Override
-  public void beforeSendResponse(Invocation invocation, HttpServletResponseEx 
responseEx) {
+  public CompletableFuture asyncBeforeSendResponse(Invocation 
invocation, HttpServletResponseEx responseEx) {
 
 Review comment:
   done.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on a change in pull request #653: [SCB-483] Springmvc rest vertx file download

[GitBox]

wujimin commented on a change in pull request #653: [SCB-483] Springmvc rest 
vertx file download
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#discussion_r182643228
 
 

 ##
 File path: 
demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/server/DownloadSchema.java
 ##
 @@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.demo.springmvc.server;
+
+import java.io.ByteArrayInputStream;
+import java.io.File;
+import java.io.IOException;
+import java.io.InputStream;
+import java.nio.charset.StandardCharsets;
+
+import org.apache.servicecomb.provider.rest.common.RestSchema;
+import org.springframework.core.io.ByteArrayResource;
+import org.springframework.core.io.Resource;
+import org.springframework.http.HttpHeaders;
+import org.springframework.http.MediaType;
+import org.springframework.http.ResponseEntity;
+import org.springframework.web.bind.annotation.GetMapping;
+import org.springframework.web.bind.annotation.RequestMapping;
+
+import io.swagger.annotations.ApiResponse;
+import io.swagger.annotations.ApiResponses;
+
+@RestSchema(schemaId = "download")
+@RequestMapping(path = "/download", produces = 
MediaType.APPLICATION_OCTET_STREAM_VALUE)
+public class DownloadSchema {
+  @GetMapping(path = "/file")
 
 Review comment:
   yes, already declared in this commit comments
   this PR just for producer
   
   https://issues.apache.org/jira/browse/SCB-487 is for consumer


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] keepongjl opened a new issue #659: 是否考虑支持函数重载

[GitBox]

keepongjl opened a new issue #659: 是否考虑支持函数重载
URL: https://github.com/apache/incubator-servicecomb-java-chassis/issues/659
 
 
   现在的Provider不支持函数重载（契约生成会报错Caused by: java.lang.Error: OperationId must be 
unique），是否考虑支持函数重载？


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] yangbor commented on a change in pull request #648: [SCB-482] Http2 support for java-chassis

[GitBox]

yangbor commented on a change in pull request #648: [SCB-482] Http2 support for 
java-chassis
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#discussion_r182619742
 
 

 ##
 File path: 
transports/transport-rest/transport-rest-vertx/src/test/java/org/apache/servicecomb/transport/rest/vertx/TestRestServerVerticle.java
 ##
 @@ -109,6 +109,38 @@ public void testRestServerVerticleWithRouterSSL(@Mocked 
Transport transport, @Mo
 server.start(startFuture);
   }
 
+  @Test
+  public void testRestServerVerticleWithHttp2(@Mocked Transport transport, 
@Mocked Vertx vertx,
+  @Mocked Context context,
+  @Mocked JsonObject jsonObject, @Mocked Future startFuture) throws 
Exception {
+URIEndpointObject endpointObject = new 
URIEndpointObject("http://127.0.0.1:8080?protocol=h2;);
+new Expectations() {
+  {
+transport.parseAddress("http://127.0.0.1:8080?protocol=h2;);
 
 Review comment:
   ALPN(h2) cannot be used for http schema, only https is allowed to use h2 
protocol.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] weichao666 commented on issue #651: [SCB-498] Configuration Center ip address need to config default port

[GitBox]

weichao666 commented on issue #651: [SCB-498] Configuration Center ip address 
need to config default port
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/651#issuecomment-382585058
 
 
   modified


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] liubao68 commented on issue #657: [SCB-503]Fix stateful access problem and resource leak issue related to WeighedResponseTimeRule

[GitBox]

liubao68 commented on issue #657: [SCB-503]Fix stateful access problem and 
resource leak issue related to WeighedResponseTimeRule
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/657#issuecomment-382582463
 
 
   I am using eclipse and all compile warnings fixed except 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/652


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] liubao68 commented on a change in pull request #653: [SCB-483] Springmvc rest vertx file download

[GitBox]

liubao68 commented on a change in pull request #653: [SCB-483] Springmvc rest 
vertx file download
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#discussion_r182612283
 
 

 ##
 File path: 
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/filter/inner/ServerRestArgsFilter.java
 ##
 @@ -50,7 +54,7 @@ public Response afterReceiveRequest(Invocation invocation, 
HttpServletRequestEx
   }
 
   @Override
-  public void beforeSendResponse(Invocation invocation, HttpServletResponseEx 
responseEx) {
+  public CompletableFuture asyncBeforeSendResponse(Invocation 
invocation, HttpServletResponseEx responseEx) {
 
 Review comment:
   I think  beforeSendResponseAsync is a better name


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] liubao68 commented on a change in pull request #653: [SCB-483] Springmvc rest vertx file download

[GitBox]

liubao68 commented on a change in pull request #653: [SCB-483] Springmvc rest 
vertx file download
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#discussion_r182611014
 
 

 ##
 File path: 
demo/demo-springmvc/springmvc-server/src/main/java/org/apache/servicecomb/demo/springmvc/server/DownloadSchema.java
 ##
 @@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.demo.springmvc.server;
+
+import java.io.ByteArrayInputStream;
+import java.io.File;
+import java.io.IOException;
+import java.io.InputStream;
+import java.nio.charset.StandardCharsets;
+
+import org.apache.servicecomb.provider.rest.common.RestSchema;
+import org.springframework.core.io.ByteArrayResource;
+import org.springframework.core.io.Resource;
+import org.springframework.http.HttpHeaders;
+import org.springframework.http.MediaType;
+import org.springframework.http.ResponseEntity;
+import org.springframework.web.bind.annotation.GetMapping;
+import org.springframework.web.bind.annotation.RequestMapping;
+
+import io.swagger.annotations.ApiResponse;
+import io.swagger.annotations.ApiResponses;
+
+@RestSchema(schemaId = "download")
+@RequestMapping(path = "/download", produces = 
MediaType.APPLICATION_OCTET_STREAM_VALUE)
+public class DownloadSchema {
+  @GetMapping(path = "/file")
 
 Review comment:
   Are you going to provide a way to invoke download service by RestTemplate or 
RPC style?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #175: SCB-505 Update to throw exception when the transaction timeout

[GitBox]

coveralls commented on issue #175: SCB-505 Update to throw exception when the 
transaction timeout
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/175#issuecomment-382423621
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16579027/badge)](https://coveralls.io/builds/16579027)
   
   Coverage decreased (-0.7%) to 94.811% when pulling 
**6638eb65a9a1107196c701400da7578395ba98e2 on zhfeng:SCB-505** into 
**87949e488ea1ec51f26cd284fe90b6bc35891c8b on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #175: SCB-505 Update to throw exception when the transaction timeout

[GitBox]

coveralls commented on issue #175: SCB-505 Update to throw exception when the 
transaction timeout
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/175#issuecomment-382423621
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16578966/badge)](https://coveralls.io/builds/16578966)
   
   Coverage decreased (-0.6%) to 94.919% when pulling 
**6638eb65a9a1107196c701400da7578395ba98e2 on zhfeng:SCB-505** into 
**87949e488ea1ec51f26cd284fe90b6bc35891c8b on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #175: SCB-505 Update to throw exception when the transaction timeout

[GitBox]

coveralls commented on issue #175: SCB-505 Update to throw exception when the 
transaction timeout
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/175#issuecomment-382423621
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16578938/badge)](https://coveralls.io/builds/16578938)
   
   Coverage decreased (-0.9%) to 94.595% when pulling 
**6638eb65a9a1107196c701400da7578395ba98e2 on zhfeng:SCB-505** into 
**87949e488ea1ec51f26cd284fe90b6bc35891c8b on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] WillemJiang commented on a change in pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration

[GitBox]

WillemJiang commented on a change in pull request #658: [SCB-474] add endpoint 
filter (only rest endpoints) for zuul integration
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/658#discussion_r182465491
 
 

 ##
 File path: 
spring-boot-starter/spring-boot-starter-discovery/src/main/java/org/apache/servicecomb/springboot/starter/discovery/CseRibbonEndpointDiscoveryFilter.java
 ##
 @@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.springboot.starter.discovery;
+
+import org.apache.servicecomb.core.filter.EndpointDiscoveryFilter;
+import org.apache.servicecomb.serviceregistry.discovery.DiscoveryContext;
+import org.apache.servicecomb.serviceregistry.discovery.DiscoveryTreeNode;
+
+public class CseRibbonEndpointDiscoveryFilter extends EndpointDiscoveryFilter {
 
 Review comment:
   Cse is not supposed to be use here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zhfeng opened a new pull request #175: SCB-505 Update to throw exception when the transaction timeout

[GitBox]

zhfeng opened a new pull request #175: SCB-505 Update to throw exception when 
the transaction timeout
URL: https://github.com/apache/incubator-servicecomb-saga/pull/175
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [x] Each commit in the pull request should have a meaningful subject line 
and body.
- [x] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [x] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [x] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on a change in pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration

[GitBox]

wujimin commented on a change in pull request #658: [SCB-474] add endpoint 
filter (only rest endpoints) for zuul integration
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/658#discussion_r182437916
 
 

 ##
 File path: spring-boot-starter/spring-boot-starter-discovery/pom.xml
 ##
 @@ -73,7 +73,7 @@


org.apache.servicecomb
-   service-registry
+   java-chassis-core
 
 Review comment:
   why need change the dependency?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on a change in pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration

[GitBox]

wujimin commented on a change in pull request #658: [SCB-474] add endpoint 
filter (only rest endpoints) for zuul integration
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/658#discussion_r182439425
 
 

 ##
 File path: 
spring-boot-starter/spring-boot-starter-discovery/src/main/java/org/apache/servicecomb/springboot/starter/discovery/CseRibbonEndpointDiscoveryFilter.java
 ##
 @@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.springboot.starter.discovery;
+
+import org.apache.servicecomb.core.filter.EndpointDiscoveryFilter;
+import org.apache.servicecomb.serviceregistry.discovery.DiscoveryContext;
+import org.apache.servicecomb.serviceregistry.discovery.DiscoveryTreeNode;
+
+public class CseRibbonEndpointDiscoveryFilter extends EndpointDiscoveryFilter {
 
 Review comment:
   better extend from AbstractEndpointDiscoveryFilter
   and createEndpoint return com.netflix.loadbalancer.Server


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Rajadeepan commented on issue #648: [SCB-482] Http2 support for java-chassis

[GitBox]

Rajadeepan commented on issue #648: [SCB-482] Http2 support for java-chassis
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#issuecomment-382374604
 
 
   commit added for UT and IT


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #648: [SCB-482] Http2 support for java-chassis

[GitBox]

coveralls commented on issue #648: [SCB-482] Http2 support for java-chassis
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#issuecomment-381568126
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16575497/badge)](https://coveralls.io/builds/16575497)
   
   Coverage increased (+0.05%) to 87.492% when pulling 
**aae6f6d246d34e429fde5569334c93b3980b42de on Rajadeepan:master** into 
**41049be9d9b41d32fbdf4e12f613d6e85ab21301 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration

[GitBox]

coveralls commented on issue #658: [SCB-474] add endpoint filter (only rest 
endpoints) for zuul integration
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/658#issuecomment-382350160
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16574872/badge)](https://coveralls.io/builds/16574872)
   
   Coverage increased (+0.0007%) to 87.441% when pulling 
**bf9f0fe450d992355e9bae7f34b4a5fc358c0b74 on zhengyangyong:SCB-474** into 
**41049be9d9b41d32fbdf4e12f613d6e85ab21301 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zhengyangyong opened a new pull request #658: [SCB-474] add endpoint filter (only rest endpoints) for zuul integration

[GitBox]

zhengyangyong opened a new pull request #658: [SCB-474] add endpoint filter 
(only rest endpoints) for zuul integration
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/658
 
 
   Signed-off-by: zhengyangyong 
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   
   Add rest filter for spring-cloud-zuul module in order to screen highway 
endpoints.
   
   only XML and Faceted project problem warnings
   
![image](https://user-images.githubusercontent.com/374335/38926660-0f1d886a-4336-11e8-9a45-505e8dbbed4f.png)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #657: [SCB-503]Fix stateful access problem and resource leak issue related to WeighedResponseTimeRule

[GitBox]

coveralls commented on issue #657: [SCB-503]Fix stateful access problem and 
resource leak issue related to WeighedResponseTimeRule
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/657#issuecomment-382318550
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16573156/badge)](https://coveralls.io/builds/16573156)
   
   Coverage increased (+0.009%) to 87.449% when pulling 
**c612977f1a76180143b4a149847189cd4dba0426 on liubao68:config** into 
**41049be9d9b41d32fbdf4e12f613d6e85ab21301 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on issue #657: [SCB-503]Fix stateful access problem and resource leak issue related to WeighedResponseTimeRule

[GitBox]

wujimin commented on issue #657: [SCB-503]Fix stateful access problem and 
resource leak issue related to WeighedResponseTimeRule
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/657#issuecomment-382310371
 
 
   paste compile warning check image please.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] liubao68 opened a new pull request #657: [SCB-503]Fix stateful access problem and resource leak issue related to WeighedResponseTimeRule

[GitBox]

liubao68 opened a new pull request #657: [SCB-503]Fix stateful access problem 
and resource leak issue related to WeighedResponseTimeRule
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/657
 
 
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #653: [SCB-483] Springmvc rest vertx file download

[GitBox]

coveralls commented on issue #653: [SCB-483] Springmvc rest vertx file download
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#issuecomment-382072555
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16572229/badge)](https://coveralls.io/builds/16572229)
   
   Coverage increased (+0.04%) to 87.479% when pulling 
**dc36cf74e64448f812b2a28dc7845302bd786e08 on 
wujimin:springmvc-rest-vertx-file-download** into 
**41049be9d9b41d32fbdf4e12f613d6e85ab21301 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on issue #653: [SCB-483] Springmvc rest vertx file download

[GitBox]

wujimin commented on issue #653: [SCB-483] Springmvc rest vertx file download
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#issuecomment-382290341
 
 
   add a new commit: "set correct content-type for download"


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zhengyangyong commented on issue #644: 新版的release编译包啥时候放出来啊？

[GitBox]

zhengyangyong commented on issue #644: 新版的release编译包啥时候放出来啊？
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/issues/644#issuecomment-382250055
 
 
   you can donwload from apache , 
http://apache.org/dyn/closer.cgi/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/
 ,thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #328: [SCB-479] Add proxy to service-center in frontend

[GitBox]

coveralls commented on issue #328: [SCB-479] Add proxy to service-center in 
frontend
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/328#issuecomment-380735106
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16570100/badge)](https://coveralls.io/builds/16570100)
   
   Coverage increased (+0.05%) to 72.985% when pulling 
**a041846f1659fa1a74ab7618e92ad7a14df7a827 on yangbor:master** into 
**ee87190f9047244cc8e6f95852aa3518b5eff6fd on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #328: [SCB-479] Add proxy to service-center in frontend

[GitBox]

coveralls commented on issue #328: [SCB-479] Add proxy to service-center in 
frontend
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/328#issuecomment-380735106
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16570059/badge)](https://coveralls.io/builds/16570059)
   
   Coverage increased (+0.1%) to 73.039% when pulling 
**a041846f1659fa1a74ab7618e92ad7a14df7a827 on yangbor:master** into 
**ee87190f9047244cc8e6f95852aa3518b5eff6fd on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #328: [SCB-479] Add proxy to service-center in frontend

[GitBox]

codecov-io commented on issue #328: [SCB-479] Add proxy to service-center in 
frontend
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/328#issuecomment-380735171
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/328?src=pr=h1)
 Report
   > Merging 
[#328](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/328?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/ee87190f9047244cc8e6f95852aa3518b5eff6fd?src=pr=desc)
 will **increase** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/328/graphs/tree.svg?width=650=150=GAaF7zrg8R=pr)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/328?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #328  +/-   ##
   ==
   + Coverage   69.45%   69.48%   +0.02% 
   ==
 Files  17   17  
 Lines3438 3438  
   ==
   + Hits 2388 2389   +1 
 Misses884  884  
   + Partials  166  165   -1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/328?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/328/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv)
 | `76.02% <0%> (+0.58%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/328?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/328?src=pr=footer).
 Last update 
[ee87190...a041846](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/328?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #328: [SCB-479] Add proxy to service-center in frontend

[GitBox]

coveralls commented on issue #328: [SCB-479] Add proxy to service-center in 
frontend
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/328#issuecomment-380735106
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16570047/badge)](https://coveralls.io/builds/16570047)
   
   Coverage remained the same at 72.937% when pulling 
**a041846f1659fa1a74ab7618e92ad7a14df7a827 on yangbor:master** into 
**ee87190f9047244cc8e6f95852aa3518b5eff6fd on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] msnetc opened a new issue #656: bmi项目的log日志没有输出

[GitBox]

msnetc opened a new issue #656: bmi项目的log日志没有输出
URL: https://github.com/apache/incubator-servicecomb-java-chassis/issues/656
 
 
   windows 机器：E:\dev\logs\
   启动后，日志并没有输出


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on a change in pull request #653: [SCB-483] Springmvc rest vertx file download

[GitBox]

wujimin commented on a change in pull request #653: [SCB-483] Springmvc rest 
vertx file download
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#discussion_r182296939
 
 

 ##
 File path: 
foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/stream/InputStreamToReadStream.java
 ##
 @@ -34,7 +34,7 @@
 public class InputStreamToReadStream implements ReadStream {
   private static final Logger LOGGER = 
LoggerFactory.getLogger(InputStreamToReadStream.class);
 
-  public static final int DEFAULT_READ_BUFFER_SIZE = 8192;
+  public static final int DEFAULT_READ_BUFFER_SIZE = 1024 * 1024;
 
 Review comment:
   only a internal buf size, customers not perceive this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on a change in pull request #653: [SCB-483] Springmvc rest vertx file download

[GitBox]

wujimin commented on a change in pull request #653: [SCB-483] Springmvc rest 
vertx file download
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#discussion_r182294530
 
 

 ##
 File path: 
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/AbstractRestInvocation.java
 ##
 @@ -220,10 +216,38 @@ protected void sendResponse(Response response) throws 
Exception {
 responseEx.setAttribute(RestConst.INVOCATION_HANDLER_RESPONSE, response);
 responseEx.setAttribute(RestConst.INVOCATION_HANDLER_PROCESSOR, 
produceProcessor);
 
-for (HttpServerFilter filter : httpServerFilters) {
-  filter.beforeSendResponse(invocation, responseEx);
+executeHttpServerFilters(response);
+  }
+
+  protected void executeHttpServerFilters(Response response) {
+HttpServerFilterBeforeSendResponseExecutor exec =
+new HttpServerFilterBeforeSendResponseExecutor(httpServerFilters, 
invocation, responseEx);
+CompletableFuture future = exec.run();
+future.whenComplete((v, e) -> {
+  onExecuteHttpServerFiltersFinish(response, e);
+});
+  }
+
+  protected void onExecuteHttpServerFiltersFinish(Response response, Throwable 
e) {
+if (e != null) {
+  LOGGER.error("Failed to execute HttpServerFilters, operation:{}.",
+  invocation.getMicroserviceQualifiedName(),
+  e);
 }
 
-responseEx.flushBuffer();
+try {
+  responseEx.flushBuffer();
+} catch (IOException flushException) {
+  LOGGER.error("Failed to flush rest response, operation:{}.",
+  invocation.getMicroserviceQualifiedName(),
+  flushException);
+}
+
+requestEx.getAsyncContext().complete();
+// if failed to locate path, then will not create invocation
+// TODO: statistics this case
 
 Review comment:
   traced by https://issues.apache.org/jira/browse/SCB-500


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] WillemJiang commented on a change in pull request #653: [SCB-483] Springmvc rest vertx file download

[GitBox]

WillemJiang commented on a change in pull request #653: [SCB-483] Springmvc 
rest vertx file download
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#discussion_r182294300
 
 

 ##
 File path: 
foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/stream/InputStreamToReadStream.java
 ##
 @@ -34,7 +34,7 @@
 public class InputStreamToReadStream implements ReadStream {
   private static final Logger LOGGER = 
LoggerFactory.getLogger(InputStreamToReadStream.class);
 
-  public static final int DEFAULT_READ_BUFFER_SIZE = 8192;
+  public static final int DEFAULT_READ_BUFFER_SIZE = 1024 * 1024;
 
 Review comment:
   We may need to mention it in the release note.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] WillemJiang commented on a change in pull request #653: [SCB-483] Springmvc rest vertx file download

[GitBox]

WillemJiang commented on a change in pull request #653: [SCB-483] Springmvc 
rest vertx file download
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#discussion_r182291768
 
 

 ##
 File path: 
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/AbstractRestInvocation.java
 ##
 @@ -220,10 +216,38 @@ protected void sendResponse(Response response) throws 
Exception {
 responseEx.setAttribute(RestConst.INVOCATION_HANDLER_RESPONSE, response);
 responseEx.setAttribute(RestConst.INVOCATION_HANDLER_PROCESSOR, 
produceProcessor);
 
-for (HttpServerFilter filter : httpServerFilters) {
-  filter.beforeSendResponse(invocation, responseEx);
+executeHttpServerFilters(response);
+  }
+
+  protected void executeHttpServerFilters(Response response) {
+HttpServerFilterBeforeSendResponseExecutor exec =
+new HttpServerFilterBeforeSendResponseExecutor(httpServerFilters, 
invocation, responseEx);
+CompletableFuture future = exec.run();
+future.whenComplete((v, e) -> {
+  onExecuteHttpServerFiltersFinish(response, e);
+});
+  }
+
+  protected void onExecuteHttpServerFiltersFinish(Response response, Throwable 
e) {
+if (e != null) {
+  LOGGER.error("Failed to execute HttpServerFilters, operation:{}.",
+  invocation.getMicroserviceQualifiedName(),
+  e);
 }
 
-responseEx.flushBuffer();
+try {
+  responseEx.flushBuffer();
+} catch (IOException flushException) {
+  LOGGER.error("Failed to flush rest response, operation:{}.",
+  invocation.getMicroserviceQualifiedName(),
+  flushException);
+}
+
+requestEx.getAsyncContext().complete();
+// if failed to locate path, then will not create invocation
+// TODO: statistics this case
 
 Review comment:
   We may also need to count the error and exceptions.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] WillemJiang commented on issue #654: java-chassis依赖的springboot版本过低

[GitBox]

WillemJiang commented on issue #654: java-chassis依赖的springboot版本过低
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/issues/654#issuecomment-382219074
 
 
   spring boot 1.5.x的最新版是1.5.12 （升级很快）， 我们会先验证1.5.x，应用本身还是需要能够重载spring boot的版本。 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] crystaldust commented on issue #174: Add guide on how to build and run alpha server

[GitBox]

crystaldust commented on issue #174: Add guide on how to build and run alpha 
server
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/174#issuecomment-382216387
 
 
   Yea, the database is required to run alpha server, but the Postgresql is a 
very generic image and all the documents are just 
[there](https://hub.docker.com/_/postgres/). We'll later add some sample of 
running the saga demo on k8s/istio, with the postgresql's resources(yamls of 
Deployment and Service) included, which might be helpful.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] msnetc opened a new issue #654: java-chassis依赖的springboot版本过低

[GitBox]

msnetc opened a new issue #654: java-chassis依赖的springboot版本过低
URL: https://github.com/apache/incubator-servicecomb-java-chassis/issues/654
 
 
   我们项目需要springboot版本是1.5.9， 而java-chassis的版本低于1.5.9， 是否能考虑升级到1.5.9。
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] WillemJiang closed pull request #174: Add guide on how to build and run alpha server

[GitBox]

WillemJiang closed pull request #174: Add guide on how to build and run alpha 
server
URL: https://github.com/apache/incubator-servicecomb-saga/pull/174
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/alpha/README.md b/alpha/README.md
new file mode 100644
index ..a1d21a66
--- /dev/null
+++ b/alpha/README.md
@@ -0,0 +1,33 @@
+# alpha-server
+
+The alpha-server works as the pack leader to keep the consistency of 
transactions.
+For more information, see [saga pack 
design](https://github.com/apache/incubator-servicecomb-saga/blob/master/docs/design.md)
+
+## Build and Run
+
+### Via docker image
+Build the executable files and docker image:
+```
+mvn clean package -DskipTests -Pdocker -Pdemo
+```
+
+Then play `alpha-server` image with docker, docker-compose or any other 
container based environment.
+
+You can override the configurations by `JAVA_OPTS` environment variable:
+```
+docker run -d -p 8080:8080 -p 8090:8090 \ 
+-e "JAVA_OPTS=-Dspring.profiles.active=prd 
-Dspring.datasource.url=jdbc:postgresql://${host_address}:5432/saga?useSSL=false"
 alpha-server:${saga_version}
+```
+
+
+### Via executable file
+
+Build the executable files:
+```bash
+mvn clean package -DskipTests -Pdemo
+```
+
+And run:
+```
+java -Dspring.profiles.active=prd 
-D"spring.datasource.url=jdbc:postgresql://${host_address}:5432/saga?useSSL=false"
 -jar alpha-server-${saga_version}-exec.jar
+```
diff --git a/saga-demo/booking/README.md b/saga-demo/booking/README.md
index 4c642b31..1540e29a 100644
--- a/saga-demo/booking/README.md
+++ b/saga-demo/booking/README.md
@@ -10,11 +10,13 @@ You will need:
 2. [Maven 3.x][maven]
 3. [Docker][docker]
 4. [Docker compose][docker_compose]
+5. [alpha server][alpha_server]
 
 [jdk]: 
http://www.oracle.com/technetwork/java/javase/downloads/jdk8-downloads-2133151.html
 [maven]: https://maven.apache.org/install.html
 [docker]: https://www.docker.com/get-docker
 [docker_compose]: https://docs.docker.com/compose/install/
+[alpha_server]: 
https://github.com/apache/incubator-servicecomb-saga/tree/master/alpha
 
 ## Running Demo
 You can run the demo using either docker compose or executable files.


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] WillemJiang commented on issue #174: Add guide on how to build and run alpha server

[GitBox]

WillemJiang commented on issue #174: Add guide on how to build and run alpha 
server
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/174#issuecomment-382202325
 
 
   @yangbor Please feel free to submit an PR for the prerequisite description 
of  Database.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] WillemJiang commented on issue #328: [SCB-479] Add proxy to service-center in frontend

[GitBox]

WillemJiang commented on issue #328: [SCB-479] Add proxy to service-center in 
frontend
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/328#issuecomment-382201777
 
 
   @yangbor  You can close and reopen the issue to trigger the build. 
   BTW, once you have the committer right, you can trigger the issue by hand.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #328: [SCB-479] Add proxy to service-center in frontend

[GitBox]

codecov-io commented on issue #328: [SCB-479] Add proxy to service-center in 
frontend
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/328#issuecomment-380735171
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/328?src=pr=h1)
 Report
   > Merging 
[#328](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/328?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/ee87190f9047244cc8e6f95852aa3518b5eff6fd?src=pr=desc)
 will **increase** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/328/graphs/tree.svg?src=pr=GAaF7zrg8R=650=150)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/328?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #328  +/-   ##
   ==
   + Coverage   69.45%   69.48%   +0.02% 
   ==
 Files  17   17  
 Lines3438 3438  
   ==
   + Hits 2388 2389   +1 
 Misses884  884  
   + Partials  166  165   -1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/328?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/328/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv)
 | `76.02% <0%> (+0.58%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/328?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/328?src=pr=footer).
 Last update 
[ee87190...9ecefb2](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/328?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on issue #652: [SCB 456]Remove warning

[GitBox]

wujimin commented on issue #652: [SCB 456]Remove warning
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/652#issuecomment-382082568
 
 
   only one line changed, why so many commit log?
   you'd better use rebase not pull git command.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on issue #652: [SCB 456]Remove warning

[GitBox]

wujimin commented on issue #652: [SCB 456]Remove warning
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/652#issuecomment-382082058
 
 
   it seems that you did not import intellij-java-google-style.xml


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin commented on issue #652: [SCB 456]Remove warning

[GitBox]

wujimin commented on issue #652: [SCB 456]Remove warning
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/652#issuecomment-382075099
 
 
   paste compile warning check image please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #653: [SCB-483] Springmvc rest vertx file download

[GitBox]

coveralls commented on issue #653: [SCB-483] Springmvc rest vertx file download
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/653#issuecomment-382072555
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16561437/badge)](https://coveralls.io/builds/16561437)
   
   Coverage increased (+0.04%) to 87.485% when pulling 
**f76acbef89207656600079bd51040e559e8bf536 on 
wujimin:springmvc-rest-vertx-file-download** into 
**41049be9d9b41d32fbdf4e12f613d6e85ab21301 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wujimin opened a new pull request #653: [SCB-483] Springmvc rest vertx file download

[GitBox]

wujimin opened a new pull request #653: [SCB-483] Springmvc rest vertx file 
download
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/653
 
 
   springmvc over rest vertx support file download.
   
![image](https://user-images.githubusercontent.com/16874843/38883855-aaeaf1ce-42a0-11e8-8608-6fe910feddbe.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #652: [SCB 456]Remove warning

[GitBox]

coveralls commented on issue #652: [SCB 456]Remove warning
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/652#issuecomment-382037053
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16559388/badge)](https://coveralls.io/builds/16559388)
   
   Coverage increased (+0.02%) to 87.463% when pulling 
**73ea2e1f4e5c99648acede5c1be8eec36af3a4a5 on jasononion:master** into 
**41049be9d9b41d32fbdf4e12f613d6e85ab21301 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jasononion opened a new pull request #652: [SCB 456]Remove warning

[GitBox]

jasononion opened a new pull request #652: [SCB 456]Remove warning
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/652
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #648: [SCB-482] Http2 support for java-chassis

[GitBox]

coveralls commented on issue #648: [SCB-482] Http2 support for java-chassis
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/648#issuecomment-381568126
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16558604/badge)](https://coveralls.io/builds/16558604)
   
   Coverage increased (+0.03%) to 87.47% when pulling 
**88b670be51e8dc2963be10ec38a53d21a04ae997 on Rajadeepan:master** into 
**41049be9d9b41d32fbdf4e12f613d6e85ab21301 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] yangbor commented on issue #328: [SCB-479] Add proxy to service-center in frontend

[GitBox]

yangbor commented on issue #328: [SCB-479] Add proxy to service-center in 
frontend
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/328#issuecomment-381937397
 
 
   The UT succeeded on local build but the following case failed on travis. 
   Need investigation.
   
   Update: This test is Service-Center only and not related to frontend.  The 
failed case is:
   ```
By("Test Get All Services in SC", func() {
It("test valid scenario", func() {
getServiceName(serviceId)
req, _ := http.NewRequest(GET, 
SCURL+GETALLSERVICE, nil)
req.Header.Set("X-Domain-Name", 
"default")
resp, _ := scclient.Do(req)
respbody, _ := ioutil.ReadAll(resp.Body)

Expect(resp.StatusCode).To(Equal(http.StatusOK))
servicesStruct := 
map[string][]map[string]interface{}{}
json.Unmarshal(respbody, 
)
foundMicroService := false
for _, services := range 
servicesStruct["services"] {
if services["serviceName"] == 
serviceName {
foundMicroService = true
break
}
}

Expect(foundMicroService).To(Equal(true))
})
   
It("test get all service with wrong domain 
name", func() {
req, _ := http.NewRequest(GET, 
SCURL+GETALLSERVICE, nil)
req.Header.Set("X-Domain-Name", 
"default1")
resp, _ := scclient.Do(req)
respbody, _ := ioutil.ReadAll(resp.Body)

Expect(resp.StatusCode).To(Equal(http.StatusOK))

Expect(strings.TrimSpace(string(respbody))).To(Equal("{}"))
})
})
   ```
   
   *Failure*
   ```
   • Failure [0.008 seconds]
   MicroService Api Test
   
/home/travis/gopath/src/github.com/apache/incubator-servicecomb-service-center/integration/microservices_test.go:522
 Testing MicroServices Functions
 
/home/travis/gopath/src/github.com/apache/incubator-servicecomb-service-center/integration/microservices_test.go:520
   Testing MicroService API's
   
/home/travis/gopath/src/github.com/apache/incubator-servicecomb-service-center/integration/microservices_test.go:519
 test valid scenario [It]
 
/home/travis/gopath/src/github.com/apache/incubator-servicecomb-service-center/integration/microservices_test.go:206
 Expected
 : false
 to equal
 : true
 
/home/travis/gopath/src/github.com/apache/incubator-servicecomb-service-center/integration/microservices_test.go:205
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] yangbor commented on issue #328: [SCB-479] Add proxy to service-center in frontend

[GitBox]

yangbor commented on issue #328: [SCB-479] Add proxy to service-center in 
frontend
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/328#issuecomment-381937397
 
 
   The UT succeeded on local build but the following case failed on travis. 
   Need investigation.
   
   Update: This test is Service-Center only and not related to frontend.  The 
failed case is:
   ```
By("Test Get All Services in SC", func() {
It("test valid scenario", func() {
getServiceName(serviceId)
req, _ := http.NewRequest(GET, 
SCURL+GETALLSERVICE, nil)
req.Header.Set("X-Domain-Name", 
"default")
resp, _ := scclient.Do(req)
respbody, _ := ioutil.ReadAll(resp.Body)

Expect(resp.StatusCode).To(Equal(http.StatusOK))
servicesStruct := 
map[string][]map[string]interface{}{}
json.Unmarshal(respbody, 
)
foundMicroService := false
for _, services := range 
servicesStruct["services"] {
if services["serviceName"] == 
serviceName {
foundMicroService = true
break
}
}

Expect(foundMicroService).To(Equal(true))
})
   
It("test get all service with wrong domain 
name", func() {
req, _ := http.NewRequest(GET, 
SCURL+GETALLSERVICE, nil)
req.Header.Set("X-Domain-Name", 
"default1")
resp, _ := scclient.Do(req)
respbody, _ := ioutil.ReadAll(resp.Body)

Expect(resp.StatusCode).To(Equal(http.StatusOK))

Expect(strings.TrimSpace(string(respbody))).To(Equal("{}"))
})
})
   ```
   
   * Failure *
   ```
   • Failure [0.008 seconds]
   MicroService Api Test
   
/home/travis/gopath/src/github.com/apache/incubator-servicecomb-service-center/integration/microservices_test.go:522
 Testing MicroServices Functions
 
/home/travis/gopath/src/github.com/apache/incubator-servicecomb-service-center/integration/microservices_test.go:520
   Testing MicroService API's
   
/home/travis/gopath/src/github.com/apache/incubator-servicecomb-service-center/integration/microservices_test.go:519
 test valid scenario [It]
 
/home/travis/gopath/src/github.com/apache/incubator-servicecomb-service-center/integration/microservices_test.go:206
 Expected
 : false
 to equal
 : true
 
/home/travis/gopath/src/github.com/apache/incubator-servicecomb-service-center/integration/microservices_test.go:205
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] yangbor commented on issue #328: [SCB-479] Add proxy to service-center in frontend

[GitBox]

yangbor commented on issue #328: [SCB-479] Add proxy to service-center in 
frontend
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/328#issuecomment-381937397
 
 
   The UT succeeded on local build but the following case failed on travis. 
   Need investigation.
   
   Update: This test is Service-Center only and not related to frontend.  The 
failed case is:
   ```
By("Test Get All Services in SC", func() {
It("test valid scenario", func() {
getServiceName(serviceId)
req, _ := http.NewRequest(GET, 
SCURL+GETALLSERVICE, nil)
req.Header.Set("X-Domain-Name", 
"default")
resp, _ := scclient.Do(req)
respbody, _ := ioutil.ReadAll(resp.Body)

Expect(resp.StatusCode).To(Equal(http.StatusOK))
servicesStruct := 
map[string][]map[string]interface{}{}
json.Unmarshal(respbody, 
)
foundMicroService := false
for _, services := range 
servicesStruct["services"] {
if services["serviceName"] == 
serviceName {
foundMicroService = true
break
}
}

Expect(foundMicroService).To(Equal(true))
})
   
It("test get all service with wrong domain 
name", func() {
req, _ := http.NewRequest(GET, 
SCURL+GETALLSERVICE, nil)
req.Header.Set("X-Domain-Name", 
"default1")
resp, _ := scclient.Do(req)
respbody, _ := ioutil.ReadAll(resp.Body)

Expect(resp.StatusCode).To(Equal(http.StatusOK))

Expect(strings.TrimSpace(string(respbody))).To(Equal("{}"))
})
})
   ```
   
   =
   • Failure [0.008 seconds]
   MicroService Api Test
   
/home/travis/gopath/src/github.com/apache/incubator-servicecomb-service-center/integration/microservices_test.go:522
 Testing MicroServices Functions
 
/home/travis/gopath/src/github.com/apache/incubator-servicecomb-service-center/integration/microservices_test.go:520
   Testing MicroService API's
   
/home/travis/gopath/src/github.com/apache/incubator-servicecomb-service-center/integration/microservices_test.go:519
 test valid scenario [It]
 
/home/travis/gopath/src/github.com/apache/incubator-servicecomb-service-center/integration/microservices_test.go:206
 Expected
 : false
 to equal
 : true
 
/home/travis/gopath/src/github.com/apache/incubator-servicecomb-service-center/integration/microservices_test.go:205


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] yangbor commented on issue #328: [SCB-479] Add proxy to service-center in frontend

[GitBox]

yangbor commented on issue #328: [SCB-479] Add proxy to service-center in 
frontend
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/328#issuecomment-381937397
 
 
   
   The UT succeeded on local build but the following case failed on travis. 
   Need investigation.
   
   • Failure [0.008 seconds]
   MicroService Api Test
   
/home/travis/gopath/src/github.com/apache/incubator-servicecomb-service-center/integration/microservices_test.go:522
 Testing MicroServices Functions
 
/home/travis/gopath/src/github.com/apache/incubator-servicecomb-service-center/integration/microservices_test.go:520
   Testing MicroService API's
   
/home/travis/gopath/src/github.com/apache/incubator-servicecomb-service-center/integration/microservices_test.go:519
 test valid scenario [It]
 
/home/travis/gopath/src/github.com/apache/incubator-servicecomb-service-center/integration/microservices_test.go:206
 Expected
 : false
 to equal
 : true
 
/home/travis/gopath/src/github.com/apache/incubator-servicecomb-service-center/integration/microservices_test.go:205


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #138: SCB-224 retry sub-transaction on failure

[GitBox]

coveralls commented on issue #138: SCB-224 retry sub-transaction on failure
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/138#issuecomment-368816986
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16554289/badge)](https://coveralls.io/builds/16554289)
   
   Coverage increased (+0.4%) to 95.863% when pulling 
**b8a1163824edcb73fb8e55169d7c083763b3ef5b on eric-lee-ltk:SCB-224** into 
**54ed83e0bf90a7aa364b7b5fdb32e64f3a402550 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #138: SCB-224 retry sub-transaction on failure

[GitBox]

coveralls commented on issue #138: SCB-224 retry sub-transaction on failure
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/138#issuecomment-368816986
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16554289/badge)](https://coveralls.io/builds/16554289)
   
   Coverage increased (+0.4%) to 95.863% when pulling 
**b8a1163824edcb73fb8e55169d7c083763b3ef5b on eric-lee-ltk:SCB-224** into 
**54ed83e0bf90a7aa364b7b5fdb32e64f3a402550 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] yangbor commented on issue #651: [SCB-498] Configuration Center ip address need to config default port

[GitBox]

yangbor commented on issue #651: [SCB-498] Configuration Center ip address need 
to config default port
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/651#issuecomment-381934241
 
 
   It seems to be the wrong place to fix the problem. the http(80) and 
https(443) are Well Known Ports and all http servers and clients should handle 
them correctly. We should fix the code where this is not correctly handled 
instead of appending the port to the URL.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #138: SCB-224 retry sub-transaction on failure

[GitBox]

coveralls commented on issue #138: SCB-224 retry sub-transaction on failure
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/138#issuecomment-368816986
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16554142/badge)](https://coveralls.io/builds/16554142)
   
   Coverage increased (+0.3%) to 95.76% when pulling 
**f6277558a2128470300e3dd858b3c5465498dd1d on eric-lee-ltk:SCB-224** into 
**54ed83e0bf90a7aa364b7b5fdb32e64f3a402550 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #328: [SCB-479] Add proxy to service-center in frontend

[GitBox]

coveralls commented on issue #328: [SCB-479] Add proxy to service-center in 
frontend
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/328#issuecomment-380735106
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16554102/badge)](https://coveralls.io/builds/16554102)
   
   Coverage increased (+0.2%) to 73.105% when pulling 
**9ecefb2f43290d3b97df778963240a6cc60d9e30 on yangbor:master** into 
**ee87190f9047244cc8e6f95852aa3518b5eff6fd on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] WillemJiang closed pull request #62: Update quick-start.md change, cd ServiceComb-Java-Chasiss to cd incubator-servicecomb-java-chassis

[GitBox]

WillemJiang closed pull request #62: Update quick-start.md  change, cd 
ServiceComb-Java-Chasiss to cd incubator-servicecomb-java-chassis 
URL: https://github.com/apache/incubator-servicecomb-website/pull/62
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/_docs/quick-start.md b/_docs/quick-start.md
index 92a3023..9d7d291 100644
--- a/_docs/quick-start.md
+++ b/_docs/quick-start.md
@@ -20,7 +20,7 @@ last_modified_at: 2017-09-06T00:50:43-55:00
 
```bash
git clone https://github.com/apache/incubator-servicecomb-java-chassis.git
-   cd ServiceComb-Java-Chassis
+   cd incubator-servicecomb-java-chassis
mvn clean install -DskipTests
```
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services