Re: [Discuss] Should we clean up vendor/github.com/go-ecosystem for ServiceCenter
Hi, The problem is fixed. I added the version information of the 2 libraries in manifest and removed the code. Please check https://github.com/apache/incubator-servicecomb-service-center/pull/372 On Fri, Jun 8, 2018 at 10:58 AM, Sure wrote: > we do not change the code in go-ecosystem package and we can remove these > files from project > > > Just make sure the same version of this package compiled with etcd > components when make the release. > > > > > > -- 原始邮件 -- > 发件人: "willem.jiang"; > 发送时间: 2018年6月7日(星期四) 中午11:32 > 收件人: "dev"; > > 主题: Re: [Discuss] Should we clean up vendor/github.com/go-ecosystem for > ServiceCenter > > > > If we changed the code, we should move it third party directory. > @Asif @Cuiyihua Could you double check with YangBo？ > > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem > > On Thu, Jun 7, 2018 at 10:29 AM, Yang Bo wrote: > > > Hi All, > > > > Currently we store github.com/go-ecosystem/grpc-gateway and > > go-grpc-prometheus under the vendor directory. > > > > The vendor directory should only contain manifest file and all other code > > should be fetched from third party repository. > > > > If we have made some modification to those libraries, then we need to > move > > them to a proper place. > > > > -- > > Best Regards, > > Yang. > > > -- Best Regards, Yang.
?????? [Discuss] Should we clean up vendor/github.com/go-ecosystem for ServiceCenter
we do not change the code in go-ecosystem package and we can remove these files from project Just make sure the same version of this package compiled with etcd components when make the release. -- -- ??: "willem.jiang"; : 2018??6??7??(??) 11:32 ??: "dev"; : Re: [Discuss] Should we clean up vendor/github.com/go-ecosystem for ServiceCenter If we changed the code, we should move it third party directory. @Asif @Cuiyihua Could you double check with YangBo?? Willem Jiang Twitter: willemjiang Weibo: willem On Thu, Jun 7, 2018 at 10:29 AM, Yang Bo wrote: > Hi All, > > Currently we store github.com/go-ecosystem/grpc-gateway and > go-grpc-prometheus under the vendor directory. > > The vendor directory should only contain manifest file and all other code > should be fetched from third party repository. > > If we have made some modification to those libraries, then we need to move > them to a proper place. > > -- > Best Regards, > Yang. >
Re: [Discuss] Should we clean up vendor/github.com/go-ecosystem for ServiceCenter
+1 to Yang Bo's suggestion, Forked to your own github organization, then used in ServiceCenter as a vendor referenced to your forked brench. The problem introduced by this approach is that the cloner needs to maintain its own branch, but if you modified the libraries, no way to escape maintaining your branch(your modifyings). Best Regards, --- Zen Lin zenlintechnofr...@gmail.com Focused on Micro Service and Apache ServiceComb 2018-06-07 14:18 GMT+08:00 Yang Bo : > If we do have modified those libraries, it's better we make a fork of them > on github and the use the forks. > > It's still better that we use them directly as is to ease later upgrade and > do the work in our code through wrappers. > > On Thu, Jun 7, 2018 at 11:32 AM, Willem Jiang > wrote: > > > If we changed the code, we should move it third party directory. > > @Asif @Cuiyihua Could you double check with YangBo？ > > > > > > Willem Jiang > > > > Twitter: willemjiang > > Weibo: 姜宁willem > > > > On Thu, Jun 7, 2018 at 10:29 AM, Yang Bo wrote: > > > > > Hi All, > > > > > > Currently we store github.com/go-ecosystem/grpc-gateway and > > > go-grpc-prometheus under the vendor directory. > > > > > > The vendor directory should only contain manifest file and all other > code > > > should be fetched from third party repository. > > > > > > If we have made some modification to those libraries, then we need to > > move > > > them to a proper place. > > > > > > -- > > > Best Regards, > > > Yang. > > > > > > > > > -- > Best Regards, > Yang. >
Re: [Discuss] Should we clean up vendor/github.com/go-ecosystem for ServiceCenter
I think it is better to decoupled package it if we want to add something enhanced, but not just only modified it and then keep in the third-party. Anyway , third-party is not a regular and recommended way to using golang libraries. Best Regards, --- Zen Lin zenlintechnofr...@gmail.com Focused on Micro Service and Apache ServiceComb 2018-06-07 11:32 GMT+08:00 Willem Jiang : > If we changed the code, we should move it third party directory. > @Asif @Cuiyihua Could you double check with YangBo？ > > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem > > On Thu, Jun 7, 2018 at 10:29 AM, Yang Bo wrote: > > > Hi All, > > > > Currently we store github.com/go-ecosystem/grpc-gateway and > > go-grpc-prometheus under the vendor directory. > > > > The vendor directory should only contain manifest file and all other code > > should be fetched from third party repository. > > > > If we have made some modification to those libraries, then we need to > move > > them to a proper place. > > > > -- > > Best Regards, > > Yang. > > >
Re: [Discuss] Should we clean up vendor/github.com/go-ecosystem for ServiceCenter
If we do have modified those libraries, it's better we make a fork of them on github and the use the forks. It's still better that we use them directly as is to ease later upgrade and do the work in our code through wrappers. On Thu, Jun 7, 2018 at 11:32 AM, Willem Jiang wrote: > If we changed the code, we should move it third party directory. > @Asif @Cuiyihua Could you double check with YangBo？ > > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem > > On Thu, Jun 7, 2018 at 10:29 AM, Yang Bo wrote: > > > Hi All, > > > > Currently we store github.com/go-ecosystem/grpc-gateway and > > go-grpc-prometheus under the vendor directory. > > > > The vendor directory should only contain manifest file and all other code > > should be fetched from third party repository. > > > > If we have made some modification to those libraries, then we need to > move > > them to a proper place. > > > > -- > > Best Regards, > > Yang. > > > -- Best Regards, Yang.
Re: [Discuss] Should we clean up vendor/github.com/go-ecosystem for ServiceCenter
If we changed the code, we should move it third party directory. @Asif @Cuiyihua Could you double check with YangBo？ Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Thu, Jun 7, 2018 at 10:29 AM, Yang Bo wrote: > Hi All, > > Currently we store github.com/go-ecosystem/grpc-gateway and > go-grpc-prometheus under the vendor directory. > > The vendor directory should only contain manifest file and all other code > should be fetched from third party repository. > > If we have made some modification to those libraries, then we need to move > them to a proper place. > > -- > Best Regards, > Yang. >
[Discuss] Should we clean up vendor/github.com/go-ecosystem for ServiceCenter
Hi All, Currently we store github.com/go-ecosystem/grpc-gateway and go-grpc-prometheus under the vendor directory. The vendor directory should only contain manifest file and all other code should be fetched from third party repository. If we have made some modification to those libraries, then we need to move them to a proper place. -- Best Regards, Yang.
