[jira] Assigned: (SLING-1545) ScripteEngineManagerFactory is not thread safe

2010-10-19 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-1545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reassigned SLING-1545:
---

Assignee: Carsten Ziegeler

 ScripteEngineManagerFactory is not thread safe
 --

 Key: SLING-1545
 URL: https://issues.apache.org/jira/browse/SLING-1545
 Project: Sling
  Issue Type: Improvement
  Components: Scripting
Affects Versions: Scripting Core 2.0.12
Reporter: Felix Meschberger
Assignee: Carsten Ziegeler
 Fix For: Scripting Core 2.0.12


 The ScriptEngineManagerFactory class is not thread-safe:
   * Access to the engineSpiBundles, engineSpiServices fields (lists) are not 
 guarded
   * Calls to refreshScriptEngineManager are not guarded
 This may cause improper states under certain circumstances.
 Accesses to these internal fields and methods should properly be guarded.
 In addition, replacement of the List as collection of the SPI bundles and 
 service by Set should be considered.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: Debugging JavaScript esp files

2010-10-19 Thread Felix Meschberger
Hi Sandro,

On 19.10.2010 02:39, Sandro Boehme wrote:
 Hi Felix,
 
 after diving into the topic I got the following understanding. Please
 correct me if I'm wrong.
 o In the Eclipse preferences one needs to map *.esp files to the
 JavaScript content type.

Yes. Likewise for *.ecma. Though I have issues setting breakpoints on
*.esp files because on my box Eclipse tells it cannot resolve the line
number to set the breakpoint on.

 o Now its possible to set a breakpoint in the esp file.
 o Next one needs to load the esp script file in the Breakpoints view.
 o Starting the debugger now calls new
 ...jsdt.debug.internal.rhino.jsdi.VirtualMachineImpl() which sends a
 scripts command request [1] to the
 ...jsdt.debug.internal.rhino.debugger.RequestHandler on the server side.
 That handler calls
 ...jsdt.debug.internal.rhino.debugger.RhinoDebuggerImpl.getScriptIds().
 The only location that sets the script id's is the
 handleCompilationDone() method of RhinoDebuggerImpl. I only see that
 indirectly called by
 oas.scripting.javascript.helper.SlingGlobal.require() and .execIdCall().
 As the latter is a method from org.mozilla.javascript.IdFunctionCall
 there are too many possible callers and I cannot easily find out if the
 trigger to load the JavaScript files is already there somewhere.
 
 I guess we only need to trigger the handleCompilationDone() methode
 somewhere in Sling but I don't know enough about Sling to decide where
 that would fit in or what to configure to make it fit. Maybe it could be
 triggered during
 ...scripting.javascript.internal.RhinoJavaScriptEngine.eval(). Do you
 have an idea?

Actually from my traces I see, that the Eclipse rhino.debugger bundle in
facts replies to the compilationDone event and informs the Eclipse
debugger about this.

Then the Eclipse debugger is probably supposed to send back breakpoints
for the script but fails to do so because of script path issues: Sling
reports script paths as they exist in Sling, e.g.
/apps/sling/nt/folder.html. Eclipse on the other hand (I am creating a
folder linking to a WebDAV mount of Sling) reports the script path as
the project IPath, that is prefixed with the project name and path to
the linked script folder.

In the end the Eclipse debugger is not able to match the script reported
from rhino.debugger in Sling with the script in Eclipse ...

I once debugged this and hacked the correct path into and in fact was
able to break a script and step through it. But we probably really need
some way of mapping the script paths ... I just didn't find out how to,
for example, set a prefix to cut off to get the actual script path from
the project's path.

Regards
Felix

 
 Best,
 
 Sandro
 
 [1] - http://wiki.eclipse.org/JSDT/Debug/Rhino_Debug_Wire_Protocol#scripts
 
 
 Am 18.10.10 02:58, schrieb Sandro Boehme:
 Hi Felix,

 that was fast. I'm impressed.
 Thanks for the tutorial. I can connect too but the debugger also doesn't
 stop at my breakpoint like in your case.

 Best,

 Sandro

 PS: Just in case somebody else want to follow: The export in step 5 is
 org.mozilla.javascript.debug.


 Am 17.10.10 23:00, schrieb Felix Meschberger:
 Hi,

 On 17.10.2010 20:34, Justin Edelson wrote:
 On Sun, Oct 17, 2010 at 2:28 PM, Felix
 Meschbergerfmesc...@gmail.com wrote:
 Hi,

 On 17.10.2010 16:05, Sandro Boehme wrote:
 Hi Felix,

 thanks for the feedback.
 The Swing debugger GUI doesn't seem to work in this case as it cannot
 open e.g. the explorer.esp file. It says:
 Syntax error (.../explorer.esp#83)
 This refers to the line containing only form action=# which is
 correct in my opinion.

 I would expect the line to be correct, but I must admit to not have
 used
 this for quite some time, so ... this may really not properly work
 (unfortunately).


 I also tried the Eclipse IDE for JavaScript Web Developers from
 http://www.eclipse.org/downloads/ as it contains debugging support
 for
 Rhino (http://wiki.eclipse.org/JSDT/Debug). But it doesn't work
 out of
 the box. Even though it is based on JPDA I guess there needs to be
 something Rhino specific installed on the serverside.

 Sounds interesting. Would be exactly what I had in mind ;-) Will
 investigate.

 It'd be better if this page wasn't blank:
 http://wiki.eclipse.org/JSDT/Debug/Embedding_Rhino_Debugger

 Yes, well, I got it sort of working with a bit hacking 

 1. deploy two JSDT bundles into Sling:
 org.eclipse.wst.jsdt.debug.rhino.debugger
 org.eclipse.wst.jsdt.debug.transport
 (ignore for now that these bundles use Require-Bundle
 and export internals ...)
 2. upgrade Sling Rhino reference to 1.7R2
 3. inside Sling add a dependency to the
 org.eclipse.wst.jsdt.debug.rhino.debugger project checked
 out from Eclipse CVS
 4. In the SlingContextFactory constructor instantiate a RhinoDebugger
 with a connector string (e.g.
 transport=socket,suspend=n,address=9000), register it as a
 listener and start the RhinoDebugger
 5. Export org.mozilla.javascript.debugger package and add an
 optional import to 

[jira] Resolved: (SLING-1842) IllegalStateException in DefaultErrorHandlerServlet when HttpServletResponse.getOutputStream() already called

2010-10-19 Thread Felix Meschberger (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Felix Meschberger resolved SLING-1842.
--

Resolution: Fixed

Thanks for the feedback. Thus I think this can be resolved.

 IllegalStateException in DefaultErrorHandlerServlet when 
 HttpServletResponse.getOutputStream() already called
 -

 Key: SLING-1842
 URL: https://issues.apache.org/jira/browse/SLING-1842
 Project: Sling
  Issue Type: Bug
  Components: Engine, Servlets
Affects Versions: Servlets Resolver 2.1.0, Engine 2.1.0
Reporter: Carl Hall
Assignee: Felix Meschberger
 Fix For: Servlets Resolver 2.1.2, Engine 2.1.2

 Attachments: SLING-1842.diff


 When getOutputStream() has been called, DefaultErrorHandlerServlet is unable 
 to write the error page and dumps an exception in the logs.  It'd be nice if 
 it failed a bit more gracefully.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (SLING-1545) ScripteEngineManagerFactory is not thread safe

2010-10-19 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-1545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-1545.
-

Resolution: Fixed

I changed the lists to sets and refactored the code. The old script manager is 
now marked invalid on changes and recreated on next access. This avoids 
blocking the bind/unbind method for a longer time.
Changed in revision 1024145

 ScripteEngineManagerFactory is not thread safe
 --

 Key: SLING-1545
 URL: https://issues.apache.org/jira/browse/SLING-1545
 Project: Sling
  Issue Type: Improvement
  Components: Scripting
Affects Versions: Scripting Core 2.0.12
Reporter: Felix Meschberger
Assignee: Carsten Ziegeler
 Fix For: Scripting Core 2.0.12


 The ScriptEngineManagerFactory class is not thread-safe:
   * Access to the engineSpiBundles, engineSpiServices fields (lists) are not 
 guarded
   * Calls to refreshScriptEngineManager are not guarded
 This may cause improper states under certain circumstances.
 Accesses to these internal fields and methods should properly be guarded.
 In addition, replacement of the List as collection of the SPI bundles and 
 service by Set should be considered.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[VOTE] Apache Sling Scripting Core 2.0.12, Scripting JSP 2.0.10, Scripting JavaScript 2.0.8, and Scripting JSP Taglib 2.1.0

2010-10-19 Thread Carsten Ziegeler
Hi,

this is the release vote for our scripting stuff for SLING-6.

This vote is for the release of:

Apache Sling Scripting Core 2.0.12
Apache Sling Scripting JavaScript 2.0.8
Apache Sling Scripting JSP 2.0.10
Apache Sling Scripting JSP-Taglib 2.1.0

Changes in these releases:

Apache Sling Scripting Core 2.0.12
https://issues.apache.org/jira/browse/SLING/fixforversion/12314797

Apache Sling Scripting JavaScript 2.0.8
https://issues.apache.org/jira/browse/SLING/fixforversion/12314406

Apache Sling Scripting JSP 2.0.10
https://issues.apache.org/jira/browse/SLING/fixforversion/12314407

Apache Sling Scripting JSP-Taglib 2.1.0
https://issues.apache.org/jira/browse/SLING/fixforversion/12314408

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-004/

You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 004 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This vote will be open for 72 hours.

Regards
Carsten

-- 
Carsten Ziegeler
cziege...@apache.org


Re: [VOTE] Apache Sling Scripting Core 2.0.12, Scripting JSP 2.0.10, Scripting JavaScript 2.0.8, and Scripting JSP Taglib 2.1.0

2010-10-19 Thread Carsten Ziegeler
+1 Approve the release

Apache Sling Scripting Core 2.0.12
Apache Sling Scripting JavaScript 2.0.8
Apache Sling Scripting JSP 2.0.10
Apache Sling Scripting JSP-Taglib 2.1.0

Carsten

-- 
Carsten Ziegeler
cziege...@apache.org


Build failed in Hudson: sling-trunk-1.5 » Apache Sling Launchpad Maven Plugin #930

2010-10-19 Thread Apache Hudson Server
See 
https://hudson.apache.org/hudson/job/sling-trunk-1.5/org.apache.sling$maven-launchpad-plugin/930/

--
[INFO] 
[INFO] Building Apache Sling Launchpad Maven Plugin
[INFO]task-segment: [clean, deploy]
[INFO] 
[INFO] [clean:clean {execution: default-clean}]
[INFO] Deleting file set: 
https://hudson.apache.org/hudson/job/sling-trunk-1.5/org.apache.sling$maven-launchpad-plugin/ws/target
 (included: [**], excluded: [])
[INFO] snapshot 
org.apache.sling:org.apache.sling.launchpad.base:2.2.1-SNAPSHOT: checking for 
updates from apache.snapshots
[INFO] [enforcer:enforce {execution: enforce-java}]
[INFO] [groovy:execute {execution: save-bundle-metadata}]
[INFO] [modello:java {execution: bundle-manifest.xml}]
[INFO] outputDirectory: 
https://hudson.apache.org/hudson/job/sling-trunk-1.5/org.apache.sling$maven-launchpad-plugin/ws/target/generated-sources/modello
[INFO] Working on model: src/main/mdo/bundle-list.xml
[INFO] Generating current version: 1.0.0
[INFO] [modello:xpp3-reader {execution: bundle-manifest.xml}]
[INFO] outputDirectory: 
https://hudson.apache.org/hudson/job/sling-trunk-1.5/org.apache.sling$maven-launchpad-plugin/ws/target/generated-sources/modello
[INFO] Working on model: src/main/mdo/bundle-list.xml
[INFO] Generating current version: 1.0.0
[INFO] [modello:xpp3-writer {execution: bundle-manifest.xml}]
[INFO] outputDirectory: 
https://hudson.apache.org/hudson/job/sling-trunk-1.5/org.apache.sling$maven-launchpad-plugin/ws/target/generated-sources/modello
[INFO] Working on model: src/main/mdo/bundle-list.xml
[INFO] Generating current version: 1.0.0
[INFO] [plugin:descriptor {execution: default-descriptor}]
[INFO] Using 'UTF-8' encoding to read mojo metadata.
[INFO] Applying mojo extractor for language: java
[INFO] Mojo extractor for language: java found 11 mojo descriptors.
[INFO] Applying mojo extractor for language: bsh
[INFO] Mojo extractor for language: bsh found 0 mojo descriptors.
[INFO] [remote-resources:process {execution: default}]
[INFO] [resources:resources {execution: default-resources}]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 2 resources
[INFO] Copying 3 resources
[INFO] [antrun:run {execution: default}]
[INFO] Executing tasks
 [echo]  WARNING (SLING-443/SLING-1782) 
**
 [echo] On most platforms, you'll get OutOfMemoryErrors when building 
unless you set
 [echo] on 32bit platforms: MAVEN_OPTS=-Xmx256M -XX:MaxPermSize=256M, see 
SLING-443
 [echo] on 64bit platforms: MAVEN_OPTS=-Xmx512M -XX:MaxPermSize=512M, see 
SLING-1782
 [echo] 
**
[INFO] Executed tasks
[INFO] [compiler:compile {execution: default-compile}]
[INFO] Compiling 24 source files to 
https://hudson.apache.org/hudson/job/sling-trunk-1.5/org.apache.sling$maven-launchpad-plugin/ws/target/classes
[INFO] [resources:testResources {execution: default-testResources}]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 
https://hudson.apache.org/hudson/job/sling-trunk-1.5/org.apache.sling$maven-launchpad-plugin/ws/src/test/resources
[INFO] Copying 3 resources
[INFO] [compiler:testCompile {execution: default-testCompile}]
[INFO] Compiling 1 source file to 
https://hudson.apache.org/hudson/job/sling-trunk-1.5/org.apache.sling$maven-launchpad-plugin/ws/target/test-classes
[INFO] [surefire:test {execution: default-test}]
[INFO] Surefire report directory: 
https://hudson.apache.org/hudson/job/sling-trunk-1.5/org.apache.sling$maven-launchpad-plugin/ws/target/surefire-reports

---
 T E S T S
---
Running org.apache.sling.maven.projectsupport.PreparePackageMojoTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.047 sec

Results :

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0

[HUDSON] Recording test results
[INFO] [emma:instrument {execution: default}]
[INFO] Instrumenting classes with EMMA
processing instrumentation path ...
instrumentation path processed in 5 ms
[0 class(es) instrumented, 34 resource(s) copied]
no output created: metadata is empty
[INFO] [jar:jar {execution: default-jar}]
[INFO] Building jar: 
https://hudson.apache.org/hudson/job/sling-trunk-1.5/org.apache.sling$maven-launchpad-plugin/ws/target/maven-launchpad-plugin-2.0.7-SNAPSHOT.jar
[INFO] [plugin:addPluginArtifactMetadata {execution: 
default-addPluginArtifactMetadata}]
[INFO] Preparing source:jar
[WARNING] Removing: jar from forked lifecycle, to prevent recursive invocation.
[HUDSON] Archiving 
https://hudson.apache.org/hudson/job/sling-trunk-1.5/org.apache.sling$maven-launchpad-plugin/ws/pom.xml
 to 

Build failed in Hudson: sling-trunk-1.5 #930

2010-10-19 Thread Apache Hudson Server
See https://hudson.apache.org/hudson/job/sling-trunk-1.5/930/changes

Changes:

[cziegeler] Go back to parent pom 10-snapshot and use latest snapshots for 
launchpad

[cziegeler] Go back to parent pom 10-snapshot and use latest snapshots for 
launchpad

[cziegeler] [maven-release-plugin] prepare for next development iteration

[cziegeler] [maven-release-plugin] prepare release 
org.apache.sling.scripting.jsp.taglib-2.1.0

[cziegeler] Update export version

[cziegeler] [maven-release-plugin] prepare for next development iteration

[cziegeler] [maven-release-plugin] prepare release 
org.apache.sling.scripting.jsp-2.0.10

[cziegeler] [maven-release-plugin] prepare for next development iteration

[cziegeler] [maven-release-plugin] prepare release 
org.apache.sling.scripting.javascript-2.0.8

[cziegeler] [maven-release-plugin] prepare for next development iteration

[cziegeler] [maven-release-plugin] prepare release 
org.apache.sling.scripting.core-2.0.12

[cziegeler] Prepare for release - going back to parent pom 9

[cziegeler] SLING-1545 : ScripteEngineManagerFactory is not thread safe

[cziegeler] Lock on special lock object and add a dropping queue

--
[...truncated 1271 lines...]
[HUDSON] Archiving 
https://hudson.apache.org/hudson/job/sling-trunk-1.5/ws/trunk/maven/maven-sling-plugin/target/maven-sling-plugin-2.0.5-SNAPSHOT.jar
 to 
/home/hudson/hudson/jobs/sling-trunk-1.5/modules/org.apache.sling$maven-sling-plugin/builds/2010-10-19_08-46-30/archive/org.apache.sling/maven-sling-plugin/2.0.5-20101019.084705-507/maven-sling-plugin-2.0.5-SNAPSHOT.jar
[HUDSON] Archiving 
https://hudson.apache.org/hudson/job/sling-trunk-1.5/ws/trunk/maven/maven-sling-plugin/target/maven-sling-plugin-2.0.5-SNAPSHOT-sources.jar
 to 
/home/hudson/hudson/jobs/sling-trunk-1.5/modules/org.apache.sling$maven-sling-plugin/builds/2010-10-19_08-46-30/archive/org.apache.sling/maven-sling-plugin/2.0.5-20101019.084705-507/maven-sling-plugin-2.0.5-SNAPSHOT-sources.jar
[INFO] 
[INFO] Building Apache Sling Launchpad Base
[INFO]task-segment: [clean, deploy]
[INFO] 
[INFO] [clean:clean {execution: default-clean}]
[INFO] Deleting file set: 
https://hudson.apache.org/hudson/job/sling-trunk-1.5/ws/trunk/launchpad/base/target
 (included: [**], excluded: [])
[INFO] [enforcer:enforce {execution: enforce-java}]
[INFO] [groovy:execute {execution: save-bundle-metadata}]
[INFO] [dependency:copy-dependencies {execution: copy-felix-httpservice-bridge}]
[INFO] Copying org.apache.felix.http.bridge-2.0.4.jar to 
https://hudson.apache.org/hudson/job/sling-trunk-1.5/ws/trunk/launchpad/base/target/felix-bridge/org.apache.felix.http.bridge-2.0.4.jar
[INFO] [dependency:unpack-dependencies {execution: extract-sling-commons-osgi}]
[INFO] Unpacking 
/home/hudson/.m2/repository/org/apache/sling/org.apache.sling.commons.osgi/2.0.6/org.apache.sling.commons.osgi-2.0.6.jar
 to
  
https://hudson.apache.org/hudson/job/sling-trunk-1.5/ws/trunk/launchpad/base/target/classes
   with includes null and excludes:null
[INFO] [dependency:unpack-dependencies {execution: extract-osgi-framework}]
[INFO] Unpacking 
/home/hudson/.m2/repository/org/apache/felix/org.apache.felix.framework/3.0.2/org.apache.felix.framework-3.0.2.jar
 to
  
https://hudson.apache.org/hudson/job/sling-trunk-1.5/ws/trunk/launchpad/base/target/classes
   with includes null and excludes:null
[INFO] [remote-resources:process {execution: default}]
[INFO] [resources:resources {execution: default-resources}]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] [antrun:run {execution: default}]
[INFO] Executing tasks
 [echo]  WARNING (SLING-443/SLING-1782) 
**
 [echo] On most platforms, you'll get OutOfMemoryErrors when building 
unless you set
 [echo] on 32bit platforms: MAVEN_OPTS=-Xmx256M -XX:MaxPermSize=256M, see 
SLING-443
 [echo] on 64bit platforms: MAVEN_OPTS=-Xmx512M -XX:MaxPermSize=512M, see 
SLING-1782
 [echo] 
**
[INFO] Executed tasks
[INFO] [compiler:compile {execution: default-compile}]
[INFO] Compiling 22 source files to 
https://hudson.apache.org/hudson/job/sling-trunk-1.5/ws/trunk/launchpad/base/target/classes
[INFO] [resources:testResources {execution: default-testResources}]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] [compiler:testCompile {execution: default-testCompile}]
[INFO] Compiling 4 source files to 
https://hudson.apache.org/hudson/job/sling-trunk-1.5/ws/trunk/launchpad/base/target/test-classes
[INFO] [surefire:test {execution: default-test}]
[INFO] Surefire report directory: 

Hudson build is still unstable: sling-trun k-1.6 » Apache Sling Launchpad Testing #616

2010-10-19 Thread Apache Hudson Server
See 
https://hudson.apache.org/hudson/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing/616/




Hudson build is still unstable: sling-trunk-1.6 #616

2010-10-19 Thread Apache Hudson Server
See https://hudson.apache.org/hudson/job/sling-trunk-1.6/changes




Re: Debugging JavaScript esp files

2010-10-19 Thread Sandro Boehme

Hi Felix,

Am 19.10.10 08:48, schrieb Felix Meschberger:
 o In the Eclipse preferences one needs to map *.esp files to the
 JavaScript content type.

 Yes. Likewise for *.ecma. Though I have issues setting breakpoints on
 *.esp files because on my box Eclipse tells it cannot resolve the line
 number to set the breakpoint on.
I had the same problem first. But after adding *.esp to the JavaScript 
content type and then opening the esp file with the JavaScript editor it 
worked without problems.



I cannot easily find out if the
trigger to load the JavaScript files is already there somewhere.

I guess we only need to trigger the handleCompilationDone() methode
somewhere in Sling but I don't know enough about Sling to decide where
that would fit in or what to configure to make it fit. Maybe it could be
triggered during
...scripting.javascript.internal.RhinoJavaScriptEngine.eval(). Do you
have an idea?


Actually from my traces I see, that the Eclipse rhino.debugger bundle in
facts replies to the compilationDone event and informs the Eclipse
debugger about this.

This sounds good. What did you do to trigger the compilationDone event?
If that works I get some example scripts from the server and can then 
try to find a mapping for the paths.




Then the Eclipse debugger is probably supposed to send back breakpoints
for the script but fails to do so because of script path issues: Sling
reports script paths as they exist in Sling, e.g.
/apps/sling/nt/folder.html. Eclipse on the other hand (I am creating a
folder linking to a WebDAV mount of Sling) reports the script path as
the project IPath, that is prefixed with the project name and path to
the linked script folder.

In the end the Eclipse debugger is not able to match the script reported
from rhino.debugger in Sling with the script in Eclipse ...

I once debugged this and hacked the correct path into and in fact was
able to break a script and step through it. But we probably really need
some way of mapping the script paths ... I just didn't find out how to,
for example, set a prefix to cut off to get the actual script path from
the project's path.

Thanks for the details.

Best,

Sandro


Re: Debugging JavaScript esp files

2010-10-19 Thread Felix Meschberger
Hi,

On 19.10.2010 13:20, Sandro Boehme wrote:
 Hi Felix,
 
 Am 19.10.10 08:48, schrieb Felix Meschberger:
 o In the Eclipse preferences one needs to map *.esp files to the
 JavaScript content type.

 Yes. Likewise for *.ecma. Though I have issues setting breakpoints on
 *.esp files because on my box Eclipse tells it cannot resolve the line
 number to set the breakpoint on.
 I had the same problem first. But after adding *.esp to the JavaScript
 content type and then opening the esp file with the JavaScript editor it
 worked without problems.
 
 I cannot easily find out if the
 trigger to load the JavaScript files is already there somewhere.

 I guess we only need to trigger the handleCompilationDone() methode
 somewhere in Sling but I don't know enough about Sling to decide where
 that would fit in or what to configure to make it fit. Maybe it could be
 triggered during
 ...scripting.javascript.internal.RhinoJavaScriptEngine.eval(). Do you
 have an idea?

 Actually from my traces I see, that the Eclipse rhino.debugger bundle in
 facts replies to the compilationDone event and informs the Eclipse
 debugger about this.
 This sounds good. What did you do to trigger the compilationDone event?
 If that works I get some example scripts from the server and can then
 try to find a mapping for the paths.

I wrote a simple /apps/nt/folder/html.esp script and then requested a
folder from Sling. This causes the html.esp script to be loaded and thus
the compilationDone event is sent and handled.

I did not have to do anything else.

Regards
Felix


 

 Then the Eclipse debugger is probably supposed to send back breakpoints
 for the script but fails to do so because of script path issues: Sling
 reports script paths as they exist in Sling, e.g.
 /apps/sling/nt/folder.html. Eclipse on the other hand (I am creating a
 folder linking to a WebDAV mount of Sling) reports the script path as
 the project IPath, that is prefixed with the project name and path to
 the linked script folder.

 In the end the Eclipse debugger is not able to match the script reported
 from rhino.debugger in Sling with the script in Eclipse ...

 I once debugged this and hacked the correct path into and in fact was
 able to break a script and step through it. But we probably really need
 some way of mapping the script paths ... I just didn't find out how to,
 for example, set a prefix to cut off to get the actual script path from
 the project's path.
 Thanks for the details.
 
 Best,
 
 Sandro
 


Re: Debugging JavaScript esp files

2010-10-19 Thread Sandro Boehme

Am 19.10.10 13:41, schrieb Felix Meschberger:

Hi,

I cannot easily find out if the
trigger to load the JavaScript files is already there somewhere.

I guess we only need to trigger the handleCompilationDone() methode
somewhere in Sling but I don't know enough about Sling to decide where
that would fit in or what to configure to make it fit. Maybe it could be
triggered during
...scripting.javascript.internal.RhinoJavaScriptEngine.eval(). Do you
have an idea?


Actually from my traces I see, that the Eclipse rhino.debugger bundle in
facts replies to the compilationDone event and informs the Eclipse
debugger about this.

This sounds good. What did you do to trigger the compilationDone event?
If that works I get some example scripts from the server and can then
try to find a mapping for the paths.


I wrote a simple /apps/nt/folder/html.esp script and then requested a
folder from Sling. This causes the html.esp script to be loaded and thus
the compilationDone event is sent and handled.

I did not have to do anything else.
Ah, I thought the compilationDone event should also get triggered if the 
bundle containing the script is deployed normally. But ok, I understand. 
The trigger is the update to WebDav.


Best,

Sandro


Re: Debugging JavaScript esp files

2010-10-19 Thread Felix Meschberger
Hi,

On 19.10.2010 14:21, Sandro Boehme wrote:
 Am 19.10.10 13:41, schrieb Felix Meschberger:
 Hi,
 I cannot easily find out if the
 trigger to load the JavaScript files is already there somewhere.

 I guess we only need to trigger the handleCompilationDone() methode
 somewhere in Sling but I don't know enough about Sling to decide where
 that would fit in or what to configure to make it fit. Maybe it
 could be
 triggered during
 ...scripting.javascript.internal.RhinoJavaScriptEngine.eval(). Do you
 have an idea?

 Actually from my traces I see, that the Eclipse rhino.debugger
 bundle in
 facts replies to the compilationDone event and informs the Eclipse
 debugger about this.
 This sounds good. What did you do to trigger the compilationDone event?
 If that works I get some example scripts from the server and can then
 try to find a mapping for the paths.

 I wrote a simple /apps/nt/folder/html.esp script and then requested a
 folder from Sling. This causes the html.esp script to be loaded and thus
 the compilationDone event is sent and handled.

 I did not have to do anything else.
 Ah, I thought the compilationDone event should also get triggered if the
 bundle containing the script is deployed normally. But ok, I understand.
 The trigger is the update to WebDav.

No, the triger is the actual execution of the script: Rhino first
compiles the script into an AST and the executes that. Once the script
has been compiled into the AST (a by-product could in fact be writing a
Java Class File) the compilationDone event is fired (IIRC).

Regards
Felix


Re: [VOTE] Initial Content and Servlet Archetypes 1.0.0

2010-10-19 Thread Justin Edelson
+1

On Fri, Oct 15, 2010 at 10:45 AM, Justin Edelson jus...@apache.org wrote:
 Hi,

 This vote is for:
 Sling Initial Content Archetype 1.0.0
 Sling Servlet Archetype 1.0.0

 This is the initial version of each.

 Staging repository:
 https://repository.apache.org/content/repositories/orgapachesling-001/

 You can use this UNIX script to download the release and verify the 
 signatures:
 http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

 Usage:
 sh check_staged_release.sh 001 /tmp/sling-staging

 Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

 This vote will be open for 72 hours.

 Thanks,
 Justin



[RESULT] [VOTE] Release Apache Sling Initial Content and Servlet Archetypes 1.0.0

2010-10-19 Thread Justin Edelson
Hi,

The vote has passed with the following result :

+1 (binding): Carsten Ziegeler, Felix Meschberger, Mike Muller, Ian
Boston, Justin Edelson
+1 (non-binding): Eric Norman

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

Justin


[jira] Closed: (SLING-1844) rename resources archetype to initial-content

2010-10-19 Thread Justin Edelson (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-1844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Edelson closed SLING-1844.
-


 rename resources archetype to initial-content
 ---

 Key: SLING-1844
 URL: https://issues.apache.org/jira/browse/SLING-1844
 Project: Sling
  Issue Type: Improvement
  Components: Maven Plugins and Archetypes
Reporter: Justin Edelson
Assignee: Justin Edelson
 Fix For: Initial Content Archetype 1.0.0


 this archetype is really about JCR content. a separate archetype can be 
 created for bundle resources.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (SLING-1054) Maven archetypes

2010-10-19 Thread Justin Edelson (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Edelson updated SLING-1054:
--

Fix Version/s: Launchpad Standalone Archetype 1.0.0
   Launchpad Webapp Archetype 1.0.0

 Maven archetypes
 

 Key: SLING-1054
 URL: https://issues.apache.org/jira/browse/SLING-1054
 Project: Sling
  Issue Type: Improvement
  Components: Maven Plugins and Archetypes
Reporter: Bertil Chapuis
Assignee: Justin Edelson
Priority: Minor
 Fix For: Initial Content Archetype 1.0.0, Servlet Archetype 
 1.0.0, Launchpad Webapp Archetype 1.0.0, Launchpad Standalone Archetype 1.0.0

 Attachments: sling-archetypes.tar.gz


 Providing maven archetypes could help people diving more quickly in sling. 
 More samples could also be proposed in this form. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: [VOTE] Apache Sling Scripting Core 2.0.12, Scripting JSP 2.0.10, Scripting JavaScript 2.0.8, and Scripting JSP Taglib 2.1.0

2010-10-19 Thread Justin Edelson
+1

Thanks

On 10/19/10 4:49 AM, Carsten Ziegeler wrote:
 Hi,
 
 this is the release vote for our scripting stuff for SLING-6.
 
 This vote is for the release of:
 
 Apache Sling Scripting Core 2.0.12
 Apache Sling Scripting JavaScript 2.0.8
 Apache Sling Scripting JSP 2.0.10
 Apache Sling Scripting JSP-Taglib 2.1.0
 
 Changes in these releases:
 
 Apache Sling Scripting Core 2.0.12
 https://issues.apache.org/jira/browse/SLING/fixforversion/12314797
 
 Apache Sling Scripting JavaScript 2.0.8
 https://issues.apache.org/jira/browse/SLING/fixforversion/12314406
 
 Apache Sling Scripting JSP 2.0.10
 https://issues.apache.org/jira/browse/SLING/fixforversion/12314407
 
 Apache Sling Scripting JSP-Taglib 2.1.0
 https://issues.apache.org/jira/browse/SLING/fixforversion/12314408
 
 Staging repository:
 https://repository.apache.org/content/repositories/orgapachesling-004/
 
 You can use this UNIX script to download the release and verify the
 signatures:
 http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
 
 Usage:
 sh check_staged_release.sh 004 /tmp/sling-staging
 
 Please vote to approve this release:
 
   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...
 
 This vote will be open for 72 hours.
 
 Regards
 Carsten
 



Hudson build is still unstable: sling-trun k-1.6 » Apache Sling Launchpad Testing #617

2010-10-19 Thread Apache Hudson Server
See 
https://hudson.apache.org/hudson/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing/617/




Hudson build is still unstable: sling-trunk-1.6 #617

2010-10-19 Thread Apache Hudson Server
See https://hudson.apache.org/hudson/job/sling-trunk-1.6/changes




Build failed in Hudson: sling-trun k-1.5 » Apache Sling (Parent) #931

2010-10-19 Thread Apache Hudson Server
See 
https://hudson.apache.org/hudson/job/sling-trunk-1.5/org.apache.sling$sling/931/

--
===[HUDSON REMOTING CAPACITY]===channel started
   Executing Maven:  -B -f 
/home/hudson/hudson-slave/workspace/sling-trunk-1.5/trunk/pom.xml 
-DobrRepository=false clean deploy -DHttpTestBase.readyTimeoutSeconds=300
[INFO] Scanning for projects...
[INFO] Reactor build order: 
[INFO]   Apache Sling (Parent)
[INFO]   Apache Sling Maven Plugin to create Jackrabbit OCM descriptors
[INFO]   Apache Sling API
[INFO]   Apache Sling Scripting Implementation API
[INFO]   Apache Sling Dynamic Class Loader Support
[INFO]   Apache Sling Scripting JSP Support
[INFO]   Apache Sling Maven Plugin for Compiling JSP Sources into Bundles
[INFO]   Apache Sling Repository API Bundle
[INFO]   Apache Sling Commons OSGi support
[INFO]   Apache Sling Adapter Manager Implementation
[INFO]   Apache Sling Testing Utilities
[INFO]   Apache Sling JSON Library
[INFO]   Apache Sling Maven Plugin for Supporting Bundle Development
[INFO]   Apache Sling Launchpad Base
[INFO]   Apache Sling Launchpad Maven Plugin
[INFO]   Sling Launchpad Standalone Archetype
[INFO]   Sling Launchpad Webapp Archetype
[INFO]   Sling Initial Content Archetype
[INFO]   Sling Servlet Archetype
[INFO]   Apache Sling OSGi LogService Implementation
[INFO]   Apache Sling MIME type mapping support
[INFO]   Apache Sling Thread Support
[INFO]   Apache Sling Scheduler Support
[INFO]   Apache Sling Authentication Service
[INFO]   Apache Sling JCR Base Bundle
[INFO]   Apache Sling Jackrabbit Embedded Repository
[INFO]   Apache Sling OpenID Authentication
[INFO]   Apache Sling Form Based Authentication Handler
[INFO]   Apache Sling Authentication Selector
[INFO]   Apache Sling Settings
[INFO]   Apache Sling Engine Implementation
[INFO]   Apache Sling JCR ClassLoader
[INFO]   Apache Sling Initial Content Loader
[INFO]   Apache Sling JCR Resource Resolver
[INFO]   Apache Sling Default POST Servlets
[INFO]   Apache Sling Jackrabbit UserManager Support
[INFO]   Apache Sling Jackrabbit JSR-283 Access Control Manager Support
[INFO]   Apache Sling Object Content Mapping
[INFO]   Apache Sling Simple WebDAV Access to repositories
[INFO]   Apache Sling DavEx Access to repositories
[INFO]   Apache Sling JCR WebConsole Bundle
[INFO]   Apache Sling Servlet Resolver
[INFO]   Apache Sling Default GET Servlets
[INFO]   Apache Sling Scripting Core implementation
[INFO]   Apache Sling Scripting JavaScript Support
[INFO]   Apache Sling JSP Tag Library
[INFO]   Apache Sling Bundle Resource Provider
[INFO]   Apache Sling Event Support
[INFO]   Apache Sling Filesystem Resource Provider
[INFO]   Apache Sling Thread Dumper
[INFO]   Apache Sling Web Console Branding
[INFO]   Apache Sling Web Console Security Provider
[INFO]   Apache Sling Groovy Extensions
[INFO]   Apache Sling Explorer
[INFO]   Apache Sling Installer
[INFO]   Apache Sling File Installer
[INFO]   Apache Sling JCR Installer
[INFO]   Apache Sling Installer Integration Tests
[INFO]   Apache Sling Launchpad Content
[INFO]   Apache Sling Launchpad Application Builder
[INFO]   Apache Sling Launchpad Testing Services
[INFO]   Apache Sling Launchpad Testing Services WAR
[INFO]   Apache Sling Integration Tests
[INFO]   Apache Sling Launchpad Testing
[INFO]   Apache Sling (Builder)
[INFO] 
[INFO] Building Apache Sling (Parent)
[INFO]task-segment: [clean, deploy]
[INFO] 
[INFO] [clean:clean {execution: default-clean}]
[INFO] Deleting file set: 
https://hudson.apache.org/hudson/job/sling-trunk-1.5/org.apache.sling$sling/ws/target
 (included: [**], excluded: [])
[INFO] [enforcer:enforce {execution: enforce-java}]
[INFO] [groovy:execute {execution: save-bundle-metadata}]
[INFO] Setting property: classpath.resource.loader.class = 
'org.codehaus.plexus.velocity.ContextClassLoaderResourceLoader'.
[INFO] Setting property: velocimacro.messages.on = 'false'.
[INFO] Setting property: resource.loader = 'classpath'.
[INFO] Setting property: resource.manager.logwhenfound = 'false'.
[INFO] [remote-resources:process {execution: default}]
[INFO] [antrun:run {execution: default}]
[INFO] Executing tasks
 [echo]  WARNING (SLING-443/SLING-1782) 
**
 [echo] On most platforms, you'll get OutOfMemoryErrors when building 
unless you set
 [echo] on 32bit platforms: MAVEN_OPTS=-Xmx256M -XX:MaxPermSize=256M, see 
SLING-443
 [echo] on 64bit platforms: MAVEN_OPTS=-Xmx512M -XX:MaxPermSize=512M, see 
SLING-1782
 [echo] 
**
[INFO] Executed tasks
[INFO] [emma:instrument {execution: default}]
[INFO] Not executing EMMA, as the project is not a Java classpath-capable 
package
[INFO] [site:attach-descriptor {execution: default-attach-descriptor}]
[INFO] Preparing 

Making emma stuff optional?

2010-10-19 Thread Carsten Ziegeler
Hi,

can we make the emma stuff optional? Currently the file coverage.em is
created in the root of each module (which is not in svn:ignore atm - no
problem with that we can just add it) and an additional artifact -emma
is created, which we don't want to release/deploy.

So I think this should be turned off by default.

Regards
Carsten
-- 
Carsten Ziegeler
cziege...@apache.org


Re: Debugging JavaScript esp files

2010-10-19 Thread Sandro Boehme

Hi Felix,

Am 19.10.10 15:28, schrieb Felix Meschberger:

Hi,

On 19.10.2010 14:21, Sandro Boehme wrote:

Am 19.10.10 13:41, schrieb Felix Meschberger:

Hi,

I cannot easily find out if the
trigger to load the JavaScript files is already there somewhere.

I guess we only need to trigger the handleCompilationDone() methode
somewhere in Sling but I don't know enough about Sling to decide where
that would fit in or what to configure to make it fit. Maybe it
could be
triggered during
...scripting.javascript.internal.RhinoJavaScriptEngine.eval(). Do you
have an idea?


Actually from my traces I see, that the Eclipse rhino.debugger
bundle in
facts replies to the compilationDone event and informs the Eclipse
debugger about this.

This sounds good. What did you do to trigger the compilationDone event?
If that works I get some example scripts from the server and can then
try to find a mapping for the paths.


I wrote a simple /apps/nt/folder/html.esp script and then requested a
folder from Sling. This causes the html.esp script to be loaded and thus
the compilationDone event is sent and handled.

I did not have to do anything else.

Ah, I thought the compilationDone event should also get triggered if the
bundle containing the script is deployed normally. But ok, I understand.
The trigger is the update to WebDav.


No, the triger is the actual execution of the script: Rhino first
compiles the script into an AST and the executes that. Once the script
has been compiled into the AST (a by-product could in fact be writing a
Java Class File) the compilationDone event is fired (IIRC).
Yes of course. I guess I didn't really read This causes the html.esp 
script to be loaded and thus the compilationDone event is sent and 
handled. in the first place :-/


Best,

Sandro


cannot run the launchpad

2010-10-19 Thread Sandro Boehme

Hello,

since quite some time I'm trying to get the launchpad running in Jetty.
I build sling on a clean checkout from SVN without errors but the 
launchpad doesn't start as it is missing the Emma classes at runtime 
(see output below).

Can you tell me where I have to add the dependency to emma?

Best,

Sandro

Sandros-MacBook:builder sboehme$ mvn jetty:run
Listening for transport dt_socket at address: 30303
[INFO] Scanning for projects...
[INFO] 


[INFO] Building Apache Sling Launchpad Application Builder
[INFO]task-segment: [jetty:run]
[INFO] 


[INFO] Preparing jetty:run
[INFO] [enforcer:enforce {execution: enforce-java}]
[INFO] [groovy:execute {execution: save-bundle-metadata}]
[INFO] [launchpad:prepare-package {execution: prepare-package-war}]
[INFO] [launchpad:prepare-package {execution: prepare-package-jar}]
[INFO] Unpacking 
/Users/sboehme/maven_local_repo/org/apache/sling/org.apache.sling.launchpad.base/2.2.1-SNAPSHOT/org.apache.sling.launchpad.base-2.2.1-SNAPSHOT-app.jar 
to


/Users/sboehme/Documents/workspaces/slingtrunk/launchpad/builder/target/classes
[INFO] Setting property: classpath.resource.loader.class = 
'org.codehaus.plexus.velocity.ContextClassLoaderResourceLoader'.

[INFO] Setting property: velocimacro.messages.on = 'false'.
[INFO] Setting property: resource.loader = 'classpath'.
[INFO] Setting property: resource.manager.logwhenfound = 'false'.
[INFO] [remote-resources:process {execution: default}]
[INFO] [resources:resources {execution: default-resources}]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 
/Users/sboehme/Documents/workspaces/slingtrunk/launchpad/builder/src/main/resources

[INFO] Copying 3 resources
[INFO] [antrun:run {execution: default}]
[INFO] Executing tasks
 [echo]  WARNING (SLING-443/SLING-1782) 
**
 [echo] On most platforms, you'll get OutOfMemoryErrors when 
building unless you set
 [echo] on 32bit platforms: MAVEN_OPTS=-Xmx256M 
-XX:MaxPermSize=256M, see SLING-443
 [echo] on 64bit platforms: MAVEN_OPTS=-Xmx512M 
-XX:MaxPermSize=512M, see SLING-1782
 [echo] 
**

[INFO] Executed tasks
[INFO] [compiler:compile {execution: default-compile}]
[INFO] No sources to compile
[INFO] [resources:testResources {execution: default-testResources}]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 
/Users/sboehme/Documents/workspaces/slingtrunk/launchpad/builder/src/test/resources

[INFO] Copying 3 resources
[INFO] [compiler:testCompile {execution: default-testCompile}]
[INFO] No sources to compile
[INFO] [jetty:run {execution: default-cli}]
[INFO] Configuring Jetty for project: Apache Sling Launchpad Application 
Builder
[INFO] Webapp source directory = 
/Users/sboehme/Documents/workspaces/slingtrunk/launchpad/builder/target/org.apache.sling.launchpad-6-SNAPSHOT

[INFO] Reload Mechanic: automatic
[INFO] Classes = 
/Users/sboehme/Documents/workspaces/slingtrunk/launchpad/builder/target/classes
2010-10-19 18:33:02.452::INFO:  Logging to STDERR via 
org.mortbay.log.StdErrLog

[INFO] Context path = /
[INFO] Tmp directory =  determined at runtime
[INFO] Web defaults = org/mortbay/jetty/webapp/webdefault.xml
[INFO] Web overrides =  none
[INFO] Adding overlay: 
jar:file:/Users/sboehme/maven_local_repo/org/apache/sling/org.apache.sling.launchpad.base/2.2.1-SNAPSHOT/org.apache.sling.launchpad.base-2.2.1-SNAPSHOT-webapp.war!/
[INFO] web.xml file = 
/Users/sboehme/Documents/workspaces/slingtrunk/launchpad/builder/target/org.apache.sling.launchpad-6-SNAPSHOT/WEB-INF/web.xml
[INFO] Webapp directory = 
/Users/sboehme/Documents/workspaces/slingtrunk/launchpad/builder/target/org.apache.sling.launchpad-6-SNAPSHOT

[INFO] Starting jetty 6.1.20 ...
2010-10-19 18:33:02.476::INFO:  jetty-6.1.20
2010-10-19 18:33:02.673::INFO:  No Transaction manager found - if your 
webapp requires one, please configure one.
2010-10-19 18:33:03.162::WARN:  failed sling: 
java.lang.NoClassDefFoundError: com/vladium/emma/rt/RT
2010-10-19 18:33:03.162::WARN:  failed 
org.mortbay.jetty.plugin.jetty6pluginwebappcont...@9946e0{/,file:/Users/sboehme/Documents/workspaces/slingtrunk/launchpad/builder/target/org.apache.sling.launchpad-6-SNAPSHOT/;jar:file:/Users/sboehme/maven_local_repo/org/apache/sling/org.apache.sling.launchpad.base/2.2.1-SNAPSHOT/org.apache.sling.launchpad.base-2.2.1-SNAPSHOT-webapp.war!/;}: 
java.lang.NoClassDefFoundError: com/vladium/emma/rt/RT
2010-10-19 18:33:03.162::WARN:  failed contexthandlercollect...@8be01: 
java.lang.NoClassDefFoundError: com/vladium/emma/rt/RT
2010-10-19 18:33:03.163::WARN:  failed handlercollect...@1f24c4a: 
java.lang.NoClassDefFoundError: com/vladium/emma/rt/RT

2010-10-19 

[jira] Commented: (SLING-1803) add coverage reporting of integration tests

2010-10-19 Thread Justin Edelson (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12922627#action_12922627
 ] 

Justin Edelson commented on SLING-1803:
---

in r1024330, disabled instrumentation profile by default.

 add coverage reporting of integration tests
 ---

 Key: SLING-1803
 URL: https://issues.apache.org/jira/browse/SLING-1803
 Project: Sling
  Issue Type: New Feature
  Components: Launchpad
Reporter: Justin Edelson
Assignee: Justin Edelson

 I've tried both emma and clover. Looks like emma is the right choice as it is 
 a little more flexible in terms of breaking apart the instrumentation from 
 the test execution.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: Making emma stuff optional?

2010-10-19 Thread Justin Edelson
done in r1024330.

Justin

On 10/19/10 11:43 AM, Carsten Ziegeler wrote:
 Hi,
 
 can we make the emma stuff optional? Currently the file coverage.em is
 created in the root of each module (which is not in svn:ignore atm - no
 problem with that we can just add it) and an additional artifact -emma
 is created, which we don't want to release/deploy.
 
 So I think this should be turned off by default.
 
 Regards
 Carsten



Re: Making emma stuff optional?

2010-10-19 Thread Sandro Boehme
Thanks a lot Justin! It also fixes the problem I wrote about in the 
other mail. I can now run the launchpad again.


Best,

Sandro

Am 19.10.10 19:28, schrieb Justin Edelson:

done in r1024330.

Justin

On 10/19/10 11:43 AM, Carsten Ziegeler wrote:

Hi,

can we make the emma stuff optional? Currently the file coverage.em is
created in the root of each module (which is not in svn:ignore atm - no
problem with that we can just add it) and an additional artifact -emma
is created, which we don't want to release/deploy.

So I think this should be turned off by default.

Regards
Carsten







Hudson build is still unstable: sling-trun k-1.6 » Apache Sling Launchpad Testing #618

2010-10-19 Thread Apache Hudson Server
See 
https://hudson.apache.org/hudson/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing/618/




Hudson build is still unstable: sling-trunk-1.6 #618

2010-10-19 Thread Apache Hudson Server
See https://hudson.apache.org/hudson/job/sling-trunk-1.6/changes




Hudson build is back to normal : sling -trunk-1.5 » Apache Sling (Parent) #932

2010-10-19 Thread Apache Hudson Server
See 
https://hudson.apache.org/hudson/job/sling-trunk-1.5/org.apache.sling$sling/932/changes




Hudson build is unstable: sling-trunk-1.5 #932

2010-10-19 Thread Apache Hudson Server
See https://hudson.apache.org/hudson/job/sling-trunk-1.5/932/changes




Build failed in Hudson: sling-trunk-1.5 #933

2010-10-19 Thread Apache Hudson Server
See https://hudson.apache.org/hudson/job/sling-trunk-1.5/933/changes

Changes:

[justin] SLING-1803 - forgot to also move the extra execution of the bundle 
plugin to the emma profile

--
[...truncated 11264 lines...]
[INFO] Copying bundle from 
/home/hudson/.m2/repository/org/apache/sling/org.apache.sling.commons.mime/2.1.4/org.apache.sling.commons.mime-2.1.4.jar
 to 
https://hudson.apache.org/hudson/job/sling-trunk-1.5/ws/trunk/launchpad/builder/target/launchpad-bundles/resources/bundles/0/org.apache.sling.commons.mime-2.1.4.jar
[INFO] Copying bundle from 
/home/hudson/.m2/repository/org/apache/sling/org.apache.sling.commons.classloader/1.2.0/org.apache.sling.commons.classloader-1.2.0.jar
 to 
https://hudson.apache.org/hudson/job/sling-trunk-1.5/ws/trunk/launchpad/builder/target/launchpad-bundles/resources/bundles/0/org.apache.sling.commons.classloader-1.2.0.jar
[INFO] Copying bundle from 
/home/hudson/.m2/repository/org/apache/sling/org.apache.sling.commons.scheduler/2.2.0/org.apache.sling.commons.scheduler-2.2.0.jar
 to 
https://hudson.apache.org/hudson/job/sling-trunk-1.5/ws/trunk/launchpad/builder/target/launchpad-bundles/resources/bundles/0/org.apache.sling.commons.scheduler-2.2.0.jar
[INFO] Copying bundle from 
/home/hudson/.m2/repository/org/apache/sling/org.apache.sling.commons.threads/3.1.0/org.apache.sling.commons.threads-3.1.0.jar
 to 
https://hudson.apache.org/hudson/job/sling-trunk-1.5/ws/trunk/launchpad/builder/target/launchpad-bundles/resources/bundles/0/org.apache.sling.commons.threads-3.1.0.jar
[INFO] Copying bundle from 
/home/hudson/.m2/repository/org/apache/sling/org.apache.sling.api/2.1.1-SNAPSHOT/org.apache.sling.api-2.1.1-SNAPSHOT.jar
 to 
https://hudson.apache.org/hudson/job/sling-trunk-1.5/ws/trunk/launchpad/builder/target/launchpad-bundles/resources/bundles/0/org.apache.sling.api-2.1.1-SNAPSHOT.jar
[INFO] Copying bundle from 
/home/hudson/.m2/repository/org/apache/sling/org.apache.sling.settings/1.0.2/org.apache.sling.settings-1.0.2.jar
 to 
https://hudson.apache.org/hudson/job/sling-trunk-1.5/ws/trunk/launchpad/builder/target/launchpad-bundles/resources/bundles/0/org.apache.sling.settings-1.0.2.jar
[INFO] Copying bundle from 
/home/hudson/.m2/repository/org/apache/sling/org.apache.sling.auth.core/1.0.3-SNAPSHOT/org.apache.sling.auth.core-1.0.3-SNAPSHOT.jar
 to 
https://hudson.apache.org/hudson/job/sling-trunk-1.5/ws/trunk/launchpad/builder/target/launchpad-bundles/resources/bundles/0/org.apache.sling.auth.core-1.0.3-SNAPSHOT.jar
[INFO] Copying bundle from 
/home/hudson/.m2/repository/org/apache/sling/org.apache.sling.engine/2.1.1-SNAPSHOT/org.apache.sling.engine-2.1.1-SNAPSHOT.jar
 to 
https://hudson.apache.org/hudson/job/sling-trunk-1.5/ws/trunk/launchpad/builder/target/launchpad-bundles/resources/bundles/0/org.apache.sling.engine-2.1.1-SNAPSHOT.jar
[INFO] Copying bundle from 
/home/hudson/.m2/repository/org/apache/sling/org.apache.sling.auth.openid/1.0.0/org.apache.sling.auth.openid-1.0.0.jar
 to 
https://hudson.apache.org/hudson/job/sling-trunk-1.5/ws/trunk/launchpad/builder/target/launchpad-bundles/resources/bundles/0/org.apache.sling.auth.openid-1.0.0.jar
[INFO] Copying bundle from 
/home/hudson/.m2/repository/org/apache/sling/org.apache.sling.auth.form/1.0.1-SNAPSHOT/org.apache.sling.auth.form-1.0.1-SNAPSHOT.jar
 to 
https://hudson.apache.org/hudson/job/sling-trunk-1.5/ws/trunk/launchpad/builder/target/launchpad-bundles/resources/bundles/0/org.apache.sling.auth.form-1.0.1-SNAPSHOT.jar
[INFO] Copying bundle from 
/home/hudson/.m2/repository/org/apache/sling/org.apache.sling.auth.selector/1.0.0/org.apache.sling.auth.selector-1.0.0.jar
 to 
https://hudson.apache.org/hudson/job/sling-trunk-1.5/ws/trunk/launchpad/builder/target/launchpad-bundles/resources/bundles/0/org.apache.sling.auth.selector-1.0.0.jar
[INFO] Copying bundle from 
/home/hudson/.m2/repository/org/apache/sling/org.apache.sling.adapter/2.0.7-SNAPSHOT/org.apache.sling.adapter-2.0.7-SNAPSHOT.jar
 to 
https://hudson.apache.org/hudson/job/sling-trunk-1.5/ws/trunk/launchpad/builder/target/launchpad-bundles/resources/bundles/0/org.apache.sling.adapter-2.0.7-SNAPSHOT.jar
[INFO] Copying bundle from 
/home/hudson/.m2/repository/org/apache/sling/org.apache.sling.servlets.resolver/2.1.0/org.apache.sling.servlets.resolver-2.1.0.jar
 to 
https://hudson.apache.org/hudson/job/sling-trunk-1.5/ws/trunk/launchpad/builder/target/launchpad-bundles/resources/bundles/0/org.apache.sling.servlets.resolver-2.1.0.jar
[INFO] Copying bundle from 
/home/hudson/.m2/repository/org/apache/sling/org.apache.sling.servlets.get/2.1.0/org.apache.sling.servlets.get-2.1.0.jar
 to 
https://hudson.apache.org/hudson/job/sling-trunk-1.5/ws/trunk/launchpad/builder/target/launchpad-bundles/resources/bundles/0/org.apache.sling.servlets.get-2.1.0.jar
[INFO] Copying bundle from 
/home/hudson/.m2/repository/org/apache/sling/org.apache.sling.servlets.post/2.1.0/org.apache.sling.servlets.post-2.1.0.jar
 to 

Hudson build is still unstable: sling-trunk-1.6 #619

2010-10-19 Thread Apache Hudson Server
See https://hudson.apache.org/hudson/job/sling-trunk-1.6/changes




Hudson build is still unstable: sling-trun k-1.6 » Apache Sling Launchpad Testing #619

2010-10-19 Thread Apache Hudson Server
See 
https://hudson.apache.org/hudson/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing/619/