Re: Is RefreshOptionalPackagesTask ever used?
It's not used - it's there for an outstanding but questionable issue I guess we can remove it for now - it's in the scm anyway Carsten 2014-08-21 22:39 GMT+02:00 Robert Munteanu romb...@apache.org: Hi, Browsing the list of open Sonar issues I found one [1] which would always cause a NPE in org.apache.sling.installer.core.impl.tasks.RefreshOptionalPackagesTask ( packageAdmin is always null ). I'm not familiar with that area of the code, but by looking at the code it seems that this class is never used. Is that the case? If so, can it be deleted? Thanks, Robert [1]: https://analysis.apache.org/drilldown/issues/35893?rule=findbugs%3ANP_ALWAYS_NULLrule_sev=CRITICALseverity=CRITICAL# -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
Re: [RT] The various roles of (multitenant) content
Hi, On Mon, Aug 18, 2014 at 7:35 PM, Ruben Reusser r...@headwire.com wrote: ...looking at this it seems the same functionality would be handy for feature flags, no?... Not sure what you mean by that, can you explain more? -Bertrand
OSGI EventAdmin event handler blacklist
Hi, In our deployment we have experienced tens of thousands of Sling Job pilling up in queue without having them being processed (for days). Using the regular Sling Jobs UI, we found no reason why this happened (queue was configured properly and active). We also analyzed multiple thread dumps and found no deadlock that could explain this issue. Quoting the doc [0] it may have been that our job topics where simply blacklisted: The OSGi EventAdmin usually comes with a timeout for event handlers. An event handler must consume an OSGi event as fast as possible otherwise the handler might get a timeout and get blacklisted How can we check for blacklisted handlers ? In which bundle is the blacklisting feature implemented ? Regards, Timothee [0] https://sling.apache.org/documentation/bundles/apache-sling-eventing-and-job-handling.html
[jira] [Assigned] (SLING-3841) Update SlingQuery README.md
[ https://issues.apache.org/jira/browse/SLING-3841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-3841: -- Assignee: Robert Munteanu Update SlingQuery README.md --- Key: SLING-3841 URL: https://issues.apache.org/jira/browse/SLING-3841 Project: Sling Issue Type: Task Components: Sling Query Reporter: Tomek Rękawek Assignee: Robert Munteanu Fix For: Sling Query 2.0.0 Attachments: SLING-3841.patch Current version of the README.md file [1] contains outdated Travis CI link and incorrect version. Travis should be removed and the version should be updated. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3841) Update SlingQuery README.md
[ https://issues.apache.org/jira/browse/SLING-3841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-3841: --- Component/s: (was: Extensions) Sling Query Update SlingQuery README.md --- Key: SLING-3841 URL: https://issues.apache.org/jira/browse/SLING-3841 Project: Sling Issue Type: Task Components: Sling Query Reporter: Tomek Rękawek Assignee: Robert Munteanu Fix For: Sling Query 2.0.0 Attachments: SLING-3841.patch Current version of the README.md file [1] contains outdated Travis CI link and incorrect version. Travis should be removed and the version should be updated. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3841) Update SlingQuery README.md
[ https://issues.apache.org/jira/browse/SLING-3841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-3841: --- Fix Version/s: (was: Sling Query 2.0.0) Sling Query 2.0.2 Update SlingQuery README.md --- Key: SLING-3841 URL: https://issues.apache.org/jira/browse/SLING-3841 Project: Sling Issue Type: Task Components: Sling Query Reporter: Tomek Rękawek Assignee: Robert Munteanu Fix For: Sling Query 2.0.2 Attachments: SLING-3841.patch Current version of the README.md file [1] contains outdated Travis CI link and incorrect version. Travis should be removed and the version should be updated. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (SLING-3841) Update SlingQuery README.md
[ https://issues.apache.org/jira/browse/SLING-3841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-3841. Resolution: Fixed Fixed in https://svn.apache.org/r1619704 , thank you for the submission! As for your question, I typically apply the patch files since my local git setup uses git-svn so I can't easily pull from the Github mirror. But feel free to use whatever suits you, I'd rather have more contributions which are a bit harder to apply rather than fewer contributions which are easier to apply :-) Update SlingQuery README.md --- Key: SLING-3841 URL: https://issues.apache.org/jira/browse/SLING-3841 Project: Sling Issue Type: Task Components: Sling Query Reporter: Tomek Rękawek Assignee: Robert Munteanu Fix For: Sling Query 2.0.2 Attachments: SLING-3841.patch Current version of the README.md file [1] contains outdated Travis CI link and incorrect version. Travis should be removed and the version should be updated. -- This message was sent by Atlassian JIRA (v6.2#6252)
Build failed in Jenkins: sling-contrib-1.6 » Apache Sling JCR Resource Security #1208
See https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.jcr.resourcesecurity/1208/ -- [INFO] [INFO] [INFO] Building Apache Sling JCR Resource Security 0.0.1-SNAPSHOT [INFO] Downloading: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.resourceaccesssecurity/0.0.1-SNAPSHOT/maven-metadata.xml Downloading: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.resourceaccesssecurity/0.0.1-SNAPSHOT/org.apache.sling.resourceaccesssecurity-0.0.1-SNAPSHOT.pom [WARNING] The POM for org.apache.sling:org.apache.sling.resourceaccesssecurity:jar:0.0.1-SNAPSHOT is missing, no dependency information available Downloading: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.resourceaccesssecurity/0.0.1-SNAPSHOT/org.apache.sling.resourceaccesssecurity-0.0.1-SNAPSHOT.jar [JENKINS] Archiving disabled
Build failed in Jenkins: sling-contrib-1.6 #1208
See https://builds.apache.org/job/sling-contrib-1.6/1208/changes Changes: [rombert] SLING-3841 - Update SlingQuery README.md Submitted by: Tomek Rękawek -- [...truncated 5706 lines...] [INFO] [INFO] --- maven-install-plugin:2.5.1:install (default-install) @ org.apache.sling.jcr.ocm --- [INFO] Installing https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/jcr/ocm/target/org.apache.sling.jcr.ocm-2.0.5-SNAPSHOT.jar to /home/jenkins/jenkins-slave/maven-repositories/3/org/apache/sling/org.apache.sling.jcr.ocm/2.0.5-SNAPSHOT/org.apache.sling.jcr.ocm-2.0.5-SNAPSHOT.jar [INFO] Installing https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/jcr/ocm/pom.xml to /home/jenkins/jenkins-slave/maven-repositories/3/org/apache/sling/org.apache.sling.jcr.ocm/2.0.5-SNAPSHOT/org.apache.sling.jcr.ocm-2.0.5-SNAPSHOT.pom [INFO] Installing https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/jcr/ocm/target/org.apache.sling.jcr.ocm-2.0.5-SNAPSHOT-sources.jar to /home/jenkins/jenkins-slave/maven-repositories/3/org/apache/sling/org.apache.sling.jcr.ocm/2.0.5-SNAPSHOT/org.apache.sling.jcr.ocm-2.0.5-SNAPSHOT-sources.jar [INFO] [INFO] --- maven-bundle-plugin:2.4.0:install (default-install) @ org.apache.sling.jcr.ocm --- [INFO] Local OBR update disabled (enable with -DobrRepository) [JENKINS] Archiving disabled [INFO] [INFO] [INFO] Building Apache Sling JCR Prefs 1.0.1-SNAPSHOT [INFO] Downloading: http://repo.maven.apache.org/maven2/org/apache/felix/org.apache.felix.prefs/1.0.2/org.apache.felix.prefs-1.0.2.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/felix/org.apache.felix.prefs/1.0.2/org.apache.felix.prefs-1.0.2.pom (4 KB at 47.3 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/felix/org.osgi.compendium/1.0.0/org.osgi.compendium-1.0.0.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/felix/org.osgi.compendium/1.0.0/org.osgi.compendium-1.0.0.pom (4 KB at 47.1 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/felix/javax.servlet/1.0.0/javax.servlet-1.0.0.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/felix/javax.servlet/1.0.0/javax.servlet-1.0.0.pom (5 KB at 59.3 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/felix/org.osgi.foundation/1.0.0/org.osgi.foundation-1.0.0.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/felix/org.osgi.foundation/1.0.0/org.osgi.foundation-1.0.0.pom (2 KB at 22.8 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/felix/felix/1.0.1/felix-1.0.1.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/felix/felix/1.0.1/felix-1.0.1.pom (14 KB at 161.1 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/felix/org.apache.felix.prefs/1.0.2/org.apache.felix.prefs-1.0.2.jar Downloading: http://repo.maven.apache.org/maven2/org/apache/felix/org.osgi.compendium/1.0.0/org.osgi.compendium-1.0.0.jar Downloading: http://repo.maven.apache.org/maven2/org/apache/felix/javax.servlet/1.0.0/javax.servlet-1.0.0.jar Downloading: http://repo.maven.apache.org/maven2/org/apache/felix/org.osgi.foundation/1.0.0/org.osgi.foundation-1.0.0.jar Downloaded: http://repo.maven.apache.org/maven2/org/apache/felix/javax.servlet/1.0.0/javax.servlet-1.0.0.jar (30 KB at 521.7 KB/sec) Downloaded: http://repo.maven.apache.org/maven2/org/apache/felix/org.apache.felix.prefs/1.0.2/org.apache.felix.prefs-1.0.2.jar (42 KB at 537.8 KB/sec) Downloaded: http://repo.maven.apache.org/maven2/org/apache/felix/org.osgi.compendium/1.0.0/org.osgi.compendium-1.0.0.jar (88 KB at 1067.8 KB/sec) Downloaded: http://repo.maven.apache.org/maven2/org/apache/felix/org.osgi.foundation/1.0.0/org.osgi.foundation-1.0.0.jar (254 KB at 2283.1 KB/sec) [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ org.apache.sling.jcr.prefs --- [INFO] Deleting https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/jcr/prefs/target [INFO] [INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce-java) @ org.apache.sling.jcr.prefs --- [INFO] [INFO] --- maven-antrun-plugin:1.7:run (set-bundle-required-execution-environment) @ org.apache.sling.jcr.prefs --- [INFO] Executing tasks main: [INFO] Executed tasks [INFO] [INFO] --- maven-remote-resources-plugin:1.5:process (default) @ org.apache.sling.jcr.prefs --- [INFO] [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ org.apache.sling.jcr.prefs --- [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 0 resource [INFO] Copying 3 resources [INFO] [INFO] --- maven-antrun-plugin:1.7:run (check-memory-task) @ org.apache.sling.jcr.prefs --- [INFO] Executing tasks main: [echo] WARNING
Build failed in Jenkins: sling-trunk-1.6 » Apache Sling JSP Tag Library #2386
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.scripting.jsp.taglib/2386/ -- [INFO] [INFO] [INFO] Building Apache Sling JSP Tag Library 2.2.1-SNAPSHOT [INFO] Downloading: http://repo.maven.apache.org/maven2/javax/servlet/jsp-api/2.0/jsp-api-2.0.pom Downloaded: http://repo.maven.apache.org/maven2/javax/servlet/jsp-api/2.0/jsp-api-2.0.pom (362 B at 6.7 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.scripting.jsp/2.0.8/org.apache.sling.scripting.jsp-2.0.8.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.scripting.jsp/2.0.8/org.apache.sling.scripting.jsp-2.0.8.pom (7 KB at 120.8 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/owasp/esapi/esapi/2.1.0/esapi-2.1.0.pom Downloaded: http://repo.maven.apache.org/maven2/org/owasp/esapi/esapi/2.1.0/esapi-2.1.0.pom (21 KB at 381.5 KB/sec) Downloading: http://repo.maven.apache.org/maven2/commons-configuration/commons-configuration/1.5/commons-configuration-1.5.pom Downloaded: http://repo.maven.apache.org/maven2/commons-configuration/commons-configuration/1.5/commons-configuration-1.5.pom (13 KB at 244.4 KB/sec) Downloading: http://repo.maven.apache.org/maven2/commons-beanutils/commons-beanutils-core/1.7.0/commons-beanutils-core-1.7.0.pom Downloaded: http://repo.maven.apache.org/maven2/commons-beanutils/commons-beanutils-core/1.7.0/commons-beanutils-core-1.7.0.pom (719 B at 13.5 KB/sec) Downloading: http://repo.maven.apache.org/maven2/commons-fileupload/commons-fileupload/1.2/commons-fileupload-1.2.pom Downloaded: http://repo.maven.apache.org/maven2/commons-fileupload/commons-fileupload/1.2/commons-fileupload-1.2.pom (11 KB at 194.4 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/commons/commons-parent/1/commons-parent-1.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/commons/commons-parent/1/commons-parent-1.pom (8 KB at 140.3 KB/sec) Downloading: http://repo.maven.apache.org/maven2/xom/xom/1.2.5/xom-1.2.5.pom Downloaded: http://repo.maven.apache.org/maven2/xom/xom/1.2.5/xom-1.2.5.pom (2 KB at 36.6 KB/sec) Downloading: http://repo.maven.apache.org/maven2/xerces/xercesImpl/2.8.0/xercesImpl-2.8.0.pom Downloaded: http://repo.maven.apache.org/maven2/xerces/xercesImpl/2.8.0/xercesImpl-2.8.0.pom (2 KB at 26.4 KB/sec) Downloading: http://repo.maven.apache.org/maven2/xalan/xalan/2.7.0/xalan-2.7.0.pom Downloaded: http://repo.maven.apache.org/maven2/xalan/xalan/2.7.0/xalan-2.7.0.pom (491 B at 9.2 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/beanshell/bsh-core/2.0b4/bsh-core-2.0b4.pom Downloaded: http://repo.maven.apache.org/maven2/org/beanshell/bsh-core/2.0b4/bsh-core-2.0b4.pom (499 B at 9.2 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/owasp/antisamy/antisamy/1.4.3/antisamy-1.4.3.pom Downloaded: http://repo.maven.apache.org/maven2/org/owasp/antisamy/antisamy/1.4.3/antisamy-1.4.3.pom (3 KB at 51.1 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/owasp/antisamy/antisamy-project/1.4.3/antisamy-project-1.4.3.pom Downloaded: http://repo.maven.apache.org/maven2/org/owasp/antisamy/antisamy-project/1.4.3/antisamy-project-1.4.3.pom (8 KB at 136.6 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/xmlgraphics/batik-css/1.7/batik-css-1.7.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/xmlgraphics/batik-css/1.7/batik-css-1.7.pom (4 KB at 66.7 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/xmlgraphics/batik-ext/1.7/batik-ext-1.7.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/xmlgraphics/batik-ext/1.7/batik-ext-1.7.pom (4 KB at 58.4 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/xmlgraphics/batik-util/1.7/batik-util-1.7.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/xmlgraphics/batik-util/1.7/batik-util-1.7.pom (3 KB at 55.9 KB/sec) Downloading: http://repo.maven.apache.org/maven2/xml-apis/xml-apis-ext/1.3.04/xml-apis-ext-1.3.04.pom Downloaded: http://repo.maven.apache.org/maven2/xml-apis/xml-apis-ext/1.3.04/xml-apis-ext-1.3.04.pom (2 KB at 33.2 KB/sec) Downloading: http://repo.maven.apache.org/maven2/net/sourceforge/nekohtml/nekohtml/1.9.12/nekohtml-1.9.12.pom Downloaded: http://repo.maven.apache.org/maven2/net/sourceforge/nekohtml/nekohtml/1.9.12/nekohtml-1.9.12.pom (2 KB at 24.6 KB/sec) Downloading: http://repo.maven.apache.org/maven2/javax/servlet/jsp-api/2.0/jsp-api-2.0.jar Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.scripting.jsp/2.0.8/org.apache.sling.scripting.jsp-2.0.8.jar Downloading:
Build failed in Jenkins: sling-trunk-1.6 #2386
See https://builds.apache.org/job/sling-trunk-1.6/2386/changes Changes: [rombert] SLING-3841 - Update SlingQuery README.md Submitted by: Tomek Rękawek -- [...truncated 24620 lines...] [INFO] Sling Taglib Archetype SUCCESS [3.214s] [INFO] Apache Sling API .. SUCCESS [15.362s] [INFO] Apache Sling Resource Resolver SUCCESS [11.486s] [INFO] Apache Sling System Bundle Extension: Java Transaction API SUCCESS [4.990s] [INFO] Apache Sling System Bundle Extension: XML APIs SUCCESS [3.439s] [INFO] Apache Sling System Bundle Extension: Activation API SUCCESS [3.493s] [INFO] Apache Sling System Bundle Extension: WS APIs . SUCCESS [3.162s] [INFO] Apache Sling Dynamic Class Loader Support . SUCCESS [15.452s] [INFO] Apache Sling Commons Java Compiler SUCCESS [6.121s] [INFO] Apache Sling JSON Library . SUCCESS [5.925s] [INFO] Apache Sling SLF4J Implementation (Logback) ... SUCCESS [35.997s] [INFO] Apache Sling OSGi LogService Implementation ... SUCCESS [5.354s] [INFO] Apache Sling MIME type mapping support SUCCESS [7.966s] [INFO] Apache Sling Commons OSGi support . SUCCESS [6.483s] [INFO] Apache Sling Scheduler Support SUCCESS [5.921s] [INFO] Apache Sling Testing Utilities SUCCESS [18.652s] [INFO] Apache Sling Thread Dumper SUCCESS [4.880s] [INFO] Apache Sling Thread Support ... SUCCESS [3.485s] [INFO] Apache Sling Authentication Service ... SUCCESS [5.988s] [INFO] Apache Sling OpenID Authentication SUCCESS [9.630s] [INFO] Apache Sling Form Based Authentication Handler SUCCESS [15.294s] [INFO] Apache Sling Authentication Selector .. SUCCESS [5.958s] [INFO] Apache Sling Engine Implementation SUCCESS [18.689s] [INFO] Apache Sling Repository API Bundle SUCCESS [3.046s] [INFO] Apache Sling JCR Base Bundle .. SUCCESS [4.686s] [INFO] Apache Sling JCR ClassLoader .. SUCCESS [3.720s] [INFO] Apache Sling Initial Content Loader ... SUCCESS [7.210s] [INFO] Apache Sling Jackrabbit Embedded Repository ... SUCCESS [11.196s] [INFO] Apache Sling Jackrabbit UserManager Support ... SUCCESS [5.538s] [INFO] Apache Sling Jackrabbit JSR-283 Access Control Manager Support SUCCESS [4.664s] [INFO] Apache Sling Wrapper Bundle for the JCR API ... SUCCESS [3.031s] [INFO] Apache Sling JCR Resource Resolver SUCCESS [37.951s] [INFO] Apache Sling JCR Repository Registration .. SUCCESS [6.055s] [INFO] Apache Sling Simple WebDAV Access to repositories . SUCCESS [5.632s] [INFO] Apache Sling DavEx Access to repositories . SUCCESS [5.964s] [INFO] Apache Sling JCR WebConsole Bundle SUCCESS [3.907s] [INFO] Apache Sling Oak Repository Server SUCCESS [5.726s] [INFO] Apache Sling SlingRepository Integration Tests SUCCESS [52.034s] [INFO] Apache Sling Servlet Resolver . SUCCESS [7.760s] [INFO] Apache Sling Default GET Servlets . SUCCESS [6.259s] [INFO] Apache Sling Default POST Servlets SUCCESS [7.688s] [INFO] Apache Sling Compat Servlets .. SUCCESS [3.342s] [INFO] Apache Sling Scripting Implementation API . SUCCESS [4.737s] [INFO] Apache Sling Scripting Core implementation SUCCESS [15.086s] [INFO] Apache Sling Scripting JavaScript Support . SUCCESS [11.572s] [INFO] Apache Sling Scripting JSP Support SUCCESS [20.023s] [INFO] Apache Sling JSP Tag Library .. FAILURE [29.577s] [INFO] Apache Sling JSP Standard Tag Library . SKIPPED [INFO] Apache Sling Adapter Manager Implementation ... SKIPPED [INFO] Apache Sling Bundle Resource Provider . SKIPPED [INFO] Apache Sling Discovery API SKIPPED [INFO] Apache Sling Resource-Based Discovery Service . SKIPPED [INFO] Apache Sling Discovery Support Bundle . SKIPPED [INFO] Apache Sling Discovery Standalone Implementation .. SKIPPED [INFO] Apache Sling Event Support SKIPPED [INFO] Apache Sling Feature Flags SKIPPED [INFO] Apache Sling Filesystem Resource Provider . SKIPPED [INFO] Apache Sling javax.activation bundle .. SKIPPED [INFO] Apache Sling Service User Mapper .. SKIPPED [INFO] Apache Sling Settings . SKIPPED [INFO] Apache Sling Web Console Branding . SKIPPED [INFO] Apache Sling Web Console Security Provider SKIPPED [INFO] Apache Sling Groovy Extensions SKIPPED [INFO] Apache Sling Explorer . SKIPPED [INFO] Apache Sling
Jenkins build is still unstable: sling-trunk-1.8 #49
See https://builds.apache.org/job/sling-trunk-1.8/changes
Jenkins build is still unstable: sling-trunk-1.8 » Apache Sling Event Support #49
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.event/49/
Jenkins build became unstable: sling-trunk-1.8 » Apache Sling Installer Integration Tests #49
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.installer.it/49/
Jenkins build is still unstable: sling-trunk-1.8 » Apache Sling Launchpad Testing #49
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.launchpad.testing/49/
Jenkins build became unstable: sling-trunk-1.7 #760
See https://builds.apache.org/job/sling-trunk-1.7/760/changes
Jenkins build became unstable: sling-trunk-1.7 » Apache Sling Installer Integration Tests #760
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.installer.it/760/
[jira] [Created] (SLING-3874) JSP Tag for partials
Julian Sedding created SLING-3874: - Summary: JSP Tag for partials Key: SLING-3874 URL: https://issues.apache.org/jira/browse/SLING-3874 Project: Sling Issue Type: New Feature Components: Scripting Affects Versions: Scripting JSP-Taglib 2.2.0 Reporter: Julian Sedding Priority: Minor As brought up in a discussion by [~gwalt], it is currently not possible to overlay JSP scripts that are included with the sling:call/ tag using other scripting languages. In order to remedy this situation, I propose a sling:partial/ tag. This allows including partial rendering scripts via selector(s). However, in contrast to sling:include replaceSelectors=.../, the selectors in the request are not modified, i.e. the original selectorString is preserved. The tag can be used as follows: sling:partial selectors=header/ This is roughly equivalent to: sling:call script=header.jsp/ If desired, the tag can easily be extended to allow modifying the extension as well. This might be useful e.g. if a snippet of JSON data should be inlined in an HTML document. Please discuss the value of such an addition on http://markmail.org/thread/6qpmh6txvsx766sm -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3874) JSP Tag for partials
[ https://issues.apache.org/jira/browse/SLING-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding updated SLING-3874: -- Attachment: SLING-3874-jsedding.patch Patch for discussion. JSP Tag for partials -- Key: SLING-3874 URL: https://issues.apache.org/jira/browse/SLING-3874 Project: Sling Issue Type: New Feature Components: Scripting Affects Versions: Scripting JSP-Taglib 2.2.0 Reporter: Julian Sedding Priority: Minor Attachments: SLING-3874-jsedding.patch As brought up in a discussion by [~gwalt], it is currently not possible to overlay JSP scripts that are included with the sling:call/ tag using other scripting languages. In order to remedy this situation, I propose a sling:partial/ tag. This allows including partial rendering scripts via selector(s). However, in contrast to sling:include replaceSelectors=.../, the selectors in the request are not modified, i.e. the original selectorString is preserved. The tag can be used as follows: sling:partial selectors=header/ This is roughly equivalent to: sling:call script=header.jsp/ If desired, the tag can easily be extended to allow modifying the extension as well. This might be useful e.g. if a snippet of JSON data should be inlined in an HTML document. Please discuss the value of such an addition on http://markmail.org/thread/6qpmh6txvsx766sm -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-2752) Revisit re-saving of config settings in light of support for wider range of types.
[ https://issues.apache.org/jira/browse/SLING-2752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-2752: Fix Version/s: (was: JCR Installer 3.1.8) Revisit re-saving of config settings in light of support for wider range of types. -- Key: SLING-2752 URL: https://issues.apache.org/jira/browse/SLING-2752 Project: Sling Issue Type: Bug Components: Installer Affects Versions: JCR Installer 3.1.6 Reporter: Ian Boston Post SLING-2477 we need to revisit SLING-1971 to ensure that anything done there to enable write back of configuration settings still works. Exactly what needs to be worked out. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-2756) Document sling:OsgiConfig format and properties format
[
https://issues.apache.org/jira/browse/SLING-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler updated SLING-2756:
Fix Version/s: (was: JCR Installer 3.1.8)
Document sling:OsgiConfig format and properties format
---
Key: SLING-2756
URL: https://issues.apache.org/jira/browse/SLING-2756
Project: Sling
Issue Type: Bug
Components: Installer
Affects Versions: JCR Installer 3.1.6
Reporter: Ian Boston
Depending on the implementation approach chosen for SLING-2477:
If the name{type} configuration format is chosen for the properties of an
sling:OsgiConfig node, then document both the name{type} format and the
I1000 format.
If the I1000 format is chosen document it including details of JCR mappings.
(The reason we need to document both for name{type} is that there are
downstream properties files in the I1000 format already which we need to
support. Requiring migration of those properties and unifying on the
name{type} format for both file and sling:OsgiConfig would be a major effort,
and probably not worth it.)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
RE: [RT] The various roles of (multitenant) content
hello betrand. i try to find the bridge to the multitenancy scenarios i've described in [1]: Deliverable content: Displayed on a website or mobile app for example. Can be global, shared between a group of tenants or tenant-specific. this is what i've called content in the wiki page. may be page content, media assets etc., everything the editors enter into the system. i18n translations may fall into this role as well. System content: Defines how a specific version of the system behaves. Multiple system versions can coexist in a shared content repository (as we demonstrated in [1], in a limited way) this is for example configuration - but as you describe it mainly system-level configuration (e.g. OSGI configuration). what is with the other types of configuration on the different levels (regions, tenants, sites). they do not belong into the role system content, but they do not fit in the other roles as well. Application content: Extensions or overrides of system content, that modify how the system behaves. Usually tenant-specific, or maybe shared between a group of tenants if an application is installed to be used by all tenants (e.g. massive multi site scenario), it may be global application-level overrides as well. but this fits in your group of tenants picture, where the group is all tenants. i assume the whole application bundle falls into this category? but an application bundle usually consist of both OSGi bundles (system role) and scripts (application context role). Module state content: The typical example is workflow models and state, which is not deliverable but persistent and might be partially shared. other examples are background jobs using sling event/job infrastructure. this is not module-related, or i do not understand clearly what you mean with model in this context. Instance-specific transient content: Transient content that's relevant to a single Sling instance. Compiled scripts, for example. Not needed when the Sling instance starts. ok stefan [1] https://cwiki.apache.org/confluence/x/So2uAg
[jira] [Updated] (SLING-2816) ConfigPrioritiesTest does not behave as expected
[ https://issues.apache.org/jira/browse/SLING-2816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-2816: Fix Version/s: Installer Core 3.5.4 ConfigPrioritiesTest does not behave as expected Key: SLING-2816 URL: https://issues.apache.org/jira/browse/SLING-2816 Project: Sling Issue Type: Bug Components: Installer Reporter: Bertrand Delacretaz Assignee: Carsten Ziegeler Priority: Minor Fix For: Installer Core 3.5.4 The ConfigPrioritiesTest in installer/it does not behave as I'd expect it, I'll add TODOs to explain the details. It probably hasn't been run in a long time, as before my SLING-2815 changes the @Test annotation was missing, and the version of JUnit used then didn't complain. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (SLING-2816) ConfigPrioritiesTest does not behave as expected
[ https://issues.apache.org/jira/browse/SLING-2816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler reassigned SLING-2816: --- Assignee: Carsten Ziegeler ConfigPrioritiesTest does not behave as expected Key: SLING-2816 URL: https://issues.apache.org/jira/browse/SLING-2816 Project: Sling Issue Type: Bug Components: Installer Reporter: Bertrand Delacretaz Assignee: Carsten Ziegeler Priority: Minor Fix For: Installer Core 3.5.4 The ConfigPrioritiesTest in installer/it does not behave as I'd expect it, I'll add TODOs to explain the details. It probably hasn't been run in a long time, as before my SLING-2815 changes the @Test annotation was missing, and the version of JUnit used then didn't complain. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (SLING-2816) ConfigPrioritiesTest does not behave as expected
[ https://issues.apache.org/jira/browse/SLING-2816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-2816. - Resolution: Fixed Corrected the test in rev 1619772 ConfigPrioritiesTest does not behave as expected Key: SLING-2816 URL: https://issues.apache.org/jira/browse/SLING-2816 Project: Sling Issue Type: Bug Components: Installer Reporter: Bertrand Delacretaz Assignee: Carsten Ziegeler Priority: Minor Fix For: Installer Core 3.5.4 The ConfigPrioritiesTest in installer/it does not behave as I'd expect it, I'll add TODOs to explain the details. It probably hasn't been run in a long time, as before my SLING-2815 changes the @Test annotation was missing, and the version of JUnit used then didn't complain. -- This message was sent by Atlassian JIRA (v6.2#6252)
Jenkins build is back to normal : sling-trunk-1.6 » Apache Sling JSP Tag Library #2387
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.scripting.jsp.taglib/2387/
Build failed in Jenkins: sling-oak-it-1.6 » Apache Sling Launchpad Testing #70
See https://builds.apache.org/job/sling-oak-it-1.6/org.apache.sling$org.apache.sling.launchpad.testing/70/ -- [...truncated 495 lines...] Downloaded: http://repo.maven.apache.org/maven2/org/eclipse/jetty/jetty-io/7.6.13.v20130916/jetty-io-7.6.13.v20130916.jar (97 KB at 555.9 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/eclipse/jetty/jetty-xml/7.6.13.v20130916/jetty-xml-7.6.13.v20130916.jar Downloaded: http://repo.maven.apache.org/maven2/org/apache/felix/org.apache.felix.http.jetty/2.2.2/org.apache.felix.http.jetty-2.2.2.jar (1304 KB at 3276.0 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/felix/org.apache.felix.http.api/2.2.2/org.apache.felix.http.api-2.2.2.jar Downloaded: http://repo.maven.apache.org/maven2/org/eclipse/jetty/jetty-security/7.6.13.v20130916/jetty-security-7.6.13.v20130916.jar (83 KB at 1085.2 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/felix/org.apache.felix.http.base/2.2.2/org.apache.felix.http.base-2.2.2.jar Downloaded: http://repo.maven.apache.org/maven2/org/eclipse/jetty/jetty-webapp/7.6.13.v20130916/jetty-webapp-7.6.13.v20130916.jar (97 KB at 894.9 KB/sec) Downloaded: http://repo.maven.apache.org/maven2/org/eclipse/jetty/jetty-xml/7.6.13.v20130916/jetty-xml-7.6.13.v20130916.jar (37 KB at 345.8 KB/sec) Downloaded: http://repo.maven.apache.org/maven2/org/apache/felix/org.apache.felix.http.api/2.2.2/org.apache.felix.http.api-2.2.2.jar (9 KB at 108.0 KB/sec) Downloaded: http://repo.maven.apache.org/maven2/org/apache/felix/org.apache.felix.http.base/2.2.2/org.apache.felix.http.base-2.2.2.jar (62 KB at 823.5 KB/sec) Downloaded: http://repo.maven.apache.org/maven2/org/eclipse/jetty/jetty-server/7.6.13.v20130916/jetty-server-7.6.13.v20130916.jar (324 KB at 702.5 KB/sec) [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ org.apache.sling.launchpad.testing --- [INFO] Deleting https://builds.apache.org/job/sling-oak-it-1.6/org.apache.sling$org.apache.sling.launchpad.testing/ws/ (includes = [derby.log, cachedir, sling/**, jackrabbit, coverage.ec], excludes = []) [INFO] [INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce-java) @ org.apache.sling.launchpad.testing --- [INFO] [INFO] --- maven-antrun-plugin:1.7:run (set-bundle-required-execution-environment) @ org.apache.sling.launchpad.testing --- Downloading: http://repo.maven.apache.org/maven2/org/apache/ant/ant-apache-regexp/1.7.1/ant-apache-regexp-1.7.1.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/ant/ant-apache-regexp/1.7.1/ant-apache-regexp-1.7.1.pom (3 KB at 24.9 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/ant/ant-parent/1.7.1/ant-parent-1.7.1.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/ant/ant-parent/1.7.1/ant-parent-1.7.1.pom (5 KB at 56.3 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/ant/ant/1.7.1/ant-1.7.1.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/ant/ant/1.7.1/ant-1.7.1.pom (10 KB at 127.1 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/ant/ant-launcher/1.7.1/ant-launcher-1.7.1.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/ant/ant-launcher/1.7.1/ant-launcher-1.7.1.pom (3 KB at 31.0 KB/sec) Downloading: http://repo.maven.apache.org/maven2/jakarta-regexp/jakarta-regexp/1.4/jakarta-regexp-1.4.pom Downloaded: http://repo.maven.apache.org/maven2/jakarta-regexp/jakarta-regexp/1.4/jakarta-regexp-1.4.pom (160 B at 2.1 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/ant/ant-apache-regexp/1.7.1/ant-apache-regexp-1.7.1.jar Downloading: http://repo.maven.apache.org/maven2/jakarta-regexp/jakarta-regexp/1.4/jakarta-regexp-1.4.jar Downloaded: http://repo.maven.apache.org/maven2/org/apache/ant/ant-apache-regexp/1.7.1/ant-apache-regexp-1.7.1.jar (4 KB at 47.7 KB/sec) Downloaded: http://repo.maven.apache.org/maven2/jakarta-regexp/jakarta-regexp/1.4/jakarta-regexp-1.4.jar (28 KB at 193.8 KB/sec) [INFO] Executing tasks main: [INFO] Executed tasks [INFO] [INFO] --- maven-remote-resources-plugin:1.5:process (default) @ org.apache.sling.launchpad.testing --- Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/apache-sling-jar-resource-bundle/1.0.0/apache-sling-jar-resource-bundle-1.0.0.jar Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/apache-sling-jar-resource-bundle/1.0.0/apache-sling-jar-resource-bundle-1.0.0.jar (8 KB at 96.8 KB/sec) [INFO] [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ org.apache.sling.launchpad.testing --- [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 1 resource [INFO] Copying 3 resources [INFO] [INFO] --- maven-antrun-plugin:1.7:run (check-memory-task) @ org.apache.sling.launchpad.testing --- [INFO] Executing tasks main: [echo] WARNING (SLING-443/SLING-1782) **
[jira] [Commented] (SLING-3657) Create a ResourceMerger-style ResourceProvider which merges based on resource super types
[ https://issues.apache.org/jira/browse/SLING-3657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14106797#comment-14106797 ] Carsten Ziegeler commented on SLING-3657: - I'm still against the ResourceMergerService - everything should be available through the resource tree and not via another way. Create a ResourceMerger-style ResourceProvider which merges based on resource super types - Key: SLING-3657 URL: https://issues.apache.org/jira/browse/SLING-3657 Project: Sling Issue Type: New Feature Components: Extensions Reporter: Justin Edelson Attachments: SLING-3657.patch The current MergingResourceProvider does a good job of a single use case - merging resources relative to the search paths. A second use case for merging is to merge resources based on their sling:resourceSuperType inheritance, i.e. /content/siteA@sling:resourceSuperType=/content/siteB /content/siteB@sling:resourceSuperType=/content/siteC It should be possible to generate a merged resource which combines /content/siteA, /content/siteB, and /content/siteC (in reverse order so that siteA overrides siteB, etc.). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (SLING-3875) Remove unused and broken RefreshOptionalPackagesTask
Robert Munteanu created SLING-3875: -- Summary: Remove unused and broken RefreshOptionalPackagesTask Key: SLING-3875 URL: https://issues.apache.org/jira/browse/SLING-3875 Project: Sling Issue Type: Bug Components: Installer Affects Versions: Installer Core 3.5.2 Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Installer Core 3.5.4 As discussed at http://sling-dev.markmail.org/thread/wbqhbuunn7myahw6 , this class is unused and visibly broken . -- This message was sent by Atlassian JIRA (v6.2#6252)
Re: Is RefreshOptionalPackagesTask ever used?
OK, removed it in https://svn.apache.org/r1619785 Robert On Fri, Aug 22, 2014 at 9:52 AM, Carsten Ziegeler cziege...@apache.org wrote: It's not used - it's there for an outstanding but questionable issue I guess we can remove it for now - it's in the scm anyway Carsten 2014-08-21 22:39 GMT+02:00 Robert Munteanu romb...@apache.org: Hi, Browsing the list of open Sonar issues I found one [1] which would always cause a NPE in org.apache.sling.installer.core.impl.tasks.RefreshOptionalPackagesTask ( packageAdmin is always null ). I'm not familiar with that area of the code, but by looking at the code it seems that this class is never used. Is that the case? If so, can it be deleted? Thanks, Robert [1]: https://analysis.apache.org/drilldown/issues/35893?rule=findbugs%3ANP_ALWAYS_NULLrule_sev=CRITICALseverity=CRITICAL# -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org -- Sent from my (old) computer
[jira] [Resolved] (SLING-3875) Remove unused and broken RefreshOptionalPackagesTask
[ https://issues.apache.org/jira/browse/SLING-3875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-3875. Resolution: Fixed Remove unused and broken RefreshOptionalPackagesTask Key: SLING-3875 URL: https://issues.apache.org/jira/browse/SLING-3875 Project: Sling Issue Type: Bug Components: Installer Affects Versions: Installer Core 3.5.2 Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Installer Core 3.5.4 As discussed at http://sling-dev.markmail.org/thread/wbqhbuunn7myahw6 , this class is unused and visibly broken . -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3875) Remove unused and broken RefreshOptionalPackagesTask
[ https://issues.apache.org/jira/browse/SLING-3875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14106801#comment-14106801 ] Robert Munteanu commented on SLING-3875: Removed in https://svn.apache.org/r1619785 Remove unused and broken RefreshOptionalPackagesTask Key: SLING-3875 URL: https://issues.apache.org/jira/browse/SLING-3875 Project: Sling Issue Type: Bug Components: Installer Affects Versions: Installer Core 3.5.2 Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Installer Core 3.5.4 As discussed at http://sling-dev.markmail.org/thread/wbqhbuunn7myahw6 , this class is unused and visibly broken . -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Issue Comment Deleted] (SLING-3657) Create a ResourceMerger-style ResourceProvider which merges based on resource super types
[ https://issues.apache.org/jira/browse/SLING-3657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-3657: -- Comment: was deleted (was: I am out of office, back on June 22. regards antonio ) Create a ResourceMerger-style ResourceProvider which merges based on resource super types - Key: SLING-3657 URL: https://issues.apache.org/jira/browse/SLING-3657 Project: Sling Issue Type: New Feature Components: Extensions Reporter: Justin Edelson Attachments: SLING-3657.patch The current MergingResourceProvider does a good job of a single use case - merging resources relative to the search paths. A second use case for merging is to merge resources based on their sling:resourceSuperType inheritance, i.e. /content/siteA@sling:resourceSuperType=/content/siteB /content/siteB@sling:resourceSuperType=/content/siteC It should be possible to generate a merged resource which combines /content/siteA, /content/siteB, and /content/siteC (in reverse order so that siteA overrides siteB, etc.). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Issue Comment Deleted] (SLING-3657) Create a ResourceMerger-style ResourceProvider which merges based on resource super types
[ https://issues.apache.org/jira/browse/SLING-3657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-3657: -- Comment: was deleted (was: I am out of office, back on June 22. regards antonio ) Create a ResourceMerger-style ResourceProvider which merges based on resource super types - Key: SLING-3657 URL: https://issues.apache.org/jira/browse/SLING-3657 Project: Sling Issue Type: New Feature Components: Extensions Reporter: Justin Edelson Attachments: SLING-3657.patch The current MergingResourceProvider does a good job of a single use case - merging resources relative to the search paths. A second use case for merging is to merge resources based on their sling:resourceSuperType inheritance, i.e. /content/siteA@sling:resourceSuperType=/content/siteB /content/siteB@sling:resourceSuperType=/content/siteC It should be possible to generate a merged resource which combines /content/siteA, /content/siteB, and /content/siteC (in reverse order so that siteA overrides siteB, etc.). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Issue Comment Deleted] (SLING-3657) Create a ResourceMerger-style ResourceProvider which merges based on resource super types
[ https://issues.apache.org/jira/browse/SLING-3657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-3657: -- Comment: was deleted (was: I am out of office, back on June 22. regards antonio ) Create a ResourceMerger-style ResourceProvider which merges based on resource super types - Key: SLING-3657 URL: https://issues.apache.org/jira/browse/SLING-3657 Project: Sling Issue Type: New Feature Components: Extensions Reporter: Justin Edelson Attachments: SLING-3657.patch The current MergingResourceProvider does a good job of a single use case - merging resources relative to the search paths. A second use case for merging is to merge resources based on their sling:resourceSuperType inheritance, i.e. /content/siteA@sling:resourceSuperType=/content/siteB /content/siteB@sling:resourceSuperType=/content/siteC It should be possible to generate a merged resource which combines /content/siteA, /content/siteB, and /content/siteC (in reverse order so that siteA overrides siteB, etc.). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3657) Create a ResourceMerger-style ResourceProvider which merges based on resource super types
[ https://issues.apache.org/jira/browse/SLING-3657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14106812#comment-14106812 ] Justin Edelson commented on SLING-3657: --- [~cziegeler] But are you against having multiple merging resource provider? See the three use cases I identified above (which are probably not exhaustive) Create a ResourceMerger-style ResourceProvider which merges based on resource super types - Key: SLING-3657 URL: https://issues.apache.org/jira/browse/SLING-3657 Project: Sling Issue Type: New Feature Components: Extensions Reporter: Justin Edelson Attachments: SLING-3657.patch The current MergingResourceProvider does a good job of a single use case - merging resources relative to the search paths. A second use case for merging is to merge resources based on their sling:resourceSuperType inheritance, i.e. /content/siteA@sling:resourceSuperType=/content/siteB /content/siteB@sling:resourceSuperType=/content/siteC It should be possible to generate a merged resource which combines /content/siteA, /content/siteB, and /content/siteC (in reverse order so that siteA overrides siteB, etc.). -- This message was sent by Atlassian JIRA (v6.2#6252)
Re: OSGI EventAdmin event handler blacklist
Hi Tim Blacklisting is a feature of the Apache Felix Event Admin bundle and IIRC at least the timeout for blacklisting is configurable. You might want to check your application, whether blacklisting timeout has been reconfigured or not. I am not really aware, whether it can be analyzed whether handlers have been blacklisted or not. Other than inspecting the log file for respective entries. Regards Felix Am 22.08.2014 um 10:28 schrieb Timothée Maret timothee.ma...@gmail.com: Hi, In our deployment we have experienced tens of thousands of Sling Job pilling up in queue without having them being processed (for days). Using the regular Sling Jobs UI, we found no reason why this happened (queue was configured properly and active). We also analyzed multiple thread dumps and found no deadlock that could explain this issue. Quoting the doc [0] it may have been that our job topics where simply blacklisted: The OSGi EventAdmin usually comes with a timeout for event handlers. An event handler must consume an OSGi event as fast as possible otherwise the handler might get a timeout and get blacklisted How can we check for blacklisted handlers ? In which bundle is the blacklisting feature implemented ? Regards, Timothee [0] https://sling.apache.org/documentation/bundles/apache-sling-eventing-and-job-handling.html
Re: OSGI EventAdmin event handler blacklist
No there is nothing apart from the log in the event admin implementation. But if you're dealing with Sling jobs you shouldn't use the event admin way of starting/processing jobs anyway. It's prefered to use the api instead (JobManager and JobConsumer) Carsten 2014-08-22 15:19 GMT+02:00 Felix Meschberger fmesc...@adobe.com: Hi Tim Blacklisting is a feature of the Apache Felix Event Admin bundle and IIRC at least the timeout for blacklisting is configurable. You might want to check your application, whether blacklisting timeout has been reconfigured or not. I am not really aware, whether it can be analyzed whether handlers have been blacklisted or not. Other than inspecting the log file for respective entries. Regards Felix Am 22.08.2014 um 10:28 schrieb Timothée Maret timothee.ma...@gmail.com: Hi, In our deployment we have experienced tens of thousands of Sling Job pilling up in queue without having them being processed (for days). Using the regular Sling Jobs UI, we found no reason why this happened (queue was configured properly and active). We also analyzed multiple thread dumps and found no deadlock that could explain this issue. Quoting the doc [0] it may have been that our job topics where simply blacklisted: The OSGi EventAdmin usually comes with a timeout for event handlers. An event handler must consume an OSGi event as fast as possible otherwise the handler might get a timeout and get blacklisted How can we check for blacklisted handlers ? In which bundle is the blacklisting feature implemented ? Regards, Timothee [0] https://sling.apache.org/documentation/bundles/apache-sling-eventing-and-job-handling.html -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
Jenkins build is unstable: sling-oak-it-1.6 » Apache Sling Launchpad Testing #71
See https://builds.apache.org/job/sling-oak-it-1.6/org.apache.sling$org.apache.sling.launchpad.testing/71/
[jira] [Commented] (SLING-3657) Create a ResourceMerger-style ResourceProvider which merges based on resource super types
[ https://issues.apache.org/jira/browse/SLING-3657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14106827#comment-14106827 ] Carsten Ziegeler commented on SLING-3657: - [~justinedelson] Sorry for my brief comment, no I'm not against multiple resource providers - I'm against a service which returns resources that are not part of the resource tree and therefore bypass all other Sling mechanisms and only create problems and confusion :) Create a ResourceMerger-style ResourceProvider which merges based on resource super types - Key: SLING-3657 URL: https://issues.apache.org/jira/browse/SLING-3657 Project: Sling Issue Type: New Feature Components: Extensions Reporter: Justin Edelson Attachments: SLING-3657.patch The current MergingResourceProvider does a good job of a single use case - merging resources relative to the search paths. A second use case for merging is to merge resources based on their sling:resourceSuperType inheritance, i.e. /content/siteA@sling:resourceSuperType=/content/siteB /content/siteB@sling:resourceSuperType=/content/siteC It should be possible to generate a merged resource which combines /content/siteA, /content/siteB, and /content/siteC (in reverse order so that siteA overrides siteB, etc.). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3657) Create a ResourceMerger-style ResourceProvider which merges based on resource super types
[ https://issues.apache.org/jira/browse/SLING-3657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14106830#comment-14106830 ] Carsten Ziegeler commented on SLING-3657: - I would love to have a configuration option whether the provider supports CRUD (CUD to be precise) as well - as originally described in SLING-3420. As this is currently one of the major pain points we have - but I'm happy to discuss this in a different issue :) Create a ResourceMerger-style ResourceProvider which merges based on resource super types - Key: SLING-3657 URL: https://issues.apache.org/jira/browse/SLING-3657 Project: Sling Issue Type: New Feature Components: Extensions Reporter: Justin Edelson Attachments: SLING-3657.patch The current MergingResourceProvider does a good job of a single use case - merging resources relative to the search paths. A second use case for merging is to merge resources based on their sling:resourceSuperType inheritance, i.e. /content/siteA@sling:resourceSuperType=/content/siteB /content/siteB@sling:resourceSuperType=/content/siteC It should be possible to generate a merged resource which combines /content/siteA, /content/siteB, and /content/siteC (in reverse order so that siteA overrides siteB, etc.). -- This message was sent by Atlassian JIRA (v6.2#6252)
Jenkins build is back to stable : sling-trunk-1.7 » Apache Sling SLF4J Implementation (Logback) #761
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.commons.log/761/
Jenkins build is still unstable: sling-trunk-1.7 #761
See https://builds.apache.org/job/sling-trunk-1.7/changes
Jenkins build is still unstable: sling-trunk-1.7 » Apache Sling Installer Integration Tests #761
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.installer.it/changes
[jira] [Commented] (SLING-3657) Create a ResourceMerger-style ResourceProvider which merges based on resource super types
[ https://issues.apache.org/jira/browse/SLING-3657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14106835#comment-14106835 ] Justin Edelson commented on SLING-3657: --- [~cziegeler] Then I guess the question at that point becomes how do we support multiple resource providers while not doing a bunch of error-prone code duplication. And let's assume for the sake of argument that at least some of these resource providers are not in this bundle and thus require some kind of API. I think the choice really comes down to a abstract base resource provider (AbstractMergingResourceProvider) or a separate service (ResourceMergerService). I'm guessing you favor the former. I haven't thought the CUD part fully through, but I expect that this doesn't have a huge bearing on how code is shared amongst resource providers. Create a ResourceMerger-style ResourceProvider which merges based on resource super types - Key: SLING-3657 URL: https://issues.apache.org/jira/browse/SLING-3657 Project: Sling Issue Type: New Feature Components: Extensions Reporter: Justin Edelson Attachments: SLING-3657.patch The current MergingResourceProvider does a good job of a single use case - merging resources relative to the search paths. A second use case for merging is to merge resources based on their sling:resourceSuperType inheritance, i.e. /content/siteA@sling:resourceSuperType=/content/siteB /content/siteB@sling:resourceSuperType=/content/siteC It should be possible to generate a merged resource which combines /content/siteA, /content/siteB, and /content/siteC (in reverse order so that siteA overrides siteB, etc.). -- This message was sent by Atlassian JIRA (v6.2#6252)
Jenkins build is still unstable: sling-trunk-1.8 » Apache Sling Launchpad Testing #50
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.launchpad.testing/50/
Jenkins build is back to stable : sling-trunk-1.8 » Apache Sling Event Support #50
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.event/50/
Jenkins build became unstable: sling-trunk-1.8 » Apache Sling Pax Exam Utilities #50
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.paxexam.util/50/
Jenkins build is back to stable : sling-trunk-1.8 » Apache Sling Installer Integration Tests #50
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.installer.it/50/changes
Jenkins build is still unstable: sling-trunk-1.8 #50
See https://builds.apache.org/job/sling-trunk-1.8/changes
[jira] [Created] (SLING-3876) SelfInjector is too aggressive
Justin Edelson created SLING-3876:
-
Summary: SelfInjector is too aggressive
Key: SLING-3876
URL: https://issues.apache.org/jira/browse/SLING-3876
Project: Sling
Issue Type: Bug
Components: Extensions
Reporter: Justin Edelson
Fix For: Sling Models Implementation 1.0.8
The service ranking of the self injector is currently 100. Since the only
restriction it has is based on class, this blocks any of the other standard
injectors from providing an object which has the same supertype as the
adaptable. For example, if you did:
Resource someOtherResource = resourceResolver.getResource(/something);
request.setAttribute(foo, someOtherResource);
@Model(adaptable=Resource.class)
public interface GettingFoo {
@Inject @Named(foo)
Resource getFooResource();
}
getFooResource() would return the adaptable, not the resource.
I'll increase the service ranking to MAX_INTEGER as a first step, but this
might require something additional.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (SLING-3876) SelfInjector is too aggressive
[
https://issues.apache.org/jira/browse/SLING-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson updated SLING-3876:
--
Labels: models (was: )
SelfInjector is too aggressive
--
Key: SLING-3876
URL: https://issues.apache.org/jira/browse/SLING-3876
Project: Sling
Issue Type: Bug
Components: Extensions
Reporter: Justin Edelson
Labels: models
Fix For: Sling Models Implementation 1.0.8
The service ranking of the self injector is currently 100. Since the only
restriction it has is based on class, this blocks any of the other standard
injectors from providing an object which has the same supertype as the
adaptable. For example, if you did:
Resource someOtherResource = resourceResolver.getResource(/something);
request.setAttribute(foo, someOtherResource);
@Model(adaptable=Resource.class)
public interface GettingFoo {
@Inject @Named(foo)
Resource getFooResource();
}
getFooResource() would return the adaptable, not the resource.
I'll increase the service ranking to MAX_INTEGER as a first step, but this
might require something additional.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
Jenkins build is back to stable : sling-trunk-1.7 » Apache Sling Installer Integration Tests #762
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.installer.it/762/
Jenkins build is back to stable : sling-trunk-1.7 #762
See https://builds.apache.org/job/sling-trunk-1.7/762/changes
Jenkins build is back to stable : sling-trunk-1.8 » Apache Sling Pax Exam Utilities #51
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.paxexam.util/51/
Jenkins build is still unstable: sling-trunk-1.8 #51
See https://builds.apache.org/job/sling-trunk-1.8/changes
Jenkins build is still unstable: sling-trunk-1.8 » Apache Sling Launchpad Testing #51
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.launchpad.testing/51/
[jira] [Commented] (SLING-3657) Create a ResourceMerger-style ResourceProvider which merges based on resource super types
[ https://issues.apache.org/jira/browse/SLING-3657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14106904#comment-14106904 ] Carsten Ziegeler commented on SLING-3657: - The question for me is, do we really have a use case for arbitrary merging resource provider implementations - or can't we handle all three use cases mentioned initially in the same bundle and are done? So basically three implementations sharing some code? I think three different ways is already hard to understand, but opening it up to N implementations makes it complicated as you first have to know it's a merging provider and then also you have to know how exactly the merging works. I would think if we can provide the common stuff in a service, than we can also directly provide the resource providers. Yes, the CUD part doesn't play a role in this discussion. Create a ResourceMerger-style ResourceProvider which merges based on resource super types - Key: SLING-3657 URL: https://issues.apache.org/jira/browse/SLING-3657 Project: Sling Issue Type: New Feature Components: Extensions Reporter: Justin Edelson Attachments: SLING-3657.patch The current MergingResourceProvider does a good job of a single use case - merging resources relative to the search paths. A second use case for merging is to merge resources based on their sling:resourceSuperType inheritance, i.e. /content/siteA@sling:resourceSuperType=/content/siteB /content/siteB@sling:resourceSuperType=/content/siteC It should be possible to generate a merged resource which combines /content/siteA, /content/siteB, and /content/siteC (in reverse order so that siteA overrides siteB, etc.). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (SLING-3877) Add a resource path injector
Justin Edelson created SLING-3877: - Summary: Add a resource path injector Key: SLING-3877 URL: https://issues.apache.org/jira/browse/SLING-3877 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Sling Models Implementation 1.0.8, Sling Models API 1.0.4 It is useful to be able to inject a resource by path, either a static path or a path defined by a property. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (SLING-3876) SelfInjector is too aggressive
[
https://issues.apache.org/jira/browse/SLING-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson reassigned SLING-3876:
-
Assignee: Justin Edelson
SelfInjector is too aggressive
--
Key: SLING-3876
URL: https://issues.apache.org/jira/browse/SLING-3876
Project: Sling
Issue Type: Bug
Components: Extensions
Reporter: Justin Edelson
Assignee: Justin Edelson
Labels: models
Fix For: Sling Models Implementation 1.0.8
The service ranking of the self injector is currently 100. Since the only
restriction it has is based on class, this blocks any of the other standard
injectors from providing an object which has the same supertype as the
adaptable. For example, if you did:
Resource someOtherResource = resourceResolver.getResource(/something);
request.setAttribute(foo, someOtherResource);
@Model(adaptable=Resource.class)
public interface GettingFoo {
@Inject @Named(foo)
Resource getFooResource();
}
getFooResource() would return the adaptable, not the resource.
I'll increase the service ranking to MAX_INTEGER as a first step, but this
might require something additional.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
Jenkins build is still unstable: sling-oak-it-1.6 #72
See https://builds.apache.org/job/sling-oak-it-1.6/72/
Jenkins build is still unstable: sling-trunk-1.8 » Apache Sling Launchpad Testing #52
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.launchpad.testing/52/
Jenkins build is still unstable: sling-trunk-1.8 #52
See https://builds.apache.org/job/sling-trunk-1.8/changes
Re: BindingsValuesProvider services ordering
Hi Radu, I think the current order is giving the service with the highest ordering the final call. If two providers provide a value for the same key, the one with the highest wins as it is called last. So I think this matches the other usages of service ranking. Regards Carsten 2014-08-22 17:17 GMT+02:00 Radu Cotescu r...@apache.org: Hi, In SLING-3320 [0] we introduced some ordering in the BVPs maps, such that BVPs are called using the natural ordering of their ServiceReferences, which is based on the service.ranking value: the higher the service.ranking is, the later in the call chain will a BVP be called to add its bindings. Given that in the OSGi world the service.ranking is used to determine which implementation is returned for a certain service, the rule of thumb being that the higher the service.ranking is the most likely that implementation will be provided, should't we actually reverse the sort order of the BVPs? In theory this might introduce some subtle bugs in clients' code, but no one complained when we introduced the ordering in the first place. WDYT? Cheers, Radu [0] - https://issues.apache.org/jira/browse/SLING-3320 -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
[jira] [Resolved] (SLING-3876) SelfInjector is too aggressive
[
https://issues.apache.org/jira/browse/SLING-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson resolved SLING-3876.
---
Resolution: Fixed
SelfInjector is too aggressive
--
Key: SLING-3876
URL: https://issues.apache.org/jira/browse/SLING-3876
Project: Sling
Issue Type: Bug
Components: Extensions
Reporter: Justin Edelson
Assignee: Justin Edelson
Labels: models
Fix For: Sling Models Implementation 1.0.8
Original Estimate: 0h
Remaining Estimate: 0h
The service ranking of the self injector is currently 100. Since the only
restriction it has is based on class, this blocks any of the other standard
injectors from providing an object which has the same supertype as the
adaptable. For example, if you did:
Resource someOtherResource = resourceResolver.getResource(/something);
request.setAttribute(foo, someOtherResource);
@Model(adaptable=Resource.class)
public interface GettingFoo {
@Inject @Named(foo)
Resource getFooResource();
}
getFooResource() would return the adaptable, not the resource.
I'll increase the service ranking to MAX_INTEGER as a first step, but this
might require something additional.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (SLING-3877) Add a resource path injector
[ https://issues.apache.org/jira/browse/SLING-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-3877: -- Remaining Estimate: 0h Original Estimate: 0h Add a resource path injector Key: SLING-3877 URL: https://issues.apache.org/jira/browse/SLING-3877 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Justin Edelson Assignee: Justin Edelson Labels: models Fix For: Sling Models Implementation 1.0.8, Sling Models API 1.0.4 Original Estimate: 0h Remaining Estimate: 0h It is useful to be able to inject a resource by path, either a static path or a path defined by a property. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (SLING-3877) Add a resource path injector
[ https://issues.apache.org/jira/browse/SLING-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-3877. --- Resolution: Fixed Add a resource path injector Key: SLING-3877 URL: https://issues.apache.org/jira/browse/SLING-3877 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Justin Edelson Assignee: Justin Edelson Labels: models Fix For: Sling Models Implementation 1.0.8, Sling Models API 1.0.4 Original Estimate: 0h Remaining Estimate: 0h It is useful to be able to inject a resource by path, either a static path or a path defined by a property. -- This message was sent by Atlassian JIRA (v6.2#6252)
Re: Deprecating JcrResource.adaptTo(URL) ?
Hi Justin, thanks for the work. I guess it's fine if we don't mark the url adaption as deprecated in the console. There will still be the log entry. I guess/hope noone is using this anyway :) In order to get the deprecation info into the console, what do we need to release? Regards Carsten 2014-08-21 15:31 GMT+02:00 Justin Edelson jus...@justinedelson.com: Ugh. I realized this one is a bit more complicated to deprecate in the way I was thinking. JcrResource.adaptTo(URL.class) is implemented as an adaptation within JcrResource along with several others. I was thinking that we would flag the whole adapter factory as deprecated. I don't see a practical way to mark a single adapation within an adaptable or an adapter factory as deprecated. Sigh... On Thu, Aug 21, 2014 at 7:19 AM, Jeff Young j...@adobe.com wrote: +1 (to deprecating adaptTo(URL), and to deprecation comments in the other thread) Cheers, Jeff. On 20/08/2014 17:29, Justin Edelson jus...@justinedelson.com wrote: Hi, I'm fine with this, although I'm see my other email about what it means to deprecate an adapter factory. Justin On Wed, Aug 20, 2014 at 11:59 AM, Carsten Ziegeler cziege...@apache.org wrote: Hi, the JCR Resource implementation currently allows to adapt it to a url which internally embeds several jackrabbit classes. The returned object keeps hold of the current session and therefore is a potential memory leak and can't be used once the session is closed. So far I've not seen any real use case for this and especially as other resource implementations do not provide it, what about deprecating this now, logging a big message when used (once) and then we can remove it in one of the next versions? Regards Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
[jira] [Updated] (SLING-3876) SelfInjector is too aggressive
[
https://issues.apache.org/jira/browse/SLING-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson updated SLING-3876:
--
Remaining Estimate: 0h
Original Estimate: 0h
SelfInjector is too aggressive
--
Key: SLING-3876
URL: https://issues.apache.org/jira/browse/SLING-3876
Project: Sling
Issue Type: Bug
Components: Extensions
Reporter: Justin Edelson
Assignee: Justin Edelson
Labels: models
Fix For: Sling Models Implementation 1.0.8
Original Estimate: 0h
Remaining Estimate: 0h
The service ranking of the self injector is currently 100. Since the only
restriction it has is based on class, this blocks any of the other standard
injectors from providing an object which has the same supertype as the
adaptable. For example, if you did:
Resource someOtherResource = resourceResolver.getResource(/something);
request.setAttribute(foo, someOtherResource);
@Model(adaptable=Resource.class)
public interface GettingFoo {
@Inject @Named(foo)
Resource getFooResource();
}
getFooResource() would return the adaptable, not the resource.
I'll increase the service ranking to MAX_INTEGER as a first step, but this
might require something additional.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
Jenkins build became unstable: sling-trunk-1.6 » Apache Sling Models Integration Tests #2390
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.models.integration-tests/2390/
Jenkins build became unstable: sling-trunk-1.6 #2390
See https://builds.apache.org/job/sling-trunk-1.6/2390/changes
Jenkins build became unstable: sling-trunk-1.6 » Apache Sling Installer Integration Tests #2390
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.installer.it/2390/
Re: Deprecating JcrResource.adaptTo(URL) ?
Hi Carsten, In order to get the deprecation info into the console, what do we need to release? The adapter bundle. You can add the deprecation flag to adapters without this release, of course, it'll just be ignored. Justin On Fri, Aug 22, 2014 at 11:59 AM, Carsten Ziegeler cziege...@apache.org wrote: Hi Justin, thanks for the work. I guess it's fine if we don't mark the url adaption as deprecated in the console. There will still be the log entry. I guess/hope noone is using this anyway :) In order to get the deprecation info into the console, what do we need to release? Regards Carsten 2014-08-21 15:31 GMT+02:00 Justin Edelson jus...@justinedelson.com: Ugh. I realized this one is a bit more complicated to deprecate in the way I was thinking. JcrResource.adaptTo(URL.class) is implemented as an adaptation within JcrResource along with several others. I was thinking that we would flag the whole adapter factory as deprecated. I don't see a practical way to mark a single adapation within an adaptable or an adapter factory as deprecated. Sigh... On Thu, Aug 21, 2014 at 7:19 AM, Jeff Young j...@adobe.com wrote: +1 (to deprecating adaptTo(URL), and to deprecation comments in the other thread) Cheers, Jeff. On 20/08/2014 17:29, Justin Edelson jus...@justinedelson.com wrote: Hi, I'm fine with this, although I'm see my other email about what it means to deprecate an adapter factory. Justin On Wed, Aug 20, 2014 at 11:59 AM, Carsten Ziegeler cziege...@apache.org wrote: Hi, the JCR Resource implementation currently allows to adapt it to a url which internally embeds several jackrabbit classes. The returned object keeps hold of the current session and therefore is a potential memory leak and can't be used once the session is closed. So far I've not seen any real use case for this and especially as other resource implementations do not provide it, what about deprecating this now, logging a big message when used (once) and then we can remove it in one of the next versions? Regards Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
Jenkins build became unstable: sling-trunk-1.8 » Apache Sling Models Integration Tests #53
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.models.integration-tests/53/
Jenkins build is still unstable: sling-trunk-1.8 » Apache Sling Launchpad Testing #53
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.launchpad.testing/53/
Jenkins build is still unstable: sling-trunk-1.8 #53
See https://builds.apache.org/job/sling-trunk-1.8/changes
Jenkins build became unstable: sling-trunk-1.7 » Apache Sling Pax Exam Utilities #764
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.paxexam.util/764/
Jenkins build became unstable: sling-trunk-1.7 » Apache Sling Models Integration Tests #764
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.models.integration-tests/764/
Jenkins build became unstable: sling-trunk-1.7 » Apache Sling Launchpad Testing #764
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.testing/764/
Jenkins build became unstable: sling-trunk-1.7 » Apache Sling Resource-Based Discovery Service #764
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.discovery.impl/764/
Build failed in Jenkins: sling-trunk-1.7 #764
See https://builds.apache.org/job/sling-trunk-1.7/764/changes Changes: [justin] SLING-3877 - adding a resource path injector. also did some minor refactoring to avoid code duplication between injectors. [justin] SLING-3876 - ensuring that class-based self injection only happens on the first constructor parameter. Otherwise the @Self annotation is necessary. Also changing the ranking so that other injectors have the opportunity to inject to the first constructor parameter before. -- [...truncated 89108 lines...] Running org.apache.sling.launchpad.webapp.integrationtest.indexing.FullTextIndexingTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.972 sec - in org.apache.sling.launchpad.webapp.integrationtest.indexing.FullTextIndexingTest Running org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletAtMoveTest Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.67 sec - in org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletAtMoveTest Running org.apache.sling.launchpad.webapp.integrationtest.servlets.post.SlingDateValuesTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.187 sec - in org.apache.sling.launchpad.webapp.integrationtest.servlets.post.SlingDateValuesTest Running org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletOrderTest Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.383 sec - in org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletOrderTest Running org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletCreateTest Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.791 sec - in org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletCreateTest Running org.apache.sling.launchpad.webapp.integrationtest.servlets.post.ReferenceTypeHintTest Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.539 sec - in org.apache.sling.launchpad.webapp.integrationtest.servlets.post.ReferenceTypeHintTest Running org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletDeleteTest Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.727 sec - in org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletDeleteTest Running org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletAtCopyTest Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.031 sec - in org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletAtCopyTest Running org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletNopTest Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.079 sec - in org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletNopTest Running org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletPatchTest Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.211 sec - in org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletPatchTest Running org.apache.sling.launchpad.webapp.integrationtest.servlets.post.SlingAutoPropertiesTest Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.287 sec - in org.apache.sling.launchpad.webapp.integrationtest.servlets.post.SlingAutoPropertiesTest Running org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostToRootTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.05 sec - in org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostToRootTest Running org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletVersionableTest Tests run: 25, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.722 sec - in org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletVersionableTest Running org.apache.sling.launchpad.webapp.integrationtest.servlets.post.CustomPostOperationTest Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.282 sec - in org.apache.sling.launchpad.webapp.integrationtest.servlets.post.CustomPostOperationTest Running org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletDeleteParentTest Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.528 sec - in org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletDeleteParentTest Running org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletMoveTest Tests run: 15, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.281 sec - in org.apache.sling.launchpad.webapp.integrationtest.servlets.post.PostServletMoveTest Running org.apache.sling.launchpad.webapp.integrationtest.servlets.post.SlingSessionInfoTest Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.031 sec - in org.apache.sling.launchpad.webapp.integrationtest.servlets.post.SlingSessionInfoTest Running
[jira] [Updated] (SLING-3860) Sling Models - max recursion depth should be configurable
[ https://issues.apache.org/jira/browse/SLING-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-3860: -- Assignee: Justin Edelson Remaining Estimate: 0h Original Estimate: 0h Sling Models - max recursion depth should be configurable - Key: SLING-3860 URL: https://issues.apache.org/jira/browse/SLING-3860 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Justin Edelson Assignee: Justin Edelson Labels: models Original Estimate: 0h Remaining Estimate: 0h Currently, the maximum recursion depth is hard set at 20 in ModelAdapterFactory. This should be made configurable. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (SLING-3860) Sling Models - max recursion depth should be configurable
[ https://issues.apache.org/jira/browse/SLING-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-3860. --- Resolution: Fixed Sling Models - max recursion depth should be configurable - Key: SLING-3860 URL: https://issues.apache.org/jira/browse/SLING-3860 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Justin Edelson Assignee: Justin Edelson Labels: models Original Estimate: 0h Remaining Estimate: 0h Currently, the maximum recursion depth is hard set at 20 in ModelAdapterFactory. This should be made configurable. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3860) Sling Models - max recursion depth should be configurable
[ https://issues.apache.org/jira/browse/SLING-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14107551#comment-14107551 ] Justin Edelson commented on SLING-3860: --- Fixed in r1619937 Sling Models - max recursion depth should be configurable - Key: SLING-3860 URL: https://issues.apache.org/jira/browse/SLING-3860 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Justin Edelson Assignee: Justin Edelson Labels: models Original Estimate: 0h Remaining Estimate: 0h Currently, the maximum recursion depth is hard set at 20 in ModelAdapterFactory. This should be made configurable. -- This message was sent by Atlassian JIRA (v6.2#6252)
Jenkins build is still unstable: sling-trunk-1.7 » Apache Sling Models Integration Tests #765
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.models.integration-tests/765/
Jenkins build is back to stable : sling-trunk-1.7 » Apache Sling Resource-Based Discovery Service #765
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.discovery.impl/765/
Jenkins build is unstable: sling-trunk-1.7 #765
See https://builds.apache.org/job/sling-trunk-1.7/765/changes
Jenkins build is back to stable : sling-trunk-1.7 » Apache Sling Launchpad Testing #765
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.testing/765/
Jenkins build is back to stable : sling-trunk-1.7 » Apache Sling Pax Exam Utilities #765
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.paxexam.util/765/
Jenkins build became unstable: sling-trunk-1.8 » Apache Sling Event Support #54
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.event/54/
Jenkins build is still unstable: sling-trunk-1.8 » Apache Sling Models Integration Tests #54
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.models.integration-tests/54/
Jenkins build is still unstable: sling-trunk-1.8 #54
See https://builds.apache.org/job/sling-trunk-1.8/changes
Jenkins build is back to stable : sling-trunk-1.6 » Apache Sling Installer Integration Tests #2391
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.installer.it/2391/
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Models Integration Tests #2391
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.models.integration-tests/2391/
Jenkins build became unstable: sling-trunk-1.6 » Apache Sling Launchpad Testing #2391
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing/2391/
