Re: [VOTE] Release Apache Sling Scripting FreeMarker 1.0.0

[Daniel Klco]

+1

On Fri, Sep 7, 2018 at 4:51 PM Oliver Lietz  wrote:

> Hi,
>
> we solved 22 issues in this release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12320256
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-1965/
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 1965 /tmp/sling-staging
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Regards,
> O.
>
>

Re: [VOTE] Release Apache Sling Scripting Groovy 1.0.4

[Daniel Klco]

+1

On Fri, Sep 7, 2018 at 4:07 PM Oliver Lietz  wrote:

> Hi,
>
> we solved 17 issues in this release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12334653
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-1964/
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 1964 /tmp/sling-staging
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Regards,
> O.
>
>

[VOTE] Release Apache Sling Scripting FreeMarker 1.0.0

[Oliver Lietz]

Hi,

we solved 22 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12320256

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1965/

You can use this UNIX script to download the release and verify the 
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 1965 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
O.

[VOTE] Release Apache Sling Scripting Groovy 1.0.4

[Oliver Lietz]

Hi,

we solved 17 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12334653

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1964/

You can use this UNIX script to download the release and verify the 
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 1964 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
O.

[jira] [Resolved] (SLING-7897) Make DynamicClassLoaderManager reference dynamic

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-7897.
-
Resolution: Done

> Make DynamicClassLoaderManager reference dynamic
> 
>
> Key: SLING-7897
> URL: https://issues.apache.org/jira/browse/SLING-7897
> Project: Sling
>  Issue Type: Improvement
>  Components: Scripting
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Scripting Groovy 1.0.4
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7897) Make DynamicClassLoaderManager reference dynamic

[Oliver Lietz (JIRA)]

Oliver Lietz created SLING-7897:
---

 Summary: Make DynamicClassLoaderManager reference dynamic
 Key: SLING-7897
 URL: https://issues.apache.org/jira/browse/SLING-7897
 Project: Sling
  Issue Type: Improvement
  Components: Scripting
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Scripting Groovy 1.0.4






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7896) Update Pax Exam to 4.12.0

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-7896.
-
Resolution: Done

> Update Pax Exam to 4.12.0
> -
>
> Key: SLING-7896
> URL: https://issues.apache.org/jira/browse/SLING-7896
> Project: Sling
>  Issue Type: Task
>  Components: Scripting
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Scripting Groovy 1.0.4
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7896) Update Pax Exam to 4.12.0

[Oliver Lietz (JIRA)]

Oliver Lietz created SLING-7896:
---

 Summary: Update Pax Exam to 4.12.0
 Key: SLING-7896
 URL: https://issues.apache.org/jira/browse/SLING-7896
 Project: Sling
  Issue Type: Task
  Components: Scripting
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Scripting Groovy 1.0.4






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7895) Update to Sling Parent 34

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-7895.
-
Resolution: Done

> Update to Sling Parent 34
> -
>
> Key: SLING-7895
> URL: https://issues.apache.org/jira/browse/SLING-7895
> Project: Sling
>  Issue Type: Task
>  Components: Scripting
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Scripting Groovy 1.0.4
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7895) Update to Sling Parent 34

[Oliver Lietz (JIRA)]

Oliver Lietz created SLING-7895:
---

 Summary: Update to Sling Parent 34
 Key: SLING-7895
 URL: https://issues.apache.org/jira/browse/SLING-7895
 Project: Sling
  Issue Type: Task
  Components: Scripting
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Scripting Groovy 1.0.4






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[VOTE] Release Apache Sling Scripting Thymeleaf 2.0.0

[Oliver Lietz]

Hi,

we solved 8 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12335601

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1963/

You can use this UNIX script to download the release and verify the 
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 1963 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
O.

Re: [VOTE] Release Apache Sling File Optimization version 0.9.2 - Round 2

[Jason E Bailey]

+1 non-binding

- Jason

On Fri, Sep 7, 2018, at 1:15 PM, Daniel Klco wrote:
> Hi,
> 
> We solved 1 issues in this release:
> https://issues.apache.org/jira/projects/SLING/versions/12343855
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-1957/
> 
> You can use this UNIX script to download the release and verify the
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> 
> Usage:
> sh check_staged_release.sh 1957 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.

[VOTE] Release Apache Sling File Optimization version 0.9.2 - Round 2

[Daniel Klco]

Hi,

We solved 1 issues in this release:
https://issues.apache.org/jira/projects/SLING/versions/12343855

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1957/

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 1957 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Re: [VOTE] Release Apache Sling Settings 1.3.10

[Daniel Klco]

+1

On Fri, Sep 7, 2018 at 8:24 AM Oliver Lietz  wrote:

> Hi,
>
> we solved 3 issues in this release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12334445
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-1960/
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 1960 /tmp/sling-staging
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Regards,
> O.
>
>

[jira] [Resolved] (SLING-7894) Update Pax Exam to 4.12.0

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-7894.
-
Resolution: Done

> Update Pax Exam to 4.12.0
> -
>
> Key: SLING-7894
> URL: https://issues.apache.org/jira/browse/SLING-7894
> Project: Sling
>  Issue Type: Task
>  Components: Scripting
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Scripting Thymeleaf 2.0.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7894) Update Pax Exam to 4.12.0

[Oliver Lietz (JIRA)]

Oliver Lietz created SLING-7894:
---

 Summary: Update Pax Exam to 4.12.0
 Key: SLING-7894
 URL: https://issues.apache.org/jira/browse/SLING-7894
 Project: Sling
  Issue Type: Task
  Components: Scripting
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Scripting Thymeleaf 2.0.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7893) Update Pax Exam to 4.12.0

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-7893.
-
Resolution: Done

> Update Pax Exam to 4.12.0
> -
>
> Key: SLING-7893
> URL: https://issues.apache.org/jira/browse/SLING-7893
> Project: Sling
>  Issue Type: Task
>  Components: Scripting
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Scripting FreeMarker 1.0.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-7892) Update to Sling Parent 34

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz updated SLING-7892:

Issue Type: Task  (was: Improvement)

> Update to Sling Parent 34
> -
>
> Key: SLING-7892
> URL: https://issues.apache.org/jira/browse/SLING-7892
> Project: Sling
>  Issue Type: Task
>  Components: Scripting
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Scripting FreeMarker 1.0.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7893) Update Pax Exam to 4.12.0

[Oliver Lietz (JIRA)]

Oliver Lietz created SLING-7893:
---

 Summary: Update Pax Exam to 4.12.0
 Key: SLING-7893
 URL: https://issues.apache.org/jira/browse/SLING-7893
 Project: Sling
  Issue Type: Task
  Components: Scripting
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Scripting FreeMarker 1.0.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7892) Update to Sling Parent 34

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-7892.
-
Resolution: Done

> Update to Sling Parent 34
> -
>
> Key: SLING-7892
> URL: https://issues.apache.org/jira/browse/SLING-7892
> Project: Sling
>  Issue Type: Improvement
>  Components: Scripting
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Scripting FreeMarker 1.0.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7892) Update to Sling Parent 34

[Oliver Lietz (JIRA)]

Oliver Lietz created SLING-7892:
---

 Summary: Update to Sling Parent 34
 Key: SLING-7892
 URL: https://issues.apache.org/jira/browse/SLING-7892
 Project: Sling
  Issue Type: Improvement
  Components: Scripting
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Scripting FreeMarker 1.0.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7858) Convert CSS to a Framework

[Jason E Bailey (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason E Bailey resolved SLING-7858.
---
Resolution: Fixed

> Convert CSS to a Framework
> --
>
> Key: SLING-7858
> URL: https://issues.apache.org/jira/browse/SLING-7858
> Project: Sling
>  Issue Type: Improvement
>  Components: App CMS
>Reporter: Jason E Bailey
>Assignee: Jason E Bailey
>Priority: Minor
> Fix For: App CMS 0.9.2
>
>
> To improve the overall UI, convert the UI to a theme-able CSS framework



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

[Jason E Bailey (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607251#comment-16607251
 ] 

Jason E Bailey commented on SLING-7890:
---

[~rombert] I've committed changes to both the default servlets and the 
integration tests. The last issue I'd like another opinion on. They current 
problem is that the json response for the VersionHistory was incorrectly 
returning a boolean property of true as "true" the integration test was set up 
to match on the String. It's now correctly responding with the boolean value. 
However this is a break if someone was expecting a String like the integration 
test.

> JSON-related IT failures when upgrading sling.servlets to 2.1.34
> 
>
> Key: SLING-7890
> URL: https://issues.apache.org/jira/browse/SLING-7890
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.34
>Reporter: Robert Munteanu
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Launchpad Integration Tests 1.0.8, Servlets Get 2.1.36
>
>
> With the following change in the sling starter
> {noformat}diff --git a/src/main/provisioning/sling.txt 
> b/src/main/provisioning/sling.txt
> index 0f76c0b..4904fc3 100644
> --- a/src/main/provisioning/sling.txt
> +++ b/src/main/provisioning/sling.txt
> @@ -62,7 +62,7 @@
>  org.apache.sling/org.apache.sling.resourceresolver/1.6.6
>  org.apache.sling/org.apache.sling.serviceusermapper/1.4.0
>  org.apache.sling/org.apache.sling.serviceuser.webconsole/1.0.0
> -org.apache.sling/org.apache.sling.servlets.get/2.1.30
> +org.apache.sling/org.apache.sling.servlets.get/2.1.34
>  org.apache.sling/org.apache.sling.servlets.post/2.3.26
>  org.apache.sling/org.apache.sling.servlets.resolver/2.4.22
>  org.apache.sling/org.apache.sling.xss/2.0.12
> {noformat}
> I get multiple IT failures, and the root cause seems top be
> {noformat}java.lang.ClassCastException: 
> org.apache.johnzon.core.JsonObjectImpl cannot be cast to javax.json.JsonArray
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.valueToString(JsonToText.java:164)
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.prettyPrint(JsonToText.java:209)
>   at 
> org.apache.sling.servlets.get.impl.VersionInfoServlet.doGet(VersionInfoServlet.java:124)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
>   at 
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
>   at 
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
>   at 
> org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:107)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.NoPropertyFilter.doFilter(NoPropertyFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.SlingFilter.doFilter(SlingFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.doProcessRequest(SlingRequestProcessorImpl.java:151)
>   at 
> 

[GitHub] OSGDuff removed a comment on issue #5: removing logging bug from line 575 of SlingLogPanel.java

[GitBox]

OSGDuff removed a comment on issue #5: removing logging bug from line 575 of 
SlingLogPanel.java
URL: 
https://github.com/apache/sling-org-apache-sling-commons-log/pull/5#issuecomment-419144499
 
 
   Made a ticket, I hate Jira tho
   https://issues.apache.org/jira/browse/SLING-7884
   
   
   Thanks!
   __
   
   DEVIN DUFFY |  INFORMATION SECURITY SPECIALIST
   APPLICATION SECURITY
   AMERICAN EXPRESS
   20022 North 31st Avenue |  Phoenix, AZ 85027
   M: 602-526-0624  |  E: 
devin.duffyhals...@aexp.com
   
   [cid:image001.png@01D3D021.75042360]
   
   
   From: Robert Munteanu 
   Reply-To: apache/sling-org-apache-sling-commons-log 
   Date: Thursday, September 6, 2018 at 7:10 AM
   To: apache/sling-org-apache-sling-commons-log 

   Cc: Devin Duffy-Halseth , Mention 

   Subject: Re: [apache/sling-org-apache-sling-commons-log] removing logging 
bug from line 575 of SlingLogPanel.java (#5)
   
   
   
@OSGDuff
 - fix looks good to me, thanks for submitting and also for mailing us.
   
   One final ask before merging - can you also raise an issue in the Sling jira 
so we can track it for the next release?
   
   Thanks!
   
   —
   You are receiving this because you were mentioned.
   Reply to this email directly, view it on 
GitHub,
 or mute the 
thread.
   
   
   American Express made the following annotations
   
**
   "This message and any attachments are solely for the intended recipient and 
may contain confidential or privileged information. If you are not the intended 
recipient, any disclosure, copying, use, or distribution of the information 
included in this message and any attachments is prohibited. If you have 
received this communication in error, please notify us by reply e-mail and 
immediately and permanently delete this message and any attachments. Thank you."
   
   American Express a ajouté le commentaire suivant le Ce courrier et toute 
pièce jointe qu'il contient sont réservés au seul destinataire indiqué et 
peuvent renfermer des 
   renseignements confidentiels et privilégiés. Si vous n'êtes pas le 
destinataire prévu, toute divulgation, duplication, utilisation ou distribution 
du courrier ou de toute pièce jointe est interdite. Si vous avez reçu cette 
communication par erreur, veuillez nous en aviser par courrier et détruire 
immédiatement le courrier et les pièces jointes. Merci.
   
   
**
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Updated] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

[Jason E Bailey (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason E Bailey updated SLING-7890:
--
Fix Version/s: Launchpad Integration Tests 1.0.8

> JSON-related IT failures when upgrading sling.servlets to 2.1.34
> 
>
> Key: SLING-7890
> URL: https://issues.apache.org/jira/browse/SLING-7890
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.34
>Reporter: Robert Munteanu
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Launchpad Integration Tests 1.0.8, Servlets Get 2.1.36
>
>
> With the following change in the sling starter
> {noformat}diff --git a/src/main/provisioning/sling.txt 
> b/src/main/provisioning/sling.txt
> index 0f76c0b..4904fc3 100644
> --- a/src/main/provisioning/sling.txt
> +++ b/src/main/provisioning/sling.txt
> @@ -62,7 +62,7 @@
>  org.apache.sling/org.apache.sling.resourceresolver/1.6.6
>  org.apache.sling/org.apache.sling.serviceusermapper/1.4.0
>  org.apache.sling/org.apache.sling.serviceuser.webconsole/1.0.0
> -org.apache.sling/org.apache.sling.servlets.get/2.1.30
> +org.apache.sling/org.apache.sling.servlets.get/2.1.34
>  org.apache.sling/org.apache.sling.servlets.post/2.3.26
>  org.apache.sling/org.apache.sling.servlets.resolver/2.4.22
>  org.apache.sling/org.apache.sling.xss/2.0.12
> {noformat}
> I get multiple IT failures, and the root cause seems top be
> {noformat}java.lang.ClassCastException: 
> org.apache.johnzon.core.JsonObjectImpl cannot be cast to javax.json.JsonArray
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.valueToString(JsonToText.java:164)
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.prettyPrint(JsonToText.java:209)
>   at 
> org.apache.sling.servlets.get.impl.VersionInfoServlet.doGet(VersionInfoServlet.java:124)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
>   at 
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
>   at 
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
>   at 
> org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:107)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.NoPropertyFilter.doFilter(NoPropertyFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.SlingFilter.doFilter(SlingFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.doProcessRequest(SlingRequestProcessorImpl.java:151)
>   at 
> org.apache.sling.engine.impl.SlingMainServlet.service(SlingMainServlet.java:234)
>   at 
> org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:120)
>   at 
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:86)
>   at 
> org.apache.sling.junit.impl.servlet.TestLogServlet$TestNameLoggingFilter.doFilter(TestLogServlet.java:257)
>   at 
> org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:135)
>   at 
> 

[VOTE] Release Apache Sling Service User Mapper 1.4.2

[Oliver Lietz]

Hi,

we solved 2 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12343086

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1961/

You can use this UNIX script to download the release and verify the 
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 1961 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
O.

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

[Jason E Bailey (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607120#comment-16607120
 ] 

Jason E Bailey commented on SLING-7890:
---

There's a number of tests failing related to my changes beyond this specific 
error. So I'm running through all of them and fixing what I can. Some of these 
are fails because the test included a very explicit String check that failed. 
e.g. It was looking for "dumped by PlainTextRendererServlet" and I had changed 
the name of the class to PlainTextRenderer because it was no longer a Servlet, 
and I changed the wording as well.

> JSON-related IT failures when upgrading sling.servlets to 2.1.34
> 
>
> Key: SLING-7890
> URL: https://issues.apache.org/jira/browse/SLING-7890
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.34
>Reporter: Robert Munteanu
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Servlets Get 2.1.36
>
>
> With the following change in the sling starter
> {noformat}diff --git a/src/main/provisioning/sling.txt 
> b/src/main/provisioning/sling.txt
> index 0f76c0b..4904fc3 100644
> --- a/src/main/provisioning/sling.txt
> +++ b/src/main/provisioning/sling.txt
> @@ -62,7 +62,7 @@
>  org.apache.sling/org.apache.sling.resourceresolver/1.6.6
>  org.apache.sling/org.apache.sling.serviceusermapper/1.4.0
>  org.apache.sling/org.apache.sling.serviceuser.webconsole/1.0.0
> -org.apache.sling/org.apache.sling.servlets.get/2.1.30
> +org.apache.sling/org.apache.sling.servlets.get/2.1.34
>  org.apache.sling/org.apache.sling.servlets.post/2.3.26
>  org.apache.sling/org.apache.sling.servlets.resolver/2.4.22
>  org.apache.sling/org.apache.sling.xss/2.0.12
> {noformat}
> I get multiple IT failures, and the root cause seems top be
> {noformat}java.lang.ClassCastException: 
> org.apache.johnzon.core.JsonObjectImpl cannot be cast to javax.json.JsonArray
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.valueToString(JsonToText.java:164)
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.prettyPrint(JsonToText.java:209)
>   at 
> org.apache.sling.servlets.get.impl.VersionInfoServlet.doGet(VersionInfoServlet.java:124)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
>   at 
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
>   at 
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
>   at 
> org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:107)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.NoPropertyFilter.doFilter(NoPropertyFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.SlingFilter.doFilter(SlingFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.doProcessRequest(SlingRequestProcessorImpl.java:151)
>   at 
> org.apache.sling.engine.impl.SlingMainServlet.service(SlingMainServlet.java:234)
>   at 
> 

[jira] [Resolved] (SLING-7891) Use bnd Maven plugins

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-7891.
-
Resolution: Done

> Use bnd Maven plugins
> -
>
> Key: SLING-7891
> URL: https://issues.apache.org/jira/browse/SLING-7891
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Service User Mapper 1.4.2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7891) Use bnd Maven plugins

[Oliver Lietz (JIRA)]

Oliver Lietz created SLING-7891:
---

 Summary: Use bnd Maven plugins
 Key: SLING-7891
 URL: https://issues.apache.org/jira/browse/SLING-7891
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Service User Mapper 1.4.2






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[VOTE] Release Apache Sling Settings 1.3.10

[Oliver Lietz]

Hi,

we solved 3 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12334445

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1960/

You can use this UNIX script to download the release and verify the 
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 1960 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
O.

Re: [VOTE] Release Apache Sling Commons Log 5.1.10

[Daniel Klco]

+1

On Fri, Sep 7, 2018 at 4:55 AM Robert Munteanu  wrote:

> On Fri, 2018-09-07 at 10:52 +0200, Robert Munteanu wrote:
> > Please vote to approve this release:
>
> +1
>
> Robert
>

[jira] [Assigned] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

[Jason E Bailey (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason E Bailey reassigned SLING-7890:
-

Assignee: Jason E Bailey

> JSON-related IT failures when upgrading sling.servlets to 2.1.34
> 
>
> Key: SLING-7890
> URL: https://issues.apache.org/jira/browse/SLING-7890
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.34
>Reporter: Robert Munteanu
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Servlets Get 2.1.36
>
>
> With the following change in the sling starter
> {noformat}diff --git a/src/main/provisioning/sling.txt 
> b/src/main/provisioning/sling.txt
> index 0f76c0b..4904fc3 100644
> --- a/src/main/provisioning/sling.txt
> +++ b/src/main/provisioning/sling.txt
> @@ -62,7 +62,7 @@
>  org.apache.sling/org.apache.sling.resourceresolver/1.6.6
>  org.apache.sling/org.apache.sling.serviceusermapper/1.4.0
>  org.apache.sling/org.apache.sling.serviceuser.webconsole/1.0.0
> -org.apache.sling/org.apache.sling.servlets.get/2.1.30
> +org.apache.sling/org.apache.sling.servlets.get/2.1.34
>  org.apache.sling/org.apache.sling.servlets.post/2.3.26
>  org.apache.sling/org.apache.sling.servlets.resolver/2.4.22
>  org.apache.sling/org.apache.sling.xss/2.0.12
> {noformat}
> I get multiple IT failures, and the root cause seems top be
> {noformat}java.lang.ClassCastException: 
> org.apache.johnzon.core.JsonObjectImpl cannot be cast to javax.json.JsonArray
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.valueToString(JsonToText.java:164)
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.prettyPrint(JsonToText.java:209)
>   at 
> org.apache.sling.servlets.get.impl.VersionInfoServlet.doGet(VersionInfoServlet.java:124)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
>   at 
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
>   at 
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
>   at 
> org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:107)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.NoPropertyFilter.doFilter(NoPropertyFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.SlingFilter.doFilter(SlingFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.doProcessRequest(SlingRequestProcessorImpl.java:151)
>   at 
> org.apache.sling.engine.impl.SlingMainServlet.service(SlingMainServlet.java:234)
>   at 
> org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:120)
>   at 
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:86)
>   at 
> org.apache.sling.junit.impl.servlet.TestLogServlet$TestNameLoggingFilter.doFilter(TestLogServlet.java:257)
>   at 
> org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:135)
>   at 
> 

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

[Jason E Bailey (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607027#comment-16607027
 ] 

Jason E Bailey commented on SLING-7890:
---

I see the problem. I'll work on the fix and a unit test.

> JSON-related IT failures when upgrading sling.servlets to 2.1.34
> 
>
> Key: SLING-7890
> URL: https://issues.apache.org/jira/browse/SLING-7890
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.34
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Servlets Get 2.1.36
>
>
> With the following change in the sling starter
> {noformat}diff --git a/src/main/provisioning/sling.txt 
> b/src/main/provisioning/sling.txt
> index 0f76c0b..4904fc3 100644
> --- a/src/main/provisioning/sling.txt
> +++ b/src/main/provisioning/sling.txt
> @@ -62,7 +62,7 @@
>  org.apache.sling/org.apache.sling.resourceresolver/1.6.6
>  org.apache.sling/org.apache.sling.serviceusermapper/1.4.0
>  org.apache.sling/org.apache.sling.serviceuser.webconsole/1.0.0
> -org.apache.sling/org.apache.sling.servlets.get/2.1.30
> +org.apache.sling/org.apache.sling.servlets.get/2.1.34
>  org.apache.sling/org.apache.sling.servlets.post/2.3.26
>  org.apache.sling/org.apache.sling.servlets.resolver/2.4.22
>  org.apache.sling/org.apache.sling.xss/2.0.12
> {noformat}
> I get multiple IT failures, and the root cause seems top be
> {noformat}java.lang.ClassCastException: 
> org.apache.johnzon.core.JsonObjectImpl cannot be cast to javax.json.JsonArray
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.valueToString(JsonToText.java:164)
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.prettyPrint(JsonToText.java:209)
>   at 
> org.apache.sling.servlets.get.impl.VersionInfoServlet.doGet(VersionInfoServlet.java:124)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
>   at 
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
>   at 
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
>   at 
> org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:107)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.NoPropertyFilter.doFilter(NoPropertyFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.SlingFilter.doFilter(SlingFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.doProcessRequest(SlingRequestProcessorImpl.java:151)
>   at 
> org.apache.sling.engine.impl.SlingMainServlet.service(SlingMainServlet.java:234)
>   at 
> org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:120)
>   at 
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:86)
>   at 
> org.apache.sling.junit.impl.servlet.TestLogServlet$TestNameLoggingFilter.doFilter(TestLogServlet.java:257)
>   at 
> org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:135)
>   at 
> 

September board report draft

[Robert Munteanu]

Hi,

Please find the draft board report below. I plan to submit it on Monday
evening, feedback welcome.

Thanks,

Robert

## Description:

Apache Sling™ is a framework for RESTful web-applications based on an
extensible content tree.

## Issues:

There are no issues requiring board attention at this time.
   
## Activity: 

Business continues as usual with individual module releases. We are
considering releasing Sling 11 in the near future with Java 11 and
preliminary Java 12 support.

The "Apache Sling and friends" conference - adaptTo - is taking place
in Potsdam, Germany on 10-12 september, and we welcome the opportunity
of meeting in person and having a Sling hackathon.

   
## Health report: 

Good activity level overall, contributions from different people
continue. We 
_think_ we see an increase in casual contributions after the move to
Github but
could not quantify this yet due to missing tooling for aggregating
stats across a large number of repositories.

## PMC changes: 
   
 - Currently 26 PMC members. 
 - New PMC members: 
- A. J. David Bosschaert was added to the PMC on Thu Jul 05 2018 
- Andrei Dulvac was added to the PMC on Mon Jul 30 2018 
- Georg Henzler was added to the PMC on Mon Jul 30 2018 
- Julian Sedding was added to the PMC on Mon Jul 30 2018 
- Nicolas Peltier was added to the PMC on Mon Jul 30 2018 
   
## Committer base changes: 
   
 - Currently 43 committers. 
 - No new committers added in the last 3 months 
 - Last committer addition was A. J. David Bosschaert at Fri Mar 09
2018 
   
## Releases: 
   
 - Apache Sling API 2.18.4 was released on Mon Aug 27 2018 
 - Apache Sling App CMS 0.9.0 was released on Wed Aug 01 2018 
 - Apache Sling Commons Threads 3.2.18 was released on Tue Jun 19 2018 
 - Apache Sling Content Distribution Core version 0.3.0 was released on
Mon 
   Aug 27 2018 
 - Apache Sling Context-Aware Configuration API 1.1.2, Context-Aware 
   Configuration SPI 1.3.4, Context-Aware Configuration Impl 1.4.14
was 
   released on Wed Sep 05 2018 
 - Apache Sling Discovery Oak 1.2.28 was released on Fri Aug 31 2018 
 - Apache Sling Dynamic Include 3.1.2 was released on Tue Aug 14 2018 
 - Apache Sling Engine 2.6.14 was released on Mon Aug 13 2018 
 - Apache Sling Event Support 4.2.12 was released on Mon Jul 23 2018 
 - Apache Sling Feature 0.1.2 was released on Thu Jun 21 2018 
 - Apache Sling Feature-Analyser 0.1.2 was released on Thu Jun 21 2018 
 - Apache Sling Feature-IO 0.1.2 was released on Thu Jun 21 2018 
 - Apache Sling Feature-ModelConverter 0.1.2 was released on Thu Jun 21
2018 
 - Apache Sling File Optimization 0.9.0 was released on Wed Aug 01
2018 
 - Apache Sling HTL Maven Plugin 1.1.8-1.4.0 was released on Tue Aug 07
2018 
 - Apache Sling JCR Content Loader 2.2.6 was released on Tue Jul 10
2018 
 - Apache Sling JCR Repository Registration 1.0.6 was released on Tue
Aug 14 
   2018 
 - Apache Sling JCR Resource Resolver 3.0.16 was released on Tue Aug 14
2018 
 - Apache Sling Maven Sling Plugin 2.3.8 was released on Fri Aug 17
2018 
 - Apache Sling Parent 34 was released on Thu Aug 09 2018 
 - Apache Sling Resource Builder 1.0.4, Testing JCR Mock 1.3.6, 
   ResourceResolver Mock 1.1.22, OSGi Mock 2.4.0, Sling Mock 2.3.0,
Sling Mock 
   Oak 2.1.0, Context-Aware Configuration Mock Plugin 1.3.2 was
released on Tue 
   Aug 21 2018 
 - Apache Sling Scripting HTL Java Compiler 1.0.26-1.4.0 was released
on Tue 
   Aug 07 2018 
 - Apache Sling Servlet Helpers 1.1.8, Testing JCR Mock 1.3.4, Testing
OSGi 
   Mock 2.3.10, Testing Sling Mock 2.2.20 was released on Mon Aug 06
2018 
 - Apache Sling Servlets Get 2.1.34 was released on Fri Aug 31 2018 
 - Apache Sling Slingstart Maven Plugin 1.8.2 was released on Thu Jun
21 2018 
 - Apache Sling Tenant 1.1.2 was released on Wed Sep 05 2018 
 - Apache Sling Testing JCR Mock 1.4.0, Sling Mock 2.3.2 was released
on Mon 
   Aug 27 2018 
 - Apache Sling Testing OSGi Mock 2.4.2, Sling Mock 2.3.4 was released
on 
   Mon Sep 03 2018 
 - Apache Sling XSS Protection 2.0.10 was released on Thu Jul 12 2018 
 - Apache Sling XSS Protection API 2.0.12 was released on Tue Aug 07
2018 
 - Apache Sling XSS Protection API 2.0.8 was released on Tue Jul 03
2018 
   
## JIRA activity: 
   
 - 174 JIRA tickets created in the last 3 months 
 - 169 JIRA tickets closed/resolved in the last 3 months 
   

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606879#comment-16606879
 ] 

Robert Munteanu commented on SLING-7890:


[~jebailey] - since you did most of the changes between 2.1.30 and 2.1.34 would 
you have time to do a first assessment of the problem? To reproduce, update the 
{{servlets.get}} bundle to the latest version in the starter and run the 
integration tests.

> JSON-related IT failures when upgrading sling.servlets to 2.1.34
> 
>
> Key: SLING-7890
> URL: https://issues.apache.org/jira/browse/SLING-7890
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.34
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Servlets Get 2.1.36
>
>
> With the following change in the sling starter
> {noformat}diff --git a/src/main/provisioning/sling.txt 
> b/src/main/provisioning/sling.txt
> index 0f76c0b..4904fc3 100644
> --- a/src/main/provisioning/sling.txt
> +++ b/src/main/provisioning/sling.txt
> @@ -62,7 +62,7 @@
>  org.apache.sling/org.apache.sling.resourceresolver/1.6.6
>  org.apache.sling/org.apache.sling.serviceusermapper/1.4.0
>  org.apache.sling/org.apache.sling.serviceuser.webconsole/1.0.0
> -org.apache.sling/org.apache.sling.servlets.get/2.1.30
> +org.apache.sling/org.apache.sling.servlets.get/2.1.34
>  org.apache.sling/org.apache.sling.servlets.post/2.3.26
>  org.apache.sling/org.apache.sling.servlets.resolver/2.4.22
>  org.apache.sling/org.apache.sling.xss/2.0.12
> {noformat}
> I get multiple IT failures, and the root cause seems top be
> {noformat}java.lang.ClassCastException: 
> org.apache.johnzon.core.JsonObjectImpl cannot be cast to javax.json.JsonArray
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.valueToString(JsonToText.java:164)
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.prettyPrint(JsonToText.java:209)
>   at 
> org.apache.sling.servlets.get.impl.VersionInfoServlet.doGet(VersionInfoServlet.java:124)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
>   at 
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
>   at 
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
>   at 
> org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:107)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.NoPropertyFilter.doFilter(NoPropertyFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.SlingFilter.doFilter(SlingFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.doProcessRequest(SlingRequestProcessorImpl.java:151)
>   at 
> org.apache.sling.engine.impl.SlingMainServlet.service(SlingMainServlet.java:234)
>   at 
> org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:120)
>   at 
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:86)
>   at 
> 

[jira] [Created] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

[Robert Munteanu (JIRA)]

Robert Munteanu created SLING-7890:
--

 Summary: JSON-related IT failures when upgrading sling.servlets to 
2.1.34
 Key: SLING-7890
 URL: https://issues.apache.org/jira/browse/SLING-7890
 Project: Sling
  Issue Type: Bug
  Components: Servlets
Affects Versions: Servlets Get 2.1.34
Reporter: Robert Munteanu
 Fix For: Servlets Get 2.1.36


With the following change in the sling starter

{noformat}diff --git a/src/main/provisioning/sling.txt 
b/src/main/provisioning/sling.txt
index 0f76c0b..4904fc3 100644
--- a/src/main/provisioning/sling.txt
+++ b/src/main/provisioning/sling.txt
@@ -62,7 +62,7 @@
 org.apache.sling/org.apache.sling.resourceresolver/1.6.6
 org.apache.sling/org.apache.sling.serviceusermapper/1.4.0
 org.apache.sling/org.apache.sling.serviceuser.webconsole/1.0.0
-org.apache.sling/org.apache.sling.servlets.get/2.1.30
+org.apache.sling/org.apache.sling.servlets.get/2.1.34
 org.apache.sling/org.apache.sling.servlets.post/2.3.26
 org.apache.sling/org.apache.sling.servlets.resolver/2.4.22
 org.apache.sling/org.apache.sling.xss/2.0.12
{noformat}

I get multiple IT failures, and the root cause seems top be

{noformat}java.lang.ClassCastException: org.apache.johnzon.core.JsonObjectImpl 
cannot be cast to javax.json.JsonArray
at 
org.apache.sling.servlets.get.impl.util.JsonToText.valueToString(JsonToText.java:164)
at 
org.apache.sling.servlets.get.impl.util.JsonToText.prettyPrint(JsonToText.java:209)
at 
org.apache.sling.servlets.get.impl.VersionInfoServlet.doGet(VersionInfoServlet.java:124)
at 
org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
at 
org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
at 
org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
at 
org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
at 
org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
at 
org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
at 
org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
at 
org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
at 
org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
at 
org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:107)
at 
org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
at 
org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
at 
org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
at 
org.apache.sling.launchpad.testservices.filters.NoPropertyFilter.doFilter(NoPropertyFilter.java:25)
at 
org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
at 
org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
at 
org.apache.sling.launchpad.testservices.filters.SlingFilter.doFilter(SlingFilter.java:25)
at 
org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131)
at 
org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
at 
org.apache.sling.engine.impl.SlingRequestProcessorImpl.doProcessRequest(SlingRequestProcessorImpl.java:151)
at 
org.apache.sling.engine.impl.SlingMainServlet.service(SlingMainServlet.java:234)
at 
org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:120)
at 
org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:86)
at 
org.apache.sling.junit.impl.servlet.TestLogServlet$TestNameLoggingFilter.doFilter(TestLogServlet.java:257)
at 
org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:135)
at 
org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:81)
at 
org.apache.felix.http.sslfilter.internal.SslFilter.doFilter(SslFilter.java:96)
at 
org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:135)
at 
org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:81)
at 

Re: [VOTE] Release Apache Sling Commons Log 5.1.10

[Robert Munteanu]

On Fri, 2018-09-07 at 10:52 +0200, Robert Munteanu wrote:
> Please vote to approve this release:

+1

Robert


signature.asc
Description: This is a digitally signed message part

[VOTE] Release Apache Sling Commons Log 5.1.10

[Robert Munteanu]

Hi,

We solved 1 issue in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12343349

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1958

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 1958 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Thanks,

Robert

[jira] [Resolved] (SLING-7884) Sanitize output of appender names

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-7884.

Resolution: Fixed

Fixed in [sling-org-apache-sling-commons-log commit 
8f46d53|https://github.com/apache/sling-org-apache-sling-commons-log/commit/8f46d53],
 thanks [~OSGDuff] for the PR

> Sanitize output of appender names
> -
>
> Key: SLING-7884
> URL: https://issues.apache.org/jira/browse/SLING-7884
> Project: Sling
>  Issue Type: Bug
>  Components: Commons
>Reporter: Devin Duffy
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Commons Log 5.1.10
>
>
> apache/sling-org-apache-sling-commons-log had an logging bug.  Created a PR 
> to address this:
>  
> [https://github.com/apache/sling-org-apache-sling-commons-log/pull/5/commits/f82aa61cc3c375b05663362ff861345fb2e0213e]
>  
> This ticket is for version tracking.  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] rombert closed pull request #5: removing logging bug from line 575 of SlingLogPanel.java

[GitBox]

rombert closed pull request #5: removing logging bug from line 575 of 
SlingLogPanel.java
URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/5
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/src/main/java/org/apache/sling/commons/log/logback/internal/SlingLogPanel.java
 
b/src/main/java/org/apache/sling/commons/log/logback/internal/SlingLogPanel.java
index df83601..ac0004b 100644
--- 
a/src/main/java/org/apache/sling/commons/log/logback/internal/SlingLogPanel.java
+++ 
b/src/main/java/org/apache/sling/commons/log/logback/internal/SlingLogPanel.java
@@ -572,7 +572,7 @@ private void renderAppenderContent(LoggerStateContext ctx, 
PrintWriter pw, Strin
 return;
 }
 }
-pw.printf("No appender with name [%s] found", appenderName);
+pw.printf("No appender with name [%s] found", 
XmlUtil.escapeXml(appenderName));
 }
 
 private String getLinkedName(FileAppender appender) throws 
UnsupportedEncodingException {


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rombert commented on issue #5: removing logging bug from line 575 of SlingLogPanel.java

[GitBox]

rombert commented on issue #5: removing logging bug from line 575 of 
SlingLogPanel.java
URL: 
https://github.com/apache/sling-org-apache-sling-commons-log/pull/5#issuecomment-419367094
 
 
   Tweaked commit message and manually applied in 8f46d53 . Thanks for your 
contribution @OSGDuff !


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Updated] (SLING-7884) Sanitize output of appender names

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-7884:
---
Summary: Sanitize output of appender names  (was: Sanitizer output of 
appender names)

> Sanitize output of appender names
> -
>
> Key: SLING-7884
> URL: https://issues.apache.org/jira/browse/SLING-7884
> Project: Sling
>  Issue Type: Bug
>  Components: Commons
>Reporter: Devin Duffy
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Commons Log 5.1.10
>
>
> apache/sling-org-apache-sling-commons-log had an logging bug.  Created a PR 
> to address this:
>  
> [https://github.com/apache/sling-org-apache-sling-commons-log/pull/5/commits/f82aa61cc3c375b05663362ff861345fb2e0213e]
>  
> This ticket is for version tracking.  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-7884) logging bug

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-7884:
---
Component/s: Commons

> logging bug
> ---
>
> Key: SLING-7884
> URL: https://issues.apache.org/jira/browse/SLING-7884
> Project: Sling
>  Issue Type: Bug
>  Components: Commons
>Reporter: Devin Duffy
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Commons Log 5.1.10
>
>
> apache/sling-org-apache-sling-commons-log had an logging bug.  Created a PR 
> to address this:
>  
> [https://github.com/apache/sling-org-apache-sling-commons-log/pull/5/commits/f82aa61cc3c375b05663362ff861345fb2e0213e]
>  
> This ticket is for version tracking.  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (SLING-7884) logging bug

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-7884:
--

Assignee: Robert Munteanu

> logging bug
> ---
>
> Key: SLING-7884
> URL: https://issues.apache.org/jira/browse/SLING-7884
> Project: Sling
>  Issue Type: Bug
>  Components: Commons
>Reporter: Devin Duffy
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Commons Log 5.1.10
>
>
> apache/sling-org-apache-sling-commons-log had an logging bug.  Created a PR 
> to address this:
>  
> [https://github.com/apache/sling-org-apache-sling-commons-log/pull/5/commits/f82aa61cc3c375b05663362ff861345fb2e0213e]
>  
> This ticket is for version tracking.  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-7884) Sanitizer output

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-7884:
---
Summary: Sanitizer output  (was: logging bug)

> Sanitizer output
> 
>
> Key: SLING-7884
> URL: https://issues.apache.org/jira/browse/SLING-7884
> Project: Sling
>  Issue Type: Bug
>  Components: Commons
>Reporter: Devin Duffy
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Commons Log 5.1.10
>
>
> apache/sling-org-apache-sling-commons-log had an logging bug.  Created a PR 
> to address this:
>  
> [https://github.com/apache/sling-org-apache-sling-commons-log/pull/5/commits/f82aa61cc3c375b05663362ff861345fb2e0213e]
>  
> This ticket is for version tracking.  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-7884) Sanitizer output of appender names

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-7884:
---
Summary: Sanitizer output of appender names  (was: Sanitizer output)

> Sanitizer output of appender names
> --
>
> Key: SLING-7884
> URL: https://issues.apache.org/jira/browse/SLING-7884
> Project: Sling
>  Issue Type: Bug
>  Components: Commons
>Reporter: Devin Duffy
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Commons Log 5.1.10
>
>
> apache/sling-org-apache-sling-commons-log had an logging bug.  Created a PR 
> to address this:
>  
> [https://github.com/apache/sling-org-apache-sling-commons-log/pull/5/commits/f82aa61cc3c375b05663362ff861345fb2e0213e]
>  
> This ticket is for version tracking.  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-7884) logging bug

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-7884:
---
Fix Version/s: Commons Log 5.1.10

> logging bug
> ---
>
> Key: SLING-7884
> URL: https://issues.apache.org/jira/browse/SLING-7884
> Project: Sling
>  Issue Type: Bug
>  Components: Commons
>Reporter: Devin Duffy
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Commons Log 5.1.10
>
>
> apache/sling-org-apache-sling-commons-log had an logging bug.  Created a PR 
> to address this:
>  
> [https://github.com/apache/sling-org-apache-sling-commons-log/pull/5/commits/f82aa61cc3c375b05663362ff861345fb2e0213e]
>  
> This ticket is for version tracking.  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [VOTE] Release Apache Sling File Optimization version 0.9.2

[Robert Munteanu]

Hi Dan,

Using the annotations depends on what you intend to do with the bundle
and what you expect consumers of the bundle to do.

In the commit I see that only FileOptimizer is marked as a
@ConsumerType, which means that you expect consumers to typically
implement this interface, but not others exposed through the API.

If that's your intent, then the changes are fine.

Also a little hint, Github allows you to generate diffs without
whitespace by appending "?w=1" at the end of the URL, it's easier to
review this changeset like this

https://github.com/apache/sling-org-apache-sling-file-optimization/commit/b8abe02a3e4290743cb89a5f8a4a077ec884be69?w=1

Thanks,

Robert

On Thu, 2018-09-06 at 14:29 -0400, Daniel Klco wrote:
> Would someone mind taking a look at the last commit and ensure I'm
> using
> the Provider / Consumer Type annotations correctly?
> 
> 
https://github.com/apache/sling-org-apache-sling-file-optimization/commit/b8abe02a3e4290743cb89a5f8a4a077ec884be69
> 
> Thanks!
> 
> On Thu, Sep 6, 2018 at 11:59 AM Daniel Klco  wrote:
> 
> > Thanks for spotting this Jason. I'm going to cancel this release
> > and
> > resolve the issues.
> > 
> > Regards,
> > Dan
> > 
> > On Thu, Sep 6, 2018 at 11:17 AM Jason E Bailey 
> > wrote:
> > 
> > > Hey Dan,
> > > 
> > > Since the interfaces that are made available are meant to be
> > > provided by
> > > the bundle they should be annotated with the @ProviderType
> > > annotation.
> > > 
> > > Additionally, the default style for Sling is that spaces are used
> > > for
> > > indentations rather than tabs. Just an FYI.
> > > 
> > > - Jason
> > > 
> > > On Thu, Sep 6, 2018, at 11:06 AM, Daniel Klco wrote:
> > > > +1
> > > > 
> > > > On Thu, Sep 6, 2018 at 11:01 AM Daniel Klco 
> > > > wrote:
> > > > 
> > > > > Hi,
> > > > > 
> > > > > We solved 1 issues in this release:
> > > > > 
https://issues.apache.org/jira/projects/SLING/versions/12343855
> > > > > 
> > > > > Staging repository:
> > > > > 
> > > 
> > > 
https://repository.apache.org/content/repositories/orgapachesling-1957/
> > > > > 
> > > > > You can use this UNIX script to download the release and
> > > > > verify the
> > > > > signatures:
> > > > > 
> > > > > 
> > > 
> > > 
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> > > > > 
> > > > > Usage:
> > > > > sh check_staged_release.sh 1957 /tmp/sling-staging
> > > > > 
> > > > > Please vote to approve this release:
> > > > > 
> > > > >   [ ] +1 Approve the release
> > > > >   [ ]  0 Don't care
> > > > >   [ ] -1 Don't release, because ...
> > > > > 
> > > > > This majority vote is open for at least 72 hours.
> > > > > 

[jira] [Updated] (SLING-7157) metatype.properties file must not be in OSGI-INF/metatype

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz updated SLING-7157:

Description: 
According to the spec the metatype.properties file must not be inside the 
OSGI-INF/metatype directory. This is against the spec, so we should move it to 
OSGI-INF/l10n
We probably should also upgrade the maven-scr-plugin for this 1.25.0

I found the following files:
./bundles/auth/core/src/main/resources/OSGI-INF/metatype/metatype.properties
./bundles/auth/form/src/main/resources/OSGI-INF/metatype/metatype.properties
./bundles/commons/log/src/main/resources/OSGI-INF/metatype/metatype.properties
./bundles/commons/threads/src/main/resources/OSGI-INF/metatype/metatype.properties
./bundles/extensions/discovery/impl/src/main/resources/OSGI-INF/metatype/metatype.properties
./bundles/extensions/discovery/oak/src/main/resources/OSGI-INF/metatype/metatype.properties
./bundles/extensions/settings/src/main/resources/OSGI-INF/metatype/metatype.properties
./bundles/jcr/classloader/src/main/resources/OSGI-INF/metatype/metatype.properties
./bundles/jcr/davex/src/main/resources/OSGI-INF/metatype/metatype.properties
./bundles/jcr/registration/src/main/resources/OSGI-INF/metatype/metatype.properties
./bundles/jcr/webconsole/src/main/resources/OSGI-INF/metatype/metatype.properties
./bundles/jcr/webdav/src/main/resources/OSGI-INF/metatype/metatype.properties
./contrib/auth/org.apache.sling.auth.xing.login/src/main/resources/OSGI-INF/metatype/metatype.properties
./contrib/auth/org.apache.sling.auth.xing.oauth/src/main/resources/OSGI-INF/metatype/metatype.properties
./contrib/extensions/datasource/src/main/resources/OSGI-INF/metatype/metatype.properties
./contrib/extensions/mongodb/src/main/resources/OSGI-INF/metatype/metatype.properties
./contrib/extensions/slf4j-mdc/src/main/resources/OSGI-INF/metatype/metatype.properties
./contrib/extensions/startup-filter/src/main/resources/OSGI-INF/metatype/metatype.properties
./contrib/extensions/urlrewriter/src/main/resources/OSGI-INF/metatype/metatype.properties
./installer/providers/jcr/src/main/resources/OSGI-INF/metatype/metatype.properties
./samples/path-based-rtp/src/main/resources/OSGI-INF/metatype/metatype.properties
./samples/workspacepicker/src/main/resources/OSGI-INF/metatype/metatype.properties
./testing/junit/core/src/main/resources/OSGI-INF/metatype/metatype.properties
./testing/junit/healthcheck/src/main/resources/OSGI-INF/metatype/metatype.properties


|| Module || Status ||
|Auth Core| |
|Auth Form|(/)|
|Commons Log|(/)|
|Commons Threads|(/)|
|Discovery Impl| |
|Discovery Oak| |
|Settings|(/)|
|JCR ClassLoader| |
|JCR DavEx| |
|JCR Registration|(/)|
|JCR WebConsole| |
|JCR WebDav| |
|Auth XING Login| |
|Auth XING Oauth| |
|Datasource| |
|MongoDB Resource Provider| |
|SLF4J MDC Filter| |
|Startup Filter| |
|URL Rewriter| |
|Installer JCR Providers| |
|Samples Path-based RTP| |
|Samples Workspacepicker| |
|Testing JUnit Core| |
|Testing JUnit Healthcheck| |


  was:
According to the spec the metatype.properties file must not be inside the 
OSGI-INF/metatype directory. This is against the spec, so we should move it to 
OSGI-INF/l10n
We probably should also upgrade the maven-scr-plugin for this 1.25.0

I found the following files:
./bundles/auth/core/src/main/resources/OSGI-INF/metatype/metatype.properties
./bundles/auth/form/src/main/resources/OSGI-INF/metatype/metatype.properties
./bundles/commons/log/src/main/resources/OSGI-INF/metatype/metatype.properties
./bundles/commons/threads/src/main/resources/OSGI-INF/metatype/metatype.properties
./bundles/extensions/discovery/impl/src/main/resources/OSGI-INF/metatype/metatype.properties
./bundles/extensions/discovery/oak/src/main/resources/OSGI-INF/metatype/metatype.properties
./bundles/extensions/settings/src/main/resources/OSGI-INF/metatype/metatype.properties
./bundles/jcr/classloader/src/main/resources/OSGI-INF/metatype/metatype.properties
./bundles/jcr/davex/src/main/resources/OSGI-INF/metatype/metatype.properties
./bundles/jcr/registration/src/main/resources/OSGI-INF/metatype/metatype.properties
./bundles/jcr/webconsole/src/main/resources/OSGI-INF/metatype/metatype.properties
./bundles/jcr/webdav/src/main/resources/OSGI-INF/metatype/metatype.properties
./contrib/auth/org.apache.sling.auth.xing.login/src/main/resources/OSGI-INF/metatype/metatype.properties
./contrib/auth/org.apache.sling.auth.xing.oauth/src/main/resources/OSGI-INF/metatype/metatype.properties
./contrib/extensions/datasource/src/main/resources/OSGI-INF/metatype/metatype.properties
./contrib/extensions/mongodb/src/main/resources/OSGI-INF/metatype/metatype.properties
./contrib/extensions/slf4j-mdc/src/main/resources/OSGI-INF/metatype/metatype.properties
./contrib/extensions/startup-filter/src/main/resources/OSGI-INF/metatype/metatype.properties
./contrib/extensions/urlrewriter/src/main/resources/OSGI-INF/metatype/metatype.properties

[GitHub] npeltier commented on issue #5: SLING-7707 Create Executor Pipe

[GitBox]

npeltier commented on issue #5: SLING-7707 Create Executor Pipe
URL: 
https://github.com/apache/sling-org-apache-sling-pipes/pull/5#issuecomment-419352800
 
 
   and as discussed in private with you "Manifold" is better to get along with 
the pipe metaphor :-)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Resolved] (SLING-7889) Use bnd Maven plugins

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-7889.
-
Resolution: Done

> Use bnd Maven plugins
> -
>
> Key: SLING-7889
> URL: https://issues.apache.org/jira/browse/SLING-7889
> Project: Sling
>  Issue Type: Improvement
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Settings 1.3.10
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] npeltier commented on issue #5: SLING-7707 Create Executor Pipe

[GitBox]

npeltier commented on issue #5: SLING-7707 Create Executor Pipe
URL: 
https://github.com/apache/sling-org-apache-sling-pipes/pull/5#issuecomment-419350303
 
 
   thanks @spopescu ! if i have some time, i'll raise a PR against your changes 
with what i have in mind. May be for the tests, we could have IT + UT testing 1 
thread & output writer merge


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] npeltier commented on a change in pull request #5: SLING-7707 Create Executor Pipe

[GitBox]

npeltier commented on a change in pull request #5: SLING-7707 Create Executor 
Pipe
URL: 
https://github.com/apache/sling-org-apache-sling-pipes/pull/5#discussion_r215869613
 
 

 ##
 File path: src/main/java/org/apache/sling/pipes/internal/PipeBuilderImpl.java
 ##
 @@ -376,6 +377,17 @@ public Job runAsync(Map bindings) throws 
PersistenceException {
 return plumber.executeAsync(resolver, pipe.getResource().getPath(), 
bindings);
 }
 
+@Override
+public ExecutionResult runParallel(int numThreads) throws Exception {
+JsonWriter writer = new JsonWriter();
+writer.starts();
+Pipe pipe = this.build();
 
 Review comment:
   this looks strange, i wonder if we shouldn't make that call just change the 
main pipe from container to "threadedpipe"


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] npeltier commented on a change in pull request #5: SLING-7707 Create Executor Pipe

[GitBox]

npeltier commented on a change in pull request #5: SLING-7707 Create Executor 
Pipe
URL: 
https://github.com/apache/sling-org-apache-sling-pipes/pull/5#discussion_r215869202
 
 

 ##
 File path: src/main/java/org/apache/sling/pipes/PipeBuilder.java
 ##
 @@ -345,4 +345,11 @@
  * @throws PersistenceException in case something goes wrong in the job 
creation
  */
 Job runAsync(Map bindings) throws PersistenceException;
+
+/**
+ * run referenced pipes in parallel
+ * @param numThreads number of threads to use for running the contained 
pipes
+ * @return set of resource path, merged output of pipes execution (order 
is arbitrary)
+ */
+ExecutionResult runParallel(int numThreads) throws Exception;
 
 Review comment:
   i guess i would have prefer execute or something , calling that method with 
`1` thread is very legit and will be used (you just want a series of N pipes to 
be executed sequentially, with one call)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Created] (SLING-7889) Use bnd Maven plugins

[Oliver Lietz (JIRA)]

Oliver Lietz created SLING-7889:
---

 Summary: Use bnd Maven plugins
 Key: SLING-7889
 URL: https://issues.apache.org/jira/browse/SLING-7889
 Project: Sling
  Issue Type: Improvement
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Settings 1.3.10






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-7888) Provide ability for SDI to ignore all query params

[JIRA]

 [ 
https://issues.apache.org/jira/browse/SLING-7888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dawid Kłos updated SLING-7888:
--
Description: 
On our project we use directive /ignoreURLparams on dispatcher together with SSI
This leads to the issue that any request with GET parameter will be cached on 
dispatcher and as result SSI also cached even ignoring nocache selector, 
because of URL params setting on SSI. There are currently not possible add all 
GET parameters into ignore field - only specify all of them.

To avoid long-lasting request we should ignore all query params in SDI

  was:
In my current project request can take up to 7000ms and more. 

To avoid long-lasting request we should ignore all query params in SDI. This is 
already done in this pull request: 
[https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/1/files]


> Provide ability for SDI to ignore all query params
> --
>
> Key: SLING-7888
> URL: https://issues.apache.org/jira/browse/SLING-7888
> Project: Sling
>  Issue Type: Improvement
>Reporter: Dawid Kłos
>Priority: Major
>
> On our project we use directive /ignoreURLparams on dispatcher together with 
> SSI
> This leads to the issue that any request with GET parameter will be cached on 
> dispatcher and as result SSI also cached even ignoring nocache selector, 
> because of URL params setting on SSI. There are currently not possible add 
> all GET parameters into ignore field - only specify all of them.
> To avoid long-lasting request we should ignore all query params in SDI



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7888) Provide ability for SDI to ignore all query params

[JIRA]

Dawid Kłos created SLING-7888:
-

 Summary: Provide ability for SDI to ignore all query params
 Key: SLING-7888
 URL: https://issues.apache.org/jira/browse/SLING-7888
 Project: Sling
  Issue Type: Improvement
Reporter: Dawid Kłos


In my current project request can take up to 7000ms and more. 

To avoid long-lasting request we should ignore all query params in SDI. This is 
already done in this pull request: 
[https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/1/files]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)