[jira] [Commented] (SLING-4075) Improve test coverage of SCD

[Oliver Lietz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887386#comment-16887386
 ] 

Oliver Lietz commented on SLING-4075:
-

You can also drop the {{getAgent(...)}} method and rely on {{@Inject}} with 
filter (see Scripting FreeMarker module for examples).

> Improve test coverage of SCD
> 
>
> Key: SLING-4075
> URL: https://issues.apache.org/jira/browse/SLING-4075
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Reporter: Tommaso Teofili
>Assignee: Timothee Maret
>Priority: Major
>
> Currently we moved lots of testing to the IT module but it'd be good to have 
> a better test coverage via unit testing in core module, at least to test 
> basic use cases and maybe some edge cases.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (SLING-4075) Improve test coverage of SCD

[Oliver Lietz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887380#comment-16887380
 ] 

Oliver Lietz commented on SLING-4075:
-

You usually don't have to specify a version as the test just picks the current 
build artifact as an additional bundle/option.
 With the current approach there is a slight chance to not test the current 
build artifact (it has to be installed and read from local Maven repo!).
 To be back on the safe side you can reassemble the {{slingDistribution}} 
option in the test and leave core bundle out or remove the core bundle easily 
from {{slingDistribution}} via {{ModifiableCompositeOption}} (available since 
PaxExam Testing 3.0).
 Example 
[ContentloaderTestSupport|https://github.com/apache/sling-org-apache-sling-jcr-contentloader/blob/master/src/test/java/org/apache/sling/jcr/contentloader/it/ContentloaderTestSupport.java]:
{noformat}
[...]
final Option contentloader = 
mavenBundle().groupId("org.apache.sling").artifactId("org.apache.sling.jcr.contentloader").version(SlingOptions.versionResolver.getVersion("org.apache.sling",
 "org.apache.sling.jcr.contentloader"));
final ModifiableCompositeOption quickstart = 
quickstart().remove(contentloader);
[...]
{noformat}
 

> Improve test coverage of SCD
> 
>
> Key: SLING-4075
> URL: https://issues.apache.org/jira/browse/SLING-4075
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Reporter: Tommaso Teofili
>Assignee: Timothee Maret
>Priority: Major
>
> Currently we moved lots of testing to the IT module but it'd be good to have 
> a better test coverage via unit testing in core module, at least to test 
> basic use cases and maybe some edge cases.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Updated] (SLING-8585) The acl page in Sling displays Apache License header

[Henry Saginor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Henry Saginor updated SLING-8585:
-
Description: 
Start Sling and go to [http://localhost:8080/content.acl.html]

Note Apache License comment rendered at the top of the page.

PR with a fix: 
[https://github.com/apache/sling-org-apache-sling-starter-content/pull/2]

  was:
Start Sling and go to [http://localhost:8080/content.acl.html]

Note Apache License comment rendered at the top of the page.

PR to fix this 
https://github.com/apache/sling-org-apache-sling-starter-content/pull/2


> The acl page in Sling displays Apache License header
> 
>
> Key: SLING-8585
> URL: https://issues.apache.org/jira/browse/SLING-8585
> Project: Sling
>  Issue Type: Bug
>Reporter: Henry Saginor
>Priority: Minor
>
> Start Sling and go to [http://localhost:8080/content.acl.html]
> Note Apache License comment rendered at the top of the page.
> PR with a fix: 
> [https://github.com/apache/sling-org-apache-sling-starter-content/pull/2]



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (SLING-4075) Improve test coverage of SCD

[Timothee Maret (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887348#comment-16887348
 ] 

Timothee Maret commented on SLING-4075:
---

[~olli] the change is meant to avoid having to specify the version of the 
tested bundle, reusing the version already specified in the pom. When we 
specify the version via a property, we always have to update the test execution 
which is error prone and arguably the flexibility is also not very useful. If 
it'd be useful for you, we could revisit this change and/or better integrate 
with SlingOptions (maybe there's a way to override if needed).

> Improve test coverage of SCD
> 
>
> Key: SLING-4075
> URL: https://issues.apache.org/jira/browse/SLING-4075
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Reporter: Tommaso Teofili
>Assignee: Timothee Maret
>Priority: Major
>
> Currently we moved lots of testing to the IT module but it'd be good to have 
> a better test coverage via unit testing in core module, at least to test 
> basic use cases and maybe some edge cases.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Updated] (SLING-8585) The acl page in Sling displays Apache License header

[Henry Saginor (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Henry Saginor updated SLING-8585:
-
Description: 
Start Sling and go to [http://localhost:8080/content.acl.html]

Note Apache License comment rendered at the top of the page.

PR to fix this 
https://github.com/apache/sling-org-apache-sling-starter-content/pull/2

  was:
Start Sling and go to [http://localhost:8080/content.acl.html]

Note Apache License comment rendered at the top of the page.


> The acl page in Sling displays Apache License header
> 
>
> Key: SLING-8585
> URL: https://issues.apache.org/jira/browse/SLING-8585
> Project: Sling
>  Issue Type: Bug
>Reporter: Henry Saginor
>Priority: Minor
>
> Start Sling and go to [http://localhost:8080/content.acl.html]
> Note Apache License comment rendered at the top of the page.
> PR to fix this 
> https://github.com/apache/sling-org-apache-sling-starter-content/pull/2



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [sling-org-apache-sling-starter-content] hsaginor opened a new pull request #2: Comment out license header corretly.

[GitBox]

hsaginor opened a new pull request #2: Comment out license header corretly.
URL: https://github.com/apache/sling-org-apache-sling-starter-content/pull/2
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (SLING-4075) Improve test coverage of SCD

[Oliver Lietz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887333#comment-16887333
 ] 

Oliver Lietz commented on SLING-4075:
-

[~marett], Why do you need to run integration tests without specifying system 
properties 
([c122d2b|https://github.com/apache/sling-org-apache-sling-distribution-core/commit/c122d2b901d78d532f5628cd29a7f8cf48e0ddcc])?

> Improve test coverage of SCD
> 
>
> Key: SLING-4075
> URL: https://issues.apache.org/jira/browse/SLING-4075
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Reporter: Tommaso Teofili
>Assignee: Timothee Maret
>Priority: Major
>
> Currently we moved lots of testing to the IT module but it'd be good to have 
> a better test coverage via unit testing in core module, at least to test 
> basic use cases and maybe some edge cases.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Created] (SLING-8585) The acl page in Sling displays Apache License header

[Henry Saginor (JIRA)]

Henry Saginor created SLING-8585:


 Summary: The acl page in Sling displays Apache License header
 Key: SLING-8585
 URL: https://issues.apache.org/jira/browse/SLING-8585
 Project: Sling
  Issue Type: Bug
Reporter: Henry Saginor


Start Sling and go to [http://localhost:8080/content.acl.html]

Note Apache License comment rendered at the top of the page.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Re: [org.apache.sling.jcr.contentparser] can we decouple it from JCR?

[Radu Cotescu]

Hi Jason,

> On 17 Jul 2019, at 15:16, Jason E Bailey  wrote:
> 
> My opinion - I'd prefer a greater decoupling of the API and implementations. 
> We should be able to design this in such a way that the addition of a new 
> format for parsing content doesn't necessitate a release of the API. To that 
> end, I think the ParserOptions should not be a final class but encompass the 
> generic options available to all content parsers and then have extended 
> classes in the other packages that reflect the ParserOptions for that package.
> 
> So there'd be a JsonParserOptions which extends ParserOptions and contains 
> json specific options.
> 
> So for me to implement a YamlContentParser I should just be able to implement 
> the appropriate classes and install an implementation package.
> 
> That would also mean moving implementation specific files to their respective 
> packages as well, like the JsonParserFeatures
> 
> --
> Jason
> 

Duly noted. I’ll try to implement these changes tomorrow.

Cheers,
Radu

Updated sling.txt PM for WebConsoleSecurityProvider

[Andreas Schaefer]

Hi

I just updated the sling.txt PM file inside the sling-org-apache-sling-starter 
project to move the WebConsoleSecurityProvider from 1.2.0 to 1.2.2 to remove 
the dependency on the Sling Lauchpad Starter Api (issue with starting Sling as 
feature model with it).

Let me know if that is a problem.

Cheers - Andy Schaefer

[GitHub] [sling-org-apache-sling-feature-cpconverter] schaefa opened a new pull request #12: Added an optional prefix to the conversion output file name to separa…

[GitBox]

schaefa opened a new pull request #12: Added an optional prefix to the 
conversion output file name to separa…
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/12
 
 
   …te them from other FM files


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Issue with Sling Feature Maven Plugin

[Andreas Schaefer]

Hi

I committed my changes to sling-slingfeature-maven-plugin branch: 
merge-cpconverter-plugin.

With these changes I was able to convert Sling Starter Provisioning and 
Headwire’s Peregrine Content Packages into a feature launcher system in one 
maven built step (mvn clean install) and launch it successfully.
There are still a few things I need to iron out but this is a good starting 
point I think.

Cheers - Andy Schaefer

> On Jul 16, 2019, at 4:36 PM, Andreas Schaefer  
> wrote:
> 
> Hi
> 
> I found a solution by moving the code into the Mojos. The entire code is now 
> here:
> 
> AbstractFeatureMojo.prepareProject()
> 
> And all Mojos interested can call them at the beginning of the execute() 
> method.
> 
> This way my Mojo can work w/o any features present and w/o having issues 
> during the different phases and goals.
> 
> Let me know if that is an acceptable solution.
> 
> Cheers - Andy Schaefer
> 
>> On Jul 16, 2019, at 7:50 AM, Andreas Schaefer  
>> wrote:
>> 
>> Hi Simone
>> 
>> I ran into a snafu with the Sling Feature Maven Plugin. This plugin is doing 
>> a blank check during the initialization phase which is causing headaches for 
>> the CP Converter goal.
>> 
>> There are various issues but the most glaring is the fact that when I use 
>> placeholders in the FM id like "${project.groupId}” then it will fail to 
>> even clean the project with ‘mvn clean’ or when there is no feature at all.
>> 
>> Can we either disable these tests or move them in the respective Mojos 
>> (phase) ?
>> 
>> Cheers - Andy Schaefer
> 

Re: [org.apache.sling.jcr.contentparser] can we decouple it from JCR?

[Jason E Bailey]

My opinion - I'd prefer a greater decoupling of the API and implementations. We 
should be able to design this in such a way that the addition of a new format 
for parsing content doesn't necessitate a release of the API. To that end, I 
think the ParserOptions should not be a final class but encompass the generic 
options available to all content parsers and then have extended classes in the 
other packages that reflect the ParserOptions for that package.

So there'd be a JsonParserOptions which extends ParserOptions and contains json 
specific options.

So for me to implement a YamlContentParser I should just be able to implement 
the appropriate classes and install an implementation package.

That would also mean moving implementation specific files to their respective 
packages as well, like the JsonParserFeatures

--
Jason

On Wed, Jul 17, 2019, at 4:02 AM, Radu Cotescu wrote:
> https://github.com/apache/sling-whiteboard/tree/master/contentparser/org-apache-sling-contentparser-api
> 
> > On 16 Jul 2019, at 16:41, Radu Cotescu  wrote:
> > 
> > Sure, I’ll prepare a README.md file for each module.
> 
>

Re: nodejs based sling packager

[Ruben Reusser]

Konrad,

since the tool packages and deploys it is dependent Jackrabbit-Vault for 
the package format and on Apache Sling and Composum for the 
upload/install/list/uninstall/delete endpoint. I'd honestly much prefer 
for it to be an Apache Sling module.


Ruben

On 7/17/2019 12:39 AM, Konrad Windszus wrote:

Hi Ruben,
very nice, but wouldn't it make more sense to contribute that to Apache Jackrabbit 
(next to the https://github.com/apache/jackrabbit-filevault-package-maven-plugin 
) rather 
than to Sling?
AFAICS there is no dependency to Sling bundles but only to JCR...

WDYT?
Thanks,
Konrad


On 14. Jul 2019, at 17:44, Ruben Reusser  wrote:

Dear Sling Developers,

in an effort to help 'front end developers' embrace Apache Sling and in order 
to make simple front-end Sling projects maven independent we created a node 
only slingpackager [1] and a sample VueJs based Slnig Content Browser [2] as a 
showcase project.

We'd like to see the slingpackager (and potentially the showcase example) be 
part of Apache Sling and maybe live on npmjs in an Apache Sling organization 
(@apachesling for example).

We'd love to hear what you think about this!

Ruben Reusser

[1] https://github.com/peregrine-cms/slingpackager
[2] https://github.com/peregrine-cms/simple-sling-vue-example

Re: [org.apache.sling.jcr.contentparser] can we decouple it from JCR?

[Radu Cotescu]

https://github.com/apache/sling-whiteboard/tree/master/contentparser/org-apache-sling-contentparser-api

> On 16 Jul 2019, at 16:41, Radu Cotescu  wrote:
> 
> Sure, I’ll prepare a README.md file for each module.

Re: nodejs based sling packager

[Konrad Windszus]

Hi Ruben,
very nice, but wouldn't it make more sense to contribute that to Apache 
Jackrabbit (next to the 
https://github.com/apache/jackrabbit-filevault-package-maven-plugin 
) rather 
than to Sling?
AFAICS there is no dependency to Sling bundles but only to JCR...

WDYT?
Thanks,
Konrad

> On 14. Jul 2019, at 17:44, Ruben Reusser  wrote:
> 
> Dear Sling Developers,
> 
> in an effort to help 'front end developers' embrace Apache Sling and in order 
> to make simple front-end Sling projects maven independent we created a node 
> only slingpackager [1] and a sample VueJs based Slnig Content Browser [2] as 
> a showcase project.
> 
> We'd like to see the slingpackager (and potentially the showcase example) be 
> part of Apache Sling and maybe live on npmjs in an Apache Sling organization 
> (@apachesling for example).
> 
> We'd love to hear what you think about this!
> 
> Ruben Reusser
> 
> [1] https://github.com/peregrine-cms/slingpackager
> [2] https://github.com/peregrine-cms/simple-sling-vue-example
>