[jira] [Resolved] (SLING-8839) Sensible defaults for the default set of analysers
[ https://issues.apache.org/jira/browse/SLING-8839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-8839. - Resolution: Fixed I've changed the logic in rev 2974d3c to only include the checks for exports/imports and requirements/capabilities if no analyser is specified. It is possible to exclude these - if they are not wanted, and additional ones can be added > Sensible defaults for the default set of analysers > -- > > Key: SLING-8839 > URL: https://issues.apache.org/jira/browse/SLING-8839 > Project: Sling > Issue Type: Improvement > Components: Maven Plugins and Archetypes >Reporter: Robert Munteanu >Assignee: Carsten Ziegeler >Priority: Major > Fix For: slingfeature-maven-plugin 1.1.12 > > > The plugin should use a default set of analysers that are generally useful > and require no configuration. On top of that, it should be possible to add > new analysers. > For instance, the connect analyser and api regions analyser should probably > not be in the default set. > Also discussed on dev@sling - > https://lists.apache.org/thread.html/8ee6655000eedd249c3b920144a51fc65c800e000d7582aa839074a6@%3Cdev.sling.apache.org%3E -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-8841) Update to Sling Bundle Parent 35
Oliver Lietz created SLING-8841: --- Summary: Update to Sling Bundle Parent 35 Key: SLING-8841 URL: https://issues.apache.org/jira/browse/SLING-8841 Project: Sling Issue Type: Task Components: Commons Reporter: Oliver Lietz Assignee: Oliver Lietz Fix For: Commons Messaging Mail 1.0.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-8840) Update to Sling Bundle Parent 35
Oliver Lietz created SLING-8840: --- Summary: Update to Sling Bundle Parent 35 Key: SLING-8840 URL: https://issues.apache.org/jira/browse/SLING-8840 Project: Sling Issue Type: Task Components: Commons Reporter: Oliver Lietz Assignee: Oliver Lietz Fix For: Commons Messaging 1.0.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-8706) Injections for java.util.Optional<> should be automatic optional
[
https://issues.apache.org/jira/browse/SLING-8706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971748#comment-16971748
]
Evgeny Tugarev commented on SLING-8706:
---
I can have a look on implementing this, however I am slightly concerned that
_Optional_ class is not serializable. I think this will introduce an artificial
limitation and may be problematic in long run. Please correct me if I am wrong.
> Injections for java.util.Optional<> should be automatic optional
> -
>
> Key: SLING-8706
> URL: https://issues.apache.org/jira/browse/SLING-8706
> Project: Sling
> Issue Type: Improvement
> Components: Sling Models
>Reporter: Jörg Hoh
>Priority: Major
>
> The current approach to support optional injections requires to annotate the
> field with {{@Optional}} plus proper handling within the javacode (null
> checks etc), which can be forgotten.
> So instead of
> {code}
> @Inject @Optional
> String fieldname;
> {code}
> it should also be possible to use this
> {code}
> @Inject
> Optional fieldname;
> {code}
> with the very same semantic. But the developer is forced to deal with the
> case that the value is not present.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Re: [VOTE] Release Apache Sling Enngine version 2.6.22
On Tue, Nov 5, 2019 at 6:07 PM Bertrand Delacretaz wrote: > ...Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2151 .. The vote passes with +1 from Stefan Seifert, Karl Pauls, Nicolas Peltier and Dan Klco, thank you! I'll take care of the remaining steps. -Bertrand
[jira] [Assigned] (SLING-8839) Sensible defaults for the default set of analysers
[ https://issues.apache.org/jira/browse/SLING-8839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler reassigned SLING-8839: --- Assignee: Carsten Ziegeler > Sensible defaults for the default set of analysers > -- > > Key: SLING-8839 > URL: https://issues.apache.org/jira/browse/SLING-8839 > Project: Sling > Issue Type: Improvement > Components: Maven Plugins and Archetypes >Reporter: Robert Munteanu >Assignee: Carsten Ziegeler >Priority: Major > Fix For: slingfeature-maven-plugin 1.1.12 > > > The plugin should use a default set of analysers that are generally useful > and require no configuration. On top of that, it should be possible to add > new analysers. > For instance, the connect analyser and api regions analyser should probably > not be in the default set. > Also discussed on dev@sling - > https://lists.apache.org/thread.html/8ee6655000eedd249c3b920144a51fc65c800e000d7582aa839074a6@%3Cdev.sling.apache.org%3E -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: [feature] Analyser complains that 'Bundle contains classes in the default package'
On Mon, 2019-11-11 at 14:49 +0100, Carsten Ziegeler wrote: > Am 11.11.2019 um 11:51 schrieb Robert Munteanu: > > On Fri, 2019-11-08 at 14:18 +0100, Carsten Ziegeler wrote: > > > Hi > > > > > > it seems you run with all available checks. You should only run > > > api > > > region checks if you use api regions. We recently moved all > > > analysers > > > that use api regions to the regions extension. > > > > As a bit of context, I started to incrementally use the feature > > model > > tooling on a simple project. I did so without any sort of explicit > > configuration, as: > > > > 1. I don't like configurations :-) > > 2. I think the tooling should work out-of-the-box with sensible > > values, > > and allow customisation if needed. > > > > Would it be an option to separate the 'default' scans from the > > additional scans, like the API order one? > > > The api regions should be optional as they are in a separate module. > Unfortunately, as the api-jars mojo uses extensions as well, this > separate module gets pulled in automatically. > > I absolutely agree that we should work with good ootb configurations. > > So maybe we should configure the slingfeature maven plugin with a > good > set of basic analysers. If someone wants additional checks, they can > be > configured. > > > > The other check is done by the analyser for OSGi connect; I can't > > > recall > > > why this check was useful though. > > > > Ack, would be interesting to know. Maybe this one would also be a > > candidate for the non-default set of scanners? If the check is > > related > > to [1], maybe it's not useful for everyone right now. > > > Agreed > > So in summary, we should configure a good default set of analysers > and > provide a way to add analysers (and skip the default ones) Sound good to me. Filed a Jira issue so we don't forget about this: https://issues.apache.org/jira/browse/SLING-8839 Thanks, Robert
[jira] [Created] (SLING-8839) Sensible defaults for the default set of analysers
Robert Munteanu created SLING-8839: -- Summary: Sensible defaults for the default set of analysers Key: SLING-8839 URL: https://issues.apache.org/jira/browse/SLING-8839 Project: Sling Issue Type: Improvement Components: Maven Plugins and Archetypes Reporter: Robert Munteanu Fix For: slingfeature-maven-plugin 1.1.12 The plugin should use a default set of analysers that are generally useful and require no configuration. On top of that, it should be possible to add new analysers. For instance, the connect analyser and api regions analyser should probably not be in the default set. Also discussed on dev@sling - https://lists.apache.org/thread.html/8ee6655000eedd249c3b920144a51fc65c800e000d7582aa839074a6@%3Cdev.sling.apache.org%3E -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-8837) Add extra verbose mode to startup options
[
https://issues.apache.org/jira/browse/SLING-8837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu resolved SLING-8837.
Resolution: Fixed
Fixed with
https://github.com/apache/sling-org-apache-sling-connection-timeout-agent/pull/4
> Add extra verbose mode to startup options
> -
>
> Key: SLING-8837
> URL: https://issues.apache.org/jira/browse/SLING-8837
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Connection Timeout Agent 1.0.2
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> It seems that sometimes the instrumentation does not work properly. We should
> have an extra verbose mode {{vv}} added to the agent so we can trace every
> time we are invoked to rewrite a class, even if we decide not to.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Re: [feature] Analyser complains that 'Bundle contains classes in the default package'
Am 11.11.2019 um 11:51 schrieb Robert Munteanu: On Fri, 2019-11-08 at 14:18 +0100, Carsten Ziegeler wrote: Hi it seems you run with all available checks. You should only run api region checks if you use api regions. We recently moved all analysers that use api regions to the regions extension. As a bit of context, I started to incrementally use the feature model tooling on a simple project. I did so without any sort of explicit configuration, as: 1. I don't like configurations :-) 2. I think the tooling should work out-of-the-box with sensible values, and allow customisation if needed. Would it be an option to separate the 'default' scans from the additional scans, like the API order one? The api regions should be optional as they are in a separate module. Unfortunately, as the api-jars mojo uses extensions as well, this separate module gets pulled in automatically. I absolutely agree that we should work with good ootb configurations. So maybe we should configure the slingfeature maven plugin with a good set of basic analysers. If someone wants additional checks, they can be configured. The other check is done by the analyser for OSGi connect; I can't recall why this check was useful though. Ack, would be interesting to know. Maybe this one would also be a candidate for the non-default set of scanners? If the check is related to [1], maybe it's not useful for everyone right now. Agreed So in summary, we should configure a good default set of analysers and provide a way to add analysers (and skip the default ones) Regards Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
[Jenkins] Sling » sling-org-apache-sling-launchpad-testing » master #391 is BROKEN
Please see
https://builds.apache.org/job/Sling/job/sling-org-apache-sling-launchpad-testing/job/master/391/
for details.
No further emails will be sent until the status of the build is changed.
Build log follows below:
Started by timer
Connecting to https://api.github.com using rombert/** (Personal access
token for Github repository access. Use with Apache Sling jobs only.)
Obtained Jenkinsfile from 3f5a0b1917f0281a20d859f3d001354be528e77f
Running in Durability level: MAX_SURVIVABILITY
Loading library sling@master
Examining apache/sling-tooling-jenkins
Attempting to resolve master as a branch
Resolved master as branch master at revision
9894be99cd9c28362536fae36ce29725786f4874
using credential sling-github-token
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url
> https://github.com/apache/sling-tooling-jenkins.git # timeout=10
Fetching without tags
Fetching upstream changes from
https://github.com/apache/sling-tooling-jenkins.git
> git --version # timeout=10
using GIT_ASKPASS to set credentials Personal access token for Github
repository access. Use with Apache Sling jobs only.
> git fetch --no-tags --progress
> https://github.com/apache/sling-tooling-jenkins.git
> +refs/heads/master:refs/remotes/origin/master
Checking out Revision 9894be99cd9c28362536fae36ce29725786f4874 (master)
> git config core.sparsecheckout # timeout=10
> git checkout -f 9894be99cd9c28362536fae36ce29725786f4874
Commit message: "corrected typo"
> git rev-list --no-walk 9894be99cd9c28362536fae36ce29725786f4874 # timeout=10
[Pipeline] Start of Pipeline
[Pipeline] node
Running on H31 in
/home/jenkins/jenkins-slave/workspace/e-sling-launchpad-testing_master
[Pipeline] {
[Pipeline] timeout
Timeout set to expire after 15 min without activity
[Pipeline] {
[Pipeline] stage
[Pipeline] { (Init)
[Pipeline] checkout
using credential sling-github-token
Fetching changes from the remote Git repository
Fetching without tags
> git rev-parse --is-inside-work-tree # timeout=10
> git config remote.origin.url
> https://github.com/apache/sling-org-apache-sling-launchpad-testing.git #
> timeout=10
Fetching upstream changes from
https://github.com/apache/sling-org-apache-sling-launchpad-testing.git
> git --version # timeout=10
using GIT_ASKPASS to set credentials Personal access token for Github
repository access. Use with Apache Sling jobs only.
> git fetch --no-tags --progress --
> https://github.com/apache/sling-org-apache-sling-launchpad-testing.git
> +refs/heads/master:refs/remotes/origin/master
Checking out Revision 3f5a0b1917f0281a20d859f3d001354be528e77f (master)
Commit message: "Java 13 is out, test with 13 instead of 12."
> git config core.sparsecheckout # timeout=10
> git checkout -f 3f5a0b1917f0281a20d859f3d001354be528e77f
> git rev-list --no-walk 3f5a0b1917f0281a20d859f3d001354be528e77f # timeout=10
[Pipeline] sh
+ git config remote.origin.url
[Pipeline] fileExists
[Pipeline] readJSON
[Pipeline] echo
Jenkins overrides: [jdks:[8, 11, 13], archivePatterns:[**/logs/*.log],
emailRecipients:[dev@sling.apache.org],
upstreamProjects:[../sling-org-apache-sling-starter/master,
../sling-org-apache-sling-launchpad-test-bundles/master]]
[Pipeline] echo
Final job config: [jdks:[8, 11, 13],
upstreamProjects:[../sling-org-apache-sling-starter/master,
../sling-org-apache-sling-launchpad-test-bundles/master],
archivePatterns:[**/logs/*.log], mavenGoal:, additionalMavenParams:,
rebuildFrequency:@weekly, enabled:true, emailRecipients:[dev@sling.apache.org],
repoName:sling-org-apache-sling-launchpad-testing]
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Configure Job)
[Pipeline] properties
[Pipeline] }
[Pipeline] // stage
[Pipeline] readMavenPom
[Pipeline] stage
[Pipeline] { (Build (Java 8, deploy))
[Pipeline] withMaven
[withMaven] Options:
[org.jenkinsci.plugins.pipeline.maven.publishers.GeneratedArtifactsPublisher[disabled=false],
JunitTestsPublisher[disabled=false,healthScaleFactor=,keepLongStdio=false,ignoreAttachments=false],
org.jenkinsci.plugins.pipeline.maven.publishers.TasksScannerPublisher[disabled='false',
healthy='', unHealthy='', thresholdLimit='low'],
org.jenkinsci.plugins.pipeline.maven.publishers.DependenciesFingerprintPublisher[disabled=false,
scopes=[compile, provided, runtime], versions={snapshot:true, release:false}]]
[withMaven] Available options:
[withMaven] using JDK installation JDK 1.8 (latest)
[withMaven] using Maven installation 'Maven (latest)'
[Pipeline] {
[Pipeline] sh
+ mvn -U clean deploy
- withMaven Wrapper script -
Picked up JAVA_TOOL_OPTIONS:
-Dmaven.ext.class.path="/home/jenkins/jenkins-slave/workspace/e-sling-launchpad-testing_master@tmp/withMaven1c84947a/pipeline-maven-spy.jar"
-Dorg.jenkinsci.plugins.pipeline.maven.reportsFolder="/home/jenkins/jenkins-slave/workspace/e-sling-launchpad-testing_master@tmp/withMaven1c84947a"
Error occurred during initialization
[GitHub] [sling-org-apache-sling-feature] bosschaert merged pull request #16: Use Integer.comapreTo() for Integer comparison
bosschaert merged pull request #16: Use Integer.comapreTo() for Integer comparison URL: https://github.com/apache/sling-org-apache-sling-feature/pull/16 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [sling-org-apache-sling-feature] bosschaert commented on issue #16: Use Integer.comapreTo() for Integer comparison
bosschaert commented on issue #16: Use Integer.comapreTo() for Integer comparison URL: https://github.com/apache/sling-org-apache-sling-feature/pull/16#issuecomment-552431869 Thanks @HarisAdzemovic - merged. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [sling-org-apache-sling-feature] HarisAdzemovic commented on issue #15: Strings and Boxed types should be compared using "equals()"
HarisAdzemovic commented on issue #15: Strings and Boxed types should be compared using "equals()" URL: https://github.com/apache/sling-org-apache-sling-feature/pull/15#issuecomment-552427412 Thanks @rombert, I've opened a new PR making use of `compareTo`: https://github.com/apache/sling-org-apache-sling-feature/pull/16 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (SLING-8838) Add HEAD support to ContentDispositionFilter
Ilyas Türkben created SLING-8838:
Summary: Add HEAD support to ContentDispositionFilter
Key: SLING-8838
URL: https://issues.apache.org/jira/browse/SLING-8838
Project: Sling
Issue Type: New Feature
Components: Extensions
Affects Versions: Security 1.1.10
Reporter: Ilyas Türkben
As per \(*) {{ContentDispositionFilter}} doesn't seem to support HEAD requests.
It is handy to use curl with {{curl -I http://localhost/path}} in order to
retrieve only the response headers rather than the whole content, especially
with blobs.
*
https://github.com/apache/sling-org-apache-sling-security/blob/master/src/main/java/org/apache/sling/security/impl/ContentDispositionFilter.java#L205
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [sling-org-apache-sling-feature] HarisAdzemovic opened a new pull request #16: Use Integer.comapreTo() for Integer comparison
HarisAdzemovic opened a new pull request #16: Use Integer.comapreTo() for Integer comparison URL: https://github.com/apache/sling-org-apache-sling-feature/pull/16 See discussion in previous PR: https://github.com/apache/sling-org-apache-sling-scripting-jsp/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (SLING-8837) Add extra verbose mode to startup options
Robert Munteanu created SLING-8837:
--
Summary: Add extra verbose mode to startup options
Key: SLING-8837
URL: https://issues.apache.org/jira/browse/SLING-8837
Project: Sling
Issue Type: Improvement
Components: Extensions
Reporter: Robert Munteanu
Assignee: Robert Munteanu
Fix For: Connection Timeout Agent 1.0.2
It seems that sometimes the instrumentation does not work properly. We should
have an extra verbose mode {{vv}} added to the agent so we can trace every time
we are invoked to rewrite a class, even if we decide not to.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Re: Publishing packages on npmjs.com
On Thu, 2019-10-24 at 12:04 +0200, Robert Munteanu wrote: > In https://issues.apache.org/jira/browse/SLING-8747 we are discussing > how to publish Sling packages on npmjs.com . Wrapping up - this is done and documented at https://cwiki.apache.org/confluence/display/SLING/Publishing+packages+on+npmjs.com Thanks, Robert
[jira] [Resolved] (SLING-8747) establish @apachesling npmjs organization
[ https://issues.apache.org/jira/browse/SLING-8747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-8747. Resolution: Fixed Done, see https://cwiki.apache.org/confluence/display/SLING/Publishing+packages+on+npmjs.com > establish @apachesling npmjs organization > - > > Key: SLING-8747 > URL: https://issues.apache.org/jira/browse/SLING-8747 > Project: Sling > Issue Type: Improvement > Components: CI >Reporter: Ruben Reusser >Assignee: Robert Munteanu >Priority: Major > > now that the donation for the slingpackager has been accepted we need to > create a common apachesling organization on npmjs and start setting up a > ci/cd flow to release the slingpackager > https://issues.apache.org/jira/browse/SLING-8584 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-commons-scheduler] rombert commented on issue #1: SLING-8764
rombert commented on issue #1: SLING-8764 URL: https://github.com/apache/sling-org-apache-sling-commons-scheduler/pull/1#issuecomment-552394316 Thanks @miroslav-beranic for sending a new version of the code for review. For the future it might be simpler to force-push to the same branch - GH will update the PR so you don't have to close the current PR and create a new one. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [sling-org-apache-sling-commons-scheduler] rombert commented on issue #2: SLING-8764 - A metric named commons.scheduler.oldest.running.job.millis already exists
rombert commented on issue #2: SLING-8764 - A metric named commons.scheduler.oldest.running.job.millis already exists URL: https://github.com/apache/sling-org-apache-sling-commons-scheduler/pull/2#issuecomment-552394024 LGTM, thanks @miroslav-beranic . @stefan-egli - WDYT? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: [feature] Analyser complains that 'Bundle contains classes in the default package'
On Fri, 2019-11-08 at 14:18 +0100, Carsten Ziegeler wrote: > Hi > > it seems you run with all available checks. You should only run api > region checks if you use api regions. We recently moved all > analysers > that use api regions to the regions extension. As a bit of context, I started to incrementally use the feature model tooling on a simple project. I did so without any sort of explicit configuration, as: 1. I don't like configurations :-) 2. I think the tooling should work out-of-the-box with sensible values, and allow customisation if needed. Would it be an option to separate the 'default' scans from the additional scans, like the API order one? > > The other check is done by the analyser for OSGi connect; I can't > recall > why this check was useful though. Ack, would be interesting to know. Maybe this one would also be a candidate for the non-default set of scanners? If the check is related to [1], maybe it's not useful for everyone right now. Thanks, Robert [1]: https://blog.osgi.org/2019/09/osgi-connect-revisited.html > > Regards > Carsten > > Am 08.11.2019 um 12:50 schrieb Robert Munteanu: > > Hi, > > > > I'm build an application using the feature model tooling. I enabled > > analysers and got shout at by the 'api-regions-check-order' checker > > since it required configuration. I don't use API regions, so I > > disabled > > that. > > > > Then I ran into a problem due to jackson jar having classes in the > > default package: > > > >Bundle contains classes in the default package: Artifact > > [id=com.fasterxml.jackson.core:jackson-core:2.10.0] > > > > I will disable this check as well, but I would like to understand > > why > > this is a problem. > > > > Thanks, > > Robert > >
[GitHub] [sling-org-apache-sling-scripting-esx] rombert merged pull request #1: Strings and Boxed types should be compared using "equals()"
rombert merged pull request #1: Strings and Boxed types should be compared using "equals()" URL: https://github.com/apache/sling-org-apache-sling-scripting-esx/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [sling-org-apache-sling-scripting-esx] rombert commented on issue #1: Strings and Boxed types should be compared using "equals()"
rombert commented on issue #1: Strings and Boxed types should be compared using "equals()" URL: https://github.com/apache/sling-org-apache-sling-scripting-esx/pull/1#issuecomment-552390768 Merged, thanks for your contribution @HarisAdzemovic This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [sling-org-apache-sling-feature] rombert commented on issue #15: Strings and Boxed types should be compared using "equals()"
rombert commented on issue #15: Strings and Boxed types should be compared using "equals()" URL: https://github.com/apache/sling-org-apache-sling-feature/pull/15#issuecomment-552389808 My reading of the code is that it's not null-safe anyway. It will fail at `o1 == 0` and `o2 == 0`. Incidentally, the original code was safe when comparing two nulls but fails now. I don't think that was intended though. I would suggest to use whichever you prefer of `Integer.compare` or `Integer.compareTo`, I don't think it makes a great difference. /cc @bosschaert This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: Sling FM Starter Module
Hi Andreas, On Fri, 2019-11-08 at 09:51 -0800, Andreas Schaefer wrote: > Hi > > I am wondering how a Sling FM Starter Module would look like and how > it is used by clients like Peregrine. > > It is my assumption that any FM slingosgifeature project will install > that file on release on a public Maven repository like all of our > Sling Module. > > Then the Sling FM Starter Module will select the appropriate > slingosgifeature files and assemble it into a Sling release > slingosgifeature which is then also installed on a public Maven repo. > This enables anyone to build the latest Sling instance w/o having any > other Sling Module checked out / built like right now it is done in > PM based Sling Starter. > > A customer will then do the same by taking the Sling slingosgifeature > file and assembly it with their own project and external projects > slingosgifeature files to build the final Sling / Customer instance. Overall that sounds reasonable to me. The only note that I want to make is that since we are doing releases at best once per year, downstream projects would either need to depend on SNAPSHOT versions of the Sling Starter, or depend on older versions. Thanks, Robert
Re: [VOTE] Release Apache Sling Feature Model API Regions Runtime Fragment 1.0.4
+1 regards, Karl On Mon, Nov 11, 2019 at 11:02 AM Carsten Ziegeler wrote: > > +1 > > Carsten > > Am 11.11.2019 um 10:42 schrieb Simone Tripodi: > > Hi, > > > > We solved 1 issue > > > > https://issues.apache.org/jira/browse/SLING-8815?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Feature%20Model%20API%20Regions%20Runtime%20Fragment%201.0.4%22 > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2153 > > > > You can use this UNIX script to download the release and verify the > > signatures: > > http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh > > > > Usage: > > sh check_staged_release.sh 2152 /tmp/sling-staging > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > Regards > > ~Simo > > > > http://people.apache.org/~simonetripodi/ > > http://twitter.com/simonetripodi > > > > -- > -- > Carsten Ziegeler > Adobe Research Switzerland > cziege...@apache.org -- Karl Pauls karlpa...@gmail.com
Re: [VOTE] Release Apache Sling Feature Model API Regions Runtime Fragment 1.0.4
+1 Carsten Am 11.11.2019 um 10:42 schrieb Simone Tripodi: Hi, We solved 1 issue https://issues.apache.org/jira/browse/SLING-8815?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Feature%20Model%20API%20Regions%20Runtime%20Fragment%201.0.4%22 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2153 You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 2152 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards ~Simo http://people.apache.org/~simonetripodi/ http://twitter.com/simonetripodi -- -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
Re: [VOTE] Release Apache Sling Feature Model API Regions Runtime Fragment 1.0.4
+1 David On Mon, 11 Nov 2019 at 09:43, Simone Tripodi wrote: > Hi, > > We solved 1 issue > > > https://issues.apache.org/jira/browse/SLING-8815?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Feature%20Model%20API%20Regions%20Runtime%20Fragment%201.0.4%22 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2153 > > You can use this UNIX script to download the release and verify the > signatures: > http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2152 /tmp/sling-staging > > Please vote to approve this release: > >[ ] +1 Approve the release >[ ] 0 Don't care >[ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > ~Simo > > http://people.apache.org/~simonetripodi/ > http://twitter.com/simonetripodi >
Re: [VOTE] Release Apache Sling Feature Model API Regions Runtime Fragment 1.0.4
My own non-binding +1 ~Simo http://people.apache.org/~simonetripodi/ http://twitter.com/simonetripodi On Mon, Nov 11, 2019 at 10:42 AM Simone Tripodi wrote: > > Hi, > > We solved 1 issue > > https://issues.apache.org/jira/browse/SLING-8815?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Feature%20Model%20API%20Regions%20Runtime%20Fragment%201.0.4%22 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2153 > > You can use this UNIX script to download the release and verify the > signatures: > http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2152 /tmp/sling-staging > > Please vote to approve this release: > >[ ] +1 Approve the release >[ ] 0 Don't care >[ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > ~Simo > > http://people.apache.org/~simonetripodi/ > http://twitter.com/simonetripodi
[VOTE] Release Apache Sling Feature Model API Regions Runtime Fragment 1.0.4
Hi, We solved 1 issue https://issues.apache.org/jira/browse/SLING-8815?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Feature%20Model%20API%20Regions%20Runtime%20Fragment%201.0.4%22 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2153 You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 2152 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards ~Simo http://people.apache.org/~simonetripodi/ http://twitter.com/simonetripodi
[jira] [Commented] (SLING-8743) Move DistributionQueueBuilderFactory class from impl to api surface
[
https://issues.apache.org/jira/browse/SLING-8743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971403#comment-16971403
]
Ashish Chopra commented on SLING-8743:
--
(responding on behalf of [~mohiaror] who's currently not available)
bq. does your use case require the DistributionQueueProcessor to be exposed?
I'd believe yes - because per my understanding _currently_
{{DistributionQueueProvider}} needs {{DistributionQueueProcessor}} [0],
unless...
bq. makes sense to expose a cleaned up version of ...
{{DistributionQueueProvider}}
...that cleanup itself erases the {{DistributionQueueProcessor}} from
{{DistributionQueueProvider}} SPI and accepts something else (perhaps a
{{Runnable}}/{{Callable}}?) in its stead.
[0]
https://github.com/apache/sling-org-apache-sling-distribution-core/blob/af3140fc5641c6c394b1bbc4dbd4013965e6/src/main/java/org/apache/sling/distribution/queue/impl/DistributionQueueProvider.java#L56
> Move DistributionQueueBuilderFactory class from impl to api surface
> ---
>
> Key: SLING-8743
> URL: https://issues.apache.org/jira/browse/SLING-8743
> Project: Sling
> Issue Type: Task
> Components: Content Distribution
>Reporter: Mohit Arora
>Priority: Major
>
> Currently, it is not possible to create an instance of DistributionQueue
> using DitributionQueueBuilderFactory as the factory is inside an impl package
> [0]. This should be exposed as an API so that consumers can get a reference
> of it.
>
> [0][https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/queue/impl/DistributionQueueProviderFactory.java]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
