[Jenkins] Sling » sling-org-apache-sling-starter » master #102 is FIXED

2020-01-17 Thread Apache Jenkins Server
Please see 
https://builds.apache.org/job/Sling/job/sling-org-apache-sling-starter/job/master/102/
 for details.

No further emails will be sent until the status of the build is changed.

[GitHub] [sling-org-apache-sling-commons-scheduler] sonarcloud[bot] commented on issue #3: Adding target name=sling for MetricRegistry referene

2020-01-17 Thread GitBox
sonarcloud[bot] commented on issue #3: Adding target name=sling for 
MetricRegistry referene
URL: 
https://github.com/apache/sling-org-apache-sling-commons-scheduler/pull/3#issuecomment-575874124
 
 
   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-scheduler&pullRequest=3&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-scheduler&pullRequest=3&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-scheduler&pullRequest=3&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-scheduler&pullRequest=3&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-scheduler&pullRequest=3&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-scheduler&pullRequest=3&resolved=false&types=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-scheduler&pullRequest=3&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-scheduler&pullRequest=3&resolved=false&types=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-scheduler&pullRequest=3&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-scheduler&pullRequest=3&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-commons-scheduler&pullRequest=3&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-scheduler&pullRequest=3&metric=coverage&view=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-scheduler&pullRequest=3&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-commons-scheduler&pullRequest=3&metric=new_duplicated_lines_density&view=list)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Release for Sling OSGi Installer bundles

2020-01-17 Thread Konrad Windszus
Hi,
does anything speak against releasing all OSGi installer bundles soon 
(including the first release of 
https://github.com/apache/sling-org-apache-sling-installer-factory-packages 
)?
My plan is to get the release vote till mid next week.

All bundles have their minimum supported Java version raised to 8.0 (due to 
dependencies only being provided for Java 8). Should I therefore increase the 
minor version instead of only the micro version?
Thanks,
Konrad



[jira] [Resolved] (SLING-9007) Base the region calculation on the feature-origin and add a feature-origin to apiregions during merge

2020-01-17 Thread Karl Pauls (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls resolved SLING-9007.
---
Resolution: Fixed

> Base the region calculation on the feature-origin and add a feature-origin to 
> apiregions during merge
> -
>
> Key: SLING-9007
> URL: https://issues.apache.org/jira/browse/SLING-9007
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Affects Versions: Feature Model API Regions Extension 1.1.0
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Feature Model API Regions Extension 1.1.2
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> We should take advantage of SLING-8998 and use the new feature-origins in the 
> api region checks and add something similar to region in the merge handler. 
> This hopefully allows to remove all the properties files.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [sling-org-apache-sling-feature-extension-apiregions] karlpauls merged pull request #4: SLING-9007: Add launcher spi that generates the property files.

2020-01-17 Thread GitBox
karlpauls merged pull request #4: SLING-9007: Add launcher spi that generates 
the property files.
URL: 
https://github.com/apache/sling-org-apache-sling-feature-extension-apiregions/pull/4
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (SLING-8963) Update to parent 36

2020-01-17 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-8963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-8963:
---
Description: Migrate to OSGi R7 annotations

> Update to parent 36
> ---
>
> Key: SLING-8963
> URL: https://issues.apache.org/jira/browse/SLING-8963
> Project: Sling
>  Issue Type: Improvement
>  Components: Installer
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: File Installer 1.1.2, Installer Packages Factory 1.0.0, 
> JCR Installer 3.1.28, Installer Core 3.9.2, Installer Configuration Factory 
> 1.2.6
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Migrate to OSGi R7 annotations



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (SLING-8963) Update to parent 36

2020-01-17 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-8963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-8963:
---
Fix Version/s: Installer Console 1.0.4

> Update to parent 36
> ---
>
> Key: SLING-8963
> URL: https://issues.apache.org/jira/browse/SLING-8963
> Project: Sling
>  Issue Type: Improvement
>  Components: Installer
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: File Installer 1.1.2, Installer Console 1.0.4, Installer 
> Packages Factory 1.0.0, JCR Installer 3.1.28, Installer Core 3.9.2, Installer 
> Configuration Factory 1.2.6
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Migrate to OSGi R7 annotations



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (SLING-8963) Update to parent 36

2020-01-17 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-8963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17018283#comment-17018283
 ] 

Konrad Windszus edited comment on SLING-8963 at 1/17/20 8:29 PM:
-

Fixed for JCR Installer: 
https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/commit/51780a1d5b0dbda0e053562ea5b21edbf25b4a5f
Fixed for File Installer: 
https://github.com/apache/sling-org-apache-sling-installer-provider-file/commit/938685c6aee750ad48a3ed94bd5d30dc3b787717
Fixed for Package Installer: 
https://github.com/apache/sling-org-apache-sling-installer-factory-packages/commit/66a098c1432672d67a65d29d1c7ccf8bbd7a2f83
Fixed for Configuration Installer: 
https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/commit/e5b5b56ebaa24ced61a84b69c849660703e936b1
Fixed for Installer Console: 
https://github.com/apache/sling-org-apache-sling-installer-console/commit/77e84bbe0a3fccff4a4b402265a0c255594a4f21


was (Author: kwin):
Fixed for JCR Installer: 
https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/commit/51780a1d5b0dbda0e053562ea5b21edbf25b4a5f
Fixed for File Installer: 
https://github.com/apache/sling-org-apache-sling-installer-provider-file/commit/938685c6aee750ad48a3ed94bd5d30dc3b787717
Fixed for Package Installer: 
https://github.com/apache/sling-org-apache-sling-installer-factory-packages/commit/66a098c1432672d67a65d29d1c7ccf8bbd7a2f83
Fixed for Configuration Installer: 
https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/commit/e5b5b56ebaa24ced61a84b69c849660703e936b1

> Update to parent 36
> ---
>
> Key: SLING-8963
> URL: https://issues.apache.org/jira/browse/SLING-8963
> Project: Sling
>  Issue Type: Improvement
>  Components: Installer
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: File Installer 1.1.2, Installer Packages Factory 1.0.0, 
> JCR Installer 3.1.28, Installer Core 3.9.2, Installer Configuration Factory 
> 1.2.6
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [sling-org-apache-sling-feature-extension-apiregions] karlpauls opened a new pull request #4: SLING-9007: Add launcher spi that generates the property files.

2020-01-17 Thread GitBox
karlpauls opened a new pull request #4: SLING-9007: Add launcher spi that 
generates the property files.
URL: 
https://github.com/apache/sling-org-apache-sling-feature-extension-apiregions/pull/4
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Comment Edited] (SLING-8963) Update to parent 36

2020-01-17 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-8963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17018283#comment-17018283
 ] 

Konrad Windszus edited comment on SLING-8963 at 1/17/20 8:27 PM:
-

Fixed for JCR Installer: 
https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/commit/51780a1d5b0dbda0e053562ea5b21edbf25b4a5f
Fixed for File Installer: 
https://github.com/apache/sling-org-apache-sling-installer-provider-file/commit/938685c6aee750ad48a3ed94bd5d30dc3b787717
Fixed for Package Installer: 
https://github.com/apache/sling-org-apache-sling-installer-factory-packages/commit/66a098c1432672d67a65d29d1c7ccf8bbd7a2f83
Fixed for Configuration Installer: 
https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/commit/e5b5b56ebaa24ced61a84b69c849660703e936b1


was (Author: kwin):
Fixed for JCR Installer: 
https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/commit/51780a1d5b0dbda0e053562ea5b21edbf25b4a5f
Fixed for File Installer: 
https://github.com/apache/sling-org-apache-sling-installer-provider-file/commit/938685c6aee750ad48a3ed94bd5d30dc3b787717
Fixed for Package Installer: 
https://github.com/apache/sling-org-apache-sling-installer-factory-packages/commit/66a098c1432672d67a65d29d1c7ccf8bbd7a2f83

> Update to parent 36
> ---
>
> Key: SLING-8963
> URL: https://issues.apache.org/jira/browse/SLING-8963
> Project: Sling
>  Issue Type: Improvement
>  Components: Installer
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: File Installer 1.1.2, Installer Packages Factory 1.0.0, 
> JCR Installer 3.1.28, Installer Core 3.9.2, Installer Configuration Factory 
> 1.2.6
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (SLING-8963) Update to parent 36

2020-01-17 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-8963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17018283#comment-17018283
 ] 

Konrad Windszus edited comment on SLING-8963 at 1/17/20 8:26 PM:
-

Fixed for JCR Installer: 
https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/commit/51780a1d5b0dbda0e053562ea5b21edbf25b4a5f
Fixed for File Installer: 
https://github.com/apache/sling-org-apache-sling-installer-provider-file/commit/938685c6aee750ad48a3ed94bd5d30dc3b787717
Fixed for Package Installer: 
https://github.com/apache/sling-org-apache-sling-installer-factory-packages/commit/66a098c1432672d67a65d29d1c7ccf8bbd7a2f83


was (Author: kwin):
Fixed for JCR Installer: 
https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/commit/51780a1d5b0dbda0e053562ea5b21edbf25b4a5f
Fixed for File Installer: 
https://github.com/apache/sling-org-apache-sling-installer-provider-file/commit/938685c6aee750ad48a3ed94bd5d30dc3b787717

> Update to parent 36
> ---
>
> Key: SLING-8963
> URL: https://issues.apache.org/jira/browse/SLING-8963
> Project: Sling
>  Issue Type: Improvement
>  Components: Installer
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: File Installer 1.1.2, Installer Packages Factory 1.0.0, 
> JCR Installer 3.1.28, Installer Core 3.9.2, Installer Configuration Factory 
> 1.2.6
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (SLING-8963) Update to parent 36

2020-01-17 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-8963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-8963:
---
Fix Version/s: Installer Packages Factory 1.0.0

> Update to parent 36
> ---
>
> Key: SLING-8963
> URL: https://issues.apache.org/jira/browse/SLING-8963
> Project: Sling
>  Issue Type: Improvement
>  Components: Installer
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: File Installer 1.1.2, Installer Packages Factory 1.0.0, 
> JCR Installer 3.1.28, Installer Core 3.9.2, Installer Configuration Factory 
> 1.2.6
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [sling-org-apache-sling-installer-provider-jcr] sonarcloud[bot] commented on issue #4: SLING-8963 update to parent 36

2020-01-17 Thread GitBox
sonarcloud[bot] commented on issue #4: SLING-8963 update to parent 36
URL: 
https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/pull/4#issuecomment-575781729
 
 
   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&resolved=false&types=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&resolved=false&types=CODE_SMELL)
 [8 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&metric=new_coverage&view=list)
 [0.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&metric=new_coverage&view=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&metric=new_duplicated_lines_density&view=list)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [sling-org-apache-sling-installer-provider-jcr] sonarcloud[bot] removed a comment on issue #4: SLING-8963 update to parent 36

2020-01-17 Thread GitBox
sonarcloud[bot] removed a comment on issue #4: SLING-8963 update to parent 36
URL: 
https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/pull/4#issuecomment-575661957
 
 
   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&resolved=false&types=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&resolved=false&types=CODE_SMELL)
 [8 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&metric=new_coverage&view=list)
 [0.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&metric=new_coverage&view=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&metric=new_duplicated_lines_density&view=list)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [sling-org-apache-sling-feature] karlpauls merged pull request #18: SLING-8998: Add feature-origins metadata entry to artifacts in featur…

2020-01-17 Thread GitBox
karlpauls merged pull request #18: SLING-8998: Add feature-origins metadata 
entry to artifacts in featur…
URL: https://github.com/apache/sling-org-apache-sling-feature/pull/18
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [sling-org-apache-sling-feature] karlpauls opened a new pull request #18: SLING-8998: Add feature-origins metadata entry to artifacts in featur…

2020-01-17 Thread GitBox
karlpauls opened a new pull request #18: SLING-8998: Add feature-origins 
metadata entry to artifacts in featur…
URL: https://github.com/apache/sling-org-apache-sling-feature/pull/18
 
 
   …es when merging


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Comment Edited] (SLING-8963) Update to parent 36

2020-01-17 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-8963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17018283#comment-17018283
 ] 

Konrad Windszus edited comment on SLING-8963 at 1/17/20 8:22 PM:
-

Fixed for JCR Installer: 
https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/commit/51780a1d5b0dbda0e053562ea5b21edbf25b4a5f
Fixed for File Installer: 
https://github.com/apache/sling-org-apache-sling-installer-provider-file/commit/938685c6aee750ad48a3ed94bd5d30dc3b787717


was (Author: kwin):
Fixed for JCR Installer: 
https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/commit/51780a1d5b0dbda0e053562ea5b21edbf25b4a5f

> Update to parent 36
> ---
>
> Key: SLING-8963
> URL: https://issues.apache.org/jira/browse/SLING-8963
> Project: Sling
>  Issue Type: Improvement
>  Components: Installer
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: File Installer 1.1.2, JCR Installer 3.1.28, Installer 
> Core 3.9.2, Installer Configuration Factory 1.2.6
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-8963) Update to parent 36

2020-01-17 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-8963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17018283#comment-17018283
 ] 

Konrad Windszus commented on SLING-8963:


Fixed for JCR Installer: 
https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/commit/51780a1d5b0dbda0e053562ea5b21edbf25b4a5f

> Update to parent 36
> ---
>
> Key: SLING-8963
> URL: https://issues.apache.org/jira/browse/SLING-8963
> Project: Sling
>  Issue Type: Improvement
>  Components: Installer
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: File Installer 1.1.2, JCR Installer 3.1.28, Installer 
> Core 3.9.2, Installer Configuration Factory 1.2.6
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [sling-org-apache-sling-installer-provider-jcr] kwin merged pull request #4: SLING-8963 update to parent 36

2020-01-17 Thread GitBox
kwin merged pull request #4: SLING-8963 update to parent 36
URL: 
https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/pull/4
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (SLING-8963) Update to parent 36

2020-01-17 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-8963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-8963:
---
Fix Version/s: Installer Configuration Factory 1.2.6

> Update to parent 36
> ---
>
> Key: SLING-8963
> URL: https://issues.apache.org/jira/browse/SLING-8963
> Project: Sling
>  Issue Type: Improvement
>  Components: Installer
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: File Installer 1.1.2, JCR Installer 3.1.28, Installer 
> Core 3.9.2, Installer Configuration Factory 1.2.6
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-7768) Add String Interpolation support to /etc/map

2020-01-17 Thread Andreas Schaefer (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17018277#comment-17018277
 ] 

Andreas Schaefer commented on SLING-7768:
-

So '$[]' does not work as node name so I guess we are back to '${}'.

Regarding the interpolation I am fine with that but I thought you did not want 
to support configuration files?

> Add String Interpolation support to /etc/map
> 
>
> Key: SLING-7768
> URL: https://issues.apache.org/jira/browse/SLING-7768
> Project: Sling
>  Issue Type: Improvement
>  Components: ResourceResolver
> Environment: Sling 11-SNAPSHOT, JDK 1.8
>Reporter: Andreas Schaefer
>Priority: Major
> Attachments: Screenshot 2018-07-06 11.41.58.png, Screenshot 
> 2018-07-06 11.42.41.png, Screenshot 2018-07-06 11.43.34.png
>
>
> Having worked on migrations of a Sling derivate Ruben & I ran into issues 
> where the /etc/map would map to production instead of testing environment.
>  Many big customer have extensive /etc/maps and also many different 
> environments like dev, qa, staging, prod etc.
>  It would be great to have a tool where for example items like the host name 
> or external links in /etc/map could be configured outside so that just one 
> entry has to adjusted rather than creating a full copy of the /etc/map tree.
>   
>  Example:
>   
>  /etc/map/http/phv.fq.host.name.8080
>   
>  Placeholder provides:
>  DEV: phv.fq.host.name=localhost
>  QA: phv.fq.host.name=qa.author.acme.com
>  STAGING: 
> phv.fq.host.name=[staging.author.acme.com|http://staging.author.acme.com/]
>  PROD: phv.fq.host.name=[acme.com|http://acme.com/]
>   
>  At runtime these are the resolved values:
>  DEV: http/localhost.8080
>  QA: http/qa.author.acme.com.8080
>  STAGING: http/[staging.author.acme.com|http://staging.author.acme.com/].8080
>  PROD: http/[acme.com|http://acme.com/].8080
>   
>  Not only does that make it easier and faster to create new test environments 
> but it also cuts down on the chance of copy-n-paste errors.
>   
>  I have a working POC with an PlaceholderProvider OSGi service and an 
> enhanced MapEntries that resolved any placeholders if found.
>   
>  Attached are 3 screenshots:
>  1. OSGi Placeholder Provider Configuration
>  2. /etc/map (Composum)
>  3. Result of [http://andreass.local:8080/] call



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-7768) Add String Interpolation support to /etc/map

2020-01-17 Thread Carsten Ziegeler (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17018222#comment-17018222
 ] 

Carsten Ziegeler commented on SLING-7768:
-

The Felix interpolation plugin is here:
https://github.com/apache/felix/tree/trunk/configadmin-plugins/interpolation/src/main/java/org/apache/felix/configadmin/plugin/interpolation

> Add String Interpolation support to /etc/map
> 
>
> Key: SLING-7768
> URL: https://issues.apache.org/jira/browse/SLING-7768
> Project: Sling
>  Issue Type: Improvement
>  Components: ResourceResolver
> Environment: Sling 11-SNAPSHOT, JDK 1.8
>Reporter: Andreas Schaefer
>Priority: Major
> Attachments: Screenshot 2018-07-06 11.41.58.png, Screenshot 
> 2018-07-06 11.42.41.png, Screenshot 2018-07-06 11.43.34.png
>
>
> Having worked on migrations of a Sling derivate Ruben & I ran into issues 
> where the /etc/map would map to production instead of testing environment.
>  Many big customer have extensive /etc/maps and also many different 
> environments like dev, qa, staging, prod etc.
>  It would be great to have a tool where for example items like the host name 
> or external links in /etc/map could be configured outside so that just one 
> entry has to adjusted rather than creating a full copy of the /etc/map tree.
>   
>  Example:
>   
>  /etc/map/http/phv.fq.host.name.8080
>   
>  Placeholder provides:
>  DEV: phv.fq.host.name=localhost
>  QA: phv.fq.host.name=qa.author.acme.com
>  STAGING: 
> phv.fq.host.name=[staging.author.acme.com|http://staging.author.acme.com/]
>  PROD: phv.fq.host.name=[acme.com|http://acme.com/]
>   
>  At runtime these are the resolved values:
>  DEV: http/localhost.8080
>  QA: http/qa.author.acme.com.8080
>  STAGING: http/[staging.author.acme.com|http://staging.author.acme.com/].8080
>  PROD: http/[acme.com|http://acme.com/].8080
>   
>  Not only does that make it easier and faster to create new test environments 
> but it also cuts down on the chance of copy-n-paste errors.
>   
>  I have a working POC with an PlaceholderProvider OSGi service and an 
> enhanced MapEntries that resolved any placeholders if found.
>   
>  Attached are 3 screenshots:
>  1. OSGi Placeholder Provider Configuration
>  2. /etc/map (Composum)
>  3. Result of [http://andreass.local:8080/] call



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Request for the Sling Feature Starter and Maven Plugin to become a Sling Module

2020-01-17 Thread Andreas Schaefer
Hi Betrand

Thanks for catching that. 

- Andy

> On Jan 17, 2020, at 8:34 AM, Bertrand Delacretaz  
> wrote:
> 
> Hi Andy,
> 
> On Fri, Jan 17, 2020 at 2:21 AM Andreas Schaefer
>  wrote:
>> ..I updated and tested both the **sling-org-apache-sling-feature-starter** 
>> which creates an executable JAR file and the 
>> **sling-slingstart-feature-maven-plugin**
>> which does start and stop a Sling instance so that they work like their PM 
>> peers...
> 
> Nice, and +1 to graduating those as non-whiteboard modules.
> 
> I fixed a circular dependency between those modules [1], hopefully
> that's ok (and if I missed something feel free to revert), it looked
> like a leftover.
> 
> -Bertrand
> 
> [1] 
> https://github.com/apache/sling-whiteboard/commit/24257a826c33bd48bac7414cb8c547c6077d380c



[VOTE] Promote sling-org-apache-sling-feature-starter / sling-slingstart-feature-maven-plugin to its own Sling Module

2020-01-17 Thread Andreas Schaefer
Hi

This is a vote to promote the sling-org-apache-sling-feature-starter and 
sling-slingstart-feature-maven-plugin to their own Sling Module. This first 
module is the Feature Model counterpart of the sling-org-apache-sling-starter 
and will create an executable JAR file. The second is the counterpart of the 
sling-slingstart-maven-plugin which will start and stop a Sling Instance from a 
Maven run and is mostly used to run Integration Tests.

Sling Feature Starter:

1. Code Location: both are in the ‘sling-whiteboard’ under 
'sling-org-apache-sling-feature-starter` folder
2. Proposed Github Repo name (I just added feature into the name):
- sling-org-apache-sling-feature-starter
3. Proposed artifact ids (group id: org.apache.sling)
- org.apache.sling.feature.starter

Sling Start Feature Maven Plugin:

1. Code Location: both are in the ‘sling-whiteboard’ under 
'sling-slingstart-feature-maven-plugin` folder
2. Proposed Github Repo names (I just added feature into the name):
- sling-slingstart-feature-maven-plugin
3. Proposed artifact ids (group id: org.apache.sling)
- slingstart-feature-maven-plugin

As requested by Carsten I created separate modules for the Feature 
counterparts. The modules work but the are not finished. The Sling Feature 
Starter is actually using the Sling Start Feature Maven Plugin to run the IT 
tests.

- Andy

Re: Request for the Sling Feature Starter and Maven Plugin to become a Sling Module

2020-01-17 Thread Bertrand Delacretaz
Hi Andy,

On Fri, Jan 17, 2020 at 2:21 AM Andreas Schaefer
 wrote:
> ..I updated and tested both the **sling-org-apache-sling-feature-starter** 
> which creates an executable JAR file and the 
> **sling-slingstart-feature-maven-plugin**
> which does start and stop a Sling instance so that they work like their PM 
> peers...

Nice, and +1 to graduating those as non-whiteboard modules.

I fixed a circular dependency between those modules [1], hopefully
that's ok (and if I missed something feel free to revert), it looked
like a leftover.

-Bertrand

[1] 
https://github.com/apache/sling-whiteboard/commit/24257a826c33bd48bac7414cb8c547c6077d380c


[jira] [Created] (SLING-9011) HTL: "automatic" context=uri on href/src seems to be wrong - Should be uri *and* html

2020-01-17 Thread Henry Kuijpers (Jira)
Henry Kuijpers created SLING-9011:
-

 Summary: HTL: "automatic" context=uri on href/src seems to be 
wrong - Should be uri *and* html
 Key: SLING-9011
 URL: https://issues.apache.org/jira/browse/SLING-9011
 Project: Sling
  Issue Type: New Feature
  Components: Scripting
Affects Versions: Scripting HTL Engine 1.3.2-1.4.0
Reporter: Henry Kuijpers


url=[http://test.com/?a=true&b=false&c=%3F|http://test.com/?a=true&b=false]

Test

I expect the href to be (when viewing page source):

[http://test.com/?a=true&b=false&c=%3F]

It however is:

[http://test.com/?a=true&b=false&c=%3F]

HTML requires attributes to also be encoded, so I believe we're not doing 
enough to do the proper encoding/escaping here.

WDYT?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [sling-org-apache-sling-feature-extension-apiregions] bosschaert commented on issue #2: SLING-8970 - adding test & fixing logic to consider inherited exports…

2020-01-17 Thread GitBox
bosschaert commented on issue #2: SLING-8970 - adding test & fixing logic to 
consider inherited exports…
URL: 
https://github.com/apache/sling-org-apache-sling-feature-extension-apiregions/pull/2#issuecomment-575667145
 
 
   @DominikSuess now there are merge conflicts...


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [sling-org-apache-sling-installer-provider-jcr] sonarcloud[bot] commented on issue #4: SLING-8963 update to parent 36

2020-01-17 Thread GitBox
sonarcloud[bot] commented on issue #4: SLING-8963 update to parent 36
URL: 
https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/pull/4#issuecomment-575661957
 
 
   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&resolved=false&types=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&resolved=false&types=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&resolved=false&types=CODE_SMELL)
 [8 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&metric=new_coverage&view=list)
 [0.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&metric=new_coverage&view=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-installer-provider-jcr&pullRequest=4&metric=new_duplicated_lines_density&view=list)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Re: Release JCR Package Init?

2020-01-17 Thread Andreas Schaefer
I am using it to launch Peregrine CMS as a FM which works like a charm.

The only issue is the loading of the extensions. Right now JCR Packageinit only 
works if loaded ahead of the Feature Launcher which works when loaded from CLI 
or through Maven dependencies but that might not work with the Starter JAR. But 
I guess we will tackle that when we are there.

- Andy

> On Jan 17, 2020, at 12:42 AM, Robert Munteanu  wrote:
> 
> Hi Andy,
> 
> On Thu, 2020-01-16 at 14:19 -0800, Andreas Schaefer wrote:
>> Hi
>> 
>> This email might got lost in all the Xmas celebration but for the CP
>> Converter and its Maven Plugin I would need to have this released
>> otherwise converted CP cannot be installed (AFAIK).
>> 
>> My offer to do the release still stands if you are too busy or focus
>> on other FM stuff.
> 
> If you're using it and it works for you, I see no reason to delay a
> release.
> 
> Thanks,
> Robert
> 
>> 
>> Cheers - Andy
>> 
>>> On Dec 20, 2019, at 11:39 AM, Andreas Schaefer <
>>> schaef...@me.com.INVALID> wrote:
>>> 
>>> Hi
>>> 
>>> I am trying to get the Sling Feature Converter Maven Plugin
>>> released and its hard dependency on CP Converter is now resolved.
>>> That said the Converter Maven Plugin is not very valuable if it
>>> cannot be installed in a FM system.
>>> 
>>> So I am wondering what the state of the JCR Package Init module is.
>>> I used it in a Peregrine CMS successfully after I made sure that
>>> this Extension is added ahead of the Launcher.
>>> 
>>> I don’t mind to do the release if you (Radu / Karl etc) are ok with
>>> it.
>>> 
>>> Cheers - Andy Schaefer
> 



[GitHub] [sling-org-apache-sling-installer-provider-jcr] kwin opened a new pull request #4: SLING-8963 update to parent 36

2020-01-17 Thread GitBox
kwin opened a new pull request #4: SLING-8963 update to parent 36
URL: 
https://github.com/apache/sling-org-apache-sling-installer-provider-jcr/pull/4
 
 
   @cziegeler I refactored slightly and only rely on DS now for service 
registration. Previously there was a service manually registered as 
`ManagedService`, but I didn't really see a benefit here. Now the service 
restarts in case of configuration changes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (SLING-8963) Update to parent 36

2020-01-17 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-8963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-8963:
---
Summary: Update to parent 36  (was: Update to parent 35)

> Update to parent 36
> ---
>
> Key: SLING-8963
> URL: https://issues.apache.org/jira/browse/SLING-8963
> Project: Sling
>  Issue Type: Improvement
>  Components: Installer
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: File Installer 1.1.2, JCR Installer 3.1.28, Installer 
> Core 3.9.2
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-7760) Sling Main Servlet - Change header configuration to a service

2020-01-17 Thread Jason E Bailey (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-7760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17018079#comment-17018079
 ] 

Jason E Bailey commented on SLING-7760:
---

This depends on why the response headers are set where they are currently set.

My initial attempt at this would be to to remove the setting of the headers 
from the initialization of SlingHttpServletResponseImpl and create a new method 
in RequestData called initHeaders(ResourceResolver) which I would call after 
calling initResource in the doProcessRequest step of SlingRequestProcessorImpl

I haven't worked with CA Configurations before so this is an educated guess.

 

> Sling Main Servlet - Change header configuration to a service
> -
>
> Key: SLING-7760
> URL: https://issues.apache.org/jira/browse/SLING-7760
> Project: Sling
>  Issue Type: Improvement
>Reporter: Jason E Bailey
>Assignee: Jason E Bailey
>Priority: Major
>
> The ability to set headers must be done prior to any writing that occurs the 
> output stream. This is the reason why the headers are set to be configured in 
> the Sling Main Servlet.
> With Sling being used to maintain multiple sites, having a single set of 
> response headers creates problems where the header provides a non tailored 
> response. One site may have a conflicting set of requirements then another 
> site.
> If the setting of headers was moved from being a configuration to being a 
> service used by the Main Servlet, this would allow the following:
>  * Headers set on a per site basis
>  * Headers based on selected resource
>  * Ability to modify the headers without causing the restart of the Sling 
> Main Servlet
>  ** Which if you're dealing with CSP headers can be a constant pain
>  * Ability to create a CSP configuration Service that eases the use of CSP 
> creation
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[Jenkins] Sling » sling-org-apache-sling-launchpad-testing » master #524 is BROKEN

2020-01-17 Thread Apache Jenkins Server
Please see 
https://builds.apache.org/job/Sling/job/sling-org-apache-sling-launchpad-testing/job/master/524/
 for details.

No further emails will be sent until the status of the build is changed.
Build log follows below:

Started by timer
Connecting to https://api.github.com using rombert/** (Personal access 
token for Github repository access. Use with Apache Sling jobs only.)
Obtained Jenkinsfile from 1b5445d7540c97f63ffac1c42fa5b920fa9b64f8
Running in Durability level: MAX_SURVIVABILITY
Loading library sling@master
Examining apache/sling-tooling-jenkins
Attempting to resolve master as a branch
Resolved master as branch master at revision 
9894be99cd9c28362536fae36ce29725786f4874
using credential sling-github-token
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url 
 > https://github.com/apache/sling-tooling-jenkins.git # timeout=10
Fetching without tags
Fetching upstream changes from 
https://github.com/apache/sling-tooling-jenkins.git
 > git --version # timeout=10
using GIT_ASKPASS to set credentials Personal access token for Github 
repository access. Use with Apache Sling jobs only.
 > git fetch --no-tags --progress 
 > https://github.com/apache/sling-tooling-jenkins.git 
 > +refs/heads/master:refs/remotes/origin/master
Checking out Revision 9894be99cd9c28362536fae36ce29725786f4874 (master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 9894be99cd9c28362536fae36ce29725786f4874
Commit message: "corrected typo"
 > git rev-list --no-walk 9894be99cd9c28362536fae36ce29725786f4874 # timeout=10
[Pipeline] Start of Pipeline
[Pipeline] node
Still waiting to schedule task
Waiting for next available executor on ‘ubuntu’
Running on H29 in 
/home/jenkins/jenkins-slave/workspace/e-sling-launchpad-testing_master
[Pipeline] {
[Pipeline] timeout
Timeout set to expire after 15 min without activity
[Pipeline] {
[Pipeline] stage
[Pipeline] { (Init)
[Pipeline] checkout
using credential sling-github-token
Fetching changes from the remote Git repository
Fetching without tags
 > git rev-parse --is-inside-work-tree # timeout=10
 > git config remote.origin.url 
 > https://github.com/apache/sling-org-apache-sling-launchpad-testing.git # 
 > timeout=10
Fetching upstream changes from 
https://github.com/apache/sling-org-apache-sling-launchpad-testing.git
 > git --version # timeout=10
using GIT_ASKPASS to set credentials Personal access token for Github 
repository access. Use with Apache Sling jobs only.
 > git fetch --no-tags --progress -- 
 > https://github.com/apache/sling-org-apache-sling-launchpad-testing.git 
 > +refs/heads/master:refs/remotes/origin/master
Checking out Revision 1b5445d7540c97f63ffac1c42fa5b920fa9b64f8 (master)
Commit message: "Some flakiness in builds, setup daily to observe"
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 1b5445d7540c97f63ffac1c42fa5b920fa9b64f8
 > git rev-list --no-walk 1b5445d7540c97f63ffac1c42fa5b920fa9b64f8 # timeout=10
[Pipeline] sh
+ git config remote.origin.url
[Pipeline] fileExists
[Pipeline] readJSON
[Pipeline] echo
Jenkins overrides: [rebuildFrequency:@daily, jdks:[8, 11, 13], 
archivePatterns:[**/logs/*.log], emailRecipients:[dev@sling.apache.org], 
upstreamProjects:[../sling-org-apache-sling-starter/master, 
../sling-org-apache-sling-launchpad-test-bundles/master]]
[Pipeline] echo
Final job config: [jdks:[8, 11, 13], 
upstreamProjects:[../sling-org-apache-sling-starter/master, 
../sling-org-apache-sling-launchpad-test-bundles/master], 
archivePatterns:[**/logs/*.log], mavenGoal:, additionalMavenParams:, 
rebuildFrequency:@daily, enabled:true, emailRecipients:[dev@sling.apache.org], 
repoName:sling-org-apache-sling-launchpad-testing]
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Configure Job)
[Pipeline] properties
[Pipeline] }
[Pipeline] // stage
[Pipeline] readMavenPom
[Pipeline] stage
[Pipeline] { (Build (Java 8, deploy))
[Pipeline] withMaven
[withMaven] Options: 
[org.jenkinsci.plugins.pipeline.maven.publishers.GeneratedArtifactsPublisher[disabled=false],
 
JunitTestsPublisher[disabled=false,healthScaleFactor=,keepLongStdio=false,ignoreAttachments=false],
 
org.jenkinsci.plugins.pipeline.maven.publishers.TasksScannerPublisher[disabled='false',
 healthy='', unHealthy='', thresholdLimit='low'], 
org.jenkinsci.plugins.pipeline.maven.publishers.DependenciesFingerprintPublisher[disabled=false,
 scopes=[compile, provided, runtime], versions={snapshot:true, release:false}]]
[withMaven] Available options: 
[withMaven] using JDK installation JDK 1.8 (latest)
[withMaven] using Maven installation 'Maven (latest)'
[Pipeline] {
[Pipeline] sh
+ mvn -U clean deploy
- withMaven Wrapper script -
/home/jenkins/tools/maven/latest/bin/mvn: 45: 
/home/jenkins/tools/maven/latest/bin/mvn: Cannot fork
[Pipeline] }
[Pipeline] // withMaven
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // timeout
[Pipeline] stage
[Pipeline] { (Notifications)

[GitHub] [sling-org-apache-sling-commons-scheduler] cziegeler commented on issue #3: Adding target name=sling for MetricRegistry referene

2020-01-17 Thread GitBox
cziegeler commented on issue #3: Adding target name=sling for MetricRegistry 
referene
URL: 
https://github.com/apache/sling-org-apache-sling-commons-scheduler/pull/3#issuecomment-575562851
 
 
   lgtm


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [sling-org-apache-sling-commons-scheduler] aman2604 opened a new pull request #3: Adding target name=sling for MetricRegistry referene

2020-01-17 Thread GitBox
aman2604 opened a new pull request #3: Adding target name=sling for 
MetricRegistry referene
URL: https://github.com/apache/sling-org-apache-sling-commons-scheduler/pull/3
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Re: [hackathon] externalization / resource mapping / rewriter

2020-01-17 Thread Georg Henzler
Hi Konrad, 

I think SLING-9005 is a good idea, but that is independent.

My idea idea was to leave resourceResolver.map() unchanged (as there is a lot 
of code using it out there, also it makes conceptually sense as is). Rather I‘d 
like to provide an SPI that allows to customize the way of the behavior of 
resourceResolver.map() - I‘m thinking of a ranked list of ResourceMapper 
services (default one being today’s behavior). Robert also has done some work 
into this direction already, I‘d like to extend on that.

I‘m currently on vacation but I have it on my list for when I‘m back.

-Georg 

> 
> On 16. Jan 2020, at 15:01, Konrad Windszus  wrote:
> 
> I would like to revive this. 
> 
> @Georg: IIRC you wanted to come up with a proposal for a externalizer API. 
> Are you working on this?
> Can we start by creating a JIRA ticket?
> 
> There has been a related ticket opened today: 
> https://issues.apache.org/jira/browse/SLING-9005 
> 
> 
> Konrad
> 
>> On 5. Sep 2019, at 17:54, Jason E Bailey  wrote:
>> 
>> Specifically with regard to the re-writer
>> 
>> I'm working on a replacement for this which I'm currently calling the 
>> transformer -> 
>> https://github.com/apache/sling-whiteboard/tree/master/transformer
>> 
>> 1. It uses an HTML tokenizer that was added to the HTML utilities to 
>> generate a stream of  elements that can be modified and recombined. It's 
>> much faster then tagsoup or jsoup since it's not trying to build a valid 
>> document. This also means that it supports anything that you write out in 
>> html. HTML4,5+
>> 
>> 2. It uses services with an ordering priority and does pattern matching so 
>> that you can fine tune when the transformer is applied
>> 
>> 3. The specific use case I was working on is creating a CSP header with a 
>> nonce or hash attribute to lock down the javascript that's on the page. 
>> 
>> It's currently working but it's not finished.
>> Are there other problems with the rewriter that I haven't addressed?
>> 
>> 
>> --
>> Jason
>> 
>>> On Thu, Sep 5, 2019, at 10:34 AM, Stefan Seifert wrote:
>>> 
>>> - resource mapping
>>> - add a new SPI to define the mapping
>>> - add a default impl that reads the mapping from /etc/map as it is 
>>> done today
>>> - possible to override with service ranking
>>> - but: there is already the ResourceMapper interface
>>>   - introduced 1-2 years ago, use case was to get all existing 
>>> mappings
>>>   - with this it's currently possible to replace mapping completely 
>>> with new logic
>>> - maybe add a support to "contribute" additional mappings via a 
>>> service interface additional to this
>>> 
>>> - generic externalizer API
>>> - naming not fixed yet, should not named "link" as this is too 
>>> specific. probably "URL".
>>> - needs a java API for using, and an SPI for hooking in special rules
>>> - then add mappings for views in HTL*, JSP, model exporter/JSON
>>>   * probably starting with a sling-only HTL extension for try-out, 
>>> add it later to the spec when design is validated
>>> - might be inspired by the basic features for wcm.io URL handler [1]
>>> 
>>> - rewriter pipeline
>>> - should be deprecated and no longer be used - especially not for 
>>> link externalization via postprocessing
>>> - it may still be in use out there for more exotic use cases like PDF 
>>> generation
>>> - should probably removed from sling starter
>>> 
>>> stefan
>>> 
>>> [1] https://wcm.io/handler/url/
>>> 
>>> 
>>> 
> 


[jira] [Resolved] (SLING-9008) Adjust seeding delay for high latency scenarios

2020-01-17 Thread Christian Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider resolved SLING-9008.

Resolution: Fixed

> Adjust seeding delay for high latency scenarios
> ---
>
> Key: SLING-9008
> URL: https://issues.apache.org/jira/browse/SLING-9008
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Affects Versions: Content Distribution Journal Core 0.1.6
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.8
>
>
> Our current delay for seeding the package topic is 1000ms. In case of high 
> latency cases like 400ms this could create unnecessary packages. So I propose 
> to double the delay to 2000ms. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (SLING-9009) Avoid committing for each skipped package

2020-01-17 Thread Christian Schneider (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider resolved SLING-9009.

Resolution: Fixed

> Avoid committing for each skipped package
> -
>
> Key: SLING-9009
> URL: https://issues.apache.org/jira/browse/SLING-9009
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Affects Versions: Content Distribution Journal Core 0.1.6
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.8
>
>
> We recently added committing offsets for skipped packages too. This improves 
> the behaviour when a new instance starts or restarts that does not yet have 
> recent distribution packages on the topic but has to chew through a lot of 
> packages that are meant for other instances.
> Unfortunately this new behaviour creates a lot of stress on the repository as 
> each such commit means a complete transaction. 
> So this issues is about going some middle road. Committing the offset for a 
> subset of the packages. This subset can be either defined by waiting a 
> certain time until the next commit or waiting for a certain number of skipped 
> packages until the next commit.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (SLING-9004) API Regions runtime should have a configured set of 'default' regions

2020-01-17 Thread A. J. David Bosschaert (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert resolved SLING-9004.
---
Resolution: Fixed

> API Regions runtime should have a configured set of 'default' regions
> -
>
> Key: SLING-9004
> URL: https://issues.apache.org/jira/browse/SLING-9004
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model
>Affects Versions: Feature Model API Regions Runtime Fragment 1.0.4
>Reporter: A. J. David Bosschaert
>Assignee: A. J. David Bosschaert
>Priority: Major
> Fix For: Feature Model API Regions Runtime Fragment 1.0.6
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Right now when a bundle is installed outside of a feature model, it ends up 
> not being in any feature at all, which means that it will not be able to see 
> any APIs exported via API Regions other than the {{global}} region. 
> We should have a mechanism to configure the API Regions runtime fragment to 
> have such bundles that are installed outside of a feature associated with one 
> or more API Regions. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Request for the Sling Feature Starter and Maven Plugin to become a Sling Module

2020-01-17 Thread Robert Munteanu
Hi Andy,


Glad to see these modules graduate out the incubator :-)

Can you please:

1. List the code locations of the two modules
2. Specify the proposed artifact ids/github repo names
3. Phrase this as a [VOTE]? I think it's fine for it to be lazy - don't
wait for 3 votes, but at least see that no one objects for 72 hours,
maybe longer since a weekend is coming up.

Thanks,
Robert

On Thu, 2020-01-16 at 17:21 -0800, Andreas Schaefer wrote:
> Hi
> 
> I updated and tested both the **sling-org-apache-sling-feature-
> starter** which creates an executable JAR file and the **sling-
> slingstart-feature-maven-plugin** which does start and stop a Sling
> instance so that they work like their PM peers.
> 
> That said the Sling Starter does only create an executable JAR file
> and the Slingstart Maven Plugin only supports start and stop.
> Additional Mojos and support for a Webapp can be added later but for
> now I wanted to be able to launch Sling FM based through a JAR file
> and test it in an IT test setting.
> In addition the Sling Feature Starter is using an externally created
> Sling FM file but that will change by either using dedicated FMs
> (something like the PMs of now) or including bundle artifacts. 
> 
> With that I would request to promote both from the Sling-Whiteboard
> into their own Sling Modules to further develop these two modules.
> 
> Cheers - Andy
> 



Re: Release JCR Package Init?

2020-01-17 Thread Robert Munteanu
Hi Andy,

On Thu, 2020-01-16 at 14:19 -0800, Andreas Schaefer wrote:
> Hi
> 
> This email might got lost in all the Xmas celebration but for the CP
> Converter and its Maven Plugin I would need to have this released
> otherwise converted CP cannot be installed (AFAIK).
> 
> My offer to do the release still stands if you are too busy or focus
> on other FM stuff.

If you're using it and it works for you, I see no reason to delay a
release.

Thanks,
Robert

> 
> Cheers - Andy
> 
> > On Dec 20, 2019, at 11:39 AM, Andreas Schaefer <
> > schaef...@me.com.INVALID> wrote:
> > 
> > Hi
> > 
> > I am trying to get the Sling Feature Converter Maven Plugin
> > released and its hard dependency on CP Converter is now resolved.
> > That said the Converter Maven Plugin is not very valuable if it
> > cannot be installed in a FM system.
> > 
> > So I am wondering what the state of the JCR Package Init module is.
> > I used it in a Peregrine CMS successfully after I made sure that
> > this Extension is added ahead of the Launcher.
> > 
> > I don’t mind to do the release if you (Radu / Karl etc) are ok with
> > it.
> > 
> > Cheers - Andy Schaefer



Re: Some jenkins builds (using pax exam) might fail because maven central now refuses http requests

2020-01-17 Thread Bertrand Delacretaz
Hi Christian,

On Thu, Jan 16, 2020 at 6:49 PM Christian Schneider
 wrote:
> ...I saw build failures in:
> https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-it/job/master/259/console
>  ..

Interestingly, the
https://builds.apache.org/job/Sling/job/sling-org-apache-sling-servlets-resolver/
build which also uses Pax Exam works fine, not sure what's different.
That's using pax exam 4.13.1 and o.a.s.testing.paxexam 3.1.0 while
your module uses 4.12.0 and 1.0.0, not sure if that's the difference.

> ...I worked around that by redefining the base configuration
> without adding the apache snapshot repo...

FWIW that's 
https://github.com/apache/sling-org-apache-sling-distribution-journal-it/commit/d14d72df5aa01d49d98613bd405f3d9abc0bf1a5

-Bertrand