[Jenkins] Sling » sling-org-apache-sling-launchpad-testing » master #777 is FIXED
Please see https://builds.apache.org/job/Sling/job/sling-org-apache-sling-launchpad-testing/job/master/777/ for details. No further emails will be sent until the status of the build is changed.
[jira] [Resolved] (SLING-9420) Create required configurations for o.a.s.installer.factory.packages
[ https://issues.apache.org/jira/browse/SLING-9420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-9420. Resolution: Fixed Fixed with https://github.com/apache/sling-org-apache-sling-starter/pull/7 > Create required configurations for o.a.s.installer.factory.packages > --- > > Key: SLING-9420 > URL: https://issues.apache.org/jira/browse/SLING-9420 > Project: Sling > Issue Type: Sub-task > Components: Starter >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > With SLNIG-6196 we have the bundle that can install content packages. > However, it still needs a user mapping to a service user with proper > privileges. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (SLING-6203) Create a Maven archetype for content packages
[ https://issues.apache.org/jira/browse/SLING-6203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-6203: -- Assignee: (was: Robert Munteanu) > Create a Maven archetype for content packages > - > > Key: SLING-6203 > URL: https://issues.apache.org/jira/browse/SLING-6203 > Project: Sling > Issue Type: Sub-task > Components: General >Reporter: Robert Munteanu >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-starter] rombert commented on a change in pull request #7: SLING-9420 - Create required configurations for o.a.s.installer.factory.packages
rombert commented on a change in pull request #7: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/7#discussion_r419748394 ## File path: src/main/provisioning/repoinit.txt ## @@ -71,6 +71,13 @@ allow rep:write on /apps/sling/install end +# content-package installer +create service user sling-package-install + +set ACL for sling-package-install +allow jcr:all on / Review comment: Ack, thanks. I'll leave that in then, as we should get a release of the installer.factory.packages bundle at some point. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-9421) Add Groovy Lang Support
[ https://issues.apache.org/jira/browse/SLING-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099367#comment-17099367 ] Dan Klco commented on SLING-9421: - Looks like Groovy 3 support is blocked until the version range in Composum is updated: https://github.com/ist-dresden/composum/pull/195 > Add Groovy Lang Support > --- > > Key: SLING-9421 > URL: https://issues.apache.org/jira/browse/SLING-9421 > Project: Sling > Issue Type: Improvement > Components: App CMS, Launchpad >Affects Versions: Starter 11, App CMS 0.16.2 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: Starter 12, App CMS 0.16.4 > > > Composum Nodes supports executing [Groovy > scripts|https://www.composum.com/home/nodes/browser.html], however, this > requires Groovy to be available in the classpath. > We should add Groovy support to the Sling Starter and App CMS to enable users > to execute Groovy scripts without having to install any additional > dependencies. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-whiteboard] cmrockwell commented on pull request #51: SAML2 Service Provider Pull Request
cmrockwell commented on pull request #51: URL: https://github.com/apache/sling-whiteboard/pull/51#issuecomment-623685394 Sound good. Thank you for merging this. I'll spend some time to analyze the build issue you identified and report back once I'm able to reproduce it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: Ianal Maven Plugin?
I had an issue where the plugin (because I used Sling Parent POM) and could not figure out what it needed. Then I realized that the plugin was outdated but guessed that when it set ’strict’ to false that it would let me process which it did. Anyhow I am concerned that eventually this plugin will fail and I think we should move away now that when it is not working anymore. Cheers - Andy > On May 4, 2020, at 7:25 AM, Robert Munteanu wrote: > > Got it. But did you stumble upon an actual problem with the plug-in, or > is the problem that plug-in is old and unmaintained? > > Thanks, > Robert > > On Thu, 2020-04-30 at 09:50 -0700, Andreas Schaefer wrote: >> I wanted to create a Feature Archive using the Slingfeature Maven >> plugin and using the Sling POM (38). >> The build failed because of the IANAL checks. While trying to find a >> solution I noticed that this is old plugin, w/o code, docs and still >> in alpha which raised a red flag. >> >> Cheers - Andy >> >>> On Apr 30, 2020, at 4:09 AM, Robert Munteanu >>> wrote: >>> >>> On Thu, 2020-04-30 at 11:58 +0200, Konrad Windszus wrote: It is still listed here: https://www.mojohaus.org/plugins.html < https://www.mojohaus.org/plugins.html> but was not (yet) moved to Github nor is any documentation available at the www.mojohaus.org < http://www.mojohaus.org/> Maybe some of the alternatives listed in http://syncope-dev.1063484.n5.nabble.com/DISCUSS-How-to-replace-ianal-maven-plugin-td5726574.html < http://syncope-dev.1063484.n5.nabble.com/DISCUSS-How-to-replace-ianal-maven-plugin-td5726574.html > would work for us... >>> >>> We cloud also ask mojohaus to move the plugin to GitHub and propose >>> a >>> fix. >>> >>> Andy, what exact problem did you encounter with the plug-in? >>> >>> Thanks, >>> Robert >>> Konrad > On 30. Apr 2020, at 11:05, Robert Munteanu > wrote: > > On Thu, 2020-04-30 at 10:06 +0200, Carsten Ziegeler wrote: >> As far as I remember, it checks that the artifacts (jars) >> have >> the >> required legal files, LICENSE and NOTICE. >> But given that this plugin is totally outdated, its probably >> safer >> to >> remove it > > It would be good to still check for the legal files though. > > Robert > >> Regards >> Carsten >> >> On 30.04.2020 09:58, Stefan Seifert wrote: >>> +1 to remove it >>> >>> it seems the plugin was already present in the very first >>> commit >>> 2009 "move sling to new TLP" location. >>> i've no idea what it does. >>> >>> stefan >>> -Original Message- From: Andreas Schaefer Sent: Thursday, April 30, 2020 1:12 AM To: dev Subject: Ianal Maven Plugin? Hi I just stumbled over an issue with Ianal Maven Plugin and when I wanted to see what it is looking for I discovered that the project does not exist anymore nor does a documentation page. The plugin was released 2008 as alpha and nothing since. Shouldn’t we stop using that plugin or find / create a replacement for it? Cheers - Andy >
[jira] [Resolved] (SLING-9422) Content Package Installer: Use service resource resolvers instead of admin resource resolver for installation
[
https://issues.apache.org/jira/browse/SLING-9422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved SLING-9422.
Resolution: Fixed
Fixed in
https://github.com/apache/sling-org-apache-sling-installer-factory-packages/commit/8c14843c254476964ad62795a2d2b67bce6a3a5e.
> Content Package Installer: Use service resource resolvers instead of admin
> resource resolver for installation
> -
>
> Key: SLING-9422
> URL: https://issues.apache.org/jira/browse/SLING-9422
> Project: Sling
> Issue Type: Improvement
> Components: Installer
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Installer Packages Factory 1.0.4
>
>
> Currently the {{PackageTransformer}} uses an an administrative session.
> Instead {{SlingRepository.loginService()}} should be used together with an
> according service user mapping. The user needs basically write access to all
> locations which is covered by packages and {{/etc/packages}} itself.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-9421) Add Groovy Lang Support
[ https://issues.apache.org/jira/browse/SLING-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099188#comment-17099188 ] Dan Klco commented on SLING-9421: - Thanks [~olli]! As a note it looks like we also need Apache Aries SPI Fly Dynamic Weaving Bundle for the groovy-json to start, did you see the same? > Add Groovy Lang Support > --- > > Key: SLING-9421 > URL: https://issues.apache.org/jira/browse/SLING-9421 > Project: Sling > Issue Type: Improvement > Components: App CMS, Launchpad >Affects Versions: Starter 11, App CMS 0.16.2 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: Starter 12, App CMS 0.16.4 > > > Composum Nodes supports executing [Groovy > scripts|https://www.composum.com/home/nodes/browser.html], however, this > requires Groovy to be available in the classpath. > We should add Groovy support to the Sling Starter and App CMS to enable users > to execute Groovy scripts without having to install any additional > dependencies. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-starter] kwin commented on a change in pull request #7: SLING-9420 - Create required configurations for o.a.s.installer.factory.packages
kwin commented on a change in pull request #7: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/7#discussion_r419602665 ## File path: src/main/provisioning/repoinit.txt ## @@ -71,6 +71,13 @@ allow rep:write on /apps/sling/install end +# content-package installer +create service user sling-package-install + +set ACL for sling-package-install +allow jcr:all on / Review comment: After having a 2nd thought I think this should be fine as once we fixed https://issues.apache.org/jira/browse/SLING-9422 we definitely need to be install all packages (which might everywhere to the repo) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-9422) Content Package Installer: Use service resource resolvers instead of admin resource resolver for installation
[
https://issues.apache.org/jira/browse/SLING-9422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099158#comment-17099158
]
Konrad Windszus commented on SLING-9422:
The actual installation still uses an administrative session in
https://github.com/apache/sling-org-apache-sling-installer-factory-packages/blob/84b0f9243e2c7cc733762e8ce199549632eaf9a2/src/main/java/org/apache/sling/installer/factory/packages/impl/PackageTransformer.java#L262.
> Content Package Installer: Use service resource resolvers instead of admin
> resource resolver for installation
> -
>
> Key: SLING-9422
> URL: https://issues.apache.org/jira/browse/SLING-9422
> Project: Sling
> Issue Type: Improvement
> Components: Installer
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Installer Packages Factory 1.0.0
>
>
> Currently the {{PackageTransformer}} uses an an administrative session.
> Instead {{SlingRepository.loginService()}} should be used together with an
> according service user mapping. The user needs basically write access to all
> locations which is covered by packages and {{/etc/packages}} itself.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-9422) Content Package Installer: Use service resource resolvers instead of admin resource resolver for installation
[
https://issues.apache.org/jira/browse/SLING-9422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-9422:
---
Fix Version/s: (was: Installer Packages Factory 1.0.0)
Installer Packages Factory 1.0.4
> Content Package Installer: Use service resource resolvers instead of admin
> resource resolver for installation
> -
>
> Key: SLING-9422
> URL: https://issues.apache.org/jira/browse/SLING-9422
> Project: Sling
> Issue Type: Improvement
> Components: Installer
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Installer Packages Factory 1.0.4
>
>
> Currently the {{PackageTransformer}} uses an an administrative session.
> Instead {{SlingRepository.loginService()}} should be used together with an
> according service user mapping. The user needs basically write access to all
> locations which is covered by packages and {{/etc/packages}} itself.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (SLING-9422) Content Package Installer: Use service resource resolvers instead of admin resource resolver for installation
Konrad Windszus created SLING-9422:
--
Summary: Content Package Installer: Use service resource resolvers
instead of admin resource resolver for installation
Key: SLING-9422
URL: https://issues.apache.org/jira/browse/SLING-9422
Project: Sling
Issue Type: Improvement
Components: Installer
Reporter: Konrad Windszus
Assignee: Konrad Windszus
Fix For: Installer Packages Factory 1.0.0
Currently the {{PackageTransformer}} uses an an administrative session. Instead
{{SlingRepository.loginService()}} should be used together with an according
service user mapping. The user needs basically write access to all locations
which is covered by packages and {{/etc/packages}} itself.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [sling-org-apache-sling-starter] kwin commented on a change in pull request #7: SLING-9420 - Create required configurations for o.a.s.installer.factory.packages
kwin commented on a change in pull request #7: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/7#discussion_r419599618 ## File path: src/main/provisioning/repoinit.txt ## @@ -71,6 +71,13 @@ allow rep:write on /apps/sling/install end +# content-package installer +create service user sling-package-install + +set ACL for sling-package-install +allow jcr:all on / Review comment: seems a bit too broad, especially as right now the service user is only used to upload packages: https://github.com/apache/sling-org-apache-sling-installer-factory-packages/blob/84b0f9243e2c7cc733762e8ce199549632eaf9a2/src/main/java/org/apache/sling/installer/factory/packages/impl/PackageTransformer.java#L146. The actual installation still takes an admin session (https://github.com/apache/sling-org-apache-sling-installer-factory-packages/blob/84b0f9243e2c7cc733762e8ce199549632eaf9a2/src/main/java/org/apache/sling/installer/factory/packages/impl/PackageTransformer.java#L262), this should be fixes though as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-9419) JCR Repoinit integration tests fail on Windows
[
https://issues.apache.org/jira/browse/SLING-9419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099154#comment-17099154
]
Stefan Seifert commented on SLING-9419:
---
no problem - attached:
[^org.apache.sling.jcr.repoinit.RepositoryInitializerTest.txt]
probably "C" is from a file system path which is interpreted as URL C:/path...
(although the project is located on drive D: on my computer)
> JCR Repoinit integration tests fail on Windows
> --
>
> Key: SLING-9419
> URL: https://issues.apache.org/jira/browse/SLING-9419
> Project: Sling
> Issue Type: Bug
> Components: Repoinit
>Reporter: Bertrand Delacretaz
>Priority: Minor
> Fix For: Repoinit JCR 1.1.28
>
>
> In the JCR Repoinit 1.1.26 vote, Stefan Seifert notes the following failures
> on Windows:
> {code}
> ---
> Test set: org.apache.sling.jcr.repoinit.RepositoryInitializerTest
> ---
> Tests run: 10, Failures: 9, Errors: 0, Skipped: 0, Time elapsed: 17.193 s <<<
> FAILURE! - in org.apache.sling.jcr.repoinit.RepositoryInitializerTest
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Using
> provisioning model] Time elapsed: 15.843 s <<< FAILURE!
> java.lang.AssertionError: Got unexpected java.net.UnknownHostException in
> activation
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:139)
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Default
> value of model section config] Time elapsed: 0.152 s <<< FAILURE!
> java.lang.AssertionError: Got unexpected java.net.UnknownHostException in
> activation
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:139)
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Raw
> repoinit/empty section] Time elapsed: 0.157 s <<< FAILURE!
> java.lang.AssertionError: Got unexpected java.net.UnknownHostException in
> activation
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:139)
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Raw
> repoinit/ignored section name] Time elapsed: 0.142 s <<< FAILURE!
> java.lang.AssertionError: Got unexpected java.net.UnknownHostException in
> activation
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:139)
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[All empty,
> just setup + parsing] Time elapsed: 0.167 s <<< FAILURE!
> java.lang.AssertionError: Got unexpected java.net.UnknownHostException in
> activation
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:139)
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Raw
> repoinit/null format] Time elapsed: 0.145 s <<< FAILURE!
> java.lang.AssertionError: expected: org.apache.sling.repoinit.parser.RepoInitParsingException> but was: java.net.UnknownHostException>
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:137)
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[With
> model/null format] Time elapsed: 0.133 s <<< FAILURE!
> java.lang.AssertionError: expected: but
> was:
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:137)
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Invalid
> format] Time elapsed: 0.162 s <<< FAILURE!
> java.lang.AssertionError: expected: but
> was:
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:137)
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Null model
> section] Time elapsed: 0.137 s <<< FAILURE!
> java.lang.AssertionError: expected: but was: java.net.UnknownHostException>
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:137)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-9419) JCR Repoinit integration tests fail on Windows
[
https://issues.apache.org/jira/browse/SLING-9419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert updated SLING-9419:
--
Attachment: org.apache.sling.jcr.repoinit.RepositoryInitializerTest.txt
> JCR Repoinit integration tests fail on Windows
> --
>
> Key: SLING-9419
> URL: https://issues.apache.org/jira/browse/SLING-9419
> Project: Sling
> Issue Type: Bug
> Components: Repoinit
>Reporter: Bertrand Delacretaz
>Priority: Minor
> Fix For: Repoinit JCR 1.1.28
>
> Attachments:
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.txt
>
>
> In the JCR Repoinit 1.1.26 vote, Stefan Seifert notes the following failures
> on Windows:
> {code}
> ---
> Test set: org.apache.sling.jcr.repoinit.RepositoryInitializerTest
> ---
> Tests run: 10, Failures: 9, Errors: 0, Skipped: 0, Time elapsed: 17.193 s <<<
> FAILURE! - in org.apache.sling.jcr.repoinit.RepositoryInitializerTest
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Using
> provisioning model] Time elapsed: 15.843 s <<< FAILURE!
> java.lang.AssertionError: Got unexpected java.net.UnknownHostException in
> activation
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:139)
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Default
> value of model section config] Time elapsed: 0.152 s <<< FAILURE!
> java.lang.AssertionError: Got unexpected java.net.UnknownHostException in
> activation
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:139)
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Raw
> repoinit/empty section] Time elapsed: 0.157 s <<< FAILURE!
> java.lang.AssertionError: Got unexpected java.net.UnknownHostException in
> activation
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:139)
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Raw
> repoinit/ignored section name] Time elapsed: 0.142 s <<< FAILURE!
> java.lang.AssertionError: Got unexpected java.net.UnknownHostException in
> activation
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:139)
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[All empty,
> just setup + parsing] Time elapsed: 0.167 s <<< FAILURE!
> java.lang.AssertionError: Got unexpected java.net.UnknownHostException in
> activation
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:139)
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Raw
> repoinit/null format] Time elapsed: 0.145 s <<< FAILURE!
> java.lang.AssertionError: expected: org.apache.sling.repoinit.parser.RepoInitParsingException> but was: java.net.UnknownHostException>
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:137)
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[With
> model/null format] Time elapsed: 0.133 s <<< FAILURE!
> java.lang.AssertionError: expected: but
> was:
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:137)
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Invalid
> format] Time elapsed: 0.162 s <<< FAILURE!
> java.lang.AssertionError: expected: but
> was:
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:137)
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Null model
> section] Time elapsed: 0.137 s <<< FAILURE!
> java.lang.AssertionError: expected: but was: java.net.UnknownHostException>
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:137)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-9421) Add Groovy Lang Support
[
https://issues.apache.org/jira/browse/SLING-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099138#comment-17099138
]
Oliver Lietz commented on SLING-9421:
-
[~dklco], see Karaf Feature for dependencies:
[https://github.com/apache/sling-org-apache-sling-karaf-features/blob/master/src/main/feature/feature.xml#L504]
You have to be careful when upgrading the dependencies because of broken OSGi
metadata in several releases (2.x and 3.x).
Scripting Groovy is registering the {{GStringTemplateEngine}} as service
({{groovy.text.TemplateEngine}}). AFAIR Groovy is using an internal counter
which could lead to integer overflow.
> Add Groovy Lang Support
> ---
>
> Key: SLING-9421
> URL: https://issues.apache.org/jira/browse/SLING-9421
> Project: Sling
> Issue Type: Improvement
> Components: App CMS, Launchpad
>Affects Versions: Starter 11, App CMS 0.16.2
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Minor
> Fix For: Starter 12, App CMS 0.16.4
>
>
> Composum Nodes supports executing [Groovy
> scripts|https://www.composum.com/home/nodes/browser.html], however, this
> requires Groovy to be available in the classpath.
> We should add Groovy support to the Sling Starter and App CMS to enable users
> to execute Groovy scripts without having to install any additional
> dependencies.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-9421) Add Groovy Lang Support
[ https://issues.apache.org/jira/browse/SLING-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099082#comment-17099082 ] Dan Klco commented on SLING-9421: - Thanks [~bdelacretaz]! I think Scripting Groovy is a different use case as it's providing a Groovy Scripting engine vs providing the Groovy dependencies. It does, however, make me second guess using 2.4.19 as it's using 3.0.1 as I don't want the two to be incompatible. > Add Groovy Lang Support > --- > > Key: SLING-9421 > URL: https://issues.apache.org/jira/browse/SLING-9421 > Project: Sling > Issue Type: Improvement > Components: App CMS, Launchpad >Affects Versions: Starter 11, App CMS 0.16.2 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: Starter 12, App CMS 0.16.4 > > > Composum Nodes supports executing [Groovy > scripts|https://www.composum.com/home/nodes/browser.html], however, this > requires Groovy to be available in the classpath. > We should add Groovy support to the Sling Starter and App CMS to enable users > to execute Groovy scripts without having to install any additional > dependencies. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-whiteboard] rombert commented on pull request #51: SAML2 Service Provider Pull Request
rombert commented on pull request #51: URL: https://github.com/apache/sling-whiteboard/pull/51#issuecomment-623545723 Ack, I read that. I understand the reasons. Note that at the ASF the primary source of disitribution are cryptographically signed source releases, not binaries on Maven Central. That does not change the fact that Maven Central discourages using `repositories` and `pluginRepository` elements - see https://central.sonatype.org/pages/requirements.html . If we do this we expose consumers to instability. There are ways around it, for now we just need to keep in mind that we (probably) should not add extra Maven repositories and fix it before a first release. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-9421) Add Groovy Lang Support
[ https://issues.apache.org/jira/browse/SLING-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099065#comment-17099065 ] Bertrand Delacretaz commented on SLING-9421: Note that we have [https://github.com/apache/sling-org-apache-sling-scripting-groovy,] I don't know if that's useful in this case. > Add Groovy Lang Support > --- > > Key: SLING-9421 > URL: https://issues.apache.org/jira/browse/SLING-9421 > Project: Sling > Issue Type: Improvement > Components: App CMS, Launchpad >Affects Versions: Starter 11, App CMS 0.16.2 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: Starter 12, App CMS 0.16.4 > > > Composum Nodes supports executing [Groovy > scripts|https://www.composum.com/home/nodes/browser.html], however, this > requires Groovy to be available in the classpath. > We should add Groovy support to the Sling Starter and App CMS to enable users > to execute Groovy scripts without having to install any additional > dependencies. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9414) Allow to disable SonarQube run via module descriptor
[
https://issues.apache.org/jira/browse/SLING-9414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099055#comment-17099055
]
Bertrand Delacretaz commented on SLING-9414:
Thank you for this! The build was fixed indeed but I think we can disable
SonarQube for the website build, I did that in
https://github.com/apache/sling-site/commit/1a648d8c12ab3403b64731358bb99eb5e75dd1fd
> Allow to disable SonarQube run via module descriptor
>
>
> Key: SLING-9414
> URL: https://issues.apache.org/jira/browse/SLING-9414
> Project: Sling
> Issue Type: Improvement
> Components: Tooling
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In the context of
> https://lists.apache.org/thread.html/ree9107867e5023e5bf468ffd34161d5226ed14dc01ba8dad3dffb8e5%40%3Cdev.sling.apache.org%3E
> it became obvious that in some cases SonarQube execution are not useful and
> should be disabled.
> In addition it would make sense to optionally not use the
> {{additionalMavenParams}}
> (https://cwiki.apache.org/confluence/display/SLING/Sling+module+descriptor)
> for the SonarQube run in
> https://github.com/apache/sling-tooling-jenkins/blob/96d11259bb003d4ff07a089d0fb66a48f8123ddb/vars/slingOsgiBundleBuild.groovy#L39.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-9421) Add Groovy Lang Support
[ https://issues.apache.org/jira/browse/SLING-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099054#comment-17099054 ] Dan Klco commented on SLING-9421: - Currently, I'm targeting Groovy 2.4.19 as this is an actively maintained branch, 2.5 changes how groovy-all is packaged, requiring separate JARs for each module and 3.0 does not seem to be compatible with Composum. > Add Groovy Lang Support > --- > > Key: SLING-9421 > URL: https://issues.apache.org/jira/browse/SLING-9421 > Project: Sling > Issue Type: Improvement > Components: App CMS, Launchpad >Affects Versions: Starter 11, App CMS 0.16.2 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: Starter 12, App CMS 0.16.4 > > > Composum Nodes supports executing [Groovy > scripts|https://www.composum.com/home/nodes/browser.html], however, this > requires Groovy to be available in the classpath. > We should add Groovy support to the Sling Starter and App CMS to enable users > to execute Groovy scripts without having to install any additional > dependencies. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-whiteboard] cmrockwell commented on pull request #51: SAML2 Service Provider Pull Request
cmrockwell commented on pull request #51: URL: https://github.com/apache/sling-whiteboard/pull/51#issuecomment-623540975 Thanks for posting. Here is what the OpenSAML (Shibboleth) developers say about Maven Central. https://wiki.shibboleth.net/confluence/display/DEV/Use+of+Maven+Central > Maven itself has no support for validating signatures of artifacts (be they signed jars or jars with a detached PGP signature) If other people aren't worried about the veracity of the artifacts they use that's on them This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-9421) Add Groovy Lang Support
Dan Klco created SLING-9421: --- Summary: Add Groovy Lang Support Key: SLING-9421 URL: https://issues.apache.org/jira/browse/SLING-9421 Project: Sling Issue Type: Improvement Components: App CMS, Launchpad Affects Versions: App CMS 0.16.2, Starter 11 Reporter: Dan Klco Assignee: Dan Klco Fix For: Starter 12, App CMS 0.16.4 Composum Nodes supports executing [Groovy scripts|https://www.composum.com/home/nodes/browser.html], however, this requires Groovy to be available in the classpath. We should add Groovy support to the Sling Starter and App CMS to enable users to execute Groovy scripts without having to install any additional dependencies. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9419) JCR Repoinit integration tests fail on Windows
[
https://issues.apache.org/jira/browse/SLING-9419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099034#comment-17099034
]
Bertrand Delacretaz commented on SLING-9419:
[~sseifert], I have added stack traces to those test failures, could you try to
run the [https://github.com/apache/sling-org-apache-sling-jcr-repoinit] tests
on Windows again when you find some time? And add the stack traces here.
(sorry, I don't have a Windows setup here)
> JCR Repoinit integration tests fail on Windows
> --
>
> Key: SLING-9419
> URL: https://issues.apache.org/jira/browse/SLING-9419
> Project: Sling
> Issue Type: Bug
> Components: Repoinit
>Reporter: Bertrand Delacretaz
>Priority: Minor
> Fix For: Repoinit JCR 1.1.28
>
>
> In the JCR Repoinit 1.1.26 vote, Stefan Seifert notes the following failures
> on Windows:
> {code}
> ---
> Test set: org.apache.sling.jcr.repoinit.RepositoryInitializerTest
> ---
> Tests run: 10, Failures: 9, Errors: 0, Skipped: 0, Time elapsed: 17.193 s <<<
> FAILURE! - in org.apache.sling.jcr.repoinit.RepositoryInitializerTest
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Using
> provisioning model] Time elapsed: 15.843 s <<< FAILURE!
> java.lang.AssertionError: Got unexpected java.net.UnknownHostException in
> activation
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:139)
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Default
> value of model section config] Time elapsed: 0.152 s <<< FAILURE!
> java.lang.AssertionError: Got unexpected java.net.UnknownHostException in
> activation
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:139)
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Raw
> repoinit/empty section] Time elapsed: 0.157 s <<< FAILURE!
> java.lang.AssertionError: Got unexpected java.net.UnknownHostException in
> activation
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:139)
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Raw
> repoinit/ignored section name] Time elapsed: 0.142 s <<< FAILURE!
> java.lang.AssertionError: Got unexpected java.net.UnknownHostException in
> activation
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:139)
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[All empty,
> just setup + parsing] Time elapsed: 0.167 s <<< FAILURE!
> java.lang.AssertionError: Got unexpected java.net.UnknownHostException in
> activation
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:139)
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Raw
> repoinit/null format] Time elapsed: 0.145 s <<< FAILURE!
> java.lang.AssertionError: expected: org.apache.sling.repoinit.parser.RepoInitParsingException> but was: java.net.UnknownHostException>
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:137)
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[With
> model/null format] Time elapsed: 0.133 s <<< FAILURE!
> java.lang.AssertionError: expected: but
> was:
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:137)
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Invalid
> format] Time elapsed: 0.162 s <<< FAILURE!
> java.lang.AssertionError: expected: but
> was:
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:137)
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Null model
> section] Time elapsed: 0.137 s <<< FAILURE!
> java.lang.AssertionError: expected: but was: java.net.UnknownHostException>
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:137)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [sling-org-apache-sling-starter] sonarcloud[bot] commented on pull request #7: SLING-9420 - Create required configurations for o.a.s.installer.factory.packages
sonarcloud[bot] commented on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/7#issuecomment-623515263 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=7=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=7=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=7=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=7=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=7=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=7=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=7=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=7=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=7=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=7=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter=7=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter=7) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter=7=duplicated_lines_density=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] rombert opened a new pull request #7: SLING-9420 - Create required configurations for o.a.s.installer.factory.packages
rombert opened a new pull request #7: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/7 Add sling-package-install user, for use with to o.a.s.installer.factory.packages bundle. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-9420) Create required configurations for o.a.s.installer.factory.packages
Robert Munteanu created SLING-9420: -- Summary: Create required configurations for o.a.s.installer.factory.packages Key: SLING-9420 URL: https://issues.apache.org/jira/browse/SLING-9420 Project: Sling Issue Type: Sub-task Components: Starter Reporter: Robert Munteanu Assignee: Robert Munteanu With SLNIG-6196 we have the bundle that can install content packages. However, it still needs a user mapping to a service user with proper privileges. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-6950) Support Content-Package based development
[ https://issues.apache.org/jira/browse/SLING-6950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-6950: --- Labels: Sling-12-ReleaseNotes (was: ) > Support Content-Package based development > - > > Key: SLING-6950 > URL: https://issues.apache.org/jira/browse/SLING-6950 > Project: Sling > Issue Type: New Feature > Components: General >Reporter: Robert Munteanu >Priority: Major > Labels: Sling-12-ReleaseNotes > Fix For: Starter 12 > > > Tracking task for supporting development based on Content Packages with Sling. -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: Do we still need https://sling.apache.org/releases.html ?
On Mon, May 4, 2020 at 4:22 PM Carsten Ziegeler wrote: > ...Today, if someone forgets to add a release to our webpage, we can easily > fix that later on by editing that page and adding an old release. Is > that possible with the reporter, too?.. Yes, the reporter nags us with https://reporter.apache.org/addrelease.html?sling and we can use that form at any time to add missing releases. > ...Or in other words, todays release page is very easy to maintain - and > for a release you have to edit the downloads page anyway. At first look, > relying on the reporter data seems to be more complicated... I think it depends whether we agree that the reporter.a.o data is required - if that's a yes, maintaining our own page duplicates data. -Bertrand
Re: Ianal Maven Plugin?
Got it. But did you stumble upon an actual problem with the plug-in, or is the problem that plug-in is old and unmaintained? Thanks, Robert On Thu, 2020-04-30 at 09:50 -0700, Andreas Schaefer wrote: > I wanted to create a Feature Archive using the Slingfeature Maven > plugin and using the Sling POM (38). > The build failed because of the IANAL checks. While trying to find a > solution I noticed that this is old plugin, w/o code, docs and still > in alpha which raised a red flag. > > Cheers - Andy > > > On Apr 30, 2020, at 4:09 AM, Robert Munteanu > > wrote: > > > > On Thu, 2020-04-30 at 11:58 +0200, Konrad Windszus wrote: > > > It is still listed here: https://www.mojohaus.org/plugins.html < > > > https://www.mojohaus.org/plugins.html> but was not (yet) moved to > > > Github nor is any documentation available at the www.mojohaus.org > > > < > > > http://www.mojohaus.org/> > > > Maybe some of the alternatives listed in > > > http://syncope-dev.1063484.n5.nabble.com/DISCUSS-How-to-replace-ianal-maven-plugin-td5726574.html > > > < > > > http://syncope-dev.1063484.n5.nabble.com/DISCUSS-How-to-replace-ianal-maven-plugin-td5726574.html > > > > would work for us... > > > > We cloud also ask mojohaus to move the plugin to GitHub and propose > > a > > fix. > > > > Andy, what exact problem did you encounter with the plug-in? > > > > Thanks, > > Robert > > > > > Konrad > > > > > > > On 30. Apr 2020, at 11:05, Robert Munteanu > > > > wrote: > > > > > > > > On Thu, 2020-04-30 at 10:06 +0200, Carsten Ziegeler wrote: > > > > > As far as I remember, it checks that the artifacts (jars) > > > > > have > > > > > the > > > > > required legal files, LICENSE and NOTICE. > > > > > But given that this plugin is totally outdated, its probably > > > > > safer > > > > > to > > > > > remove it > > > > > > > > It would be good to still check for the legal files though. > > > > > > > > Robert > > > > > > > > > Regards > > > > > Carsten > > > > > > > > > > On 30.04.2020 09:58, Stefan Seifert wrote: > > > > > > +1 to remove it > > > > > > > > > > > > it seems the plugin was already present in the very first > > > > > > commit > > > > > > 2009 "move sling to new TLP" location. > > > > > > i've no idea what it does. > > > > > > > > > > > > stefan > > > > > > > > > > > > > -Original Message- > > > > > > > From: Andreas Schaefer > > > > > > > Sent: Thursday, April 30, 2020 1:12 AM > > > > > > > To: dev > > > > > > > Subject: Ianal Maven Plugin? > > > > > > > > > > > > > > Hi > > > > > > > > > > > > > > I just stumbled over an issue with Ianal Maven Plugin and > > > > > > > when I > > > > > > > wanted to > > > > > > > see what it is looking for I discovered that the project > > > > > > > does > > > > > > > not > > > > > > > exist > > > > > > > anymore nor does a documentation page. > > > > > > > The plugin was released 2008 as alpha and nothing since. > > > > > > > > > > > > > > Shouldn’t we stop using that plugin or find / create a > > > > > > > replacement for it? > > > > > > > > > > > > > > Cheers - Andy
[jira] [Commented] (SLING-9417) Content-type and InputStream are null when accessing nt:file resources with ";v="
[
https://issues.apache.org/jira/browse/SLING-9417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098976#comment-17098976
]
Robert Munteanu commented on SLING-9417:
Thank you for the report [~alldaysunshine]. I am not very familiar with that
area ( I think [~tomekr] did the initial implementation of the versioning
access ) but a pull request would be a good way to start a discussion.
Additionally, we will probably need some integration tests added to describe
the problematic behaviour - see
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/blob/master/src/main/java/org/apache/sling/launchpad/webapp/integrationtest/VersionInfoServletTest.java
for what we currently have.
> Content-type and InputStream are null when accessing nt:file resources with
> ";v="
> -
>
> Key: SLING-9417
> URL: https://issues.apache.org/jira/browse/SLING-9417
> Project: Sling
> Issue Type: Bug
> Components: JCR
>Reporter: Matthias Herold
>Priority: Minor
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> When using the methods resource.getMetadata().getContentType() or
> resource.adaptTo(InputStream.class), both methods return null when:
> # the resource is a child of a versionable node,
> # the resource is of type nt:file, and
> # resource has been looked up with a version identifier in the URL (";v=").
> From my understanding, both methods should return the relevant values from
> the frozen node. The error occurs because of line 185 in JcrNodeResource.java
> {{Node content = node.isNodeType(NT_FILE)}}
> {{? node.getNode(JCR_CONTENT)}}
> {{: node.isNodeType(NT_LINKEDFILE) ? node.getProperty(JCR_CONTENT).getNode()
> : node;}}
> When the resource is looked up with a version modifier, the node type will
> not nt:file. Instead it is jcr:frozenNode with a property
> jcr:frozenPrimaryType set to nt:file. Therefore, the above code fails and
> will not use the jcr:content subnode, but the node itself. In my opinion, it
> would be better to change this to:
> Node content = (node.isNodeType(NodeType.NT_FILE) ||
> (node.isNodeType("nt:frozenNode") &&
> node.hasProperty("jcr:frozenPrimaryType")
> {{ &&
> node.getProperty("jcr:frozenPrimaryType").getString().equals(NT_FILE)))}}
> {{ ? node.getNode(Node.JCR_CONTENT)
> {{ : node.isNodeType(JcrConstants.NT_LINKEDFILE) ?
> node.getProperty(Node.JCR_CONTENT).getNode() : node;}}
>
> JcrResourceMetadata has the same issue (line 65):
> {{ if ( (!nodePromotionChecked) && node.isNodeType(NT_FILE)) {}}
> This could be changed to:
> {{ if ( (!nodePromotionChecked) && (node.isNodeType(NT_FILE) ||}}
> {{ (node.isNodeType("nt:frozenNode") &&
> node.hasProperty("jcr:frozenPrimaryType") }}
> {{ &&
> node.getProperty("jcr:frozenPrimaryType").getString().equals(NT_FILE {}}
>
> As I'm still a newbie in Sling, I'm not sure if the proposed solution is
> completely right. At the moment, I use a ResourceDecorator for my project
> with these changes and this fixes my problem - but there might be a better
> way to solve this.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Re: Do we still need https://sling.apache.org/releases.html ?
Many releases are missing from that data. Today, if someone forgets to add a release to our webpage, we can easily fix that later on by editing that page and adding an old release. Is that possible with the reporter, too? Or in other words, todays release page is very easy to maintain - and for a release you have to edit the downloads page anyway. At first look, relying on the reporter data seems to be more complicated. Carsten On 04.05.2020 16:04, Bertrand Delacretaz wrote: On Mon, May 4, 2020 at 3:56 PM Bertrand Delacretaz wrote: ...It looks like that reporter website belongs to http://community.apache.org/, I'll ask there if that releases data or page could be made public... turns out that the release data itself is already public, https://svn.apache.org/repos/asf/comdev/reporter.apache.org/trunk/data/releases/sling.json I'll look at how to merge that automatically in https://sling.apache.org/releases.html , we already have some similar processing in the website for [1] -Bertrand [1] https://github.com/apache/sling-site/blob/master/src/main/jbake/templates/repolist.tpl -- -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
Re: Do we still need https://sling.apache.org/releases.html ?
On Mon, May 4, 2020 at 3:56 PM Bertrand Delacretaz wrote: > ...It looks like that reporter website belongs to > http://community.apache.org/, I'll ask there if that releases data or > page could be made public... turns out that the release data itself is already public, https://svn.apache.org/repos/asf/comdev/reporter.apache.org/trunk/data/releases/sling.json I'll look at how to merge that automatically in https://sling.apache.org/releases.html , we already have some similar processing in the website for [1] -Bertrand [1] https://github.com/apache/sling-site/blob/master/src/main/jbake/templates/repolist.tpl
[GitHub] [sling-whiteboard] rombert edited a comment on pull request #51: SAML2 Service Provider Pull Request
rombert edited a comment on pull request #51: URL: https://github.com/apache/sling-whiteboard/pull/51#issuecomment-623478010 @cmrockwell - what I get is ```$ mvn -U clean verify [WARNING] SystemTray is not supported, skipping notifications... [INFO] Scanning for projects... [INFO] [INFO] < org.apache.sling:org.apache.sling.auth.saml2 > [INFO] Building SAML2 Service Provider 0.1.0-SNAPSHOT [INFO] [ jar ]- Downloading from shibboleth: https://build.shibboleth.net/nexus/content/groups/public/org/relaxng/com.springsource.org.relaxng.datatype/1.0.0/com.springsource.org.relaxng.datatype-1.0.0.pom Downloading from central: https://repo.maven.apache.org/maven2/org/relaxng/com.springsource.org.relaxng.datatype/1.0.0/com.springsource.org.relaxng.datatype-1.0.0.pom [WARNING] The POM for org.relaxng:com.springsource.org.relaxng.datatype:jar:1.0.0 is missing, no dependency information available Downloading from shibboleth: https://build.shibboleth.net/nexus/content/groups/public/org/relaxng/com.springsource.org.relaxng.datatype/1.0.0/com.springsource.org.relaxng.datatype-1.0.0.jar Downloading from central: https://repo.maven.apache.org/maven2/org/relaxng/com.springsource.org.relaxng.datatype/1.0.0/com.springsource.org.relaxng.datatype-1.0.0.jar [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 1.351 s [INFO] Finished at: 2020-05-04T15:52:37+02:00 [INFO] [ERROR] Failed to execute goal on project org.apache.sling.auth.saml2: Could not resolve dependencies for project org.apache.sling:org.apache.sling.auth.saml2:jar:0.1.0-SNAPSHOT: Could not find artifact org.relaxng:com.springsource.org.relaxng.datatype:jar:1.0.0 in shibboleth (https://build.shibboleth.net/nexus/content/groups/public) -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException ``` I have no settings.xml. I am running with ```$ mvn -v Apache Maven 3.6.3 (SUSE 3.6.3-2.1) Maven home: /usr/share/maven Java version: 11.0.7, vendor: Oracle Corporation, runtime: /usr/lib64/jvm/java-11-openjdk-11 Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "5.6.6-1-default", arch: "amd64", family: "unix" ``` At any rate, we'll have to solve the issue of external artifacts at some points, we should not have any custom repositories set. I've merged this in now, let's focus on getting the build passing so we can start validating the functionality. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: Do we still need https://sling.apache.org/releases.html ?
On Mon, May 4, 2020 at 3:21 PM Carsten Ziegeler wrote: > > Where can I see the release info for Sling?.. At https://reporter.apache.org/wizard/statistics?sling but as Dan notes that requires an Apache committer login. It looks like that reporter website belongs to http://community.apache.org/, I'll ask there if that releases data or page could be made public. -Bertrand
[GitHub] [sling-whiteboard] rombert edited a comment on pull request #51: SAML2 Service Provider Pull Request
rombert edited a comment on pull request #51: URL: https://github.com/apache/sling-whiteboard/pull/51#issuecomment-623478010 @cmrockwell - what I get is ```$ mvn -U clean verify [WARNING] SystemTray is not supported, skipping notifications... [INFO] Scanning for projects... [INFO] [INFO] < org.apache.sling:org.apache.sling.auth.saml2 > [INFO] Building SAML2 Service Provider 0.1.0-SNAPSHOT [INFO] [ jar ]- Downloading from shibboleth: https://build.shibboleth.net/nexus/content/groups/public/org/relaxng/com.springsource.org.relaxng.datatype/1.0.0/com.springsource.org.relaxng.datatype-1.0.0.pom Downloading from central: https://repo.maven.apache.org/maven2/org/relaxng/com.springsource.org.relaxng.datatype/1.0.0/com.springsource.org.relaxng.datatype-1.0.0.pom [WARNING] The POM for org.relaxng:com.springsource.org.relaxng.datatype:jar:1.0.0 is missing, no dependency information available Downloading from shibboleth: https://build.shibboleth.net/nexus/content/groups/public/org/relaxng/com.springsource.org.relaxng.datatype/1.0.0/com.springsource.org.relaxng.datatype-1.0.0.jar Downloading from central: https://repo.maven.apache.org/maven2/org/relaxng/com.springsource.org.relaxng.datatype/1.0.0/com.springsource.org.relaxng.datatype-1.0.0.jar [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 1.351 s [INFO] Finished at: 2020-05-04T15:52:37+02:00 [INFO] [ERROR] Failed to execute goal on project org.apache.sling.auth.saml2: Could not resolve dependencies for project org.apache.sling:org.apache.sling.auth.saml2:jar:0.1.0-SNAPSHOT: Could not find artifact org.relaxng:com.springsource.org.relaxng.datatype:jar:1.0.0 in shibboleth (https://build.shibboleth.net/nexus/content/groups/public) -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException ``` I have no settings.xml. I am running with ```$ mvn -v Apache Maven 3.6.3 (SUSE 3.6.3-2.1) Maven home: /usr/share/maven Java version: 11.0.7, vendor: Oracle Corporation, runtime: /usr/lib64/jvm/java-11-openjdk-11 Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "5.6.6-1-default", arch: "amd64", family: "unix"``` At any rate, we'll have to solve the issue of external artifacts at some points, we should not have any custom repositories set. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-9397) SAML2 Authentication Handler [initial submission]
[
https://issues.apache.org/jira/browse/SLING-9397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-9397:
---
Description:
Here is a pull request which adds an authentication handler for a SAML2 Service
Provider via the embedded OpenSAML V3 dependencies
[https://github.com/apache/sling-whiteboard/pull/51]
*TODO Before Initial*
[X] Sync attributes released by the IDP
[X] Confirm license and attribution
"As the code is ASL2 and does not require a notice or anything else, we don't
need to mention in. But I think its usually good style to do so and have a
single sentence in our NOTICE that we include (modified) code from ... which
has ASL2 as the license"
*TODO After Initial*
[ ] Get confirmation the project builds and operates as expected
[ ] Clarify whether we can depend on artifacts not deployed on Maven Central
[ ] Review Web Browser SSO Profile Specification 4.1 and confirm all aspects
* [https://docs.oasis-open.org/security/saml/v2.0/saml-profiles-2.0-os.pdf]
[ ] Consider whether use of {{SAML2ConfigService}} and
{{SAML2ConfigServiceImpl}} is a good design or not.
[ ] Get feedback whether README instructions are too much, too little, unclear,
etc
[ ] Decide whether to make signing and encryption optional. Currently it is
required
[ ] Find and fix any bugs
was:
Here is a pull request which adds an authentication handler for a SAML2 Service
Provider via the embedded OpenSAML V3 dependencies
[https://github.com/apache/sling-whiteboard/pull/51]
*TODO Before Initial*
[X] Sync attributes released by the IDP
[X] Confirm license and attribution
"As the code is ASL2 and does not require a notice or anything else, we don't
need to mention in. But I think its usually good style to do so and have a
single sentence in our NOTICE that we include (modified) code from ... which
has ASL2 as the license"
[ ] Get confirmation the project builds and operates as expected
*TODO After Initial*
[ ] Review Web Browser SSO Profile Specification 4.1 and confirm all aspects
* [https://docs.oasis-open.org/security/saml/v2.0/saml-profiles-2.0-os.pdf]
[ ] Consider whether use of {{SAML2ConfigService}} and
{{SAML2ConfigServiceImpl}} is a good design or not.
[ ] Get feedback whether README instructions are too much, too little, unclear,
etc
[ ] Decide whether to make signing and encryption optional. Currently it is
required
[ ] Find and fix any bugs
> SAML2 Authentication Handler [initial submission]
> -
>
> Key: SLING-9397
> URL: https://issues.apache.org/jira/browse/SLING-9397
> Project: Sling
> Issue Type: New Feature
> Components: Authentication
> Environment: localhost
>Reporter: Cris Rockwell
>Priority: Major
> Labels: SAML, authentification, security, user_management
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Here is a pull request which adds an authentication handler for a SAML2
> Service Provider via the embedded OpenSAML V3 dependencies
> [https://github.com/apache/sling-whiteboard/pull/51]
>
> *TODO Before Initial*
> [X] Sync attributes released by the IDP
> [X] Confirm license and attribution
> "As the code is ASL2 and does not require a notice or anything else, we don't
> need to mention in. But I think its usually good style to do so and have a
> single sentence in our NOTICE that we include (modified) code from ... which
> has ASL2 as the license"
>
> *TODO After Initial*
> [ ] Get confirmation the project builds and operates as expected
> [ ] Clarify whether we can depend on artifacts not deployed on Maven Central
> [ ] Review Web Browser SSO Profile Specification 4.1 and confirm all aspects
> * [https://docs.oasis-open.org/security/saml/v2.0/saml-profiles-2.0-os.pdf]
> [ ] Consider whether use of {{SAML2ConfigService}} and
> {{SAML2ConfigServiceImpl}} is a good design or not.
> [ ] Get feedback whether README instructions are too much, too little,
> unclear, etc
> [ ] Decide whether to make signing and encryption optional. Currently it is
> required
> [ ] Find and fix any bugs
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [sling-whiteboard] rombert commented on pull request #51: SAML2 Service Provider Pull Request
rombert commented on pull request #51: URL: https://github.com/apache/sling-whiteboard/pull/51#issuecomment-623478010 @cmrockwell - what I get is ```$ mvn -U clean verify [WARNING] SystemTray is not supported, skipping notifications... [INFO] Scanning for projects... [INFO] [INFO] < org.apache.sling:org.apache.sling.auth.saml2 > [INFO] Building SAML2 Service Provider 0.1.0-SNAPSHOT [INFO] [ jar ]- Downloading from shibboleth: https://build.shibboleth.net/nexus/content/groups/public/org/relaxng/com.springsource.org.relaxng.datatype/1.0.0/com.springsource.org.relaxng.datatype-1.0.0.pom Downloading from central: https://repo.maven.apache.org/maven2/org/relaxng/com.springsource.org.relaxng.datatype/1.0.0/com.springsource.org.relaxng.datatype-1.0.0.pom [WARNING] The POM for org.relaxng:com.springsource.org.relaxng.datatype:jar:1.0.0 is missing, no dependency information available Downloading from shibboleth: https://build.shibboleth.net/nexus/content/groups/public/org/relaxng/com.springsource.org.relaxng.datatype/1.0.0/com.springsource.org.relaxng.datatype-1.0.0.jar Downloading from central: https://repo.maven.apache.org/maven2/org/relaxng/com.springsource.org.relaxng.datatype/1.0.0/com.springsource.org.relaxng.datatype-1.0.0.jar [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 1.351 s [INFO] Finished at: 2020-05-04T15:52:37+02:00 [INFO] [ERROR] Failed to execute goal on project org.apache.sling.auth.saml2: Could not resolve dependencies for project org.apache.sling:org.apache.sling.auth.saml2:jar:0.1.0-SNAPSHOT: Could not find artifact org.relaxng:com.springsource.org.relaxng.datatype:jar:1.0.0 in shibboleth (https://build.shibboleth.net/nexus/content/groups/public) -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException``` I have no settings.xml. I am running with ```$ mvn -v Apache Maven 3.6.3 (SUSE 3.6.3-2.1) Maven home: /usr/share/maven Java version: 11.0.7, vendor: Oracle Corporation, runtime: /usr/lib64/jvm/java-11-openjdk-11 Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "5.6.6-1-default", arch: "amd64", family: "unix"``` At any rate, we'll have to solve the issue of external artifacts at some points, we should not have any custom repositories set. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: Sling Starter 12-SNAPSHOT java.lang.InterruptedException
On Mon, 2020-05-04 at 15:42 +0200, Konrad Windszus wrote: > Hi Robert, > thanks for your response. > I agree with all points except for > > > One option is to ask Oak to > > make a configuration required for some components [3], but IMO this > > is > > not fixing the root cause. Oak is not to blame for the way we > > manage > > components and configurations. > > > IMHO every OSGi service should be able to deal with reconfigurations > no matter when they happen. Therefore fixing it on the Oak side makes > IMHO sense. In addition we can improve in which order we set the > configuration in Sling. I regret the fact that Oak does not go with regular Java concurrency patterns and asks to avoid Thread.interrupt. I agree that in principle each OSGi service should be reconfigurable with ease. But unfortunately that is not the case with the Oak NodeStore implementation, and it's going to be really hard to do it. What we are doing is now is making sure that the repository is not restarted at all, and the most convenient place of doing it is Oak. Thanks, Robert
Re: Sling Starter 12-SNAPSHOT java.lang.InterruptedException
Hi Robert, thanks for your response. I agree with all points except for > One option is to ask Oak to > make a configuration required for some components [3], but IMO this is > not fixing the root cause. Oak is not to blame for the way we manage > components and configurations. > IMHO every OSGi service should be able to deal with reconfigurations no matter when they happen. Therefore fixing it on the Oak side makes IMHO sense. In addition we can improve in which order we set the configuration in Sling. Konrad
Re: Do we still need https://sling.apache.org/releases.html ?
AFAIK, they serve two different purposes, releases.html is a public list of all releases made by Sling whereas the reporter wizard requires login with Apache credentials. It would be nice if the releases.html could be driven off the ASF database, but I'm not sure that's possible as it seems to require authentication. On Mon, May 4, 2020 at 9:21 AM Carsten Ziegeler wrote: > Where can I see the release info for Sling? > > > Carsten > > On 04.05.2020 15:18, Bertrand Delacretaz wrote: > > Hi, > > > > The releases info now goes to > > https://reporter.apache.org/wizard/statistics, which nags us to add it > > when we make a release. > > > > Is anyone opposed to deprecating > > https://sling.apache.org/releases.html ? We might indicate that that > > page is only valid until a certain date, and point to point to the > > reporter info. > > > > -Bertrand > > > > -- > -- > Carsten Ziegeler > Adobe Research Switzerland > cziege...@apache.org >
Re: Sling Starter 12-SNAPSHOT java.lang.InterruptedException
Hi Konrad, On Sun, 2020-05-03 at 11:32 +0200, Konrad Windszus wrote: > Hi, > I just experienced this exception when starting Sling Starter 12- > SNAPSHOT: > > 03.05.2020 11:22:33.372 *INFO* [CM Event Dispatcher (Fire > ConfigurationEvent: > pid=org.apache.jackrabbit.oak.spi.security.user.action.DefaultAuthori > zableActionProvider)] > org.apache.jackrabbit.oak.security.internal.SecurityProviderRegistrat > ion Trying to unregister the SecurityProvider... > 03.05.2020 11:22:33.405 *ERROR* [Apache Sling Repository Startup > Thread #1] > org.apache.sling.jcr.oak.server.internal.OakSlingRepositoryManager > start: Uncaught Throwable trying to access Repository, calling > stopRepository() > java.lang.RuntimeException: > org.apache.jackrabbit.oak.api.CommitFailedException: OakSegment0002: > Merge interrupted > at > org.apache.jackrabbit.oak.OakInitializer.initialize(OakInitializer.ja > va:50) [org.apache.jackrabbit.oak-core:1.26.0] > at org.apache.jackrabbit.oak.Oak.initialContent(Oak.java:689) > [org.apache.jackrabbit.oak-core:1.26.0] > at > org.apache.jackrabbit.oak.Oak.createNewContentRepository(Oak.java:734 > ) [org.apache.jackrabbit.oak-core:1.26.0] > at > org.apache.jackrabbit.oak.Oak.createContentRepository(Oak.java:673) > [org.apache.jackrabbit.oak-core:1.26.0] > at > org.apache.jackrabbit.oak.jcr.Jcr.createContentRepository(Jcr.java:37 > 6) [org.apache.jackrabbit.oak-jcr:1.26.0] > at > org.apache.sling.jcr.oak.server.internal.OakSlingRepositoryManager.ac > quireRepository(OakSlingRepositoryManager.java:152) > [org.apache.sling.jcr.oak.server:1.2.4] > at > org.apache.sling.jcr.base.AbstractSlingRepositoryManager.initializeAn > dRegisterRepositoryService(AbstractSlingRepositoryManager.java:515) > [org.apache.sling.jcr.base:3.1.0] > at > org.apache.sling.jcr.base.AbstractSlingRepositoryManager.access$300(A > bstractSlingRepositoryManager.java:92) > [org.apache.sling.jcr.base:3.1.0] > at > org.apache.sling.jcr.base.AbstractSlingRepositoryManager$4.run(Abstra > ctSlingRepositoryManager.java:496) [org.apache.sling.jcr.base:3.1.0] > Caused by: org.apache.jackrabbit.oak.api.CommitFailedException: > OakSegment0002: Merge interrupted > at > org.apache.jackrabbit.oak.segment.scheduler.LockBasedScheduler.schedu > le(LockBasedScheduler.java:284) [org.apache.jackrabbit.oak-segment- > tar:1.26.0] > at > org.apache.jackrabbit.oak.segment.SegmentNodeStore.merge(SegmentNodeS > tore.java:211) [org.apache.jackrabbit.oak-segment-tar:1.26.0] > at > org.apache.jackrabbit.oak.OakInitializer.initialize(OakInitializer.ja > va:48) [org.apache.jackrabbit.oak-core:1.26.0] > ... 8 common frames omitted > Caused by: java.lang.InterruptedException: null > at > java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireSharedIn > terruptibly(AbstractQueuedSynchronizer.java:1302) > at java.util.concurrent.Semaphore.acquire(Semaphore.java:312) > at > org.apache.jackrabbit.oak.segment.scheduler.LockBasedScheduler.schedu > le(LockBasedScheduler.java:262) [org.apache.jackrabbit.oak-segment- > tar:1.26.0] > ... 10 common frames omitted > I don't know what lead to the restart of the Oak service itself > (probably some reconfigurations) and I remember vaguely there once > was a JIRA issue about that. Couldn't find it though, so any pointers > are appreciated. > > Should I open this in a new issue or add as comment to any existing > one? I see you correctly identified SLING-7811 [1] as place where we discuss the root cause. I think the problem surfaces at different levels: 1. We start components and the apply configurations later, this restarting them. I though this was fixed in the feature model, but apparently we get the same problem [2]. One option is to ask Oak to make a configuration required for some components [3], but IMO this is not fixing the root cause. Oak is not to blame for the way we manage components and configurations. 2. Oak does not play nicely with Thread interrupt. Unfortunately this is by design [4] 3. We stop the Oak repository using Thread.interrupt [1]. As mentioned in the Jira issue, I am working on a version that stops the repository without using interrupts, but on the other hand this will not fix it properly. If we initialise the repository without all the required services/initialisers being available, we will create and expose an inconsistent repository service, which leads to Sling being unable to start and an incorrect repository state. I am more and more convinced that we must be 100% sure that we have all the pre-requisites for the repository service. The fix in Oak [3] will help, but I would've preferred a solution at the OSGi level. Thanks, Robert [1]: https://issues.apache.org/jira/browse/SLING-7811 [2]: https://issues.apache.org/jira/browse/SLING-9118?focusedCommentId=17090938=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17090938 [3]:
[jira] [Resolved] (SLING-9414) Allow to disable SonarQube run via module descriptor
[
https://issues.apache.org/jira/browse/SLING-9414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved SLING-9414.
Resolution: Fixed
> Allow to disable SonarQube run via module descriptor
>
>
> Key: SLING-9414
> URL: https://issues.apache.org/jira/browse/SLING-9414
> Project: Sling
> Issue Type: Improvement
> Components: Tooling
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In the context of
> https://lists.apache.org/thread.html/ree9107867e5023e5bf468ffd34161d5226ed14dc01ba8dad3dffb8e5%40%3Cdev.sling.apache.org%3E
> it became obvious that in some cases SonarQube execution are not useful and
> should be disabled.
> In addition it would make sense to optionally not use the
> {{additionalMavenParams}}
> (https://cwiki.apache.org/confluence/display/SLING/Sling+module+descriptor)
> for the SonarQube run in
> https://github.com/apache/sling-tooling-jenkins/blob/96d11259bb003d4ff07a089d0fb66a48f8123ddb/vars/slingOsgiBundleBuild.groovy#L39.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Re: Do we still need https://sling.apache.org/releases.html ?
Where can I see the release info for Sling? Carsten On 04.05.2020 15:18, Bertrand Delacretaz wrote: Hi, The releases info now goes to https://reporter.apache.org/wizard/statistics, which nags us to add it when we make a release. Is anyone opposed to deprecating https://sling.apache.org/releases.html ? We might indicate that that page is only valid until a certain date, and point to point to the reporter info. -Bertrand -- -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
[jira] [Commented] (SLING-9414) Allow to disable SonarQube run via module descriptor
[
https://issues.apache.org/jira/browse/SLING-9414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098923#comment-17098923
]
Konrad Windszus commented on SLING-9414:
Using {{sonarQubeUseAdditionalMavenParams": false}} fixed the website build. I
updated
https://cwiki.apache.org/confluence/display/SLING/Sling+module+descriptor with
the new options.
> Allow to disable SonarQube run via module descriptor
>
>
> Key: SLING-9414
> URL: https://issues.apache.org/jira/browse/SLING-9414
> Project: Sling
> Issue Type: Improvement
> Components: Tooling
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In the context of
> https://lists.apache.org/thread.html/ree9107867e5023e5bf468ffd34161d5226ed14dc01ba8dad3dffb8e5%40%3Cdev.sling.apache.org%3E
> it became obvious that in some cases SonarQube execution are not useful and
> should be disabled.
> In addition it would make sense to optionally not use the
> {{additionalMavenParams}}
> (https://cwiki.apache.org/confluence/display/SLING/Sling+module+descriptor)
> for the SonarQube run in
> https://github.com/apache/sling-tooling-jenkins/blob/96d11259bb003d4ff07a089d0fb66a48f8123ddb/vars/slingOsgiBundleBuild.groovy#L39.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Do we still need https://sling.apache.org/releases.html ?
Hi, The releases info now goes to https://reporter.apache.org/wizard/statistics, which nags us to add it when we make a release. Is anyone opposed to deprecating https://sling.apache.org/releases.html ? We might indicate that that page is only valid until a certain date, and point to point to the reporter info. -Bertrand
[jira] [Commented] (SLING-7811) NPE when repository is starting up due to repository manager shutdown
[
https://issues.apache.org/jira/browse/SLING-7811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098916#comment-17098916
]
Robert Munteanu commented on SLING-7811:
[~kwin] - I am working on a version of the stop method that does not rely on
{{Thread#interrupt}} , but unfortunately that does not work reliably yet. My
test bed is in SLING-9118.
> NPE when repository is starting up due to repository manager shutdown
> -
>
> Key: SLING-7811
> URL: https://issues.apache.org/jira/browse/SLING-7811
> Project: Sling
> Issue Type: Bug
> Components: JCR
>Affects Versions: JCR Oak Server 1.1.4, JCR Base 3.0.4
>Reporter: Carsten Ziegeler
>Priority: Major
> Fix For: JCR Oak Server 1.2.6
>
>
> With the latest Sling Starter, the following NPE occurs in the logs. It seems
> to be harmless, nevertheless we should fix it:
> For now I assigned it to both, JCR Base and Oak Server, as it's unclear which
> one it is. Interestingly we've released Oak Server 1.2.0 but are not using it
> in the starter.
> {noformat}
> 06.08.2018 15:45:18.396 *ERROR* [Apache Sling Repository Startup Thread]
> org.apache.sling.jcr.oak.server.internal.OakSlingRepositoryManager start:
> Uncaught Throwable trying to access Repository, calling stopRepository()
> java.lang.NullPointerException: null
> at
> com.google.common.base.Preconditions.checkNotNull(Preconditions.java:192)
> [com.google.guava:15.0.0]
> at org.apache.jackrabbit.oak.jcr.Jcr.with(Jcr.java:296)
> [org.apache.jackrabbit.oak-jcr:1.6.8]
> at
> org.apache.sling.jcr.oak.server.internal.OakSlingRepositoryManager.acquireRepository(OakSlingRepositoryManager.java:161)
> [org.apache.sling.jcr.oak.server:1.1.4]
> at
> org.apache.sling.jcr.base.AbstractSlingRepositoryManager.initializeAndRegisterRepositoryService(AbstractSlingRepositoryManager.java:471)
> [org.apache.sling.jcr.base:3.0.4]
> at
> org.apache.sling.jcr.base.AbstractSlingRepositoryManager.access$300(AbstractSlingRepositoryManager.java:85)
> [org.apache.sling.jcr.base:3.0.4]
> at
> org.apache.sling.jcr.base.AbstractSlingRepositoryManager$4.run(AbstractSlingRepositoryManager.java:455)
> [org.apache.sling.jcr.base:3.0.4]
> {noformat}
> The stack trace points to a null workspace name ( see
> https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.6.8/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/Jcr.java#L296
> ).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[RESULT][VOTE] Release Apache Sling Repoinit JCR 1.1.26
Hi, On Thu, Apr 30, 2020 at 5:14 PM Bertrand Delacretaz wrote: > ...Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2254/.. The vote passes with more than 3 binding +1s and no other votes, thank you! I'll promote this release now. I have created https://issues.apache.org/jira/browse/SLING-9419 for the reported test failures on Windows. -Bertrand
Re: [VOTE] Release Apache Sling Installer Factory Feature Model 0.3.0
On Sun, 2020-05-03 at 10:20 +0200, Carsten Ziegeler wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part
[jira] [Created] (SLING-9419) JCR Repoinit integration tests fail on Windows
Bertrand Delacretaz created SLING-9419:
--
Summary: JCR Repoinit integration tests fail on Windows
Key: SLING-9419
URL: https://issues.apache.org/jira/browse/SLING-9419
Project: Sling
Issue Type: Bug
Components: Repoinit
Reporter: Bertrand Delacretaz
In the JCR Repoinit 1.1.26 vote, Stefan Seifert notes the following failures on
Windows:
{code}
---
Test set: org.apache.sling.jcr.repoinit.RepositoryInitializerTest
---
Tests run: 10, Failures: 9, Errors: 0, Skipped: 0, Time elapsed: 17.193 s <<<
FAILURE! - in org.apache.sling.jcr.repoinit.RepositoryInitializerTest
org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Using
provisioning model] Time elapsed: 15.843 s <<< FAILURE!
java.lang.AssertionError: Got unexpected java.net.UnknownHostException in
activation
at
org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:139)
org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Default value
of model section config] Time elapsed: 0.152 s <<< FAILURE!
java.lang.AssertionError: Got unexpected java.net.UnknownHostException in
activation
at
org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:139)
org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Raw
repoinit/empty section] Time elapsed: 0.157 s <<< FAILURE!
java.lang.AssertionError: Got unexpected java.net.UnknownHostException in
activation
at
org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:139)
org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Raw
repoinit/ignored section name] Time elapsed: 0.142 s <<< FAILURE!
java.lang.AssertionError: Got unexpected java.net.UnknownHostException in
activation
at
org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:139)
org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[All empty,
just setup + parsing] Time elapsed: 0.167 s <<< FAILURE!
java.lang.AssertionError: Got unexpected java.net.UnknownHostException in
activation
at
org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:139)
org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Raw
repoinit/null format] Time elapsed: 0.145 s <<< FAILURE!
java.lang.AssertionError: expected: but was:
at
org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:137)
org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[With
model/null format] Time elapsed: 0.133 s <<< FAILURE!
java.lang.AssertionError: expected: but
was:
at
org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:137)
org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Invalid
format] Time elapsed: 0.162 s <<< FAILURE!
java.lang.AssertionError: expected: but
was:
at
org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:137)
org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Null model
section] Time elapsed: 0.137 s <<< FAILURE!
java.lang.AssertionError: expected: but was:
at
org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:137)
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-9419) JCR Repoinit integration tests fail on Windows
[
https://issues.apache.org/jira/browse/SLING-9419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz updated SLING-9419:
---
Fix Version/s: Repoinit JCR 1.1.28
> JCR Repoinit integration tests fail on Windows
> --
>
> Key: SLING-9419
> URL: https://issues.apache.org/jira/browse/SLING-9419
> Project: Sling
> Issue Type: Bug
> Components: Repoinit
>Reporter: Bertrand Delacretaz
>Priority: Minor
> Fix For: Repoinit JCR 1.1.28
>
>
> In the JCR Repoinit 1.1.26 vote, Stefan Seifert notes the following failures
> on Windows:
> {code}
> ---
> Test set: org.apache.sling.jcr.repoinit.RepositoryInitializerTest
> ---
> Tests run: 10, Failures: 9, Errors: 0, Skipped: 0, Time elapsed: 17.193 s <<<
> FAILURE! - in org.apache.sling.jcr.repoinit.RepositoryInitializerTest
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Using
> provisioning model] Time elapsed: 15.843 s <<< FAILURE!
> java.lang.AssertionError: Got unexpected java.net.UnknownHostException in
> activation
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:139)
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Default
> value of model section config] Time elapsed: 0.152 s <<< FAILURE!
> java.lang.AssertionError: Got unexpected java.net.UnknownHostException in
> activation
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:139)
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Raw
> repoinit/empty section] Time elapsed: 0.157 s <<< FAILURE!
> java.lang.AssertionError: Got unexpected java.net.UnknownHostException in
> activation
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:139)
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Raw
> repoinit/ignored section name] Time elapsed: 0.142 s <<< FAILURE!
> java.lang.AssertionError: Got unexpected java.net.UnknownHostException in
> activation
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:139)
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[All empty,
> just setup + parsing] Time elapsed: 0.167 s <<< FAILURE!
> java.lang.AssertionError: Got unexpected java.net.UnknownHostException in
> activation
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:139)
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Raw
> repoinit/null format] Time elapsed: 0.145 s <<< FAILURE!
> java.lang.AssertionError: expected: org.apache.sling.repoinit.parser.RepoInitParsingException> but was: java.net.UnknownHostException>
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:137)
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[With
> model/null format] Time elapsed: 0.133 s <<< FAILURE!
> java.lang.AssertionError: expected: but
> was:
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:137)
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Invalid
> format] Time elapsed: 0.162 s <<< FAILURE!
> java.lang.AssertionError: expected: but
> was:
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:137)
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Null model
> section] Time elapsed: 0.137 s <<< FAILURE!
> java.lang.AssertionError: expected: but was: java.net.UnknownHostException>
> at
> org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:137)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-9414) Allow to disable SonarQube run via module descriptor
[
https://issues.apache.org/jira/browse/SLING-9414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098900#comment-17098900
]
Robert Munteanu commented on SLING-9414:
LGTM, thanks [~kwin]. There is no way of testing right now, short of actually
running the build. Feel free to run and tweak if needed.
> Allow to disable SonarQube run via module descriptor
>
>
> Key: SLING-9414
> URL: https://issues.apache.org/jira/browse/SLING-9414
> Project: Sling
> Issue Type: Improvement
> Components: Tooling
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In the context of
> https://lists.apache.org/thread.html/ree9107867e5023e5bf468ffd34161d5226ed14dc01ba8dad3dffb8e5%40%3Cdev.sling.apache.org%3E
> it became obvious that in some cases SonarQube execution are not useful and
> should be disabled.
> In addition it would make sense to optionally not use the
> {{additionalMavenParams}}
> (https://cwiki.apache.org/confluence/display/SLING/Sling+module+descriptor)
> for the SonarQube run in
> https://github.com/apache/sling-tooling-jenkins/blob/96d11259bb003d4ff07a089d0fb66a48f8123ddb/vars/slingOsgiBundleBuild.groovy#L39.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Re: Subject: [VOTE] Release Apache Sling Repoinit JCR 1.1.26
+1 Carsten On 30.04.2020 17:14, Bertrand Delacretaz wrote: Hi, We solved 1 issue in this release: https://issues.apache.org/jira/projects/SLING/versions/12348199 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2254/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2254 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Here's my +1 -Bertrand -- -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
Re: Subject: [VOTE] Release Apache Sling Repoinit JCR 1.1.26
+1 On Thu, Apr 30, 2020 at 6:13 PM Stefan Seifert wrote: > +1 > > > please note that the unit tests fail on windows (they are running fine on > linux) > > > --- > Test set: org.apache.sling.jcr.repoinit.RepositoryInitializerTest > > --- > Tests run: 10, Failures: 9, Errors: 0, Skipped: 0, Time elapsed: 17.193 s > <<< FAILURE! - in org.apache.sling.jcr.repoinit.RepositoryInitializerTest > org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Using > provisioning model] Time elapsed: 15.843 s <<< FAILURE! > java.lang.AssertionError: Got unexpected java.net.UnknownHostException in > activation > at > org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:139) > > org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Default > value of model section config] Time elapsed: 0.152 s <<< FAILURE! > java.lang.AssertionError: Got unexpected java.net.UnknownHostException in > activation > at > org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:139) > > org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Raw > repoinit/empty section] Time elapsed: 0.157 s <<< FAILURE! > java.lang.AssertionError: Got unexpected java.net.UnknownHostException in > activation > at > org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:139) > > org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Raw > repoinit/ignored section name] Time elapsed: 0.142 s <<< FAILURE! > java.lang.AssertionError: Got unexpected java.net.UnknownHostException in > activation > at > org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:139) > > org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[All > empty, just setup + parsing] Time elapsed: 0.167 s <<< FAILURE! > java.lang.AssertionError: Got unexpected java.net.UnknownHostException in > activation > at > org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:139) > > org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Raw > repoinit/null format] Time elapsed: 0.145 s <<< FAILURE! > java.lang.AssertionError: expected: org.apache.sling.repoinit.parser.RepoInitParsingException> but was: java.net.UnknownHostException> > at > org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:137) > > org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[With > model/null format] Time elapsed: 0.133 s <<< FAILURE! > java.lang.AssertionError: expected: but > was: > at > org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:137) > > org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Invalid > format] Time elapsed: 0.162 s <<< FAILURE! > java.lang.AssertionError: expected: but > was: > at > org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:137) > > org.apache.sling.jcr.repoinit.RepositoryInitializerTest.testLogin[Null > model section] Time elapsed: 0.137 s <<< FAILURE! > java.lang.AssertionError: expected: but > was: > at > org.apache.sling.jcr.repoinit.RepositoryInitializerTest.setup(RepositoryInitializerTest.java:137) > > > > stefan > -- - Andrei
[jira] [Commented] (SLING-8704) Build PRs from non-committers
[ https://issues.apache.org/jira/browse/SLING-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098779#comment-17098779 ] Konrad Windszus commented on SLING-8704: I don’t think that approach scales as it involves committing to the master branch for each whitelisting. The idea is that we check PRs before a committer is involved. > Build PRs from non-committers > - > > Key: SLING-8704 > URL: https://issues.apache.org/jira/browse/SLING-8704 > Project: Sling > Issue Type: Improvement > Components: Build and Source Control >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > As outlined in > https://issues.apache.org/jira/browse/INFRA-18748?focusedCommentId=16885091=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16885091 > and discussed in > https://lists.apache.org/thread.html/7ba9424ae1cadd61363a5c6e7d12dec9f5b424b1f68e27915032fbab@%3Cprivate.infra.apache.org%3E > it is no longer allowed to automatically build PRs from non-committers on > ASF infra. > Therefore another solution needs to be found to be able to validate PRs from > contributors. This validation should include at least a Maven build and the > validation of SonarQube rules. > Several options come to my mind > # Use CloudBees Code Ship https://app.codeship.com/home. Currently it is > unclear whether there is a dedicated ASF account. I asked about it in > https://issues.apache.org/jira/browse/INFRA-18973. Preferred option as > probably the Jenkinsfile can be reused. > # Use Travis CI. There is a dedicated ASF account but it a) needs to be > enabled by INFRA per project and b) requires to maintain another build script > next to the Jenkinsfile we already have > # Use another 3rd party build provider > This was also discussed during the Sling Hackathon 2019 > (https://lists.apache.org/thread.html/fb675eda239779450943623490e5a232786464df1dfb1feac5ec4ee0@%3Cdev.sling.apache.org%3E). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-8704) Build PRs from non-committers
[
https://issues.apache.org/jira/browse/SLING-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098756#comment-17098756
]
Bertrand Delacretaz commented on SLING-8704:
https://cwiki.apache.org/confluence/display/INFRA/.asf.yaml+features+for+git+repositories
mentions a {{github_whitelist}} option in the {{.asf.yaml}} file, to
"designate a GitHub person as a 'safe/reliable' person" for Jenkins builds,
isn't that what we need here?
> Build PRs from non-committers
> -
>
> Key: SLING-8704
> URL: https://issues.apache.org/jira/browse/SLING-8704
> Project: Sling
> Issue Type: Improvement
> Components: Build and Source Control
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> As outlined in
> https://issues.apache.org/jira/browse/INFRA-18748?focusedCommentId=16885091=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16885091
> and discussed in
> https://lists.apache.org/thread.html/7ba9424ae1cadd61363a5c6e7d12dec9f5b424b1f68e27915032fbab@%3Cprivate.infra.apache.org%3E
> it is no longer allowed to automatically build PRs from non-committers on
> ASF infra.
> Therefore another solution needs to be found to be able to validate PRs from
> contributors. This validation should include at least a Maven build and the
> validation of SonarQube rules.
> Several options come to my mind
> # Use CloudBees Code Ship https://app.codeship.com/home. Currently it is
> unclear whether there is a dedicated ASF account. I asked about it in
> https://issues.apache.org/jira/browse/INFRA-18973. Preferred option as
> probably the Jenkinsfile can be reused.
> # Use Travis CI. There is a dedicated ASF account but it a) needs to be
> enabled by INFRA per project and b) requires to maintain another build script
> next to the Jenkinsfile we already have
> # Use another 3rd party build provider
> This was also discussed during the Sling Hackathon 2019
> (https://lists.apache.org/thread.html/fb675eda239779450943623490e5a232786464df1dfb1feac5ec4ee0@%3Cdev.sling.apache.org%3E).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [sling-org-apache-sling-discovery-base] rombert commented on pull request #1: Change for security concern
rombert commented on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-discovery-base/pull/1#issuecomment-623299155 Thanks. I'll defer to @stefan-egli on this one, as he has worked on this module the most This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
