date:20200508

Hi

I tried to release the sling-project-archetype but ran into an issue where it 
cannot upload the SNAPSHOT to its snapshot folder:

http://repository.apache.org/content/groups/snapshots/org/apache/sling/sling-project-archetype/
 


If I open this in a browser then I get a 500 - This stopwatch is already 
stopped.

I also saw that Jenkins ran into that issues today as well due to my commits.

Any idea on how to fix it?

- Andy

[jira] [Commented] (SLING-9118) Sling fails to start when database exists but 'sling' directory is missing



[ 
https://issues.apache.org/jira/browse/SLING-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103013#comment-17103013
 ] 

Robert Munteanu commented on SLING-9118:


[~andysch] - that's a good point. As mentioned on dev@sling, I'm still finding 
my way around these things :-) I preferred a different approach for a couple of 
reasons

- the kickstart embedded an oak_tar feature file
- the kickstart embedded a slightly older feature file
- I preferred as few moving parts as possible; I'm familiar with the feature 
launcher, not so much with the kickstart (yet)

> Sling fails to start when database exists but 'sling' directory is missing
> --
>
> Key: SLING-9118
> URL: https://issues.apache.org/jira/browse/SLING-9118
> Project: Sling
>  Issue Type: Bug
>Reporter: Ben Radey
>Assignee: Robert Munteanu
>Priority: Major
> Attachments: drop-mongo.sh, error.log, fm-launch.zip, karaf.log, 
> recreateSlingReplicaSet.sh, run-mongo.sh, run-sling-initial.sh, 
> run-sling-second.sh, sling-startup-error.log.txt
>
>
> # Create a persistent mongodb to use with Sling.
>  # Start sling using the mongodb.
>  # Stop sling.
>  # Remove 'sling' directory.
>  # Attempt to restart sling. Ultimately, sling fails to start.
> 
> Steps to reproduce with attached scripts:
> # Run [^run-mongo.sh] . This creates a MongoDB 3.6 container named 
> _mongo-sling_
> # Run [^run-sling-initial.sh]. This starts up Sling in the oak_mongo runmode, 
> shuts it down after it's (probably) started up
> # Run [^run-sling-second.sh]. This moves away the sling directory and starts 
> up a new instance. This always fails
> For cleanup, the [^drop-mongo.sh] script stops and removes the _mongo-sling_ 
> container.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [feature-model] Different input format for feature files?

On Fri, 2020-05-08 at 18:58 +0200, Carsten Ziegeler wrote:
> We had that discussion twice in the past as well as the one about
> the 
> format :)

Right, I was not looking for a format change, JSON is in my mind here
to stay. Just trying to understand what it would take to get another
format as the source of truth.

Right now the only option is for it to live the fully outside the
feature model tooling. Maybe I'll have time to experiment with such a
Maven plugin setup, maybe not. But it's definitely not something that
will impact the Sling Feature Model project.

> 
> If you have a reference, you need to manage that and make sure that
> you 
> always transport two files (the feature model and the referenced
> repo 
> init). This can get pretty complicated.

Right, I remember that discussion and I think the argument for having
self-contained feature definition files is solid.

> 
> Now, we could support this in the slingfeature maven plugin only -
> when 
> reading a feature file; that would be fine. But once that feature is 
> written, it will be written with the repoinit inlined.
> 
> We deviate from the specified format there already by not requiring
> an 
> id in the file, so this would be just another case.

I don't have a strong opinion either way. I like self-contained feature
files, and dislike how repoinit looks as JSON.

Thanks,
Robert

> 
> Carsten
> 
> 
> On 08.05.2020 18:52, Daniel Klco wrote:
> > Would it be possible to externalize the repoinit files? I feel like
> > that
> > would resolve a lot of the issues if you could instead reference a
> > repoinit
> > file in the native format vs. embedding it into the JSON (which I
> > agree is
> > a pain to read.
> > 
> > On Fri, May 8, 2020 at 11:49 AM Robert Munteanu  > > wrote:
> > 
> > > On Fri, 2020-05-08 at 17:47 +0200, Carsten Ziegeler wrote:
> > > > It's documented :)
> > > > 
> > > > 
> > > https://github.com/apache/sling-org-apache-sling-feature/blob/master/docs/features.md#feature-file-format
> > > > And yes, integrating a preprocessor in every place where we
> > > > today
> > > > read
> > > > feature files is another major undertaking.
> > > 
> > > I was thinking more about having a Maven plugin running in the
> > > build
> > > before the slingfeature-maven-plugin starts to do its magic. This
> > > way
> > > there is no actual change to the sling feature model tooling.
> > > 
> > > 
> > > > And I think its a bad idea to support more than one format.
> > > 
> > > But yes, a major undertaking and possibly a bad idea.
> > > 
> > > Thanks,
> > > Robert
> > > 
> > > > Regards
> > > > Carsten
> > > > 
> > > > On 08.05.2020 17:44, Robert Munteanu wrote:
> > > > > Ok, probably not worth the effort :-)
> > > > > 
> > > > > Thanks for the information about JSMin-style comments, I was
> > > > > not
> > > > > aware
> > > > > of that. I guess the downside is that IDEs/editors will
> > > > > complain,
> > > > > but
> > > > > that's a choice we can make.
> > > > > 
> > > > > Thinking out loud - if we generate the JSON files from
> > > > > another
> > > > > format
> > > > > before passing them over to the feature launcher/analyser
> > > > > then we
> > > > > would
> > > > > be safe. But that's also not very easy I guess.
> > > > > 
> > > > > Thanks,
> > > > > Robert
> > > > > 
> > > > > On Fri, 2020-05-08 at 17:36 +0200, Carsten Ziegeler wrote:
> > > > > > It would be a significant effort, basically rewriting
> > > > > > everything
> > > > > > including all modules, extensions and tooling.
> > > > > > 
> > > > > > Not sure if that is really worth the effort.
> > > > > > 
> > > > > > Repoinit is a little bit of a pain, I agree. But I don't
> > > > > > think
> > > > > > this
> > > > > > minor use case warrants such a dramatic change.
> > > > > > 
> > > > > > For comments, you can use JSmin style comments (like
> > > > > > mentioned on
> > > > > > jsonnet), so I don't consider this an issue.
> > > > > > 
> > > > > > Regards
> > > > > > Carsten
> > > > > > 
> > > > > > On 08.05.2020 17:28, Robert Munteanu wrote:
> > > > > > > Hi,
> > > > > > > 
> > > > > > > I keep thinking about how the feature files would look
> > > > > > > like in
> > > > > > > a
> > > > > > > different format. The main driver is the way repoinit
> > > > > > > statements
> > > > > > > look
> > > > > > > at the moment. Comments are also a bit awkward, even
> > > > > > > though
> > > > > > > possible in
> > > > > > > JSON.
> > > > > > > 
> > > > > > > I was looking at Jsonnet [1], which is a superset of JSON
> > > > > > > with
> > > > > > > lots
> > > > > > > of
> > > > > > > bells and whistles, including comments and multiline
> > > > > > > strings.
> > > > > > > 
> > > > > > > But irrespective of format - Jsonnet, YAML, or something
> > > > > > > else -
> > > > > > > what
> > > > > > > would it take to add another input format to the feature
> > > > > > > model?
> > > > > > > Is
> > > > > > > it
> > > > > > > something can be easily plugged in or would it require a
> > > > > > >

Re: Animal Sniffer Failure on Kickstart Project

On Fri, 2020-05-08 at 10:56 -0700, Andreas Schaefer wrote:
> The build runs fine. I only ran into an issue when I did ‘man
> deploy’.

Ah, good point. I ran a `mvn deploy` with Java 8, and it does fail to
me with the same error.

I updated to parent pom version 38, but then I got lots of error
related to shaded classes from jackrabbit, e.g.

[ERROR] 
/home/robert/sources/apache/sling/org-apache-sling-kickstart/target/classes/shaded/org/apache/jackrabbit/vault/fs/spi/impl/jcr20/JackrabbitUserManagement.class:88:
 Undefined reference: shaded.org.apache.jackrabbit.api.JackrabbitSession
Maybe an unfortunate interaction between the animal sniffer and shade
plugins?

Thanks,
Robert

> 
> - Andy
> 
> > On May 8, 2020, at 12:37 AM, Robert Munteanu 
> > wrote:
> > 
> > Hi Andy,
> > 
> > On Thu, 2020-05-07 at 17:13 -0700, Andreas Schaefer wrote:
> > > Hi
> > > 
> > > While I was trying to release the Sling Kickstart Project during
> > > ‘man
> > > deploy’ of the snapshots I ran into this issue (Sling Parent 38):
> > (snip)
> > > [ERROR] Failed to execute goal org.codehaus.mojo:animal-sniffer-
> > > maven-plugin:1.17:check (default) on project
> > > org.apache.sling.kickstart: Execution default of goal
> > > org.codehaus.mojo:animal-sniffer-maven-plugin:1.17:check failed:
> > > An
> > > API incompatibility was encountered while executing
> > > org.codehaus.mojo:animal-sniffer-maven-plugin:1.17:check:
> > > java.lang.NoSuchMethodError:
> > > java.nio.CharBuffer.position(I)Ljava/nio/CharBuffer;
> > > [ERROR] -
> > > [ERROR] realm =plugin>org.codehaus.mojo:animal-sniffer-maven-
> > > plugin:1.17
> > > [ERROR] strategy =
> > > org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
> > 
> > I was able to build the kickstart project without issues. I tried
> > both
> > Java 8 and 11:
> > 
> > Apache Maven 3.6.3 (SUSE 3.6.3-2.1)
> > Maven home: /usr/share/maven
> > Java version: 1.8.0_242, vendor: IcedTea, runtime:
> > /usr/lib64/jvm/java-1.8.0-openjdk-1.8.0/jre
> > Default locale: en_US, platform encoding: UTF-8
> > OS name: "linux", version: "5.6.8-1-default", arch: "amd64",
> > family: "unix"
> > 
> > Apache Maven 3.6.3 (SUSE 3.6.3-2.1)
> > Maven home: /usr/share/maven
> > Java version: 11.0.7, vendor: Oracle Corporation, runtime:
> > /usr/lib64/jvm/java-11-openjdk-11
> > Default locale: en_US, platform encoding: UTF-8
> > OS name: "linux", version: "5.6.8-1-default", arch: "amd64",
> > family: "unix"
> > 
> > Thanks,
> > Robert
> >

Re: Kickstart modules still in whiteboard

On Fri, 2020-05-08 at 13:22 -0700, Andreas Schaefer wrote:
> Done

Thanks, Andy!

Robert

> 
> > On May 8, 2020, at 10:55 AM, Andreas Schaefer <
> > schaef...@me.com.INVALID> wrote:
> > 
> > I’ll do that today.
> > 
> > - Andy
> > 
> > > On May 8, 2020, at 12:42 AM, Robert Munteanu <
> > > rmunt...@adobe.com.INVALID> wrote:
> > > 
> > > Hi,
> > > 
> > > I see we have moved the kickstart modules to their own
> > > repositories,
> > > but they are still present in the sling whiteboard.
> > > 
> > > Should the code in the whiteboard be deleted?
> > > 
> > > Thanks,
> > > Robert

Re: [Discuss] (SLING-8350) Switch the Sling starter to the feature model

Hi Ruben,

On Fri, 2020-05-08 at 10:55 -0700, Ruben Reusser wrote:
> Robert,
> 
> you mentioned bringing this discussion to the dev mailing list (hope
> I 
> did this the right way)
> 
> > - kickstart launcher (fat JAR)
> 
> I am not sure why you think the kickstarter is a fat jar. It relies
> on a 
> feature file for sling and the feature launcher. It's main purpose is
> to 
> provide the same command line argument interface as the 
> apache.sling.starter on top of the feature launcher as the feature 
> launcher is rather limited in that regard. Also note that once the 
> feature launcher with FAR support is released the kickstarter will
> also 
> support FARs.

Ah, thanks for clarifying that. I'm slowly trying to better understand
how things fit in the picture, and I had the impression that the
kickstart launcher was the complete equivalent of the launchpad jar.

I think both the kickstart and the feature launcher have their place in
the Sling space. But I still don't claim to understand things
completely :-)

I think this is the point where someone says 'enough emails, someone
should go write a Wiki page. I'll try and summarise the current status
and the options that I'm aware of and come back to the dev list.

I think from a technical point of view we are close enough to having a
proper alternative to the feature model based starter to start drawing
up a concrete proposal.

Thanks,
Robert

> 
> as a reference: below the -h output for the feature launcher, 
> kickstarter and classic sling starter
> 
> Ruben
> 
> feature launcher command line interface:
> 
> usage: launcher -C  Set artifact clash override -c  Set
> cache 
> dir -CC  Set config clash override -D  Set framework 
> properties -ec  Provide extension configuration, format: 
> extensionName:key1=val1,key2=val2 -f  Set feature files -fa
>  
> Set framework artifact (overrides felix framework version) -fv 
> Set 
> felix framework version -p  Set home dir -u  Set
> repository 
> url -V  Set variable value -v Verbose
> 
> kickstarter command line interface
> 
> Usage: java -jar  [-hnv] [-a=] 
> [-c=] [-f=] [-i=] 
> [-j=] [-l=] [-p=] [-r=] 
> [-s=] [-af=]... 
> [-D=]... [COMMAND] Apache Sling Kickstart [COMMAND] 
> Optional Command for Server Instance Interaction, can be one of: 
> 'start', 'stop', 'status' or 'threads' -a, --address= the 
> interface to bind to (use 0.0.0.0 for any) -af, 
> --additionalFeature= additional feature files
> -c, 
> --slingHome= the sling context directory (default sling)
> -D, 
> --define= sets property n to value v. Make sure to
> use 
> this option *after* the jar filename. The JVM also has a -D option
> which 
> has a different meaning -f, --logFile= the log file, "-"
> for 
> stdout (default logs/error.log) -h, --help Display the usage
> message. 
> -i, --launcherHome= the launcher home directory
> (default 
> launcher) -j, --control= host and port to use for 
> control connection in the format '[host:]port' (default 127.0.0.1:0)
> -l, 
> --logLevel= the initial loglevel (0..4, FATAL, ERROR,
> WARN, 
> INFO, DEBUG) -n, --noShutdownHook don't install the shutdown hook
> -p, 
> --port= the port to listen to (default 8080) -r, 
> --context= the root servlet context path for the http 
> service (default is /) -s, --mainFeature= main
> feature 
> file (file path or URL) replacing the provided Sling Feature File
> -v, 
> --verbose the feature launcher is verbose on launch Copyright(c)
> 2020 
> The Apache Software Foundation.
> 
> classic
> 
> usage: org.apache.sling.launchpad.app.Main [ start | stop | status ]
> [ 
> -j adr ] [ -l loglevel ] [ -f logfile ] [ -c slinghome ] [ -i 
> launchpadhome ] [ -a address ] [ -p port ] { -Dn=v } [ -h ]
>  start listen for control connection (uses -j)
>  stop  terminate running Apache Sling (uses -j)
>  statuscheck whether Apache Sling is running (uses -j)
>  threads   request a thread dump from Apache Sling (uses -j)
>  -j adrhost and port to use for control connection in
> the 
> format '[host:]port' (default 127.0.0.1:0)
>  -l loglevel   the initial loglevel (0..4, FATAL, ERROR, WARN,
> INFO, 
> DEBUG)
>  -f logfilethe log file, "-" for stdout (default
> logs/error.log)
>  -c slinghome  the sling context directory (default sling)
>  -i launchpadhome  the launchpad directory (default slinghome)
>  -a addressthe interfact to bind to (use 0.0.0.0 for any)
>  -p port   the port to listen to (default 8080)
>  -r path   the root servlet context path for the http
> service 
> (default is /)
>  -ndon't install the shutdown hook
>  -Dn=v sets property n to value v. Make sure to use this 
> option *after* the jar filename. The JVM also has a -D option which
> has 
> a different meaning
>  -hprints this usage message
> 
> On 5/8/2020 12:27 AM, Robert Munteanu (Jira) wrote:
> >  [ 
> >

Re: [VOTE] Move o.a.s.graphql.core to its own repo

2020-05-08 Thread Andrei Dulvac

+1

On Fri, 8 May 2020 at 23:13, Daniel Klco  wrote:

> +1
>
> On Fri, May 8, 2020 at 8:06 AM Radu Cotescu  wrote:
>
> > On 8 May 2020, at 14:03, Bertrand Delacretaz 
> > wrote:
> > >
> > > I'd like to move the org.apache.sling.graphql.core [1] code to its own
> > > module, see the README there for more info on what it does.
> >
> > +1
>

Re: [VOTE] Move o.a.s.graphql.core to its own repo

2020-05-08 Thread Daniel Klco

+1

On Fri, May 8, 2020 at 8:06 AM Radu Cotescu  wrote:

> On 8 May 2020, at 14:03, Bertrand Delacretaz 
> wrote:
> >
> > I'd like to move the org.apache.sling.graphql.core [1] code to its own
> > module, see the README there for more info on what it does.
>
> +1

Re: Kickstart modules still in whiteboard

Done

> On May 8, 2020, at 10:55 AM, Andreas Schaefer  
> wrote:
> 
> I’ll do that today.
> 
> - Andy
> 
>> On May 8, 2020, at 12:42 AM, Robert Munteanu  
>> wrote:
>> 
>> Hi,
>> 
>> I see we have moved the kickstart modules to their own repositories,
>> but they are still present in the sling whiteboard.
>> 
>> Should the code in the whiteboard be deleted?
>> 
>> Thanks,
>> Robert
>

[jira] [Commented] (SLING-9118) Sling fails to start when database exists but 'sling' directory is missing

2020-05-08 Thread Andreas Schaefer (Jira)



[ 
https://issues.apache.org/jira/browse/SLING-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102827#comment-17102827
 ] 

Andreas Schaefer commented on SLING-9118:
-

[~rombert] you could have just used the Kickstart as this does exactly that 
(java -jar org.apache.sling.kickstart-.jar)

> Sling fails to start when database exists but 'sling' directory is missing
> --
>
> Key: SLING-9118
> URL: https://issues.apache.org/jira/browse/SLING-9118
> Project: Sling
>  Issue Type: Bug
>Reporter: Ben Radey
>Assignee: Robert Munteanu
>Priority: Major
> Attachments: drop-mongo.sh, error.log, fm-launch.zip, karaf.log, 
> recreateSlingReplicaSet.sh, run-mongo.sh, run-sling-initial.sh, 
> run-sling-second.sh, sling-startup-error.log.txt
>
>
> # Create a persistent mongodb to use with Sling.
>  # Start sling using the mongodb.
>  # Stop sling.
>  # Remove 'sling' directory.
>  # Attempt to restart sling. Ultimately, sling fails to start.
> 
> Steps to reproduce with attached scripts:
> # Run [^run-mongo.sh] . This creates a MongoDB 3.6 container named 
> _mongo-sling_
> # Run [^run-sling-initial.sh]. This starts up Sling in the oak_mongo runmode, 
> shuts it down after it's (probably) started up
> # Run [^run-sling-second.sh]. This moves away the sling directory and starts 
> up a new instance. This always fails
> For cleanup, the [^drop-mongo.sh] script stops and removes the _mongo-sling_ 
> container.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Animal Sniffer Failure on Kickstart Project

The build runs fine. I only ran into an issue when I did ‘man deploy’.

- Andy

> On May 8, 2020, at 12:37 AM, Robert Munteanu  wrote:
> 
> Hi Andy,
> 
> On Thu, 2020-05-07 at 17:13 -0700, Andreas Schaefer wrote:
>> Hi
>> 
>> While I was trying to release the Sling Kickstart Project during ‘man
>> deploy’ of the snapshots I ran into this issue (Sling Parent 38):
> (snip)
>> [ERROR] Failed to execute goal org.codehaus.mojo:animal-sniffer-
>> maven-plugin:1.17:check (default) on project
>> org.apache.sling.kickstart: Execution default of goal
>> org.codehaus.mojo:animal-sniffer-maven-plugin:1.17:check failed: An
>> API incompatibility was encountered while executing
>> org.codehaus.mojo:animal-sniffer-maven-plugin:1.17:check:
>> java.lang.NoSuchMethodError:
>> java.nio.CharBuffer.position(I)Ljava/nio/CharBuffer;
>> [ERROR] -
>> [ERROR] realm =plugin>org.codehaus.mojo:animal-sniffer-maven-
>> plugin:1.17
>> [ERROR] strategy =
>> org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
> 
> I was able to build the kickstart project without issues. I tried both
> Java 8 and 11:
> 
> Apache Maven 3.6.3 (SUSE 3.6.3-2.1)
> Maven home: /usr/share/maven
> Java version: 1.8.0_242, vendor: IcedTea, runtime: 
> /usr/lib64/jvm/java-1.8.0-openjdk-1.8.0/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "5.6.8-1-default", arch: "amd64", family: "unix"
> 
> Apache Maven 3.6.3 (SUSE 3.6.3-2.1)
> Maven home: /usr/share/maven
> Java version: 11.0.7, vendor: Oracle Corporation, runtime: 
> /usr/lib64/jvm/java-11-openjdk-11
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "5.6.8-1-default", arch: "amd64", family: "unix"
> 
> Thanks,
> Robert
>

[Discuss] (SLING-8350) Switch the Sling starter to the feature model

2020-05-08 Thread Ruben Reusser


Robert,

you mentioned bringing this discussion to the dev mailing list (hope I 
did this the right way)



- kickstart launcher (fat JAR)


I am not sure why you think the kickstarter is a fat jar. It relies on a 
feature file for sling and the feature launcher. It's main purpose is to 
provide the same command line argument interface as the 
apache.sling.starter on top of the feature launcher as the feature 
launcher is rather limited in that regard. Also note that once the 
feature launcher with FAR support is released the kickstarter will also 
support FARs.


as a reference: below the -h output for the feature launcher, 
kickstarter and classic sling starter


Ruben

feature launcher command line interface:

usage: launcher -C  Set artifact clash override -c  Set cache 
dir -CC  Set config clash override -D  Set framework 
properties -ec  Provide extension configuration, format: 
extensionName:key1=val1,key2=val2 -f  Set feature files -fa  
Set framework artifact (overrides felix framework version) -fv  Set 
felix framework version -p  Set home dir -u  Set repository 
url -V  Set variable value -v Verbose


kickstarter command line interface

Usage: java -jar  [-hnv] [-a=] 
[-c=] [-f=] [-i=] 
[-j=] [-l=] [-p=] [-r=] 
[-s=] [-af=]... 
[-D=]... [COMMAND] Apache Sling Kickstart [COMMAND] 
Optional Command for Server Instance Interaction, can be one of: 
'start', 'stop', 'status' or 'threads' -a, --address= the 
interface to bind to (use 0.0.0.0 for any) -af, 
--additionalFeature= additional feature files -c, 
--slingHome= the sling context directory (default sling) -D, 
--define= sets property n to value v. Make sure to use 
this option *after* the jar filename. The JVM also has a -D option which 
has a different meaning -f, --logFile= the log file, "-" for 
stdout (default logs/error.log) -h, --help Display the usage message. 
-i, --launcherHome= the launcher home directory (default 
launcher) -j, --control= host and port to use for 
control connection in the format '[host:]port' (default 127.0.0.1:0) -l, 
--logLevel= the initial loglevel (0..4, FATAL, ERROR, WARN, 
INFO, DEBUG) -n, --noShutdownHook don't install the shutdown hook -p, 
--port= the port to listen to (default 8080) -r, 
--context= the root servlet context path for the http 
service (default is /) -s, --mainFeature= main feature 
file (file path or URL) replacing the provided Sling Feature File -v, 
--verbose the feature launcher is verbose on launch Copyright(c) 2020 
The Apache Software Foundation.


classic

usage: org.apache.sling.launchpad.app.Main [ start | stop | status ] [ 
-j adr ] [ -l loglevel ] [ -f logfile ] [ -c slinghome ] [ -i 
launchpadhome ] [ -a address ] [ -p port ] { -Dn=v } [ -h ]

    start listen for control connection (uses -j)
    stop  terminate running Apache Sling (uses -j)
    status    check whether Apache Sling is running (uses -j)
    threads   request a thread dump from Apache Sling (uses -j)
    -j adr    host and port to use for control connection in the 
format '[host:]port' (default 127.0.0.1:0)
    -l loglevel   the initial loglevel (0..4, FATAL, ERROR, WARN, INFO, 
DEBUG)

    -f logfile    the log file, "-" for stdout (default logs/error.log)
    -c slinghome  the sling context directory (default sling)
    -i launchpadhome  the launchpad directory (default slinghome)
    -a address    the interfact to bind to (use 0.0.0.0 for any)
    -p port   the port to listen to (default 8080)
    -r path   the root servlet context path for the http service 
(default is /)

    -n    don't install the shutdown hook
    -Dn=v sets property n to value v. Make sure to use this 
option *after* the jar filename. The JVM also has a -D option which has 
a different meaning

    -h    prints this usage message

On 5/8/2020 12:27 AM, Robert Munteanu (Jira) wrote:

 [ 
https://issues.apache.org/jira/browse/SLING-8350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102331#comment-17102331
 ]

Robert Munteanu commented on SLING-8350:


I think it's worthwhile discussing the way forward ( or the way out :-) ) with 
the Feature Model on dev@sling . I don't claim to have a good understanding of 
the solution space yet, but what I understand is that we have three possible 
levels of support:

- feature launcher + feature file ( JSON )
- feature launcher + feature archive ( FAR )
- kickstart launcher (fat JAR)

I am not sure which option is "the best", and IIRC at some point we were 
discussing FAR vs KickStart.

As I've said, it would be worthwhile to discuss on the dev list.

Re: Kickstart modules still in whiteboard

I’ll do that today.

- Andy

> On May 8, 2020, at 12:42 AM, Robert Munteanu  
> wrote:
> 
> Hi,
> 
> I see we have moved the kickstart modules to their own repositories,
> but they are still present in the sling whiteboard.
> 
> Should the code in the whiteboard be deleted?
> 
> Thanks,
> Robert

Re: [feature-model] Different input format for feature files?

We had that discussion twice in the past as well as the one about the
format :)

If you have a reference, you need to manage that and make sure that you
always transport two files (the feature model and the referenced repo
init). This can get pretty complicated.

Now, we could support this in the slingfeature maven plugin only - when
reading a feature file; that would be fine. But once that feature is
written, it will be written with the repoinit inlined.

We deviate from the specified format there already by not requiring an
id in the file, so this would be just another case.

Carsten

On 08.05.2020 18:52, Daniel Klco wrote:

Would it be possible to externalize the repoinit files? I feel like that
would resolve a lot of the issues if you could instead reference a repoinit
file in the native format vs. embedding it into the JSON (which I agree is
a pain to read.

On Fri, May 8, 2020 at 11:49 AM Robert Munteanu wrote:

On Fri, 2020-05-08 at 17:47 +0200, Carsten Ziegeler wrote:

It's documented :)

https://github.com/apache/sling-org-apache-sling-feature/blob/master/docs/features.md#feature-file-format

And yes, integrating a preprocessor in every place where we today
read
feature files is another major undertaking.

I was thinking more about having a Maven plugin running in the build
before the slingfeature-maven-plugin starts to do its magic. This way
there is no actual change to the sling feature model tooling.

And I think its a bad idea to support more than one format.

But yes, a major undertaking and possibly a bad idea.

Thanks,
Robert

Regards
Carsten

On 08.05.2020 17:44, Robert Munteanu wrote:

Ok, probably not worth the effort :-)

Thanks for the information about JSMin-style comments, I was not
aware
of that. I guess the downside is that IDEs/editors will complain,
but
that's a choice we can make.

Thinking out loud - if we generate the JSON files from another
format
before passing them over to the feature launcher/analyser then we
would
be safe. But that's also not very easy I guess.

Thanks,
Robert

On Fri, 2020-05-08 at 17:36 +0200, Carsten Ziegeler wrote:

It would be a significant effort, basically rewriting everything
including all modules, extensions and tooling.

Not sure if that is really worth the effort.

Repoinit is a little bit of a pain, I agree. But I don't think
this
minor use case warrants such a dramatic change.

For comments, you can use JSmin style comments (like mentioned on
jsonnet), so I don't consider this an issue.

Regards
Carsten

On 08.05.2020 17:28, Robert Munteanu wrote:

Hi,

I keep thinking about how the feature files would look like in
a
different format. The main driver is the way repoinit
statements
look
at the moment. Comments are also a bit awkward, even though
possible in
JSON.

I was looking at Jsonnet [1], which is a superset of JSON with
lots
of
bells and whistles, including comments and multiline strings.

But irrespective of format - Jsonnet, YAML, or something else -
what
would it take to add another input format to the feature model?
Is
it
something can be easily plugged in or would it require a
significant
rewrite?

Thanks,
Robert

[1]: https://jsonnet.org/

--
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: [feature-model] Different input format for feature files?

2020-05-08 Thread Daniel Klco

Would it be possible to externalize the repoinit files? I feel like that
would resolve a lot of the issues if you could instead reference a repoinit
file in the native format vs. embedding it into the JSON (which I agree is
a pain to read.

On Fri, May 8, 2020 at 11:49 AM Robert Munteanu  wrote:

> On Fri, 2020-05-08 at 17:47 +0200, Carsten Ziegeler wrote:
> > It's documented :)
> >
> >
> https://github.com/apache/sling-org-apache-sling-feature/blob/master/docs/features.md#feature-file-format
> >
> > And yes, integrating a preprocessor in every place where we today
> > read
> > feature files is another major undertaking.
>
> I was thinking more about having a Maven plugin running in the build
> before the slingfeature-maven-plugin starts to do its magic. This way
> there is no actual change to the sling feature model tooling.
>
>
> > And I think its a bad idea to support more than one format.
>
> But yes, a major undertaking and possibly a bad idea.
>
> Thanks,
> Robert
>
> >
> > Regards
> > Carsten
> >
> > On 08.05.2020 17:44, Robert Munteanu wrote:
> > > Ok, probably not worth the effort :-)
> > >
> > > Thanks for the information about JSMin-style comments, I was not
> > > aware
> > > of that. I guess the downside is that IDEs/editors will complain,
> > > but
> > > that's a choice we can make.
> > >
> > > Thinking out loud - if we generate the JSON files from another
> > > format
> > > before passing them over to the feature launcher/analyser then we
> > > would
> > > be safe. But that's also not very easy I guess.
> > >
> > > Thanks,
> > > Robert
> > >
> > > On Fri, 2020-05-08 at 17:36 +0200, Carsten Ziegeler wrote:
> > > > It would be a significant effort, basically rewriting everything
> > > > including all modules, extensions and tooling.
> > > >
> > > > Not sure if that is really worth the effort.
> > > >
> > > > Repoinit is a little bit of a pain, I agree. But I don't think
> > > > this
> > > > minor use case warrants such a dramatic change.
> > > >
> > > > For comments, you can use JSmin style comments (like mentioned on
> > > > jsonnet), so I don't consider this an issue.
> > > >
> > > > Regards
> > > > Carsten
> > > >
> > > > On 08.05.2020 17:28, Robert Munteanu wrote:
> > > > > Hi,
> > > > >
> > > > > I keep thinking about how the feature files would look like in
> > > > > a
> > > > > different format. The main driver is the way repoinit
> > > > > statements
> > > > > look
> > > > > at the moment. Comments are also a bit awkward, even though
> > > > > possible in
> > > > > JSON.
> > > > >
> > > > > I was looking at Jsonnet [1], which is a superset of JSON with
> > > > > lots
> > > > > of
> > > > > bells and whistles, including comments and multiline strings.
> > > > >
> > > > > But irrespective of format - Jsonnet, YAML, or something else -
> > > > > what
> > > > > would it take to add another input format to the feature model?
> > > > > Is
> > > > > it
> > > > > something can be easily plugged in or would it require a
> > > > > significant
> > > > > rewrite?
> > > > >
> > > > > Thanks,
> > > > > Robert
> > > > >
> > > > >
> > > > > [1]: https://jsonnet.org/
> > > > >
>
>

[jira] [Commented] (SLING-9118) Sling fails to start when database exists but 'sling' directory is missing



[ 
https://issues.apache.org/jira/browse/SLING-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102708#comment-17102708
 ] 

Robert Munteanu commented on SLING-9118:


[~carlosmunoz], [~benradey] - I gave this a try using the Sling Feature model 
and it seems to work perfectly for me. I converted the Sling Starter to the 
Feature Model ( so same bundles, same configs ) and launched it. Would you like 
to try that as well?

I have uploaded [^fm-launch.zip] , which contains:

- the generated feature model files
- the latest SNAPSHOT build of the feature launcher built from 
https://github.com/apache/sling-org-apache-sling-feature-launcher
- a script that launches it all (run-fm.sh)

Note that the 'sling' directory is now 'launcher', so the workflow would be:

1. Start up Sling with {{run-fm.sh}}
2. Wait for it to start
3. Stop Sling
4. Remove the launcher directory
5. Launch Sling again with {{run-fm.sh}}

I noticed no instability with this setup. Note that we are planning to move to 
the feature model, so this kind of setup is definitely supported.



> Sling fails to start when database exists but 'sling' directory is missing
> --
>
> Key: SLING-9118
> URL: https://issues.apache.org/jira/browse/SLING-9118
> Project: Sling
>  Issue Type: Bug
>Reporter: Ben Radey
>Assignee: Robert Munteanu
>Priority: Major
> Attachments: drop-mongo.sh, error.log, fm-launch.zip, karaf.log, 
> recreateSlingReplicaSet.sh, run-mongo.sh, run-sling-initial.sh, 
> run-sling-second.sh, sling-startup-error.log.txt
>
>
> # Create a persistent mongodb to use with Sling.
>  # Start sling using the mongodb.
>  # Stop sling.
>  # Remove 'sling' directory.
>  # Attempt to restart sling. Ultimately, sling fails to start.
> 
> Steps to reproduce with attached scripts:
> # Run [^run-mongo.sh] . This creates a MongoDB 3.6 container named 
> _mongo-sling_
> # Run [^run-sling-initial.sh]. This starts up Sling in the oak_mongo runmode, 
> shuts it down after it's (probably) started up
> # Run [^run-sling-second.sh]. This moves away the sling directory and starts 
> up a new instance. This always fails
> For cleanup, the [^drop-mongo.sh] script stops and removes the _mongo-sling_ 
> container.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9118) Sling fails to start when database exists but 'sling' directory is missing



 [ 
https://issues.apache.org/jira/browse/SLING-9118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-9118:
---
Attachment: fm-launch.zip

> Sling fails to start when database exists but 'sling' directory is missing
> --
>
> Key: SLING-9118
> URL: https://issues.apache.org/jira/browse/SLING-9118
> Project: Sling
>  Issue Type: Bug
>Reporter: Ben Radey
>Assignee: Robert Munteanu
>Priority: Major
> Attachments: drop-mongo.sh, error.log, fm-launch.zip, karaf.log, 
> recreateSlingReplicaSet.sh, run-mongo.sh, run-sling-initial.sh, 
> run-sling-second.sh, sling-startup-error.log.txt
>
>
> # Create a persistent mongodb to use with Sling.
>  # Start sling using the mongodb.
>  # Stop sling.
>  # Remove 'sling' directory.
>  # Attempt to restart sling. Ultimately, sling fails to start.
> 
> Steps to reproduce with attached scripts:
> # Run [^run-mongo.sh] . This creates a MongoDB 3.6 container named 
> _mongo-sling_
> # Run [^run-sling-initial.sh]. This starts up Sling in the oak_mongo runmode, 
> shuts it down after it's (probably) started up
> # Run [^run-sling-second.sh]. This moves away the sling directory and starts 
> up a new instance. This always fails
> For cleanup, the [^drop-mongo.sh] script stops and removes the _mongo-sling_ 
> container.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-9435) Take configured javadoc links into account

2020-05-08 Thread Carsten Ziegeler (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-9435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-9435.
-
Resolution: Fixed

Implemented in 
https://github.com/apache/sling-slingfeature-maven-plugin/commit/237ce63f8e396e763a90a44d086c096be31b3551
by reading the package lists from the links and adding them to the exclude list 
of packages used for javadoc generation

> Take configured javadoc links into account
> --
>
> Key: SLING-9435
> URL: https://issues.apache.org/jira/browse/SLING-9435
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.3.2
>
>
> The javadoc generation can be configured with a set of javadoc links. The 
> packages behind these links should be taken into consideration when javadoc 
> is generated : if artifacts provide them, they should be excluded



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-launchpad-integration-tests] alldaysunshine commented on pull request #1: [SLING-9417] Added test for an nt:file child of a versioned node



alldaysunshine commented on pull request #1:
URL: 
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/1#issuecomment-625892415


   Commit has been updated and SonarCloud issues have been addressed. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [feature-model] Different input format for feature files?

On Fri, 2020-05-08 at 17:47 +0200, Carsten Ziegeler wrote:
> It's documented :)
> 
> https://github.com/apache/sling-org-apache-sling-feature/blob/master/docs/features.md#feature-file-format
> 
> And yes, integrating a preprocessor in every place where we today
> read 
> feature files is another major undertaking.

I was thinking more about having a Maven plugin running in the build
before the slingfeature-maven-plugin starts to do its magic. This way
there is no actual change to the sling feature model tooling.


> And I think its a bad idea to support more than one format.

But yes, a major undertaking and possibly a bad idea.

Thanks,
Robert

> 
> Regards
> Carsten
> 
> On 08.05.2020 17:44, Robert Munteanu wrote:
> > Ok, probably not worth the effort :-)
> > 
> > Thanks for the information about JSMin-style comments, I was not
> > aware
> > of that. I guess the downside is that IDEs/editors will complain,
> > but
> > that's a choice we can make.
> > 
> > Thinking out loud - if we generate the JSON files from another
> > format
> > before passing them over to the feature launcher/analyser then we
> > would
> > be safe. But that's also not very easy I guess.
> > 
> > Thanks,
> > Robert
> > 
> > On Fri, 2020-05-08 at 17:36 +0200, Carsten Ziegeler wrote:
> > > It would be a significant effort, basically rewriting everything
> > > including all modules, extensions and tooling.
> > > 
> > > Not sure if that is really worth the effort.
> > > 
> > > Repoinit is a little bit of a pain, I agree. But I don't think
> > > this
> > > minor use case warrants such a dramatic change.
> > > 
> > > For comments, you can use JSmin style comments (like mentioned on
> > > jsonnet), so I don't consider this an issue.
> > > 
> > > Regards
> > > Carsten
> > > 
> > > On 08.05.2020 17:28, Robert Munteanu wrote:
> > > > Hi,
> > > > 
> > > > I keep thinking about how the feature files would look like in
> > > > a
> > > > different format. The main driver is the way repoinit
> > > > statements
> > > > look
> > > > at the moment. Comments are also a bit awkward, even though
> > > > possible in
> > > > JSON.
> > > > 
> > > > I was looking at Jsonnet [1], which is a superset of JSON with
> > > > lots
> > > > of
> > > > bells and whistles, including comments and multiline strings.
> > > > 
> > > > But irrespective of format - Jsonnet, YAML, or something else -
> > > > what
> > > > would it take to add another input format to the feature model?
> > > > Is
> > > > it
> > > > something can be easily plugged in or would it require a
> > > > significant
> > > > rewrite?
> > > > 
> > > > Thanks,
> > > > Robert
> > > > 
> > > > 
> > > > [1]: https://jsonnet.org/
> > > >

Re: [feature-model] Different input format for feature files?

It's documented :)

https://github.com/apache/sling-org-apache-sling-feature/blob/master/docs/features.md#feature-file-format

And yes, integrating a preprocessor in every place where we today read
feature files is another major undertaking.

And I think its a bad idea to support more than one format.

Regards
Carsten

On 08.05.2020 17:44, Robert Munteanu wrote:

Ok, probably not worth the effort :-)

Thanks for the information about JSMin-style comments, I was not aware
of that. I guess the downside is that IDEs/editors will complain, but
that's a choice we can make.

Thinking out loud - if we generate the JSON files from another format
before passing them over to the feature launcher/analyser then we would
be safe. But that's also not very easy I guess.

Thanks,
Robert

On Fri, 2020-05-08 at 17:36 +0200, Carsten Ziegeler wrote:

It would be a significant effort, basically rewriting everything
including all modules, extensions and tooling.

Not sure if that is really worth the effort.

Repoinit is a little bit of a pain, I agree. But I don't think this
minor use case warrants such a dramatic change.

For comments, you can use JSmin style comments (like mentioned on
jsonnet), so I don't consider this an issue.

Regards
Carsten

On 08.05.2020 17:28, Robert Munteanu wrote:

Hi,

I keep thinking about how the feature files would look like in a
different format. The main driver is the way repoinit statements
look
at the moment. Comments are also a bit awkward, even though
possible in
JSON.

I was looking at Jsonnet [1], which is a superset of JSON with lots
of
bells and whistles, including comments and multiline strings.

But irrespective of format - Jsonnet, YAML, or something else -
what
would it take to add another input format to the feature model? Is
it
something can be easily plugged in or would it require a
significant
rewrite?

Thanks,
Robert

[1]: https://jsonnet.org/

--
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: [feature-model] Different input format for feature files?

Ok, probably not worth the effort :-)

Thanks for the information about JSMin-style comments, I was not aware
of that. I guess the downside is that IDEs/editors will complain, but
that's a choice we can make.

Thinking out loud - if we generate the JSON files from another format
before passing them over to the feature launcher/analyser then we would
be safe. But that's also not very easy I guess.

Thanks,
Robert

On Fri, 2020-05-08 at 17:36 +0200, Carsten Ziegeler wrote:
> It would be a significant effort, basically rewriting everything 
> including all modules, extensions and tooling.
> 
> Not sure if that is really worth the effort.
> 
> Repoinit is a little bit of a pain, I agree. But I don't think this 
> minor use case warrants such a dramatic change.
> 
> For comments, you can use JSmin style comments (like mentioned on 
> jsonnet), so I don't consider this an issue.
> 
> Regards
> Carsten
> 
> On 08.05.2020 17:28, Robert Munteanu wrote:
> > Hi,
> > 
> > I keep thinking about how the feature files would look like in a
> > different format. The main driver is the way repoinit statements
> > look
> > at the moment. Comments are also a bit awkward, even though
> > possible in
> > JSON.
> > 
> > I was looking at Jsonnet [1], which is a superset of JSON with lots
> > of
> > bells and whistles, including comments and multiline strings.
> > 
> > But irrespective of format - Jsonnet, YAML, or something else -
> > what
> > would it take to add another input format to the feature model? Is
> > it
> > something can be easily plugged in or would it require a
> > significant
> > rewrite?
> > 
> > Thanks,
> > Robert
> > 
> > 
> > [1]: https://jsonnet.org/
> >

[jira] [Created] (SLING-9436) Append reactor module Notice Statement

2020-05-08 Thread Cris Rockwell (Jira)

Cris Rockwell created SLING-9436:


 Summary: Append reactor module Notice Statement 
 Key: SLING-9436
 URL: https://issues.apache.org/jira/browse/SLING-9436
 Project: Sling
  Issue Type: Improvement
  Components: Build and Source Control
Affects Versions: Jar Resource Bundle 1.0.2
Reporter: Cris Rockwell


As discussed in SLING-9397 ...

The NOTICE is built from a Velocity template. The template needs an update such 
that reactor module's can append a notice statement into this aggregated NOTICE
 * 
[https://github.com/apache/sling-apache-sling-jar-resource-bundle/blob/master/src/main/resources/META-INF/NOTICE.vm]
 * [https://github.com/apache/sling-apache-sling-jar-resource-bundle/pull/1]

 

Current version is 1.0.0, updating to 1.0.1. Once that occurs, line 209 from 
the sling-parent would also need to increment the version to 1.0.1
 * [https://github.com/apache/sling-parent/blob/master/sling-parent/pom.xml]

 

This would allow notice statement from the project pom.xml properties to append 
into a combined NOTICE file

{{ }}{{}}
 

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [feature-model] Different input format for feature files?

It would be a significant effort, basically rewriting everything 
including all modules, extensions and tooling.


Not sure if that is really worth the effort.

Repoinit is a little bit of a pain, I agree. But I don't think this 
minor use case warrants such a dramatic change.


For comments, you can use JSmin style comments (like mentioned on 
jsonnet), so I don't consider this an issue.


Regards
Carsten

On 08.05.2020 17:28, Robert Munteanu wrote:

Hi,

I keep thinking about how the feature files would look like in a
different format. The main driver is the way repoinit statements look
at the moment. Comments are also a bit awkward, even though possible in
JSON.

I was looking at Jsonnet [1], which is a superset of JSON with lots of
bells and whistles, including comments and multiline strings.

But irrespective of format - Jsonnet, YAML, or something else - what
would it take to add another input format to the feature model? Is it
something can be easily plugged in or would it require a significant
rewrite?

Thanks,
Robert


[1]: https://jsonnet.org/



--
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[feature-model] Different input format for feature files?

Hi,

I keep thinking about how the feature files would look like in a
different format. The main driver is the way repoinit statements look
at the moment. Comments are also a bit awkward, even though possible in
JSON.

I was looking at Jsonnet [1], which is a superset of JSON with lots of
bells and whistles, including comments and multiline strings.

But irrespective of format - Jsonnet, YAML, or something else - what
would it take to add another input format to the feature model? Is it
something can be easily plugged in or would it require a significant
rewrite?

Thanks,
Robert


[1]: https://jsonnet.org/

[jira] [Created] (SLING-9435) Take configured javadoc links into account

2020-05-08 Thread Carsten Ziegeler (Jira)

Carsten Ziegeler created SLING-9435:
---

 Summary: Take configured javadoc links into account
 Key: SLING-9435
 URL: https://issues.apache.org/jira/browse/SLING-9435
 Project: Sling
  Issue Type: Improvement
  Components: Feature Model, Maven Plugins and Archetypes
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: slingfeature-maven-plugin 1.3.2


The javadoc generation can be configured with a set of javadoc links. The 
packages behind these links should be taken into consideration when javadoc is 
generated : if artifacts provide them, they should be excluded



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-7811) NPE when repository is starting up due to repository manager shutdown



[ 
https://issues.apache.org/jira/browse/SLING-7811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102666#comment-17102666
 ] 

Robert Munteanu commented on SLING-7811:


FWIW, I have started Sling using the Feature Launcher, using the slightly old 
conversion result from 
https://github.com/apache/sling-whiteboard/blob/master/sling-org-apache-sling-kickstart/src/main/resources/feature-sling12.json
 , and I did not see any repository service restarts.

> NPE when repository is starting up due to repository manager shutdown
> -
>
> Key: SLING-7811
> URL: https://issues.apache.org/jira/browse/SLING-7811
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR Oak Server 1.1.4, JCR Base 3.0.4
>Reporter: Carsten Ziegeler
>Priority: Major
> Fix For: JCR Oak Server 1.2.6
>
>
> With the latest Sling Starter, the following NPE occurs in the logs. It seems 
> to be harmless, nevertheless we should fix it:
> For now I assigned it to both, JCR Base and Oak Server, as it's unclear which 
> one it is. Interestingly we've released Oak Server 1.2.0 but are not using it 
> in the starter.
> {noformat}
> 06.08.2018 15:45:18.396 *ERROR* [Apache Sling Repository Startup Thread] 
> org.apache.sling.jcr.oak.server.internal.OakSlingRepositoryManager start: 
> Uncaught Throwable trying to access Repository, calling stopRepository()
> java.lang.NullPointerException: null
> at 
> com.google.common.base.Preconditions.checkNotNull(Preconditions.java:192) 
> [com.google.guava:15.0.0]
> at org.apache.jackrabbit.oak.jcr.Jcr.with(Jcr.java:296) 
> [org.apache.jackrabbit.oak-jcr:1.6.8]
> at 
> org.apache.sling.jcr.oak.server.internal.OakSlingRepositoryManager.acquireRepository(OakSlingRepositoryManager.java:161)
>  [org.apache.sling.jcr.oak.server:1.1.4]
> at 
> org.apache.sling.jcr.base.AbstractSlingRepositoryManager.initializeAndRegisterRepositoryService(AbstractSlingRepositoryManager.java:471)
>  [org.apache.sling.jcr.base:3.0.4]
> at 
> org.apache.sling.jcr.base.AbstractSlingRepositoryManager.access$300(AbstractSlingRepositoryManager.java:85)
>  [org.apache.sling.jcr.base:3.0.4]
> at 
> org.apache.sling.jcr.base.AbstractSlingRepositoryManager$4.run(AbstractSlingRepositoryManager.java:455)
>  [org.apache.sling.jcr.base:3.0.4]
> {noformat}
> The stack trace points to a null workspace name ( see 
> https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.6.8/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/Jcr.java#L296
>  ).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9417) Content-type and InputStream are null when accessing nt:file resources with ";v="



 [ 
https://issues.apache.org/jira/browse/SLING-9417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-9417:
---
Fix Version/s: JCR Resource 3.0.22

> Content-type and InputStream are null when accessing nt:file resources with 
> ";v="
> -
>
> Key: SLING-9417
> URL: https://issues.apache.org/jira/browse/SLING-9417
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Reporter: Matthias Herold
>Priority: Minor
> Fix For: JCR Resource 3.0.22
>
>   Original Estimate: 1h
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> When using the methods resource.getMetadata().getContentType() or 
> resource.adaptTo(InputStream.class), both methods return null when:
>  # the resource is a child of a versionable node,
>  # the resource is of type nt:file, and
>  # resource has been looked up with a version identifier in the URL (";v=").
> From my understanding, both methods should return the relevant values from 
> the frozen node. The error occurs because of line 185 in JcrNodeResource.java
> {{Node content = node.isNodeType(NT_FILE)}}
> {{? node.getNode(JCR_CONTENT)}}
> {{: node.isNodeType(NT_LINKEDFILE) ? node.getProperty(JCR_CONTENT).getNode() 
> : node;}}
> When the resource is looked up with a version modifier, the node type will 
> not nt:file. Instead it is jcr:frozenNode with a property 
> jcr:frozenPrimaryType set to nt:file. Therefore, the above code fails and 
> will not use the jcr:content subnode, but the node itself. In my opinion, it 
> would be better to change this to: 
> Node content = (node.isNodeType(NodeType.NT_FILE) || 
> (node.isNodeType("nt:frozenNode") && 
> node.hasProperty("jcr:frozenPrimaryType") 
> {{ && 
> node.getProperty("jcr:frozenPrimaryType").getString().equals(NT_FILE)))}}
> {{ ? node.getNode(Node.JCR_CONTENT)
> {{ : node.isNodeType(JcrConstants.NT_LINKEDFILE) ? 
> node.getProperty(Node.JCR_CONTENT).getNode() : node;}}
>  
> JcrResourceMetadata has the same issue (line 65):
> {{ if ( (!nodePromotionChecked) && node.isNodeType(NT_FILE)) {}}
> This could be changed to: 
> {{ if ( (!nodePromotionChecked) && (node.isNodeType(NT_FILE) ||}}
> {{ (node.isNodeType("nt:frozenNode") && 
> node.hasProperty("jcr:frozenPrimaryType") }}
> {{ && 
> node.getProperty("jcr:frozenPrimaryType").getString().equals(NT_FILE {}}
>  
> As I'm still a newbie in Sling, I'm not sure if the proposed solution is 
> completely right. At the moment, I use a ResourceDecorator for my project 
> with these changes and this fixes my problem - but there might be a better 
> way to solve this.
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (SLING-9417) Content-type and InputStream are null when accessing nt:file resources with ";v="



 [ 
https://issues.apache.org/jira/browse/SLING-9417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-9417:
--

Assignee: Robert Munteanu

> Content-type and InputStream are null when accessing nt:file resources with 
> ";v="
> -
>
> Key: SLING-9417
> URL: https://issues.apache.org/jira/browse/SLING-9417
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Reporter: Matthias Herold
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: JCR Resource 3.0.22
>
>   Original Estimate: 1h
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> When using the methods resource.getMetadata().getContentType() or 
> resource.adaptTo(InputStream.class), both methods return null when:
>  # the resource is a child of a versionable node,
>  # the resource is of type nt:file, and
>  # resource has been looked up with a version identifier in the URL (";v=").
> From my understanding, both methods should return the relevant values from 
> the frozen node. The error occurs because of line 185 in JcrNodeResource.java
> {{Node content = node.isNodeType(NT_FILE)}}
> {{? node.getNode(JCR_CONTENT)}}
> {{: node.isNodeType(NT_LINKEDFILE) ? node.getProperty(JCR_CONTENT).getNode() 
> : node;}}
> When the resource is looked up with a version modifier, the node type will 
> not nt:file. Instead it is jcr:frozenNode with a property 
> jcr:frozenPrimaryType set to nt:file. Therefore, the above code fails and 
> will not use the jcr:content subnode, but the node itself. In my opinion, it 
> would be better to change this to: 
> Node content = (node.isNodeType(NodeType.NT_FILE) || 
> (node.isNodeType("nt:frozenNode") && 
> node.hasProperty("jcr:frozenPrimaryType") 
> {{ && 
> node.getProperty("jcr:frozenPrimaryType").getString().equals(NT_FILE)))}}
> {{ ? node.getNode(Node.JCR_CONTENT)
> {{ : node.isNodeType(JcrConstants.NT_LINKEDFILE) ? 
> node.getProperty(Node.JCR_CONTENT).getNode() : node;}}
>  
> JcrResourceMetadata has the same issue (line 65):
> {{ if ( (!nodePromotionChecked) && node.isNodeType(NT_FILE)) {}}
> This could be changed to: 
> {{ if ( (!nodePromotionChecked) && (node.isNodeType(NT_FILE) ||}}
> {{ (node.isNodeType("nt:frozenNode") && 
> node.hasProperty("jcr:frozenPrimaryType") }}
> {{ && 
> node.getProperty("jcr:frozenPrimaryType").getString().equals(NT_FILE {}}
>  
> As I'm still a newbie in Sling, I'm not sure if the proposed solution is 
> completely right. At the moment, I use a ResourceDecorator for my project 
> with these changes and this fixes my problem - but there might be a better 
> way to solve this.
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-jcr-resource] rombert commented on pull request #8: [SLING-9417] Versioning support for nt:file as child of versioned node



rombert commented on pull request #8:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/8#issuecomment-625858591


   Perfect, thanks a lot for the contribution @alldaysunshine !



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-jcr-resource] alldaysunshine commented on pull request #8: [SLING-9417] Versioning support for nt:file as child of versioned node



alldaysunshine commented on pull request #8:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/8#issuecomment-625857419


   I squashed the two commits into a single one by rebasing. Hope this was done 
in the right way and it can be merged.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: Documentation for content-package based development

Hi Ruben,

On Fri, 2020-05-08 at 07:38 -0700, Ruben Reusser wrote:
> Hi Robert,
> 
> this is awesome! I think it would be nice to also mention at [1] the 
> ability to upload and deploy a content package through the composum
> UI. 

That's a very good point, added in 
https://github.com/apache/sling-site/commit/c8a458ec .
 .
> Also, should we move [2] from the peregrine repos to the sling
> samples 
> instead?

Sure, just include it in a PR for 
https://github.com/apache/sling-samples .

Robert

> 
> Ruben
> 
> ]1] 
> https://sling.apache.org/documentation/development/content-packages.html#deploying-a-content-package-at-runtime-1
> [2] https://github.com/peregrine-cms/simple-sling-vue-example
> 
> On 5/8/2020 7:00 AM, Robert Munteanu wrote:
> > Hi,
> > 
> > As part of the sling 12 theme of content-package based development
> > I
> > kicked off a page to help users wrap their head around the concept.
> > 
> >
> > https://sling.apache.org/documentation/development/content-packages.html
> > 
> > I'm talking about things that are not fully familiar to me, like
> > the
> > Sling Project Archetype and the Sling Packager tool, so any input
> > is
> > welcome.
> > 
> > Note that it's not supposed to be a comprehensive guide, but rather
> > a
> > starting point.
> > 
> > Comments welcome.
> > 
> > Thanks,
> > Robert
> >

Re: Documentation for content-package based development

2020-05-08 Thread Ruben Reusser


Hi Robert,

this is awesome! I think it would be nice to also mention at [1] the 
ability to upload and deploy a content package through the composum UI. 
Also, should we move [2] from the peregrine repos to the sling samples 
instead?


Ruben

]1] 
https://sling.apache.org/documentation/development/content-packages.html#deploying-a-content-package-at-runtime-1

[2] https://github.com/peregrine-cms/simple-sling-vue-example

On 5/8/2020 7:00 AM, Robert Munteanu wrote:

Hi,

As part of the sling 12 theme of content-package based development I
kicked off a page to help users wrap their head around the concept.

   https://sling.apache.org/documentation/development/content-packages.html

I'm talking about things that are not fully familiar to me, like the
Sling Project Archetype and the Sling Packager tool, so any input is
welcome.

Note that it's not supposed to be a comprehensive guide, but rather a
starting point.

Comments welcome.

Thanks,
Robert

Re: [VOTE] Release Apache Sling Slingfeature Maven Plugin 1.3.0

2020-05-08 Thread davidb

+1

David

On Fri, 8 May 2020 at 15:02, Daniel Klco  wrote:

> +1
>
> On Fri, May 8, 2020 at 3:38 AM Robert Munteanu  wrote:
>
> > On Thu, 2020-05-07 at 19:28 +0200, Carsten Ziegeler wrote:
> > > Please vote to approve this release:
> >
> > +1
> > Robert
> >
>

[GitHub] [sling-apache-sling-jar-resource-bundle] cmrockwell commented on pull request #1: SLING-9397: Update NOTICE.vm



cmrockwell commented on pull request #1:
URL: 
https://github.com/apache/sling-apache-sling-jar-resource-bundle/pull/1#issuecomment-625835017


   @rombert  The changes you suggested should be all set.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [VOTE] Release Apache Sling Slingfeature Maven Plugin 1.3.0

2020-05-08 Thread Daniel Klco

+1

On Fri, May 8, 2020 at 3:38 AM Robert Munteanu  wrote:

> On Thu, 2020-05-07 at 19:28 +0200, Carsten Ziegeler wrote:
> > Please vote to approve this release:
>
> +1
> Robert
>

Documentation for content-package based development

Hi,

As part of the sling 12 theme of content-package based development I
kicked off a page to help users wrap their head around the concept.

  https://sling.apache.org/documentation/development/content-packages.html

I'm talking about things that are not fully familiar to me, like the
Sling Project Archetype and the Sling Packager tool, so any input is
welcome.

Note that it's not supposed to be a comprehensive guide, but rather a
starting point.

Comments welcome.

Thanks,
Robert

[jira] [Resolved] (SLING-9434) Add documentation for content-package based development



 [ 
https://issues.apache.org/jira/browse/SLING-9434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-9434.

Resolution: Fixed

Fixed with [sling-site commit 
ddce6542|https://github.com/apache/sling-site/commit/ddce6542]
, available at 
https://sling.apache.org/documentation/development/content-packages.html

> Add documentation for content-package based development
> ---
>
> Key: SLING-9434
> URL: https://issues.apache.org/jira/browse/SLING-9434
> Project: Sling
>  Issue Type: Sub-task
>  Components: Documentation
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [VOTE] Release Apache Sling Installer Packages Factory 1.0.4

2020-05-08 Thread Konrad Windszus

+1

Konrad

> Am 08.05.2020 um 13:31 schrieb Robert Munteanu :
> 
> Hi,
> 
> We solved 1 issue in this release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12347878
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2261/
> 
> You can use this UNIX script to download the release and verify the 
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> 
> Usage:
> sh check_staged_release.sh 2261 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.
> 
> Regards,
> Robert Munteanu

[jira] [Created] (SLING-9434) Add documentation for content-package based development

Robert Munteanu created SLING-9434:
--

 Summary: Add documentation for content-package based development
 Key: SLING-9434
 URL: https://issues.apache.org/jira/browse/SLING-9434
 Project: Sling
  Issue Type: Sub-task
  Components: Documentation
Reporter: Robert Munteanu
Assignee: Robert Munteanu






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [VOTE] Release Apache Sling Form Based Authentication 1.0.20

On Fri, 2020-05-08 at 12:34 +, Robert Munteanu wrote:
> Please vote to approve this release:

+1
Robert


signature.asc
Description: This is a digitally signed message part

[VOTE] Release Apache Sling Form Based Authentication 1.0.20

Hi,

We solved 3 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12348250

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2263/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2263 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Robert Munteanu

[jira] [Updated] (SLING-9431) Login form should set focus to the first input field



 [ 
https://issues.apache.org/jira/browse/SLING-9431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-9431:
---
Fix Version/s: (was: Form Based Authentication 1.0.18)
   Form Based Authentication 1.0.20

> Login form should set focus to the first input field
> 
>
> Key: SLING-9431
> URL: https://issues.apache.org/jira/browse/SLING-9431
> Project: Sling
>  Issue Type: Bug
>  Components: Authentication
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Form Based Authentication 1.0.20
>
>
> It's a minor usability issue, but I think it would be really useful and it 
> would save - me at least - tons of time clicking around with the mouse.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9432) Update form-based auth to parent 38



 [ 
https://issues.apache.org/jira/browse/SLING-9432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-9432:
---
Fix Version/s: (was: Form Based Authentication 1.0.18)

> Update form-based auth to parent 38
> ---
>
> Key: SLING-9432
> URL: https://issues.apache.org/jira/browse/SLING-9432
> Project: Sling
>  Issue Type: Sub-task
>  Components: Authentication
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9432) Update form-based auth to parent 38



 [ 
https://issues.apache.org/jira/browse/SLING-9432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-9432:
---
Fix Version/s: Form Based Authentication 1.0.20

> Update form-based auth to parent 38
> ---
>
> Key: SLING-9432
> URL: https://issues.apache.org/jira/browse/SLING-9432
> Project: Sling
>  Issue Type: Sub-task
>  Components: Authentication
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Form Based Authentication 1.0.20
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9433) Do not log stack trace in case of cookies with no match in the token store



[ 
https://issues.apache.org/jira/browse/SLING-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102532#comment-17102532
 ] 

Robert Munteanu commented on SLING-9433:


Fixed with [sling-org-apache-sling-auth-form commit 
1a4413c|https://github.com/apache/sling-org-apache-sling-auth-form/commit/1a4413c]


> Do not log stack trace in case of cookies with no match in the token store
> --
>
> Key: SLING-9433
> URL: https://issues.apache.org/jira/browse/SLING-9433
> Project: Sling
>  Issue Type: Improvement
>  Components: Authentication
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Form Based Authentication 1.0.20
>
>
> When a cookie does not have a match in the token store, a stack trace is 
> logged at error level
> {noformat}08.05.2020 14:21:42.991 *ERROR* [qtp804599815-226] 
> org.apache.sling.auth.form.impl.TokenStore No installed provider supports 
> this key: (null)
> java.security.InvalidKeyException: No installed provider supports this key: 
> (null)
>   at java.base/javax.crypto.Mac.chooseProvider(Mac.java:392)
>   at java.base/javax.crypto.Mac.init(Mac.java:435)
>   at 
> org.apache.sling.auth.form.impl.TokenStore.encode(TokenStore.java:174) 
> [org.apache.sling.auth.form:1.0.19.SNAPSHOT]
>   at 
> org.apache.sling.auth.form.impl.TokenStore.isValid(TokenStore.java:229) 
> [org.apache.sling.auth.form:1.0.19.SNAPSHOT]
>   at 
> org.apache.sling.auth.form.impl.FormAuthenticationHandler.extractCredentials(FormAuthenticationHandler.java:195)
>  [org.apache.sling.auth.form:1.0.19.SNAPSHOT]{noformat}
> (snip)
> This is easily preventable, as we should not be passing a null {{SecretKey}} 
> further. Instead, we should log an ERROR and consider the cookie as invalid.
> Steps to reproduce:
> 1. Start up Sling Starter
> 2. Log in
> 3. Stop Sling Starter
> 4. Remove sling directory
> 5. Start Sling Starter
> 6. Visit front page
> Alternatively, save a Sling login cookie ( sling.formauth=... ) and send it 
> via a curl call to a fresh instance of Sling.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-9433) Do not log stack trace in case of cookies with no match in the token store



 [ 
https://issues.apache.org/jira/browse/SLING-9433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-9433.

Resolution: Fixed

> Do not log stack trace in case of cookies with no match in the token store
> --
>
> Key: SLING-9433
> URL: https://issues.apache.org/jira/browse/SLING-9433
> Project: Sling
>  Issue Type: Improvement
>  Components: Authentication
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Form Based Authentication 1.0.20
>
>
> When a cookie does not have a match in the token store, a stack trace is 
> logged at error level
> {noformat}08.05.2020 14:21:42.991 *ERROR* [qtp804599815-226] 
> org.apache.sling.auth.form.impl.TokenStore No installed provider supports 
> this key: (null)
> java.security.InvalidKeyException: No installed provider supports this key: 
> (null)
>   at java.base/javax.crypto.Mac.chooseProvider(Mac.java:392)
>   at java.base/javax.crypto.Mac.init(Mac.java:435)
>   at 
> org.apache.sling.auth.form.impl.TokenStore.encode(TokenStore.java:174) 
> [org.apache.sling.auth.form:1.0.19.SNAPSHOT]
>   at 
> org.apache.sling.auth.form.impl.TokenStore.isValid(TokenStore.java:229) 
> [org.apache.sling.auth.form:1.0.19.SNAPSHOT]
>   at 
> org.apache.sling.auth.form.impl.FormAuthenticationHandler.extractCredentials(FormAuthenticationHandler.java:195)
>  [org.apache.sling.auth.form:1.0.19.SNAPSHOT]{noformat}
> (snip)
> This is easily preventable, as we should not be passing a null {{SecretKey}} 
> further. Instead, we should log an ERROR and consider the cookie as invalid.
> Steps to reproduce:
> 1. Start up Sling Starter
> 2. Log in
> 3. Stop Sling Starter
> 4. Remove sling directory
> 5. Start Sling Starter
> 6. Visit front page
> Alternatively, save a Sling login cookie ( sling.formauth=... ) and send it 
> via a curl call to a fresh instance of Sling.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[CANCELLED] [VOTE] Release Apache Sling Form Based Authentication 1.0.18

Hi,

I am cancelling the release to include a fix for freshly-discovered
SLING-9433 [1] as well.

Apologies for the noise.

Robert

[1]: https://issues.apache.org/jira/browse/SLING-9433

[jira] [Created] (SLING-9433) Do not log stack trace in case of cookies with no match in the token store

Robert Munteanu created SLING-9433:
--

 Summary: Do not log stack trace in case of cookies with no match 
in the token store
 Key: SLING-9433
 URL: https://issues.apache.org/jira/browse/SLING-9433
 Project: Sling
  Issue Type: Improvement
  Components: Authentication
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Form Based Authentication 1.0.20


When a cookie does not have a match in the token store, a stack trace is logged 
at error level

{noformat}08.05.2020 14:21:42.991 *ERROR* [qtp804599815-226] 
org.apache.sling.auth.form.impl.TokenStore No installed provider supports this 
key: (null)
java.security.InvalidKeyException: No installed provider supports this key: 
(null)
at java.base/javax.crypto.Mac.chooseProvider(Mac.java:392)
at java.base/javax.crypto.Mac.init(Mac.java:435)
at 
org.apache.sling.auth.form.impl.TokenStore.encode(TokenStore.java:174) 
[org.apache.sling.auth.form:1.0.19.SNAPSHOT]
at 
org.apache.sling.auth.form.impl.TokenStore.isValid(TokenStore.java:229) 
[org.apache.sling.auth.form:1.0.19.SNAPSHOT]
at 
org.apache.sling.auth.form.impl.FormAuthenticationHandler.extractCredentials(FormAuthenticationHandler.java:195)
 [org.apache.sling.auth.form:1.0.19.SNAPSHOT]{noformat}

(snip)

This is easily preventable, as we should not be passing a null {{SecretKey}} 
further. Instead, we should log an ERROR and consider the cookie as invalid.

Steps to reproduce:

1. Start up Sling Starter
2. Log in
3. Stop Sling Starter
4. Remove sling directory
5. Start Sling Starter
6. Visit front page

Alternatively, save a Sling login cookie ( sling.formauth=... ) and send it via 
a curl call to a fresh instance of Sling.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [VOTE] Release Apache Sling Form Based Authentication 1.0.18


+1

Carsten

On 08.05.2020 14:03, Robert Munteanu wrote:

Hi,

We solved 2 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12346081

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2262/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2262 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Robert Munteanu



--
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: [VOTE] Release Apache Sling Installer Packages Factory 1.0.4


+1

Carsten

On 08.05.2020 13:31, Robert Munteanu wrote:

Hi,

We solved 1 issue in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12347878

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2261/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2261 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Robert Munteanu



--
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: [VOTE] Move o.a.s.graphql.core to its own repo

On Fri, 2020-05-08 at 14:03 +0200, Bertrand Delacretaz wrote:
> I'd like to move the org.apache.sling.graphql.core [1] code to its
> own
> 
> module, see the README there for more info on what it does.

+1

Robert


signature.asc
Description: This is a digitally signed message part

Re: [VOTE] Move o.a.s.graphql.core to its own repo

2020-05-08 Thread Radu Cotescu

On 8 May 2020, at 14:03, Bertrand Delacretaz  wrote:
> 
> I'd like to move the org.apache.sling.graphql.core [1] code to its own
> module, see the README there for more info on what it does.

+1

Re: [VOTE] Release Apache Sling Form Based Authentication 1.0.18

On Fri, 2020-05-08 at 12:03 +, Robert Munteanu wrote:
> Please vote to approve this release:

+1
Robert


signature.asc
Description: This is a digitally signed message part

[VOTE] Release Apache Sling Form Based Authentication 1.0.18

Hi,

We solved 2 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12346081

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2262/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2262 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Robert Munteanu

[VOTE] Move o.a.s.graphql.core to its own repo

2020-05-08 Thread Bertrand Delacretaz

Hi,

I'd like to move the org.apache.sling.graphql.core [1] code to its own
module, see the README there for more info on what it does.

Proposed repository name: sling-org-apache-sling-graphql-core

This is still an early version of that code but it would be useful to
configure a Jenkins build on it and I'd like to make an initial
release soon.

This majority vote is open for at least 72 hours.

Here's my +1

-Bertrand

[1] https://github.com/apache/sling-whiteboard/tree/master/graphql-scripting
(the module name changed from "scripting" to "core" as it does more
than just scripting)

[jira] [Updated] (SLING-9432) Update form-based auth to parent 38



 [ 
https://issues.apache.org/jira/browse/SLING-9432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-9432:
---
Component/s: Authentication

> Update form-based auth to parent 38
> ---
>
> Key: SLING-9432
> URL: https://issues.apache.org/jira/browse/SLING-9432
> Project: Sling
>  Issue Type: Sub-task
>  Components: Authentication
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Form Based Authentication 1.0.18
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-9432) Update form-based auth to parent 38



 [ 
https://issues.apache.org/jira/browse/SLING-9432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-9432.

Resolution: Fixed

Fixed with [sling-org-apache-sling-auth-form commit 
0879899|https://github.com/apache/sling-org-apache-sling-auth-form/commit/0879899]


> Update form-based auth to parent 38
> ---
>
> Key: SLING-9432
> URL: https://issues.apache.org/jira/browse/SLING-9432
> Project: Sling
>  Issue Type: Sub-task
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Form Based Authentication 1.0.18
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-9432) Update form-based auth to parent 38

Robert Munteanu created SLING-9432:
--

 Summary: Update form-based auth to parent 38
 Key: SLING-9432
 URL: https://issues.apache.org/jira/browse/SLING-9432
 Project: Sling
  Issue Type: Sub-task
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Form Based Authentication 1.0.18






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-9431) Login form should set focus to the first input field



 [ 
https://issues.apache.org/jira/browse/SLING-9431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-9431.

Resolution: Fixed

Fixed with [sling-org-apache-sling-auth-form commit 
9639e62|https://github.com/apache/sling-org-apache-sling-auth-form/commit/9639e62]


> Login form should set focus to the first input field
> 
>
> Key: SLING-9431
> URL: https://issues.apache.org/jira/browse/SLING-9431
> Project: Sling
>  Issue Type: Bug
>  Components: Authentication
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Form Based Authentication 1.0.18
>
>
> It's a minor usability issue, but I think it would be really useful and it 
> would save - me at least - tons of time clicking around with the mouse.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-9431) Login form should set focus to the first input field

Robert Munteanu created SLING-9431:
--

 Summary: Login form should set focus to the first input field
 Key: SLING-9431
 URL: https://issues.apache.org/jira/browse/SLING-9431
 Project: Sling
  Issue Type: Bug
  Components: Authentication
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Form Based Authentication 1.0.18


It's a minor usability issue, but I think it would be really useful and it 
would save - me at least - tons of time clicking around with the mouse.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [VOTE] Release Apache Sling Installer Packages Factory 1.0.4

On Fri, 2020-05-08 at 11:31 +, Robert Munteanu wrote:
> Please vote to approve this release:

+1
Robert


signature.asc
Description: This is a digitally signed message part

[jira] [Updated] (SLING-6999) Package Installer Factory: Prevent package upload/extraction in case the same package is already installed



 [ 
https://issues.apache.org/jira/browse/SLING-6999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-6999:
---
Fix Version/s: (was: Installer Packages Factory 1.0.4)
   Installer Packages Factory 1.0.6

> Package Installer Factory: Prevent package upload/extraction in case the same 
> package is already installed
> --
>
> Key: SLING-6999
> URL: https://issues.apache.org/jira/browse/SLING-6999
> Project: Sling
>  Issue Type: Improvement
>  Components: Installer
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Installer Packages Factory 1.0.6
>
>
> To prevent unnecessary double uploads (in case a package is already 
> installed), there should be an existence check within 
> {{PackageTransformer.checkForPackage(...)}}. The check should leverage the 
> functionality from https://issues.apache.org/jira/browse/JCRVLT-193.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-6989) Package Installer Factory: Prevent package upload in case of uninstallation/2nd installation



 [ 
https://issues.apache.org/jira/browse/SLING-6989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-6989:
---
Fix Version/s: (was: Installer Packages Factory 1.0.4)
   Installer Packages Factory 1.0.6

> Package Installer Factory: Prevent package upload in case of 
> uninstallation/2nd installation
> 
>
> Key: SLING-6989
> URL: https://issues.apache.org/jira/browse/SLING-6989
> Project: Sling
>  Issue Type: Improvement
>  Components: Installer
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Installer Packages Factory 1.0.6
>
>
> Currently in case a package is supposed to be uninstalled through the package 
> installer, the package is first being uploaded to the PackageManager 
> (https://github.com/apache/sling/blob/trunk/installer/factories/packages/src/main/java/org/apache/sling/installer/factory/packages/impl/PackageTransformer.java#L138).
>  That should not be necessary though. Instead the package id/version should 
> be extracted from the underlying resource and then should be uninstalled.
> Also in case the package is already installed in the same version upload 
> should be prevented.
> This applies to both regular and hollow package installation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[VOTE] Release Apache Sling Installer Packages Factory 1.0.4

Hi,

We solved 1 issue in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12347878

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2261/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2261 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Robert Munteanu

[GitHub] [sling-apache-sling-jar-resource-bundle] sonarcloud[bot] commented on pull request #1: SLING-9397: Update NOTICE.vm



sonarcloud[bot] commented on pull request #1:
URL: 
https://github.com/apache/sling-apache-sling-jar-resource-bundle/pull/1#issuecomment-625758682


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle=1=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle=1=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle=1=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle=1=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle=1=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle=1=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle=1=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle=1=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle=1=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle=1=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle=1=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-apache-sling-jar-resource-bundle=1)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-apache-sling-jar-resource-bundle=1=duplicated_lines_density=list)
 No Duplication information
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Resolved] (SLING-9209) Report which requirements are not directly satisfied by the current project

2020-05-08 Thread Radu Cotescu (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-9209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu resolved SLING-9209.
-
Resolution: Fixed

Fixed in [commit 
671c6dc|https://github.com/apache/sling-scriptingbundle-maven-plugin/commit/671c6dc].

> Report which requirements are not directly satisfied by the current project
> ---
>
> Key: SLING-9209
> URL: https://issues.apache.org/jira/browse/SLING-9209
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Scripting Bundle Maven Plugin 0.2.0
>
>
> When the {{MetadataMojo}} executes it would help to see which required 
> resource types (capabilities) are not provided by the current project and 
> report them.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9422) Content Package Installer: Use service resource resolvers instead of admin resource resolver for installation



[ 
https://issues.apache.org/jira/browse/SLING-9422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102455#comment-17102455
 ] 

Robert Munteanu commented on SLING-9422:


Added documentation at [sling-site commit 
276ac6b5|https://github.com/apache/sling-site/commit/276ac6b5]


> Content Package Installer: Use service resource resolvers instead of admin 
> resource resolver for installation
> -
>
> Key: SLING-9422
> URL: https://issues.apache.org/jira/browse/SLING-9422
> Project: Sling
>  Issue Type: Improvement
>  Components: Installer
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Installer Packages Factory 1.0.4
>
>
> Currently the {{PackageTransformer}} uses an an administrative session. 
> Instead {{SlingRepository.loginService()}} should be used together with an 
> according service user mapping. The user needs basically write access to all 
> locations which is covered by packages and {{/etc/packages}} itself.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[RESULT][VOTE] Sling Feature Model API Regions Runtime Fragment 1.1.2

2020-05-08 Thread davidb

With 3 binding +1 votes this release is successful.

I've promoted the artifacts.

Best regards,

David

On Tue, 5 May 2020 at 10:55,  wrote:

> Hi all,
>
> I would like to call the release on the Sling Feature Model API Regions
> Runtime Fragment 1.1.2.
>
> Resolved issues:
> https://issues.apache.org/jira/projects/SLING/versions/12348198
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2256
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2256 /tmp/sling-staging
>
> Please vote to approve this release:
>
>[ ] +1 Approve the release
>[ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Best regards,
>
> David
>

Re: [sling 12] Content-Package maven archetype

On Fri, 2020-05-08 at 00:36 +0200, Robert Munteanu wrote:
> I don't really have a timeline, as it might've become apparent :-) So
> 
> if you find the time to update the archetype, that'd be great. It's
> 
> just that for me the quickest path is to push the content-package
> 
> archetype that I have sitting on my local machine and polished a bit
> 
> today.

FWIW, I have pushed the code that I have to GitHub (outside of the
apache org, for now)

  https://github.com/rombert/content-package-archetype/

Thanks,
Robert

[GitHub] [sling-org-apache-sling-jcr-resource] rombert commented on pull request #8: [SLING-9417] Versioning support for nt:file as child of versioned node



rombert commented on pull request #8:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/8#issuecomment-625729783


   @alldaysunshine - can you please:
   
   - squash the two commits into a single one
   - reference the Jira issue in the commit title
   
   ? Then I can merge this



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-jcr-resource] kwin commented on pull request #8: [SLING-9417] Versioning support for nt:file as child of versioned node



kwin commented on pull request #8:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/8#issuecomment-625727007


   Yes, although I would like to move all constants to the javax.jcr packages. 
But this is independent of this fix.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-jcr-resource] rombert commented on pull request #8: [SLING-9417] Versioning support for nt:file as child of versioned node



rombert commented on pull request #8:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/8#issuecomment-625726420


   @kwin , does this look ok to you now?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-9397) SAML2 Authentication Handler [initial submission]



[ 
https://issues.apache.org/jira/browse/SLING-9397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102350#comment-17102350
 ] 

Robert Munteanu commented on SLING-9397:


Thanks for the jar-resource-bundle PR [~cris_rockwell]! Yes, once that is 
merged and included in the saml handler module, the NOTICE issue will be fixed.

> SAML2 Authentication Handler [initial submission]
> -
>
> Key: SLING-9397
> URL: https://issues.apache.org/jira/browse/SLING-9397
> Project: Sling
>  Issue Type: New Feature
>  Components: Authentication
> Environment: localhost
>Reporter: Cris Rockwell
>Priority: Major
>  Labels: SAML, authentification, security, user_management
>   Original Estimate: 168h
>  Time Spent: 40m
>  Remaining Estimate: 167h 20m
>
> Here is a pull request which adds an authentication handler for a SAML2 
> Service Provider via the embedded OpenSAML V3 dependencies
> [https://github.com/apache/sling-whiteboard/pull/51]
>  
> *TODO Before Initial*
> [X] Sync attributes released by the IDP
> [X] Confirm license and attribution 
> "As the code is ASL2 and does not require a notice or anything else, we don't 
> need to mention in. But I think its usually good style to do so and have a 
> single sentence in our NOTICE that we include (modified) code from ... which 
> has ASL2 as the license"
>  
> *TODO After Initial* 
> [ ] Get confirmation the project builds and operates as expected
> [ ] Ensure that the NOTICE file is the correct one 
> [ ] Clarify whether we can depend on artifacts not deployed on Maven Central
> [ ] Review Web Browser SSO Profile Specification 4.1 and confirm all aspects 
> * [https://docs.oasis-open.org/security/saml/v2.0/saml-profiles-2.0-os.pdf]
> [ ] Consider whether use of {{SAML2ConfigService}} and 
> {{SAML2ConfigServiceImpl}} is a good design or not.
> [ ] Get feedback whether README instructions are too much, too little, 
> unclear, etc
> [ ] Decide whether to make signing and encryption optional. Currently it is 
> required
> [ ] Find and fix any bugs
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-apache-sling-jar-resource-bundle] rombert edited a comment on pull request #1: SLING-9397: Update NOTICE.vm



rombert edited a comment on pull request #1:
URL: 
https://github.com/apache/sling-apache-sling-jar-resource-bundle/pull/1#issuecomment-625691123


   Two high-level comments:
   
   - please squash all commits into one once you have applied the changes.
   - please create a new Jira for this change, we need to track it separately ( 
version is https://issues.apache.org/jira/projects/SLING/versions/12348248 ). I 
will then release this bundle, pull it into the parent pom and release that one 
as well, so you can reference it in the SAML handler



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-apache-sling-jar-resource-bundle] rombert removed a comment on pull request #1: SLING-9397: Update NOTICE.vm



rombert removed a comment on pull request #1:
URL: 
https://github.com/apache/sling-apache-sling-jar-resource-bundle/pull/1#issuecomment-625691123


   Two high-level comments:
   
   - please squash all commits into one once you have applied the changes.
   - please create a new Jira for this change, we need to track it separately ( 
version is https://issues.apache.org/jira/projects/SLING/versions/12348248 ). I 
will then release this bundle, pull it into the parent pom and release that one 
as well, so you can reference it in the SAML handler



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-apache-sling-jar-resource-bundle] rombert commented on pull request #1: SLING-9397: Update NOTICE.vm



rombert commented on pull request #1:
URL: 
https://github.com/apache/sling-apache-sling-jar-resource-bundle/pull/1#issuecomment-625691123


   Also, please squash all commits into one once you have applied the changes.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-apache-sling-jar-resource-bundle] rombert commented on a change in pull request #1: SLING-9397: Update NOTICE.vm



rombert commented on a change in pull request #1:
URL: 
https://github.com/apache/sling-apache-sling-jar-resource-bundle/pull/1#discussion_r422000899



##
File path: src/main/resources/META-INF/NOTICE.vm
##
@@ -18,14 +18,19 @@
 ##
 
 #if ($projectName)$projectName#else${project.name}#end
+#if ($project.properties.noticeStatement)
+   $project.properties.noticeStatement
+#end
 
 Copyright ${projectTimespan}#if($project.organization.name) 
$project.organization.name#else The Apache Software Foundation#end
 
-
-Apache Sling is based on source code originally developed 
+Apache Sling is based on source code originally developed
 by Day Software (http://www.day.com/).
 
 This product includes software developed at
 The Apache Software Foundation (http://www.apache.org/).
 
 
+

Review comment:
   Please remove this whitespace-only change.

##
File path: src/main/resources/META-INF/NOTICE.vm
##
@@ -18,14 +18,19 @@
 ##
 
 #if ($projectName)$projectName#else${project.name}#end
+#if ($project.properties.noticeStatement)
+   $project.properties.noticeStatement
+#end
 
 Copyright ${projectTimespan}#if($project.organization.name) 
$project.organization.name#else The Apache Software Foundation#end
 
-
-Apache Sling is based on source code originally developed 
+Apache Sling is based on source code originally developed

Review comment:
   Please remove this whitespace-only change.

##
File path: src/main/resources/META-INF/NOTICE.vm
##
@@ -18,14 +18,19 @@
 ##
 
 #if ($projectName)$projectName#else${project.name}#end
+#if ($project.properties.noticeStatement)

Review comment:
   Is this picked up from the pom.xml properties? Also, ca you please move 
this to the end of the file?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Kickstart modules still in whiteboard

Hi,

I see we have moved the kickstart modules to their own repositories,
but they are still present in the sling whiteboard.

Should the code in the whiteboard be deleted?

Thanks,
Robert

Re: Animal Sniffer Failure on Kickstart Project

Hi Andy,

On Thu, 2020-05-07 at 17:13 -0700, Andreas Schaefer wrote:
> Hi
> 
> While I was trying to release the Sling Kickstart Project during ‘man
> deploy’ of the snapshots I ran into this issue (Sling Parent 38):
(snip)
> [ERROR] Failed to execute goal org.codehaus.mojo:animal-sniffer-
> maven-plugin:1.17:check (default) on project
> org.apache.sling.kickstart: Execution default of goal
> org.codehaus.mojo:animal-sniffer-maven-plugin:1.17:check failed: An
> API incompatibility was encountered while executing
> org.codehaus.mojo:animal-sniffer-maven-plugin:1.17:check:
> java.lang.NoSuchMethodError:
> java.nio.CharBuffer.position(I)Ljava/nio/CharBuffer;
> [ERROR] -
> [ERROR] realm =plugin>org.codehaus.mojo:animal-sniffer-maven-
> plugin:1.17
> [ERROR] strategy =
> org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy

I was able to build the kickstart project without issues. I tried both
Java 8 and 11:

Apache Maven 3.6.3 (SUSE 3.6.3-2.1)
Maven home: /usr/share/maven
Java version: 1.8.0_242, vendor: IcedTea, runtime: 
/usr/lib64/jvm/java-1.8.0-openjdk-1.8.0/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "5.6.8-1-default", arch: "amd64", family: "unix"

Apache Maven 3.6.3 (SUSE 3.6.3-2.1)
Maven home: /usr/share/maven
Java version: 11.0.7, vendor: Oracle Corporation, runtime: 
/usr/lib64/jvm/java-11-openjdk-11
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "5.6.8-1-default", arch: "amd64", family: "unix"

Thanks,
Robert

Re: [VOTE] Release Apache Sling Slingfeature Maven Plugin 1.3.0

On Thu, 2020-05-07 at 19:28 +0200, Carsten Ziegeler wrote:
> Please vote to approve this release:

+1
Robert


signature.asc
Description: This is a digitally signed message part

[jira] [Commented] (SLING-9418) Usage of SHA-256 is insecure

2020-05-08 Thread Oliver Lietz (Jira)



[ 
https://issues.apache.org/jira/browse/SLING-9418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102334#comment-17102334
 ] 

Oliver Lietz commented on SLING-9418:
-

[~asanso], The internal {{hash}} method is used in several places – have you 
done a complete review?

> Usage of SHA-256 is insecure
> 
>
> Key: SLING-9418
> URL: https://issues.apache.org/jira/browse/SLING-9418
> Project: Sling
>  Issue Type: Improvement
>Reporter: Md Mahir Asef Kabir
>Priority: Major
>
> *Vulnerability Description:* In 
> “src/main/java/org/apache/sling/discovery/base/connectors/ping/TopologyRequestValidator.java”
>  file the following code was written in
> {code:java}
> private String hash(String toHash){code}
> method -
> {code:java}
> MessageDigest m = MessageDigest.getInstance("SHA-256");{code}
> The vulnerability is, using "SHA-256” as the argument to 
> MessageDigest.getInstance method.
> *Reason it’s vulnerable:* According to 
> [this|https://securityboulevard.com/2019/07/insecure-default-password-hashing-in-cmss/],
>  “SHA256 functions do not include a salt and a separate function must be used 
> to add the salt”. Another reference can be found 
> [here|https://dusted.codes/sha-256-is-not-a-secure-password-hashing-algorithm].
> *Suggested Fix:* According to 
> [this|https://securityboulevard.com/2019/07/insecure-default-password-hashing-in-cmss/],
>  “The most secure current hash functions are BCRYPT, SCRYPT, and Argon2”
> *Feedback:* Please select any of the options down below to help us get an 
> idea about how you felt about the suggestion -
>  # Liked it and will make the suggested changes
>  # Liked it but happy with the existing version
>  # Didn’t find the suggestion helpful
>  
> *Note:* Tagging *[~stefanegli]* as suggested by [~rombert] in this [pull 
> request.|https://github.com/apache/sling-org-apache-sling-discovery-base/pull/1]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [VOTE]: Release Apache Sling Kickstart Project 0.0.2 and Apache Sling Kickstart Maven Plugin 0.0.2

On Thu, 2020-05-07 at 17:37 -0700, Andreas Schaefer wrote:
> Please vote to approve this release:

+1
Robert


signature.asc
Description: This is a digitally signed message part

[jira] [Commented] (SLING-8350) Switch the Sling starter to the feature model