date:20201110

Re: [VOTE] Release Apache Sling Testing Clients version 2.0.8

2020-11-10 Thread Eric Norman

+1

On Tue, Nov 10, 2020 at 6:02 AM Andrei Dulvac  wrote:

> Hi, We solved 1 issue in this release:
> https://issues.apache.org/jira/projects/SLING/versions/12349274  Staging
> repository:
> https://repository.apache.org/content/repositories/orgapachesling-2372/
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> Usage: sh check_staged_release.sh 2372 /tmp/sling-staging Please vote to
> approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1
> Don't release, because ... This majority vote is open for at least 72
> hours.
>

Can we Un-deprecate SlingAnnotationsTestRunner ?

2020-11-10 Thread Cris Rockwell

Hi Sling Dev

SlingAnnotationsTestRunner is one of my favorite ways to test because it make
my life simpler when doing Test Driven Development in Sling. Using this tool I
have had fewer setup and dependency problems because it runs in the instance I
develop and deploy to. SlingAnnotationsTestRunner can run JUnit tests in any of
my various Sling instances (local, staging and production), which is super
handy when diagnosing and troubleshooting remote server problems. QA, Ops,
Admins and developers can easily run the JUnit tests after updates and restarts
using the web-based user interface.

Unfortunately SlingAnnotationsTestRunner was marked as deprecated in 2015
stating "TeleporterRule is a much simpler way of executing” That maybe true in
your experience, but TeleporterRule does not provide me the same value. IMO
project developers should have a choice whether to use
SlingAnnotationsTestRunner or TeleporterRule for their project. For some
TeleporterRule may be better indeed. For me, SlingAnnotationsTestRunner is
perfect when I’m trying to develop projects in Sling.
SlingAnnotationsTestRunner Junit tests do not increase Maven build speed, and
the UI allows me to run all the tests or just the ones I want.

In summary, could I please volunteer to keep SlingAnnotationsTestRunner.java
alive, supported and not deprecated?

Regards
Cris

https://github.com/apache/sling-org-apache-sling-junit-core/blob/master/src/main/java/org/apache/sling/junit/annotations/SlingAnnotationsTestRunner.java

Re: Two "adapter annotations" module, deprecate the old one?

2020-11-10 Thread Bertrand Delacretaz

Hi,

I have implemented the below plan, the update to
https://sling.apache.org/downloads.cgi is not live yet.

-Bertrand

On Tue, Nov 10, 2020 at 1:24 PM Bertrand Delacretaz
 wrote:
> ...So I suggest:
>
> 1) Renaming the adapter-annotations-1.0.0 section to "Adapter
> Annotations (JSON)" at https://sling.apache.org/downloads.cgi and
> changing the name in its source code (pom and README), including a
> link to the new module
>
> 2) Releasing the new module as "Adapter Annotations 2.0.0"
>
> 3) Mentioning both modules and their difference using the new names at
> https://github.com/apache/sling-org-apache-sling-adapter-annotations
>
> I think that's a reasonable plan, or is anything missing? ...

[jira] [Commented] (SLING-9890) Document the new adapter-annotations module

2020-11-10 Thread Bertrand Delacretaz (Jira)



[ 
https://issues.apache.org/jira/browse/SLING-9890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17229439#comment-17229439
 ] 

Bertrand Delacretaz commented on SLING-9890:


The docs should mention both this 
https://github.com/apache/sling-org-apache-sling-adapter-annotations module and 
the older https://github.com/apache/sling-adapter-annotations one and explain 
the difference between them.

> Document the new adapter-annotations module
> ---
>
> Key: SLING-9890
> URL: https://issues.apache.org/jira/browse/SLING-9890
> Project: Sling
>  Issue Type: Task
>  Components: Documentation
>Affects Versions: Adapter Annotations 2.0.0
>Reporter: Bertrand Delacretaz
>Assignee: Henry Kuijpers
>Priority: Major
> Fix For: Adapter Annotations 2.0.2
>
>
> The new 
> [https://github.com/apache/sling-org-apache-sling-adapter-annotations] module 
> needs to be documented at 
> [https://sling.apache.org/documentation/the-sling-engine/adapters.html]
> That page can either briefly mention the module and point to its README for 
> more info, or include the full documentation.
> I'm assigning this ticket to [~Henry Kuijpers] who volunteered in SLING-2938



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [VOTE] Release Apache Sling Settings 1.4.2

2020-11-10 Thread Eric Norman

+1

On Sat, Nov 7, 2020 at 4:05 AM Oliver Lietz  wrote:

> Hi,
>
> We solved 1 issue in this release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12348652
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2370
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2370 /tmp/sling-staging
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Regards,
> O.
>
>
>
>
>

[jira] [Commented] (SLING-2938) AdapterMethods annotation and adapter proxy service

2020-11-10 Thread Bertrand Delacretaz (Jira)



[ 
https://issues.apache.org/jira/browse/SLING-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17229413#comment-17229413
 ] 

Bertrand Delacretaz commented on SLING-2938:


I have now started the release vote for Sling Adapter Annotations 2.0.0 and 
renamed the older module with a "(JSON)" suffix for clarity, in the pom and 
README at [https://github.com/apache/sling-adapter-annotations] and at 
https://sling.apache.org/downloads.cgi

> AdapterMethods annotation and adapter proxy service
> ---
>
> Key: SLING-2938
> URL: https://issues.apache.org/jira/browse/SLING-2938
> Project: Sling
>  Issue Type: Bug
>  Components: Engine, Extensions
>Affects Versions: Adapter 2.1.0
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: Adapter Annotations 2.0.0
>
> Attachments: SLING-2938-api.patch, console.jpg
>
>
> Following up on an idea that Olaf Otto presented at CQCon last week, I've 
> been working on an @AdapterMethod annotation that makes it easier to create 
> Sling adapters, as in
>   @Component
>   @Service
>   public class MyAdapters implements AdapterMethodProvider {
> @AdapterMethod
> public Bar toBar(Foo f) { ... adapt Foo to Bar ... }
>   }
> As this requires changes to the sling.api bundle, I'll commit to my 
> whiteboard first, for review



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[VOTE] Release Sling Adapter Annotations 2.0.0

2020-11-10 Thread Bertrand Delacretaz

Hi,

This is a new module, at
https://github.com/apache/sling-org-apache-sling-adapter-annotations

...not to be confused with the older
https://github.com/apache/sling-adapter-annotations module, which I
have renamed with a (JSON) suffix for clarity.

There are still some outstanding issues:
https://issues.apache.org/jira/projects/SLING/versions/12349370

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2374/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2374 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Here's my +1.

-Bertrand

[jira] [Updated] (SLING-9890) Document the new adapter-annotations module

2020-11-10 Thread Bertrand Delacretaz (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-9890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bertrand Delacretaz updated SLING-9890:
---
Affects Version/s: (was: Adapter Annotations (JSON) 1.0.0)
   Adapter Annotations 2.0.0

> Document the new adapter-annotations module
> ---
>
> Key: SLING-9890
> URL: https://issues.apache.org/jira/browse/SLING-9890
> Project: Sling
>  Issue Type: Task
>  Components: Documentation
>Affects Versions: Adapter Annotations 2.0.0
>Reporter: Bertrand Delacretaz
>Assignee: Henry Kuijpers
>Priority: Major
>
> The new 
> [https://github.com/apache/sling-org-apache-sling-adapter-annotations] module 
> needs to be documented at 
> [https://sling.apache.org/documentation/the-sling-engine/adapters.html]
> That page can either briefly mention the module and point to its README for 
> more info, or include the full documentation.
> I'm assigning this ticket to [~Henry Kuijpers] who volunteered in SLING-2938



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9892) adapter-annotations integration tests sometimes fail

2020-11-10 Thread Bertrand Delacretaz (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-9892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bertrand Delacretaz updated SLING-9892:
---
Affects Version/s: (was: Adapter Annotations (JSON) 1.0.0)
   Adapter Annotations 2.0.0

> adapter-annotations integration tests sometimes fail
> 
>
> Key: SLING-9892
> URL: https://issues.apache.org/jira/browse/SLING-9892
> Project: Sling
>  Issue Type: Bug
>  Components: Engine, Extensions
>Affects Versions: Adapter Annotations 2.0.0
>Reporter: Bertrand Delacretaz
>Priority: Minor
> Fix For: Adapter Annotations 2.0.2
>
>
> I have marked two such failing builds at 
> [https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-adapter-annotations/job/master/]
>  as "keep forever", the error is apparently always
> {code}
> [INFO] [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time 
> elapsed: 11.235 s <<< FAILURE! - in 
> org.apache.sling.adapter.annotations.AdapterRegistrationIT
> [INFO] [ERROR] org.apache.sling.adapter.annotations.AdapterRegistrationIT  
> Time elapsed: 11.21 s  <<< ERROR!
> [INFO] java.lang.RuntimeException: Could not read content from response
> [INFO]at 
> org.apache.sling.adapter.annotations.AdapterRegistrationIT.setUpAdaptions(AdapterRegistrationIT.java:58)
> [INFO] Caused by: org.apache.http.MalformedChunkCodingException: CRLF 
> expected at end of chunk
> [INFO]at 
> org.apache.sling.adapter.annotations.AdapterRegistrationIT.setUpAdaptions(AdapterRegistrationIT.java:58)
> [INFO] 
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9890) Document the new adapter-annotations module

2020-11-10 Thread Bertrand Delacretaz (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-9890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bertrand Delacretaz updated SLING-9890:
---
Fix Version/s: Adapter Annotations 2.0.2

> Document the new adapter-annotations module
> ---
>
> Key: SLING-9890
> URL: https://issues.apache.org/jira/browse/SLING-9890
> Project: Sling
>  Issue Type: Task
>  Components: Documentation
>Affects Versions: Adapter Annotations 2.0.0
>Reporter: Bertrand Delacretaz
>Assignee: Henry Kuijpers
>Priority: Major
> Fix For: Adapter Annotations 2.0.2
>
>
> The new 
> [https://github.com/apache/sling-org-apache-sling-adapter-annotations] module 
> needs to be documented at 
> [https://sling.apache.org/documentation/the-sling-engine/adapters.html]
> That page can either briefly mention the module and point to its README for 
> more info, or include the full documentation.
> I'm assigning this ticket to [~Henry Kuijpers] who volunteered in SLING-2938



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9892) adapter-annotations integration tests sometimes fail

2020-11-10 Thread Bertrand Delacretaz (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-9892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bertrand Delacretaz updated SLING-9892:
---
Fix Version/s: Adapter Annotations 2.0.2

> adapter-annotations integration tests sometimes fail
> 
>
> Key: SLING-9892
> URL: https://issues.apache.org/jira/browse/SLING-9892
> Project: Sling
>  Issue Type: Bug
>  Components: Engine, Extensions
>Affects Versions: Adapter Annotations (JSON) 1.0.0
>Reporter: Bertrand Delacretaz
>Priority: Minor
> Fix For: Adapter Annotations 2.0.2
>
>
> I have marked two such failing builds at 
> [https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-adapter-annotations/job/master/]
>  as "keep forever", the error is apparently always
> {code}
> [INFO] [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time 
> elapsed: 11.235 s <<< FAILURE! - in 
> org.apache.sling.adapter.annotations.AdapterRegistrationIT
> [INFO] [ERROR] org.apache.sling.adapter.annotations.AdapterRegistrationIT  
> Time elapsed: 11.21 s  <<< ERROR!
> [INFO] java.lang.RuntimeException: Could not read content from response
> [INFO]at 
> org.apache.sling.adapter.annotations.AdapterRegistrationIT.setUpAdaptions(AdapterRegistrationIT.java:58)
> [INFO] Caused by: org.apache.http.MalformedChunkCodingException: CRLF 
> expected at end of chunk
> [INFO]at 
> org.apache.sling.adapter.annotations.AdapterRegistrationIT.setUpAdaptions(AdapterRegistrationIT.java:58)
> [INFO] 
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-2938) AdapterMethods annotation and adapter proxy service

2020-11-10 Thread Bertrand Delacretaz (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bertrand Delacretaz updated SLING-2938:
---
Fix Version/s: Adapter Annotations 2.0.0

> AdapterMethods annotation and adapter proxy service
> ---
>
> Key: SLING-2938
> URL: https://issues.apache.org/jira/browse/SLING-2938
> Project: Sling
>  Issue Type: Bug
>  Components: Engine, Extensions
>Affects Versions: Adapter 2.1.0
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: Adapter Annotations 2.0.0
>
> Attachments: SLING-2938-api.patch, console.jpg
>
>
> Following up on an idea that Olaf Otto presented at CQCon last week, I've 
> been working on an @AdapterMethod annotation that makes it easier to create 
> Sling adapters, as in
>   @Component
>   @Service
>   public class MyAdapters implements AdapterMethodProvider {
> @AdapterMethod
> public Bar toBar(Foo f) { ... adapt Foo to Bar ... }
>   }
> As this requires changes to the sling.api bundle, I'll commit to my 
> whiteboard first, for review



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [roundtable] Code coverage

2020-11-10 Thread Radu Cotescu

Hi Konrad,

Sorry for getting back so late - I was off for two weeks.

> On 24 Oct 2020, at 17:09, Konrad Windszus  wrote:
> 
> Hi Radu,
> I am wondering why we need to still generate reports for both unit and 
> integration test separately in 
> https://github.com/apache/sling-parent/blob/3e7b3edb7411440b6a5dcd4836da2c45f4cc7166/sling-parent/pom.xml#L509
>  
> .
> IMHO just generating the report after merging the exec files should be enough.

We *don’t* need to generate reports for both, but it could be useful in some 
setups to see how a project’s code is covered. Feel free to change the 
configuration if it takes too much time on the projects you’re working on.

> WDYT?
> Konrad
> 

Cheers,
Radu

80 matches

Mail list logo