date:20210419

Please see 
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/433/
 for details.

No further emails will be sent until the status of the build is changed.

[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] removed a comment on pull request #27: DockerHub build - using hooks to build and push



sonarcloud[bot] removed a comment on pull request #27:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27#issuecomment-822738997


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=coverage=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] commented on pull request #27: DockerHub build - using hooks to build and push



sonarcloud[bot] commented on pull request #27:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27#issuecomment-822763929


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=coverage=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #432 is BROKEN

OT.jar
[INFO] Checking legal files in: 
org.apache.sling.launchpad.testing-12-SNAPSHOT-sources.jar
[INFO] 
[INFO] --- apache-rat-plugin:0.11:check (default) @ 
org.apache.sling.launchpad.testing ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: DEPENDENCIES
[INFO] Exclude: src/main/appended-resources/META-INF/*
[INFO] Exclude: velocity.log
[INFO] Exclude: target/*
[INFO] Exclude: README.md
[INFO] Exclude: maven-eclipse.xml
[INFO] Exclude: .*
[INFO] Exclude: .*/**
[INFO] Exclude: **/*.json
[INFO] Exclude: DEPENDENCIES
[INFO] Exclude: **/*.rej
[INFO] Exclude: hs_err_*.log
[INFO] Exclude: **/repository/index/*/index-details.txt
[INFO] Exclude: bnd.bnd
[INFO] 6 resources included (use -debug for more details)
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
approved: 5 licence.
[INFO] 
[INFO] --- maven-failsafe-plugin:2.21.0:verify (default) @ 
org.apache.sling.launchpad.testing ---
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time:  03:18 min
[INFO] Finished at: 2021-04-19T20:03:18Z
[INFO] 
[WARNING] The requested profile "ci" could not be activated because it does not 
exist.
[INFO] [jenkins-event-spy] Generated 
/home/jenkins/jenkins-agent/workspace/e-sling-launchpad-testing_master@tmp/withMaven8da05807/maven-spy-20210419-195959-5581655062780740309154.log
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-failsafe-plugin:2.21.0:verify (default) on 
project org.apache.sling.launchpad.testing: There are test failures.
[ERROR] 
[ERROR] Please refer to 
/home/jenkins/jenkins-agent/workspace/e-sling-launchpad-testing_master/target/failsafe-reports
 for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump, 
[date].dumpstream and [date]-jvmRun[N].dumpstream.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[Pipeline] }
[withMaven] junitPublisher - Archive test results for Maven artifact 
org.apache.sling:org.apache.sling.launchpad.testing:jar:12-SNAPSHOT generated 
by maven-surefire-plugin:test (default-test): target/surefire-reports/*.xml
Recording test results
None of the test reports contained any result
[withMaven] junitPublisher - Archive test results for Maven artifact 
org.apache.sling:org.apache.sling.launchpad.testing:jar:12-SNAPSHOT generated 
by maven-failsafe-plugin:integration-test (default): 
target/failsafe-reports/*.xml
Recording test results
[DevOpticsMavenPublisher] dependencies consumed: 93, artifacts produced: 0
[withMaven] Publishers: Pipeline Graph Publisher: 1 ms, Generated Artifacts 
Publisher: 340 ms, Junit Publisher: 127263 ms, Dependencies Fingerprint 
Publisher: 1185 ms, Open Task Scanner Publisher: 333 ms, CloudBees DevOptics 
Gate Artifact Publisher: 53783 ms
[Pipeline] // withMaven
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // timeout
[Pipeline] stage
[Pipeline] { (Notifications)
[Pipeline] echo
Status change is BROKEN, notifications will be sent.
[Pipeline] emailext

[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #93 is FIXED

Please see 
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/93/
 for details.

No further emails will be sent until the status of the build is changed.

[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] commented on pull request #27: DockerHub build - using hooks to build and push



sonarcloud[bot] commented on pull request #27:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27#issuecomment-822738997


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=coverage=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] removed a comment on pull request #27: DockerHub build - using hooks to build and push



sonarcloud[bot] removed a comment on pull request #27:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27#issuecomment-822736080


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=coverage=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] removed a comment on pull request #27: DockerHub build - using hooks to build and push



sonarcloud[bot] removed a comment on pull request #27:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27#issuecomment-822706448


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=coverage=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] commented on pull request #27: DockerHub build - using hooks to build and push



sonarcloud[bot] commented on pull request #27:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27#issuecomment-822736080


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=coverage=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] removed a comment on pull request #27: DockerHub build - using hooks to build and push



sonarcloud[bot] removed a comment on pull request #27:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27#issuecomment-822690285


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=coverage=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] commented on pull request #27: DockerHub build - using hooks to build and push



sonarcloud[bot] commented on pull request #27:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27#issuecomment-822706448


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=coverage=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] commented on pull request #27: DockerHub build - using hooks to build and push



sonarcloud[bot] commented on pull request #27:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27#issuecomment-822690285


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=coverage=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] removed a comment on pull request #27: DockerHub build - using hooks to build and push



sonarcloud[bot] removed a comment on pull request #27:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27#issuecomment-822669156


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=coverage=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] removed a comment on pull request #27: DockerHub build - using hooks to build and push



sonarcloud[bot] removed a comment on pull request #27:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27#issuecomment-822657421


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=coverage=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] commented on pull request #27: DockerHub build - using hooks to build and push



sonarcloud[bot] commented on pull request #27:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27#issuecomment-822669156


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=coverage=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] commented on pull request #27: DockerHub build - using hooks to build and push



sonarcloud[bot] commented on pull request #27:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27#issuecomment-822657421


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=coverage=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] removed a comment on pull request #27: DockerHub build - using hooks to build and push



sonarcloud[bot] removed a comment on pull request #27:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27#issuecomment-822508035


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=coverage=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Closed] (SLING-10310) Update to Sling Bundle Parent 41

2021-04-19 Thread Eric Norman (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-10310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Norman closed SLING-10310.
---

Closing with the JCR Maintenance 1.0.2 release

> Update to Sling Bundle Parent 41
> 
>
> Key: SLING-10310
> URL: https://issues.apache.org/jira/browse/SLING-10310
> Project: Sling
>  Issue Type: Task
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR Maintenance 1.0.2
>
>
> Update to Sling Bundle Parent 41
> Also, add project.build.outputTimestamp property to the pom for reproducible 
> builds support.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-10263) create the sling-versionmgr system user with path system/sling

2021-04-19 Thread Eric Norman (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-10263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Norman closed SLING-10263.
---

Closing with the JCR Maintenance 1.0.2 release

> create the sling-versionmgr system user with path system/sling
> --
>
> Key: SLING-10263
> URL: https://issues.apache.org/jira/browse/SLING-10263
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR Maintenance 1.0.2
>
>
> All the system users created in the starter are created with path system/sling
> For consistency, create the sling-versionmgr system user with the same path.
> Also, use pre-authentication for system users to achieve the equivalent of 
> what was done for SLING-9786



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Sling Declarative Dynamic Resources

2021-04-19 Thread Ruben Reusser


dear sling community

Andreas has been working to create a way to dynamically create component 
proxies in Sling based on a configuration. In peregrine-cms we are 
planning to use this approach when a new tenant (a new website) is 
created by a user. It allows us to proxy the base components into a new 
/apps folder for the website. A super user for the site can then 
potentially change the title/group of a component and the default 
structure that is used when adding a component to a page.


We hope this component may be useful to other sling based content 
management systems as well. We'd like to ask to move this module out of 
the whiteboard - but of course we welcome any comments/concerns/things 
we should consider to make sure everybody can benefit from this module.


looking forward to your comments!

Ruben

[GitHub] [sling-org-apache-sling-discovery-oak] sonarcloud[bot] commented on pull request #2: SLING-10204 : less noisy logging on unregistration



sonarcloud[bot] commented on pull request #2:
URL: 
https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/2#issuecomment-822642542


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=2=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=2=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=2=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=2=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=2=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=2=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-oak=2=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-oak=2=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-discovery-oak=2=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=2=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=2=false=CODE_SMELL)
 [9 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak=2=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak=2=new_coverage=list)
 [0.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak=2=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak=2=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-discovery-oak=2=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-10204) Make OakDiscoveryService.updatedPropertyProvider tolerate deactivated repository



[ 
https://issues.apache.org/jira/browse/SLING-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325195#comment-17325195
 ] 

Stefan Egli commented on SLING-10204:
-

* [PR|https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/2] 
created
* as noted in the PR this brushes up the pom slightly, just slightly, to have 
it work with java 11. More work is to be done separately, ie upgrading to 
parent 41 - but that involves some more work and should not block this PR (and 
the upcoming release).

[~cziegeler], wdyt?

> Make OakDiscoveryService.updatedPropertyProvider tolerate deactivated 
> repository
> 
>
> Key: SLING-10204
> URL: https://issues.apache.org/jira/browse/SLING-10204
> Project: Sling
>  Issue Type: Task
>  Components: Discovery
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The following exception has been witnessed during resource resolver factory 
> unregistration:
> {noformat}
> java.lang.IllegalArgumentException: Can't create child on a synthetic root
> at 
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl.create(ResourceResolverImpl.java:979)
>  [org.apache.sling.resourceresolver:1.7.2]
> ...
> at 
> org.apache.sling.api.resource.ResourceUtil.getOrCreateResource(ResourceUtil.java:571)
>  [org.apache.sling.api:2.22.0]
> at 
> org.apache.sling.discovery.commons.providers.util.ResourceHelper.getOrCreateResource(ResourceHelper.java:45)
>  [org.apache.sling.discovery.commons:1.0.20]
> at 
> org.apache.sling.discovery.oak.OakDiscoveryService.doUpdateProperties(OakDiscoveryService.java:492)
>  [org.apache.sling.discovery.oak:1.2.30]
> at 
> org.apache.sling.discovery.oak.OakDiscoveryService.bindPropertyProviderInteral(OakDiscoveryService.java:406)
>  [org.apache.sling.discovery.oak:1.2.30]
> at 
> org.apache.sling.discovery.oak.OakDiscoveryService.updatedPropertyProvider(OakDiscoveryService.java:421)
>  [org.apache.sling.discovery.oak:1.2.30]
>   at jdk.internal.reflect.GeneratedMethodAccessor65.invoke(Unknown 
> Source){noformat}
> Under normal circumstances osgi should not invoke any of the 
> updatedPropertyProvider/unbindPropertyProvider methods after the 
> resourceResolverFactory is deactivated - but it has been seen nevertheless.
> What can be done in OakDiscoveryService is to tolerate this and not issue a 
> log.warn instead of throwing an uncaught IllegalArgumentException.
> Edit: more cases with the same root cause:
> {noformat}
> java.lang.Exception: Could not adapt resourceResolver to session: 
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl@3e685b17
>   at 
> org.apache.sling.discovery.commons.providers.spi.base.DiscoveryLiteDescriptor.getDescriptorFrom(DiscoveryLiteDescriptor.java:54)
>  [org.apache.sling.discovery.commons:1.0.20]
>   at 
> org.apache.sling.discovery.oak.cluster.OakClusterViewService.getLocalClusterView(OakClusterViewService.java:113)
>  [org.apache.sling.discovery.oak:1.2.30]
>   at 
> org.apache.sling.discovery.base.commons.BaseDiscoveryService.getTopology(BaseDiscoveryService.java:77)
>  [org.apache.sling.discovery.base:2.0.8]
>   at 
> org.apache.sling.discovery.oak.OakDiscoveryService.checkForTopologyChange(OakDiscoveryService.java:660)
>  [org.apache.sling.discovery.oak:1.2.30]
>   at 
> org.apache.sling.discovery.oak.pinger.OakViewChecker.discoveryLiteCheck(OakViewChecker.java:217)
>  [org.apache.sling.discovery.oak:1.2.30]
>   at 
> org.apache.sling.discovery.oak.pinger.OakViewChecker.access$000(OakViewChecker.java:62)
>  [org.apache.sling.discovery.oak:1.2.30]
>   at 
> org.apache.sling.discovery.oak.pinger.OakViewChecker$1.run(OakViewChecker.java:193)
>  [org.apache.sling.discovery.oak:1.2.30]
>   at 
> org.apache.sling.discovery.base.commons.PeriodicBackgroundJob.safelyRun(PeriodicBackgroundJob.java:86)
>  [org.apache.sling.discovery.base:2.0.8]
>   at 
> org.apache.sling.discovery.base.commons.PeriodicBackgroundJob.run(PeriodicBackgroundJob.java:77)
>  [org.apache.sling.discovery.base:2.0.8]
>   at java.base/java.lang.Thread.run(Thread.java:834)
> {noformat}
> {noformat}
> java.lang.Exception: Could not adapt resourceResolver to session: 
> org.apache.sling.resourceresolver.impl.ResourceResolverImpl@215bf7ef
>   at 
> org.apache.sling.discovery.commons.providers.spi.base.DiscoveryLiteDescriptor.getDescriptorFrom(DiscoveryLiteDescriptor.java:54)
>  [org.apache.sling.discovery.commons:1.0.20]
>   at 
> org.apache.sling.discovery.oak.TopologyWebConsolePlugin.updateDiscoveryLiteHistory(TopologyWebConsolePlugin.java:778)
>  [org.apache.sling.discovery.oak:1.2.30]
>   at 
>

[GitHub] [sling-org-apache-sling-discovery-oak] stefan-egli opened a new pull request #2: SLING-10204 : less noisy logging on unregistration



stefan-egli opened a new pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/2


   When resourceResolverFactory is deactivated we have seen some noisy log 
messages, including lengthy stack traces. While what these logs report is 
legitimate, we should log less noisy as the unregistration of 
resourceResolverFactory is non trivial and slightly non-osgiy.
   
   This PR suggests to lower to warn from error, and not include the stack 
trace. If one is interested in the stack trace for debugging, the log level can 
be set to DEBUG and then the stack trace will be included (while the log level 
it prints will stay at WARN).
   
   Additionally, as part of this PR, the pom had to be slightly brushed up to 
work with java 11. The changes were kept at a minimum though, since switching 
to parent 41 would involve switching away from felix scr to osgi scr 
annotations. That should be done in a separate task.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[RESULT] [VOTE] Release Release Apache Sling JCR Maintenance version 1.0.2

2021-04-19 Thread Eric Norman

Hi,

The vote has passed with the following result :

+1 (binding): Eric Norman, Daniel Klco, Stefan Seifert

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

Re: [VOTE] Release Apache Sling Auth Core 1.5.2

2021-04-19 Thread Eric Norman

+1 Conditionally on there being some documentation somewhere that states
that this version is not quite a drop in replacement for the previous
release.  The o.a.s.auth.core bundle now requires the [1] and [2] bundles
and those bundles should have a start level that is even or below the
o.a.s.auth.core bundle start level.

1. org.apache.sling:org.apache.sling.commons.metrics:1.2.8
2. io.dropwizard.metrics:metrics-core:3.2.6

For example, the starter project currently has those two metrics bundles at
start level 15 which results in errors during the "Analyzing feature" build
with messages like below when switching to this o.a.s.auth.core release:

[ERROR] org.apache.sling:org.apache.sling.auth.core:1.5.2:  is importing
package(s) org.apache.sling.commons.metrics in start level 5 but no bundle
is exporting these for that start level.


and later after fixing the first error by changing the start level of
o.a.s.commons.metrics to 5:

[ERROR] org.apache.sling:org.apache.sling.commons.metrics:1.2.8:  is
importing package(s) com.codahale.metrics in start level 5 but no bundle is
exporting these for that start level.


Other than those configuration troubles, I didn't see any obvious
regressions in the runtime functionality so it is ok for me.

Regards,
-Eric

On Sun, Apr 18, 2021 at 7:57 AM Carsten Ziegeler 
wrote:

> Hi,
>
> We solved 10 issues in this release:
> https://issues.apache.org/jira/projects/SLING/versions/12348715
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2431/
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2431 /tmp/sling-staging
>
> Please vote to approve this release:
>
>[ ] +1 Approve the release
>[ ]  0 Don't care
>[ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Regards
> Carsten
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziege...@apache.org
>

Re: [VOTE] Release Apache Sling Auth Core 1.5.2

2021-04-19 Thread Robert Munteanu

Hi Cris,

On Mon, 2021-04-19 at 09:23 -0400, Cris Rockwell wrote:
> All the work happened directly on the master branch. Why not have a
> PR
> so others can review the changes in their totality?

comm...@sling.apache.org records all the commits that are pushed to
Sling repositories, so there is always the opportunity to review them.
Commits are reversible until released, and we prefer to work in a CTR
(commit-then-review) mode.

Thanks,
Robert

[jira] [Resolved] (SLING-10317) Write a report file about used sources and dependencies



 [ 
https://issues.apache.org/jira/browse/SLING-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-10317.
--
Resolution: Fixed

Added a report about the sources for each artifact and a report for artifacts 
not used as dependencies ( if use dependency is enabled)

https://github.com/apache/sling-slingfeature-maven-plugin/commit/f2bb13dc9b9c93ceb57649d84d38e355b76c230f

> Write a report file about used sources and dependencies
> ---
>
> Key: SLING-10317
> URL: https://issues.apache.org/jira/browse/SLING-10317
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.5.2
>
>
> For better understanding the contents of the apis jar, the apis mojo should 
> write a report to a file at the end, detailing the used sources (artifacts, 
> scm etc.) and the used dependencies - in addition also why an artifact was 
> not used as a dependency.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Release of Servlets Resolver and Scripting bundles

2021-04-19 Thread Carsten Ziegeler

I discussed the Version class with Radu briefly offline, looking for an 
alternative - but we coulnd't come up with any good alternative. So I 
think its ok for this use case to have it there.


Regards
Carsten

Am 19.04.2021 um 17:13 schrieb Oliver Lietz:

On Thursday, 15 April 2021 14:24:19 CEST Radu Cotescu wrote:

Hi,


On 14 Apr 2021, at 13:47, Oliver Lietz  wrote:

Sounds good! Do we agree on dedicated package
org.apache.sling.api.resource.type?


This has now been addressed -
https://github.com/apache/sling-org-apache-sling-scripting-spi/tree/master/
src/main/java/org/apache/sling/api/resource/type
.

Are we ok to release?


Back from holidays...

Carsten addressed the OSGi Version class and I wonder if there is a better
alternative (but no idea currently).

The javadoc build fails due to SlingHttpServletRequest with (Open) JDK 11 (.
0.10).

Thanks,
O.



Thanks,
Radu







--
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: Release of Servlets Resolver and Scripting bundles

2021-04-19 Thread Oliver Lietz

On Thursday, 15 April 2021 14:24:19 CEST Radu Cotescu wrote:
> Hi,
> 
> > On 14 Apr 2021, at 13:47, Oliver Lietz  wrote:
> > 
> > Sounds good! Do we agree on dedicated package
> > org.apache.sling.api.resource.type?
> 
> This has now been addressed -
> https://github.com/apache/sling-org-apache-sling-scripting-spi/tree/master/
> src/main/java/org/apache/sling/api/resource/type
>  /src/main/java/org/apache/sling/api/resource/type>.
> 
> Are we ok to release?

Back from holidays...

Carsten addressed the OSGi Version class and I wonder if there is a better 
alternative (but no idea currently).

The javadoc build fails due to SlingHttpServletRequest with (Open) JDK 11 (.
0.10).

Thanks,
O.

> Thanks,
> Radu

[GitHub] [sling-org-apache-sling-auth-core] abhishekgarg18 closed pull request #9: adding loggin



abhishekgarg18 closed pull request #9:
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/9


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-10319) Use the "equals" method if value comparison was intended



[ 
https://issues.apache.org/jira/browse/SLING-10319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325103#comment-17325103
 ] 

Carsten Ziegeler commented on SLING-10319:
--

Forgot to push one test:
https://github.com/apache/sling-org-apache-sling-auth-core/commit/769a5a4f5c1ba33c57555f2778685a89826fcb8f

> Use the "equals" method if value comparison was intended
> 
>
> Key: SLING-10319
> URL: https://issues.apache.org/jira/browse/SLING-10319
> Project: Sling
>  Issue Type: Improvement
>  Components: Authentication
>Affects Versions: Auth Core 1.5.0, Auth Core 1.5.2
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Auth Core 1.5.4
>
>
> See sonar check:
> https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core=AWogePnQ9zLXaOU8uV59=false=BUG
> The fix suggested at
> https://github.com/apache/sling-org-apache-sling-auth-core/pull/1
> will cause a NPE. The whole if block needs to be reworked



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-auth-core] cziegeler commented on pull request #9: adding loggin



cziegeler commented on pull request #9:
URL: 
https://github.com/apache/sling-org-apache-sling-auth-core/pull/9#issuecomment-822528731


   I guess we can close this PR as the problem was elsewhere?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Resolved] (SLING-10319) Use the "equals" method if value comparison was intended



 [ 
https://issues.apache.org/jira/browse/SLING-10319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-10319.
--
  Assignee: Carsten Ziegeler
Resolution: Fixed

Replaced the if block with a much simpler variant.

Added full test coverage

https://github.com/apache/sling-org-apache-sling-auth-core/commit/17913d1668ad783e70fc5eace50d8fb5202baee0

> Use the "equals" method if value comparison was intended
> 
>
> Key: SLING-10319
> URL: https://issues.apache.org/jira/browse/SLING-10319
> Project: Sling
>  Issue Type: Improvement
>  Components: Authentication
>Affects Versions: Auth Core 1.5.0, Auth Core 1.5.2
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Auth Core 1.5.4
>
>
> See sonar check:
> https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core=AWogePnQ9zLXaOU8uV59=false=BUG
> The fix suggested at
> https://github.com/apache/sling-org-apache-sling-auth-core/pull/1
> will cause a NPE. The whole if block needs to be reworked



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [VOTE] Release Apache Sling Auth Core 1.5.2

2021-04-19 Thread Daniel Klco

+1

On Sun, Apr 18, 2021 at 10:57 AM Carsten Ziegeler 
wrote:

> Hi,
>
> We solved 10 issues in this release:
> https://issues.apache.org/jira/projects/SLING/versions/12348715
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2431/
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2431 /tmp/sling-staging
>
> Please vote to approve this release:
>
>[ ] +1 Approve the release
>[ ]  0 Don't care
>[ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Regards
> Carsten
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziege...@apache.org
>

[GitHub] [sling-org-apache-sling-feature-launcher] sonarcloud[bot] commented on pull request #27: DockerHub build - using hooks to build and push



sonarcloud[bot] commented on pull request #27:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27#issuecomment-822508035


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-launcher=27=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher=27=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=coverage=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-launcher=27=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (SLING-10319) Use the "equals" method if value comparison was intended

Carsten Ziegeler created SLING-10319:


 Summary: Use the "equals" method if value comparison was intended
 Key: SLING-10319
 URL: https://issues.apache.org/jira/browse/SLING-10319
 Project: Sling
  Issue Type: Improvement
  Components: Authentication
Affects Versions: Auth Core 1.5.0, Auth Core 1.5.2
Reporter: Carsten Ziegeler
 Fix For: Auth Core 1.5.4


See sonar check:

https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core=AWogePnQ9zLXaOU8uV59=false=BUG

The fix suggested at
https://github.com/apache/sling-org-apache-sling-auth-core/pull/1
will cause a NPE. The whole if block needs to be reworked



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-auth-core] cziegeler commented on pull request #1: Strings and Boxed types should be compared using "equals()"



cziegeler commented on pull request #1:
URL: 
https://github.com/apache/sling-org-apache-sling-auth-core/pull/1#issuecomment-822501382


   Closing in favour of https://issues.apache.org/jira/browse/SLING-10319


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-auth-core] cziegeler closed pull request #1: Strings and Boxed types should be compared using "equals()"



cziegeler closed pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/1


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-10229) [LauncherContainer]Set up automated builds for this Docker image

2021-04-19 Thread Stefan Bischof (Jira)



[ 
https://issues.apache.org/jira/browse/SLING-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325059#comment-17325059
 ] 

Stefan Bischof commented on SLING-10229:


here is a pr that usex the dockerhub hooks to build and create an image with 3 
tags
- latest
- project-version
- commit hash

https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27

> [LauncherContainer]Set up automated builds for this Docker image 
> -
>
> Key: SLING-10229
> URL: https://issues.apache.org/jira/browse/SLING-10229
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Reporter: Stefan Bischof
>Priority: Minor
>
> This is an leftover from an other PR:
> [~rombert]: in  
> [PR|https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18]
> "I think it would be good to set up automated builds for this Docker image 
> eventually ( not in scope of this PR ). Looking at 
> https://stackoverflow.com/questions/36853002/writing-dockerfile-for-dockerhub-automated-builds,
>  it looks like the Docker build is basically invoking a top-level Dockerfile. 
> Maybe we should move the 'launch' Dockerfile where the plug-in expects it and 
> leave the top-level Dockerfile as an entry point for Dockerhub automated 
> builds?"
> ---
> I am not sure what you mean with `launch`Dockerfile. And that would mean that 
> we have 2 files?
> The Docker Hub automated build uses a file, that could be specified in 
> Docker-hub. They use the Tag/Branch as the version tag of the image. But we 
> are holding the version just inside maven. So I am not sure that this 
> automated build from the Dockerhub-side is the best way. And we are back at 
> the point where we have to find a way to copy the launcher-${version].jar 
> without changing the Dockerfile in every version just because of the 
> different names. 
> I would really like to have this official container automated in the docker 
> hub.
> But I do not know how to solve this with your CI-Tooling / Access rights on 
> DockerHub.
> Having an jenkins that builds every commit with the -P container option and 
> pushes the images would be the easiest way.
> regards
> Stefan



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Comment Edited] (SLING-10229) [LauncherContainer]Set up automated builds for this Docker image

2021-04-19 Thread Stefan Bischof (Jira)



[ 
https://issues.apache.org/jira/browse/SLING-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325059#comment-17325059
 ] 

Stefan Bischof edited comment on SLING-10229 at 4/19/21, 2:06 PM:
--

here is a pr that uses the dockerhub hooks to build and create an image with 3 
tags
 - latest
 - project-version
 - commit hash

[https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27]


was (Author: bisch...@jena.de):
here is a pr that usex the dockerhub hooks to build and create an image with 3 
tags
- latest
- project-version
- commit hash

https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27

> [LauncherContainer]Set up automated builds for this Docker image 
> -
>
> Key: SLING-10229
> URL: https://issues.apache.org/jira/browse/SLING-10229
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Reporter: Stefan Bischof
>Priority: Minor
>
> This is an leftover from an other PR:
> [~rombert]: in  
> [PR|https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18]
> "I think it would be good to set up automated builds for this Docker image 
> eventually ( not in scope of this PR ). Looking at 
> https://stackoverflow.com/questions/36853002/writing-dockerfile-for-dockerhub-automated-builds,
>  it looks like the Docker build is basically invoking a top-level Dockerfile. 
> Maybe we should move the 'launch' Dockerfile where the plug-in expects it and 
> leave the top-level Dockerfile as an entry point for Dockerhub automated 
> builds?"
> ---
> I am not sure what you mean with `launch`Dockerfile. And that would mean that 
> we have 2 files?
> The Docker Hub automated build uses a file, that could be specified in 
> Docker-hub. They use the Tag/Branch as the version tag of the image. But we 
> are holding the version just inside maven. So I am not sure that this 
> automated build from the Dockerhub-side is the best way. And we are back at 
> the point where we have to find a way to copy the launcher-${version].jar 
> without changing the Dockerfile in every version just because of the 
> different names. 
> I would really like to have this official container automated in the docker 
> hub.
> But I do not know how to solve this with your CI-Tooling / Access rights on 
> DockerHub.
> Having an jenkins that builds every commit with the -P container option and 
> pushes the images would be the easiest way.
> regards
> Stefan



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-feature-launcher] stbischof opened a new pull request #27: DockerHub build - using hooks to build and push



stbischof opened a new pull request #27:
URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27


   uses the DockerHub CI and hooks to build and tag and push  the docker images.
   tags: latest, project-version, commit-sha1
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [VOTE] Release Apache Sling Auth Core 1.5.2

2021-04-19 Thread Carsten Ziegeler

Thanks Cris,

while you bring up valid concerns, this release is not "worse" than the
previous one. I've increased the overall code coverage - still not
optimal. Especially the new code is covered. And in fact it's fixing a
bug introduced in 1.5.0.

Based on that I don't see a technical reason to discard the vote. All
the points can be addressed in a follow-up release.

Regards
Carsten

Am 19.04.2021 um 15:23 schrieb Cris Rockwell:

Hi,

-1 (non-binding) for now

All the work happened directly on the master branch. Why not have a PR so
others can review the changes in their totality?
PR's make it easier to review, because you get a clear picture of the overall
changes and test coverage[0].

Issue 8825 is not included in this release. But it seems like a valid issue.
String comparison with == just compares the instance identifiers,
so I don’t get how that would ever result true
https://issues.apache.org/jira/browse/SLING-8825

https://github.com/apache/sling-org-apache-sling-auth-core/pull/1

New code does not quite add up to 80% coverage.
https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-core=new_coverage=list

Since SlingAuthenticator.java handleSecurity and doHandleSecurity methods has
multiple uncovered branches.
As stated in the issue, this bundle handles some core security concerns.

There should be a way to get these covered.
https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-core=new_coverage=apache_sling-org-apache-sling-auth-core%3Asrc%2Fmain%2Fjava%2Forg%2Fapache%2Fsling%2Fauth%2Fcore%2Fimpl%2FSlingAuthenticator.java=list

Regards
Cris

On Apr 19, 2021, at 3:24 AM, Robert Munteanu wrote:

On Sun, 2021-04-18 at 16:56 +0200, Carsten Ziegeler wrote:

Please vote to approve this release:

+1
Robert

--
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #92 is BROKEN

ci.plugins.pipeline.maven.reportsFolder="/home/jenkins/jenkins-agent/workspace/_org-apache-sling-starter_master@tmp/withMaven44588a28"
 
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: /home/jenkins/tools/maven/latest3
Java version: 1.8.0_281, vendor: Oracle Corporation, runtime: 
/usr/local/asfpackages/java/oraclejdk-1.8.0-281/jre
Default locale: en_US, platform encoding: ISO-8859-1
OS name: "linux", version: "4.15.0-122-generic", arch: "amd64", family: "unix"
[INFO] [jenkins-event-spy] Generate 
/home/jenkins/jenkins-agent/workspace/_org-apache-sling-starter_master@tmp/withMaven44588a28/maven-spy-20210419-133513-8194765451131192025618.log.tmp
 ...
[INFO] Scanning for projects...
[INFO] 
[INFO] -< org.apache.sling:org.apache.sling.starter >--
[INFO] Building Apache Sling Starter Application 12-SNAPSHOT
[INFO] [ jar ]-
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.event/4.2.18/org.apache.sling.event-4.2.18.pom
[WARNING] The POM for org.apache.sling:org.apache.sling.event:jar:4.2.18 is 
missing, no dependency information available
[INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.event/4.2.18/org.apache.sling.event-4.2.18.jar
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time:  6.328 s
[INFO] Finished at: 2021-04-19T13:35:20Z
[INFO] ----
[INFO] [jenkins-event-spy] Generated 
/home/jenkins/jenkins-agent/workspace/_org-apache-sling-starter_master@tmp/withMaven44588a28/maven-spy-20210419-133513-8194765451131192025618.log
[ERROR] Failed to execute goal on project org.apache.sling.starter: Could not 
resolve dependencies for project 
org.apache.sling:org.apache.sling.starter:jar:12-SNAPSHOT: Could not find 
artifact org.apache.sling:org.apache.sling.event:jar:4.2.18 in central 
(https://repo.maven.apache.org/maven2) -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
[Pipeline] }
[DevOpticsMavenPublisher] dependencies consumed: 0, artifacts produced: 0
[withMaven] Publishers: Generated Artifacts Publisher: 1402 ms, Open Task 
Scanner Publisher: 172 ms
[Pipeline] // withMaven
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // timeout
[Pipeline] stage
[Pipeline] { (Notifications)
[Pipeline] echo
Status change is BROKEN, notifications will be sent.
[Pipeline] emailext

[jira] [Closed] (SLING-10120) Upgrade event to parent 41 [was: Upgrade event to parent 40]



 [ 
https://issues.apache.org/jira/browse/SLING-10120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Egli closed SLING-10120.
---

> Upgrade event to parent 41 [was: Upgrade event to parent 40]
> 
>
> Key: SLING-10120
> URL: https://issues.apache.org/jira/browse/SLING-10120
> Project: Sling
>  Issue Type: Sub-task
>  Components: Event
>Reporter: Robert Munteanu
>Assignee: Stefan Egli
>Priority: Major
> Fix For: Event 4.2.18
>
>  Time Spent: 5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-10300) fix maven dependencies in sling.event



 [ 
https://issues.apache.org/jira/browse/SLING-10300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Egli closed SLING-10300.
---

> fix maven dependencies in sling.event
> -
>
> Key: SLING-10300
> URL: https://issues.apache.org/jira/browse/SLING-10300
> Project: Sling
>  Issue Type: Task
>  Components: Event
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Major
> Fix For: Event 4.2.18
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> The following maven dependencies when building sling.event should be fixed:
> {noformat}
> [INFO] Scanning for projects...
> [WARNING] 
> [WARNING] Some problems were encountered while building the effective model 
> for org.apache.sling:org.apache.sling.event:jar:4.2.15-SNAPSHOT
> [WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must 
> be unique: org.apache.sling:org.apache.sling.serviceusermapper:jar -> version 
> 1.2.0 vs 1.4.6 @ line 357, column 21
> [WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must 
> be unique: org.apache.felix:org.apache.felix.framework:jar -> version 5.6.2 
> vs 6.0.3 @ line 377, column 21
> [WARNING] 
> [WARNING] It is highly recommended to fix these problems because they 
> threaten the stability of your build.
> [WARNING] 
> [WARNING] For this reason, future Maven versions might no longer support 
> building such malformed projects.
> [WARNING] 
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9906) Avoid retrying to load jobs if classes are missing



 [ 
https://issues.apache.org/jira/browse/SLING-9906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Egli closed SLING-9906.
--

> Avoid retrying to load jobs if classes are missing
> --
>
> Key: SLING-9906
> URL: https://issues.apache.org/jira/browse/SLING-9906
> Project: Sling
>  Issue Type: Improvement
>  Components: Event
>Reporter: Carsten Ziegeler
>Assignee: Stefan Egli
>Priority: Major
> Fix For: Event 4.2.18
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> When a Sling job is tried to be loaded, it might reference public api classes 
> provided by bundles - although that is a bad pattern that should be avoid, 
> sometimes this is used.
> While the job engine does not try to reload those jobs for execution - unless 
> such a new job is created (which is unlikely as the class is missing), the 
> re-assigning of jobs from a removed instance to a new one suffers from the 
> same problem. And that is retried over and over again.
> So there are probably several possible improvements:
> - make sure that jobs are not reloaded when public classes are missing during 
> job execution (unless bundles have changed)
> - reduce log output to a log statement (except of stack trace) if 
> classloading for jobs fails
> - change re-assigning of jobs to not require classes to be available. This 
> can probably be solved by using ResourceResolver.move



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-7756) Improve logging for Job retries



 [ 
https://issues.apache.org/jira/browse/SLING-7756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Egli closed SLING-7756.
--

> Improve logging for Job retries
> ---
>
> Key: SLING-7756
> URL: https://issues.apache.org/jira/browse/SLING-7756
> Project: Sling
>  Issue Type: Improvement
>  Components: Event
>Affects Versions: Event 4.2.10
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Event 4.2.18
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Currently a {{JobConsumer}} returning {{JobResult.FAILED}} is usually retried 
> (https://sling.apache.org/documentation/bundles/apache-sling-eventing-and-job-handling.html).
>  Unfortunately this is not exposed in the logs, so in case a JobConsumer logs 
> an error before returning {{JobResult.FAILED}} the job is silently retried 
> without any particular log message. I think each failed job should lead to a 
> WARN in the log (in case the job is retried) with the attempt number and 
> outstanding attempts in the log message. In case a job is not retried, an 
> ERROR should be emitted to the log for every failed job.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [VOTE] Release Apache Sling Auth Core 1.5.2

2021-04-19 Thread Cris Rockwell

Hi,

-1 (non-binding) for now

All the work happened directly on the master branch. Why not have a PR so 
others can review the changes in their totality?
PR's make it easier to review, because you get a clear picture of the overall 
changes and test coverage[0].

Issue 8825 is not included in this release. But it seems like a valid issue. 
String comparison with == just compares the instance identifiers,
so I don’t get how that would ever result true
https://issues.apache.org/jira/browse/SLING-8825 

https://github.com/apache/sling-org-apache-sling-auth-core/pull/1 

New code does not quite add up to 80% coverage. 
https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-core=new_coverage=list

Since SlingAuthenticator.java handleSecurity and doHandleSecurity methods has 
multiple uncovered branches. 
As stated in the issue, this bundle handles some core security concerns. 

There should be a way to get these covered.
https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-core=new_coverage=apache_sling-org-apache-sling-auth-core%3Asrc%2Fmain%2Fjava%2Forg%2Fapache%2Fsling%2Fauth%2Fcore%2Fimpl%2FSlingAuthenticator.java=list

Regards
Cris 

> On Apr 19, 2021, at 3:24 AM, Robert Munteanu  wrote:
> 
> On Sun, 2021-04-18 at 16:56 +0200, Carsten Ziegeler wrote:
>> Please vote to approve this release:
> 
> +1
> Robert

[RESULT][VOTE] Release Apache Sling Event Support 4.2.18

2021-04-19 Thread Stefan Egli


Hi,

The vote has passed with the following result :

+1 (binding): Stefan Seifert, Carsten Ziegeler, Eric Norman, Daniel Klco
+1 (non binding): Jörg Hoh

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

Cheers,
Stefan

On 13.04.21 15:45, Stefan Egli wrote:

Hi,

We solved 4 issues in this release:
https://issues.apache.org/jira/projects/SLING/versions/12350074

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2429/

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD 



Usage:
sh check_staged_release.sh 2429 /tmp/sling-staging

Please vote to approve this release:

[ ] +1 Approve the release
[ ]  0 Don't care
[ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Cheers,
Stefan

[GitHub] [sling-org-apache-sling-auth-core] abhishekgarg18 closed pull request #8: SLING-10273 adding null check



abhishekgarg18 closed pull request #8:
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/8


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-10318) Content Loader - Fix merge and overwrite options



[ 
https://issues.apache.org/jira/browse/SLING-10318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325001#comment-17325001
 ] 

Konrad Windszus commented on SLING-10318:
-

The first goal is to identify the desired behaviour (by fixing the javadoc). 
Then we need to consolidate the handling of the different types JSON, XML and 
JCR XML (because they behave differently with regards to the flag right now).

> Content Loader - Fix merge and overwrite options
> 
>
> Key: SLING-10318
> URL: https://issues.apache.org/jira/browse/SLING-10318
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.4.0
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: JCR ContentLoader 2.4.2
>
>
> There are 4 boolean flags which influence the import behaviour:
> # overwrite
> # overwriteProperties
> # merge
> # mergeProperties
> The latter two have been added with SLING-8243. Currently the  behaviour 
> differs between JSON and XML Import and also from the Javadoc 
> the differences between {{overwrite}} and {{merge}} are not really clear 
> (https://github.com/apache/sling-org-apache-sling-jcr-contentloader/blob/master/src/main/java/org/apache/sling/jcr/contentloader/ImportOptions.java).
> For me the flag {{merge}} seems a bit misleading, as the javadoc indicates 
> this will replace all old content (nodes and properties or only nodes). 
> Usually when you refer to a merge you also keep some part of the existing 
> content. It seems that {{merge}} should rather be named something like 
> {{replace}}. WDYT?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Comment Edited] (SLING-8243) Content Loader - support merge of properties and child nodes

2021-04-19 Thread Jason Bailey (Jira)



[ 
https://issues.apache.org/jira/browse/SLING-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324997#comment-17324997
 ] 

Jason Bailey edited comment on SLING-8243 at 4/19/21, 12:36 PM:


It's been 2 1/2 years since I touched this code and the overwrite and 
overwriteProperties were preexisting configurations. If I remember correctly, 
if you imported a node structure over an existing node structure without any 
directives set, It would just add new node's and properties starting from the 
top. So let's say the top node "A" with a child of "B" if you imported a new 
node of "A" that had a child of "C" it wouldn't do anything. "A" already exists 
so it doesn't get overwritten. Since it doesn't get overwritten it never gets 
to the child level to add "C". If set overwrite to true then your final result 
will be a top level node of "A" with two children of "B" and "C". If you then 
add the merge directive on your import the result will be a top level node of 
"A" with a singular child of "C"

If you chose all 4 of the directives you would essentially be replacing the 
existing content with the new content.

I'll see if I can pull together a diagram to explain it.


was (Author: jeb):
It's been 2 1/2 years since I touched this code and the overwrite and 
overwriteProperties were preexisting configurations. If I remember correctly, 
if you imported a node structure over an existing node structure without any 
properties set, It would just add new node's and properties starting from the 
top. So let's say the top node "A" with a child of "B" if you imported a new 
node of "A" that had a child of "C" it wouldn't do anything. "A" already exists 
so it doesn't get overwritten. Since it doesn't get overwritten it never gets 
to the child level to add "C". If set overwrite to true then your final result 
will be a top level node of "A" with two children of "B" and "C". If you then 
add the merge directive on your import the result will be a top level node of 
"A" with a singular child of "C"

If you chose all 4 of the directives you would essentially be replacing the 
existing content with the new content.

I'll see if I can pull together a diagram to explain it.

> Content Loader - support merge of properties and child nodes
> 
>
> Key: SLING-8243
> URL: https://issues.apache.org/jira/browse/SLING-8243
> Project: Sling
>  Issue Type: New Feature
>Reporter: Jason E Bailey
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: JCR ContentLoader 2.4.0
>
>
> Currently the Content Loader doesn't support a merge feature, a merge feature 
> would provide the ability for the an import to update existing properties and 
> nodes, and additionally delete the specific properties and nodes that aren't 
> imported.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-8243) Content Loader - support merge of properties and child nodes

2021-04-19 Thread Jason Bailey (Jira)



[ 
https://issues.apache.org/jira/browse/SLING-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324997#comment-17324997
 ] 

Jason Bailey commented on SLING-8243:
-

It's been 2 1/2 years since I touched this code and the overwrite and 
overwriteProperties were preexisting configurations. If I remember correctly, 
if you imported a node structure over an existing node structure without any 
properties set, It would just add new node's and properties starting from the 
top. So let's say the top node "A" with a child of "B" if you imported a new 
node of "A" that had a child of "C" it wouldn't do anything. "A" already exists 
so it doesn't get overwritten. Since it doesn't get overwritten it never gets 
to the child level to add "C". If set overwrite to true then your final result 
will be a top level node of "A" with two children of "B" and "C". If you then 
add the merge directive on your import the result will be a top level node of 
"A" with a singular child of "C"

If you chose all 4 of the directives you would essentially be replacing the 
existing content with the new content.

I'll see if I can pull together a diagram to explain it.

> Content Loader - support merge of properties and child nodes
> 
>
> Key: SLING-8243
> URL: https://issues.apache.org/jira/browse/SLING-8243
> Project: Sling
>  Issue Type: New Feature
>Reporter: Jason E Bailey
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: JCR ContentLoader 2.4.0
>
>
> Currently the Content Loader doesn't support a merge feature, a merge feature 
> would provide the ability for the an import to update existing properties and 
> nodes, and additionally delete the specific properties and nodes that aren't 
> imported.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-10318) Content Loader - Fix merge and overwrite options

2021-04-19 Thread Jason Bailey (Jira)



[ 
https://issues.apache.org/jira/browse/SLING-10318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324982#comment-17324982
 ] 

Jason Bailey commented on SLING-10318:
--

The idea here is that there was a need to have a feature that would delete 
nodes or properties that were no longer part of a daily import of data. I 
remember going back and forth a bit with someone on the mailing list about 
naming conventions and settled on merge. It's not clear what the goal of this 
ticket is. Clarity in documentation? Replacing the flag name?

> Content Loader - Fix merge and overwrite options
> 
>
> Key: SLING-10318
> URL: https://issues.apache.org/jira/browse/SLING-10318
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.4.0
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: JCR ContentLoader 2.4.2
>
>
> There are 4 boolean flags which influence the import behaviour:
> # overwrite
> # overwriteProperties
> # merge
> # mergeProperties
> The latter two have been added with SLING-8243. Currently the  behaviour 
> differs between JSON and XML Import and also from the Javadoc 
> the differences between {{overwrite}} and {{merge}} are not really clear 
> (https://github.com/apache/sling-org-apache-sling-jcr-contentloader/blob/master/src/main/java/org/apache/sling/jcr/contentloader/ImportOptions.java).
> For me the flag {{merge}} seems a bit misleading, as the javadoc indicates 
> this will replace all old content (nodes and properties or only nodes). 
> Usually when you refer to a merge you also keep some part of the existing 
> content. It seems that {{merge}} should rather be named something like 
> {{replace}}. WDYT?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #74: SLING-10243 extract Sling-Initial-Content



sonarcloud[bot] commented on pull request #74:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/74#issuecomment-822396941


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=74=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=74=false=BUG)
 [2 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=74=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=74=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=74=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=74=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=74=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=74=false=SECURITY_HOTSPOT)
 [2 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=74=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=74=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=74=false=CODE_SMELL)
 [18 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=74=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=74=new_coverage=list)
 [19.1% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=74=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=74=new_duplicated_lines_density=list)
 [4.4% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=74=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on a change in pull request #74: SLING-10243 extract Sling-Initial-Content



kwin commented on a change in pull request #74:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/74#discussion_r615767600



##
File path: 
src/main/java/org/apache/sling/feature/cpconverter/handlers/BundleEntryHandler.java
##
@@ -108,111 +144,302 @@ public void handle(@NotNull String path, @NotNull 
Archive archive, @NotNull Entr
 logger.debug("Start level {} was extracted from path {}", 
startLevel, path);
 }
 
-try (JarInputStream jarInput = new 
JarInputStream(Objects.requireNonNull(archive.openInputStream(entry {
-Properties properties = readGav(entry.getName(), jarInput);
-manifest = jarInput.getManifest();
-
-if (!properties.isEmpty()) {
-groupId = getCheckedProperty(properties, NAME_GROUP_ID);
-artifactId = getCheckedProperty(properties, NAME_ARTIFACT_ID);
-version = getCheckedProperty(properties, NAME_VERSION);
-classifier = properties.getProperty(NAME_CLASSIFIER);
-} else { // maybe the included jar is just an OSGi bundle but not 
a valid Maven artifact
-groupId = getCheckedProperty(manifest, BUNDLE_SYMBOLIC_NAME);
-// Make sure there are not spaces in the name to adhere to the 
Maven Group Id specification
-groupId = groupId.replace(' ', '_').replace(':', 
'_').replace('/', '_').replace('\\', '_');
-if (groupId.indexOf('.') != -1) {
-artifactId = groupId.substring(groupId.lastIndexOf('.') + 
1);
-groupId = groupId.substring(0, groupId.lastIndexOf('.'));
-}
-if (artifactId == null || artifactId.isEmpty()) {
-artifactId = groupId;
+String bundleName = entry.getName();
+// Remove the leading path
+int idx = bundleName.lastIndexOf('/');
+if (idx >= 0) {
+bundleName = bundleName.substring(idx + 1);
+}
+// Remove the extension
+int edx = bundleName.lastIndexOf('.');
+if (edx > 0) {
+bundleName = bundleName.substring(0, edx);
+}
+
+// create a temporary JAR file (extracted from archive)
+Path tmpBundleJar = 
Files.createTempFile(converter.getTempDirectory().toPath(), "extracted", 
bundleName + ".jar");
+try (OutputStream output = Files.newOutputStream(tmpBundleJar);
+ InputStream input = 
Objects.requireNonNull(archive.openInputStream(entry))) {
+IOUtils.copy(input, output);
+}
+
+try (JarFile jarFile = new JarFile(tmpBundleJar.toFile())) {
+// first extract bundle metadata from JAR input stream
+ArtifactId id = extractArtifactId(bundleName, jarFile);
+
+try (InputStream strippedBundleInput = extractInitialContent(id, 
jarFile, converter, runMode)) {
+
Objects.requireNonNull(converter.getArtifactsDeployer()).deploy(new 
InputStreamArtifactWriter(strippedBundleInput), id);
+
Objects.requireNonNull(converter.getFeaturesManager()).addArtifact(runMode, id, 
startLevel);
+
+String exportHeader = 
Objects.requireNonNull(jarFile.getManifest()).getMainAttributes().getValue(Constants.EXPORT_PACKAGE);
+if (exportHeader != null) {
+for (Clause clause : Parser.parseHeader(exportHeader)) {
+
converter.getFeaturesManager().addAPIRegionExport(runMode, clause.getName());
+}
 }
-Version osgiVersion = 
Version.parseVersion(getCheckedProperty(manifest, BUNDLE_VERSION));
-version = osgiVersion.getMajor() + "." + 
osgiVersion.getMinor() + "." + osgiVersion.getMicro() + 
(osgiVersion.getQualifier().isEmpty() ? "" : "-" + osgiVersion.getQualifier());
 }
+} finally {
+Files.delete(tmpBundleJar);
 }
+}
 
-try (InputStream input = archive.openInputStream(entry)) {
-if (input != null) {
-ArtifactId id = new ArtifactId(groupId, artifactId, version, 
classifier, JAR_TYPE);
+@NotNull InputStream extractInitialContent(@NotNull ArtifactId 
bundleArtifactId, @NotNull JarFile jarFile, @NotNull 
ContentPackage2FeatureModelConverter converter, @Nullable String runMode) 
throws Exception {
+// parse "Sling-Initial-Content" header
+Manifest manifest = Objects.requireNonNull(jarFile.getManifest());
+Iterator pathEntries = PathEntry.getContentPaths(manifest, 
-1);
+if (pathEntries == null) {
+return new FileInputStream(jarFile.getName());
+}
+logger.info("Extracting Sling-Initial-Content from '{}'", 
bundleArtifactId);
+Collection pathEntryList = new ArrayList<>();
+pathEntries.forEachRemaining(pathEntryList::add);
+
+// remove header
+

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on a change in pull request #74: SLING-10243 extract Sling-Initial-Content



kwin commented on a change in pull request #74:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/74#discussion_r615766440



##
File path: 
src/main/java/org/apache/sling/feature/cpconverter/cli/ContentPackage2FeatureModelConverterLauncher.java
##
@@ -133,6 +135,9 @@
 @Option(names = { "-u", "--unreferenced-artifacts-output-directory" }, 
description = "The output directory where unreferenced artifacts will be 
deployed.", required = false)
 private File unreferencedArtifactsOutputDirectory;
 
+@Option(names = { "-c", "--cndUri" }, description = "A URI returning a CND 
file. Used for resolving namespace prefixes in Sling-Initial-Content in 
addition to the namespaces given in the bundle headers", required = false)
+private List cndUris = new ArrayList<>();

Review comment:
   Done in 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/74/commits/36340ec7927e6679e831fc26a700760033e3500b.
 Thanks for the pointer.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Comment Edited] (SLING-7926) JSON Content Parser should support FileVault filename escaping



[ 
https://issues.apache.org/jira/browse/SLING-7926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324926#comment-17324926
 ] 

Konrad Windszus edited comment on SLING-7926 at 4/19/21, 10:16 AM:
---

As mentioned by [~sseifert] I don't see how this could be implemented without 
breaking backwards-compatibility. There may be bundles out there which rely on 
underscores which currently don't need to be escaped.


was (Author: kwin):
As mentioned by [~sseifert] I don't see how this could be implemented without 
breaking backwards-compatibility. There may be bundle out there which rely on 
underscored which currently don't need to be escaped.

> JSON Content Parser should support FileVault filename escaping
> --
>
> Key: SLING-7926
> URL: https://issues.apache.org/jira/browse/SLING-7926
> Project: Sling
>  Issue Type: Improvement
>Reporter: Jason E Bailey
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: JCR ContentLoader 2.4.2
>
>
> Currently it's possible to define a json file with a name that matches a 
> mangled namespace. Which then makes the file unable to be accessed from the 
> ResourceResolver
> i.e. importing a file {{_jcr_content.json}} will create the node 
> {{_jcr_content}} which cannot then be resolved as the resource resolver will 
> attempt to convert {{_jcr_content}} to {{jcr:content}} supporting namespace 
> mangling will additionally provide a cleaner {{colon}} support than the 
> current recommendation of a url mangled colon of {{%3A}}.
> The exact FileVault filename escape rules are outlined at 
> https://jackrabbit.apache.org/filevault/vaultfs.html#Filename_escaping.
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-7926) JSON Content Parser should support FileVault filename escaping



[ 
https://issues.apache.org/jira/browse/SLING-7926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324926#comment-17324926
 ] 

Konrad Windszus commented on SLING-7926:


As mentioned by [~sseifert] I don't see how this could be implemented without 
breaking backwards-compatibility. There may be bundle out there which rely on 
underscored which currently don't need to be escaped.

> JSON Content Parser should support FileVault filename escaping
> --
>
> Key: SLING-7926
> URL: https://issues.apache.org/jira/browse/SLING-7926
> Project: Sling
>  Issue Type: Improvement
>Reporter: Jason E Bailey
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: JCR ContentLoader 2.4.2
>
>
> Currently it's possible to define a json file with a name that matches a 
> mangled namespace. Which then makes the file unable to be accessed from the 
> ResourceResolver
> i.e. importing a file {{_jcr_content.json}} will create the node 
> {{_jcr_content}} which cannot then be resolved as the resource resolver will 
> attempt to convert {{_jcr_content}} to {{jcr:content}} supporting namespace 
> mangling will additionally provide a cleaner {{colon}} support than the 
> current recommendation of a url mangled colon of {{%3A}}.
> The exact FileVault filename escape rules are outlined at 
> https://jackrabbit.apache.org/filevault/vaultfs.html#Filename_escaping.
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls commented on a change in pull request #74: SLING-10243 extract Sling-Initial-Content



karlpauls commented on a change in pull request #74:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/74#discussion_r615709459



##
File path: 
src/main/java/org/apache/sling/feature/cpconverter/cli/ContentPackage2FeatureModelConverterLauncher.java
##
@@ -133,6 +135,9 @@
 @Option(names = { "-u", "--unreferenced-artifacts-output-directory" }, 
description = "The output directory where unreferenced artifacts will be 
deployed.", required = false)
 private File unreferencedArtifactsOutputDirectory;
 
+@Option(names = { "-c", "--cndUri" }, description = "A URI returning a CND 
file. Used for resolving namespace prefixes in Sling-Initial-Content in 
addition to the namespaces given in the bundle headers", required = false)
+private List cndUris = new ArrayList<>();

Review comment:
   I was hoping you could do something similar like we did for the service 
users - i.e., parse the repoinit and use the information from it. An example 
would be here: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/5be6cf3b0ce39372598343f015c9276cdb220909/src/main/java/org/apache/sling/feature/cpconverter/accesscontrol/DefaultAclManager.java#L185
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (SLING-7926) JSON Content Parser should support FileVault filename escaping



 [ 
https://issues.apache.org/jira/browse/SLING-7926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-7926:
---
Description: 
Currently it's possible to define a json file with a name that matches a 
mangled namespace. Which then makes the file unable to be accessed from the 
ResourceResolver

i.e. importing a file {{_jcr_content.json}} will create the node 
{{_jcr_content}} which cannot then be resolved as the resource resolver will 
attempt to convert {{_jcr_content}} to {{jcr:content}} supporting namespace 
mangling will additionally provide a cleaner {{colon}} support than the current 
recommendation of a url mangled colon of {{%3A}}.

The exact FileVault filename escape rules are outlined at 
https://jackrabbit.apache.org/filevault/vaultfs.html#Filename_escaping.

 

 

  was:
Currently it's possible to define a json file with a name that matches a 
mangled namespace. Which then makes the file unable to be accessed from the 
ResourceResolver

i.e. importing a file `_jcr_content.json` will create the node `_jcr_content` 
which cannot then be resolved as the resource resolver will attempt to convert 
`_jcr_content` to `jcr:content` supporting namespace mangling will additionally 
provide a cleaner `colon` support then the current recommendation of a url 
mangled colon of `%3A`

 

 


> JSON Content Parser should support FileVault filename escaping
> --
>
> Key: SLING-7926
> URL: https://issues.apache.org/jira/browse/SLING-7926
> Project: Sling
>  Issue Type: Improvement
>Reporter: Jason E Bailey
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: JCR ContentLoader 2.4.2
>
>
> Currently it's possible to define a json file with a name that matches a 
> mangled namespace. Which then makes the file unable to be accessed from the 
> ResourceResolver
> i.e. importing a file {{_jcr_content.json}} will create the node 
> {{_jcr_content}} which cannot then be resolved as the resource resolver will 
> attempt to convert {{_jcr_content}} to {{jcr:content}} supporting namespace 
> mangling will additionally provide a cleaner {{colon}} support than the 
> current recommendation of a url mangled colon of {{%3A}}.
> The exact FileVault filename escape rules are outlined at 
> https://jackrabbit.apache.org/filevault/vaultfs.html#Filename_escaping.
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-7926) JSON Content Parser should support FileVault filename escaping



 [ 
https://issues.apache.org/jira/browse/SLING-7926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-7926:
---
Summary: JSON Content Parser should support FileVault filename escaping  
(was: JSON Content Parser should support namespace mangling)

> JSON Content Parser should support FileVault filename escaping
> --
>
> Key: SLING-7926
> URL: https://issues.apache.org/jira/browse/SLING-7926
> Project: Sling
>  Issue Type: Improvement
>Reporter: Jason E Bailey
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: JCR ContentLoader 2.4.2
>
>
> Currently it's possible to define a json file with a name that matches a 
> mangled namespace. Which then makes the file unable to be accessed from the 
> ResourceResolver
> i.e. importing a file `_jcr_content.json` will create the node `_jcr_content` 
> which cannot then be resolved as the resource resolver will attempt to 
> convert `_jcr_content` to `jcr:content` supporting namespace mangling will 
> additionally provide a cleaner `colon` support then the current 
> recommendation of a url mangled colon of `%3A`
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-10297) Expose org.apache.sling.jcr.contentloader.internal.PathEntry as API



 [ 
https://issues.apache.org/jira/browse/SLING-10297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus resolved SLING-10297.
-
Resolution: Fixed

Fixed in 
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/commit/372e212078ee0a5da31f21943d9a5d6ec96a509b.

> Expose org.apache.sling.jcr.contentloader.internal.PathEntry as API
> ---
>
> Key: SLING-10297
> URL: https://issues.apache.org/jira/browse/SLING-10297
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: JCR ContentLoader 2.4.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: JCR ContentLoader 2.4.2
>
>  Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> To ease parsing the {{Sling-Initial-Content}} header outside the OSGi 
> container context (e.g. for SLING-10243) it would be useful to expose the 
> {{PathEntry}} 
> (https://github.com/apache/sling-org-apache-sling-jcr-contentloader/blob/235a16eaa8cb6ed0fde56b1966e6506d1edae46f/src/main/java/org/apache/sling/jcr/contentloader/internal/PathEntry.java)
>  as API



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-jcr-contentloader] kwin merged pull request #6: SLING-10297 expose PathEntry as API



kwin merged pull request #6:
URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/6


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-jcr-contentloader] kwin commented on a change in pull request #6: SLING-10297 expose PathEntry as API



kwin commented on a change in pull request #6:
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/6#discussion_r615703327



##
File path: src/main/java/org/apache/sling/jcr/contentloader/package-info.java
##
@@ -17,6 +17,6 @@
  * under the License.
  */
 
-@org.osgi.annotation.versioning.Version("0.4.0")
+@org.osgi.annotation.versioning.Version("0.5.0")

Review comment:
   Let's discuss separately. I'll merge as is.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on a change in pull request #74: SLING-10243 extract Sling-Initial-Content



kwin commented on a change in pull request #74:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/74#discussion_r615700227



##
File path: 
src/main/java/org/apache/sling/feature/cpconverter/cli/ContentPackage2FeatureModelConverterLauncher.java
##
@@ -133,6 +135,9 @@
 @Option(names = { "-u", "--unreferenced-artifacts-output-directory" }, 
description = "The output directory where unreferenced artifacts will be 
deployed.", required = false)
 private File unreferencedArtifactsOutputDirectory;
 
+@Option(names = { "-c", "--cndUri" }, description = "A URI returning a CND 
file. Used for resolving namespace prefixes in Sling-Initial-Content in 
addition to the namespaces given in the bundle headers", required = false)
+private List cndUris = new ArrayList<>();

Review comment:
   Do you have some pointers how to easily extract the CNDs from there?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on pull request #74: SLING-10243 extract Sling-Initial-Content



kwin commented on pull request #74:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/74#issuecomment-822331297


   >  do we need another cli switch for this?
   
   Currently `Sling-Initial-Content` does not require the prefixes to be 
defined. As long as they exist in the repo when importing the content all is 
fine. That does not work with FileVault DocView XML though, as that always 
requires the full namespace declaration at the beginning of the XML.
   
   There might be some bundles relying on well-known namespaces like `crx` or 
`cq`. Without that CLI option the conversion must fail, as they are nowhere 
else defined.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls commented on a change in pull request #74: SLING-10243 extract Sling-Initial-Content



karlpauls commented on a change in pull request #74:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/74#discussion_r615699403



##
File path: 
src/main/java/org/apache/sling/feature/cpconverter/cli/ContentPackage2FeatureModelConverterLauncher.java
##
@@ -133,6 +135,9 @@
 @Option(names = { "-u", "--unreferenced-artifacts-output-directory" }, 
description = "The output directory where unreferenced artifacts will be 
deployed.", required = false)
 private File unreferencedArtifactsOutputDirectory;
 
+@Option(names = { "-c", "--cndUri" }, description = "A URI returning a CND 
file. Used for resolving namespace prefixes in Sling-Initial-Content in 
addition to the namespaces given in the bundle headers", required = false)
+private List cndUris = new ArrayList<>();

Review comment:
   So, basically, use the --seed-feature (if any), parse the repoinit (if 
any), and use the given namespaces there (if any)...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (SLING-10318) Content Loader - Fix merge and overwrite options



 [ 
https://issues.apache.org/jira/browse/SLING-10318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-10318:

Description: 
There are 4 boolean flags which influence the import behaviour:

# overwrite
# overwriteProperties
# merge
# mergeProperties

The latter two have been added with SLING-8243. Currently the  behaviour 
differs between JSON and XML Import and also from the Javadoc at the 
differences between {{overwrite}} and {{merge}} is not really clear 
(https://github.com/apache/sling-org-apache-sling-jcr-contentloader/blob/master/src/main/java/org/apache/sling/jcr/contentloader/ImportOptions.java).

For me the flag {{merge}} seems a bit misleading, as the javadoc indicates this 
will replace all old content (nodes and properties or only nodes). Usually when 
you refer to a merge you also keep some part of the existing content. It seems 
that {{merge}} should rather be named something like {{replace}}. WDYT?

  was:
There are 4 boolean flags which influence the import behaviour:

1. overwrite
1. overwriteProperties
1. merge
1. mergeProperties

The latter two have been added with SLING-8243. Currently the  behaviour 
differs between JSON and XML Import and also from the Javadoc at the 
differences between {{overwrite}} and {{merge}} is not really clear 
(https://github.com/apache/sling-org-apache-sling-jcr-contentloader/blob/master/src/main/java/org/apache/sling/jcr/contentloader/ImportOptions.java).

For me the flag {{merge}} seems a bit misleading, as the javadoc indicates this 
will replace all old content (nodes and properties or only nodes). Usually when 
you refer to a merge you also keep some part of the existing content. It seems 
that {{merge}} should rather be named something like {{replace}}. WDYT?


> Content Loader - Fix merge and overwrite options
> 
>
> Key: SLING-10318
> URL: https://issues.apache.org/jira/browse/SLING-10318
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.4.0
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: JCR ContentLoader 2.4.2
>
>
> There are 4 boolean flags which influence the import behaviour:
> # overwrite
> # overwriteProperties
> # merge
> # mergeProperties
> The latter two have been added with SLING-8243. Currently the  behaviour 
> differs between JSON and XML Import and also from the Javadoc at the 
> differences between {{overwrite}} and {{merge}} is not really clear 
> (https://github.com/apache/sling-org-apache-sling-jcr-contentloader/blob/master/src/main/java/org/apache/sling/jcr/contentloader/ImportOptions.java).
> For me the flag {{merge}} seems a bit misleading, as the javadoc indicates 
> this will replace all old content (nodes and properties or only nodes). 
> Usually when you refer to a merge you also keep some part of the existing 
> content. It seems that {{merge}} should rather be named something like 
> {{replace}}. WDYT?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-10318) Content Loader - Fix merge and overwrite options



 [ 
https://issues.apache.org/jira/browse/SLING-10318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-10318:

Description: 
There are 4 boolean flags which influence the import behaviour:

# overwrite
# overwriteProperties
# merge
# mergeProperties

The latter two have been added with SLING-8243. Currently the  behaviour 
differs between JSON and XML Import and also from the Javadoc 
the differences between {{overwrite}} and {{merge}} are not really clear 
(https://github.com/apache/sling-org-apache-sling-jcr-contentloader/blob/master/src/main/java/org/apache/sling/jcr/contentloader/ImportOptions.java).

For me the flag {{merge}} seems a bit misleading, as the javadoc indicates this 
will replace all old content (nodes and properties or only nodes). Usually when 
you refer to a merge you also keep some part of the existing content. It seems 
that {{merge}} should rather be named something like {{replace}}. WDYT?

  was:
There are 4 boolean flags which influence the import behaviour:

# overwrite
# overwriteProperties
# merge
# mergeProperties

The latter two have been added with SLING-8243. Currently the  behaviour 
differs between JSON and XML Import and also from the Javadoc at the 
differences between {{overwrite}} and {{merge}} is not really clear 
(https://github.com/apache/sling-org-apache-sling-jcr-contentloader/blob/master/src/main/java/org/apache/sling/jcr/contentloader/ImportOptions.java).

For me the flag {{merge}} seems a bit misleading, as the javadoc indicates this 
will replace all old content (nodes and properties or only nodes). Usually when 
you refer to a merge you also keep some part of the existing content. It seems 
that {{merge}} should rather be named something like {{replace}}. WDYT?


> Content Loader - Fix merge and overwrite options
> 
>
> Key: SLING-10318
> URL: https://issues.apache.org/jira/browse/SLING-10318
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.4.0
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: JCR ContentLoader 2.4.2
>
>
> There are 4 boolean flags which influence the import behaviour:
> # overwrite
> # overwriteProperties
> # merge
> # mergeProperties
> The latter two have been added with SLING-8243. Currently the  behaviour 
> differs between JSON and XML Import and also from the Javadoc 
> the differences between {{overwrite}} and {{merge}} are not really clear 
> (https://github.com/apache/sling-org-apache-sling-jcr-contentloader/blob/master/src/main/java/org/apache/sling/jcr/contentloader/ImportOptions.java).
> For me the flag {{merge}} seems a bit misleading, as the javadoc indicates 
> this will replace all old content (nodes and properties or only nodes). 
> Usually when you refer to a merge you also keep some part of the existing 
> content. It seems that {{merge}} should rather be named something like 
> {{replace}}. WDYT?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-feature-launcher] stbischof commented on pull request #26: container: adoptopenjdk/openjdk11:alpine-jre



stbischof commented on pull request #26:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/26#issuecomment-822312127


   I am happy to get the fast review/response! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (SLING-10318) Content Loader - Fix merge and overwrite options



 [ 
https://issues.apache.org/jira/browse/SLING-10318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-10318:

Description: 
There are 4 boolean flags which influence the import behaviour:

1. overwrite
1. overwriteProperties
1. merge
1. mergeProperties

The latter two have been added with SLING-8243. Currently the  behaviour 
differs between JSON and XML Import and also from the Javadoc at the 
differences between {{overwrite}} and {{merge}} is not really clear 
(https://github.com/apache/sling-org-apache-sling-jcr-contentloader/blob/master/src/main/java/org/apache/sling/jcr/contentloader/ImportOptions.java).

For me the flag {{merge}} seems a bit misleading, as the javadoc indicates this 
will replace all old content (nodes and properties or only nodes). Usually when 
you refer to a merge you also keep some part of the existing content. It seems 
that {{merge}} should rather be named something like {{replace}}. WDYT?

  was:
There are 4 boolean flags which influence the import behaviour:

1. overwrite
1. overwriteProperties
1. merge
1. mergeProperties

The latter two have been added with SLING-8243. Currently the  behaviour 
differs between JSON and XML Import and also from the Javadoc at the 
differences between {{overwrite}} and {{merge}} is not really clear 
(https://github.com/apache/sling-org-apache-sling-jcr-contentloader/blob/master/src/main/java/org/apache/sling/jcr/contentloader/ImportOptions.java).


> Content Loader - Fix merge and overwrite options
> 
>
> Key: SLING-10318
> URL: https://issues.apache.org/jira/browse/SLING-10318
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.4.0
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: JCR ContentLoader 2.4.2
>
>
> There are 4 boolean flags which influence the import behaviour:
> 1. overwrite
> 1. overwriteProperties
> 1. merge
> 1. mergeProperties
> The latter two have been added with SLING-8243. Currently the  behaviour 
> differs between JSON and XML Import and also from the Javadoc at the 
> differences between {{overwrite}} and {{merge}} is not really clear 
> (https://github.com/apache/sling-org-apache-sling-jcr-contentloader/blob/master/src/main/java/org/apache/sling/jcr/contentloader/ImportOptions.java).
> For me the flag {{merge}} seems a bit misleading, as the javadoc indicates 
> this will replace all old content (nodes and properties or only nodes). 
> Usually when you refer to a merge you also keep some part of the existing 
> content. It seems that {{merge}} should rather be named something like 
> {{replace}}. WDYT?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-10318) Content Loader - Fix merge and overwrite options



 [ 
https://issues.apache.org/jira/browse/SLING-10318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-10318:

Description: 
There are 4 boolean flags which influence the import behaviour:

1. overwrite
1. overwriteProperties
1. merge
1. mergeProperties

The latter two have been added with SLING-8243. Currently the  behaviour 
differs between JSON and XML Import and also from the Javadoc at the 
differences between {{overwrite}} and {{merge}} is not really clear 
(https://github.com/apache/sling-org-apache-sling-jcr-contentloader/blob/master/src/main/java/org/apache/sling/jcr/contentloader/ImportOptions.java).

  was:
There are 4 boolean flags which influence the import behaviour:

1. overwrite
1. overwriteProperties
1. merge
1. mergeProperties

The latter two have been added with SLING-8243. Currently the  behaviour 
differs between JSON and XML Import and also from the Javadoc at the 
differences between {{overwrite}} and {{merge}} is not really clear.


> Content Loader - Fix merge and overwrite options
> 
>
> Key: SLING-10318
> URL: https://issues.apache.org/jira/browse/SLING-10318
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.4.0
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: JCR ContentLoader 2.4.2
>
>
> There are 4 boolean flags which influence the import behaviour:
> 1. overwrite
> 1. overwriteProperties
> 1. merge
> 1. mergeProperties
> The latter two have been added with SLING-8243. Currently the  behaviour 
> differs between JSON and XML Import and also from the Javadoc at the 
> differences between {{overwrite}} and {{merge}} is not really clear 
> (https://github.com/apache/sling-org-apache-sling-jcr-contentloader/blob/master/src/main/java/org/apache/sling/jcr/contentloader/ImportOptions.java).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-10318) Content Loader - Fix merge and overwrite options



[ 
https://issues.apache.org/jira/browse/SLING-10318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324836#comment-17324836
 ] 

Konrad Windszus commented on SLING-10318:
-

[~sseifert] [~jeb] I would appreciate your input here with regards to the 
desired behaviour before I come up with a fix.

> Content Loader - Fix merge and overwrite options
> 
>
> Key: SLING-10318
> URL: https://issues.apache.org/jira/browse/SLING-10318
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR ContentLoader 2.4.0
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: JCR ContentLoader 2.4.2
>
>
> There are 4 boolean flags which influence the import behaviour:
> 1. overwrite
> 1. overwriteProperties
> 1. merge
> 1. mergeProperties
> The latter two have been added with SLING-8243. Currently the  behaviour 
> differs between JSON and XML Import and also from the Javadoc at the 
> differences between {{overwrite}} and {{merge}} is not really clear.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-10318) Content Loader - Fix merge and overwrite options

Konrad Windszus created SLING-10318:
---

 Summary: Content Loader - Fix merge and overwrite options
 Key: SLING-10318
 URL: https://issues.apache.org/jira/browse/SLING-10318
 Project: Sling
  Issue Type: Improvement
  Components: JCR
Affects Versions: JCR ContentLoader 2.4.0
Reporter: Konrad Windszus
 Fix For: JCR ContentLoader 2.4.2


There are 4 boolean flags which influence the import behaviour:

1. overwrite
1. overwriteProperties
1. merge
1. mergeProperties

The latter two have been added with SLING-8243. Currently the  behaviour 
differs between JSON and XML Import and also from the Javadoc at the 
differences between {{overwrite}} and {{merge}} is not really clear.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-feature-launcher] bdelacretaz commented on pull request #26: container: adoptopenjdk/openjdk11:alpine-jre



bdelacretaz commented on pull request #26:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/26#issuecomment-82229


   > ...Sling starter uses openjdk:8-jre-alpine and that is an jre not an jdk...
   
   Correct, sorry about the noise and +1 for this change then!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Resolved] (SLING-10316) Provide an option to use dependencies for javadoc artifact



 [ 
https://issues.apache.org/jira/browse/SLING-10316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-10316.
--
Resolution: Fixed

Added two new options:
- useApiDependenciesForJavadoc : if enabled, dependencies are also used for 
javadoc
- generateJavadocForAllApi : if the previous one is enabled and this is 
enabled, in addition a second javadoc jar will be generated with all api - 
basically the same if previous option is false

https://github.com/apache/sling-slingfeature-maven-plugin/commit/327e53eeed826246d487fa52f7be049229f50686

> Provide an option to use dependencies for javadoc artifact
> --
>
> Key: SLING-10316
> URL: https://issues.apache.org/jira/browse/SLING-10316
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.5.2
>
>
> When generating api jars, dependencies can be used instead of embedding for 
> the binary and the source jar - but not for the javadoc jar. This one always 
> contains the full api.
> An option should be provided to also use dependencies for the javadoc jar.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Comment Edited] (SLING-8243) Content Loader - support merge of properties and child nodes



[ 
https://issues.apache.org/jira/browse/SLING-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324805#comment-17324805
 ] 

Konrad Windszus edited comment on SLING-8243 at 4/19/21, 7:59 AM:
--

[~jebailey] Ping again. 
Also it is not really clear what the differences are to {{overwrite}} and 
{{overwriteProperties}}. What happens if both directives (merge and overwrite) 
are set to {{true}}? Also it seems this has not been implemented for 
{{importJcrXml(...)}}.


was (Author: kwin):
[~jebailey] Ping again. 
Also it is not really clear what the differences are {{overwrite}} and 
{{overwriteProperties}}. What happens if both directives are set to {{true}}?

> Content Loader - support merge of properties and child nodes
> 
>
> Key: SLING-8243
> URL: https://issues.apache.org/jira/browse/SLING-8243
> Project: Sling
>  Issue Type: New Feature
>Reporter: Jason E Bailey
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: JCR ContentLoader 2.4.0
>
>
> Currently the Content Loader doesn't support a merge feature, a merge feature 
> would provide the ability for the an import to update existing properties and 
> nodes, and additionally delete the specific properties and nodes that aren't 
> imported.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-8243) Content Loader - support merge of properties and child nodes