[jira] [Resolved] (SLING-7637) PropertyRenderingTest fails
[
https://issues.apache.org/jira/browse/SLING-7637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz resolved SLING-7637.
Resolution: Fixed
Assignee: Bertrand Delacretaz
I have fixed the test with this commit:
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/commit/2001e979f756eba37aa71e6c6db850987e8e33ed
But I'm not sure what caused it to fail. The root cause is that HttpClient gets
a redirect if the URL ends with /multiText without a trailing / and the GET
request that follows the redirect doesn't include credentials (see requests
dump below).
The change might be that Sling previously didn't send a redirect, or that it
didn't require credentials before. Or maybe that the httpclient version changed
and behaves differently.
Requests/responses:
{code}
##
T 127.0.0.1:57426 -> 127.0.0.1:8080 [AP]
GET /PropertyRenderingTest/1525348448317/this_is_a_test_15253/multiText HTTP
/1.1..Authorization: Basic YWRtaW46YWRtaW4=..User-Agent: Jakarta Commons-Htt
pClient/3.1..Host: localhost:8080
##
T 127.0.0.1:8080 -> 127.0.0.1:57426 [AP]
HTTP/1.1 302 Found..Date: Thu, 03 May 2018 11:54:40 GMT..X-Content-Type-Opti
ons: nosniff..X-Frame-Options: SAMEORIGIN..FILTER_COUNTER_SLING: 1..FILTER_C
OUNTER_NOPROP: 1..Location: http://localhost:8080/PropertyRenderingTest/1525
348448317/this_is_a_test_15253/multiText/..Content-Length: 0
##
T 127.0.0.1:57426 -> 127.0.0.1:8080 [AP]
GET /PropertyRenderingTest/1525348448317/this_is_a_test_15253/multiText/ HTT
P/1.1..User-Agent: Jakarta Commons-HttpClient/3.1..Host: localhost:8080
##
{code}
The second GET does not include the {{Authorization}} header.
> PropertyRenderingTest fails
> ---
>
> Key: SLING-7637
> URL: https://issues.apache.org/jira/browse/SLING-7637
> Project: Sling
> Issue Type: Bug
> Components: Testing
>Reporter: Robert Munteanu
>Assignee: Bertrand Delacretaz
>Priority: Major
> Labels: sling-IT
>
> org.apache.sling.launchpad.webapp.integrationtest.PropertyRenderingTest.testMultiValuedTextNoExt
> fails with
> {{http://localhost:41000/PropertyRenderingTest/1525143696194/this_is_a_test_15251/multiText
> expected:<403> but was:<404>}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SLING-7621) Regex path matching in Sling Dynamic Include
[
https://issues.apache.org/jira/browse/SLING-7621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz resolved SLING-7621.
Resolution: Fixed
Thank you for your contribution! I have merged your pull request and made a few
minor changes after that, please cross-check.
There were lots of extra whitespace changes in your diffs, in general if you
can avoid that it's better, for the clarify of the diffs. But sometimes our
source code is inconsistent in terms of white space so that's not always easy -
no big deal and thank you again.
> Regex path matching in Sling Dynamic Include
>
>
> Key: SLING-7621
> URL: https://issues.apache.org/jira/browse/SLING-7621
> Project: Sling
> Issue Type: New Feature
>Affects Versions: Dynamic Include 3.0.0
>Reporter: Marek Krokosinski
>Assignee: Bertrand Delacretaz
>Priority: Major
> Fix For: Dynamic Include 3.0.2
>
>
> In some cases one might want to include external content to a page. Example
> of such external content are AEM Experience Fragments or Content Fragments,
> or Zen Garden Snippets.
> Sometimes such 3rd party content can be categorized into two categories:
> * not included by SDI - content which should not be included separately (for
> example when content requires page context)
> * included by SDI - content which is static, so it can be cached because it
> does not change often (header, footer), or because it changes once per week
> and we don't want to invalidate whole cache.
> Example content structure:
> * /content/my-site/my-micro-site/en_gl/content/fragments/
> * /content/my-site/my-micro-site/en_gl/content/fragments/cacheable-fragments
> When content is specific to market (by market I mean for example British
> market, German market etc.), and we would want to include that 3rd party
> content using SDI, we would have to provide one Sling Dynamic Include
> configuration per market.
> As you may know, one site can have 100 or more markets, it means at least
> 100 configuration for such simple case (and usually, it's not the only one!).
> Solution for this problem is to change the way, how SDI performs check on the
> path.
> Currently SDI checks if requested resource path starts from the configured
> path.
> Instead of simple check with startsWith, SDI should support regular
> expressions, which are much more flexible.
> In the given scenario we would have one simple configuration with path
> configured to:
> ^/content/my-site/([a-zA-Z-_]+)/([a-z]{2}_[a-z]{2})/content/fragments/cacheable-fragments$
> I have created pull requests which also provides some unit tests for
> Configuration and ConfigurationWhiteboard classes.
>
> Pull request:
> https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/3
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (SLING-7621) Regex path matching in Sling Dynamic Include
[
https://issues.apache.org/jira/browse/SLING-7621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz reassigned SLING-7621:
--
Assignee: Bertrand Delacretaz
> Regex path matching in Sling Dynamic Include
>
>
> Key: SLING-7621
> URL: https://issues.apache.org/jira/browse/SLING-7621
> Project: Sling
> Issue Type: New Feature
>Affects Versions: Dynamic Include 3.0.0
>Reporter: Marek Krokosinski
>Assignee: Bertrand Delacretaz
>Priority: Major
> Fix For: Dynamic Include 3.0.2
>
>
> In some cases one might want to include external content to a page. Example
> of such external content are AEM Experience Fragments or Content Fragments,
> or Zen Garden Snippets.
> Sometimes such 3rd party content can be categorized into two categories:
> * not included by SDI - content which should not be included separately (for
> example when content requires page context)
> * included by SDI - content which is static, so it can be cached because it
> does not change often (header, footer), or because it changes once per week
> and we don't want to invalidate whole cache.
> Example content structure:
> * /content/my-site/my-micro-site/en_gl/content/fragments/
> * /content/my-site/my-micro-site/en_gl/content/fragments/cacheable-fragments
> When content is specific to market (by market I mean for example British
> market, German market etc.), and we would want to include that 3rd party
> content using SDI, we would have to provide one Sling Dynamic Include
> configuration per market.
> As you may know, one site can have 100 or more markets, it means at least
> 100 configuration for such simple case (and usually, it's not the only one!).
> Solution for this problem is to change the way, how SDI performs check on the
> path.
> Currently SDI checks if requested resource path starts from the configured
> path.
> Instead of simple check with startsWith, SDI should support regular
> expressions, which are much more flexible.
> In the given scenario we would have one simple configuration with path
> configured to:
> ^/content/my-site/([a-zA-Z-_]+)/([a-z]{2}_[a-z]{2})/content/fragments/cacheable-fragments$
> I have created pull requests which also provides some unit tests for
> Configuration and ConfigurationWhiteboard classes.
>
> Pull request:
> https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/3
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SLING-7621) Regex path matching in Sling Dynamic Include
[
https://issues.apache.org/jira/browse/SLING-7621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz updated SLING-7621:
---
Fix Version/s: Dynamic Include 3.0.2
> Regex path matching in Sling Dynamic Include
>
>
> Key: SLING-7621
> URL: https://issues.apache.org/jira/browse/SLING-7621
> Project: Sling
> Issue Type: New Feature
>Affects Versions: Dynamic Include 3.0.0
>Reporter: Marek Krokosinski
>Priority: Major
> Fix For: Dynamic Include 3.0.2
>
>
> In some cases one might want to include external content to a page. Example
> of such external content are AEM Experience Fragments or Content Fragments,
> or Zen Garden Snippets.
> Sometimes such 3rd party content can be categorized into two categories:
> * not included by SDI - content which should not be included separately (for
> example when content requires page context)
> * included by SDI - content which is static, so it can be cached because it
> does not change often (header, footer), or because it changes once per week
> and we don't want to invalidate whole cache.
> Example content structure:
> * /content/my-site/my-micro-site/en_gl/content/fragments/
> * /content/my-site/my-micro-site/en_gl/content/fragments/cacheable-fragments
> When content is specific to market (by market I mean for example British
> market, German market etc.), and we would want to include that 3rd party
> content using SDI, we would have to provide one Sling Dynamic Include
> configuration per market.
> As you may know, one site can have 100 or more markets, it means at least
> 100 configuration for such simple case (and usually, it's not the only one!).
> Solution for this problem is to change the way, how SDI performs check on the
> path.
> Currently SDI checks if requested resource path starts from the configured
> path.
> Instead of simple check with startsWith, SDI should support regular
> expressions, which are much more flexible.
> In the given scenario we would have one simple configuration with path
> configured to:
> ^/content/my-site/([a-zA-Z-_]+)/([a-z]{2}_[a-z]{2})/content/fragments/cacheable-fragments$
> I have created pull requests which also provides some unit tests for
> Configuration and ConfigurationWhiteboard classes.
>
> Pull request:
> https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/3
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7621) Regex path matching in Sling Dynamic Include
[
https://issues.apache.org/jira/browse/SLING-7621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456179#comment-16456179
]
Bertrand Delacretaz commented on SLING-7621:
> I can check only for ^ at the begin of the input value.
My suggestion was to check for either that or $ at end end - I think one of
them clearly signals a regexp, and by checking only one of them writing the
regexp is more flexible.
> Regex path matching in Sling Dynamic Include
>
>
> Key: SLING-7621
> URL: https://issues.apache.org/jira/browse/SLING-7621
> Project: Sling
> Issue Type: New Feature
>Affects Versions: Dynamic Include 3.0.0
>Reporter: Marek Krokosinski
>Priority: Major
>
> In some cases one might want to include external content to a page. Example
> of such external content are AEM Experience Fragments or Content Fragments,
> or Zen Garden Snippets.
> Sometimes such 3rd party content can be categorized into two categories:
> * not included by SDI - content which should not be included separately (for
> example when content requires page context)
> * included by SDI - content which is static, so it can be cached because it
> does not change often (header, footer), or because it changes once per week
> and we don't want to invalidate whole cache.
> Example content structure:
> * /content/my-site/my-micro-site/en_gl/content/fragments/
> * /content/my-site/my-micro-site/en_gl/content/fragments/cacheable-fragments
> When content is specific to market (by market I mean for example British
> market, German market etc.), and we would want to include that 3rd party
> content using SDI, we would have to provide one Sling Dynamic Include
> configuration per market.
> As you may know, one site can have 100 or more markets, it means at least
> 100 configuration for such simple case (and usually, it's not the only one!).
> Solution for this problem is to change the way, how SDI performs check on the
> path.
> Currently SDI checks if requested resource path starts from the configured
> path.
> Instead of simple check with startsWith, SDI should support regular
> expressions, which are much more flexible.
> In the given scenario we would have one simple configuration with path
> configured to:
> ^/content/my-site/([a-zA-Z-_]+)/([a-z]{2}_[a-z]{2})/content/fragments/cacheable-fragments$
> I have created pull requests which also provides some unit tests for
> Configuration and ConfigurationWhiteboard classes.
>
> Pull request:
> https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/3
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7621) Regex path matching in Sling Dynamic Include
[
https://issues.apache.org/jira/browse/SLING-7621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456119#comment-16456119
]
Bertrand Delacretaz commented on SLING-7621:
Ah ok, got it now, your plan is that if the path starts with ^ and ends with $
you consider it a regexp, otherwise it's just a startsWith expression.
I think that works but maybe you can have just one of those conditions? A
regexp must either start with ^ or end with $, otherwise it's considered a
startsWith expression - that can make writing them easier. And log a the DEBUG
level which variant you select, of course.
> Regex path matching in Sling Dynamic Include
>
>
> Key: SLING-7621
> URL: https://issues.apache.org/jira/browse/SLING-7621
> Project: Sling
> Issue Type: New Feature
>Affects Versions: Dynamic Include 3.0.0
>Reporter: Marek Krokosinski
>Priority: Major
>
> In some cases one might want to include external content to a page. Example
> of such external content are AEM Experience Fragments or Content Fragments,
> or Zen Garden Snippets.
> Sometimes such 3rd party content can be categorized into two categories:
> * not included by SDI - content which should not be included separately (for
> example when content requires page context)
> * included by SDI - content which is static, so it can be cached because it
> does not change often (header, footer), or because it changes once per week
> and we don't want to invalidate whole cache.
> Example content structure:
> * /content/my-site/my-micro-site/en_gl/content/fragments/
> * /content/my-site/my-micro-site/en_gl/content/fragments/cacheable-fragments
> When content is specific to market (by market I mean for example British
> market, German market etc.), and we would want to include that 3rd party
> content using SDI, we would have to provide one Sling Dynamic Include
> configuration per market.
> As you may know, one site can have 100 or more markets, it means at least
> 100 configuration for such simple case (and usually, it's not the only one!).
> Solution for this problem is to change the way, how SDI performs check on the
> path.
> Currently SDI checks if requested resource path starts from the configured
> path.
> Instead of simple check with startsWith, SDI should support regular
> expressions, which are much more flexible.
> In the given scenario we would have one simple configuration with path
> configured to:
> ^/content/my-site/([a-zA-Z-_]+)/([a-z]{2}_[a-z]{2})/content/fragments/cacheable-fragments$
> I have created pull requests which also provides some unit tests for
> Configuration and ConfigurationWhiteboard classes.
>
> Pull request:
> https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/3
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (SLING-7621) Regex path matching in Sling Dynamic Include
[
https://issues.apache.org/jira/browse/SLING-7621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456104#comment-16456104
]
Bertrand Delacretaz edited comment on SLING-7621 at 4/27/18 8:22 AM:
-
I haven't used SDI myself but what you suggest looks useful, thanks for this
contribution!
How about backwards compatibility? IIUC with your changes an existing
{{include-filter.config.path}} configuration property is processed as a regexp,
so will not match anything unless a {{.*}} is appended to it.
If I'm correct, I think that would break backwards compatibility. One way to
avoid this is to define the path regexp as a new property, recommend that it's
used instead of the old parameter, and complain if both are defined. Or maybe
you have a better suggestion? Assuming my understanding is correct.
was (Author: bdelacretaz):
I haven't used SDI myself but what you suggest looks useful, thanks for this
contribution!
How about backwards compatibility? IIUC with your changes an existing
{{include-filter.config.path}} configuration property is processed as a regexp,
so will not match anything unless a {{.*}} is appended to it.
If I'm correct, I think that would break backwards compatibility. One way to
avoid this is to define the path regexp as a new property, recommend that it's
used before the old parameter, and complain if both are defined. Or maybe you
have a better suggestion? Assuming my understanding is correct.
> Regex path matching in Sling Dynamic Include
>
>
> Key: SLING-7621
> URL: https://issues.apache.org/jira/browse/SLING-7621
> Project: Sling
> Issue Type: New Feature
>Affects Versions: Dynamic Include 3.0.0
>Reporter: Marek Krokosinski
>Priority: Major
>
> In some cases one might want to include external content to a page. Example
> of such external content are AEM Experience Fragments or Content Fragments,
> or Zen Garden Snippets.
> Sometimes such 3rd party content can be categorized into two categories:
> * not included by SDI - content which should not be included separately (for
> example when content requires page context)
> * included by SDI - content which is static, so it can be cached because it
> does not change often (header, footer), or because it changes once per week
> and we don't want to invalidate whole cache.
> Example content structure:
> * /content/my-site/my-micro-site/en_gl/content/fragments/
> * /content/my-site/my-micro-site/en_gl/content/fragments/cacheable-fragments
> When content is specific to market (by market I mean for example British
> market, German market etc.), and we would want to include that 3rd party
> content using SDI, we would have to provide one Sling Dynamic Include
> configuration per market.
> As you may know, one site can have 100 or more markets, it means at least
> 100 configuration for such simple case (and usually, it's not the only one!).
> Solution for this problem is to change the way, how SDI performs check on the
> path.
> Currently SDI checks if requested resource path starts from the configured
> path.
> Instead of simple check with startsWith, SDI should support regular
> expressions, which are much more flexible.
> In the given scenario we would have one simple configuration with path
> configured to:
> ^/content/my-site/([a-zA-Z-_]+)/([a-z]{2}_[a-z]{2})/content/fragments/cacheable-fragments$
> I have created pull requests which also provides some unit tests for
> Configuration and ConfigurationWhiteboard classes.
>
> Pull request:
> https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/3
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (SLING-7621) Regex path matching in Sling Dynamic Include
[
https://issues.apache.org/jira/browse/SLING-7621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456104#comment-16456104
]
Bertrand Delacretaz edited comment on SLING-7621 at 4/27/18 8:22 AM:
-
I haven't used SDI myself but what you suggest looks useful, thanks for this
contribution!
How about backwards compatibility? IIUC with your changes an existing
{{include-filter.config.path}} configuration property is processed as a regexp,
so will not match anything unless a {{.*}} is appended to it.
If I'm correct, I think that would break backwards compatibility. One way to
avoid this is to define the path regexp as a new property, recommend that it's
used before the old parameter, and complain if both are defined. Or maybe you
have a better suggestion? Assuming my understanding is correct.
was (Author: bdelacretaz):
I haven't used SDI myself but what you suggest looks useful, thanks for this
contribution!
How about backwards compatibility? IIUC with your changes an existing
`include-filter.config.path` configuration property is processed as a regexp,
so will not match anything unless a `.*` is appended to it.
If I'm correct, I think that would break backwards compatibility. One way to
avoid this is to define the path regexp as a new property, recommend that it's
used before the old parameter, and complain if both are defined. Or maybe you
have a better suggestion? Assuming my understanding is correct.
> Regex path matching in Sling Dynamic Include
>
>
> Key: SLING-7621
> URL: https://issues.apache.org/jira/browse/SLING-7621
> Project: Sling
> Issue Type: New Feature
>Affects Versions: Dynamic Include 3.0.0
>Reporter: Marek Krokosinski
>Priority: Major
>
> In some cases one might want to include external content to a page. Example
> of such external content are AEM Experience Fragments or Content Fragments,
> or Zen Garden Snippets.
> Sometimes such 3rd party content can be categorized into two categories:
> * not included by SDI - content which should not be included separately (for
> example when content requires page context)
> * included by SDI - content which is static, so it can be cached because it
> does not change often (header, footer), or because it changes once per week
> and we don't want to invalidate whole cache.
> Example content structure:
> * /content/my-site/my-micro-site/en_gl/content/fragments/
> * /content/my-site/my-micro-site/en_gl/content/fragments/cacheable-fragments
> When content is specific to market (by market I mean for example British
> market, German market etc.), and we would want to include that 3rd party
> content using SDI, we would have to provide one Sling Dynamic Include
> configuration per market.
> As you may know, one site can have 100 or more markets, it means at least
> 100 configuration for such simple case (and usually, it's not the only one!).
> Solution for this problem is to change the way, how SDI performs check on the
> path.
> Currently SDI checks if requested resource path starts from the configured
> path.
> Instead of simple check with startsWith, SDI should support regular
> expressions, which are much more flexible.
> In the given scenario we would have one simple configuration with path
> configured to:
> ^/content/my-site/([a-zA-Z-_]+)/([a-z]{2}_[a-z]{2})/content/fragments/cacheable-fragments$
> I have created pull requests which also provides some unit tests for
> Configuration and ConfigurationWhiteboard classes.
>
> Pull request:
> https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/3
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7621) Regex path matching in Sling Dynamic Include
[
https://issues.apache.org/jira/browse/SLING-7621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456104#comment-16456104
]
Bertrand Delacretaz commented on SLING-7621:
I haven't used SDI myself but what you suggest looks useful, thanks for this
contribution!
How about backwards compatibility? IIUC with your changes an existing
`include-filter.config.path` configuration property is processed as a regexp,
so will not match anything unless a `.*` is appended to it.
If I'm correct, I think that would break backwards compatibility. One way to
avoid this is to define the path regexp as a new property, recommend that it's
used before the old parameter, and complain if both are defined. Or maybe you
have a better suggestion? Assuming my understanding is correct.
> Regex path matching in Sling Dynamic Include
>
>
> Key: SLING-7621
> URL: https://issues.apache.org/jira/browse/SLING-7621
> Project: Sling
> Issue Type: New Feature
>Affects Versions: Dynamic Include 3.0.0
>Reporter: Marek Krokosinski
>Priority: Major
>
> In some cases one might want to include external content to a page. Example
> of such external content are AEM Experience Fragments or Content Fragments,
> or Zen Garden Snippets.
> Sometimes such 3rd party content can be categorized into two categories:
> * not included by SDI - content which should not be included separately (for
> example when content requires page context)
> * included by SDI - content which is static, so it can be cached because it
> does not change often (header, footer), or because it changes once per week
> and we don't want to invalidate whole cache.
> Example content structure:
> * /content/my-site/my-micro-site/en_gl/content/fragments/
> * /content/my-site/my-micro-site/en_gl/content/fragments/cacheable-fragments
> When content is specific to market (by market I mean for example British
> market, German market etc.), and we would want to include that 3rd party
> content using SDI, we would have to provide one Sling Dynamic Include
> configuration per market.
> As you may know, one site can have 100 or more markets, it means at least
> 100 configuration for such simple case (and usually, it's not the only one!).
> Solution for this problem is to change the way, how SDI performs check on the
> path.
> Currently SDI checks if requested resource path starts from the configured
> path.
> Instead of simple check with startsWith, SDI should support regular
> expressions, which are much more flexible.
> In the given scenario we would have one simple configuration with path
> configured to:
> ^/content/my-site/([a-zA-Z-_]+)/([a-z]{2}_[a-z]{2})/content/fragments/cacheable-fragments$
> I have created pull requests which also provides some unit tests for
> Configuration and ConfigurationWhiteboard classes.
>
> Pull request:
> https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/3
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7612) Use Declarative Services to register optional components
[ https://issues.apache.org/jira/browse/SLING-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448182#comment-16448182 ] Bertrand Delacretaz commented on SLING-7612: hehe, this old stuff challenges our memories of how things were built ;-) We might accept these changes then but if we do so I suggest adding a backwards compatibility note in the README, about potential startup sequence changes. Nothing that this shouldn't be a problem if Declarative Services are available before this module starts. > Use Declarative Services to register optional components > > > Key: SLING-7612 > URL: https://issues.apache.org/jira/browse/SLING-7612 > Project: Sling > Issue Type: Improvement > Components: Commons >Affects Versions: Commons Mime 2.1.10 >Reporter: Christian Schneider >Priority: Major > Fix For: Commons Mime 2.1.12 > > > Currently the TikaMimeTypeProvider as well as the MimeTypeWebConsolePlugin > are registered programmatically. I guess this is done make sure they work > with the optional package dependencies. > I recently learned that DS is very good to handle this case. So I propose to > do both with simple DS component annotations. I will provide a PR. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7612) Use Declarative Services to register optional components
[ https://issues.apache.org/jira/browse/SLING-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448148#comment-16448148 ] Bertrand Delacretaz commented on SLING-7612: Christian, you're right that your changes make the code cleaner but they don't bring any functional benefits IMO and Carsten is right about breaking backwards compatibility. I suggest that we drop these changes, to avoid breaking backwards compatibility. > Use Declarative Services to register optional components > > > Key: SLING-7612 > URL: https://issues.apache.org/jira/browse/SLING-7612 > Project: Sling > Issue Type: Improvement > Components: Commons >Affects Versions: Commons Mime 2.1.10 >Reporter: Christian Schneider >Priority: Major > Fix For: Commons Mime 2.1.12 > > > Currently the TikaMimeTypeProvider as well as the MimeTypeWebConsolePlugin > are registered programmatically. I guess this is done make sure they work > with the optional package dependencies. > I recently learned that DS is very good to handle this case. So I propose to > do both with simple DS component annotations. I will provide a PR. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-7611) Replace LogService with slf4j
[ https://issues.apache.org/jira/browse/SLING-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-7611. Resolution: Fixed Assignee: Bertrand Delacretaz Fix Version/s: Commons Mime 2.1.12 Pull request merged, thanks for your contribution! > Replace LogService with slf4j > - > > Key: SLING-7611 > URL: https://issues.apache.org/jira/browse/SLING-7611 > Project: Sling > Issue Type: Improvement > Components: Commons >Affects Versions: Commons Mime 2.1.10 >Reporter: Christian Schneider >Assignee: Bertrand Delacretaz >Priority: Major > Fix For: Commons Mime 2.1.12 > > Time Spent: 20m > Remaining Estimate: 0h > > Currently commons mime uses the LogService to log registered mime types. If > no LogService is available (like often in tests) it directly writes to > stdout. In this case it is not possible to configure what is logged. > So I propose to switch this to slf4j. So this module works more like the > other ones in sling and the logging is easier to set up. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (SLING-7612) Use Declarative Services to register optional components
[ https://issues.apache.org/jira/browse/SLING-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448072#comment-16448072 ] Bertrand Delacretaz edited comment on SLING-7612 at 4/23/18 12:43 PM: -- Does this bring any actual benefit besides being "more modern", in a way? I'm a bit wary as using DS will slightly change the startup dynamics, i.e. with this the TikaMimeTypeProvider will start later and other components might see the mime type service without that feature being active (_comment edited, I misunderstood initially_). If the changes does bring any actual benefits why not, but I'm not sure that's the case - might be worth a discussion on our dev list. was (Author: bdelacretaz): Does this bring any actual benefit besides being "more modern", in a way? I'm a bit wary as using DS will slightly change the startup dynamics and I suppose many components have a reference to the MimeTypeService and as such might start later, as MimeTypeService will now wait for DS. If the changes does bring any actual benefits why not, but I'm not sure that's the case - might be worth a discussion on our dev list. > Use Declarative Services to register optional components > > > Key: SLING-7612 > URL: https://issues.apache.org/jira/browse/SLING-7612 > Project: Sling > Issue Type: Improvement > Components: Commons >Affects Versions: Commons Mime 2.1.10 >Reporter: Christian Schneider >Priority: Major > Fix For: Commons Mime 2.1.12 > > > Currently the TikaMimeTypeProvider as well as the MimeTypeWebConsolePlugin > are registered programmatically. I guess this is done make sure they work > with the optional package dependencies. > I recently learned that DS is very good to handle this case. So I propose to > do both with simple DS component annotations. I will provide a PR. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7612) Use DS to register optional components
[ https://issues.apache.org/jira/browse/SLING-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448072#comment-16448072 ] Bertrand Delacretaz commented on SLING-7612: Does this bring any actual benefit besides being "more modern", in a way? I'm a bit wary as using DS will slightly change the startup dynamics and I suppose many components have a reference to the MimeTypeService and as such might start later, as MimeTypeService will now wait for DS. If the changes does bring any actual benefits why not, but I'm not sure that's the case - might be worth a discussion on our dev list. > Use DS to register optional components > -- > > Key: SLING-7612 > URL: https://issues.apache.org/jira/browse/SLING-7612 > Project: Sling > Issue Type: Improvement > Components: Commons >Affects Versions: Commons Mime 2.1.10 >Reporter: Christian Schneider >Priority: Major > Fix For: Commons Mime 2.1.12 > > > Currently the TikaMimeTypeProvider as well as the MimeTypeWebConsolePlugin > are registered programmatically. I guess this is done make sure they work > with the optional package dependencies. > I recently learned that DS is very good to handle this case. So I propose to > do both with simple DS component annotations. I will provide a PR. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7612) Use Declarative Services to register optional components
[ https://issues.apache.org/jira/browse/SLING-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-7612: --- Summary: Use Declarative Services to register optional components (was: Use DS to register optional components) > Use Declarative Services to register optional components > > > Key: SLING-7612 > URL: https://issues.apache.org/jira/browse/SLING-7612 > Project: Sling > Issue Type: Improvement > Components: Commons >Affects Versions: Commons Mime 2.1.10 >Reporter: Christian Schneider >Priority: Major > Fix For: Commons Mime 2.1.12 > > > Currently the TikaMimeTypeProvider as well as the MimeTypeWebConsolePlugin > are registered programmatically. I guess this is done make sure they work > with the optional package dependencies. > I recently learned that DS is very good to handle this case. So I propose to > do both with simple DS component annotations. I will provide a PR. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (SLING-7534) Release policy - stop providing MD5 signatures
[
https://issues.apache.org/jira/browse/SLING-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436956#comment-16436956
]
Bertrand Delacretaz edited comment on SLING-7534 at 4/13/18 7:35 AM:
-
As per discussion at [1], it looks like it's indeed {{maven-deploy-plugin}}
which generates the checksum files - although I don't see a mention of
checksums in the docs at
[http://maven.apache.org/plugins/maven-deploy-plugin/deploy-mojo.html] so I'm
still a bit skeptical.
However in INFRA-14923 and at [1] Brian Fox says that getting rid of {{.md5}}
requires Nexus code changes.
I suggest that we wait for INFRA-14923 to be clarified, nothing's urgent.
[1]
[https://lists.apache.org/thread.html/c50e4842dbbe13b8196a43fa76d6040f8971bc5e812b561d080c5776@%3Cusers.infra.apache.org%3E]
was (Author: bdelacretaz):
As per discussion at [1], it looks like it's indeed {{maven-deploy-plugin}}
which generates the checksum files.
However in INFRA-14923 and at [1] Brian Fox says that getting rid of {{.md5}}
requires Nexus code changes.
I suggest that we wait for INFRA-14923 to be clarified, nothing's urgent.
[1]
https://lists.apache.org/thread.html/c50e4842dbbe13b8196a43fa76d6040f8971bc5e812b561d080c5776@%3Cusers.infra.apache.org%3E
> Release policy - stop providing MD5 signatures
> --
>
> Key: SLING-7534
> URL: https://issues.apache.org/jira/browse/SLING-7534
> Project: Sling
> Issue Type: Task
> Components: Tooling
>Reporter: Robert Munteanu
>Priority: Major
>
> See http://www.apache.org/dev/release-distribution#sigs-and-sums , we SHOULD
> no longer provide MD5 checksums for new releases.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7534) Release policy - stop providing MD5 signatures
[
https://issues.apache.org/jira/browse/SLING-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436956#comment-16436956
]
Bertrand Delacretaz commented on SLING-7534:
As per discussion at [1], it looks like it's indeed {{maven-deploy-plugin}}
which generates the checksum files.
However in INFRA-14923 and at [1] Brian Fox says that getting rid of {{.md5}}
requires Nexus code changes.
I suggest that we wait for INFRA-14923 to be clarified, nothing's urgent.
[1]
https://lists.apache.org/thread.html/c50e4842dbbe13b8196a43fa76d6040f8971bc5e812b561d080c5776@%3Cusers.infra.apache.org%3E
> Release policy - stop providing MD5 signatures
> --
>
> Key: SLING-7534
> URL: https://issues.apache.org/jira/browse/SLING-7534
> Project: Sling
> Issue Type: Task
> Components: Tooling
>Reporter: Robert Munteanu
>Priority: Major
>
> See http://www.apache.org/dev/release-distribution#sigs-and-sums , we SHOULD
> no longer provide MD5 checksums for new releases.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7534) Release policy - stop providing MD5 signatures
[ https://issues.apache.org/jira/browse/SLING-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436925#comment-16436925 ] Bertrand Delacretaz commented on SLING-7534: Once this is clarified we should also remove existing .md5 files under https://dist.apache.org/repos/dist/release/sling/ > Release policy - stop providing MD5 signatures > -- > > Key: SLING-7534 > URL: https://issues.apache.org/jira/browse/SLING-7534 > Project: Sling > Issue Type: Task > Components: Tooling >Reporter: Robert Munteanu >Priority: Major > > See http://www.apache.org/dev/release-distribution#sigs-and-sums , we SHOULD > no longer provide MD5 checksums for new releases. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7534) Release policy - stop providing MD5 signatures
[ https://issues.apache.org/jira/browse/SLING-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435564#comment-16435564 ] Bertrand Delacretaz commented on SLING-7534: I have asked on infrastructure@a.o if Nexus generates the checksum files on upload, mentioning this ticket's ID. Unfortunately [https://lists.apache.org/list.html?infrastruct...@apache.org] does not show recent messages, for some reason. > Release policy - stop providing MD5 signatures > -- > > Key: SLING-7534 > URL: https://issues.apache.org/jira/browse/SLING-7534 > Project: Sling > Issue Type: Task > Components: Tooling >Reporter: Robert Munteanu >Priority: Major > > See http://www.apache.org/dev/release-distribution#sigs-and-sums , we SHOULD > no longer provide MD5 checksums for new releases. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7534) Release policy - stop providing MD5 signatures
[
https://issues.apache.org/jira/browse/SLING-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435459#comment-16435459
]
Bertrand Delacretaz commented on SLING-7534:
I'm wondering if it's repository.apache.org that generates the checksums:
grepping the output of {{mvn -X deploy}} on the
{{sling-org-apache-sling-engine}} module as an example:
{code}
$ egrep -i 'md5|checksum|uploaded' deploy-output.txt
${createChecksum}
[DEBUG] (f) createChecksum = false
Uploaded:
https://repository.apache.org/content/repositories/snapshots/org/apache/sling/org.apache.sling.engine/2.6.13-SNAPSHOT/org.apache.sling.engine-2.6.13-20180412.121129-18.jar
(203 KB at 96.0 KB/sec)
Uploaded:
https://repository.apache.org/content/repositories/snapshots/org/apache/sling/org.apache.sling.engine/2.6.13-SNAPSHOT/org.apache.sling.engine-2.6.13-20180412.121129-18.pom
(10 KB at 5.1 KB/sec)
Uploaded:
https://repository.apache.org/content/repositories/snapshots/org/apache/sling/org.apache.sling.engine/2.6.13-SNAPSHOT/maven-metadata.xml
(1011 B at 0.7 KB/sec)
Uploaded:
https://repository.apache.org/content/repositories/snapshots/org/apache/sling/org.apache.sling.engine/maven-metadata.xml
(2 KB at 0.7 KB/sec)
Uploaded:
https://repository.apache.org/content/repositories/snapshots/org/apache/sling/org.apache.sling.engine/2.6.13-SNAPSHOT/org.apache.sling.engine-2.6.13-20180412.121129-18-sources.jar
(144 KB at 71.2 KB/sec)
Uploaded:
https://repository.apache.org/content/repositories/snapshots/org/apache/sling/org.apache.sling.engine/2.6.13-SNAPSHOT/maven-metadata.xml
(1011 B at 0.7 KB/sec)
{code}
It doesn't seem like checksums are generated by the build nor uploaded, but
after running the above there is an
https://repository.apache.org/content/repositories/snapshots/org/apache/sling/org.apache.sling.engine/2.6.13-SNAPSHOT/org.apache.sling.engine-2.6.13-20180412.121129-18-sources.jar.md5
indeed.
Also, {{mvn help:effective-pom}} doesn't say anything about checksums or md5 -
but maybe those are defaults of the install or release plugin, I'm not sure.
> Release policy - stop providing MD5 signatures
> --
>
> Key: SLING-7534
> URL: https://issues.apache.org/jira/browse/SLING-7534
> Project: Sling
> Issue Type: Task
> Components: Tooling
>Reporter: Robert Munteanu
>Priority: Major
>
> See http://www.apache.org/dev/release-distribution#sigs-and-sums , we SHOULD
> no longer provide MD5 checksums for new releases.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SLING-7477) Downloads page should explain how to verify releases
[ https://issues.apache.org/jira/browse/SLING-7477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-7477. Resolution: Fixed Done, the downloads page now points to https://www.apache.org/info/verification > Downloads page should explain how to verify releases > > > Key: SLING-7477 > URL: https://issues.apache.org/jira/browse/SLING-7477 > Project: Sling > Issue Type: Task > Components: Site >Reporter: Bertrand Delacretaz >Priority: Major > > As suggested by Sebb at SLING-7474 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7536) Refactor servlets resolver implementation
[ https://issues.apache.org/jira/browse/SLING-7536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-7536: --- Summary: Refactor servlets resolver implementation (was: Refactor implementation) > Refactor servlets resolver implementation > - > > Key: SLING-7536 > URL: https://issues.apache.org/jira/browse/SLING-7536 > Project: Sling > Issue Type: Improvement > Components: Servlets >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Servlets Resolver 2.4.24 > > > The SlingServletResolver class is currently a combination of various things. > I think we should refactor it to make the code more maintainable -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7545) Groovy Scripting Engine not loading in Apache Sling 10
[
https://issues.apache.org/jira/browse/SLING-7545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407784#comment-16407784
]
Bertrand Delacretaz commented on SLING-7545:
I have also added an integration test that would have exposed this regression:
https://github.com/apache/sling-org-apache-sling-scripting-core/blob/master/src/test/java/org/apache/sling/scripting/core/impl/jsr223/Jsr223ScriptEngineBundleIT.java
> Groovy Scripting Engine not loading in Apache Sling 10
> --
>
> Key: SLING-7545
> URL: https://issues.apache.org/jira/browse/SLING-7545
> Project: Sling
> Issue Type: Bug
> Components: Scripting
>Affects Versions: Scripting Core 2.0.54
>Reporter: Ben Fortuna
>Assignee: Bertrand Delacretaz
>Priority: Major
> Fix For: Scripting Core 2.0.56
>
>
> With the latest release of Apache Sling (10) the Groovy Scripting engine is
> no longer loading.
> The impact is that scripts with a (*.groovy) extension aren't rendering.
> This works with Apache Sling 9, so I believe there was a change in the Apache
> Sling Scripting Core that broke the Groovy implementation.
>
> How to reproduce:
> Load groovy-all JAR into Apache Sling as a bundle, under the url
> [http://localhost:8080/system/console/status-slingscripting] the following
> should display:
> {code:java}
> Groovy Scripting Engine 2.0
> -
> - Language : Groovy, 2.4.14
> - Extensions : groovy
> - MIME Types : application/x-groovy
> - Names : groovy, Groovy{code}
>
> This works with Apache Sling 9, not with Sling 10
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7545) Groovy Scripting Engine not loading in Apache Sling 10
[
https://issues.apache.org/jira/browse/SLING-7545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406431#comment-16406431
]
Bertrand Delacretaz commented on SLING-7545:
Thanks [~kwin], I was wondering about that indeed, should have asked.
I have removed the {{BundleListener.class}} element of the services annotation,
in commit 0339ac9
> Groovy Scripting Engine not loading in Apache Sling 10
> --
>
> Key: SLING-7545
> URL: https://issues.apache.org/jira/browse/SLING-7545
> Project: Sling
> Issue Type: Bug
> Components: Scripting
>Affects Versions: Scripting Core 2.0.54
>Reporter: Ben Fortuna
>Assignee: Bertrand Delacretaz
>Priority: Major
> Fix For: Scripting Core 2.0.56
>
>
> With the latest release of Apache Sling (10) the Groovy Scripting engine is
> no longer loading.
> The impact is that scripts with a (*.groovy) extension aren't rendering.
> This works with Apache Sling 9, so I believe there was a change in the Apache
> Sling Scripting Core that broke the Groovy implementation.
>
> How to reproduce:
> Load groovy-all JAR into Apache Sling as a bundle, under the url
> [http://localhost:8080/system/console/status-slingscripting] the following
> should display:
> {code:java}
> Groovy Scripting Engine 2.0
> -
> - Language : Groovy, 2.4.14
> - Extensions : groovy
> - MIME Types : application/x-groovy
> - Names : groovy, Groovy{code}
>
> This works with Apache Sling 9, not with Sling 10
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (SLING-7545) Groovy Scripting Engine not loading in Apache Sling 10
[
https://issues.apache.org/jira/browse/SLING-7545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406299#comment-16406299
]
Bertrand Delacretaz edited comment on SLING-7545 at 3/20/18 1:18 PM:
-
Thank you [~fortuna] for verfiying, marking this fixed.
Digging deeper it looks like this bug has been introduced by the following
commit for SLING-7134 - I'll add a comment there to verify that fixing this one
does not cause trouble there.
[https://github.com/apache/sling-org-apache-sling-scripting-core/commit/2e15bd4f230d390ceadc9481627156bb3b6caaa3#diff-502d0f72184777e3bfd2f0e1dca75eff]
IIUC this means that scripting-core V 2.0.52 also has this bug.
was (Author: bdelacretaz):
Thank you [~fortuna] for verfiying, marking this fixed.
Digging deeper it looks like this bug has been introduced by the following
commit for SLING-7134 - I'll add a comment there to verify that fixing this one
does not cause trouble there.
https://github.com/apache/sling-org-apache-sling-scripting-core/commit/2e15bd4f230d390ceadc9481627156bb3b6caaa3#diff-502d0f72184777e3bfd2f0e1dca75eff
> Groovy Scripting Engine not loading in Apache Sling 10
> --
>
> Key: SLING-7545
> URL: https://issues.apache.org/jira/browse/SLING-7545
> Project: Sling
> Issue Type: Bug
> Components: Scripting
>Affects Versions: Scripting Core 2.0.54
>Reporter: Ben Fortuna
>Assignee: Bertrand Delacretaz
>Priority: Major
> Fix For: Scripting Core 2.0.56
>
>
> With the latest release of Apache Sling (10) the Groovy Scripting engine is
> no longer loading.
> The impact is that scripts with a (*.groovy) extension aren't rendering.
> This works with Apache Sling 9, so I believe there was a change in the Apache
> Sling Scripting Core that broke the Groovy implementation.
>
> How to reproduce:
> Load groovy-all JAR into Apache Sling as a bundle, under the url
> [http://localhost:8080/system/console/status-slingscripting] the following
> should display:
> {code:java}
> Groovy Scripting Engine 2.0
> -
> - Language : Groovy, 2.4.14
> - Extensions : groovy
> - MIME Types : application/x-groovy
> - Names : groovy, Groovy{code}
>
> This works with Apache Sling 9, not with Sling 10
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7134) Script execution order is not deterministic on Java 9 and nashorn engine is missing in java8
[
https://issues.apache.org/jira/browse/SLING-7134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406304#comment-16406304
]
Bertrand Delacretaz commented on SLING-7134:
Note that IIUC the changes of this ticket caused the SLING-7545 issue, as the
script engine manager was not listening to bundle events anymore.
Hopefully fixing SLING-7545 doesn't cause trouble here - all tests pass after
that fix.
> Script execution order is not deterministic on Java 9 and nashorn engine is
> missing in java8
>
>
> Key: SLING-7134
> URL: https://issues.apache.org/jira/browse/SLING-7134
> Project: Sling
> Issue Type: Bug
> Components: Scripting, Servlets
>Reporter: Robert Munteanu
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Scripting Core 2.0.52, Servlets Resolver 2.4.20
>
> Attachments: scripting-engines-java-9.png
>
>
> When starting up the Sling launchpad with Java 9 and accessing
> http://localhost:8080/bin/browser.html I get an empty page and the following
> stack trace in the error log
> {noformat}18.09.2017 23:50:44.656 *ERROR* [127.0.0.1 [1505767840754] GET
> /bin/browser.html HTTP/1.1] org.apache.sling.engine.impl.SlingRequestProcesso
> rImpl service: Uncaught SlingException
> jdk.nashorn.internal.runtime.ECMAException: ReferenceError: "window" is not
> defined
> at
> jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ECMAErrors.error(ECMAErrors.java:57)
> at
> jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ECMAErrors.referenceError(ECMAErrors.java:319)
> at
> jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ECMAErrors.referenceError(ECMAErrors.java:291)
> at
> jdk.scripting.nashorn/jdk.nashorn.internal.objects.Global.__noSuchProperty__(Global.java:1615)
> at
> jdk.scripting.nashorn.scripts/jdk.nashorn.internal.scripts.Script$Recompilation$1$\^eval\_.:program(:5)
> at
> jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ScriptFunctionData.invoke(ScriptFunctionData.java:652)
> at
> jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:513)
> at
> jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:517)
> at
> jdk.scripting.nashorn/jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:420)
> at
> jdk.scripting.nashorn/jdk.nashorn.api.scripting.NashornScriptEngine.access$300(NashornScriptEngine.java:72)
> at
> jdk.scripting.nashorn/jdk.nashorn.api.scripting.NashornScriptEngine$3.eval(NashornScriptEngine.java:513)
> at
> org.apache.sling.scripting.core.impl.DefaultSlingScript.call(DefaultSlingScript.java:386)
> at
> org.apache.sling.scripting.core.impl.DefaultSlingScript.eval(DefaultSlingScript.java:184)
> at
> org.apache.sling.scripting.core.impl.DefaultSlingScript.service(DefaultSlingScript.java:491)
> at
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
> at
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
> at
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:77)
> at
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
> at
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.dispatchRequest(SlingRequestProcessorImpl.java:322)
> at
> org.apache.sling.engine.impl.request.SlingRequestDispatcher.dispatch(SlingRequestDispatcher.java:211)
> at
> org.apache.sling.engine.impl.request.SlingRequestDispatcher.include(SlingRequestDispatcher.java:104)
> at
> org.apache.sling.scripting.jsp.taglib.IncludeTagHandler.dispatch(IncludeTagHandler.java:54)
> at
> org.apache.sling.scripting.jsp.taglib.AbstractDispatcherTagHandler.doEndTag(AbstractDispatcherTagHandler.java:129)
> at
> org.apache.jsp.libs.composum.nodes.console.components.codeeditor.editdialog.editdialog_jsp._jspx_meth_sling_005finclude_005f0(edi
> tdialog_jsp.java:128)
> at
> org.apache.jsp.libs.composum.nodes.console.components.codeeditor.editdialog.editdialog_jsp._jspService(editdialog_jsp.java:99)
> at
> org.apache.sling.scripting.jsp.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:725)
> at
> org.apache.sling.scripting.jsp.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:502)
> at
> org.apache.sling.scripting.jsp.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:449)
> at
>
[jira] [Resolved] (SLING-7545) Groovy Scripting Engine not loading in Apache Sling 10
[
https://issues.apache.org/jira/browse/SLING-7545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz resolved SLING-7545.
Resolution: Fixed
Assignee: Bertrand Delacretaz
Thank you [~fortuna] for verfiying, marking this fixed.
Digging deeper it looks like this bug has been introduced by the following
commit for SLING-7134 - I'll add a comment there to verify that fixing this one
does not cause trouble there.
https://github.com/apache/sling-org-apache-sling-scripting-core/commit/2e15bd4f230d390ceadc9481627156bb3b6caaa3#diff-502d0f72184777e3bfd2f0e1dca75eff
> Groovy Scripting Engine not loading in Apache Sling 10
> --
>
> Key: SLING-7545
> URL: https://issues.apache.org/jira/browse/SLING-7545
> Project: Sling
> Issue Type: Bug
> Components: Scripting
>Affects Versions: Scripting Core 2.0.54
>Reporter: Ben Fortuna
>Assignee: Bertrand Delacretaz
>Priority: Major
> Fix For: Scripting Core 2.0.56
>
>
> With the latest release of Apache Sling (10) the Groovy Scripting engine is
> no longer loading.
> The impact is that scripts with a (*.groovy) extension aren't rendering.
> This works with Apache Sling 9, so I believe there was a change in the Apache
> Sling Scripting Core that broke the Groovy implementation.
>
> How to reproduce:
> Load groovy-all JAR into Apache Sling as a bundle, under the url
> [http://localhost:8080/system/console/status-slingscripting] the following
> should display:
> {code:java}
> Groovy Scripting Engine 2.0
> -
> - Language : Groovy, 2.4.14
> - Extensions : groovy
> - MIME Types : application/x-groovy
> - Names : groovy, Groovy{code}
>
> This works with Apache Sling 9, not with Sling 10
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SLING-7545) Groovy Scripting Engine not loading in Apache Sling 10
[
https://issues.apache.org/jira/browse/SLING-7545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz updated SLING-7545:
---
Fix Version/s: Scripting Core 2.0.56
> Groovy Scripting Engine not loading in Apache Sling 10
> --
>
> Key: SLING-7545
> URL: https://issues.apache.org/jira/browse/SLING-7545
> Project: Sling
> Issue Type: Bug
> Components: Scripting
>Affects Versions: Scripting Core 2.0.54
>Reporter: Ben Fortuna
>Priority: Major
> Fix For: Scripting Core 2.0.56
>
>
> With the latest release of Apache Sling (10) the Groovy Scripting engine is
> no longer loading.
> The impact is that scripts with a (*.groovy) extension aren't rendering.
> This works with Apache Sling 9, so I believe there was a change in the Apache
> Sling Scripting Core that broke the Groovy implementation.
>
> How to reproduce:
> Load groovy-all JAR into Apache Sling as a bundle, under the url
> [http://localhost:8080/system/console/status-slingscripting] the following
> should display:
> {code:java}
> Groovy Scripting Engine 2.0
> -
> - Language : Groovy, 2.4.14
> - Extensions : groovy
> - MIME Types : application/x-groovy
> - Names : groovy, Groovy{code}
>
> This works with Apache Sling 9, not with Sling 10
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7545) Groovy Scripting Engine not loading in Apache Sling 10
[
https://issues.apache.org/jira/browse/SLING-7545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16406192#comment-16406192
]
Bertrand Delacretaz commented on SLING-7545:
I think this commit fixes this:
https://github.com/apache/sling-org-apache-sling-scripting-core/commit/7f6145e79666c49844c49e9ce0d49d7954713a88
For some reason the {{SlingScriptEngineManager}} was not registered as a
{{BundleListener}} anymore but that's needed to correctly handle scripting
bundles like {{groovy-all.jar}}.
[~fortuna] could you try with this fix? You'll need to build the master branch
of https://github.com/apache/sling-org-apache-sling-scripting-core for that.
> Groovy Scripting Engine not loading in Apache Sling 10
> --
>
> Key: SLING-7545
> URL: https://issues.apache.org/jira/browse/SLING-7545
> Project: Sling
> Issue Type: Bug
> Components: Scripting
>Affects Versions: Scripting Core 2.0.54
>Reporter: Ben Fortuna
>Priority: Major
>
> With the latest release of Apache Sling (10) the Groovy Scripting engine is
> no longer loading.
> The impact is that scripts with a (*.groovy) extension aren't rendering.
> This works with Apache Sling 9, so I believe there was a change in the Apache
> Sling Scripting Core that broke the Groovy implementation.
>
> How to reproduce:
> Load groovy-all JAR into Apache Sling as a bundle, under the url
> [http://localhost:8080/system/console/status-slingscripting] the following
> should display:
> {code:java}
> Groovy Scripting Engine 2.0
> -
> - Language : Groovy, 2.4.14
> - Extensions : groovy
> - MIME Types : application/x-groovy
> - Names : groovy, Groovy{code}
>
> This works with Apache Sling 9, not with Sling 10
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-3987) Move from Subversion to Git
[ https://issues.apache.org/jira/browse/SLING-3987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400416#comment-16400416 ] Bertrand Delacretaz commented on SLING-3987: https://cwiki.apache.org/confluence/display/SLING/Move+from+Subversion+to+Git has instructions for moving modules that might not have been handled by the initial conversion, in the "Migrating a module" section. > Move from Subversion to Git > --- > > Key: SLING-3987 > URL: https://issues.apache.org/jira/browse/SLING-3987 > Project: Sling > Issue Type: Task > Components: Best practices >Reporter: Oliver Lietz >Assignee: Robert Munteanu >Priority: Major > > track work for moving to Git > [Wiki: Move from Subversion to > Git|https://cwiki.apache.org/confluence/display/SLING/Move+from+Subversion+to+Git] > [discussion > @dev|http://apache-sling.73963.n3.nabble.com/jira-Created-SLING-3987-move-from-Subversion-to-Git-td4040882.html#a4040901] > with [~cziegeler], [~bdelacretaz], [~fmeschbe], [~justinedelson], [~rombert] > and [~radu.cotescu] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7486) Remove tags of canceled releases from Subversion and Git repositories
[ https://issues.apache.org/jira/browse/SLING-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378494#comment-16378494 ] Bertrand Delacretaz commented on SLING-7486: Your examples are from Git repositories, do you need to be able to change Subversion data to fix them? > Remove tags of canceled releases from Subversion and Git repositories > - > > Key: SLING-7486 > URL: https://issues.apache.org/jira/browse/SLING-7486 > Project: Sling > Issue Type: Task > Components: Best practices, General >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > > ||Subversion Tag||POM Group ID||POM Artifact ID||POM Version||TODO|| > |org.apache.sling.bgservlets-1.0.0|org.apache.sling|org.apache.sling.bgservlets.reactor|0.0.1-SNAPSHOT| > remove | > |org.apache.sling.bgservlets-1.0.2|org.apache.sling|org.apache.sling.bgservlets.reactor|0.0.1-SNAPSHOT| > remove | > |org.apache.sling.commons.johnzon-1.0.2|org.apache.sling|org.apache.sling.commons.johnzon|1.0.2| > remove | > |org.apache.sling.commons.metrics-0.0.2|org.apache.sling|org.apache.sling.commons.metrics|0.0.2| > remove | > |org.apache.sling.crankstart.api.fragment-1.0.0|org.apache.sling|org.apache.sling.crankstart.api.fragment|1.0.0| > remove | > |org.apache.sling.discovery.base-2.0.2|org.apache.sling|org.apache.sling.discovery.base|2.0.2| > remove | > |org.apache.sling.discovery.commons-1.0.14|org.apache.sling|org.apache.sling.discovery.commons|1.0.14| > remove | > |org.apache.sling.discovery.commons-1.0.22|org.apache.sling|org.apache.sling.discovery.commons|1.0.22| > remove | > |org.apache.sling.discovery.oak-1.2.12|org.apache.sling|org.apache.sling.discovery.oak|1.2.12| > remove | > |org.apache.sling.event-3.3.8|org.apache.sling|org.apache.sling.event|3.3.8| > remove | > |org.apache.sling.fsresource-1.2.0|org.apache.sling|org.apache.sling.fsresource|1.2.0| > remove | > |org.apache.sling.hc.core-1.0.0|org.apache.sling|sling-builder|7-SNAPSHOT| > remove | > |org.apache.sling.hc.core-1.0.2|org.apache.sling|sling-builder|7-SNAPSHOT| > remove | > |org.apache.sling.i18n-2.3.0|org.apache.sling|org.apache.sling.i18n|2.3.0| > remove | > |org.apache.sling.i18n-2.4.0|org.apache.sling|org.apache.sling.i18n|2.4.0| > remove | > |org.apache.sling.installer.factory.configuration-1.0.6|org.apache.sling|org.apache.sling.installer.factory.configuration|1.0.6| > remove | > |org.apache.sling.jcr.base-2.0.8|org.apache.sling|org.apache.sling.jcr.base|2.0.8| > remove | > |org.apache.sling.jcr.oak.server-1.1.2|org.apache.sling|org.apache.sling.jcr.oak.server|1.1.2| > remove | > |org.apache.sling.jcr.resource-2.4.0|org.apache.sling|org.apache.sling.jcr.resource|2.4.0| > remove | > |org.apache.sling.junit.healthcheck-1.0.4|org.apache.sling|org.apache.sling.junit.remote|1.0.9-SNAPSHOT| > remove | > |org.apache.sling.launchpad.test-services-2.0.4-incubator|org.apache.sling|org.apache.sling.launchpad.test-services|2.0.4-incubator| > remove | > |org.apache.sling.launchpad.testing-6|org.apache.sling|org.apache.sling.launchpad.testing|6| > remove | > |org.apache.sling.launchpad.testing-war-6|org.apache.sling|org.apache.sling.launchpad.testing-war|6| > remove | > |org.apache.sling.performance.base-0.0.2|org.apache.sling|org.apache.sling.performance.base|0.0.2| > remove | > |org.apache.sling.resourcemerger-1.2.2|org.apache.sling|org.apache.sling.resourcemerger|1.2.2| > remove | > |org.apache.sling.resourceresolver-1.4.6|org.apache.sling|org.apache.sling.resourceresolver|1.4.6| > remove | > |org.apache.sling.scripting.core-2.0.12|org.apache.sling|org.apache.sling.scripting.core|2.0.12| > remove | > |org.apache.sling.scripting.java-2.0.8|org.apache.sling|org.apache.sling.scripting.java|2.0.8| > remove | > |org.apache.sling.scripting.jsp-2.1.2|org.apache.sling|org.apache.sling.scripting.jsp|2.1.2| > remove | > |org.apache.sling.scripting.jsp.taglib-2.1.4|org.apache.sling|org.apache.sling.scripting.jsp.taglib|2.1.4| > remove | > |org.apache.sling.scripting.velocity-2.0.0|org.apache.sling|org.apache.sling.scripting.velocity|2.0.0| > remove | > |org.apache.sling.testing.tools-1.0.4|org.apache.sling|org.apache.sling.testing.tools|1.0.4| > remove | > |org.apache.sling.validation.reactor-1.0.0|org.apache.sling|org.apache.sling.validation.reactor|1.0.0-SNAPSHOT| > remove | > |sling-6-source-release|org.apache.sling|sling-builder|6-SNAPSHOT| remove | > |sling-archetype-parent-2|org.apache.sling|sling-archetype-parent|2-SNAPSHOT| > remove | > |sling-archetype-parent-3|org.apache.sling|sling-archetype-parent|3| remove | > |sling-ide-tooling-1.0.10|org.apache.sling.ide|reactor|1.0.10| keep | > |sling-ide-tooling-1.0.2|org.apache.sling.ide|reactor|1.0.2| keep | > |sling-ide-tooling-1.0.4|org.apache.sling.ide|reactor|1.0.4|
[jira] [Commented] (SLING-7486) Remove tags of canceled releases from Subversion and Git repositories
[ https://issues.apache.org/jira/browse/SLING-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16378387#comment-16378387 ] Bertrand Delacretaz commented on SLING-7486: I do not support removing tags from the locked-down subversion Sling repository, I don't think it's really useful and as Greg says in INFRA-16104 it creates work for our infra team. I suggest just cleaning up Git. > Remove tags of canceled releases from Subversion and Git repositories > - > > Key: SLING-7486 > URL: https://issues.apache.org/jira/browse/SLING-7486 > Project: Sling > Issue Type: Task > Components: Best practices, General >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > > ||Subversion Tag||POM Group ID||POM Artifact ID||POM Version||TODO|| > |org.apache.sling.bgservlets-1.0.0|org.apache.sling|org.apache.sling.bgservlets.reactor|0.0.1-SNAPSHOT| > remove | > |org.apache.sling.bgservlets-1.0.2|org.apache.sling|org.apache.sling.bgservlets.reactor|0.0.1-SNAPSHOT| > remove | > |org.apache.sling.commons.johnzon-1.0.2|org.apache.sling|org.apache.sling.commons.johnzon|1.0.2| > remove | > |org.apache.sling.commons.metrics-0.0.2|org.apache.sling|org.apache.sling.commons.metrics|0.0.2| > remove | > |org.apache.sling.crankstart.api.fragment-1.0.0|org.apache.sling|org.apache.sling.crankstart.api.fragment|1.0.0| > remove | > |org.apache.sling.discovery.base-2.0.2|org.apache.sling|org.apache.sling.discovery.base|2.0.2| > remove | > |org.apache.sling.discovery.commons-1.0.14|org.apache.sling|org.apache.sling.discovery.commons|1.0.14| > remove | > |org.apache.sling.discovery.commons-1.0.22|org.apache.sling|org.apache.sling.discovery.commons|1.0.22| > remove | > |org.apache.sling.discovery.oak-1.2.12|org.apache.sling|org.apache.sling.discovery.oak|1.2.12| > remove | > |org.apache.sling.event-3.3.8|org.apache.sling|org.apache.sling.event|3.3.8| > remove | > |org.apache.sling.fsresource-1.2.0|org.apache.sling|org.apache.sling.fsresource|1.2.0| > remove | > |org.apache.sling.hc.core-1.0.0|org.apache.sling|sling-builder|7-SNAPSHOT| > remove | > |org.apache.sling.hc.core-1.0.2|org.apache.sling|sling-builder|7-SNAPSHOT| > remove | > |org.apache.sling.i18n-2.3.0|org.apache.sling|org.apache.sling.i18n|2.3.0| > remove | > |org.apache.sling.i18n-2.4.0|org.apache.sling|org.apache.sling.i18n|2.4.0| > remove | > |org.apache.sling.installer.factory.configuration-1.0.6|org.apache.sling|org.apache.sling.installer.factory.configuration|1.0.6| > remove | > |org.apache.sling.jcr.base-2.0.8|org.apache.sling|org.apache.sling.jcr.base|2.0.8| > remove | > |org.apache.sling.jcr.oak.server-1.1.2|org.apache.sling|org.apache.sling.jcr.oak.server|1.1.2| > remove | > |org.apache.sling.jcr.resource-2.4.0|org.apache.sling|org.apache.sling.jcr.resource|2.4.0| > remove | > |org.apache.sling.junit.healthcheck-1.0.4|org.apache.sling|org.apache.sling.junit.remote|1.0.9-SNAPSHOT| > remove | > |org.apache.sling.launchpad.test-services-2.0.4-incubator|org.apache.sling|org.apache.sling.launchpad.test-services|2.0.4-incubator| > remove | > |org.apache.sling.launchpad.testing-6|org.apache.sling|org.apache.sling.launchpad.testing|6| > remove | > |org.apache.sling.launchpad.testing-war-6|org.apache.sling|org.apache.sling.launchpad.testing-war|6| > remove | > |org.apache.sling.performance.base-0.0.2|org.apache.sling|org.apache.sling.performance.base|0.0.2| > remove | > |org.apache.sling.resourcemerger-1.2.2|org.apache.sling|org.apache.sling.resourcemerger|1.2.2| > remove | > |org.apache.sling.resourceresolver-1.4.6|org.apache.sling|org.apache.sling.resourceresolver|1.4.6| > remove | > |org.apache.sling.scripting.core-2.0.12|org.apache.sling|org.apache.sling.scripting.core|2.0.12| > remove | > |org.apache.sling.scripting.java-2.0.8|org.apache.sling|org.apache.sling.scripting.java|2.0.8| > remove | > |org.apache.sling.scripting.jsp-2.1.2|org.apache.sling|org.apache.sling.scripting.jsp|2.1.2| > remove | > |org.apache.sling.scripting.jsp.taglib-2.1.4|org.apache.sling|org.apache.sling.scripting.jsp.taglib|2.1.4| > remove | > |org.apache.sling.scripting.velocity-2.0.0|org.apache.sling|org.apache.sling.scripting.velocity|2.0.0| > remove | > |org.apache.sling.testing.tools-1.0.4|org.apache.sling|org.apache.sling.testing.tools|1.0.4| > remove | > |org.apache.sling.validation.reactor-1.0.0|org.apache.sling|org.apache.sling.validation.reactor|1.0.0-SNAPSHOT| > remove | > |sling-6-source-release|org.apache.sling|sling-builder|6-SNAPSHOT| remove | > |sling-archetype-parent-2|org.apache.sling|sling-archetype-parent|2-SNAPSHOT| > remove | > |sling-archetype-parent-3|org.apache.sling|sling-archetype-parent|3| remove | > |sling-ide-tooling-1.0.10|org.apache.sling.ide|reactor|1.0.10| keep | >
[jira] [Commented] (SLING-7509) Add QueryClient
[
https://issues.apache.org/jira/browse/SLING-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372784#comment-16372784
]
Bertrand Delacretaz commented on SLING-7509:
The {{JsonQueryServlet}} is in the attic at
https://svn.apache.org/repos/asf/sling/attic/bundles-servlets-compat/
See https://issues.apache.org/jira/browse/SLING-2226 for why it was deprecated.
> Add QueryClient
> ---
>
> Key: SLING-7509
> URL: https://issues.apache.org/jira/browse/SLING-7509
> Project: Sling
> Issue Type: New Feature
> Components: Apache Sling Testing Clients
>Reporter: Valentin Olteanu
>Priority: Major
>
> Currently, there is no way to run queries in sling using the clients. This is
> needed in several tests to search content and assert the effects of a feature.
>
> The solution proposed in
> [https://github.com/apache/sling-org-apache-sling-testing-clients/pull/5]
> * installs a custom query servlet
> * runs the query in any of the supported format
> * returns results as json
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7465) Clarify licensing of fonts added to launchpad-content
[ https://issues.apache.org/jira/browse/SLING-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365499#comment-16365499 ] Bertrand Delacretaz commented on SLING-7465: Thank you [~klcodanr] ! I don't think Open Sans requires a NOTICE, so I have removed it, NOTICE must be kept minimal. And tweaked LICENSE a bit, I think we're all good now. ( https://github.com/apache/sling-org-apache-sling-starter-content/commit/f8e51f7906dcf602189dc017dc5e54f9c687b8dd ) > Clarify licensing of fonts added to launchpad-content > - > > Key: SLING-7465 > URL: https://issues.apache.org/jira/browse/SLING-7465 > Project: Sling > Issue Type: Task > Components: Launchpad >Reporter: Bertrand Delacretaz >Assignee: Dan Klco >Priority: Minor > Fix For: Launchpad Content 2.0.14 > > > Hi Dan, assigning this to you as it's related to your changes in SLING-7379 > (cool stuff BTW!) > Those changes have added fonts under > [https://github.com/apache/sling-org-apache-sling-launchpad-content/tree/master/src/main/frontend/src/fonts] > Do you have licensing information for those fonts? Do we need to add a > LICENSE to that module for them? > If that's needed I think we just need to add a license (and notice if needed) > under appended-resources like in > https://github.com/apache/sling-org-apache-sling-commons-log/tree/master/src/main/appended-resources/META-INF -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-7480) Fix the feature model examples wrt to Start Order
[ https://issues.apache.org/jira/browse/SLING-7480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-7480. Resolution: Fixed Assignee: Bertrand Delacretaz I have merged your pull request, thank you for your contribution! > Fix the feature model examples wrt to Start Order > - > > Key: SLING-7480 > URL: https://issues.apache.org/jira/browse/SLING-7480 > Project: Sling > Issue Type: Improvement >Reporter: David Bosschaert >Assignee: Bertrand Delacretaz >Priority: Major > > The examples in > [https://github.com/apache/sling-whiteboard/tree/master/featuremodel/example] > use the old 'start level' syntax and need to be reworked to use startOrder > metadata in the JSON. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7474) Please use HTTPS for sigs and hashes
[ https://issues.apache.org/jira/browse/SLING-7474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355334#comment-16355334 ] Bertrand Delacretaz commented on SLING-7474: Thanks, I fixed the copyright dates as well. It's the kind of thing that you don't notice anymore after some time ;) > Please use HTTPS for sigs and hashes > > > Key: SLING-7474 > URL: https://issues.apache.org/jira/browse/SLING-7474 > Project: Sling > Issue Type: Bug > Components: Site >Reporter: Sebb >Assignee: Bertrand Delacretaz >Priority: Major > > Please use HTTPS for links to hashes and sigs on the download page. > Also, the KEYS file must be linked from https://www.apache.org/dist/sling/KEYS > and NOT > https://people.apache.org/keys/group/sling.asc > which is unsuitable for the reasons noted here: > https://people.apache.org/keys/ > Thanks -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-7474) Please use HTTPS for sigs and hashes
[ https://issues.apache.org/jira/browse/SLING-7474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-7474. Resolution: Fixed Assignee: Bertrand Delacretaz Thanks Sebb, good points! I have made the https and KEYS changes at [http://sling.apache.org/downloads.cgi] and created SLING-7477 for explaining the verification. > Please use HTTPS for sigs and hashes > > > Key: SLING-7474 > URL: https://issues.apache.org/jira/browse/SLING-7474 > Project: Sling > Issue Type: Bug > Components: Site >Reporter: Sebb >Assignee: Bertrand Delacretaz >Priority: Major > > Please use HTTPS for links to hashes and sigs on the download page. > Also, the KEYS file must be linked from https://www.apache.org/dist/sling/KEYS > and NOT > https://people.apache.org/keys/group/sling.asc > which is unsuitable for the reasons noted here: > https://people.apache.org/keys/ > Thanks -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7474) Please use HTTPS for sigs and hashes
[ https://issues.apache.org/jira/browse/SLING-7474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-7474: --- Component/s: Site > Please use HTTPS for sigs and hashes > > > Key: SLING-7474 > URL: https://issues.apache.org/jira/browse/SLING-7474 > Project: Sling > Issue Type: Bug > Components: Site >Reporter: Sebb >Assignee: Bertrand Delacretaz >Priority: Major > > Please use HTTPS for links to hashes and sigs on the download page. > Also, the KEYS file must be linked from https://www.apache.org/dist/sling/KEYS > and NOT > https://people.apache.org/keys/group/sling.asc > which is unsuitable for the reasons noted here: > https://people.apache.org/keys/ > Thanks -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-7477) Downloads page should explain how to verify releases
Bertrand Delacretaz created SLING-7477: -- Summary: Downloads page should explain how to verify releases Key: SLING-7477 URL: https://issues.apache.org/jira/browse/SLING-7477 Project: Sling Issue Type: Task Components: Site Reporter: Bertrand Delacretaz As suggested by Sebb at SLING-7474 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7473) "Edit on GitHub" button for the website
[
https://issues.apache.org/jira/browse/SLING-7473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz updated SLING-7473:
---
Description:
Not sure when I'll find time to work on this but it's a cool feature for the
website - so if someone else wants to beat me to it please do!
On the ASF builds mailing list, the Struts team has mentioned their "Edit on
GitHub" button, like at the top of [http://struts.apache.org/getting-started/]
In our case we need a link like
[https://github.com/apache/sling-site/edit/master/src/main/jbake/content/index.md]
with the path after {{/content}} computed from the actual content path.
The cool thing is that GitHub either edits the page directly, if the logged in
user is allowed to do that, or suggest forking if not.
was:
Not sure when I'll find time to work on this but it's a cool feature for the
website - so if someone else wants to beat me to it please do!
On the asf-infra mailing list, the Struts team has mentioned their "Edit on
GitHub" button, like at the top of http://struts.apache.org/getting-started/
In our case we need a link like
[https://github.com/apache/sling-site/edit/master/src/main/jbake/content/index.md]
with the path after {{/content}} computed from the actual content path.
The cool thing is that GitHub either edits the page directly, if the logged in
user is allowed to do that, or suggest forking if not.
> "Edit on GitHub" button for the website
> ---
>
> Key: SLING-7473
> URL: https://issues.apache.org/jira/browse/SLING-7473
> Project: Sling
> Issue Type: Task
> Components: Site
>Reporter: Bertrand Delacretaz
>Priority: Minor
>
> Not sure when I'll find time to work on this but it's a cool feature for the
> website - so if someone else wants to beat me to it please do!
> On the ASF builds mailing list, the Struts team has mentioned their "Edit on
> GitHub" button, like at the top of [http://struts.apache.org/getting-started/]
> In our case we need a link like
> [https://github.com/apache/sling-site/edit/master/src/main/jbake/content/index.md]
> with the path after {{/content}} computed from the actual content path.
> The cool thing is that GitHub either edits the page directly, if the logged
> in user is allowed to do that, or suggest forking if not.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (SLING-7473) "Edit on GitHub" button for the website
Bertrand Delacretaz created SLING-7473:
--
Summary: "Edit on GitHub" button for the website
Key: SLING-7473
URL: https://issues.apache.org/jira/browse/SLING-7473
Project: Sling
Issue Type: Task
Components: Site
Reporter: Bertrand Delacretaz
Not sure when I'll find time to work on this but it's a cool feature for the
website - so if someone else wants to beat me to it please do!
On the asf-infra mailing list, the Struts team has mentioned their "Edit on
GitHub" button, like at the top of http://struts.apache.org/getting-started/
In our case we need a link like
[https://github.com/apache/sling-site/edit/master/src/main/jbake/content/index.md]
with the path after {{/content}} computed from the actual content path.
The cool thing is that GitHub either edits the page directly, if the logged in
user is allowed to do that, or suggest forking if not.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7471) Pricing information for subscription is incorrect. Shows $infinity / month.
[ https://issues.apache.org/jira/browse/SLING-7471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351908#comment-16351908 ] Bertrand Delacretaz commented on SLING-7471: This doesn't look like an Apache Sling issue. > Pricing information for subscription is incorrect. Shows $infinity / month. > --- > > Key: SLING-7471 > URL: https://issues.apache.org/jira/browse/SLING-7471 > Project: Sling > Issue Type: Bug > Environment: Mac OS EL Capitan. Chrome v 63.0.3239.132. >Reporter: Vivek Gokuladas >Priority: Major > Attachments: Screen Shot 2018-02-04 at 2.24.10 PM.png, Screen Shot > 2018-02-04 at 2.29.16 PM.png > > > Pricing information is incorrect. Please check screenshot -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-7465) Clarify licensing of fonts added to launchpad-content
Bertrand Delacretaz created SLING-7465: -- Summary: Clarify licensing of fonts added to launchpad-content Key: SLING-7465 URL: https://issues.apache.org/jira/browse/SLING-7465 Project: Sling Issue Type: Task Components: Launchpad Reporter: Bertrand Delacretaz Assignee: Dan Klco Fix For: Launchpad Content 2.0.14 Hi Dan, assigning this to you as it's related to your changes in SLING-7379 (cool stuff BTW!) Those changes have added fonts under [https://github.com/apache/sling-org-apache-sling-launchpad-content/tree/master/src/main/frontend/src/fonts] Do you have licensing information for those fonts? Do we need to add a LICENSE to that module for them? If that's needed I think we just need to add a license (and notice if needed) under appended-resources like in https://github.com/apache/sling-org-apache-sling-commons-log/tree/master/src/main/appended-resources/META-INF -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7454) Move repoinit integration tests to the JCR repoinit module
[
https://issues.apache.org/jira/browse/SLING-7454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346575#comment-16346575
]
Bertrand Delacretaz commented on SLING-7454:
Thank you [~karlpauls], looks good to me! {{usePomDependencies}} is what I was
missing, I see it now in the
[https://sling.apache.org/components/slingstart-maven-plugin/prepare-package-mojo.html]
docs.
+1 for merging and releasing.
> Move repoinit integration tests to the JCR repoinit module
> --
>
> Key: SLING-7454
> URL: https://issues.apache.org/jira/browse/SLING-7454
> Project: Sling
> Issue Type: Task
> Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.6
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: Repoinit JCR 1.1.8
>
>
> Currently those tests are at
> [https://github.com/apache/sling-org-apache-sling-repoinit-it] and they are
> failing.
> It makes more sense anyway to move them to the jcr-repoinit module which has
> similar dependencies, and in that way they are executed at the right time,
> before releasing that module.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (SLING-7262) Generate reusable lists of Git repositories for machine consumption
[
https://issues.apache.org/jira/browse/SLING-7262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346554#comment-16346554
]
Bertrand Delacretaz edited comment on SLING-7262 at 1/31/18 10:26 AM:
--
Trying to summarize the various initiatives going on, as well as our
requirements, please correct/complete as needed.
*Inputs*
* Either the GitHub API to list all Sling repositories as currently used at
[https://github.com/apache/sling-aggregator]
* Or the Gitbox OPML at [https://gitbox.apache.org/repos/asf?a=opml] as
currently used by [https://github.com/oliverlietz/apache-sling-aggregator]
*Desired Outputs*
* 1) A manifest for the Google Repo tool, which requires just the repository
names and their paths.
* 2) Our Jenkins jobs, currently generated manually by running scripts from
https://github.com/apache/sling-tooling-jenkins
* 3) A list suitable for updating [http://sling.apache.org/repolist.html] (or
a similar canonical Web page)
* 4) A Maven reactor pom that allows for building everything or sets of
modules, probably based on Maven profiles
For 1) I haven't checked if the Repo manifest format officially allows us to
add extra information, currently we have an additional "groups" attribute, if
that's supported we might add "tags", "badges" and "descriptions" as needed.
For 3) the repositories need to be grouped by functional areas (already
partially done) and should also have tags or badges for contrib/core/legacy and
similar classifications. It would be nice to have a brief description of each
repository as well in that list, maybe the first few lines of their README
(excluding "belongs to Apache Sling" of course)
*Environment*
The generation of these files needs to run as a Jenkins build so that they can
be regenerated automatically.
Commiting the output of Jenkins jobs to Git is easy if the target is the
{{asf-site}} branch, for that we just need to tie the jobs to nodes having the
{{git-websites}} label. Committing the output to the {{asf-site}} branch of the
[https://github.com/apache/sling-site] repository seems to be a good solution
to me and other scripts can pick it up there at a stable URL, even if the raw
result is not visible on the website.
*Here's what we currently have "in production"*
* [https://github.com/apache/sling-aggregator] generates a Repo manifest,
needs to be updated manually by running a script and pushing the result when
new Git repos are created
* [http://sling.apache.org/repolist.html] is generated from that Repo
manifest. It's missing tags/badges and descriptions
* Our Jenkins jobs are generated from
[https://github.com/apache/sling-tooling-jenkins] and optionally use
information from a {{.sling-module.xml}} file described at
[https://cwiki.apache.org/confluence/display/SLING/Sling+module+descriptor]
* I don't think we have an official Maven aggregator pom at this point
* [~olli] has been working on
[https://github.com/oliverlietz/apache-sling-aggregator] with useful things in
various branches of that repository, which generate a Repo manifest, a Maven
pom and a GitHub page.
See
[https://github.com/apache/sling-org-apache-sling-launchpad-contrib-testing]
for an example of a sling:contrib badge that can easily be parsed from the
README and is displayed there, as opposed to {{.sling-module.xml}} which has no
impact on the README page on GitHub:
{code:java}
curl -s
https://raw.githubusercontent.com/apache/sling-org-apache-sling-launchpad-contrib-testing/master/README.md
| grep sling:badge
{code}
We should consolidate all that and ideally generate all the outputs from a
single master list that's automatically updated at regular intervals.
was (Author: bdelacretaz):
Trying to summarize the various initiatives going on, as well as our
requirements, please correct/complete as needed.
*Inputs*
* Either the GitHub API to list all Sling repositories as currently used at
https://github.com/apache/sling-aggregator
* Or the Gitbox OPML at https://gitbox.apache.org/repos/asf?a=opml as currently
used by https://github.com/oliverlietz/apache-sling-aggregator
*Desired Outputs*
* 1) A manifest for the Google Repo tool, which requires just the repository
names and their paths.
* 2) A list suitable for updating http://sling.apache.org/repolist.html (or a
similar canonical Web page)
* 3) A Maven reactor pom that allows for building everything or sets of
modules, probably based on Maven profiles
For 1) I haven't checked if the Repo manifest format officially allows us to
add extra information, currently we have an additional "groups" attribute, if
that's supported we might add "tags", "badges" and "descriptions" as needed.
For 2) the repositories need to be grouped by functional areas (already
partially done) and should also have tags or badges for
[jira] [Commented] (SLING-7262) Generate reusable lists of Git repositories for machine consumption
[
https://issues.apache.org/jira/browse/SLING-7262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346554#comment-16346554
]
Bertrand Delacretaz commented on SLING-7262:
Trying to summarize the various initiatives going on, as well as our
requirements, please correct/complete as needed.
*Inputs*
* Either the GitHub API to list all Sling repositories as currently used at
https://github.com/apache/sling-aggregator
* Or the Gitbox OPML at https://gitbox.apache.org/repos/asf?a=opml as currently
used by https://github.com/oliverlietz/apache-sling-aggregator
*Desired Outputs*
* 1) A manifest for the Google Repo tool, which requires just the repository
names and their paths.
* 2) A list suitable for updating http://sling.apache.org/repolist.html (or a
similar canonical Web page)
* 3) A Maven reactor pom that allows for building everything or sets of
modules, probably based on Maven profiles
For 1) I haven't checked if the Repo manifest format officially allows us to
add extra information, currently we have an additional "groups" attribute, if
that's supported we might add "tags", "badges" and "descriptions" as needed.
For 2) the repositories need to be grouped by functional areas (already
partially done) and should also have tags or badges for contrib/core/legacy and
similar classifications. It would be nice to have a brief description of each
repository as well in that list, maybe the first few lines of their README
(excluding "belongs to Apache Sling" of course)
*Environment*
The generation of these files needs to run as a Jenkins build so that they can
be regenerated automatically.
Commiting the output of Jenkins jobs to Git is easy if the target is the
{{asf-site}} branch, for that we just need to tie the jobs to nodes having the
{{git-websites}} label. Committing the output to the {{asf-site}} branch of the
https://github.com/apache/sling-site repository seems to be a good solution to
me and other scripts can pick it up there at a stable URL, even if the raw
result is not visible on the website.
*Here's what we currently have "in production"*
* https://github.com/apache/sling-aggregator generates a Repo manifest, needs
to be updated manually by running a script and pushing the result when new Git
repos are created
* http://sling.apache.org/repolist.html is generated from that Repo manifest.
It's missing tags/badges and descriptions
* Our Jenkins jobs are generated from
https://github.com/apache/sling-tooling-jenkins and optionally use information
from a {{.sling-module.xml}} file described at
https://cwiki.apache.org/confluence/display/SLING/Sling+module+descriptor
* I don't think we have an official Maven aggregator pom at this point
* [~olli] has been working on
https://github.com/oliverlietz/apache-sling-aggregator with useful things in
various branches of that repository, which generate a Repo manifest, a Maven
pom and a GitHub page.
See https://github.com/apache/sling-org-apache-sling-launchpad-contrib-testing
for an example of a sling:contrib badge that can easily be parsed from the
README and is displayed there, as opposed to {{.sling-module.xml}} which has no
impact on the README page on GitHub:
{code}
curl -s
https://raw.githubusercontent.com/apache/sling-org-apache-sling-launchpad-contrib-testing/master/README.md
| grep sling:badge
{code}
We should consolidate all that and ideally generate all the outputs from a
single master list that's automatically updated at regular intervals.
> Generate reusable lists of Git repositories for machine consumption
> ---
>
> Key: SLING-7262
> URL: https://issues.apache.org/jira/browse/SLING-7262
> Project: Sling
> Issue Type: Task
> Components: Build and Source Control
>Reporter: Robert Munteanu
>Priority: Major
>
> We currently have two 'clients' that query the github repos and the
> .sling-module.xml descriptors:
> * the jenkins job creation DSL script
> * the repo manifest creation script
> We've also discussed in SLING-7161 the possibility of listing all
> repositories on the website.
> To minimize the effort of talking to github in each location and reduce the
> number of calls to Github ( for rate limiting purposes ) we should generate a
> JSON/XML file that contains all information about the git repos. This file is
> in turns read by various "clients" that need the information.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SLING-7262) Generate reusable lists of Git repositories for machine consumption
[ https://issues.apache.org/jira/browse/SLING-7262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-7262: --- Summary: Generate reusable lists of Git repositories for machine consumption (was: Generate reusable list of repositories for machine consumption) > Generate reusable lists of Git repositories for machine consumption > --- > > Key: SLING-7262 > URL: https://issues.apache.org/jira/browse/SLING-7262 > Project: Sling > Issue Type: Task > Components: Build and Source Control >Reporter: Robert Munteanu >Priority: Major > > We currently have two 'clients' that query the github repos and the > .sling-module.xml descriptors: > * the jenkins job creation DSL script > * the repo manifest creation script > We've also discussed in SLING-7161 the possibility of listing all > repositories on the website. > To minimize the effort of talking to github in each location and reduce the > number of calls to Github ( for rate limiting purposes ) we should generate a > JSON/XML file that contains all information about the git repos. This file is > in turns read by various "clients" that need the information. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7454) Move repoinit integration tests to the JCR repoinit module
[ https://issues.apache.org/jira/browse/SLING-7454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344982#comment-16344982 ] Bertrand Delacretaz commented on SLING-7454: I have also emptied the [https://github.com/apache/sling-org-apache-sling-repoinit-it] module to avoid confusion and added a .sling-module.xml file to disable its Jenkins build. > Move repoinit integration tests to the JCR repoinit module > -- > > Key: SLING-7454 > URL: https://issues.apache.org/jira/browse/SLING-7454 > Project: Sling > Issue Type: Task > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.6 >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz >Priority: Minor > Fix For: Repoinit JCR 1.1.8 > > > Currently those tests are at > [https://github.com/apache/sling-org-apache-sling-repoinit-it] and they are > failing. > It makes more sense anyway to move them to the jcr-repoinit module which has > similar dependencies, and in that way they are executed at the right time, > before releasing that module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7454) Move repoinit integration tests to the JCR repoinit module
[ https://issues.apache.org/jira/browse/SLING-7454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344972#comment-16344972 ] Bertrand Delacretaz commented on SLING-7454: I have moved the ITs in commit [https://github.com/apache/sling-org-apache-sling-jcr-repoinit/commit/6ebeeccd7f69cbc741ae71fe46f207cb3af32f36] - they pass but they are not using the latest repoinit bundles snapshots so far, so I had to disable one of them, add TODOs in the code. > Move repoinit integration tests to the JCR repoinit module > -- > > Key: SLING-7454 > URL: https://issues.apache.org/jira/browse/SLING-7454 > Project: Sling > Issue Type: Task > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.6 >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz >Priority: Minor > Fix For: Repoinit JCR 1.1.8 > > > Currently those tests are at > [https://github.com/apache/sling-org-apache-sling-repoinit-it] and they are > failing. > It makes more sense anyway to move them to the jcr-repoinit module which has > similar dependencies, and in that way they are executed at the right time, > before releasing that module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-7454) Move repoinit integration tests to the JCR repoinit module
Bertrand Delacretaz created SLING-7454: -- Summary: Move repoinit integration tests to the JCR repoinit module Key: SLING-7454 URL: https://issues.apache.org/jira/browse/SLING-7454 Project: Sling Issue Type: Task Components: Repoinit Affects Versions: Repoinit JCR 1.1.6 Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Fix For: Repoinit JCR 1.1.8 Currently those tests are at [https://github.com/apache/sling-org-apache-sling-repoinit-it] and they are failing. It makes more sense anyway to move them to the jcr-repoinit module which has similar dependencies, and in that way they are executed at the right time, before releasing that module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7148) Do not fail when disabling or deleting a non existing service user
[ https://issues.apache.org/jira/browse/SLING-7148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344843#comment-16344843 ] Bertrand Delacretaz commented on SLING-7148: Thanks Karl, your changes look good, I'd just add a DEBUG log when ignoring instructions due to non-existing user or service user. > Do not fail when disabling or deleting a non existing service user > -- > > Key: SLING-7148 > URL: https://issues.apache.org/jira/browse/SLING-7148 > Project: Sling > Issue Type: Improvement > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.6 >Reporter: Timothee Maret >Assignee: Karl Pauls >Priority: Major > Fix For: Repoinit JCR 1.1.8 > > > SLING-6984 allows to disable service user. The existing implementation does > throw an exception if the service user to be disabled does not exist. This > prevent to remove the service user for new setups. > This issue is about allowing to disable a non existing user, by simply > logging a warning message rather than throwing an exception. > cc [~bdelacretaz] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7262) Generate reusable list of repositories for machine consumption
[ https://issues.apache.org/jira/browse/SLING-7262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343313#comment-16343313 ] Bertrand Delacretaz commented on SLING-7262: I have now linked this ticket with the similar SLING-7331, and created [http://sling.apache.org/repolist.html] last week based on the list generated by [https://github.com/apache/sling-aggregator] . We'll need to consolidate those efforts at some point! > Generate reusable list of repositories for machine consumption > -- > > Key: SLING-7262 > URL: https://issues.apache.org/jira/browse/SLING-7262 > Project: Sling > Issue Type: Task > Components: Build and Source Control >Reporter: Robert Munteanu >Priority: Major > > We currently have two 'clients' that query the github repos and the > .sling-module.xml descriptors: > * the jenkins job creation DSL script > * the repo manifest creation script > We've also discussed in SLING-7161 the possibility of listing all > repositories on the website. > To minimize the effort of talking to github in each location and reduce the > number of calls to Github ( for rate limiting purposes ) we should generate a > JSON/XML file that contains all information about the git repos. This file is > in turns read by various "clients" that need the information. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7331) Set up Maven aggregator project for all regular modules
[
https://issues.apache.org/jira/browse/SLING-7331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343311#comment-16343311
]
Bertrand Delacretaz commented on SLING-7331:
Ok, I think it's good at some point to merge the various initiatives around
building lists of all Sling Git repos - probably worth a discussion on our dev
list when the time comes.
For now I have linked this ticket and SLING-7262 as being related.
> Set up Maven aggregator project for all regular modules
> ---
>
> Key: SLING-7331
> URL: https://issues.apache.org/jira/browse/SLING-7331
> Project: Sling
> Issue Type: Task
> Components: General, Tooling
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>
> Goals:
> * open all regular modules with a single POM in IDEs
> ** groups: core, scripting, models, karaf, commons, distribution,
> discovery, ...
> * _full_ build
>
> https://github.com/oliverlietz/apache-sling-aggregator
> {noformat}
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache Sling Adapter Annotations ... SUCCESS [ 12.689
> s]
> [INFO] Apache Sling JAR Resource Bundle ... SUCCESS [ 0.535
> s]
> [INFO] Apache Sling HTL Maven Plugin .. SUCCESS [ 15.121
> s]
> [INFO] Apache Sling Maven JSP Compiler Plugin . SUCCESS [ 5.573
> s]
> [INFO] Apache Sling Launchpad Comparator .. SUCCESS [ 10.489
> s]
> [INFO] Apache Sling Maven JCROCM Plugin ... SUCCESS [ 1.183
> s]
> [INFO] Apache Sling Maven Launchpad Plugin SUCCESS [ 14.740
> s]
> [INFO] Apache Sling Maven Sling Plugin SUCCESS [ 7.567
> s]
> [INFO] Apache Sling Adapter Manager Implementation SUCCESS [ 5.527
> s]
> [INFO] Apache Sling API ... SUCCESS [ 11.931
> s]
> [INFO] Apache Sling Authentication Service SUCCESS [ 4.236
> s]
> [INFO] Apache Sling Form Based Authentication Handler . SUCCESS [ 18.973
> s]
> [INFO] Apache Sling Authentication XING API ... SUCCESS [ 2.086
> s]
> [INFO] Apache Sling Authentication XING Login . SUCCESS [ 6.348
> s]
> [INFO] Apache Sling Authentication XING OAuth . SUCCESS [ 2.301
> s]
> [INFO] Apache Sling Models bnd Plugin . SUCCESS [ 2.557
> s]
> [INFO] Apache Sling Bundle Resource Provider .. SUCCESS [ 2.935
> s]
> [INFO] Apache Sling Context-Aware Configuration API ... SUCCESS [ 1.440
> s]
> [INFO] Apache Sling Context-Aware Configuration bnd Plugin SUCCESS [ 1.131
> s]
> [INFO] Apache Sling Context-Aware Configuration Implementation SUCCESS [
> 14.570 s]
> [INFO] Apache Sling Context-Aware Configuration SPI ... SUCCESS [ 2.591
> s]
> [INFO] Apache Sling Validation Framework Core Implementation SUCCESS [01:54
> min]
> [INFO] Apache Sling Sample Slingshot .. SUCCESS [ 10.975
> s]
> [INFO] Apache Sling Context-Aware Configuration Integration Tests SUCCESS [
> 48.131 s]
> [INFO] Apache Sling Cassandra Resource Provider ... FAILURE [01:20
> min]
> [INFO] Apache Sling Commons Cache API . SUCCESS [ 8.379
> s]
> [INFO] Apache Sling OSGi PAX Exam support library . SUCCESS [ 10.545
> s]
> [INFO] Apache Sling Cache API Implementation support library SUCCESS [ 0.336
> s]
> [INFO] Apache Sling Cache API EhCache implementation .. FAILURE [ 52.695
> s]
> [INFO] Apache Sling Cache Portal Cache FAILURE [ 1.036
> s]
> [INFO] Apache Sling Dynamic Class Loader Support .. SUCCESS [ 10.888
> s]
> [INFO] Apache Sling Commons Java Compiler . SUCCESS [ 4.175
> s]
> [INFO] Apache Sling Content Detection Support . SUCCESS [ 20.521
> s]
> [INFO] Apache Sling Commons FileSystem ClassLoader SUCCESS [ 2.955
> s]
> [INFO] Apache Sling Commons HTML Utilities SUCCESS [ 1.610
> s]
> [INFO] Apache Sling Commons Johnzon Wrapper Library ... SUCCESS [ 2.192
> s]
> [INFO] Apache Sling Commons Log ... SUCCESS [ 40.843
> s]
> [INFO] Apache Sling Log WebConsole SUCCESS [ 16.236
> s]
> [INFO] Apache Sling OSGi LogService Implementation SUCCESS [ 1.673
> s]
> [INFO] Apache Sling Commons Messaging . SUCCESS [ 1.422
> s]
> [INFO] Apache Sling Commons Messaging Mail SUCCESS [ 21.980
> s]
> [INFO] Apache Sling Metrics ... SUCCESS [ 18.032
> s]
> [INFO] Apache Sling RRD4J metrics reporter SUCCESS [ 6.611
> s]
> [INFO] Apache Sling Commons MIME type
[jira] [Commented] (SLING-7331) Set up Maven aggregator project for all regular modules
[
https://issues.apache.org/jira/browse/SLING-7331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341299#comment-16341299
]
Bertrand Delacretaz commented on SLING-7331:
I haven't checked how you generate the list of modules - note that we have an
autogenerated one at https://github.com/apache/sling-aggregator, which I'm now
using the generate the new http://sling.apache.org/repolist.html page
> Set up Maven aggregator project for all regular modules
> ---
>
> Key: SLING-7331
> URL: https://issues.apache.org/jira/browse/SLING-7331
> Project: Sling
> Issue Type: Task
> Components: General, Tooling
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>
> Goals:
> * open all regular modules with a single POM in IDEs
> ** groups: core, scripting, models, karaf, commons, distribution,
> discovery, ...
> * _full_ build
>
> https://github.com/oliverlietz/apache-sling-aggregator
> {noformat}
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache Sling Adapter Annotations ... SUCCESS [ 12.689
> s]
> [INFO] Apache Sling JAR Resource Bundle ... SUCCESS [ 0.535
> s]
> [INFO] Apache Sling HTL Maven Plugin .. SUCCESS [ 15.121
> s]
> [INFO] Apache Sling Maven JSP Compiler Plugin . SUCCESS [ 5.573
> s]
> [INFO] Apache Sling Launchpad Comparator .. SUCCESS [ 10.489
> s]
> [INFO] Apache Sling Maven JCROCM Plugin ... SUCCESS [ 1.183
> s]
> [INFO] Apache Sling Maven Launchpad Plugin SUCCESS [ 14.740
> s]
> [INFO] Apache Sling Maven Sling Plugin SUCCESS [ 7.567
> s]
> [INFO] Apache Sling Adapter Manager Implementation SUCCESS [ 5.527
> s]
> [INFO] Apache Sling API ... SUCCESS [ 11.931
> s]
> [INFO] Apache Sling Authentication Service SUCCESS [ 4.236
> s]
> [INFO] Apache Sling Form Based Authentication Handler . SUCCESS [ 18.973
> s]
> [INFO] Apache Sling Authentication XING API ... SUCCESS [ 2.086
> s]
> [INFO] Apache Sling Authentication XING Login . SUCCESS [ 6.348
> s]
> [INFO] Apache Sling Authentication XING OAuth . SUCCESS [ 2.301
> s]
> [INFO] Apache Sling Models bnd Plugin . SUCCESS [ 2.557
> s]
> [INFO] Apache Sling Bundle Resource Provider .. SUCCESS [ 2.935
> s]
> [INFO] Apache Sling Context-Aware Configuration API ... SUCCESS [ 1.440
> s]
> [INFO] Apache Sling Context-Aware Configuration bnd Plugin SUCCESS [ 1.131
> s]
> [INFO] Apache Sling Context-Aware Configuration Implementation SUCCESS [
> 14.570 s]
> [INFO] Apache Sling Context-Aware Configuration SPI ... SUCCESS [ 2.591
> s]
> [INFO] Apache Sling Validation Framework Core Implementation SUCCESS [01:54
> min]
> [INFO] Apache Sling Sample Slingshot .. SUCCESS [ 10.975
> s]
> [INFO] Apache Sling Context-Aware Configuration Integration Tests SUCCESS [
> 48.131 s]
> [INFO] Apache Sling Cassandra Resource Provider ... FAILURE [01:20
> min]
> [INFO] Apache Sling Commons Cache API . SUCCESS [ 8.379
> s]
> [INFO] Apache Sling OSGi PAX Exam support library . SUCCESS [ 10.545
> s]
> [INFO] Apache Sling Cache API Implementation support library SUCCESS [ 0.336
> s]
> [INFO] Apache Sling Cache API EhCache implementation .. FAILURE [ 52.695
> s]
> [INFO] Apache Sling Cache Portal Cache FAILURE [ 1.036
> s]
> [INFO] Apache Sling Dynamic Class Loader Support .. SUCCESS [ 10.888
> s]
> [INFO] Apache Sling Commons Java Compiler . SUCCESS [ 4.175
> s]
> [INFO] Apache Sling Content Detection Support . SUCCESS [ 20.521
> s]
> [INFO] Apache Sling Commons FileSystem ClassLoader SUCCESS [ 2.955
> s]
> [INFO] Apache Sling Commons HTML Utilities SUCCESS [ 1.610
> s]
> [INFO] Apache Sling Commons Johnzon Wrapper Library ... SUCCESS [ 2.192
> s]
> [INFO] Apache Sling Commons Log ... SUCCESS [ 40.843
> s]
> [INFO] Apache Sling Log WebConsole SUCCESS [ 16.236
> s]
> [INFO] Apache Sling OSGi LogService Implementation SUCCESS [ 1.673
> s]
> [INFO] Apache Sling Commons Messaging . SUCCESS [ 1.422
> s]
> [INFO] Apache Sling Commons Messaging Mail SUCCESS [ 21.980
> s]
> [INFO] Apache Sling Metrics ... SUCCESS [ 18.032
> s]
> [INFO] Apache Sling RRD4J metrics reporter SUCCESS [ 6.611
> s]
> [INFO] Apache Sling Commons MIME type mapping support .
[jira] [Commented] (SLING-7227) Repo Init: Add ability to register custom privileges
[
https://issues.apache.org/jira/browse/SLING-7227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341070#comment-16341070
]
Bertrand Delacretaz commented on SLING-7227:
...I forgot another nitpick, please add a few examples of the new syntax in
test-99.txt which is supposed to have short examples of everything. That's the
file that we copy to the website docs, slightly adapted to indicate required
bundle versions.
Apart from that I'm fine with you merging those changes in, thanks!
> Repo Init: Add ability to register custom privileges
>
>
> Key: SLING-7227
> URL: https://issues.apache.org/jira/browse/SLING-7227
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
>Reporter: angela
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Repoinit Parser 1.2.2, Repoinit JCR 1.1.8
>
>
> [~marett], [~bdelacretaz], looking at the repo-init source I couldn't find a
> way to register a custom privilege during repo init. I am sure this is an
> oversight and hasn't been omitted intentionally.
> The corresponding API calls are:
> {code}
> JackrabbitWorkspace.getPrivilegeManager()
> PrivilegeManager.registerPrivilege(String privilegeName, boolean isAbstract,
> String[] declaredAggregateNames)
> {code}
> See also
> http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-api/src/main/java/org/apache/jackrabbit/api/JackrabbitWorkspace.java?view=markup
> http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-api/src/main/java/org/apache/jackrabbit/api/security/authorization/PrivilegeManager.java?view=markup
> I would be appreciate if the repo init could have this gap filled. Thanks.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7227) Repo Init: Add ability to register custom privileges
[
https://issues.apache.org/jira/browse/SLING-7227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341018#comment-16341018
]
Bertrand Delacretaz commented on SLING-7227:
Thanks [~karlpauls], looks good!
For the syntax I think "register abstract privilege" would be more consistent
with the existing syntax, compared to "create service user" for example.
Instead of the "as abstract" suffix and with "abstract" being optional of
course.
FWIW there's a full syntax example at
https://sling.apache.org/documentation/bundles/repository-initialization.html ,
for comparison with other statements.
If you agree, that's just a small parser change. Apart from that I think you're
good to go, thanks!
In general we should add tests to {{ParsingErrorsTest}} [1] when introducing
new syntax. If you think of interesting error cases please add them, but given
that this new syntax is simple and flexible there might not be any. Just
mentioning this in case someone looks at this ticket as an example later.
[1]
https://github.com/apache/sling-org-apache-sling-repoinit-parser/blob/master/src/test/java/org/apache/sling/repoinit/parser/test/ParsingErrorsTest.java
> Repo Init: Add ability to register custom privileges
>
>
> Key: SLING-7227
> URL: https://issues.apache.org/jira/browse/SLING-7227
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
>Reporter: angela
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Repoinit Parser 1.2.2, Repoinit JCR 1.1.8
>
>
> [~marett], [~bdelacretaz], looking at the repo-init source I couldn't find a
> way to register a custom privilege during repo init. I am sure this is an
> oversight and hasn't been omitted intentionally.
> The corresponding API calls are:
> {code}
> JackrabbitWorkspace.getPrivilegeManager()
> PrivilegeManager.registerPrivilege(String privilegeName, boolean isAbstract,
> String[] declaredAggregateNames)
> {code}
> See also
> http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-api/src/main/java/org/apache/jackrabbit/api/JackrabbitWorkspace.java?view=markup
> http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-api/src/main/java/org/apache/jackrabbit/api/security/authorization/PrivilegeManager.java?view=markup
> I would be appreciate if the repo init could have this gap filled. Thanks.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7202) o.a.j.o.j.o.ObservationManagerImpl times out eventually in pax container init
[
https://issues.apache.org/jira/browse/SLING-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327114#comment-16327114
]
Bertrand Delacretaz commented on SLING-7202:
I don't remember seeing similar failures, but it's been a long time since I
worked on that CommonTests class.
> o.a.j.o.j.o.ObservationManagerImpl times out eventually in pax container init
> -
>
> Key: SLING-7202
> URL: https://issues.apache.org/jira/browse/SLING-7202
> Project: Sling
> Issue Type: Bug
> Components: Testing
>Affects Versions: Testing PaxExam 0.0.4
>Reporter: Nicolas Peltier
>Priority: Major
> Attachments: success-fail-logs.tar
>
>
> pipes IT intermittently fail. When they do, after having compared to when
> they don't, look like the core cause is
> {Code}
> 2017-10-10 22:32:13,092 WARN [FelixStartLevel]
> o.a.j.o.j.o.ObservationManagerImpl [ObservationManagerImpl.java : 457] Timed
> out waiting for change processor to stop after 1000 milliseconds. Falling
> back to asynchronous stop on ChangeProcessor [listenerId=10,
> tracker=//*[1b]@org.apache.sling.jcr.resource.internal.JcrResourceListener,
> contentSession=session-17,
> eventCount=org.apache.jackrabbit.oak.stats.SimpleStats@4405759a,
> eventDuration=org.apache.jackrabbit.oak.stats.SimpleStats@4aa43935,
> commitRateLimiter=null, running=false] (listener details:
> 'JcrResourceListener [BasicObserverConfiguration [includeExternal=true,
> paths=PathSet [paths=[Path [path=/]]], excludedPaths=PathSet [paths=[Path
> [path=/libs/sling/sightly/js], Path
> [path=/apps/sling/servlet/default/SLING_av... (1907 chars cut),
> propertyNamesHint=null, changeTypes=[ADDED, REMOVED, CHANGED],
> listeners=[ResourceChangeListenerInfo [paths=PathSet [paths=[Path [path=/]]],
> resourceChangeTypes=[ADDED, REMOVED, CHANGED],
> providerChangeTypes=[PROVIDER_ADDED, PROVIDER_REMOVED],
> propertyNamesHint=null, valid=true, external=true,
> listener=org.apache.sling.servlets.resolver.internal.SlingServletResolver@3993ddcd],
> ResourceChangeListenerInfo [paths=PathSet [paths=[Path [path=/]]],
> resourceChangeTypes=[ADDED, REMOVED, CHANGED],
> providerChangeTypes=[PROVIDER_ADDED, PROVIDER_REMOVED],
> propertyNamesHint=null, valid=true, external=true,
> listener=org.apache.sling.resourceresolver.impl.mapping.MapEntries@70b4e2df],
> ResourceChangeListenerInfo [paths=PathSet [paths=[Path [path=/]]],
> resourceChangeTypes=[ADDED, REMOVED, CHANGED],
> providerChangeTypes=[PROVIDER_ADDED, PROVIDER_REMOVED],
> propertyNamesHint=null, valid=true, external=true,
> listener=org.apache.sling.i18n.impl.JcrResourceBundleProvider@60af913d')
> {Code}
> after which content loading does not work, resulting in test failing
> cc [~olli]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (SLING-7356) Fix siblings selector name in Sling Query documentation
[
https://issues.apache.org/jira/browse/SLING-7356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz reassigned SLING-7356:
--
Assignee: Bertrand Delacretaz
> Fix siblings selector name in Sling Query documentation
> ---
>
> Key: SLING-7356
> URL: https://issues.apache.org/jira/browse/SLING-7356
> Project: Sling
> Issue Type: Bug
> Components: Documentation
>Reporter: Jordan Shurmer
>Assignee: Bertrand Delacretaz
>Priority: Trivial
> Attachments: hierarchy-operators.mdtext
>
>
> This is a simple documentation update to improve the consistency of the
> documentation.
> The siblings selector examples were called {{next}} in two places rather than
> {{siblings}}, which made it a little hard to read.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (SLING-7226) Repoinit: support optional intermediate path for user creation
[
https://issues.apache.org/jira/browse/SLING-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz resolved SLING-7226.
Resolution: Fixed
JCR repoinit module adapted in
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/commit/d039439fe21905a8a086979c375c0c21e5e08d49
- marking this fixed as a result.
> Repoinit: support optional intermediate path for user creation
> --
>
> Key: SLING-7226
> URL: https://issues.apache.org/jira/browse/SLING-7226
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
>Affects Versions: Repoinit Parser 1.2.0, Repoinit JCR 1.1.6
>Reporter: angela
>Assignee: Bertrand Delacretaz
> Fix For: Repoinit Parser 1.2.2, Repoinit JCR 1.1.8
>
>
> [~marett], [~bdelacretaz], if I am not mistaken it is currently not possible
> to pass the second parameter 'intermediatePath' when creating a service user
> using the repo-init.
> In the Jackrabbit {{UserManager}} API the call looks as follows:
> {code}
> UserManager.createSystemUser(String userID, String intermediatePath)
> {code}
> I would appreciate if both params would be respected by the repo-init and I
> don't think it should be a big deal adding this.
> Thanks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (SLING-7226) Repoinit: support optional intermediate path for user creation
[
https://issues.apache.org/jira/browse/SLING-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301248#comment-16301248
]
Bertrand Delacretaz edited comment on SLING-7226 at 12/22/17 2:31 PM:
--
Parser changes implemented in
https://github.com/apache/sling-org-apache-sling-repoinit-parser/commit/02c0d968fdac73240821873d930fabd190c1c9a8
- an optional "with path" clause is now supported for "create user" and
"create service user" statements. The parser doesn't check the path and accept
both relative and absolute paths.
The JCR repoinit module still needs to be adapted for these new options.
was (Author: bdelacretaz):
Parser changes implemented in
https://github.com/apache/sling-org-apache-sling-repoinit-parser/commit/02c0d968fdac73240821873d930fabd190c1c9a8
- an optional "with path" clause is now supported for "create user" and
"create service user" statements.
The JCR repoinit module still needs to be adapted for these new options.
> Repoinit: support optional intermediate path for user creation
> --
>
> Key: SLING-7226
> URL: https://issues.apache.org/jira/browse/SLING-7226
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
>Affects Versions: Repoinit Parser 1.2.0, Repoinit JCR 1.1.6
>Reporter: angela
>Assignee: Bertrand Delacretaz
> Fix For: Repoinit Parser 1.2.2, Repoinit JCR 1.1.8
>
>
> [~marett], [~bdelacretaz], if I am not mistaken it is currently not possible
> to pass the second parameter 'intermediatePath' when creating a service user
> using the repo-init.
> In the Jackrabbit {{UserManager}} API the call looks as follows:
> {code}
> UserManager.createSystemUser(String userID, String intermediatePath)
> {code}
> I would appreciate if both params would be respected by the repo-init and I
> don't think it should be a big deal adding this.
> Thanks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (SLING-7326) Disallow empty strings in repoinit grammar
[ https://issues.apache.org/jira/browse/SLING-7326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-7326. Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-repoinit-parser/commit/f490305727325927b710309992ffefd7b8bfccca > Disallow empty strings in repoinit grammar > -- > > Key: SLING-7326 > URL: https://issues.apache.org/jira/browse/SLING-7326 > Project: Sling > Issue Type: Bug > Components: Repoinit >Affects Versions: Repoinit Parser 1.2.0 >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz >Priority: Minor > Fix For: Repoinit Parser 1.2.2 > > > The JavaCC parser generator warns that the STRING production allowing empty > strings could potentially cause infinite loops. > Empty strings should not be needed in the grammar so far, so we should change > the STRING production to disallow them. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (SLING-7326) Disallow empty strings in repoinit grammar
Bertrand Delacretaz created SLING-7326: -- Summary: Disallow empty strings in repoinit grammar Key: SLING-7326 URL: https://issues.apache.org/jira/browse/SLING-7326 Project: Sling Issue Type: Bug Components: Repoinit Affects Versions: Repoinit Parser 1.2.0 Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor Fix For: Repoinit Parser 1.2.2 The JavaCC parser generator warns that the STRING production allowing empty strings could potentially cause infinite loops. Empty strings should not be needed in the grammar so far, so we should change the STRING production to disallow them. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SLING-7226) Repoinit: support optional intermediate path for user creation
[
https://issues.apache.org/jira/browse/SLING-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301248#comment-16301248
]
Bertrand Delacretaz commented on SLING-7226:
Parser changes implemented in
https://github.com/apache/sling-org-apache-sling-repoinit-parser/commit/02c0d968fdac73240821873d930fabd190c1c9a8
- an optional "with path" clause is now supported for "create user" and
"create service user" statements.
The JCR repoinit module still needs to be adapted for these new options.
> Repoinit: support optional intermediate path for user creation
> --
>
> Key: SLING-7226
> URL: https://issues.apache.org/jira/browse/SLING-7226
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
>Affects Versions: Repoinit Parser 1.2.0, Repoinit JCR 1.1.6
>Reporter: angela
>Assignee: Bertrand Delacretaz
> Fix For: Repoinit Parser 1.2.2, Repoinit JCR 1.1.8
>
>
> [~marett], [~bdelacretaz], if I am not mistaken it is currently not possible
> to pass the second parameter 'intermediatePath' when creating a service user
> using the repo-init.
> In the Jackrabbit {{UserManager}} API the call looks as follows:
> {code}
> UserManager.createSystemUser(String userID, String intermediatePath)
> {code}
> I would appreciate if both params would be respected by the repo-init and I
> don't think it should be a big deal adding this.
> Thanks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (SLING-7226) Repoinit: support optional intermediate path for user creation
[
https://issues.apache.org/jira/browse/SLING-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz updated SLING-7226:
---
Affects Version/s: Repoinit Parser 1.2.0
Repoinit JCR 1.1.6
> Repoinit: support optional intermediate path for user creation
> --
>
> Key: SLING-7226
> URL: https://issues.apache.org/jira/browse/SLING-7226
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
>Affects Versions: Repoinit Parser 1.2.0, Repoinit JCR 1.1.6
>Reporter: angela
>Assignee: Bertrand Delacretaz
> Fix For: Repoinit Parser 1.2.2, Repoinit JCR 1.1.8
>
>
> [~marett], [~bdelacretaz], if I am not mistaken it is currently not possible
> to pass the second parameter 'intermediatePath' when creating a service user
> using the repo-init.
> In the Jackrabbit {{UserManager}} API the call looks as follows:
> {code}
> UserManager.createSystemUser(String userID, String intermediatePath)
> {code}
> I would appreciate if both params would be respected by the repo-init and I
> don't think it should be a big deal adding this.
> Thanks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (SLING-7226) Repoinit: support optional intermediate path for user creation
[
https://issues.apache.org/jira/browse/SLING-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz updated SLING-7226:
---
Fix Version/s: Repoinit JCR 1.1.8
Repoinit Parser 1.2.2
> Repoinit: support optional intermediate path for user creation
> --
>
> Key: SLING-7226
> URL: https://issues.apache.org/jira/browse/SLING-7226
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
>Affects Versions: Repoinit Parser 1.2.0, Repoinit JCR 1.1.6
>Reporter: angela
>Assignee: Bertrand Delacretaz
> Fix For: Repoinit Parser 1.2.2, Repoinit JCR 1.1.8
>
>
> [~marett], [~bdelacretaz], if I am not mistaken it is currently not possible
> to pass the second parameter 'intermediatePath' when creating a service user
> using the repo-init.
> In the Jackrabbit {{UserManager}} API the call looks as follows:
> {code}
> UserManager.createSystemUser(String userID, String intermediatePath)
> {code}
> I would appreciate if both params would be respected by the repo-init and I
> don't think it should be a big deal adding this.
> Thanks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (SLING-7226) Repoinit: support optional intermediate path for user creation
[
https://issues.apache.org/jira/browse/SLING-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz updated SLING-7226:
---
Summary: Repoinit: support optional intermediate path for user creation
(was: Repo Init: allow to pass intermediate path upon creating service user)
> Repoinit: support optional intermediate path for user creation
> --
>
> Key: SLING-7226
> URL: https://issues.apache.org/jira/browse/SLING-7226
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
>Reporter: angela
>Assignee: Bertrand Delacretaz
>
> [~marett], [~bdelacretaz], if I am not mistaken it is currently not possible
> to pass the second parameter 'intermediatePath' when creating a service user
> using the repo-init.
> In the Jackrabbit {{UserManager}} API the call looks as follows:
> {code}
> UserManager.createSystemUser(String userID, String intermediatePath)
> {code}
> I would appreciate if both params would be respected by the repo-init and I
> don't think it should be a big deal adding this.
> Thanks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (SLING-7226) Repo Init: allow to pass intermediate path upon creating service user
[
https://issues.apache.org/jira/browse/SLING-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz reassigned SLING-7226:
--
Assignee: Bertrand Delacretaz
> Repo Init: allow to pass intermediate path upon creating service user
> -
>
> Key: SLING-7226
> URL: https://issues.apache.org/jira/browse/SLING-7226
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
>Reporter: angela
>Assignee: Bertrand Delacretaz
>
> [~marett], [~bdelacretaz], if I am not mistaken it is currently not possible
> to pass the second parameter 'intermediatePath' when creating a service user
> using the repo-init.
> In the Jackrabbit {{UserManager}} API the call looks as follows:
> {code}
> UserManager.createSystemUser(String userID, String intermediatePath)
> {code}
> I would appreciate if both params would be respected by the repo-init and I
> don't think it should be a big deal adding this.
> Thanks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (SLING-7280) Repoinit: add support for empty rep:glob restriction
[ https://issues.apache.org/jira/browse/SLING-7280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-7280. Resolution: Fixed > Repoinit: add support for empty rep:glob restriction > > > Key: SLING-7280 > URL: https://issues.apache.org/jira/browse/SLING-7280 > Project: Sling > Issue Type: Bug > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.6 >Reporter: angela >Assignee: Bertrand Delacretaz > Fix For: Repoinit JCR 1.1.8 > > > [~bdelacretaz], I was asked by a colleague at Adobe how to create a > _rep:glob_ restriction with an empty string value as it is possible and > documented with Jackrabbit API. I didn't find how to do that and suspect that > it's simply a bug in the repo init. > I would appreciate if you could look into this and fix it. > cc: [~marett] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SLING-7280) Repoinit: add support for empty rep:glob restriction
[ https://issues.apache.org/jira/browse/SLING-7280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16301152#comment-16301152 ] Bertrand Delacretaz commented on SLING-7280: Also added an example at https://sling.apache.org/documentation/bundles/repository-initialization.html > Repoinit: add support for empty rep:glob restriction > > > Key: SLING-7280 > URL: https://issues.apache.org/jira/browse/SLING-7280 > Project: Sling > Issue Type: Bug > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.6 >Reporter: angela >Assignee: Bertrand Delacretaz > Fix For: Repoinit JCR 1.1.8 > > > [~bdelacretaz], I was asked by a colleague at Adobe how to create a > _rep:glob_ restriction with an empty string value as it is possible and > documented with Jackrabbit API. I didn't find how to do that and suspect that > it's simply a bug in the repo init. > I would appreciate if you could look into this and fix it. > cc: [~marett] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (SLING-7280) Repoinit: add support for empty rep:glob restriction
[ https://issues.apache.org/jira/browse/SLING-7280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz reassigned SLING-7280: -- Assignee: Bertrand Delacretaz > Repoinit: add support for empty rep:glob restriction > > > Key: SLING-7280 > URL: https://issues.apache.org/jira/browse/SLING-7280 > Project: Sling > Issue Type: Bug > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.6 >Reporter: angela >Assignee: Bertrand Delacretaz > Fix For: Repoinit JCR 1.1.8 > > > [~bdelacretaz], I was asked by a colleague at Adobe how to create a > _rep:glob_ restriction with an empty string value as it is possible and > documented with Jackrabbit API. I didn't find how to do that and suspect that > it's simply a bug in the repo init. > I would appreciate if you could look into this and fix it. > cc: [~marett] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SLING-7280) Repoinit: add support for empty rep:glob restriction
[
https://issues.apache.org/jira/browse/SLING-7280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300098#comment-16300098
]
Bertrand Delacretaz commented on SLING-7280:
Implemented in
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/commit/87994dd2f090591012721d79eb00727f7a2ba4b6
FWIW It looks like an empty rep:glob restriction does not work for all
permissions, I initially tried with a {{jcr:modifyProperties}} permission and
didn't get the expected behavior.
It works fine with {{jcr:read}} as in this example, similar to the test that I
added in the above commit:
{code}
allow jcr:read on /someNode restriction (rep:glob)
{code}
And allows reading /someNode but not its children
Note the repoinit syntax with just {{rep:glob}} as opposed to {{rep:glob,""}} -
this is already supported by the current repoinit parser module, but the
repoinit JCR module didn't handle it so far.
> Repoinit: add support for empty rep:glob restriction
>
>
> Key: SLING-7280
> URL: https://issues.apache.org/jira/browse/SLING-7280
> Project: Sling
> Issue Type: Bug
> Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.6
>Reporter: angela
> Fix For: Repoinit JCR 1.1.8
>
>
> [~bdelacretaz], I was asked by a colleague at Adobe how to create a
> _rep:glob_ restriction with an empty string value as it is possible and
> documented with Jackrabbit API. I didn't find how to do that and suspect that
> it's simply a bug in the repo init.
> I would appreciate if you could look into this and fix it.
> cc: [~marett]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (SLING-7280) Repoinit: add support for empty rep:glob restriction
[ https://issues.apache.org/jira/browse/SLING-7280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-7280: --- Fix Version/s: Repoinit JCR 1.1.8 > Repoinit: add support for empty rep:glob restriction > > > Key: SLING-7280 > URL: https://issues.apache.org/jira/browse/SLING-7280 > Project: Sling > Issue Type: Bug > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.6 >Reporter: angela > Fix For: Repoinit JCR 1.1.8 > > > [~bdelacretaz], I was asked by a colleague at Adobe how to create a > _rep:glob_ restriction with an empty string value as it is possible and > documented with Jackrabbit API. I didn't find how to do that and suspect that > it's simply a bug in the repo init. > I would appreciate if you could look into this and fix it. > cc: [~marett] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SLING-7280) Repoinit: add support for empty rep:glob restriction
[ https://issues.apache.org/jira/browse/SLING-7280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-7280: --- Summary: Repoinit: add support for empty rep:glob restriction (was: Repo Init: Unable to create rep:glob restriction with empty string value) > Repoinit: add support for empty rep:glob restriction > > > Key: SLING-7280 > URL: https://issues.apache.org/jira/browse/SLING-7280 > Project: Sling > Issue Type: Bug > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.6 >Reporter: angela > Fix For: Repoinit JCR 1.1.8 > > > [~bdelacretaz], I was asked by a colleague at Adobe how to create a > _rep:glob_ restriction with an empty string value as it is possible and > documented with Jackrabbit API. I didn't find how to do that and suspect that > it's simply a bug in the repo init. > I would appreciate if you could look into this and fix it. > cc: [~marett] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SLING-7280) Repoinit: add support for empty rep:glob restriction
[ https://issues.apache.org/jira/browse/SLING-7280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-7280: --- Affects Version/s: Repoinit JCR 1.1.6 > Repoinit: add support for empty rep:glob restriction > > > Key: SLING-7280 > URL: https://issues.apache.org/jira/browse/SLING-7280 > Project: Sling > Issue Type: Bug > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.6 >Reporter: angela > Fix For: Repoinit JCR 1.1.8 > > > [~bdelacretaz], I was asked by a colleague at Adobe how to create a > _rep:glob_ restriction with an empty string value as it is possible and > documented with Jackrabbit API. I didn't find how to do that and suspect that > it's simply a bug in the repo init. > I would appreciate if you could look into this and fix it. > cc: [~marett] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (SLING-7259) Repo Init: Empty glob causes repo-init fail
[ https://issues.apache.org/jira/browse/SLING-7259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-7259. Resolution: Duplicate > Repo Init: Empty glob causes repo-init fail > --- > > Key: SLING-7259 > URL: https://issues.apache.org/jira/browse/SLING-7259 > Project: Sling > Issue Type: Bug > Components: Repoinit >Reporter: Lydia Puric > > According to > https://jackrabbit.apache.org/oak/docs/security/authorization/restriction.html > empty glob is supported to restrict access only the node but not its > subtrees. > Doing this it causes the repo-init to fail. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SLING-7259) Repo Init: Empty glob causes repo-init fail
[ https://issues.apache.org/jira/browse/SLING-7259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295022#comment-16295022 ] Bertrand Delacretaz commented on SLING-7259: Duplicate of SLING-7280 > Repo Init: Empty glob causes repo-init fail > --- > > Key: SLING-7259 > URL: https://issues.apache.org/jira/browse/SLING-7259 > Project: Sling > Issue Type: Bug > Components: Repoinit >Reporter: Lydia Puric > > According to > https://jackrabbit.apache.org/oak/docs/security/authorization/restriction.html > empty glob is supported to restrict access only the node but not its > subtrees. > Doing this it causes the repo-init to fail. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SLING-7268) unable to create principals and use principals in ACLs on import
[
https://issues.apache.org/jira/browse/SLING-7268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272631#comment-16272631
]
Bertrand Delacretaz commented on SLING-7268:
Could you use repoinit instead to create those users and ACLs? That's the
recommended way.
See
https://sling.apache.org/documentation/bundles/repository-initialization.html
for details
> unable to create principals and use principals in ACLs on import
>
>
> Key: SLING-7268
> URL: https://issues.apache.org/jira/browse/SLING-7268
> Project: Sling
> Issue Type: Bug
>Affects Versions: JCR ContentLoader 2.2.6
>Reporter: Andres Bott
>Priority: Minor
>
> Not able to use principals and ACLS on the same bundle when defining initial
> content
> ie:
> {
> "jcr:primaryType" : "sling:Folder",
> "security:principals": [
> { "name": "*user*", "password": "mypassword"}
> ],
> "security:acl": [
> { "principal": "*user*", "granted": ["jcr:read","jcr:write"] }
> ]
> }
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SLING-7241) [pipes] Nashorn ScriptEngine in PipeBindings is null
[ https://issues.apache.org/jira/browse/SLING-7241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265145#comment-16265145 ] Bertrand Delacretaz commented on SLING-7241: Ok, I understand the classloader trick now - and yes a method which does that more clearly is useful. My angle is that we might encounter a similar issue in other places, so it's good to briefly explain the "trick" in the code. > [pipes] Nashorn ScriptEngine in PipeBindings is null > > > Key: SLING-7241 > URL: https://issues.apache.org/jira/browse/SLING-7241 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: Pipes 1.0.4 > Environment: java.runtime.name = Java(TM) SE Runtime Environment > java.runtime.version = 1.8.0_144-b01 >Reporter: Björn Csott >Assignee: Nicolas Peltier >Priority: Minor > Fix For: pipes 2.0.0 > > Attachments: error.log > > > Under some unclear circumstances the ScriptEngine in PipeBindings does not > get initialized. > There is a solution out there to attach Nashorn to the system bundle. Appart > from that I was able to fix it by using a different constructor: > ScriptEngineManager(null). > The issue can be reproduced by deploying > https://github.com/bcsott/migration-tool > When it fails the following is written to stderror.log: > ScriptEngineManager providers.next(): javax.script.ScriptEngineFactory: > Provider jdk.nashorn.api.scripting.NashornScriptEngineFactory not found -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SLING-7241) [pipes] Nashorn ScriptEngine in PipeBindings is null
[
https://issues.apache.org/jira/browse/SLING-7241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265124#comment-16265124
]
Bertrand Delacretaz commented on SLING-7241:
IIUC there's a classloader related reason for calling
{{ScriptEngineManager(null).getEngineByName("nashorn")}} twice?
If that's correct please add comments to explain the idea - right now I'd say
one of those calls should go away but it looks like there's a specific reason
for doing that.
Also, "nashorn" should be a constant I guess ;-)
> [pipes] Nashorn ScriptEngine in PipeBindings is null
>
>
> Key: SLING-7241
> URL: https://issues.apache.org/jira/browse/SLING-7241
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Pipes 1.0.4
> Environment: java.runtime.name = Java(TM) SE Runtime Environment
> java.runtime.version = 1.8.0_144-b01
>Reporter: Björn Csott
>Assignee: Nicolas Peltier
>Priority: Minor
> Fix For: pipes 2.0.0
>
> Attachments: error.log
>
>
> Under some unclear circumstances the ScriptEngine in PipeBindings does not
> get initialized.
> There is a solution out there to attach Nashorn to the system bundle. Appart
> from that I was able to fix it by using a different constructor:
> ScriptEngineManager(null).
> The issue can be reproduced by deploying
> https://github.com/bcsott/migration-tool
> When it fails the following is written to stderror.log:
> ScriptEngineManager providers.next(): javax.script.ScriptEngineFactory:
> Provider jdk.nashorn.api.scripting.NashornScriptEngineFactory not found
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SLING-7262) Generate reusable list of repositories for machine consumption
[
https://issues.apache.org/jira/browse/SLING-7262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264327#comment-16264327
]
Bertrand Delacretaz commented on SLING-7262:
You're welcome! I have now also added a {{OncePerBuild}} mechanism that we
might use to create that modules json file, I think it's cleaner than having an
additional Maven setup?
The code that talks to Git should not run if the json file already exists, to
avoid slowing down interactive staging.
See commit https://github.com/apache/sling-site/commit/03c78d0
I'm not planning to implement the Git -> json code now but that should make it
easy for you to adapt what you have in your prototype.
> Generate reusable list of repositories for machine consumption
> --
>
> Key: SLING-7262
> URL: https://issues.apache.org/jira/browse/SLING-7262
> Project: Sling
> Issue Type: Task
> Components: Build and Source Control
>Reporter: Robert Munteanu
>
> We currently have two 'clients' that query the github repos and the
> .sling-module.xml descriptors:
> * the jenkins job creation DSL script
> * the repo manifest creation script
> We've also discussed in SLING-7161 the possibility of listing all
> repositories on the website.
> To minimize the effort of talking to github in each location and reduce the
> number of calls to Github ( for rate limiting purposes ) we should generate a
> JSON/XML file that contains all information about the git repos. This file is
> in turns read by various "clients" that need the information.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SLING-7262) Generate reusable list of repositories for machine consumption
[ https://issues.apache.org/jira/browse/SLING-7262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264231#comment-16264231 ] Bertrand Delacretaz commented on SLING-7262: I saw that Konrad's prototype duplicates some code from page.tpl, to avoid that I have refactored the templates utility code in https://github.com/apache/sling-site/commit/e21451fabcb1e7d36164b54f0393181b7f08d3f2 > Generate reusable list of repositories for machine consumption > -- > > Key: SLING-7262 > URL: https://issues.apache.org/jira/browse/SLING-7262 > Project: Sling > Issue Type: Task > Components: Build and Source Control >Reporter: Robert Munteanu > > We currently have two 'clients' that query the github repos and the > .sling-module.xml descriptors: > * the jenkins job creation DSL script > * the repo manifest creation script > We've also discussed in SLING-7161 the possibility of listing all > repositories on the website. > To minimize the effort of talking to github in each location and reduce the > number of calls to Github ( for rate limiting purposes ) we should generate a > JSON/XML file that contains all information about the git repos. This file is > in turns read by various "clients" that need the information. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SLING-7258) org.apache.sling.starter.startup.impl.StartupFilter should return 503 when Sling is starting
[
https://issues.apache.org/jira/browse/SLING-7258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261109#comment-16261109
]
Bertrand Delacretaz commented on SLING-7258:
Thank you! I think that's enough information.
> org.apache.sling.starter.startup.impl.StartupFilter should return 503 when
> Sling is starting
>
>
> Key: SLING-7258
> URL: https://issues.apache.org/jira/browse/SLING-7258
> Project: Sling
> Issue Type: Bug
> Components: Launchpad
>Affects Versions: Starter Startup 1.0.2
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
> Fix For: Launchpad Builder 10, Starter Startup 1.0.4
>
> Attachments: starting.png
>
>
> The {{org.apache.sling.starter.startup.impl.StartupFilter}} should return 503
> when Sling is starting, since that's the correct state of the server until
> it's ready to accept requests.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (SLING-7258) org.apache.sling.starter.startup.impl.StartupFilter should return 503 when Sling is starting
[
https://issues.apache.org/jira/browse/SLING-7258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261076#comment-16261076
]
Bertrand Delacretaz edited comment on SLING-7258 at 11/21/17 5:16 PM:
--
Thanks for this, I agree with the logic.
The new index.html page is very nice but some of its information duplicates
stuff found elsewhere, and if the bundle is used outside of the Sling Launchpad
some of that might not apply.
Would it make sense to have less information on that page so it's less likely
to get stale or be invalid in other contexts? Maybe just the "Almost there..."
title and then what starts with "To get started with Sling...", omitting the
two paragraphs that are currently in between. And use "Apache Sling" in that
first title then instead of "the instance".
was (Author: bdelacretaz):
Thanks for this, I agree with the logic.
The new index.html page is very nice but some of its information duplicates
stuff found elsewhere, and if the bundle is used outside of the Sling Launchpad
some of that might not apply.
Would it make sense to have less information on that page so it's less likely
to get stale or be invalid in other contexts? Maybe just the "Almost there..."
title and then what starts with "To get started with Sling...", omitting the
two paragraphs that are currently in between.
> org.apache.sling.starter.startup.impl.StartupFilter should return 503 when
> Sling is starting
>
>
> Key: SLING-7258
> URL: https://issues.apache.org/jira/browse/SLING-7258
> Project: Sling
> Issue Type: Bug
> Components: Launchpad
>Affects Versions: Starter Startup 1.0.2
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
> Fix For: Launchpad Builder 10, Starter Startup 1.0.4
>
>
> The {{org.apache.sling.starter.startup.impl.StartupFilter}} should return 503
> when Sling is starting, since that's the correct state of the server until
> it's ready to accept requests.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (SLING-7258) org.apache.sling.starter.startup.impl.StartupFilter should return 503 when Sling is starting
[
https://issues.apache.org/jira/browse/SLING-7258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261076#comment-16261076
]
Bertrand Delacretaz edited comment on SLING-7258 at 11/21/17 5:11 PM:
--
Thanks for this, I agree with the logic.
The new index.html page is very nice but some of its information duplicates
stuff found elsewhere, and if the bundle is used outside of the Sling Launchpad
some of that might not apply.
Would it make sense to have less information on that page so it's less likely
to get stale or be invalid in other contexts? Maybe just the "Almost there..."
title and then what starts with "To get started with Sling...", omitting the
two paragraphs that are currently in between.
was (Author: bdelacretaz):
Thanks for this, I agree with the logic.
The new index.html page is very nice but some of its information duplicates
stuff found elsewhere, and if the bundle is used outside of the Sling Launchpad
some of that might not apply.
Would it make sense to have less information on that page so it's less likely
to get stale or become invalid? Maybe just the "Almost there..." title and then
what starts with "To get started with Sling...", omitting the two paragraphs
that are currently in between.
> org.apache.sling.starter.startup.impl.StartupFilter should return 503 when
> Sling is starting
>
>
> Key: SLING-7258
> URL: https://issues.apache.org/jira/browse/SLING-7258
> Project: Sling
> Issue Type: Bug
> Components: Launchpad
>Affects Versions: Starter Startup 1.0.2
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
> Fix For: Launchpad Builder 10, Starter Startup 1.0.4
>
>
> The {{org.apache.sling.starter.startup.impl.StartupFilter}} should return 503
> when Sling is starting, since that's the correct state of the server until
> it's ready to accept requests.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SLING-7258) org.apache.sling.starter.startup.impl.StartupFilter should return 503 when Sling is starting
[
https://issues.apache.org/jira/browse/SLING-7258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261076#comment-16261076
]
Bertrand Delacretaz commented on SLING-7258:
Thanks for this, I agree with the logic.
The new index.html page is very nice but some of its information duplicates
stuff found elsewhere, and if the bundle is used outside of the Sling Launchpad
some of that might not apply.
Would it make sense to have less information on that page so it's less likely
to get stale or become invalid? Maybe just the "Almost there..." title and then
what starts with "To get started with Sling...", omitting the two paragraphs
that are currently in between.
> org.apache.sling.starter.startup.impl.StartupFilter should return 503 when
> Sling is starting
>
>
> Key: SLING-7258
> URL: https://issues.apache.org/jira/browse/SLING-7258
> Project: Sling
> Issue Type: Bug
> Components: Launchpad
>Affects Versions: Starter Startup 1.0.2
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
> Fix For: Launchpad Builder 10, Starter Startup 1.0.4
>
>
> The {{org.apache.sling.starter.startup.impl.StartupFilter}} should return 503
> when Sling is starting, since that's the correct state of the server until
> it's ready to accept requests.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SLING-7259) Repo Init: Empty glob causes repo-init fail
[ https://issues.apache.org/jira/browse/SLING-7259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260752#comment-16260752 ] Bertrand Delacretaz commented on SLING-7259: Can you provide steps to reproduce, maybe just a failing repoinit statement? Thanks. > Repo Init: Empty glob causes repo-init fail > --- > > Key: SLING-7259 > URL: https://issues.apache.org/jira/browse/SLING-7259 > Project: Sling > Issue Type: Bug > Components: Repoinit >Reporter: Lydia Puric > > According to > https://jackrabbit.apache.org/oak/docs/security/authorization/restriction.html > empty glob is supported to restrict access only the node but not its > subtrees. > Doing this it causes the repo-init to fail. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (SLING-7161) Update site to reference git instead of svn
[ https://issues.apache.org/jira/browse/SLING-7161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255096#comment-16255096 ] Bertrand Delacretaz edited comment on SLING-7161 at 11/16/17 10:37 AM: --- > ...inconsistent spacing in Groovy templates (sometimes tabs, sometimes > spaces)... Totally my fault, I used a mix of editors when working on those, including some badly configured ones :-\ I suggest that we fix files when we need to touch them, ideally with separate formatting-only commits. Suggest using tabs as we do in other places. was (Author: bdelacretaz): > ...inconsistent spacing in Groovy templates (sometimes tabs, sometimes > spaces)... Totally my fault, I used a mix of editors when working on those, including some badly configured ones :-\ I suggest that we fix files when we need to touch them, ideally with separate formatting-only commits. > Update site to reference git instead of svn > --- > > Key: SLING-7161 > URL: https://issues.apache.org/jira/browse/SLING-7161 > Project: Sling > Issue Type: Sub-task > Components: Site >Reporter: Robert Munteanu >Assignee: Robert Munteanu > > All the https://svn.apache.org/repos/asf/sling/... tags should be rewritten > to the git repos. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SLING-7161) Update site to reference git instead of svn
[ https://issues.apache.org/jira/browse/SLING-7161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255096#comment-16255096 ] Bertrand Delacretaz commented on SLING-7161: > ...inconsistent spacing in Groovy templates (sometimes tabs, sometimes > spaces)... Totally my fault, I used a mix of editors when working on those, including some badly configured ones :-\ I suggest that we fix files when we need to touch them, ideally with separate formatting-only commits. > Update site to reference git instead of svn > --- > > Key: SLING-7161 > URL: https://issues.apache.org/jira/browse/SLING-7161 > Project: Sling > Issue Type: Sub-task > Components: Site >Reporter: Robert Munteanu >Assignee: Robert Munteanu > > All the https://svn.apache.org/repos/asf/sling/... tags should be rewritten > to the git repos. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SLING-3049) Make Logback Stacktrace Packaging data support OSGi aware
[ https://issues.apache.org/jira/browse/SLING-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226482#comment-16226482 ] Bertrand Delacretaz commented on SLING-3049: Thanks for this, looks very useful! Echoing Robert's comment on Twitter, I think it would be useful to also include the bundle symbolic name. It makes the log lines more verbose but such logs are verbose anyway, and it's useful information. > Make Logback Stacktrace Packaging data support OSGi aware > - > > Key: SLING-3049 > URL: https://issues.apache.org/jira/browse/SLING-3049 > Project: Sling > Issue Type: Improvement > Components: Commons >Reporter: Chetan Mehrotra >Assignee: Chetan Mehrotra > Labels: logback > Attachments: SLING-3049.patch, > buildbot-exceptions-while-stopping-jetty.txt > > > Logback provides a useful feature where it dumps the Class packaging Data > along with the stacktrace [1]. This provides a quick view of the location > from where classes in a given stacktrace are coming. Its default logic does > not work properly in OSGi env. Hence it would be useful to patch its logic to > become OSGi aware > [1] http://logback.qos.ch/reasonsToSwitch.html#packagingData -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SLING-7161) Update site to reference git instead of svn
[ https://issues.apache.org/jira/browse/SLING-7161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16212324#comment-16212324 ] Bertrand Delacretaz commented on SLING-7161: Note that http://sling.apache.org/project-information.html should already mention our Git repositories, but for some reason the website is out of sync with the content published on its asf-site branch, INFRA-15330 > Update site to reference git instead of svn > --- > > Key: SLING-7161 > URL: https://issues.apache.org/jira/browse/SLING-7161 > Project: Sling > Issue Type: Sub-task > Components: Site >Reporter: Robert Munteanu > > All the https://svn.apache.org/repos/asf/sling/... tags should be rewritten > to the git repos. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SLING-3987) Move from Subversion to Git
[ https://issues.apache.org/jira/browse/SLING-3987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210868#comment-16210868 ] Bertrand Delacretaz commented on SLING-3987: The move is partially executed, see INFRA-15308 and search for that on the Sling dev list for details. > Move from Subversion to Git > --- > > Key: SLING-3987 > URL: https://issues.apache.org/jira/browse/SLING-3987 > Project: Sling > Issue Type: Task > Components: Best practices >Reporter: Oliver Lietz > > track work for moving to Git > [Wiki: Move from Subversion to > Git|https://cwiki.apache.org/confluence/display/SLING/Move+from+Subversion+to+Git] > [discussion > @dev|http://apache-sling.73963.n3.nabble.com/jira-Created-SLING-3987-move-from-Subversion-to-Git-td4040882.html#a4040901] > with [~cziegeler], [~bdelacretaz], [~fmeschbe], [~justinedelson], [~rombert] > and [~radu.cotescu] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SLING-5421) Allow JCR installer to recover from being paused indefinitely
[ https://issues.apache.org/jira/browse/SLING-5421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210809#comment-16210809 ] Bertrand Delacretaz commented on SLING-5421: This is not the place to discuss AEM issues, please ask your Adobe contacts via Adobe channels. > Allow JCR installer to recover from being paused indefinitely > - > > Key: SLING-5421 > URL: https://issues.apache.org/jira/browse/SLING-5421 > Project: Sling > Issue Type: Improvement > Components: Installer >Affects Versions: JCR Installer 3.1.8 >Reporter: Chetan Mehrotra >Assignee: Chetan Mehrotra >Priority: Critical > > With SLING-3747 the JCR installer provided a mechanism for pausing the > installer to support cases where installation can result in restart of > installer bundle itself. > However it may happen that once this flag is set the process gets abruptly > killed and the flag remain set. In such a case the installer would remain > paused and a user would have to remove the flag for it to work again. To > support such cases there should be some kind of timeout such that installer > does not remain in pause state forever. > Note also the [discussion on the > mailinglist|http://markmail.org/thread/dlutannhyrk55h43]. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SLING-7176) Link and embed bundle readme's from Sling Site
[ https://issues.apache.org/jira/browse/SLING-7176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191077#comment-16191077 ] Bertrand Delacretaz commented on SLING-7176: I'd prefer using the name "modules" rather than "bundles" as it's more general. Otherwise +1 For bundles which have website docs we might add a front matter variable with their GitHub repository name, to establish the mapping. > Link and embed bundle readme's from Sling Site > -- > > Key: SLING-7176 > URL: https://issues.apache.org/jira/browse/SLING-7176 > Project: Sling > Issue Type: Improvement > Components: Site >Reporter: Konrad Windszus > > As proposed in > https://lists.apache.org/thread.html/7cb85c44d3b852fd13acc66413606d1ada1e6585eda2220981ad0c6d@%3Cdev.sling.apache.org%3E > we should link > # from the bundle's readme MD files to the according page below > http://sling.apache.org/documentation/bundles.html > # from the [bundles overview > page|http://sling.apache.org/documentation/bundles.html] in the Sling Site > towards the individual bundle's readmes > The latter should be done automatically by leveraging JBake template > functionionality. > Some technical hints on how to implement this: > # Come up with a new JBake template: bundles > # This template will use the Github API with its [List organization > repositories > method|https://developer.github.com/v3/repos/#list-organization-repositories] > to figure out all Sling repositories > # For all repositories containing a readme.md file a link towards this file > (on Github) should be placed in the bundle overview page > # To figure out the relation between individual Sling Site Bundle > Documentation pages (e.g. > http://sling.apache.org/documentation/bundles/models.html) and the according > readme.md, the readme should be optionally extended with a link towards the > Sling Site page. > # TBD: format of the link towards the Sling Site documentation, so that it > can be easily extracted with Groovy to put the link to the readme in the > right position of the bundle overview page. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SLING-7167) Adjust READMEs
[
https://issues.apache.org/jira/browse/SLING-7167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189589#comment-16189589
]
Bertrand Delacretaz commented on SLING-7167:
bq. We have some valuable READMEs next to reactor/builder POMs – where should
we put that information?
Let me reformulate to make sure I understand: you want to move those READMEs
elsewhere because the reactor POMs are going away with the move to Git?
If yes I suggest that we list those READMEs here and discuss on a case-by-case
basis. I think several of these "module groups" have a module named "core" or
"api" where those general READMEs can go.
> Adjust READMEs
> --
>
> Key: SLING-7167
> URL: https://issues.apache.org/jira/browse/SLING-7167
> Project: Sling
> Issue Type: Sub-task
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>
> * remove outdated information (/)
> * switch from plain text to Markdown (/)
> * add uniform header linking to Sling project (/)
> * add README where missing (/)
> Uniform header:
>
> {noformat}
> # Apache Sling ... [module name from POM]
> This module is part of the [Apache Sling](https://sling.apache.org) project.
> {noformat}
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (SLING-6955) Convert Sling website to JBake and gitpubsub
[ https://issues.apache.org/jira/browse/SLING-6955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-6955. Resolution: Fixed http://sling.apache.org/ is now generated from https://git-wip-us.apache.org/repos/asf?p=sling-site.git , marking this resolved. We'll create more specific tickets if needed. > Convert Sling website to JBake and gitpubsub > > > Key: SLING-6955 > URL: https://issues.apache.org/jira/browse/SLING-6955 > Project: Sling > Issue Type: Bug > Components: Site >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz > > I've started experimenting with JBake to generate the Sling website. If that > works well we might switch to that + gitpubsub to have a more flexible way to > generate the site. > My current experiment is at https://github.com/bdelacretaz/sling-jbake, at > this point the site starts looking like the current one and many pages work > well. Update: it's now at https://github.com/apache/sling-site > Internal links will need to be converted, all *.md files need a more complete > "front matter" section, currently I have a stub for that, and I think images > need to move under the assets folder. > To play with that, generate the site with the bake.sh script (setup > shamelessly copied from https://github.com/apache/incubator-tamaya-site) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SLING-6955) Convert Sling website to JBake and gitpubsub
[ https://issues.apache.org/jira/browse/SLING-6955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184221#comment-16184221 ] Bertrand Delacretaz commented on SLING-6955: I have asked for the new website to be activated in INFRA-15186 and saved the contents of the current website (except apidocs and components which are static) at https://svn.apache.org/repos/asf/sling/site/trunk/site-backup-2017-09-28.zip > Convert Sling website to JBake and gitpubsub > > > Key: SLING-6955 > URL: https://issues.apache.org/jira/browse/SLING-6955 > Project: Sling > Issue Type: Bug > Components: Site >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz > > I've started experimenting with JBake to generate the Sling website. If that > works well we might switch to that + gitpubsub to have a more flexible way to > generate the site. > My current experiment is at https://github.com/bdelacretaz/sling-jbake, at > this point the site starts looking like the current one and many pages work > well. Update: it's now at https://github.com/apache/sling-site > Internal links will need to be converted, all *.md files need a more complete > "front matter" section, currently I have a stub for that, and I think images > need to move under the assets folder. > To play with that, generate the site with the bake.sh script (setup > shamelessly copied from https://github.com/apache/incubator-tamaya-site) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (SLING-6955) Convert Sling website to JBake and gitpubsub
[ https://issues.apache.org/jira/browse/SLING-6955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182488#comment-16182488 ] Bertrand Delacretaz edited comment on SLING-6955 at 9/27/17 12:37 PM: -- I have added client-side automatic table of contents generation for pages of type "page", see https://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html for example. Based on Robert's https://github.com/nghuuphuoc/tocjs suggestion, thanks! For now, all such pages get a ToC, we might want to refine later. was (Author: bdelacretaz): I have added client-side automatic table of contents generation for pages of type "page", see https://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html for example. For now, all such pages get a ToC, we might want to refine later. > Convert Sling website to JBake and gitpubsub > > > Key: SLING-6955 > URL: https://issues.apache.org/jira/browse/SLING-6955 > Project: Sling > Issue Type: Bug > Components: Site >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz > > I've started experimenting with JBake to generate the Sling website. If that > works well we might switch to that + gitpubsub to have a more flexible way to > generate the site. > My current experiment is at https://github.com/bdelacretaz/sling-jbake, at > this point the site starts looking like the current one and many pages work > well. Update: it's now at https://github.com/apache/sling-site > Internal links will need to be converted, all *.md files need a more complete > "front matter" section, currently I have a stub for that, and I think images > need to move under the assets folder. > To play with that, generate the site with the bake.sh script (setup > shamelessly copied from https://github.com/apache/incubator-tamaya-site) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SLING-6955) Convert Sling website to JBake and gitpubsub
[ https://issues.apache.org/jira/browse/SLING-6955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182488#comment-16182488 ] Bertrand Delacretaz commented on SLING-6955: I have added client-side automatic table of contents generation for pages of type "page", see https://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html for example. For now, all such pages get a ToC, we might want to refine later. > Convert Sling website to JBake and gitpubsub > > > Key: SLING-6955 > URL: https://issues.apache.org/jira/browse/SLING-6955 > Project: Sling > Issue Type: Bug > Components: Site >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz > > I've started experimenting with JBake to generate the Sling website. If that > works well we might switch to that + gitpubsub to have a more flexible way to > generate the site. > My current experiment is at https://github.com/bdelacretaz/sling-jbake, at > this point the site starts looking like the current one and many pages work > well. Update: it's now at https://github.com/apache/sling-site > Internal links will need to be converted, all *.md files need a more complete > "front matter" section, currently I have a stub for that, and I think images > need to move under the assets folder. > To play with that, generate the site with the bake.sh script (setup > shamelessly copied from https://github.com/apache/incubator-tamaya-site) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SLING-6955) Convert Sling website to JBake and gitpubsub
[ https://issues.apache.org/jira/browse/SLING-6955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180983#comment-16180983 ] Bertrand Delacretaz commented on SLING-6955: I have just suggested making the new site live on our dev list, "Ok to replace sling.apache.org with the new JBake-generated site ?" > Convert Sling website to JBake and gitpubsub > > > Key: SLING-6955 > URL: https://issues.apache.org/jira/browse/SLING-6955 > Project: Sling > Issue Type: Bug > Components: Site >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz > > I've started experimenting with JBake to generate the Sling website. If that > works well we might switch to that + gitpubsub to have a more flexible way to > generate the site. > My current experiment is at https://github.com/bdelacretaz/sling-jbake, at > this point the site starts looking like the current one and many pages work > well. Update: it's now at https://github.com/apache/sling-site > Internal links will need to be converted, all *.md files need a more complete > "front matter" section, currently I have a stub for that, and I think images > need to move under the assets folder. > To play with that, generate the site with the bake.sh script (setup > shamelessly copied from https://github.com/apache/incubator-tamaya-site) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SLING-6955) Convert Sling website to JBake and gitpubsub
[ https://issues.apache.org/jira/browse/SLING-6955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16180848#comment-16180848 ] Bertrand Delacretaz commented on SLING-6955: I have now resynced the content and the staged https://sling.apache.org/ng/ website with revision 1809724 of our svn content. Note that the links inside pages of that staged website still point to the existing website, the safest way to navigate to the new pages to check them is using https://sling.apache.org/ng/sitemap.html This affected the following pages: * https://sling.apache.org/ng/documentation/bundles/content-distribution.html * https://sling.apache.org/ng/documentation/bundles/content-loading-jcr-contentloader.html * https://sling.apache.org/ng/documentation/bundles/discovery-api-and-impl.html * https://sling.apache.org/ng/documentation/bundles/jcr-installer-provider.html * https://sling.apache.org/ng/documentation/bundles/models.html * https://sling.apache.org/ng/documentation/bundles/org-apache-sling-junit-bundles.html * https://sling.apache.org/ng/documentation/bundles/repository-initialization.html * https://sling.apache.org/ng/documentation/bundles/resource-merger.html * https://sling.apache.org/ng/documentation/bundles/scheduler-service-commons-scheduler.html * https://sling.apache.org/ng/documentation/bundles/sling-pipes.html * https://sling.apache.org/ng/documentation/bundles/sling-query.html * https://sling.apache.org/ng/documentation/bundles/sling-query/basic-ideas.html * https://sling.apache.org/ng/documentation/bundles/sling-query/examples.html * https://sling.apache.org/ng/documentation/bundles/sling-query/hierarchy-operators.html *https://sling.apache.org/ng/documentation/bundles/sling-query/methods.html * https://sling.apache.org/ng/documentation/bundles/sling-query/modifiers.html * https://sling.apache.org/ng/documentation/bundles/sling-query/operators.html * https://sling.apache.org/ng/documentation/bundles/sling-query/selectors.html * https://sling.apache.org/ng/documentation/bundles/sling-query/vs-jcr.html * https://sling.apache.org/ng/documentation/development/jsr-305.html * https://sling.apache.org/ng/documentation/development/release-management.html * https://sling.apache.org/ng/documentation/the-sling-engine/architecture.html * https://sling.apache.org/ng/documentation/the-sling-engine/service-authentication.html * https://sling.apache.org/ng/documentation/tutorials-how-tos/46-line-blog.html * https://sling.apache.org/ng/news.html * https://sling.apache.org/ng/old-stuff/scriptengineintegration/groovy-support.html * https://sling.apache.org/ng/old-stuff/scriptengineintegration/xslt-processing-pipeline.html > Convert Sling website to JBake and gitpubsub > > > Key: SLING-6955 > URL: https://issues.apache.org/jira/browse/SLING-6955 > Project: Sling > Issue Type: Bug > Components: Site >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz > > I've started experimenting with JBake to generate the Sling website. If that > works well we might switch to that + gitpubsub to have a more flexible way to > generate the site. > My current experiment is at https://github.com/bdelacretaz/sling-jbake, at > this point the site starts looking like the current one and many pages work > well. Update: it's now at https://github.com/apache/sling-site > Internal links will need to be converted, all *.md files need a more complete > "front matter" section, currently I have a stub for that, and I think images > need to move under the assets folder. > To play with that, generate the site with the bake.sh script (setup > shamelessly copied from https://github.com/apache/incubator-tamaya-site) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
