Re: [VOTE] Release Apache Sling Models API 1.5.2, Models Implementation 1.7.0
+1 Am Di., 25. Juni 2024 um 17:08 Uhr schrieb Stefan Seifert : > Hi, > > Models API 1.5.2 (3 issues) > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12353054=Text=12310710 > > Models Implementation 1.7.0 (4 issues) > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12353296=Text=12310710 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2870/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2870 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > stefan > -- https://cqdump.joerghoh.de
Re: [VOTE] Release Apache Sling OSGi Feature Maven Plugin 1.8.4
+1 Am Fr., 21. Juni 2024 um 23:13 Uhr schrieb Robert Munteanu < romb...@apache.org>: > Hi, > > We solved 4 issues in this release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354617=Text > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2868/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2868 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Robert Munteanu > -- https://cqdump.joerghoh.de
Re: [VOTE] Release Apache Sling Feature Model Analyser 2.0.8
+1 Am Fr., 21. Juni 2024 um 23:14 Uhr schrieb Robert Munteanu < romb...@apache.org>: > Hi, > > We solved 3 issues in this release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354844=Text > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2869/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2869 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Robert Munteanu > -- https://cqdump.joerghoh.de
Re: Sling API exporting @ConsumerType class
Hi Julian, regarding the "LazyBindings.putOnly" method, the motivation was a mostly about performance, as I found a number of occurrences, where the put method actually resolved the supplier, but the return value of put() was not used at all. Also I want to avoid any change on the semantics of put, because for that I would need a major version bump; besides that the API contract of java.script.Bindings says that null is only returned if there was no value previously associated with that name. For that reason I believe that it's best if * the ProtectedBindings moves into the SLING API bundle (package org.apache.sling.api.scripting, next to the LazyBindings) * and the both LazyBindings and ProtectedBindings are marked as ProviderType to make that take effect I need to release a new version of scirpting.core as well, but then the narrow import range for the package org.apache.sling.api.scripting is more relaxed, and allows an easier evolution of the API. Jörg Am Mi., 12. Juni 2024 um 14:22 Uhr schrieb Julian Sedding < jsedd...@gmail.com>: > Hi Jörg > > In general, I agree that we could, and maybe should, evaluate which > types in the Sling API should be @ProviderType instead of > @ConsumerType. My assumption would be that most types should be > @ProviderType. I don't know what sort of versioning change adding the > @ProviderType annotation causes, however. > > Regarding your specific case, I wonder if it would be acceptable to > remove the "putOnly" method, and instead modify the "put" method to > return "null" for in the case where a key was inserted, but the > supplier never evaluated. Of course that would change the behaviour, > so might cause issues in some edge cases. > > Regards > Julian > > On Mon, Jun 10, 2024 at 12:38 PM Jörg Hoh > wrote: > > > > Eric pointed out correctly, that there was tight connection between SLING > > API and Scripting core, as the package import range on scripting core > > (bundle version 2.4.8) is quite narrow for the package > > org.apache.sling.api.scripting: > > > > org.apache.sling.api.scripting; version="[2.5, 2.6)" > > > > This is caused by the class LazyBindings being a ConsumerType ( > > > https://github.com/apache/sling-org-apache-sling-api/blob/bdbd1768969917d0e2436d5b008fff80aaa729dc/src/main/java/org/apache/sling/api/scripting/LazyBindings.java#L56 > ) > > and the scripting core inheriting from it (in ProtectedBindings). > > > > My latest extension to it (SLING-12062) then caused a bump of the > exported > > version, thus breaking the existing imports. > > > > Of course I could do a release of the Scripting Core as well and make > sure > > that it works with the package version as well, but I wonder if this is > the > > right thing to do. > > > > Should the Sling API export ConsumerType interfaces and classes at all, > > which can cause this type of problems, or should we try to avoid them? > This > > is a more general question; and in case that we want to avoid those, the > > question is still how we want to move forward with this specific instance > > of it. > > > > My personal opinion is > > * to avoid @ConsumerType exports in the Sling API in general and > > * move the ProtectedBindings class, which inherits from the LazyBindings > > over to the API > > > > that would allow us to have a wider import range on the scripting.core > side. > > > > WDYT? > > > > Jörg > > > > > > -- > > https://cqdump.joerghoh.de > -- https://cqdump.joerghoh.de
[CANCELLED] [VOTE] Release Apache Sling API 2.27.4
Hi, I cancelled the release, as Eric pointed out correctly that this new version did not play with the latest version of scripting core. Will fix it and then restart the release process. Jörg Am Di., 4. Juni 2024 um 15:24 Uhr schrieb Jörg Hoh : > We solved 9 issues in this > release:https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12353245=Text=12310710 > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2865/ > > You can use this UNIX script to download the release and verify the > signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > Usage: > sh check_staged_release.sh 2865 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > > > -- > https://cqdump.joerghoh.de > > -- https://cqdump.joerghoh.de
Sling API exporting @ConsumerType class
Eric pointed out correctly, that there was tight connection between SLING API and Scripting core, as the package import range on scripting core (bundle version 2.4.8) is quite narrow for the package org.apache.sling.api.scripting: org.apache.sling.api.scripting; version="[2.5, 2.6)" This is caused by the class LazyBindings being a ConsumerType ( https://github.com/apache/sling-org-apache-sling-api/blob/bdbd1768969917d0e2436d5b008fff80aaa729dc/src/main/java/org/apache/sling/api/scripting/LazyBindings.java#L56) and the scripting core inheriting from it (in ProtectedBindings). My latest extension to it (SLING-12062) then caused a bump of the exported version, thus breaking the existing imports. Of course I could do a release of the Scripting Core as well and make sure that it works with the package version as well, but I wonder if this is the right thing to do. Should the Sling API export ConsumerType interfaces and classes at all, which can cause this type of problems, or should we try to avoid them? This is a more general question; and in case that we want to avoid those, the question is still how we want to move forward with this specific instance of it. My personal opinion is * to avoid @ConsumerType exports in the Sling API in general and * move the ProtectedBindings class, which inherits from the LazyBindings over to the API that would allow us to have a wider import range on the scripting.core side. WDYT? Jörg -- https://cqdump.joerghoh.de
Re: [VOTE] Release Apache Sling API 2.27.4
Hi Eric, good point; I already thought about it, but wasn't aware of that narrow dependency range between scripting.core and Sling API. Will cancel this release and try to come up with a proper solution. Thanks! Am Do., 6. Juni 2024 um 23:18 Uhr schrieb Eric Norman : > 0 for me. It is probably ok, but I wasn't able to try it in the starter > (or my own projects) due to the errors below from the feature analyzer, > Maybe you can update and release those other impacted bundles at the same > time as this one? > > [ERROR] [bundle-packages] > org.apache.sling:org.apache.sling.scripting.core:2.4.8: Bundle is importing > package org.apache.sling.api.scripting;version=[2.5,2.6) with start order > 20 but no bundle is exporting these for that start order in the required > version range. > [ERROR] [bundle-packages] > org.apache.sling:org.apache.sling.servlets.resolver:2.11.2: Bundle is > importing package org.apache.sling.api.scripting;version=[2.5,2.6) with > start order 20 but no bundle is exporting these for that start order in the > required version range. > > Regards, > Eric > > On Tue, Jun 4, 2024 at 6:25 AM Jörg Hoh > wrote: > > > We solved 9 issues in this > > release: > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12353245=Text=12310710 > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2865/ > > > > You can use this UNIX script to download the release and verify the > > signatures: > > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > > sh check_staged_release.sh 2865 /tmp/sling-staging > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > > > > > -- > > https://cqdump.joerghoh.de > > > -- https://cqdump.joerghoh.de
Re: VOTE] Release Apache Sling Feature Model Analyser 2.0.4
+1 (You might need to update your gpg keys before) Am Fr., 7. Juni 2024 um 14:00 Uhr schrieb ang...@apache.org < ang...@apache.org>: > Hi everyone, > > We solved 4 issues in this release: > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353831=Text > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2866/ > > You can use this UNIX script to download the release and verify the > signatures: > > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2866 /tmp/sling-staging > > Please vote to approve this release: > >[ ] +1 Approve the release >[ ] 0 Don't care >[ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Thanks for voting and kind regards > Angela > -- https://cqdump.joerghoh.de
Re: [VOTE] Release Apache Sling Repoinit JCR 1.1.50
+1 Am Di., 4. Juni 2024 um 15:51 Uhr schrieb Julian Sedding : > Hi, > > We solved 1 issue in this release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354758=Text > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2864/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2864 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Julian > -- https://cqdump.joerghoh.de
Re: [VOTE] Release Apache Sling API 2.27.4
+1 Am Di., 4. Juni 2024 um 15:24 Uhr schrieb Jörg Hoh : > We solved 9 issues in this > release:https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12353245=Text=12310710 > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2865/ > > You can use this UNIX script to download the release and verify the > signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > Usage: > sh check_staged_release.sh 2865 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > > > -- > https://cqdump.joerghoh.de > > -- https://cqdump.joerghoh.de
[VOTE] Release Apache Sling API 2.27.4
We solved 9 issues in this release:https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12353245=Text=12310710 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2865/ You can use this UNIX script to download the release and verify the signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2865 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. -- https://cqdump.joerghoh.de
[Result][VOTE] Release Apache Sling Engine 2.15.16
Hi, The vote has passed with the following result : +1 (binding): Jörg Hoh, Eric Norman, Julian Sedding I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Am Di., 28. Mai 2024 um 16:59 Uhr schrieb Jörg Hoh : > Hi, > > We solved 5 issues in this > release:https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354681=Text > Staging > repository:https://repository.apache.org/content/repositories/orgapachesling-2863/ > > You can use this UNIX script to download the release and verify the > signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > Usage: > sh check_staged_release.sh 2863 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours5 > > Jörg > > -- > https://cqdump.joerghoh.de > > -- https://cqdump.joerghoh.de
Intent to release SLING API 2.27.4
Hi, We have accumulated a number of changes to the SLING API: https://issues.apache.org/jira/issues/?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22API%202.27.4%22 I don't see any non-resolved tickets for this release. If there are no objections I would start a release at the begin of next week. Jörg -- https://cqdump.joerghoh.de
Re: [VOTE] Release Apache Sling Engine 2.15.16
+1 Am Di., 28. Mai 2024 um 16:59 Uhr schrieb Jörg Hoh : > Hi, > > We solved 5 issues in this > release:https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354681=Text > Staging > repository:https://repository.apache.org/content/repositories/orgapachesling-2863/ > > You can use this UNIX script to download the release and verify the > signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > Usage: > sh check_staged_release.sh 2863 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours5 > > Jörg > > -- > https://cqdump.joerghoh.de > > -- https://cqdump.joerghoh.de
[VOTE] Release Apache Sling Engine 2.15.16
Hi, We solved 5 issues in this release:https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354681=Text Staging repository:https://repository.apache.org/content/repositories/orgapachesling-2863/ You can use this UNIX script to download the release and verify the signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2863 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours5 Jörg -- https://cqdump.joerghoh.de
Re: [VOTE] Release Apache Sling Repoinit JCR 1.1.48
+1 Am Sa., 25. Mai 2024 um 11:55 Uhr schrieb Julian Sedding : > Hi, > > We solved 3 issues in the Apache Sling Repoinit JCR 1.1.48 release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353873=Text > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2862/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: sh check_staged_release.sh 2862 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ]0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Julian > -- https://cqdump.joerghoh.de
Re: [VOTE] Release Apache Sling JCR Resource 3.3.2
+1 Am Mo., 20. Mai 2024 um 18:03 Uhr schrieb Radu Cotescu : > Hi, > > We solved 1 issue in this release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354675=Text > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2861/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2861 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Radu Cotescu > -- https://cqdump.joerghoh.de
Re: [VOTE] Release Apache Sling JCR Resource 3.3.0
+1 Am Mo., 6. Mai 2024 um 18:20 Uhr schrieb Radu Cotescu : > Hi, > > We solved 4 issues in this release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354599=Text > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2860/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2860 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Radu Cotescu > -- https://cqdump.joerghoh.de
Re: [VOTE] Release Apache Sling Hypermedia API client-side tools 1.0.2
+1 Am Di., 30. Apr. 2024 um 16:20 Uhr schrieb Andrei Dulvac : > We solved 1 issues in this release: > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22HApi%20Client%201.0.2%22 > > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2858/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2858 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > - Andrei > -- https://cqdump.joerghoh.de
[RESULT][VOTE] Sling Engine 2.15.14
Hi, The vote has passed with the following result : +1 (binding): Carsten Ziegeler, Stefan Seifert, Jörg Hoh +1 (non binding): I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Jörg Am Mo., 22. Apr. 2024 um 05:19 Uhr schrieb Jörg Hoh : > Hi, > > We solved 1 issue in this > release:https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354595=Text > > Staging > repository:https://repository.apache.org/content/repositories/orgapachesling-2852/ > > You can use this UNIX script to download the release and verify the > signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > Usage: > sh check_staged_release.sh 2852 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > > > -- > https://cqdump.joerghoh.de > > -- https://cqdump.joerghoh.de
Re: [VOTE] Release Apache Sling Commons JSON 2.0.28
+1 Am Do., 25. Apr. 2024 um 04:21 Uhr schrieb Robert Munteanu < romb...@apache.org>: > Hi, > > We solved 1 issue in this release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354549=Text > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2856/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2856 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Robert Munteanu > -- https://cqdump.joerghoh.de
Re: [VOTE] Sling Engine 2.15.14
my +1 Am So., 21. Apr. 2024 um 21:19 Uhr schrieb Jörg Hoh : > Hi, > > We solved 1 issue in this > release:https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354595=Text > > Staging > repository:https://repository.apache.org/content/repositories/orgapachesling-2852/ > > You can use this UNIX script to download the release and verify the > signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > Usage: > sh check_staged_release.sh 2852 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > > > -- > https://cqdump.joerghoh.de > > -- https://cqdump.joerghoh.de
[VOTE] Sling Engine 2.15.14
Hi, We solved 1 issue in this release:https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354595=Text Staging repository:https://repository.apache.org/content/repositories/orgapachesling-2852/ You can use this UNIX script to download the release and verify the signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2852 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. -- https://cqdump.joerghoh.de
[CANCELLED] [Vote] Release Apache Sling Engine 2.15.12
The fix SLING-12297 does not work as intended, will therefor cancel the release. Thanks Paul Bjorkstrand for spotting it. Jörg Am Do., 18. Apr. 2024 um 10:14 Uhr schrieb Jörg Hoh : > Hi, > > We solved 1 issue in this > release:https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354582=Text > > Staging > repository:https://repository.apache.org/content/repositories/orgapachesling-2850/ > > You can use this UNIX script to download the release and verify the > signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > Usage: > sh check_staged_release.sh 2850 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Jörg > > -- > https://cqdump.joerghoh.de > > -- https://cqdump.joerghoh.de
Re: [Vote] Release Apache Sling Engine 2.15.12
HI Paul, you are absolutely right. I will cancel this release, fix the issue and restart the release process. Thanks, Jörg Am Do., 18. Apr. 2024 um 15:11 Uhr schrieb Paul Bjorkstrand < paul.bjorkstr...@gmail.com>: > -1 (non-binding) > > I have a concern with one change that was merged recently. I added a > comment, but it was already merged by the time I read through it. I think a > recent log addition [1] is incorrect. I think this logging addition will > not log what is desired. > > [1]: > > https://github.com/apache/sling-org-apache-sling-engine/pull/41/files#diff-6457a924a51a1c233c4c4c45de49a05b0e438032ac111c0c1644c6dcd546ab9bR521 > > // Paul > > > On Thu, Apr 18, 2024 at 6:08 AM Stefan Seifert > wrote: > > > +1 > > > > stefan > > > -- https://cqdump.joerghoh.de
Re: [VOTE] Release Apache Sling Testing Sling Mock Oak 3.2.0-1.22.15
+1 Am Mi., 17. Apr. 2024 um 20:32 Uhr schrieb Stefan Seifert : > Hi, > > We solved 6 issues in this release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12353253=Text=12310710 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2849/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2849 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > stefan > -- https://cqdump.joerghoh.de
Re: [VOTE] Release Apache Sling Testing Sling Mock 3.5.0, Sling Mock Oak 4.0.0-1.62.0
+1 Am Mi., 17. Apr. 2024 um 20:32 Uhr schrieb Stefan Seifert : > Hi, > > Testing Sling Mock 3.5.0 (3 issues) > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12354169=Text=12310710 > > Testing Sling Mock Oak 4.0.0-1.62.0 (7 issues) > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12354581=Text=12310710 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2848/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2848 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > stefan > -- https://cqdump.joerghoh.de
Re: [VOTE] Release Apache Sling Tenant 1.1.8
+1 Am Do., 11. Apr. 2024 um 15:33 Uhr schrieb Robert Munteanu < romb...@apache.org>: > Hi, > > We solved 3 issues in this release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354544=Text > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2845/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2845 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Robert Munteanu > -- https://cqdump.joerghoh.de
Re: [VOTE] Release Apache Sling JUnit Tests Teleporter 1.0.26
+1 Am Mi., 17. Apr. 2024 um 11:31 Uhr schrieb Robert Munteanu < romb...@apache.org>: > Hi, > > We solved 2 issues in this release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12348597=Text > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2847/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2847 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Robert Munteanu > -- https://cqdump.joerghoh.de
Re: [Vote] Release Apache Sling Engine 2.15.12
my +1 Am Do., 18. Apr. 2024 um 10:14 Uhr schrieb Jörg Hoh : > Hi, > > We solved 1 issue in this > release:https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354582=Text > > Staging > repository:https://repository.apache.org/content/repositories/orgapachesling-2850/ > > You can use this UNIX script to download the release and verify the > signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > Usage: > sh check_staged_release.sh 2850 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Jörg > > -- > https://cqdump.joerghoh.de > > -- https://cqdump.joerghoh.de
[Vote] Release Apache Sling Engine 2.15.12
Hi, We solved 1 issue in this release:https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354582=Text Staging repository:https://repository.apache.org/content/repositories/orgapachesling-2850/ You can use this UNIX script to download the release and verify the signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2850 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Jörg -- https://cqdump.joerghoh.de
Re: [VOTE] Release Apache Sling Resource Observation Annotations 1.0.0
+1 Am Fr., 1. März 2024 um 13:19 Uhr schrieb Konrad Windszus : > Hi, > > We solved 1 issues in this release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354378=Text > > The source code is located in the new repository at > https://github.com/apache/sling-org-apache-sling-resource-observation-annotations > . > > Its usage is described in https://github.com/apache/sling-site/pull/157 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2841/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2841 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Thanks in advance for voting, > Konrad -- https://cqdump.joerghoh.de
Re: [VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.3.6
+1 Am Do., 29. Feb. 2024 um 15:29 Uhr schrieb Robert Munteanu < romb...@apache.org>: > Hi, > > We solved 2 issues in this release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353651=Text > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2840/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2840 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Robert Munteanu > -- https://cqdump.joerghoh.de
Re: [git] New git repository for retired module - sling-org-apache-sling-commons-json
Hi Robert, makes sense. To clarify: We just provide this final version of commons.json as a convenience for all users who are still depending on commons.json; but there is no intention to continue development of commons.json or to re-introducing this dependency again into other areas of Sling. Correct? Jörg Am Mo., 26. Feb. 2024 um 16:30 Uhr schrieb Robert Munteanu < romb...@apache.org>: > Hi, > > A long time ago we retired the commons.json module for legal reasons > [1], leaving it only in the SVN attic [2]. > > After some time a CVE was reported against this module [3] which we > could not fix as we could not release new versions. > > In the meantime, the JSON library we have been using has changed its > license to 'Public domain', which makes it acceptable for use at the > ASF. [4] > > I would like to create a GitHub repository for this module and include > the current state from the attic. This opens up the way for creating a > final service release, allowing consumers of this bundle that have not > cleaned up their usages to use non-vulnerable versions. > > I will leave this thread open for comments for 72 hours. > > Thanks, > Robert > > > [1]: https://lists.apache.org/thread/p9rmd9dvgk04h36dtm6vn0bj6dkx0hkk > [2]: https://svn.apache.org/repos/asf/sling/attic/commons.json/ > [3]: https://www.cve.org/CVERecord?id=CVE-2022-47937 > [4]: https://issues.apache.org/jira/browse/LEGAL-666 > -- https://cqdump.joerghoh.de
[RESULT][VOTE] Release Apache Sling Servlets Resolver version 2.11.2
Hi, The vote has passed with the following result : +1 (binding): Radu Cotescu, Julian Sedding, Jörg Hoh +1 (non binding): - I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Jörg Am Mi., 21. Feb. 2024 um 14:27 Uhr schrieb Jörg Hoh : > Hi, > > We solved 4 issues in this > release:https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354345=Text > > Staging > repository:https://repository.apache.org/content/repositories/orgapachesling-2839/ > > You can use this UNIX script to download the release and verify the > signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > Usage: > sh check_staged_release.sh 2839 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Jörg > > -- > https://cqdump.joerghoh.de > > -- https://cqdump.joerghoh.de
Re: [VOTE] Release Apache Sling Servlets Resolver version 2.11.2
+1 Am Mi., 21. Feb. 2024 um 14:27 Uhr schrieb Jörg Hoh : > Hi, > > We solved 4 issues in this > release:https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354345=Text > > Staging > repository:https://repository.apache.org/content/repositories/orgapachesling-2839/ > > You can use this UNIX script to download the release and verify the > signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > Usage: > sh check_staged_release.sh 2839 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Jörg > > -- > https://cqdump.joerghoh.de > > -- https://cqdump.joerghoh.de
[VOTE] Release Apache Sling Servlets Resolver version 2.11.2
Hi, We solved 4 issues in this release:https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354345=Text Staging repository:https://repository.apache.org/content/repositories/orgapachesling-2839/ You can use this UNIX script to download the release and verify the signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2839 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Jörg -- https://cqdump.joerghoh.de
Re: [VOTE] Release Apache Sling GraphQL Core 0.0.30
+1 Am Do., 8. Feb. 2024 um 16:22 Uhr schrieb Radu Cotescu : > Hi, > > We solved 1 issue in this release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354075=Text > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2838/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2838 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Radu Cotescu > -- https://cqdump.joerghoh.de
Re: [VOTE] Release Apache Sling Testing Clients 3.0.24
+1 Am Di., 6. Feb. 2024 um 13:33 Uhr schrieb Andrei Dulvac : > Hi, > > We solved 1 issue in this release: > https://issues.apache.org/jira/projects/SLING/versions/12354205 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2837 > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2837 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > - Andrei > -- https://cqdump.joerghoh.de
Re: [VOTE] Release Apache Sling Parent and Bundle Parent version 60
+1 Am Di., 30. Jan. 2024 um 14:27 Uhr schrieb Konrad Windszus : > Hi, > > We solved some issues in this release: > > Sling Parent 60: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353433=Text > Sling Bundle Parent 60: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353434=Text > > Some important hints to consider when upgrading to that version are > available at https://cwiki.apache.org/confluence/x/SI75E. > These releases increase the minimum Java build version to 11/17 and > introduce automated code formatting with spotless-maven-plugin. > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2836/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > Usage: sh check_staged_release.sh 2836 /tmp/sling-staging > > Please vote to approve this release: > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because … > > This majority vote is open for at least 72 hours. > > Thanks, > Konrad -- https://cqdump.joerghoh.de
Re: Sling Model Caching & GC problems
Paul, thanks for your mail. I agree to your observation what's going on. I also think that cache at the ResourceResolver level makes more sense, and it's easier to control and remove cached models, which cannot be used any more. @Carsten: Regarding the size, we can still use a WeakHashMap as a container for these Sling Models (and store the WeakHashMap in the PropertyMap of the ResourceResolver), and that should prevent the worst, even in case of a long-running ResourceResolver or many adaptions. Jörg Am Di., 30. Jan. 2024 um 07:16 Uhr schrieb Carsten Ziegeler < cziege...@apache.org>: > I don't know much about sling models caching, but it seems storing the > cache into the resource resolver and therefore binding it to that > lifecycle sounds very reasonable to me. And due to the mentioned support > for Closeable, the cache gets discarded automatically with the resolver > being closed. No extra handling required, no soft references etc. needed. > > Obviously, that sounds problematic with long or forever running resource > resolvers as the cache would never be released. However, I guess thats > not worse than what we have today. And long running resource resolvers > are an anti-pattern anyway. > > Regards > Carsten > > On 23.01.2024 17:23, Paul Bjorkstrand wrote: > > Hi Jörg, > > > > My guess is that you are running up against the problem where the Model > is > > referencing its adaptable, directly or indirectly. In that situation, the > > model would not be collectable because it is referenced more strongly > than > > by weak reference. The reference path of these might look like this: > > > > Model Cache Holder (the Model Adapter Factory > > (strong reference) > > Model Cache > > (soft reference) > > Model > > (strong reference) > > Resource Resolver > > (strong reference, maybe indirectly) > > Resource [the adaptable] > > > > > > The resource is strongly or softly referenced, possibly indirectly, > making > > it ineligible for collection on normal GC cycles. The resource & > resolver, > > will not be collected until after the model is collected. Since the model > > is not collected until there is memory pressure, that would explain why > you > > are seeing this (expensive) GC behavior. > > > > When memory pressure occurs, first the models (soft references) are > > collected prior to the OOM, which releases both resolver (no longer > > referenced via field in the model) and resource. > > > > The quickest fix is to release the resource resolver at the end of the > > model’s constructor or @PostConstruct [2]. Alternatively, you can > eliminate > > the cache=true, provided it does not negatively impact your application > > performance. > > Another option, though more involved, is that the entire caching impl > could > > be changed to better handle these kinds of reference loops, by putting > the > > cache in the adaptable itself (Resolver, Resource, Request, etc). > Possible > > good candidates of these are [4] or request attributes. [4] seems to be > the > > overall best candidate, especially since you can hook into it using > > Closeable ([5]) improving the cache eviction even more. > > > > As long as the object holding the cache is not referenced strongly > outside > > that reference loop (cache holder > cache > model > ... > cache holder), > > then the loop's objects would be eligible for GC as soon as the cache > > holder is eligible. > > > > [1]: > > > https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/ref/SoftReference.html > > [2]: > > > https://sling.apache.org/documentation/bundles/models.html#a-note-about-cache-true-and-using-the-self-injector > > [3]: > https://github.com/apache/sling-org-apache-sling-models-impl/pull/18 > > [4]: > > > https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/java/org/apache/sling/api/resource/ResourceResolver.java#L888 > > [5]: > > > https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/java/org/apache/sling/api/resource/ResourceResolver.java#L610 > > > > // Paul > > > > > > On Tue, Jan 23, 2024 at 6:48 AM Jörg Hoh .invalid> > > wrote: > > > >> Hi Sling community, > >> > >> I want to share a recent experience I had with Sling Models, Sling Model > >> caching and Garbage Collection problems. > >> > >> I had a case, where an AEM instance had massive garbage collection > >> problems, but no memory problems. We saw the regular sawtooth pattern in > >> the heap cons
Re: [VOTE] Release Apache Sling Commons Log 5.5.0
+1 Am Mo., 29. Jan. 2024 um 13:38 Uhr schrieb Robert Munteanu < romb...@apache.org>: > Hi, > > We solved 2 issues in this release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354154=Text > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2835/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2835 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Robert Munteanu > -- https://cqdump.joerghoh.de
Re: [VOTE] Release Apache Sling Rewriter 1.3.10
+1 Am Mi., 24. Jan. 2024 um 07:07 Uhr schrieb Carsten Ziegeler < cziege...@apache.org>: > Hi, > > We solved 2 issues in this release > https://issues.apache.org/jira/projects/SLING/versions/12354138 > > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2833/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2833 /tmp/sling-staging > > Please vote to approve this release: > >[ ] +1 Approve the release >[ ] 0 Don't care >[ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe > cziege...@apache.org > -- https://cqdump.joerghoh.de
Re: [VOTE] Release Apache Sling Servlets Resolver 2.11.0
+1 Am Mi., 24. Jan. 2024 um 14:56 Uhr schrieb Carsten Ziegeler < cziege...@apache.org>: > Hi, > > We solved 1 issues in this release > https://issues.apache.org/jira/browse/SLING-12233 > > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2834/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2834 /tmp/sling-staging > > Please vote to approve this release: > >[ ] +1 Approve the release >[ ] 0 Don't care >[ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe > cziege...@apache.org > -- https://cqdump.joerghoh.de
Re: [VOTE] Release Apache Sling Testing JCR Mock 1.6.14, OSGi Mock 3.4.2, ResourceResolver Mock 1.4.6, Sling Mock 3.4.18
+1 Am Mo., 22. Jan. 2024 um 15:56 Uhr schrieb Stefan Seifert : > Hi, > > Testing JCR Mock 1.6.14 (1 issue) > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12354068=Text=12310710 > > Testing OSGi Mock 3.4.2 (1 issue) > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12353872=Text=12310710 > > Testing ResourceResolver Mock 1.4.6 (1 issue) > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12353544=Text=12310710 > > Testing Sling Mock 3.4.18 (1 issue) > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12354009=Text=12310710 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2832/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2832 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > stefan > -- https://cqdump.joerghoh.de
Sling Model Caching & GC problems
Hi Sling community, I want to share a recent experience I had with Sling Models, Sling Model caching and Garbage Collection problems. I had a case, where an AEM instance had massive garbage collection problems, but no memory problems. We saw the regular sawtooth pattern in the heap consumption, but heavy GC activity (in a stop-the-world manner) almost constantly. But no OutOfMemory situation, there it's not a memory leak. I manually captured a heapdump and found a lot of Sling models being referenced by the Sling ModelAdapterFactory cache, and rechecking these model classes in detail I found them to specify "cache=true" in their @Model annotation.When these statements were removed, the situation looks completely different, and the garbage collection was normal again. I don't have a full explanation for this behavior yet. The Sling Models had a reference to a ResourceResolver (which was properly closed), but I assume that this reference somehow "disabled" the cleaning of the cache on major GCs (as its a WeakHashMap), but tied the collection of these models to the collection of the ResourceResolver objects, which have finalizers registered. And finalizers are only executed under memory pressure. Having this connetion might have led to the situation that the SlingModel objects were not disposed eagerly, but only alongside the finalizers in situation of high memory pressure in a "stop-the-world" situation. I try to get some more examples for that behavior; but I am not sure of the caching of Sling Models as-is is something we should continue to use. This case was quite hard to crack, and I don't know if/how we can avoid such a situation by design. Jörg -- https://cqdump.joerghoh.de
Re: [VOTE] Release Apache Sling Testing Clients 3.0.22
+1 Am Mo., 15. Jan. 2024 um 11:09 Uhr schrieb Andrei Dulvac : > Hi, > > We solved 5 issues in this release: > https://issues.apache.org/jira/projects/SLING/versions/12353709 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2829/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2829 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > - Andrei > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [VOTE] Release Apache Sling Rewriter 1.3.8
+1 Am Mo., 15. Jan. 2024 um 10:58 Uhr schrieb Carsten Ziegeler < cziege...@apache.org>: > Hi, > > We solved 3 issues in this release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354083 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2828/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2828 /tmp/sling-staging > > Please vote to approve this release: > >[ ] +1 Approve the release >[ ] 0 Don't care >[ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe > cziege...@apache.org > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [VOTE] Release Apache Sling JCR Jackrabbit Access Manager version 4.0.2
+1 Am Di., 9. Jan. 2024 um 01:03 Uhr schrieb Eric Norman : > Hi, > > We solved 1 issues in this release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353756=Text > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2827/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2827 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [VOTE] Release Apache Sling GraphQL 0.0.26
+1 Am Mi., 13. Dez. 2023 um 07:15 Uhr schrieb Carsten Ziegeler < cziege...@apache.org>: > Hi, > > We solved 2 issues in this release > https://issues.apache.org/jira/projects/SLING/versions/12353628 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2822/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2822 /tmp/sling-staging > > Please vote to approve this release: > >[ ] +1 Approve the release >[ ] 0 Don't care >[ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe > cziege...@apache.org > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [VOTE] Release Apache Sling Engine 2.15.10
+1 Am Fr., 15. Dez. 2023 um 12:55 Uhr schrieb Carsten Ziegeler < cziege...@apache.org>: > Hi, > > We solved 1 issue in this release > https://issues.apache.org/jira/browse/SLING-12201 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2823/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2823 /tmp/sling-staging > > Please vote to approve this release: > >[ ] +1 Approve the release >[ ] 0 Don't care >[ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe > cziege...@apache.org > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
[RESULT][VOTE] Release Apache Sling Resource Resolver 1.11.4
Hi, The vote has passed with the following result : +1 (binding): Jörg Hoh, Robert Munteanu, Stefan Seifert, Julian Sedding, Carsten Ziegeler, Daniel Klco I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Am Di., 14. Nov. 2023 um 09:38 Uhr schrieb Jörg Hoh : > Hi, > > We solved 1 issue in this > release:https://issues.apache.org/jira/projects/SLING/versions/12353817=Text > > Staging > repository:https://repository.apache.org/content/repositories/orgapachesling-2808/ > > You can use this UNIX script to download the release and verify the > signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > Usage: > sh check_staged_release.sh 2808 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours1 > > > > -- > Cheers, > Jörg Hoh, > > https://cqdump.joerghoh.de > Twitter: @joerghoh > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [VOTE] Release Apache Sling Testing OSGi Mock 3.4.0
+1 Am Fr., 17. Nov. 2023 um 10:06 Uhr schrieb Stefan Seifert : > Hi, > > We solved 5 issues in this release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12353545=Text=12310710 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2810/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2810 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > stefan > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [VOTE] Release Apache Sling Engine 2.15.8
+1 Am Di., 14. Nov. 2023 um 19:50 Uhr schrieb Carsten Ziegeler < cziege...@apache.org>: > Hi, > > We solved 3 issues > > https://issues.apache.org/jira/browse/SLING-12152?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Engine%202.15.8%22 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2809/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2809 /tmp/sling-staging > > Please vote to approve this release: > >[ ] +1 Approve the release >[ ] 0 Don't care >[ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe > cziege...@apache.org > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [VOTE] Release Apache Sling Resource Resolver 1.11.4
My +1 Am Di., 14. Nov. 2023 um 09:38 Uhr schrieb Jörg Hoh : > Hi, > > We solved 1 issue in this > release:https://issues.apache.org/jira/projects/SLING/versions/12353817=Text > > Staging > repository:https://repository.apache.org/content/repositories/orgapachesling-2808/ > > You can use this UNIX script to download the release and verify the > signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > Usage: > sh check_staged_release.sh 2808 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours1 > > > > -- > Cheers, > Jörg Hoh, > > https://cqdump.joerghoh.de > Twitter: @joerghoh > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
[VOTE] Release Apache Sling Resource Resolver 1.11.4
Hi, We solved 1 issue in this release:https://issues.apache.org/jira/projects/SLING/versions/12353817=Text Staging repository:https://repository.apache.org/content/repositories/orgapachesling-2808/ You can use this UNIX script to download the release and verify the signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2808 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours1 -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [VOTE] Release Apache Sling Repoinit JCR 1.1.46
+1 Am Mo., 13. Nov. 2023 um 13:25 Uhr schrieb Julian Sedding < jsedd...@gmail.com>: > Hi, > > We solved 3 issues in this release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12352870=Text > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2807/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2807 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Julian > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [VOTE] Release Apache Sling slingfeature maven plugin 1.8.0
+1 Am Mo., 13. Nov. 2023 um 10:41 Uhr schrieb Carsten Ziegeler < cziege...@apache.org>: > Hi, > > We solved 6 issues in the feature model > https://issues.apache.org/jira/projects/SLING/versions/12353832 > > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2806/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2806 /tmp/sling-staging > > Please vote to approve this release: > >[ ] +1 Approve the release >[ ] 0 Don't care >[ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe > cziege...@apache.org > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [VOTE] Release Apache Sling XSS Protection API 2.4.0
+1 Am Fr., 10. Nov. 2023 um 17:22 Uhr schrieb Robert Munteanu < romb...@apache.org>: > Hi, > > We solved 8 issues in this release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353773=Text > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2804/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2804 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Robert Munteanu > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [VOTE] Release Apache Sling Content Distribution Journal Messages 0.5.8
+1 Am Sa., 11. Nov. 2023 um 22:40 Uhr schrieb Timothee Maret : > Hi, > > We solved 1 issues in this release: > https://issues.apache.org/jira/projects/SLING/versions/12353845 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2805/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2805 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
[RESULT] [VOTE] Release Apache Sling ResourceResolver 1.11.2
Hi, The vote has passed with the following result : +1 (binding): Jörg Hoh, Julian Sedding, Carsten Ziegeler, Daniel Klco I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Jörg Am So., 5. Nov. 2023 um 12:21 Uhr schrieb Jörg Hoh : > Hi, > > We solved 4 issues in this > release:https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353649=Text > > Staging > repository:https://repository.apache.org/content/repositories/orgapachesling-2802/ > > You can use this UNIX script to download the release and verify the > signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > Usage: > sh check_staged_release.sh 2802 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > > > -- > Cheers, > Jörg Hoh, > > https://cqdump.joerghoh.de > Twitter: @joerghoh > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [VOTE] Release Apache Sling Feature Model Analyser 2.0.2, Apache Sling OSGi Feature Maven Plugin 1.7.4
+1 Am Sa., 4. Nov. 2023 um 16:07 Uhr schrieb Julian Sedding : > Hi, > > We solved 9 issues in these releases: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12352907=Text > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353405=Text > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2800/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2800 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Julian > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [VOTE] Release Apache Sling ResourceResolver 1.11.2
my +1 Am So., 5. Nov. 2023 um 12:21 Uhr schrieb Jörg Hoh : > Hi, > > We solved 4 issues in this > release:https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353649=Text > > Staging > repository:https://repository.apache.org/content/repositories/orgapachesling-2802/ > > You can use this UNIX script to download the release and verify the > signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > Usage: > sh check_staged_release.sh 2802 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > > > -- > Cheers, > Jörg Hoh, > > https://cqdump.joerghoh.de > Twitter: @joerghoh > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
[VOTE] Release Apache Sling ResourceResolver 1.11.2
Hi, We solved 4 issues in this release:https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353649=Text Staging repository:https://repository.apache.org/content/repositories/orgapachesling-2802/ You can use this UNIX script to download the release and verify the signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2802 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: Reviewing "abandoned" sling modules
I created https://cwiki.apache.org/confluence/display/SLING/Module+cleanup+discussion+-+2023 for it. Please update this page with your thoughts if we should move a module into attic or not at all. Am So., 15. Okt. 2023 um 09:45 Uhr schrieb Stefan Seifert : > hello jörg. > > thanks for picking up! good idea to create a wiki page. in general, there > is no harm (and no shame) to put a module into attic - we can always bring > it back without effort if interest comes back. > > those libraries have to be kept active in my pov: > > > ./org-apache-sling-testing-logging-mock,Date: 2015 > > this is still in use by the other mock projects and also customer projects > - there was just no need to do any updates since them since it only > contains a default logging conf for unit tests and dependencies in the pom. > > > ./org-apache-sling-bnd-models,Date: 2016 > > this is an important part of the sling models build process and used > everywhere - but there was no need to update it as no new bundle headers > where introduced in the last years. > > stefan > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Reviewing "abandoned" sling modules
Hi, I volunteered to provide a list of modules, which are not touched for quite some time; the thought is that that these modules are also less used, and there is a very low (potentially no) interest in maintaining them anymore. If we have such modules, we should consider to move them into the attic, and officially deprecate them. Right now we have 300+ git repositories in github, and my gut feeling is that the current focus is quite narrow on a few dozens of module, and that we many modules which are not in active maintenance yet (that means, that PRs by dependabot are not checked, etc.). I found a wiki page [1] plus an accompanying ticket SLING-6264 [2] from 2016, in which we already had that discussion, but I think it's time to repeat it. To compile such a list as a starting point for the discussion, I just checked all maven modules for the latest commit in the src/ folder (ignoring all POM updates and any CI/CD settings and badges) and sorted them by their year, just listing the ones which have the last commit before 2020. I used the command [3] to achieve it (works on Linux). The list of modules, in which the latest commit into src/ has been made before 2018 (that means no code change in the last 5 years): ./org-apache-sling-commons-cache-ehcache,Date: 2012 ./org-apache-sling-commons-cache-impl,Date: 2012 ./org-apache-sling-commons-cache-portal,Date: 2012 ./adapter-annotations,Date: 2013 ./org-apache-sling-commons-cache-container-test,Date: 2013 ./org-apache-sling-launchpad-test-fragment,Date: 2013 ./org-apache-sling-auth-xing-api,Date: 2014 ./org-apache-sling-extensions-classloader-leak-detector,Date: 2014 ./org-apache-sling-junit-performance,Date: 2014 ./launchpad-standalone-archetype,Date: 2015 ./launchpad-webapp-archetype,Date: 2015 ./maven-launchpad-plugin,Date: 2015 ./org-apache-sling-hc-junit-bridge,Date: 2015 ./org-apache-sling-jcr-repository-it-resource-versioning,Date: 2015 ./org-apache-sling-launchpad-installer,Date: 2015 ./org-apache-sling-nosql-couchbase-client,Date: 2015 ./org-apache-sling-nosql-launchpad,Date: 2015 ./org-apache-sling-resourceaccesssecurity-it,Date: 2015 ./org-apache-sling-scripting-xproc,Date: 2015 ./org-apache-sling-testing-logging-mock,Date: 2015 ./servlet-archetype,Date: 2015 ./launchpad-debian,Date: 2016 ./org-apache-sling-bnd-models,Date: 2016 ./org-apache-sling-hapi-samplecontent,Date: 2016 ./org-apache-sling-jcr-js-nodetypes,Date: 2016 ./org-apache-sling-nosql-couchbase-resourceprovider,Date: 2016 ./org-apache-sling-nosql-generic,Date: 2016 ./org-apache-sling-nosql-mongodb-resourceprovider,Date: 2016 ./org-apache-sling-resource-editor,Date: 2016 ./org-apache-sling-testing-hamcrest,Date: 2016 ./org-apache-sling-cassandra,Date: 2017 ./org-apache-sling-extensions-webconsolebranding,Date: 2017 ./org-apache-sling-hapi-client,Date: 2017 ./org-apache-sling-hapi,Date: 2017 ./org-apache-sling-hc-it,Date: 2017 ./org-apache-sling-hc-samples,Date: 2017 ./org-apache-sling-installer-factory-model,Date: 2017 ./org-apache-sling-junit-remote,Date: 2017 ./org-apache-sling-launchpad-api,Date: 2017 ./org-apache-sling-launchpad-contrib-testing,Date: 2017 ./org-apache-sling-paxexam-util,Date: 2017 ./org-apache-sling-tail,Date: 2017 ./org-apache-sling-testing-email,Date: 2017 ./taglib-archetype,Date: 2017 Looking at those, a few might be referenced from other sling modules, but many are standalone, and I am not sure if anyone is still using them (xing-auth anyone?) I understand that the mailing list is not necessarily the right place to discuss if an individual module should or should not be moved into an attic. So I will create a page in cwiki (or what's the system we should use today?) and will create a table (just like [1]) and there we can annotate each bundle if it's needed by a different Sling module (which is either actively used/developed or in active maintenance), or if someone is volunteering to maintain it. [1] https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=65873121 [2] https://issues.apache.org/jira/browse/SLING-6264 [3] it can probably be done better, but worked for me: find ./* -maxdepth 0 -type d | while read a; do (cd $a; test -d src && echo -n "$a," &&git log --date=format:%Y -1 -- src -- | grep Date); done | grep 201 | sort -t ' ' -k 2 -n -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de
Re: [VOTE] Release Apache Sling JCR Maintenance v1.1.0, Apache Sling JCR Oak Server v1.4.0
+1 Am Di., 10. Okt. 2023 um 01:15 Uhr schrieb Eric Norman : > Hi, > > These releases are needed to be compatible with the latest production > version of oak (1.56.0 or later). > > We solved 2 issues in the JCR Maintenance release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12350102=Text > > We solved 5 issues in the JCR Oak Server release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12351767=Text > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2795/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2795 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [VOTE] Release Apache Sling Commons MIME version 2.2.4
+1 Am Fr., 6. Okt. 2023 um 06:52 Uhr schrieb Carsten Ziegeler < cziege...@apache.org>: > +1 > > Carsten > > On 05.10.2023 20:28, Daniel Klco wrote: > > Hi, > > > > We solved 2 issues in this release: > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12346287=Text > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2792/ > > > > You can use this UNIX script to download the release and verify the > signatures: > > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > > > Usage: > > sh check_staged_release.sh 2792 /tmp/sling-staging > > > > Please vote to approve this release: > > > >[ ] +1 Approve the release > >[ ] 0 Don't care > >[ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > -- > Carsten Ziegeler > Adobe > cziege...@apache.org > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [VOTE] Release Apache Sling Servlets Get 2.2.0, Post 2.6.0, Resolver 2.10.0
+1 Am Do., 5. Okt. 2023 um 22:07 Uhr schrieb Daniel Klco : > +1 > > On Thu, Oct 5, 2023 at 7:19 AM Carsten Ziegeler > wrote: > > > > Hi, > > > > We solved 3 issues for servlets resolver 2.10.0 > > https://issues.apache.org/jira/projects/SLING/versions/12353474 > > > > We solved 4 issues for servlets get 2.2.0 > > https://issues.apache.org/jira/projects/SLING/versions/12352682 > > > > We solved 3 issues for servlets post 2.10.0 > > https://issues.apache.org/jira/projects/SLING/versions/12352478 > > > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2791/ > > > > You can use this UNIX script to download the release and verify the > > signatures: > > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > Usage: > > sh check_staged_release.sh 2791 /tmp/sling-staging > > > > Please vote to approve this release: > > > >[ ] +1 Approve the release > >[ ] 0 Don't care > >[ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > Regards > > Carsten > > -- > > Carsten Ziegeler > > Adobe > > cziege...@apache.org > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [VOTE] Release Apache Sling Auth Core 1.7.0
+1 Am Mi., 4. Okt. 2023 um 07:48 Uhr schrieb Carsten Ziegeler < cziege...@apache.org>: > Hi, > > We solved 1 issue in this release: > https://issues.apache.org/jira/browse/SLING-12059 > > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2790/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2790 /tmp/sling-staging > > Please vote to approve this release: > >[ ] +1 Approve the release >[ ] 0 Don't care >[ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe > cziege...@apache.org > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [VOTE] Release Apache Sling JCR Base 3.2.0
+1 Am Mo., 2. Okt. 2023 um 07:10 Uhr schrieb Carsten Ziegeler < cziege...@apache.org>: > Hi, > > We solved 2 issues in this release: > https://issues.apache.org/jira/projects/SLING/versions/12353098 > > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2789/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2789 /tmp/sling-staging > > Please vote to approve this release: > >[ ] +1 Approve the release >[ ] 0 Don't care >[ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe > cziege...@apache.org > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [VOTE] Release Apache Sling org.apache.sling.distribution.journal.messages 0.5.4, org.apache.sling.distribution.journal 0.2.0
+1 Am Fr., 22. Sept. 2023 um 14:38 Uhr schrieb Christian Schneider < ch...@die-schneider.net>: > Release Notes - Sling - Version Content Distribution Journal Messages 0.5.4 > ** Improvement > * [SLING-11255] - Update to parent bundle 47 > * [SLING-11914] - Accept initial offset via OffsetMessage > > https://issues.apache.org/jira/projects/SLING/versions/12351666 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2785 > > Release Notes - Sling - Version Content Distribution Journal Core 0.2.0 > ** Bug > * [SLING-9321] - Update to declarative services 1.4 > * [SLING-9403] - Filter status messages by subscriber agent > * [SLING-11560] - Vault error when importing a node with the same name > and UUID as a pre-existing non-sibling node > * [SLING-11809] - Disable "overwritePrimaryTypesOfFolders" in the > distribution journal > * [SLING-11990] - Fix TEST distribution requests > ** Improvement > * [SLING-11365] - Improve the exception handling of the > DistributionPublisher.execute > * [SLING-11607] - Emit metric on the time that a package spends in the > journal > * [SLING-11914] - Accept initial offset via OffsetMessage > * [SLING-11986] - Bundle relies on Guava (15) > > https://issues.apache.org/jira/projects/SLING/versions/12351663 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2786/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh [YOUR REPOSITORY ID] /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Christian Schneider > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [VOTE] Release Feature Model Content Extension 1.0.12
+1 Am Fr., 22. Sept. 2023 um 15:39 Uhr schrieb Robert Munteanu < romb...@apache.org>: > Hi, > > We solved 7 issues in this release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12350251=Text > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2787/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2787 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Robert Munteanu > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [VOTE] Release Apache Sling GraphQL Core 0.0.24
OK, after updating the KEYS it works here as well. +1 from me Am Di., 12. Sept. 2023 um 10:31 Uhr schrieb Stefan Seifert : > +1 > > gpg validation is fine on my machine (updated with latest [1] some weeks > ago) > > please note that the unit tests are failing on *windows* (also on > jenkins). this should be fixed for upcoming releases. > > stefan > > [1] https://downloads.apache.org/sling/KEYS > > > -Original Message- > > From: Andreas Schaefer > > Sent: Monday, September 11, 2023 8:24 PM > > To: dev > > Subject: [VOTE] Release Apache Sling GraphQL Core 0.0.24 > > > > Hi, > > > > We solved 1 issues in this release: > > https://issues.apache.org/jira/browse/SLING-12014 > > > > There are still some outstanding issues: > > https://issues.apache.org/jira/browse/SLING-10901 > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2781 > > > > You can use this UNIX script to download the release and verify the > > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling- > > release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > Usage: > > sh check_staged_release.sh 2781 /tmp/sling-staging > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > Cheers - Andy > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [VOTE] Release Apache Sling GraphQL Core 0.0.24
Andy, I get gpg: BAD warnings while checking the digests. Your GPG key seems to be expired: joerg@joergM5 ~ % gpg --list-keys 749391D163EFCDEF pub rsa4096 2019-04-22 [SC] [expired: 2023-04-22] 49ECC3FCFD4CDF49F308DEC2749391D163EFCDEF uid [ expired] Andreas Schaefer (CODE SIGNING KEY) < andy...@apache.org> Am Mo., 11. Sept. 2023 um 20:24 Uhr schrieb Andreas Schaefer : > Hi, > > We solved 1 issues in this release: > https://issues.apache.org/jira/browse/SLING-12014 > > There are still some outstanding issues: > https://issues.apache.org/jira/browse/SLING-10901 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2781 > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2781 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Cheers - Andy -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Overhead in 404 handling
Hi, The handling of 404s in Sling can be quite resource-intense, especially if a custom error handler is provided, which renders a full-blown page. This can lead to the situation, that the 404 handling is as complex and resource-intense as handling a normal resource. This comes with these 2 aspects: * In such a situation a 404 often takes the same amount to handle than to render a proper HTML result. So creating a lot of 404s is an easy way for overload. * the useragent (browser) often does not look at the body of a 404 response, especially if the requested content type is not HTML. So for example if the browser requests a JS file, but gets a 404 statuscode, it ignores the (costly rendered) 404 page. In this case I think that an empty response body has the same effect. For these reasons I am thinking about creating a short-cut in the request error handling (opt-in), which will prevent the default error handling from being started if the user-agent does not request a HTML resource; instead just the status code plus a short status in the response body will be sent. For HTML requests still the regular error handling is executed. In a first POC this would all be hardcoded, but even in a releaseable version I don't think it makes sense to distinguish between more than "HTML requests" and "everything else". Also the response body can be hardcoded in these "short-cut" version. WDYT? -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
[RESULT] [VOTE] Release Apache Sling Servlets Resolver 2.9.14
Hi, The vote has passed with the following result : +1 (binding): Jörg Hoh, Carsten Ziegeler, Eric Norman +1 (non binding): I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Jörg Am Do., 3. Aug. 2023 um 12:47 Uhr schrieb Jörg Hoh : > Hi, > > We solved 6 issues in this > release:https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353299=Text > > Staging > repository:https://repository.apache.org/content/repositories/orgapachesling-2777/ > > You can use this UNIX script to download the release and verify the > signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > Usage: > sh check_staged_release.sh 2777 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > > > -- > Cheers, > Jörg Hoh, > > https://cqdump.joerghoh.de > Twitter: @joerghoh > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [VOTE] Release Apache Sling Servlets Resolver 2.9.14
my +1 Am Do., 3. Aug. 2023 um 12:47 Uhr schrieb Jörg Hoh : > Hi, > > We solved 6 issues in this > release:https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353299=Text > > Staging > repository:https://repository.apache.org/content/repositories/orgapachesling-2777/ > > You can use this UNIX script to download the release and verify the > signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > Usage: > sh check_staged_release.sh 2777 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > > > -- > Cheers, > Jörg Hoh, > > https://cqdump.joerghoh.de > Twitter: @joerghoh > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
[VOTE] Release Apache Sling Servlets Resolver 2.9.14
Hi, We solved 6 issues in this release:https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353299=Text Staging repository:https://repository.apache.org/content/repositories/orgapachesling-2777/ You can use this UNIX script to download the release and verify the signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2777 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [VOTE] Release Apache Sling Tracer 1.0.8
+1 Am Do., 3. Aug. 2023 um 06:55 Uhr schrieb Carsten Ziegeler < cziege...@apache.org>: > Hi, > > We solved 5 issuse in this release > > https://issues.apache.org/jira/browse/SLING-11980?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Log%20Tracer%201.0.8%22 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2776/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2776 /tmp/sling-staging > > Please vote to approve this release: > >[ ] +1 Approve the release >[ ] 0 Don't care >[ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe > cziege...@apache.org > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [VOTE] Release Apache Sling GraphQL Core 0.0.22
+1 Am Do., 20. Juli 2023 um 09:49 Uhr schrieb Radu Cotescu : > Hi, > > We solved 1 issue in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12353082 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2772/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2772 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Radu Cotescu > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Problems when updating to later bundle-parents (50+)
Hi, I just found that the pax exam tests can break when you update to bundle-parent 50 or higher. It seems that the minimal version of java 11 is not handled properly. See https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/39 I created [1] for it. [1] https://issues.apache.org/jira/browse/SLING-11981 -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: SLING-11974: Spec Compliance vs. Backward compatibility
Should we document that in this case we are not spec compliant for backwards compatibility reasons? Am Do., 20. Juli 2023 um 12:53 Uhr schrieb Carsten Ziegeler < cziege...@apache.org>: > I think there is no one solution fits all here. As always it depends. > > In general we should try to be spec compliant - unless there is a good > reason not to. There could be different reasons. > > In this particular case, imho there is a good reason to not be > compliant. We have a huge user base and the non spec compliant behaviour > is in there for many many years. There is a chance that some of our > users rely on this behaviour. If we change it, we break our users. Which > actually happened in this case. > > In addition, in this case if users are trying out our non spec compliant > method they will immediately see that it is not compliant during > development/testing. > > Regards > Carsten > > On 20.07.2023 12:28, Konrad Windszus wrote: > > Hi, > > Carsten just reverted the fix from > https://issues.apache.org/jira/browse/SLING-11825 in > https://issues.apache.org/jira/browse/SLING-11974. > > The fix is correct according to the Servlet Spec, but it seems some > customer rely on Sling behaving not spec compliant here. > > The question is what weighs more: > > 1) Spec compliance to make it easier for most new/existing users as > otherwise behaviour differs from Javadoc and underlying Spec. > > 2) Backwards compatibility for those users who rely on this spec > incompatibility. > > > > > > In my opinion I would clearly go for 1) but I would like to hear other > opinions. > > > > Thanks, > > Konrad > > -- > Carsten Ziegeler > Adobe > cziege...@apache.org > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [VOTE] Release Apache Sling Auth Core 1.6.2
+1 Am Do., 20. Juli 2023 um 07:19 Uhr schrieb Carsten Ziegeler < cziege...@apache.org>: > Hi, > > We solved 1 issue in this release: > https://issues.apache.org/jira/browse/SLING-11867 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2771 > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2771 /tmp/sling-staging > > Please vote to approve this release: > >[ ] +1 Approve the release >[ ] 0 Don't care >[ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe > cziege...@apache.org > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [VOTE] Release Apache Sling Commons Johnzon Wrapper Library 1.2.16
+1 Am Mi., 19. Juli 2023 um 18:08 Uhr schrieb Robert Munteanu < romb...@apache.org>: > Hi, > > We solved 1 issue in this release: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12351880=Text > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2770 > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2770 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Thanks, > Robert > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
[RESULT][VOTE] Release Apache Sling Models Jackson Exporter 1.1.4
Hi, The vote has passed with the following result : +1 (binding): Jörg Hoh, Robert Munteanu, Daniel Klco, Stefan Seifert +1 (non binding): - I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Am Do., 13. Juli 2023 um 11:48 Uhr schrieb Jörg Hoh : > Hi, > > We solved 2 issues in this > release:https://issues.apache.org/jira/projects/SLING/versions/12351062 > > Staging > repository:https://repository.apache.org/content/repositories/orgapachesling-2767/ > > You can use this UNIX script to download the release and verify the > signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > Usage: > sh check_staged_release.sh 2767 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > > > -- > Cheers, > Jörg Hoh, > > https://cqdump.joerghoh.de > Twitter: @joerghoh > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [VOTE] Release Project Archetype 1.0.12
+1 Am Do., 13. Juli 2023 um 13:44 Uhr schrieb Robert Munteanu < romb...@apache.org>: > Hi, > > We solved 1 issue in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12351459 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2768/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2768 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Robert Munteanu > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Rewriter: resource structure forcing a dependency on OSGI services
Hi, I want to bring up a topic, which has caused me headaches for quite some time. We have a rewriter configuration, which is stored within in the Sling Repository, and which is picked up any request. But we often see messages like this in the logs: org.apache.sling.engine.impl.SlingRequestProcessorImpl service: Uncaught SlingException java.io.IOException: Unable to get component of class 'interface org.apache.sling.rewriter.Transformer' with type 'externallinks'. This is normally caused by the requested rewriter not being present and should vanish as soon as that service is present. But I also have seen cases, that the instance was not getting up because of this; *at least that's my impression, I have not closely analyzed it. (I hoped that this problem of instances not starting up properly was fixed with SSLING-11317, but I spotted this behavior afterwards as well.) The problem is the dependency of a repository structure to an OSGI service, which we cannot model with the means of OSGI (at least I am not aware of that); it will be always a polling mechanism to see if the service is present, and fail with an exception if not. Are you aware of a way to change this dependency and make it more OSGI-aware, and not starting the relevant parts of the sling engine if the requested rewriter is not present? Jörg -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [VOTE] Release Apache Sling Models Jackson Exporter 1.1.4
my +1 Am Do., 13. Juli 2023 um 11:48 Uhr schrieb Jörg Hoh : > Hi, > > We solved 2 issues in this > release:https://issues.apache.org/jira/projects/SLING/versions/12351062 > > Staging > repository:https://repository.apache.org/content/repositories/orgapachesling-2767/ > > You can use this UNIX script to download the release and verify the > signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > Usage: > sh check_staged_release.sh 2767 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > > > -- > Cheers, > Jörg Hoh, > > https://cqdump.joerghoh.de > Twitter: @joerghoh > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
[VOTE] Release Apache Sling Models Jackson Exporter 1.1.4
Hi, We solved 2 issues in this release:https://issues.apache.org/jira/projects/SLING/versions/12351062 Staging repository:https://repository.apache.org/content/repositories/orgapachesling-2767/ You can use this UNIX script to download the release and verify the signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2767 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [VOTE] Release Apache Sling Feature Launcher Maven Plugin 0.1.6
+1 Am Fr., 7. Juli 2023 um 12:56 Uhr schrieb Robert Munteanu < romb...@apache.org>: > Hi, > > We solved 1 issue in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12352559 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2763/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2763 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Robert Munteanu > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [VOTE] Release Apache Sling OSGi Feature Maven Plugin 1.7.2
+1 Am Fr., 7. Juli 2023 um 12:53 Uhr schrieb Robert Munteanu < romb...@apache.org>: > Hi, > > We solved 2 issues in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12353301 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2762/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2762 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Robert Munteanu > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: Disabling dependabot for the whiteboard
+1 Robert Munteanu schrieb am Do. 6. Juli 2023 um 17:05: > Hi, > > Dependabot keeps creating PRs for the whiteboard module [1]. No one is > addressing them, and they're just lingering there. > > I think that this makes it harder to find actually useful PRs and that > it creates Jenkins checks for not good reason. > > Additionally, the Jenkins checks are not really useful since they use a > outdated reactor POM which does not contain all projects. > > Given this, I would disable dependabot checks outright for this repo. > > Thoughts? > > Thanks, > Robert > > [1]: https://github.com/apache/sling-whiteboard/pulls/app%2Fdependabot > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: [VOTE] Release Apache Sling XSS Protection API 2.3.8
+1 Jörg Am Fr., 30. Juni 2023 um 13:44 Uhr schrieb Robert Munteanu < romb...@apache.org>: > Hi, > > We solved 1 issue in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12353104 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2758/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2758 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Robert Munteanu > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
Re: Sling Model Exporter: Prevent serializing of a ResourceResolver
Hi Radu,
In general I agree, that it is too easy to leak implementation details
here. Maybe I can use these mixins in the first way to write a lot of WARN
messages in such a case, plus the option not to serialize them (by default
turned off, so serializing them nevertheless).
But my priority is not the prevention of these leaks, but rather mitigating
the.risk of breaking the serialization process. In that case I did not
experience issues with serializing the list of resources.
Jörg
Am Di., 27. Juni 2023 um 19:12 Uhr schrieb Radu Cotescu :
> Hi Jörg,
>
> I think you would have the same problem with that model given the other
> property, namely that list of resources.
>
> Unfortunately I don’t see an easy way out other than documenting this
> aspect and advising developers to avoid exposing implementation details.
> Whatever you’d change in the implementation to prevent this, it would be at
> least a behaviour change, potentially causing regressions similar to
> https://xkcd.com/1172/.
>
> Regards,
> Radu
>
> On Tue, 27 Jun 2023 at 18:35, Jörg Hoh
> wrote:
>
> > HI Stefan,
> >
> > I agree, but:
> >
> > I don't have control over the code, which causes the ResourceResolver to
> be
> > serialized. Also I cannot enforce, that such code is NOT written and
> > deployed (there are too many ways to make it wrong). Also because it
> > currently works, I would have to counter the "but it worked yesterday,
> and
> > I did not change anything since then" argument, in case it fails with an
> > exception like above.
> >
> > So I have to find another way to prevent the ResourceResolver from being
> > serialized ...
> >
> > Jörg
> >
> >
> >
> > Am Di., 27. Juni 2023 um 13:38 Uhr schrieb Stefan Seifert
> > :
> >
> > > well, using lombok with such a result is a bad idea. there should not
> be
> > a
> > > getResolver() method, this is an implementation detail and no getter
> > should
> > > be provided for it.
> > >
> > > so to put it another way: good that the serialization fails, so you can
> > > fix the calls to not add a getResolver() method!
> > >
> > > stefan
> > >
> > > p.s. i'm not a fan of lombok in general and have no experience with it,
> > > but I assume it can be configured to not expose the resolver.
> > >
> > > > -Original Message-
> > > > From: Jörg Hoh
> > > > Sent: Tuesday, June 27, 2023 1:28 PM
> > > > To: Sling Developers List
> > > > Subject: Sling Model Exporter: Prevent serializing of a
> > ResourceResolver
> > > >
> > > > Hi,
> > > >
> > > > Assuming this Sling Model (using Lombok's @Getter annotation)
> > > >
> > > > @Getter
> > > > @Model(
> > > > adaptables = { SlingHttpServletRequest.class },
> > > > adapters = { MyModel.class, ComponentExporter.class },
> > > > resourceType = MyModel.RESOURCE_TYPE) @Exporter(
> > > > name = ExporterConstants.SLING_MODEL_EXPORTER_NAME,
> > > > extensions = ExporterConstants.SLING_MODEL_EXTENSION)
> > > > public class MyModel implements ComponentExporter {
> > > >
> > > > static final String RESOURCE_TYPE =
> "myapp/components/mymodel";
> > > >
> > > > @Inject
> > > > private ResourceResolver resolver;
> > > >
> > > > @ChildResource
> > > > private List items;
> > > >
> > > > }
> > > >
> > > > When it this model is serialized via SlingModelExporter / Jackson,
> the
> > > > resolver field is also exported via the created getResolver())
> method.
> > > >
> > > > But serializing that does not always work:
> > > >
> > > > org.apache.sling.models.factory.ExportException:
> > > > com.fasterxml.jackson.databind.exc.InvalidDefinitionException: No
> > > > serializer found for class
> > > > com.day.cq.wcm.core.impl.policies.ContentPolicyManagerImpl and no
> > > > properties discovered to create BeanSerializer (to avoid exception,
> > > > disable
> > > > SerializationFeature.FAIL_ON_EMPTY_BEANS) (through reference chain:
> > > > com.myapp.PageImpl[":items"]> [...] > com.myapp.MyModel["resolver"]
> > > >
> > >org.apache.sling.resourceresolver.impl.ResourceResolverImpl["propertyM
Re: Sling Model Exporter: Prevent serializing of a ResourceResolver
Hm, I think that Jackson Mixins [1] could work here.
[1] https://github.com/FasterXML/jackson-docs/wiki/JacksonMixInAnnotations
Am Di., 27. Juni 2023 um 13:28 Uhr schrieb Jörg Hoh :
> Hi,
>
> Assuming this Sling Model (using Lombok's @Getter annotation)
>
> @Getter
> @Model(
> adaptables = { SlingHttpServletRequest.class },
> adapters = { MyModel.class, ComponentExporter.class },
> resourceType = MyModel.RESOURCE_TYPE)
> @Exporter(
> name = ExporterConstants.SLING_MODEL_EXPORTER_NAME,
> extensions = ExporterConstants.SLING_MODEL_EXTENSION)
> public class MyModel implements ComponentExporter {
>
> static final String RESOURCE_TYPE = "myapp/components/mymodel";
>
> @Inject
> private ResourceResolver resolver;
>
> @ChildResource
> private List items;
>
> }
>
> When it this model is serialized via SlingModelExporter / Jackson, the
> resolver field is also exported via the created getResolver()) method.
>
> But serializing that does not always work:
>
> org.apache.sling.models.factory.ExportException:
> com.fasterxml.jackson.databind.exc.InvalidDefinitionException: No
> serializer found for class
> com.day.cq.wcm.core.impl.policies.ContentPolicyManagerImpl and no
> properties discovered to create BeanSerializer (to avoid exception, disable
> SerializationFeature.FAIL_ON_EMPTY_BEANS) (through reference chain:
> com.myapp.PageImpl[":items"]> [...] > com.myapp.MyModel["resolver"]
> >org.apache.sling.resourceresolver.impl.ResourceResolverImpl["propertyMap"]
> >java.util.HashMap["com.day.cq.wcm.core.impl.policies.ContentPolicyAdapterFactory.ContentPolicy"])
> at
> org.apache.sling.models.jacksonexporter.impl.JacksonExporter.export(JacksonExporter.java:138)
> [org.apache.sling.models.jacksonexporter:1.1.2]
> at
> org.apache.sling.models.impl.ModelAdapterFactory.exportModel(ModelAdapterFactory.java:1333)
> [org.apache.sling.models.impl:1.5.4]
>
>
> I don't want to check each class I want to add to the propertyMap if it
> can be serialized or not; and a more serious problem is that serializing
> the resourceResolver and it's properyMap can leak a lot of information,
> which should be not get public.
>
> Do you see a way to prevent serialization of the ResourceResolver (and
> potentially other types as well) without touching the model classes?
>
> Jörg
>
> --
> Cheers,
> Jörg Hoh,
>
> https://cqdump.joerghoh.de
> Twitter: @joerghoh
>
--
Cheers,
Jörg Hoh,
https://cqdump.joerghoh.de
Twitter: @joerghoh
Re: Sling Model Exporter: Prevent serializing of a ResourceResolver
HI Stefan,
I agree, but:
I don't have control over the code, which causes the ResourceResolver to be
serialized. Also I cannot enforce, that such code is NOT written and
deployed (there are too many ways to make it wrong). Also because it
currently works, I would have to counter the "but it worked yesterday, and
I did not change anything since then" argument, in case it fails with an
exception like above.
So I have to find another way to prevent the ResourceResolver from being
serialized ...
Jörg
Am Di., 27. Juni 2023 um 13:38 Uhr schrieb Stefan Seifert
:
> well, using lombok with such a result is a bad idea. there should not be a
> getResolver() method, this is an implementation detail and no getter should
> be provided for it.
>
> so to put it another way: good that the serialization fails, so you can
> fix the calls to not add a getResolver() method!
>
> stefan
>
> p.s. i'm not a fan of lombok in general and have no experience with it,
> but I assume it can be configured to not expose the resolver.
>
> > -Original Message-
> > From: Jörg Hoh
> > Sent: Tuesday, June 27, 2023 1:28 PM
> > To: Sling Developers List
> > Subject: Sling Model Exporter: Prevent serializing of a ResourceResolver
> >
> > Hi,
> >
> > Assuming this Sling Model (using Lombok's @Getter annotation)
> >
> > @Getter
> > @Model(
> > adaptables = { SlingHttpServletRequest.class },
> > adapters = { MyModel.class, ComponentExporter.class },
> > resourceType = MyModel.RESOURCE_TYPE) @Exporter(
> > name = ExporterConstants.SLING_MODEL_EXPORTER_NAME,
> > extensions = ExporterConstants.SLING_MODEL_EXTENSION)
> > public class MyModel implements ComponentExporter {
> >
> > static final String RESOURCE_TYPE = "myapp/components/mymodel";
> >
> > @Inject
> > private ResourceResolver resolver;
> >
> > @ChildResource
> > private List items;
> >
> > }
> >
> > When it this model is serialized via SlingModelExporter / Jackson, the
> > resolver field is also exported via the created getResolver()) method.
> >
> > But serializing that does not always work:
> >
> > org.apache.sling.models.factory.ExportException:
> > com.fasterxml.jackson.databind.exc.InvalidDefinitionException: No
> > serializer found for class
> > com.day.cq.wcm.core.impl.policies.ContentPolicyManagerImpl and no
> > properties discovered to create BeanSerializer (to avoid exception,
> > disable
> > SerializationFeature.FAIL_ON_EMPTY_BEANS) (through reference chain:
> > com.myapp.PageImpl[":items"]> [...] > com.myapp.MyModel["resolver"]
> > >org.apache.sling.resourceresolver.impl.ResourceResolverImpl["propertyMa
> > >p"]
> > >java.util.HashMap["com.day.cq.wcm.core.impl.policies.ContentPolicyAdapt
> > >erFactory.ContentPolicy"])
> > at
> >
> org.apache.sling.models.jacksonexporter.impl.JacksonExporter.export(Jackso
> > nExporter.java:138)
> > [org.apache.sling.models.jacksonexporter:1.1.2]
> > at
> >
> org.apache.sling.models.impl.ModelAdapterFactory.exportModel(ModelAdapterF
> > actory.java:1333)
> > [org.apache.sling.models.impl:1.5.4]
> >
> >
> > I don't want to check each class I want to add to the propertyMap if it
> > can be serialized or not; and a more serious problem is that serializing
> > the resourceResolver and it's properyMap can leak a lot of information,
> > which should be not get public.
> >
> > Do you see a way to prevent serialization of the ResourceResolver (and
> > potentially other types as well) without touching the model classes?
> >
> > Jörg
> >
> > --
> > Cheers,
> > Jörg Hoh,
> >
> > https://cqdump.joerghoh.de
> > Twitter: @joerghoh
>
--
Cheers,
Jörg Hoh,
https://cqdump.joerghoh.de
Twitter: @joerghoh
Sling Model Exporter: Prevent serializing of a ResourceResolver
Hi,
Assuming this Sling Model (using Lombok's @Getter annotation)
@Getter
@Model(
adaptables = { SlingHttpServletRequest.class },
adapters = { MyModel.class, ComponentExporter.class },
resourceType = MyModel.RESOURCE_TYPE)
@Exporter(
name = ExporterConstants.SLING_MODEL_EXPORTER_NAME,
extensions = ExporterConstants.SLING_MODEL_EXTENSION)
public class MyModel implements ComponentExporter {
static final String RESOURCE_TYPE = "myapp/components/mymodel";
@Inject
private ResourceResolver resolver;
@ChildResource
private List items;
}
When it this model is serialized via SlingModelExporter / Jackson, the
resolver field is also exported via the created getResolver()) method.
But serializing that does not always work:
org.apache.sling.models.factory.ExportException:
com.fasterxml.jackson.databind.exc.InvalidDefinitionException: No
serializer found for class
com.day.cq.wcm.core.impl.policies.ContentPolicyManagerImpl and no
properties discovered to create BeanSerializer (to avoid exception, disable
SerializationFeature.FAIL_ON_EMPTY_BEANS) (through reference chain:
com.myapp.PageImpl[":items"]> [...] > com.myapp.MyModel["resolver"]
>org.apache.sling.resourceresolver.impl.ResourceResolverImpl["propertyMap"]
>java.util.HashMap["com.day.cq.wcm.core.impl.policies.ContentPolicyAdapterFactory.ContentPolicy"])
at
org.apache.sling.models.jacksonexporter.impl.JacksonExporter.export(JacksonExporter.java:138)
[org.apache.sling.models.jacksonexporter:1.1.2]
at
org.apache.sling.models.impl.ModelAdapterFactory.exportModel(ModelAdapterFactory.java:1333)
[org.apache.sling.models.impl:1.5.4]
I don't want to check each class I want to add to the propertyMap if it can
be serialized or not; and a more serious problem is that serializing the
resourceResolver and it's properyMap can leak a lot of information, which
should be not get public.
Do you see a way to prevent serialization of the ResourceResolver (and
potentially other types as well) without touching the model classes?
Jörg
--
Cheers,
Jörg Hoh,
https://cqdump.joerghoh.de
Twitter: @joerghoh
Re: [VOTE] Release Apache Sling Engine 2.15.2
+1 Am Fr., 9. Juni 2023 um 09:42 Uhr schrieb Robert Munteanu < romb...@apache.org>: > Hi, > > We solved 2 issues in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12353274 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2756/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2756 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Robert Munteanu > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
[RESULT][VOTE] Release Servlets Resolver 2.9.12
Hi, The vote has passed with the following result : +1 (binding): Jörg Hoh, Robert Munteanu, Angela Schreiber +1 (non binding): - I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Jörg Am Do., 1. Juni 2023 um 11:38 Uhr schrieb Jörg Hoh : > Hi, > > We solved 3 issues in this > release:https://issues.apache.org/jira/projects/SLING/versions/12352611 > > Staging > repository:https://repository.apache.org/content/repositories/orgapachesling-2754 > > You can use this UNIX script to download the release and verify the > signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > Usage: > sh check_staged_release.sh 2754 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > > > -- > Cheers, > Jörg Hoh, > > https://cqdump.joerghoh.de > Twitter: @joerghoh > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
