[jira] [Assigned] (SLING-12351) Create a default implementation for generating the analyser-metadata extension

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-12351:
---

Assignee: Robert Munteanu

> Create a default implementation for generating the analyser-metadata extension
> --
>
> Key: SLING-12351
> URL: https://issues.apache.org/jira/browse/SLING-12351
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model Analyser
>    Reporter: Robert Munteanu
>    Assignee: Robert Munteanu
>Priority: Major
> Fix For: Feature Model Analyser 2.0.4
>
>
> The feature model analysers contains and use the 
> {{AnalyserMetaDataExtension}} - 
> https://github.com/apache/sling-org-apache-sling-feature-analyser/blob/c8518ebd7c8fa245781ad8062f2c2d6b52174345/src/main/java/org/apache/sling/feature/analyser/extensions/AnalyserMetaDataExtension.java
>  .
> This class is read and used (error reporting, cached manifests) but there is 
> currently no automated way of generating the metadata.
> We should provide a default implementation that simplifies the metadata 
> generation. The same implementation should also support generating the 
> framework capabilities metadata as discussed in SLING-10288 .



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (SLING-12351) Create a default implementation for generating the analyser-metadata extension

[Robert Munteanu (Jira)]

Robert Munteanu created SLING-12351:
---

 Summary: Create a default implementation for generating the 
analyser-metadata extension
 Key: SLING-12351
 URL: https://issues.apache.org/jira/browse/SLING-12351
 Project: Sling
  Issue Type: Improvement
  Components: Feature Model Analyser
Reporter: Robert Munteanu
 Fix For: Feature Model Analyser 2.0.4


The feature model analysers contains and use the {{AnalyserMetaDataExtension}} 
- 
https://github.com/apache/sling-org-apache-sling-feature-analyser/blob/c8518ebd7c8fa245781ad8062f2c2d6b52174345/src/main/java/org/apache/sling/feature/analyser/extensions/AnalyserMetaDataExtension.java
 .

This class is read and used (error reporting, cached manifests) but there is 
currently no automated way of generating the metadata.

We should provide a default implementation that simplifies the metadata 
generation. The same implementation should also support generating the 
framework capabilities metadata as discussed in SLING-10288 .



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-10288) FelixFrameworkScanner sets framework properties always for current Java version

[Robert Munteanu (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17852795#comment-17852795
 ] 

Robert Munteanu commented on SLING-10288:
-

I came to the conclusion that there is no way of generating the analyser 
metadata and raised SLING-12351 for it.

> FelixFrameworkScanner sets framework properties always for current Java 
> version
> ---
>
> Key: SLING-10288
> URL: https://issues.apache.org/jira/browse/SLING-10288
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model Analyser
>Reporter: Konrad Windszus
>Assignee: Robert Munteanu
>Priority: Major
>
> Sometimes the analyser is executed with a different java version than the one 
> executing the actual OSGi container. There should be a possibility to 
> explicitly set a Java version.
> Currently the framework properties are gathered in a dedicated java process 
> executing 
> https://github.com/apache/sling-org-apache-sling-feature-analyser/blob/730b7d3297ab9f17f484e7b557e4ec47c3d9b3e9/src/main/java/org/apache/sling/feature/scanner/impl/fwk/FrameworkPropertiesGatherer.java#L41.
>  That new process always takes the current  {{java.home}} which therefore 
> returns the wrong properties (i.e. the ones for the current  java version 
> instead of the one used to execute the framework).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-10288) FelixFrameworkScanner sets framework properties always for current Java version

[Robert Munteanu (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17852508#comment-17852508
 ] 

Robert Munteanu commented on SLING-10288:
-

I am going to give this a shot. I would like to start some experiments on the 
Sling Starter, but I am not sure how to generate a feature model that includes 
the analyser-metadata. I was looking into the {{apis-jar}} mojo but that does 
not look to be the case.

[~kwin] / [~kpauls] - any hints on how to generate a feature model that 
includes the analyser-metadata section?

> FelixFrameworkScanner sets framework properties always for current Java 
> version
> ---
>
> Key: SLING-10288
> URL: https://issues.apache.org/jira/browse/SLING-10288
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model Analyser
>Reporter: Konrad Windszus
>Assignee: Robert Munteanu
>Priority: Major
>
> Sometimes the analyser is executed with a different java version than the one 
> executing the actual OSGi container. There should be a possibility to 
> explicitly set a Java version.
> Currently the framework properties are gathered in a dedicated java process 
> executing 
> https://github.com/apache/sling-org-apache-sling-feature-analyser/blob/730b7d3297ab9f17f484e7b557e4ec47c3d9b3e9/src/main/java/org/apache/sling/feature/scanner/impl/fwk/FrameworkPropertiesGatherer.java#L41.
>  That new process always takes the current  {{java.home}} which therefore 
> returns the wrong properties (i.e. the ones for the current  java version 
> instead of the one used to execute the framework).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (SLING-10288) FelixFrameworkScanner sets framework properties always for current Java version

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-10288:
---

Assignee: Robert Munteanu

> FelixFrameworkScanner sets framework properties always for current Java 
> version
> ---
>
> Key: SLING-10288
> URL: https://issues.apache.org/jira/browse/SLING-10288
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model Analyser
>Reporter: Konrad Windszus
>Assignee: Robert Munteanu
>Priority: Major
>
> Sometimes the analyser is executed with a different java version than the one 
> executing the actual OSGi container. There should be a possibility to 
> explicitly set a Java version.
> Currently the framework properties are gathered in a dedicated java process 
> executing 
> https://github.com/apache/sling-org-apache-sling-feature-analyser/blob/730b7d3297ab9f17f484e7b557e4ec47c3d9b3e9/src/main/java/org/apache/sling/feature/scanner/impl/fwk/FrameworkPropertiesGatherer.java#L41.
>  That new process always takes the current  {{java.home}} which therefore 
> returns the wrong properties (i.e. the ones for the current  java version 
> instead of the one used to execute the framework).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-11906) Migrate to slf4j 2.x

[Robert Munteanu (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17852420#comment-17852420
 ] 

Robert Munteanu commented on SLING-11906:
-

[~reschke] - we don't have any other ticket besides this one.

> Migrate to slf4j 2.x
> 
>
> Key: SLING-11906
> URL: https://issues.apache.org/jira/browse/SLING-11906
> Project: Sling
>  Issue Type: Improvement
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Commons Log 6.0.0
>
>
> Increasingly more libraries have been migrating to slf4j 2.x (for example 
> logback 1.3+, tika 2.5+ and jetty 10+)
> To be compatible with those, the sling commons log bundle should migrate to 
> slf4j v2.x (and logback v1.4.x or v1.3.x?)
> It looks like slf4j 2.x exports both 2.x and 1.7.36 versions of the exported 
> packages, so it should hopefully be compatible with existing bundles that are 
> importing the 1.x version of the slf4j packages.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [VOTE] Release Apache Sling Repoinit JCR 1.1.48

[Robert Munteanu]

On Sat, 2024-05-25 at 11:53 +0200, Julian Sedding wrote:
> Please vote to approve this release:

+1
Robert

P.S. Would be great to upgrade the build to work with Java 17 or newer.
Many tests fail with 

java.lang.ClassNotFoundException: java.security.acl.Group


signature.asc
Description: This is a digitally signed message part

Re: parent pom 60 & requirement to use java17 for builds

[Robert Munteanu]

On Thu, 2024-05-23 at 09:10 +, Stefan Seifert wrote:
> konrad provided this wiki page with hints for update to parent 60+:
> https://cwiki.apache.org/confluence/x/SI75E
> 
> you have to remove java 11 from .sling-module.json during the update,
> or add one like this if it does not exist:
> https://github.com/apache/sling-org-apache-sling-testing-sling-mock/blob/master/.sling-module.json

I wonder if we could/should do some magic here and automatically remove
Java 11 from the JDKs if we find parent pom >= 60

Robert

> 
> stefan
> 
> > -Original Message-
> > From: Jörg Hoh 
> > Sent: Thursday, May 23, 2024 11:04 AM
> > To: Sling Developers List 
> > Subject: parent pom 60 & requirement to use java17 for builds
> > 
> > Hi,
> > 
> > While updating the sling engine to use the latest parent, I found
> > that it
> > enforces Java 17 or newer to build:
> > 
> > https://ci-
> > builds.apache.org/blue/organizations/jenkins/Sling%2Fmodules%2Fslin
> > g-org-
> > apache-sling-engine/detail/PR-46/1/pipeline
> > 
> > Rule 0: org.apache.maven.enforcer.rules.version.RequireJavaVersion
> > failed with message:
> > 
> >   > builds.apache.org/blue/organizations/jenkins/Sling%2Fmodules%2Fslin
> > g-org-
> > apache-sling-engine/detail/PR-46/1/pipeline#step-49-log-
> > 153>Detected
> > JDK version 11.0.16-1
> > (JAVA_HOME=/usr/local/asfpackages/java/adoptium-jdk-11.0.16.1+1) is
> > not in the allowed range [17,).
> > 
> > 
> > I checked and found that the resulting bytecode is version 55.0
> > (Java
> > SE 11), so it should be okay.
> > 
> > But: How do we adjust the CI builds in a way, that it des not try
> > to
> > build them with Java 11 anymore?
> > 
> > Jörg
> > 
> > --
> > https://cqdump.joerghoh.de

June 2023 board report draft

[Robert Munteanu]

Hi,

I plan to submit the following report on Monday.

Feedback welcome,

Thanks,
Robert

---

## Description:
Apache Sling™ is a framework for RESTful web-applications based on an 
extensible content tree.

## Project Status:
Current project status: Ongoing, with moderate activity.
Issues for the board: none.

## Membership Data:
Apache Sling was founded 2009-06-17 (15 years ago)
There are currently 51 committers and 29 PMC members in this project.
The Committer-to-PMC ratio is roughly 7:4.

Community changes, past quarter:
- No new PMC members. Last addition was Joerg Hoh on 2022-06-13.
- No new committers. Last addition was Henry Kuijpers on 2023-10-19.

## Project Activity:
We released version 12 of our sample application, the Sling Starter, on
March 18th, 2022. We have not yet made plans for version 13, but
individual modules are being developed and released, with 21 releases
for this reporting period.

Work is ongoing for migrating individual modules to the Jakarta JSON
specification.

## Community Health:
Community health is good and contributions from various individuals
continue.

[jira] [Resolved] (SLING-12317) Make Sling Engine build with Java 21

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-12317.
-
Resolution: Fixed

> Make Sling Engine build with Java 21
> 
>
> Key: SLING-12317
> URL: https://issues.apache.org/jira/browse/SLING-12317
> Project: Sling
>  Issue Type: Task
>  Components: Engine
>Affects Versions: Engine 2.15.14
>Reporter: Joerg Hoh
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Engine 2.15.16
>
>
> {noformat}[ERROR] 
> org.apache.sling.engine.impl.SlingHttpServletRequestImplTest.getUserPrincipal_testUnauthenticated_nonspeccompliant
>   Time elapsed: 0 s  <<< ERROR!
> java.lang.IllegalStateException: No code generation strategy available
>   at 
> org.jmock.imposters.ByteBuddyClassImposteriser.proxyClass(ByteBuddyClassImposteriser.java:167)
>   at 
> org.jmock.imposters.ByteBuddyClassImposteriser.access$000(ByteBuddyClassImposteriser.java:41)
>   at 
> org.jmock.imposters.ByteBuddyClassImposteriser$1.apply(ByteBuddyClassImposteriser.java:100)
>   at 
> org.jmock.imposters.ByteBuddyClassImposteriser$1.apply(ByteBuddyClassImposteriser.java:96)
>   at 
> java.base/java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1708)
>   at 
> org.jmock.imposters.ByteBuddyClassImposteriser.proxy(ByteBuddyClassImposteriser.java:95)
>   at 
> org.jmock.imposters.ByteBuddyClassImposteriser.imposterise(ByteBuddyClassImposteriser.java:66)
>   at org.jmock.Mockery.mock(Mockery.java:167)
>   at org.jmock.Mockery.mock(Mockery.java:143)
>   at 
> org.apache.sling.engine.impl.SlingHttpServletRequestImplTest.getUserPrincipal_testUnauthenticated_nonspeccompliant(SlingHttpServletRequestImplTest.java:176)
>   at 
> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
>   at java.base/java.lang.reflect.Method.invoke(Method.java:580)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
>   at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
>   at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
>   at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:364)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:272)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:237)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:158)
>   at 
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:428)
>   at 
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
>   at 
> org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:562)
>   at 
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:548){noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [VOTE] Release Apache Sling JCR Resource 3.3.2

[Robert Munteanu]

On Mon, 2024-05-20 at 16:02 +, Radu Cotescu wrote:
> Please vote to approve this release:

+1
Robert


signature.asc
Description: This is a digitally signed message part

[jira] [Updated] (SLING-12317) Make Sling Engine build with Java 21

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-12317:

Fix Version/s: Engine 2.15.16

> Make Sling Engine build with Java 21
> 
>
> Key: SLING-12317
> URL: https://issues.apache.org/jira/browse/SLING-12317
> Project: Sling
>  Issue Type: Task
>  Components: Engine
>Affects Versions: Engine 2.15.14
>Reporter: Joerg Hoh
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Engine 2.15.16
>
>
> {noformat}[ERROR] 
> org.apache.sling.engine.impl.SlingHttpServletRequestImplTest.getUserPrincipal_testUnauthenticated_nonspeccompliant
>   Time elapsed: 0 s  <<< ERROR!
> java.lang.IllegalStateException: No code generation strategy available
>   at 
> org.jmock.imposters.ByteBuddyClassImposteriser.proxyClass(ByteBuddyClassImposteriser.java:167)
>   at 
> org.jmock.imposters.ByteBuddyClassImposteriser.access$000(ByteBuddyClassImposteriser.java:41)
>   at 
> org.jmock.imposters.ByteBuddyClassImposteriser$1.apply(ByteBuddyClassImposteriser.java:100)
>   at 
> org.jmock.imposters.ByteBuddyClassImposteriser$1.apply(ByteBuddyClassImposteriser.java:96)
>   at 
> java.base/java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1708)
>   at 
> org.jmock.imposters.ByteBuddyClassImposteriser.proxy(ByteBuddyClassImposteriser.java:95)
>   at 
> org.jmock.imposters.ByteBuddyClassImposteriser.imposterise(ByteBuddyClassImposteriser.java:66)
>   at org.jmock.Mockery.mock(Mockery.java:167)
>   at org.jmock.Mockery.mock(Mockery.java:143)
>   at 
> org.apache.sling.engine.impl.SlingHttpServletRequestImplTest.getUserPrincipal_testUnauthenticated_nonspeccompliant(SlingHttpServletRequestImplTest.java:176)
>   at 
> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
>   at java.base/java.lang.reflect.Method.invoke(Method.java:580)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
>   at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
>   at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
>   at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:364)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:272)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:237)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:158)
>   at 
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:428)
>   at 
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
>   at 
> org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:562)
>   at 
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:548){noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12317) Make Sling Engine build with Java 21

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-12317:

Description: 
{noformat}[ERROR] 
org.apache.sling.engine.impl.SlingHttpServletRequestImplTest.getUserPrincipal_testUnauthenticated_nonspeccompliant
  Time elapsed: 0 s  <<< ERROR!
java.lang.IllegalStateException: No code generation strategy available
at 
org.jmock.imposters.ByteBuddyClassImposteriser.proxyClass(ByteBuddyClassImposteriser.java:167)
at 
org.jmock.imposters.ByteBuddyClassImposteriser.access$000(ByteBuddyClassImposteriser.java:41)
at 
org.jmock.imposters.ByteBuddyClassImposteriser$1.apply(ByteBuddyClassImposteriser.java:100)
at 
org.jmock.imposters.ByteBuddyClassImposteriser$1.apply(ByteBuddyClassImposteriser.java:96)
at 
java.base/java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1708)
at 
org.jmock.imposters.ByteBuddyClassImposteriser.proxy(ByteBuddyClassImposteriser.java:95)
at 
org.jmock.imposters.ByteBuddyClassImposteriser.imposterise(ByteBuddyClassImposteriser.java:66)
at org.jmock.Mockery.mock(Mockery.java:167)
at org.jmock.Mockery.mock(Mockery.java:143)
at 
org.apache.sling.engine.impl.SlingHttpServletRequestImplTest.getUserPrincipal_testUnauthenticated_nonspeccompliant(SlingHttpServletRequestImplTest.java:176)
at 
java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at 
org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:364)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:272)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:237)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:158)
at 
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:428)
at 
org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
at 
org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:562)
at 
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:548){noformat}

> Make Sling Engine build with Java 21
> 
>
> Key: SLING-12317
> URL: https://issues.apache.org/jira/browse/SLING-12317
> Project: Sling
>  Issue Type: Task
>  Components: Engine
>Affects Versions: Engine 2.15.14
>Reporter: Joerg Hoh
>Assignee: Robert Munteanu
>Priority: Major
>
> {noformat}[ERROR] 
> org.apache.sling.engine.impl.SlingHttpServletRequestImplTest.getUserPrincipal_testUnauthenticated_nonspeccompliant
>   Time elapsed: 0 s  <<< ERROR!
> java.lang.IllegalStateException: No code generation strategy available
>   at 
> org.jmock.imposters.ByteBuddyClassImposteriser.proxyClass(ByteBuddyClassImposteriser.java:167)
>   at 
> org.jmock.imposters.ByteBuddyClassImposteriser.access$000(ByteBuddyClassImposteriser.java:41)
>   at 
> org.jmock.imposters.ByteBuddyClassImposteriser$1.apply(ByteBuddyClassImposteriser.java:100)
>   at 
> org.jmock.imposters.ByteBuddyClassImposteriser$1.apply(ByteBuddyClassImposteriser.java:96)
>   at

[jira] [Assigned] (SLING-12317) Make Sling Engine build with Java 21

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-12317:
---

Assignee: Robert Munteanu

> Make Sling Engine build with Java 21
> 
>
> Key: SLING-12317
> URL: https://issues.apache.org/jira/browse/SLING-12317
> Project: Sling
>  Issue Type: Task
>  Components: Engine
>Affects Versions: Engine 2.15.14
>Reporter: Joerg Hoh
>Assignee: Robert Munteanu
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [VOTE] Release Apache Sling JCR Resource 3.3.0

[Robert Munteanu]

On Tue, 2024-05-14 at 10:46 +0200, Radu Cotescu wrote:
> Hi Robert,
> 
> On Tue, 7 May 2024 at 10:57, Robert Munteanu 
> wrote:
> > 
> > FWIW, you probably did not want to tag
> > https://issues.apache.org/jira/browse/SLING-12094 as being fixed
> > for
> > this release.
> > 
> 
> Why not? It was committed in
> https://github.com/apache/sling-org-apache-sling-jcr-resource/commit/1849e113a0ae94ca4484b1a766b97149959a06cc
> .

Because it affected all Sling modules, not just this one.

Moving exclusively to jakarta.servlet APIs vs keeping compatibility with javax.servlet

[Robert Munteanu]

Hi,

In https://github.com/apache/sling-org-apache-sling-i18n/pull/13 a
discussion was started regarding javax.servlet / jakarta.servlet
support.

The PR as it is requires both packages to resolve ( javax.servlet /
jakarta.servlet ), which means users that only have javax.servlet
support would be unable to consume newer versions of the i18n bundle.

We have typically tried very hard to keep backwards compatibility so
that our bundles are drop-in replacements; we don't do maintenance
branches for older versions because it would be a burden to us. Of
course, we can always revisit that.

So my question is - where do we stand on the jakarta.servlet /
javax.servlet topic? It's either a) we drop support for javax.servlet
and require jakarta.servlet or b) we keep supporting javax.servlet,
using newer features of jakarta.servlet without a hard binding, where
applicable.

Thoughts?

Thanks,
Robert

[jira] [Assigned] (SLING-12315) A race condition leads to failing resource-bundle registration during deactivation

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-12315:
---

Assignee: Elia Colombo

> A race condition leads to failing resource-bundle registration during 
> deactivation
> --
>
> Key: SLING-12315
> URL: https://issues.apache.org/jira/browse/SLING-12315
> Project: Sling
>  Issue Type: Bug
>  Components: i18n
>Reporter: Elia Colombo
>Assignee: Elia Colombo
>Priority: Major
>
> The following exception was observed:
> {code:java}
> [sling-default-5-ResourceBundleProvider: reload all resource bundles] 
> org.apache.sling.commons.scheduler.impl.QuartzScheduler Exception during job 
> execution of job 
> 'org.apache.sling.i18n.impl.JcrResourceBundleProvider$1@688bc8e' with name 
> 'ResourceBundleProvider: reload all resource bundles' : Cannot invoke 
> "org.osgi.framework.BundleContext.registerService(java.lang.Class, Object, 
> java.util.Dictionary)" because "this.bundleContext" is 
> nulljava.lang.NullPointerException: Cannot invoke 
> "org.osgi.framework.BundleContext.registerService(java.lang.Class, Object, 
> java.util.Dictionary)" because "this.bundleContext" is null at  
> org.apache.sling.i18n.impl.JcrResourceBundleProvider.registerResourceBundle(JcrResourceBundleProvider.java:532)
>  [org.apache.sling.i18n:2.6.2]{code}
> During the deactivation of JcrResourceBundleProvider, ReloadBundle jobs that 
> are still running can try to register new resourceBundles. This fails, if 
> deactivate already set bundleContext to null. 
> Proposed solution:
>  * use bundleContext as cancel flag during deactivation (bundleContext=null)
>  * prevent new registration of resources during deactivation (necessary)
>  * prevent processing of new onChange events during deactivation (improvement)
>  * prevent scheduling of new bundle reloading jobs during deactivation 
> (improvement)
>  * execute clearCache after setting bundleContext to null, to prevent new 
> registrations (improvement)
> BundleContext can be used as cancel flag, since conveniently it is anyway set 
> to null during deactivation. New registrations can be effectively avoided by 
> checking bundleContext==null before any registration within a synchronized 
> block.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12315) A race condition leads to failing resource-bundle registration during deactivation

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-12315:

Fix Version/s: i18n 2.6.4

> A race condition leads to failing resource-bundle registration during 
> deactivation
> --
>
> Key: SLING-12315
> URL: https://issues.apache.org/jira/browse/SLING-12315
> Project: Sling
>  Issue Type: Bug
>  Components: i18n
>Reporter: Elia Colombo
>Assignee: Elia Colombo
>Priority: Major
> Fix For: i18n 2.6.4
>
>
> The following exception was observed:
> {code:java}
> [sling-default-5-ResourceBundleProvider: reload all resource bundles] 
> org.apache.sling.commons.scheduler.impl.QuartzScheduler Exception during job 
> execution of job 
> 'org.apache.sling.i18n.impl.JcrResourceBundleProvider$1@688bc8e' with name 
> 'ResourceBundleProvider: reload all resource bundles' : Cannot invoke 
> "org.osgi.framework.BundleContext.registerService(java.lang.Class, Object, 
> java.util.Dictionary)" because "this.bundleContext" is 
> nulljava.lang.NullPointerException: Cannot invoke 
> "org.osgi.framework.BundleContext.registerService(java.lang.Class, Object, 
> java.util.Dictionary)" because "this.bundleContext" is null at  
> org.apache.sling.i18n.impl.JcrResourceBundleProvider.registerResourceBundle(JcrResourceBundleProvider.java:532)
>  [org.apache.sling.i18n:2.6.2]{code}
> During the deactivation of JcrResourceBundleProvider, ReloadBundle jobs that 
> are still running can try to register new resourceBundles. This fails, if 
> deactivate already set bundleContext to null. 
> Proposed solution:
>  * use bundleContext as cancel flag during deactivation (bundleContext=null)
>  * prevent new registration of resources during deactivation (necessary)
>  * prevent processing of new onChange events during deactivation (improvement)
>  * prevent scheduling of new bundle reloading jobs during deactivation 
> (improvement)
>  * execute clearCache after setting bundleContext to null, to prevent new 
> registrations (improvement)
> BundleContext can be used as cancel flag, since conveniently it is anyway set 
> to null during deactivation. New registrations can be effectively avoided by 
> checking bundleContext==null before any registration within a synchronized 
> block.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [VOTE] Release Apache Sling JCR Resource 3.3.0

[Robert Munteanu]

On Mon, 2024-05-06 at 16:19 +, Radu Cotescu wrote:
> Please vote to approve this release:

+1

FWIW, you probably did not want to tag
https://issues.apache.org/jira/browse/SLING-12094 as being fixed for
this release.

Thanks,
Robert


signature.asc
Description: This is a digitally signed message part

Re: [VOTE] Release Content Distribution Journal Core 0.3.0 , Content Distribution API 0.7.2, Content Distribution Journal Messages 0.5.10

[Robert Munteanu]

On Fri, 2024-05-03 at 09:51 +0200, Christian Schneider wrote:
> Please vote to approve this release:

+1
Robert


signature.asc
Description: This is a digitally signed message part

Re: [VOTE] Release Apache Sling Rewriter 1.4.4

[Robert Munteanu]

On Tue, 2024-04-30 at 11:27 +0200, Carsten Ziegeler wrote:
> Please vote to approve this release:

+1
Robert


signature.asc
Description: This is a digitally signed message part

[jira] [Closed] (SLING-12304) Broken backwards compatibility: out of order json object

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-12304.
---

> Broken backwards compatibility: out of order json object
> 
>
> Key: SLING-12304
> URL: https://issues.apache.org/jira/browse/SLING-12304
> Project: Sling
>  Issue Type: Bug
>Affects Versions: Commons JSON 2.0.26
>Reporter: Remo Liechti
>Assignee: Remo Liechti
>Priority: Critical
> Fix For: Commons JSON 2.0.28
>
>
> The fix of CVE-2022-47937 introduced an invalid backwards compatibility for 
> the order in jsonobject.
> New behaviour: has the keys unordered, as JsonObject uses a HashMap.
> Old behaviour: Kept insertion order of keys as JsonObject used LinkedHashMap.
> To no break existing users of the library, reestablish the old behaviour.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[RESULT] [VOTE] Release Apache Sling Commons JSON 2.0.28

[Robert Munteanu]

Hi,

The vote has passed with the following result:

+1 (binding): Stefan Seifert, Carsten Ziegeler, Joerg Hoh
+1 (non-binding): none

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

Regards,
Robert Munteanu

[jira] [Commented] (SLING-12197) cpconverter: Sling-Initial-Content directories created as nt:folder instead of sling:Folder

[Robert Munteanu (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-12197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841882#comment-17841882
 ] 

Robert Munteanu commented on SLING-12197:
-

[~Sc0rpic0m] [~sseifert] - any concerns with closing this and tracking the fix 
on the AEM Analyser side?

> cpconverter: Sling-Initial-Content directories created as nt:folder instead 
> of sling:Folder
> ---
>
> Key: SLING-12197
> URL: https://issues.apache.org/jira/browse/SLING-12197
> Project: Sling
>  Issue Type: Bug
>  Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.3.4
>Reporter: Stefan Seifert
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.3.8
>
> Attachments: io.wcm.handler.link-apps-1.10.2-cp2fm-converted.zip
>
>
> the cpconverter extracts Sling-Initial-Content from OSGi bundles and creates 
> FileVault packages with the transformed content.
> this works well, but there is one difference when the resulting content 
> package is installed compared when uploading the OSGi bundle with the 
> Sling-Initial-Content directly:
> * the JCR Content Loader by defaults creates a {{sling:Folder}} node type for 
> each directory found in the Sling-Initial-Content (see also 
> [docs|https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html#initial-content-loading-1])
> * the cpconverter process creates no {{.content.xml}} file for the folders, 
> but only for the actual JSON files found in the process. as a result, the 
> folders are created as {{nt:folder}} when uploading the transformed package
> * this difference becomes relevant, when a JSON file in Sling-Initial-Content 
> defines a primary type of {{nt:unstructured}} - it is not allowed to created 
> such a node directly below a {{nt:folder}} node - but it is allowed to do so 
> below a {{sling:Folder}} node



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-12173) Configuration errors in Eclipse for projects using the slingfeature-maven-plugin

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-12173.
---

> Configuration errors in Eclipse for projects using the 
> slingfeature-maven-plugin
> 
>
> Key: SLING-12173
> URL: https://issues.apache.org/jira/browse/SLING-12173
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>    Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: OSGi Feature Maven Plugin 1.8.2
>
>
> The slingfeature-maven-plugin currently uses the Jakarta JSON implementation 
> of the Apache Johnzon parser. 
> I have noticed problems in the Eclipse IDE, where projects fail to update 
> with hard to isolate errors (see below).
> {noformat}java.util.ServiceConfigurationError: jakarta.json.spi.JsonProvider: 
> org.apache.johnzon.core.JsonProviderImpl not a subtype
>   at java.base/java.util.ServiceLoader.fail(ServiceLoader.java:593)
>   at 
> java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNextService(ServiceLoader.java:1244)
>   at 
> java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNext(ServiceLoader.java:1273)
>   at java.base/java.util.ServiceLoader$2.hasNext(ServiceLoader.java:1309)
>   at java.base/java.util.ServiceLoader$3.hasNext(ServiceLoader.java:1393)
>   at jakarta.json.spi.JsonProvider.provider(JsonProvider.java:69)
>   at jakarta.json.Json.createReader(Json.java:189)
>   at 
> org.apache.sling.feature.maven.JSONFeatures.read(JSONFeatures.java:64)
>   at 
> org.apache.sling.feature.maven.ProjectHelper.readFeatureFile(ProjectHelper.java:622)
>   at 
> org.apache.sling.feature.maven.Preprocessor.readProjectFeatures(Preprocessor.java:304)
>   at 
> org.apache.sling.feature.maven.Preprocessor.process(Preprocessor.java:145)
>   at 
> org.apache.sling.feature.maven.Preprocessor.process(Preprocessor.java:110)
>   at 
> org.apache.sling.feature.maven.extensions.DependencyLifecycleParticipant.afterProjectsRead(DependencyLifecycleParticipant.java:87)
>   at 
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.executeParticipants(ProjectRegistryManager.java:824)
>   at 
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$15(ProjectRegistryManager.java:791)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:394)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:275)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:214)
>   at 
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$14(ProjectRegistryManager.java:790)
>   at java.base/java.util.HashMap$Values.forEach(HashMap.java:1065)
>   at 
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$11(ProjectRegistryManager.java:788)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:394)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:275)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:214)
>   at 
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.readMavenProjectFacades(ProjectRegistryManager.java:760)
>   at 
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.refresh(ProjectRegistryManager.java:392)
>   at 
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.refresh(ProjectRegistryManager.java:366)
>   at 
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.refresh(ProjectRegistryManager.java:318)
>   at 
> org.eclipse.m2e.core.internal.builder.MavenBuilder$BuildMethod.getProjectFacade(MavenBuilder.java:146)
>   at 
> org.eclipse.m2e.core.internal.builder.MavenBuilder$BuildMethod.lambda$0(MavenBuilder.java:84)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:394)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:275)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:214)
>   at 
> org.eclipse.m2e.core.inter

[jira] [Closed] (SLING-12153) Update maven-archiver and maven-filtering

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-12153.
---

> Update maven-archiver and maven-filtering
> -
>
> Key: SLING-12153
> URL: https://issues.apache.org/jira/browse/SLING-12153
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>    Reporter: Robert Munteanu
>    Assignee: Robert Munteanu
>Priority: Minor
> Fix For: OSGi Feature Maven Plugin 1.8.2
>
>
> [~jsedding] noticed that the plug-in brings in older versions of the 
> maven-archiver and maven-filtering. Those dependencies 
> {quote}drag an ancient guava version into the classpath via a transitive 
> dependency that was moved into "test" scope in newer versions of these two 
> libraries{quote}
> This causes various problems with IntelliJ and Eclipse integration. And 
> upgrading dependencies is always a good idea :-)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-12159) Add report to list package imports of jsp scripts

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-12159.
---

> Add report to list package imports of jsp scripts
> -
>
> Key: SLING-12159
> URL: https://issues.apache.org/jira/browse/SLING-12159
> Project: Sling
>  Issue Type: New Feature
>  Components: Maven Plugins and Archetypes
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: OSGi Feature Maven Plugin 1.8.2
>
>
> In addition to the reports about bundle package imports, we should generate 
> info about package imports from scripts (jsps)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-12174) Parameter 'defaultMetadata' is unknown for plugin

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-12174.
---

> Parameter 'defaultMetadata' is unknown for plugin
> -
>
> Key: SLING-12174
> URL: https://issues.apache.org/jira/browse/SLING-12174
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model, Maven Plugins and Archetypes
>Affects Versions: OSGi Feature Maven Plugin 1.8.0
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: OSGi Feature Maven Plugin 1.8.2
>
>
> When running the slingfeature maven plugin with latest Apache Maven, the 
> warning "Parameter 'defaultMetadata' is unknown for plugin" appears for all 
> goals.
> This is due to the fact that this parameter is evaluated in the preprocessor.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[RESULT] [VOTE] Release Apache Sling OSGi Feature Maven Plugin 1.8.2

[Robert Munteanu]

Hi,

The vote has passed with the following result:

+1 (binding): Stefan Seifert, Carsten Ziegeler, Robert Munteanu
+1 (non-binding): none

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

Regards,
Robert Munteanu

Re: [VOTE] Release Apache Sling OSGi Feature Maven Plugin 1.8.2

[Robert Munteanu]

On Thu, 2024-04-25 at 08:42 +, Robert Munteanu wrote:
> Please vote to approve this release:

+1
Robert


signature.asc
Description: This is a digitally signed message part

[jira] [Commented] (SLING-12197) cpconverter: Sling-Initial-Content directories created as nt:folder instead of sling:Folder

[Robert Munteanu (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-12197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840821#comment-17840821
 ] 

Robert Munteanu commented on SLING-12197:
-

Sure, if Niek has the time to look at it I'm all for it :-) I looked the 
initial PR from SLING-10931 and it's a lot of code, not easy to figure out 
where to insert what.

As for the test case, it would be very helpful if you could create a simple 
package with Sling initial content that install on the latest Sling Starter but 
fails when passed through the CP Converter. The bundle you linked above 
requires AEM-specific APIs and I can't use it for testing. 

> cpconverter: Sling-Initial-Content directories created as nt:folder instead 
> of sling:Folder
> ---
>
> Key: SLING-12197
> URL: https://issues.apache.org/jira/browse/SLING-12197
> Project: Sling
>  Issue Type: Bug
>  Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.3.4
>Reporter: Stefan Seifert
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.3.8
>
> Attachments: io.wcm.handler.link-apps-1.10.2-cp2fm-converted.zip
>
>
> the cpconverter extracts Sling-Initial-Content from OSGi bundles and creates 
> FileVault packages with the transformed content.
> this works well, but there is one difference when the resulting content 
> package is installed compared when uploading the OSGi bundle with the 
> Sling-Initial-Content directly:
> * the JCR Content Loader by defaults creates a {{sling:Folder}} node type for 
> each directory found in the Sling-Initial-Content (see also 
> [docs|https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html#initial-content-loading-1])
> * the cpconverter process creates no {{.content.xml}} file for the folders, 
> but only for the actual JSON files found in the process. as a result, the 
> folders are created as {{nt:folder}} when uploading the transformed package
> * this difference becomes relevant, when a JSON file in Sling-Initial-Content 
> defines a primary type of {{nt:unstructured}} - it is not allowed to created 
> such a node directly below a {{nt:folder}} node - but it is allowed to do so 
> below a {{sling:Folder}} node



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[VOTE] Release Apache Sling Commons JSON 2.0.28

[Robert Munteanu]

Hi,

We solved 1 issue in this release:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354549=Text

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2856/

You can use this UNIX script to download the release and verify the signatures:
https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh

Usage:
sh check_staged_release.sh 2856 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Robert Munteanu

[jira] [Assigned] (SLING-12304) Broken backwards compatibility: out of order json object

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-12304:
---

Assignee: Remo Liechti

> Broken backwards compatibility: out of order json object
> 
>
> Key: SLING-12304
> URL: https://issues.apache.org/jira/browse/SLING-12304
> Project: Sling
>  Issue Type: Bug
>Affects Versions: Commons JSON 2.0.26
>Reporter: Remo Liechti
>Assignee: Remo Liechti
>Priority: Critical
> Fix For: Commons JSON 2.0.28
>
>
> The fix of CVE-2022-47937 introduced an invalid backwards compatibility for 
> the order in jsonobject.
> New behaviour: has the keys unordered, as JsonObject uses a HashMap.
> Old behaviour: Kept insertion order of keys as JsonObject used LinkedHashMap.
> To no break existing users of the library, reestablish the old behaviour.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-12304) Broken backwards compatibility: out of order json object

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-12304.
-
Resolution: Fixed

PR applied, thanks [~rliechti]!

> Broken backwards compatibility: out of order json object
> 
>
> Key: SLING-12304
> URL: https://issues.apache.org/jira/browse/SLING-12304
> Project: Sling
>  Issue Type: Bug
>Affects Versions: Commons JSON 2.0.26
>Reporter: Remo Liechti
>Assignee: Remo Liechti
>Priority: Critical
> Fix For: Commons JSON 2.0.28
>
>
> The fix of CVE-2022-47937 introduced an invalid backwards compatibility for 
> the order in jsonobject.
> New behaviour: has the keys unordered, as JsonObject uses a HashMap.
> Old behaviour: Kept insertion order of keys as JsonObject used LinkedHashMap.
> To no break existing users of the library, reestablish the old behaviour.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-11633) ClientSideTeleporter throwing illegal argument when target byte code is > 1.8

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-11633.
---

> ClientSideTeleporter throwing illegal argument when target byte code is > 1.8
> -
>
> Key: SLING-11633
> URL: https://issues.apache.org/jira/browse/SLING-11633
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
> Environment: Apache Maven 3.8.5 
> (3599d3414f046de2324203b78ddcf9b5e4388aa0)
> Maven home: C:\aem-tools\utils\apache-maven-3.8.5
> Java version: 11.0.15.1, vendor: Oracle Corporation, runtime: 
> C:\aem-tools\utils\jdk-11.0.15.1
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>Reporter: Scott Yuan
>Assignee: Scott Yuan
>Priority: Trivial
> Fix For: JUnit Tests Teleporter 1.0.26
>
> Attachments: mylab.zip
>
>   Original Estimate: 2h
>  Time Spent: 0.5h
>  Remaining Estimate: 1.5h
>
> When attempted to use the latest 1.0.22 to build test cases using 
> TeleporterRule with Java 11+ code, illegal arguments error occurred. 
> It can be reproduce with the attached Maven project by change following 
> properites to 11. 
> * maven.compiler.source
> * maven.compiler.target



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-9327) Teleporter not working with jdk11 due to missing xml bind classes

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-9327.
--

> Teleporter not working with jdk11 due to missing xml bind classes
> -
>
> Key: SLING-9327
> URL: https://issues.apache.org/jira/browse/SLING-9327
> Project: Sling
>  Issue Type: Bug
>  Components: Testing
>Affects Versions: JUnit Tests Teleporter 1.0.10
>Reporter: Thierry Ygé
>Assignee: Robert Munteanu
>Priority: Blocker
> Fix For: JUnit Tests Teleporter 1.0.26
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Currently when using teleporter on jdk11 based environment, the teleporter is 
> failing due to missing class.
> {quote}java.lang.NoClassDefFoundError: javax/xml/bind/DatatypeConverter at 
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.setConnectionCredentials(TeleporterHttpClient.java:63)
>  at 
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.getHttpGetStatus(TeleporterHttpClient.java:136)
>  at 
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.waitForStatus(TeleporterHttpClient.java:75)
>  at 
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.installBundle(TeleporterHttpClient.java:94)
>  at 
> org.apache.sling.testing.teleporter.client.ClientSideTeleporter.installTestBundle(ClientSideTeleporter.java:173)
>  at 
> org.apache.sling.testing.teleporter.client.ClientSideTeleporter.access$000(ClientSideTeleporter.java:45)
>  at 
> org.apache.sling.testing.teleporter.client.ClientSideTeleporter$2.evaluate(ClientSideTeleporter.java:207)
>  at 
> com.adobe.granite.testing.serverside.rules.GraniteSSTRule$1.evaluate(GraniteSSTRule.java:104)
> {quote}
> This is due to jdk not containing this package anymore since jdk 9.
> Teleporter used is 1.0.10 and with 1.0.20 I couldn't use it as it fails with 
> missing osgi core dependency, unless I would then add it manually in the test 
> module pom.
> Note from [~bdelacretaz]
> As per 
> [https://stackoverflow.com/questions/52502189/java-11-package-javax-xml-bind-does-not-exist]
>  it looks like using {{jakarta.xml.bind}} as an additional dependency might 
> fix this.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[RESULT] [VOTE] Release Apache Sling JUnit Tests Teleporter 1.0.26

[Robert Munteanu]

Hi,

The vote has passed with the following result:

+1 (binding): Robert Munteanu, Stefan Seifert, Joerg Hoh, Radu Cotescu
+1 (non-binding): none

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

Regards,
Robert Munteanu

Re: [VOTE] Release Apache Sling Rewriter 1.4.2

[Robert Munteanu]

On Wed, 2024-04-24 at 14:35 +0200, Carsten Ziegeler wrote:
> Please vote to approve this release:

+1

Note: the build fails for me in various forms on anything but Java 8,
it would be good to clean this up.

Robert


signature.asc
Description: This is a digitally signed message part

[VOTE] Release Apache Sling OSGi Feature Maven Plugin 1.8.2

[Robert Munteanu]

Hi,

We solved 4 issues in this release:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353863=Text

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2855/

You can use this UNIX script to download the release and verify the signatures:
https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh

Usage:
sh check_staged_release.sh 2855 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Robert Munteanu

[jira] [Resolved] (SLING-12173) Configuration errors in Eclipse for projects using the slingfeature-maven-plugin

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-12173.
-
Fix Version/s: OSGi Feature Maven Plugin 1.8.2
   (was: OSGi Feature Maven Plugin 1.8.4)
   Resolution: Fixed

> Configuration errors in Eclipse for projects using the 
> slingfeature-maven-plugin
> 
>
> Key: SLING-12173
> URL: https://issues.apache.org/jira/browse/SLING-12173
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>    Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: OSGi Feature Maven Plugin 1.8.2
>
>
> The slingfeature-maven-plugin currently uses the Jakarta JSON implementation 
> of the Apache Johnzon parser. 
> I have noticed problems in the Eclipse IDE, where projects fail to update 
> with hard to isolate errors (see below).
> {noformat}java.util.ServiceConfigurationError: jakarta.json.spi.JsonProvider: 
> org.apache.johnzon.core.JsonProviderImpl not a subtype
>   at java.base/java.util.ServiceLoader.fail(ServiceLoader.java:593)
>   at 
> java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNextService(ServiceLoader.java:1244)
>   at 
> java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNext(ServiceLoader.java:1273)
>   at java.base/java.util.ServiceLoader$2.hasNext(ServiceLoader.java:1309)
>   at java.base/java.util.ServiceLoader$3.hasNext(ServiceLoader.java:1393)
>   at jakarta.json.spi.JsonProvider.provider(JsonProvider.java:69)
>   at jakarta.json.Json.createReader(Json.java:189)
>   at 
> org.apache.sling.feature.maven.JSONFeatures.read(JSONFeatures.java:64)
>   at 
> org.apache.sling.feature.maven.ProjectHelper.readFeatureFile(ProjectHelper.java:622)
>   at 
> org.apache.sling.feature.maven.Preprocessor.readProjectFeatures(Preprocessor.java:304)
>   at 
> org.apache.sling.feature.maven.Preprocessor.process(Preprocessor.java:145)
>   at 
> org.apache.sling.feature.maven.Preprocessor.process(Preprocessor.java:110)
>   at 
> org.apache.sling.feature.maven.extensions.DependencyLifecycleParticipant.afterProjectsRead(DependencyLifecycleParticipant.java:87)
>   at 
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.executeParticipants(ProjectRegistryManager.java:824)
>   at 
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$15(ProjectRegistryManager.java:791)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:394)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:275)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:214)
>   at 
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$14(ProjectRegistryManager.java:790)
>   at java.base/java.util.HashMap$Values.forEach(HashMap.java:1065)
>   at 
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$11(ProjectRegistryManager.java:788)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:394)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:275)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:214)
>   at 
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.readMavenProjectFacades(ProjectRegistryManager.java:760)
>   at 
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.refresh(ProjectRegistryManager.java:392)
>   at 
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.refresh(ProjectRegistryManager.java:366)
>   at 
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.refresh(ProjectRegistryManager.java:318)
>   at 
> org.eclipse.m2e.core.internal.builder.MavenBuilder$BuildMethod.getProjectFacade(MavenBuilder.java:146)
>   at 
> org.eclipse.m2e.core.internal.builder.MavenBuilder$BuildMethod.lambda$0(MavenBuilder.java:84)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:394)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionC

[jira] [Updated] (SLING-12305) Build fails on Java 21 due to invoker plug-in: Unsupported class file major version 65

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-12305:

Fix Version/s: OSGi Feature Maven Plugin 1.8.4
   (was: OSGi Feature Maven Plugin 1.8.2)

> Build fails on Java 21 due to invoker plug-in: Unsupported class file major 
> version 65
> --
>
> Key: SLING-12305
> URL: https://issues.apache.org/jira/browse/SLING-12305
> Project: Sling
>  Issue Type: Bug
>Affects Versions: OSGi Feature Maven Plugin 1.8.0
>    Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: OSGi Feature Maven Plugin 1.8.4
>
>
> The invoker plugin-ins runs groovy scripts in the {{verify}} goal, and this 
> fails on Java 21 with
> {noformat}
> [INFO] --- invoker:3.5.1:integration-test (integration-test) @ 
> slingfeature-maven-plugin ---
> [INFO] Building: analyzer-apiregions-errors-detected/pom.xml
> [INFO] run post-build script verify.groovy
> [INFO]   BUG! exception in phase 'semantic analysis' in source unit 
> 'Script1.groovy' Unsupported class file major version 65
> [INFO]   analyzer-apiregions-errors-detected/pom.xml .. FAILED 
> (3.0 s)
> {noformat}
> The stack trace seems to indicate that Groovy tries to parse Java 21 bytecode 
> and fails.
> {noformat}
> Caused by: java.lang.IllegalArgumentException: Unsupported class file major 
> version 65
>   at groovyjarjarasm.asm.ClassReader.(ClassReader.java:199)
>   at groovyjarjarasm.asm.ClassReader.(ClassReader.java:180)
>   at groovyjarjarasm.asm.ClassReader.(ClassReader.java:166)
>   at groovyjarjarasm.asm.ClassReader.(ClassReader.java:287)
>   at 
> org.codehaus.groovy.ast.decompiled.AsmDecompiler.parseClass(AsmDecompiler.java:83)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-12305) Build fails on Java 21 due to invoker plug-in: Unsupported class file major version 65

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-12305.
-
Resolution: Fixed

> Build fails on Java 21 due to invoker plug-in: Unsupported class file major 
> version 65
> --
>
> Key: SLING-12305
> URL: https://issues.apache.org/jira/browse/SLING-12305
> Project: Sling
>  Issue Type: Bug
>Affects Versions: OSGi Feature Maven Plugin 1.8.0
>    Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: OSGi Feature Maven Plugin 1.8.4
>
>
> The invoker plugin-ins runs groovy scripts in the {{verify}} goal, and this 
> fails on Java 21 with
> {noformat}
> [INFO] --- invoker:3.5.1:integration-test (integration-test) @ 
> slingfeature-maven-plugin ---
> [INFO] Building: analyzer-apiregions-errors-detected/pom.xml
> [INFO] run post-build script verify.groovy
> [INFO]   BUG! exception in phase 'semantic analysis' in source unit 
> 'Script1.groovy' Unsupported class file major version 65
> [INFO]   analyzer-apiregions-errors-detected/pom.xml .. FAILED 
> (3.0 s)
> {noformat}
> The stack trace seems to indicate that Groovy tries to parse Java 21 bytecode 
> and fails.
> {noformat}
> Caused by: java.lang.IllegalArgumentException: Unsupported class file major 
> version 65
>   at groovyjarjarasm.asm.ClassReader.(ClassReader.java:199)
>   at groovyjarjarasm.asm.ClassReader.(ClassReader.java:180)
>   at groovyjarjarasm.asm.ClassReader.(ClassReader.java:166)
>   at groovyjarjarasm.asm.ClassReader.(ClassReader.java:287)
>   at 
> org.codehaus.groovy.ast.decompiled.AsmDecompiler.parseClass(AsmDecompiler.java:83)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12173) Configuration errors in Eclipse for projects using the slingfeature-maven-plugin

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-12173:

Fix Version/s: OSGi Feature Maven Plugin 1.8.4
   (was: OSGi Feature Maven Plugin 1.8.2)

> Configuration errors in Eclipse for projects using the 
> slingfeature-maven-plugin
> 
>
> Key: SLING-12173
> URL: https://issues.apache.org/jira/browse/SLING-12173
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>    Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: OSGi Feature Maven Plugin 1.8.4
>
>
> The slingfeature-maven-plugin currently uses the Jakarta JSON implementation 
> of the Apache Johnzon parser. 
> I have noticed problems in the Eclipse IDE, where projects fail to update 
> with hard to isolate errors (see below).
> {noformat}java.util.ServiceConfigurationError: jakarta.json.spi.JsonProvider: 
> org.apache.johnzon.core.JsonProviderImpl not a subtype
>   at java.base/java.util.ServiceLoader.fail(ServiceLoader.java:593)
>   at 
> java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNextService(ServiceLoader.java:1244)
>   at 
> java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNext(ServiceLoader.java:1273)
>   at java.base/java.util.ServiceLoader$2.hasNext(ServiceLoader.java:1309)
>   at java.base/java.util.ServiceLoader$3.hasNext(ServiceLoader.java:1393)
>   at jakarta.json.spi.JsonProvider.provider(JsonProvider.java:69)
>   at jakarta.json.Json.createReader(Json.java:189)
>   at 
> org.apache.sling.feature.maven.JSONFeatures.read(JSONFeatures.java:64)
>   at 
> org.apache.sling.feature.maven.ProjectHelper.readFeatureFile(ProjectHelper.java:622)
>   at 
> org.apache.sling.feature.maven.Preprocessor.readProjectFeatures(Preprocessor.java:304)
>   at 
> org.apache.sling.feature.maven.Preprocessor.process(Preprocessor.java:145)
>   at 
> org.apache.sling.feature.maven.Preprocessor.process(Preprocessor.java:110)
>   at 
> org.apache.sling.feature.maven.extensions.DependencyLifecycleParticipant.afterProjectsRead(DependencyLifecycleParticipant.java:87)
>   at 
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.executeParticipants(ProjectRegistryManager.java:824)
>   at 
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$15(ProjectRegistryManager.java:791)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:394)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:275)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:214)
>   at 
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$14(ProjectRegistryManager.java:790)
>   at java.base/java.util.HashMap$Values.forEach(HashMap.java:1065)
>   at 
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$11(ProjectRegistryManager.java:788)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:394)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:275)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:214)
>   at 
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.readMavenProjectFacades(ProjectRegistryManager.java:760)
>   at 
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.refresh(ProjectRegistryManager.java:392)
>   at 
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.refresh(ProjectRegistryManager.java:366)
>   at 
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.refresh(ProjectRegistryManager.java:318)
>   at 
> org.eclipse.m2e.core.internal.builder.MavenBuilder$BuildMethod.getProjectFacade(MavenBuilder.java:146)
>   at 
> org.eclipse.m2e.core.internal.builder.MavenBuilder$BuildMethod.lambda$0(MavenBuilder.java:84)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:394)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:275)
>   at 
> org.eclipse.m2e.core.internal.embed

[jira] [Updated] (SLING-12305) Build fails on Java 21 due to invoker plug-in: Unsupported class file major version 65

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-12305:

Issue Type: Bug  (was: Task)

> Build fails on Java 21 due to invoker plug-in: Unsupported class file major 
> version 65
> --
>
> Key: SLING-12305
> URL: https://issues.apache.org/jira/browse/SLING-12305
> Project: Sling
>  Issue Type: Bug
>Affects Versions: OSGi Feature Maven Plugin 1.8.0
>    Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: OSGi Feature Maven Plugin 1.8.2
>
>
> The invoker plugin-ins runs groovy scripts in the {{verify}} goal, and this 
> fails on Java 21 with
> {noformat}
> [INFO] --- invoker:3.5.1:integration-test (integration-test) @ 
> slingfeature-maven-plugin ---
> [INFO] Building: analyzer-apiregions-errors-detected/pom.xml
> [INFO] run post-build script verify.groovy
> [INFO]   BUG! exception in phase 'semantic analysis' in source unit 
> 'Script1.groovy' Unsupported class file major version 65
> [INFO]   analyzer-apiregions-errors-detected/pom.xml .. FAILED 
> (3.0 s)
> {noformat}
> The stack trace seems to indicate that Groovy tries to parse Java 21 bytecode 
> and fails.
> {noformat}
> Caused by: java.lang.IllegalArgumentException: Unsupported class file major 
> version 65
>   at groovyjarjarasm.asm.ClassReader.(ClassReader.java:199)
>   at groovyjarjarasm.asm.ClassReader.(ClassReader.java:180)
>   at groovyjarjarasm.asm.ClassReader.(ClassReader.java:166)
>   at groovyjarjarasm.asm.ClassReader.(ClassReader.java:287)
>   at 
> org.codehaus.groovy.ast.decompiled.AsmDecompiler.parseClass(AsmDecompiler.java:83)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (SLING-12305) Build fails on Java 21 due to invoker plug-in: Unsupported class file major version 65

[Robert Munteanu (Jira)]

Robert Munteanu created SLING-12305:
---

 Summary: Build fails on Java 21 due to invoker plug-in: 
Unsupported class file major version 65
 Key: SLING-12305
 URL: https://issues.apache.org/jira/browse/SLING-12305
 Project: Sling
  Issue Type: Task
Affects Versions: OSGi Feature Maven Plugin 1.8.0
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: OSGi Feature Maven Plugin 1.8.2


The invoker plugin-ins runs groovy scripts in the {{verify}} goal, and this 
fails on Java 21 with

{noformat}
[INFO] --- invoker:3.5.1:integration-test (integration-test) @ 
slingfeature-maven-plugin ---
[INFO] Building: analyzer-apiregions-errors-detected/pom.xml
[INFO] run post-build script verify.groovy
[INFO]   BUG! exception in phase 'semantic analysis' in source unit 
'Script1.groovy' Unsupported class file major version 65
[INFO]   analyzer-apiregions-errors-detected/pom.xml .. FAILED (3.0 
s)
{noformat}

The stack trace seems to indicate that Groovy tries to parse Java 21 bytecode 
and fails.

{noformat}
Caused by: java.lang.IllegalArgumentException: Unsupported class file major 
version 65
at groovyjarjarasm.asm.ClassReader.(ClassReader.java:199)
at groovyjarjarasm.asm.ClassReader.(ClassReader.java:180)
at groovyjarjarasm.asm.ClassReader.(ClassReader.java:166)
at groovyjarjarasm.asm.ClassReader.(ClassReader.java:287)
at 
org.codehaus.groovy.ast.decompiled.AsmDecompiler.parseClass(AsmDecompiler.java:83)
{noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-12197) cpconverter: Sling-Initial-Content directories created as nt:folder instead of sling:Folder

[Robert Munteanu (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-12197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840675#comment-17840675
 ] 

Robert Munteanu commented on SLING-12197:
-

[~sseifert] - I did not have time to look into it in depth, but reading through 
the description it seems like a clear incompatibility between the CP Converter 
and Initial Content behaviour that we need to address. I don't know the 
codebase that well either, so a fix is not immediate for me either, 
unfortunately.

> cpconverter: Sling-Initial-Content directories created as nt:folder instead 
> of sling:Folder
> ---
>
> Key: SLING-12197
> URL: https://issues.apache.org/jira/browse/SLING-12197
> Project: Sling
>  Issue Type: Bug
>  Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.3.4
>Reporter: Stefan Seifert
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.3.8
>
> Attachments: io.wcm.handler.link-apps-1.10.2-cp2fm-converted.zip
>
>
> the cpconverter extracts Sling-Initial-Content from OSGi bundles and creates 
> FileVault packages with the transformed content.
> this works well, but there is one difference when the resulting content 
> package is installed compared when uploading the OSGi bundle with the 
> Sling-Initial-Content directly:
> * the JCR Content Loader by defaults creates a {{sling:Folder}} node type for 
> each directory found in the Sling-Initial-Content (see also 
> [docs|https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html#initial-content-loading-1])
> * the cpconverter process creates no {{.content.xml}} file for the folders, 
> but only for the actual JSON files found in the process. as a result, the 
> folders are created as {{nt:folder}} when uploading the transformed package
> * this difference becomes relevant, when a JSON file in Sling-Initial-Content 
> defines a primary type of {{nt:unstructured}} - it is not allowed to created 
> such a node directly below a {{nt:folder}} node - but it is allowed to do so 
> below a {{sling:Folder}} node



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12304) Broken backwards compatibility: out of order json object

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-12304:

Fix Version/s: Commons JSON 2.0.28

> Broken backwards compatibility: out of order json object
> 
>
> Key: SLING-12304
> URL: https://issues.apache.org/jira/browse/SLING-12304
> Project: Sling
>  Issue Type: Bug
>Affects Versions: Commons JSON 2.0.26
>Reporter: Remo Liechti
>Priority: Critical
> Fix For: Commons JSON 2.0.28
>
>
> The fix of CVE-2022-47937 introduced an invalid backwards compatibility for 
> the order in jsonobject.
> New behaviour: has the keys unordered, as JsonObject uses a HashMap.
> Old behaviour: Kept insertion order of keys as JsonObject used LinkedHashMap.
> To no break existing users of the library, reestablish the old behaviour.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-12173) Configuration errors in Eclipse for projects using the slingfeature-maven-plugin

[Robert Munteanu (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-12173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840540#comment-17840540
 ] 

Robert Munteanu commented on SLING-12173:
-

[~cziegeler] - that was my attempt to try out and see if the older plug-in 
version has the same problem. It does have it, so both the jakarta.json and 
javax.json implementations are problematic - in Eclipse, for me.

I suspect this is a classloader interaction between
- Maven/Plexus
- the OSGi runtime from Eclipse (Equinox)
- the ServiceLoader framework
- m2e

I _could_ try and chase this down across these projects but it seems like a lot 
of work. Instead, I am experimenting with using our commons.johnzon dependency 
instead the official JSON artifacts, and for now it seems to work fine.

IIUC this would avoid any such classloading issues, and hopefully will not 
bring any problems with Maven executions. I'll try to run some tests over the 
coming days, but wanted to check what you think of this approach.

> Configuration errors in Eclipse for projects using the 
> slingfeature-maven-plugin
> 
>
> Key: SLING-12173
> URL: https://issues.apache.org/jira/browse/SLING-12173
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>    Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: OSGi Feature Maven Plugin 1.8.2
>
>
> The slingfeature-maven-plugin currently uses the Jakarta JSON implementation 
> of the Apache Johnzon parser. 
> I have noticed problems in the Eclipse IDE, where projects fail to update 
> with hard to isolate errors (see below).
> {noformat}java.util.ServiceConfigurationError: jakarta.json.spi.JsonProvider: 
> org.apache.johnzon.core.JsonProviderImpl not a subtype
>   at java.base/java.util.ServiceLoader.fail(ServiceLoader.java:593)
>   at 
> java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNextService(ServiceLoader.java:1244)
>   at 
> java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNext(ServiceLoader.java:1273)
>   at java.base/java.util.ServiceLoader$2.hasNext(ServiceLoader.java:1309)
>   at java.base/java.util.ServiceLoader$3.hasNext(ServiceLoader.java:1393)
>   at jakarta.json.spi.JsonProvider.provider(JsonProvider.java:69)
>   at jakarta.json.Json.createReader(Json.java:189)
>   at 
> org.apache.sling.feature.maven.JSONFeatures.read(JSONFeatures.java:64)
>   at 
> org.apache.sling.feature.maven.ProjectHelper.readFeatureFile(ProjectHelper.java:622)
>   at 
> org.apache.sling.feature.maven.Preprocessor.readProjectFeatures(Preprocessor.java:304)
>   at 
> org.apache.sling.feature.maven.Preprocessor.process(Preprocessor.java:145)
>   at 
> org.apache.sling.feature.maven.Preprocessor.process(Preprocessor.java:110)
>   at 
> org.apache.sling.feature.maven.extensions.DependencyLifecycleParticipant.afterProjectsRead(DependencyLifecycleParticipant.java:87)
>   at 
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.executeParticipants(ProjectRegistryManager.java:824)
>   at 
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$15(ProjectRegistryManager.java:791)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:394)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:275)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:214)
>   at 
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$14(ProjectRegistryManager.java:790)
>   at java.base/java.util.HashMap$Values.forEach(HashMap.java:1065)
>   at 
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.lambda$11(ProjectRegistryManager.java:788)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:394)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:275)
>   at 
> org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:214)
>   at 
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.readMavenProjectFacades(ProjectRegistryManager.java:760)
>   at 
> org.eclipse.m2e.core.internal.project.registry.ProjectRegistryManager.refresh(ProjectRegistryManager.java:392)
>   at 
> org.eclipse.m2e.core.intern

Re: [VOTE] Release Apache Sling Testing Sling Mock Oak 3.2.0-1.22.15

[Robert Munteanu]

On Wed, 2024-04-17 at 18:32 +, Stefan Seifert wrote:
> Please vote to approve this release:

+1
Robert


signature.asc
Description: This is a digitally signed message part

Re: [VOTE] Release Apache Sling Testing Sling Mock 3.5.0, Sling Mock Oak 4.0.0-1.62.0

[Robert Munteanu]

On Wed, 2024-04-17 at 18:32 +, Stefan Seifert wrote:
> Please vote to approve this release:

+1
Robert


signature.asc
Description: This is a digitally signed message part

[jira] [Closed] (SLING-12290) Update tenant module to use parent pom 52

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-12290.
---

> Update tenant module to use parent pom 52
> -
>
> Key: SLING-12290
> URL: https://issues.apache.org/jira/browse/SLING-12290
> Project: Sling
>  Issue Type: Task
>  Components: Extensions
>    Reporter: Robert Munteanu
>    Assignee: Robert Munteanu
>Priority: Major
> Fix For: Tenant 1.1.8
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-12285) adding bind & unbind methods mapping in reference annotation

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-12285.
---

> adding bind & unbind methods mapping in reference annotation
> 
>
> Key: SLING-12285
> URL: https://issues.apache.org/jira/browse/SLING-12285
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Gagan Malpani
>Assignee: Gagan Malpani
>Priority: Major
> Fix For: Tenant 1.1.8
>
>
> adding bind & unbind methods mapping in reference annotation for 
> tenantproviderimpl



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (SLING-12286) Tenant build fails with Java 17 or newer

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-12286.
---

> Tenant build fails with Java 17 or newer
> 
>
> Key: SLING-12286
> URL: https://issues.apache.org/jira/browse/SLING-12286
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>    Reporter: Robert Munteanu
>    Assignee: Robert Munteanu
>Priority: Major
> Fix For: Tenant 1.1.8
>
>
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.038 
> s <<< FAILURE! - in org.apache.sling.tenant.internal.TenantProviderImplTest
> [ERROR] 
> org.apache.sling.tenant.internal.TenantProviderImplTest.testListTenantsWithoutTenantRoot
>   Time elapsed: 0.036 s  <<< ERROR!
> java.lang.ExceptionInInitializerError
>   at 
> org.mockito.cglib.core.KeyFactory$Generator.generateClass(KeyFactory.java:167)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[RESULT] [VOTE] Release Apache Sling Tenant 1.1.8

[Robert Munteanu]

Hi,

The vote has passed with the following result:

+1 (binding): Stefan Seifert, Robert Munteanu, Joerg Hoh, Radu Cotescu
+1 (non-binding): none

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

Regards,
Robert Munteanu

Re: [VOTE] Release Apache Sling Rewriter 1.4.0

[Robert Munteanu]

On Thu, 2024-04-18 at 18:36 +0200, Carsten Ziegeler wrote:
> Please vote to approve this release:

+1
Robert


signature.asc
Description: This is a digitally signed message part

Re: [VOTE] Release Apache Sling Tenant 1.1.8

[Robert Munteanu]

We need one more binding vote.

Thanks,
Robert

Re: [VOTE] Release Apache Sling Tenant 1.1.8

[Robert Munteanu]

On Thu, 2024-04-11 at 13:33 +, Robert Munteanu wrote:
> Please vote to approve this release:

+1
Robert


signature.asc
Description: This is a digitally signed message part

[jira] [Closed] (SLING-12291) Broken backwards compatibility for duplicated keys

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-12291.
---

> Broken backwards compatibility for duplicated keys
> --
>
> Key: SLING-12291
> URL: https://issues.apache.org/jira/browse/SLING-12291
> Project: Sling
>  Issue Type: Bug
>Affects Versions: Commons JSON 2.0.24
>Reporter: Remo Liechti
>Assignee: Remo Liechti
>Priority: Major
> Fix For: Commons JSON 2.0.26
>
>
> The fix of CVE-2022-47937 introduced an invalid backwards compatibility for 
> duplicated keys in a json.
> New behaviour: throws an exception on duplicated keys
> Old behaviour: ignores the fact and is able to process json with duplicated 
> keys.
> To no break existing users of the library, reestablish the old behaviour.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[RESULT] [VOTE] Release Apache Sling Commons JSON 2.0.26

[Robert Munteanu]

Hi,

The vote has passed with the following result:

+1 (binding): Stefan Seifert, Carsten Ziegeler, Robert Munteanu
+1 (non-binding): none

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

Regards,
Robert Munteanu

Re: [VOTE] Release Apache Sling Commons JSON 2.0.26

[Robert Munteanu]

On Fri, 2024-04-12 at 07:49 +, Robert Munteanu wrote:
> Please vote to approve this release:

+1
Robert


signature.asc
Description: This is a digitally signed message part

Re: [VOTE] Release Apache Sling JUnit Tests Teleporter 1.0.26

[Robert Munteanu]

Please disregard this thread, I accidentally sent the email twice.

Thanks,
Robert

On Wed, 2024-04-17 at 11:52 +0200, Robert Munteanu wrote:
> Hi,
> 
> We solved 2 issues in this release:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12348597=Text
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2847/
> 
> You can use this UNIX script to download the release and verify the
> signatures:
> https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh
> 
> Usage:
> sh check_staged_release.sh 2847 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.
> 
> Regards,
> Robert Munteanu



signature.asc
Description: This is a digitally signed message part

[VOTE] Release Apache Sling JUnit Tests Teleporter 1.0.26

[Robert Munteanu]

Hi,

We solved 2 issues in this release:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12348597=Text

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2847/

You can use this UNIX script to download the release and verify the signatures:
https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh

Usage:
sh check_staged_release.sh 2847 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Robert Munteanu

[jira] [Assigned] (SLING-11633) ClientSideTeleporter throwing illegal argument when target byte code is > 1.8

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-11633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-11633:
---

Assignee: Scott Yuan

> ClientSideTeleporter throwing illegal argument when target byte code is > 1.8
> -
>
> Key: SLING-11633
> URL: https://issues.apache.org/jira/browse/SLING-11633
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
> Environment: Apache Maven 3.8.5 
> (3599d3414f046de2324203b78ddcf9b5e4388aa0)
> Maven home: C:\aem-tools\utils\apache-maven-3.8.5
> Java version: 11.0.15.1, vendor: Oracle Corporation, runtime: 
> C:\aem-tools\utils\jdk-11.0.15.1
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>Reporter: Scott Yuan
>Assignee: Scott Yuan
>Priority: Trivial
> Fix For: JUnit Tests Teleporter 1.0.26
>
> Attachments: mylab.zip
>
>   Original Estimate: 2h
>  Time Spent: 0.5h
>  Remaining Estimate: 1.5h
>
> When attempted to use the latest 1.0.22 to build test cases using 
> TeleporterRule with Java 11+ code, illegal arguments error occurred. 
> It can be reproduce with the attached Maven project by change following 
> properites to 11. 
> * maven.compiler.source
> * maven.compiler.target



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[VOTE] Release Apache Sling JUnit Tests Teleporter 1.0.26

[Robert Munteanu]

Hi,

We solved 2 issues in this release:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12348597=Text

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2847/

You can use this UNIX script to download the release and verify the
signatures:
https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh

Usage:
sh check_staged_release.sh 2847 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Robert Munteanu

[jira] [Resolved] (SLING-9327) Teleporter not working with jdk11 due to missing xml bind classes

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-9327.

Resolution: Fixed

Merged 
https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/6, I 
think we can close this now.

> Teleporter not working with jdk11 due to missing xml bind classes
> -
>
> Key: SLING-9327
> URL: https://issues.apache.org/jira/browse/SLING-9327
> Project: Sling
>  Issue Type: Bug
>  Components: Testing
>Affects Versions: JUnit Tests Teleporter 1.0.10
>Reporter: Thierry Ygé
>Assignee: Robert Munteanu
>Priority: Blocker
> Fix For: JUnit Tests Teleporter 1.0.24
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Currently when using teleporter on jdk11 based environment, the teleporter is 
> failing due to missing class.
> {quote}java.lang.NoClassDefFoundError: javax/xml/bind/DatatypeConverter at 
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.setConnectionCredentials(TeleporterHttpClient.java:63)
>  at 
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.getHttpGetStatus(TeleporterHttpClient.java:136)
>  at 
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.waitForStatus(TeleporterHttpClient.java:75)
>  at 
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.installBundle(TeleporterHttpClient.java:94)
>  at 
> org.apache.sling.testing.teleporter.client.ClientSideTeleporter.installTestBundle(ClientSideTeleporter.java:173)
>  at 
> org.apache.sling.testing.teleporter.client.ClientSideTeleporter.access$000(ClientSideTeleporter.java:45)
>  at 
> org.apache.sling.testing.teleporter.client.ClientSideTeleporter$2.evaluate(ClientSideTeleporter.java:207)
>  at 
> com.adobe.granite.testing.serverside.rules.GraniteSSTRule$1.evaluate(GraniteSSTRule.java:104)
> {quote}
> This is due to jdk not containing this package anymore since jdk 9.
> Teleporter used is 1.0.10 and with 1.0.20 I couldn't use it as it fails with 
> missing osgi core dependency, unless I would then add it manually in the test 
> module pom.
> Note from [~bdelacretaz]
> As per 
> [https://stackoverflow.com/questions/52502189/java-11-package-javax-xml-bind-does-not-exist]
>  it looks like using {{jakarta.xml.bind}} as an additional dependency might 
> fix this.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-12276) Update to java-html-sanitizer 20240325.1

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-12276.
-
Resolution: Fixed

> Update to java-html-sanitizer 20240325.1
> 
>
> Key: SLING-12276
> URL: https://issues.apache.org/jira/browse/SLING-12276
> Project: Sling
>  Issue Type: Improvement
>  Components: XSS Protection API
>    Reporter: Robert Munteanu
>    Assignee: Robert Munteanu
>Priority: Major
> Fix For: XSS Protection API 2.4.2
>
>
> A new Java HTML Sanitizer version is out, notably removing the dependency on 
> Guava ( 
> https://github.com/OWASP/java-html-sanitizer/releases/tag/release-20240325.1 
> ).
> This will allow us to remove:
> - the embedding of Guava classes, cutting down on bundle size
> - the shading of the Guava classes, reducing the complexity of the pom



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[VOTE] Release Apache Sling Commons JSON 2.0.26

[Robert Munteanu]

Hi,

We solved 1 issue in this release:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354548=Text

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2846/

You can use this UNIX script to download the release and verify the signatures:
https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh

Usage:
sh check_staged_release.sh 2846 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Robert Munteanu

[jira] [Updated] (SLING-12291) Broken backwards compatibility for duplicated keys

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-12291:

Fix Version/s: Commons JSON 2.0.26
   (was: Commons JSON 2.0.24)

> Broken backwards compatibility for duplicated keys
> --
>
> Key: SLING-12291
> URL: https://issues.apache.org/jira/browse/SLING-12291
> Project: Sling
>  Issue Type: Bug
>Affects Versions: Commons JSON 2.0.24
>Reporter: Remo Liechti
>Assignee: Remo Liechti
>Priority: Major
> Fix For: Commons JSON 2.0.26
>
>
> The fix of CVE-2022-47937 introduced an invalid backwards compatibility for 
> duplicated keys in a json.
> New behaviour: throws an exception on duplicated keys
> Old behaviour: ignores the fact and is able to process json with duplicated 
> keys.
> To no break existing users of the library, reestablish the old behaviour.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-12291) Broken backwards compatibility for duplicated keys

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-12291.
-
Resolution: Fixed

PR applied, thanks [~rliechti]!

> Broken backwards compatibility for duplicated keys
> --
>
> Key: SLING-12291
> URL: https://issues.apache.org/jira/browse/SLING-12291
> Project: Sling
>  Issue Type: Bug
>Affects Versions: Commons JSON 2.0.24
>Reporter: Remo Liechti
>Assignee: Remo Liechti
>Priority: Major
> Fix For: Commons JSON 2.0.24
>
>
> The fix of CVE-2022-47937 introduced an invalid backwards compatibility for 
> duplicated keys in a json.
> New behaviour: throws an exception on duplicated keys
> Old behaviour: ignores the fact and is able to process json with duplicated 
> keys.
> To no break existing users of the library, reestablish the old behaviour.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (SLING-12291) Broken backwards compatibility for duplicated keys

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-12291:
---

Assignee: Remo Liechti

> Broken backwards compatibility for duplicated keys
> --
>
> Key: SLING-12291
> URL: https://issues.apache.org/jira/browse/SLING-12291
> Project: Sling
>  Issue Type: Bug
>Affects Versions: Commons JSON 2.0.24
>Reporter: Remo Liechti
>Assignee: Remo Liechti
>Priority: Major
> Fix For: Commons JSON 2.0.24
>
>
> The fix of CVE-2022-47937 introduced an invalid backwards compatibility for 
> duplicated keys in a json.
> New behaviour: throws an exception on duplicated keys
> Old behaviour: ignores the fact and is able to process json with duplicated 
> keys.
> To no break existing users of the library, reestablish the old behaviour.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12291) Broken backwards compatibility for duplicated keys

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-12291:

Fix Version/s: Commons JSON 2.0.24

> Broken backwards compatibility for duplicated keys
> --
>
> Key: SLING-12291
> URL: https://issues.apache.org/jira/browse/SLING-12291
> Project: Sling
>  Issue Type: Bug
>Affects Versions: Commons JSON 2.0.24
>Reporter: Remo Liechti
>Priority: Major
> Fix For: Commons JSON 2.0.24
>
>
> The fix of CVE-2022-47937 introduced an invalid backwards compatibility for 
> duplicated keys in a json.
> New behaviour: throws an exception on duplicated keys
> Old behaviour: ignores the fact and is able to process json with duplicated 
> keys.
> To no break existing users of the library, reestablish the old behaviour.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[VOTE] Release Apache Sling Tenant 1.1.8

[Robert Munteanu]

Hi,

We solved 3 issues in this release:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354544=Text

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2845/

You can use this UNIX script to download the release and verify the signatures:
https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh

Usage:
sh check_staged_release.sh 2845 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Robert Munteanu

[jira] [Resolved] (SLING-12290) Update tenant module to use parent pom 52

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-12290.
-
Resolution: Fixed

> Update tenant module to use parent pom 52
> -
>
> Key: SLING-12290
> URL: https://issues.apache.org/jira/browse/SLING-12290
> Project: Sling
>  Issue Type: Task
>  Components: Extensions
>    Reporter: Robert Munteanu
>    Assignee: Robert Munteanu
>Priority: Major
> Fix For: Tenant 1.1.8
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (SLING-12290) Update tenant module to use parent pom 52

[Robert Munteanu (Jira)]

Robert Munteanu created SLING-12290:
---

 Summary: Update tenant module to use parent pom 52
 Key: SLING-12290
 URL: https://issues.apache.org/jira/browse/SLING-12290
 Project: Sling
  Issue Type: Task
  Components: Extensions
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Tenant 1.1.8






--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-12285) adding bind & unbind methods mapping in reference annotation

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-12285.
-
Resolution: Fixed

> adding bind & unbind methods mapping in reference annotation
> 
>
> Key: SLING-12285
> URL: https://issues.apache.org/jira/browse/SLING-12285
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Gagan Malpani
>Assignee: Gagan Malpani
>Priority: Major
> Fix For: Tenant 1.1.8
>
>
> adding bind & unbind methods mapping in reference annotation for 
> tenantproviderimpl



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (SLING-12285) adding bind & unbind methods mapping in reference annotation

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-12285:
---

Assignee: Gagan Malpani

> adding bind & unbind methods mapping in reference annotation
> 
>
> Key: SLING-12285
> URL: https://issues.apache.org/jira/browse/SLING-12285
> Project: Sling
>  Issue Type: Bug
>  Components: General
>Reporter: Gagan Malpani
>Assignee: Gagan Malpani
>Priority: Major
> Fix For: Tenant 1.1.8
>
>
> adding bind & unbind methods mapping in reference annotation for 
> tenantproviderimpl



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12285) adding bind & unbind methods mapping in reference annotation

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-12285:

Component/s: Extensions
 (was: General)

> adding bind & unbind methods mapping in reference annotation
> 
>
> Key: SLING-12285
> URL: https://issues.apache.org/jira/browse/SLING-12285
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Gagan Malpani
>Assignee: Gagan Malpani
>Priority: Major
> Fix For: Tenant 1.1.8
>
>
> adding bind & unbind methods mapping in reference annotation for 
> tenantproviderimpl



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12285) adding bind & unbind methods mapping in reference annotation

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-12285:

Issue Type: Bug  (was: Improvement)

> adding bind & unbind methods mapping in reference annotation
> 
>
> Key: SLING-12285
> URL: https://issues.apache.org/jira/browse/SLING-12285
> Project: Sling
>  Issue Type: Bug
>  Components: General
>Reporter: Gagan Malpani
>Priority: Major
> Fix For: Tenant 1.1.8
>
>
> adding bind & unbind methods mapping in reference annotation for 
> tenantproviderimpl



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (SLING-12286) Tenant build fails with Java 17 or newer

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-12286.
-
Resolution: Fixed

> Tenant build fails with Java 17 or newer
> 
>
> Key: SLING-12286
> URL: https://issues.apache.org/jira/browse/SLING-12286
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>    Reporter: Robert Munteanu
>    Assignee: Robert Munteanu
>Priority: Major
> Fix For: Tenant 1.1.8
>
>
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.038 
> s <<< FAILURE! - in org.apache.sling.tenant.internal.TenantProviderImplTest
> [ERROR] 
> org.apache.sling.tenant.internal.TenantProviderImplTest.testListTenantsWithoutTenantRoot
>   Time elapsed: 0.036 s  <<< ERROR!
> java.lang.ExceptionInInitializerError
>   at 
> org.mockito.cglib.core.KeyFactory$Generator.generateClass(KeyFactory.java:167)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12286) Tenant build fails with Java 17 or newer

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-12286:

Summary: Tenant build fails with Java 17 or newer  (was: Tenat build fails 
with Java 17 or newer)

> Tenant build fails with Java 17 or newer
> 
>
> Key: SLING-12286
> URL: https://issues.apache.org/jira/browse/SLING-12286
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>    Reporter: Robert Munteanu
>    Assignee: Robert Munteanu
>Priority: Major
> Fix For: Tenant 1.1.8
>
>
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.038 
> s <<< FAILURE! - in org.apache.sling.tenant.internal.TenantProviderImplTest
> [ERROR] 
> org.apache.sling.tenant.internal.TenantProviderImplTest.testListTenantsWithoutTenantRoot
>   Time elapsed: 0.036 s  <<< ERROR!
> java.lang.ExceptionInInitializerError
>   at 
> org.mockito.cglib.core.KeyFactory$Generator.generateClass(KeyFactory.java:167)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (SLING-12286) Tenat build fails with Java 17 or newer

[Robert Munteanu (Jira)]

Robert Munteanu created SLING-12286:
---

 Summary: Tenat build fails with Java 17 or newer
 Key: SLING-12286
 URL: https://issues.apache.org/jira/browse/SLING-12286
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Tenant 1.1.8


[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.038 s 
<<< FAILURE! - in org.apache.sling.tenant.internal.TenantProviderImplTest
[ERROR] 
org.apache.sling.tenant.internal.TenantProviderImplTest.testListTenantsWithoutTenantRoot
  Time elapsed: 0.036 s  <<< ERROR!
java.lang.ExceptionInInitializerError
at 
org.mockito.cglib.core.KeyFactory$Generator.generateClass(KeyFactory.java:167)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12285) adding bind & unbind methods mapping in reference annotation

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-12285:

Fix Version/s: Tenant 1.1.8

> adding bind & unbind methods mapping in reference annotation
> 
>
> Key: SLING-12285
> URL: https://issues.apache.org/jira/browse/SLING-12285
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Reporter: Gagan Malpani
>Priority: Major
> Fix For: Tenant 1.1.8
>
>
> adding bind & unbind methods mapping in reference annotation for 
> tenantproviderimpl



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (SLING-12285) adding bind & unbind methods mapping in reference annotation

[Robert Munteanu (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-12285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835704#comment-17835704
 ] 

Robert Munteanu commented on SLING-12285:
-

Thanks for the report [~malp...@adobe.com]. Is this an actual bug? How does 
this manifest (log entries, etc)?

> adding bind & unbind methods mapping in reference annotation
> 
>
> Key: SLING-12285
> URL: https://issues.apache.org/jira/browse/SLING-12285
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Reporter: Gagan Malpani
>Priority: Major
>
> adding bind & unbind methods mapping in reference annotation for 
> tenantproviderimpl



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: How to use structured logging in sling?

[Robert Munteanu]

Hi Christian,

On Wed, 2024-04-10 at 10:14 +0200, Christian Schneider wrote:
> I would like to add an appender like below to sling.
> The idea is to use structured logging for simpler ingestion and the
> ability
> to easily add markers and MDC key/value pairs.
> 
> Did anyone try this before? The issue here is that I need special
> classes
> for encoder and decorator that are not part of logback core.
> 

I did not try this. The docs indicate though that you can register
Appenders as OSGi services [1], perhaps you can create a small bundle
that has a such a service and register it?

Thanks,
Robert


[1]:
https://sling.apache.org/documentation/development/logging.html#appenders-as-osgi-services-1

Re: [VOTE] Release Apache Sling Content Parser JSON 2.1.0

[Robert Munteanu]

On Tue, 2024-04-09 at 10:15 +, Stefan Seifert wrote:
> Please vote to approve this release:

+1
Robert


signature.asc
Description: This is a digitally signed message part

[jira] [Commented] (SLING-9327) Teleporter not working with jdk11 due to missing xml bind classes

[Robert Munteanu (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834913#comment-17834913
 ] 

Robert Munteanu commented on SLING-9327:


I've created a PR to remove the commons-codec dependency, I don't see how that 
can be needed. I'll try to get some proper tests running before merging.

> Teleporter not working with jdk11 due to missing xml bind classes
> -
>
> Key: SLING-9327
> URL: https://issues.apache.org/jira/browse/SLING-9327
> Project: Sling
>  Issue Type: Bug
>  Components: Testing
>Affects Versions: JUnit Tests Teleporter 1.0.10
>Reporter: Thierry Ygé
>Assignee: Robert Munteanu
>Priority: Blocker
> Fix For: JUnit Tests Teleporter 1.0.24
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Currently when using teleporter on jdk11 based environment, the teleporter is 
> failing due to missing class.
> {quote}java.lang.NoClassDefFoundError: javax/xml/bind/DatatypeConverter at 
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.setConnectionCredentials(TeleporterHttpClient.java:63)
>  at 
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.getHttpGetStatus(TeleporterHttpClient.java:136)
>  at 
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.waitForStatus(TeleporterHttpClient.java:75)
>  at 
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.installBundle(TeleporterHttpClient.java:94)
>  at 
> org.apache.sling.testing.teleporter.client.ClientSideTeleporter.installTestBundle(ClientSideTeleporter.java:173)
>  at 
> org.apache.sling.testing.teleporter.client.ClientSideTeleporter.access$000(ClientSideTeleporter.java:45)
>  at 
> org.apache.sling.testing.teleporter.client.ClientSideTeleporter$2.evaluate(ClientSideTeleporter.java:207)
>  at 
> com.adobe.granite.testing.serverside.rules.GraniteSSTRule$1.evaluate(GraniteSSTRule.java:104)
> {quote}
> This is due to jdk not containing this package anymore since jdk 9.
> Teleporter used is 1.0.10 and with 1.0.20 I couldn't use it as it fails with 
> missing osgi core dependency, unless I would then add it manually in the test 
> module pom.
> Note from [~bdelacretaz]
> As per 
> [https://stackoverflow.com/questions/52502189/java-11-package-javax-xml-bind-does-not-exist]
>  it looks like using {{jakarta.xml.bind}} as an additional dependency might 
> fix this.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (SLING-9327) Teleporter not working with jdk11 due to missing xml bind classes

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-9327:
--

Assignee: Robert Munteanu

> Teleporter not working with jdk11 due to missing xml bind classes
> -
>
> Key: SLING-9327
> URL: https://issues.apache.org/jira/browse/SLING-9327
> Project: Sling
>  Issue Type: Bug
>  Components: Testing
>Affects Versions: JUnit Tests Teleporter 1.0.10
>Reporter: Thierry Ygé
>Assignee: Robert Munteanu
>Priority: Blocker
> Fix For: JUnit Tests Teleporter 1.0.24
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Currently when using teleporter on jdk11 based environment, the teleporter is 
> failing due to missing class.
> {quote}java.lang.NoClassDefFoundError: javax/xml/bind/DatatypeConverter at 
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.setConnectionCredentials(TeleporterHttpClient.java:63)
>  at 
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.getHttpGetStatus(TeleporterHttpClient.java:136)
>  at 
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.waitForStatus(TeleporterHttpClient.java:75)
>  at 
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.installBundle(TeleporterHttpClient.java:94)
>  at 
> org.apache.sling.testing.teleporter.client.ClientSideTeleporter.installTestBundle(ClientSideTeleporter.java:173)
>  at 
> org.apache.sling.testing.teleporter.client.ClientSideTeleporter.access$000(ClientSideTeleporter.java:45)
>  at 
> org.apache.sling.testing.teleporter.client.ClientSideTeleporter$2.evaluate(ClientSideTeleporter.java:207)
>  at 
> com.adobe.granite.testing.serverside.rules.GraniteSSTRule$1.evaluate(GraniteSSTRule.java:104)
> {quote}
> This is due to jdk not containing this package anymore since jdk 9.
> Teleporter used is 1.0.10 and with 1.0.20 I couldn't use it as it fails with 
> missing osgi core dependency, unless I would then add it manually in the test 
> module pom.
> Note from [~bdelacretaz]
> As per 
> [https://stackoverflow.com/questions/52502189/java-11-package-javax-xml-bind-does-not-exist]
>  it looks like using {{jakarta.xml.bind}} as an additional dependency might 
> fix this.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: Improving unit testing performance for JCR_OAK (SLING-12265 and SLING-12266)

[Robert Munteanu]

Hello Csaba,

On Thu, 2024-04-04 at 11:54 +, Csaba Varga wrote:
> Hello,
> 
> I would like to ask about two issues I opened last month. SLING-12265
> is about decreasing the number of commits done while setting up a new
> repository during unit testing. SLING-12266 proposes going a bit
> further, caching and re-using the complete repository state,
> requiring just one initialization from scratch regardless of the
> number of tests using a JCR_OAK context.
> 
> I haven't heard any feedback about either ticket, even though I have
> added a PR for the first one. Am I missing something? Are there
> issues with this approach? I have some numbers for both proposals,
> and they are speeding things up significantly as far as I can tell,
> so I think everyone could benefit from this. (I only did a quick and
> dirty test for SLING-12266, not clean enough to make a PR out of it,
> but I can polish it into a PR if there is interest.)
> 
> If this is not the right channel to discuss it, please feel free to
> let me know.

Writing to the dev list is the right thing in case your does not get
attention.

The PR looks good overall to me but someone closer to the topic should
review it.

Maybe you got their attention and you'll get a review next week.
Otherwise, we can do an optimistic merge and revert if we find
problems down the road.

Thanks for your patience,
Robert

[RESULT] [VOTE] Release Apache Sling Commons JSON 2.0.24

[Robert Munteanu]

Hi,

The vote has passed with the following result:

+1 (binding): Robert Munteanu, Dan Klco, Stefan Egli
+1 (non-binding): none

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

Regards,
Robert Munteanu

Re: [VOTE] Release Apache Sling Commons JSON 2.0.24

[Robert Munteanu]

Hi,

We need two more binding votes for the release to pass.

Thanks,
Robert

Re: [VOTE] Release Apache Sling Commons JSON 2.0.24

[Robert Munteanu]

On Wed, 2024-03-20 at 12:16 +, Robert Munteanu wrote:
> Please vote to approve this release:

+1
Robert


signature.asc
Description: This is a digitally signed message part

[jira] [Assigned] (SLING-12276) Update to java-html-sanitizer 20240325.1

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-12276:
---

Assignee: Robert Munteanu

> Update to java-html-sanitizer 20240325.1
> 
>
> Key: SLING-12276
> URL: https://issues.apache.org/jira/browse/SLING-12276
> Project: Sling
>  Issue Type: Improvement
>  Components: XSS Protection API
>    Reporter: Robert Munteanu
>    Assignee: Robert Munteanu
>Priority: Major
> Fix For: XSS Protection API 2.4.2
>
>
> A new Java HTML Sanitizer version is out, notably removing the dependency on 
> Guava ( 
> https://github.com/OWASP/java-html-sanitizer/releases/tag/release-20240325.1 
> ).
> This will allow us to remove:
> - the embedding of Guava classes, cutting down on bundle size
> - the shading of the Guava classes, reducing the complexity of the pom



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (SLING-12276) Update to java-html-sanitizer 20240325.1

[Robert Munteanu (Jira)]

Robert Munteanu created SLING-12276:
---

 Summary: Update to java-html-sanitizer 20240325.1
 Key: SLING-12276
 URL: https://issues.apache.org/jira/browse/SLING-12276
 Project: Sling
  Issue Type: Improvement
  Components: XSS Protection API
Reporter: Robert Munteanu
 Fix For: XSS Protection API 2.4.2


A new Java HTML Sanitizer version is out, notably removing the dependency on 
Guava ( 
https://github.com/OWASP/java-html-sanitizer/releases/tag/release-20240325.1 ).

This will allow us to remove:
- the embedding of Guava classes, cutting down on bundle size
- the shading of the Guava classes, reducing the complexity of the pom



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12272) Document org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-12272:

Component/s: Sling Models

> Document org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor
> --
>
> Key: SLING-12272
> URL: https://issues.apache.org/jira/browse/SLING-12272
> Project: Sling
>  Issue Type: Improvement
>  Components: Documentation, Sling Models
>Reporter: Konrad Windszus
>Priority: Major
>
> With JDK 22 annotation processors will no longer be automatically executed by 
> javac (https://bugs.openjdk.org/browse/JDK-8306819). Instead they need to be 
> explicitly enabled with
> {code}
> -processor 
> {code}
> (https://docs.oracle.com/en/java/javase/17/docs/specs/man/javac.html#option-processor)
> That and a minimum description of what it does should be added to 
> https://sling.apache.org/documentation/bundles/models.html.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (SLING-12272) Document org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-12272:

Component/s: Documentation

> Document org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor
> --
>
> Key: SLING-12272
> URL: https://issues.apache.org/jira/browse/SLING-12272
> Project: Sling
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: Konrad Windszus
>Priority: Major
>
> With JDK 22 annotation processors will no longer be automatically executed by 
> javac (https://bugs.openjdk.org/browse/JDK-8306819). Instead they need to be 
> explicitly enabled with
> {code}
> -processor 
> {code}
> (https://docs.oracle.com/en/java/javase/17/docs/specs/man/javac.html#option-processor)
> That and a minimum description of what it does should be added to 
> https://sling.apache.org/documentation/bundles/models.html.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[CANCELLED] [VOTE] Release Apache Sling Commons JSON version 2.0.22

[Robert Munteanu]

I am cancelling this release because a regressions has crept up.

  https://issues.apache.org/jira/browse/SLING-12269

Will create a follow-up release for it.

Thanks,
Robert


On Tue, 2024-03-19 at 14:11 +0100, Robert Munteanu wrote:
> Hi,
> 
> Time to cut a release of the (still deprecated) commons.json module.
> We
> only include the already-known CVE fix, cut from the maintenance
> branch.
> 
> We solved 1 issues in this release:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=
> 12354425=Text
> 
> Staging repository:
> 
> https://repository.apache.org/content/repositories/orgapachesling-2842
> 
> You can use this UNIX script to download the release and verify the
> signatures:
> https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh
> 
> Usage:
> sh check_staged_release.sh 2842 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.
> 

[VOTE] Release Apache Sling Commons JSON 2.0.24

[Robert Munteanu]

Hi,

We solved 2 issues in this release:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354429=Text

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2843/

You can use this UNIX script to download the release and verify the signatures:
https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh

Usage:
sh check_staged_release.sh 2843 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Robert Munteanu

[jira] [Assigned] (SLING-12269) Changed behaviour in commons json when used as a dependency

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-12269:
---

Assignee: Remo Liechti

> Changed behaviour in commons json when used as a dependency
> ---
>
> Key: SLING-12269
> URL: https://issues.apache.org/jira/browse/SLING-12269
> Project: Sling
>  Issue Type: Bug
>  Components: Commons
>Reporter: Remo Liechti
>Assignee: Remo Liechti
>Priority: Blocker
> Attachments: SLING-12269.patch
>
>
> With the new internal release 2.0.22, there seems to be a different behaviour 
> when it comes to get values from JSONObject.
> The new version checks for types and throws an exception, as of the old 
> version simply called toString() on any object found.
> *Old:*
> {code:java}
> public String getString(String key) throws JSONException {
>   return get(key).toString();
> }{code}
> *New:*
> {{}}
> {code:java}
> public String getString(String key) throws JSONException {
>   Objectobject=this.get(key);
>   if (objectinstanceofString) {
>     return (String) object;
>      }
>   throwwrongValueFormatException(key, "string", object, null);
> }{code}
>  
> Same is true for all other types, such as getInt, getLong etc.
> There might be more such small differences in behaviour.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[VOTE] Release Apache Sling Commons JSON 2.0.24

[Robert Munteanu]

Hi,

We solved 2 issues in this release:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354429=Text

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2843/

You can use this UNIX script to download the release and verify the
signatures:
https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh

Usage:
sh check_staged_release.sh 2843 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Robert Munteanu

[jira] [Resolved] (SLING-12269) Restore previous behaviour of JSONObject and JSONArray getString methods

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-12269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-12269.
-
Resolution: Fixed

Thanks for the PR [~rliechti], I have merged it.

> Restore previous behaviour of JSONObject and JSONArray getString methods
> 
>
> Key: SLING-12269
> URL: https://issues.apache.org/jira/browse/SLING-12269
> Project: Sling
>  Issue Type: Bug
>  Components: Commons
>Reporter: Remo Liechti
>Assignee: Remo Liechti
>Priority: Blocker
> Fix For: Commons JSON 2.0.24
>
> Attachments: SLING-12269.patch
>
>
> With the new internal release 2.0.22, there seems to be a different behaviour 
> when it comes to get values from JSONObject.
> The new version checks for types and throws an exception, as of the old 
> version simply called toString() on any object found.
> *Old:*
> {code:java}
> public String getString(String key) throws JSONException {
>   return get(key).toString();
> }{code}
> *New:*
> {{}}
> {code:java}
> public String getString(String key) throws JSONException {
>   Objectobject=this.get(key);
>   if (objectinstanceofString) {
>     return (String) object;
>      }
>   throwwrongValueFormatException(key, "string", object, null);
> }{code}
>  
> Same is true for all other types, such as getInt, getLong etc.
> There might be more such small differences in behaviour.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)