Re: Maven Launchpad Plugin : Support for other files than bundles

2010-08-11 Thread Carsten Ziegeler
Justin Edelson  wrote
> src/main/resources won't work?

Not quiet as one would need it. If I put something under
src/main/resources/foo/bar.txt it ends up in the standalone jar under
/foo/bar.txt which is fine - so I could use something like
/resources/install etc.
In the resulting war this ends up in /WEB-INF/classes/foo/bar.txt

As long as I just want to get one resulting artifact I'm fine - so this
solves my use case; but in the general use case this needs to be adapted
somehow.

Carsten
> 
> On Aug 11, 2010, at 3:04 AM, Carsten Ziegeler  wrote:
> 
>> Justin Edelson  wrote
>>
>>>
>>> As with the launchpad plugin's current goals, I would suggest prototyping 
>>> with the existing Maven plugins (maven-resources-plugin and 
>>> maven-jar-plugin in this case) and then decide if we need new 
>>> goals/functionality. 
>> Yes, this was my initial thought as well - but I failed to see how this
>> could be done in a general way so that it works for all generated
>> artifacts. Do you have an idea how this could work?
>>
>> Regards
>> Carsten
>> -- 
>> Carsten Ziegeler
>> cziege...@apache.org
> 


-- 
Carsten Ziegeler
cziege...@apache.org


Re: Maven Launchpad Plugin : Support for other files than bundles

2010-08-11 Thread Justin Edelson
src/main/resources won't work?

On Aug 11, 2010, at 3:04 AM, Carsten Ziegeler  wrote:

> Justin Edelson  wrote
> 
>> 
>> As with the launchpad plugin's current goals, I would suggest prototyping 
>> with the existing Maven plugins (maven-resources-plugin and maven-jar-plugin 
>> in this case) and then decide if we need new goals/functionality. 
> Yes, this was my initial thought as well - but I failed to see how this
> could be done in a general way so that it works for all generated
> artifacts. Do you have an idea how this could work?
> 
> Regards
> Carsten
> -- 
> Carsten Ziegeler
> cziege...@apache.org


Re: Maven Launchpad Plugin : Support for other files than bundles

2010-08-11 Thread Carsten Ziegeler
Justin Edelson  wrote

> 
> As with the launchpad plugin's current goals, I would suggest prototyping 
> with the existing Maven plugins (maven-resources-plugin and maven-jar-plugin 
> in this case) and then decide if we need new goals/functionality. 
Yes, this was my initial thought as well - but I failed to see how this
could be done in a general way so that it works for all generated
artifacts. Do you have an idea how this could work?

Regards
Carsten
-- 
Carsten Ziegeler
cziege...@apache.org


Re: Maven Launchpad Plugin : Support for other files than bundles

2010-08-09 Thread Justin Edelson


On Aug 9, 2010, at 11:44 AM, Carsten Ziegeler  wrote:

> Hi Justin,
> 
> Justin Edelson  wrote
>> 
>> 
>> On Aug 6, 2010, at 11:41 AM, Carsten Ziegeler  wrote:
>> 
>>> Hi,
>>> 
>>> does our maven launchpad plugin support including other artifacts than
>>> bundles by just listing them in the XML file?
>>> 
>> 
>> Assuming you're talking about src/main/bundles/list.xml, no, this just 
>> handles bundles (i.e. Maven artifacts).
> Yes, sorry I was a little bit in a hurry while writing the mail :)
> It is maven artifacts or bundles? :) So if I would reference a plain jar
> file (which is not a bundle) this jar would be included as well, I assume.

To be exact, they're Maven artifacts. The plugin makes no attempt to validate 
that these artifacts are valid bundles.
> 
>>> In addition I would like to add configuration files - usually these
>>> files are not available as dependencies. I see two options:
>>> - either include them as resources and the launchpad plugin could just
>>> copy the src/main/resources directory
>> 
>> In general, this is the right way IMHO, but... 
>> 
>>> - having a separate project for this stuff - and then just reference the
>>> dependency from the builder project. As this is a resource dependency
>>> the jar/zip gets extracted when included
>> 
>> What configs do you envision including in launchpad? I assumed that this 
>> functionally would only be used downstream, i.e. By something like Sakai or 
>> IKS.
>> 
>> If there are going to be 'standard' configs, then I think we probably should 
>> have a separate project, a la launchpad.base so that they can be easily 
>> consumed downstream, but let's cross that bridge when we get to it.
>> 
> I don't envision any configs for the launchpad we ship with Sling and I
> agree that this is downstream functionality. But I would like to have
> support in the maven launchpad plugin which enables downstream apps
> based on launchpad to easily include configs etc.
> 
> The simplest way would be to include all resources from
> /src/main/resources and put them under a predefined path in the
> resulting launchpad.
> 
> WDYT?

As with the launchpad plugin's current goals, I would suggest prototyping with 
the existing Maven plugins (maven-resources-plugin and maven-jar-plugin in this 
case) and then decide if we need new goals/functionality. 

Justin
> 
> Regards
> Carsten
> 
> -- 
> Carsten Ziegeler
> cziege...@apache.org


Re: Maven Launchpad Plugin : Support for other files than bundles

2010-08-09 Thread Carsten Ziegeler
Hi Justin,

Justin Edelson  wrote
> 
> 
> On Aug 6, 2010, at 11:41 AM, Carsten Ziegeler  wrote:
> 
>> Hi,
>>
>> does our maven launchpad plugin support including other artifacts than
>> bundles by just listing them in the XML file?
>>
> 
> Assuming you're talking about src/main/bundles/list.xml, no, this just 
> handles bundles (i.e. Maven artifacts).
Yes, sorry I was a little bit in a hurry while writing the mail :)
It is maven artifacts or bundles? :) So if I would reference a plain jar
file (which is not a bundle) this jar would be included as well, I assume.

>> In addition I would like to add configuration files - usually these
>> files are not available as dependencies. I see two options:
>> - either include them as resources and the launchpad plugin could just
>> copy the src/main/resources directory
> 
> In general, this is the right way IMHO, but... 
> 
>> - having a separate project for this stuff - and then just reference the
>> dependency from the builder project. As this is a resource dependency
>> the jar/zip gets extracted when included
> 
> What configs do you envision including in launchpad? I assumed that this 
> functionally would only be used downstream, i.e. By something like Sakai or 
> IKS.
> 
> If there are going to be 'standard' configs, then I think we probably should 
> have a separate project, a la launchpad.base so that they can be easily 
> consumed downstream, but let's cross that bridge when we get to it.
> 
I don't envision any configs for the launchpad we ship with Sling and I
agree that this is downstream functionality. But I would like to have
support in the maven launchpad plugin which enables downstream apps
based on launchpad to easily include configs etc.

The simplest way would be to include all resources from
/src/main/resources and put them under a predefined path in the
resulting launchpad.

WDYT?

Regards
Carsten

-- 
Carsten Ziegeler
cziege...@apache.org


Re: Maven Launchpad Plugin : Support for other files than bundles

2010-08-06 Thread Justin Edelson


On Aug 6, 2010, at 11:41 AM, Carsten Ziegeler  wrote:

> Hi,
> 
> does our maven launchpad plugin support including other artifacts than
> bundles by just listing them in the XML file?
> 

Assuming you're talking about src/main/bundles/list.xml, no, this just handles 
bundles (i.e. Maven artifacts).

> In addition I would like to add configuration files - usually these
> files are not available as dependencies. I see two options:
> - either include them as resources and the launchpad plugin could just
> copy the src/main/resources directory

In general, this is the right way IMHO, but... 

> - having a separate project for this stuff - and then just reference the
> dependency from the builder project. As this is a resource dependency
> the jar/zip gets extracted when included

What configs do you envision including in launchpad? I assumed that this 
functionally would only be used downstream, i.e. By something like Sakai or IKS.

If there are going to be 'standard' configs, then I think we probably should 
have a separate project, a la launchpad.base so that they can be easily 
consumed downstream, but let's cross that bridge when we get to it.

Justin  
> 
> 
> WDYT?
> 
> Regards
> Carsten
> -- 
> Carsten Ziegeler
> cziege...@apache.org


Maven Launchpad Plugin : Support for other files than bundles

2010-08-06 Thread Carsten Ziegeler
Hi,

does our maven launchpad plugin support including other artifacts than
bundles by just listing them in the XML file?

In addition I would like to add configuration files - usually these
files are not available as dependencies. I see two options:
- either include them as resources and the launchpad plugin could just
copy the src/main/resources directory
- having a separate project for this stuff - and then just reference the
dependency from the builder project. As this is a resource dependency
the jar/zip gets extracted when included


WDYT?

Regards
Carsten
-- 
Carsten Ziegeler
cziege...@apache.org