[jira] [Commented] (SLING-7692) MockSession.revert(false) should send UnsupportedOperationException
[ https://issues.apache.org/jira/browse/SLING-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496250#comment-16496250 ] Nicolas Peltier commented on SLING-7692: [~sseif...@pro-vision.de] right but if the backup is a deep copy of the items map (copying each itemData element), reverting to it would effectively work, or am i missing something? > MockSession.revert(false) should send UnsupportedOperationException > --- > > Key: SLING-7692 > URL: https://issues.apache.org/jira/browse/SLING-7692 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Testing JCR Mock 1.3.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Testing JCR Mock 1.3.4 > > > MockSession does not cancel the changes when refresh(false) is called, hence > resolver.revert() not working in case JCR_MOCK is used -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Reopened] (SLING-7692) MockSession.revert(false) should send UnsupportedOperationException
[ https://issues.apache.org/jira/browse/SLING-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier reopened SLING-7692: great, re-opening, and re-changing the subject :-D > MockSession.revert(false) should send UnsupportedOperationException > --- > > Key: SLING-7692 > URL: https://issues.apache.org/jira/browse/SLING-7692 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Testing JCR Mock 1.3.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Testing JCR Mock 1.3.4 > > > MockSession does not cancel the changes when refresh(false) is called, hence > resolver.revert() not working in case JCR_MOCK is used -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7692) MockSession.revert(false) should send UnsupportedOperationException
[ https://issues.apache.org/jira/browse/SLING-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496244#comment-16496244 ] Nicolas Peltier commented on SLING-7692: [~sseif...@pro-vision.de] re-thinking about it, wouldn't it be acceptable to : # backup the items map at save time # revert to the backup if refresh is false? wdyt? > MockSession.revert(false) should send UnsupportedOperationException > --- > > Key: SLING-7692 > URL: https://issues.apache.org/jira/browse/SLING-7692 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Testing JCR Mock 1.3.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Testing JCR Mock 1.3.4 > > > MockSession does not cancel the changes when refresh(false) is called, hence > resolver.revert() not working in case JCR_MOCK is used -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-7692) MockSession should support revert(false)
[ https://issues.apache.org/jira/browse/SLING-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-7692. Resolution: Fixed Assignee: Nicolas Peltier Fix Version/s: Testing JCR Mock 1.3.4 > MockSession should support revert(false) > > > Key: SLING-7692 > URL: https://issues.apache.org/jira/browse/SLING-7692 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Testing JCR Mock 1.3.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Testing JCR Mock 1.3.4 > > > MockSession does not cancel the changes when refresh(false) is called, hence > resolver.revert() not working in case JCR_MOCK is used -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-7692) MockSession should support revert(false)
Nicolas Peltier created SLING-7692: -- Summary: MockSession should support revert(false) Key: SLING-7692 URL: https://issues.apache.org/jira/browse/SLING-7692 Project: Sling Issue Type: Improvement Components: Testing Affects Versions: Testing JCR Mock 1.3.2 Reporter: Nicolas Peltier MockSession does not cancel the changes when refresh(false) is called, hence resolver.revert() not working in case JCR_MOCK is used -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7692) MockSession.revert(false) support should be clearer
[ https://issues.apache.org/jira/browse/SLING-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499946#comment-16499946 ] Nicolas Peltier commented on SLING-7692: [~sseif...@pro-vision.de] done. > MockSession.revert(false) support should be clearer > --- > > Key: SLING-7692 > URL: https://issues.apache.org/jira/browse/SLING-7692 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Testing JCR Mock 1.3.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Testing JCR Mock 1.3.4 > > Time Spent: 20m > Remaining Estimate: 0h > > MockSession does not cancel the changes when refresh(false) is called, hence > resolver.revert() not working in case JCR_MOCK is used -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7692) MockSession.revert(false) support should be clearer
[ https://issues.apache.org/jira/browse/SLING-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-7692: --- Summary: MockSession.revert(false) support should be clearer (was: MockSession.revert(false) should be supported) > MockSession.revert(false) support should be clearer > --- > > Key: SLING-7692 > URL: https://issues.apache.org/jira/browse/SLING-7692 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Testing JCR Mock 1.3.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Testing JCR Mock 1.3.4 > > Time Spent: 10m > Remaining Estimate: 0h > > MockSession does not cancel the changes when refresh(false) is called, hence > resolver.revert() not working in case JCR_MOCK is used -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7692) MockSession.revert(false) should be supported
[ https://issues.apache.org/jira/browse/SLING-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497746#comment-16497746 ] Nicolas Peltier commented on SLING-7692: fine :-) https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/1 > MockSession.revert(false) should be supported > - > > Key: SLING-7692 > URL: https://issues.apache.org/jira/browse/SLING-7692 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Testing JCR Mock 1.3.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Testing JCR Mock 1.3.4 > > Time Spent: 10m > Remaining Estimate: 0h > > MockSession does not cancel the changes when refresh(false) is called, hence > resolver.revert() not working in case JCR_MOCK is used -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (SLING-7692) MockSession.revert(false) should be supported
[
https://issues.apache.org/jira/browse/SLING-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497669#comment-16497669
]
Nicolas Peltier edited comment on SLING-7692 at 6/1/18 7:28 AM:
{quote}would be better to do such things no a branch first{quote} yeah sorry
about that. Do you think --force push on github would be reflected on gitbox?
{quote}jcr-mock has support for multiple sessions{quote} isn't this the issue?
I mean the problem then is not only refresh(false) should throw unsupported,
but refresh(true & false). I guess then it drills down either to support
multiple session, and not support refreshes, either not support multiple
session, and support refresh(false) (refresh(true) being cool then as a NOP).
I'd lean towards the later as i see less cases of multiple session than reverts
in a unit test context, but i'll take your word.
was (Author: npeltier):
{quote}would be better to do such things no a branch first{quote} yeah sorry
about that. Do you think --force push on github would be reflected on gitbox?
{quote}jcr-mock has support for multiple sessions{quote} isn't this the issue?
I mean the problem then is not only refresh(false) should throw unsupported,
but refresh(*). I guess then it drills down either to support multiple session,
and not support refreshes, either not support multiple session, and support
refresh(false) (refresh(true) being cool then as a NOP).
I'd lean towards the later as i see less cases of multiple session than reverts
in a unit test context, but i'll take your word.
> MockSession.revert(false) should be supported
> -
>
> Key: SLING-7692
> URL: https://issues.apache.org/jira/browse/SLING-7692
> Project: Sling
> Issue Type: Improvement
> Components: Testing
>Affects Versions: Testing JCR Mock 1.3.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Testing JCR Mock 1.3.4
>
>
> MockSession does not cancel the changes when refresh(false) is called, hence
> resolver.revert() not working in case JCR_MOCK is used
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7692) MockSession.revert(false) should be supported
[
https://issues.apache.org/jira/browse/SLING-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497669#comment-16497669
]
Nicolas Peltier commented on SLING-7692:
{quote}would be better to do such things no a branch first{quote} yeah sorry
about that. Do you think --force push on github would be reflected on gitbox?
{quote}jcr-mock has support for multiple sessions{quote} isn't this the issue?
I mean the problem then is not only refresh(false) should throw unsupported,
but refresh(*). I guess then it drills down either to support multiple session,
and not support refreshes, either not support multiple session, and support
refresh(false) (refresh(true) being cool then as a NOP).
I'd lean towards the later as i see less cases of multiple session than reverts
in a unit test context, but i'll take your word.
> MockSession.revert(false) should be supported
> -
>
> Key: SLING-7692
> URL: https://issues.apache.org/jira/browse/SLING-7692
> Project: Sling
> Issue Type: Improvement
> Components: Testing
>Affects Versions: Testing JCR Mock 1.3.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Testing JCR Mock 1.3.4
>
>
> MockSession does not cancel the changes when refresh(false) is called, hence
> resolver.revert() not working in case JCR_MOCK is used
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (SLING-7708) Update pipes documentation
Nicolas Peltier created SLING-7708: -- Summary: Update pipes documentation Key: SLING-7708 URL: https://issues.apache.org/jira/browse/SLING-7708 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: pipes 2.0.2 Reporter: Nicolas Peltier - there are new pipes / features in release 3.0.0 that should be documented, - size=0 to get all the element is wrong, it should be size=-1 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-7707) Create Union Pipe
Nicolas Peltier created SLING-7707:
--
Summary: Create Union Pipe
Key: SLING-7707
URL: https://issues.apache.org/jira/browse/SLING-7707
Project: Sling
Issue Type: Improvement
Components: Extensions
Affects Versions: pipes 2.0.2
Reporter: Nicolas Peltier
pipe that executes its subpipes in sequence, with no relation ship between
them, and returns the union of the outputs, like a or / {{+}} operator (as
opposed to actual Container Pipe that chain them together and could be the
{{x}} operator)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SLING-7705) dryRun parameter no longer allows GET requests on pipe modifying content
[ https://issues.apache.org/jira/browse/SLING-7705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-7705. Resolution: Fixed Assignee: Nicolas Peltier Fix Version/s: pipes 3.0.0 > dryRun parameter no longer allows GET requests on pipe modifying content > > > Key: SLING-7705 > URL: https://issues.apache.org/jira/browse/SLING-7705 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: pipes 2.0.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: pipes 3.0.0 > > > it's not possible anymore to do a GET call on a pipe modifying content with > dry run parameter set -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-7690) Reference pipe expression should be dynamically evaluated
Nicolas Peltier created SLING-7690: -- Summary: Reference pipe expression should be dynamically evaluated Key: SLING-7690 URL: https://issues.apache.org/jira/browse/SLING-7690 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: pipes 2.0.2 Reporter: Nicolas Peltier reference pipe expression is computed at creation, it should be re-evaluated at each "getOutput" call if it has changed to allow dynamic references -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SLING-7690) Reference pipe expression should be dynamically evaluated
[ https://issues.apache.org/jira/browse/SLING-7690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier reassigned SLING-7690: -- Assignee: Nicolas Peltier > Reference pipe expression should be dynamically evaluated > - > > Key: SLING-7690 > URL: https://issues.apache.org/jira/browse/SLING-7690 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: pipes 2.0.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > > reference pipe expression is computed at creation, it should be re-evaluated > at each "getOutput" call if it has changed to allow dynamic references -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-7691) getPreviousPipe of a referenced container's first pipe should be the referrer's
Nicolas Peltier created SLING-7691: -- Summary: getPreviousPipe of a referenced container's first pipe should be the referrer's Key: SLING-7691 URL: https://issues.apache.org/jira/browse/SLING-7691 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: pipes 2.0.2 Reporter: Nicolas Peltier getPrevious pipe of the first pipe of a container, if referred, should be the referrer's -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-7690) Reference pipe expression should be dynamically evaluated
[ https://issues.apache.org/jira/browse/SLING-7690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-7690. Resolution: Fixed Fix Version/s: pipes 3.0.0 > Reference pipe expression should be dynamically evaluated > - > > Key: SLING-7690 > URL: https://issues.apache.org/jira/browse/SLING-7690 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: pipes 2.0.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: pipes 3.0.0 > > > reference pipe expression is computed at creation, it should be re-evaluated > at each "getOutput" call if it has changed to allow dynamic references -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-7691) getPreviousPipe of a referenced container's first pipe should be the referrer's
[ https://issues.apache.org/jira/browse/SLING-7691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-7691. Resolution: Fixed Assignee: Nicolas Peltier Fix Version/s: pipes 3.0.0 > getPreviousPipe of a referenced container's first pipe should be the > referrer's > --- > > Key: SLING-7691 > URL: https://issues.apache.org/jira/browse/SLING-7691 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: pipes 2.0.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: pipes 3.0.0 > > > getPrevious pipe of the first pipe of a container, if referred, should be the > referrer's -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-7693) PathPipe should support pure JCR path creation when nodeType is specified
Nicolas Peltier created SLING-7693: -- Summary: PathPipe should support pure JCR path creation when nodeType is specified Key: SLING-7693 URL: https://issues.apache.org/jira/browse/SLING-7693 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: pipes 2.0.2 Reporter: Nicolas Peltier with SLING-6998, looks like some JCR paths are no longer creatable because of some node type restrictions. When a node type is specified in the pipe configuration, we should explicitally use JCR api to create the path -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-7694) pipe support for relative input paths
Nicolas Peltier created SLING-7694:
--
Summary: pipe support for relative input paths
Key: SLING-7694
URL: https://issues.apache.org/jira/browse/SLING-7694
Project: Sling
Issue Type: Improvement
Components: Extensions
Affects Versions: pipes 2.0.2
Reporter: Nicolas Peltier
it happens that several pipes in a container need to have input processed
depending on the upper output.
In other words, we should be supporting
{{.echo("/content").echo("fruits")}} that should be the same as
{{.echo("/content/fruits")}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SLING-7693) PathPipe should support pure JCR path creation when nodeType is specified
[ https://issues.apache.org/jira/browse/SLING-7693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-7693. Resolution: Fixed Assignee: Nicolas Peltier Fix Version/s: pipes 3.0.0 > PathPipe should support pure JCR path creation when nodeType is specified > - > > Key: SLING-7693 > URL: https://issues.apache.org/jira/browse/SLING-7693 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: pipes 2.0.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: pipes 3.0.0 > > > with SLING-6998, looks like some JCR paths are no longer creatable because of > some node type restrictions. > When a node type is specified in the pipe configuration, we should > explicitally use JCR api to create the path -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-7692) MockSession.revert(false) should be supported
[ https://issues.apache.org/jira/browse/SLING-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-7692. Resolution: Fixed pls have a look [~sseif...@pro-vision.de] > MockSession.revert(false) should be supported > - > > Key: SLING-7692 > URL: https://issues.apache.org/jira/browse/SLING-7692 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Testing JCR Mock 1.3.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Testing JCR Mock 1.3.4 > > > MockSession does not cancel the changes when refresh(false) is called, hence > resolver.revert() not working in case JCR_MOCK is used -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7692) MockSession.revert(false) should be supported
[ https://issues.apache.org/jira/browse/SLING-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-7692: --- Summary: MockSession.revert(false) should be supported (was: MockSession.revert(false) should send UnsupportedOperationException) > MockSession.revert(false) should be supported > - > > Key: SLING-7692 > URL: https://issues.apache.org/jira/browse/SLING-7692 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Testing JCR Mock 1.3.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Testing JCR Mock 1.3.4 > > > MockSession does not cancel the changes when refresh(false) is called, hence > resolver.revert() not working in case JCR_MOCK is used -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-7704) create pipe execution hooks
Nicolas Peltier created SLING-7704:
--
Summary: create pipe execution hooks
Key: SLING-7704
URL: https://issues.apache.org/jira/browse/SLING-7704
Project: Sling
Issue Type: Improvement
Components: Extensions
Affects Versions: pipes 2.0.2
Reporter: Nicolas Peltier
There is a need for package pipe to build if configured. This ticket to add a
generic solution for a pipe implementation to do things when parent pipe is
over. Basically container pipe calls all its subpipe and call a ends() method.
May be a starts method would help as well.
one other nice thing would be to create {{startsHook}} and {{endsHook}}
properties, that would be pipe references to execute before or after the
configured pipe.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (SLING-7705) dryRun parameter no longer allows GET requests on pipe modifying content
Nicolas Peltier created SLING-7705: -- Summary: dryRun parameter no longer allows GET requests on pipe modifying content Key: SLING-7705 URL: https://issues.apache.org/jira/browse/SLING-7705 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: pipes 2.0.2 Reporter: Nicolas Peltier it's not possible anymore to do a GET call on a pipe modifying content with dry run parameter set -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-7759) add other "patterns" than path for filters
Nicolas Peltier created SLING-7759:
--
Summary: add other "patterns" than path for filters
Key: SLING-7759
URL: https://issues.apache.org/jira/browse/SLING-7759
Project: Sling
Issue Type: Improvement
Components: Engine
Affects Versions: Engine 2.6.12
Reporter: Nicolas Peltier
adding additional patterns to filters (right now {{sling.filter.pattern}}
allows to include them based on path only):
- path passes if sling.filter.pattern (i propose we keep it for legacy & add
sling.filter.pattern.path for consistency with what follow) regexp matches
current path,
- selector passes if sling.filter.pattern.selector is in the selector chain,
- method passes if sling.filter.pattern.method is equals to curren method,
- suffix passes if sling.filter.pattern.suffix regep matches current suffix
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7759) add other "patterns" than path for filters
[
https://issues.apache.org/jira/browse/SLING-7759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529565#comment-16529565
]
Nicolas Peltier commented on SLING-7759:
[~kwin] agreed. Will first try to get something in, and then we can discuss in
this ticket how we should amend SlingServletFilter annotations
> add other "patterns" than path for filters
> --
>
> Key: SLING-7759
> URL: https://issues.apache.org/jira/browse/SLING-7759
> Project: Sling
> Issue Type: Improvement
> Components: Engine
>Affects Versions: Engine 2.6.12
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
>
> adding additional patterns to filters (right now {{sling.filter.pattern}}
> allows to include them based on path only):
> - path passes if sling.filter.pattern (i propose we keep it for legacy & add
> sling.filter.pattern.path for consistency with what follow) regexp matches
> current path,
> - selector passes if sling.filter.pattern.selector is in the selector chain,
> - method passes if sling.filter.pattern.method is equals to curren method,
> - suffix passes if sling.filter.pattern.suffix regep matches current suffix
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7759) add other "patterns" than path for filters
[
https://issues.apache.org/jira/browse/SLING-7759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529587#comment-16529587
]
Nicolas Peltier commented on SLING-7759:
[~jsedding] agreed some consistency would be nice here. In the end servlets &
filters being tightly coupled with the {{RequestPathInfo}} instance's values.
However "registration properties" for a servlet or a filter should not be the
same exactly. For a servlet it should be generally much more exclusive than for
a filter.
* Adding multiple paths & prefix, while we have a path pattern might be enough
& simpler (even if inconsistent). may be sling.filter.pathPattern (that would
be the same as sling.filter.pattern i'd keep for )
* I think suffix still makes sense,
* resource type, why not :-)
* selector, extension, and method should MV, agreed
> add other "patterns" than path for filters
> --
>
> Key: SLING-7759
> URL: https://issues.apache.org/jira/browse/SLING-7759
> Project: Sling
> Issue Type: Improvement
> Components: Engine
>Affects Versions: Engine 2.6.12
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
>
> adding additional patterns to filters (right now {{sling.filter.pattern}}
> allows to include them based on path only):
> - path passes if sling.filter.pattern (i propose we keep it for legacy & add
> sling.filter.pattern.path for consistency with what follow) regexp matches
> current path,
> - selector passes if sling.filter.pattern.selector is in the selector chain,
> - method passes if sling.filter.pattern.method is equals to curren method,
> - suffix passes if sling.filter.pattern.suffix regep matches current suffix
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (SLING-7759) add other "patterns" than path for filters
[
https://issues.apache.org/jira/browse/SLING-7759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier reassigned SLING-7759:
--
Assignee: Nicolas Peltier
> add other "patterns" than path for filters
> --
>
> Key: SLING-7759
> URL: https://issues.apache.org/jira/browse/SLING-7759
> Project: Sling
> Issue Type: Improvement
> Components: Engine
>Affects Versions: Engine 2.6.12
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
>
> adding additional patterns to filters (right now {{sling.filter.pattern}}
> allows to include them based on path only):
> - path passes if sling.filter.pattern (i propose we keep it for legacy & add
> sling.filter.pattern.path for consistency with what follow) regexp matches
> current path,
> - selector passes if sling.filter.pattern.selector is in the selector chain,
> - method passes if sling.filter.pattern.method is equals to curren method,
> - suffix passes if sling.filter.pattern.suffix regep matches current suffix
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7759) add other "patterns" than path for filters
[
https://issues.apache.org/jira/browse/SLING-7759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529810#comment-16529810
]
Nicolas Peltier commented on SLING-7759:
[~bdelacretaz][~jsedding] what about moving those properties naming and
matching mechanism to {{requestpathinfo}} or a related class? I.e. focus on the
request description, rather than on the feature we bind to that request.
so rather sling.request.paths, sling,request.selectors, etc... ?
> add other "patterns" than path for filters
> --
>
> Key: SLING-7759
> URL: https://issues.apache.org/jira/browse/SLING-7759
> Project: Sling
> Issue Type: Improvement
> Components: Engine
>Affects Versions: Engine 2.6.12
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
>
> adding additional patterns to filters (right now {{sling.filter.pattern}}
> allows to include them based on path only):
> - path passes if sling.filter.pattern (i propose we keep it for legacy & add
> sling.filter.pattern.path for consistency with what follow) regexp matches
> current path,
> - selector passes if sling.filter.pattern.selector is in the selector chain,
> - method passes if sling.filter.pattern.method is equals to curren method,
> - suffix passes if sling.filter.pattern.suffix regep matches current suffix
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (SLING-7632) Pipe Execution Result should show an error list
Nicolas Peltier created SLING-7632: -- Summary: Pipe Execution Result should show an error list Key: SLING-7632 URL: https://issues.apache.org/jira/browse/SLING-7632 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: pipes 2.0.2 Reporter: Nicolas Peltier While not breaking the pipe execution at the first issue encountered is important in a production world when a content exception should/could be handled separately. Errors happening are "only" happening on logs. They should be tracked in the execution result as well, with path excerpt, and total #, with same limit as for results. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-7638) Pipe binding expression instantiation failure should break the containing pipe
Nicolas Peltier created SLING-7638: -- Summary: Pipe binding expression instantiation failure should break the containing pipe Key: SLING-7638 URL: https://issues.apache.org/jira/browse/SLING-7638 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: pipes 2.0.2 Reporter: Nicolas Peltier now a failed expression instantation just take the source, which is always a problem, the pipe should rather fail -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-7639) Enhance error message when additional script has erros
Nicolas Peltier created SLING-7639:
--
Summary: Enhance error message when additional script has erros
Key: SLING-7639
URL: https://issues.apache.org/jira/browse/SLING-7639
Project: Sling
Issue Type: Improvement
Components: Extensions
Affects Versions: pipes 2.0.2
Reporter: Nicolas Peltier
{{org.apache.sling.pipes.PipeBindings unable to execute ..blah.js}} is pretty
useless...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (SLING-7640) Package pipe
Nicolas Peltier created SLING-7640: -- Summary: Package pipe Key: SLING-7640 URL: https://issues.apache.org/jira/browse/SLING-7640 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: pipes 2.0.2 Reporter: Nicolas Peltier à la Authorizable pipe, both reader & writer, ability to read apache filevault package filters, or write some. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-7629) Regexp pipe
Nicolas Peltier created SLING-7629: -- Summary: Regexp pipe Key: SLING-7629 URL: https://issues.apache.org/jira/browse/SLING-7629 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: pipes 2.0.2 Reporter: Nicolas Peltier For some use case, instead of json or csv inputstream, a more unstructured input like a text file, with regexp pattern (e.g. an html file) could be used in a pipe -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-7629) Regexp pipe
[ https://issues.apache.org/jira/browse/SLING-7629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-7629. Resolution: Fixed Fix Version/s: pipes 2.0.4 > Regexp pipe > --- > > Key: SLING-7629 > URL: https://issues.apache.org/jira/browse/SLING-7629 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: pipes 2.0.2 >Reporter: Nicolas Peltier >Priority: Major > Fix For: pipes 2.0.4 > > > For some use case, instead of json or csv inputstream, a more unstructured > input like a text file, with regexp pattern (e.g. an html file) could be used > in a pipe -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7172) Change SlingQuery Pipe API
[ https://issues.apache.org/jira/browse/SLING-7172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16212814#comment-16212814 ] Nicolas Peltier commented on SLING-7172: after discussion with [~tomek.rekawek] will implement children(), find(), closest(), parents() and siblings() the old $ was children, and will be find, which is more obvious > Change SlingQuery Pipe API > -- > > Key: SLING-7172 > URL: https://issues.apache.org/jira/browse/SLING-7172 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: pipes 1.1.0 >Reporter: Nicolas Peltier > > currently SlingQuery Pipe expression is used for retrieving resources using > getChildren. This should be calling "find" which is more natural for > developers. > getChildren should still be optional (flag isDeep=false)? > we should update to 4.0 version -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (SLING-7172) Change SlingQuery Pipe API
[ https://issues.apache.org/jira/browse/SLING-7172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-7172. Resolution: Fixed Fix Version/s: pipes 1.2.0 > Change SlingQuery Pipe API > -- > > Key: SLING-7172 > URL: https://issues.apache.org/jira/browse/SLING-7172 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: pipes 1.1.0 >Reporter: Nicolas Peltier > Fix For: pipes 1.2.0 > > > currently SlingQuery Pipe expression is used for retrieving resources using > getChildren. This should be calling "find" which is more natural for > developers. > getChildren should still be optional (flag isDeep=false)? > we should update to 4.0 version -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (SLING-7759) add other "patterns" than path for filters
[
https://issues.apache.org/jira/browse/SLING-7759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16531956#comment-16531956
]
Nicolas Peltier edited comment on SLING-7759 at 7/3/18 9:35 PM:
introduced FilterPredicate in
https://github.com/apache/sling-org-apache-sling-engine/pull/3, please review.
Note
* i didn't add filter.prefix, as i'm not sure it makes sense, and it is a
complicated beast.
* I finally added paths because it is simple, although i'm not sure it makes
sense.
* Hope adding commons-lang3 is ok,
* for selectors, i just added a "OR" simple implementation
was (Author: npeltier):
introduced FilterPredicate in
https://github.com/apache/sling-org-apache-sling-engine/pull/3, please review.
Note i didn't add filter.prefix, as i'm not sure it makes sense, and it is a
complicated beast. I finally added paths because it is simple, although i'm not
sure it makes sense.
Hope adding commons-lang3 is ok
> add other "patterns" than path for filters
> --
>
> Key: SLING-7759
> URL: https://issues.apache.org/jira/browse/SLING-7759
> Project: Sling
> Issue Type: Improvement
> Components: Engine
>Affects Versions: Engine 2.6.12
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> adding additional patterns to filters (right now {{sling.filter.pattern}}
> allows to include them based on path only):
> - path passes if sling.filter.pattern (i propose we keep it for legacy & add
> sling.filter.pattern.path for consistency with what follow) regexp matches
> current path,
> - selector passes if sling.filter.pattern.selector is in the selector chain,
> - method passes if sling.filter.pattern.method is equals to curren method,
> - suffix passes if sling.filter.pattern.suffix regep matches current suffix
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7759) add other "patterns" than path for filters
[
https://issues.apache.org/jira/browse/SLING-7759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16531956#comment-16531956
]
Nicolas Peltier commented on SLING-7759:
introduced FilterPredicate in
https://github.com/apache/sling-org-apache-sling-engine/pull/3, please review.
Note i didn't add filter.prefix, as i'm not sure it makes sense, and it is a
complicated beast. I finally added paths because it is simple, although i'm not
sure it makes sense.
Hope adding commons-lang3 is ok
> add other "patterns" than path for filters
> --
>
> Key: SLING-7759
> URL: https://issues.apache.org/jira/browse/SLING-7759
> Project: Sling
> Issue Type: Improvement
> Components: Engine
>Affects Versions: Engine 2.6.12
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> adding additional patterns to filters (right now {{sling.filter.pattern}}
> allows to include them based on path only):
> - path passes if sling.filter.pattern (i propose we keep it for legacy & add
> sling.filter.pattern.path for consistency with what follow) regexp matches
> current path,
> - selector passes if sling.filter.pattern.selector is in the selector chain,
> - method passes if sling.filter.pattern.method is equals to curren method,
> - suffix passes if sling.filter.pattern.suffix regep matches current suffix
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SLING-7173) Add JMX data for pipes
[ https://issues.apache.org/jira/browse/SLING-7173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-7173. Resolution: Fixed fixed in https://github.com/apache/sling-org-apache-sling-pipes/commit/d70bd984b6b70a036f6b074b1035318a2e83ca79 > Add JMX data for pipes > -- > > Key: SLING-7173 > URL: https://issues.apache.org/jira/browse/SLING-7173 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: pipes 1.1.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: pipes 2.0.0 > > > some JMX data would be interesting to expose : > - pipe occurence calls #, > - mean time per pipe, > - ... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SLING-7173) Add JMX data for pipes
[ https://issues.apache.org/jira/browse/SLING-7173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier reassigned SLING-7173: -- Assignee: Nicolas Peltier > Add JMX data for pipes > -- > > Key: SLING-7173 > URL: https://issues.apache.org/jira/browse/SLING-7173 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: pipes 1.1.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: pipes 2.0.0 > > > some JMX data would be interesting to expose : > - pipe occurence calls #, > - mean time per pipe, > - ... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-7314) Dry run not working
[
https://issues.apache.org/jira/browse/SLING-7314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier resolved SLING-7314.
Resolution: Fixed
fixed in
https://github.com/apache/sling-org-apache-sling-pipes/commit/0e767394a0f1c42bcecdbb7406fc47c1bb976f71
> Dry run not working
> ---
>
> Key: SLING-7314
> URL: https://issues.apache.org/jira/browse/SLING-7314
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: pipes 1.1.0
>Reporter: Honwai Wong
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: pipes 2.0.0
>
>
> I worked with [~npeltier] to define a pipe to perform content migration, see
> below for an example of this pipe:
> {code}
> def plumber = getService("org.apache.sling.pipes.Plumber");
> plumber.newPipe(resourceResolver)
> .echo('/content/foo/bar').name('startPath')
> .mv('${path.startPath.replace("/bar", "/xyz")}')
> .parent().name('parentContent')
> .mkdir('${path.parentContent}/bar').with('nodeType',
> 'nt:unstructured').name('targetResource')
> .write('sling:resourceType', 'test/components/somecomponent')
> .echo('${path.parentContent}/xyz')
> .mv('${path.targetResource}/xyz')
> .runWith("dryRun", "true");
> {code}
> However, the {{dryRun}} argument is not taken into account, the changes are
> actually persisted in the repository.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7251) Fix pipes plumber servlet IT
[
https://issues.apache.org/jira/browse/SLING-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332307#comment-16332307
]
Nicolas Peltier commented on SLING-7251:
wow thanks a lot [~olli]!
* for ACLs i don't see where you'd want some? i was assuming the ones we have
in the parents (/etc, /var) are already good?
* Service user is required for certain tasks (async pipes mostly), but for the
rest, i use the user from the request.
* {{target/failsafe-reports}} is good but i hate the xml format
> Fix pipes plumber servlet IT
> -
>
> Key: SLING-7251
> URL: https://issues.apache.org/jira/browse/SLING-7251
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: pipes 2.0.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
>
> new Plumber servlet IT fail. This should be fixed
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7251) Fix pipes plumber servlet IT
[
https://issues.apache.org/jira/browse/SLING-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332337#comment-16332337
]
Nicolas Peltier commented on SLING-7251:
[~olli] for the ACLs, are you referring to loginAdministrative in integration
tests?
everything under {{src/main}} is tied to
- either passed in resolver (delegating to caller code the security)
- either service-user's resolver (i hadn't created in test)
if you are referring to {{src/test}}, i'll change that (now i know how to do
:-))
> Fix pipes plumber servlet IT
> -
>
> Key: SLING-7251
> URL: https://issues.apache.org/jira/browse/SLING-7251
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: pipes 2.0.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
>
> new Plumber servlet IT fail. This should be fixed
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SLING-7251) Fix pipes plumber servlet IT
[ https://issues.apache.org/jira/browse/SLING-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-7251: --- Fix Version/s: pipes 2.0.0 > Fix pipes plumber servlet IT > - > > Key: SLING-7251 > URL: https://issues.apache.org/jira/browse/SLING-7251 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: pipes 2.0.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: pipes 2.0.0 > > > new Plumber servlet IT fail. This should be fixed -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7202) o.a.j.o.j.o.ObservationManagerImpl times out eventually in pax container init
[
https://issues.apache.org/jira/browse/SLING-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332408#comment-16332408
]
Nicolas Peltier commented on SLING-7202:
[~olli] yes i do. Not sure how i was generating that message with pipes IT, but
i confirm it's gone now
> o.a.j.o.j.o.ObservationManagerImpl times out eventually in pax container init
> -
>
> Key: SLING-7202
> URL: https://issues.apache.org/jira/browse/SLING-7202
> Project: Sling
> Issue Type: Bug
> Components: Testing
>Affects Versions: Testing PaxExam 0.0.4
>Reporter: Nicolas Peltier
>Assignee: Oliver Lietz
>Priority: Major
> Attachments: success-fail-logs.tar
>
>
> pipes IT intermittently fail. When they do, after having compared to when
> they don't, look like the core cause is
> {Code}
> 2017-10-10 22:32:13,092 WARN [FelixStartLevel]
> o.a.j.o.j.o.ObservationManagerImpl [ObservationManagerImpl.java : 457] Timed
> out waiting for change processor to stop after 1000 milliseconds. Falling
> back to asynchronous stop on ChangeProcessor [listenerId=10,
> tracker=//*[1b]@org.apache.sling.jcr.resource.internal.JcrResourceListener,
> contentSession=session-17,
> eventCount=org.apache.jackrabbit.oak.stats.SimpleStats@4405759a,
> eventDuration=org.apache.jackrabbit.oak.stats.SimpleStats@4aa43935,
> commitRateLimiter=null, running=false] (listener details:
> 'JcrResourceListener [BasicObserverConfiguration [includeExternal=true,
> paths=PathSet [paths=[Path [path=/]]], excludedPaths=PathSet [paths=[Path
> [path=/libs/sling/sightly/js], Path
> [path=/apps/sling/servlet/default/SLING_av... (1907 chars cut),
> propertyNamesHint=null, changeTypes=[ADDED, REMOVED, CHANGED],
> listeners=[ResourceChangeListenerInfo [paths=PathSet [paths=[Path [path=/]]],
> resourceChangeTypes=[ADDED, REMOVED, CHANGED],
> providerChangeTypes=[PROVIDER_ADDED, PROVIDER_REMOVED],
> propertyNamesHint=null, valid=true, external=true,
> listener=org.apache.sling.servlets.resolver.internal.SlingServletResolver@3993ddcd],
> ResourceChangeListenerInfo [paths=PathSet [paths=[Path [path=/]]],
> resourceChangeTypes=[ADDED, REMOVED, CHANGED],
> providerChangeTypes=[PROVIDER_ADDED, PROVIDER_REMOVED],
> propertyNamesHint=null, valid=true, external=true,
> listener=org.apache.sling.resourceresolver.impl.mapping.MapEntries@70b4e2df],
> ResourceChangeListenerInfo [paths=PathSet [paths=[Path [path=/]]],
> resourceChangeTypes=[ADDED, REMOVED, CHANGED],
> providerChangeTypes=[PROVIDER_ADDED, PROVIDER_REMOVED],
> propertyNamesHint=null, valid=true, external=true,
> listener=org.apache.sling.i18n.impl.JcrResourceBundleProvider@60af913d')
> {Code}
> after which content loading does not work, resulting in test failing
> cc [~olli]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7251) Fix pipes plumber servlet IT
[
https://issues.apache.org/jira/browse/SLING-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332021#comment-16332021
]
Nicolas Peltier commented on SLING-7251:
[~olli] interesting. How long does the tests take for you (good indicator of
load i guess):
for me
{Code}
---
T E S T S
---
Running org.apache.sling.pipes.it.PipeBuilderIT
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 21.548 sec - in
org.apache.sling.pipes.it.PipeBuilderIT
Running org.apache.sling.pipes.it.PlumberTestIT
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 16.367 sec - in
org.apache.sling.pipes.it.PlumberTestIT
Running org.apache.sling.pipes.it.PlumberServletIT
Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 14.186 sec - in
org.apache.sling.pipes.it.PlumberServletIT
Running org.apache.sling.pipes.it.PipeModelIT
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 18.167 sec <<<
FAILURE! - in org.apache.sling.pipes.it.PipeModelIT
testListComponent(org.apache.sling.pipes.it.PipeModelIT) Time elapsed: 3.586
sec <<< ERROR!
java.io.FileNotFoundException:
http://localhost:62056/content/list-component.html
at
sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1872)
at
sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1474)
at java.net.URL.openStream(URL.java:1045)
at
org.apache.sling.pipes.it.PipeModelIT.testListComponent(PipeModelIT.java:53)
{Code}
> Fix pipes plumber servlet IT
> -
>
> Key: SLING-7251
> URL: https://issues.apache.org/jira/browse/SLING-7251
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: pipes 2.0.0
>Reporter: Nicolas Peltier
>Assignee: Oliver Lietz
>Priority: Major
>
> new Plumber servlet IT fail. This should be fixed
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7251) Fix pipes plumber servlet IT
[ https://issues.apache.org/jira/browse/SLING-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331951#comment-16331951 ] Nicolas Peltier commented on SLING-7251: [~olli] not really, looks more like random failure. Doesn't it fail for you? > Fix pipes plumber servlet IT > - > > Key: SLING-7251 > URL: https://issues.apache.org/jira/browse/SLING-7251 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: pipes 2.0.0 >Reporter: Nicolas Peltier >Priority: Major > > new Plumber servlet IT fail. This should be fixed -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-7427) Package names should be all lowercase
[
https://issues.apache.org/jira/browse/SLING-7427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier resolved SLING-7427.
Resolution: Fixed
> Package names should be all lowercase
> -
>
> Key: SLING-7427
> URL: https://issues.apache.org/jira/browse/SLING-7427
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Reporter: Oliver Lietz
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: pipes 2.0.0
>
>
> {{org.apache.sling.pipes.internal.slingQuery}}
> See [Naming a
> Package|https://docs.oracle.com/javase/tutorial/java/package/namingpkgs.html].
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7427) Package names should be all lowercase
[
https://issues.apache.org/jira/browse/SLING-7427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335554#comment-16335554
]
Nicolas Peltier commented on SLING-7427:
thanks for your vigilance [~olli]!
> Package names should be all lowercase
> -
>
> Key: SLING-7427
> URL: https://issues.apache.org/jira/browse/SLING-7427
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Reporter: Oliver Lietz
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: pipes 2.0.0
>
>
> {{org.apache.sling.pipes.internal.slingQuery}}
> See [Naming a
> Package|https://docs.oracle.com/javase/tutorial/java/package/namingpkgs.html].
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SLING-7426) Use bnd Maven plugins
[ https://issues.apache.org/jira/browse/SLING-7426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-7426. Resolution: Fixed Fix Version/s: pipes 2.0.0 Thanks [~olli] ! > Use bnd Maven plugins > - > > Key: SLING-7426 > URL: https://issues.apache.org/jira/browse/SLING-7426 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: pipes 2.0.0 >Reporter: Oliver Lietz >Assignee: Nicolas Peltier >Priority: Major > Fix For: pipes 2.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7426) Use bnd Maven plugins
[ https://issues.apache.org/jira/browse/SLING-7426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335558#comment-16335558 ] Nicolas Peltier commented on SLING-7426: is the rationale the arguments detailed here: http://njbartlett.name/2015/03/27/announcing-bnd-maven-plugin.html ? > Use bnd Maven plugins > - > > Key: SLING-7426 > URL: https://issues.apache.org/jira/browse/SLING-7426 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: pipes 2.0.0 >Reporter: Oliver Lietz >Assignee: Nicolas Peltier >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7426) Use bnd Maven plugins
[ https://issues.apache.org/jira/browse/SLING-7426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335734#comment-16335734 ] Nicolas Peltier commented on SLING-7426: thanks [~cziegeler] (cc [~olli]) will run additional checks > Use bnd Maven plugins > - > > Key: SLING-7426 > URL: https://issues.apache.org/jira/browse/SLING-7426 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: pipes 2.0.0 >Reporter: Oliver Lietz >Assignee: Nicolas Peltier >Priority: Major > Fix For: pipes 2.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-7444) Container and Reference Pipe (others?) are missing debug or trace logs
[ https://issues.apache.org/jira/browse/SLING-7444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-7444. Resolution: Fixed Fix Version/s: pipes 2.0.0 > Container and Reference Pipe (others?) are missing debug or trace logs > -- > > Key: SLING-7444 > URL: https://issues.apache.org/jira/browse/SLING-7444 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: pipes 1.1.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Trivial > Fix For: pipes 2.0.0 > > > in case things go wrong, it's hard to see what's wrong -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SLING-7444) Container and Reference Pipe (others?) are missing debug or trace logs
[ https://issues.apache.org/jira/browse/SLING-7444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier reassigned SLING-7444: -- Assignee: Nicolas Peltier > Container and Reference Pipe (others?) are missing debug or trace logs > -- > > Key: SLING-7444 > URL: https://issues.apache.org/jira/browse/SLING-7444 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: pipes 1.1.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Trivial > > in case things go wrong, it's hard to see what's wrong -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7444) Container and Reference Pipe (others?) are missing debug or trace logs
[ https://issues.apache.org/jira/browse/SLING-7444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-7444: --- Priority: Trivial (was: Major) > Container and Reference Pipe (others?) are missing debug or trace logs > -- > > Key: SLING-7444 > URL: https://issues.apache.org/jira/browse/SLING-7444 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: pipes 1.1.0 >Reporter: Nicolas Peltier >Priority: Trivial > > in case things go wrong, it's hard to see what's wrong -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7251) Fix pipes plumber servlet IT
[ https://issues.apache.org/jira/browse/SLING-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-7251: --- Fix Version/s: (was: pipes 2.0.0) > Fix pipes plumber servlet IT > - > > Key: SLING-7251 > URL: https://issues.apache.org/jira/browse/SLING-7251 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: pipes 2.0.0 >Reporter: Nicolas Peltier >Priority: Major > > new Plumber servlet IT fail. This should be fixed -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-7251) Fix pipes plumber servlet IT
[ https://issues.apache.org/jira/browse/SLING-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-7251. Resolution: Won't Fix issue depends on SLING-7202 (add it in model IT, not servlet) > Fix pipes plumber servlet IT > - > > Key: SLING-7251 > URL: https://issues.apache.org/jira/browse/SLING-7251 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: pipes 2.0.0 >Reporter: Nicolas Peltier >Priority: Major > Fix For: pipes 2.0.0 > > > new Plumber servlet IT fail. This should be fixed -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-7435) Authorizable pipe autocreate group does not handle dryRun
[ https://issues.apache.org/jira/browse/SLING-7435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-7435. Resolution: Fixed Fix Version/s: pipes 2.0.0 > Authorizable pipe autocreate group does not handle dryRun > - > > Key: SLING-7435 > URL: https://issues.apache.org/jira/browse/SLING-7435 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: pipes 2.0.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: pipes 2.0.0 > > > autocreateGroup does not handle dry Run -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-7444) Container and Reference Pipe (others?) are missing debug or trace logs
Nicolas Peltier created SLING-7444: -- Summary: Container and Reference Pipe (others?) are missing debug or trace logs Key: SLING-7444 URL: https://issues.apache.org/jira/browse/SLING-7444 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: pipes 1.1.0 Reporter: Nicolas Peltier in case things go wrong, it's hard to see what's wrong -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-7251) Fix pipes plumber servlet IT
[ https://issues.apache.org/jira/browse/SLING-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-7251. Resolution: Fixed > Fix pipes plumber servlet IT > - > > Key: SLING-7251 > URL: https://issues.apache.org/jira/browse/SLING-7251 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: pipes 2.0.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: pipes 2.0.0 > > > new Plumber servlet IT fail. This should be fixed -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SLING-7275) update sling pipes documentation
[ https://issues.apache.org/jira/browse/SLING-7275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-7275. Resolution: Fixed Assignee: Nicolas Peltier https://github.com/apache/sling-site/pull/8 will merge it when release is done > update sling pipes documentation > > > Key: SLING-7275 > URL: https://issues.apache.org/jira/browse/SLING-7275 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: pipes 2.0.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: pipes 2.0.0 > > > Documentation should be much clearer (in several pages, with nested details > only if needed), and adapted to pipes 2.0.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-7450) make write pipe able to dub a resource tree referenced by a path
Nicolas Peltier created SLING-7450: -- Summary: make write pipe able to dub a resource tree referenced by a path Key: SLING-7450 URL: https://issues.apache.org/jira/browse/SLING-7450 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: pipes 2.0.0 Reporter: Nicolas Peltier For now write pipe can only copy what's in its conf node, which might be sometimes limited, in case source changes depending on the context, or just in case you don't want to copy the whole tree in conf -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7450) make write pipe able to dub a resource tree referenced by a path
[
https://issues.apache.org/jira/browse/SLING-7450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier updated SLING-7450:
---
Description:
For now write pipe can only copy what's in its conf node, which might be
sometimes limited, in case source changes depending on the context, or just in
case you don't want to copy the whole tree in conf.
Will add the possibility to point to an existing tree, with {{expr}} string
was:For now write pipe can only copy what's in its conf node, which might be
sometimes limited, in case source changes depending on the context, or just in
case you don't want to copy the whole tree in conf
> make write pipe able to dub a resource tree referenced by a path
>
>
> Key: SLING-7450
> URL: https://issues.apache.org/jira/browse/SLING-7450
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: pipes 2.0.0
>Reporter: Nicolas Peltier
>Priority: Major
>
> For now write pipe can only copy what's in its conf node, which might be
> sometimes limited, in case source changes depending on the context, or just
> in case you don't want to copy the whole tree in conf.
> Will add the possibility to point to an existing tree, with {{expr}} string
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SLING-7450) make write pipe able to dub a resource tree referenced by a path
[
https://issues.apache.org/jira/browse/SLING-7450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier resolved SLING-7450.
Resolution: Fixed
Assignee: Nicolas Peltier
Fix Version/s: pipes 2.0.0
fixed
> make write pipe able to dub a resource tree referenced by a path
>
>
> Key: SLING-7450
> URL: https://issues.apache.org/jira/browse/SLING-7450
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: pipes 2.0.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: pipes 2.0.0
>
>
> For now write pipe can only copy what's in its conf node, which might be
> sometimes limited, in case source changes depending on the context, or just
> in case you don't want to copy the whole tree in conf.
> Will add the possibility to point to an existing tree, with {{expr}} string
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SLING-7434) Authorizable pipe autocreate group does not handle dryRun
[ https://issues.apache.org/jira/browse/SLING-7434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-7434. Resolution: Duplicate > Authorizable pipe autocreate group does not handle dryRun > - > > Key: SLING-7434 > URL: https://issues.apache.org/jira/browse/SLING-7434 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: pipes 2.0.0 >Reporter: Nicolas Peltier >Priority: Major > > autocreateGroup does not handle dry Run -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7451) Upgrade Sling Query to 4.0
[ https://issues.apache.org/jira/browse/SLING-7451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343352#comment-16343352 ] Nicolas Peltier commented on SLING-7451: [~olli] this breaks the integration tests e.g. [0] i guess this is waiting for SlingVersionResolver to update its sling query's version to 4.0 [0] [INFO] Running org.apache.sling.pipes.it.PipeBuilderIT [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 17.935 s <<< FAILURE! - in org.apache.sling.pipes.it.PipeBuilderIT [ERROR] org.apache.sling.pipes.it.PipeBuilderIT Time elapsed: 15.512 s <<< ERROR! org.ops4j.pax.exam.TestContainerException: There are unresolved bundles. See previous ERROR log messages for details. > Upgrade Sling Query to 4.0 > -- > > Key: SLING-7451 > URL: https://issues.apache.org/jira/browse/SLING-7451 > Project: Sling > Issue Type: Task > Components: Extensions >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: pipes 2.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-7793) ACLs pipes
Nicolas Peltier created SLING-7793: -- Summary: ACLs pipes Key: SLING-7793 URL: https://issues.apache.org/jira/browse/SLING-7793 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: pipes 2.0.2 Reporter: Nicolas Peltier ACLs pipes could be great, with following feature: - .allow(userName) (default allow jcr:all on currentResource to userName, can be overriden with jcr:privilege=... property), - .deny(userName) (default deny jcr:read on currentResource to userName, can be overriden with jcr:privilege) - .acls() will return current resource, with in output bindings array of ACLs mentioning principal, privilege of that resource. If current resource is an authorizable, and if some flag is set to true, then returns ACLs attached to that user in the repository. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7759) add other "patterns" than path for filters
[
https://issues.apache.org/jira/browse/SLING-7759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier updated SLING-7759:
---
Fix Version/s: Engine 2.6.14
Sling Servlet Annotations 1.1.0
> add other "patterns" than path for filters
> --
>
> Key: SLING-7759
> URL: https://issues.apache.org/jira/browse/SLING-7759
> Project: Sling
> Issue Type: Improvement
> Components: Engine
>Affects Versions: Engine 2.6.12, Sling Servlet Annotations 1.0.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Sling Servlet Annotations 1.1.0, Engine 2.6.14
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> adding additional patterns to filters (right now {{sling.filter.pattern}}
> allows to include them based on path only):
> - path passes if sling.filter.pattern (i propose we keep it for legacy & add
> sling.filter.pattern.path for consistency with what follow) regexp matches
> current path,
> - selector passes if sling.filter.pattern.selector is in the selector chain,
> - method passes if sling.filter.pattern.method is equals to curren method,
> - suffix passes if sling.filter.pattern.suffix regep matches current suffix
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SLING-7678) create gogo command provider for running & building pipe
[ https://issues.apache.org/jira/browse/SLING-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-7678. Resolution: Fixed > create gogo command provider for running & building pipe > > > Key: SLING-7678 > URL: https://issues.apache.org/jira/browse/SLING-7678 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: pipes 2.0.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: pipes 3.0.0 > > > would be nice to have gogo command to run & build pipes quickly -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SLING-7759) add other "patterns" than path for filters
[
https://issues.apache.org/jira/browse/SLING-7759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier closed SLING-7759.
--
> add other "patterns" than path for filters
> --
>
> Key: SLING-7759
> URL: https://issues.apache.org/jira/browse/SLING-7759
> Project: Sling
> Issue Type: Improvement
> Components: Engine
>Affects Versions: Engine 2.6.12, Sling Servlet Annotations 1.0.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Sling Servlet Annotations 1.1.0, Engine 2.6.14
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> adding additional patterns to filters (right now {{sling.filter.pattern}}
> allows to include them based on path only):
> - path passes if sling.filter.pattern (i propose we keep it for legacy & add
> sling.filter.pattern.path for consistency with what follow) regexp matches
> current path,
> - selector passes if sling.filter.pattern.selector is in the selector chain,
> - method passes if sling.filter.pattern.method is equals to curren method,
> - suffix passes if sling.filter.pattern.suffix regep matches current suffix
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7759) add other "patterns" than path for filters
[
https://issues.apache.org/jira/browse/SLING-7759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533501#comment-16533501
]
Nicolas Peltier commented on SLING-7759:
ok [~jsedding] merged your PR, added a few minor changes + dpe removal here
https://github.com/apache/sling-org-apache-sling-engine/pull/3/commits/b00e55e9dd13c57f00262553c87f211f2d6afb5f
as mentionned in the PR i think we should squash this. Please review and i'll
go ahead (if one reviewer is fine)
> add other "patterns" than path for filters
> --
>
> Key: SLING-7759
> URL: https://issues.apache.org/jira/browse/SLING-7759
> Project: Sling
> Issue Type: Improvement
> Components: Engine
>Affects Versions: Engine 2.6.12
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> adding additional patterns to filters (right now {{sling.filter.pattern}}
> allows to include them based on path only):
> - path passes if sling.filter.pattern (i propose we keep it for legacy & add
> sling.filter.pattern.path for consistency with what follow) regexp matches
> current path,
> - selector passes if sling.filter.pattern.selector is in the selector chain,
> - method passes if sling.filter.pattern.method is equals to curren method,
> - suffix passes if sling.filter.pattern.suffix regep matches current suffix
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (SLING-7759) add other "patterns" than path for filters
[
https://issues.apache.org/jira/browse/SLING-7759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533501#comment-16533501
]
Nicolas Peltier edited comment on SLING-7759 at 7/5/18 10:47 AM:
-
ok [~jsedding]
{quote}Handling between path and suffix matching is slightly different, as path
is set to "/" if it is
blank. Is this desired or accidental?{quote}
i'm reproducing (and covering with a unit test) behaviour before this change,
pls check initial code
{quote}Do you mean the null checks? If that's the case, I wouldn't worry.{quote}
yeah that's what i mean, again, i was lost in my lambda thinking, i find your
code much clearer, simpler, and yeah performance wise, i think that should be
completely fine.
merged your PR, added a few minor changes + dpe removal here
https://github.com/apache/sling-org-apache-sling-engine/pull/3/commits/b00e55e9dd13c57f00262553c87f211f2d6afb5f
as mentionned in the PR i think we should squash this. Please review and i'll
go ahead (if one reviewer is fine)
was (Author: npeltier):
ok [~jsedding] merged your PR, added a few minor changes + dpe removal here
https://github.com/apache/sling-org-apache-sling-engine/pull/3/commits/b00e55e9dd13c57f00262553c87f211f2d6afb5f
as mentionned in the PR i think we should squash this. Please review and i'll
go ahead (if one reviewer is fine)
> add other "patterns" than path for filters
> --
>
> Key: SLING-7759
> URL: https://issues.apache.org/jira/browse/SLING-7759
> Project: Sling
> Issue Type: Improvement
> Components: Engine
>Affects Versions: Engine 2.6.12
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> adding additional patterns to filters (right now {{sling.filter.pattern}}
> allows to include them based on path only):
> - path passes if sling.filter.pattern (i propose we keep it for legacy & add
> sling.filter.pattern.path for consistency with what follow) regexp matches
> current path,
> - selector passes if sling.filter.pattern.selector is in the selector chain,
> - method passes if sling.filter.pattern.method is equals to curren method,
> - suffix passes if sling.filter.pattern.suffix regep matches current suffix
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7759) add other "patterns" than path for filters
[
https://issues.apache.org/jira/browse/SLING-7759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533664#comment-16533664
]
Nicolas Peltier commented on SLING-7759:
[~kwin] ended up with 5 new potential properties, 4 of them are string array, 1
is a string (suffix pattern)
should i go on and create {{SlingServletFilterXXX}} classes (one class per
configuration) rather than making SlingServletFitler a uber annotation?
After the interesting read of SLING-7624, i guess creating 6 classes might be
better (one additional for sling.filter.pattern) wdyt?
> add other "patterns" than path for filters
> --
>
> Key: SLING-7759
> URL: https://issues.apache.org/jira/browse/SLING-7759
> Project: Sling
> Issue Type: Improvement
> Components: Engine
>Affects Versions: Engine 2.6.12
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> adding additional patterns to filters (right now {{sling.filter.pattern}}
> allows to include them based on path only):
> - path passes if sling.filter.pattern (i propose we keep it for legacy & add
> sling.filter.pattern.path for consistency with what follow) regexp matches
> current path,
> - selector passes if sling.filter.pattern.selector is in the selector chain,
> - method passes if sling.filter.pattern.method is equals to curren method,
> - suffix passes if sling.filter.pattern.suffix regep matches current suffix
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7759) add other "patterns" than path for filters
[
https://issues.apache.org/jira/browse/SLING-7759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537454#comment-16537454
]
Nicolas Peltier commented on SLING-7759:
[~kwin] did a PR here
https://github.com/apache/sling-org-apache-sling-servlets-annotations/pull/1
started some IT changes as well, but i'm not sure how i'm supposed to integrate
snapshot version of the engine there? Should i wait for the release?
> add other "patterns" than path for filters
> --
>
> Key: SLING-7759
> URL: https://issues.apache.org/jira/browse/SLING-7759
> Project: Sling
> Issue Type: Improvement
> Components: Engine
>Affects Versions: Engine 2.6.12, Sling Servlet Annotations 1.0.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> adding additional patterns to filters (right now {{sling.filter.pattern}}
> allows to include them based on path only):
> - path passes if sling.filter.pattern (i propose we keep it for legacy & add
> sling.filter.pattern.path for consistency with what follow) regexp matches
> current path,
> - selector passes if sling.filter.pattern.selector is in the selector chain,
> - method passes if sling.filter.pattern.method is equals to curren method,
> - suffix passes if sling.filter.pattern.suffix regep matches current suffix
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SLING-7759) add other "patterns" than path for filters
[
https://issues.apache.org/jira/browse/SLING-7759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier updated SLING-7759:
---
Affects Version/s: Sling Servlet Annotations 1.0.0
> add other "patterns" than path for filters
> --
>
> Key: SLING-7759
> URL: https://issues.apache.org/jira/browse/SLING-7759
> Project: Sling
> Issue Type: Improvement
> Components: Engine
>Affects Versions: Engine 2.6.12, Sling Servlet Annotations 1.0.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> adding additional patterns to filters (right now {{sling.filter.pattern}}
> allows to include them based on path only):
> - path passes if sling.filter.pattern (i propose we keep it for legacy & add
> sling.filter.pattern.path for consistency with what follow) regexp matches
> current path,
> - selector passes if sling.filter.pattern.selector is in the selector chain,
> - method passes if sling.filter.pattern.method is equals to curren method,
> - suffix passes if sling.filter.pattern.suffix regep matches current suffix
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SLING-7759) add other "patterns" than path for filters
[
https://issues.apache.org/jira/browse/SLING-7759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier resolved SLING-7759.
Resolution: Fixed
issue is resolved in engine and annotations. IT around annotation can come
later in the game
> add other "patterns" than path for filters
> --
>
> Key: SLING-7759
> URL: https://issues.apache.org/jira/browse/SLING-7759
> Project: Sling
> Issue Type: Improvement
> Components: Engine
>Affects Versions: Engine 2.6.12, Sling Servlet Annotations 1.0.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> adding additional patterns to filters (right now {{sling.filter.pattern}}
> allows to include them based on path only):
> - path passes if sling.filter.pattern (i propose we keep it for legacy & add
> sling.filter.pattern.path for consistency with what follow) regexp matches
> current path,
> - selector passes if sling.filter.pattern.selector is in the selector chain,
> - method passes if sling.filter.pattern.method is equals to curren method,
> - suffix passes if sling.filter.pattern.suffix regep matches current suffix
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (SLING-7772) add other scripting options for pipe expressions
Nicolas Peltier created SLING-7772: -- Summary: add other scripting options for pipe expressions Key: SLING-7772 URL: https://issues.apache.org/jira/browse/SLING-7772 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: pipes 2.0.2 Reporter: Nicolas Peltier nashorn is being deprecated (http://openjdk.java.net/jeps/335). There might be another option soon, that will be another dependency. Thinking about it, we should provide an option for script in pipe expression (which should be fairly easy to do). And may be thinking of changing the default script engine not to be JS anymore but something that does not need dependency installed, popular and performant -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7759) add other "patterns" than path for filters
[
https://issues.apache.org/jira/browse/SLING-7759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16532867#comment-16532867
]
Nicolas Peltier commented on SLING-7759:
that's great [~jsedding]!
i didn't like it neither, comes out of a strange re-absorption of java 8 code
in java 7, and your version is much better.
- The only thing bugging me here is that we'll test over & over presence of a
given configuration, even if we know from registration it is (or not) here,
will think about a way to have best of both worlds,
- How do i do with your commit? should i merge it, and redo a commit, or should
i amend my initial commit (losing your name), problem with the later that seems
the better to me is that we'll end up with 3 commits and we might only need one?
> add other "patterns" than path for filters
> --
>
> Key: SLING-7759
> URL: https://issues.apache.org/jira/browse/SLING-7759
> Project: Sling
> Issue Type: Improvement
> Components: Engine
>Affects Versions: Engine 2.6.12
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> adding additional patterns to filters (right now {{sling.filter.pattern}}
> allows to include them based on path only):
> - path passes if sling.filter.pattern (i propose we keep it for legacy & add
> sling.filter.pattern.path for consistency with what follow) regexp matches
> current path,
> - selector passes if sling.filter.pattern.selector is in the selector chain,
> - method passes if sling.filter.pattern.method is equals to curren method,
> - suffix passes if sling.filter.pattern.suffix regep matches current suffix
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7251) Fix pipes plumber servlet IT
[ https://issues.apache.org/jira/browse/SLING-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334241#comment-16334241 ] Nicolas Peltier commented on SLING-7251: [~olli] last (hopefully) question, is testing.paxexam 1.0.0 close to be released? pipes 2.0.0 should be, and i guess snapshot deps are bad > Fix pipes plumber servlet IT > - > > Key: SLING-7251 > URL: https://issues.apache.org/jira/browse/SLING-7251 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: pipes 2.0.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: pipes 2.0.0 > > > new Plumber servlet IT fail. This should be fixed -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-7425) Add service user and base integration tests on this in sling pipes
Nicolas Peltier created SLING-7425: -- Summary: Add service user and base integration tests on this in sling pipes Key: SLING-7425 URL: https://issues.apache.org/jira/browse/SLING-7425 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: pipes 2.0.0 Reporter: Nicolas Peltier would be better to have a service user in IT so we can test: - asynchronous registration & execution, - pipes executed with non admin resolver -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-7251) Fix pipes plumber servlet IT
[ https://issues.apache.org/jira/browse/SLING-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1633#comment-1633 ] Nicolas Peltier commented on SLING-7251: [~olli] - integrated your commit, removed service user creation (not used for now, but created SLING-7425) - didn't change maven-bundle-plugin to bnd's could that be discussed more widely as a general best practice for sling's projects? > Fix pipes plumber servlet IT > - > > Key: SLING-7251 > URL: https://issues.apache.org/jira/browse/SLING-7251 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: pipes 2.0.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: pipes 2.0.0 > > > new Plumber servlet IT fail. This should be fixed -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-7435) Authorizable pipe autocreate group does not handle dryRun
Nicolas Peltier created SLING-7435: -- Summary: Authorizable pipe autocreate group does not handle dryRun Key: SLING-7435 URL: https://issues.apache.org/jira/browse/SLING-7435 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: pipes 2.0.0 Reporter: Nicolas Peltier autocreateGroup does not handle dry Run -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-7434) Authorizable pipe autocreate group does not handle dryRun
Nicolas Peltier created SLING-7434: -- Summary: Authorizable pipe autocreate group does not handle dryRun Key: SLING-7434 URL: https://issues.apache.org/jira/browse/SLING-7434 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: pipes 2.0.0 Reporter: Nicolas Peltier autocreateGroup does not handle dry Run -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SLING-7435) Authorizable pipe autocreate group does not handle dryRun
[ https://issues.apache.org/jira/browse/SLING-7435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier reassigned SLING-7435: -- Assignee: Nicolas Peltier > Authorizable pipe autocreate group does not handle dryRun > - > > Key: SLING-7435 > URL: https://issues.apache.org/jira/browse/SLING-7435 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: pipes 2.0.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > > autocreateGroup does not handle dry Run -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SLING-7707) Create Executor Pipe
[
https://issues.apache.org/jira/browse/SLING-7707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier reassigned SLING-7707:
--
Assignee: Nicolas Peltier
> Create Executor Pipe
>
>
> Key: SLING-7707
> URL: https://issues.apache.org/jira/browse/SLING-7707
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: pipes 2.0.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: pipes 3.0.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> pipe that executes its subpipes in sequence or in parallel, with no relation
> ship between them, and returns the union of the outputs, like a or / {{+}}
> operator (as opposed to actual Container Pipe that chain them together and
> could be the {{x}} operator)
> Considering subpipe1, subpipe2, ...subpipeN, we could
> - execute them in sequence (easy case),
> - execute them in parallel (default configuration for performance first, with
> {{parallel=true}} & {{maxThreads=5}} (on my laptop heavy thread consumes ~10%
> CPU except at commit time)
> one important thing to consider is the PipeBinding object should be
> duplicated and passed to the subpipe (it's ok to assume container pipe of the
> executor pipe should not have effects on its bindings). Use case for this is
> {{.echo("/content/mysite").children("some:Page").children("some:Page").name("locale").executor("ref1","ref2","ref3","ref4")}}
> should basically call, for each locale, in parallel, "ref1","ref2","ref3"
> and"ref4", that all have in their bindings path.locale to work with
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SLING-7707) Create Manifold Pipe
[
https://issues.apache.org/jira/browse/SLING-7707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier updated SLING-7707:
---
Summary: Create Manifold Pipe (was: Create Executor Pipe)
> Create Manifold Pipe
>
>
> Key: SLING-7707
> URL: https://issues.apache.org/jira/browse/SLING-7707
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: pipes 2.0.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: pipes 3.0.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> pipe that executes its subpipes in sequence or in parallel, with no relation
> ship between them, and returns the union of the outputs, like a or / {{+}}
> operator (as opposed to actual Container Pipe that chain them together and
> could be the {{x}} operator)
> Considering subpipe1, subpipe2, ...subpipeN, we could
> - execute them in sequence (easy case),
> - execute them in parallel (default configuration for performance first, with
> {{parallel=true}} & {{maxThreads=5}} (on my laptop heavy thread consumes ~10%
> CPU except at commit time)
> one important thing to consider is the PipeBinding object should be
> duplicated and passed to the subpipe (it's ok to assume container pipe of the
> executor pipe should not have effects on its bindings). Use case for this is
> {{.echo("/content/mysite").children("some:Page").children("some:Page").name("locale").executor("ref1","ref2","ref3","ref4")}}
> should basically call, for each locale, in parallel, "ref1","ref2","ref3"
> and"ref4", that all have in their bindings path.locale to work with
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SLING-7707) Create Executor Pipe
[
https://issues.apache.org/jira/browse/SLING-7707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier resolved SLING-7707.
Resolution: Fixed
> Create Executor Pipe
>
>
> Key: SLING-7707
> URL: https://issues.apache.org/jira/browse/SLING-7707
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: pipes 2.0.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: pipes 3.0.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> pipe that executes its subpipes in sequence or in parallel, with no relation
> ship between them, and returns the union of the outputs, like a or / {{+}}
> operator (as opposed to actual Container Pipe that chain them together and
> could be the {{x}} operator)
> Considering subpipe1, subpipe2, ...subpipeN, we could
> - execute them in sequence (easy case),
> - execute them in parallel (default configuration for performance first, with
> {{parallel=true}} & {{maxThreads=5}} (on my laptop heavy thread consumes ~10%
> CPU except at commit time)
> one important thing to consider is the PipeBinding object should be
> duplicated and passed to the subpipe (it's ok to assume container pipe of the
> executor pipe should not have effects on its bindings). Use case for this is
> {{.echo("/content/mysite").children("some:Page").children("some:Page").name("locale").executor("ref1","ref2","ref3","ref4")}}
> should basically call, for each locale, in parallel, "ref1","ref2","ref3"
> and"ref4", that all have in their bindings path.locale to work with
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SLING-7793) ACLs pipes
[ https://issues.apache.org/jira/browse/SLING-7793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-7793. Resolution: Fixed Assignee: Nicolas Peltier Fix Version/s: pipes 3.0.0 thx Dinesh! > ACLs pipes > -- > > Key: SLING-7793 > URL: https://issues.apache.org/jira/browse/SLING-7793 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: pipes 2.0.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: pipes 3.0.0 > > Time Spent: 5h > Remaining Estimate: 0h > > ACLs pipes could be great, with following feature: > - .allow(userName) (default allow jcr:all on currentResource to userName, can > be overriden with jcr:privilege=... property), > - .deny(userName) (default deny jcr:read on currentResource to userName, can > be overriden with jcr:privilege) > - .acls() will return current resource, with in output bindings array of ACLs > mentioning principal, privilege of that resource. If current resource is an > authorizable, and if some flag is set to true, then returns ACLs attached to > that user in the repository. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SLING-7614) write pipe should allow expression in node names
Nicolas Peltier created SLING-7614: -- Summary: write pipe should allow expression in node names Key: SLING-7614 URL: https://issues.apache.org/jira/browse/SLING-7614 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: pipes 2.0.2 Reporter: Nicolas Peltier when writing a structure, configuration should allow expressions in node names -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SLING-6771) exception occurs when write pipe has binding expression in the path
[ https://issues.apache.org/jira/browse/SLING-6771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier closed SLING-6771. -- > exception occurs when write pipe has binding expression in the path > --- > > Key: SLING-6771 > URL: https://issues.apache.org/jira/browse/SLING-6771 > Project: Sling > Issue Type: Bug > Components: Extensions >Reporter: Nicolas Peltier >Priority: Minor > > when a write pipe has a binding expression in its path (meaning it's *not* > executed from scratch), it spits out an exception from build time moaning > about binding variable not being instantiated. > There should not be any instantiation at that moment. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SLING-7614) write pipe should allow expression in node names
[ https://issues.apache.org/jira/browse/SLING-7614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-7614: --- Fix Version/s: pipes 2.0.4 > write pipe should allow expression in node names > > > Key: SLING-7614 > URL: https://issues.apache.org/jira/browse/SLING-7614 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: pipes 2.0.2 >Reporter: Nicolas Peltier >Priority: Major > Fix For: pipes 2.0.4 > > > when writing a structure, configuration should allow expressions in node names -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SLING-6037) sling pipes additionnal bindings should be configurable as resources
[ https://issues.apache.org/jira/browse/SLING-6037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier closed SLING-6037. -- > sling pipes additionnal bindings should be configurable as resources > > > Key: SLING-6037 > URL: https://issues.apache.org/jira/browse/SLING-6037 > Project: Sling > Issue Type: Improvement > Components: Extensions >Reporter: Nicolas Peltier >Priority: Major > > a bit like writers can be configured by adding a writers node, we should be > able to add a bindings node to a pipe with configured additional bindings -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SLING-7435) Authorizable pipe autocreate group does not handle dryRun
[ https://issues.apache.org/jira/browse/SLING-7435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier closed SLING-7435. -- > Authorizable pipe autocreate group does not handle dryRun > - > > Key: SLING-7435 > URL: https://issues.apache.org/jira/browse/SLING-7435 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: pipes 2.0.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: pipes 2.0.2 > > > autocreateGroup does not handle dry Run -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SLING-7434) Authorizable pipe autocreate group does not handle dryRun
[ https://issues.apache.org/jira/browse/SLING-7434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier closed SLING-7434. -- > Authorizable pipe autocreate group does not handle dryRun > - > > Key: SLING-7434 > URL: https://issues.apache.org/jira/browse/SLING-7434 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: pipes 2.0.2 >Reporter: Nicolas Peltier >Priority: Major > > autocreateGroup does not handle dry Run -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SLING-7173) Add JMX data for pipes
[ https://issues.apache.org/jira/browse/SLING-7173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier closed SLING-7173. -- > Add JMX data for pipes > -- > > Key: SLING-7173 > URL: https://issues.apache.org/jira/browse/SLING-7173 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: pipes 1.1.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: pipes 2.0.2 > > > some JMX data would be interesting to expose : > - pipe occurence calls #, > - mean time per pipe, > - ... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SLING-5407) ui for sling pipes
[
https://issues.apache.org/jira/browse/SLING-5407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier closed SLING-5407.
--
> ui for sling pipes
> --
>
> Key: SLING-5407
> URL: https://issues.apache.org/jira/browse/SLING-5407
> Project: Sling
> Issue Type: New Feature
> Components: Extensions
>Reporter: Nicolas Peltier
>Priority: Major
>
> a user interface would be nice :-) for now a tree explorer, or vault are
> needed to create the configuration and make it a bit cumbersome to create /
> update pipes.
> An interface listing available pipes, allowing to quickly configure them,
> validating also values, helping the user by showing which resources such &
> such pipes output configured as this, would make this whole tool much better.
> am thinking of a command line interface allowing such commands:
> - rm /one/single/resource
> - "find . -xpath "//element(*,nt:base)[@sling:resourceType='blah']" | rm"
> - "find . -slingQuery "[@sling:resourceType='foo']" | write
> {"sling:resourceType":"bar"}
> plus "browsing" command:
> - ls, cd, and cat
> would be in the end (i think) better than web page
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (SLING-5269) Sling Pipes IP clearance
[ https://issues.apache.org/jira/browse/SLING-5269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier closed SLING-5269. -- > Sling Pipes IP clearance > > > Key: SLING-5269 > URL: https://issues.apache.org/jira/browse/SLING-5269 > Project: Sling > Issue Type: Task > Components: Extensions >Reporter: Oliver Lietz >Assignee: Bertrand Delacretaz >Priority: Major > > This issue tracks the IP clearance for the donation of Sling Pipes > (SLING-5134). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SLING-7275) update sling pipes documentation
[ https://issues.apache.org/jira/browse/SLING-7275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier closed SLING-7275. -- > update sling pipes documentation > > > Key: SLING-7275 > URL: https://issues.apache.org/jira/browse/SLING-7275 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: pipes 2.0.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: pipes 2.0.2 > > > Documentation should be much clearer (in several pages, with nested details > only if needed), and adapted to pipes 2.0.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
