[Bug 7166] Jenkins fails trunk on two tests: 1 is dnsbl.t (can reproduce) and other is uri_text.t (can't reproduce)
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7166 --- Comment #11 from Mark Martinec mark.marti...@ijs.si --- Interesting jenkins results: On the first 'make test' pass all tests pass, including the t/uri_text.t : [...] t/zz_cleanup 1..1 # Running under perl version 5.008006 for solaris # Current time local: Thu Apr 9 10:49:13 2015 # Current time GMT: Thu Apr 9 10:49:13 2015 # Using Test.pm version 1.25 sh: chacl: not found ok 1 ok All tests successful. Files=170, Tests=3446, 1953 wallclock secs ( 1.83 usr 0.88 sys + 740.79 cusr 61.88 csys = 805.38 CPU) Result: PASS Then the following happens: + mv t/log artifacts/t.log.make_test PASTHRU=TEST_VERBOSE=1 + export PASTHRU + tee artifacts/make_disttest.log + make -e disttest TEST_VERBOSE=1 rm -rf Mail-SpamAssassin-3.4.1 /export/home/jm/tools/perl586/bin/perl -MExtUtils::Manifest=manicopy,maniread \ -e manicopy(maniread(),'Mail-SpamAssassin-3.4.1', 'best'); mkdir Mail-SpamAssassin-3.4.1 mkdir Mail-SpamAssassin-3.4.1/t mkdir Mail-SpamAssassin-3.4.1/lib mkdir Mail-SpamAssassin-3.4.1/lib/Mail mkdir Mail-SpamAssassin-3.4.1/lib/Mail/SpamAssassin mkdir Mail-SpamAssassin-3.4.1/lib/Mail/SpamAssassin/Plugin mkdir Mail-SpamAssassin-3.4.1/lib/Mail/SpamAssassin/Logger mkdir Mail-SpamAssassin-3.4.1/lib/Mail/SpamAssassin/Util mkdir Mail-SpamAssassin-3.4.1/t/data mkdir Mail-SpamAssassin-3.4.1/t/data/whitelists mkdir Mail-SpamAssassin-3.4.1/t/data/nice mkdir Mail-SpamAssassin-3.4.1/t/data/dkim mkdir Mail-SpamAssassin-3.4.1/spamd-apache2 mkdir Mail-SpamAssassin-3.4.1/spamd-apache2/lib mkdir Mail-SpamAssassin-3.4.1/spamd-apache2/lib/Mail mkdir Mail-SpamAssassin-3.4.1/spamd-apache2/lib/Mail/SpamAssassin mkdir Mail-SpamAssassin-3.4.1/spamd-apache2/lib/Mail/SpamAssassin/Spamd mkdir Mail-SpamAssassin-3.4.1/spamd-apache2/lib/Mail/SpamAssassin/Spamd/Apache2 mkdir Mail-SpamAssassin-3.4.1/rules mkdir Mail-SpamAssassin-3.4.1/t/data/nice/dkim mkdir Mail-SpamAssassin-3.4.1/t/data/spam mkdir Mail-SpamAssassin-3.4.1/lib/Mail/SpamAssassin/Conf mkdir Mail-SpamAssassin-3.4.1/spamc mkdir Mail-SpamAssassin-3.4.1/build mkdir Mail-SpamAssassin-3.4.1/ldap mkdir Mail-SpamAssassin-3.4.1/lib/Mail/SpamAssassin/BayesStore mkdir Mail-SpamAssassin-3.4.1/t/data/etc mkdir Mail-SpamAssassin-3.4.1/sql mkdir Mail-SpamAssassin-3.4.1/spamd-apache2/bin mkdir Mail-SpamAssassin-3.4.1/spamd mkdir Mail-SpamAssassin-3.4.1/lib/Mail/SpamAssassin/Bayes mkdir Mail-SpamAssassin-3.4.1/spamd-apache2/t mkdir Mail-SpamAssassin-3.4.1/spamd-apache2/t/certs mkdir Mail-SpamAssassin-3.4.1/spamd/OSXStartup mkdir Mail-SpamAssassin-3.4.1/lib/Mail/SpamAssassin/Message mkdir Mail-SpamAssassin-3.4.1/lib/Mail/SpamAssassin/Locker mkdir Mail-SpamAssassin-3.4.1/lib/Mail/SpamAssassin/Message/Metadata mkdir Mail-SpamAssassin-3.4.1/spamd-apache2/t/conf Generating META.yml cd Mail-SpamAssassin-3.4.1 /export/home/jm/tools/perl586/bin/perl Makefile.PL So the: make -e disttest TEST_VERBOSE=1 does the whole initial setup from scratch (Makefile.PL; make; ...), and sure enough, this fresh installation does not have .cf files in the rules directory and t/uri_text.t fails. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 7170] MS::Util::RegistrarBoundaries replaced by MS::RegistryBoundaries
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7170 Quanah Gibson-Mount qua...@zimbra.com changed: What|Removed |Added CC||qua...@zimbra.com --- Comment #5 from Quanah Gibson-Mount qua...@zimbra.com --- (In reply to Kevin A. McGrail from comment #4) I would assume it does not work that simply and had relied on the 1:1. Henrik, can you please look at M:S:Util for the move of trim_domain and is_domain_valid to RegistryBoundaries? Mark is certainly write it can't be correct. s/write/right/ :) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 7170] MS::Util::RegistrarBoundaries replaced by MS::RegistryBoundaries
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7170 Kevin A. McGrail kmcgr...@pccc.com changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REOPENED --- Comment #4 from Kevin A. McGrail kmcgr...@pccc.com --- (In reply to Mark Martinec from comment #3) Committed revision 1672426. - $uri = Mail::SpamAssassin::Util::RegistrarBoundaries::trim_domain($uri); + $uri = Mail::SpamAssassin::RegistryBoundaries::trim_domain($uri); -(Mail::SpamAssassin::Util::RegistrarBoundaries::is_domain_valid($uri)); +(Mail::SpamAssassin::RegistryBoundaries::is_domain_valid($uri)); Does this work??? The is_domain_valid and trim_domain in RegistryBoundaries are methods ($self as the first argument), while in RegistrarBoundaries they were plain subroutines. I would assume it does not work that simply and had relied on the 1:1. Henrik, can you please look at M:S:Util for the move of trim_domain and is_domain_valid to RegistryBoundaries? Mark is certainly write it can't be correct. Could/should the Util::uri_to_domain be turned into a thin wrapper around RegistryBoundaries::uri_to_domain instead of duplicating the code? I considered that but I'm considering it deprecated and want 3rd party plugins people to move to RegistryBoundaries ASAP. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 7166] Jenkins fails trunk on two tests: 1 is dnsbl.t (can reproduce) and other is uri_text.t (can't reproduce)
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7166 --- Comment #14 from Mark Martinec mark.marti...@ijs.si --- So a quick fix is to update the built-in list of top-level domains, at least removing the .tp and .gov.tp : This can now be closed I suppose, unless some kind soul volunteers to check that 20_aux_tlds.cf and hard-wired TLD defaults in Conf.pm are in sync. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 7170] MS::Util::RegistrarBoundaries replaced by MS::RegistryBoundaries
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7170 Kevin A. McGrail kmcgr...@pccc.com changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #2 from Kevin A. McGrail kmcgr...@pccc.com --- svn commit -m 'Fixing M:S:Util for RegistrarBoundaries move to Registry and some cleanup on docs for deprecation - bug 7170' Sendinglib/Mail/SpamAssassin/Util/RegistrarBoundaries.pm Sendinglib/Mail/SpamAssassin/Util.pm Transmitting file data .. Committed revision 1672426. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 6782] TLD update handling / RegistrarBoundaries need improving
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=6782 --- Comment #28 from AXB axb.li...@gmail.com --- Any special reason the new RegistryBoundaries.pm is not in /lib/Mail/SpamAssassin/Util ? -- You are receiving this mail because: You are the assignee for the bug.
Jenkins build is back to stable : SpamAssassin-trunk #9854
See https://builds.apache.org/job/SpamAssassin-trunk/9854/changes
[Bug 7170] MS::Util::RegistrarBoundaries replaced by MS::RegistryBoundaries
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7170 Kevin A. McGrail kmcgr...@pccc.com changed: What|Removed |Added Severity|minor |blocker Target Milestone|Undefined |3.4.2 --- Comment #6 from Kevin A. McGrail kmcgr...@pccc.com --- I realized the function in Util.pm is also being deprecated and should not be changed to the new function. I'm an idiot. Thanks for the catch Mark I have reversed my change. And UPGRADE for 3.4.1 needs to note that: Mail::SpamAssassin::Util::RegistrarBoundaries is being replaced by Mail::SpamAssassin::RegistryBoundaries so that new TLDs can be updated via 20_aux_tlds.cf delivered via sa-update. ***3rd Party Plugin Authors, Please Note*** The following functions will be removed in the next release after 3.4.1 excepting any emergency break/fix releases immediately after 3.4.1: Mail::SpamAssassin::Util::RegistrarBoundaries::is_domain_valid Mail::SpamAssassin::Util::RegistrarBoundaries::trim_domain Mail::SpamAssassin::Util::RegistrarBoundaries::split_domain Mail::SpamAssassin::Util::uri_to_domain And the following variables will also be removed: Mail::SpamAssassin::Util::RegistrarBoundaries::US_STATES Mail::SpamAssassin::Util::RegistrarBoundaries::THREE_LEVEL_DOMAINS Mail::SpamAssassin::Util::RegistrarBoundaries::TWO_LEVEL_DOMAINS Mail::SpamAssassin::Util::RegistrarBoundaries::VALID_TLDS_RE Mail::SpamAssassin::Util::RegistrarBoundaries::VALID_TLDS This change should only affect 3rd party plugin authors who will need to update their code to utilize Mail::SpamAssassin::RegistryBoundaries instead of the functions and variables in Mail::SpamAssassin::Util::RegistrarBoundaries and the function Mail::SpamAssassin::Util::uri_to_domain which are deprecated and will be removed. svn commit -m 'reversed my change on the deprecated function and cleaned up UPGRADE for RegistrarBoundaries impending removal - Bug 7170' SendingUPGRADE Sendinglib/Mail/SpamAssassin/Util.pm Transmitting file data .. Committed revision 1672441. I've added the above to UPGRADE and hence this ticket is now a ticket of what needs to be removed for the next release after 3.4.1 (which might be 3.4.2 unless we have a breakfix release(s) after 3.4.1): - A few weeks after 3.4.1 is released and solid (i.e. not needing an emergency 3.4.2), trunk should be modified to remove RegistrarBoundaries.pm - Also, the function uri_to_domain in M:S:Util should be removed - The text for uri_text.t from bug 7166 needs to be resolved because when RegistrarBoundaries is removed, we'll fail the entire test, I believe. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 7166] Jenkins fails trunk on two tests: 1 is dnsbl.t (can reproduce) and other is uri_text.t (can't reproduce)
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7166 --- Comment #12 from Mark Martinec mark.marti...@ijs.si --- So to replicate, either do the full run: make -e disttest TEST_VERBOSE=1 or cd into spamassassin-trunk/Mail-SpamAssassin-3.4.1/ (after it has been created), and: make test TEST_FILES=t/uri_text.t The spamassassin-trunk/Mail-SpamAssassin-3.4.1/rules directory (of the distribution) only contains the following files: 72_active.cf active.list init.pre languages local.cf regression_tests.cf sa-update-pubkey.txt user_prefs.template v310.pre v312.pre v320.pre v330.pre v340.pre v341.pre unlike the cvs trunk, where the rules/ contains all .cf files. -- You are receiving this mail because: You are the assignee for the bug.
Rule updates are too old - 2015-04-09
SpamAssassin version 3.3.0 has not had a rule update since 2015-04-01. SpamAssassin version 3.3.1 has not had a rule update since 2015-04-01. SpamAssassin version 3.3.2 has not had a rule update since 2015-04-01. 20150408: Spam or ham is below threshold of 150,000: http://ruleqa.spamassassin.org/?daterev=20150408 20150408: Spam: 112216, Ham: 149865 The spam and ham counts on which this script alerts are from http://ruleqa.spamassassin.org/?daterev=20150408 Click (source details) (it's tiny and low contrast). It's from the second and third columns of the line that ends with (all messages) The source to this script is http://www.chaosreigns.com/sa/update-version-mon.pl
[Bug 7170] New: MS::Util::RegistrarBoundaries replaced by MS::RegistryBoundaries
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7170 Bug ID: 7170 Summary: MS::Util::RegistrarBoundaries replaced by MS::RegistryBoundaries Product: Spamassassin Version: SVN Trunk (Latest Devel Version) Hardware: All OS: All Status: NEW Severity: minor Priority: P2 Component: Libraries Assignee: dev@spamassassin.apache.org Reporter: mark.marti...@ijs.si The docs in Mail::SpamAssassin::Util::RegistrarBoundaries claim: Mail::SpamAssassin::Util::RegistrarBoundaries - domain delegation rules DEPRECATED AND REPLACED WITH Mail::SpamAssassin::RegistryBoundaries !! DO NOT USE. This is left as fallback for third party plugins. yet the MS::Util still uses this old module: $uri = Mail::SpamAssassin::Util::RegistrarBoundaries::trim_domain($uri); (Mail::SpamAssassin::Util::RegistrarBoundaries::is_domain_valid($uri)); This should probably be fixed. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 7166] Jenkins fails trunk on two tests: 1 is dnsbl.t (can reproduce) and other is uri_text.t (can't reproduce)
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7166 --- Comment #13 from Mark Martinec mark.marti...@ijs.si --- Wikipedia: .tp was the listed Internet country code top-level domain (ccTLD) for East Timor. The letters used refer to Timor Português, or Portuguese Timor, a legacy from the nation's previous status as a Portuguese colony. The domain .tp was officially launched in December 1997 by connect.ie, an internet service provider based in Dublin, Ireland, in cooperation with the East Timorese authorities in absentia, while East Timor was under Indonesian military control. .tp remained active for the period of transition, although it now no longer complies with the ISO 3166-1 standard for the two-letter codes for the name of countries as the code for East Timor changed from TP to TL after independence. Regardless, it retained a number of domains until it was finally deleted in February 2015. So a quick fix is to update the built-in list of top-level domains, at least removing the .tp and .gov.tp : removed domain .tp from hard-coded default in Conf.pm, removed debug output from t/uri_text.t Sending lib/Mail/SpamAssassin/Conf.pm Sending t/uri_text.t Committed revision 1672316. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 7170] MS::Util::RegistrarBoundaries replaced by MS::RegistryBoundaries
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7170 Kevin A. McGrail kmcgr...@pccc.com changed: What|Removed |Added CC||kmcgr...@pccc.com --- Comment #1 from Kevin A. McGrail kmcgr...@pccc.com --- That's a mistake. Will clean up the docs a bit and fix the M:S:Util. Waiting on a make test to commit. regards, KAM -- You are receiving this mail because: You are the assignee for the bug.
[Bug 7166] Jenkins fails trunk on two tests: 1 is dnsbl.t (can reproduce) and other is uri_text.t (can't reproduce)
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7166 Kevin A. McGrail kmcgr...@pccc.com changed: What|Removed |Added Severity|blocker |normal Priority|P5 |P3 --- Comment #15 from Kevin A. McGrail kmcgr...@pccc.com --- (In reply to Mark Martinec from comment #13) So a quick fix is to update the built-in list of top-level domains, at least removing the .tp and .gov.tp : removed domain .tp from hard-coded default in Conf.pm, removed debug output from t/uri_text.t Sending lib/Mail/SpamAssassin/Conf.pm Sending t/uri_text.t Committed revision 1672316. Sorry, I knew this part but was leaving that in because it was showing an issue that when we remove the old RegistrarBoundaries functionality and rely solely on 20_aux_tlds (currently ONLY in their as a transition for 3rd party plugins), ALL the tests in uri_text.t would presumably fail. The good news is that your work really helps me confirm this is NOT a release blocker. The out of sync .tp issue brought to light a bug. Syncing the two sources of TLDs so that the test passes, isn't a fix. I think we need to fix the test implementation so that we copy 20_aux_tlds.cf. Thanks a lot also for letting us duplicate this locally as that should make it easier to resolve. I've added this as a dependency for the release of 3.4.2 noted on bug 7170 and lowered this ticket's priority and remove the blocker status for 3.4.1. regards, KAM -- You are receiving this mail because: You are the assignee for the bug.
[Bug 6782] TLD update handling / RegistrarBoundaries need improving
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=6782 --- Comment #29 from Mark Martinec mark.marti...@ijs.si --- Any special reason the new RegistryBoundaries.pm is not in /lib/Mail/SpamAssassin/Util ? They need their own namespace so that an object can be created (-new) holding the environment for its methods. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 7166] Jenkins fails trunk on two tests: 1 is dnsbl.t (can reproduce) and other is uri_text.t (can't reproduce)
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7166 --- Comment #10 from Mark Martinec mark.marti...@ijs.si --- Apart from hard-coded 01_test_rules.cf and 99_test_default.cf, all remaining .cf files are missing in the log/test_rules_copy/ directory on Jenkins. If I run the t/uri_text.t test here [...] t/uri_text.t: disabled SA debugging, print contents of ../rules/*.cf and log/test_rules_copy/* Sending t/uri_text.t Committed revision 1672275. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 7170] MS::Util::RegistrarBoundaries replaced by MS::RegistryBoundaries
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7170 --- Comment #3 from Mark Martinec mark.marti...@ijs.si --- Committed revision 1672426. - $uri = Mail::SpamAssassin::Util::RegistrarBoundaries::trim_domain($uri); + $uri = Mail::SpamAssassin::RegistryBoundaries::trim_domain($uri); -(Mail::SpamAssassin::Util::RegistrarBoundaries::is_domain_valid($uri)); +(Mail::SpamAssassin::RegistryBoundaries::is_domain_valid($uri)); Does this work??? The is_domain_valid and trim_domain in RegistryBoundaries are methods ($self as the first argument), while in RegistrarBoundaries they were plain subroutines. Could/should the Util::uri_to_domain be turned into a thin wrapper around RegistryBoundaries::uri_to_domain instead of duplicating the code? -- You are receiving this mail because: You are the assignee for the bug.
Jenkins build is still unstable: SpamAssassin-trunk #9853
See https://builds.apache.org/job/SpamAssassin-trunk/changes
