Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

[Anna Szonyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54699/
---

(Updated Dec. 16, 2016, 11:24 a.m.)


Review request for Sqoop, Attila Szabo and Szabolcs Vasas.


Changes
---

changed append based on review


Bugs: SQOOP-3081
https://issues.apache.org/jira/browse/SQOOP-3081


Repository: sqoop-trunk


Description
---

SQOOP-3081 Introduce OracleEscapeUtils.escapeIdentifiers In 
OracleUpsertOutputFormat to make it consistent with the rest of the code and 
add escaping to the rest of the column variables.


Diffs (updated)
-

  src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java 88754e7 
  src/test/com/cloudera/sqoop/manager/OracleExportTest.java 382eb92 

Diff: https://reviews.apache.org/r/54699/diff/


Testing
---

ran ant clean test, ant clean test -Dsqoop.thirdparty.lib.dir=$3rdpartylib 
-Dthirdparty=true 
-Dsqoop.test.oracle.connectstring=$connstr-Dmapred.child.java.opts="-Djava.security.egd=file:/dev/../dev/urandom"
 -Dtest.timeout=100 -Dtestcase=*racle*Test with special attention to 
OracleExportTest#testUpsertTextExport


Thanks,

Anna Szonyi

Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

[Attila Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54699/#review159427
---


Fix it, then Ship it!




Hi Anna,

Thanks for spotting this problem!
The changes looks good except a slight change in OracleUpsertRecordWriter (I've 
highlighted it in the source).

Otherwise +1.

Thanks,
Attila


src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java (line 90)


Hi Anna,

Could please move the two append command into two different lines?

Thanks,
Attila


- Attila Szabo


On Dec. 14, 2016, 11:50 a.m., Anna Szonyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54699/
> ---
> 
> (Updated Dec. 14, 2016, 11:50 a.m.)
> 
> 
> Review request for Sqoop, Attila Szabo and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3081
> https://issues.apache.org/jira/browse/SQOOP-3081
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> SQOOP-3081 Introduce OracleEscapeUtils.escapeIdentifiers In 
> OracleUpsertOutputFormat to make it consistent with the rest of the code and 
> add escaping to the rest of the column variables.
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java 88754e7 
>   src/test/com/cloudera/sqoop/manager/OracleExportTest.java 382eb92 
> 
> Diff: https://reviews.apache.org/r/54699/diff/
> 
> 
> Testing
> ---
> 
> ran ant clean test, ant clean test -Dsqoop.thirdparty.lib.dir=$3rdpartylib 
> -Dthirdparty=true 
> -Dsqoop.test.oracle.connectstring=$connstr-Dmapred.child.java.opts="-Djava.security.egd=file:/dev/../dev/urandom"
>  -Dtest.timeout=100 -Dtestcase=*racle*Test with special attention to 
> OracleExportTest#testUpsertTextExport
> 
> 
> Thanks,
> 
> Anna Szonyi
> 
>

Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

[Boglarka Egyed]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54699/#review159422
---


Ship it!




Ship It!

- Boglarka Egyed


On Dec. 14, 2016, 11:50 a.m., Anna Szonyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54699/
> ---
> 
> (Updated Dec. 14, 2016, 11:50 a.m.)
> 
> 
> Review request for Sqoop, Attila Szabo and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3081
> https://issues.apache.org/jira/browse/SQOOP-3081
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> SQOOP-3081 Introduce OracleEscapeUtils.escapeIdentifiers In 
> OracleUpsertOutputFormat to make it consistent with the rest of the code and 
> add escaping to the rest of the column variables.
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java 88754e7 
>   src/test/com/cloudera/sqoop/manager/OracleExportTest.java 382eb92 
> 
> Diff: https://reviews.apache.org/r/54699/diff/
> 
> 
> Testing
> ---
> 
> ran ant clean test, ant clean test -Dsqoop.thirdparty.lib.dir=$3rdpartylib 
> -Dthirdparty=true 
> -Dsqoop.test.oracle.connectstring=$connstr-Dmapred.child.java.opts="-Djava.security.egd=file:/dev/../dev/urandom"
>  -Dtest.timeout=100 -Dtestcase=*racle*Test with special attention to 
> OracleExportTest#testUpsertTextExport
> 
> 
> Thanks,
> 
> Anna Szonyi
> 
>

Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

[Erzsebet Szilagyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54699/#review159420
---


Ship it!




Thanks for adding testing too!

- Erzsebet Szilagyi


On Dec. 14, 2016, 12:50 p.m., Anna Szonyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54699/
> ---
> 
> (Updated Dec. 14, 2016, 12:50 p.m.)
> 
> 
> Review request for Sqoop, Attila Szabo and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3081
> https://issues.apache.org/jira/browse/SQOOP-3081
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> SQOOP-3081 Introduce OracleEscapeUtils.escapeIdentifiers In 
> OracleUpsertOutputFormat to make it consistent with the rest of the code and 
> add escaping to the rest of the column variables.
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java 88754e7 
>   src/test/com/cloudera/sqoop/manager/OracleExportTest.java 382eb92 
> 
> Diff: https://reviews.apache.org/r/54699/diff/
> 
> 
> Testing
> ---
> 
> ran ant clean test, ant clean test -Dsqoop.thirdparty.lib.dir=$3rdpartylib 
> -Dthirdparty=true 
> -Dsqoop.test.oracle.connectstring=$connstr-Dmapred.child.java.opts="-Djava.security.egd=file:/dev/../dev/urandom"
>  -Dtest.timeout=100 -Dtestcase=*racle*Test with special attention to 
> OracleExportTest#testUpsertTextExport
> 
> 
> Thanks,
> 
> Anna Szonyi
> 
>

Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

[Anna Szonyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54699/
---

(Updated Dec. 14, 2016, 11:50 a.m.)


Review request for Sqoop, Attila Szabo and Szabolcs Vasas.


Changes
---

use config for consistency


Bugs: SQOOP-3081
https://issues.apache.org/jira/browse/SQOOP-3081


Repository: sqoop-trunk


Description
---

SQOOP-3081 Introduce OracleEscapeUtils.escapeIdentifiers In 
OracleUpsertOutputFormat to make it consistent with the rest of the code and 
add escaping to the rest of the column variables.


Diffs (updated)
-

  src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java 88754e7 
  src/test/com/cloudera/sqoop/manager/OracleExportTest.java 382eb92 

Diff: https://reviews.apache.org/r/54699/diff/


Testing
---

ran ant clean test, ant clean test -Dsqoop.thirdparty.lib.dir=$3rdpartylib 
-Dthirdparty=true 
-Dsqoop.test.oracle.connectstring=$connstr-Dmapred.child.java.opts="-Djava.security.egd=file:/dev/../dev/urandom"
 -Dtest.timeout=100 -Dtestcase=*racle*Test with special attention to 
OracleExportTest#testUpsertTextExport


Thanks,

Anna Szonyi

Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

[Szabolcs Vasas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54699/#review159134
---




src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java (line 76)


Can we use a org.apache.hadoop.conf.Configuration instance for accessing 
this property instead of the system property?


- Szabolcs Vasas


On Dec. 14, 2016, 10:14 a.m., Anna Szonyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54699/
> ---
> 
> (Updated Dec. 14, 2016, 10:14 a.m.)
> 
> 
> Review request for Sqoop, Attila Szabo and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3081
> https://issues.apache.org/jira/browse/SQOOP-3081
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> SQOOP-3081 Introduce OracleEscapeUtils.escapeIdentifiers In 
> OracleUpsertOutputFormat to make it consistent with the rest of the code and 
> add escaping to the rest of the column variables.
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/SqoopOptions.java 53cc03a 
>   src/java/org/apache/sqoop/manager/oracle/OracleUtils.java aa56e70 
>   src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java 88754e7 
>   src/test/com/cloudera/sqoop/manager/OracleExportTest.java 382eb92 
> 
> Diff: https://reviews.apache.org/r/54699/diff/
> 
> 
> Testing
> ---
> 
> ran ant clean test, ant clean test -Dsqoop.thirdparty.lib.dir=$3rdpartylib 
> -Dthirdparty=true 
> -Dsqoop.test.oracle.connectstring=$connstr-Dmapred.child.java.opts="-Djava.security.egd=file:/dev/../dev/urandom"
>  -Dtest.timeout=100 -Dtestcase=*racle*Test with special attention to 
> OracleExportTest#testUpsertTextExport
> 
> 
> Thanks,
> 
> Anna Szonyi
> 
>

Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

[Anna Szonyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54699/#review159129
---




src/java/org/apache/sqoop/SqoopOptions.java (line 2735)


If this is an acceptable solution, we could change the code so that all of 
the escaping/decisions about escaping are handled by the escapeIdentifier 
method.


- Anna Szonyi


On Dec. 14, 2016, 10:14 a.m., Anna Szonyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54699/
> ---
> 
> (Updated Dec. 14, 2016, 10:14 a.m.)
> 
> 
> Review request for Sqoop, Attila Szabo and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3081
> https://issues.apache.org/jira/browse/SQOOP-3081
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> SQOOP-3081 Introduce OracleEscapeUtils.escapeIdentifiers In 
> OracleUpsertOutputFormat to make it consistent with the rest of the code and 
> add escaping to the rest of the column variables.
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/SqoopOptions.java 53cc03a 
>   src/java/org/apache/sqoop/manager/oracle/OracleUtils.java aa56e70 
>   src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java 88754e7 
>   src/test/com/cloudera/sqoop/manager/OracleExportTest.java 382eb92 
> 
> Diff: https://reviews.apache.org/r/54699/diff/
> 
> 
> Testing
> ---
> 
> ran ant clean test, ant clean test -Dsqoop.thirdparty.lib.dir=$3rdpartylib 
> -Dthirdparty=true 
> -Dsqoop.test.oracle.connectstring=$connstr-Dmapred.child.java.opts="-Djava.security.egd=file:/dev/../dev/urandom"
>  -Dtest.timeout=100 -Dtestcase=*racle*Test with special attention to 
> OracleExportTest#testUpsertTextExport
> 
> 
> Thanks,
> 
> Anna Szonyi
> 
>

Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

[Anna Szonyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54699/
---

(Updated Dec. 14, 2016, 10:14 a.m.)


Review request for Sqoop, Attila Szabo and Szabolcs Vasas.


Changes
---

changed to public static instead of System prop


Bugs: SQOOP-3081
https://issues.apache.org/jira/browse/SQOOP-3081


Repository: sqoop-trunk


Description
---

SQOOP-3081 Introduce OracleEscapeUtils.escapeIdentifiers In 
OracleUpsertOutputFormat to make it consistent with the rest of the code and 
add escaping to the rest of the column variables.


Diffs (updated)
-

  src/java/org/apache/sqoop/SqoopOptions.java 53cc03a 
  src/java/org/apache/sqoop/manager/oracle/OracleUtils.java aa56e70 
  src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java 88754e7 
  src/test/com/cloudera/sqoop/manager/OracleExportTest.java 382eb92 

Diff: https://reviews.apache.org/r/54699/diff/


Testing
---

ran ant clean test, ant clean test -Dsqoop.thirdparty.lib.dir=$3rdpartylib 
-Dthirdparty=true 
-Dsqoop.test.oracle.connectstring=$connstr-Dmapred.child.java.opts="-Djava.security.egd=file:/dev/../dev/urandom"
 -Dtest.timeout=100 -Dtestcase=*racle*Test with special attention to 
OracleExportTest#testUpsertTextExport


Thanks,

Anna Szonyi

Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

[Anna Szonyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54699/
---

(Updated Dec. 14, 2016, 9:52 a.m.)


Review request for Sqoop, Attila Szabo and Szabolcs Vasas.


Changes
---

made it compliant with 3066 + fixed per reviews


Bugs: SQOOP-3081
https://issues.apache.org/jira/browse/SQOOP-3081


Repository: sqoop-trunk


Description
---

SQOOP-3081 Introduce OracleEscapeUtils.escapeIdentifiers In 
OracleUpsertOutputFormat to make it consistent with the rest of the code and 
add escaping to the rest of the column variables.


Diffs (updated)
-

  src/java/org/apache/sqoop/SqoopOptions.java 53cc03a 
  src/java/org/apache/sqoop/manager/oracle/OracleUtils.java aa56e70 
  src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java 88754e7 
  src/test/com/cloudera/sqoop/manager/OracleExportTest.java 382eb92 

Diff: https://reviews.apache.org/r/54699/diff/


Testing
---

ran ant clean test, ant clean test -Dsqoop.thirdparty.lib.dir=$3rdpartylib 
-Dthirdparty=true 
-Dsqoop.test.oracle.connectstring=$connstr-Dmapred.child.java.opts="-Djava.security.egd=file:/dev/../dev/urandom"
 -Dtest.timeout=100 -Dtestcase=*racle*Test with special attention to 
OracleExportTest#testUpsertTextExport


Thanks,

Anna Szonyi

Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

[Anna Szonyi]

> On Dec. 13, 2016, 3:27 p.m., Szabolcs Vasas wrote:
> > src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java, line 81
> > 
> >
> > Is the tableName already escaped or shall we invoke 
> > OracleUtils.escapeIdentifier on it?

The tableName is already invoked, however you're right: this should be 
consistent throught this patch, I'll remove it from the columns too, as they 
are escaped already as well - there should probably be a central logic for 
this, as right now the escaping logic is all over the code...


- Anna


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54699/#review159010
---


On Dec. 13, 2016, 2:29 p.m., Anna Szonyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54699/
> ---
> 
> (Updated Dec. 13, 2016, 2:29 p.m.)
> 
> 
> Review request for Sqoop, Attila Szabo and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3081
> https://issues.apache.org/jira/browse/SQOOP-3081
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> SQOOP-3081 Introduce OracleEscapeUtils.escapeIdentifiers In 
> OracleUpsertOutputFormat to make it consistent with the rest of the code and 
> add escaping to the rest of the column variables.
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java 88754e7 
> 
> Diff: https://reviews.apache.org/r/54699/diff/
> 
> 
> Testing
> ---
> 
> ran ant clean test, ant clean test -Dsqoop.thirdparty.lib.dir=$3rdpartylib 
> -Dthirdparty=true 
> -Dsqoop.test.oracle.connectstring=$connstr-Dmapred.child.java.opts="-Djava.security.egd=file:/dev/../dev/urandom"
>  -Dtest.timeout=100 -Dtestcase=*racle*Test with special attention to 
> OracleExportTest#testUpsertTextExport
> 
> 
> Thanks,
> 
> Anna Szonyi
> 
>

Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

[Boglarka Egyed]

> On Dec. 13, 2016, 2:37 p.m., Erzsebet Szilagyi wrote:
> > Thank you! This change really makes our code base more consistent and safer 
> > to change later.
> > Did you consider expanding our tests along this change?

+1
Thanks for this improvement, Anna!
I would also suggest to add specific test cases to check this behavior.


- Boglarka


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54699/#review159003
---


On Dec. 13, 2016, 2:29 p.m., Anna Szonyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54699/
> ---
> 
> (Updated Dec. 13, 2016, 2:29 p.m.)
> 
> 
> Review request for Sqoop, Attila Szabo and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3081
> https://issues.apache.org/jira/browse/SQOOP-3081
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> SQOOP-3081 Introduce OracleEscapeUtils.escapeIdentifiers In 
> OracleUpsertOutputFormat to make it consistent with the rest of the code and 
> add escaping to the rest of the column variables.
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java 88754e7 
> 
> Diff: https://reviews.apache.org/r/54699/diff/
> 
> 
> Testing
> ---
> 
> ran ant clean test, ant clean test -Dsqoop.thirdparty.lib.dir=$3rdpartylib 
> -Dthirdparty=true 
> -Dsqoop.test.oracle.connectstring=$connstr-Dmapred.child.java.opts="-Djava.security.egd=file:/dev/../dev/urandom"
>  -Dtest.timeout=100 -Dtestcase=*racle*Test with special attention to 
> OracleExportTest#testUpsertTextExport
> 
> 
> Thanks,
> 
> Anna Szonyi
> 
>

Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

[Szabolcs Vasas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54699/#review159010
---




src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java (line 81)


Is the tableName already escaped or shall we invoke 
OracleUtils.escapeIdentifier on it?



src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java (line 103)


If the tableName is escaped then it is possible that the elements of 
columnNames are also already escaped. In this case do we need the 
escapeIdentifier call?



src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java (line 116)


Same as line 101.


- Szabolcs Vasas


On Dec. 13, 2016, 2:29 p.m., Anna Szonyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54699/
> ---
> 
> (Updated Dec. 13, 2016, 2:29 p.m.)
> 
> 
> Review request for Sqoop, Attila Szabo and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3081
> https://issues.apache.org/jira/browse/SQOOP-3081
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> SQOOP-3081 Introduce OracleEscapeUtils.escapeIdentifiers In 
> OracleUpsertOutputFormat to make it consistent with the rest of the code and 
> add escaping to the rest of the column variables.
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java 88754e7 
> 
> Diff: https://reviews.apache.org/r/54699/diff/
> 
> 
> Testing
> ---
> 
> ran ant clean test, ant clean test -Dsqoop.thirdparty.lib.dir=$3rdpartylib 
> -Dthirdparty=true 
> -Dsqoop.test.oracle.connectstring=$connstr-Dmapred.child.java.opts="-Djava.security.egd=file:/dev/../dev/urandom"
>  -Dtest.timeout=100 -Dtestcase=*racle*Test with special attention to 
> OracleExportTest#testUpsertTextExport
> 
> 
> Thanks,
> 
> Anna Szonyi
> 
>

Re: Review Request 54699: SQOOP-3081 use OracleEscapeUtils.escapeIdentifier in OracleUpsertOutputFormat

[Erzsebet Szilagyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54699/#review159003
---



Thank you! This change really makes our code base more consistent and safer to 
change later.
Did you consider expanding our tests along this change?

- Erzsebet Szilagyi


On Dec. 13, 2016, 3:29 p.m., Anna Szonyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54699/
> ---
> 
> (Updated Dec. 13, 2016, 3:29 p.m.)
> 
> 
> Review request for Sqoop, Attila Szabo and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3081
> https://issues.apache.org/jira/browse/SQOOP-3081
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> SQOOP-3081 Introduce OracleEscapeUtils.escapeIdentifiers In 
> OracleUpsertOutputFormat to make it consistent with the rest of the code and 
> add escaping to the rest of the column variables.
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java 88754e7 
> 
> Diff: https://reviews.apache.org/r/54699/diff/
> 
> 
> Testing
> ---
> 
> ran ant clean test, ant clean test -Dsqoop.thirdparty.lib.dir=$3rdpartylib 
> -Dthirdparty=true 
> -Dsqoop.test.oracle.connectstring=$connstr-Dmapred.child.java.opts="-Djava.security.egd=file:/dev/../dev/urandom"
>  -Dtest.timeout=100 -Dtestcase=*racle*Test with special attention to 
> OracleExportTest#testUpsertTextExport
> 
> 
> Thanks,
> 
> Anna Szonyi
> 
>