[PR] STORM-3945 - Upgrade Zookeeper to 3.8.2 & Curator 5.5.0 (storm)
rzo1 opened a new pull request, #3560: URL: https://github.com/apache/storm/pull/3560 ## What is the purpose of the change - Replace EOL Zookeeper with modern Zookeeper version. - Updates Curator - Note: Exhibitor support is dropped in modern curator -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [STORM-3944] Synchronize access to map in Multi*Metric (storm)
jnioche merged PR #3559: URL: https://github.com/apache/storm/pull/3559 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [STORM-3944] Synchronize access to map in Multi*Metric (storm)
jnioche commented on PR #3559: URL: https://github.com/apache/storm/pull/3559#issuecomment-1669688708 > If the title is changed to this format then the release tools can properly detect the linkage between Jira and PR (at release time): > > [STORM-3944] Synchronize access to map in Multi*Metric thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Test (storm)
rzo1 closed pull request #3489: Test URL: https://github.com/apache/storm/pull/3489 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Synchronize access to map in Multi*Metric; fixes STORM-3944 (storm)
jnioche opened a new pull request, #3559: URL: https://github.com/apache/storm/pull/3559 See https://issues.apache.org/jira/browse/STORM-3944 Also marks fields as final -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [STORM-3938] Unhandled InterruptedException and missing log in Supervisor's close(… (storm)
rzo1 commented on PR #3554: URL: https://github.com/apache/storm/pull/3554#issuecomment-1667646679 Can you rebase @LoggingResearch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [STORM-3939] Remove gitact build for JDK 8, set class format to JDK11 and allow introspection in test (storm)
rzo1 merged PR #3558: URL: https://github.com/apache/storm/pull/3558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm-site] dependabot[bot] closed pull request #43: Bump tzinfo from 1.2.4 to 1.2.11 in /content
dependabot[bot] closed pull request #43: Bump tzinfo from 1.2.4 to 1.2.11 in /content URL: https://github.com/apache/storm-site/pull/43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm-site] dependabot[bot] commented on pull request #43: Bump tzinfo from 1.2.4 to 1.2.11 in /content
dependabot[bot] commented on PR #43: URL: https://github.com/apache/storm-site/pull/43#issuecomment-1666166315 Looks like tzinfo is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm-site] dependabot[bot] closed pull request #44: Bump nokogiri from 1.13.3 to 1.15.3 in /content
dependabot[bot] closed pull request #44: Bump nokogiri from 1.13.3 to 1.15.3 in /content URL: https://github.com/apache/storm-site/pull/44 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm-site] dependabot[bot] commented on pull request #44: Bump nokogiri from 1.13.3 to 1.15.3 in /content
dependabot[bot] commented on PR #44: URL: https://github.com/apache/storm-site/pull/44#issuecomment-1666166117 Looks like nokogiri is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm-site] rzo1 merged pull request #40: Remove 3rd party hosted content from storm.apache.org
rzo1 merged PR #40: URL: https://github.com/apache/storm-site/pull/40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm-site] bipinprasad merged pull request #42: Storm 2.5.0 release - generate and add documents
bipinprasad merged PR #42: URL: https://github.com/apache/storm-site/pull/42 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm-site] rzo1 merged pull request #35: Update meetups.yml
rzo1 merged PR #35: URL: https://github.com/apache/storm-site/pull/35 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] rzo1 merged pull request #3557: STORM-3941 - Add .asf.yaml to GitHub repository
rzo1 merged PR #3557: URL: https://github.com/apache/storm/pull/3557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm-site] rzo1 commented on pull request #40: Remove 3rd party hosted content from storm.apache.org
rzo1 commented on PR #40: URL: https://github.com/apache/storm-site/pull/40#issuecomment-1666083450 Resolved conflicts after dependency updates from #41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm-site] dependabot[bot] closed pull request #38: Bump nokogiri from 1.13.3 to 1.14.3 in /content
dependabot[bot] closed pull request #38: Bump nokogiri from 1.13.3 to 1.14.3 in /content URL: https://github.com/apache/storm-site/pull/38 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm-site] dependabot[bot] opened a new pull request, #44: Bump nokogiri from 1.13.3 to 1.15.3 in /content
dependabot[bot] opened a new pull request, #44: URL: https://github.com/apache/storm-site/pull/44 Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.3 to 1.15.3. Release notes Sourced from https://github.com/sparklemotion/nokogiri/releases;>nokogiri's releases. 1.15.3 / 2023-07-05 Fixed Passing an object that is not a kind of XML::Node as the first parameter to CDATA.new now raises a TypeError. Previously this would result in either a segfault (CRuby) or a Java exception (JRuby). [https://redirect.github.com/sparklemotion/nokogiri/issues/2920;>#2920] Passing an object that is not a kind of XML::Node as the first parameter to Schema.from_document now raises a TypeError. Previously this would result in either a segfault (CRuby) or a Java exception (JRuby). [https://redirect.github.com/sparklemotion/nokogiri/issues/2920;>#2920] [CRuby] Passing an object that is not a kind of XML::Node as the second parameter to Text.new now raises a TypeError. Previously this would result in a segfault. [https://redirect.github.com/sparklemotion/nokogiri/issues/2920;>#2920] [CRuby] Replacing a node's children via methods like Node#inner_html=, #children=, and #replace no longer defensively dups the node's next sibling if it is a Text node. This behavior was originally adopted to work around libxml2's memory management (see https://redirect.github.com/sparklemotion/nokogiri/issues/283;>#283 and https://redirect.github.com/sparklemotion/nokogiri/issues/595;>#595) but should not have included operations involving xmlAddChild(). [https://redirect.github.com/sparklemotion/nokogiri/issues/2916;>#2916] [JRuby] Fixed NPE when serializing an unparented HTML node. [https://redirect.github.com/sparklemotion/nokogiri/issues/2559;>#2559, https://redirect.github.com/sparklemotion/nokogiri/issues/2895;>#2895] (Thanks, https://github.com/cbasguti;>@cbasguti!) sha256 checksums: 70dadf636ae026f475f07c16b12c685544d4f8a764777df629abf1f7af0f2fb5 nokogiri-1.15.3-aarch64-linux.gem 83871fa3f544dc601e27abbdef87315a77fe1270fe4904986bd3a7df9ca3d56f nokogiri-1.15.3-arm-linux.gem fa4a027478df9004a2ce91389af7b7b5a4fc790c23492dca43b210a0f8770596 nokogiri-1.15.3-arm64-darwin.gem 95d410f995364d9780c4147d8fca6974447a1ccd3a1e1b092f0408836a36cc9c nokogiri-1.15.3-java.gem 599a46b6e4f5a34dd21da06bdbd69611728304af5ef42bb183e4b4ca073fd7a3 nokogiri-1.15.3-x64-mingw-ucrt.gem 92ebfb637c9b7ba92a221b49ea3328c7e5ee79a28307d75ef55bfe4b5807face nokogiri-1.15.3-x64-mingw32.gem ee314666eca832fa71b5bb4c090be46a80aded857aa26121b3b51f3ed658a646 nokogiri-1.15.3-x86-linux.gem 44b7f18817894a5b697bab3d757b12bb7857a0218c1b2e929456a2178b34 nokogiri-1.15.3-x86-mingw32.gem 1f0bc0343f9dd1db8dd42e4c9110dd24fc11a7f923b9fa0f866e7f90739e4e7a nokogiri-1.15.3-x86_64-darwin.gem ca244ed58568d7265088f83c568d2947102fb00bac14b5bc0e63f678dcd6323d nokogiri-1.15.3-x86_64-linux.gem 876631295a85315dac37e7a71386d62d9eb452a891083cfe7505cca4805088cb nokogiri-1.15.3.gem 1.15.2 / 2023-05-24 Dependencies [JRuby] Vendored org.nokogiri:nekodtd is updated to v0.1.11.noko2. This is functionally equivalent to v0.1.11.noko1 but restores support for Java 8. Fixed [JRuby] Java 8 support is restored, fixing a regression present in v1.14.0..v1.14.4 and v1.15.0..v1.15.1. [https://redirect.github.com/sparklemotion/nokogiri/issues/2887;>#2887] sha256 checksums: 497c698f0cc0f283934c9c93064249d113408e97e5f3677b0b5111af24a67c29 nokogiri-1.15.2-aarch64-linux.gem 505ad4b80cedd12bc3c53065079cc825e7f3d4094ca7b54176ae6f3734dbe2cc nokogiri-1.15.2-arm-linux.gem bbedeaf45ce1494f51806e5fab0d31816fc4584f8e2ec757dd516b9b30847ee4 nokogiri-1.15.2-arm64-darwin.gem b15ba3c1aa5b3726d7aceb44f635250653467c5b0d04248fa0f6a6afc6515fb0 nokogiri-1.15.2-java.gem bc3cc9631c9dd7a74a59554215474da657f956ccb126391d082a2a8c45d3ee14 nokogiri-1.15.2-x64-mingw-ucrt.gem 1fd27732b161a497275798e502b31e97dfe1ab58aac02c0d6ace9cbe1fd6a38c nokogiri-1.15.2-x64-mingw32.gem /tr/table ... (truncated) Changelog Sourced from https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md;>nokogiri's changelog. 1.15.3 / 2023-07-05 Fixed Passing an object that is not a kind of XML::Node as the first parameter to CDATA.new now raises a TypeError. Previously this would result in either a segfault (CRuby) or a Java exception (JRuby). [https://redirect.github.com/sparklemotion/nokogiri/issues/2920;>#2920] Passing an object that is not a kind of XML::Node as the first parameter to Schema.from_document now raises a TypeError. Previously this would result in either a segfault (CRuby) or a Java exception (JRuby). [https://redirect.github.com/sparklemotion/nokogiri/issues/2920;>#2920] [CRuby] Passing an object that is not a kind of XML::Node as the second parameter to Text.new now raises a
[GitHub] [storm-site] dependabot[bot] commented on pull request #38: Bump nokogiri from 1.13.3 to 1.14.3 in /content
dependabot[bot] commented on PR #38: URL: https://github.com/apache/storm-site/pull/38#issuecomment-1666028716 Superseded by #44. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm-site] dependabot[bot] closed pull request #34: Bump tzinfo from 1.2.4 to 1.2.10 in /content
dependabot[bot] closed pull request #34: Bump tzinfo from 1.2.4 to 1.2.10 in /content URL: https://github.com/apache/storm-site/pull/34 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm-site] dependabot[bot] commented on pull request #34: Bump tzinfo from 1.2.4 to 1.2.10 in /content
dependabot[bot] commented on PR #34: URL: https://github.com/apache/storm-site/pull/34#issuecomment-1666025538 Superseded by #43. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm-site] dependabot[bot] opened a new pull request, #43: Bump tzinfo from 1.2.4 to 1.2.11 in /content
dependabot[bot] opened a new pull request, #43:
URL: https://github.com/apache/storm-site/pull/43
Bumps [tzinfo](https://github.com/tzinfo/tzinfo) from 1.2.4 to 1.2.11.
Release notes
Sourced from https://github.com/tzinfo/tzinfo/releases;>tzinfo's releases.
v1.2.11
Eliminate Object#untaint deprecation warnings on JRuby
9.4.0.0. https://redirect.github.com/tzinfo/tzinfo/issues/145;>#145.
https://rubygems.org/gems/tzinfo/versions/1.2.11;>TZInfo v1.2.11
on RubyGems.org
v1.2.10
Fixed a relative path traversal bug that could cause arbitrary files to
be loaded with require when used with RubyDataSource. Please refer
to
https://github.com/tzinfo/tzinfo/security/advisories/GHSA-5cm2-9h8c-rvfx;>https://github.com/tzinfo/tzinfo/security/advisories/GHSA-5cm2-9h8c-rvfx
for details. CVE-2022-31163.
Ignore the SECURITY file from Arch Linux's tzdata package. https://redirect.github.com/tzinfo/tzinfo/issues/134;>#134.
https://rubygems.org/gems/tzinfo/versions/1.2.10;>TZInfo v1.2.10
on RubyGems.org
v1.2.9
Fixed an incorrect InvalidTimezoneIdentifier exception
raised when loading a zoneinfo file that includes rules specifying an
additional transition to the final defined offset (for example,
Africa/Casablanca in version 2018e of the Time Zone Database). https://redirect.github.com/tzinfo/tzinfo/issues/123;>#123.
https://rubygems.org/gems/tzinfo/versions/1.2.9;>TZInfo v1.2.9
on RubyGems.org
v1.2.8
Added support for handling slim format zoneinfo files that
are produced by default by zic version 2020b and later. The POSIX-style TZ
string is now used calculate DST transition times after the final defined
transition in the file. The 64-bit section is now always used regardless of
whether Time has support for 64-bit times. https://redirect.github.com/tzinfo/tzinfo/issues/120;>#120.
Rubinius is no longer supported.
https://rubygems.org/gems/tzinfo/versions/1.2.8;>TZInfo v1.2.8
on RubyGems.org
v1.2.7
Fixed 'wrong number of arguments' errors when running on JRuby 9.0. https://redirect.github.com/tzinfo/tzinfo/issues/114;>#114.
Fixed warnings when running on Ruby 2.8. https://redirect.github.com/tzinfo/tzinfo/issues/112;>#112.
https://rubygems.org/gems/tzinfo/versions/1.2.7;>TZInfo v1.2.7
on RubyGems.org
v1.2.6
Timezone#strftime('%s', time) will now return the correct
number of seconds since the epoch. https://redirect.github.com/tzinfo/tzinfo/issues/91;>#91.
Removed the unused TZInfo::RubyDataSource::REQUIRE_PATH
constant.
Fixed SecurityError: Insecure operation - require exceptions
when loading data with recent Ruby releases in safe mode.
Fixed warnings when running on Ruby 2.7. https://redirect.github.com/tzinfo/tzinfo/issues/106;>#106 and https://redirect.github.com/tzinfo/tzinfo/issues/111;>#111.
https://rubygems.org/gems/tzinfo/versions/1.2.6;>TZInfo v1.2.6
on RubyGems.org
v1.2.5
Support recursively (deep) freezing Country and
Timezone instances. https://redirect.github.com/tzinfo/tzinfo/issues/80;>#80.
Allow negative daylight savings time offsets to be derived when reading
from zoneinfo files. The utc_offset and std_offset are now derived correctly
for Europe/Dublin in the 2018a and 2018b releases of the Time Zone
Database.
https://rubygems.org/gems/tzinfo/versions/1.2.5;>TZInfo v1.2.5
on RubyGems.org
Changelog
Sourced from https://github.com/tzinfo/tzinfo/blob/master/CHANGES.md;>tzinfo's
changelog.
Version 1.2.11 - 28-Jan-2023
Eliminate Object#untaint deprecation warnings on JRuby
9.4.0.0. https://redirect.github.com/tzinfo/tzinfo/issues/145;>#145.
Version 1.2.10 - 19-Jul-2022
Fixed a relative path traversal bug that could cause arbitrary files to
be
loaded with require when used with RubyDataSource.
Please refer to
https://github.com/tzinfo/tzinfo/security/advisories/GHSA-5cm2-9h8c-rvfx;>https://github.com/tzinfo/tzinfo/security/advisories/GHSA-5cm2-9h8c-rvfx
for
details. CVE-2022-31163.
Ignore the SECURITY file from Arch Linux's tzdata package. https://redirect.github.com/tzinfo/tzinfo/issues/134;>#134.
Version 1.2.9 - 16-Dec-2020
Fixed an incorrect InvalidTimezoneIdentifier exception
raised when loading a
zoneinfo file that includes rules specifying an additional transition to the
final defined offset (for example, Africa/Casablanca in version 2018e of the
Time Zone Database). https://redirect.github.com/tzinfo/tzinfo/issues/123;>#123.
Version 1.2.8 - 8-Nov-2020
Added support for handling slim format zoneinfo files that
are produced by
default by zic version 2020b and later. The POSIX-style TZ string is now used
calculate DST transition times after the final defined transition in the
file.
The 64-bit section is now always used regardless of whether Time has support
for 64-bit times.
[GitHub] [storm-site] dependabot[bot] closed pull request #39: Bump nokogiri from 1.13.3 to 1.14.3
dependabot[bot] closed pull request #39: Bump nokogiri from 1.13.3 to 1.14.3 URL: https://github.com/apache/storm-site/pull/39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm-site] dependabot[bot] commented on pull request #39: Bump nokogiri from 1.13.3 to 1.14.3
dependabot[bot] commented on PR #39: URL: https://github.com/apache/storm-site/pull/39#issuecomment-1666023600 Looks like nokogiri is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm-site] bipinprasad commented on pull request #39: Bump nokogiri from 1.13.3 to 1.14.3
bipinprasad commented on PR #39: URL: https://github.com/apache/storm-site/pull/39#issuecomment-1666023309 @dependabot recreate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm-site] dependabot[bot] closed pull request #33: Bump tzinfo from 1.2.4 to 1.2.10
dependabot[bot] closed pull request #33: Bump tzinfo from 1.2.4 to 1.2.10 URL: https://github.com/apache/storm-site/pull/33 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm-site] dependabot[bot] commented on pull request #33: Bump tzinfo from 1.2.4 to 1.2.10
dependabot[bot] commented on PR #33: URL: https://github.com/apache/storm-site/pull/33#issuecomment-1666022821 Looks like tzinfo is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm-site] bipinprasad commented on pull request #33: Bump tzinfo from 1.2.4 to 1.2.10
bipinprasad commented on PR #33: URL: https://github.com/apache/storm-site/pull/33#issuecomment-1666022510 @dependabot recreate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm-site] bipinprasad opened a new pull request, #42: Storm 2.5.0 release - generate and add documents
bipinprasad opened a new pull request, #42: URL: https://github.com/apache/storm-site/pull/42 Also move current symbolic link -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm-site] bipinprasad merged pull request #41: Upgrade ruby, bundler, github-pages, jekyll, add webrick dependency.
bipinprasad merged PR #41: URL: https://github.com/apache/storm-site/pull/41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm-site] bipinprasad opened a new pull request, #41: Upgrade ruby, bundler, github-pages, jekyll, add webrick dependency.
bipinprasad opened a new pull request, #41: URL: https://github.com/apache/storm-site/pull/41 In order to use ruby3, jekyll, github-pages and webrick. Tested by running "bundle exec jekyll serve -w --incremental" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] 6harat commented on pull request #3546: [STORM-3924] Support for declaring WorkerHook in Flux topology definitions
6harat commented on PR #3546: URL: https://github.com/apache/storm/pull/3546#issuecomment-1665297205 will rebase and check it out over the weekend -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] rzo1 commented on pull request #3558: [STORM-3939] Remove gitact build for JDK 8, set class format to JDK11 and allow introspection in test
rzo1 commented on PR #3558: URL: https://github.com/apache/storm/pull/3558#issuecomment-166774 Aside from needed a rebase after release, it looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] rzo1 commented on pull request #3546: [STORM-3924] Support for declaring WorkerHook in Flux topology definitions
rzo1 commented on PR #3546: URL: https://github.com/apache/storm/pull/3546#issuecomment-1664435945 @6harat Can you try a rebase? So we can find out why the license file checks fail on your branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm-site] rzo1 commented on pull request #40: Remove 3rd party hosted content from storm.apache.org
rzo1 commented on PR #40: URL: https://github.com/apache/storm-site/pull/40#issuecomment-1663948118 There are some other things, which can be improved in subsequent and better reviewable PRs: - Updating JS libs used - Unify asset folder (atm we have different locations, making it difficult to follow, etc) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm-site] rzo1 commented on a diff in pull request #40: Remove 3rd party hosted content from storm.apache.org
rzo1 commented on code in PR #40: URL: https://github.com/apache/storm-site/pull/40#discussion_r1283155075 ## content/about/scalable.html: ## @@ -16,7 +16,7 @@ -https://fortawesome.github.io/Font-Awesome/assets/font-awesome/css/font-awesome.css;> + Review Comment: You are right. I made it consistent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad opened a new pull request, #3558: [STORM-3939] Remove gitact build for JDK 8, set class format to JDK11 and allow introspection in test
bipinprasad opened a new pull request, #3558: URL: https://github.com/apache/storm/pull/3558 ## What is the purpose of the change *Drop support for JDK8, set minimum JDK level to 11 - in order for new JDK and packaging features to be used* ## How was the change tested *mvn test; also allow githun actions to run.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] jnioche merged pull request #3556: Missing dependency prevents Storm from being built, fixes #3940
jnioche merged PR #3556: URL: https://github.com/apache/storm/pull/3556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm-site] rzo1 opened a new pull request, #40: Remove 3rd party hosted content from storm.apache.org
rzo1 opened a new pull request, #40: URL: https://github.com/apache/storm-site/pull/40 # What does this PR do? - Removes Twitter assets - Doesn't work anymore anyway - Violates ASF Privacy Policy - Removes external loading of font-awesome 4 from non-existing sources - Violates ASF Privacy Policy anyway - Removes Font loading from google statics - Violates ASF Privacy Policy anyway - Fix Ruby gems / Jekyll to work with Ubuntu 22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] rzo1 opened a new pull request, #3557: STORM-3941 - Add .asf.yaml to GitHub repository
rzo1 opened a new pull request, #3557: URL: https://github.com/apache/storm/pull/3557 ## What is the purpose of the change - Adds an `.asf.yaml` for GitHub configuration. - Updates the titles of the auto generated messages from GitHub like described in https://community.apache.org/contributors/mailing-lists.html#configuring-the-subject-lines-of-the-emails-being-sent - Make it human readable like in https://lists.apache.org/list?d...@streampipes.apache.org:lte=4M (Note: As per discussion on comdev, the defaults might change anyway to this one) - Prevent force pushed on master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] rzo1 commented on pull request #3547: [STORM-3925] Allow user resources (in WorkerTopologyContext) to be set by Worker Hooks
rzo1 commented on PR #3547: URL: https://github.com/apache/storm/pull/3547#issuecomment-1661608128 Guess we can include this after 2.5.0 vote is over. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] rzo1 commented on pull request #3546: [STORM-3924] Support for declaring WorkerHook in Flux topology definitions
rzo1 commented on PR #3546: URL: https://github.com/apache/storm/pull/3546#issuecomment-1661607392 @6harat triggered the workflow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad commented on pull request #3556: Missing dependency prevents Storm from being built, fixes #3940
bipinprasad commented on PR #3556: URL: https://github.com/apache/storm/pull/3556#issuecomment-1660768551 storm builds on all pull requests under github actions currently. However, I think it is better to consistent in excluding this dependency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] rzo1 commented on pull request #3556: Missing dependency prevents Storm from being built, fixes #3940
rzo1 commented on PR #3556: URL: https://github.com/apache/storm/pull/3556#issuecomment-1660648311 > This artifact is available on maven central. Is there a need to exclude it? https://mvnrepository.com/artifact/org.pentaho/pentaho-aggdesigner-algorithm/5.1.5-jhyde I think, that the actual problem is, that hive 2.3.9 declares the (dead) conjars repo in https://github.com/apache/hive/blob/rel/release-2.3.9/pom.xml#L225 Thus, Maven tries to use this repository (because it is declared on a transient dependency) to download the repo and fails. Given that it is already excluded in `storm-sql-runtime`, `storm-hive` and in `storm-autocreds`, the changes by @jnioche just apply the excludes systematically. If we run the GH actions, we will see, if the dependency is required at runtime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad commented on pull request #3556: Missing dependency prevents Storm from being built, fixes #3940
bipinprasad commented on PR #3556: URL: https://github.com/apache/storm/pull/3556#issuecomment-1660419649 This artifact is available on maven central. Is there a need to exclude it? https://mvnrepository.com/artifact/org.pentaho/pentaho-aggdesigner-algorithm/5.1.5-jhyde -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] jnioche opened a new pull request, #3556: Missing dependency prevents Storm from being built, fixes #3940
jnioche opened a new pull request, #3556: URL: https://github.com/apache/storm/pull/3556 ## What is the purpose of the change Storm can't be built because the dependency pentaho-aggdesigner-algorithm is not available. This dependency is excluded in some places of the poms but not systematically, excluding it everywhere allows the code to be built. ## How was the change tested `mvn clean install -DskipTests` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad merged pull request #3555: [STORM-3895] Add JDK-17 build
bipinprasad merged PR #3555: URL: https://github.com/apache/storm/pull/3555 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad commented on pull request #3555: [STORM-3895] Add JDK-17 build
bipinprasad commented on PR #3555: URL: https://github.com/apache/storm/pull/3555#issuecomment-1654447554 For some reason, under openjdk-17, the license file is much smaller (and different) from that generated under jdk8 and jdk11. Wondering is this is related to strict isolation of packages and restrictions on reflection introduced in JDK17. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] agresch commented on a diff in pull request #3555: [STORM-3895] Add JDK-17 build
agresch commented on code in PR #3555: URL: https://github.com/apache/storm/pull/3555#discussion_r1276602250 ## storm-server/pom.xml: ## @@ -169,6 +169,8 @@ maven-surefire-plugin 1 + Review Comment: I'm not sure what this issue is, but I would file a JIRA for it and mention it in this comment so we can track progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] avermeer commented on pull request #3555: [STORM-3895] Add JDK-17 build
avermeer commented on PR #3555: URL: https://github.com/apache/storm/pull/3555#issuecomment-1653001618 Very good initiative, thanks ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad opened a new pull request, #3555: [STORM-3895] Add JDK-17 build
bipinprasad opened a new pull request, #3555: URL: https://github.com/apache/storm/pull/3555 ## What is the purpose of the change *Add JDK-17 Build* ## How was the change tested *Let the github actions run* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] 6harat commented on pull request #3546: [STORM-3924] Support for declaring WorkerHook in Flux topology definitions
6harat commented on PR #3546: URL: https://github.com/apache/storm/pull/3546#issuecomment-1647188305 @bipinprasad just pushed a README update commit, the prev workflow was already successful, so triggering it again might not be reqd. Please let me know if anything else is required from my side for going ahead with the merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] 6harat commented on a diff in pull request #3546: [STORM-3924] Support for declaring WorkerHook in Flux topology definitions
6harat commented on code in PR #3546:
URL: https://github.com/apache/storm/pull/3546#discussion_r1271728650
##
docs/flux.md:
##
@@ -765,6 +770,16 @@ The `override` property controls how includes affect the
values defined in the c
**N.B.:** Includes are not yet recursive. Includes from included files will be
ignored.
+## Worker Hooks
+Flux allows you to attach topology component that can be executed when a
worker starts, and when a worker shuts down. It can be useful when you want to
execute operations before topology processing starts, or cleanup operations
before your workers shut down, e.g. managing application context. Worker Hooks
should be an implementation of
[IWorkerHook]({{page.git-blob-base}}/storm-client/src/jvm/org/apache/storm/hooks/IWorkerHook.java).
Other than that, they follow similar Bean definition semantics as
[Components](##Components) for declaration within yaml file.
Review Comment:
rectified the typo in the docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] 6harat commented on pull request #3547: [STORM-3925] Allow user resources (in WorkerTopologyContext) to be set by Worker Hooks
6harat commented on PR #3547: URL: https://github.com/apache/storm/pull/3547#issuecomment-1647184755 @bipinprasad please let me know if anything else is required for going ahead with merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] LoggingResearch opened a new pull request, #3554: [STORM-3938] Unhandled InterruptedException and missing log in Supervisor's close(…
LoggingResearch opened a new pull request, #3554: URL: https://github.com/apache/storm/pull/3554 ## What is the purpose of the change This PR addresses the handling of InterruptedException in the close() method of the Supervisor class. The changes include: Adding a separate catch block for InterruptedException that is thrown by the close() method of the AsyncLocalizer class. Logging the InterruptedException separately to ensure that the exception type and message are correctly recorded in the logs. The motivation behind this change is to properly handle the scenario where the close() method of AsyncLocalizer is interrupted, which is a situation that was not specifically addressed in the original code. By catching and logging the InterruptedException separately, we can provide more specific information in the logs when such an event occurs. ## How was the change tested Built storm-server. Validated logging on dev supervisor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] LoggingResearch closed pull request #3553: Handle InterruptedException in Supervisor close() method.
LoggingResearch closed pull request #3553: Handle InterruptedException in Supervisor close() method. URL: https://github.com/apache/storm/pull/3553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] LoggingResearch opened a new pull request, #3553: Handle InterruptedException in Supervisor close() method.
LoggingResearch opened a new pull request, #3553: URL: https://github.com/apache/storm/pull/3553 ## What is the purpose of the change This PR addresses the handling of InterruptedException in the close() method of the Supervisor class. The changes include: 1. Adding a separate catch block for InterruptedException that is thrown by the close() method of the AsyncLocalizer class. 2. Logging the InterruptedException separately to ensure that the exception type and message are correctly recorded in the logs. The motivation behind this change is to properly handle the scenario where the close() method of AsyncLocalizer is interrupted, which is a situation that was not specifically addressed in the original code. By catching and logging the InterruptedException separately, we can provide more specific information in the logs when such an event occurs. ## How was the change tested Built storm-server. Validated logging on dev supervisor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad merged pull request #3552: [STORM-3930] Change the source code control URI
bipinprasad merged PR #3552: URL: https://github.com/apache/storm/pull/3552 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad opened a new pull request, #3552: [STORM-3930] Change the source code control URI
bipinprasad opened a new pull request, #3552: URL: https://github.com/apache/storm/pull/3552 …d update the uri from gitbox to github ## What is the purpose of the change *While doing "mvm perform", the checkout times out at the end when using the https connection. Also the url is old. Use the new url (change from gitbox to github) that is the target of redirect.* ## How was the change tested *Pulle request checks* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad merged pull request #3549: [STORM-3927] Change python to python3 in examples
bipinprasad merged PR #3549: URL: https://github.com/apache/storm/pull/3549 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad commented on pull request #3547: [STORM-3925] Allow user resources (in WorkerTopologyContext) to be set by Worker Hooks
bipinprasad commented on PR #3547: URL: https://github.com/apache/storm/pull/3547#issuecomment-1614815685 Triggered workflow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad merged pull request #3550: [STORM-3928] Use python3 in flux test, examples and wrappers
bipinprasad merged PR #3550: URL: https://github.com/apache/storm/pull/3550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad merged pull request #3551: [STORM-3929] Update documentation to refer to python3
bipinprasad merged PR #3551: URL: https://github.com/apache/storm/pull/3551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad merged pull request #3548: [STORM-3926] Require python3 for bin/storm
bipinprasad merged PR #3548: URL: https://github.com/apache/storm/pull/3548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad opened a new pull request, #3551: [STORM-3929] Update documentation to refer to python3
bipinprasad opened a new pull request, #3551: URL: https://github.com/apache/storm/pull/3551 ## What is the purpose of the change *Python2 has been deprecated and removed Storm 2.5.0. Update documentation to reflect this change.* ## How was the change tested *Render ".md" documentation and read generated page* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad opened a new pull request, #3550: [STORM-3928] Use python3 in flux test, examples and wrappers
bipinprasad opened a new pull request, #3550: URL: https://github.com/apache/storm/pull/3550 ## What is the purpose of the change *Python2 has been deprecated. However many systems still activate python2 when only using python. Change it to python3 to ensure Python version 3 is used.* ## How was the change tested *Run the example python scripts through Python 3 syntax checks* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad opened a new pull request, #3549: [STORM-3927] Change python to python3 in examples
bipinprasad opened a new pull request, #3549: URL: https://github.com/apache/storm/pull/3549 ## What is the purpose of the change *Python2 has been deprecated. However many systems still activate python2 when only using python. Change it to python3 to ensure Python version 3 is used.* ## How was the change tested *Run the example python scripts through Python 3 syntax checks* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] rzo1 commented on a diff in pull request #3546: [STORM-3924] Support for declaring WorkerHook in Flux topology definitions
rzo1 commented on code in PR #3546:
URL: https://github.com/apache/storm/pull/3546#discussion_r1246591112
##
docs/flux.md:
##
@@ -765,6 +770,16 @@ The `override` property controls how includes affect the
values defined in the c
**N.B.:** Includes are not yet recursive. Includes from included files will be
ignored.
+## Worker Hooks
+Flux allows you to attach topology component that can be executed when a
worker starts, and when a worker shuts down. It can be useful when you want to
execute operations before topology processing starts, or cleanup operations
before your workers shut down, e.g. managing application context. Worker Hooks
should be an implementation of
[IWorkerHook]({{page.git-blob-base}}/storm-client/src/jvm/org/apache/storm/hooks/IWorkerHook.java).
Other than that, they follow similar Bean definition semantics as
[Components](##Components) for declaration within yaml file.
Review Comment:
`components`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] rzo1 commented on pull request #3547: [STORM-3925] Allow user resources (in WorkerTopologyContext) to be set by Worker Hooks
rzo1 commented on PR #3547: URL: https://github.com/apache/storm/pull/3547#issuecomment-1605965102 @6harat i am no committer on Storm, so nö karma to do so ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] 6harat commented on pull request #3547: [STORM-3925] Allow user resources (in WorkerTopologyContext) to be set by Worker Hooks
6harat commented on PR #3547: URL: https://github.com/apache/storm/pull/3547#issuecomment-1605948131 @bipinprasad @rzo1 could you please help trigger the workflow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] 6harat commented on pull request #3546: [STORM-3924] Support for declaring WorkerHook in Flux topology definitions
6harat commented on PR #3546:
URL: https://github.com/apache/storm/pull/3546#issuecomment-1605932509
> I was going through other parts of the code and found this TODO. Seems
like it was intended to be connected to WorkerHooks when those were first
introduced.
>
> ```
> private Map makeUserResources() {
> /* TODO: need to invoke a hook provided by the topology, giving it
a chance to create user resources.
> * this would be part of the initialization hook
> * need to separate workertopologycontext into WorkerContext and
WorkerUserContext.
> * actually just do it via interfaces. just need to make sure to
hide setResource from tasks
> */
> return new HashMap<>();
> }
> ```
>
> AFAIS, the current implementation will always lead to empty userResources
as no interface exposes a way to allow user to set them.
>
> Lmk, if my above understanding is correct and this change can also be
taken up. this would allow for better application context management. Will put
this fix in a separate PR.
>
> cc: @abhishekagarwal87 , @schonfeld , @revans2 , @nathanmarz , @rzo1 ,
@bipinprasad
this has been taken up here: https://github.com/apache/storm/pull/3547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] bipinprasad merged pull request #3540: [STORM-3916] Add Round Robin Scheduling strategy with optional node limit
bipinprasad merged PR #3540: URL: https://github.com/apache/storm/pull/3540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] 6harat commented on pull request #3547: [STORM-3925] Allow user resources (in WorkerTopologyContext) to be set by Worker Hooks
6harat commented on PR #3547: URL: https://github.com/apache/storm/pull/3547#issuecomment-1599002790 Pending tasks: 1. Add feature tests 2. Update documentation / comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad commented on pull request #3546: [STORM-XXXX] Support for declaring WorkerHook in Flux topology definitions
bipinprasad commented on PR #3546: URL: https://github.com/apache/storm/pull/3546#issuecomment-1597358946 Activated the checks. There may be some PMD exceptions - that can be checked locally as "mvn pmd:check" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad merged pull request #3545: [STORM-3923] Increase MAVEN_OPTS max memory setting to 2gb
bipinprasad merged PR #3545: URL: https://github.com/apache/storm/pull/3545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] 6harat commented on pull request #3546: [STORM-XXXX] Support for declaring WorkerHook in Flux topology definitions
6harat commented on PR #3546:
URL: https://github.com/apache/storm/pull/3546#issuecomment-1596224842
I was going through other parts of the code and found this TODO. Seems like
it was intended to be connected to WorkerHooks when those were first introduced.
```
private Map makeUserResources() {
/* TODO: need to invoke a hook provided by the topology, giving it a
chance to create user resources.
* this would be part of the initialization hook
* need to separate workertopologycontext into WorkerContext and
WorkerUserContext.
* actually just do it via interfaces. just need to make sure to
hide setResource from tasks
*/
return new HashMap<>();
}
```
AFAIS, the current implementation will always lead to empty userResources as
no interface exposes a way to allow user to set them.
Lmk, if my above understanding is correct and this change can also be taken
up. this would allow for better application context management. Will put this
fix in a separate PR.
cc: @abhishekagarwal87 , @schonfeld , @revans2 , @nathanmarz , @rzo1 ,
@bipinprasad
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] 6harat commented on pull request #3546: [STORM-XXXX] Support for declaring WorkerHook in Flux topology definitions
6harat commented on PR #3546: URL: https://github.com/apache/storm/pull/3546#issuecomment-1595677853 Please note the following observations / callouts: 1. have not added workerHoosk to executioncontext. AFAIS constructed spouts and bolts are being stored here so as to allow creation of streams later in the flow `FluxBuilder.buildStreamDefinitions` 2. have not added explicit type descriptors as being done for spouts, bolts and includes in `FluxParser.yaml`. AFAIU the info provided in TopologyDef is more than enough to parse yaml containing `workerHooks` field. Let me know if my understanding was incorrect and a change is indeed required on the above files. Will pick it up right away. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] 6harat opened a new pull request, #3546: [STORM-XXXX] Support for declaring WorkerHook in Flux topology definitions
6harat opened a new pull request, #3546: URL: https://github.com/apache/storm/pull/3546 ## What is the purpose of the change A while back the support for declaring WorkerHook in TopologyBuilder was added. Related JIRA: https://issues.apache.org/jira/browse/STORM-126. This change adds support for the aforementioned feature for topology definitions submitted as Flux yaml. ## How was the change tested Correspoding feature test case was added in `org.apache.storm.flux.TCKTest` For regression: Git Actions build and test run as part of this pull request -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad opened a new pull request, #3545: [STORM-3923] Increase MAVEN_OPTS max memory setting to 2gb
bipinprasad opened a new pull request, #3545: URL: https://github.com/apache/storm/pull/3545 ## What is the purpose of the change *Storm Cassandra (external/storm-cassandra) test fail because OOM* ## How was the code tested *Git Actions build and test run as part of this pull request* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad merged pull request #3544: [STORM-3922] Acker scheduling changes.
bipinprasad merged PR #3544: URL: https://github.com/apache/storm/pull/3544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad opened a new pull request, #3544: [STORM-3922] Acker scheduling changes.
bipinprasad opened a new pull request, #3544: URL: https://github.com/apache/storm/pull/3544 ## What is the purpose of the change *Acker executors are sorted in a specific order that backtracking needs to account for.* ## How was the change tested *This code has been running for over a year on staging and production cluster at a contributing company* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] agresch commented on a diff in pull request #3540: [STORM-3916] Add Round Robin Scheduling strategy with optional node limit
agresch commented on code in PR #3540:
URL: https://github.com/apache/storm/pull/3540#discussion_r1221809229
##
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java:
##
@@ -527,13 +538,13 @@ protected SchedulingResult
scheduleExecutorsOnNodes(List ordere
if (execIndex == 0) {
break;
} else {
-searcherState.backtrack(execToComp, nodeForExec[execIndex -
1], workerSlotForExec[execIndex - 1]);
Review Comment:
Are there more missing changes that go along with this? Can we get that
merged first before this PR if there are more changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] bipinprasad commented on a diff in pull request #3540: [STORM-3916] Add Round Robin Scheduling strategy with optional node limit
bipinprasad commented on code in PR #3540:
URL: https://github.com/apache/storm/pull/3540#discussion_r1220355853
##
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java:
##
@@ -527,13 +538,13 @@ protected SchedulingResult
scheduleExecutorsOnNodes(List ordere
if (execIndex == 0) {
break;
} else {
-searcherState.backtrack(execToComp, nodeForExec[execIndex -
1], workerSlotForExec[execIndex - 1]);
Review Comment:
This method signature was changed to backtrack correctly in the presence of
Acker executors. I believe this is Ray's change that did not make it to
community earlier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] bipinprasad commented on a diff in pull request #3540: [STORM-3916] Add Round Robin Scheduling strategy with optional node limit
bipinprasad commented on code in PR #3540:
URL: https://github.com/apache/storm/pull/3540#discussion_r1220322597
##
storm-client/src/jvm/org/apache/storm/Config.java:
##
@@ -859,9 +859,11 @@ public class Config extends HashMap {
@IsString
public static final String STORM_DO_AS_USER = "storm.doAsUser";
/**
- * The number of machines that should be used by this topology to isolate
it from all others. Set storm.scheduler to
- * org.apache.storm.scheduler.multitenant.MultitenantScheduler
- */
+ * The number of machines that should be used by this topology to isolate
it from all others.
Review Comment:
Added more detailed explanation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] bipinprasad commented on a diff in pull request #3540: [STORM-3916] Add Round Robin Scheduling strategy with optional node limit
bipinprasad commented on code in PR #3540:
URL: https://github.com/apache/storm/pull/3540#discussion_r1220291317
##
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java:
##
@@ -164,6 +168,7 @@ public SchedulingResult schedule(Cluster cluster,
TopologyDetails td) {
//order executors to be scheduled
List orderedExecutors =
execSorter.sortExecutors(unassignedExecutors);
+isolateAckersToEnd(orderedExecutors);
Review Comment:
This is refactoring. This reordering was earlier being done in
scheduleExecutorsOnNodes(). But it should be done when the executors are
sorted. Then Round Robin strategy to can override scheduleExecutorsOnNodes()
and still receive the executors sorted in right order (i.e. ackers at the end)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] bipinprasad commented on a diff in pull request #3540: [STORM-3916] Add Round Robin Scheduling strategy with optional node limit
bipinprasad commented on code in PR #3540:
URL: https://github.com/apache/storm/pull/3540#discussion_r1220277226
##
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java:
##
@@ -123,6 +123,10 @@ public BaseResourceAwareStrategy(boolean
sortNodesForEachExecutor, NodeSortType
this.nodeSortType = nodeSortType;
}
+public boolean isSortNodesForEachExecutor() {
Review Comment:
Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] bipinprasad commented on a diff in pull request #3540: [STORM-3916] Add Round Robin Scheduling strategy with optional node limit
bipinprasad commented on code in PR #3540:
URL: https://github.com/apache/storm/pull/3540#discussion_r1219931053
##
storm-client/src/jvm/org/apache/storm/Config.java:
##
@@ -859,9 +859,11 @@ public class Config extends HashMap {
@IsString
public static final String STORM_DO_AS_USER = "storm.doAsUser";
/**
- * The number of machines that should be used by this topology to isolate
it from all others. Set storm.scheduler to
- * org.apache.storm.scheduler.multitenant.MultitenantScheduler
- */
+ * The number of machines that should be used by this topology to isolate
it from all others.
Review Comment:
or "Maximum limit for the number of machines on which a topology will be
scheduled"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] bipinprasad commented on a diff in pull request #3540: [STORM-3916] Add Round Robin Scheduling strategy with optional node limit
bipinprasad commented on code in PR #3540:
URL: https://github.com/apache/storm/pull/3540#discussion_r1219927539
##
storm-client/src/jvm/org/apache/storm/Config.java:
##
@@ -859,9 +859,11 @@ public class Config extends HashMap {
@IsString
public static final String STORM_DO_AS_USER = "storm.doAsUser";
/**
- * The number of machines that should be used by this topology to isolate
it from all others. Set storm.scheduler to
- * org.apache.storm.scheduler.multitenant.MultitenantScheduler
- */
+ * The number of machines that should be used by this topology to isolate
it from all others.
Review Comment:
I think I can add "Topology scheduling will be limited to this number of
machines".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] agresch commented on a diff in pull request #3540: [STORM-3916] Add Round Robin Scheduling strategy with optional node limit
agresch commented on code in PR #3540:
URL: https://github.com/apache/storm/pull/3540#discussion_r1218307249
##
storm-client/src/jvm/org/apache/storm/Config.java:
##
@@ -859,9 +859,11 @@ public class Config extends HashMap {
@IsString
public static final String STORM_DO_AS_USER = "storm.doAsUser";
/**
- * The number of machines that should be used by this topology to isolate
it from all others. Set storm.scheduler to
- * org.apache.storm.scheduler.multitenant.MultitenantScheduler
- */
+ * The number of machines that should be used by this topology to isolate
it from all others.
Review Comment:
Unrelated to your change, but hopefully you can address... I don't
understand why specifying a number of machines causes isolation. Your PR
mentions this is a max number of machines. Can you add/modify the description
to clarify this config description?
##
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java:
##
@@ -164,6 +168,7 @@ public SchedulingResult schedule(Cluster cluster,
TopologyDetails td) {
//order executors to be scheduled
List orderedExecutors =
execSorter.sortExecutors(unassignedExecutors);
+isolateAckersToEnd(orderedExecutors);
Review Comment:
this seems to be a behavior change? Why was this added?
##
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java:
##
@@ -527,13 +538,13 @@ protected SchedulingResult
scheduleExecutorsOnNodes(List ordere
if (execIndex == 0) {
break;
} else {
-searcherState.backtrack(execToComp, nodeForExec[execIndex -
1], workerSlotForExec[execIndex - 1]);
Review Comment:
why did this line change?
##
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java:
##
@@ -123,6 +123,10 @@ public BaseResourceAwareStrategy(boolean
sortNodesForEachExecutor, NodeSortType
this.nodeSortType = nodeSortType;
}
+public boolean isSortNodesForEachExecutor() {
Review Comment:
where is this used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] bipinprasad merged pull request #3538: [STORM-3921] Bump spring-core from 5.3.26 to 5.3.27 in /examples/storm-jms-examples
bipinprasad merged PR #3538: URL: https://github.com/apache/storm/pull/3538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad commented on a diff in pull request #3536: [STORM-3911] fetch net.minidev:json-smart:2.3 artifact from maven repo before conjars.org repo is referenced
bipinprasad commented on code in PR #3536:
URL: https://github.com/apache/storm/pull/3536#discussion_r1213687480
##
storm-core/pom.xml:
##
@@ -137,6 +137,7 @@
org.mockito
mockito-core
+${mockito.version}
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] agresch commented on a diff in pull request #3536: [STORM-3911] fetch net.minidev:json-smart:2.3 artifact from maven repo before conjars.org repo is referenced
agresch commented on code in PR #3536:
URL: https://github.com/apache/storm/pull/3536#discussion_r1213655650
##
storm-core/pom.xml:
##
@@ -137,6 +137,7 @@
org.mockito
mockito-core
+${mockito.version}
Review Comment:
why was this line added?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] bipinprasad merged pull request #3535: [STORM-3910] Enhanced logging for rocksdb metrics store.
bipinprasad merged PR #3535: URL: https://github.com/apache/storm/pull/3535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm-site] ScottBrenner commented on pull request #35: Update meetups.yml
ScottBrenner commented on PR #35: URL: https://github.com/apache/storm-site/pull/35#issuecomment-1565183279 @bipinprasad please review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] vesense commented on pull request #3543: STORM-3920 Update security document
vesense commented on PR #3543: URL: https://github.com/apache/storm/pull/3543#issuecomment-1557058816 Thanks @snikhil5 Merged into master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] vesense merged pull request #3543: STORM-3920 Update security document
vesense merged PR #3543: URL: https://github.com/apache/storm/pull/3543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] snikhil5 opened a new pull request, #3543: STORM-3920 Update security document
snikhil5 opened a new pull request, #3543: URL: https://github.com/apache/storm/pull/3543 ## What is the purpose of the change Update the document for setting up secure cluster ## How was the change tested Tested on a secure cluster -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] vesense commented on pull request #3542: [STORM-3917] Remove explicit worker heap size in ThroughputVsLatency
vesense commented on PR #3542: URL: https://github.com/apache/storm/pull/3542#issuecomment-1545705349 Thanks @jmartell7 Merged into master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] vesense merged pull request #3542: [STORM-3917] Remove explicit worker heap size in ThroughputVsLatency
vesense merged PR #3542: URL: https://github.com/apache/storm/pull/3542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] jmartell7 opened a new pull request, #3542: Remove explicit worker heap size in ThroughputVsLatency
jmartell7 opened a new pull request, #3542: URL: https://github.com/apache/storm/pull/3542 Allow users to change worker heap size in ThroughputVsLatency example topo. ## What is the purpose of the change ThroughputVsLatency adds an explicit 2GB worker heapsize overriding the RAS / user settings ## How was the change tested Worker JVM options were observed to have both automatic heap and this explicit setting. No further testing was performed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
