[GitHub] storm pull request: STORM-130: Supervisor getting killed due to ja...
Github user ssudhaiyer commented on the pull request: https://github.com/apache/storm/pull/418#issuecomment-107232634 I'm using 0.9.4 and seeing this issue. This seems to happen for me after an exception in my topology. I deactivate the topology and try deploying the topology again and I run into this issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-130: Supervisor getting killed due to ja...
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/418#issuecomment-107257398 @ssudhaiyer can you give us some steps on reproducing this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-130: Supervisor getting killed due to ja...
Github user HQebupt commented on the pull request: https://github.com/apache/storm/pull/418#issuecomment-92704866 It works. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-130: Supervisor getting killed due to ja...
Github user sweetest commented on the pull request: https://github.com/apache/storm/pull/418#issuecomment-76107560 hi guys, I want to know about when you will release 0.9.4 including this feature. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-130: Supervisor getting killed due to ja...
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/418#issuecomment-75842588 merged to 0.9.3-branch. The next release of that branch will be 0.9.4, I'll update JIRA. @harshach Can you close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-130: Supervisor getting killed due to ja...
Github user harshach closed the pull request at: https://github.com/apache/storm/pull/418 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-130: Supervisor getting killed due to ja...
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/418#issuecomment-75844084 Thanks @ptgoetz --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-130: Supervisor getting killed due to ja...
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/418#issuecomment-75580704 @ptgoetz I merged the corresponding pull into master, but I'm not totally sure what version number you want for a 0.9.3 update, will it be 0.9.4? 0.9.3.1? If you just want to merge it in and update the JIRA with the new number that will be great, otherwise I'll just go with 0.9.4 and call it good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-130: Supervisor getting killed due to ja...
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/401 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-130: Supervisor getting killed due to ja...
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/401#issuecomment-72726626 @ptgoetz will send a new PR against 0.9.3 branch. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-130: Supervisor getting killed due to ja...
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/401#issuecomment-72725245 +1. I'd also like to see this back-ported to the 0.9.3 branch, but that shouldn't block this from getting merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-130: Supervisor getting killed due to ja...
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/401#issuecomment-72078838 @ptgoetz @d2r @revans2 @Parth-Brahmbhatt Please take a look at the new PR. I apologize for the whitespace issue. There are still few left in this patch. As Taylor suggested please ?w=1 to the URL. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-130. Supervisor getting killed due to ja...
Github user harshach closed the pull request at: https://github.com/apache/storm/pull/400 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-130. Supervisor getting killed due to ja...
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/400#issuecomment-72070868 Closing this pr will re-open a new one. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-130. Supervisor getting killed due to ja...
Github user Parth-Brahmbhatt commented on the pull request: https://github.com/apache/storm/pull/400#issuecomment-72071447 +1, lgtm. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-130: Supervisor getting killed due to ja...
GitHub user harshach opened a pull request: https://github.com/apache/storm/pull/401 STORM-130: Supervisor getting killed due to java.io.FileNotFoundException: File '../stormconf.ser' does not exist. You can merge this pull request into a Git repository by running: $ git pull https://github.com/harshach/incubator-storm STORM-130-V2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/401.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #401 commit 6b061aaab5a39e4b95670e3f0590bb48de4375fd Author: Sriharsha Chintalapani m...@harsha.io Date: 2015-01-29T18:22:20Z STORM-130: Supervisor getting killed due to java.io.FileNotFoundException: File '../stormconf.ser' does not exist. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-130: Supervisor getting killed due to ja...
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/401#issuecomment-72105884 Ok So this is for an existing topology that moved and then moved back. I understand now about the race. I am +1 for the change, once we avoid hitting ZK quite so frequently. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-130: Supervisor getting killed due to ja...
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/401#discussion_r23801424 --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj --- @@ -349,6 +350,20 @@ (keys keepers)) (zipmap (vals new-worker-ids) (keys new-worker-ids)) )) + +;; check storm topology code dir exists before launching workers +(doseq [[port assignment] reassign-executors] + (let [storm-cluster-state (:storm-cluster-state supervisor) +downloaded-storm-ids (set (read-downloaded-storm-ids conf)) +storm-id (:storm-id assignment) +assignment-info (.assignment-info-with-version storm-cluster-state storm-id nil) --- End diff -- This is going to cause a large load on zookeeper. There is a reason we have the cache for the assignment info, and we only download it when it has changed. We really should use the cache here if we can. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-130: Supervisor getting killed due to ja...
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/401#discussion_r23803166 --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj --- @@ -349,6 +350,20 @@ (keys keepers)) (zipmap (vals new-worker-ids) (keys new-worker-ids)) )) + +;; check storm topology code dir exists before launching workers +(doseq [[port assignment] reassign-executors] + (let [storm-cluster-state (:storm-cluster-state supervisor) +downloaded-storm-ids (set (read-downloaded-storm-ids conf)) +storm-id (:storm-id assignment) +assignment-info (.assignment-info-with-version storm-cluster-state storm-id nil) --- End diff -- Yes. We could replace it with ```@(:assignment-versions supervisor)``` and presumably get the same result without hitting zookeeper. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-130: Supervisor getting killed due to ja...
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/401#issuecomment-72131353 @revans2 thanks for pointer on using cached assignment. I also spoke to @Parth-Brahmbhatt about download-storm-code, added the lock to make sure there won't be multiple threads downloading the same code . Please take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-130. Supervisor getting killed due to ja...
GitHub user harshach opened a pull request: https://github.com/apache/storm/pull/400 STORM-130. Supervisor getting killed due to java.io.FileNotFoundException: File '../stormconf.ser' does not exist. You can merge this pull request into a Git repository by running: $ git pull https://github.com/harshach/incubator-storm STORM-130 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/400.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #400 commit a16a95c5e8d889685389607f3a67514b73688e14 Author: Sriharsha Chintalapani m...@harsha.io Date: 2015-01-29T02:07:42Z STORM-130. Supervisor getting killed due to java.io.FileNotFoundException: File '../stormconf.ser' does not exist. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-130. Supervisor getting killed due to ja...
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/400#issuecomment-71956562 @revans2 @ptgoetz @d2r @Parth-Brahmbhatt please take a look at this patch. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-130. Supervisor getting killed due to ja...
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/400#issuecomment-71970386 @harshach One nit: white space changes make the diff harder to read. (Though appending '?w=1' to the URL will force github to ignore white space.) Otherwise, given a cursory review of the changes, I'm +1 initially. I'd like to verify the patch myself and/or give others a chance to do so as well. Regardless, nice work on tracking down the probable root cause and formulating a fix. This has been an oft reported issue that's difficult to reproduce. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
