Re: [S2] Struts 2.0.2 Build - ON HOLD
OK, we're getting closer, but there's still a few issues to resolve, if 2.0.2 is going to be a step forward. * Apply patch for Dojo topic notification (WW-1554) * Apply patch for DatePicker (WW-1555) * Fix XSLT Result (WW-1550) * Move Continuations support to an experimental plugin (WW-1548) * Fix other new showcase problems (WW-1538) ** Prefix example ** MessageStoreInterceptor Example ** Hangman Ajax example I've a users group meeting tonight, and two events at school tomorrow, so it will be Thursday before I can look at any of these myself. If anyone wants to jump in, feel free. -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [S2] Struts 2.0.2 Build - ON HOLD
I'm trying to get hangman to work. musachy Ted Husted wrote: OK, we're getting closer, but there's still a few issues to resolve, if 2.0.2 is going to be a step forward. * Apply patch for Dojo topic notification (WW-1554) * Apply patch for DatePicker (WW-1555) * Fix XSLT Result (WW-1550) * Move Continuations support to an experimental plugin (WW-1548) * Fix other new showcase problems (WW-1538) ** Prefix example ** MessageStoreInterceptor Example ** Hangman Ajax example I've a users group meeting tonight, and two events at school tomorrow, so it will be Thursday before I can look at any of these myself. If anyone wants to jump in, feel free. -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [S2] Struts 2.0.2 Build - ON HOLD
I attached WW-1554_2.patch (use this one instead of the previous ones) to WW-1554, a parameter was missing in notifyTopics. It has a fix to hangman ajax, which now works. There is an image attached to the ticket that needs to be added to showcase. regards musachy Musachy Barroso wrote: I'm trying to get hangman to work. musachy Ted Husted wrote: OK, we're getting closer, but there's still a few issues to resolve, if 2.0.2 is going to be a step forward. * Apply patch for Dojo topic notification (WW-1554) * Apply patch for DatePicker (WW-1555) * Fix XSLT Result (WW-1550) * Move Continuations support to an experimental plugin (WW-1548) * Fix other new showcase problems (WW-1538) ** Prefix example ** MessageStoreInterceptor Example ** Hangman Ajax example I've a users group meeting tonight, and two events at school tomorrow, so it will be Thursday before I can look at any of these myself. If anyone wants to jump in, feel free. -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [S2] Struts 2.0.2 Build - ON HOLD
The problem with the fileupload examples is that Don added this line: upload.setSizeMax(maxSize); to JakartaMultiPartRequest, the thing is that size is the threshold for the DeferredFileOutputStream for the files, not the actual limit of the file size, so the files never get written and the validation for the file size fails. Now here's where I got confused, as per: http://jakarta.apache.org/commons/fileupload/apidocs/org/apache/commons/fileupload/FileUploadBase.html#setFileSizeMax(long) setFileSizeMax, is what should be used to limit the size of the files, which I think was Don's intention, but that method is not in the class musachy Musachy Barroso wrote: The tokens examples are failing because the doInput is never being called in TokenAction, instead input is being called on ActionSupport, that's why the values are not on the session, hence the NullPointerException. How does this doX method discovery work? I can't find it on the docs. musachy Ted Husted wrote: We're making progress. There were already problems with the 2.0.1 Showcase, a few of which we fixed, but we've also added several new problems, namely Continuation - continuations/guess.action * pause doesn't pause and the example runs through all the guesses on the first execution Prefix example * redirect-action throws a null pointer exception UI Tag Input Example (both) - tags/ui/example!input.action * birthday field missing and not linked to control * color blank, picture blank If example (freemarker) * freemarker version doesn't wrap #26 through #33, they run together as a paragraph * (In 2.0.1, both versions ran everything together.) Person Manager * Create returns: No result defined for action org.apache.struts2.showcase.person.NewPersonAction and result input * List returns: No result defined for action org.apache.struts2.showcase.person.ListPeopleAction and result success validation/quizAjax!input.action * Validation messages stack up on resubmit * Submit button is at top left rather than bottom right Store across request using MessageStoreInterceptor (Example) * If provide an age, but not a name, the system returns for the name, but clears the age. * The validation messages appear at the top and next to the field, which is confusing. Hangman * Ajax, Selected letters not displayed. This is in addition to five problems remaining from the 2.0.1, and several quirks. Since we seem to be losing ground, it doesn't seem appropriate to tag another build until we have at least stabalized our own Showcase. Right now, all the problems are being tracked in * https://issues.apache.org/struts/browse/WW-1538 I'm tied up until Monday evening. If anyone has a chance to look at these, please dive in. -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [S2] Struts 2.0.2 Build - ON HOLD
setFileSizeMax(long) is available in fileupload-commons 1.2. No idea why their javadoc link is pointing to the current javadocs instead of the last release (1.1.1). This looks like a problem in 1.1.1. musachy Musachy Barroso wrote: The problem with the fileupload examples is that Don added this line: upload.setSizeMax(maxSize); to JakartaMultiPartRequest, the thing is that size is the threshold for the DeferredFileOutputStream for the files, not the actual limit of the file size, so the files never get written and the validation for the file size fails. Now here's where I got confused, as per: http://jakarta.apache.org/commons/fileupload/apidocs/org/apache/commons/fileupload/FileUploadBase.html#setFileSizeMax(long) setFileSizeMax, is what should be used to limit the size of the files, which I think was Don's intention, but that method is not in the class musachy Musachy Barroso wrote: The tokens examples are failing because the doInput is never being called in TokenAction, instead input is being called on ActionSupport, that's why the values are not on the session, hence the NullPointerException. How does this doX method discovery work? I can't find it on the docs. musachy Ted Husted wrote: We're making progress. There were already problems with the 2.0.1 Showcase, a few of which we fixed, but we've also added several new problems, namely Continuation - continuations/guess.action * pause doesn't pause and the example runs through all the guesses on the first execution Prefix example * redirect-action throws a null pointer exception UI Tag Input Example (both) - tags/ui/example!input.action * birthday field missing and not linked to control * color blank, picture blank If example (freemarker) * freemarker version doesn't wrap #26 through #33, they run together as a paragraph * (In 2.0.1, both versions ran everything together.) Person Manager * Create returns: No result defined for action org.apache.struts2.showcase.person.NewPersonAction and result input * List returns: No result defined for action org.apache.struts2.showcase.person.ListPeopleAction and result success validation/quizAjax!input.action * Validation messages stack up on resubmit * Submit button is at top left rather than bottom right Store across request using MessageStoreInterceptor (Example) * If provide an age, but not a name, the system returns for the name, but clears the age. * The validation messages appear at the top and next to the field, which is confusing. Hangman * Ajax, Selected letters not displayed. This is in addition to five problems remaining from the 2.0.1, and several quirks. Since we seem to be losing ground, it doesn't seem appropriate to tag another build until we have at least stabalized our own Showcase. Right now, all the problems are being tracked in * https://issues.apache.org/struts/browse/WW-1538 I'm tied up until Monday evening. If anyone has a chance to look at these, please dive in. -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [S2] Struts 2.0.2 Build - ON HOLD
Actually, the showcase example is working for me now. Do you still see a problem? Don Musachy Barroso wrote: setFileSizeMax(long) is available in fileupload-commons 1.2. No idea why their javadoc link is pointing to the current javadocs instead of the last release (1.1.1). This looks like a problem in 1.1.1. musachy Musachy Barroso wrote: The problem with the fileupload examples is that Don added this line: upload.setSizeMax(maxSize); to JakartaMultiPartRequest, the thing is that size is the threshold for the DeferredFileOutputStream for the files, not the actual limit of the file size, so the files never get written and the validation for the file size fails. Now here's where I got confused, as per: http://jakarta.apache.org/commons/fileupload/apidocs/org/apache/commons/fileupload/FileUploadBase.html#setFileSizeMax(long) setFileSizeMax, is what should be used to limit the size of the files, which I think was Don's intention, but that method is not in the class musachy Musachy Barroso wrote: The tokens examples are failing because the doInput is never being called in TokenAction, instead input is being called on ActionSupport, that's why the values are not on the session, hence the NullPointerException. How does this doX method discovery work? I can't find it on the docs. musachy Ted Husted wrote: We're making progress. There were already problems with the 2.0.1 Showcase, a few of which we fixed, but we've also added several new problems, namely Continuation - continuations/guess.action * pause doesn't pause and the example runs through all the guesses on the first execution Prefix example * redirect-action throws a null pointer exception UI Tag Input Example (both) - tags/ui/example!input.action * birthday field missing and not linked to control * color blank, picture blank If example (freemarker) * freemarker version doesn't wrap #26 through #33, they run together as a paragraph * (In 2.0.1, both versions ran everything together.) Person Manager * Create returns: No result defined for action org.apache.struts2.showcase.person.NewPersonAction and result input * List returns: No result defined for action org.apache.struts2.showcase.person.ListPeopleAction and result success validation/quizAjax!input.action * Validation messages stack up on resubmit * Submit button is at top left rather than bottom right Store across request using MessageStoreInterceptor (Example) * If provide an age, but not a name, the system returns for the name, but clears the age. * The validation messages appear at the top and next to the field, which is confusing. Hangman * Ajax, Selected letters not displayed. This is in addition to five problems remaining from the 2.0.1, and several quirks. Since we seem to be losing ground, it doesn't seem appropriate to tag another build until we have at least stabalized our own Showcase. Right now, all the problems are being tracked in * https://issues.apache.org/struts/browse/WW-1538 I'm tied up until Monday evening. If anyone has a chance to look at these, please dive in. -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [S2] Struts 2.0.2 Build - ON HOLD
Yeap, I always get File cannot be empty (validation upload.lenght() 0 failing) message. Do you have any uncommitted changes? musachy Don Brown wrote: Actually, the showcase example is working for me now. Do you still see a problem? Don Musachy Barroso wrote: setFileSizeMax(long) is available in fileupload-commons 1.2. No idea why their javadoc link is pointing to the current javadocs instead of the last release (1.1.1). This looks like a problem in 1.1.1. musachy Musachy Barroso wrote: The problem with the fileupload examples is that Don added this line: upload.setSizeMax(maxSize); to JakartaMultiPartRequest, the thing is that size is the threshold for the DeferredFileOutputStream for the files, not the actual limit of the file size, so the files never get written and the validation for the file size fails. Now here's where I got confused, as per: http://jakarta.apache.org/commons/fileupload/apidocs/org/apache/commons/fileupload/FileUploadBase.html#setFileSizeMax(long) setFileSizeMax, is what should be used to limit the size of the files, which I think was Don's intention, but that method is not in the class musachy Musachy Barroso wrote: The tokens examples are failing because the doInput is never being called in TokenAction, instead input is being called on ActionSupport, that's why the values are not on the session, hence the NullPointerException. How does this doX method discovery work? I can't find it on the docs. musachy Ted Husted wrote: We're making progress. There were already problems with the 2.0.1 Showcase, a few of which we fixed, but we've also added several new problems, namely Continuation - continuations/guess.action * pause doesn't pause and the example runs through all the guesses on the first execution Prefix example * redirect-action throws a null pointer exception UI Tag Input Example (both) - tags/ui/example!input.action * birthday field missing and not linked to control * color blank, picture blank If example (freemarker) * freemarker version doesn't wrap #26 through #33, they run together as a paragraph * (In 2.0.1, both versions ran everything together.) Person Manager * Create returns: No result defined for action org.apache.struts2.showcase.person.NewPersonAction and result input * List returns: No result defined for action org.apache.struts2.showcase.person.ListPeopleAction and result success validation/quizAjax!input.action * Validation messages stack up on resubmit * Submit button is at top left rather than bottom right Store across request using MessageStoreInterceptor (Example) * If provide an age, but not a name, the system returns for the name, but clears the age. * The validation messages appear at the top and next to the field, which is confusing. Hangman * Ajax, Selected letters not displayed. This is in addition to five problems remaining from the 2.0.1, and several quirks. Since we seem to be losing ground, it doesn't seem appropriate to tag another build until we have at least stabalized our own Showcase. Right now, all the problems are being tracked in * https://issues.apache.org/struts/browse/WW-1538 I'm tied up until Monday evening. If anyone has a chance to look at these, please dive in. -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [S2] Struts 2.0.2 Build - ON HOLD
Nope, and I'm able to successfully upload a file on the single, multiple (array), and multiple (list). To be clear, this page has the file upload tests that are failing? http://localhost:8080/struts2-showcase/fileupload/ Don Musachy Barroso wrote: Yeap, I always get File cannot be empty (validation upload.lenght() 0 failing) message. Do you have any uncommitted changes? musachy Don Brown wrote: Actually, the showcase example is working for me now. Do you still see a problem? Don Musachy Barroso wrote: setFileSizeMax(long) is available in fileupload-commons 1.2. No idea why their javadoc link is pointing to the current javadocs instead of the last release (1.1.1). This looks like a problem in 1.1.1. musachy Musachy Barroso wrote: The problem with the fileupload examples is that Don added this line: upload.setSizeMax(maxSize); to JakartaMultiPartRequest, the thing is that size is the threshold for the DeferredFileOutputStream for the files, not the actual limit of the file size, so the files never get written and the validation for the file size fails. Now here's where I got confused, as per: http://jakarta.apache.org/commons/fileupload/apidocs/org/apache/commons/fileupload/FileUploadBase.html#setFileSizeMax(long) setFileSizeMax, is what should be used to limit the size of the files, which I think was Don's intention, but that method is not in the class musachy Musachy Barroso wrote: The tokens examples are failing because the doInput is never being called in TokenAction, instead input is being called on ActionSupport, that's why the values are not on the session, hence the NullPointerException. How does this doX method discovery work? I can't find it on the docs. musachy Ted Husted wrote: We're making progress. There were already problems with the 2.0.1 Showcase, a few of which we fixed, but we've also added several new problems, namely Continuation - continuations/guess.action * pause doesn't pause and the example runs through all the guesses on the first execution Prefix example * redirect-action throws a null pointer exception UI Tag Input Example (both) - tags/ui/example!input.action * birthday field missing and not linked to control * color blank, picture blank If example (freemarker) * freemarker version doesn't wrap #26 through #33, they run together as a paragraph * (In 2.0.1, both versions ran everything together.) Person Manager * Create returns: No result defined for action org.apache.struts2.showcase.person.NewPersonAction and result input * List returns: No result defined for action org.apache.struts2.showcase.person.ListPeopleAction and result success validation/quizAjax!input.action * Validation messages stack up on resubmit * Submit button is at top left rather than bottom right Store across request using MessageStoreInterceptor (Example) * If provide an age, but not a name, the system returns for the name, but clears the age. * The validation messages appear at the top and next to the field, which is confusing. Hangman * Ajax, Selected letters not displayed. This is in addition to five problems remaining from the 2.0.1, and several quirks. Since we seem to be losing ground, it doesn't seem appropriate to tag another build until we have at least stabalized our own Showcase. Right now, all the problems are being tracked in * https://issues.apache.org/struts/browse/WW-1538 I'm tied up until Monday evening. If anyone has a chance to look at these, please dive in. -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [S2] Struts 2.0.2 Build - ON HOLD
Another thing - if this was truly a bug, then our unit tests should be failing. Take a look at the file upload unit test and see if it is properly testing the feature. Don Musachy Barroso wrote: The problem with the fileupload examples is that Don added this line: upload.setSizeMax(maxSize); to JakartaMultiPartRequest, the thing is that size is the threshold for the DeferredFileOutputStream for the files, not the actual limit of the file size, so the files never get written and the validation for the file size fails. Now here's where I got confused, as per: http://jakarta.apache.org/commons/fileupload/apidocs/org/apache/commons/fileupload/FileUploadBase.html#setFileSizeMax(long) setFileSizeMax, is what should be used to limit the size of the files, which I think was Don's intention, but that method is not in the class musachy Musachy Barroso wrote: The tokens examples are failing because the doInput is never being called in TokenAction, instead input is being called on ActionSupport, that's why the values are not on the session, hence the NullPointerException. How does this doX method discovery work? I can't find it on the docs. musachy Ted Husted wrote: We're making progress. There were already problems with the 2.0.1 Showcase, a few of which we fixed, but we've also added several new problems, namely Continuation - continuations/guess.action * pause doesn't pause and the example runs through all the guesses on the first execution Prefix example * redirect-action throws a null pointer exception UI Tag Input Example (both) - tags/ui/example!input.action * birthday field missing and not linked to control * color blank, picture blank If example (freemarker) * freemarker version doesn't wrap #26 through #33, they run together as a paragraph * (In 2.0.1, both versions ran everything together.) Person Manager * Create returns: No result defined for action org.apache.struts2.showcase.person.NewPersonAction and result input * List returns: No result defined for action org.apache.struts2.showcase.person.ListPeopleAction and result success validation/quizAjax!input.action * Validation messages stack up on resubmit * Submit button is at top left rather than bottom right Store across request using MessageStoreInterceptor (Example) * If provide an age, but not a name, the system returns for the name, but clears the age. * The validation messages appear at the top and next to the field, which is confusing. Hangman * Ajax, Selected letters not displayed. This is in addition to five problems remaining from the 2.0.1, and several quirks. Since we seem to be losing ground, it doesn't seem appropriate to tag another build until we have at least stabalized our own Showcase. Right now, all the problems are being tracked in * https://issues.apache.org/struts/browse/WW-1538 I'm tied up until Monday evening. If anyone has a chance to look at these, please dive in. -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [S2] Struts 2.0.2 Build - ON HOLD
Yeah that one. The multiple(list) and multiple(array) are working, I hadn't tried'em before. The tests pass, that what the first thing I tried. I'll double-check to see if I figure it out. musachy Don Brown wrote: Nope, and I'm able to successfully upload a file on the single, multiple (array), and multiple (list). To be clear, this page has the file upload tests that are failing? http://localhost:8080/struts2-showcase/fileupload/ Don Musachy Barroso wrote: Yeap, I always get File cannot be empty (validation upload.lenght() 0 failing) message. Do you have any uncommitted changes? musachy Don Brown wrote: Actually, the showcase example is working for me now. Do you still see a problem? Don Musachy Barroso wrote: setFileSizeMax(long) is available in fileupload-commons 1.2. No idea why their javadoc link is pointing to the current javadocs instead of the last release (1.1.1). This looks like a problem in 1.1.1. musachy Musachy Barroso wrote: The problem with the fileupload examples is that Don added this line: upload.setSizeMax(maxSize); to JakartaMultiPartRequest, the thing is that size is the threshold for the DeferredFileOutputStream for the files, not the actual limit of the file size, so the files never get written and the validation for the file size fails. Now here's where I got confused, as per: http://jakarta.apache.org/commons/fileupload/apidocs/org/apache/commons/fileupload/FileUploadBase.html#setFileSizeMax(long) setFileSizeMax, is what should be used to limit the size of the files, which I think was Don's intention, but that method is not in the class musachy Musachy Barroso wrote: The tokens examples are failing because the doInput is never being called in TokenAction, instead input is being called on ActionSupport, that's why the values are not on the session, hence the NullPointerException. How does this doX method discovery work? I can't find it on the docs. musachy Ted Husted wrote: We're making progress. There were already problems with the 2.0.1 Showcase, a few of which we fixed, but we've also added several new problems, namely Continuation - continuations/guess.action * pause doesn't pause and the example runs through all the guesses on the first execution Prefix example * redirect-action throws a null pointer exception UI Tag Input Example (both) - tags/ui/example!input.action * birthday field missing and not linked to control * color blank, picture blank If example (freemarker) * freemarker version doesn't wrap #26 through #33, they run together as a paragraph * (In 2.0.1, both versions ran everything together.) Person Manager * Create returns: No result defined for action org.apache.struts2.showcase.person.NewPersonAction and result input * List returns: No result defined for action org.apache.struts2.showcase.person.ListPeopleAction and result success validation/quizAjax!input.action * Validation messages stack up on resubmit * Submit button is at top left rather than bottom right Store across request using MessageStoreInterceptor (Example) * If provide an age, but not a name, the system returns for the name, but clears the age. * The validation messages appear at the top and next to the field, which is confusing. Hangman * Ajax, Selected letters not displayed. This is in addition to five problems remaining from the 2.0.1, and several quirks. Since we seem to be losing ground, it doesn't seem appropriate to tag another build until we have at least stabalized our own Showcase. Right now, all the problems are being tracked in * https://issues.apache.org/struts/browse/WW-1538 I'm tied up until Monday evening. If anyone has a chance to look at these, please dive in. -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To
Re: [S2] Struts 2.0.2 Build - ON HOLD
The tokens examples are failing because the doInput is never being called in TokenAction, instead input is being called on ActionSupport, that's why the values are not on the session, hence the NullPointerException. How does this doX method discovery work? I can't find it on the docs. musachy Ted Husted wrote: We're making progress. There were already problems with the 2.0.1 Showcase, a few of which we fixed, but we've also added several new problems, namely Continuation - continuations/guess.action * pause doesn't pause and the example runs through all the guesses on the first execution Prefix example * redirect-action throws a null pointer exception UI Tag Input Example (both) - tags/ui/example!input.action * birthday field missing and not linked to control * color blank, picture blank If example (freemarker) * freemarker version doesn't wrap #26 through #33, they run together as a paragraph * (In 2.0.1, both versions ran everything together.) Person Manager * Create returns: No result defined for action org.apache.struts2.showcase.person.NewPersonAction and result input * List returns: No result defined for action org.apache.struts2.showcase.person.ListPeopleAction and result success validation/quizAjax!input.action * Validation messages stack up on resubmit * Submit button is at top left rather than bottom right Store across request using MessageStoreInterceptor (Example) * If provide an age, but not a name, the system returns for the name, but clears the age. * The validation messages appear at the top and next to the field, which is confusing. Hangman * Ajax, Selected letters not displayed. This is in addition to five problems remaining from the 2.0.1, and several quirks. Since we seem to be losing ground, it doesn't seem appropriate to tag another build until we have at least stabalized our own Showcase. Right now, all the problems are being tracked in * https://issues.apache.org/struts/browse/WW-1538 I'm tied up until Monday evening. If anyone has a chance to look at these, please dive in. -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [S2] Struts 2.0.2 Build - ON HOLD
We should change the example to not use the do methods anymore. On 12/8/06, Musachy Barroso [EMAIL PROTECTED] wrote: The tokens examples are failing because the doInput is never being called in TokenAction, instead input is being called on ActionSupport, that's why the values are not on the session, hence the NullPointerException. How does this doX method discovery work? I can't find it on the docs. musachy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [S2] Struts 2.0.2 Build - ON HOLD
The submit tag has the same problem, I logged WW-1547 just to make sure
we don't forget it.
regards
musachy
Musachy Barroso wrote:
I did missed that one :)
I'm not sure about the ajaxHref, because it means the same as
href, IMO it is going to be confusing.
What if we don't build the url at all, and just use it as it is (
addParameter(href), findString(href)), and document that the url
needs to be built with the url tag to be used on the ajax tags?
musachy
Ted Husted wrote:
GMail has been marking many JIRA posting as spam lately (no doubt
because several are now). In case anyone missed it, Rainer posted a
comment to the ticket.
* http://issues.apache.org/struts/browse/WW-1537?page=all
-Ted.
On 12/4/06, Musachy Barroso [EMAIL PROTECTED] wrote:
Well, I need help on this one:
if (href != null)
addParameter(href, UrlHelper.buildUrl(findString(href), request,
response, null));
I can't figure out how to know if href (%{url}) is pointing to a url
that already contains the context. Checking if it starts with the
context really smells like a hack, and wouldn't work in the case when
the context is the same as the namespace (weird but possible after
all).
musachy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [S2] Struts 2.0.2 Build - ON HOLD
Yep, I'll look into this later at home...
Already seen your comment :)
thanks,
Rainer
The submit tag has the same problem, I logged WW-1547 just to make sure
we don't forget it.
regards
musachy
Musachy Barroso wrote:
I did missed that one :)
I'm not sure about the ajaxHref, because it means the same as
href, IMO it is going to be confusing.
What if we don't build the url at all, and just use it as it is (
addParameter(href), findString(href)), and document that the url
needs to be built with the url tag to be used on the ajax tags?
musachy
Ted Husted wrote:
GMail has been marking many JIRA posting as spam lately (no doubt
because several are now). In case anyone missed it, Rainer posted a
comment to the ticket.
* http://issues.apache.org/struts/browse/WW-1537?page=all
-Ted.
On 12/4/06, Musachy Barroso [EMAIL PROTECTED] wrote:
Well, I need help on this one:
if (href != null)
addParameter(href, UrlHelper.buildUrl(findString(href), request,
response, null));
I can't figure out how to know if href (%{url}) is pointing to a url
that already contains the context. Checking if it starts with the
context really smells like a hack, and wouldn't work in the case when
the context is the same as the namespace (weird but possible after
all).
musachy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [S2] Struts 2.0.2 Build - ON HOLD
Sorry for being a PITA :), but I have to log everything or I forget it.
thanks
musachy
Rainer Hermanns wrote:
Yep, I'll look into this later at home...
Already seen your comment :)
thanks,
Rainer
The submit tag has the same problem, I logged WW-1547 just to make sure
we don't forget it.
regards
musachy
Musachy Barroso wrote:
I did missed that one :)
I'm not sure about the ajaxHref, because it means the same as
href, IMO it is going to be confusing.
What if we don't build the url at all, and just use it as it is (
addParameter(href), findString(href)), and document that the url
needs to be built with the url tag to be used on the ajax tags?
musachy
Ted Husted wrote:
GMail has been marking many JIRA posting as spam lately (no doubt
because several are now). In case anyone missed it, Rainer posted a
comment to the ticket.
* http://issues.apache.org/struts/browse/WW-1537?page=all
-Ted.
On 12/4/06, Musachy Barroso [EMAIL PROTECTED] wrote:
Well, I need help on this one:
if (href != null)
addParameter(href, UrlHelper.buildUrl(findString(href), request,
response, null));
I can't figure out how to know if href (%{url}) is pointing to a url
that already contains the context. Checking if it starts with the
context really smells like a hack, and wouldn't work in the case when
the context is the same as the namespace (weird but possible after
all).
musachy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [S2] Struts 2.0.2 Build - ON HOLD
We're making progress. There were already problems with the 2.0.1 Showcase, a few of which we fixed, but we've also added several new problems, namely Continuation - continuations/guess.action * pause doesn't pause and the example runs through all the guesses on the first execution Prefix example * redirect-action throws a null pointer exception UI Tag Input Example (both) - tags/ui/example!input.action * birthday field missing and not linked to control * color blank, picture blank If example (freemarker) * freemarker version doesn't wrap #26 through #33, they run together as a paragraph * (In 2.0.1, both versions ran everything together.) Person Manager * Create returns: No result defined for action org.apache.struts2.showcase.person.NewPersonAction and result input * List returns: No result defined for action org.apache.struts2.showcase.person.ListPeopleAction and result success validation/quizAjax!input.action * Validation messages stack up on resubmit * Submit button is at top left rather than bottom right Store across request using MessageStoreInterceptor (Example) * If provide an age, but not a name, the system returns for the name, but clears the age. * The validation messages appear at the top and next to the field, which is confusing. Hangman * Ajax, Selected letters not displayed. This is in addition to five problems remaining from the 2.0.1, and several quirks. Since we seem to be losing ground, it doesn't seem appropriate to tag another build until we have at least stabalized our own Showcase. Right now, all the problems are being tracked in * https://issues.apache.org/struts/browse/WW-1538 I'm tied up until Monday evening. If anyone has a chance to look at these, please dive in. -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [S2] Struts 2.0.2 Build - ON HOLD
I'm assuming this is still the issue holding us up. . .if there's
anything else that needs to be done prior to the release, I've got some
spare cycles for the next few days to help push it. Just let me know
David
Ted Husted wrote:
I just filed
* https://issues.apache.org/struts/browse/WW-1537
Links in the showcase that refer to namespaces are rendering the
webapp root twice.
* http://localhost:8080/struts2-showcase/struts2-showcase/tags/non-ui/
The problem breaks a lot of the showcase links, and is going to break
links in other applications that use namespaces or paths in URL links.
It might be something simple, but we should fix it before tagging a build.
For now, I'm going to look at other things in the Showcase, in the
hope someone has a quick solution to WW-1537.
-Ted.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [S2] Struts 2.0.2 Build - ON HOLD
I might not be able to tag it tonight, but tomorrow's looking good.
In the meantime, there's are outstanding issues for Struts 2.0.3 and
2.0.x, generally, if anyone is interested. We just might want to hold
off on the patches until Friday.
*
https://issues.apache.org/struts/secure/IssueNavigator.jspa?mode=hiderequestId=10736
*
https://issues.apache.org/struts/secure/IssueNavigator.jspa?mode=hiderequestId=10735
-Ted.
On 12/6/06, David H. DeWolf [EMAIL PROTECTED] wrote:
I'm assuming this is still the issue holding us up. . .if there's
anything else that needs to be done prior to the release, I've got some
spare cycles for the next few days to help push it. Just let me know
David
Ted Husted wrote:
I just filed
* https://issues.apache.org/struts/browse/WW-1537
Links in the showcase that refer to namespaces are rendering the
webapp root twice.
* http://localhost:8080/struts2-showcase/struts2-showcase/tags/non-ui/
The problem breaks a lot of the showcase links, and is going to break
links in other applications that use namespaces or paths in URL links.
It might be something simple, but we should fix it before tagging a build.
For now, I'm going to look at other things in the Showcase, in the
hope someone has a quick solution to WW-1537.
-Ted.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
HTH, Ted.
* http://www.husted.com/struts/
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [S2] Struts 2.0.2 Build - ON HOLD
GMail has been marking many JIRA posting as spam lately (no doubt
because several are now). In case anyone missed it, Rainer posted a
comment to the ticket.
* http://issues.apache.org/struts/browse/WW-1537?page=all
-Ted.
On 12/4/06, Musachy Barroso [EMAIL PROTECTED] wrote:
Well, I need help on this one:
if (href != null)
addParameter(href, UrlHelper.buildUrl(findString(href), request,
response, null));
I can't figure out how to know if href (%{url}) is pointing to a url
that already contains the context. Checking if it starts with the
context really smells like a hack, and wouldn't work in the case when
the context is the same as the namespace (weird but possible after all).
musachy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [S2] Struts 2.0.2 Build - ON HOLD
I did missed that one :)
I'm not sure about the ajaxHref, because it means the same as href,
IMO it is going to be confusing.
What if we don't build the url at all, and just use it as it is (
addParameter(href), findString(href)), and document that the url needs
to be built with the url tag to be used on the ajax tags?
musachy
Ted Husted wrote:
GMail has been marking many JIRA posting as spam lately (no doubt
because several are now). In case anyone missed it, Rainer posted a
comment to the ticket.
* http://issues.apache.org/struts/browse/WW-1537?page=all
-Ted.
On 12/4/06, Musachy Barroso [EMAIL PROTECTED] wrote:
Well, I need help on this one:
if (href != null)
addParameter(href, UrlHelper.buildUrl(findString(href), request,
response, null));
I can't figure out how to know if href (%{url}) is pointing to a url
that already contains the context. Checking if it starts with the
context really smells like a hack, and wouldn't work in the case when
the context is the same as the namespace (weird but possible after all).
musachy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [S2] Struts 2.0.2 Build - ON HOLD
I just filed
* https://issues.apache.org/struts/browse/WW-1537
Links in the showcase that refer to namespaces are rendering the
webapp root twice.
* http://localhost:8080/struts2-showcase/struts2-showcase/tags/non-ui/
The problem breaks a lot of the showcase links, and is going to break
links in other applications that use namespaces or paths in URL links.
It might be something simple, but we should fix it before tagging a build.
For now, I'm going to look at other things in the Showcase, in the
hope someone has a quick solution to WW-1537.
-Ted.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [S2] Struts 2.0.2 Build - ON HOLD
From what I can tell, the recent patch WW-1485 broke, or at least
changed, the anchor tag. The url is being generated correctly, however,
the anchor tag is incorrectly processing the url a second time. Rainer
applied the patch, so perhaps he might know how to fix it?
Don
Ted Husted wrote:
I just filed
* https://issues.apache.org/struts/browse/WW-1537
Links in the showcase that refer to namespaces are rendering the
webapp root twice.
* http://localhost:8080/struts2-showcase/struts2-showcase/tags/non-ui/
The problem breaks a lot of the showcase links, and is going to break
links in other applications that use namespaces or paths in URL links.
It might be something simple, but we should fix it before tagging a
build.
For now, I'm going to look at other things in the Showcase, in the
hope someone has a quick solution to WW-1537.
-Ted.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [S2] Struts 2.0.2 Build - ON HOLD
Before the anchor tag was processing the href attribute like this:
addParameter(href, findString(href));
after the changes for the ajax tags, they are all processing the href
like this:
addParameter(href, UrlHelper.buildUrl(findString(href), request,
response, null));
but I can't figure out what is the relationship between Anchor and URL
musachy
Don Brown wrote:
From what I can tell, the recent patch WW-1485 broke, or at least
changed, the anchor tag. The url is being generated correctly,
however, the anchor tag is incorrectly processing the url a second
time. Rainer applied the patch, so perhaps he might know how to fix it?
Don
Ted Husted wrote:
I just filed
* https://issues.apache.org/struts/browse/WW-1537
Links in the showcase that refer to namespaces are rendering the
webapp root twice.
* http://localhost:8080/struts2-showcase/struts2-showcase/tags/non-ui/
The problem breaks a lot of the showcase links, and is going to break
links in other applications that use namespaces or paths in URL links.
It might be something simple, but we should fix it before tagging a
build.
For now, I'm going to look at other things in the Showcase, in the
hope someone has a quick solution to WW-1537.
-Ted.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [S2] Struts 2.0.2 Build - ON HOLD
And 3 seconds later :)
The anchor is just using the url(duh), so it is processing it again.
musachy
Musachy Barroso wrote:
Before the anchor tag was processing the href attribute like this:
addParameter(href, findString(href));
after the changes for the ajax tags, they are all processing the href
like this:
addParameter(href, UrlHelper.buildUrl(findString(href), request,
response, null));
but I can't figure out what is the relationship between Anchor and URL
musachy
Don Brown wrote:
From what I can tell, the recent patch WW-1485 broke, or at least
changed, the anchor tag. The url is being generated correctly,
however, the anchor tag is incorrectly processing the url a second
time. Rainer applied the patch, so perhaps he might know how to fix it?
Don
Ted Husted wrote:
I just filed
* https://issues.apache.org/struts/browse/WW-1537
Links in the showcase that refer to namespaces are rendering the
webapp root twice.
* http://localhost:8080/struts2-showcase/struts2-showcase/tags/non-ui/
The problem breaks a lot of the showcase links, and is going to break
links in other applications that use namespaces or paths in URL links.
It might be something simple, but we should fix it before tagging a
build.
For now, I'm going to look at other things in the Showcase, in the
hope someone has a quick solution to WW-1537.
-Ted.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [S2] Struts 2.0.2 Build - ON HOLD
Musachy Barroso wrote:
Before the anchor tag was processing the href attribute like this:
addParameter(href, findString(href));
after the changes for the ajax tags, they are all processing the href
like this:
addParameter(href, UrlHelper.buildUrl(findString(href), request,
response, null));
Ok, then that's the problem. When generating a url via the URL tag, it
already calls that buildUrl method, so it shouldn't be called again by
the Anchor tag. We should back that change out as it breaks existing
behavior. In general, please do be careful not to change how a tag
works, as we are going for a fully backwards compatible release in
2.0.x, or at least as close as we can get.
Don
but I can't figure out what is the relationship between Anchor and URL
musachy
Don Brown wrote:
From what I can tell, the recent patch WW-1485 broke, or at least
changed, the anchor tag. The url is being generated correctly,
however, the anchor tag is incorrectly processing the url a second
time. Rainer applied the patch, so perhaps he might know how to fix it?
Don
Ted Husted wrote:
I just filed
* https://issues.apache.org/struts/browse/WW-1537
Links in the showcase that refer to namespaces are rendering the
webapp root twice.
* http://localhost:8080/struts2-showcase/struts2-showcase/tags/non-ui/
The problem breaks a lot of the showcase links, and is going to break
links in other applications that use namespaces or paths in URL links.
It might be something simple, but we should fix it before tagging a
build.
For now, I'm going to look at other things in the Showcase, in the
hope someone has a quick solution to WW-1537.
-Ted.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [S2] Struts 2.0.2 Build - ON HOLD
The problem is that for the ajax stuff it needs buildUrl to generate the
right url, is there anything we can do to keep them both working?
musachy
On 12/4/06, Don Brown [EMAIL PROTECTED] wrote:
Musachy Barroso wrote:
Before the anchor tag was processing the href attribute like this:
addParameter(href, findString(href));
after the changes for the ajax tags, they are all processing the href
like this:
addParameter(href, UrlHelper.buildUrl(findString(href), request,
response, null));
Ok, then that's the problem. When generating a url via the URL tag, it
already calls that buildUrl method, so it shouldn't be called again by
the Anchor tag. We should back that change out as it breaks existing
behavior. In general, please do be careful not to change how a tag
works, as we are going for a fully backwards compatible release in
2.0.x, or at least as close as we can get.
Don
but I can't figure out what is the relationship between Anchor and URL
musachy
Don Brown wrote:
From what I can tell, the recent patch WW-1485 broke, or at least
changed, the anchor tag. The url is being generated correctly,
however, the anchor tag is incorrectly processing the url a second
time. Rainer applied the patch, so perhaps he might know how to fix
it?
Don
Ted Husted wrote:
I just filed
* https://issues.apache.org/struts/browse/WW-1537
Links in the showcase that refer to namespaces are rendering the
webapp root twice.
* http://localhost:8080/struts2-showcase/struts2-showcase/tags/non-ui/
The problem breaks a lot of the showcase links, and is going to break
links in other applications that use namespaces or paths in URL links.
It might be something simple, but we should fix it before tagging a
build.
For now, I'm going to look at other things in the Showcase, in the
hope someone has a quick solution to WW-1537.
-Ted.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
Hey you! Would you help me to carry the stone? Pink Floyd
Re: [S2] Struts 2.0.2 Build - ON HOLD
I don't know - you are the one that wrote the patch :) If we need to
break the new ajax tag to keep backward compatibility for the 2.0.2
release, I can live with it. Are there any examples in the showcase
that would be broken if we reverted the anchor tag behavior?
Don
Musachy Barroso wrote:
The problem is that for the ajax stuff it needs buildUrl to generate
the
right url, is there anything we can do to keep them both working?
musachy
On 12/4/06, Don Brown [EMAIL PROTECTED] wrote:
Musachy Barroso wrote:
Before the anchor tag was processing the href attribute like this:
addParameter(href, findString(href));
after the changes for the ajax tags, they are all processing the href
like this:
addParameter(href, UrlHelper.buildUrl(findString(href), request,
response, null));
Ok, then that's the problem. When generating a url via the URL tag, it
already calls that buildUrl method, so it shouldn't be called again by
the Anchor tag. We should back that change out as it breaks existing
behavior. In general, please do be careful not to change how a tag
works, as we are going for a fully backwards compatible release in
2.0.x, or at least as close as we can get.
Don
but I can't figure out what is the relationship between Anchor and URL
musachy
Don Brown wrote:
From what I can tell, the recent patch WW-1485 broke, or at least
changed, the anchor tag. The url is being generated correctly,
however, the anchor tag is incorrectly processing the url a second
time. Rainer applied the patch, so perhaps he might know how to fix
it?
Don
Ted Husted wrote:
I just filed
* https://issues.apache.org/struts/browse/WW-1537
Links in the showcase that refer to namespaces are rendering the
webapp root twice.
*
http://localhost:8080/struts2-showcase/struts2-showcase/tags/non-ui/
The problem breaks a lot of the showcase links, and is going to
break
links in other applications that use namespaces or paths in URL
links.
It might be something simple, but we should fix it before tagging a
build.
For now, I'm going to look at other things in the Showcase, in the
hope someone has a quick solution to WW-1537.
-Ted.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [S2] Struts 2.0.2 Build - ON HOLD
The anchor demo on showcase will break, if it is holding the build we can just change the Anchor class, something like addParameter(href, null); addParameter(href, findString(href)); to make it behave like before, I will fix it after 2.0.2 then. If there is anything else still pending I'd probably have time before the build. Ted? musachy On 12/4/06, Don Brown [EMAIL PROTECTED] wrote: I don't know - you are the one that wrote the patch :) If we need to break the new ajax tag to keep backward compatibility for the 2.0.2 release, I can live with it. Are there any examples in the showcase that would be broken if we reverted the anchor tag behavior? Don Musachy Barroso wrote: The problem is that for the ajax stuff it needs buildUrl to generate the right url, is there anything we can do to keep them both working? musachy On 12/4/06, Don Brown [EMAIL PROTECTED] wrote: Musachy Barroso wrote: Before the anchor tag was processing the href attribute like this: addParameter(href, findString(href)); after the changes for the ajax tags, they are all processing the href like this: addParameter(href, UrlHelper.buildUrl(findString(href), request, response, null)); Ok, then that's the problem. When generating a url via the URL tag, it already calls that buildUrl method, so it shouldn't be called again by the Anchor tag. We should back that change out as it breaks existing behavior. In general, please do be careful not to change how a tag works, as we are going for a fully backwards compatible release in 2.0.x, or at least as close as we can get. Don but I can't figure out what is the relationship between Anchor and URL musachy Don Brown wrote: From what I can tell, the recent patch WW-1485 broke, or at least changed, the anchor tag. The url is being generated correctly, however, the anchor tag is incorrectly processing the url a second time. Rainer applied the patch, so perhaps he might know how to fix it? Don Ted Husted wrote: I just filed * https://issues.apache.org/struts/browse/WW-1537 Links in the showcase that refer to namespaces are rendering the webapp root twice. * http://localhost:8080/struts2-showcase/struts2-showcase/tags/non-ui/ The problem breaks a lot of the showcase links, and is going to break links in other applications that use namespaces or paths in URL links. It might be something simple, but we should fix it before tagging a build. For now, I'm going to look at other things in the Showcase, in the hope someone has a quick solution to WW-1537. -Ted. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Hey you! Would you help me to carry the stone? Pink Floyd
Re: [S2] Struts 2.0.2 Build - ON HOLD
Well, I need help on this one:
if (href != null)
addParameter(href, UrlHelper.buildUrl(findString(href), request,
response, null));
I can't figure out how to know if href (%{url}) is pointing to a url
that already contains the context. Checking if it starts with the
context really smells like a hack, and wouldn't work in the case when
the context is the same as the namespace (weird but possible after all).
musachy
Musachy Barroso wrote:
The anchor demo on showcase will break, if it is holding the build we can
just change the Anchor class, something like
addParameter(href, null);
addParameter(href, findString(href));
to make it behave like before, I will fix it after 2.0.2 then. If
there is
anything else still pending I'd probably have time before the build. Ted?
musachy
On 12/4/06, Don Brown [EMAIL PROTECTED] wrote:
I don't know - you are the one that wrote the patch :) If we need to
break the new ajax tag to keep backward compatibility for the 2.0.2
release, I can live with it. Are there any examples in the showcase
that would be broken if we reverted the anchor tag behavior?
Don
Musachy Barroso wrote:
The problem is that for the ajax stuff it needs buildUrl to generate
the
right url, is there anything we can do to keep them both working?
musachy
On 12/4/06, Don Brown [EMAIL PROTECTED] wrote:
Musachy Barroso wrote:
Before the anchor tag was processing the href attribute like this:
addParameter(href, findString(href));
after the changes for the ajax tags, they are all processing the
href
like this:
addParameter(href, UrlHelper.buildUrl(findString(href), request,
response, null));
Ok, then that's the problem. When generating a url via the URL
tag, it
already calls that buildUrl method, so it shouldn't be called
again by
the Anchor tag. We should back that change out as it breaks existing
behavior. In general, please do be careful not to change how a tag
works, as we are going for a fully backwards compatible release in
2.0.x, or at least as close as we can get.
Don
but I can't figure out what is the relationship between Anchor and
URL
musachy
Don Brown wrote:
From what I can tell, the recent patch WW-1485 broke, or at least
changed, the anchor tag. The url is being generated correctly,
however, the anchor tag is incorrectly processing the url a second
time. Rainer applied the patch, so perhaps he might know how
to fix
it?
Don
Ted Husted wrote:
I just filed
* https://issues.apache.org/struts/browse/WW-1537
Links in the showcase that refer to namespaces are rendering the
webapp root twice.
*
http://localhost:8080/struts2-showcase/struts2-showcase/tags/non-ui/
The problem breaks a lot of the showcase links, and is going to
break
links in other applications that use namespaces or paths in URL
links.
It might be something simple, but we should fix it before
tagging a
build.
For now, I'm going to look at other things in the Showcase, in
the
hope someone has a quick solution to WW-1537.
-Ted.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
