Re: Struts 2.3.x - a new release

2015-10-12 Thread Lukasz Lenart
2015-10-12 13:31 GMT+02:00 Christoph Nenning :
>> > Can I still cherrypick changes from PRs 54 and 55 to support-2-3 ?
>>
>> It isn't possible :) I meant, XWork was moved into struts-core so
>> cherry-picking will create a file in wrong place. You can manually
>> apply the change.
>>
>
> Oh, yes. Nasty details.
>
>
>> > Or is it too late for that?
>>
>> Not sure if it was intended, author opened the PR against "master"
>> branch and didn't mention "Fix Version" in the issue.
>>
>
> I guess he wants it in the 2.3 series. I'll set JIRA accordingly.

Nicely handled, thanks a lot!


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org



Re: Struts 2.3.x - a new release

2015-10-12 Thread Christoph Nenning
> > Can I still cherrypick changes from PRs 54 and 55 to support-2-3 ?
> 
> It isn't possible :) I meant, XWork was moved into struts-core so
> cherry-picking will create a file in wrong place. You can manually
> apply the change.
> 

Oh, yes. Nasty details.


> > Or is it too late for that?
> 
> Not sure if it was intended, author opened the PR against "master"
> branch and didn't mention "Fix Version" in the issue.
> 

I guess he wants it in the 2.3 series. I'll set JIRA accordingly.



Regards,
Christoph

This Email was scanned by Sophos Anti Virus


Re: Struts 2.3.x - a new release

2015-10-12 Thread Lukasz Lenart
2015-10-12 12:57 GMT+02:00 Christoph Nenning :
> Can I still cherrypick changes from PRs 54 and 55 to support-2-3 ?

It isn't possible :) I meant, XWork was moved into struts-core so
cherry-picking will create a file in wrong place. You can manually
apply the change.

> Or is it too late for that?

Not sure if it was intended, author opened the PR against "master"
branch and didn't mention "Fix Version" in the issue.


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org



Re: Struts 2.3.x - a new release

2015-10-12 Thread Christoph Nenning
> From: Lukasz Lenart 
> To: Struts Developers List , 
> Date: 09.10.2015 17:55
> Subject: Struts 2.3.x - a new release
> 
> Hi,
> 
> I am going to spend some time on preparing a new 2.3.x release, there
> is already few issues registered. All the work will be performed in
> the "struts-2-3" branch. I am also wondering if I should merge the
> changes with Strict Method Invocation into to that branch?
> 
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20WW%20AND%
> 20resolution%20%3D%20Unresolved%20AND%20fixVersion%20%3D%202.3.x%
> 20ORDER%20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC
> 
> 

Can I still cherrypick changes from PRs 54 and 55 to support-2-3 ?

Or is it too late for that?


Regards,
Christoph

This Email was scanned by Sophos Anti Virus


Re: Struts 2.3.x - a new release

2015-10-11 Thread Lukasz Lenart
2015-10-10 11:08 GMT+02:00 Johannes Geppert :
> Hi,
>
> I think SMI has a high impact and should be better a feature for 2.5 only.
> Cause this can break some existing apps and is may not a "drop in" upgrade
> only.

You are right :)


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org



Re: Struts 2.3.x - a new release

2015-10-10 Thread Johannes Geppert
Hi,

I think SMI has a high impact and should be better a feature for 2.5 only.
Cause this can break some existing apps and is may not a "drop in" upgrade
only.

Johannes
Am 09.10.2015 5:56 nachm. schrieb "Lukasz Lenart" :

> Hi,
>
> I am going to spend some time on preparing a new 2.3.x release, there
> is already few issues registered. All the work will be performed in
> the "struts-2-3" branch. I am also wondering if I should merge the
> changes with Strict Method Invocation into to that branch?
>
>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20WW%20AND%20resolution%20%3D%20Unresolved%20AND%20fixVersion%20%3D%202.3.x%20ORDER%20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
> For additional commands, e-mail: dev-h...@struts.apache.org
>
>


Re: Struts 2.3.x - a new release

2015-10-09 Thread Lukasz Lenart
Woops! Just noticed that I have created the branch based on "master"
but I should use some of the STRUTS_2_3_x tags, will do it right now.

2015-10-09 17:58 GMT+02:00 Lukasz Lenart :
> I meant the "support-2-3" branch ;-)
>
> 2015-10-09 17:56 GMT+02:00 Lukasz Lenart :
>> Hi,
>>
>> I am going to spend some time on preparing a new 2.3.x release, there
>> is already few issues registered. All the work will be performed in
>> the "struts-2-3" branch. I am also wondering if I should merge the
>> changes with Strict Method Invocation into to that branch?
>>
>> https://issues.apache.org/jira/issues/?jql=project%20%3D%20WW%20AND%20resolution%20%3D%20Unresolved%20AND%20fixVersion%20%3D%202.3.x%20ORDER%20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC
>>
>>
>> Regards
>> --
>> Łukasz
>> + 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org



Re: Struts 2.3.x - a new release

2015-10-09 Thread Lukasz Lenart
I meant the "support-2-3" branch ;-)

2015-10-09 17:56 GMT+02:00 Lukasz Lenart :
> Hi,
>
> I am going to spend some time on preparing a new 2.3.x release, there
> is already few issues registered. All the work will be performed in
> the "struts-2-3" branch. I am also wondering if I should merge the
> changes with Strict Method Invocation into to that branch?
>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20WW%20AND%20resolution%20%3D%20Unresolved%20AND%20fixVersion%20%3D%202.3.x%20ORDER%20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org



Struts 2.3.x - a new release

2015-10-09 Thread Lukasz Lenart
Hi,

I am going to spend some time on preparing a new 2.3.x release, there
is already few issues registered. All the work will be performed in
the "struts-2-3" branch. I am also wondering if I should merge the
changes with Strict Method Invocation into to that branch?

https://issues.apache.org/jira/issues/?jql=project%20%3D%20WW%20AND%20resolution%20%3D%20Unresolved%20AND%20fixVersion%20%3D%202.3.x%20ORDER%20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC


Regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org



Re: A new release

2011-02-22 Thread Lukasz Lenart
2011/2/18 Martin Cooper :
>> Besides it's more about promoting a release. I was asking about that
>> sometime ago. It would be great to promote Betas or RCs without
>> calling for a Vote.
>
> There is no such thing as a release without a vote. Every release must
> be voted on by the PMC, no exceptions. It doesn't matter how it's
> labeled.

I've read throughout all the docs I found out and now it's a bit clear
for me - release and build - I was mixing these terms ;-)
Anyway, as you said, there is no release without a vote. I was
thinking about a test build, but right now we have snapshots, so it
should be sufficient.

I'm still missing something, but it's just matter of time to figure
out how it should be / how it works ;-)
The second thing, the whole talk about preparing the release plan
should be included into the release page - it explains a lot - many
thanks Wendy!

Ok, let's start preparing a new release ... ;-)


Kind regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Kapituła Javarsovia http://javarsovia.pl

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org



Re: A new release

2011-02-17 Thread Martin Cooper
On Mon, Jan 31, 2011 at 10:52 PM, Lukasz Lenart
 wrote:
> 2011/1/31 Paul Benedict :
>> He he.. I'll give you the answer that I got whenever I wanted to do "beta"
>> releases. Votes determine the quality of the release, not the version label.
>> So 2.2.2 could be production if it's voted that way. When you put out your
>> vote, ask:
>>
>> [ ] GA
>> [ ] Beta
>> [ ] Alpha
>>
>> If it's GA, it's production. Otherwise, beta can be published too. Alpha
>> will just stay a developer build.
>
> It's quite uncommon, thanks Paul :-)

Actually, it's not. If you look around even just the ASF, you'll find
that a number of the best-known ASF projects use this same scheme. In
fact, we didn't invent it, we adopted it from those projects.

--
Martin Cooper


>
> Kind regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
> Kapituła Javarsovia http://javarsovia.pl
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
> For additional commands, e-mail: dev-h...@struts.apache.org
>
>

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org



Re: A new release

2011-02-17 Thread Martin Cooper
On Thu, Feb 17, 2011 at 7:35 AM, Lukasz Lenart
 wrote:
> 2011/2/17 Wendy Smoak :



> Yep, that's the one of the reasons I have, another is that we fixed 41
> bugs of total 50 assigned to 2.2.2 version. The most important are
> done, the rest is related to JSONPlugin (not everyone uses) or
> development improvement. Few users requested a new release, especially
> that the most important bugs are done. So I can just postpone those
> bugs and prepare a new release or start a new thread about changing
> labeling. Hmmm preparing a new release will be faster ;-)

Yup, especially since you will find me *extremely* hard to convince. :-)

> Besides it's more about promoting a release. I was asking about that
> sometime ago. It would be great to promote Betas or RCs without
> calling for a Vote.

There is no such thing as a release without a vote. Every release must
be voted on by the PMC, no exceptions. It doesn't matter how it's
labeled.

Just to be clear, we start by building what we call a Test Build, with
the latest 3-part number. That Test Build is made available to
developers (i.e. dev@ only). After it's been available for long enough
that people have had a chance to determine how stable it is, we vote
on whether it should become a Beta release, a GA release, or not a
release at all.

As Wendy has implied, we vote on actual bits. That means that if we
had created a build as an RC, we would need to vote on it to release
the RC, and if everyone thought it was good enough to be GA, we would
need to re-roll the release with the new name (i.e. not RC now), and
vote on it *again*, because the bits are different. I don't think
that's what you want.

Having been Release Manager for about a dozen releases of Struts over
the years (not counting test builds that didn't make releases),
including through the transition from the old scheme to the new one, I
can tell you, you don't want to go back.

--
Martin Cooper


> I was looking for that discussion about labeling but didn't find,
> could you help and point to the right direction ? Maybe it was on PMC
> group ?
>
>
> Kind regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
> Kapituła Javarsovia http://javarsovia.pl
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
> For additional commands, e-mail: dev-h...@struts.apache.org
>
>

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org



Re: A new release

2011-02-17 Thread Wendy Smoak
On Thu, Feb 17, 2011 at 10:35 AM, Lukasz Lenart
 wrote:
> I was looking for that discussion about labeling but didn't find,
> could you help and point to the right direction ? Maybe it was on PMC
> group ?

I poked around on MarkMail and found some discussion in late 2004.

Try this: 
http://struts.markmail.org/search/?q=release%20version#query:release%20version%20list%3Aorg.apache.struts.dev%20date%3A200308-200504%20+page:1+mid:byisn6isnyq25lsr+state:results

> Besides it's more about promoting a release. I was asking about that
> sometime ago. It would be great to promote Betas or RCs without
> calling for a Vote.

What do you mean?

-- 
Wendy

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org



Re: A new release

2011-02-17 Thread Lukasz Lenart
2011/2/17 Wendy Smoak :
> But does it matter?  If you've tested it and it works for your
> project, who cares what the Struts developers think. ;)

No, but it gives me a clear signal what can be the origin of my problem.

> One of the reasons it was done is to eliminate double work.  If you
> use version 5.4.3-Beta for a while and decide that it's GA, then you
> have to re-do the release process to re-label the artifacts, and do
> another round of testing.  Ditto with RC1, RC2, once you decide this
> is "the one" then you have to re-do the process one last time.

It isn't a problem anymore, with Nexus on our side is just few steps
to prepare a release ;-)

> Another is that it's hard to know whether something is *really* GA
> until it gets beat on for a while.  Sure we tested as much as we
> could, but it's much easier to promote something after a couple of
> weeks than is to have to retract a GA release that turned out to have
> a fatal flaw.

Yep, that's the one of the reasons I have, another is that we fixed 41
bugs of total 50 assigned to 2.2.2 version. The most important are
done, the rest is related to JSONPlugin (not everyone uses) or
development improvement. Few users requested a new release, especially
that the most important bugs are done. So I can just postpone those
bugs and prepare a new release or start a new thread about changing
labeling. Hmmm preparing a new release will be faster ;-)

Besides it's more about promoting a release. I was asking about that
sometime ago. It would be great to promote Betas or RCs without
calling for a Vote.

I was looking for that discussion about labeling but didn't find,
could you help and point to the right direction ? Maybe it was on PMC
group ?


Kind regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Kapituła Javarsovia http://javarsovia.pl

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org



Re: A new release

2011-02-17 Thread Wendy Smoak
On Thu, Feb 17, 2011 at 10:01 AM, Lukasz Lenart
 wrote:

> The answer is simple: I'm using Maven for development basis and it's
> easy for me to switch between versions. I don't need to go to a web
> page to check if 2.2.2 is a Beta or GA. I see it just in my pom.

But does it matter?  If you've tested it and it works for your
project, who cares what the Struts developers think. ;)

One of the reasons it was done is to eliminate double work.  If you
use version 5.4.3-Beta for a while and decide that it's GA, then you
have to re-do the release process to re-label the artifacts, and do
another round of testing.  Ditto with RC1, RC2, once you decide this
is "the one" then you have to re-do the process one last time.

Once upon a time, this method of versioning had the happy side effect
of letting some of use more bleeding edge versions in production,
since we could say to the powers that be with a straight face, "I'm
using version 3.8.2" and just... not mention... that it's "only" a
beta version. ;)

Another is that it's hard to know whether something is *really* GA
until it gets beat on for a while.  Sure we tested as much as we
could, but it's much easier to promote something after a couple of
weeks than is to have to retract a GA release that turned out to have
a fatal flaw.

Anyway... I don't have a dog in this fight anymore, but if you want to
change the versioning scheme then start a new thread with a
[PROPOSAL].

-- 
Wendy

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org



Re: A new release

2011-02-17 Thread Lukasz Lenart
W dniu 17 lutego 2011 16:07 użytkownik Dave Newton
 napisał:
> Why not RCn?

Fine for me, RC or Beta it's just a signal to community, work in
progress, stay tune


Kind regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Kapituła Javarsovia http://javarsovia.pl

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org



Re: A new release

2011-02-17 Thread Dave Newton
Why not RCn?

Dave
On Feb 17, 2011 10:02 AM, "Lukasz Lenart" 
wrote:
> 2011/2/17 Wendy Smoak :
>> As release manager you can frame the vote however you want.  If you
>> have specific reasons for calling it a Beta release (unfinished
>> feature, API not yet locked down,) then you can mention them.  It's
>> unlikely the rest of the dev team will revolt and insist on labeling
>> it GA. ;)
>
> OK, thanks :-)
>
>> The convention here (decided long ago) is to use "plain" numbered
>> versions like 2.3.4 and apply a quality label to them later.  It's not
>> clear whether you want to change that, but if so I'd suggest digging
>> back through the archives to understand why it was done and then
>> starting a separate thread to discuss.
>
> The answer is simple: I'm using Maven for development basis and it's
> easy for me to switch between versions. I don't need to go to a web
> page to check if 2.2.2 is a Beta or GA. I see it just in my pom.
>
>
> Kind regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
> Kapituła Javarsovia http://javarsovia.pl
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
> For additional commands, e-mail: dev-h...@struts.apache.org
>


Re: A new release

2011-02-17 Thread Lukasz Lenart
2011/2/17 Wendy Smoak :
> As release manager you can frame the vote however you want.  If you
> have specific reasons for calling it a Beta release (unfinished
> feature, API not yet locked down,) then you can mention them.  It's
> unlikely the rest of the dev team will revolt and insist on labeling
> it GA. ;)

OK, thanks :-)

> The convention here (decided long ago) is to use "plain" numbered
> versions like 2.3.4 and apply a quality label to them later.  It's not
> clear whether you want to change that, but if so I'd suggest digging
> back through the archives to understand why it was done and then
> starting a separate thread to discuss.

The answer is simple: I'm using Maven for development basis and it's
easy for me to switch between versions. I don't need to go to a web
page to check if 2.2.2 is a Beta or GA. I see it just in my pom.


Kind regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Kapituła Javarsovia http://javarsovia.pl

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org



Re: A new release

2011-02-17 Thread Wendy Smoak
On Thu, Feb 17, 2011 at 9:11 AM, Lukasz Lenart
 wrote:
> So, is it possible to call for a Vote just with the [] Beta option ?
> If the Votes passes, the release can be officially promoted to Maven
> Central Repo as a Beta, if not, it can be deleted.

As release manager you can frame the vote however you want.  If you
have specific reasons for calling it a Beta release (unfinished
feature, API not yet locked down,) then you can mention them.  It's
unlikely the rest of the dev team will revolt and insist on labeling
it GA. ;)

The convention here (decided long ago) is to use "plain" numbered
versions like 2.3.4 and apply a quality label to them later.  It's not
clear whether you want to change that, but if so I'd suggest digging
back through the archives to understand why it was done and then
starting a separate thread to discuss.

-- 
Wendy

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org



Re: A new release

2011-02-17 Thread Lukasz Lenart
I was thinking about that and there isn't possible to release Struts
2.2.2-BETA1, I mean, the intention is to always release a GA version,
but during the Vote process it can be changed to a Beta. My point of
view is more from technical perspective. Before calling a Vote I must
walk through Maven release process where I must provide the name for
the artifacts. So in such a case it would be 2.2.2 but my intention is
to release a Beta version. So I should call it 2.2.2-BETA1 but then I
cannot cast a Vote with the GA option.

So, is it possible to call for a Vote just with the [] Beta option ?
If the Votes passes, the release can be officially promoted to Maven
Central Repo as a Beta, if not, it can be deleted.


Kind regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Kapituła Javarsovia http://javarsovia.pl

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org



Re: A new release

2011-01-31 Thread Lukasz Lenart
2011/1/31 Paul Benedict :
> He he.. I'll give you the answer that I got whenever I wanted to do "beta"
> releases. Votes determine the quality of the release, not the version label.
> So 2.2.2 could be production if it's voted that way. When you put out your
> vote, ask:
>
> [ ] GA
> [ ] Beta
> [ ] Alpha
>
> If it's GA, it's production. Otherwise, beta can be published too. Alpha
> will just stay a developer build.

It's quite uncommon, thanks Paul :-)


Kind regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Kapituła Javarsovia http://javarsovia.pl

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org



Re: A new release

2011-01-30 Thread Paul Benedict
He he.. I'll give you the answer that I got whenever I wanted to do "beta"
releases. Votes determine the quality of the release, not the version label.
So 2.2.2 could be production if it's voted that way. When you put out your
vote, ask:

[ ] GA
[ ] Beta
[ ] Alpha

If it's GA, it's production. Otherwise, beta can be published too. Alpha
will just stay a developer build.

Paul

On Mon, Jan 31, 2011 at 1:31 AM, Lukasz Lenart  wrote:

> Hi all!
>
> What about releasing a new version, say 2.2.2-BETA1 ?
>
>
> Kind regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
> Kapituła Javarsovia http://javarsovia.pl
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
> For additional commands, e-mail: dev-h...@struts.apache.org
>
>


A new release

2011-01-30 Thread Lukasz Lenart
Hi all!

What about releasing a new version, say 2.2.2-BETA1 ?


Kind regards
-- 
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
Kapituła Javarsovia http://javarsovia.pl

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org