[GitHub] john-bodley commented on issue #4552: [travis/tox] Restructuring configuration and testing

[GitBox]

john-bodley commented on issue #4552: [travis/tox] Restructuring configuration 
and testing
URL: 
https://github.com/apache/incubator-superset/pull/4552#issuecomment-378831814
 
 
   @mistercrunch I definitely explored the `pip-compile` route as it would be 
great to have `requirements.txt` autogenerated from `setup.py` and 
`requirements-dev.txt` autogenerated from `requirements-dev.in` etc. 
   
   The issue is there's not a plausible way to autogenerate a Python 2/3 
compatible `requirements.txt` file, i.e., in Python 2.7 `pip-compile` generates:
   ```
   #
   # This file is autogenerated by pip-compile
   # To update, run:
   #
   #pip-compile --output-file requirements.txt setup.py
   #
   alembic==0.9.9# via flask-migrate
   amqp==2.2.2   # via kombu
   asn1crypto==0.24.0# via cryptography
   babel==2.5.3  # via flask-babel, flower
   backports-abc==0.5# via tornado
   billiard==3.5.0.3 # via celery
   bleach==2.1.3
   boto3==1.7.0
   botocore==1.10.0  # via boto3, s3transfer
   celery==4.1.0
   certifi==2018.1.18# via requests
   cffi==1.11.5  # via cryptography
   chardet==3.0.4# via requests
   click==6.7# via flask, flask-appbuilder
   colorama==0.3.9
   cryptography==2.2.2
   docutils==0.14# via botocore
   enum34==1.1.6 # via cryptography
   flask-appbuilder==1.10.0
   flask-babel==0.11.1   # via flask-appbuilder
   flask-cache==0.13.1
   flask-compress==1.4.0
   flask-login==0.2.11   # via flask-appbuilder
   flask-migrate==2.1.1
   flask-openid==1.2.5   # via flask-appbuilder
   flask-script==2.0.6
   flask-sqlalchemy==2.1
   flask-testing==0.7.1
   flask-wtf==0.14.2
   flask==0.12.2
   flower==0.9.2
   future==0.16.0
   futures==3.2.0# via flower, s3transfer, tornado
   geopy==1.12.0
   gunicorn==19.7.1
   html5lib==1.0.1   # via bleach
   humanize==0.5.1
   idna==2.6
   ipaddress==1.0.19 # via cryptography
   itsdangerous==0.24# via flask
   jinja2==2.10  # via flask, flask-babel
   jmespath==0.9.3   # via boto3, botocore
   kombu==4.1.0  # via celery
   mako==1.0.7   # via alembic
   markdown==2.6.11
   markupsafe==1.0   # via jinja2, mako
   numpy==1.14.2 # via pandas
   pandas==0.22.0
   parsedatetime==2.4
   pathlib2==2.3.0
   polyline==1.3.2
   pycparser==2.18   # via cffi
   pydruid==0.4.2
   pyhive==0.5.1
   python-dateutil==2.6.1
   python-editor==1.0.3  # via alembic
   python-geohash==0.8.5
   python-openid==2.2.5  # via flask-openid
   pytz==2018.3  # via babel, celery, flower, pandas
   pyyaml==3.12
   requests==2.18.4
   s3transfer==0.1.13# via boto3
   sasl==0.2.1   # via thrift-sasl
   scandir==1.7  # via pathlib2
   simplejson==3.13.2
   singledispatch==3.4.0.3   # via tornado
   six==1.11.0
   sqlalchemy-utils==0.33.2
   sqlalchemy==1.2.6
   sqlparse==0.2.4
   thrift-sasl==0.3.0
   thrift==0.11.0
   tornado==5.0.1# via flower
   unicodecsv==0.14.1
   unidecode==1.0.22
   urllib3==1.22 # via requests
   vine==1.1.4   # via amqp
   webencodings==0.5.1   # via html5lib
   werkzeug==0.14.1  # via flask
   wtforms==2.1  # via flask-wtf
   ```
   however if you try to install this in Python 3 via, `pip3 install -r 
requirements.txt` it fails with the following error:
   ```
   Collecting futures==3.2.0 (from -r requirements.txt (line 33))
 Could not find a version that satisfies the requirement futures==3.2.0 
(from -r requirements.txt (line 33)) (from versions: 0.2.python3, 0.1, 0.2, 
1.0, 2.0, 2.1, 2.1.1, 2.1.2, 2.1.3, 2.1.4, 2.1.5, 2.1.6, 2.2.0, 3.0.0, 3.0.1, 
3.0.2, 3.0.3, 3.0.4, 3.0.5, 3.1.0, 3.1.1)
   No matching distribution found for futures==3.2.0 (from -r requirements.txt 
(line 33))
   ```
   I thought of two possible solutions:
   1. Enabling `pip-compile` to support multiple Python versions, which is 
something that `requirements.txt supports, i.e.,
   ```
   futures==3.2.0; python_version == '2.7'
   ```
   2. Enabling `pip-compile` to exclude dependencies (which `futures` is) which 
would make the output Python 2/3 compatible.
   
   I raised this [issue](https://github.com/jazzband/pip-tools/issues/639) with 
`pip-tools` where the suggestion was to create a `requirements.txt` for each 
environment, however I'm not certain we want to have to build/maintain 
environment specific files.



This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4552: [travis/tox] Restructuring configuration and testing

[GitBox]

codecov-io commented on issue #4552: [travis/tox] Restructuring configuration 
and testing
URL: 
https://github.com/apache/incubator-superset/pull/4552#issuecomment-371021034
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr&el=h1)
 Report
   > Merging 
[#4552](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/df4ff05441eaac7ca99f5725956f500344bc257d?src=pr&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4552/graphs/tree.svg?height=150&width=650&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#4552   +/-   ##
   ===
 Coverage   72.59%   72.59%   
   ===
 Files 205  205   
 Lines   1539915399   
 Branches 1183 1183   
   ===
 Hits1117911179   
 Misses   4217 4217   
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5)
 | `92.3% <0%> (ø)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr&el=footer).
 Last update 
[df4ff05...af9241e](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #4708: Does Superset have an API to expose a Chart's JSON data?

[GitBox]

mistercrunch commented on issue #4708: Does Superset have an API to expose a 
Chart's JSON data?
URL: 
https://github.com/apache/incubator-superset/issues/4708#issuecomment-378828914
 
 
   Flask App Builder (FAB) offers a CRUD REST API out of the box for all models.
   Check out:
   ```
   /slicemodelview/api
   /slicemodelview/api/read
   /dashboardmodelview/api
   /dashboardmodelview/api/read
   ```
   http://flask-appbuilder.readthedocs.io/en/latest/quickhowto.html#rest-api


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #4756: Improve xAxis ticks, thinner bottom margin

[GitBox]

mistercrunch commented on issue #4756: Improve xAxis ticks, thinner bottom 
margin
URL: 
https://github.com/apache/incubator-superset/pull/4756#issuecomment-378828200
 
 
   But yeah, while this doesn't fix everything, it addresses many 
visualizations defects and bugs with the xAxis and makes much better use of 
real estate. It also does not change the content of the labels which could be 
controversial and could be considered breaking backwards compatibility.
   
   It also improves the organization of axis-related controls for many chart 
types, making more consistent.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4765: [line] fix verbose names in time shift

[GitBox]

codecov-io commented on issue #4765: [line] fix verbose names in time shift
URL: 
https://github.com/apache/incubator-superset/pull/4765#issuecomment-378827057
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4765?src=pr&el=h1)
 Report
   > Merging 
[#4765](https://codecov.io/gh/apache/incubator-superset/pull/4765?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/df4ff05441eaac7ca99f5725956f500344bc257d?src=pr&el=desc)
 will **decrease** coverage by `0.01%`.
   > The diff coverage is `20%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4765/graphs/tree.svg?width=650&height=150&token=KsB0fHcx6l&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4765?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4765  +/-   ##
   ==
   - Coverage   72.59%   72.58%   -0.02% 
   ==
 Files 205  205  
 Lines   1539915400   +1 
 Branches 1183 1183  
   ==
   - Hits1117911178   -1 
   - Misses   4217 4219   +2 
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4765?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4765/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5)
 | `79.46% <20%> (-0.13%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4765?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4765?src=pr&el=footer).
 Last update 
[df4ff05...b2c1d39](https://codecov.io/gh/apache/incubator-superset/pull/4765?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4765: [line] fix verbose names in time shift

[GitBox]

codecov-io commented on issue #4765: [line] fix verbose names in time shift
URL: 
https://github.com/apache/incubator-superset/pull/4765#issuecomment-378827057
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4765?src=pr&el=h1)
 Report
   > Merging 
[#4765](https://codecov.io/gh/apache/incubator-superset/pull/4765?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/df4ff05441eaac7ca99f5725956f500344bc257d?src=pr&el=desc)
 will **decrease** coverage by `0.01%`.
   > The diff coverage is `20%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4765/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4765?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4765  +/-   ##
   ==
   - Coverage   72.59%   72.58%   -0.02% 
   ==
 Files 205  205  
 Lines   1539915400   +1 
 Branches 1183 1183  
   ==
   - Hits1117911178   -1 
   - Misses   4217 4219   +2 
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4765?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4765/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5)
 | `79.46% <20%> (-0.13%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4765?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4765?src=pr&el=footer).
 Last update 
[df4ff05...b2c1d39](https://codecov.io/gh/apache/incubator-superset/pull/4765?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #4756: Improve xAxis ticks, thinner bottom margin

[GitBox]

mistercrunch commented on issue #4756: Improve xAxis ticks, thinner bottom 
margin
URL: 
https://github.com/apache/incubator-superset/pull/4756#issuecomment-378826578
 
 
   Actually the default setting is `auto`, which turns into staggered for time 
series. We can change what `auto` means in the future. Same goes with `Adaptive 
formatting`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #4552: [travis/tox] Restructuring configuration and testing

[GitBox]

mistercrunch commented on issue #4552: [travis/tox] Restructuring configuration 
and testing
URL: 
https://github.com/apache/incubator-superset/pull/4552#issuecomment-378826189
 
 
   So if I want to add a python dep where do I do it? In setup.py AND in 
requirements.txt?
   
   I was thinking this process would involve a [documented] pip-compile step 
and the whole dep tree. 
   
   I remember we spoke about this but forgot the details on why no pip-compile 
+ pinning the whole tree. If the goal is to get as close as possible to an 
fully reproducible build, it seems like we need the whole dep tree.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] williaster commented on issue #4756: Improve xAxis ticks, thinner bottom margin

[GitBox]

williaster commented on issue #4756: Improve xAxis ticks, thinner bottom margin
URL: 
https://github.com/apache/incubator-superset/pull/4756#issuecomment-378825466
 
 
   is there a rush to merge this? would it be worthwhile to add the shorter 
date formatting in this PR and set the default to `flat`?
   
   the main concern I have is with saved slices, by merging this `staggered` is 
set for any slices saved for the foreseeable future and I'd guess users 
wouldn't go to the trouble to update them after the new concise time is added. 
another option would be a migration script to change them to `flat`, but that 
seems tricky?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch opened a new pull request #4765: [line] fix verbose names in time shift

[GitBox]

mistercrunch opened a new pull request #4765: [line] fix verbose names in time 
shift
URL: https://github.com/apache/incubator-superset/pull/4765
 
 
   https://user-images.githubusercontent.com/487433/38348683-1a0bff60-3858-11e8-85dc-76ee81e391e0.png";>
   closes https://github.com/apache/incubator-superset/issues/4750


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] lprashant-94 commented on issue #4758: [Sql_lab] Setting 100 column length limit in sql_lab resultset.

[GitBox]

lprashant-94 commented on issue #4758: [Sql_lab] Setting 100 column length 
limit in sql_lab resultset.
URL: 
https://github.com/apache/incubator-superset/pull/4758#issuecomment-378822990
 
 
   @mistercrunch, You are right. I think I should add resizable property to it 
and max width should be 200px. If I set it resizable, then user will able to 
extend some columns if required.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on a change in pull request #4746: Filtering out SQLLab views out of table list view by default

[GitBox]

mistercrunch commented on a change in pull request #4746: Filtering out SQLLab 
views out of table list view by default
URL: 
https://github.com/apache/incubator-superset/pull/4746#discussion_r179346252
 
 

 ##
 File path: superset/migrations/versions/130915240929_is_sqllab_viz_flow.py
 ##
 @@ -0,0 +1,54 @@
+"""is_sqllab_view
+
+Revision ID: 130915240929
+Revises: f231d82b9b26
+Create Date: 2018-04-03 08:19:34.098789
+
+"""
+from alembic import op
+import sqlalchemy as sa
+from sqlalchemy.ext.declarative import declarative_base
+
+from superset import db
+
+# revision identifiers, used by Alembic.
+revision = '130915240929'
+down_revision = 'f231d82b9b26'
+
+Base = declarative_base()
+
+
+class Table(Base):
+"""Declarative class to do query in upgrade"""
+__tablename__ = 'tables'
+id = sa.Column(sa.Integer, primary_key=True)
+sql = sa.Column(sa.Text)
+is_sqllab_view = sa.Column(sa.Boolean())
+
+
+def upgrade():
+bind = op.get_bind()
+op.add_column(
+'tables',
+sa.Column(
+'is_sqllab_view',
+sa.Boolean(),
+nullable=True,
+default=False,
+server_default=sa.false(),
+),
+)
+
+session = db.Session(bind=bind)
+
+# Use Slice class defined here instead of models.Slice
+for tbl in session.query(Table).all():
+if tbl.sql:
+tbl.is_sqllab_view = True
 
 Review comment:
   Right, I'm not sure how else to identify it. It's the best proxy we have. 
Note that this does not change any behavior other than being filtered out by 
default in the Table list view, but the filter can be removed anyways, so I 
didn't think it had to be perfect. Goal here is just to hide some of the 
clutter this creates.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on a change in pull request #4746: Filtering out SQLLab views out of table list view by default

[GitBox]

mistercrunch commented on a change in pull request #4746: Filtering out SQLLab 
views out of table list view by default
URL: 
https://github.com/apache/incubator-superset/pull/4746#discussion_r179346093
 
 

 ##
 File path: superset/connectors/sqla/views.py
 ##
 @@ -213,8 +216,10 @@ class TableModelView(DatasourceModelView, DeleteMixin, 
YamlExportMixin):  # noqa
 "Whether to populate the filter's dropdown in the explore "
 "view's filter section with a list of distinct values fetched "
 'from the backend on the fly'),
+'is_sqllab_view': _(
 
 Review comment:
   I could remove it from the `edit_columns` and have it only in the 
`show_columns` if you think it's better


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #4756: Improve xAxis ticks, thinner bottom margin

[GitBox]

mistercrunch commented on issue #4756: Improve xAxis ticks, thinner bottom 
margin
URL: 
https://github.com/apache/incubator-superset/pull/4756#issuecomment-378815265
 
 
   I'd also prefer `flat` to staggered as a default, but with the current 
default time formatter the labels overlap in some situation, depending on the 
time grain (some are wider) and on the width (d3.axis fits more or less tick 
density in ways we don't control).
   
   Maybe next PR on this we'd go:
   * new default `auto` format that's shorter than current `Adaptive formatting`
   * use `flat` as new default
   * somehow squeeze `Adaptive formatting` as the tooltip formatter (should be 
possible)
   
   The magic formatting is the part where the devil is in the detail and people 
may not agree on the exact layout. Here's a link to the code we have now:
   
https://github.com/apache/incubator-superset/blob/master/superset/assets/javascripts/modules/dates.js#L15
   
   Oh and we haven't even talked about locales :(


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #4764: [Dashboard Feature] Copy charts based on a dimension value

[GitBox]

mistercrunch commented on issue #4764: [Dashboard Feature] Copy charts based on 
a dimension value
URL: 
https://github.com/apache/incubator-superset/issues/4764#issuecomment-378814432
 
 
   Another idea would be to "export your dashboard as code", then check it into 
source control. Engineers can then alter the code, squeeze a for loop in there 
or something. It would all be pretty intuitive coming out of the codegen, 
except maybe for positioning & layout. Given a simpler API around layout it 
would be very powerful.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #4764: [Dashboard Feature] Copy charts based on a dimension value

[GitBox]

mistercrunch commented on issue #4764: [Dashboard Feature] Copy charts based on 
a dimension value
URL: 
https://github.com/apache/incubator-superset/issues/4764#issuecomment-378814124
 
 
   I had conversations about arrays or matrix of charts before. Idea being to 
write a for loop around a chart and varying one or many control values (filter 
value, what to groupby, metric, ...).
   
   There's power in this idea of "meta-charts" that can take one or many charts 
as input.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on a change in pull request #4760: URL shortner for dashboards

[GitBox]

mistercrunch commented on a change in pull request #4760: URL shortner for 
dashboards
URL: 
https://github.com/apache/incubator-superset/pull/4760#discussion_r179328605
 
 

 ##
 File path: superset/assets/javascripts/dashboard/dashboardUtils.js
 ##
 @@ -0,0 +1,17 @@
+/* eslint camelcase: 0 */
+import URI from 'urijs';
+
+export function getURIDirectory(dashboard) {
 
 Review comment:
   that logic already exists in the backend, you could add a line `'url': 
self.url,` here:
   
https://github.com/apache/incubator-superset/blob/master/superset/models/core.py#L378


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on a change in pull request #4760: URL shortner for dashboards

[GitBox]

mistercrunch commented on a change in pull request #4760: URL shortner for 
dashboards
URL: 
https://github.com/apache/incubator-superset/pull/4760#discussion_r179325525
 
 

 ##
 File path: superset/assets/javascripts/dashboard/components/Dashboard.jsx
 ##
 @@ -153,6 +157,27 @@ class Dashboard extends React.PureComponent {
 return this.props.filters[sliceId];
   }
 
+  addHistory({ isReplace = false, title }) {
+const payload = { ...this.props.dashboard.metadata };
+const longUrl = getDashboardLongUrl(this.props.dashboard);
+if (isReplace) {
+  history.replaceState(
 
 Review comment:
   nit: this would fit on a single line


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on a change in pull request #4760: URL shortner for dashboards

[GitBox]

mistercrunch commented on a change in pull request #4760: URL shortner for 
dashboards
URL: 
https://github.com/apache/incubator-superset/pull/4760#discussion_r179325574
 
 

 ##
 File path: superset/assets/javascripts/dashboard/components/Dashboard.jsx
 ##
 @@ -153,6 +157,27 @@ class Dashboard extends React.PureComponent {
 return this.props.filters[sliceId];
   }
 
+  addHistory({ isReplace = false, title }) {
+const payload = { ...this.props.dashboard.metadata };
+const longUrl = getDashboardLongUrl(this.props.dashboard);
+if (isReplace) {
+  history.replaceState(
+payload,
+title,
+longUrl);
+} else {
+  history.pushState(
 
 Review comment:
   nit: this would fit on a single line


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on a change in pull request #4760: URL shortner for dashboards

[GitBox]

mistercrunch commented on a change in pull request #4760: URL shortner for 
dashboards
URL: 
https://github.com/apache/incubator-superset/pull/4760#discussion_r179328605
 
 

 ##
 File path: superset/assets/javascripts/dashboard/dashboardUtils.js
 ##
 @@ -0,0 +1,17 @@
+/* eslint camelcase: 0 */
+import URI from 'urijs';
+
+export function getURIDirectory(dashboard) {
 
 Review comment:
   that logic already exists in the backend, you could add a line `'url': 
self.url,` here:
   
https://github.com/apache/incubator-superset/blob/master/superset/models/core.py#L378


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on a change in pull request #4760: URL shortner for dashboards

[GitBox]

mistercrunch commented on a change in pull request #4760: URL shortner for 
dashboards
URL: 
https://github.com/apache/incubator-superset/pull/4760#discussion_r179325754
 
 

 ##
 File path: superset/assets/javascripts/dashboard/dashboardUtils.js
 ##
 @@ -0,0 +1,17 @@
+/* eslint camelcase: 0 */
+import URI from 'urijs';
+
+export function getURIDirectory(dashboard) {
+  // Building the directory part of the URI
+  const dashboardId = dashboard.slug || dashboard.id;
+  const directory = '/superset/dashboard/' + dashboardId + '/';
 
 Review comment:
   nit we prefer template literals as in
   ```javascript
   `/superset/dashboard/${dashboardId}/`
   ```
   instead of `+`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on a change in pull request #4760: URL shortner for dashboards

[GitBox]

mistercrunch commented on a change in pull request #4760: URL shortner for 
dashboards
URL: 
https://github.com/apache/incubator-superset/pull/4760#discussion_r179326670
 
 

 ##
 File path: superset/assets/javascripts/components/URLShortLinkButton.jsx
 ##
 @@ -25,20 +27,20 @@ export default class URLShortLinkButton extends 
React.Component {
   }
 
   getCopyUrl() {
-const longUrl = getExploreLongUrl(this.props.latestQueryFormData);
+const longUrl = (this.props.type === 'Dashboard') ? 
getDashboardLongUrl(this.props.context) : getExploreLongUrl(this.props.context);
 
 Review comment:
   Now that this is becoming a more general-purpose component, a better prop 
would be `url`, and for the component to not be aware of the context beyond 
that. The caller can run context-specific logic like `getDashboardLongUrl `
   
   Let's make the component more generic.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on a change in pull request #4760: URL shortner for dashboards

[GitBox]

mistercrunch commented on a change in pull request #4760: URL shortner for 
dashboards
URL: 
https://github.com/apache/incubator-superset/pull/4760#discussion_r179344205
 
 

 ##
 File path: superset/assets/javascripts/dashboard/components/Dashboard.jsx
 ##
 @@ -153,6 +157,27 @@ class Dashboard extends React.PureComponent {
 return this.props.filters[sliceId];
   }
 
+  addHistory({ isReplace = false, title }) {
 
 Review comment:
   I'm confused about this method:
   * why using destructuring in the function parameters?
   * why do we need to alter the browser history?
   * `title` is never passed to it, won't that lead to clearing the title?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on a change in pull request #4760: URL shortner for dashboards

[GitBox]

mistercrunch commented on a change in pull request #4760: URL shortner for 
dashboards
URL: 
https://github.com/apache/incubator-superset/pull/4760#discussion_r179326998
 
 

 ##
 File path: superset/assets/javascripts/components/URLShortLinkButton.jsx
 ##
 @@ -25,20 +27,20 @@ export default class URLShortLinkButton extends 
React.Component {
   }
 
   getCopyUrl() {
-const longUrl = getExploreLongUrl(this.props.latestQueryFormData);
+const longUrl = (this.props.type === 'Dashboard') ? 
getDashboardLongUrl(this.props.context) : getExploreLongUrl(this.props.context);
 getShortUrl(longUrl, this.onShortUrlSuccess.bind(this));
   }
 
   renderPopover() {
-const emailBody = t('Check out this slice: %s', this.state.shortUrl);
+const emailBody = t('Check out this %s: %s', 
this.props.type.toLowerCase(), this.state.shortUrl);
 
 Review comment:
   `emailBody` and `emailSubject` could be the prop to make the component more 
generic


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on a change in pull request #4760: URL shortner for dashboards

[GitBox]

mistercrunch commented on a change in pull request #4760: URL shortner for 
dashboards
URL: 
https://github.com/apache/incubator-superset/pull/4760#discussion_r179344602
 
 

 ##
 File path: superset/assets/javascripts/components/URLShortLinkButton.jsx
 ##
 @@ -25,20 +27,20 @@ export default class URLShortLinkButton extends 
React.Component {
   }
 
   getCopyUrl() {
-const longUrl = getExploreLongUrl(this.props.latestQueryFormData);
+const longUrl = (this.props.type === 'Dashboard') ? 
getDashboardLongUrl(this.props.context) : getExploreLongUrl(this.props.context);
 
 Review comment:
   Also not sure why `getDashboardLongUrl` is necessary in the first place, can 
we just use `window.location`? Assuming we want the current state of the 
dashboard (with current filters), `window.location` should be in sync at that 
point.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] vylc opened a new issue #4764: [Dashboard Feature] Copy charts based on a dimension value

[GitBox]

vylc opened a new issue #4764: [Dashboard Feature] Copy charts based on a 
dimension value
URL: https://github.com/apache/incubator-superset/issues/4764
 
 
   A flavor of templating, it would be a killer feature to:
   (1) Programmatically create charts. The use case here is if I'm monitoring a 
bunch of servers and need to see each one as a time series for CPU usage.
   (2) Create charts in bulk via the UI. The use case here is if I manage a 
bunch of products, regions, territories, I'd like to see each one at one 
glance, but as a dashboard creator, don't want to create 20 charts for each 
metric I want to monitor.
   
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [ ] I have checked the superset logs for python stacktraces and included 
it here as text if any
   - [ ] I have reproduced the issue with at least the latest released version 
of superset
   - [ ] I have checked the issue tracker for the same issue and I haven't 
found one similar
   
   
   ### Superset version
   
   
   ### Expected results
   
   
   ### Actual results
   
   
   ### Steps to reproduce
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] williaster commented on issue #4756: Improve xAxis ticks, thinner bottom margin

[GitBox]

williaster commented on issue #4756: Improve xAxis ticks, thinner bottom margin
URL: 
https://github.com/apache/incubator-superset/pull/4756#issuecomment-378795429
 
 
   great addition. my only suggestion at this point is setting `flat` as the 
default because `staggered` isn't as polished / adds visual noise to the chart. 
thoughts @elibrumbaugh? 
   
   as discussed offline, in the future it'd be useful to add a 
"concise"/"compact" version of the auto time format to help fix this problem. 
this could be used for axes and the "detailed" version could be used in 
tooltips.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4552: [travis/tox] Restructuring configuration and testing

[GitBox]

codecov-io commented on issue #4552: [travis/tox] Restructuring configuration 
and testing
URL: 
https://github.com/apache/incubator-superset/pull/4552#issuecomment-371021034
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr&el=h1)
 Report
   > Merging 
[#4552](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/df4ff05441eaac7ca99f5725956f500344bc257d?src=pr&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4552/graphs/tree.svg?token=KsB0fHcx6l&src=pr&height=150&width=650)](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#4552   +/-   ##
   ===
 Coverage   72.59%   72.59%   
   ===
 Files 205  205   
 Lines   1539915399   
 Branches 1183 1183   
   ===
 Hits1117911179   
 Misses   4217 4217   
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5)
 | `92.3% <0%> (ø)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr&el=footer).
 Last update 
[df4ff05...8254499](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4552: [travis/tox] Restructuring configuration and testing

[GitBox]

codecov-io commented on issue #4552: [travis/tox] Restructuring configuration 
and testing
URL: 
https://github.com/apache/incubator-superset/pull/4552#issuecomment-371021034
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr&el=h1)
 Report
   > Merging 
[#4552](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/df4ff05441eaac7ca99f5725956f500344bc257d?src=pr&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4552/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#4552   +/-   ##
   ===
 Coverage   72.59%   72.59%   
   ===
 Files 205  205   
 Lines   1539915399   
 Branches 1183 1183   
   ===
 Hits1117911179   
 Misses   4217 4217   
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5)
 | `92.3% <0%> (ø)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr&el=footer).
 Last update 
[df4ff05...8254499](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4552: [travis/tox] Restructuring configuration and testing

[GitBox]

codecov-io commented on issue #4552: [travis/tox] Restructuring configuration 
and testing
URL: 
https://github.com/apache/incubator-superset/pull/4552#issuecomment-371021034
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr&el=h1)
 Report
   > Merging 
[#4552](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/df4ff05441eaac7ca99f5725956f500344bc257d?src=pr&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4552/graphs/tree.svg?token=KsB0fHcx6l&width=650&src=pr&height=150)](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#4552   +/-   ##
   ===
 Coverage   72.59%   72.59%   
   ===
 Files 205  205   
 Lines   1539915399   
 Branches 1183 1183   
   ===
 Hits1117911179   
 Misses   4217 4217   
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5)
 | `92.3% <0%> (ø)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr&el=footer).
 Last update 
[df4ff05...8254499](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4552: [travis/tox] Restructuring configuration and testing

[GitBox]

codecov-io commented on issue #4552: [travis/tox] Restructuring configuration 
and testing
URL: 
https://github.com/apache/incubator-superset/pull/4552#issuecomment-371021034
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr&el=h1)
 Report
   > Merging 
[#4552](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/df4ff05441eaac7ca99f5725956f500344bc257d?src=pr&el=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4552/graphs/tree.svg?width=650&src=pr&token=KsB0fHcx6l&height=150)](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#4552   +/-   ##
   ===
 Coverage   72.59%   72.59%   
   ===
 Files 205  205   
 Lines   1539915399   
 Branches 1183 1183   
   ===
 Hits1117911179   
 Misses   4217 4217   
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5)
 | `92.3% <0%> (ø)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr&el=footer).
 Last update 
[df4ff05...8254499](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] john-bodley commented on a change in pull request #4746: Filtering out SQLLab views out of table list view by default

[GitBox]

john-bodley commented on a change in pull request #4746: Filtering out SQLLab 
views out of table list view by default
URL: 
https://github.com/apache/incubator-superset/pull/4746#discussion_r179326091
 
 

 ##
 File path: superset/migrations/versions/130915240929_is_sqllab_viz_flow.py
 ##
 @@ -0,0 +1,54 @@
+"""is_sqllab_view
+
+Revision ID: 130915240929
+Revises: f231d82b9b26
+Create Date: 2018-04-03 08:19:34.098789
+
+"""
+from alembic import op
+import sqlalchemy as sa
+from sqlalchemy.ext.declarative import declarative_base
+
+from superset import db
+
+# revision identifiers, used by Alembic.
+revision = '130915240929'
+down_revision = 'f231d82b9b26'
+
+Base = declarative_base()
+
+
+class Table(Base):
+"""Declarative class to do query in upgrade"""
+__tablename__ = 'tables'
+id = sa.Column(sa.Integer, primary_key=True)
+sql = sa.Column(sa.Text)
+is_sqllab_view = sa.Column(sa.Boolean())
+
+
+def upgrade():
+bind = op.get_bind()
+op.add_column(
+'tables',
+sa.Column(
+'is_sqllab_view',
+sa.Boolean(),
+nullable=True,
+default=False,
+server_default=sa.false(),
+),
+)
+
+session = db.Session(bind=bind)
+
+# Use Slice class defined here instead of models.Slice
+for tbl in session.query(Table).all():
+if tbl.sql:
+tbl.is_sqllab_view = True
 
 Review comment:
   I guess the presence of custom SQL doesn't always imply that the SQL 
corresponds to a SQL Lab view.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] john-bodley commented on a change in pull request #4746: Filtering out SQLLab views out of table list view by default

[GitBox]

john-bodley commented on a change in pull request #4746: Filtering out SQLLab 
views out of table list view by default
URL: 
https://github.com/apache/incubator-superset/pull/4746#discussion_r179326188
 
 

 ##
 File path: superset/migrations/versions/130915240929_is_sqllab_viz_flow.py
 ##
 @@ -0,0 +1,54 @@
+"""is_sqllab_view
+
+Revision ID: 130915240929
+Revises: f231d82b9b26
+Create Date: 2018-04-03 08:19:34.098789
+
+"""
+from alembic import op
+import sqlalchemy as sa
+from sqlalchemy.ext.declarative import declarative_base
+
+from superset import db
+
+# revision identifiers, used by Alembic.
+revision = '130915240929'
+down_revision = 'f231d82b9b26'
+
+Base = declarative_base()
+
+
+class Table(Base):
+"""Declarative class to do query in upgrade"""
+__tablename__ = 'tables'
+id = sa.Column(sa.Integer, primary_key=True)
+sql = sa.Column(sa.Text)
+is_sqllab_view = sa.Column(sa.Boolean())
+
+
+def upgrade():
+bind = op.get_bind()
+op.add_column(
+'tables',
+sa.Column(
+'is_sqllab_view',
+sa.Boolean(),
+nullable=True,
+default=False,
+server_default=sa.false(),
+),
+)
+
+session = db.Session(bind=bind)
+
+# Use Slice class defined here instead of models.Slice
+for tbl in session.query(Table).all():
+if tbl.sql:
+tbl.is_sqllab_view = True
+session.merge(tbl)
+session.commit()
 
 Review comment:
   I think the `session.commit()` could be defined outside the for loop.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] john-bodley commented on a change in pull request #4746: Filtering out SQLLab views out of table list view by default

[GitBox]

john-bodley commented on a change in pull request #4746: Filtering out SQLLab 
views out of table list view by default
URL: 
https://github.com/apache/incubator-superset/pull/4746#discussion_r179325932
 
 

 ##
 File path: superset/connectors/sqla/views.py
 ##
 @@ -213,8 +216,10 @@ class TableModelView(DatasourceModelView, DeleteMixin, 
YamlExportMixin):  # noqa
 "Whether to populate the filter's dropdown in the explore "
 "view's filter section with a list of distinct values fetched "
 'from the backend on the fly'),
+'is_sqllab_view': _(
 
 Review comment:
   Is there anyway to infer this rather than it be a form option?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] john-bodley commented on issue #4552: [travis/tox] Restructuring configuration and testing

[GitBox]

john-bodley commented on issue #4552: [travis/tox] Restructuring configuration 
and testing
URL: 
https://github.com/apache/incubator-superset/pull/4552#issuecomment-378790730
 
 
   @mistercrunch sorry I was wondering what your thoughts were on this? 
Additionally having a `requirements.txt` with pinned versions would help us 
with caching Python packages in Docker.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4760: URL shortner for dashboards

[GitBox]

codecov-io commented on issue #4760: URL shortner for dashboards
URL: 
https://github.com/apache/incubator-superset/pull/4760#issuecomment-378721411
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr&el=h1)
 Report
   > Merging 
[#4760](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/9a79d33e0d19e8b49fa0392f877fd7bf4c457a22?src=pr&el=desc)
 will **increase** coverage by `0.2%`.
   > The diff coverage is `75%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4760/graphs/tree.svg?src=pr&token=KsB0fHcx6l&width=650&height=150)](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master#4760 +/-   ##
   =
   + Coverage   72.39%   72.59%   +0.2% 
   =
 Files 205  206  +1 
 Lines   1539415423 +29 
 Branches 1182 1188  +6 
   =
   + Hits1114411197 +53 
   + Misses   4247 4223 -24 
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...set/assets/javascripts/dashboard/dashboardUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2Rhc2hib2FyZC9kYXNoYm9hcmRVdGlscy5qcw==)
 | `100% <100%> (ø)` | |
   | 
[...sets/javascripts/components/URLShortLinkButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uLmpzeA==)
 | `95.83% <100%> (ø)` | |
   | 
[...cripts/explore/components/ExploreActionButtons.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWN0aW9uQnV0dG9ucy5qc3g=)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[...assets/javascripts/dashboard/components/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci5qc3g=)
 | `55.88% <100%> (+1.33%)` | :arrow_up: |
   | 
[...ets/javascripts/dashboard/components/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZC5qc3g=)
 | `69.71% <27.27%> (-2.85%)` | :arrow_down: |
   | 
[...explore/components/controls/SelectAsyncControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RBc3luY0NvbnRyb2wuanN4)
 | `63.15% <0%> (-1.55%)` | :arrow_down: |
   | 
[...s/javascripts/SqlLab/components/VisualizeModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1Zpc3VhbGl6ZU1vZGFsLmpzeA==)
 | `99.24% <0%> (ø)` | :arrow_up: |
   | 
[superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5)
 | `92.3% <0%> (+0.05%)` | :arrow_up: |
   | 
[superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==)
 | `73.48% <0%> (+2.33%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr&el=footer).
 Last update 
[9a79d33...953d2bf](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4760: URL shortner for dashboards

[GitBox]

codecov-io commented on issue #4760: URL shortner for dashboards
URL: 
https://github.com/apache/incubator-superset/pull/4760#issuecomment-378721411
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr&el=h1)
 Report
   > Merging 
[#4760](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/9a79d33e0d19e8b49fa0392f877fd7bf4c457a22?src=pr&el=desc)
 will **increase** coverage by `0.2%`.
   > The diff coverage is `75%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4760/graphs/tree.svg?token=KsB0fHcx6l&width=650&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master#4760 +/-   ##
   =
   + Coverage   72.39%   72.59%   +0.2% 
   =
 Files 205  206  +1 
 Lines   1539415423 +29 
 Branches 1182 1188  +6 
   =
   + Hits1114411197 +53 
   + Misses   4247 4223 -24 
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...set/assets/javascripts/dashboard/dashboardUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2Rhc2hib2FyZC9kYXNoYm9hcmRVdGlscy5qcw==)
 | `100% <100%> (ø)` | |
   | 
[...assets/javascripts/dashboard/components/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci5qc3g=)
 | `55.88% <100%> (+1.33%)` | :arrow_up: |
   | 
[...cripts/explore/components/ExploreActionButtons.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWN0aW9uQnV0dG9ucy5qc3g=)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[...sets/javascripts/components/URLShortLinkButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uLmpzeA==)
 | `95.83% <100%> (ø)` | |
   | 
[...ets/javascripts/dashboard/components/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZC5qc3g=)
 | `69.71% <27.27%> (-2.85%)` | :arrow_down: |
   | 
[...explore/components/controls/SelectAsyncControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RBc3luY0NvbnRyb2wuanN4)
 | `63.15% <0%> (-1.55%)` | :arrow_down: |
   | 
[...s/javascripts/SqlLab/components/VisualizeModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1Zpc3VhbGl6ZU1vZGFsLmpzeA==)
 | `99.24% <0%> (ø)` | :arrow_up: |
   | 
[superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5)
 | `92.3% <0%> (+0.05%)` | :arrow_up: |
   | 
[superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==)
 | `73.48% <0%> (+2.33%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr&el=footer).
 Last update 
[9a79d33...953d2bf](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] williaster closed pull request #4763: [dashboard builder] static layout + toasts

[GitBox]

williaster closed pull request #4763: [dashboard builder] static layout + toasts
URL: https://github.com/apache/incubator-superset/pull/4763
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] williaster commented on issue #4763: [dashboard builder] static layout + toasts

[GitBox]

williaster commented on issue #4763: [dashboard builder] static layout + toasts
URL: 
https://github.com/apache/incubator-superset/pull/4763#issuecomment-378786701
 
 
   gonna merge this (build doesn't matter for us now)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] john-bodley closed pull request #4761: [druid] Excluding refreshing verbose name

[GitBox]

john-bodley closed pull request #4761: [druid] Excluding refreshing verbose name
URL: https://github.com/apache/incubator-superset/pull/4761
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/connectors/druid/models.py 
b/superset/connectors/druid/models.py
index 9a8d6584d8..25c68acae1 100644
--- a/superset/connectors/druid/models.py
+++ b/superset/connectors/druid/models.py
@@ -372,7 +372,7 @@ def refresh_metrics(self):
 for metric in metrics.values():
 dbmetric = dbmetrics.get(metric.metric_name)
 if dbmetric:
-for attr in ['json', 'metric_type', 'verbose_name']:
+for attr in ['json', 'metric_type']:
 setattr(dbmetric, attr, getattr(metric, attr))
 else:
 with db.session.no_autoflush:
diff --git a/tests/druid_tests.py b/tests/druid_tests.py
index 7406dacbc3..b0d9caff76 100644
--- a/tests/druid_tests.py
+++ b/tests/druid_tests.py
@@ -376,13 +376,19 @@ def test_refresh_metadata(self, PyDruid):
 'double{}'.format(agg.capitalize()),
 )
 
-# Augment a metric.
-metadata = SEGMENT_METADATA[:]
-metadata[0]['columns']['metric1']['type'] = 'LONG'
-instance = PyDruid.return_value
-instance.segment_metadata.return_value = metadata
-cluster.refresh_datasources()
+@patch('superset.connectors.druid.models.PyDruid')
+def test_refresh_metadata_augment_type(self, PyDruid):
+self.login(username='admin')
+cluster = self.get_cluster(PyDruid)
+cluster.refresh_datasources()
 
+metadata = SEGMENT_METADATA[:]
+metadata[0]['columns']['metric1']['type'] = 'LONG'
+instance = PyDruid.return_value
+instance.segment_metadata.return_value = metadata
+cluster.refresh_datasources()
+
+for i, datasource in enumerate(cluster.datasources):
 metrics = (
 db.session.query(DruidMetric)
 .filter(DruidMetric.datasource_id == datasource.id)
@@ -397,6 +403,37 @@ def test_refresh_metadata(self, PyDruid):
 'long{}'.format(agg.capitalize()),
 )
 
+@patch('superset.connectors.druid.models.PyDruid')
+def test_refresh_metadata_augment_verbose_name(self, PyDruid):
+self.login(username='admin')
+cluster = self.get_cluster(PyDruid)
+cluster.refresh_datasources()
+
+for i, datasource in enumerate(cluster.datasources):
+metrics = (
+db.session.query(DruidMetric)
+.filter(DruidMetric.datasource_id == datasource.id)
+.filter(DruidMetric.metric_name.like('%__metric1'))
+)
+
+for metric in metrics:
+metric.verbose_name = metric.metric_name
+
+db.session.commit()
+
+# The verbose name should not change during a refresh.
+cluster.refresh_datasources()
+
+for i, datasource in enumerate(cluster.datasources):
+metrics = (
+db.session.query(DruidMetric)
+.filter(DruidMetric.datasource_id == datasource.id)
+.filter(DruidMetric.metric_name.like('%__metric1'))
+)
+
+for metric in metrics:
+self.assertEqual(metric.verbose_name, metric.metric_name)
+
 def test_urls(self):
 cluster = self.get_test_cluster_obj()
 self.assertEquals(


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4756: Improve xAxis ticks, thinner bottom margin

[GitBox]

codecov-io commented on issue #4756: Improve xAxis ticks, thinner bottom margin
URL: 
https://github.com/apache/incubator-superset/pull/4756#issuecomment-378512697
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4756?src=pr&el=h1)
 Report
   > Merging 
[#4756](https://codecov.io/gh/apache/incubator-superset/pull/4756?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/adda30bf6653084757f4f1a093dce6898c1bb35f?src=pr&el=desc)
 will **decrease** coverage by `0.23%`.
   > The diff coverage is `83.33%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4756/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/4756?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4756  +/-   ##
   ==
   - Coverage   72.59%   72.36%   -0.24% 
   ==
 Files 205  207   +2 
 Lines   1539715484  +87 
 Branches 1183 1193  +10 
   ==
   + Hits1117811205  +27 
   - Misses   4216 4276  +60 
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4756?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/assets/javascripts/utils/reducerUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/4756/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL3V0aWxzL3JlZHVjZXJVdGlscy5qcw==)
 | `0% <ø> (ø)` | |
   | 
[...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4756/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==)
 | `39.25% <ø> (ø)` | :arrow_up: |
   | 
[...rset/assets/javascripts/explore/stores/visTypes.js](https://codecov.io/gh/apache/incubator-superset/pull/4756/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL3Zpc1R5cGVzLmpz)
 | `70.58% <ø> (ø)` | :arrow_up: |
   | 
[superset/assets/javascripts/utils/common.js](https://codecov.io/gh/apache/incubator-superset/pull/4756/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL3V0aWxzL2NvbW1vbi5qcw==)
 | `49.05% <100%> (ø)` | |
   | 
[.../javascripts/SqlLab/components/CopyQueryTabUrl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4756/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL0NvcHlRdWVyeVRhYlVybC5qc3g=)
 | `78.57% <100%> (ø)` | :arrow_up: |
   | 
[...ascripts/explore/components/URLShortLinkButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4756/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9VUkxTaG9ydExpbmtCdXR0b24uanN4)
 | `86.95% <100%> (ø)` | :arrow_up: |
   | 
[...ssets/javascripts/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4756/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4)
 | `84.28% <100%> (ø)` | :arrow_up: |
   | 
[superset/assets/javascripts/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4756/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NoYXJ0L0NoYXJ0LmpzeA==)
 | `65.25% <33.33%> (+0.29%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4756?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4756?src=pr&el=footer).
 Last update 
[adda30b...14102d3](https://codecov.io/gh/apache/incubator-superset/pull/4756?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch closed pull request #4754: [deck_multi] fixing issues with deck_multi

[GitBox]

mistercrunch closed pull request #4754: [deck_multi] fixing issues with 
deck_multi
URL: https://github.com/apache/incubator-superset/pull/4754
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/superset/assets/javascripts/explore/components/controls/SelectAsyncControl.jsx
 
b/superset/assets/javascripts/explore/components/controls/SelectAsyncControl.jsx
index e06778fc61..ec5a365322 100644
--- 
a/superset/assets/javascripts/explore/components/controls/SelectAsyncControl.jsx
+++ 
b/superset/assets/javascripts/explore/components/controls/SelectAsyncControl.jsx
@@ -2,6 +2,7 @@
 import React from 'react';
 import PropTypes from 'prop-types';
 import Select from '../../../components/AsyncSelect';
+import ControlHeader from '../ControlHeader';
 import { t } from '../../../locales';
 
 const propTypes = {
@@ -26,24 +27,27 @@ const defaultProps = {
   placeholder: t('Select ...'),
 };
 
-const SelectAsyncControl = ({ value, onChange, dataEndpoint,
-  multi, mutator, placeholder, onAsyncErrorMessage 
}) => {
+const SelectAsyncControl = (props) => {
+  const { value, onChange, dataEndpoint, multi, mutator, placeholder, 
onAsyncErrorMessage } = props;
   const onSelectionChange = (options) => {
 const optionValues = options.map(option => option.value);
 onChange(optionValues);
   };
 
   return (
- notify.error(onAsyncErrorMessage + ': ' + 
errorMsg)}
-  mutator={mutator}
-  multi={multi}
-  value={value}
-  placeholder={placeholder}
-  valueRenderer={v => ({v.label})}
-/>
+
+  
+   notify.error(onAsyncErrorMessage + ': ' + 
errorMsg)}
+mutator={mutator}
+multi={multi}
+value={value}
+placeholder={placeholder}
+valueRenderer={v => ({v.label})}
+  />
+
   );
 };
 
diff --git a/superset/assets/javascripts/explore/stores/controls.jsx 
b/superset/assets/javascripts/explore/stores/controls.jsx
index e4a37a20ed..72baf1ff35 100644
--- a/superset/assets/javascripts/explore/stores/controls.jsx
+++ b/superset/assets/javascripts/explore/stores/controls.jsx
@@ -1979,7 +1979,7 @@ export const controls = {
 validators: [v.nonEmpty],
 default: [],
 description: t('Pick a set of deck.gl charts to layer on top of one 
another'),
-dataEndpoint: '/sliceasync/api/read?_flt_0_viz_type=deck_',
+dataEndpoint: 
'/sliceasync/api/read?_flt_0_viz_type=deck_&_flt_7_viz_type=deck_multi',
 placeholder: t('Select charts'),
 onAsyncErrorMessage: t('Error while fetching charts'),
 mutator: (data) => {
diff --git a/superset/assets/package.json b/superset/assets/package.json
index 6b271b4f3a..6d39a6b289 100644
--- a/superset/assets/package.json
+++ b/superset/assets/package.json
@@ -58,7 +58,7 @@
 "d3-tip": "^0.6.7",
 "datamaps": "^0.5.8",
 "datatables.net-bs": "^1.10.15",
-"deck.gl": "^5.0.1",
+"deck.gl": "^5.1.4",
 "deep-equal": "^1.0.1",
 "distributions": "^1.0.0",
 "dompurify": "^1.0.3",
@@ -69,8 +69,8 @@
 "jed": "^1.1.1",
 "jquery": "3.1.1",
 "lodash.throttle": "^4.1.1",
-"luma.gl": "^5.0.1",
-"mapbox-gl": "^0.43.0",
+"luma.gl": "^5.1.4",
+"mapbox-gl": "^0.44.2",
 "mathjs": "^3.20.2",
 "moment": "^2.20.1",
 "mousetrap": "^1.6.1",
diff --git a/superset/assets/visualizations/deckgl/multi.jsx 
b/superset/assets/visualizations/deckgl/multi.jsx
index aa712caa1c..4006b474cf 100644
--- a/superset/assets/visualizations/deckgl/multi.jsx
+++ b/superset/assets/visualizations/deckgl/multi.jsx
@@ -8,9 +8,7 @@ import layerGenerators from './layers';
 
 
 function deckMulti(slice, payload, setControlValue) {
-  if (!slice.subSlicesLayers) {
-slice.subSlicesLayers = {}; // eslint-disable-line no-param-reassign
-  }
+  const subSlicesLayers = {};
   const fd = slice.formData;
   const render = () => {
 const viewport = {
@@ -18,7 +16,7 @@ function deckMulti(slice, payload, setControlValue) {
   width: slice.width(),
   height: slice.height(),
 };
-const layers = Object.keys(slice.subSlicesLayers).map(k => 
slice.subSlicesLayers[k]);
+const layers = Object.keys(subSlicesLayers).map(k => subSlicesLayers[k]);
 ReactDOM.render(
{
-  // Late import to avoid circular deps
   const layer = 
layerGenerators[subsliceCopy.form_data.viz_type](subsliceCopy.form_data, data);
-  slice.subSlicesLayers[subsliceCopy.slice_id] = layer; // 
eslint-disable-line no-param-reassign
+  subSlicesLayers[subsliceCopy.slice_id] = layer;
   render();
 });
   });
diff --git a/superset/assets/yarn.lock b/superset/assets/yarn.lock
index 935cf62f64..6ca7fe1e96 100644
--- a/superset/assets/yarn.lock
+++ b/superset/assets/yarn.lock
@@ -2726,18 +2726,18 @@ decimal.js@9.0.1:
  

[GitHub] mistercrunch commented on issue #4758: [Sql_lab] Setting 100 column length limit in sql_lab resultset.

[GitBox]

mistercrunch commented on issue #4758: [Sql_lab] Setting 100 column length 
limit in sql_lab resultset.
URL: 
https://github.com/apache/incubator-superset/pull/4758#issuecomment-378780210
 
 
   100px is very small, I do agree that we need to collapse wide columns, but 
we can't assume an hover tooltip as a fallback is sufficient. It's impossible 
to copy (command-c) out of the tooltip for instance.
   
   Say if you were running a `SELECT user_satisfaction_comment FROM comments` 
you'd be mad a this feature as it would collapse your column and not even make 
use of the real estate.
   
   Let's think this through. @vylc what do you think?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4756: Improve xAxis ticks, thinner bottom margin

[GitBox]

codecov-io commented on issue #4756: Improve xAxis ticks, thinner bottom margin
URL: 
https://github.com/apache/incubator-superset/pull/4756#issuecomment-378512697
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4756?src=pr&el=h1)
 Report
   > Merging 
[#4756](https://codecov.io/gh/apache/incubator-superset/pull/4756?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/adda30bf6653084757f4f1a093dce6898c1bb35f?src=pr&el=desc)
 will **decrease** coverage by `0.23%`.
   > The diff coverage is `83.33%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4756/graphs/tree.svg?token=KsB0fHcx6l&src=pr&height=150&width=650)](https://codecov.io/gh/apache/incubator-superset/pull/4756?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4756  +/-   ##
   ==
   - Coverage   72.59%   72.36%   -0.24% 
   ==
 Files 205  207   +2 
 Lines   1539715484  +87 
 Branches 1183 1193  +10 
   ==
   + Hits1117811205  +27 
   - Misses   4216 4276  +60 
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4756?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...rset/assets/javascripts/explore/stores/visTypes.js](https://codecov.io/gh/apache/incubator-superset/pull/4756/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL3Zpc1R5cGVzLmpz)
 | `70.58% <ø> (ø)` | :arrow_up: |
   | 
[superset/assets/javascripts/utils/reducerUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/4756/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL3V0aWxzL3JlZHVjZXJVdGlscy5qcw==)
 | `0% <ø> (ø)` | |
   | 
[...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4756/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==)
 | `39.25% <ø> (ø)` | :arrow_up: |
   | 
[.../javascripts/SqlLab/components/CopyQueryTabUrl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4756/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL0NvcHlRdWVyeVRhYlVybC5qc3g=)
 | `78.57% <100%> (ø)` | :arrow_up: |
   | 
[superset/assets/javascripts/utils/common.js](https://codecov.io/gh/apache/incubator-superset/pull/4756/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL3V0aWxzL2NvbW1vbi5qcw==)
 | `49.05% <100%> (ø)` | |
   | 
[...ssets/javascripts/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4756/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4)
 | `84.28% <100%> (ø)` | :arrow_up: |
   | 
[...ascripts/explore/components/URLShortLinkButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4756/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9VUkxTaG9ydExpbmtCdXR0b24uanN4)
 | `86.95% <100%> (ø)` | :arrow_up: |
   | 
[superset/assets/javascripts/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4756/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NoYXJ0L0NoYXJ0LmpzeA==)
 | `65.25% <33.33%> (+0.29%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4756?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4756?src=pr&el=footer).
 Last update 
[adda30b...14102d3](https://codecov.io/gh/apache/incubator-superset/pull/4756?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4756: Improve xAxis ticks, thinner bottom margin

[GitBox]

codecov-io commented on issue #4756: Improve xAxis ticks, thinner bottom margin
URL: 
https://github.com/apache/incubator-superset/pull/4756#issuecomment-378512697
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4756?src=pr&el=h1)
 Report
   > Merging 
[#4756](https://codecov.io/gh/apache/incubator-superset/pull/4756?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/adda30bf6653084757f4f1a093dce6898c1bb35f?src=pr&el=desc)
 will **decrease** coverage by `0.23%`.
   > The diff coverage is `83.33%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4756/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4756?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4756  +/-   ##
   ==
   - Coverage   72.59%   72.36%   -0.24% 
   ==
 Files 205  207   +2 
 Lines   1539715484  +87 
 Branches 1183 1193  +10 
   ==
   + Hits1117811205  +27 
   - Misses   4216 4276  +60 
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4756?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/assets/javascripts/utils/reducerUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/4756/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL3V0aWxzL3JlZHVjZXJVdGlscy5qcw==)
 | `0% <ø> (ø)` | |
   | 
[...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4756/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==)
 | `39.25% <ø> (ø)` | :arrow_up: |
   | 
[...rset/assets/javascripts/explore/stores/visTypes.js](https://codecov.io/gh/apache/incubator-superset/pull/4756/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL3Zpc1R5cGVzLmpz)
 | `70.58% <ø> (ø)` | :arrow_up: |
   | 
[...ascripts/explore/components/URLShortLinkButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4756/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9VUkxTaG9ydExpbmtCdXR0b24uanN4)
 | `86.95% <100%> (ø)` | :arrow_up: |
   | 
[.../javascripts/SqlLab/components/CopyQueryTabUrl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4756/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL0NvcHlRdWVyeVRhYlVybC5qc3g=)
 | `78.57% <100%> (ø)` | :arrow_up: |
   | 
[...ssets/javascripts/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4756/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4)
 | `84.28% <100%> (ø)` | :arrow_up: |
   | 
[superset/assets/javascripts/utils/common.js](https://codecov.io/gh/apache/incubator-superset/pull/4756/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL3V0aWxzL2NvbW1vbi5qcw==)
 | `49.05% <100%> (ø)` | |
   | 
[superset/assets/javascripts/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4756/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NoYXJ0L0NoYXJ0LmpzeA==)
 | `65.25% <33.33%> (+0.29%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4756?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4756?src=pr&el=footer).
 Last update 
[adda30b...14102d3](https://codecov.io/gh/apache/incubator-superset/pull/4756?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #4756: Improve xAxis ticks, thinner bottom margin

[GitBox]

mistercrunch commented on issue #4756: Improve xAxis ticks, thinner bottom 
margin
URL: 
https://github.com/apache/incubator-superset/pull/4756#issuecomment-378777839
 
 
   @graceguo-supercat @michellethomas would love for someone at Airbnb to sign 
off on this as it will affects a million line charts over there, but that 
should be for the best.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] williaster opened a new pull request #4763: [dashboard builder] static layout + toasts

[GitBox]

williaster opened a new pull request #4763: [dashboard builder] static layout + 
toasts
URL: https://github.com/apache/incubator-superset/pull/4763
 
 
   This PR adds several improvements to the dashboard builder
   
   **redux state**
 - changed layout key from `dashboard` => `dashboardLayout` for clarity
 - added `editMode` state + actions/reducers
 - added `messageToasts` state + actions/reducers
   
   **UX improvements**
   - added `` + `` components for general messaging
 https://user-images.githubusercontent.com/4496521/38339664-4a2c7fc8-3824-11e8-86cf-2ccdf1d72736.png";
 width="300" />
   - detects and prevents parent overflow on dnd drop, notifies user via toast
 https://user-images.githubusercontent.com/4496521/38339612-f7ec2128-3823-11e8-87d5-e93bbf5bbc8f.gif";
 width="500" />
   - several tweaks to improve drag and drop UX
   
   **UI improvements**
   - propagated `editMode` prop to all `DashboardComponent`s so that they 
render in both editable + static mode (for when the dashboard is in view mode)
   - removed `Spacer` component as it added too much complexity
   - added improved transparent indicator
 https://user-images.githubusercontent.com/4496521/38339528-83778792-3823-11e8-8fee-25207ed9a698.png";
 width="300" />
   - resizable container + header style fixes to ensure that headers are always 
multiples of the grid base unit 
   
   **Cleanup / bug fix**
   - removed grid gutter components, instead added margins between row and 
column contents
   - fixed a bug with resizable containers that resulted in compressed 
component width when too many elements were in a row
   
   @graceguo-supercat @elibrumbaugh
   cc @hug @mistercrunch 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch closed issue #4739: The CSRF token has expired

[GitBox]

mistercrunch closed issue #4739: The CSRF token has expired
URL: https://github.com/apache/incubator-superset/issues/4739
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch closed pull request #4741: Set longer CSRF token duration (one week)

[GitBox]

mistercrunch closed pull request #4741: Set longer CSRF token duration (one 
week)
URL: https://github.com/apache/incubator-superset/pull/4741
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/docs/installation.rst b/docs/installation.rst
index 725dd9c28e..3036255272 100644
--- a/docs/installation.rst
+++ b/docs/installation.rst
@@ -242,17 +242,29 @@ of the parameters you can copy / paste in that 
configuration module: ::
 WTF_CSRF_ENABLED = True
 # Add endpoints that need to be exempt from CSRF protection
 WTF_CSRF_EXEMPT_LIST = []
+# A CSRF token that expires in 1 year
+WTF_CSRF_TIME_LIMIT = 60 * 60 * 24 * 365
 
 # Set this API key to enable Mapbox visualizations
 MAPBOX_API_KEY = ''
 
-This file also allows you to define configuration parameters used by
-Flask App Builder, the web framework used by Superset. Please consult
+All the parameters and default values defined in
+https://github.com/apache/incubator-superset/blob/master/superset/config.py
+can be altered in your local ``superset_config.py`` .
+Administrators will want to
+read through the file to understand what can be configured locally
+as well as the default values in place.
+
+Since ``superset_config.py`` acts as a Flask configuration module, it
+can be used to alter the settings Flask itself,
+as well as Flask extensions like ``flask-wtf``, ``flask-cache``,
+``flask-migrate``, and ``flask-appbuilder``. Flask App Builder, the web
+framework used by Superset offers many configuration settings. Please consult
 the `Flask App Builder Documentation
 `_
-for more information on how to configure Superset.
+for more information on how to configure it.
 
-Please make sure to change:
+Make sure to change:
 
 * *SQLALCHEMY_DATABASE_URI*, by default it is stored at 
*~/.superset/superset.db*
 * *SECRET_KEY*, to a long random string
diff --git a/superset/config.py b/superset/config.py
index 34788b40c1..6075352e27 100644
--- a/superset/config.py
+++ b/superset/config.py
@@ -357,6 +357,9 @@ class CeleryConfig(object):
 # It will be appended at the bottom of sql_lab errors.
 TROUBLESHOOTING_LINK = ''
 
+# CSRF token timeout, set to None for a token that never expires
+WTF_CSRF_TIME_LIMIT = 60 * 60 * 24 * 7
+
 # This link should lead to a page with instructions on how to gain access to a
 # Datasource. It will be placed at the bottom of permissions errors.
 PERMISSION_INSTRUCTIONS_LINK = ''


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #4741: Set longer CSRF token duration (one week)

[GitBox]

mistercrunch commented on issue #4741: Set longer CSRF token duration (one week)
URL: 
https://github.com/apache/incubator-superset/pull/4741#issuecomment-378770453
 
 
   I think SQL Lab surfaces the error properly and the explore view does give 
`Unexpected error`. Let me open an issue. Here: 
https://github.com/apache/incubator-superset/issues/4762


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch opened a new issue #4762: CSRF token expiration leads to "Unexpected Error"

[GitBox]

mistercrunch opened a new issue #4762: CSRF token expiration leads to 
"Unexpected Error"
URL: https://github.com/apache/incubator-superset/issues/4762
 
 
   ### Superset version
   0.24.0
   
   
   ### Expected results
   Proper error message "CSRF token has expired please refresh the page".
   
   ### Actual results
   "Unexpected Error" message
   
   ### Steps to reproduce
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #4759: Ability to add multiple sources (namely time series) to a chart

[GitBox]

mistercrunch commented on issue #4759: Ability to add multiple sources (namely 
time series) to a chart
URL: 
https://github.com/apache/incubator-superset/issues/4759#issuecomment-378769581
 
 
   Line chart only ok? That would make this feature a lot easier to build, and 
insure that most line chart-specific feature are accessible.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #4759: Ability to add multiple sources (namely time series) to a chart

[GitBox]

mistercrunch commented on issue #4759: Ability to add multiple sources (namely 
time series) to a chart
URL: 
https://github.com/apache/incubator-superset/issues/4759#issuecomment-378769581
 
 
   Line chart only ok? That would make this feature a lot easier to build, and 
insure that most line charts feature are accessible.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #4740: Add extraction function support for Druid queries

[GitBox]

mistercrunch commented on issue #4740: Add extraction function support for 
Druid queries
URL: 
https://github.com/apache/incubator-superset/pull/4740#issuecomment-378768974
 
 
   @fabianmenges do you all use extraction functions much? Do you think you can 
review/test this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #4740: Add extraction function support for Druid queries

[GitBox]

mistercrunch commented on issue #4740: Add extraction function support for 
Druid queries
URL: 
https://github.com/apache/incubator-superset/pull/4740#issuecomment-378768974
 
 
   @fabianmenges do you all use extraction functions much? Do you think you can 
review this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #4761: [druid] Excluding refreshing verbose name

[GitBox]

mistercrunch commented on issue #4761: [druid] Excluding refreshing verbose name
URL: 
https://github.com/apache/incubator-superset/pull/4761#issuecomment-378768694
 
 
   Good catch LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #844: Update to d3 v4 ?

[GitBox]

mistercrunch commented on issue #844: Update to d3 v4 ?
URL: 
https://github.com/apache/incubator-superset/issues/844#issuecomment-378768453
 
 
   There have been conversations and work in the direction or using data-ui 
which is build on top of vx, for composable, stylable, React-first 
visualization. Both projects are out of folks at Airbnb.
   
   In the meantime getting moving away from nvd3 represents a lot of work that 
is not on anyone's short term roadmap.
   
   There's also work to do lazy imports of visualization-specific JS bundles, 
meaning it's possible we'd be using both v3 and v4 at once until `nvd3` 
upgrades or until we remove our dependence on it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #844: Update to d3 v4 ?

[GitBox]

mistercrunch commented on issue #844: Update to d3 v4 ?
URL: 
https://github.com/apache/incubator-superset/issues/844#issuecomment-378768453
 
 
   There have been conversations and work in the direction or using data-ui 
which is build on top of vx, for composable, stylable, React-first 
visualization.
   
   In the meantime getting moving away from nvd3 represents a lot of work that 
is not on anyone's short term roadmap.
   
   There's also work to do lazy imports of visualization-specific JS bundles, 
meaning it's possible we'd be using both v3 and v4 at once until `nvd3` 
upgrades or until we remove our dependence on it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] john-bodley commented on issue #4551: [sql lab] option to disable cross schema search

[GitBox]

john-bodley commented on issue #4551: [sql lab] option to disable cross schema 
search
URL: 
https://github.com/apache/incubator-superset/pull/4551#issuecomment-378767310
 
 
   @mistercrunch this migration didn't cause a lock on our end. I wonder 
whether there's also merit in caching when someone chooses a schema. I think 
there's plan for us to analyze the Presto logs to see the frequency of `SHOW 
SCHEMAS` and `SHOW TABLES` queries and whether there is reason to alleviate 
additional load on the database.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mattmoehr commented on issue #844: Update to d3 v4 ?

[GitBox]

mattmoehr commented on issue #844: Update to d3 v4 ?
URL: 
https://github.com/apache/incubator-superset/issues/844#issuecomment-378746562
 
 
   I was just doing some research about version breaks in regards to D3. What I 
found is that Superset is using NVD3, which is a project that wraps and 
abstracts parts of D3. NVD3 is strongly tied to v3 of D3. See this issue 
discussion going back 2 years at the NVD3 project:
   
   https://github.com/novus/nvd3/issues/1681
   
   If I were guessing, I would guess that NVD3 will never jump to D3 v4. So I 
guess before Superset decides whether or not to jump from v3 to v4 (or v5) of 
D3, they would first need to decide if they are going to continue to use NVD3 
or go for a straight implementation of D3.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mattmoehr commented on issue #844: Update to d3 v4 ?

[GitBox]

mattmoehr commented on issue #844: Update to d3 v4 ?
URL: 
https://github.com/apache/incubator-superset/issues/844#issuecomment-378746562
 
 
   I was just doing some research about version breaks in regards to D3, and 
basically what I found is that Superset is using NVD3 which is a project that 
wraps and abstracts parts of D3. NVD3 is pretty strongly tied to v3 of D3. See 
this issue discussion going back 2 years at the NVD3 project:
   
   https://github.com/novus/nvd3/issues/1681
   
   So I guess before Superset decides whether or not to jump from v3 to v4 (or 
v5) of D3, they would first need to decide if they are going to continue to use 
NVD3 or go for a straight implementation of D3.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4754: [deck_multi] fixing issues with deck_multi

[GitBox]

codecov-io commented on issue #4754: [deck_multi] fixing issues with deck_multi
URL: 
https://github.com/apache/incubator-superset/pull/4754#issuecomment-378447046
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4754?src=pr&el=h1)
 Report
   > Merging 
[#4754](https://codecov.io/gh/apache/incubator-superset/pull/4754?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/7a497e2f6b9681c19954fc848b27f94856ab9089?src=pr&el=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `33.33%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4754/graphs/tree.svg?token=KsB0fHcx6l&src=pr&width=650&height=150)](https://codecov.io/gh/apache/incubator-superset/pull/4754?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4754  +/-   ##
   ==
   + Coverage   72.38%   72.38%   +<.01% 
   ==
 Files 205  205  
 Lines   1537415396  +22 
 Branches 1182 1182  
   ==
   + Hits1112811145  +17 
   - Misses   4243 4248   +5 
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4754?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4754/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==)
 | `39.25% <ø> (ø)` | :arrow_up: |
   | 
[...explore/components/controls/SelectAsyncControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4754/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RBc3luY0NvbnRyb2wuanN4)
 | `63.15% <33.33%> (-1.55%)` | :arrow_down: |
   | 
[superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/4754/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5)
 | `97.7% <0%> (-1.05%)` | :arrow_down: |
   | 
[superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4754/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5)
 | `79.58% <0%> (-0.04%)` | :arrow_down: |
   | 
[superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4754/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=)
 | `88.07% <0%> (+0.02%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4754?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4754?src=pr&el=footer).
 Last update 
[7a497e2...604e2f8](https://codecov.io/gh/apache/incubator-superset/pull/4754?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ttannis commented on a change in pull request #4760: URL shortner for dashboards

[GitBox]

ttannis commented on a change in pull request #4760: URL shortner for dashboards
URL: 
https://github.com/apache/incubator-superset/pull/4760#discussion_r179280068
 
 

 ##
 File path: superset/assets/javascripts/dashboard/dashboardUtils.js
 ##
 @@ -0,0 +1,17 @@
+/* eslint camelcase: 0 */
+import URI from 'urijs';
+
+export function getURIDirectory(dashboard) {
 
 Review comment:
   👍


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ttannis commented on a change in pull request #4760: URL shortner for dashboards

[GitBox]

ttannis commented on a change in pull request #4760: URL shortner for dashboards
URL: 
https://github.com/apache/incubator-superset/pull/4760#discussion_r179279931
 
 

 ##
 File path: superset/assets/javascripts/components/URLShortLinkButton.jsx
 ##
 @@ -25,20 +27,20 @@ export default class URLShortLinkButton extends 
React.Component {
   }
 
   getCopyUrl() {
-const longUrl = getExploreLongUrl(this.props.latestQueryFormData);
+const longUrl = (this.props.type === 'Dashboard') ? 
getDashboardLongUrl(this.props.context) : getExploreLongUrl(this.props.context);
 
 Review comment:
   Yeah, I noticed after uploading the effect on code coverage. I'll get to 
fixing that.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #4756: Improve xAxis ticks, thinner bottom margin

[GitBox]

mistercrunch commented on issue #4756: Improve xAxis ticks, thinner bottom 
margin
URL: 
https://github.com/apache/incubator-superset/pull/4756#issuecomment-378739069
 
 
   I agree on the [un] manageability of this file. The challenge is that the 
different visualizations both from a controls and API standpoint have a lot in 
common. A lot of code is shared in odd intricate ways. It's a though puzzle.
   
   A balanced way to evolve this would be to refactor out portion of the code 
into smaller functions an unit test those. 
   
   We've been talking about moving to `data-ui` / vx for a while, and maybe 
that's the end game and justify not spending too many cycles on `nvd3`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch closed pull request #4742: [sql lab] preserve schema through visualize flow

[GitBox]

mistercrunch closed pull request #4742: [sql lab] preserve schema through 
visualize flow
URL: https://github.com/apache/incubator-superset/pull/4742
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/assets/javascripts/SqlLab/components/QuerySearch.jsx 
b/superset/assets/javascripts/SqlLab/components/QuerySearch.jsx
index a3e4bf4dfd..9d36d85218 100644
--- a/superset/assets/javascripts/SqlLab/components/QuerySearch.jsx
+++ b/superset/assets/javascripts/SqlLab/components/QuerySearch.jsx
@@ -13,7 +13,7 @@ const $ = window.$ = require('jquery');
 
 const propTypes = {
   actions: PropTypes.object.isRequired,
-  height: PropTypes.number.isRequired,
+  height: PropTypes.string.isRequired,
 };
 
 class QuerySearch extends React.PureComponent {
diff --git a/superset/assets/javascripts/SqlLab/components/VisualizeModal.jsx 
b/superset/assets/javascripts/SqlLab/components/VisualizeModal.jsx
index 1c4315ff91..d97831c64a 100644
--- a/superset/assets/javascripts/SqlLab/components/VisualizeModal.jsx
+++ b/superset/assets/javascripts/SqlLab/components/VisualizeModal.jsx
@@ -31,6 +31,7 @@ const propTypes = {
   onHide: PropTypes.func,
   query: PropTypes.object,
   show: PropTypes.bool,
+  schema: PropTypes.string,
   datasource: PropTypes.string,
   errorMessage: PropTypes.string,
   timeout: PropTypes.number,
@@ -48,6 +49,7 @@ class VisualizeModal extends React.PureComponent {
   chartType: CHART_TYPES[0],
   datasourceName: this.datasourceName(),
   columns: this.getColumnFromProps(),
+  schema: props.query ? props.query.schema : null,
   hints: [],
 };
   }
@@ -126,6 +128,7 @@ class VisualizeModal extends React.PureComponent {
   buildVizOptions() {
 return {
   chartType: this.state.chartType.value,
+  schema: this.state.schema,
   datasourceName: this.state.datasourceName,
   columns: this.state.columns,
   sql: this.props.query.sql,
diff --git a/superset/assets/spec/javascripts/sqllab/VisualizeModal_spec.jsx 
b/superset/assets/spec/javascripts/sqllab/VisualizeModal_spec.jsx
index 6c9fc5b1ed..7c9907982f 100644
--- a/superset/assets/spec/javascripts/sqllab/VisualizeModal_spec.jsx
+++ b/superset/assets/spec/javascripts/sqllab/VisualizeModal_spec.jsx
@@ -269,6 +269,7 @@ describe('VisualizeModal', () => {
   chartType: wrapper.state().chartType.value,
   datasourceName: wrapper.state().datasourceName,
   columns: wrapper.state().columns,
+  schema: 'test_schema',
   sql: wrapper.instance().props.query.sql,
   dbId: wrapper.instance().props.query.dbId,
 });
diff --git a/superset/assets/spec/javascripts/sqllab/fixtures.js 
b/superset/assets/spec/javascripts/sqllab/fixtures.js
index 5f9df8d08c..2fef334ef7 100644
--- a/superset/assets/spec/javascripts/sqllab/fixtures.js
+++ b/superset/assets/spec/javascripts/sqllab/fixtures.js
@@ -197,7 +197,7 @@ export const queries = [
 rows: 42,
 endDttm: 1476910566798,
 limit_reached: false,
-schema: null,
+schema: 'test_schema',
 errorMessage: null,
 db: 'main',
 user: 'admin',
diff --git a/superset/views/core.py b/superset/views/core.py
index 91a420ae28..c2099e3007 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -2160,6 +2160,7 @@ def sqllab_viz(self):
 if not table:
 table = SqlaTable(table_name=table_name)
 table.database_id = data.get('dbId')
+table.schema = data.get('schema')
 q = SupersetQuery(data.get('sql'))
 table.sql = q.stripped()
 db.session.add(table)
diff --git a/tests/sqllab_tests.py b/tests/sqllab_tests.py
index afab1403f0..4626f53093 100644
--- a/tests/sqllab_tests.py
+++ b/tests/sqllab_tests.py
@@ -226,6 +226,37 @@ def test_df_conversion_dict(self):
 self.assertEquals(len(data), cdf.size)
 self.assertEquals(len(cols), len(cdf.columns))
 
+def test_sqllab_viz(self):
+payload = {
+'chartType': 'dist_bar',
+'datasourceName': 'test_viz_flow_table',
+'schema': 'superset',
+'columns': {
+'viz_type': {
+'is_date': False,
+'type': 'STRING',
+'nam:qe': 'viz_type',
+'is_dim': True,
+},
+'ccount': {
+'is_date': False,
+'type': 'OBJECT',
+'name': 'ccount',
+'is_dim': True,
+'agg': 'sum',
+},
+},
+'sql': """\
+SELECT viz_type, count(1) as ccount
+FROM slices
+WHERE viz_type LIKE '%%a%%'
+GROUP BY viz_type""",
+'dbId': 1,
+}
+

[GitHub] codecov-io commented on issue #4761: [druid] Excluding refreshing verbose name

[GitBox]

codecov-io commented on issue #4761: [druid] Excluding refreshing verbose name
URL: 
https://github.com/apache/incubator-superset/pull/4761#issuecomment-378736710
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4761?src=pr&el=h1)
 Report
   > Merging 
[#4761](https://codecov.io/gh/apache/incubator-superset/pull/4761?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/9a79d33e0d19e8b49fa0392f877fd7bf4c457a22?src=pr&el=desc)
 will **not change** coverage.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4761/graphs/tree.svg?token=KsB0fHcx6l&width=650&src=pr&height=150)](https://codecov.io/gh/apache/incubator-superset/pull/4761?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#4761   +/-   ##
   ===
 Coverage   72.39%   72.39%   
   ===
 Files 205  205   
 Lines   1539415394   
 Branches 1182 1182   
   ===
 Hits1114411144   
 Misses   4247 4247   
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4761?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4761/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=)
 | `81.61% <100%> (ø)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4761?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4761?src=pr&el=footer).
 Last update 
[9a79d33...3ef9b48](https://codecov.io/gh/apache/incubator-superset/pull/4761?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] john-bodley opened a new pull request #4761: [druid] Excluding refreshing verbose name

[GitBox]

john-bodley opened a new pull request #4761: [druid] Excluding refreshing 
verbose name
URL: https://github.com/apache/incubator-superset/pull/4761
 
 
   The verbose name is often user defined however when refreshing Druid metrics 
this would be overwritten. This PR removes setting of the `verbose_name` 
attribute for existing metrics during a refresh. 
   
   Note I added a unit test for this case and decided to re-factor the various 
refresh metadata checks into separate tests. 
   
   to: @michellethomas @mistercrunch 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] hughhhh commented on a change in pull request #4760: Dptools 414 dashboard url

[GitBox]

hug commented on a change in pull request #4760: Dptools 414 dashboard url
URL: 
https://github.com/apache/incubator-superset/pull/4760#discussion_r179269531
 
 

 ##
 File path: superset/assets/javascripts/dashboard/dashboardUtils.js
 ##
 @@ -0,0 +1,17 @@
+/* eslint camelcase: 0 */
+import URI from 'urijs';
+
+export function getURIDirectory(dashboard) {
 
 Review comment:
   Also add a few unit test here for the utils as well?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] hughhhh commented on a change in pull request #4760: Dptools 414 dashboard url

[GitBox]

hug commented on a change in pull request #4760: Dptools 414 dashboard url
URL: 
https://github.com/apache/incubator-superset/pull/4760#discussion_r179269372
 
 

 ##
 File path: superset/assets/javascripts/components/URLShortLinkButton.jsx
 ##
 @@ -25,20 +27,20 @@ export default class URLShortLinkButton extends 
React.Component {
   }
 
   getCopyUrl() {
-const longUrl = getExploreLongUrl(this.props.latestQueryFormData);
+const longUrl = (this.props.type === 'Dashboard') ? 
getDashboardLongUrl(this.props.context) : getExploreLongUrl(this.props.context);
 
 Review comment:
   Can we write a small unit test for this function?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on a change in pull request #4755: Pass granularity from backend to frontend as ISO duration

[GitBox]

mistercrunch commented on a change in pull request #4755: Pass granularity from 
backend to frontend as ISO duration
URL: 
https://github.com/apache/incubator-superset/pull/4755#discussion_r179266163
 
 

 ##
 File path: superset/assets/javascripts/explore/stores/controls.jsx
 ##
 @@ -699,21 +699,21 @@ export const controls = {
 freeForm: true,
 label: t('Time Granularity'),
 default: 'one day',
-choices: formatSelectOptions([
-  'all',
-  '5 seconds',
-  '30 seconds',
-  '1 minute',
-  '5 minutes',
-  '1 hour',
-  '6 hour',
-  '1 day',
-  '7 days',
-  'week',
-  'week_starting_sunday',
-  'week_ending_saturday',
-  'month',
-]),
+choices: [
+  [null, 'all'],
+  ['PT5S', '5 seconds'],
 
 Review comment:
   If a chart has been saved with a string say `5 seconds` as a value, did you 
confirm that this load up ok in here as a "free form" value? From my 
understanding it should.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4760: Dptools 414 dashboard url

[GitBox]

codecov-io commented on issue #4760: Dptools 414 dashboard url
URL: 
https://github.com/apache/incubator-superset/pull/4760#issuecomment-378721411
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr&el=h1)
 Report
   > Merging 
[#4760](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/9a79d33e0d19e8b49fa0392f877fd7bf4c457a22?src=pr&el=desc)
 will **decrease** coverage by `0.06%`.
   > The diff coverage is `46.87%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4760/graphs/tree.svg?token=KsB0fHcx6l&src=pr&height=150&width=650)](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4760  +/-   ##
   ==
   - Coverage   72.39%   72.33%   -0.07% 
   ==
 Files 205  206   +1 
 Lines   1539415418  +24 
 Branches 1182 1187   +5 
   ==
   + Hits1114411152   +8 
   - Misses   4247 4263  +16 
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...cripts/explore/components/ExploreActionButtons.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWN0aW9uQnV0dG9ucy5qc3g=)
 | `100% <100%> (ø)` | :arrow_up: |
   | 
[...assets/javascripts/dashboard/components/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci5qc3g=)
 | `55.88% <100%> (+1.33%)` | :arrow_up: |
   | 
[...set/assets/javascripts/dashboard/dashboardUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2Rhc2hib2FyZC9kYXNoYm9hcmRVdGlscy5qcw==)
 | `27.27% <27.27%> (ø)` | |
   | 
[...ets/javascripts/dashboard/components/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZC5qc3g=)
 | `69.71% <27.27%> (-2.85%)` | :arrow_down: |
   | 
[...sets/javascripts/components/URLShortLinkButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4760/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uLmpzeA==)
 | `87.5% <85.71%> (ø)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr&el=footer).
 Last update 
[9a79d33...fc10c05](https://codecov.io/gh/apache/incubator-superset/pull/4760?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ttannis opened a new pull request #4760: Dptools 414 dashboard url

[GitBox]

ttannis opened a new pull request #4760: Dptools 414 dashboard url
URL: https://github.com/apache/incubator-superset/pull/4760
 
 
   This PR addresses issue #4309 filed by @vylc. A URLShortLinkButton has been 
added to the dashboard, and the component has been refactored to be able to be 
shared in the dashboard view and explore view.
   
   
![url_dashboard](https://user-images.githubusercontent.com/1790900/38329673-642833e8-3803-11e8-8dc4-31d89545beea.gif)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] betodealmeida commented on a change in pull request #4754: [deck_multi] fixing issues with deck_multi

[GitBox]

betodealmeida commented on a change in pull request #4754: [deck_multi] fixing 
issues with deck_multi
URL: 
https://github.com/apache/incubator-superset/pull/4754#discussion_r179254409
 
 

 ##
 File path: superset/assets/visualizations/deckgl/multi.jsx
 ##
 @@ -8,17 +8,15 @@ import layerGenerators from './layers';
 
 
 function deckMulti(slice, payload, setControlValue) {
-  if (!slice.subSlicesLayers) {
-slice.subSlicesLayers = {}; // eslint-disable-line no-param-reassign
-  }
+  const subSlicesLayers = {}; // eslint-disable-line no-param-reassign
 
 Review comment:
   You can remove the eslint comment here, no?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] betodealmeida commented on a change in pull request #4754: [deck_multi] fixing issues with deck_multi

[GitBox]

betodealmeida commented on a change in pull request #4754: [deck_multi] fixing 
issues with deck_multi
URL: 
https://github.com/apache/incubator-superset/pull/4754#discussion_r179254609
 
 

 ##
 File path: superset/assets/visualizations/deckgl/multi.jsx
 ##
 @@ -49,9 +47,8 @@ function deckMulti(slice, payload, setControlValue) {
 
 const url = getExploreLongUrl(subsliceCopy.form_data, 'json');
 $.get(url, (data) => {
-  // Late import to avoid circular deps
   const layer = 
layerGenerators[subsliceCopy.form_data.viz_type](subsliceCopy.form_data, data);
-  slice.subSlicesLayers[subsliceCopy.slice_id] = layer; // 
eslint-disable-line no-param-reassign
+  subSlicesLayers[subsliceCopy.slice_id] = layer; // eslint-disable-line 
no-param-reassign
 
 Review comment:
   Same here, eslint comment should not be necessary.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] vylc opened a new issue #4759: Ability to add multiple sources (namely time series) to a chart

[GitBox]

vylc opened a new issue #4759: Ability to add multiple sources (namely time 
series) to a chart
URL: https://github.com/apache/incubator-superset/issues/4759
 
 
   Currently, the best way to add multiple datasets to the same chart is to use 
annotations. However, annotation layers don't respond to filters.
   The deck.gl Multi-layer model is great, but is only available for geospatial 
visualizations right now.
   
   If we can do the same thing for line charts, this would be huge
   
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [ ] I have checked the superset logs for python stacktraces and included 
it here as text if any
   - [ ] I have reproduced the issue with at least the latest released version 
of superset
   - [ ] I have checked the issue tracker for the same issue and I haven't 
found one similar
   
   
   ### Superset version
   
   
   ### Expected results
   
   
   ### Actual results
   
   
   ### Steps to reproduce
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] betodealmeida commented on a change in pull request #4756: Improve xAxis ticks, thinner bottom margin

[GitBox]

betodealmeida commented on a change in pull request #4756: Improve xAxis ticks, 
thinner bottom margin
URL: 
https://github.com/apache/incubator-superset/pull/4756#discussion_r179226751
 
 

 ##
 File path: superset/assets/visualizations/nvd3_vis.js
 ##
 @@ -160,31 +145,57 @@ function nvd3Vis(slice, payload) {
   svg = d3.select(slice.selector).append('svg');
 }
 let height = slice.height();
+const isTimeSeries = [
+  'line', 'dual_line', 'area', 'compare', 'bar', 
'time_pivot'].indexOf(vizType) >= 0;
+
+// Handling xAxis ticks settings
+let xLabelRotation = 0;
+let staggerLabels = false;
+if (fd.x_ticks_layout === 'auto') {
+  if (['column', 'dist_bar'].indexOf(vizType) >= 0) {
+xLabelRotation = 45;
+  } else if (isTimeSeries) {
+staggerLabels = true;
+  }
+} else if (fd.x_ticks_layout === 'staggered') {
+  staggerLabels = true;
+} else if (fd.x_ticks_layout === '45°') {
+  if (fd.show_brush === true || fd.show_brush === 'yes') {
 
 Review comment:
   This seems to be a common pattern when we add more options to a control 
(usually when "auto" is added to an on/off control). Maybe we should have a 
function called `isTruthy`, eg:
   
   ```javascript
   function isTruthy(obj) {
   if (typeof variable === 'boolean') {
   return obj;
   } else if (typeof variable === 'string') {
   return obj.toLowerCase() !== 'no';
   } else {
   return !!obj;
   }
   }
   ```
   
   Or maybe not. Just thinking out loud. :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] betodealmeida commented on a change in pull request #4756: Improve xAxis ticks, thinner bottom margin

[GitBox]

betodealmeida commented on a change in pull request #4756: Improve xAxis ticks, 
thinner bottom margin
URL: 
https://github.com/apache/incubator-superset/pull/4756#discussion_r179228737
 
 

 ##
 File path: superset/assets/visualizations/nvd3_vis.js
 ##
 @@ -160,31 +145,57 @@ function nvd3Vis(slice, payload) {
   svg = d3.select(slice.selector).append('svg');
 }
 let height = slice.height();
+const isTimeSeries = [
+  'line', 'dual_line', 'area', 'compare', 'bar', 
'time_pivot'].indexOf(vizType) >= 0;
+
+// Handling xAxis ticks settings
+let xLabelRotation = 0;
+let staggerLabels = false;
+if (fd.x_ticks_layout === 'auto') {
+  if (['column', 'dist_bar'].indexOf(vizType) >= 0) {
+xLabelRotation = 45;
+  } else if (isTimeSeries) {
+staggerLabels = true;
+  }
+} else if (fd.x_ticks_layout === 'staggered') {
+  staggerLabels = true;
+} else if (fd.x_ticks_layout === '45°') {
+  if (fd.show_brush === true || fd.show_brush === 'yes') {
+const error = t('You cannot use 45° tick layout along with the time 
range filter');
+slice.error(error);
+return null;
+  }
+  xLabelRotation = 45;
+}
+const showBrush = (
+  fd.show_brush === true ||
+  fd.show_brush === 'yes' ||
 
 Review comment:
   ^ here it is, the other use for `isTruthy`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4758: [Sql_lab] Setting 100 column length limit in sql_lab resultset.

[GitBox]

codecov-io commented on issue #4758: [Sql_lab] Setting 100 column length limit 
in sql_lab resultset.
URL: 
https://github.com/apache/incubator-superset/pull/4758#issuecomment-378701560
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr&el=h1)
 Report
   > Merging 
[#4758](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/9a79d33e0d19e8b49fa0392f877fd7bf4c457a22?src=pr&el=desc)
 will **not change** coverage.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4758/graphs/tree.svg?src=pr&width=650&token=KsB0fHcx6l&height=150)](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#4758   +/-   ##
   ===
 Coverage   72.39%   72.39%   
   ===
 Files 205  205   
 Lines   1539415394   
 Branches 1182 1182   
   ===
 Hits1114411144   
 Misses   4247 4247   
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...pts/components/FilterableTable/FilterableTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4758/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL0ZpbHRlcmFibGVUYWJsZS5qc3g=)
 | `91.95% <100%> (ø)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr&el=footer).
 Last update 
[9a79d33...368006d](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4758: [Sql_lab] Setting 100 column length limit in sql_lab resultset.

[GitBox]

codecov-io commented on issue #4758: [Sql_lab] Setting 100 column length limit 
in sql_lab resultset.
URL: 
https://github.com/apache/incubator-superset/pull/4758#issuecomment-378701560
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr&el=h1)
 Report
   > Merging 
[#4758](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/9a79d33e0d19e8b49fa0392f877fd7bf4c457a22?src=pr&el=desc)
 will **not change** coverage.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4758/graphs/tree.svg?token=KsB0fHcx6l&src=pr&height=150&width=650)](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr&el=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#4758   +/-   ##
   ===
 Coverage   72.39%   72.39%   
   ===
 Files 205  205   
 Lines   1539415394   
 Branches 1182 1182   
   ===
 Hits1114411144   
 Misses   4247 4247   
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...pts/components/FilterableTable/FilterableTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4758/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL0ZpbHRlcmFibGVUYWJsZS5qc3g=)
 | `91.95% <100%> (ø)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr&el=footer).
 Last update 
[9a79d33...368006d](https://codecov.io/gh/apache/incubator-superset/pull/4758?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] lprashant-94 opened a new pull request #4758: [Sql_lab] Setting 100 column length limit in sql_lab resultset.

[GitBox]

lprashant-94 opened a new pull request #4758: [Sql_lab] Setting 100 column 
length limit in sql_lab resultset.
URL: https://github.com/apache/incubator-superset/pull/4758
 
 
   Fix: #2900
   
   Setting 100 column length limit in sql_lab resultset. 
   
![query_result](https://user-images.githubusercontent.com/23256596/38326114-746b7e28-3834-11e8-98c0-07b7ba537a3f.jpg)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] GabeLoins commented on issue #4729: [explore] don't prompt to 'Run Query' on viewport change

[GitBox]

GabeLoins commented on issue #4729: [explore] don't prompt to 'Run Query' on 
viewport change
URL: 
https://github.com/apache/incubator-superset/pull/4729#issuecomment-378688131
 
 
   Nice! Glad you found a way out. Closing my old PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] GabeLoins commented on issue #4610: [Explore] removing refresh chart overlay on deck_gl charts

[GitBox]

GabeLoins commented on issue #4610: [Explore] removing refresh chart overlay on 
deck_gl charts
URL: 
https://github.com/apache/incubator-superset/pull/4610#issuecomment-378688089
 
 
   closing in favor of: https://github.com/apache/incubator-superset/pull/4729


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] GabeLoins closed pull request #4610: [Explore] removing refresh chart overlay on deck_gl charts

[GitBox]

GabeLoins closed pull request #4610: [Explore] removing refresh chart overlay 
on deck_gl charts
URL: https://github.com/apache/incubator-superset/pull/4610
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/assets/javascripts/chart/Chart.jsx 
b/superset/assets/javascripts/chart/Chart.jsx
index 54736e53cb..241082ead6 100644
--- a/superset/assets/javascripts/chart/Chart.jsx
+++ b/superset/assets/javascripts/chart/Chart.jsx
@@ -223,6 +223,7 @@ class Chart extends React.PureComponent {
   !this.props.chartAlert &&
   this.props.refreshOverlayVisible &&
   !this.props.errorMessage &&
+  !this.props.vizType.startsWith('deck_') &&
   

[GitHub] codecov-io commented on issue #4755: Pass granularity from backend to frontend as ISO duration

[GitBox]

codecov-io commented on issue #4755: Pass granularity from backend to frontend 
as ISO duration
URL: 
https://github.com/apache/incubator-superset/pull/4755#issuecomment-378680060
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4755?src=pr&el=h1)
 Report
   > Merging 
[#4755](https://codecov.io/gh/apache/incubator-superset/pull/4755?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/7a497e2f6b9681c19954fc848b27f94856ab9089?src=pr&el=desc)
 will **decrease** coverage by `0.04%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4755/graphs/tree.svg?token=KsB0fHcx6l&height=150&src=pr&width=650)](https://codecov.io/gh/apache/incubator-superset/pull/4755?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4755  +/-   ##
   ==
   - Coverage   72.38%   72.33%   -0.05% 
   ==
 Files 205  205  
 Lines   1537415394  +20 
 Branches 1182 1182  
   ==
   + Hits1112811136   +8 
   - Misses   4243 4255  +12 
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4755?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4755/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==)
 | `39.25% <ø> (ø)` | :arrow_up: |
   | 
[superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4755/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5)
 | `51.89% <100%> (ø)` | :arrow_up: |
   | 
[superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4755/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=)
 | `86.52% <100%> (ø)` | :arrow_up: |
   | 
[superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4755/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==)
 | `77.08% <100%> (-0.21%)` | :arrow_down: |
   | 
[superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/4755/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5)
 | `97.7% <0%> (-1.05%)` | :arrow_down: |
   | 
[superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4755/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5)
 | `79.1% <0%> (-0.53%)` | :arrow_down: |
   | 
[superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4755/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=)
 | `88.07% <0%> (+0.02%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4755?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4755?src=pr&el=footer).
 Last update 
[7a497e2...9c08b66](https://codecov.io/gh/apache/incubator-superset/pull/4755?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4740: Add extraction function support for Druid queries

[GitBox]

codecov-io commented on issue #4740: Add extraction function support for Druid 
queries
URL: 
https://github.com/apache/incubator-superset/pull/4740#issuecomment-378676086
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4740?src=pr&el=h1)
 Report
   > Merging 
[#4740](https://codecov.io/gh/apache/incubator-superset/pull/4740?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/11c9e67ebb957d1782c26ebb242a951537266cfb?src=pr&el=desc)
 will **increase** coverage by `0.16%`.
   > The diff coverage is `81.42%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4740/graphs/tree.svg?height=150&width=650&token=KsB0fHcx6l&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4740?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4740  +/-   ##
   ==
   + Coverage   72.22%   72.38%   +0.16% 
   ==
 Files 204  205   +1 
 Lines   1532415431 +107 
 Branches 1181 1182   +1 
   ==
   + Hits1106711169 +102 
   - Misses   4254 4259   +5 
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4740?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4740/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=)
 | `80.97% <81.42%> (+1.71%)` | :arrow_up: |
   | 
[superset/assets/javascripts/modules/sandbox.js](https://codecov.io/gh/apache/incubator-superset/pull/4740/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL21vZHVsZXMvc2FuZGJveC5qcw==)
 | `93.75% <0%> (-6.25%)` | :arrow_down: |
   | 
[superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/4740/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5)
 | `97.7% <0%> (-1.05%)` | :arrow_down: |
   | 
[superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4740/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5)
 | `79.58% <0%> (-0.04%)` | :arrow_down: |
   | 
[...assets/javascripts/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4740/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=)
 | `77.88% <0%> (ø)` | :arrow_up: |
   | 
[...scripts/SqlLab/components/RunQueryActionButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4740/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1J1blF1ZXJ5QWN0aW9uQnV0dG9uLmpzeA==)
 | `88% <0%> (ø)` | :arrow_up: |
   | 
[...ts/javascripts/SqlLab/components/TabStatusIcon.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4740/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1RhYlN0YXR1c0ljb24uanN4)
 | `94.44% <0%> (ø)` | |
   | 
[superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4740/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=)
 | `88.07% <0%> (+0.02%)` | :arrow_up: |
   | 
[...javascripts/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4740/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4)
 | `91.74% <0%> (+0.07%)` | :arrow_up: |
   | 
[superset/assets/javascripts/reduxUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/4740/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL3JlZHV4VXRpbHMuanM=)
 | `74.57% <0%> (+0.43%)` | :arrow_up: |
   | ... and [2 
more](https://codecov.io/gh/apache/incubator-superset/pull/4740/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4740?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4740?src=pr&el=footer).
 Last update 
[11c9e67...fc6c1ee](https://codecov.io/gh/apache/incubator-superset/pull/4740?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch closed issue #4757: delete sum and avg field but not deleted.

[GitBox]

mistercrunch closed issue #4757: delete sum and avg field but not deleted.
URL: https://github.com/apache/incubator-superset/issues/4757
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #4757: delete sum and avg field but not deleted.

[GitBox]

mistercrunch commented on issue #4757: delete sum and avg field but not deleted.
URL: 
https://github.com/apache/incubator-superset/issues/4757#issuecomment-378664577
 
 
   That's the intended behavior, for now you have to manually delete the 
metrics as well. If we'd just delete metrics there's high potential for 
breaking existing charts unknowingly...
   
   https://github.com/apache/incubator-superset/pull/4663 changes the way this 
is done, and make it much easier to define metrics.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch closed issue #3829: Cannot create table with same name from a different datasource

[GitBox]

mistercrunch closed issue #3829: Cannot create table with same name from a 
different datasource
URL: https://github.com/apache/incubator-superset/issues/3829
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #4613: Uncaught TypeError: Cannot read property 'map' of null

[GitBox]

mistercrunch commented on issue #4613: Uncaught TypeError: Cannot read property 
'map' of null
URL: 
https://github.com/apache/incubator-superset/issues/4613#issuecomment-378663082
 
 
   If you've seen this > `0.24.0` let me know and I'll reopen


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] feng-tao closed pull request #4745: [bugfix] Fix the arguement order for security function

[GitBox]

feng-tao closed pull request #4745: [bugfix] Fix the arguement order for 
security function
URL: https://github.com/apache/incubator-superset/pull/4745
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/security.py b/superset/security.py
index e342b034d9..90a26fd1f8 100644
--- a/superset/security.py
+++ b/superset/security.py
@@ -211,7 +211,7 @@ def accessible_by_user(self, database, datasource_names, 
schema=None):
 full_names = {d.full_name for d in user_datasources}
 return [d for d in datasource_names if d in full_names]
 
-def merge_perm(self, permission_name, view_menu_name):
+def merge_perm(self, view_menu_name, permission_name):
 # Implementation copied from sm.find_permission_view_menu.
 # TODO: use sm.find_permission_view_menu once issue
 #   https://github.com/airbnb/superset/issues/1944 is resolved.


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jcoelho-pt commented on issue #4501: No columns imported from table from MSSQL-DB

[GitBox]

jcoelho-pt commented on issue #4501: No columns imported from table from 
MSSQL-DB 
URL: 
https://github.com/apache/incubator-superset/issues/4501#issuecomment-378609733
 
 
   Thanks @sebastianwindeck!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] amishyn commented on issue #4613: Uncaught TypeError: Cannot read property 'map' of null

[GitBox]

amishyn commented on issue #4613: Uncaught TypeError: Cannot read property 
'map' of null
URL: 
https://github.com/apache/incubator-superset/issues/4613#issuecomment-378553076
 
 
   On the `Edit Dashboard` page


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pranavoyo commented on issue #4613: Uncaught TypeError: Cannot read property 'map' of null

[GitBox]

pranavoyo commented on issue #4613: Uncaught TypeError: Cannot read property 
'map' of null
URL: 
https://github.com/apache/incubator-superset/issues/4613#issuecomment-378552760
 
 
   sorry to sound dumb, but where do i set this value for 'Position JSON'?
   for now, i upgraded superset and now everything is working fine.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] amishyn commented on issue #4613: Uncaught TypeError: Cannot read property 'map' of null

[GitBox]

amishyn commented on issue #4613: Uncaught TypeError: Cannot read property 
'map' of null
URL: 
https://github.com/apache/incubator-superset/issues/4613#issuecomment-378547578
 
 
   Oh, I'm sorry, suggested fix for the another issue of uploading csv.
   
   For this one, I've added '[]' as a value for 'Position JSON' 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pranavoyo commented on issue #4613: Uncaught TypeError: Cannot read property 'map' of null

[GitBox]

pranavoyo commented on issue #4613: Uncaught TypeError: Cannot read property 
'map' of null
URL: 
https://github.com/apache/incubator-superset/issues/4613#issuecomment-378546276
 
 
   doesn't work for me,
   dashboard.b21ed8e6fe6a55e3a492.entry.js:326 Uncaught TypeError: Cannot read 
property 'map' of null
   at b (dashboard.b21ed8e6fe6a55e3a492.entry.js:326)
   at Object. (dashboard.b21ed8e6fe6a55e3a492.entry.js:305)
   at n (dashboard.b21ed8e6fe6a55e3a492.entry.js:1)
   at Object. (dashboard.b21ed8e6fe6a55e3a492.entry.js:305)
   at n (dashboard.b21ed8e6fe6a55e3a492.entry.js:1)
   at dashboard.b21ed8e6fe6a55e3a492.entry.js:1
   at dashboard.b21ed8e6fe6a55e3a492.entry.js:1


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] amishyn commented on issue #4613: Uncaught TypeError: Cannot read property 'map' of null

[GitBox]

amishyn commented on issue #4613: Uncaught TypeError: Cannot read property 
'map' of null
URL: 
https://github.com/apache/incubator-superset/issues/4613#issuecomment-378541353
 
 
   What worked out for me, is to add custom config file `superset_config.py` 
with
   `UPLOAD_FOLDER='/tmp/'`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pranavoyo commented on issue #4613: Uncaught TypeError: Cannot read property 'map' of null

[GitBox]

pranavoyo commented on issue #4613: Uncaught TypeError: Cannot read property 
'map' of null
URL: 
https://github.com/apache/incubator-superset/issues/4613#issuecomment-378540859
 
 
   same issue, please suggest solution. @wangqi19940304 @xrmx 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asyd commented on issue #3829: Cannot create table with same name from a different datasource

[GitBox]

asyd commented on issue #3829: Cannot create table with same name from a 
different datasource
URL: 
https://github.com/apache/incubator-superset/issues/3829#issuecomment-378534554
 
 
   Oh, just tested 0.24.0 and seem it's working, so maybe someone should close 
this issue?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] songying2013 opened a new issue #4757: delete sum and avg field but not deleted.

[GitBox]

songying2013 opened a new issue #4757: delete sum and avg field but not deleted.
URL: https://github.com/apache/incubator-superset/issues/4757
 
 
   When I am in Sources > Tables > Edit Record > List Columns , I delete some 
field, but after I save the edit, it still there.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services