Re: [HELP!] Please close your stale issues and PRs 🚮

2019-03-28 Thread Charles Givre
Hi Krist, 
I have a PR (https://github.com/apache/incubator-superset/pull/6610 
) which I would love to 
close, but need some assistance.  The PR as it stands works, passes all unit 
tests and doesn’t break anything, however there are two hardcoded lines which 
should be moved, but I am stuck here. 

I’d like to ask that we mark this as a WIP, merge the PR, open an issue to 
clean that up and I’ll keep working on it.
Thanks for the consideration. 



> On Mar 27, 2019, at 21:02, Krist Wongsuphasawat  wrote:
> 
> Hi Superset dev,
> 
> As of now, we have 986 issues 📝and 148 PRs 📝on github.
> Thank you for all your contributions.
> 
> To keep the project maintainable, please help the community by
> 
> - 🚮*closing your issues* that has been resolved, are no longer relevant or
> is duplicated.
> https://github.com/apache/incubator-superset/issues
> 
> - 🚮*closing your PRs *that you no longer intend to merge or the code is
> not relevant any more. If the problem in the PRs still persists, please
> create an issue instead.
> https://github.com/apache/incubator-superset/pulls
> 
> Everyone closing 1-2 PRs/issues can really make a difference.
> 🗑️✨
> Thank you in advance,
> 
> Krist
> 
> -- 
> 
> *Krist Wongsuphasawat*
> http://kristw.yellowpigz.com



Re: [HELP!] Please close your stale issues and PRs 🚮

2019-03-29 Thread Maxime Beauchemin
Thank you Krist for bringing this up. Our repo needs more TLC!

I did a pass on old issues I created a long time ago and one some PRs
(closed dozens of things). The overall workload is monumental and it may
really help to have bots auto-commenting and closing stale issues and PRs
that aren't labelled as "bot-immune". I'm not sure how people feel about
that.

Max

On Thu, Mar 28, 2019 at 8:40 AM Charles Givre  wrote:

> Hi Krist,
> I have a PR (https://github.com/apache/incubator-superset/pull/6610 <
> https://github.com/apache/incubator-superset/pull/6610>) which I would
> love to close, but need some assistance.  The PR as it stands works, passes
> all unit tests and doesn’t break anything, however there are two hardcoded
> lines which should be moved, but I am stuck here.
>
> I’d like to ask that we mark this as a WIP, merge the PR, open an issue to
> clean that up and I’ll keep working on it.
> Thanks for the consideration.
>
>
>
> > On Mar 27, 2019, at 21:02, Krist Wongsuphasawat 
> wrote:
> >
> > Hi Superset dev,
> >
> > As of now, we have 986 issues 📝and 148 PRs 📝on github.
> > Thank you for all your contributions.
> >
> > To keep the project maintainable, please help the community by
> >
> > - 🚮*closing your issues* that has been resolved, are no longer relevant
> or
> > is duplicated.
> > https://github.com/apache/incubator-superset/issues
> >
> > - 🚮*closing your PRs *that you no longer intend to merge or the code is
> > not relevant any more. If the problem in the PRs still persists, please
> > create an issue instead.
> > https://github.com/apache/incubator-superset/pulls
> >
> > Everyone closing 1-2 PRs/issues can really make a difference.
> > 🗑️✨
> > Thank you in advance,
> >
> > Krist
> >
> > --
> >
> > *Krist Wongsuphasawat*
> > http://kristw.yellowpigz.com
>
>