[jira] [Commented] (THRIFT-1167) Java nonblocking server with more than one thread for select and handling IO

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086746#comment-13086746
 ] 

Hudson commented on THRIFT-1167:


Integrated in Thrift #223 (See [https://builds.apache.org/job/Thrift/223/])
THRIFT-1167. java: Java nonblocking server with more than one thread for 
select and handling IO

This patch refactors the nonblocking server hierarchy and adds in a new server 
that has a threaded selector pool as well as a threaded invoker pool.

Patch: Steve Jiang

bryanduxbury : http://svn.apache.org/viewvc/?view=rev&rev=1158977
Files : 
* /thrift/trunk/lib/java/src/org/apache/thrift/server/Invocation.java
* 
/thrift/trunk/lib/java/src/org/apache/thrift/server/TThreadedSelectorServer.java
* 
/thrift/trunk/lib/java/test/org/apache/thrift/server/TestThreadedSelectorServer.java
* /thrift/trunk/lib/java/src/org/apache/thrift/server/THsHaServer.java
* 
/thrift/trunk/lib/java/src/org/apache/thrift/server/AbstractNonblockingServer.java
* /thrift/trunk/lib/java/src/org/apache/thrift/server/TNonblockingServer.java


> Java nonblocking server with more than one thread for select and handling IO
> 
>
> Key: THRIFT-1167
> URL: https://issues.apache.org/jira/browse/THRIFT-1167
> Project: Thrift
>  Issue Type: New Feature
>  Components: Java - Library
>Reporter: Steve Jiang
>Assignee: Steve Jiang
> Fix For: 0.8
>
> Attachments: TSHSHAServer-Patch-MultiThreaded_v3.patch, 
> threadedselectorthrift3.diff
>
>
> I've used the HsHa server model to write a server that uses a thread for 
> accept and a separate, configurable number of Selector threads to handle IO.  
> I'd like to contribute this back to Thrift.
> For apps that are RPC-heavy and require little computation from the executor 
> pool running on multi-core architectures, this server allows gets throughput 
> as IO is not limited by one CPU.
> Please take a look at the attached patch.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Build failed in Jenkins: Thrift #223

[Apache Jenkins Server]

See 

Changes:

[bryanduxbury] THRIFT-1167. java: Java nonblocking server with more than one 
thread for select and handling IO

This patch refactors the nonblocking server hierarchy and adds in a new server 
that has a threaded selector pool as well as a threaded invoker pool.

Patch: Steve Jiang

--
[...truncated 2093 lines...]
make[3]: Leaving directory 
`
make[2]: Leaving directory 
`
Making check in js/test
make[2]: Entering directory 
`
make  check-local
make[3]: Entering directory 
`
/home/hudson/tools/ant/latest/bin/ant -Dtest.junit.output.format=xml test
Buildfile: 


generate:

check-gjslint:
 [echo] check if gjslint is available:
 [exec] Execute failed: java.io.IOException: Cannot run program "gjslint": 
java.io.IOException: error=2, No such file or directory

gjslint:

resolve:
 [copy] Copying 36 files to 


jslint:

lint:

dependencies:

init:
[mkdir] Created dir: 

[mkdir] Created dir: 

[mkdir] Created dir: 

[mkdir] Created dir: 


xvfb:
 [echo] check if Xvfb is available:
 [exec] Execute failed: java.io.IOException: Cannot run program "Xvfb": 
java.io.IOException: error=2, No such file or directory

phantomjs:

compile:
[javac] Compiling 21 source files to 

[javac] Note: Some input files use unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.
[javac] Compiling 1 source file to 

[javac] Note: 

 uses unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.

jstest:
  [jar] Building jar: 


proxy:

jslibs:
  [get] Getting: http://code.jquery.com/jquery-1.5.2.js
  [get] To: 

  [get] Getting: 
http://js-test-driver.googlecode.com/svn/trunk/JsTestDriver/contrib/qunit/src/equiv.js
  [get] To: 

  [get] Getting: 
http://js-test-driver.googlecode.com/svn/trunk/JsTestDriver/contrib/qunit/src/QUnitAdapter.js
  [get] To: 

  [get] Getting: http://code.jquery.com/qunit/git/qunit.js
  [get] To: 

  [get] Getting: http://code.jquery.com/qunit/git/qunit.css
  [get] To: 

 [copy] Copying 1 file to 


unittest:

test:

BUILD SUCCESSFUL
Total time: 9 seconds
make[3]: Leaving directory 
`
make[2]: Leaving directory 
`
Making check in py
make[2]: Entering directory 
`
/usr/bin/python setup.py build
running build
running build_py
running build_ext
make  check-local
make[3]: Entering directory 
`
/usr/bin/python setup.py build
running build
running build_py
running build_ext
make[3]: Leaving directory 
`
make[2]: Leaving directory 
`
Making check in erl
make[2]: Entering directory 
`
./rebar eunit
==> erl (eunit)
Compiled src/thrift_transport.erl
Compiled src/thrift_protocol.erl
Compiled src/thrift_service.erl
Compiled test/smallTest_types.erl
Compiled test/yowza_thrift.erl
Compiled test/test_disklog.erl
Compiled test/aService_thrift.erl
Compiled test/service_thrift.erl
Compiled test/test_membuffer.erl
Compiled test/thriftTest_thrift.erl
Compiled test/stress_server.erl
Compiled test/secondService_thrift.erl
Compiled

Build failed in Jenkins: Thrift-cpp #125

[Apache Jenkins Server]

See 

Changes:

[bryanduxbury] THRIFT-1167. java: Java nonblocking server with more than one 
thread for select and handling IO

This patch refactors the nonblocking server hierarchy and adds in a new server 
that has a threaded selector pool as well as a threaded invoker pool.

Patch: Steve Jiang

--
[...truncated 113 lines...]
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether make sets $(MAKE)... (cached) yes
checking for bison... bison -y
checking for flex... flex
checking lex output file root... lex.yy
checking lex library... -lfl
checking whether yytext is a pointer... yes
checking whether ln -s works... yes
checking for gawk... (cached) mawk
checking for ranlib... (cached) ranlib
checking for boostlib >= 1.33.1... yes
checking for libevent >= 1.0... yes
checking for zlib >= 1.2.3... yes
checking for trial... /usr/bin/trial
checking for 6g... /usr/local/bin/6g
checking for 6l... /usr/local/bin/6l
checking for gomake... /usr/local/bin/gomake
checking for goinstall... /usr/local/bin/goinstall
checking for an ANSI C-conforming const... yes
checking for inline... inline
checking for working volatile... yes
checking for stdbool.h that conforms to C99... no
checking for _Bool... no
checking for ANSI C header files... (cached) yes
checking whether time.h and sys/time.h may both be included... yes
checking for sys/wait.h that is POSIX.1 compatible... yes
checking return type of signal handlers... void
checking arpa/inet.h usability... yes
checking arpa/inet.h presence... yes
checking for arpa/inet.h... yes
checking sys/param.h usability... yes
checking sys/param.h presence... yes
checking for sys/param.h... yes
checking fcntl.h usability... yes
checking fcntl.h presence... yes
checking for fcntl.h... yes
checking for inttypes.h... (cached) yes
checking limits.h usability... yes
checking limits.h presence... yes
checking for limits.h... yes
checking netdb.h usability... yes
checking netdb.h presence... yes
checking for netdb.h... yes
checking netinet/in.h usability... yes
checking netinet/in.h presence... yes
checking for netinet/in.h... yes
checking pthread.h usability... yes
checking pthread.h presence... yes
checking for pthread.h... yes
checking stddef.h usability... yes
checking stddef.h presence... yes
checking for stddef.h... yes
checking for stdlib.h... (cached) yes
checking sys/socket.h usability... yes
checking sys/socket.h presence... yes
checking for sys/socket.h... yes
checking sys/time.h usability... yes
checking sys/time.h presence... yes
checking for sys/time.h... yes
checking for unistd.h... (cached) yes
checking libintl.h usability... yes
checking libintl.h presence... yes
checking for libintl.h... yes
checking malloc.h usability... yes
checking malloc.h presence... yes
checking for malloc.h... yes
checking openssl/ssl.h usability... yes
checking openssl/ssl.h presence... yes
checking for openssl/ssl.h... yes
checking openssl/rand.h usability... yes
checking openssl/rand.h presence... yes
checking for openssl/rand.h... yes
checking openssl/x509v3.h usability... yes
checking openssl/x509v3.h presence... yes
checking for openssl/x509v3.h... yes
checking for pthread_create in -lpthread... yes
checking for clock_gettime in -lrt... yes
checking for setsockopt in -lsocket... no
checking for SSL_ctrl in -lssl... yes
checking for int16_t... yes
checking for int32_t... yes
checking for int64_t... yes
checking for int8_t... yes
checking for mode_t... yes
checking for off_t... yes
checking for size_t... yes
checking for ssize_t... yes
checking for uint16_t... yes
checking for uint32_t... yes
checking for uint64_t... yes
checking for uint8_t... yes
checking for ptrdiff_t... yes
checking whether struct tm is in sys/time.h or time.h... time.h
checking whether AI_ADDRCONFIG is declared... yes
checking for working alloca.h... yes
checking for alloca... yes
checking for pid_t... yes
checking vfork.h usability... no
checking vfork.h presence... no
checking for vfork.h... no
checking for fork... yes
checking for vfork... yes
checking for working fork... yes
checking for working vfork... (cached) yes
checking for stdlib.h... (cached) yes
checking for GNU libc compatible malloc... yes
checking for working memcmp... yes
checking for stdlib.h... (cached) yes
checking for GNU libc compatible realloc... yes
checking sys/select.h usability... yes
checking sys/select.h presence... yes
checking for sys/select.h... yes
checking for sys/socket.h... (cached) yes
checking types of arguments for select... int,fd_set *,struct timeval *
checking whether lstat correctly handles trailing slash... yes
checking whether stat accepts an empty string... no
checking whether strerror_r is declared... yes
checking for strerror_r... yes
checking whether strerror_r returns char *... yes
checking for strftime... yes
checking for vprintf... yes
checking for 

[jira] [Updated] (THRIFT-1276) Add thrift compiler option to suppress warnings about

[Dave Watson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Watson updated THRIFT-1276:


Attachment: 
0008-Add-thrift-compiler-option-to-suppress-warnings-abou.patch.diff

>  Add thrift compiler option to suppress warnings about

> ---
>
> Key: THRIFT-1276
> URL: https://issues.apache.org/jira/browse/THRIFT-1276
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Priority: Minor
> Attachments: 
> 0008-Add-thrift-compiler-option-to-suppress-warnings-abou.patch.diff
>
>
> From 888de29f39ea6235c39416585b234a32712ae16b Mon Sep 17 00:00:00 2001
> From: Doug Ihde 
> Date: Thu, 4 Mar 2010 20:21:18 +
> Subject: [PATCH 08/33] Add thrift compiler option to suppress warnings about
>  64-bit constants
> Summary: The thrift compiler generates warnings whenever you define a 64-bit
>  constant in a .thrift file, because some languages don't support
>  64-bit values. But most useful languages do, so it's annoying to
>  get these warnings all the time for project in which we know we're
>  only using 64-bit-safe languages.
> Test Plan: I added "--allow-64bit-consts" to the TARGETS file for
>business/account/if and watched all the warnings from
>account.thrift go away.
> ---
>  compiler/cpp/src/globals.h  |9 +
>  compiler/cpp/src/main.cc|8 
>  compiler/cpp/src/thrifty.yy |2 +-
>  3 files changed, 18 insertions(+), 1 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1275) thrift: always prefix namespaces with " ::"

[Dave Watson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Watson updated THRIFT-1275:


Attachment: 0007-thrift-always-prefix-namespaces-with.patch.diff

>  thrift: always prefix namespaces with " ::"

> -
>
> Key: THRIFT-1275
> URL: https://issues.apache.org/jira/browse/THRIFT-1275
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Priority: Minor
> Attachments: 0007-thrift-always-prefix-namespaces-with.patch.diff
>
>
> From d56203d414d23c7858a269e4aa547ee3164832fd Mon Sep 17 00:00:00 2001
> From: Adam Simpkins 
> Date: Thu, 4 Mar 2010 00:53:37 +
> Subject: [PATCH 07/33] thrift: always prefix namespaces with " ::"
> Summary:
> Thrift always refers to namespaces using their full name.  Therefore, it
> should prefix them with "::" to avoid accidentally matching a name
> defined in one of the current namespaces, rather than at the top-level.
> For example, if ServiceB is in namespace bar, and inherits from ServiceA
> in namespace foo, all code emitted for ServiceB now refers to ServiceA
> as ::foo::ServiceA instead of just foo::ServiceA.  This allows the code
> to compile even if a namespace ::bar::foo also exists.
> An extra leading whitespace is also emitted, which is needed in cases
> when the name is used as the first template parameter, so that the
> emitted code contains "< ::" instead of "<::".
> Test Plan:
> jsong reported a build problem because of this name lookup error, and
> this change fixed his build.
> I also tested building [internal fb thing] and [internal fb thing], and they 
> both built
> successfully.
> Tags: thrift
> ---
>  compiler/cpp/src/generate/t_cpp_generator.cc |   11 +--
>  1 files changed, 9 insertions(+), 2 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (THRIFT-1276) Add thrift compiler option to suppress warnings about

[Dave Watson (JIRA)]

 Add thrift compiler option to suppress warnings about

---

 Key: THRIFT-1276
 URL: https://issues.apache.org/jira/browse/THRIFT-1276
 Project: Thrift
  Issue Type: Improvement
  Components: C++ - Library
Reporter: Dave Watson
Priority: Minor
 Attachments: 
0008-Add-thrift-compiler-option-to-suppress-warnings-abou.patch.diff

>From 888de29f39ea6235c39416585b234a32712ae16b Mon Sep 17 00:00:00 2001
From: Doug Ihde 
Date: Thu, 4 Mar 2010 20:21:18 +
Subject: [PATCH 08/33] Add thrift compiler option to suppress warnings about
 64-bit constants

Summary: The thrift compiler generates warnings whenever you define a 64-bit
 constant in a .thrift file, because some languages don't support
 64-bit values. But most useful languages do, so it's annoying to
 get these warnings all the time for project in which we know we're
 only using 64-bit-safe languages.


Test Plan: I added "--allow-64bit-consts" to the TARGETS file for
   business/account/if and watched all the warnings from
   account.thrift go away.



---
 compiler/cpp/src/globals.h  |9 +
 compiler/cpp/src/main.cc|8 
 compiler/cpp/src/thrifty.yy |2 +-
 3 files changed, 18 insertions(+), 1 deletions(-)



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (THRIFT-1275) thrift: always prefix namespaces with " ::"

[Dave Watson (JIRA)]

 thrift: always prefix namespaces with " ::"

-

 Key: THRIFT-1275
 URL: https://issues.apache.org/jira/browse/THRIFT-1275
 Project: Thrift
  Issue Type: Improvement
  Components: C++ - Library
Reporter: Dave Watson
Priority: Minor


>From d56203d414d23c7858a269e4aa547ee3164832fd Mon Sep 17 00:00:00 2001
From: Adam Simpkins 
Date: Thu, 4 Mar 2010 00:53:37 +
Subject: [PATCH 07/33] thrift: always prefix namespaces with " ::"

Summary:
Thrift always refers to namespaces using their full name.  Therefore, it
should prefix them with "::" to avoid accidentally matching a name
defined in one of the current namespaces, rather than at the top-level.

For example, if ServiceB is in namespace bar, and inherits from ServiceA
in namespace foo, all code emitted for ServiceB now refers to ServiceA
as ::foo::ServiceA instead of just foo::ServiceA.  This allows the code
to compile even if a namespace ::bar::foo also exists.

An extra leading whitespace is also emitted, which is needed in cases
when the name is used as the first template parameter, so that the
emitted code contains "< ::" instead of "<::".




Test Plan:
jsong reported a build problem because of this name lookup error, and
this change fixed his build.

I also tested building [internal fb thing] and [internal fb thing], and they 
both built
successfully.

Tags: thrift


---
 compiler/cpp/src/generate/t_cpp_generator.cc |   11 +--
 1 files changed, 9 insertions(+), 2 deletions(-)



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (THRIFT-1274) thrift: fail compilation if an unexpected token is

[Dave Watson (JIRA)]

 thrift: fail compilation if an unexpected token is



 Key: THRIFT-1274
 URL: https://issues.apache.org/jira/browse/THRIFT-1274
 Project: Thrift
  Issue Type: Improvement
  Components: C++ - Library
Reporter: Dave Watson
Priority: Minor
 Attachments: 
0006-thrift-fail-compilation-if-an-unexpected-token-is-en.patch.diff

>From e52b015b1c3d3b25ca1c905ea28cab80783a14bc Mon Sep 17 00:00:00 2001
From: Adam Simpkins 
Date: Fri, 26 Feb 2010 04:48:55 +
Subject: [PATCH 06/33] thrift: fail compilation if an unexpected token is
 encountered

Summary:
Currently, if the thrift lexer encounters a token it does not expect, it
prints the token it to stdout and continues.  (This is the default
behavior of flex when a token is unmatched.)  This updates thriftl.ll to
fail with an error message when it sees an unexpected character.


Test Plan:
[internal fb thing].thrift contains a stray single-quote.
Previously it was getting printed to stdout whenever you compile this
file, or anything that includes it.  (Furthermore, it is printed out
multiple times, since we scan the file twice each time it is included.
Compiling [internal fb thing].thrift scans this file 8 times!)

Now compiling this file fails with an error, as desired.  I'll submit a
separate diff to fix [internal fb thing].thrift.



---
 compiler/cpp/src/thriftl.ll |9 +
 1 files changed, 9 insertions(+), 0 deletions(-)



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1274) thrift: fail compilation if an unexpected token is

[Dave Watson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Watson updated THRIFT-1274:


Attachment: 
0006-thrift-fail-compilation-if-an-unexpected-token-is-en.patch.diff

>  thrift: fail compilation if an unexpected token is

> 
>
> Key: THRIFT-1274
> URL: https://issues.apache.org/jira/browse/THRIFT-1274
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Priority: Minor
> Attachments: 
> 0006-thrift-fail-compilation-if-an-unexpected-token-is-en.patch.diff
>
>
> From e52b015b1c3d3b25ca1c905ea28cab80783a14bc Mon Sep 17 00:00:00 2001
> From: Adam Simpkins 
> Date: Fri, 26 Feb 2010 04:48:55 +
> Subject: [PATCH 06/33] thrift: fail compilation if an unexpected token is
>  encountered
> Summary:
> Currently, if the thrift lexer encounters a token it does not expect, it
> prints the token it to stdout and continues.  (This is the default
> behavior of flex when a token is unmatched.)  This updates thriftl.ll to
> fail with an error message when it sees an unexpected character.
> Test Plan:
> [internal fb thing].thrift contains a stray single-quote.
> Previously it was getting printed to stdout whenever you compile this
> file, or anything that includes it.  (Furthermore, it is printed out
> multiple times, since we scan the file twice each time it is included.
> Compiling [internal fb thing].thrift scans this file 8 times!)
> Now compiling this file fails with an error, as desired.  I'll submit a
> separate diff to fix [internal fb thing].thrift.
> ---
>  compiler/cpp/src/thriftl.ll |9 +
>  1 files changed, 9 insertions(+), 0 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1273) Replace assignment of a negative literal to an

[Dave Watson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Watson updated THRIFT-1273:


Attachment: 
0005-Replace-assignment-of-a-negative-literal-to-an-unsig.patch.diff

>  Replace assignment of a negative literal to an

> 
>
> Key: THRIFT-1273
> URL: https://issues.apache.org/jira/browse/THRIFT-1273
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Priority: Minor
> Attachments: 
> 0005-Replace-assignment-of-a-negative-literal-to-an-unsig.patch.diff
>
>
> From 7f84cde1fd531bdae8c0e423e97e34c69a56197b Mon Sep 17 00:00:00 2001
> From: [internal fb thing] Stein 
> Date: Thu, 25 Feb 2010 23:07:15 +
> Subject: [PATCH 05/33] Replace assignment of a negative literal to an
>  unsigned int with assignment of an unsigned int
> Summary: I have been using this file in [internal fb thing], and it causes 
> compiler
>  warnings. The compiler gets upset because negative literals are
>  being assigned to unsigned types. This diff replaces the negative
>  literals with unsigned bitwise equivalents.
> Test Plan: I wrote a program that checks the bitwise equivalence of the
>array before and after. I also used the base64 encode and decode
>functions before and after, with equivalent results.
> ---
>  lib/cpp/src/protocol/TBase64Utils.cpp |   32 
>  1 files changed, 16 insertions(+), 16 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (THRIFT-1273) Replace assignment of a negative literal to an

[Dave Watson (JIRA)]

 Replace assignment of a negative literal to an



 Key: THRIFT-1273
 URL: https://issues.apache.org/jira/browse/THRIFT-1273
 Project: Thrift
  Issue Type: Improvement
  Components: C++ - Library
Reporter: Dave Watson
Priority: Minor
 Attachments: 
0005-Replace-assignment-of-a-negative-literal-to-an-unsig.patch.diff

>From 7f84cde1fd531bdae8c0e423e97e34c69a56197b Mon Sep 17 00:00:00 2001
From: [internal fb thing] Stein 
Date: Thu, 25 Feb 2010 23:07:15 +
Subject: [PATCH 05/33] Replace assignment of a negative literal to an
 unsigned int with assignment of an unsigned int

Summary: I have been using this file in [internal fb thing], and it causes 
compiler
 warnings. The compiler gets upset because negative literals are
 being assigned to unsigned types. This diff replaces the negative
 literals with unsigned bitwise equivalents.



Test Plan: I wrote a program that checks the bitwise equivalence of the
   array before and after. I also used the base64 encode and decode
   functions before and after, with equivalent results.



---
 lib/cpp/src/protocol/TBase64Utils.cpp |   32 
 1 files changed, 16 insertions(+), 16 deletions(-)



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1272) add subclass of ReadWriteMutex that avoids writer

[Dave Watson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Watson updated THRIFT-1272:


Attachment: 
0004-add-subclass-of-ReadWriteMutex-that-avoids-writer-st.patch.diff

>  add subclass of ReadWriteMutex that avoids writer

> ---
>
> Key: THRIFT-1272
> URL: https://issues.apache.org/jira/browse/THRIFT-1272
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Priority: Minor
> Attachments: 
> 0004-add-subclass-of-ReadWriteMutex-that-avoids-writer-st.patch.diff
>
>
> From e30d5bc332d7671ecaf3dd95fea1d8693506923d Mon Sep 17 00:00:00 2001
> From: Doug Ihde 
> Date: Mon, 22 Feb 2010 23:36:52 +
> Subject: [PATCH 04/33] add subclass of ReadWriteMutex that avoids writer
>  starvation
> Summary: The ReadWriteMutex class does not guarantee that writers will not
>  suffer from starvation. This new subclass provides such a
>  guarantee.
>  Also fixing a bug in ReadWriteMutex attemptRead() and
>  attemptWrite() where the return value is the opposite of what is
>  documented.
> Test Plan: I wrote a simple program that launches 3 reader threads and 2
>writer thread to demonstrate the starvation. With a regular
>ReadWriteMutex, the writer threads never acquire the lock. With
>the new subclass, they acquire the lock as expected.
> ---
>  lib/cpp/src/concurrency/Mutex.cpp  |   34 +++-
>  lib/cpp/src/concurrency/Mutex.h|   19 
>  lib/cpp/test/Makefile.am   |5 +-
>  lib/cpp/test/RWMutexStarveTest.cpp |  168 
> 
>  4 files changed, 222 insertions(+), 4 deletions(-)
>  create mode 100644 lib/cpp/test/RWMutexStarveTest.cpp

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (THRIFT-1272) add subclass of ReadWriteMutex that avoids writer

[Dave Watson (JIRA)]

 add subclass of ReadWriteMutex that avoids writer

---

 Key: THRIFT-1272
 URL: https://issues.apache.org/jira/browse/THRIFT-1272
 Project: Thrift
  Issue Type: Improvement
  Components: C++ - Library
Reporter: Dave Watson
Priority: Minor


>From e30d5bc332d7671ecaf3dd95fea1d8693506923d Mon Sep 17 00:00:00 2001
From: Doug Ihde 
Date: Mon, 22 Feb 2010 23:36:52 +
Subject: [PATCH 04/33] add subclass of ReadWriteMutex that avoids writer
 starvation

Summary: The ReadWriteMutex class does not guarantee that writers will not
 suffer from starvation. This new subclass provides such a
 guarantee.
 Also fixing a bug in ReadWriteMutex attemptRead() and
 attemptWrite() where the return value is the opposite of what is
 documented.



Test Plan: I wrote a simple program that launches 3 reader threads and 2
   writer thread to demonstrate the starvation. With a regular
   ReadWriteMutex, the writer threads never acquire the lock. With
   the new subclass, they acquire the lock as expected.



---
 lib/cpp/src/concurrency/Mutex.cpp  |   34 +++-
 lib/cpp/src/concurrency/Mutex.h|   19 
 lib/cpp/test/Makefile.am   |5 +-
 lib/cpp/test/RWMutexStarveTest.cpp |  168 
 4 files changed, 222 insertions(+), 4 deletions(-)
 create mode 100644 lib/cpp/test/RWMutexStarveTest.cpp



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1271) thrift: fix missing namespace in generated local

[Dave Watson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Watson updated THRIFT-1271:


Attachment: 
0003-thrift-fix-missing-namespace-in-generated-local-refl.patch.diff

>  thrift: fix missing namespace in generated local

> --
>
> Key: THRIFT-1271
> URL: https://issues.apache.org/jira/browse/THRIFT-1271
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Priority: Minor
> Attachments: 
> 0003-thrift-fix-missing-namespace-in-generated-local-refl.patch.diff
>
>
> From a0ef2f341fcb613728c6be888082dfe98cde0ad8 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins 
> Date: Thu, 14 Jan 2010 23:02:40 +
> Subject: [PATCH 03/33] thrift: fix missing namespace in generated local
>  reflection
> Summary:
> The TypeSpec definitions for lists, sets, and maps did not prefix the 
> contained
> type names with the correct namespace.  This resulted in a compile failure 
> when
> defining a list of types from another namespace.
> Test Plan:
> Tested building [internal fb thing]'s [internal fb thing] changes.  The 
> generated C++ code compiles now.
> ---
>  compiler/cpp/src/generate/t_cpp_generator.cc |8 
>  1 files changed, 4 insertions(+), 4 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (THRIFT-1167) Java nonblocking server with more than one thread for select and handling IO

[Bryan Duxbury (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Duxbury resolved THRIFT-1167.
---

   Resolution: Fixed
Fix Version/s: 0.8
 Assignee: Steve Jiang  (was: Bryan Duxbury)

I finally fully reviewed this, and it's great stuff. I cleaned up a few minor 
things (spacing mostly, along with converting the FrameBuffer states into an 
Enum), and committed this to TRUNK. Really looking forward to seeing the 
performance improvements! Thanks Steve!

> Java nonblocking server with more than one thread for select and handling IO
> 
>
> Key: THRIFT-1167
> URL: https://issues.apache.org/jira/browse/THRIFT-1167
> Project: Thrift
>  Issue Type: New Feature
>  Components: Java - Library
>Reporter: Steve Jiang
>Assignee: Steve Jiang
> Fix For: 0.8
>
> Attachments: TSHSHAServer-Patch-MultiThreaded_v3.patch, 
> threadedselectorthrift3.diff
>
>
> I've used the HsHa server model to write a server that uses a thread for 
> accept and a separate, configurable number of Selector threads to handle IO.  
> I'd like to contribute this back to Thrift.
> For apps that are RPC-heavy and require little computation from the executor 
> pool running on multi-core architectures, this server allows gets throughput 
> as IO is not limited by one CPU.
> Please take a look at the attached patch.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1270) thrift: add --allow-neg-keys argument to allow

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086686#comment-13086686
 ] 

Hudson commented on THRIFT-1270:


Integrated in Thrift #222 (See [https://builds.apache.org/job/Thrift/222/])
THRIFT-1270. compiler: add --allow-neg-keys argument to allow 

This switch allows the user to specify explicit negative field IDs in Thrift 
IDL in order to avoid breaking wire protocol.

Patch: Dave Watson

bryanduxbury : http://svn.apache.org/viewvc/?view=rev&rev=1158967
Files : 
* /thrift/trunk/compiler/cpp/src/main.cc
* /thrift/trunk/compiler/cpp/src/thrifty.yy
* /thrift/trunk/compiler/cpp/src/globals.h
* /thrift/trunk/compiler/cpp/src/parse/t_field.h


>  thrift: add --allow-neg-keys argument to allow

> 
>
> Key: THRIFT-1270
> URL: https://issues.apache.org/jira/browse/THRIFT-1270
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Assignee: Dave Watson
>Priority: Minor
> Fix For: 0.8
>
> Attachments: 
> 0002-thrift-add-allow-neg-keys-argument-to-allow-negative.patch.diff
>
>
> From 0df0b8cec89a9d7652fbbabd06e5b4d153537431 Mon Sep 17 00:00:00 2001
> From: Dave Watson 
> Date: Tue, 2 Aug 2011 08:40:44 -0700
> Subject: [PATCH 02/33] thrift: add --allow-neg-keys argument to allow
>  negative field keys
> Summary:
> Several of our .thrift files already deployed in production do not have
> explicitly specified key values for all fields.  Thrift automatically
> chooses negative values for these keys (and also emits a warning while
> doing so).  Previously, this couldn't be fixed without breaking protocol
> compatibility, since thrift refuses to accept explicitly specified
> negative key values.
> This new flag causes thrift to accept negative key values, so that these
> older .thrift files can be updated with explicitly specified values.  It
> emits a warning if a negative value is specified that is different from
> what thrift would have otherwise chosen.
> Test Plan:
> Tested modifying common/fbunit/logger/if/UnitTestLogger.thrift
> and biggrep/BigGrep.thrift to pass in negative field values.
> I'll check in the changes to these .thrift files separately, since it
> also requires changes to fbconfig to support passing in the
> --allow-neg-keys argument.  For fbunit, I'll probably change it to just
> use positive key values, since we don't really care about backwards
> compatibility in that case.
> ---
>  compiler/cpp/src/globals.h   |   15 +
>  compiler/cpp/src/main.cc |   10 
>  compiler/cpp/src/parse/t_field.h |9 
>  compiler/cpp/src/thrifty.yy  |   43 +++--
>  4 files changed, 70 insertions(+), 7 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Build failed in Jenkins: Thrift #222

[Apache Jenkins Server]

See 

Changes:

[bryanduxbury] THRIFT-1270. compiler: add --allow-neg-keys argument to allow 

This switch allows the user to specify explicit negative field IDs in Thrift 
IDL in order to avoid breaking wire protocol.

Patch: Dave Watson

--
[...truncated 2087 lines...]
make[3]: Leaving directory 
`
make[2]: Leaving directory 
`
Making check in js/test
make[2]: Entering directory 
`
make  check-local
make[3]: Entering directory 
`
/home/hudson/tools/ant/latest/bin/ant -Dtest.junit.output.format=xml test
Buildfile: 


generate:

check-gjslint:
 [echo] check if gjslint is available:
 [exec] Execute failed: java.io.IOException: Cannot run program "gjslint": 
java.io.IOException: error=2, No such file or directory

gjslint:

resolve:
 [copy] Copying 36 files to 


jslint:

lint:

dependencies:

init:
[mkdir] Created dir: 

[mkdir] Created dir: 

[mkdir] Created dir: 

[mkdir] Created dir: 


xvfb:
 [echo] check if Xvfb is available:
 [exec] Execute failed: java.io.IOException: Cannot run program "Xvfb": 
java.io.IOException: error=2, No such file or directory

phantomjs:

compile:
[javac] Compiling 21 source files to 

[javac] Note: Some input files use unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.
[javac] Compiling 1 source file to 

[javac] Note: 

 uses unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.

jstest:
  [jar] Building jar: 


proxy:

jslibs:
  [get] Getting: http://code.jquery.com/jquery-1.5.2.js
  [get] To: 

  [get] Getting: 
http://js-test-driver.googlecode.com/svn/trunk/JsTestDriver/contrib/qunit/src/equiv.js
  [get] To: 

  [get] Getting: 
http://js-test-driver.googlecode.com/svn/trunk/JsTestDriver/contrib/qunit/src/QUnitAdapter.js
  [get] To: 

  [get] Getting: http://code.jquery.com/qunit/git/qunit.js
  [get] To: 

  [get] Getting: http://code.jquery.com/qunit/git/qunit.css
  [get] To: 

 [copy] Copying 1 file to 


unittest:

test:

BUILD SUCCESSFUL
Total time: 9 seconds
make[3]: Leaving directory 
`
make[2]: Leaving directory 
`
Making check in py
make[2]: Entering directory 
`
/usr/bin/python setup.py build
running build
running build_py
running build_ext
make  check-local
make[3]: Entering directory 
`
/usr/bin/python setup.py build
running build
running build_py
running build_ext
make[3]: Leaving directory 
`
make[2]: Leaving directory 
`
Making check in erl
make[2]: Entering directory 
`
./rebar eunit
==> erl (eunit)
Compiled src/thrift_protocol.erl
Compiled src/thrift_service.erl
Compiled src/thrift_transport.erl
Compiled test/emptyService_thrift.erl
Compiled test/serviceForExceptionWithAMap_thrift.erl
Compiled test/test_disklog.erl
Compiled test/test_thrift_1151.erl
Compiled test/stress_server.erl
Compiled test/service_thrift.erl
Compiled test/test_membuffer.erl
Compiled test/test_server.erl
Compiled test/optionalRequiredTest_types.erl
Compiled test/stressTest_types.erl
Compil

[jira] [Created] (THRIFT-1271) thrift: fix missing namespace in generated local

[Dave Watson (JIRA)]

 thrift: fix missing namespace in generated local

--

 Key: THRIFT-1271
 URL: https://issues.apache.org/jira/browse/THRIFT-1271
 Project: Thrift
  Issue Type: Improvement
  Components: C++ - Library
Reporter: Dave Watson
Priority: Minor


>From a0ef2f341fcb613728c6be888082dfe98cde0ad8 Mon Sep 17 00:00:00 2001
From: Adam Simpkins 
Date: Thu, 14 Jan 2010 23:02:40 +
Subject: [PATCH 03/33] thrift: fix missing namespace in generated local
 reflection

Summary:
The TypeSpec definitions for lists, sets, and maps did not prefix the contained
type names with the correct namespace.  This resulted in a compile failure when
defining a list of types from another namespace.


Test Plan:
Tested building [internal fb thing]'s [internal fb thing] changes.  The 
generated C++ code compiles now.



---
 compiler/cpp/src/generate/t_cpp_generator.cc |8 
 1 files changed, 4 insertions(+), 4 deletions(-)



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Build failed in Jenkins: Thrift-cpp #124

[Apache Jenkins Server]

See 

Changes:

[bryanduxbury] THRIFT-1270. compiler: add --allow-neg-keys argument to allow 

This switch allows the user to specify explicit negative field IDs in Thrift 
IDL in order to avoid breaking wire protocol.

Patch: Dave Watson

--
[...truncated 1331 lines...]
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether make sets $(MAKE)... (cached) yes
checking for bison... bison -y
checking for flex... flex
checking lex output file root... lex.yy
checking lex library... -lfl
checking whether yytext is a pointer... yes
checking whether ln -s works... yes
checking for gawk... (cached) mawk
checking for ranlib... (cached) ranlib
checking for boostlib >= 1.33.1... yes
checking for libevent >= 1.0... yes
checking for zlib >= 1.2.3... yes
checking for trial... /usr/bin/trial
checking for 6g... /usr/local/bin/6g
checking for 6l... /usr/local/bin/6l
checking for gomake... /usr/local/bin/gomake
checking for goinstall... /usr/local/bin/goinstall
checking for an ANSI C-conforming const... yes
checking for inline... inline
checking for working volatile... yes
checking for stdbool.h that conforms to C99... no
checking for _Bool... no
checking for ANSI C header files... (cached) yes
checking whether time.h and sys/time.h may both be included... yes
checking for sys/wait.h that is POSIX.1 compatible... yes
checking return type of signal handlers... void
checking arpa/inet.h usability... yes
checking arpa/inet.h presence... yes
checking for arpa/inet.h... yes
checking sys/param.h usability... yes
checking sys/param.h presence... yes
checking for sys/param.h... yes
checking fcntl.h usability... yes
checking fcntl.h presence... yes
checking for fcntl.h... yes
checking for inttypes.h... (cached) yes
checking limits.h usability... yes
checking limits.h presence... yes
checking for limits.h... yes
checking netdb.h usability... yes
checking netdb.h presence... yes
checking for netdb.h... yes
checking netinet/in.h usability... yes
checking netinet/in.h presence... yes
checking for netinet/in.h... yes
checking pthread.h usability... yes
checking pthread.h presence... yes
checking for pthread.h... yes
checking stddef.h usability... yes
checking stddef.h presence... yes
checking for stddef.h... yes
checking for stdlib.h... (cached) yes
checking sys/socket.h usability... yes
checking sys/socket.h presence... yes
checking for sys/socket.h... yes
checking sys/time.h usability... yes
checking sys/time.h presence... yes
checking for sys/time.h... yes
checking for unistd.h... (cached) yes
checking libintl.h usability... yes
checking libintl.h presence... yes
checking for libintl.h... yes
checking malloc.h usability... yes
checking malloc.h presence... yes
checking for malloc.h... yes
checking openssl/ssl.h usability... yes
checking openssl/ssl.h presence... yes
checking for openssl/ssl.h... yes
checking openssl/rand.h usability... yes
checking openssl/rand.h presence... yes
checking for openssl/rand.h... yes
checking openssl/x509v3.h usability... yes
checking openssl/x509v3.h presence... yes
checking for openssl/x509v3.h... yes
checking for pthread_create in -lpthread... yes
checking for clock_gettime in -lrt... yes
checking for setsockopt in -lsocket... no
checking for SSL_ctrl in -lssl... yes
checking for int16_t... yes
checking for int32_t... yes
checking for int64_t... yes
checking for int8_t... yes
checking for mode_t... yes
checking for off_t... yes
checking for size_t... yes
checking for ssize_t... yes
checking for uint16_t... yes
checking for uint32_t... yes
checking for uint64_t... yes
checking for uint8_t... yes
checking for ptrdiff_t... yes
checking whether struct tm is in sys/time.h or time.h... time.h
checking whether AI_ADDRCONFIG is declared... yes
checking for working alloca.h... yes
checking for alloca... yes
checking for pid_t... yes
checking vfork.h usability... no
checking vfork.h presence... no
checking for vfork.h... no
checking for fork... yes
checking for vfork... yes
checking for working fork... yes
checking for working vfork... (cached) yes
checking for stdlib.h... (cached) yes
checking for GNU libc compatible malloc... yes
checking for working memcmp... yes
checking for stdlib.h... (cached) yes
checking for GNU libc compatible realloc... yes
checking sys/select.h usability... yes
checking sys/select.h presence... yes
checking for sys/select.h... yes
checking for sys/socket.h... (cached) yes
checking types of arguments for select... int,fd_set *,struct timeval *
checking whether lstat correctly handles trailing slash... yes
checking whether stat accepts an empty string... no
checking whether strerror_r is declared... yes
checking for strerror_r... yes
checking whether strerror_r returns char *... yes
checking for strftime... yes
checking for vprintf... yes
checking for _doprnt... no
checking for strtoul... yes
checking for bzer

[jira] [Closed] (THRIFT-380) Use setuptools for python build

[Jake Farrell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jake Farrell closed THRIFT-380.
---

   Resolution: Fixed
Fix Version/s: 0.8

Added to .7 branch and trunk, client now available via pypi.python.org

> Use setuptools for python build
> ---
>
> Key: THRIFT-380
> URL: https://issues.apache.org/jira/browse/THRIFT-380
> Project: Thrift
>  Issue Type: Bug
>  Components: Python - Library
>Reporter: Ben Maurer
>Assignee: Jake Farrell
> Fix For: 0.8
>
>
> We should use setuptools for the python build as this allows thrift to be 
> distributed as an egg file:
> {quote}
> Index: setup.py
> ===
> --- setup.py  (revision 755803)
> +++ setup.py  (working copy)
> @@ -5,9 +5,8 @@
>  #
>  # See accompanying file LICENSE or visit the Thrift site at:
>  # http://developers.facebook.com/thrift/
> +from setuptools import setup, Extension
> -from distutils.core import setup, Extension
>  fastbinarymod = Extension('thrift.protocol.fastbinary',
>sources = ['src/protocol/fastbinary.c'],
>)
> {quote}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (THRIFT-1270) thrift: add --allow-neg-keys argument to allow

[Bryan Duxbury (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Duxbury closed THRIFT-1270.
-

   Resolution: Fixed
Fix Version/s: 0.8
 Assignee: Dave Watson

I just committed this to TRUNK. Thanks Dave!

>  thrift: add --allow-neg-keys argument to allow

> 
>
> Key: THRIFT-1270
> URL: https://issues.apache.org/jira/browse/THRIFT-1270
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Assignee: Dave Watson
>Priority: Minor
> Fix For: 0.8
>
> Attachments: 
> 0002-thrift-add-allow-neg-keys-argument-to-allow-negative.patch.diff
>
>
> From 0df0b8cec89a9d7652fbbabd06e5b4d153537431 Mon Sep 17 00:00:00 2001
> From: Dave Watson 
> Date: Tue, 2 Aug 2011 08:40:44 -0700
> Subject: [PATCH 02/33] thrift: add --allow-neg-keys argument to allow
>  negative field keys
> Summary:
> Several of our .thrift files already deployed in production do not have
> explicitly specified key values for all fields.  Thrift automatically
> chooses negative values for these keys (and also emits a warning while
> doing so).  Previously, this couldn't be fixed without breaking protocol
> compatibility, since thrift refuses to accept explicitly specified
> negative key values.
> This new flag causes thrift to accept negative key values, so that these
> older .thrift files can be updated with explicitly specified values.  It
> emits a warning if a negative value is specified that is different from
> what thrift would have otherwise chosen.
> Test Plan:
> Tested modifying common/fbunit/logger/if/UnitTestLogger.thrift
> and biggrep/BigGrep.thrift to pass in negative field values.
> I'll check in the changes to these .thrift files separately, since it
> also requires changes to fbconfig to support passing in the
> --allow-neg-keys argument.  For fbunit, I'll probably change it to just
> use positive key values, since we don't really care about backwards
> compatibility in that case.
> ---
>  compiler/cpp/src/globals.h   |   15 +
>  compiler/cpp/src/main.cc |   10 
>  compiler/cpp/src/parse/t_field.h |9 
>  compiler/cpp/src/thrifty.yy  |   43 +++--
>  4 files changed, 70 insertions(+), 7 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1270) thrift: add --allow-neg-keys argument to allow

[Dave Watson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Watson updated THRIFT-1270:


Attachment: 
0002-thrift-add-allow-neg-keys-argument-to-allow-negative.patch.diff

>  thrift: add --allow-neg-keys argument to allow

> 
>
> Key: THRIFT-1270
> URL: https://issues.apache.org/jira/browse/THRIFT-1270
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Priority: Minor
> Attachments: 
> 0002-thrift-add-allow-neg-keys-argument-to-allow-negative.patch.diff
>
>
> From 0df0b8cec89a9d7652fbbabd06e5b4d153537431 Mon Sep 17 00:00:00 2001
> From: Dave Watson 
> Date: Tue, 2 Aug 2011 08:40:44 -0700
> Subject: [PATCH 02/33] thrift: add --allow-neg-keys argument to allow
>  negative field keys
> Summary:
> Several of our .thrift files already deployed in production do not have
> explicitly specified key values for all fields.  Thrift automatically
> chooses negative values for these keys (and also emits a warning while
> doing so).  Previously, this couldn't be fixed without breaking protocol
> compatibility, since thrift refuses to accept explicitly specified
> negative key values.
> This new flag causes thrift to accept negative key values, so that these
> older .thrift files can be updated with explicitly specified values.  It
> emits a warning if a negative value is specified that is different from
> what thrift would have otherwise chosen.
> Test Plan:
> Tested modifying common/fbunit/logger/if/UnitTestLogger.thrift
> and biggrep/BigGrep.thrift to pass in negative field values.
> I'll check in the changes to these .thrift files separately, since it
> also requires changes to fbconfig to support passing in the
> --allow-neg-keys argument.  For fbunit, I'll probably change it to just
> use positive key values, since we don't really care about backwards
> compatibility in that case.
> ---
>  compiler/cpp/src/globals.h   |   15 +
>  compiler/cpp/src/main.cc |   10 
>  compiler/cpp/src/parse/t_field.h |9 
>  compiler/cpp/src/thrifty.yy  |   43 +++--
>  4 files changed, 70 insertions(+), 7 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1254) Code can't be compiled against a regular JRE: Object.clone() override has a different return type

[Bryan Duxbury (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Duxbury updated THRIFT-1254:
--

Attachment: thrift-1254.patch

What do you think of this patch, Raphael?

> Code can't be compiled against a regular JRE: Object.clone() override has a 
> different return type
> -
>
> Key: THRIFT-1254
> URL: https://issues.apache.org/jira/browse/THRIFT-1254
> Project: Thrift
>  Issue Type: Bug
>  Components: JavaME - Compiler
>Affects Versions: 0.6.1
>Reporter: Raphaël Bartement
>Priority: Minor
> Attachments: Patch.patch, thrift-1254.patch
>
>
> Code generator produces 2 methods to clone objects: "clone" and "deepCopy", 
> with the exact same implementation.
> The "clone()" methods is conflicting with the regular Object.clone() method 
> of the standard Java platform. Its return type is different (type of the 
> object, instead of just Object).
> (http://download.oracle.com/javase/1.4.2/docs/api/java/lang/Object.html#clone())
> This prevent the code from being compiled by the regular java compiler.
> This is not it's finality, but it is really useful to produce intermediate 
> libraries as JAR files.
> Using only RAPC (BlackBerry's JDE compiler), we would have to include source 
> code directly.
> Attached patch preserves the strongly typed signature of deepCopy(), but turn 
> back clone()'s return type to Object.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1268) FB cpp updates, jan-apr 2010.

[Dave Watson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Watson updated THRIFT-1268:


Attachment: (was: patches.tar.gz)

> FB cpp updates, jan-apr 2010.
> -
>
> Key: THRIFT-1268
> URL: https://issues.apache.org/jira/browse/THRIFT-1268
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Priority: Minor
>
> I've got a backlog of about 18 months of thrift patches I'm going to push out 
> as time allows.  Around ~200 individual commits.  Mostly cpp, but some 
> java/php/python or other.
> Here's the first couple months of cpp patches.
> Let me know if you'd rather these come one commit per issue, or some other 
> way, I'm flexible.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1268) FB cpp updates, jan-apr 2010.

[Dave Watson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Watson updated THRIFT-1268:


Attachment: (was: jan-apr.patch)

> FB cpp updates, jan-apr 2010.
> -
>
> Key: THRIFT-1268
> URL: https://issues.apache.org/jira/browse/THRIFT-1268
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Priority: Minor
>
> I've got a backlog of about 18 months of thrift patches I'm going to push out 
> as time allows.  Around ~200 individual commits.  Mostly cpp, but some 
> java/php/python or other.
> Here's the first couple months of cpp patches.
> Let me know if you'd rather these come one commit per issue, or some other 
> way, I'm flexible.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1270) thrift: add --allow-neg-keys argument to allow

[Dave Watson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Watson updated THRIFT-1270:


Attachment: (was: 
0002-thrift-add-allow-neg-keys-argument-to-allow-negative.patch)

>  thrift: add --allow-neg-keys argument to allow

> 
>
> Key: THRIFT-1270
> URL: https://issues.apache.org/jira/browse/THRIFT-1270
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Priority: Minor
>
> From 0df0b8cec89a9d7652fbbabd06e5b4d153537431 Mon Sep 17 00:00:00 2001
> From: Dave Watson 
> Date: Tue, 2 Aug 2011 08:40:44 -0700
> Subject: [PATCH 02/33] thrift: add --allow-neg-keys argument to allow
>  negative field keys
> Summary:
> Several of our .thrift files already deployed in production do not have
> explicitly specified key values for all fields.  Thrift automatically
> chooses negative values for these keys (and also emits a warning while
> doing so).  Previously, this couldn't be fixed without breaking protocol
> compatibility, since thrift refuses to accept explicitly specified
> negative key values.
> This new flag causes thrift to accept negative key values, so that these
> older .thrift files can be updated with explicitly specified values.  It
> emits a warning if a negative value is specified that is different from
> what thrift would have otherwise chosen.
> Test Plan:
> Tested modifying common/fbunit/logger/if/UnitTestLogger.thrift
> and biggrep/BigGrep.thrift to pass in negative field values.
> I'll check in the changes to these .thrift files separately, since it
> also requires changes to fbconfig to support passing in the
> --allow-neg-keys argument.  For fbunit, I'll probably change it to just
> use positive key values, since we don't really care about backwards
> compatibility in that case.
> ---
>  compiler/cpp/src/globals.h   |   15 +
>  compiler/cpp/src/main.cc |   10 
>  compiler/cpp/src/parse/t_field.h |9 
>  compiler/cpp/src/thrifty.yy  |   43 +++--
>  4 files changed, 70 insertions(+), 7 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1270) thrift: add --allow-neg-keys argument to allow

[Dave Watson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Watson updated THRIFT-1270:


Attachment: 0002-thrift-add-allow-neg-keys-argument-to-allow-negative.patch

>  thrift: add --allow-neg-keys argument to allow

> 
>
> Key: THRIFT-1270
> URL: https://issues.apache.org/jira/browse/THRIFT-1270
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Priority: Minor
>
> From 0df0b8cec89a9d7652fbbabd06e5b4d153537431 Mon Sep 17 00:00:00 2001
> From: Dave Watson 
> Date: Tue, 2 Aug 2011 08:40:44 -0700
> Subject: [PATCH 02/33] thrift: add --allow-neg-keys argument to allow
>  negative field keys
> Summary:
> Several of our .thrift files already deployed in production do not have
> explicitly specified key values for all fields.  Thrift automatically
> chooses negative values for these keys (and also emits a warning while
> doing so).  Previously, this couldn't be fixed without breaking protocol
> compatibility, since thrift refuses to accept explicitly specified
> negative key values.
> This new flag causes thrift to accept negative key values, so that these
> older .thrift files can be updated with explicitly specified values.  It
> emits a warning if a negative value is specified that is different from
> what thrift would have otherwise chosen.
> Test Plan:
> Tested modifying common/fbunit/logger/if/UnitTestLogger.thrift
> and biggrep/BigGrep.thrift to pass in negative field values.
> I'll check in the changes to these .thrift files separately, since it
> also requires changes to fbconfig to support passing in the
> --allow-neg-keys argument.  For fbunit, I'll probably change it to just
> use positive key values, since we don't really care about backwards
> compatibility in that case.
> ---
>  compiler/cpp/src/globals.h   |   15 +
>  compiler/cpp/src/main.cc |   10 
>  compiler/cpp/src/parse/t_field.h |9 
>  compiler/cpp/src/thrifty.yy  |   43 +++--
>  4 files changed, 70 insertions(+), 7 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (THRIFT-1270) thrift: add --allow-neg-keys argument to allow

[Dave Watson (JIRA)]

 thrift: add --allow-neg-keys argument to allow



 Key: THRIFT-1270
 URL: https://issues.apache.org/jira/browse/THRIFT-1270
 Project: Thrift
  Issue Type: Improvement
  Components: C++ - Library
Reporter: Dave Watson
Priority: Minor


>From 0df0b8cec89a9d7652fbbabd06e5b4d153537431 Mon Sep 17 00:00:00 2001
From: Dave Watson 
Date: Tue, 2 Aug 2011 08:40:44 -0700
Subject: [PATCH 02/33] thrift: add --allow-neg-keys argument to allow
 negative field keys

Summary:
Several of our .thrift files already deployed in production do not have
explicitly specified key values for all fields.  Thrift automatically
chooses negative values for these keys (and also emits a warning while
doing so).  Previously, this couldn't be fixed without breaking protocol
compatibility, since thrift refuses to accept explicitly specified
negative key values.

This new flag causes thrift to accept negative key values, so that these
older .thrift files can be updated with explicitly specified values.  It
emits a warning if a negative value is specified that is different from
what thrift would have otherwise chosen.


Test Plan:
Tested modifying common/fbunit/logger/if/UnitTestLogger.thrift
and biggrep/BigGrep.thrift to pass in negative field values.

I'll check in the changes to these .thrift files separately, since it
also requires changes to fbconfig to support passing in the
--allow-neg-keys argument.  For fbunit, I'll probably change it to just
use positive key values, since we don't really care about backwards
compatibility in that case.



---
 compiler/cpp/src/globals.h   |   15 +
 compiler/cpp/src/main.cc |   10 
 compiler/cpp/src/parse/t_field.h |9 
 compiler/cpp/src/thrifty.yy  |   43 +++--
 4 files changed, 70 insertions(+), 7 deletions(-)



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1269) thrift: handle undeclared exceptions in the async

[Dave Watson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Watson updated THRIFT-1269:


Attachment: 0001-thrift-handle-undeclared-exceptions-in-the-async-err.patch

> thrift: handle undeclared exceptions in the async
> -
>
> Key: THRIFT-1269
> URL: https://issues.apache.org/jira/browse/THRIFT-1269
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Compiler, C++ - Library
>Reporter: Dave Watson
>Priority: Minor
> Attachments: 
> 0001-thrift-handle-undeclared-exceptions-in-the-async-err.patch
>
>
> From 25366c3648ef4c2d436641a2051c057abde05975 Mon Sep 17 00:00:00 2001
> From: Adam Simpkins 
> Date: Wed, 6 Jan 2010 02:10:19 +
> Subject: [PATCH 01/33] thrift: handle undeclared exceptions in the async
>  error cob
> Summary:
> This updates the generated TAsyncProcessor code to correctly handle when
> an undeclared exception type is passed into an error callback.  It now
> sends back a T_EXCEPTION message to the client, just like the non-async
> code does.  Previously the exception wouldn't be handled, causing the
> TEventWorker thread to exit.
> Test Plan:
> Tested changing the async sort tutorial to pass in a generic TException
> rather than a SortError, and verified that the client correctly received
> an exception.
> Conflicts:
>   compiler/cpp/src/generate/t_cpp_generator.cc
> ---
>  compiler/cpp/src/generate/t_cpp_generator.cc |   38 +
>  1 files changed, 32 insertions(+), 6 deletions(-)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (THRIFT-1269) thrift: handle undeclared exceptions in the async

[Dave Watson (JIRA)]

thrift: handle undeclared exceptions in the async
-

 Key: THRIFT-1269
 URL: https://issues.apache.org/jira/browse/THRIFT-1269
 Project: Thrift
  Issue Type: Improvement
  Components: C++ - Compiler, C++ - Library
Reporter: Dave Watson
Priority: Minor


>From 25366c3648ef4c2d436641a2051c057abde05975 Mon Sep 17 00:00:00 2001
From: Adam Simpkins 
Date: Wed, 6 Jan 2010 02:10:19 +
Subject: [PATCH 01/33] thrift: handle undeclared exceptions in the async
 error cob

Summary:
This updates the generated TAsyncProcessor code to correctly handle when
an undeclared exception type is passed into an error callback.  It now
sends back a T_EXCEPTION message to the client, just like the non-async
code does.  Previously the exception wouldn't be handled, causing the
TEventWorker thread to exit.


Test Plan:
Tested changing the async sort tutorial to pass in a generic TException
rather than a SortError, and verified that the client correctly received
an exception.




Conflicts:

compiler/cpp/src/generate/t_cpp_generator.cc
---
 compiler/cpp/src/generate/t_cpp_generator.cc |   38 +
 1 files changed, 32 insertions(+), 6 deletions(-)


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Build failed in Jenkins: Thrift-cpp #123

[Apache Jenkins Server]

See 

Changes:

[jfarrell] Updating python setup.py for deploying client to pypi

--
[...truncated 1331 lines...]
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether make sets $(MAKE)... (cached) yes
checking for bison... bison -y
checking for flex... flex
checking lex output file root... lex.yy
checking lex library... -lfl
checking whether yytext is a pointer... yes
checking whether ln -s works... yes
checking for gawk... (cached) mawk
checking for ranlib... (cached) ranlib
checking for boostlib >= 1.33.1... yes
checking for libevent >= 1.0... yes
checking for zlib >= 1.2.3... yes
checking for trial... /usr/bin/trial
checking for 6g... /usr/local/bin/6g
checking for 6l... /usr/local/bin/6l
checking for gomake... /usr/local/bin/gomake
checking for goinstall... /usr/local/bin/goinstall
checking for an ANSI C-conforming const... yes
checking for inline... inline
checking for working volatile... yes
checking for stdbool.h that conforms to C99... no
checking for _Bool... no
checking for ANSI C header files... (cached) yes
checking whether time.h and sys/time.h may both be included... yes
checking for sys/wait.h that is POSIX.1 compatible... yes
checking return type of signal handlers... void
checking arpa/inet.h usability... yes
checking arpa/inet.h presence... yes
checking for arpa/inet.h... yes
checking sys/param.h usability... yes
checking sys/param.h presence... yes
checking for sys/param.h... yes
checking fcntl.h usability... yes
checking fcntl.h presence... yes
checking for fcntl.h... yes
checking for inttypes.h... (cached) yes
checking limits.h usability... yes
checking limits.h presence... yes
checking for limits.h... yes
checking netdb.h usability... yes
checking netdb.h presence... yes
checking for netdb.h... yes
checking netinet/in.h usability... yes
checking netinet/in.h presence... yes
checking for netinet/in.h... yes
checking pthread.h usability... yes
checking pthread.h presence... yes
checking for pthread.h... yes
checking stddef.h usability... yes
checking stddef.h presence... yes
checking for stddef.h... yes
checking for stdlib.h... (cached) yes
checking sys/socket.h usability... yes
checking sys/socket.h presence... yes
checking for sys/socket.h... yes
checking sys/time.h usability... yes
checking sys/time.h presence... yes
checking for sys/time.h... yes
checking for unistd.h... (cached) yes
checking libintl.h usability... yes
checking libintl.h presence... yes
checking for libintl.h... yes
checking malloc.h usability... yes
checking malloc.h presence... yes
checking for malloc.h... yes
checking openssl/ssl.h usability... yes
checking openssl/ssl.h presence... yes
checking for openssl/ssl.h... yes
checking openssl/rand.h usability... yes
checking openssl/rand.h presence... yes
checking for openssl/rand.h... yes
checking openssl/x509v3.h usability... yes
checking openssl/x509v3.h presence... yes
checking for openssl/x509v3.h... yes
checking for pthread_create in -lpthread... yes
checking for clock_gettime in -lrt... yes
checking for setsockopt in -lsocket... no
checking for SSL_ctrl in -lssl... yes
checking for int16_t... yes
checking for int32_t... yes
checking for int64_t... yes
checking for int8_t... yes
checking for mode_t... yes
checking for off_t... yes
checking for size_t... yes
checking for ssize_t... yes
checking for uint16_t... yes
checking for uint32_t... yes
checking for uint64_t... yes
checking for uint8_t... yes
checking for ptrdiff_t... yes
checking whether struct tm is in sys/time.h or time.h... time.h
checking whether AI_ADDRCONFIG is declared... yes
checking for working alloca.h... yes
checking for alloca... yes
checking for pid_t... yes
checking vfork.h usability... no
checking vfork.h presence... no
checking for vfork.h... no
checking for fork... yes
checking for vfork... yes
checking for working fork... yes
checking for working vfork... (cached) yes
checking for stdlib.h... (cached) yes
checking for GNU libc compatible malloc... yes
checking for working memcmp... yes
checking for stdlib.h... (cached) yes
checking for GNU libc compatible realloc... yes
checking sys/select.h usability... yes
checking sys/select.h presence... yes
checking for sys/select.h... yes
checking for sys/socket.h... (cached) yes
checking types of arguments for select... int,fd_set *,struct timeval *
checking whether lstat correctly handles trailing slash... yes
checking whether stat accepts an empty string... no
checking whether strerror_r is declared... yes
checking for strerror_r... yes
checking whether strerror_r returns char *... yes
checking for strftime... yes
checking for vprintf... yes
checking for _doprnt... no
checking for strtoul... yes
checking for bzero... yes
checking for ftruncate... yes
checking for gethostbyname... yes
checking for gettimeofday... yes
checking for memmove... yes
checking for memset... y

Build failed in Jenkins: Thrift #221

[Apache Jenkins Server]

See 

Changes:

[jfarrell] Updating python setup.py for deploying client to pypi

--
[...truncated 3631 lines...]
[artifact:dependencies] Unable to locate resource in repository
[artifact:dependencies] [INFO] Unable to find resource 
'org.codehaus.plexus:plexus-component-annotations:jar:1.0-beta-3.0.1' in 
repository jstd-maven-plugin google code repo 
(http://jstd-maven-plugin.googlecode.com/svn/maven2)
[artifact:dependencies] Downloading: 
org/codehaus/plexus/plexus-component-annotations/1.0-beta-3.0.1/plexus-component-annotations-1.0-beta-3.0.1.jar
 from repository maven2-repository.dev.java.net at 
http://download.java.net/maven/2/
[artifact:dependencies] Unable to locate resource in repository
[artifact:dependencies] [INFO] Unable to find resource 
'org.codehaus.plexus:plexus-component-annotations:jar:1.0-beta-3.0.1' in 
repository maven2-repository.dev.java.net (http://download.java.net/maven/2/)
[artifact:dependencies] Downloading: 
org/codehaus/plexus/plexus-component-annotations/1.0-beta-3.0.1/plexus-component-annotations-1.0-beta-3.0.1.jar
 from repository jstd-maven-plugin-repo at 
http://jstd-maven-plugin.googlecode.com/svn/maven2
[artifact:dependencies] Unable to locate resource in repository
[artifact:dependencies] [INFO] Unable to find resource 
'org.codehaus.plexus:plexus-component-annotations:jar:1.0-beta-3.0.1' in 
repository jstd-maven-plugin-repo 
(http://jstd-maven-plugin.googlecode.com/svn/maven2)
[artifact:dependencies] Downloading: 
org/codehaus/plexus/plexus-component-annotations/1.0-beta-3.0.1/plexus-component-annotations-1.0-beta-3.0.1.jar
 from repository central at http://repo1.maven.org/maven2
[artifact:dependencies] Downloading: 
org/apache/maven/maven-project-builder/3.0-alpha-1/maven-project-builder-3.0-alpha-1.jar
 from repository jstd-maven-plugin google code repo at 
http://jstd-maven-plugin.googlecode.com/svn/maven2
[artifact:dependencies] Unable to locate resource in repository
[artifact:dependencies] [INFO] Unable to find resource 
'org.apache.maven:maven-project-builder:jar:3.0-alpha-1' in repository 
jstd-maven-plugin google code repo 
(http://jstd-maven-plugin.googlecode.com/svn/maven2)
[artifact:dependencies] Downloading: 
org/apache/maven/maven-project-builder/3.0-alpha-1/maven-project-builder-3.0-alpha-1.jar
 from repository maven2-repository.dev.java.net at 
http://download.java.net/maven/2/
[artifact:dependencies] Unable to locate resource in repository
[artifact:dependencies] [INFO] Unable to find resource 
'org.apache.maven:maven-project-builder:jar:3.0-alpha-1' in repository 
maven2-repository.dev.java.net (http://download.java.net/maven/2/)
[artifact:dependencies] Downloading: 
org/apache/maven/maven-project-builder/3.0-alpha-1/maven-project-builder-3.0-alpha-1.jar
 from repository jstd-maven-plugin-repo at 
http://jstd-maven-plugin.googlecode.com/svn/maven2
[artifact:dependencies] Unable to locate resource in repository
[artifact:dependencies] [INFO] Unable to find resource 
'org.apache.maven:maven-project-builder:jar:3.0-alpha-1' in repository 
jstd-maven-plugin-repo (http://jstd-maven-plugin.googlecode.com/svn/maven2)
[artifact:dependencies] Downloading: 
org/apache/maven/maven-project-builder/3.0-alpha-1/maven-project-builder-3.0-alpha-1.jar
 from repository central at http://repo1.maven.org/maven2
 [copy] Copying 36 files to 


jslint:

lint:

dependencies:

init:
[mkdir] Created dir: 

[mkdir] Created dir: 

[mkdir] Created dir: 

[mkdir] Created dir: 


xvfb:
 [echo] check if Xvfb is available:
 [exec] Execute failed: java.io.IOException: Cannot run program "Xvfb": 
java.io.IOException: error=2, No such file or directory

phantomjs:

compile:
[javac] Compiling 21 source files to 

[javac] Note: Some input files use unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.
[javac] Compiling 1 source file to 

[javac] Note: 

 uses unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.

jstest:
  [jar] Building jar: 


proxy:

jslibs:
  [get] Getting: http://code.jquery.com/jquery-1.5.2.js
  [get] To: 

[jira] [Commented] (THRIFT-1268) FB cpp updates, jan-apr 2010.

[Dave Watson (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086480#comment-13086480
 ] 

Dave Watson commented on THRIFT-1268:
-

Sure, no problem.

> FB cpp updates, jan-apr 2010.
> -
>
> Key: THRIFT-1268
> URL: https://issues.apache.org/jira/browse/THRIFT-1268
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Priority: Minor
> Attachments: jan-apr.patch, patches.tar.gz
>
>
> I've got a backlog of about 18 months of thrift patches I'm going to push out 
> as time allows.  Around ~200 individual commits.  Mostly cpp, but some 
> java/php/python or other.
> Here's the first couple months of cpp patches.
> Let me know if you'd rather these come one commit per issue, or some other 
> way, I'm flexible.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1268) FB cpp updates, jan-apr 2010.

[Bryan Duxbury (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086478#comment-13086478
 ] 

Bryan Duxbury commented on THRIFT-1268:
---

Dave - I'm excited to get tons of FB updates, but I think we'd really be better 
off with them as separate tickets. Otherwise, it's going to be really difficult 
for us to track which ones we want and which ones we don't, not to mention 
include the changes in the release notes.

> FB cpp updates, jan-apr 2010.
> -
>
> Key: THRIFT-1268
> URL: https://issues.apache.org/jira/browse/THRIFT-1268
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Priority: Minor
> Attachments: jan-apr.patch, patches.tar.gz
>
>
> I've got a backlog of about 18 months of thrift patches I'm going to push out 
> as time allows.  Around ~200 individual commits.  Mostly cpp, but some 
> java/php/python or other.
> Here's the first couple months of cpp patches.
> Let me know if you'd rather these come one commit per issue, or some other 
> way, I'm flexible.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1268) FB cpp updates, jan-apr 2010.

[Dave Watson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Watson updated THRIFT-1268:


Attachment: jan-apr.patch

big patch, combined all the individual patches.

> FB cpp updates, jan-apr 2010.
> -
>
> Key: THRIFT-1268
> URL: https://issues.apache.org/jira/browse/THRIFT-1268
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Priority: Minor
> Attachments: jan-apr.patch, patches.tar.gz
>
>
> I've got a backlog of about 18 months of thrift patches I'm going to push out 
> as time allows.  Around ~200 individual commits.  Mostly cpp, but some 
> java/php/python or other.
> Here's the first couple months of cpp patches.
> Let me know if you'd rather these come one commit per issue, or some other 
> way, I'm flexible.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1268) FB cpp updates, jan-apr 2010.

[Dave Watson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Watson updated THRIFT-1268:


Attachment: patches.tar.gz

> FB cpp updates, jan-apr 2010.
> -
>
> Key: THRIFT-1268
> URL: https://issues.apache.org/jira/browse/THRIFT-1268
> Project: Thrift
>  Issue Type: Improvement
>  Components: C++ - Library
>Reporter: Dave Watson
>Priority: Minor
> Attachments: jan-apr.patch, patches.tar.gz
>
>
> I've got a backlog of about 18 months of thrift patches I'm going to push out 
> as time allows.  Around ~200 individual commits.  Mostly cpp, but some 
> java/php/python or other.
> Here's the first couple months of cpp patches.
> Let me know if you'd rather these come one commit per issue, or some other 
> way, I'm flexible.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (THRIFT-1268) FB cpp updates, jan-apr 2010.

[Dave Watson (JIRA)]

FB cpp updates, jan-apr 2010.
-

 Key: THRIFT-1268
 URL: https://issues.apache.org/jira/browse/THRIFT-1268
 Project: Thrift
  Issue Type: Improvement
  Components: C++ - Library
Reporter: Dave Watson
Priority: Minor


I've got a backlog of about 18 months of thrift patches I'm going to push out 
as time allows.  Around ~200 individual commits.  Mostly cpp, but some 
java/php/python or other.
Here's the first couple months of cpp patches.

Let me know if you'd rather these come one commit per issue, or some other way, 
I'm flexible.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1267) Node.js can't throw exceptions.

[Wade Simmons (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086436#comment-13086436
 ] 

Wade Simmons commented on THRIFT-1267:
--

I wonder if we should instead make a backwards incompatible change for the 0.8 
release and change the callback style to match the rest of Node.js: 
callback(err, result). instead of the current: callback(result).

> Node.js can't throw exceptions. 
> 
>
> Key: THRIFT-1267
> URL: https://issues.apache.org/jira/browse/THRIFT-1267
> Project: Thrift
>  Issue Type: Improvement
>  Components: JavaScript - Compiler
>Affects Versions: 0.7
>Reporter: Hans Duedal
>  Labels: compiler, javascript, node, nodejs
> Fix For: 0.7
>
> Attachments: nodejs-exception.patch
>
>
> There is no way as far as I can tell for node.js servers to throw thrift 
> exceptions.
> I have made a patch to allow it to throw exceptions. It lets the node.js 
> server implementation give params directly to the result object, thereby 
> being able to specify the exception. It doesn't affect normal (non exception) 
> return data.
> Test case: https://gist.github.com/1151782
> Install thrift module "npm install thrift", generate thrift "thrift --gen 
> js:node test.thrift" and run server then client.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1267) Node.js can't throw exceptions.

[Hans Duedal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hans Duedal updated THRIFT-1267:


Attachment: nodejs-exception.patch

Applies to both 0.7.x and trunk atm.

> Node.js can't throw exceptions. 
> 
>
> Key: THRIFT-1267
> URL: https://issues.apache.org/jira/browse/THRIFT-1267
> Project: Thrift
>  Issue Type: Improvement
>  Components: JavaScript - Compiler
>Affects Versions: 0.7
>Reporter: Hans Duedal
>  Labels: compiler, javascript, node, nodejs
> Fix For: 0.7
>
> Attachments: nodejs-exception.patch
>
>
> There is no way as far as I can tell for node.js servers to throw thrift 
> exceptions.
> I have made a patch to allow it to throw exceptions. It lets the node.js 
> server implementation give params directly to the result object, thereby 
> being able to specify the exception. It doesn't affect normal (non exception) 
> return data.
> Test case: https://gist.github.com/1151782
> Install thrift module "npm install thrift", generate thrift "thrift --gen 
> js:node test.thrift" and run server then client.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (THRIFT-1267) Node.js can't throw exceptions.

[Hans Duedal (JIRA)]

Node.js can't throw exceptions. 


 Key: THRIFT-1267
 URL: https://issues.apache.org/jira/browse/THRIFT-1267
 Project: Thrift
  Issue Type: Improvement
  Components: JavaScript - Compiler
Affects Versions: 0.7
Reporter: Hans Duedal
 Fix For: 0.7


There is no way as far as I can tell for node.js servers to throw thrift 
exceptions.

I have made a patch to allow it to throw exceptions. It lets the node.js server 
implementation give params directly to the result object, thereby being able to 
specify the exception. It doesn't affect normal (non exception) return data.

Test case: https://gist.github.com/1151782
Install thrift module "npm install thrift", generate thrift "thrift --gen 
js:node test.thrift" and run server then client.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1266) generated C code for iterating over nested maps is wrong

[Aleksandrs Saveljevs (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aleksandrs Saveljevs updated THRIFT-1266:
-

Attachment: batch_mutate.c

> generated C code for iterating over nested maps is wrong
> 
>
> Key: THRIFT-1266
> URL: https://issues.apache.org/jira/browse/THRIFT-1266
> Project: Thrift
>  Issue Type: Bug
>  Components: C glib - Compiler
>Affects Versions: 0.8
> Environment: Revision 1158683 of 
> http://svn.apache.org/repos/asf/thrift/trunk.
>Reporter: Aleksandrs Saveljevs
>Priority: Critical
>  Labels: c_glib, cassandra
> Attachments: batch_mutate.c
>
>
> We are working with Cassandra API in C generated by Thrift and have noticed a 
> bug in the generated code for cassandra_client_send_batch_mutate().
> Full code that Thrift generates for this function is attached, but here is 
> the specification for Cassandra's batch_mutate method:
> {code}/**
>   Mutate many columns or super columns for many row keys. See also: Mutation.
>   mutation_map maps key to column family to a list of Mutation objects to 
> take place at that scope.
> **/
> void batch_mutate(1:required map>> 
> mutation_map,
>   2:required ConsistencyLevel 
> consistency_level=ConsistencyLevel.ONE)
>  throws (1:InvalidRequestException ire, 2:UnavailableException ue, 
> 3:TimedOutException te),
> {code}
> If we now look at the generated code, we will notice the following fragment:
> {code}GPtrArray * value;
> g_hash_table_foreach ((GHashTable *)  value, thrift_hash_table_get_keys, 
> &key_list); /* LINE A */
> {code}
> We can see that in line A it uses the variable "value" as GHashTable, even 
> though the GHashTable "value" was shadowed by GPtrArray "value" a line before.
> Similarly, we can see another fragment below that one, where one instance of 
> variable "value" shadows another instance:
> {code}
> value = (GPtrArray *) g_hash_table_lookup (((GHashTable *)  value), 
> (gpointer) key); /* LINE B */
> {code}
> We have worked around the bug in our particular case by renaming one of the 
> "value" variables to "value2" (see "svn di -c 21176 
> svn://svn.zabbix.com/branches/dev/ZBXNEXT-844/src/libs/zbxcassa/cassandra.c" 
> for a diff), but it would be nice to fix it in Thrift, too.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (THRIFT-1266) generated C code for iterating over nested maps is wrong

[Aleksandrs Saveljevs (JIRA)]

generated C code for iterating over nested maps is wrong


 Key: THRIFT-1266
 URL: https://issues.apache.org/jira/browse/THRIFT-1266
 Project: Thrift
  Issue Type: Bug
  Components: C glib - Compiler
Affects Versions: 0.8
 Environment: Revision 1158683 of 
http://svn.apache.org/repos/asf/thrift/trunk.
Reporter: Aleksandrs Saveljevs
Priority: Critical


We are working with Cassandra API in C generated by Thrift and have noticed a 
bug in the generated code for cassandra_client_send_batch_mutate().

Full code that Thrift generates for this function is attached, but here is the 
specification for Cassandra's batch_mutate method:

{code}/**
  Mutate many columns or super columns for many row keys. See also: Mutation.

  mutation_map maps key to column family to a list of Mutation objects to take 
place at that scope.
**/
void batch_mutate(1:required map>> 
mutation_map,
  2:required ConsistencyLevel 
consistency_level=ConsistencyLevel.ONE)
 throws (1:InvalidRequestException ire, 2:UnavailableException ue, 
3:TimedOutException te),
{code}

If we now look at the generated code, we will notice the following fragment:

{code}GPtrArray * value;
g_hash_table_foreach ((GHashTable *)  value, thrift_hash_table_get_keys, 
&key_list); /* LINE A */
{code}

We can see that in line A it uses the variable "value" as GHashTable, even 
though the GHashTable "value" was shadowed by GPtrArray "value" a line before.

Similarly, we can see another fragment below that one, where one instance of 
variable "value" shadows another instance:

{code}
value = (GPtrArray *) g_hash_table_lookup (((GHashTable *)  value), (gpointer) 
key); /* LINE B */
{code}

We have worked around the bug in our particular case by renaming one of the 
"value" variables to "value2" (see "svn di -c 21176 
svn://svn.zabbix.com/branches/dev/ZBXNEXT-844/src/libs/zbxcassa/cassandra.c" 
for a diff), but it would be nice to fix it in Thrift, too.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1264) TSocketClient is queried by run loop after deallocation in Cocoa

[JIRA]

 [ 
https://issues.apache.org/jira/browse/THRIFT-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Rüth updated THRIFT-1264:
-

Summary: TSocketClient is queried by run loop after deallocation in Cocoa  
(was: TSocketClient is queried by run loop after deallocation)

> TSocketClient is queried by run loop after deallocation in Cocoa
> 
>
> Key: THRIFT-1264
> URL: https://issues.apache.org/jira/browse/THRIFT-1264
> Project: Thrift
>  Issue Type: Bug
>  Components: Cocoa - Library
>Affects Versions: 0.7
> Environment: iPad, iOS SDK 4.3
>Reporter: Jan Rüth
> Attachments: THRIFT-1264.diff
>
>
> When using TSocketClient in a Cocoa client and correctly managing the memory:
> {code:title=Server.m|borderStyle=solid}
> - (id)initWithServer:(NSString*)server port:(NSInteger)port
> {
> self = [super init];
> if (self) {
> TSocketClient *transport = [[TSocketClient alloc] 
> initWithHostname:server 
>port:port];
> TBinaryProtocol *protocol = [[TBinaryProtocolFactory sharedFactory] 
> newProtocolOnTransport:transport];
> Client *client = [[Client alloc] initWithProtocol:protocol];
> // self.client is a retained property
> self.client = client;
> [client release];
> [protocol release];
> [transport release];
> }
> 
> return self;
> }
> - (void)dealloc {
> self.client = nil;
> [super dealloc];
> }
> {code}
> (maybe this should be fixed in the cocoa example, memory management is 
> erroneous there)
> After successfully releasing the object with the code above. One gets a 
> EXC_BAD_ACCESS signal because the runloop send a responseToSelector: message 
> to our object. With the selector stream:handleEvent:
> This all leads to TSocketClient which opens two NSStream objects and 
> delegates it self to both, afterwards both Streams are scheduled in the 
> runloop, which should actually notify the delegate when something happens to 
> the stream like data is available, this obviously results in the runloop 
> asking TSocketClient for previously described selector. However this 
> mechanism is not used, the TNSStreamTransport class is subclassed and 
> responsible for read/write.
> So why are the Streams schedules in the run loop in the first place?
> Why are the streams not closed and released when the object gets deallocated?
> I could fix this behavior by implementing a dealloc method in TSocketClient 
> and making the Streams member variables
> {code:title=TSocketClient.h|borderStyle=solid}
> @interface TSocketClient : TNSStreamTransport {
> NSInputStream * inputStream;
>   NSOutputStream * outputStream;
> }
> {code}
> {code:title=TSocketClient.m|borderStyle=solid}
> -(void)dealloc {
> [inputStream close];
> [outputStream close];
> [inputStream release];
> [outputStream release];
> [super dealloc];
> }
> {code}
> However I still don't know if that is the right way.
> Suggestions?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira