[jira] [Commented] (THRIFT-3857) thrift js:node complier support an object as parameter not an instance of struct
[
https://issues.apache.org/jira/browse/THRIFT-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958331#comment-15958331
]
ASF GitHub Bot commented on THRIFT-3857:
Github user leaves4j commented on the issue:
https://github.com/apache/thrift/pull/1034
I have rebased on upstream/master and add those commits into latest branch
@jeking3
> thrift js:node complier support an object as parameter not an instance of
> struct
>
>
> Key: THRIFT-3857
> URL: https://issues.apache.org/jira/browse/THRIFT-3857
> Project: Thrift
> Issue Type: New Feature
> Components: Node.js - Compiler
>Affects Versions: 0.9.3, 1.0
>Reporter: jiangq
>
> use the tutorial.thrift,code like:
> {code:javascript}
> let param = {
> op: ttypes.Operation.DIVIDE,
> num1: 1,
> num2: 0
> }
> let work = new ttypes.Work(param);
> client.calculate(1, work)
> .then(function(message) {
> console.log('Whoa? You know how to divide by zero?');
> })
> .fail(function(err) {
> console.log("InvalidOperation " + err);
> });
> {code}
> can we support like these:
> {code:javascript}
> let work = {
> op: ttypes.Operation.DIVIDE,
> num1: 1,
> num2: 0
> }
> client.calculate(1, work)
> .then(function(message) {
> console.log('Whoa? You know how to divide by zero?');
> })
> .fail(function(err) {
> console.log("InvalidOperation " + err);
> });
> {code}
> If we can support this feature will be very convenient， and I have read the
> 't_js_generator.cc' file, find this feature is easy to support, can we add
> the support for this feature?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] thrift issue #1034: THRIFT-3857
Github user leaves4j commented on the issue: https://github.com/apache/thrift/pull/1034 I have rebased on upstream/master and add those commits into latest branch @jeking3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #1240: return full error message when exception happens
GitHub user DanielYWoo opened a pull request: https://github.com/apache/thrift/pull/1240 return full error message when exception happens If you throw an exception with error message, the error message will be IGNORED and replaced with a generic message like "Internal processing error getUserInfo". The pull request will append the ACTUAL error message to that message. e,g. "Internal processing error getUserInfo, error message: Cannot connect to database" You can merge this pull request into a Git repository by running: $ git pull https://github.com/DanielYWoo/thrift master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1240.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1240 commit 61138b8c3392fdb6cd546cacfc2c6b87fc77ca04 Author: Daniel Wu Date: 2017-04-06T04:07:10Z return full error message when exception happens --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #1227: Is tornado server not support TMultiplexedProtoco...
Github user nxgych closed the pull request at: https://github.com/apache/thrift/pull/1227 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1227: Is tornado server not support TMultiplexedProtocol?
Github user nxgych commented on the issue: https://github.com/apache/thrift/pull/1227 OK, i will close this pull request, by the way, could you tell me when are you going to merge? next version? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Resolved] (THRIFT-4071) Consolidate the Travis CI jobs where possible to put less stress on the Apache Foundation's allocation of CI build slaves
[ https://issues.apache.org/jira/browse/THRIFT-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4071. Resolution: Fixed Fix Version/s: 0.11.0 > Consolidate the Travis CI jobs where possible to put less stress on the > Apache Foundation's allocation of CI build slaves > - > > Key: THRIFT-4071 > URL: https://issues.apache.org/jira/browse/THRIFT-4071 > Project: Thrift > Issue Type: Improvement > Components: Build Process >Affects Versions: 0.10.0 > Environment: Travis CI >Reporter: James E. King, III >Assignee: James E. King, III > Fix For: 0.11.0 > > > Based on INFRA-13477 it sounds like we need to start working on eliminating > unnecessary build jobs of combining some of them. I emailed the dev mailing > list but didn't hear back after 5 days, so I am proceeding with these changes: > # We don't need to run cross tests on both debian andon ubuntu, especially > since we're using a dockerfile that's practically identical between the two; > one derives from the other. I'd like to recommend removing build jobs #2 and > #4 (debian) and keeping the ubuntu ones. > # Given we remove debian build jobs #2 and #4 above, we can keep #10 which is > a Debian build job with cmake, and eliminate #9 which is the same as #10 but > on Ubuntu. I think it is adqeuately covered in other jobs. > # We don't need to build the matrix of (boost threads, std > threads)x(gcc,clang). Let's get rid of #12 which is boost threads with > clang, and let's get rid of #15 which is std threads with gcc. > # Add missing compiler plug-in builds for autoconf and clang. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-4071) Consolidate the Travis CI jobs where possible to put less stress on the Apache Foundation's allocation of CI build slaves
[ https://issues.apache.org/jira/browse/THRIFT-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958027#comment-15958027 ] ASF GitHub Bot commented on THRIFT-4071: Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1238 > Consolidate the Travis CI jobs where possible to put less stress on the > Apache Foundation's allocation of CI build slaves > - > > Key: THRIFT-4071 > URL: https://issues.apache.org/jira/browse/THRIFT-4071 > Project: Thrift > Issue Type: Improvement > Components: Build Process >Affects Versions: 0.10.0 > Environment: Travis CI >Reporter: James E. King, III >Assignee: James E. King, III > Fix For: 0.11.0 > > > Based on INFRA-13477 it sounds like we need to start working on eliminating > unnecessary build jobs of combining some of them. I emailed the dev mailing > list but didn't hear back after 5 days, so I am proceeding with these changes: > # We don't need to run cross tests on both debian andon ubuntu, especially > since we're using a dockerfile that's practically identical between the two; > one derives from the other. I'd like to recommend removing build jobs #2 and > #4 (debian) and keeping the ubuntu ones. > # Given we remove debian build jobs #2 and #4 above, we can keep #10 which is > a Debian build job with cmake, and eliminate #9 which is the same as #10 but > on Ubuntu. I think it is adqeuately covered in other jobs. > # We don't need to build the matrix of (boost threads, std > threads)x(gcc,clang). Let's get rid of #12 which is boost threads with > clang, and let's get rid of #15 which is std threads with gcc. > # Add missing compiler plug-in builds for autoconf and clang. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift pull request #1238: THRIFT-4071: collapse and remove unnecessary buil...
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1238 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-4071) Consolidate the Travis CI jobs where possible to put less stress on the Apache Foundation's allocation of CI build slaves
[ https://issues.apache.org/jira/browse/THRIFT-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958019#comment-15958019 ] ASF GitHub Bot commented on THRIFT-4071: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1238 The build failure is due to a docker image rebuild because of a submit that was not against master from yesterday/today. > Consolidate the Travis CI jobs where possible to put less stress on the > Apache Foundation's allocation of CI build slaves > - > > Key: THRIFT-4071 > URL: https://issues.apache.org/jira/browse/THRIFT-4071 > Project: Thrift > Issue Type: Improvement > Components: Build Process >Affects Versions: 0.10.0 > Environment: Travis CI >Reporter: James E. King, III >Assignee: James E. King, III > > Based on INFRA-13477 it sounds like we need to start working on eliminating > unnecessary build jobs of combining some of them. I emailed the dev mailing > list but didn't hear back after 5 days, so I am proceeding with these changes: > # We don't need to run cross tests on both debian andon ubuntu, especially > since we're using a dockerfile that's practically identical between the two; > one derives from the other. I'd like to recommend removing build jobs #2 and > #4 (debian) and keeping the ubuntu ones. > # Given we remove debian build jobs #2 and #4 above, we can keep #10 which is > a Debian build job with cmake, and eliminate #9 which is the same as #10 but > on Ubuntu. I think it is adqeuately covered in other jobs. > # We don't need to build the matrix of (boost threads, std > threads)x(gcc,clang). Let's get rid of #12 which is boost threads with > clang, and let's get rid of #15 which is std threads with gcc. > # Add missing compiler plug-in builds for autoconf and clang. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift issue #1238: THRIFT-4071: collapse and remove unnecessary build jobs ...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1238 The build failure is due to a docker image rebuild because of a submit that was not against master from yesterday/today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #1239: Fix wrong numActiveProcessors_ when failing to no...
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1239 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Resolved] (THRIFT-4160) TNonblocking server fix use of closed/freed connections
[ https://issues.apache.org/jira/browse/THRIFT-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4160. Resolution: Fixed > TNonblocking server fix use of closed/freed connections > --- > > Key: THRIFT-4160 > URL: https://issues.apache.org/jira/browse/THRIFT-4160 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.10.0 >Reporter: James E. King, III >Assignee: James E. King, III > Fix For: 0.11.0 > > > Opening a Jira ticket to track changes in > https://github.com/apache/thrift/pull/1211/files. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-4156) Using boost spirit instead of lex and yacc
[ https://issues.apache.org/jira/browse/THRIFT-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957706#comment-15957706 ] Jens Geyer commented on THRIFT-4156: Don't know. This is the [doc testcase we have|https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=blob_plain;f=test/DocTest.thrift;hb=HEAD]. Does that one work? > Using boost spirit instead of lex and yacc > -- > > Key: THRIFT-4156 > URL: https://issues.apache.org/jira/browse/THRIFT-4156 > Project: Thrift > Issue Type: Improvement > Components: Compiler (General) >Reporter: Mike Gresens > Attachments: ast.hpp, doxygen_enum.png, doxygen_service.png, > doxygen_struct.png, MyService.hpp, MyService.thrift, parser.cpp > > > As a developer I want to use boost spirit to get rid of lex and yacc. > This kicks dependency to lex, flex, yacc, bison or what ever. > This makes building easier, because only c++ code must be compiled. > All grammar is inside the code - all c++. No need to learn ll and yy. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (THRIFT-4071) Consolidate the Travis CI jobs where possible to put less stress on the Apache Foundation's allocation of CI build slaves
[ https://issues.apache.org/jira/browse/THRIFT-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4071: --- Description: Based on INFRA-13477 it sounds like we need to start working on eliminating unnecessary build jobs of combining some of them. I emailed the dev mailing list but didn't hear back after 5 days, so I am proceeding with these changes: # We don't need to run cross tests on both debian andon ubuntu, especially since we're using a dockerfile that's practically identical between the two; one derives from the other. I'd like to recommend removing build jobs #2 and #4 (debian) and keeping the ubuntu ones. # Given we remove debian build jobs #2 and #4 above, we can keep #10 which is a Debian build job with cmake, and eliminate #9 which is the same as #10 but on Ubuntu. I think it is adqeuately covered in other jobs. # We don't need to build the matrix of (boost threads, std threads)x(gcc,clang). Let's get rid of #12 which is boost threads with clang, and let's get rid of #15 which is std threads with gcc. # Add missing compiler plug-in builds for autoconf and clang. was: Based on INFRA-13477 it sounds like we need to start working on eliminating unnecessary build jobs of combining some of them. I emailed the dev mailing list but didn't hear back after 5 days, so I am proceeding with these changes: # We don't need to run cross tests on both debian andon ubuntu, especially since we're using a dockerfile that's practically identical between the two; one derives from the other. I'd like to recommend removing build jobs #2 and #4 (debian) and keeping the ubuntu ones. # Given we remove debian build jobs #2 and #4 above, we can keep #10 which is a Debian build job with cmake, and eliminate #9 which is the same as #10 but on Ubuntu. I think it is adqeuately covered in other jobs. # We don't need to build the matrix of (boost threads, std threads)x(gcc,clang). Let's get rid of #12 which is boost threads with clang, and let's get rid of #15 which is std threads with gcc. > Consolidate the Travis CI jobs where possible to put less stress on the > Apache Foundation's allocation of CI build slaves > - > > Key: THRIFT-4071 > URL: https://issues.apache.org/jira/browse/THRIFT-4071 > Project: Thrift > Issue Type: Improvement > Components: Build Process >Affects Versions: 0.10.0 > Environment: Travis CI >Reporter: James E. King, III >Assignee: James E. King, III > > Based on INFRA-13477 it sounds like we need to start working on eliminating > unnecessary build jobs of combining some of them. I emailed the dev mailing > list but didn't hear back after 5 days, so I am proceeding with these changes: > # We don't need to run cross tests on both debian andon ubuntu, especially > since we're using a dockerfile that's practically identical between the two; > one derives from the other. I'd like to recommend removing build jobs #2 and > #4 (debian) and keeping the ubuntu ones. > # Given we remove debian build jobs #2 and #4 above, we can keep #10 which is > a Debian build job with cmake, and eliminate #9 which is the same as #10 but > on Ubuntu. I think it is adqeuately covered in other jobs. > # We don't need to build the matrix of (boost threads, std > threads)x(gcc,clang). Let's get rid of #12 which is boost threads with > clang, and let's get rid of #15 which is std threads with gcc. > # Add missing compiler plug-in builds for autoconf and clang. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-4071) Consolidate the Travis CI jobs where possible to put less stress on the Apache Foundation's allocation of CI build slaves
[ https://issues.apache.org/jira/browse/THRIFT-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957525#comment-15957525 ] ASF GitHub Bot commented on THRIFT-4071: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1238 Although all builds passed, the plug-in builds were not enabled properly for autoconf and a plug-in build with cmake was missing. Pushing a fix. > Consolidate the Travis CI jobs where possible to put less stress on the > Apache Foundation's allocation of CI build slaves > - > > Key: THRIFT-4071 > URL: https://issues.apache.org/jira/browse/THRIFT-4071 > Project: Thrift > Issue Type: Improvement > Components: Build Process >Affects Versions: 0.10.0 > Environment: Travis CI >Reporter: James E. King, III >Assignee: James E. King, III > > Based on INFRA-13477 it sounds like we need to start working on eliminating > unnecessary build jobs of combining some of them. I emailed the dev mailing > list but didn't hear back after 5 days, so I am proceeding with these changes: > # We don't need to run cross tests on both debian andon ubuntu, especially > since we're using a dockerfile that's practically identical between the two; > one derives from the other. I'd like to recommend removing build jobs #2 and > #4 (debian) and keeping the ubuntu ones. > # Given we remove debian build jobs #2 and #4 above, we can keep #10 which is > a Debian build job with cmake, and eliminate #9 which is the same as #10 but > on Ubuntu. I think it is adqeuately covered in other jobs. > # We don't need to build the matrix of (boost threads, std > threads)x(gcc,clang). Let's get rid of #12 which is boost threads with > clang, and let's get rid of #15 which is std threads with gcc. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift issue #1238: THRIFT-4071: collapse and remove unnecessary build jobs ...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1238 Although all builds passed, the plug-in builds were not enabled properly for autoconf and a plug-in build with cmake was missing. Pushing a fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-4166) Recent fix to remove boost::lexical_cast usage broke VS2010
[ https://issues.apache.org/jira/browse/THRIFT-4166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957422#comment-15957422 ] ASF GitHub Bot commented on THRIFT-4166: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1237 Appveyor died due to an environmental error getting "ant" with chocolatey. I have to do an empty commit and kick another one, but I'm going to wait until THRIFT-4071 so it isn't as expensive. > Recent fix to remove boost::lexical_cast usage broke VS2010 > --- > > Key: THRIFT-4166 > URL: https://issues.apache.org/jira/browse/THRIFT-4166 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.11.0 > Environment: VS2010 >Reporter: James E. King, III >Assignee: James E. King, III >Priority: Minor > > Removal of boost::lexical_cast and replaced with code that calls > std::log10(2). std::log10(2) is ambiguous to VS2010. > # Fix build breakage > # add VS2010 32-bit build job to Appveyor to prevent future regression. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift issue #1237: THRIFT-4166: fix recent VC2010 build regression and prev...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1237 Appveyor died due to an environmental error getting "ant" with chocolatey. I have to do an empty commit and kick another one, but I'm going to wait until THRIFT-4071 so it isn't as expensive. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-4160) TNonblocking server fix use of closed/freed connections
[ https://issues.apache.org/jira/browse/THRIFT-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957399#comment-15957399 ] ASF GitHub Bot commented on THRIFT-4160: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1239 We'll re-use THRIFT-4160 for this. > TNonblocking server fix use of closed/freed connections > --- > > Key: THRIFT-4160 > URL: https://issues.apache.org/jira/browse/THRIFT-4160 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.10.0 >Reporter: James E. King, III >Assignee: James E. King, III > Fix For: 0.11.0 > > > Opening a Jira ticket to track changes in > https://github.com/apache/thrift/pull/1211/files. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Reopened] (THRIFT-4160) TNonblocking server fix use of closed/freed connections
[ https://issues.apache.org/jira/browse/THRIFT-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reopened THRIFT-4160: Reopening to get the second pull request for this. > TNonblocking server fix use of closed/freed connections > --- > > Key: THRIFT-4160 > URL: https://issues.apache.org/jira/browse/THRIFT-4160 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.10.0 >Reporter: James E. King, III >Assignee: James E. King, III > Fix For: 0.11.0 > > > Opening a Jira ticket to track changes in > https://github.com/apache/thrift/pull/1211/files. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift issue #1239: Fix wrong numActiveProcessors_ when failing to notify an...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1239 We'll re-use THRIFT-4160 for this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3118) Python MemoryError in THttpClient when using an SSL endpoint
[
https://issues.apache.org/jira/browse/THRIFT-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957375#comment-15957375
]
ASF GitHub Bot commented on THRIFT-3118:
Github user jfarrell closed the pull request at:
https://github.com/apache/thrift/pull/467
> Python MemoryError in THttpClient when using an SSL endpoint
>
>
> Key: THRIFT-3118
> URL: https://issues.apache.org/jira/browse/THRIFT-3118
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
>Affects Versions: 0.9
>Reporter: Jean-Baptiste Quenot
>Assignee: James E. King, III
>
> When using the Python Thrift HTTP client, a MemoryError is raised by the
> underlying socket when using SSL:
> {noformat}
> File
> "/path/to/local/lib/python2.7/site-packages/thrift/transport/THttpClient.py",
> line 116, in read
> return self.__http.file.read(sz)
> File "/usr/lib/python2.7/socket.py", line 380, in read
> data = self._sock.recv(left)
> File "/usr/lib/python2.7/ssl.py", line 241, in recv
> return self.read(buflen)
> File "/usr/lib/python2.7/ssl.py", line 160, in read
> return self._sslobj.read(len)
> MemoryError
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (THRIFT-3263) PHP jsonSerialize() should cast scalar types
[ https://issues.apache.org/jira/browse/THRIFT-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957373#comment-15957373 ] ASF GitHub Bot commented on THRIFT-3263: Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/560 > PHP jsonSerialize() should cast scalar types > > > Key: THRIFT-3263 > URL: https://issues.apache.org/jira/browse/THRIFT-3263 > Project: Thrift > Issue Type: Improvement > Components: PHP - Compiler >Affects Versions: 0.9.2 >Reporter: Stig Bakken >Assignee: Stig Bakken >Priority: Minor > Fix For: 0.10.0 > > > In PHP, values from databases and such are usually always strings, so it is > useful to cast values during JSON serialization to maintain the Thrift > schema's types. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift pull request #617: fix PHP TCompactProtocol Int64 trans error when nu...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/617 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #467: Work around [THRIFT-3118] MemoryError when using a...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/467 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #560: THRIFT-3263: PHP Compiler always casts scalar type...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/560 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3251) Add http transport for server to Go lib
[ https://issues.apache.org/jira/browse/THRIFT-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957372#comment-15957372 ] ASF GitHub Bot commented on THRIFT-3251: Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/557 > Add http transport for server to Go lib > --- > > Key: THRIFT-3251 > URL: https://issues.apache.org/jira/browse/THRIFT-3251 > Project: Thrift > Issue Type: Sub-task > Components: Go - Library >Affects Versions: 0.9.2 >Reporter: Dylan Wen >Assignee: Claudemiro Alves Feitosa Neto >Priority: Minor > Fix For: 0.10.0 > > > There is a lack of http transport for server in Go lib, so the server could > not communicate with client running http transport, e.g., client runs the Go > code lib/go/thrift/http_client.go, or C++ async client which usually runs > along with libevent and http transport. > Some code similar to lib/cpp/src/thrift/transport/THttpTransport.cpp needs to > be added to Go lib, in order to run a server written in Go to communicate > with these http transport client. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift pull request #549: Fix path to generated dirs for python examples in ...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/549 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #557: Thrift 3251 Add http transport for server to Go li...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/557 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-4156) Using boost spirit instead of lex and yacc
[ https://issues.apache.org/jira/browse/THRIFT-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957357#comment-15957357 ] Mike Gresens commented on THRIFT-4156: -- Did some work with documentation comments: No problems found. Still no semantic actions in parser. Was able to generate doxygen comments into the code. Doxygen was able to generate html documentation from generated code. So I am happy with that. Did I overlook some show-stoppers? > Using boost spirit instead of lex and yacc > -- > > Key: THRIFT-4156 > URL: https://issues.apache.org/jira/browse/THRIFT-4156 > Project: Thrift > Issue Type: Improvement > Components: Compiler (General) >Reporter: Mike Gresens > Attachments: ast.hpp, doxygen_enum.png, doxygen_service.png, > doxygen_struct.png, MyService.hpp, MyService.thrift, parser.cpp > > > As a developer I want to use boost spirit to get rid of lex and yacc. > This kicks dependency to lex, flex, yacc, bison or what ever. > This makes building easier, because only c++ code must be compiled. > All grammar is inside the code - all c++. No need to learn ll and yy. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (THRIFT-4156) Using boost spirit instead of lex and yacc
[ https://issues.apache.org/jira/browse/THRIFT-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Gresens updated THRIFT-4156: - Attachment: doxygen_enum.png doxygen_service.png doxygen_struct.png > Using boost spirit instead of lex and yacc > -- > > Key: THRIFT-4156 > URL: https://issues.apache.org/jira/browse/THRIFT-4156 > Project: Thrift > Issue Type: Improvement > Components: Compiler (General) >Reporter: Mike Gresens > Attachments: ast.hpp, doxygen_enum.png, doxygen_service.png, > doxygen_struct.png, MyService.hpp, MyService.thrift, parser.cpp > > > As a developer I want to use boost spirit to get rid of lex and yacc. > This kicks dependency to lex, flex, yacc, bison or what ever. > This makes building easier, because only c++ code must be compiled. > All grammar is inside the code - all c++. No need to learn ll and yy. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (THRIFT-4156) Using boost spirit instead of lex and yacc
[ https://issues.apache.org/jira/browse/THRIFT-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Gresens updated THRIFT-4156: - Attachment: MyService.hpp > Using boost spirit instead of lex and yacc > -- > > Key: THRIFT-4156 > URL: https://issues.apache.org/jira/browse/THRIFT-4156 > Project: Thrift > Issue Type: Improvement > Components: Compiler (General) >Reporter: Mike Gresens > Attachments: ast.hpp, MyService.hpp, MyService.thrift, parser.cpp > > > As a developer I want to use boost spirit to get rid of lex and yacc. > This kicks dependency to lex, flex, yacc, bison or what ever. > This makes building easier, because only c++ code must be compiled. > All grammar is inside the code - all c++. No need to learn ll and yy. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (THRIFT-4156) Using boost spirit instead of lex and yacc
[ https://issues.apache.org/jira/browse/THRIFT-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Gresens updated THRIFT-4156: - Attachment: MyService.thrift > Using boost spirit instead of lex and yacc > -- > > Key: THRIFT-4156 > URL: https://issues.apache.org/jira/browse/THRIFT-4156 > Project: Thrift > Issue Type: Improvement > Components: Compiler (General) >Reporter: Mike Gresens > Attachments: ast.hpp, MyService.hpp, MyService.thrift, parser.cpp > > > As a developer I want to use boost spirit to get rid of lex and yacc. > This kicks dependency to lex, flex, yacc, bison or what ever. > This makes building easier, because only c++ code must be compiled. > All grammar is inside the code - all c++. No need to learn ll and yy. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-3118) Python MemoryError in THttpClient when using an SSL endpoint
[
https://issues.apache.org/jira/browse/THRIFT-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957350#comment-15957350
]
James E. King, III commented on THRIFT-3118:
The code in the py implementation has changed significantly since this issue
was created, and may no longer be relevant. file.read is no longer used, so I
would suggest this issue is not reproducible any longer. Thoughts? If so, the
pull request can be closed.
> Python MemoryError in THttpClient when using an SSL endpoint
>
>
> Key: THRIFT-3118
> URL: https://issues.apache.org/jira/browse/THRIFT-3118
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
>Affects Versions: 0.9
>Reporter: Jean-Baptiste Quenot
>
> When using the Python Thrift HTTP client, a MemoryError is raised by the
> underlying socket when using SSL:
> {noformat}
> File
> "/path/to/local/lib/python2.7/site-packages/thrift/transport/THttpClient.py",
> line 116, in read
> return self.__http.file.read(sz)
> File "/usr/lib/python2.7/socket.py", line 380, in read
> data = self._sock.recv(left)
> File "/usr/lib/python2.7/ssl.py", line 241, in recv
> return self.read(buflen)
> File "/usr/lib/python2.7/ssl.py", line 160, in read
> return self._sslobj.read(len)
> MemoryError
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Assigned] (THRIFT-3118) Python MemoryError in THttpClient when using an SSL endpoint
[
https://issues.apache.org/jira/browse/THRIFT-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III reassigned THRIFT-3118:
--
Assignee: James E. King, III
> Python MemoryError in THttpClient when using an SSL endpoint
>
>
> Key: THRIFT-3118
> URL: https://issues.apache.org/jira/browse/THRIFT-3118
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
>Affects Versions: 0.9
>Reporter: Jean-Baptiste Quenot
>Assignee: James E. King, III
>
> When using the Python Thrift HTTP client, a MemoryError is raised by the
> underlying socket when using SSL:
> {noformat}
> File
> "/path/to/local/lib/python2.7/site-packages/thrift/transport/THttpClient.py",
> line 116, in read
> return self.__http.file.read(sz)
> File "/usr/lib/python2.7/socket.py", line 380, in read
> data = self._sock.recv(left)
> File "/usr/lib/python2.7/ssl.py", line 241, in recv
> return self.read(buflen)
> File "/usr/lib/python2.7/ssl.py", line 160, in read
> return self._sslobj.read(len)
> MemoryError
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (THRIFT-4156) Using boost spirit instead of lex and yacc
[ https://issues.apache.org/jira/browse/THRIFT-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Gresens updated THRIFT-4156: - Attachment: parser.cpp > Using boost spirit instead of lex and yacc > -- > > Key: THRIFT-4156 > URL: https://issues.apache.org/jira/browse/THRIFT-4156 > Project: Thrift > Issue Type: Improvement > Components: Compiler (General) >Reporter: Mike Gresens > Attachments: ast.hpp, parser.cpp > > > As a developer I want to use boost spirit to get rid of lex and yacc. > This kicks dependency to lex, flex, yacc, bison or what ever. > This makes building easier, because only c++ code must be compiled. > All grammar is inside the code - all c++. No need to learn ll and yy. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (THRIFT-4156) Using boost spirit instead of lex and yacc
[ https://issues.apache.org/jira/browse/THRIFT-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Gresens updated THRIFT-4156: - Attachment: ast.hpp > Using boost spirit instead of lex and yacc > -- > > Key: THRIFT-4156 > URL: https://issues.apache.org/jira/browse/THRIFT-4156 > Project: Thrift > Issue Type: Improvement > Components: Compiler (General) >Reporter: Mike Gresens > Attachments: ast.hpp > > > As a developer I want to use boost spirit to get rid of lex and yacc. > This kicks dependency to lex, flex, yacc, bison or what ever. > This makes building easier, because only c++ code must be compiled. > All grammar is inside the code - all c++. No need to learn ll and yy. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (THRIFT-4156) Using boost spirit instead of lex and yacc
[ https://issues.apache.org/jira/browse/THRIFT-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Gresens updated THRIFT-4156: - Attachment: (was: ast.hpp) > Using boost spirit instead of lex and yacc > -- > > Key: THRIFT-4156 > URL: https://issues.apache.org/jira/browse/THRIFT-4156 > Project: Thrift > Issue Type: Improvement > Components: Compiler (General) >Reporter: Mike Gresens > > As a developer I want to use boost spirit to get rid of lex and yacc. > This kicks dependency to lex, flex, yacc, bison or what ever. > This makes building easier, because only c++ code must be compiled. > All grammar is inside the code - all c++. No need to learn ll and yy. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (THRIFT-4156) Using boost spirit instead of lex and yacc
[ https://issues.apache.org/jira/browse/THRIFT-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Gresens updated THRIFT-4156: - Attachment: (was: parser.cpp) > Using boost spirit instead of lex and yacc > -- > > Key: THRIFT-4156 > URL: https://issues.apache.org/jira/browse/THRIFT-4156 > Project: Thrift > Issue Type: Improvement > Components: Compiler (General) >Reporter: Mike Gresens > > As a developer I want to use boost spirit to get rid of lex and yacc. > This kicks dependency to lex, flex, yacc, bison or what ever. > This makes building easier, because only c++ code must be compiled. > All grammar is inside the code - all c++. No need to learn ll and yy. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-3263) PHP jsonSerialize() should cast scalar types
[ https://issues.apache.org/jira/browse/THRIFT-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957338#comment-15957338 ] ASF GitHub Bot commented on THRIFT-3263: Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/560 @jfarrell this can be closed. It was merged. > PHP jsonSerialize() should cast scalar types > > > Key: THRIFT-3263 > URL: https://issues.apache.org/jira/browse/THRIFT-3263 > Project: Thrift > Issue Type: Improvement > Components: PHP - Compiler >Affects Versions: 0.9.2 >Reporter: Stig Bakken >Assignee: Stig Bakken >Priority: Minor > Fix For: 0.10.0 > > > In PHP, values from databases and such are usually always strings, so it is > useful to cast values during JSON serialization to maintain the Thrift > schema's types. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift issue #560: THRIFT-3263: PHP Compiler always casts scalar types in js...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/560 @jfarrell this can be closed. It was merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #1239: Fix wrong numActiveProcessors_ when failing to notify an...
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1239 Please open an Apache Jira ticket for each pull request. https://thrift.apache.org/docs/HowToContribute --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #639: Implements ssl sockets on c_glib
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/639 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-2668) TestSuite: detailed result on passed tests by feature
[
https://issues.apache.org/jira/browse/THRIFT-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957273#comment-15957273
]
ASF GitHub Bot commented on THRIFT-2668:
Github user jfarrell closed the pull request at:
https://github.com/apache/thrift/pull/194
> TestSuite: detailed result on passed tests by feature
> -
>
> Key: THRIFT-2668
> URL: https://issues.apache.org/jira/browse/THRIFT-2668
> Project: Thrift
> Issue Type: Sub-task
> Components: Test Suite
>Reporter: Roger Meier
>Assignee: Roger Meier
> Fix For: 0.10.0
>
>
> return code shall be 0 on success or an integer in the range 1 - 255 on error
> as mentioned http://thrift.apache.org/test
> We can define bit fields for the byte we pass as return code:
> {noformat}
> #define TEST_BASETYPES 1 // 0001
> #define TEST_STRUCTS 2 // 0010
> #define TEST_CONTAINERS4 // 0100
> #define TEST_EXCEPTIONS8 // 1000
> #define TEST_NOTUSED 240 //
> {noformat}
> this will help us to see which tests passed
> a TestClient will do this:
> {noformat}
> ret = 255 - TEST_NOTUSED
> if testBaseTypes == passed
> ret = ret - TEST_BASETYPES
> if testStructs == passed
> ret = ret - TEST_STRUCTS
> if testContainers == passed
> ret = ret - TEST_CONTAINERS
> if testExceptions == passed
> ret = ret - TEST_EXCEPTIONS
> return ret
> {noformat}
> test suite reporting can take care on the individual test status
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] thrift pull request #194: THRIFT-2668 TestSuite: detailed result on passed t...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/194 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-2796) Testcase for THRIFT-2793
[ https://issues.apache.org/jira/browse/THRIFT-2796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957269#comment-15957269 ] ASF GitHub Bot commented on THRIFT-2796: Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/278 > Testcase for THRIFT-2793 > > > Key: THRIFT-2796 > URL: https://issues.apache.org/jira/browse/THRIFT-2796 > Project: Thrift > Issue Type: Test > Components: Go - Compiler >Reporter: Jens Geyer > > Add test for THRIFT-2793 Go compiler produces uncompilable code -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-2721) generate more idiomatic erlang code
[ https://issues.apache.org/jira/browse/THRIFT-2721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957272#comment-15957272 ] ASF GitHub Bot commented on THRIFT-2721: Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/226 > generate more idiomatic erlang code > --- > > Key: THRIFT-2721 > URL: https://issues.apache.org/jira/browse/THRIFT-2721 > Project: Thrift > Issue Type: Improvement > Components: Erlang - Compiler >Reporter: alisdair sullivan >Assignee: alisdair sullivan >Priority: Minor > Labels: erlang > > reduces the amount of code generated by the erlang compiler and increases > readability of resulting modules. also adds some more comprehensive tests for > the compiler -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift pull request #226: THRIFT-2721: reduce complexity of generated erlang...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/226 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-2940) Allow installing Thrift from git as NPM module by providing package.json in top level directory
[
https://issues.apache.org/jira/browse/THRIFT-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957267#comment-15957267
]
ASF GitHub Bot commented on THRIFT-2940:
Github user jfarrell closed the pull request at:
https://github.com/apache/thrift/pull/354
> Allow installing Thrift from git as NPM module by providing package.json in
> top level directory
> ---
>
> Key: THRIFT-2940
> URL: https://issues.apache.org/jira/browse/THRIFT-2940
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
>Reporter: Radoslaw Gruchalski
>Assignee: Roger Meier
> Fix For: 0.9.3
>
>
> Allow installing thirft from git as NPM module by providing package.json in
> top level directory. Currently, result is similar to:
> {noformat}
> drone:gossiperl-client-js rad$ npm install
> npm WARN excluding symbolic link tutorial/erl/client.sh -> server.sh
> npm ERR! Error: ENOENT, open
> '/var/folders/gd/jkx3kmg53gj85lwjslf79n6mgn/T/npm-36445-mmwd9VRJ/1421011402511-0.04021586640737951/package/package.json'
> npm ERR! If you need help, you may report this log at:
> npm ERR!
> npm ERR! or email it to:
> npm ERR!
> npm ERR! System Darwin 14.0.0
> npm ERR! command "node" "/usr/local/bin/npm" "install"
> npm ERR! cwd /Users/rad/dev/my/gossiperl-client-js
> npm ERR! node -v v0.10.22
> npm ERR! npm -v 1.3.14
> npm ERR! path
> /var/folders/gd/jkx3kmg53gj85lwjslf79n6mgn/T/npm-36445-mmwd9VRJ/1421011402511-0.04021586640737951/package/package.json
> npm ERR! code ENOENT
> npm ERR! errno 34
> npm ERR!
> npm ERR! Additional logging details can be found in:
> npm ERR! /Users/rad/dev/my/gossiperl-client-js/npm-debug.log
> npm ERR! not ok code 0
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (THRIFT-2983) Replace use of deprecated -[NSData getBytes:] in -[TNSFileHandleTransport readAll:offset:length:]
[ https://issues.apache.org/jira/browse/THRIFT-2983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957263#comment-15957263 ] ASF GitHub Bot commented on THRIFT-2983: Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/386 > Replace use of deprecated -[NSData getBytes:] in -[TNSFileHandleTransport > readAll:offset:length:] > -- > > Key: THRIFT-2983 > URL: https://issues.apache.org/jira/browse/THRIFT-2983 > Project: Thrift > Issue Type: Bug > Components: Cocoa - Library >Affects Versions: 0.9.2 >Reporter: Jeremy W. Sherman >Assignee: James E. King, III > Fix For: 0.10.0 > > Original Estimate: 1h > Remaining Estimate: 1h > > It looks like the access is actually safe; the code just needs to provide the > known length to -getBytes:length: and this will be fixed. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-3088) TThreadPoolServer with Sasl auth may leak CLOSE_WAIT socket
[ https://issues.apache.org/jira/browse/THRIFT-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957262#comment-15957262 ] ASF GitHub Bot commented on THRIFT-3088: Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/432 > TThreadPoolServer with Sasl auth may leak CLOSE_WAIT socket > --- > > Key: THRIFT-3088 > URL: https://issues.apache.org/jira/browse/THRIFT-3088 > Project: Thrift > Issue Type: Bug > Components: Java - Library >Affects Versions: 0.9 >Reporter: Winger Pun > Fix For: 0.9.3 > > > Start TThreadPoolServer to server with TSaslServerTransport.Factory as > transportFactory. While using nc to test the specified port whether > reachable, it will leak CLOSE_WAIT socket.That's because nc will close socket > at once while successful connect TThreadPoolServer, but the server still try > using sasl protocol to build an inputTransport which of course failed at > once. However inputTransport is null which makes it can't close socket > properly which lead to CLOSE_WAIT socket. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift pull request #278: THRIFT-2796: Added testcase for THRIFT-2793. Needs...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/278 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #354: THRIFT-2940: Package json
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/354 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-2899) Enum values should be prefixed with the Cocoa namespace
[ https://issues.apache.org/jira/browse/THRIFT-2899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957268#comment-15957268 ] ASF GitHub Bot commented on THRIFT-2899: Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/328 > Enum values should be prefixed with the Cocoa namespace > --- > > Key: THRIFT-2899 > URL: https://issues.apache.org/jira/browse/THRIFT-2899 > Project: Thrift > Issue Type: Improvement > Components: Cocoa - Compiler >Reporter: Jim Speth >Assignee: James E. King, III >Priority: Minor > Fix For: 0.10.0 > > > Enum types are prefixed with the Cocoa namespace, but enum values are not. > This means the values could potentially collide. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-2941) Convert processor to use switch instead of map
[ https://issues.apache.org/jira/browse/THRIFT-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957264#comment-15957264 ] ASF GitHub Bot commented on THRIFT-2941: Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/356 > Convert processor to use switch instead of map > -- > > Key: THRIFT-2941 > URL: https://issues.apache.org/jira/browse/THRIFT-2941 > Project: Thrift > Issue Type: Improvement > Components: Go - Compiler >Reporter: Craig Peterson > > We are using a special protocol extension to insert auxiliary tracking data > into our method names on certain services. Our implementation works by > creating a special Processor Wrapper and creating a new Handler/Processor for > each request. > The current implementation of the generated handler makes this rather > expensive, as a new map is created each time you create a processor. I > propose reworking the generated processor to use a switch structure for > dispatch rather than the current map-based solution. > A summary of the differences before and after for a small example can be > found in this gist: > https://gist.github.com/captncraig/e2bc7e7d1a0cb2c8127b#file-foo-thrift > I ran benchmarks and the baseline performance (both in time and allocations) > of the processor seem almost exactly the same after my changes. My > modified/wrapped processor however is able to perform much faster and with > less memory with these changes. > No application code should need to be changed unless it was interacting with > the exported processor map functions (which I suspect should have been > private all along). > Working on a patch right now. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift pull request #328: THRIFT-2899: Prefix enum values with the Cocoa nam...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/328 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #356: THRIFT-2941
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/356 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #386: THRIFT-2983: replaces deprecated -[NSData getBytes...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/386 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #475: THRIFT-3121 Librt does not exist on OSX
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/475 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #432: [THRIFT-3088] TThreadPoolServer with Sasl auth may...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/432 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3121) Librt does not exist on OS X
[ https://issues.apache.org/jira/browse/THRIFT-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957260#comment-15957260 ] ASF GitHub Bot commented on THRIFT-3121: Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/475 > Librt does not exist on OS X > > > Key: THRIFT-3121 > URL: https://issues.apache.org/jira/browse/THRIFT-3121 > Project: Thrift > Issue Type: Bug > Components: Test Suite > Environment: OSX >Reporter: Thomas Bartelmess > Fix For: 0.9.3 > > > THRIFT-2441 introduced a dependency on librt which does not exist on OS X -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift pull request #1239: Fix wrong numActiveProcessors_ when failing to no...
GitHub user xiaosuo opened a pull request: https://github.com/apache/thrift/pull/1239 Fix wrong numActiveProcessors_ when failing to notify any IO thread We should decrease numActiveProcessors_ when failing to notify any IO thread. You can merge this pull request into a Git repository by running: $ git pull https://github.com/xiaosuo/thrift active_processors Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1239.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1239 commit 4597f1d2230636201d2445c4621949dcc1e688e0 Author: Changli Gao Date: 2017-04-05T16:42:01Z Fix wrong numActiveProcessors_ when failing to notify any IO thread We should decrease numActiveProcessors_ when failing to notify any IO thread. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift issue #639: Implements ssl sockets on c_glib
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/639 @jfarrell you probably meant to close this, but it was already closed, and got reopened. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3154) tutorial/py.tornado throw EOF exception
[ https://issues.apache.org/jira/browse/THRIFT-3154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957055#comment-15957055 ] ASF GitHub Bot commented on THRIFT-3154: Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/501 > tutorial/py.tornado throw EOF exception > --- > > Key: THRIFT-3154 > URL: https://issues.apache.org/jira/browse/THRIFT-3154 > Project: Thrift > Issue Type: Bug > Components: Python - Compiler >Affects Versions: 0.9.2 > Environment: ubuntu 14.04 >Reporter: K K > Fix For: 0.10.0 > > > make check also fail at py.tornado -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-3204) SimpleServer process loop missed handle some error
[ https://issues.apache.org/jira/browse/THRIFT-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957052#comment-15957052 ] ASF GitHub Bot commented on THRIFT-3204: Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/529 > SimpleServer process loop missed handle some error > -- > > Key: THRIFT-3204 > URL: https://issues.apache.org/jira/browse/THRIFT-3204 > Project: Thrift > Issue Type: Bug > Components: Go - Library >Affects Versions: 0.9.2 >Reporter: Jing Wang >Assignee: Jing Wang > Labels: patch > > SimpleServer do not handle all errors returned by processor. > When a error returned by processor.Process methods In SimpleServer's > processRequests, program will omit this error and log nothing to the > programmer if this error is not thrift.TTransportException type. > If a Protocol error happens, the server will close the client connection and > log nothing, > This bug is cause by a wrong "else if" condition. In the if esle condition, > the inside variable "err" will cover the scope of outside "err", and it will > always be "nil", the "else if" condition will never reached -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-3112) [Java] AsyncMethodCallback should be typed in generated AsyncIface
[
https://issues.apache.org/jira/browse/THRIFT-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957056#comment-15957056
]
ASF GitHub Bot commented on THRIFT-3112:
Github user jfarrell closed the pull request at:
https://github.com/apache/thrift/pull/500
> [Java] AsyncMethodCallback should be typed in generated AsyncIface
> --
>
> Key: THRIFT-3112
> URL: https://issues.apache.org/jira/browse/THRIFT-3112
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Compiler, Java - Library
>Affects Versions: 0.9.2, 0.9.3
>Reporter: Sergei Egorov
>Assignee: John Sirois
> Fix For: 0.10.0
>
>
> AsyncMethodCallback is generic, but current Java code generator is not adding
> type info to it, and instead of:
> {code:java}
> public interface AsyncIface {
> public void ping(org.apache.thrift.async.AsyncMethodCallback
> resultHandler) throws org.apache.thrift.TException;
> }
> {code}
> we have:
> {code:java}
> public interface AsyncIface {
> public void ping(org.apache.thrift.async.AsyncMethodCallback
> resultHandler) throws org.apache.thrift.TException;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (THRIFT-3288) c_glib: Build unit tests with all warnings enabled, no warnings generated
[
https://issues.apache.org/jira/browse/THRIFT-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957051#comment-15957051
]
ASF GitHub Bot commented on THRIFT-3288:
Github user jfarrell closed the pull request at:
https://github.com/apache/thrift/pull/577
> c_glib: Build unit tests with all warnings enabled, no warnings generated
> -
>
> Key: THRIFT-3288
> URL: https://issues.apache.org/jira/browse/THRIFT-3288
> Project: Thrift
> Issue Type: Improvement
> Components: C glib - Library
>Affects Versions: 0.9.3
> Environment: Cloud9 (Ubuntu 14.04.2 LTS; gcc 4.8.2)
>Reporter: Simon South
>Assignee: Simon South
>Priority: Minor
> Labels: c_glib, unit-test
> Fix For: 0.9.3
>
>
> For correctness and to help with tracking down bugs, the C (GLib) unit tests
> (in {{lib/c_glib/test}}) should build with the same compiler-warning options
> enabled for the C++ library's tests ({{-Wall -Wextra -pedantic}}) and without
> any warnings generated.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] thrift pull request #500: THRIFT-3112: Typed AsyncMethodCallback with return...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/500 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #529: [THRIFT-3204] SimpleServer processRequests method ...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/529 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #501: THRIFT-3154: tornado tutorial fail to work
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/501 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #577: THRIFT-3288 c glib build unit tests with all warni...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/577 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #639: Implements ssl sockets on c_glib
GitHub user gadLinux reopened a pull request: https://github.com/apache/thrift/pull/639 Implements ssl sockets on c_glib Adds dependencies to gobject at compile time because it needs it. Server side is not complete so some tests are failing. Looking to fix them all. I moved openssl check outside of the cpp compilation because now it's needed for at least two subprojects at lib. -avoid-version has to be reviewed as this is only for android, and must be enabled only when compiling with android-arm or android-* You can merge this pull request into a Git repository by running: $ git pull https://github.com/gadLinux/thrift thrift-1016 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/639.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #639 commit 3ad451863e67374829cc99e94fd7b5473effdc3b Author: Gonzalo Aguilar Delgado Date: 2015-10-09T02:24:47Z Implements ssl sockets on c_glib. Adds dependencies to gobject at compile time because it needs it. commit 782b3767b35d6e564b9a49076ae38b8abdb15bfc Author: Gonzalo Aguilar Delgado Date: 2015-10-09T02:37:39Z Add missing files. Fix GOBJECT missing in build. commit 3ce56a99313bab6418c9ac40cbbc380183d6a360 Author: Gonzalo Aguilar Delgado Date: 2015-11-11T14:08:44Z Add partially supported certificate pining. It fails the verify result. commit 0e0f534c68e52464946eeab190db5522691ad36b Author: Gonzalo Aguilar Delgado Date: 2015-11-11T14:14:03Z Use functionality provided by library instead of hacking in --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3380) nodejs: 0.9.2 -> 0.9.3 upgrade breaks Protocol and Transport requires
[
https://issues.apache.org/jira/browse/THRIFT-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957049#comment-15957049
]
ASF GitHub Bot commented on THRIFT-3380:
Github user jfarrell closed the pull request at:
https://github.com/apache/thrift/pull/651
> nodejs: 0.9.2 -> 0.9.3 upgrade breaks Protocol and Transport requires
> -
>
> Key: THRIFT-3380
> URL: https://issues.apache.org/jira/browse/THRIFT-3380
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Library
>Affects Versions: 0.9.3
>Reporter: Matt Willer
>Assignee: Roger Meier
>Priority: Critical
> Fix For: 0.10.0
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> Node.js projects that depend on Thrift and need to use a specific transport
> or protocol must require them in separately, like this:
> {code}
> var thrift = require('thrift'),
> ThriftTransports = require('thrift/lib/thrift/transport');
> {code}
> The new version (0.9.3) changed that directory structure of the thrift module
> so that the transport file is now located at
> thrift/lib/nodejs/lib/thrift/transport.js, which breaks any application that
> was requiring it at the old path. This type of breaking change is
> inappropriate for a patch version, and should be fixed immediately.
> The directory structure change also has the undesirable side effect of
> including every single language implementation of thrift in the Node.js
> module, bloating the size of the module with unnecessary files.
> Long-term, the right fix for this is to export useful parts of the library
> (e.g. transport and protocol constructors) from the main file, but since this
> is a patch version the immediate fix should be to maintain existing behavior.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] thrift pull request #651: THRIFT-3380 nodejs Fix broken transport and protoc...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/651 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3385) warning: format ‘%lu’ expects ‘long unsigned int’, but has type ‘std::basic_string::size_type {aka unsigned int}
[
https://issues.apache.org/jira/browse/THRIFT-3385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957048#comment-15957048
]
ASF GitHub Bot commented on THRIFT-3385:
Github user jfarrell closed the pull request at:
https://github.com/apache/thrift/pull/688
> warning: format ‘%lu’ expects ‘long unsigned int’, but has type
> ‘std::basic_string::size_type {aka unsigned int}
> --
>
> Key: THRIFT-3385
> URL: https://issues.apache.org/jira/browse/THRIFT-3385
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
>Reporter: Jens Geyer
>Assignee: Jens Geyer
>Priority: Minor
> Fix For: 0.10.0
>
> Attachments:
> THRIFT-3385-warning-format-lu-expects-long-unsigned-.patch
>
>
> {{make check}} for C++ produces the following:
> {code}
> src/TestClient.cpp: In function ‘int main(int, char**)’:
> src/TestClient.cpp:486:58: warning: format ‘%lu’ expects argument of type
> ‘long unsigned int’, but argument 2 has type
> ‘std::basic_string::size_type {aka unsigned int}’ [-Wformat=]
> {code}
> ___
> EDIT: sorry for the noise
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] thrift pull request #688: THRIFT-3385 warning: format ‘%lu’ expects ‘l...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/688 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #991: dependency version constraints for haskell
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/991 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (THRIFT-3474) Docker: thrift-compiler
[ https://issues.apache.org/jira/browse/THRIFT-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957042#comment-15957042 ] ASF GitHub Bot commented on THRIFT-3474: Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/733 > Docker: thrift-compiler > --- > > Key: THRIFT-3474 > URL: https://issues.apache.org/jira/browse/THRIFT-3474 > Project: Thrift > Issue Type: Bug > Components: Compiler (General), Deployment >Reporter: Roger Meier >Assignee: Roger Meier > Fix For: 0.10.0 > > > I made a Dockerfile and .dockerignore for this -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-3828) cmake fails when Boost_INCLUDE_DIRS (and other variables passed to include_directories()) is empty
[ https://issues.apache.org/jira/browse/THRIFT-3828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957043#comment-15957043 ] ASF GitHub Bot commented on THRIFT-3828: Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/1082 > cmake fails when Boost_INCLUDE_DIRS (and other variables passed to > include_directories()) is empty > --- > > Key: THRIFT-3828 > URL: https://issues.apache.org/jira/browse/THRIFT-3828 > Project: Thrift > Issue Type: Bug > Components: Build Process >Reporter: Cody Schafer >Assignee: James E. King, III >Priority: Minor > Fix For: 0.10.0 > > Attachments: > 0001-cmake-avoid-use-of-both-quoted-paths-and-SYSTEM-with.patch > > > This is due to the current quoting of those variables when passed to > `include_directories()`. These variables may (and soon will, see below) be > empty in the case where the include directory is a system include path that > is implicitly included. > I ran into this issue when trying to build thrift using gcc-6. gcc-6 doesn't > work with includes that are part of the platform/system include path (see > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129 for one mention). To > resolve this, `FindBoost.cmake` will be adjusted to avoid adding those types > of directories to Boost_INCLUDE_DIRS. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift pull request #1082: THRIFT-3828 In cmake avoid use of both quoted pat...
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/1082 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] thrift pull request #733: THRIFT-3474 Docker: thrift-compiler
Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/733 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Closed] (THRIFT-4153) Add CI build jobs that do nothing except rebuild the docker image(s) if necessary to avoid timeouts
[ https://issues.apache.org/jira/browse/THRIFT-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III closed THRIFT-4153. -- > Add CI build jobs that do nothing except rebuild the docker image(s) if > necessary to avoid timeouts > --- > > Key: THRIFT-4153 > URL: https://issues.apache.org/jira/browse/THRIFT-4153 > Project: Thrift > Issue Type: Improvement > Components: Build Process >Affects Versions: 0.10.0 > Environment: Travis CI >Reporter: James E. King, III >Assignee: James E. King, III >Priority: Critical > > In the Travis CI environment if someone modifies a docker image, the build > system has to rebuild the image. This is expensive and takes a while, and > usually causes one of the first five build jobs to fail. In addition the > image is rebuilt multiple times. > The improvement here is to have a set of docker image verificaion/rebuild > jobs that run before the other build jobs. Each one will simply load up the > docker image, see if it needs to be rebuilt, and rebuilt it. If it is > possible to express dependencies between Travis CI jobs, then we can add > dependencies so that once the docker image has been rebuilt, certain jobs can > start running. > This is typically seen when someone needs to rev the docker image. Their > pull request causes docker images to be rebuilt, and it can timeout a build > job. Then their build fails, and the build job that queues behind it will > have to rebuild the docker image back to what's based on master, so it will > probably timeout too. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (THRIFT-4153) Add CI build jobs that do nothing except rebuild the docker image(s) if necessary to avoid timeouts
[ https://issues.apache.org/jira/browse/THRIFT-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4153. Resolution: Won't Fix Travis has no facilities to put in a barrier or initialization phase job like this, so I am closing this out as won't fix. > Add CI build jobs that do nothing except rebuild the docker image(s) if > necessary to avoid timeouts > --- > > Key: THRIFT-4153 > URL: https://issues.apache.org/jira/browse/THRIFT-4153 > Project: Thrift > Issue Type: Improvement > Components: Build Process >Affects Versions: 0.10.0 > Environment: Travis CI >Reporter: James E. King, III >Assignee: James E. King, III >Priority: Critical > > In the Travis CI environment if someone modifies a docker image, the build > system has to rebuild the image. This is expensive and takes a while, and > usually causes one of the first five build jobs to fail. In addition the > image is rebuilt multiple times. > The improvement here is to have a set of docker image verificaion/rebuild > jobs that run before the other build jobs. Each one will simply load up the > docker image, see if it needs to be rebuilt, and rebuilt it. If it is > possible to express dependencies between Travis CI jobs, then we can add > dependencies so that once the docker image has been rebuilt, certain jobs can > start running. > This is typically seen when someone needs to rev the docker image. Their > pull request causes docker images to be rebuilt, and it can timeout a build > job. Then their build fails, and the build job that queues behind it will > have to rebuild the docker image back to what's based on master, so it will > probably timeout too. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Reopened] (THRIFT-4146) Appveyor builds are being triggered by apache master pushes
[ https://issues.apache.org/jira/browse/THRIFT-4146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reopened THRIFT-4146: This is still happening: https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/build/1.0.0-dev.1166 > Appveyor builds are being triggered by apache master pushes > --- > > Key: THRIFT-4146 > URL: https://issues.apache.org/jira/browse/THRIFT-4146 > Project: Thrift > Issue Type: Bug > Components: Build Process >Affects Versions: 0.10.0 > Environment: Appveyor >Reporter: James E. King, III >Assignee: Jake Farrell >Priority: Minor > Fix For: 0.11.0 > > > When I commit and push something into the apache git repository for thrift, > it synchronizes to github and that seems to add an Appveyor job to build it. > Appveyor auto-build triggering needs to be configured to ignore updates to > "master". > This is an example: > https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/build/1.0.0-dev.1121 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (THRIFT-4168) Travis CI builds are being triggered by apache master pushes
James E. King, III created THRIFT-4168: -- Summary: Travis CI builds are being triggered by apache master pushes Key: THRIFT-4168 URL: https://issues.apache.org/jira/browse/THRIFT-4168 Project: Thrift Issue Type: Bug Components: Build Process Affects Versions: 0.10.0 Environment: Appveyor Reporter: James E. King, III Assignee: Jake Farrell Priority: Minor Fix For: 0.11.0 When I commit and push something into the apache git repository for thrift, it synchronizes to github and that seems to add an Appveyor job to build it. Appveyor auto-build triggering needs to be configured to ignore updates to "master". This is an example: https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/build/1.0.0-dev.1121 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (THRIFT-4168) Travis CI builds are being triggered by apache master pushes
[ https://issues.apache.org/jira/browse/THRIFT-4168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4168: --- Description: When I commit and push something into the apache git repository for thrift, it synchronizes to github and that seems to add an Travis CI job to build it. This is an example: https://travis-ci.org/apache/thrift/builds/218868926 was: When I commit and push something into the apache git repository for thrift, it synchronizes to github and that seems to add an Appveyor job to build it. Appveyor auto-build triggering needs to be configured to ignore updates to "master". This is an example: https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/build/1.0.0-dev.1121 > Travis CI builds are being triggered by apache master pushes > > > Key: THRIFT-4168 > URL: https://issues.apache.org/jira/browse/THRIFT-4168 > Project: Thrift > Issue Type: Bug > Components: Build Process >Affects Versions: 0.11.0 > Environment: Appveyor >Reporter: James E. King, III >Assignee: Jake Farrell >Priority: Minor > Fix For: 0.11.0 > > > When I commit and push something into the apache git repository for thrift, > it synchronizes to github and that seems to add an Travis CI job to build it. > This is an example: > https://travis-ci.org/apache/thrift/builds/218868926 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (THRIFT-4168) Travis CI builds are being triggered by apache master pushes
[ https://issues.apache.org/jira/browse/THRIFT-4168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4168: --- Affects Version/s: (was: 0.10.0) 0.11.0 > Travis CI builds are being triggered by apache master pushes > > > Key: THRIFT-4168 > URL: https://issues.apache.org/jira/browse/THRIFT-4168 > Project: Thrift > Issue Type: Bug > Components: Build Process >Affects Versions: 0.11.0 > Environment: Appveyor >Reporter: James E. King, III >Assignee: Jake Farrell >Priority: Minor > Fix For: 0.11.0 > > > When I commit and push something into the apache git repository for thrift, > it synchronizes to github and that seems to add an Travis CI job to build it. > This is an example: > https://travis-ci.org/apache/thrift/builds/218868926 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (THRIFT-4168) Travis CI builds are being triggered by apache master pushes
[ https://issues.apache.org/jira/browse/THRIFT-4168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4168: --- Environment: Travis CI (was: Appveyor) > Travis CI builds are being triggered by apache master pushes > > > Key: THRIFT-4168 > URL: https://issues.apache.org/jira/browse/THRIFT-4168 > Project: Thrift > Issue Type: Bug > Components: Build Process >Affects Versions: 0.11.0 > Environment: Travis CI >Reporter: James E. King, III >Assignee: Jake Farrell >Priority: Minor > Fix For: 0.11.0 > > > When I commit and push something into the apache git repository for thrift, > it synchronizes to github and that seems to add an Travis CI job to build it. > This is an example: > https://travis-ci.org/apache/thrift/builds/218868926 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-4071) Consolidate the Travis CI jobs where possible to put less stress on the Apache Foundation's allocation of CI build slaves
[ https://issues.apache.org/jira/browse/THRIFT-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956959#comment-15956959 ] ASF GitHub Bot commented on THRIFT-4071: GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1238 THRIFT-4071: collapse and remove unnecessary build jobs in Travis CI Removed build jobs 2 and 4 as they were duplicates of 1 and 3 but on debian instead of ubuntu, this adds too little value to justify the expense of two 40 minute builds. Added compiler plug-in option to job 6 to make sure it is tested in CI. Combined jobs 7 and 8 because there is enough time in the build to support it. Removed build job 9 but kept 10 because it uses debian in light of removing 2 and 4. Removed build job 12 and 15 as they are redundant to 13 and 14 and add too little value to justify the expense. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift THRIFT-4071 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1238.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1238 commit 208edb0583cf4daa673f2553317448d2f3823db3 Author: James E. King, III Date: 2017-04-05T14:36:07Z THRIFT-4071: collapse and remove unnecessary build jobs in Travis CI; ensure WITH_PLUGIN is tested somewhere > Consolidate the Travis CI jobs where possible to put less stress on the > Apache Foundation's allocation of CI build slaves > - > > Key: THRIFT-4071 > URL: https://issues.apache.org/jira/browse/THRIFT-4071 > Project: Thrift > Issue Type: Improvement > Components: Build Process >Affects Versions: 0.10.0 > Environment: Travis CI >Reporter: James E. King, III >Assignee: James E. King, III > > Based on INFRA-13477 it sounds like we need to start working on eliminating > unnecessary build jobs of combining some of them. I emailed the dev mailing > list but didn't hear back after 5 days, so I am proceeding with these changes: > # We don't need to run cross tests on both debian andon ubuntu, especially > since we're using a dockerfile that's practically identical between the two; > one derives from the other. I'd like to recommend removing build jobs #2 and > #4 (debian) and keeping the ubuntu ones. > # Given we remove debian build jobs #2 and #4 above, we can keep #10 which is > a Debian build job with cmake, and eliminate #9 which is the same as #10 but > on Ubuntu. I think it is adqeuately covered in other jobs. > # We don't need to build the matrix of (boost threads, std > threads)x(gcc,clang). Let's get rid of #12 which is boost threads with > clang, and let's get rid of #15 which is std threads with gcc. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift pull request #1238: THRIFT-4071: collapse and remove unnecessary buil...
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1238 THRIFT-4071: collapse and remove unnecessary build jobs in Travis CI Removed build jobs 2 and 4 as they were duplicates of 1 and 3 but on debian instead of ubuntu, this adds too little value to justify the expense of two 40 minute builds. Added compiler plug-in option to job 6 to make sure it is tested in CI. Combined jobs 7 and 8 because there is enough time in the build to support it. Removed build job 9 but kept 10 because it uses debian in light of removing 2 and 4. Removed build job 12 and 15 as they are redundant to 13 and 14 and add too little value to justify the expense. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift THRIFT-4071 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1238.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1238 commit 208edb0583cf4daa673f2553317448d2f3823db3 Author: James E. King, III Date: 2017-04-05T14:36:07Z THRIFT-4071: collapse and remove unnecessary build jobs in Travis CI; ensure WITH_PLUGIN is tested somewhere --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Updated] (THRIFT-4071) Consolidate the Travis CI jobs where possible to put less stress on the Apache Foundation's allocation of CI build slaves
[ https://issues.apache.org/jira/browse/THRIFT-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4071: --- Description: Based on INFRA-13477 it sounds like we need to start working on eliminating unnecessary build jobs of combining some of them. I emailed the dev mailing list but didn't hear back after 5 days, so I am proceeding with these changes: # We don't need to run cross tests on both debian andon ubuntu, especially since we're using a dockerfile that's practically identical between the two; one derives from the other. I'd like to recommend removing build jobs #2 and #4 (debian) and keeping the ubuntu ones. # Given we remove debian build jobs #2 and #4 above, we can keep #10 which is a Debian build job with cmake, and eliminate #9 which is the same as #10 but on Ubuntu. I think it is adqeuately covered in other jobs. # We don't need to build the matrix of (boost threads, std threads)x(gcc,clang). Let's get rid of #12 which is boost threads with clang, and let's get rid of #15 which is std threads with gcc. was: Based on INFRA-13477 it sounds like we need to start working on eliminating unnecessary build jobs of combining some of them. I emailed the dev mailing list but didn't hear back after 5 days, so I am proceeding with these changes: # We don't need to run cross tests on both debian andon ubuntu, especially since we're using a dockerfile that's practically identical between the two; one derives from the other. I'd like to recommend removing build jobs #2 and #4 (debian) and keeping the ubuntu ones. # Given we remove debian build jobs #2 and #4 above, we can keep #10 which is a Debian build job with cmake, and eliminate #9 which is the same as #10 but on Ubuntu. I think it is adqeuately covered in other jobs. # We don't need to build the matrix of (boost threads, std threads)x(gcc,clang). Let's get rid of #12 which is boost threads with clang, and let's get rid of #15 which is std threads with gcc. > Consolidate the Travis CI jobs where possible to put less stress on the > Apache Foundation's allocation of CI build slaves > - > > Key: THRIFT-4071 > URL: https://issues.apache.org/jira/browse/THRIFT-4071 > Project: Thrift > Issue Type: Improvement > Components: Build Process >Affects Versions: 0.10.0 > Environment: Travis CI >Reporter: James E. King, III >Assignee: James E. King, III > > Based on INFRA-13477 it sounds like we need to start working on eliminating > unnecessary build jobs of combining some of them. I emailed the dev mailing > list but didn't hear back after 5 days, so I am proceeding with these changes: > # We don't need to run cross tests on both debian andon ubuntu, especially > since we're using a dockerfile that's practically identical between the two; > one derives from the other. I'd like to recommend removing build jobs #2 and > #4 (debian) and keeping the ubuntu ones. > # Given we remove debian build jobs #2 and #4 above, we can keep #10 which is > a Debian build job with cmake, and eliminate #9 which is the same as #10 but > on Ubuntu. I think it is adqeuately covered in other jobs. > # We don't need to build the matrix of (boost threads, std > threads)x(gcc,clang). Let's get rid of #12 which is boost threads with > clang, and let's get rid of #15 which is std threads with gcc. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (THRIFT-4071) Consolidate the Travis CI jobs where possible to put less stress on the Apache Foundation's allocation of CI build slaves
[ https://issues.apache.org/jira/browse/THRIFT-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4071: --- Description: Based on INFRA-13477 it sounds like we need to start working on eliminating unnecessary build jobs of combining some of them. I emailed the dev mailing list but didn't hear back after 5 days, so I am proceeding with these changes: # We don't need to run cross tests on both debian andon ubuntu, especially since we're using a dockerfile that's practically identical between the two; one derives from the other. I'd like to recommend removing build jobs #2 and #4 (debian) and keeping the ubuntu ones. # Given we remove debian build jobs #2 and #4 above, we can keep #10 which is a Debian build job with cmake, and eliminate #9 which is the same as #10 but on Ubuntu. I think it is adqeuately covered in other jobs. # We don't need to build the matrix of (boost threads, std threads)x(gcc,clang). Let's get rid of #12 which is boost threads with clang, and let's get rid of #15 which is std threads with gcc. was:Based on INFRA-13477 it sounds like we need to start working on eliminating unnecessary build jobs of combining some of them. > Consolidate the Travis CI jobs where possible to put less stress on the > Apache Foundation's allocation of CI build slaves > - > > Key: THRIFT-4071 > URL: https://issues.apache.org/jira/browse/THRIFT-4071 > Project: Thrift > Issue Type: Improvement > Components: Build Process >Affects Versions: 0.10.0 > Environment: Travis CI >Reporter: James E. King, III >Assignee: James E. King, III > > Based on INFRA-13477 it sounds like we need to start working on eliminating > unnecessary build jobs of combining some of them. I emailed the dev mailing > list but didn't hear back after 5 days, so I am proceeding with these changes: > # We don't need to run cross tests on both debian andon ubuntu, especially > since we're using a dockerfile that's practically identical between the two; > one derives from the other. I'd like to recommend removing build jobs #2 and > #4 (debian) and keeping the ubuntu ones. > # Given we remove debian build jobs #2 and #4 above, we can keep #10 which is > a Debian build job with cmake, and eliminate #9 which is the same as #10 but > on Ubuntu. I think it is adqeuately covered in other jobs. > # We don't need to build the matrix of (boost threads, std > threads)x(gcc,clang). Let's get rid of #12 which is boost threads with > clang, and let's get rid of #15 which is std threads with gcc. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-4166) Recent fix to remove boost::lexical_cast usage broke VS2010
[ https://issues.apache.org/jira/browse/THRIFT-4166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956905#comment-15956905 ] ASF GitHub Bot commented on THRIFT-4166: GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1237 THRIFT-4166: fix recent VC2010 build regression and prevent it in the future with appveyor I added a MSVC 2010, x86, debug, boost-1.54, python-2.7, qt-5.6 appveyor job to prevent this from happening again. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift THRIFT-4166 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1237.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1237 commit d8bfc0d0d283c38c918d10bd22b5a3391961a9b4 Author: James E. King, III Date: 2017-04-04T19:30:32Z THRIFT-4166: fix recent VC2010 build regression and prevent it in the future > Recent fix to remove boost::lexical_cast usage broke VS2010 > --- > > Key: THRIFT-4166 > URL: https://issues.apache.org/jira/browse/THRIFT-4166 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.11.0 > Environment: VS2010 >Reporter: James E. King, III >Assignee: James E. King, III >Priority: Minor > > Removal of boost::lexical_cast and replaced with code that calls > std::log10(2). std::log10(2) is ambiguous to VS2010. > # Fix build breakage > # add VS2010 32-bit build job to Appveyor to prevent future regression. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift pull request #1237: THRIFT-4166: fix recent VC2010 build regression a...
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1237 THRIFT-4166: fix recent VC2010 build regression and prevent it in the future with appveyor I added a MSVC 2010, x86, debug, boost-1.54, python-2.7, qt-5.6 appveyor job to prevent this from happening again. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift THRIFT-4166 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1237.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1237 commit d8bfc0d0d283c38c918d10bd22b5a3391961a9b4 Author: James E. King, III Date: 2017-04-04T19:30:32Z THRIFT-4166: fix recent VC2010 build regression and prevent it in the future --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Updated] (THRIFT-4166) Recent fix to remove boost::lexical_cast usage broke VS2010
[ https://issues.apache.org/jira/browse/THRIFT-4166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4166: --- Description: Removal of boost::lexical_cast and replaced with code that calls std::log10(2). std::log10(2) is ambiguous to VS2010. # Fix build breakage # add VS2010 32-bit build job to Appveyor to prevent future regression. was: Removal of boost::lexical_cast and replaced with code that calls std::log10(2). std::log10(2) is ambiguous to VS2010. # Fix build breakage # add VS2010 build job to Appveyor to prevent future regression. > Recent fix to remove boost::lexical_cast usage broke VS2010 > --- > > Key: THRIFT-4166 > URL: https://issues.apache.org/jira/browse/THRIFT-4166 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.11.0 > Environment: VS2010 >Reporter: James E. King, III >Assignee: James E. King, III >Priority: Minor > > Removal of boost::lexical_cast and replaced with code that calls > std::log10(2). std::log10(2) is ambiguous to VS2010. > # Fix build breakage > # add VS2010 32-bit build job to Appveyor to prevent future regression. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (THRIFT-4165) C++ build has many warnings under c++03 due to recent changes, cmake needs better platform-independent language level control
[ https://issues.apache.org/jira/browse/THRIFT-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956803#comment-15956803 ] ASF GitHub Bot commented on THRIFT-4165: Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1236 > C++ build has many warnings under c++03 due to recent changes, cmake needs > better platform-independent language level control > - > > Key: THRIFT-4165 > URL: https://issues.apache.org/jira/browse/THRIFT-4165 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.11.0 > Environment: Ubuntu 14.04 with gcc-4.6 (c++03) >Reporter: James E. King, III >Assignee: James E. King, III >Priority: Minor > Fix For: 0.11.0 > > > When not using -std=c++11 there are a number of build warnings coming out of > gcc-4.6.x. These can be turned off specifically if C++11 support is not > enabled for the compiler, but the compiler allows some C99 extensions (with > warning). > To better support C++ language levels, I propose changing the minimum > required cmake version to 3.1 to get access to CMAKE_CXX_STANDARD. > # In DefineCmakeDefaults.cmake if it isn't set, set it to 11 allowing for > decay, and disabling compiler-specific language extensions. > # Add to the DefineOptions table output showing the language level > # Add some command-line options to disable common warnings that occur if you > use an older compiler, like "long long is a C99 thing" and "variadic macros > are a C99 thing" and "register keyword is deprecated and will be removed in > c++1z" (note: register is only used in flex/bison output right now). > # Update docker files as necessary to support new cmake minimum version. > Ubuntu and debian need to change, centos6 is not used with cmake builds in > CI, centos7 already has an adequate version of cmake. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (THRIFT-4165) C++ build has many warnings under c++03 due to recent changes, cmake needs better platform-independent language level control
[ https://issues.apache.org/jira/browse/THRIFT-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4165. Resolution: Fixed Fix Version/s: 0.11.0 > C++ build has many warnings under c++03 due to recent changes, cmake needs > better platform-independent language level control > - > > Key: THRIFT-4165 > URL: https://issues.apache.org/jira/browse/THRIFT-4165 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.11.0 > Environment: Ubuntu 14.04 with gcc-4.6 (c++03) >Reporter: James E. King, III >Assignee: James E. King, III >Priority: Minor > Fix For: 0.11.0 > > > When not using -std=c++11 there are a number of build warnings coming out of > gcc-4.6.x. These can be turned off specifically if C++11 support is not > enabled for the compiler, but the compiler allows some C99 extensions (with > warning). > To better support C++ language levels, I propose changing the minimum > required cmake version to 3.1 to get access to CMAKE_CXX_STANDARD. > # In DefineCmakeDefaults.cmake if it isn't set, set it to 11 allowing for > decay, and disabling compiler-specific language extensions. > # Add to the DefineOptions table output showing the language level > # Add some command-line options to disable common warnings that occur if you > use an older compiler, like "long long is a C99 thing" and "variadic macros > are a C99 thing" and "register keyword is deprecated and will be removed in > c++1z" (note: register is only used in flex/bison output right now). > # Update docker files as necessary to support new cmake minimum version. > Ubuntu and debian need to change, centos6 is not used with cmake builds in > CI, centos7 already has an adequate version of cmake. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (THRIFT-4167) Missing compile flag
[ https://issues.apache.org/jira/browse/THRIFT-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III closed THRIFT-4167. -- Resolution: Duplicate Fix Version/s: 0.11.0 > Missing compile flag > > > Key: THRIFT-4167 > URL: https://issues.apache.org/jira/browse/THRIFT-4167 > Project: Thrift > Issue Type: Bug >Reporter: Arnaud Lacombe >Assignee: James E. King, III > Fix For: 0.11.0 > > Attachments: 0001-fix-build.patch > > > While trying to build the following on ubuntu 16.04: > # cmake -DBUILD_COMPILER=ON -DBUILD_LIBRARIES=ON -DBUILD_TESTING=OFF > -DBUILD_EXAMPLES=OFF -DWITH_CPP=ON -DWITH_BOOST_STATIC=ON > -DWITH_STDTHREADS=ON .. > the build dies on the following: > In file included from /usr/include/c++/5/thread:35:0, > from /tmp/thrift/lib/cpp/src/thrift/concurrency/Thread.h:32, > from > /tmp/thrift/lib/cpp/src/thrift/concurrency/ThreadManager.h:26, > from > /build_tmp/thrift/lib/cpp/src/thrift/concurrency/ThreadManager.cpp:22: > /usr/include/c++/5/bits/c++0x_warning.h:32:2: error: #error This file > requires compiler and library support for the ISO C++ 2011 standard. This > support must be enabled with the -std=c++11 or -std=gnu++11 compiler options. > #error This file requires compiler and library support > [...] -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] thrift pull request #1236: THRIFT-4165: better cmake support for C++ languag...
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1236 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Assigned] (THRIFT-4071) Consolidate the Travis CI jobs where possible to put less stress on the Apache Foundation's allocation of CI build slaves
[ https://issues.apache.org/jira/browse/THRIFT-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4071: -- Assignee: James E. King, III > Consolidate the Travis CI jobs where possible to put less stress on the > Apache Foundation's allocation of CI build slaves > - > > Key: THRIFT-4071 > URL: https://issues.apache.org/jira/browse/THRIFT-4071 > Project: Thrift > Issue Type: Improvement > Components: Build Process >Affects Versions: 0.10.0 > Environment: Travis CI >Reporter: James E. King, III >Assignee: James E. King, III > > Based on INFRA-13477 it sounds like we need to start working on eliminating > unnecessary build jobs of combining some of them. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
