[jira] [Commented] (THRIFT-4439) Shouldn't download dart.deb directly.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305906#comment-16305906
 ] 

ASF GitHub Bot commented on THRIFT-4439:


Github user RobberPhex commented on the issue:

https://github.com/apache/thrift/pull/1453
  
travis-ci failed, but same commit at my repo is success: 



> Shouldn't download dart.deb directly.
> -
>
> Key: THRIFT-4439
> URL: https://issues.apache.org/jira/browse/THRIFT-4439
> Project: Thrift
>  Issue Type: Bug
>  Components: Dart - Library
>Affects Versions: 0.11.0
> Environment: travis-ci
>Reporter: RobberPhex
>
> https://storage.googleapis.com/dart-archive/channels/stable/release/latest/linux_packages/dart_1.24.2-1_amd64.deb
>  is 404,
> So, as https://www.dartlang.org/install/linux suggested, use source list.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4439) Shouldn't download dart.deb directly.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305846#comment-16305846
 ] 

ASF GitHub Bot commented on THRIFT-4439:


GitHub user RobberPhex opened a pull request:

https://github.com/apache/thrift/pull/1453

THRIFT-4439: use dartlang repo instead of download dart.deb



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/RobberPhex/thrift dartlang

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1453.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1453


commit 154186cf93e70f9a50c7cebd7da71fc100b59e8e
Author: Robert Lu 
Date:   2017-12-28T20:14:38Z

use dartlang repo




> Shouldn't download dart.deb directly.
> -
>
> Key: THRIFT-4439
> URL: https://issues.apache.org/jira/browse/THRIFT-4439
> Project: Thrift
>  Issue Type: Bug
>  Components: Dart - Library
>Affects Versions: 0.11.0
> Environment: travis-ci
>Reporter: RobberPhex
>
> https://storage.googleapis.com/dart-archive/channels/stable/release/latest/linux_packages/dart_1.24.2-1_amd64.deb
>  is 404,
> So, as https://www.dartlang.org/install/linux suggested, use source list.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] thrift pull request #1453: THRIFT-4439: use dartlang repo instead of downloa...

[RobberPhex]

GitHub user RobberPhex opened a pull request:

https://github.com/apache/thrift/pull/1453

THRIFT-4439: use dartlang repo instead of download dart.deb



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/RobberPhex/thrift dartlang

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1453.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1453


commit 154186cf93e70f9a50c7cebd7da71fc100b59e8e
Author: Robert Lu 
Date:   2017-12-28T20:14:38Z

use dartlang repo




---

[jira] [Created] (THRIFT-4439) Shouldn't download dart.deb directly.

[RobberPhex (JIRA)]

RobberPhex created THRIFT-4439:
--

 Summary: Shouldn't download dart.deb directly.
 Key: THRIFT-4439
 URL: https://issues.apache.org/jira/browse/THRIFT-4439
 Project: Thrift
  Issue Type: Bug
  Components: Dart - Library
Affects Versions: 0.11.0
 Environment: travis-ci
Reporter: RobberPhex


https://storage.googleapis.com/dart-archive/channels/stable/release/latest/linux_packages/dart_1.24.2-1_amd64.deb
 is 404,

So, as https://www.dartlang.org/install/linux suggested, use source list.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4406) JavaScript: Use modern Promise implementations

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305469#comment-16305469
 ] 

ASF GitHub Bot commented on THRIFT-4406:


GitHub user bananer opened a pull request:

https://github.com/apache/thrift/pull/1452

THRIFT-4406: ES6 compatible JavaScript with Promises



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bananer/thrift THRIFT-4406-pr

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1452.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1452


commit ed1efba5ddd4d632bf53b0a9ef0b485b82979a04
Author: Philip Frank 
Date:   2017-12-06T11:38:05Z

THRIFT-4406: Optionally generate ES6 compatible JavaScript where service 
methods return Promises

includes tests and TypeScript support




> JavaScript: Use modern Promise implementations
> --
>
> Key: THRIFT-4406
> URL: https://issues.apache.org/jira/browse/THRIFT-4406
> Project: Thrift
>  Issue Type: Improvement
>  Components: JavaScript - Compiler
>Reporter: Philip Frank
>Priority: Minor
>
> I would like to acces the results of service method invocations in a web 
> browser environment using 
> [Promises|https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/this]
>  (or a compatible API). I'm willing to work on the necessary changes in the 
> compiler and am seeking guidance regarding the best way to make these changes.
> Current state:
> In browser JS, i can pass a callback function as last argument when calling a 
> method:
> {code:javascript}
> service.getFoo('a1', 'a2', function(foo) {
> alert(foo);
> });
> {code}
> There is also a synchronous API, however this blocking way is discouraged by 
> browser vendors. It also fails with an error for me when using 
> WebSocketTransport instead of XHRTransport.
> {code:javascript}
> alert(service.getFoo('a1', 'a2'));
> {code}
> In JS code generated for NodeJS, the 'q' library is included, which provides 
> an API mostly compatible with JavaScript's native Promises.
> {code:javascript}
> service.getFoo('a1', 'a2').then(function(foo) {
> alert(foo);
> });
> {code}
> From what I can tell 'q' is mostly irrelevant today since native Promises are 
> supported in NodeJs [for many 
> versions|http://node.green/#ES2015-built-ins-Promise].
> Regarding support in browsers, native Promises work in [recent versions of 
> most browsers|https://caniuse.com/#feat=promises] and can be enabled in other 
> cases by including one of the many polyfill libraries, like the popular 
> [core-js|https://github.com/zloirock/core-js#ecmascript-6-promise].
> Proposed solution:
> In both browser and nodeJS, service methods return a Promise when invoked 
> without a callback. This has many advantages for developers:
> * Promise API is an established standard in modern JavaScript (ECMAScript), 
> it is easy for developers to consume and to use with other libraries
> * Error handling is possible through {{catch()}}
> * Result handling is very flexible through chaining
> * Promises can be combined through {{Promise.all()}} and {{Promise.race()}}
> * The 
> [{{await}}|https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/await]
>  keyword makes it even easier to write async code. (Support limited to some 
> browsers or with cross-compilers like [babel|https://babeljs.io/])
> However, this would break compatibility:
> * Synchronous (blocking) invocations would no longer be supported, instead a 
> Promise instead of the value is returned
> * with NodeJS code relying on some features specific to 'q' (e.g. 
> {{finally()}} and {{done()`)
> * Internet Explorer needs a polyfill for Promises
> I'm assuming the code generated by Thrift should stay backwards compatible in 
> the foreseeable future, so I suggest making these changes behind a new 
> compiler flag, {{-gen js:es6}} (for ECMAScript 6). This would also open up 
> the ability to leverage more ES6 features in the future: For example, using 
> {{const}} instead of {{var}} might give a slight performance improvement and 
> using the {{class}} syntax could improve readability of the generated code.
> Please share any thoughts regarding this topic or hints towards a good 
> implementation. If there are no objections, I'm willing to start working on 
> this soon, with the hopes of getting my changes accepted into the project 
> codebase.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] thrift pull request #1452: THRIFT-4406: ES6 compatible JavaScript with Promi...

[bananer]

GitHub user bananer opened a pull request:

https://github.com/apache/thrift/pull/1452

THRIFT-4406: ES6 compatible JavaScript with Promises



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bananer/thrift THRIFT-4406-pr

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1452.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1452


commit ed1efba5ddd4d632bf53b0a9ef0b485b82979a04
Author: Philip Frank 
Date:   2017-12-06T11:38:05Z

THRIFT-4406: Optionally generate ES6 compatible JavaScript where service 
methods return Promises

includes tests and TypeScript support




---

[jira] [Commented] (THRIFT-4437) JS WebSocket client callbacks invoked twice on parallel requests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305425#comment-16305425
 ] 

ASF GitHub Bot commented on THRIFT-4437:


Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/1450


> JS WebSocket client callbacks invoked twice on parallel requests
> 
>
> Key: THRIFT-4437
> URL: https://issues.apache.org/jira/browse/THRIFT-4437
> Project: Thrift
>  Issue Type: Bug
>  Components: JavaScript - Library
>Affects Versions: 0.11.0
>Reporter: Philip Frank
>Assignee: James E. King, III
>
> When using a WebSocket Transport and doing two service calls immediately, 
> without waiting for the first to return, e.g. like this:
> {code:javascript}
> const t = new Thrift.TWebSocketTransport('ws://localhost:8338/hello');
>   const p = new Thrift.TJSONProtocol(t);
>   const client = new HelloSvcClient(p);
>   t.open();
>   client.test(function (res) {
>   console.log(1, res);
>   });
>   client.test(function (res) {
>   console.log(2, res);
>   });
> {code}
> The callback to the first invocation is called twice, and the second never, 
> i.e. console shows:
> {code}
> 1 "test result"
> 1 "test result"
> {code}
> instead of the expected
> {code}
> 1 "test result"
> 2 "test result"
> {code}
> I suspect this bug was introduced with the patch for 
> https://issues.apache.org/jira/browse/THRIFT-4131 where for some reason the 
> callback registered twice when set: 
> https://github.com/apache/thrift/pull/1372/files



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (THRIFT-4437) JS WebSocket client callbacks invoked twice on parallel requests

[James E. King, III (JIRA)]

 [ 
https://issues.apache.org/jira/browse/THRIFT-4437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James E. King, III reassigned THRIFT-4437:
--

Assignee: James E. King, III

> JS WebSocket client callbacks invoked twice on parallel requests
> 
>
> Key: THRIFT-4437
> URL: https://issues.apache.org/jira/browse/THRIFT-4437
> Project: Thrift
>  Issue Type: Bug
>  Components: JavaScript - Library
>Affects Versions: 0.11.0
>Reporter: Philip Frank
>Assignee: James E. King, III
>
> When using a WebSocket Transport and doing two service calls immediately, 
> without waiting for the first to return, e.g. like this:
> {code:javascript}
> const t = new Thrift.TWebSocketTransport('ws://localhost:8338/hello');
>   const p = new Thrift.TJSONProtocol(t);
>   const client = new HelloSvcClient(p);
>   t.open();
>   client.test(function (res) {
>   console.log(1, res);
>   });
>   client.test(function (res) {
>   console.log(2, res);
>   });
> {code}
> The callback to the first invocation is called twice, and the second never, 
> i.e. console shows:
> {code}
> 1 "test result"
> 1 "test result"
> {code}
> instead of the expected
> {code}
> 1 "test result"
> 2 "test result"
> {code}
> I suspect this bug was introduced with the patch for 
> https://issues.apache.org/jira/browse/THRIFT-4131 where for some reason the 
> callback registered twice when set: 
> https://github.com/apache/thrift/pull/1372/files



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] thrift pull request #1450: THRIFT-4437: JavaScript WebSocket - fix duplicate...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/1450


---

[GitHub] thrift issue #1450: THRIFT-4437: JavaScript WebSocket - fix duplicate callba...

[jeking3]

Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1450
  
Running autotools.sh locally on xenial to see if it was one of those 
annoying npm transient failures.


---

[jira] [Commented] (THRIFT-4437) JS WebSocket client callbacks invoked twice on parallel requests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305413#comment-16305413
 ] 

ASF GitHub Bot commented on THRIFT-4437:


Github user jeking3 commented on the issue:

https://github.com/apache/thrift/pull/1450
  
Running autotools.sh locally on xenial to see if it was one of those 
annoying npm transient failures.


> JS WebSocket client callbacks invoked twice on parallel requests
> 
>
> Key: THRIFT-4437
> URL: https://issues.apache.org/jira/browse/THRIFT-4437
> Project: Thrift
>  Issue Type: Bug
>  Components: JavaScript - Library
>Affects Versions: 0.11.0
>Reporter: Philip Frank
>
> When using a WebSocket Transport and doing two service calls immediately, 
> without waiting for the first to return, e.g. like this:
> {code:javascript}
> const t = new Thrift.TWebSocketTransport('ws://localhost:8338/hello');
>   const p = new Thrift.TJSONProtocol(t);
>   const client = new HelloSvcClient(p);
>   t.open();
>   client.test(function (res) {
>   console.log(1, res);
>   });
>   client.test(function (res) {
>   console.log(2, res);
>   });
> {code}
> The callback to the first invocation is called twice, and the second never, 
> i.e. console shows:
> {code}
> 1 "test result"
> 1 "test result"
> {code}
> instead of the expected
> {code}
> 1 "test result"
> 2 "test result"
> {code}
> I suspect this bug was introduced with the patch for 
> https://issues.apache.org/jira/browse/THRIFT-4131 where for some reason the 
> callback registered twice when set: 
> https://github.com/apache/thrift/pull/1372/files



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4423) migrate php library to psr-4

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305408#comment-16305408
 ] 

ASF GitHub Bot commented on THRIFT-4423:


Github user jeking3 commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1445#discussion_r158937524
  
--- Diff: build/docker/run.sh ---
@@ -25,6 +25,8 @@ DOCKER_TAG=$DOCKER_REPO:$DISTRO
 
 printenv | sort
 
+composer install
--- End diff --

This looks like it should be part of the php section of the Dockerfile.  By 
putting it in the run section, we run "composer install" on the host and then 
start a docker environment which doesn't have access to it.


> migrate php library to psr-4
> 
>
> Key: THRIFT-4423
> URL: https://issues.apache.org/jira/browse/THRIFT-4423
> Project: Thrift
>  Issue Type: Improvement
>  Components: PHP - Library
>Affects Versions: 0.11.0
>Reporter: Robert Lu
>
> The latest autoload standard is [http://www.php-fig.org/psr/psr-4/].
> So, I migrate thrift to PSR-4.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4423) migrate php library to psr-4

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305409#comment-16305409
 ] 

ASF GitHub Bot commented on THRIFT-4423:


Github user jeking3 commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1445#discussion_r158937598
  
--- Diff: build/docker/scripts/sca.sh ---
@@ -56,7 +56,3 @@ echo  TODOs: `grep -r TODO * | wc -l`
 
 # LoC
 sloccount .
-
-# System Info
--- End diff --

Removing these lines looks unrelated to the task at hand, and they don't 
take much time, and they provide useful info.


> migrate php library to psr-4
> 
>
> Key: THRIFT-4423
> URL: https://issues.apache.org/jira/browse/THRIFT-4423
> Project: Thrift
>  Issue Type: Improvement
>  Components: PHP - Library
>Affects Versions: 0.11.0
>Reporter: Robert Lu
>
> The latest autoload standard is [http://www.php-fig.org/psr/psr-4/].
> So, I migrate thrift to PSR-4.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4423) migrate php library to psr-4

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305410#comment-16305410
 ] 

ASF GitHub Bot commented on THRIFT-4423:


Github user jeking3 commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1445#discussion_r158937682
  
--- Diff: lib/php/test/Makefile.am ---
@@ -17,6 +17,8 @@
 # under the License.
 #
 
+PHPUNIT=./../../../vendor/bin/phpunit
--- End diff --

Is this relative path going to work on every platform?


> migrate php library to psr-4
> 
>
> Key: THRIFT-4423
> URL: https://issues.apache.org/jira/browse/THRIFT-4423
> Project: Thrift
>  Issue Type: Improvement
>  Components: PHP - Library
>Affects Versions: 0.11.0
>Reporter: Robert Lu
>
> The latest autoload standard is [http://www.php-fig.org/psr/psr-4/].
> So, I migrate thrift to PSR-4.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] thrift pull request #1445: THRIFT-4423 migrate to psr-4

[jeking3]

Github user jeking3 commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1445#discussion_r158937682
  
--- Diff: lib/php/test/Makefile.am ---
@@ -17,6 +17,8 @@
 # under the License.
 #
 
+PHPUNIT=./../../../vendor/bin/phpunit
--- End diff --

Is this relative path going to work on every platform?


---

[GitHub] thrift pull request #1445: THRIFT-4423 migrate to psr-4

[jeking3]

Github user jeking3 commented on a diff in the pull request:

https://github.com/apache/thrift/pull/1445#discussion_r158937598
  
--- Diff: build/docker/scripts/sca.sh ---
@@ -56,7 +56,3 @@ echo  TODOs: `grep -r TODO * | wc -l`
 
 # LoC
 sloccount .
-
-# System Info
--- End diff --

Removing these lines looks unrelated to the task at hand, and they don't 
take much time, and they provide useful info.


---

[jira] [Commented] (THRIFT-4438) require php ^5.6 || ^7.0

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305340#comment-16305340
 ] 

ASF GitHub Bot commented on THRIFT-4438:


GitHub user RobberPhex opened a pull request:

https://github.com/apache/thrift/pull/1451

THRIFT-4438: delete trusty and requrie php56

* remove support php 5.3, 5.4 and 5.5
* remove test at ubuntu trusty(trusty only have php5.5, haven't php5.6)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/RobberPhex/thrift php56

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1451.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1451


commit b960a1e447457d2eba98dad75e4ebf023b5504de
Author: Robert Lu 
Date:   2017-12-28T10:07:08Z

delete trusty and requrie php56




> require php ^5.6 || ^7.0
> 
>
> Key: THRIFT-4438
> URL: https://issues.apache.org/jira/browse/THRIFT-4438
> Project: Thrift
>  Issue Type: Improvement
>  Components: PHP - Library
>Affects Versions: 0.11.0
>Reporter: RobberPhex
>
> We can remove php5.3~php5.5 support.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] thrift pull request #1451: THRIFT-4438: delete trusty and requrie php56

[RobberPhex]

GitHub user RobberPhex opened a pull request:

https://github.com/apache/thrift/pull/1451

THRIFT-4438: delete trusty and requrie php56

* remove support php 5.3, 5.4 and 5.5
* remove test at ubuntu trusty(trusty only have php5.5, haven't php5.6)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/RobberPhex/thrift php56

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/1451.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1451


commit b960a1e447457d2eba98dad75e4ebf023b5504de
Author: Robert Lu 
Date:   2017-12-28T10:07:08Z

delete trusty and requrie php56




---

[jira] [Commented] (THRIFT-4423) migrate php library to psr-4

[RobberPhex (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305333#comment-16305333
 ] 

RobberPhex commented on THRIFT-4423:


Finally, all test passed.

[~jking3] Is this pull request OK?

> migrate php library to psr-4
> 
>
> Key: THRIFT-4423
> URL: https://issues.apache.org/jira/browse/THRIFT-4423
> Project: Thrift
>  Issue Type: Improvement
>  Components: PHP - Library
>Affects Versions: 0.11.0
>Reporter: Robert Lu
>
> The latest autoload standard is [http://www.php-fig.org/psr/psr-4/].
> So, I migrate thrift to PSR-4.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (THRIFT-4437) JS WebSocket client callbacks invoked twice on parallel requests

[Philip Frank (JIRA)]

[ 
https://issues.apache.org/jira/browse/THRIFT-4437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305300#comment-16305300
 ] 

Philip Frank commented on THRIFT-4437:
--

This issue would have been caught by the `ThriftWS` test suite, which is not 
enabled for some reason. I will add a commit to my PR that enables these tests.

> JS WebSocket client callbacks invoked twice on parallel requests
> 
>
> Key: THRIFT-4437
> URL: https://issues.apache.org/jira/browse/THRIFT-4437
> Project: Thrift
>  Issue Type: Bug
>  Components: JavaScript - Library
>Affects Versions: 0.11.0
>Reporter: Philip Frank
>
> When using a WebSocket Transport and doing two service calls immediately, 
> without waiting for the first to return, e.g. like this:
> {code:javascript}
> const t = new Thrift.TWebSocketTransport('ws://localhost:8338/hello');
>   const p = new Thrift.TJSONProtocol(t);
>   const client = new HelloSvcClient(p);
>   t.open();
>   client.test(function (res) {
>   console.log(1, res);
>   });
>   client.test(function (res) {
>   console.log(2, res);
>   });
> {code}
> The callback to the first invocation is called twice, and the second never, 
> i.e. console shows:
> {code}
> 1 "test result"
> 1 "test result"
> {code}
> instead of the expected
> {code}
> 1 "test result"
> 2 "test result"
> {code}
> I suspect this bug was introduced with the patch for 
> https://issues.apache.org/jira/browse/THRIFT-4131 where for some reason the 
> callback registered twice when set: 
> https://github.com/apache/thrift/pull/1372/files



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (THRIFT-4438) require php ^5.6 || ^7.0

[RobberPhex (JIRA)]

RobberPhex created THRIFT-4438:
--

 Summary: require php ^5.6 || ^7.0
 Key: THRIFT-4438
 URL: https://issues.apache.org/jira/browse/THRIFT-4438
 Project: Thrift
  Issue Type: Improvement
  Components: PHP - Library
Affects Versions: 0.11.0
Reporter: RobberPhex


We can remove php5.3~php5.5 support.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)