[jira] [Commented] (THRIFT-3803) Remove "file" attribute from XML generator
[ https://issues.apache.org/jira/browse/THRIFT-3803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268003#comment-15268003 ] Hudson commented on THRIFT-3803: SUCCESS: Integrated in Thrift-precommit #451 (See [https://builds.apache.org/job/Thrift-precommit/451/]) THRIFT-3803 - Remove file attribute from include elements in XML (jensg: [https://github.com/apache/thrift/commit/ea0da97d44d1f9e367303c66cc55e825ed419260]) * lib/xml/thrift-idl.xsd * compiler/cpp/src/generate/t_xml_generator.cc > Remove "file" attribute from XML generator > -- > > Key: THRIFT-3803 > URL: https://issues.apache.org/jira/browse/THRIFT-3803 > Project: Thrift > Issue Type: Improvement > Components: XML/XSD - Compiler >Affects Versions: 0.10.0 >Reporter: Benjamin Gould >Assignee: Benjamin Gould >Priority: Minor > Fix For: 0.10.0 > > > When I created the XML generator, I added an attribute named "file" to the > element that has path information to the included file. > The information being exported into the XML file however is an absolute path > that is specific to the system on which the XML file is generated, which > probably should not exported. Additionally, I'm not sure that the path > information has much particular use anyhow, so IMO this should just be > removed (especially since it has not been in an official release yet). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3807) Swift compiler does not escape reserved words
[ https://issues.apache.org/jira/browse/THRIFT-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268001#comment-15268001 ] Hudson commented on THRIFT-3807: SUCCESS: Integrated in Thrift-precommit #451 (See [https://builds.apache.org/job/Thrift-precommit/451/]) THRIFT-3807 Swift compiler does not escape reserved words Client: Swift (jensg: [https://github.com/apache/thrift/commit/b749c2603ef1935bc1fbba4f9c2935b12b1328e0]) * compiler/cpp/src/generate/t_swift_generator.cc > Swift compiler does not escape reserved words > - > > Key: THRIFT-3807 > URL: https://issues.apache.org/jira/browse/THRIFT-3807 > Project: Thrift > Issue Type: Bug > Components: Swift - Compiler >Reporter: Stig Bakken >Assignee: Stig Bakken >Priority: Minor > Fix For: 0.10.0 > > > Swift has a number of reserved words that may still be used if quoted with > backticks in the generated code: > Self > associatedtype > defer > deinit > dynamicType > enum > extension > fallthrough > false > func > guard > init > inout > internal > let > operator > protocol > repeat > rethrows > struct > subscript > throws > true > typealias > where -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3806) Swift generator does not handle self-referring structs
[ https://issues.apache.org/jira/browse/THRIFT-3806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268005#comment-15268005 ] Hudson commented on THRIFT-3806: SUCCESS: Integrated in Thrift-precommit #451 (See [https://builds.apache.org/job/Thrift-precommit/451/]) THRIFT-3806 Swift generator does not handle self-referring structs (jensg: [https://github.com/apache/thrift/commit/ad3714ac3d7b9220d16f3a68503c261b8d22c8ee]) * compiler/cpp/src/generate/t_swift_generator.cc > Swift generator does not handle self-referring structs > -- > > Key: THRIFT-3806 > URL: https://issues.apache.org/jira/browse/THRIFT-3806 > Project: Thrift > Issue Type: Bug > Components: Swift - Compiler >Reporter: Stig Bakken >Assignee: Stig Bakken >Priority: Minor > Fix For: 0.10.0 > > > Changing generated code from `struct` to `final class` solves this. Haven't > found any other problems with this approach. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3797) Generated Delphi processor shouldn't error out on timed out exceptions
[ https://issues.apache.org/jira/browse/THRIFT-3797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268006#comment-15268006 ] Hudson commented on THRIFT-3797: SUCCESS: Integrated in Thrift-precommit #451 (See [https://builds.apache.org/job/Thrift-precommit/451/]) THRIFT-3797 Generated Delphi processor shouldn't error out on timed out (jensg: [https://github.com/apache/thrift/commit/f5972c9682744014c9d825c3ccd9200e9c6e]) * compiler/cpp/src/generate/t_delphi_generator.cc > Generated Delphi processor shouldn't error out on timed out exceptions > -- > > Key: THRIFT-3797 > URL: https://issues.apache.org/jira/browse/THRIFT-3797 > Project: Thrift > Issue Type: Bug > Components: Delphi - Compiler >Reporter: Kyle Johnson >Assignee: Kyle Johnson > Fix For: 0.10.0 > > > When the generated service processor waits on a new message to arrive in the > TProcessorImpl.Process() function, it treats all exceptions identically, > causing the function to return False when an exception is raised. When > returning false, the server treats this as an error, aborts the processing > loop and subsequently aborts the connection, tears down all connection > information and then waits for a new connection. > However, this is undesired in the situation where a message hasn't arrived > for longer than the configured timeout of the connection. In this instance, > the server shouldn't consider the timeout to be an error, because it is > desired to have the server continue running even when an RPC call hasn't been > received in longer than the duration of the timeout. > The patch fixes this issue by catching the timeout exception and returning > success even when a timeout occurs, allowing the server to continue execution > with the current connection. This behavior mirrors what happens in the C++ > library in TConnectedClient.cpp, where in TConnectedClient.run(), TIMED_OUT > exception types don't cause the processing loop to abort. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3794) Split Delphi application, protocol and transport exception subtypes into separate exceptions
[ https://issues.apache.org/jira/browse/THRIFT-3794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268004#comment-15268004 ] Hudson commented on THRIFT-3794: SUCCESS: Integrated in Thrift-precommit #451 (See [https://builds.apache.org/job/Thrift-precommit/451/]) THRIFT-3794 Fixing exception types in library now that they have been (jensg: [https://github.com/apache/thrift/commit/e363a34e63e851f17061a912a77e75a8ed8474bc]) * lib/delphi/src/Thrift.Transport.pas * lib/delphi/src/Thrift.Socket.pas > Split Delphi application, protocol and transport exception subtypes into > separate exceptions > > > Key: THRIFT-3794 > URL: https://issues.apache.org/jira/browse/THRIFT-3794 > Project: Thrift > Issue Type: Improvement > Components: Delphi - Library >Reporter: Kyle Johnson >Assignee: Kyle Johnson > Fix For: 0.10.0 > > Attachments: > THRIFT-3794-Split-Application-Protocol-Transport-exception-subtypes.patch, > THRIFT-3794-Split-Delphi-application-protocol-and-tr.patch > > > It is much more convenient to work with a hierarchy of exceptions for several > reasons, including, but not limited to the following: > 1) Writing exception handler filters is much simpler and clearer when one can > simply say "on E: TTransportExceptionTimedOut do" instead of "on E: > TTransportException do if E.Type_ = > TTransportException.TExceptionType.TimedOut then". > 2) Ignoring exception types within the Delphi IDE is doable, but not by > exception subtype, as with the Delphi library. It isn't possible to ignore > transport timeouts and not ignore all other transport exception subtypes. > This makes debugging much more challenging when stepping through code. > I propose splitting the TApplicationException, TProtocolException and > TTransportException classes into separate exception classes based on > exception subtype. It should be possible to do so while retaining backward > compatibility for code that relies on the old exception methodology. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3808) Missing `DOUBLE` in thrift type enumeration
[ https://issues.apache.org/jira/browse/THRIFT-3808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268002#comment-15268002 ] Hudson commented on THRIFT-3808: SUCCESS: Integrated in Thrift-precommit #451 (See [https://builds.apache.org/job/Thrift-precommit/451/]) THRIFT-3808 Missing `DOUBLE` in thrift type enumeration Client: Go (jensg: [https://github.com/apache/thrift/commit/7c3eac3ee28facfea3593b4a78488d73eb6a7f4d]) * lib/go/thrift/type.go > Missing `DOUBLE` in thrift type enumeration > --- > > Key: THRIFT-3808 > URL: https://issues.apache.org/jira/browse/THRIFT-3808 > Project: Thrift > Issue Type: Improvement > Components: Go - Library >Reporter: Mahendran Kathirvel >Assignee: Mahendran Kathirvel >Priority: Minor > Labels: easyfix > Fix For: 0.10.0 > > > Type `DOUBLE` declared as thrift type constants in the thrift protocol but > not included in the type enumeration -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3809) wrong/unused BINARY type code
[
https://issues.apache.org/jira/browse/THRIFT-3809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268000#comment-15268000
]
Hudson commented on THRIFT-3809:
SUCCESS: Integrated in Thrift-precommit #451 (See
[https://builds.apache.org/job/Thrift-precommit/451/])
THRIFT-3809 wrong/unused BINARY type code Client: Go Patch: Jens Geyer (jensg:
[https://github.com/apache/thrift/commit/eed661313f4da242d1b3c6e4166b993fd6efba6b])
* lib/go/thrift/type.go
> wrong/unused BINARY type code
> -
>
> Key: THRIFT-3809
> URL: https://issues.apache.org/jira/browse/THRIFT-3809
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
>Reporter: Jens Geyer
>Assignee: Jens Geyer
>Priority: Trivial
> Fix For: 0.10.0
>
> Attachments: 0001-THRIFT-3809-wrong-unused-BINARY-type-code.patch
>
>
> There is a type code for {{BINARY = 18}} which is both wrong and unused.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3796) There's no --dbg for dh_strip, maybe someone has mistaken this for --dbg-package.
[ https://issues.apache.org/jira/browse/THRIFT-3796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268008#comment-15268008 ] Hudson commented on THRIFT-3796: SUCCESS: Integrated in Thrift-precommit #451 (See [https://builds.apache.org/job/Thrift-precommit/451/]) THRIFT-3796 There's no --dbg for dh_strip, maybe someone has mistaken (jensg: [https://github.com/apache/thrift/commit/f457780facf8e4effe92af7c0192fbc6321d0a66]) * debian/rules > There's no --dbg for dh_strip, maybe someone has mistaken this for > --dbg-package. > - > > Key: THRIFT-3796 > URL: https://issues.apache.org/jira/browse/THRIFT-3796 > Project: Thrift > Issue Type: Bug > Components: Build Process >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 0.10.0 > > > [GitHub] thrift pull request: Fix command option error. > GitHub user matyapiro31 opened a pull request: > https://github.com/apache/thrift/pull/988 > Fix command option error. > There's no --dbg for dh_strip, maybe someone has mistaken this for > --dbg-package. > You can merge this pull request into a Git repository by running: > $ git pull https://github.com/matyapiro31/thrift matyapiro31-patch-1 > Alternatively you can review and apply these changes as the patch at: > https://github.com/apache/thrift/pull/988.patch > To close this pull request, make a commit to your master/trunk branch > with (at least) the following in the commit message: > This closes #988 > > commit 547fcae26ff5bb67961bd5d2c45092303a9bf600 > Author: Akira > Date: 2016-04-15T17:09:49Z > Fix command option error. > There's no --dbg for dh_strip, maybe someone has mistaken this for > --dbg-package. > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at infrastructure@... or file a JIRA ticket > with INFRA. > --- -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3795) Generated hashValue method in Swift will overflow
[ https://issues.apache.org/jira/browse/THRIFT-3795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268007#comment-15268007 ] Hudson commented on THRIFT-3795: SUCCESS: Integrated in Thrift-precommit #451 (See [https://builds.apache.org/job/Thrift-precommit/451/]) THRIFT-3795 Generated hashValue method in Swift will overflow Client: (jensg: [https://github.com/apache/thrift/commit/80542987f96febd5182072b6ce32ffcc1d43eab7]) * compiler/cpp/src/generate/t_swift_generator.cc > Generated hashValue method in Swift will overflow > - > > Key: THRIFT-3795 > URL: https://issues.apache.org/jira/browse/THRIFT-3795 > Project: Thrift > Issue Type: Bug > Components: Swift - Compiler >Affects Versions: 0.9.3 >Reporter: Håkon Hitland >Assignee: Håkon Hitland >Priority: Minor > Fix For: 0.10.0 > > Attachments: overflow.patch > > > The generated hashValue code for Swift uses the + and * arithmetic operators, > for which an overflow is a fatal error. > The intention is probably to wrap around, so the overflow operators should be > used instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3791) Delphi pipe client may fail even in a non-error condition
[ https://issues.apache.org/jira/browse/THRIFT-3791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15253199#comment-15253199 ] Hudson commented on THRIFT-3791: SUCCESS: Integrated in Thrift-precommit #438 (See [https://builds.apache.org/job/Thrift-precommit/438/]) THRIFT-3791 Delphi pipe client may fail even in a non-error condition (jensg: [https://github.com/apache/thrift/commit/5988f4800694d81e547d47596f737c0db551ef50]) * lib/delphi/src/Thrift.Transport.Pipes.pas > Delphi pipe client may fail even in a non-error condition > - > > Key: THRIFT-3791 > URL: https://issues.apache.org/jira/browse/THRIFT-3791 > Project: Thrift > Issue Type: Bug > Components: Delphi - Library >Affects Versions: 1.0 >Reporter: Kyle Johnson >Assignee: Kyle Johnson > Fix For: 0.10.0 > > Attachments: > 0001-THRIFT-3791-Delphi-pipe-client-may-fail-even-in-a-no.patch, > THRIFT-3791-fix-for-calling-GetLastError-even-on-success.patch > > > In TPipeStreamBase.ReadDirect(), the code performs a peek on the pipe. If no > data is available (bytes = 0), GetLastError is still checked, even though > Microsoft documentation clearly states that not all functions set the last > error code to 0 on success > (https://msdn.microsoft.com/en-us/library/windows/desktop/ms679360(v=vs.85).aspx). > Furthermore, because PeekNamedPipe only mentions that GetLastError should > be called on failure, the logic of the if test must be changed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3793) Appveyor builds reference an ant version that is no longer there
[ https://issues.apache.org/jira/browse/THRIFT-3793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15253196#comment-15253196 ] Hudson commented on THRIFT-3793: SUCCESS: Integrated in Thrift-precommit #438 (See [https://builds.apache.org/job/Thrift-precommit/438/]) THRIFT-3793: move to ant-1.9.7 for appveyor builds Client: Build process (jensg: [https://github.com/apache/thrift/commit/8077883a71bb3a2d3fbc05e665d5020708b5cafc]) * appveyor.yml > Appveyor builds reference an ant version that is no longer there > > > Key: THRIFT-3793 > URL: https://issues.apache.org/jira/browse/THRIFT-3793 > Project: Thrift > Issue Type: Bug > Components: Build Process >Affects Versions: 0.10.0 > Environment: Appveyor CI >Reporter: James E. King, III >Assignee: James E. King, III >Priority: Blocker > Fix For: 0.10.0 > > > From a build today: > https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/build/265 > Chocolatey installed 1/1 package(s). 0 package(s) failed. > See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log). > appveyor DownloadFile > http://www.us.apache.org/dist//ant/binaries/apache-ant-1.9.6-bin.zip > Error downloading file: The remote server returned an error: (404) Not Found. > Command exited with code 2 > I went the directory and 1.9.7 is there, not 1.9.6: > http://www.us.apache.org/dist/ant/binaries/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3792) Timeouts for anonymous pipes should be configurable
[ https://issues.apache.org/jira/browse/THRIFT-3792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15253200#comment-15253200 ] Hudson commented on THRIFT-3792: SUCCESS: Integrated in Thrift-precommit #438 (See [https://builds.apache.org/job/Thrift-precommit/438/]) THRIFT-3792 Timeouts for anonymous pipes should be configurable Client: (jensg: [https://github.com/apache/thrift/commit/dd074e714a07df9e48dc1d7d2c7528dc5e945b4c]) * lib/delphi/src/Thrift.Transport.Pipes.pas > Timeouts for anonymous pipes should be configurable > --- > > Key: THRIFT-3792 > URL: https://issues.apache.org/jira/browse/THRIFT-3792 > Project: Thrift > Issue Type: Improvement > Components: Delphi - Library >Reporter: Kyle Johnson >Assignee: Kyle Johnson > Fix For: 0.10.0 > > Attachments: > THRIFT-3792-make-anonymous-pipe-timeouts-configurable.patch > > > Timeouts for anonymous pipes aren't currently configurable and should be. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3790) Fix Delphi named pipe client to use timeout even when pipe doesn't yet exist
[ https://issues.apache.org/jira/browse/THRIFT-3790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15253195#comment-15253195 ] Hudson commented on THRIFT-3790: SUCCESS: Integrated in Thrift-precommit #438 (See [https://builds.apache.org/job/Thrift-precommit/438/]) THRIFT-3790 Fix Delphi named pipe client to use timeout even when pipe (jensg: [https://github.com/apache/thrift/commit/b89b5b9d03f322043f70c552b1a56b5fdb57ef84]) * lib/delphi/src/Thrift.Transport.Pipes.pas THRIFT-3790 Fix Delphi named pipe client to use timeout even when pipe (jensg: [https://github.com/apache/thrift/commit/653f0de4813ed3cbff508a735ad77b03f4fb1c84]) * lib/delphi/src/Thrift.Transport.Pipes.pas THRIFT-3790 Fix Delphi named pipe client to use timeout even when pipe (jensg: [https://github.com/apache/thrift/commit/ae985dda55418c6524da5dd7e6a466fc8d1656a8]) * lib/delphi/test/TestClient.pas > Fix Delphi named pipe client to use timeout even when pipe doesn't yet exist > > > Key: THRIFT-3790 > URL: https://issues.apache.org/jira/browse/THRIFT-3790 > Project: Thrift > Issue Type: Bug > Components: Delphi - Library >Affects Versions: 1.0 >Reporter: Kyle Johnson >Assignee: Kyle Johnson >Priority: Minor > Fix For: 0.10.0 > > Attachments: > 0001-THRIFT-3790-Fix-Delphi-named-pipe-client-to-use-time.patch, > 0002-THRIFT-3790-Fix-Delphi-named-pipe-client-to-use-time.patch, > THRIFT-3790-Test-client-fix.patch, > THRIFT-3790-fix-for-closing-and-reopening-client-pipe-connection.patch > > > In the Delphi test code, the test client closes the connection and then > immediately reopens it. However, it takes a small amount of time for the > server to tear down the connection and then rebuild it. In that time, the > client has issued an Open() call on the pipe client when the server hasn't > yet recreated the pipe. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3794) Split Delphi application, protocol and transport exception subtypes into separate exceptions
[ https://issues.apache.org/jira/browse/THRIFT-3794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15253197#comment-15253197 ] Hudson commented on THRIFT-3794: SUCCESS: Integrated in Thrift-precommit #438 (See [https://builds.apache.org/job/Thrift-precommit/438/]) THRIFT-3794 Split Delphi application, protocol and transport exception (jensg: [https://github.com/apache/thrift/commit/e0e3240d6409a3a3f49225db114a3c6914fc682f]) * lib/delphi/test/server.dpr * lib/delphi/test/client.dpr * lib/delphi/src/Thrift.Server.pas * lib/delphi/src/Thrift.Transport.Pipes.pas * lib/delphi/src/Thrift.Processor.Multiplex.pas * lib/delphi/src/Thrift.Protocol.JSON.pas * lib/delphi/src/Thrift.Protocol.Compact.pas * lib/delphi/src/Thrift.Protocol.pas * lib/delphi/src/Thrift.pas * lib/delphi/src/Thrift.Transport.pas * compiler/cpp/src/generate/t_delphi_generator.cc > Split Delphi application, protocol and transport exception subtypes into > separate exceptions > > > Key: THRIFT-3794 > URL: https://issues.apache.org/jira/browse/THRIFT-3794 > Project: Thrift > Issue Type: Improvement > Components: Delphi - Library >Reporter: Kyle Johnson >Assignee: Kyle Johnson > Fix For: 0.10.0 > > Attachments: > THRIFT-3794-Split-Application-Protocol-Transport-exception-subtypes.patch, > THRIFT-3794-Split-Delphi-application-protocol-and-tr.patch > > > It is much more convenient to work with a hierarchy of exceptions for several > reasons, including, but not limited to the following: > 1) Writing exception handler filters is much simpler and clearer when one can > simply say "on E: TTransportExceptionTimedOut do" instead of "on E: > TTransportException do if E.Type_ = > TTransportException.TExceptionType.TimedOut then". > 2) Ignoring exception types within the Delphi IDE is doable, but not by > exception subtype, as with the Delphi library. It isn't possible to ignore > transport timeouts and not ignore all other transport exception subtypes. > This makes debugging much more challenging when stepping through code. > I propose splitting the TApplicationException, TProtocolException and > TTransportException classes into separate exception classes based on > exception subtype. It should be possible to do so while retaining backward > compatibility for code that relies on the old exception methodology. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3487) Full support for newer Delphi versions
[ https://issues.apache.org/jira/browse/THRIFT-3487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15253198#comment-15253198 ] Hudson commented on THRIFT-3487: SUCCESS: Integrated in Thrift-precommit #438 (See [https://builds.apache.org/job/Thrift-precommit/438/]) THRIFT-3487 Full support for newer Delphi versions Client: Delphi Patch: (jensg: [https://github.com/apache/thrift/commit/bea9bbe7c6c72630ba7f9461ea70cb4a2e454548]) * lib/delphi/test/typeregistry/TestTypeRegistry.dpr * lib/delphi/test/skip/skiptest_version2.dpr * lib/delphi/src/Thrift.Transport.pas * lib/delphi/test/server.dpr * lib/delphi/test/client.dpr * lib/delphi/test/multiplexed/Multiplex.Test.Client.dpr * lib/delphi/test/TestClient.pas * lib/delphi/test/skip/skiptest_version1.dpr * lib/delphi/test/serializer/TestSerializer.dpr * lib/delphi/src/Thrift.Socket.pas * lib/delphi/test/multiplexed/Multiplex.Test.Server.dpr * lib/delphi/test/TestServer.pas > Full support for newer Delphi versions > -- > > Key: THRIFT-3487 > URL: https://issues.apache.org/jira/browse/THRIFT-3487 > Project: Thrift > Issue Type: Bug > Components: Delphi - Compiler >Affects Versions: 0.9.3 >Reporter: Franz Rauscher >Assignee: Kyle Johnson > Fix For: 0.10.0 > > Attachments: > 0001-THRIFT-3487-Full-support-for-newer-Delphi-versions.patch, > THRIFT-3487-Full-support-for-newer-Delphi-versions.patch, > THRIFT-3487-Full-support-for-sockets-in-newer-Delphi-versions.patch > > > There are a few issues with newer Delphi versions, in particular regarding > the deprecated sockets library that we use today. Currently, the sockets > support has been removed from the Thrift Delphi bindings for newer Delphi > versions, so we are at least able to compile the rest w/o problems. > If sockets are needed, one may consider downloading the file [Web.Win.Sockets > from the RAD-Studio Samples| > http://sourceforge.net/p/radstudiodemos/code/HEAD/tree/branches/RadStudio_XE8/Object%20Pascal/VCL/InetWinSockets/] > instead to reactivate the old behaviour. However, this is not a recommended > solution, only a workaround. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3559) Fix awkward extra semi-colons with Cocoa container literals
[ https://issues.apache.org/jira/browse/THRIFT-3559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15247780#comment-15247780 ] Hudson commented on THRIFT-3559: SUCCESS: Integrated in Thrift-precommit #428 (See [https://builds.apache.org/job/Thrift-precommit/428/]) THRIFT-3559 Fix awkward extra semi-colons with Cocoa container literals (jensg: [https://github.com/apache/thrift/commit/4b7abedb0463fb55a15b389fb9f12b77cf5194f8]) * compiler/cpp/src/generate/t_cocoa_generator.cc > Fix awkward extra semi-colons with Cocoa container literals > --- > > Key: THRIFT-3559 > URL: https://issues.apache.org/jira/browse/THRIFT-3559 > Project: Thrift > Issue Type: Bug > Components: Cocoa - Compiler >Reporter: Kevin Wooten >Assignee: Kevin Wooten >Priority: Minor > Fix For: 0.10.0 > > > Changes made in THRIFT-3545 introduce and awkward semi-colons and extra new > lines. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2) Thrift::Socket->isOpen() throws 'Can't use string ("1") as an ARRAY ref while "strict refs" in use at /usr/local/lib/perl5/site_perl/5.8.8/Thrift/Socket.pm line 87.'
[
https://issues.apache.org/jira/browse/THRIFT-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15243248#comment-15243248
]
Hudson commented on THRIFT-2:
-
FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #1202 (See
[https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/1202/])
HBASE-15637 TSHA Thrift-2 server should allow limiting call queue size
(apurtell: rev a09ed49683551361947adcc1e6551799645f3058)
* hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java
> Thrift::Socket->isOpen() throws 'Can't use string ("1") as an ARRAY ref while
> "strict refs" in use at /usr/local/lib/perl5/site_perl/5.8.8/Thrift/Socket.pm
> line 87.'
> -
>
> Key: THRIFT-2
> URL: https://issues.apache.org/jira/browse/THRIFT-2
> Project: Thrift
> Issue Type: Bug
> Components: Perl - Library
> Environment: Linux (CentOS release 5), thrift-20080411, perl 5.8.8
>Reporter: Josh Rotenberg
>Assignee: T Jake Luciani
>Priority: Minor
> Attachments: Socket.pm.patch
>
>
> Trying to call $socket->isOpen on an opened socket dies with:
>
> Can't use string ("1") as an ARRAY ref while "strict refs" in use at
> /usr/local/lib/perl5/site_perl/5.8.8/Thrift/Socket.pm line 87.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-2) Thrift::Socket->isOpen() throws 'Can't use string ("1") as an ARRAY ref while "strict refs" in use at /usr/local/lib/perl5/site_perl/5.8.8/Thrift/Socket.pm line 87.'
[
https://issues.apache.org/jira/browse/THRIFT-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15243197#comment-15243197
]
Hudson commented on THRIFT-2:
-
FAILURE: Integrated in HBase-0.98-matrix #329 (See
[https://builds.apache.org/job/HBase-0.98-matrix/329/])
HBASE-15637 TSHA Thrift-2 server should allow limiting call queue size
(apurtell: rev a09ed49683551361947adcc1e6551799645f3058)
* hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java
> Thrift::Socket->isOpen() throws 'Can't use string ("1") as an ARRAY ref while
> "strict refs" in use at /usr/local/lib/perl5/site_perl/5.8.8/Thrift/Socket.pm
> line 87.'
> -
>
> Key: THRIFT-2
> URL: https://issues.apache.org/jira/browse/THRIFT-2
> Project: Thrift
> Issue Type: Bug
> Components: Perl - Library
> Environment: Linux (CentOS release 5), thrift-20080411, perl 5.8.8
>Reporter: Josh Rotenberg
>Assignee: T Jake Luciani
>Priority: Minor
> Attachments: Socket.pm.patch
>
>
> Trying to call $socket->isOpen on an opened socket dies with:
>
> Can't use string ("1") as an ARRAY ref while "strict refs" in use at
> /usr/local/lib/perl5/site_perl/5.8.8/Thrift/Socket.pm line 87.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3788) Compatibility improvements and Win64 support
[ https://issues.apache.org/jira/browse/THRIFT-3788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15242379#comment-15242379 ] Hudson commented on THRIFT-3788: FAILURE: Integrated in Thrift-precommit #419 (See [https://builds.apache.org/job/Thrift-precommit/419/]) THRIFT-3788 Compatibility improvements and Win64 support Client: Delphi (jensg: [https://github.com/apache/thrift/commit/4f5229e4a7cb49eb376021be586019d8dc325299]) * lib/delphi/src/Thrift.Utils.pas * lib/delphi/src/Thrift.Transport.pas * lib/delphi/src/Thrift.Server.pas * lib/delphi/src/Thrift.Serializer.pas * lib/delphi/src/Thrift.Stream.pas * lib/delphi/src/Thrift.Transport.Pipes.pas THRIFT-3788 Compatibility improvements and Win64 support Client: Delphi (jensg: [https://github.com/apache/thrift/commit/9f7f11e73ba2622397b3586468628032b1d26688]) * lib/delphi/src/Thrift.Transport.Pipes.pas * lib/delphi/src/Thrift.Server.pas * lib/delphi/test/server.dpr * lib/delphi/test/TestClient.pas * lib/delphi/src/Thrift.Stream.pas * lib/delphi/test/client.dpr * lib/delphi/src/Thrift.Defines.inc * lib/delphi/src/Thrift.Console.pas * lib/delphi/test/TestServer.pas * lib/delphi/src/Thrift.Utils.pas * lib/delphi/src/Thrift.Serializer.pas * lib/delphi/src/Thrift.Transport.pas > Compatibility improvements and Win64 support > > > Key: THRIFT-3788 > URL: https://issues.apache.org/jira/browse/THRIFT-3788 > Project: Thrift > Issue Type: Improvement > Components: Delphi - Library >Affects Versions: 0.9.3 > Environment: windows x32/x64 >Reporter: Nick Homolibere >Assignee: Jens Geyer > Labels: github-import, windows > Fix For: 0.10.0 > > Attachments: > 0002-THRIFT-3788-Compatibility-improvements-and-Win64-sup.patch > > > Add support for Delphi up to XE10 Seattle. > There are allot of missing IFDEFs. And unit Sockets was renamed several times. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3038) Use of volatile in cpp library
[ https://issues.apache.org/jira/browse/THRIFT-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15241070#comment-15241070 ] Hudson commented on THRIFT-3038: FAILURE: Integrated in Thrift-precommit #410 (See [https://builds.apache.org/job/Thrift-precommit/410/]) THRIFT-3038: fix a couple races and removed volatile per analysis (jim.king: [https://github.com/apache/thrift/commit/cb4849abc4156d64532989344a4b2c2fa8be8148]) * lib/cpp/src/thrift/server/TThreadPoolServer.h * lib/cpp/src/thrift/server/TThreadPoolServer.cpp * lib/cpp/src/thrift/transport/TFileTransport.h > Use of volatile in cpp library > -- > > Key: THRIFT-3038 > URL: https://issues.apache.org/jira/browse/THRIFT-3038 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.9.2 >Reporter: Adriaan Schmidt > > In the cpp library there are several member variables which are declared > volatile, I believe with the intention of providing some sort of > thread-safety. > While volatile can be used in this way in Java and C#, in C++ it cannot! It > does not provide any guarantees with regard to instruction (re-)ordering, > i.e. there are no implied memory barriers like you would get by using > explicit locking or atomic variables. > This means that all uses of volatile should be examined, the volatile > qualifier should be removed and replaced by proper synchronization. > The affected member variables are: > # NoStarveReadWriteMutex::writerWaiting_ > Unprotected read access in acquireRead(). Data race can be seen by running > the unit test with Helgrind. > # TFileTransport::forceFlush_ > Always accessed while holding mutex_. In this case, the volatile can just be > removed. > # TFileTransport::closing_ > Sometimes accessed while holding mutex_ (in combination with the notEmpty_ > Monitor), > but, e.g., enqueueEvent reads closing_ without any synchronization. > # TThreadPoolServer::stop_, TThreadedServer::stop_ > Accessed (read and written) without synchronization. These would probably be > fine using an atomic data type. Or, use explicit locking or signaling. > # TThreadPoolServer::timeout_, TThreadPoolServer::taskExpiration_ > Should probably use a lock. > # Mutex.cpp has mutexProfilingCounter as static variable. This probably > doesn’t break anything, but still the volatile serves no real purpose. > While some of the fixes are probably simple, in general I think someone with > better knowledge of the code should have a look at this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2821) Enable the use of custom HTTP-Header in the Transport
[ https://issues.apache.org/jira/browse/THRIFT-2821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240947#comment-15240947 ] Hudson commented on THRIFT-2821: FAILURE: Integrated in Thrift-precommit #408 (See [https://builds.apache.org/job/Thrift-precommit/408/]) THRIFT-2821: Add HTTP header support to JavaScript lib Client: (ra: [https://github.com/apache/thrift/commit/3ca89e60d231f1f466232599b7138536f401845b]) * lib/js/src/thrift.js > Enable the use of custom HTTP-Header in the Transport > - > > Key: THRIFT-2821 > URL: https://issues.apache.org/jira/browse/THRIFT-2821 > Project: Thrift > Issue Type: Improvement > Components: JavaScript - Library >Affects Versions: 0.9.2 > Environment: Browser >Reporter: David Sautter >Assignee: Randy Abernethy >Priority: Trivial > Labels: features > Fix For: 0.10.0 > > Attachments: > 0001-THRIFT-2821-Enable-the-use-of-custom-HTTP-Header-in-.patch, javascript > http header support.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > Several Thrift server implementations (for example csharp) enable to read > custom HTTP Headers, but the JavaScript Client is not yet able to provide > them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3763) Fix serialization of i64 larger than 2^53 for browserify
[ https://issues.apache.org/jira/browse/THRIFT-3763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240945#comment-15240945 ] Hudson commented on THRIFT-3763: FAILURE: Integrated in Thrift-precommit #408 (See [https://builds.apache.org/job/Thrift-precommit/408/]) THRIFT-3763 Fix serialization of i64 larger than 2^53 for browserify (nsuke: [https://github.com/apache/thrift/commit/abbc8d0ec19850f7ce1125a7f8b1fc9878aac052]) * lib/nodejs/lib/thrift/int64_util.js > Fix serialization of i64 larger than 2^53 for browserify > > > Key: THRIFT-3763 > URL: https://issues.apache.org/jira/browse/THRIFT-3763 > Project: Thrift > Issue Type: Bug > Components: Node.js - Library > Environment: browserify 13.0.0 >Reporter: Aki Sukegawa >Assignee: Aki Sukegawa > Fix For: 0.10.0 > > > Apparently, storing negative value to Buffer works for node but not for > browserify. > Forcing positive value by (& 0xff) before storing fixed the problem. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3756) Improve requiredness documentation
[ https://issues.apache.org/jira/browse/THRIFT-3756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240935#comment-15240935 ] Hudson commented on THRIFT-3756: FAILURE: Integrated in Thrift-precommit #408 (See [https://builds.apache.org/job/Thrift-precommit/408/]) THRIFT-3756 Improve requiredness documentation Client: Website Patch: (jensg: [https://github.com/apache/thrift/commit/fe9222a6ec20d23d9cfd3ec9c793887f7212b313]) * doc/specs/idl.md > Improve requiredness documentation > -- > > Key: THRIFT-3756 > URL: https://issues.apache.org/jira/browse/THRIFT-3756 > Project: Thrift > Issue Type: Improvement > Components: Documentation, Website >Reporter: Jens Geyer >Assignee: Jens Geyer >Priority: Minor > Fix For: 0.10.0 > > > The documentation on the Apache Thrift web site regarding requiredness is > very minorish (that's an euphemism) and needs to be improved. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3762) Fix build warnings for deprecated Thrift "byte" fields
[ https://issues.apache.org/jira/browse/THRIFT-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240943#comment-15240943 ] Hudson commented on THRIFT-3762: FAILURE: Integrated in Thrift-precommit #408 (See [https://builds.apache.org/job/Thrift-precommit/408/]) THRIFT-3762 Fix warnings for deprecated Thrift "byte" fields (nsuke: [https://github.com/apache/thrift/commit/eb344a81913234183bd5f4ab63a872ca165d308d]) * test/DocTest.thrift * test/StressTest.thrift * test/DebugProtoTest.thrift * test/ThriftTest.thrift > Fix build warnings for deprecated Thrift "byte" fields > -- > > Key: THRIFT-3762 > URL: https://issues.apache.org/jira/browse/THRIFT-3762 > Project: Thrift > Issue Type: Improvement > Components: Build Process, Test Suite >Reporter: Aki Sukegawa >Assignee: Aki Sukegawa >Priority: Trivial > Fix For: 0.10.0 > > > "byte" fields in test/*.thrift is causing excessive amount of warnings for > build output. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3780) Fix dart int64 usage when compiled to js
[ https://issues.apache.org/jira/browse/THRIFT-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240942#comment-15240942 ] Hudson commented on THRIFT-3780: FAILURE: Integrated in Thrift-precommit #408 (See [https://builds.apache.org/job/Thrift-precommit/408/]) THRIFT-3780 Use fixnum Int64 to write/read binary encoded i64 Client: (merickson: [https://github.com/apache/thrift/commit/8b0b7e5eb419eaa47294fa0a70ab96b3a9a07d0b]) * lib/dart/lib/src/protocol/t_binary_protocol.dart > Fix dart int64 usage when compiled to js > > > Key: THRIFT-3780 > URL: https://issues.apache.org/jira/browse/THRIFT-3780 > Project: Thrift > Issue Type: Bug > Components: Dart - Library >Reporter: Steven > Fix For: 0.10.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3778) go client can not pass method parameter to server of other language if no field_id is given
[
https://issues.apache.org/jira/browse/THRIFT-3778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240937#comment-15240937
]
Hudson commented on THRIFT-3778:
FAILURE: Integrated in Thrift-precommit #408 (See
[https://builds.apache.org/job/Thrift-precommit/408/])
THRIFT-3778 go client can not pass method parameter to server of other (jensg:
[https://github.com/apache/thrift/commit/717334816de896acc5dac3f787d64b52e033b38f])
* compiler/cpp/src/generate/t_go_generator.cc
> go client can not pass method parameter to server of other language if no
> field_id is given
> ---
>
> Key: THRIFT-3778
> URL: https://issues.apache.org/jira/browse/THRIFT-3778
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
>Affects Versions: 0.9.3
>Reporter: Guo
>Assignee: Guo
> Fix For: 0.11.0
>
>
> go client can not pass method parameter to java server
> for example message.thrift
> {code:title=message.thrift|borderStyle=solid}
> namespace java test
> namespace csharp test
> namespace go test
> struct Message
> {
> 1: string text
> }
> service MessageProcessor {
> void process(Message message);
> }
> {code}
> We generated messageprocess.go as golang client and MessageProcessor.java as
> java server
> When go client send service method arguments "process_args", 1 is sent as the
> field_id of struct "message"
> {code:title=messageprocessor.go|borderStyle=solid}
> func (p *MessageProcessorProcessArgs) Write(oprot thrift.TProtocol) error {
> if err := oprot.WriteStructBegin("process_args"); err != nil {
> return thrift.PrependError(fmt.Sprintf("%T write struct begin error: ",
> p), err)
> }
> if err := p.writeField_1(oprot); err != nil {
> return err
> }
> ...
> }
> func (p *MessageProcessorProcessArgs) writeField_1(oprot thrift.TProtocol)
> (err error) {
> if err := oprot.WriteFieldBegin("message", thrift.STRUCT, 1); err != nil {
> return thrift.PrependError(fmt.Sprintf("%T write field begin error
> 1:message: ", p), err)
> }
> ...
> }
> {code}
> When java server try to receive service method arguments "process_args", -1
> is marked as the field_id of struct "message"
> {code:title=MessageProcessor.java|borderStyle=solid}
> private static class process_argsStandardScheme extends
> StandardScheme {
> ...
> iprot.readStructBegin();
> while (true)
> {
> schemeField = iprot.readFieldBegin();
> if (schemeField.type == org.apache.thrift.protocol.TType.STOP) {
> break;
> }
> switch (schemeField.id) {
> case -1: // MESSAGE
> if (schemeField.type == org.apache.thrift.protocol.TType.STRUCT) {
> struct.message = new Message();
> struct.message.read(iprot);
> struct.setMessageIsSet(true);
> } else {
> org.apache.thrift.protocol.TProtocolUtil.skip(iprot,
> schemeField.type);
> }
> break;
> default:
> org.apache.thrift.protocol.TProtocolUtil.skip(iprot,
> schemeField.type);
> }
> iprot.readFieldEnd();
> }
> iprot.readStructEnd();
> ...
> {code}
> Because of this, we always receive NULL "message" in java server.
> Compared to some other language implementation, I think it's a thrift go
> generator problem.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3758) TApplicationException::getType and TProtocolException::getType should be const
[ https://issues.apache.org/jira/browse/THRIFT-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240933#comment-15240933 ] Hudson commented on THRIFT-3758: FAILURE: Integrated in Thrift-precommit #408 (See [https://builds.apache.org/job/Thrift-precommit/408/]) THRIFT-3758 TApplicationException::getType and (nsuke: [https://github.com/apache/thrift/commit/d42d8be78fff22fab9f524d4766b61bb9053fd69]) * lib/cpp/src/thrift/TApplicationException.h * lib/cpp/src/thrift/protocol/TProtocolException.h > TApplicationException::getType and TProtocolException::getType should be const > -- > > Key: THRIFT-3758 > URL: https://issues.apache.org/jira/browse/THRIFT-3758 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Reporter: Ted Wang >Assignee: Ted Wang >Priority: Trivial > Fix For: 0.10.0 > > > I can't catch these exceptions by const-reference and then call get_type. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3761) Add debian package for Python3
[ https://issues.apache.org/jira/browse/THRIFT-3761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240941#comment-15240941 ] Hudson commented on THRIFT-3761: FAILURE: Integrated in Thrift-precommit #408 (See [https://builds.apache.org/job/Thrift-precommit/408/]) THRIFT-3761 Add debian package for Python3 (nsuke: [https://github.com/apache/thrift/commit/f43d0ca6e57c4c30ea742e5f80e086288e999ecb]) * debian/control * debian/rules * build/docker/debian/Dockerfile * build/docker/ubuntu/Dockerfile > Add debian package for Python3 > -- > > Key: THRIFT-3761 > URL: https://issues.apache.org/jira/browse/THRIFT-3761 > Project: Thrift > Issue Type: Improvement > Components: Build Process, Python - Library >Reporter: Aki Sukegawa >Assignee: Aki Sukegawa > Fix For: 0.10.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3765) memory leak in python compact protocol extension
[
https://issues.apache.org/jira/browse/THRIFT-3765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240949#comment-15240949
]
Hudson commented on THRIFT-3765:
FAILURE: Integrated in Thrift-precommit #408 (See
[https://builds.apache.org/job/Thrift-precommit/408/])
THRIFT-3765 fix memory leak in python compact protocol extension (nsuke:
[https://github.com/apache/thrift/commit/6657b8337d1aedfd2aed22a8cdcf4b96965ece26])
* lib/py/src/ext/protocol.tcc
> memory leak in python compact protocol extension
>
>
> Key: THRIFT-3765
> URL: https://issues.apache.org/jira/browse/THRIFT-3765
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
>Affects Versions: 0.10.0
>Reporter: Chandler May
>Assignee: Chandler May
> Fix For: 0.10.0
>
>
> There is a memory leak in the compact protocol encoder extension module
> introduced in THRIFT-3612. This leak is significant enough to prevent us
> from using the extension in practice.
> Example output from valgrind:
> {code}
> ==18238== 4,177,472 bytes in 96,403 blocks are definitely lost in loss record
> 3,534 of 3,534
> ==18238==at 0x4C29BFD: malloc (in
> /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
> ==18238==by 0x4EBD49C: PyObject_Malloc (in /usr/lib64/libpython2.7.so.1.0)
> ==18238==by 0x4EC6381: PyString_FromStringAndSize (in
> /usr/lib64/libpython2.7.so.1.0)
> ==18238==by 0x4EE9669: PyUnicodeUCS4_EncodeUTF8 (in
> /usr/lib64/libpython2.7.so.1.0)
> ==18238==by 0x143D0CC7:
> apache::thrift::py::ProtocolBase::encodeValue(_object*,
> apache::thrift::py::TType, _object*) (protocol.tcc:422)
> ==18238==by 0x143D085B: writeField (compact.h:100)
> ==18238==by 0x143D085B:
> apache::thrift::py::ProtocolBase::encodeValue(_object*,
> apache::thrift::py::TType, _object*) (protocol.tcc:531)
> ==18238==by 0x143D0F71:
> apache::thrift::py::ProtocolBase::encodeValue(_object*,
> apache::thrift::py::TType, _object*) (protocol.tcc:459)
> ==18238==by 0x143D085B: writeField (compact.h:100)
> ==18238==by 0x143D085B:
> apache::thrift::py::ProtocolBase::encodeValue(_object*,
> apache::thrift::py::TType, _object*) (protocol.tcc:531)
> ==18238==by 0x143D085B: writeField (compact.h:100)
> ==18238==by 0x143D085B:
> apache::thrift::py::ProtocolBase::encodeValue(_object*,
> apache::thrift::py::TType, _object*) (protocol.tcc:531)
> ==18238==by 0x143D085B: writeField (compact.h:100)
> ==18238==by 0x143D085B:
> apache::thrift::py::ProtocolBase::encodeValue(_object*,
> apache::thrift::py::TType, _object*) (protocol.tcc:531)
> ==18238==by 0x143D0F71:
> apache::thrift::py::ProtocolBase::encodeValue(_object*,
> apache::thrift::py::TType, _object*) (protocol.tcc:459)
> ==18238==by 0x143D085B: writeField (compact.h:100)
> ==18238==by 0x143D085B:
> apache::thrift::py::ProtocolBase::encodeValue(_object*,
> apache::thrift::py::TType, _object*) (protocol.tcc:531)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3755) TDebugProtocol::writeString hits assert in isprint on Windows with debug CRT
[ https://issues.apache.org/jira/browse/THRIFT-3755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240934#comment-15240934 ] Hudson commented on THRIFT-3755: FAILURE: Integrated in Thrift-precommit #408 (See [https://builds.apache.org/job/Thrift-precommit/408/]) THRIFT-3755 TDebugProtocol::writeString hits assert in isprint on (nsuke: [https://github.com/apache/thrift/commit/3bf5bf99334c2da212e5e3d14145a1783657877c]) * lib/cpp/src/thrift/protocol/TDebugProtocol.cpp > TDebugProtocol::writeString hits assert in isprint on Windows with debug CRT > > > Key: THRIFT-3755 > URL: https://issues.apache.org/jira/browse/THRIFT-3755 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.9.3 >Reporter: Ted Wang >Assignee: Ted Wang >Priority: Minor > Fix For: 0.10.0 > > > Passing characters <0 to std::isprint causes asserts. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3764) PHP "make install" does not install TMultiplexedProtocol.php nor TSimpleJSONProtocol.php
[
https://issues.apache.org/jira/browse/THRIFT-3764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240946#comment-15240946
]
Hudson commented on THRIFT-3764:
FAILURE: Integrated in Thrift-precommit #408 (See
[https://builds.apache.org/job/Thrift-precommit/408/])
THRIFT-3764: Ensure PHP TSimpleJSONProtocol and TMultiplexedProtocol (nsuke:
[https://github.com/apache/thrift/commit/4ab9a88496413087df1ee3256472b19c5b4be500])
* lib/php/Makefile.am
> PHP "make install" does not install TMultiplexedProtocol.php nor
> TSimpleJSONProtocol.php
>
>
> Key: THRIFT-3764
> URL: https://issues.apache.org/jira/browse/THRIFT-3764
> Project: Thrift
> Issue Type: Bug
> Components: PHP - Library
>Reporter: Mark Goldfinch
>Assignee: Mark Goldfinch
>Priority: Minor
> Labels: php
> Fix For: 0.10.0
>
>
> lib/php/Makefile.am does not include:
> {code}
> lib/Thrift/TMultiplexedProcessor.php
> lib/Thrift/Protocol/TMultiplexedProtocol.php
> lib/Thrift/Protocol/TProtocol.php
> lib/Thrift/Protocol/TProtocolDecorator.php
> lib/Thrift/Protocol/TSimpleJSONProtocol.php
> lib/Thrift/Protocol/SimpleJSON/CollectionMapKeyException.php
> lib/Thrift/Protocol/SimpleJSON/Context.php
> lib/Thrift/Protocol/SimpleJSON/ListContext.php
> lib/Thrift/Protocol/SimpleJSON/MapContext.php
> lib/Thrift/Protocol/SimpleJSON/StructContext.php
> {code}
> which are all support files for either TMultiplexedProtocol.php or
> TSimpleJSON.php.
> If using "make install" to install the PHP client library, these files are
> excluded.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3786) Node.js TLS emits 'connect' before connection is ready
[ https://issues.apache.org/jira/browse/THRIFT-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240939#comment-15240939 ] Hudson commented on THRIFT-3786: FAILURE: Integrated in Thrift-precommit #408 (See [https://builds.apache.org/job/Thrift-precommit/408/]) THRIFT-3786: Node TLS emits 'connect' before connection is ready Client: (ra: [https://github.com/apache/thrift/commit/0ea6c1d5d77f046f089f200c67cffb629f3fe11e]) * lib/nodejs/lib/thrift/connection.js > Node.js TLS emits 'connect' before connection is ready > -- > > Key: THRIFT-3786 > URL: https://issues.apache.org/jira/browse/THRIFT-3786 > Project: Thrift > Issue Type: Bug > Components: Node.js - Library >Reporter: James Reggio >Assignee: Randy Abernethy > Fix For: 0.10.0 > > > When using a TLS connection, the Node.js Thrift connection instance will emit > a `connect` event early, making it possible to lose commands. > `connect` is emitted by the Thrift connection instance when the underlying > socket is opened, instead of when the TLS handshake has completed. Making > matters worse, the offline queue is flushed during this premature `connect`, > which means that any commands issued prior to the TLS connection handshake > will be lost. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3776) Go code from multiple thrift files with the same namespace
[ https://issues.apache.org/jira/browse/THRIFT-3776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240938#comment-15240938 ] Hudson commented on THRIFT-3776: FAILURE: Integrated in Thrift-precommit #408 (See [https://builds.apache.org/job/Thrift-precommit/408/]) THRIFT-3776 Go code from multiple thrift files with the same namespace (jensg: [https://github.com/apache/thrift/commit/9b39e1686bdc61263894b26cfa7a86967e2afa30]) * compiler/cpp/src/generate/t_go_generator.cc > Go code from multiple thrift files with the same namespace > -- > > Key: THRIFT-3776 > URL: https://issues.apache.org/jira/browse/THRIFT-3776 > Project: Thrift > Issue Type: Improvement > Components: Go - Compiler >Affects Versions: 0.9.3 >Reporter: artem antonenko >Assignee: artem antonenko > Fix For: 0.11.0 > > > Currently compiler puts all generated Go code into two files - ttypes.go and > constants.go. Because of that you can't compile multiple thrift files with > the same namespace. They will just overwrite each other. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3746) JSON protocol left in incorrect state on read errors
[ https://issues.apache.org/jira/browse/THRIFT-3746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240948#comment-15240948 ] Hudson commented on THRIFT-3746: FAILURE: Integrated in Thrift-precommit #408 (See [https://builds.apache.org/job/Thrift-precommit/408/]) THRIFT-3746 JSON protocol left in incorrect state on read errors Client: (jensg: [https://github.com/apache/thrift/commit/51850abb7ed0a7304f60cbced853285c9b63f4cb]) * lib/go/thrift/simple_json_protocol.go * lib/go/thrift/json_protocol.go Revert "THRIFT-3746 JSON protocol left in incorrect state on read (nsuke: [https://github.com/apache/thrift/commit/3aa461b97b3230d357543808f1facf9898818f71]) * lib/go/thrift/json_protocol.go * lib/go/thrift/simple_json_protocol.go > JSON protocol left in incorrect state on read errors > > > Key: THRIFT-3746 > URL: https://issues.apache.org/jira/browse/THRIFT-3746 > Project: Thrift > Issue Type: Bug > Components: Go - Library >Reporter: Tyler Treat >Assignee: Tyler Treat > > This is related to THRIFT-3735, but the problem was not fully addressed > there. The JSON protocol's read buffer needs to be reset to avoid being put > in an invalid state on read errors. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3771) TBufferedTransport gets in invalid state on read/write errors
[ https://issues.apache.org/jira/browse/THRIFT-3771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240944#comment-15240944 ] Hudson commented on THRIFT-3771: FAILURE: Integrated in Thrift-precommit #408 (See [https://builds.apache.org/job/Thrift-precommit/408/]) THRIFT-3771 TBufferedTransport gets in invalid state on read/write (jensg: [https://github.com/apache/thrift/commit/cdc83335d60756c4bfb0d2c8af7933500c9e3c06]) * lib/go/thrift/buffered_transport.go > TBufferedTransport gets in invalid state on read/write errors > - > > Key: THRIFT-3771 > URL: https://issues.apache.org/jira/browse/THRIFT-3771 > Project: Thrift > Issue Type: Bug > Components: Go - Library >Reporter: Tyler Treat >Assignee: Tyler Treat > Fix For: 0.10.0 > > > Go's TBufferedTransport can enter an invalid state after an error occurs > while calling read, write, or flush. This is because TBufferedTransport uses > a bufio.ReadWriter, which "caches" the error returned by a call to read or > write such that subsequent calls return the same error. This can be > problematic if you wish to reuse the transport after a failed read or write. > The solution is to reset the reader/writer on failed calls. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3467) Go Maps for Thrift Sets Should Have Values of Type struct{}
[
https://issues.apache.org/jira/browse/THRIFT-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240936#comment-15240936
]
Hudson commented on THRIFT-3467:
FAILURE: Integrated in Thrift-precommit #408 (See
[https://builds.apache.org/job/Thrift-precommit/408/])
THRIFT-3467 Go Maps for Thrift Sets Should Have Values of Type struct{} (jensg:
[https://github.com/apache/thrift/commit/ca714c4397ed78bd880f0dd76526e3817ecc08f0])
* test/go/src/bin/stress/main.go
* lib/go/thrift/serializer_types_test.go
* lib/go/test/tests/client_error_test.go
* test/go/src/common/mock_handler.go
* test/go/src/common/printing_handler.go
* test/go/src/common/simple_handler.go
* compiler/cpp/src/generate/t_go_generator.cc
* lib/go/test/tests/thrifttest_handler.go
* lib/go/test/tests/thrifttest_driver.go
* test/go/src/common/clientserver_test.go
* lib/go/thrift/serializer_test.go
* test/go/src/bin/testclient/main.go
> Go Maps for Thrift Sets Should Have Values of Type struct{}
>
>
> Key: THRIFT-3467
> URL: https://issues.apache.org/jira/browse/THRIFT-3467
> Project: Thrift
> Issue Type: Improvement
> Components: Go - Compiler
>Affects Versions: 0.9.3
>Reporter: Tom Deering
>Assignee: artem antonenko
> Labels: golang
> Fix For: 0.11.0
>
>
> Sets in Thrift are currently turned into maps with boolean values in Go.
> Example:
> Thrift
> {code}
> namespace go bug
> service FooService{
> void bar (1:set foos)
> }
> {code}
> Go
> {code}
> func (p *FooServiceClient) Bar(foos map[string]bool) (err error)
> {code}
> Boolean map values waste memory. Map values should be of the zero-byte
> struct{} type.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3760) Fix install paths etc of debian packages for py and perl
[ https://issues.apache.org/jira/browse/THRIFT-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240940#comment-15240940 ] Hudson commented on THRIFT-3760: FAILURE: Integrated in Thrift-precommit #408 (See [https://builds.apache.org/job/Thrift-precommit/408/]) THRIFT-3760 Fix install paths etc of debian packages for py and perl (nsuke: [https://github.com/apache/thrift/commit/93bbdc8127cb6ebdd34350fbba1b3a0a4e8e4111]) * debian/rules * debian/control * debian/substvars > Fix install paths etc of debian packages for py and perl > > > Key: THRIFT-3760 > URL: https://issues.apache.org/jira/browse/THRIFT-3760 > Project: Thrift > Issue Type: Bug > Components: Build Process >Reporter: Aki Sukegawa >Assignee: Aki Sukegawa >Priority: Minor > Fix For: 0.10.0 > > > * Perl: /usr/usr/local -> /usr > * Python: /usr/local -> /usr > perl fix for "local" part is frankly bad but at least it works. > The patch also removes .pyo files from python package that should be > generated by install process instead. > This resolves most of lintian warnings. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3757) Fix various build warnings on Windows with VS2015 compiler
[ https://issues.apache.org/jira/browse/THRIFT-3757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240932#comment-15240932 ] Hudson commented on THRIFT-3757: FAILURE: Integrated in Thrift-precommit #408 (See [https://builds.apache.org/job/Thrift-precommit/408/]) THRIFT-3757 Fix various compile warnings with VS2015 (nsuke: [https://github.com/apache/thrift/commit/f98d59fc822dd6d05c6cd48c5b86d716469a48fc]) * lib/cpp/src/thrift/server/TNonblockingServer.cpp * lib/cpp/src/thrift/protocol/TJSONProtocol.cpp * lib/cpp/src/thrift/concurrency/TimerManager.cpp * lib/cpp/src/thrift/server/TServerFramework.cpp * lib/cpp/test/TransportTest.cpp * lib/cpp/src/thrift/transport/TSocket.cpp > Fix various build warnings on Windows with VS2015 compiler > -- > > Key: THRIFT-3757 > URL: https://issues.apache.org/jira/browse/THRIFT-3757 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.9.3 >Reporter: Ted Wang >Assignee: Ted Wang >Priority: Trivial > Fix For: 0.10.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2) Thrift::Socket->isOpen() throws 'Can't use string ("1") as an ARRAY ref while "strict refs" in use at /usr/local/lib/perl5/site_perl/5.8.8/Thrift/Socket.pm line 87.'
[
https://issues.apache.org/jira/browse/THRIFT-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240308#comment-15240308
]
Hudson commented on THRIFT-2:
-
SUCCESS: Integrated in HBase-1.3 #648 (See
[https://builds.apache.org/job/HBase-1.3/648/])
HBASE-15637 TSHA Thrift-2 server should allow limiting call queue size
(antonov: rev 0cf60611541764c5a8d5db4f5eedd0e58aeef42f)
* hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java
> Thrift::Socket->isOpen() throws 'Can't use string ("1") as an ARRAY ref while
> "strict refs" in use at /usr/local/lib/perl5/site_perl/5.8.8/Thrift/Socket.pm
> line 87.'
> -
>
> Key: THRIFT-2
> URL: https://issues.apache.org/jira/browse/THRIFT-2
> Project: Thrift
> Issue Type: Bug
> Components: Perl - Library
> Environment: Linux (CentOS release 5), thrift-20080411, perl 5.8.8
>Reporter: Josh Rotenberg
>Assignee: T Jake Luciani
>Priority: Minor
> Attachments: Socket.pm.patch
>
>
> Trying to call $socket->isOpen on an opened socket dies with:
>
> Can't use string ("1") as an ARRAY ref while "strict refs" in use at
> /usr/local/lib/perl5/site_perl/5.8.8/Thrift/Socket.pm line 87.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-2) Thrift::Socket->isOpen() throws 'Can't use string ("1") as an ARRAY ref while "strict refs" in use at /usr/local/lib/perl5/site_perl/5.8.8/Thrift/Socket.pm line 87.'
[
https://issues.apache.org/jira/browse/THRIFT-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240253#comment-15240253
]
Hudson commented on THRIFT-2:
-
FAILURE: Integrated in HBase-Trunk_matrix #845 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/845/])
HBASE-15637 TSHA Thrift-2 server should allow limiting call queue size
(antonov: rev 0bb18de91c69ec43dc5118e59035686c586f3372)
* hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java
> Thrift::Socket->isOpen() throws 'Can't use string ("1") as an ARRAY ref while
> "strict refs" in use at /usr/local/lib/perl5/site_perl/5.8.8/Thrift/Socket.pm
> line 87.'
> -
>
> Key: THRIFT-2
> URL: https://issues.apache.org/jira/browse/THRIFT-2
> Project: Thrift
> Issue Type: Bug
> Components: Perl - Library
> Environment: Linux (CentOS release 5), thrift-20080411, perl 5.8.8
>Reporter: Josh Rotenberg
>Assignee: T Jake Luciani
>Priority: Minor
> Attachments: Socket.pm.patch
>
>
> Trying to call $socket->isOpen on an opened socket dies with:
>
> Can't use string ("1") as an ARRAY ref while "strict refs" in use at
> /usr/local/lib/perl5/site_perl/5.8.8/Thrift/Socket.pm line 87.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-2) Thrift::Socket->isOpen() throws 'Can't use string ("1") as an ARRAY ref while "strict refs" in use at /usr/local/lib/perl5/site_perl/5.8.8/Thrift/Socket.pm line 87.'
[
https://issues.apache.org/jira/browse/THRIFT-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240203#comment-15240203
]
Hudson commented on THRIFT-2:
-
SUCCESS: Integrated in HBase-1.3-IT #611 (See
[https://builds.apache.org/job/HBase-1.3-IT/611/])
HBASE-15637 TSHA Thrift-2 server should allow limiting call queue size
(antonov: rev 0cf60611541764c5a8d5db4f5eedd0e58aeef42f)
* hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java
> Thrift::Socket->isOpen() throws 'Can't use string ("1") as an ARRAY ref while
> "strict refs" in use at /usr/local/lib/perl5/site_perl/5.8.8/Thrift/Socket.pm
> line 87.'
> -
>
> Key: THRIFT-2
> URL: https://issues.apache.org/jira/browse/THRIFT-2
> Project: Thrift
> Issue Type: Bug
> Components: Perl - Library
> Environment: Linux (CentOS release 5), thrift-20080411, perl 5.8.8
>Reporter: Josh Rotenberg
>Assignee: T Jake Luciani
>Priority: Minor
> Attachments: Socket.pm.patch
>
>
> Trying to call $socket->isOpen on an opened socket dies with:
>
> Can't use string ("1") as an ARRAY ref while "strict refs" in use at
> /usr/local/lib/perl5/site_perl/5.8.8/Thrift/Socket.pm line 87.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-2) Thrift::Socket->isOpen() throws 'Can't use string ("1") as an ARRAY ref while "strict refs" in use at /usr/local/lib/perl5/site_perl/5.8.8/Thrift/Socket.pm line 87.'
[
https://issues.apache.org/jira/browse/THRIFT-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15240142#comment-15240142
]
Hudson commented on THRIFT-2:
-
FAILURE: Integrated in HBase-1.4 #87 (See
[https://builds.apache.org/job/HBase-1.4/87/])
HBASE-15637 TSHA Thrift-2 server should allow limiting call queue size
(antonov: rev a57eb1759c38c270fd5b1ed8376451589734e538)
* hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java
> Thrift::Socket->isOpen() throws 'Can't use string ("1") as an ARRAY ref while
> "strict refs" in use at /usr/local/lib/perl5/site_perl/5.8.8/Thrift/Socket.pm
> line 87.'
> -
>
> Key: THRIFT-2
> URL: https://issues.apache.org/jira/browse/THRIFT-2
> Project: Thrift
> Issue Type: Bug
> Components: Perl - Library
> Environment: Linux (CentOS release 5), thrift-20080411, perl 5.8.8
>Reporter: Josh Rotenberg
>Assignee: T Jake Luciani
>Priority: Minor
> Attachments: Socket.pm.patch
>
>
> Trying to call $socket->isOpen on an opened socket dies with:
>
> Can't use string ("1") as an ARRAY ref while "strict refs" in use at
> /usr/local/lib/perl5/site_perl/5.8.8/Thrift/Socket.pm line 87.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3786) Node.js TLS emits 'connect' before connection is ready
[ https://issues.apache.org/jira/browse/THRIFT-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15236440#comment-15236440 ] Hudson commented on THRIFT-3786: FAILURE: Integrated in Thrift-precommit #404 (See [https://builds.apache.org/job/Thrift-precommit/404/]) THRIFT-3786 Fix premature firing of `connect` event for secure sockets (james.reggio: [https://github.com/apache/thrift/commit/b76bad70826d539ddfb26b5277ff3bc09ffa9803]) * lib/nodejs/lib/thrift/connection.js > Node.js TLS emits 'connect' before connection is ready > -- > > Key: THRIFT-3786 > URL: https://issues.apache.org/jira/browse/THRIFT-3786 > Project: Thrift > Issue Type: Bug > Components: Node.js - Library >Reporter: James Reggio >Assignee: Randy Abernethy > Fix For: 0.10.0 > > > When using a TLS connection, the Node.js Thrift connection instance will emit > a `connect` event early, making it possible to lose commands. > `connect` is emitted by the Thrift connection instance when the underlying > socket is opened, instead of when the TLS handshake has completed. Making > matters worse, the offline queue is flushed during this premature `connect`, > which means that any commands issued prior to the TLS connection handshake > will be lost. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3768) TThreadedServer may crash if it is destroyed immediately after it returns from serve(); TThreadedServer disconnects clients when they connec
[ https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15234116#comment-15234116 ] Hudson commented on THRIFT-3768: FAILURE: Integrated in Thrift-precommit #403 (See [https://builds.apache.org/job/Thrift-precommit/403/]) THRIFT-3768: ensure TThreadedServer guarantees the lifetime of the (jim.king: [https://github.com/apache/thrift/commit/acfa3ea233d4218a39255f434a9bc82ea49353af]) * lib/cpp/src/thrift/server/TThreadedServer.cpp * lib/cpp/src/thrift/server/TServerFramework.h * lib/cpp/src/thrift/server/TServerFramework.cpp * lib/cpp/src/thrift/server/TThreadedServer.h THRIFT-3768: properly join TThreadedServer threads, added a stress test (jim.king: [https://github.com/apache/thrift/commit/a3a1bf86eec1b3f25e16934700154f46526576ae]) * lib/cpp/src/thrift/server/TThreadedServer.h * lib/cpp/test/TServerIntegrationTest.cpp * lib/cpp/src/thrift/concurrency/Thread.h * lib/cpp/src/thrift/server/TThreadedServer.cpp THRIFT-3768: small maintainability change (jim.king: [https://github.com/apache/thrift/commit/9410809bb8df7c9742e37c93c0cb4785e2d2de1c]) * lib/cpp/src/thrift/server/TThreadedServer.cpp > TThreadedServer may crash if it is destroyed immediately after it returns > from serve(); TThreadedServer disconnects clients when they connec > > > Key: THRIFT-3768 > URL: https://issues.apache.org/jira/browse/THRIFT-3768 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.9.3 >Reporter: Ted Wang >Assignee: James E. King, III >Priority: Minor > > Here's a sequence that shows the race: > Thread-1 (Users of TThreadedServer): Calls TThreadedServer::stop(), which > calls interruptChildren and initiates the tearing down of client connections. > Thread-2: In TServerFramework::serve(), broke out of accept, and now blocks > in TThreadedServer::serve() waiting to drain all the clients. > Thread-3 (The connected client thread created by TThreadedServer): In > disposeConnectedClient, running because the server is shutting down and the > shared_ptr specified this function to be the cleanup function for the client. > This thread just returned from onClientDisconnected and now context switches. > Thread-2: TThreadedServer::serve() is notified that all of the clients have > disconnected and completes. > Thread-1: Joins on Thread-2 and destroys the server object because it is done. > Thread-3: Finally gets a chance to run, but now encounters undefined behavior > because it is still executing a member function of an object that has been > destroyed. > You can force this race in action if you put sleep(1) before > onClientDisconnected() in disposeConnectedClient -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3768) TThreadedServer may crash if it is destroyed immediately after it returns from serve(); TThreadedServer disconnects clients when they connec
[ https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15233147#comment-15233147 ] Hudson commented on THRIFT-3768: FAILURE: Integrated in Thrift-precommit #402 (See [https://builds.apache.org/job/Thrift-precommit/402/]) THRIFT-3768: ensure TThreadedServer guarantees the lifetime of the (jim.king: [https://github.com/apache/thrift/commit/7132ec16086daf2b2808e3a91f78ecfbca6a5dab]) * lib/cpp/src/thrift/server/TServerFramework.cpp * lib/cpp/src/thrift/server/TThreadedServer.h * lib/cpp/src/thrift/server/TServerFramework.h * lib/cpp/src/thrift/server/TThreadedServer.cpp THRIFT-3768: properly join TThreadedServer threads, added a stress test (jim.king: [https://github.com/apache/thrift/commit/8627e5d391489aafbd8892d9d57296b0358e2015]) * lib/cpp/src/thrift/server/TThreadedServer.cpp * lib/cpp/test/TServerIntegrationTest.cpp * lib/cpp/src/thrift/server/TThreadedServer.h * lib/cpp/src/thrift/concurrency/Thread.h THRIFT-3768: small maintainability change (jim.king: [https://github.com/apache/thrift/commit/e258a1ad1434edd04426caf0fb05b528d2b1503e]) * lib/cpp/src/thrift/server/TThreadedServer.cpp > TThreadedServer may crash if it is destroyed immediately after it returns > from serve(); TThreadedServer disconnects clients when they connec > > > Key: THRIFT-3768 > URL: https://issues.apache.org/jira/browse/THRIFT-3768 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.9.3 >Reporter: Ted Wang >Assignee: James E. King, III >Priority: Minor > > Here's a sequence that shows the race: > Thread-1 (Users of TThreadedServer): Calls TThreadedServer::stop(), which > calls interruptChildren and initiates the tearing down of client connections. > Thread-2: In TServerFramework::serve(), broke out of accept, and now blocks > in TThreadedServer::serve() waiting to drain all the clients. > Thread-3 (The connected client thread created by TThreadedServer): In > disposeConnectedClient, running because the server is shutting down and the > shared_ptr specified this function to be the cleanup function for the client. > This thread just returned from onClientDisconnected and now context switches. > Thread-2: TThreadedServer::serve() is notified that all of the clients have > disconnected and completes. > Thread-1: Joins on Thread-2 and destroys the server object because it is done. > Thread-3: Finally gets a chance to run, but now encounters undefined behavior > because it is still executing a member function of an object that has been > destroyed. > You can force this race in action if you put sleep(1) before > onClientDisconnected() in disposeConnectedClient -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3038) Use of volatile in cpp library
[ https://issues.apache.org/jira/browse/THRIFT-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229335#comment-15229335 ] Hudson commented on THRIFT-3038: FAILURE: Integrated in Thrift-precommit #392 (See [https://builds.apache.org/job/Thrift-precommit/392/]) THRIFT-3038: fix a couple races and removed volatile per analysis (jim.king: [https://github.com/apache/thrift/commit/cb4849abc4156d64532989344a4b2c2fa8be8148]) * lib/cpp/src/thrift/server/TThreadPoolServer.cpp * lib/cpp/src/thrift/server/TThreadPoolServer.h * lib/cpp/src/thrift/transport/TFileTransport.h > Use of volatile in cpp library > -- > > Key: THRIFT-3038 > URL: https://issues.apache.org/jira/browse/THRIFT-3038 > Project: Thrift > Issue Type: Bug > Components: C++ - Library >Affects Versions: 0.9.2 >Reporter: Adriaan Schmidt > > In the cpp library there are several member variables which are declared > volatile, I believe with the intention of providing some sort of > thread-safety. > While volatile can be used in this way in Java and C#, in C++ it cannot! It > does not provide any guarantees with regard to instruction (re-)ordering, > i.e. there are no implied memory barriers like you would get by using > explicit locking or atomic variables. > This means that all uses of volatile should be examined, the volatile > qualifier should be removed and replaced by proper synchronization. > The affected member variables are: > # NoStarveReadWriteMutex::writerWaiting_ > Unprotected read access in acquireRead(). Data race can be seen by running > the unit test with Helgrind. > # TFileTransport::forceFlush_ > Always accessed while holding mutex_. In this case, the volatile can just be > removed. > # TFileTransport::closing_ > Sometimes accessed while holding mutex_ (in combination with the notEmpty_ > Monitor), > but, e.g., enqueueEvent reads closing_ without any synchronization. > # TThreadPoolServer::stop_, TThreadedServer::stop_ > Accessed (read and written) without synchronization. These would probably be > fine using an atomic data type. Or, use explicit locking or signaling. > # TThreadPoolServer::timeout_, TThreadPoolServer::taskExpiration_ > Should probably use a lock. > # Mutex.cpp has mutexProfilingCounter as static variable. This probably > doesn’t break anything, but still the volatile serves no real purpose. > While some of the fixes are probably simple, in general I think someone with > better knowledge of the code should have a look at this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3779) Qt Client Android and Windows QTcpSocket
[ https://issues.apache.org/jira/browse/THRIFT-3779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228616#comment-15228616 ] Hudson commented on THRIFT-3779: FAILURE: Integrated in Thrift-precommit #386 (See [https://builds.apache.org/job/Thrift-precommit/386/]) THRIFT-3779 Qt Client Android and Windows QTcpSocket (gjergjiramku: [https://github.com/apache/thrift/commit/c07cf39775e0b39f5251b72c14419a583a87cc70]) * lib/cpp/libthriftQt/thrift/config.h * lib/cpp/README.md * lib/cpp/libthriftQt.pro THRIFT-3779 more informatin to link against the library and (gjergjiramku: [https://github.com/apache/thrift/commit/643320f2abc6f15c4e1268db19e369482a3196da]) * lib/cpp/README.md > Qt Client Android and Windows QTcpSocket > > > Key: THRIFT-3779 > URL: https://issues.apache.org/jira/browse/THRIFT-3779 > Project: Thrift > Issue Type: New Feature > Components: C++ - Library > Environment: Qt Windows, Qt Android on windows >Reporter: Gjergji Ramku >Priority: Minor > Labels: features > > Thrift Client library based on QTcpSocket. > QTcpSocket should help make a tcp socket client run on all platforms where Qt > runs. > Is there such port? > I already have a port that I have tested on Qt Android and Qt Windows clients. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3779) Qt Client Android and Windows QTcpSocket
[ https://issues.apache.org/jira/browse/THRIFT-3779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15227919#comment-15227919 ] Hudson commented on THRIFT-3779: FAILURE: Integrated in Thrift-precommit #385 (See [https://builds.apache.org/job/Thrift-precommit/385/]) THRIFT-3779 Qt Client Android and Windows QTcpSocket (gjergjiramku: [https://github.com/apache/thrift/commit/c07cf39775e0b39f5251b72c14419a583a87cc70]) * lib/cpp/README.md * lib/cpp/libthriftQt/thrift/config.h * lib/cpp/libthriftQt.pro > Qt Client Android and Windows QTcpSocket > > > Key: THRIFT-3779 > URL: https://issues.apache.org/jira/browse/THRIFT-3779 > Project: Thrift > Issue Type: New Feature > Components: C++ - Library > Environment: Qt Windows, Qt Android on windows >Reporter: Gjergji Ramku >Priority: Minor > Labels: features > > Thrift Client library based on QTcpSocket. > QTcpSocket should help make a tcp socket client run on all platforms where Qt > runs. > Is there such port? > I already have a port that I have tested on Qt Android and Qt Windows clients. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3774) The generated code should have exception_names meta info
[ https://issues.apache.org/jira/browse/THRIFT-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15224763#comment-15224763 ] Hudson commented on THRIFT-3774: FAILURE: Integrated in Thrift-precommit #367 (See [https://builds.apache.org/job/Thrift-precommit/367/]) THRIFT-3774 The generated code should have exception_names meta info (laozhp: [https://github.com/apache/thrift/commit/8e6d2927ab357d668182240468513e75e2273e04]) * compiler/cpp/src/generate/t_erl_generator.cc > The generated code should have exception_names meta info > > > Key: THRIFT-3774 > URL: https://issues.apache.org/jira/browse/THRIFT-3774 > Project: Thrift > Issue Type: Improvement > Components: Erlang - Compiler >Reporter: laozhp >Assignee: laozhp >Priority: Minor > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3771) TBufferedTransport gets in invalid state on read/write errors
[ https://issues.apache.org/jira/browse/THRIFT-3771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15222659#comment-15222659 ] Hudson commented on THRIFT-3771: FAILURE: Integrated in Thrift-precommit #363 (See [https://builds.apache.org/job/Thrift-precommit/363/]) THRIFT-3771 TBufferedTransport gets in invalid state on read/write (tyler.treat: [https://github.com/apache/thrift/commit/30fd0384a9cf5c67432a7a9f869c65e0f0350766]) * lib/go/thrift/buffered_transport.go > TBufferedTransport gets in invalid state on read/write errors > - > > Key: THRIFT-3771 > URL: https://issues.apache.org/jira/browse/THRIFT-3771 > Project: Thrift > Issue Type: Bug > Components: Go - Library >Reporter: Tyler Treat >Assignee: Tyler Treat > Fix For: 0.10.0 > > > Go's TBufferedTransport can enter an invalid state after an error occurs > while calling read, write, or flush. This is because TBufferedTransport uses > a bufio.ReadWriter, which "caches" the error returned by a call to read or > write such that subsequent calls return the same error. This can be > problematic if you wish to reuse the transport after a failed read or write. > The solution is to reset the reader/writer on failed calls. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3771) TBufferedTransport gets in invalid state on read/write errors
[ https://issues.apache.org/jira/browse/THRIFT-3771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15222056#comment-15222056 ] Hudson commented on THRIFT-3771: SUCCESS: Integrated in Thrift-precommit #362 (See [https://builds.apache.org/job/Thrift-precommit/362/]) THRIFT-3771 TBufferedTransport gets in invalid state on read/write (tyler.treat: [https://github.com/apache/thrift/commit/0b7723664b12ee86c003f76bd19bee722f4bbb7f]) * lib/go/thrift/buffered_transport.go > TBufferedTransport gets in invalid state on read/write errors > - > > Key: THRIFT-3771 > URL: https://issues.apache.org/jira/browse/THRIFT-3771 > Project: Thrift > Issue Type: Bug > Components: Go - Library >Reporter: Tyler Treat > > Go's TBufferedTransport can enter an invalid state after an error occurs > while calling read, write, or flush. This is because TBufferedTransport uses > a bufio.ReadWriter, which "caches" the error returned by a call to read or > write such that subsequent calls return the same error. This can be > problematic if you wish to reuse the transport after a failed read or write. > The solution is to reset the reader/writer on failed calls. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3765) memory leak in python compact protocol extension
[
https://issues.apache.org/jira/browse/THRIFT-3765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15214467#comment-15214467
]
Hudson commented on THRIFT-3765:
SUCCESS: Integrated in Thrift-precommit #355 (See
[https://builds.apache.org/job/Thrift-precommit/355/])
THRIFT-3765 fix memory leak in python compact protocol extension (cjmay4754:
[https://github.com/apache/thrift/commit/0208491f73aadcaad76917d41b1f921fdcaa239a])
* lib/py/src/ext/protocol.tcc
> memory leak in python compact protocol extension
>
>
> Key: THRIFT-3765
> URL: https://issues.apache.org/jira/browse/THRIFT-3765
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
>Affects Versions: 0.10.0
>Reporter: Chandler May
>
> There is a memory leak in the compact protocol encoder extension module
> introduced in THRIFT-3612. This leak is significant enough to prevent us
> from using the extension in practice.
> Example output from valgrind:
> {code}
> ==18238== 4,177,472 bytes in 96,403 blocks are definitely lost in loss record
> 3,534 of 3,534
> ==18238==at 0x4C29BFD: malloc (in
> /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
> ==18238==by 0x4EBD49C: PyObject_Malloc (in /usr/lib64/libpython2.7.so.1.0)
> ==18238==by 0x4EC6381: PyString_FromStringAndSize (in
> /usr/lib64/libpython2.7.so.1.0)
> ==18238==by 0x4EE9669: PyUnicodeUCS4_EncodeUTF8 (in
> /usr/lib64/libpython2.7.so.1.0)
> ==18238==by 0x143D0CC7:
> apache::thrift::py::ProtocolBase::encodeValue(_object*,
> apache::thrift::py::TType, _object*) (protocol.tcc:422)
> ==18238==by 0x143D085B: writeField (compact.h:100)
> ==18238==by 0x143D085B:
> apache::thrift::py::ProtocolBase::encodeValue(_object*,
> apache::thrift::py::TType, _object*) (protocol.tcc:531)
> ==18238==by 0x143D0F71:
> apache::thrift::py::ProtocolBase::encodeValue(_object*,
> apache::thrift::py::TType, _object*) (protocol.tcc:459)
> ==18238==by 0x143D085B: writeField (compact.h:100)
> ==18238==by 0x143D085B:
> apache::thrift::py::ProtocolBase::encodeValue(_object*,
> apache::thrift::py::TType, _object*) (protocol.tcc:531)
> ==18238==by 0x143D085B: writeField (compact.h:100)
> ==18238==by 0x143D085B:
> apache::thrift::py::ProtocolBase::encodeValue(_object*,
> apache::thrift::py::TType, _object*) (protocol.tcc:531)
> ==18238==by 0x143D085B: writeField (compact.h:100)
> ==18238==by 0x143D085B:
> apache::thrift::py::ProtocolBase::encodeValue(_object*,
> apache::thrift::py::TType, _object*) (protocol.tcc:531)
> ==18238==by 0x143D0F71:
> apache::thrift::py::ProtocolBase::encodeValue(_object*,
> apache::thrift::py::TType, _object*) (protocol.tcc:459)
> ==18238==by 0x143D085B: writeField (compact.h:100)
> ==18238==by 0x143D085B:
> apache::thrift::py::ProtocolBase::encodeValue(_object*,
> apache::thrift::py::TType, _object*) (protocol.tcc:531)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3765) memory leak in python compact protocol extension
[
https://issues.apache.org/jira/browse/THRIFT-3765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213800#comment-15213800
]
Hudson commented on THRIFT-3765:
SUCCESS: Integrated in Thrift-precommit #353 (See
[https://builds.apache.org/job/Thrift-precommit/353/])
THRIFT-3765 fix memory leak in python compact protocol extension (cjmay4754:
[https://github.com/apache/thrift/commit/39c1bf3d483a4978aeb7872a0a71d235552aafb2])
* lib/py/src/ext/protocol.tcc
> memory leak in python compact protocol extension
>
>
> Key: THRIFT-3765
> URL: https://issues.apache.org/jira/browse/THRIFT-3765
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
>Affects Versions: 0.10.0
>Reporter: Chandler May
>
> There is a memory leak in the compact protocol encoder extension module
> introduced in THRIFT-3612. This leak is significant enough to prevent us
> from using the extension in practice.
> Example output from valgrind:
> {code}
> ==18238== 4,177,472 bytes in 96,403 blocks are definitely lost in loss record
> 3,534 of 3,534
> ==18238==at 0x4C29BFD: malloc (in
> /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
> ==18238==by 0x4EBD49C: PyObject_Malloc (in /usr/lib64/libpython2.7.so.1.0)
> ==18238==by 0x4EC6381: PyString_FromStringAndSize (in
> /usr/lib64/libpython2.7.so.1.0)
> ==18238==by 0x4EE9669: PyUnicodeUCS4_EncodeUTF8 (in
> /usr/lib64/libpython2.7.so.1.0)
> ==18238==by 0x143D0CC7:
> apache::thrift::py::ProtocolBase::encodeValue(_object*,
> apache::thrift::py::TType, _object*) (protocol.tcc:422)
> ==18238==by 0x143D085B: writeField (compact.h:100)
> ==18238==by 0x143D085B:
> apache::thrift::py::ProtocolBase::encodeValue(_object*,
> apache::thrift::py::TType, _object*) (protocol.tcc:531)
> ==18238==by 0x143D0F71:
> apache::thrift::py::ProtocolBase::encodeValue(_object*,
> apache::thrift::py::TType, _object*) (protocol.tcc:459)
> ==18238==by 0x143D085B: writeField (compact.h:100)
> ==18238==by 0x143D085B:
> apache::thrift::py::ProtocolBase::encodeValue(_object*,
> apache::thrift::py::TType, _object*) (protocol.tcc:531)
> ==18238==by 0x143D085B: writeField (compact.h:100)
> ==18238==by 0x143D085B:
> apache::thrift::py::ProtocolBase::encodeValue(_object*,
> apache::thrift::py::TType, _object*) (protocol.tcc:531)
> ==18238==by 0x143D085B: writeField (compact.h:100)
> ==18238==by 0x143D085B:
> apache::thrift::py::ProtocolBase::encodeValue(_object*,
> apache::thrift::py::TType, _object*) (protocol.tcc:531)
> ==18238==by 0x143D0F71:
> apache::thrift::py::ProtocolBase::encodeValue(_object*,
> apache::thrift::py::TType, _object*) (protocol.tcc:459)
> ==18238==by 0x143D085B: writeField (compact.h:100)
> ==18238==by 0x143D085B:
> apache::thrift::py::ProtocolBase::encodeValue(_object*,
> apache::thrift::py::TType, _object*) (protocol.tcc:531)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3760) Fix install paths etc of debian packages for py and perl
[ https://issues.apache.org/jira/browse/THRIFT-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15212043#comment-15212043 ] Hudson commented on THRIFT-3760: FAILURE: Integrated in Thrift-precommit #351 (See [https://builds.apache.org/job/Thrift-precommit/351/]) THRIFT-3760 Fix install paths etc of debian packages for py and perl (nsuke: [https://github.com/apache/thrift/commit/7b60c223f05fe55bbd4f20a39a0c8f831f542307]) * debian/substvars * debian/control * debian/rules > Fix install paths etc of debian packages for py and perl > > > Key: THRIFT-3760 > URL: https://issues.apache.org/jira/browse/THRIFT-3760 > Project: Thrift > Issue Type: Bug > Components: Build Process >Reporter: Aki Sukegawa >Assignee: Aki Sukegawa >Priority: Minor > > * Perl: /usr/usr/local -> /usr > * Python: /usr/local -> /usr > perl fix for "local" part is frankly bad but at least it works. > The patch also removes .pyo files from python package that should be > generated by install process instead. > This resolves most of lintian warnings. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3751) Compiler allows field ids that are too large for generated code
[
https://issues.apache.org/jira/browse/THRIFT-3751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15211286#comment-15211286
]
Hudson commented on THRIFT-3751:
SUCCESS: Integrated in Thrift-precommit #348 (See
[https://builds.apache.org/job/Thrift-precommit/348/])
THRIFT-3751 Compiler allows field ids that are too large for generated (jensg:
[https://github.com/apache/thrift/commit/06340a4664cd05cb78064a4216736c8aa4f782a8])
* compiler/cpp/src/thrifty.yy
> Compiler allows field ids that are too large for generated code
> ---
>
> Key: THRIFT-3751
> URL: https://issues.apache.org/jira/browse/THRIFT-3751
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (General)
> Environment: thrift 0.9.3
>Reporter: Ryan Greenberg
>Assignee: Jens Geyer
> Fix For: 0.10.0
>
> Attachments: big_field_ids.thrift, big_field_ids_max32.thrift
>
>
> Shorts are used to represent field ids in generated code for some languages
> (e.g. Java), however using a field id greater than max short does not produce
> an error and instead produced incorrect generated code.
> Compiling the attached big_field_ids_max32.thrift succeeds and produces this
> Java:
> {code}
> @SuppressWarnings({"cast", "rawtypes", "serial", "unchecked"})
> @Generated(value = "Autogenerated by Thrift Compiler (0.9.3)", date =
> "2016-03-22")
> public class BigFieldIds implements org.apache.thrift.TBase BigFieldIds._Fields>, java.io.Serializable, Cloneable,
> Comparable {
> private static final org.apache.thrift.protocol.TStruct STRUCT_DESC = new
> org.apache.thrift.protocol.TStruct("BigFieldIds");
> private static final org.apache.thrift.protocol.TField MAX1_FIELD_DESC =
> new org.apache.thrift.protocol.TField("max1",
> org.apache.thrift.protocol.TType.STRING, (short)1);
> private static final org.apache.thrift.protocol.TField MAX2_FIELD_DESC =
> new org.apache.thrift.protocol.TField("max2",
> org.apache.thrift.protocol.TType.STRING, (short)3);
> private static final org.apache.thrift.protocol.TField MAX3_FIELD_DESC =
> new org.apache.thrift.protocol.TField("max3",
> org.apache.thrift.protocol.TType.STRING, (short)7);
> private static final org.apache.thrift.protocol.TField MAX4_FIELD_DESC =
> new org.apache.thrift.protocol.TField("max4",
> org.apache.thrift.protocol.TType.STRING, (short)15);
> private static final org.apache.thrift.protocol.TField MAX5_FIELD_DESC =
> new org.apache.thrift.protocol.TField("max5",
> org.apache.thrift.protocol.TType.STRING, (short)31);
> private static final org.apache.thrift.protocol.TField MAX6_FIELD_DESC =
> new org.apache.thrift.protocol.TField("max6",
> org.apache.thrift.protocol.TType.STRING, (short)63);
> private static final org.apache.thrift.protocol.TField MAX7_FIELD_DESC =
> new org.apache.thrift.protocol.TField("max7",
> org.apache.thrift.protocol.TType.STRING, (short)127);
> private static final org.apache.thrift.protocol.TField MAX8_FIELD_DESC =
> new org.apache.thrift.protocol.TField("max8",
> org.apache.thrift.protocol.TType.STRING, (short)255);
> private static final org.apache.thrift.protocol.TField MAX9_FIELD_DESC =
> new org.apache.thrift.protocol.TField("max9",
> org.apache.thrift.protocol.TType.STRING, (short)511);
> private static final org.apache.thrift.protocol.TField MAX10_FIELD_DESC =
> new org.apache.thrift.protocol.TField("max10",
> org.apache.thrift.protocol.TType.STRING, (short)1023);
> private static final org.apache.thrift.protocol.TField MAX11_FIELD_DESC =
> new org.apache.thrift.protocol.TField("max11",
> org.apache.thrift.protocol.TType.STRING, (short)2047);
> private static final org.apache.thrift.protocol.TField MAX12_FIELD_DESC =
> new org.apache.thrift.protocol.TField("max12",
> org.apache.thrift.protocol.TType.STRING, (short)4095);
> private static final org.apache.thrift.protocol.TField MAX13_FIELD_DESC =
> new org.apache.thrift.protocol.TField("max13",
> org.apache.thrift.protocol.TType.STRING, (short)8191);
> private static final org.apache.thrift.protocol.TField MAX14_FIELD_DESC =
> new org.apache.thrift.protocol.TField("max14",
> org.apache.thrift.protocol.TType.STRING, (short)16383);
> private static final org.apache.thrift.protocol.TField MAX15_FIELD_DESC =
> new org.apache.thrift.protocol.TField("max15",
> org.apache.thrift.protocol.TType.STRING, (short)32767);
> private static final org.apache.thrift.protocol.TField MAX16_FIELD_DESC =
> new org.apache.thrift.protocol.TField("max16",
> org.apache.thrift.protocol.TType.STRING, (short)65535);
> private static final org.apache.thrift.protocol.TField MAX17_FIELD_DESC =
> new org.apache.thrift.protocol.TField("max17",
> org.apache.thrift.protocol.TType.STRING, (short)131071);
> private static final org.apa
[jira] [Commented] (THRIFT-3763) Fix serialization of i64 larger than 2^53 for browserify
[ https://issues.apache.org/jira/browse/THRIFT-3763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15211284#comment-15211284 ] Hudson commented on THRIFT-3763: SUCCESS: Integrated in Thrift-precommit #347 (See [https://builds.apache.org/job/Thrift-precommit/347/]) THRIFT-3763 Fix serialization of i64 larger than 2^53 for browserify (nsuke: [https://github.com/apache/thrift/commit/39ecd22d7ae87ff2783928c0b26816a8128ad49d]) * lib/nodejs/lib/thrift/int64_util.js > Fix serialization of i64 larger than 2^53 for browserify > > > Key: THRIFT-3763 > URL: https://issues.apache.org/jira/browse/THRIFT-3763 > Project: Thrift > Issue Type: Bug > Components: Node.js - Library > Environment: browserify 13.0.0 >Reporter: Aki Sukegawa >Assignee: Aki Sukegawa > > Apparently, storing negative value to Buffer works for node but not for > browserify. > Forcing positive value by (& 0xff) before storing fixed the problem. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3759) required fields that are nil are silently ignored on write
[
https://issues.apache.org/jira/browse/THRIFT-3759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15211285#comment-15211285
]
Hudson commented on THRIFT-3759:
SUCCESS: Integrated in Thrift-precommit #348 (See
[https://builds.apache.org/job/Thrift-precommit/348/])
THRIFT-3759 required fields that are nil are silently ignored on write (jensg:
[https://github.com/apache/thrift/commit/1043d71c2efb0ffdc2ec526c4177b97a8a0ff4c6])
* compiler/cpp/src/generate/t_delphi_generator.cc
> required fields that are nil are silently ignored on write
> --
>
> Key: THRIFT-3759
> URL: https://issues.apache.org/jira/browse/THRIFT-3759
> Project: Thrift
> Issue Type: Bug
> Components: Delphi - Library
>Affects Versions: 0.9.3
>Reporter: Jens Geyer
>Assignee: Jens Geyer
>Priority: Critical
> Fix For: 0.10.0
>
> Attachments:
> THRIFT-3759-required-fields-that-are-nil-are-silentl.patch
>
>
> The Delphi code generated for {{required}} fields silently ignores {{nil}}
> values, because {{nil}} values cannot be written. Consequently, the data
> stored this way cannot be read later on because of the missing members.
> {code}
> struct foo {
>// leaving this member nil will ignore the field on write
>// and thus make the data unreadable
>1 : required foo try_to_leave_me_nil
> }
> {code}
> The expected behaviour would be to throw an exception when the code is about
> to write required, but unset data.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3762) Fix build warnings for deprecated Thrift "byte" fields
[ https://issues.apache.org/jira/browse/THRIFT-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15211283#comment-15211283 ] Hudson commented on THRIFT-3762: FAILURE: Integrated in Thrift-precommit #346 (See [https://builds.apache.org/job/Thrift-precommit/346/]) THRIFT-3762 Fix warnings for deprecated Thrift "byte" fields (nsuke: [https://github.com/apache/thrift/commit/8cdb0d6cca53d5e38955a8ad22d6dda8e479a869]) * test/StressTest.thrift * test/DebugProtoTest.thrift * test/ThriftTest.thrift * test/DocTest.thrift > Fix build warnings for deprecated Thrift "byte" fields > -- > > Key: THRIFT-3762 > URL: https://issues.apache.org/jira/browse/THRIFT-3762 > Project: Thrift > Issue Type: Improvement > Components: Build Process, Test Suite >Reporter: Aki Sukegawa >Assignee: Aki Sukegawa >Priority: Trivial > > "byte" fields in test/*.thrift is causing excessive amount of warnings for > build output. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3750) NSCopying copyWithZone: implementation does not check isSet
[ https://issues.apache.org/jira/browse/THRIFT-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15203121#comment-15203121 ] Hudson commented on THRIFT-3750: SUCCESS: Integrated in Thrift-precommit #336 (See [https://builds.apache.org/job/Thrift-precommit/336/]) THRIFT-3750 Check isSet in copyWithZone (zach: [https://github.com/apache/thrift/commit/39894afdd79fc54652e57afb4e42c6c871a9ea77]) * compiler/cpp/src/generate/t_cocoa_generator.cc > NSCopying copyWithZone: implementation does not check isSet > --- > > Key: THRIFT-3750 > URL: https://issues.apache.org/jira/browse/THRIFT-3750 > Project: Thrift > Issue Type: Bug > Components: Cocoa - Compiler >Reporter: Zach Howe >Priority: Critical > > The NSCopying copyWithZone: implementation does not check isSet. This causes > the copy not to be a true copy, since all the isSet properties will be set to > YES on the newly copied object. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3739) Deprecation warning in codegen/base.d
[
https://issues.apache.org/jira/browse/THRIFT-3739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15200478#comment-15200478
]
Hudson commented on THRIFT-3739:
SUCCESS: Integrated in Thrift-precommit #327 (See
[https://builds.apache.org/job/Thrift-precommit/327/])
THRIFT-3739 Deprecation warning in codegen/base.d (nsuke:
[https://github.com/apache/thrift/commit/8e1fd869853e5b5d1aa97f69ac6b567b0e9c7ccd])
* lib/d/src/thrift/codegen/base.d
> Deprecation warning in codegen/base.d
> -
>
> Key: THRIFT-3739
> URL: https://issues.apache.org/jira/browse/THRIFT-3739
> Project: Thrift
> Issue Type: Bug
> Components: D - Library
>Affects Versions: 0.9.3
> Environment: dmd 2.070
>Reporter: Aki Sukegawa
>Assignee: Aki Sukegawa
>Priority: Trivial
> Fix For: 0.10.0
>
>
> {quote}
> ../../lib/d/src/thrift/codegen/base.d(502): Deprecation: this is not an lvalue
> {quote}
> https://travis-ci.org/apache/thrift/jobs/113139459#L5997
> It's caused by passing this pointer to "ref" parameter of "readStruct"
> function.
> Making the parameter to auto ref resolves the problem.
> This should be OK because the readStruct function is for internal use only.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3736) C++ library build fails if OpenSSL does not surrpot SSLv3
[ https://issues.apache.org/jira/browse/THRIFT-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15200173#comment-15200173 ] Hudson commented on THRIFT-3736: SUCCESS: Integrated in Thrift-precommit #325 (See [https://builds.apache.org/job/Thrift-precommit/325/]) THRIFT-3736 C++ library build fails if OpenSSL does not surrpot SSLv3 (nsuke: [https://github.com/apache/thrift/commit/53dc6e255bec2e4cd8bae85d14bec1cf28310d3f]) * lib/cpp/test/SecurityTest.cpp * lib/cpp/src/thrift/transport/TSSLSocket.cpp > C++ library build fails if OpenSSL does not surrpot SSLv3 > - > > Key: THRIFT-3736 > URL: https://issues.apache.org/jira/browse/THRIFT-3736 > Project: Thrift > Issue Type: Bug > Components: Build Process, C++ - Library > Environment: ArchLinux > OpenSSL 1.0.2g >Reporter: Aki Sukegawa >Assignee: Aki Sukegawa >Priority: Trivial > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3728) http transport for thrift-lua
[ https://issues.apache.org/jira/browse/THRIFT-3728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15198816#comment-15198816 ] Hudson commented on THRIFT-3728: SUCCESS: Integrated in Thrift-precommit #324 (See [https://builds.apache.org/job/Thrift-precommit/324/]) THRIFT-3728 http transport for thrift-lua (voipman: [https://github.com/apache/thrift/commit/a4dd37b45afd7236fe47a1ed3e33853e64470823]) * lib/lua/THttpTransport.lua THRIFT-3728 http transport for thrift-lua (voipman: [https://github.com/apache/thrift/commit/962c520262af0421c6cc47a0f04120f8e4d6c164]) * test/tests.json THRIFT-3728 http transport for thrift-lua (voipman: [https://github.com/apache/thrift/commit/ea4b0d8dacfdebbaf4f06261badb9a7e9e454188]) * test/lua/test_basic_client.lua THRIFT-3728 http transport for thrift-lua (voipman: [https://github.com/apache/thrift/commit/93b51547160f7ae7a5d08ad97d40f858c9c6584b]) * test/lua/test_basic_server.lua THRIFT-3728 http transport for thrift-lua (voipman: [https://github.com/apache/thrift/commit/e42fe710c7e92c6099c6adfde0ead54dfa5c070a]) * test/lua/test_basic_client.lua THRIFT-3728 http transport for thrift-lua (voipman: [https://github.com/apache/thrift/commit/c5238fd2df9ca4eb512691f87c9993b4d89b1a54]) * lib/lua/TSocket.lua THRIFT-3728 http transport for thrift-lua (voipman: [https://github.com/apache/thrift/commit/14c14f4cfdcd8357ffb96fc2e3a4d72e2c01ab10]) * lib/lua/THttpTransport.lua THRIFT-3728 http transport for thrift-lua (voipman: [https://github.com/apache/thrift/commit/3991b9bc7cb87999ea33dea63a342a03ea324c17]) * lib/lua/TServer.lua THRIFT-3728 http transport for thrift-lua (voipman: [https://github.com/apache/thrift/commit/ce8d8c9d5c3a196d4bb9e5dfb74e27d9f833c5c5]) * lib/lua/TSocket.lua THRIFT-3728 http transport for thrift-lua (voipman: [https://github.com/apache/thrift/commit/f54e60e11070249275b72a83a1882cc918088c14]) * lib/lua/THttpTransport.lua THRIFT-3728 http transport for thrift-lua (voipman: [https://github.com/apache/thrift/commit/ef2c8a0a516dfd5deda086daf41135680bd3da43]) * lib/lua/THttpTransport.lua THRIFT-3728 http transport for thrift-lua (voipman: [https://github.com/apache/thrift/commit/40a0072547c079b3b0e7ff61ffc4c0e750ecd18b]) * test/tests.json THRIFT-3728 http transport for thrift-lua (voipman: [https://github.com/apache/thrift/commit/cd1e6c024a3e992b05d9323ab4bedfebba2dd0e2]) * test/tests.json > http transport for thrift-lua > - > > Key: THRIFT-3728 > URL: https://issues.apache.org/jira/browse/THRIFT-3728 > Project: Thrift > Issue Type: Improvement > Components: Lua - Library >Affects Versions: 0.9.3 >Reporter: WangYaofu >Assignee: WangYaofu > Fix For: 0.9.3 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3723) Fix Lua include path
[ https://issues.apache.org/jira/browse/THRIFT-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15201292#comment-15201292 ] Hudson commented on THRIFT-3723: SUCCESS: Integrated in Thrift-precommit #328 (See [https://builds.apache.org/job/Thrift-precommit/328/]) THRIFT-3723 Fix Lua include path (nsuke: [https://github.com/apache/thrift/commit/19d86a23dde5d4696eea5251b4d2e193c15fe34c]) * lib/lua/Makefile.am * aclocal/ax_lua.m4 > Fix Lua include path > > > Key: THRIFT-3723 > URL: https://issues.apache.org/jira/browse/THRIFT-3723 > Project: Thrift > Issue Type: Bug > Components: Build Process, Lua - Library >Reporter: Aki Sukegawa >Assignee: Aki Sukegawa >Priority: Trivial > Fix For: 0.10.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3744) The precision should be 17 (16 bits need after dot) after dot for double type.
[
https://issues.apache.org/jira/browse/THRIFT-3744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15200479#comment-15200479
]
Hudson commented on THRIFT-3744:
SUCCESS: Integrated in Thrift-precommit #327 (See
[https://builds.apache.org/job/Thrift-precommit/327/])
THRIFT-3744 The precision should be 17 (16 bits need after dot) after (nsuke:
[https://github.com/apache/thrift/commit/7f6ea4e7fe6fc15955438e00335398424cf0fca4])
* lib/d/src/thrift/protocol/json.d
> The precision should be 17 (16 bits need after dot) after dot for double type.
> --
>
> Key: THRIFT-3744
> URL: https://issues.apache.org/jira/browse/THRIFT-3744
> Project: Thrift
> Issue Type: Bug
> Components: D - Library
>Affects Versions: 0.9.3
>Reporter: WangYaofu
>Assignee: WangYaofu
> Fix For: 0.10.0
>
>
> The precision is lost when converting double to string.
> E.g:
> double PI = 3.1415926535897931;
> string value = format("%.16g", PI);
> The value will be '3.141592653589793' and last 1 is lost after format
> operation.
> But expected value should be '3.1415926535897931'.
> Solution:
> string value = format("%.17g", PI);
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3746) JSON protocol left in incorrect state on read errors
[ https://issues.apache.org/jira/browse/THRIFT-3746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15201992#comment-15201992 ] Hudson commented on THRIFT-3746: SUCCESS: Integrated in Thrift-precommit #330 (See [https://builds.apache.org/job/Thrift-precommit/330/]) THRIFT-3746 JSON protocol left in incorrect state on read errors (tyler.treat: [https://github.com/apache/thrift/commit/7503e55f5cc3ed65e80cf0df1da9e76ba900e103]) * lib/go/thrift/json_protocol.go * lib/go/thrift/simple_json_protocol.go > JSON protocol left in incorrect state on read errors > > > Key: THRIFT-3746 > URL: https://issues.apache.org/jira/browse/THRIFT-3746 > Project: Thrift > Issue Type: Bug > Components: Go - Library >Reporter: Tyler Treat > > This is related to THRIFT-3735, but the problem was not fully addressed > there. The JSON protocol's read buffer needs to be reset to avoid being put > in an invalid state on read errors. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3723) Fix Lua include path
[ https://issues.apache.org/jira/browse/THRIFT-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15202841#comment-15202841 ] Hudson commented on THRIFT-3723: SUCCESS: Integrated in Thrift-precommit #335 (See [https://builds.apache.org/job/Thrift-precommit/335/]) THRIFT-3723 Fix Lua include path (nsuke: [https://github.com/apache/thrift/commit/a4f96403210566bd1e76fee9b6e40412ff014e0a]) * lib/lua/Makefile.am * aclocal/ax_lua.m4 > Fix Lua include path > > > Key: THRIFT-3723 > URL: https://issues.apache.org/jira/browse/THRIFT-3723 > Project: Thrift > Issue Type: Bug > Components: Build Process, Lua - Library >Reporter: Aki Sukegawa >Assignee: Aki Sukegawa >Priority: Trivial > Fix For: 0.10.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3747) Duplicate node.js build on Travis-CI
[ https://issues.apache.org/jira/browse/THRIFT-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15202847#comment-15202847 ] Hudson commented on THRIFT-3747: SUCCESS: Integrated in Thrift-precommit #335 (See [https://builds.apache.org/job/Thrift-precommit/335/]) THRIFT-3747 Duplicate node.js build on Travis-CI (nsuke: [https://github.com/apache/thrift/commit/6505312e0ad23795f84161db190b5a426fff6b42]) * .travis.yml > Duplicate node.js build on Travis-CI > > > Key: THRIFT-3747 > URL: https://issues.apache.org/jira/browse/THRIFT-3747 > Project: Thrift > Issue Type: Bug > Components: Build Process >Reporter: Aki Sukegawa >Assignee: Aki Sukegawa >Priority: Trivial > Fix For: 0.10.0 > > > As npm download is unstable, node.js build was supposed to be isolated into a > separate job on Travis (with haskell which is unstable due to cabal download). > In reality, node.js was built in "Java Lua ..." job too, so we've been having > double chance of download failures. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3112) [Java] AsyncMethodCallback should be typed in generated AsyncIface
[
https://issues.apache.org/jira/browse/THRIFT-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15202839#comment-15202839
]
Hudson commented on THRIFT-3112:
SUCCESS: Integrated in Thrift-precommit #335 (See
[https://builds.apache.org/job/Thrift-precommit/335/])
THRIFT-3112 [Java] AsyncMethodCallback should be typed in generated (nsuke:
[https://github.com/apache/thrift/commit/bd964c7f3460c308161cb6eb90583874a7d8d848])
* lib/java/src/org/apache/thrift/async/TAsyncMethodCall.java
* lib/java/test/org/apache/thrift/server/ServerTestBase.java
* test/DebugProtoTest.thrift
* lib/java/test/org/apache/thrift/protocol/ProtocolTestBase.java
* compiler/cpp/src/generate/t_java_generator.cc
* lib/java/test/org/apache/thrift/async/TestTAsyncClientManager.java
* lib/java/src/org/apache/thrift/async/AsyncMethodCallback.java
Follow-up THRIFT-3112: key.cancel when error (nsuke:
[https://github.com/apache/thrift/commit/c3072227c06c570135741b625db612aaccff67b3])
* lib/java/src/org/apache/thrift/async/TAsyncMethodCall.java
> [Java] AsyncMethodCallback should be typed in generated AsyncIface
> --
>
> Key: THRIFT-3112
> URL: https://issues.apache.org/jira/browse/THRIFT-3112
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Compiler, Java - Library
>Affects Versions: 0.9.2, 0.9.3
>Reporter: Sergei Egorov
>Assignee: John Sirois
> Fix For: 0.10.0
>
>
> AsyncMethodCallback is generic, but current Java code generator is not adding
> type info to it, and instead of:
> {code:java}
> public interface AsyncIface {
> public void ping(org.apache.thrift.async.AsyncMethodCallback
> resultHandler) throws org.apache.thrift.TException;
> }
> {code}
> we have:
> {code:java}
> public interface AsyncIface {
> public void ping(org.apache.thrift.async.AsyncMethodCallback
> resultHandler) throws org.apache.thrift.TException;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3736) C++ library build fails if OpenSSL does not surrpot SSLv3
[ https://issues.apache.org/jira/browse/THRIFT-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15202845#comment-15202845 ] Hudson commented on THRIFT-3736: SUCCESS: Integrated in Thrift-precommit #335 (See [https://builds.apache.org/job/Thrift-precommit/335/]) THRIFT-3736 C++ library build fails if OpenSSL does not surrpot SSLv3 (nsuke: [https://github.com/apache/thrift/commit/b819260c653f6fd9602419ee2541060ecb930c4c]) * lib/cpp/test/SecurityTest.cpp * lib/cpp/src/thrift/transport/TSSLSocket.cpp > C++ library build fails if OpenSSL does not surrpot SSLv3 > - > > Key: THRIFT-3736 > URL: https://issues.apache.org/jira/browse/THRIFT-3736 > Project: Thrift > Issue Type: Bug > Components: Build Process, C++ - Library > Environment: ArchLinux > OpenSSL 1.0.2g >Reporter: Aki Sukegawa >Assignee: Aki Sukegawa >Priority: Trivial > Fix For: 0.10.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3680) Java async processor fails to notify errors to clients
[ https://issues.apache.org/jira/browse/THRIFT-3680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15202842#comment-15202842 ] Hudson commented on THRIFT-3680: SUCCESS: Integrated in Thrift-precommit #335 (See [https://builds.apache.org/job/Thrift-precommit/335/]) THRIFT-3680 Java async processor fails to notify errors to clients (nsuke: [https://github.com/apache/thrift/commit/a8765276d80fa86d258fa323cfd30bfcf22a0d67]) * lib/java/src/org/apache/thrift/TServiceClient.java * lib/java/src/org/apache/thrift/TNonblockingMultiFetchClient.java * lib/java/src/org/apache/thrift/TBaseAsyncProcessor.java * lib/java/src/org/apache/thrift/async/TAsyncMethodCall.java * lib/java/src/org/apache/thrift/transport/TSSLTransportFactory.java * compiler/cpp/src/generate/t_java_generator.cc * lib/java/src/org/apache/thrift/server/TThreadPoolServer.java * lib/java/src/org/apache/thrift/AsyncProcessFunction.java * lib/java/src/org/apache/thrift/TNonblockingMultiFetchStats.java * lib/java/test/org/apache/thrift/server/ServerTestBase.java > Java async processor fails to notify errors to clients > -- > > Key: THRIFT-3680 > URL: https://issues.apache.org/jira/browse/THRIFT-3680 > Project: Thrift > Issue Type: Bug > Components: Java - Library >Reporter: Aki Sukegawa >Assignee: Aki Sukegawa > Fix For: 0.10.0 > > > Unlike its sync counter part, Java async processor has been ignoring any > errors. > It turned out that it was actually trying to send errors back and failing to > do so because of other bugs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3728) http transport for thrift-lua
[ https://issues.apache.org/jira/browse/THRIFT-3728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15202848#comment-15202848 ] Hudson commented on THRIFT-3728: SUCCESS: Integrated in Thrift-precommit #335 (See [https://builds.apache.org/job/Thrift-precommit/335/]) THRIFT-3728 http transport for thrift-lua (nsuke: [https://github.com/apache/thrift/commit/e432c6b828d70ee4901f1ec3e04b0145da2ce54e]) * test/lua/test_basic_server.lua * test/lua/test_basic_client.lua * lib/lua/TServer.lua * lib/lua/THttpTransport.lua * test/tests.json > http transport for thrift-lua > - > > Key: THRIFT-3728 > URL: https://issues.apache.org/jira/browse/THRIFT-3728 > Project: Thrift > Issue Type: Improvement > Components: Lua - Library >Affects Versions: 0.9.3 >Reporter: WangYaofu >Assignee: WangYaofu > Fix For: 0.10.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3449) TBaseAsyncProcessor fb.responseReady() never called for oneway functions
[ https://issues.apache.org/jira/browse/THRIFT-3449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15202846#comment-15202846 ] Hudson commented on THRIFT-3449: SUCCESS: Integrated in Thrift-precommit #335 (See [https://builds.apache.org/job/Thrift-precommit/335/]) THRIFT-3449 TBaseAsyncProcessor fb.responseReady() never called for (nsuke: [https://github.com/apache/thrift/commit/400ae6e76e07ec929125c1d78b11541eeb254de2]) * lib/java/src/org/apache/thrift/TBaseAsyncProcessor.java * compiler/cpp/src/generate/t_java_generator.cc * lib/java/test/org/apache/thrift/server/ServerTestBase.java > TBaseAsyncProcessor fb.responseReady() never called for oneway functions > > > Key: THRIFT-3449 > URL: https://issues.apache.org/jira/browse/THRIFT-3449 > Project: Thrift > Issue Type: Bug > Components: Java - Library >Affects Versions: 0.9.3 > Environment: java libthrift-0.9.3 >Reporter: Jan Sileny >Assignee: Aki Sukegawa > Labels: newbie, patch > Fix For: 0.10.0 > > Attachments: responseReadyPatch.patch > > > For regular service functions, fb.responseReady() is called from generated > AsyncProcessFunction's sendResponse(...). Precisely in its result handler's > AsyncMethodCallback onComplete or onError implementations. Because oneway > methods have void result handler's onComplete and onError implementations, > responseReady is not called and frame buffer never goes back to reading > state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3402) Provide a perl Unix Socket implementation
[ https://issues.apache.org/jira/browse/THRIFT-3402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15202840#comment-15202840 ] Hudson commented on THRIFT-3402: SUCCESS: Integrated in Thrift-precommit #335 (See [https://builds.apache.org/job/Thrift-precommit/335/]) Add make dist entires for THRIFT-3402 (nsuke: [https://github.com/apache/thrift/commit/834f1b45c78df42e132889c72c4feafe9b8e2e07]) * lib/perl/Makefile.am > Provide a perl Unix Socket implementation > - > > Key: THRIFT-3402 > URL: https://issues.apache.org/jira/browse/THRIFT-3402 > Project: Thrift > Issue Type: Improvement > Components: Perl - Library >Affects Versions: 0.9.3 >Reporter: James E. King, III >Assignee: James E. King, III >Priority: Minor > Fix For: 0.10.0 > > > Now that perl socket code was refactored with virtual overrides, it will be > easier to provide a unix socket implementation. > Desired usage: > server: > my $serversock = new Thrift::UnixServerSocket($path); > or > my $serversock = new Thrift::UnixServerSocket(path => $path, queue => $queue); > client: > my $sock = new Thrift::UnixSocket($path); > Leverage the refactored socket code in perl that was added in 0.9.3 using > virtual overrides. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3479) Oneway calls should not return exceptions to clients
[ https://issues.apache.org/jira/browse/THRIFT-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15202844#comment-15202844 ] Hudson commented on THRIFT-3479: SUCCESS: Integrated in Thrift-precommit #335 (See [https://builds.apache.org/job/Thrift-precommit/335/]) THRIFT-3479 Avoid returning a message to a client on TException. (nsuke: [https://github.com/apache/thrift/commit/b3a42dd050db2657a589b7b73e3d121211649fe5]) * lib/java/src/org/apache/thrift/ProcessFunction.java > Oneway calls should not return exceptions to clients > > > Key: THRIFT-3479 > URL: https://issues.apache.org/jira/browse/THRIFT-3479 > Project: Thrift > Issue Type: Bug > Components: Java - Library >Affects Versions: 0.9.1, 0.9.2, 0.9.3 >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Critical > Fix For: 0.10.0 > > Attachments: THRIFT-3479.001.patch > > > We noticed the following happening over in ACCUMULO-4065. > A client made a oneway call to a server which ultimately caused a TException > to propagate up through to ProcessFunction. This caused a message to be sent > back to the client with a TApplicationException wrapping the TException. > The problem is that the client had already returned its connection to a pool > because it was oneway (it had no means to know when the call finished -- nor > did it care). The next client that tried to send an RPC to the same server > sent its message, then read the response off the wire, only to get the oneway > call's exception Message, not the response for the call it made. > Ultimately, this screwed up the connection (the next client was always > reading the previous clients response). > Given my understanding on the current implementation (mostly discerned from > the docs, a bit from code), it's my belief that oneway calls can never safely > return a message to clients. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-640) Support deprecation
[ https://issues.apache.org/jira/browse/THRIFT-640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15202843#comment-15202843 ] Hudson commented on THRIFT-640: --- SUCCESS: Integrated in Thrift-precommit #335 (See [https://builds.apache.org/job/Thrift-precommit/335/]) THRIFT-640 Support deprecation (nsuke: [https://github.com/apache/thrift/commit/0d12de3b27115dfd8246102320e97d77bc596945]) * compiler/cpp/src/generate/t_java_generator.cc follow-up: THRIFT-640 Fix indent in generated code (nsuke: [https://github.com/apache/thrift/commit/e831490db9ca3c0539ffadb55cbb20967c7c4fbd]) * compiler/cpp/src/generate/t_java_generator.cc > Support deprecation > --- > > Key: THRIFT-640 > URL: https://issues.apache.org/jira/browse/THRIFT-640 > Project: Thrift > Issue Type: New Feature > Components: Java - Compiler >Reporter: Nathan Marz >Assignee: Daniel Wolf >Priority: Minor > Fix For: 0.10.0 > > Attachments: thrift-640-java-deprecation.patch > > > Sometimes we do schema migrations and it would be cool to be able to have > deprecation functionality from Thrift. At the most basic level, we should be > able to annotate a field as deprecated and have the compiler generate > "@Deprecated" annotations in the Java code. > Sometimes though, you may want creators of structs to be forced to use new > fields, but you still want to be able to read the old fields until you have > everything migrated over. In this case you could mark a field as > "strong-deprecated" and just not generate any setters for those fields (only > getters). This would force all users of the struct to migrate to new schema, > since the code won't compile otherwise. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3743) Java JSON protocol left in incorrect state when an exception is thrown during read or write operations
[ https://issues.apache.org/jira/browse/THRIFT-3743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15202838#comment-15202838 ] Hudson commented on THRIFT-3743: SUCCESS: Integrated in Thrift-precommit #335 (See [https://builds.apache.org/job/Thrift-precommit/335/]) THRIFT-3743 Java JSON protocol left in incorrect state when an exception (nsuke: [https://github.com/apache/thrift/commit/1d4a4393c9a9396ec76c3ba674e0d6a65fe39cc1]) * lib/java/src/org/apache/thrift/protocol/TSimpleJSONProtocol.java * lib/java/src/org/apache/thrift/protocol/TJSONProtocol.java > Java JSON protocol left in incorrect state when an exception is thrown during > read or write operations > -- > > Key: THRIFT-3743 > URL: https://issues.apache.org/jira/browse/THRIFT-3743 > Project: Thrift > Issue Type: Bug > Components: Java - Library >Reporter: Tyler Treat >Assignee: Tyler Treat > Fix For: 0.10.0 > > > This is the same issue as THRIFT-1473 (Delphi) and THRIFT-3735 (Go) but for > the Java library. > The JSON context stack may be left in an incorrect state when an exception is > thrown during read or write operations. This leads to further errors while > writing/reading the NEXT message, because incorrect characters may be written > or expected. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3747) Duplicate node.js build on Travis-CI
[ https://issues.apache.org/jira/browse/THRIFT-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15200174#comment-15200174 ] Hudson commented on THRIFT-3747: FAILURE: Integrated in Thrift-precommit #326 (See [https://builds.apache.org/job/Thrift-precommit/326/]) THRIFT-3747 Duplicate node.js build on Travis-CI (nsuke: [https://github.com/apache/thrift/commit/77fab722cb26ac4e4f0312b1557add841073987b]) * .travis.yml > Duplicate node.js build on Travis-CI > > > Key: THRIFT-3747 > URL: https://issues.apache.org/jira/browse/THRIFT-3747 > Project: Thrift > Issue Type: Bug > Components: Build Process >Reporter: Aki Sukegawa >Assignee: Aki Sukegawa >Priority: Trivial > > As npm download is unstable, node.js build was supposed to be isolated into a > separate job on Travis (with haskell which is unstable due to cabal download). > In reality, node.js was built in "Java Lua ..." job too, so we've been having > double chance of download failures. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3705) Go map has incorrect types when used with forward-defined types
[
https://issues.apache.org/jira/browse/THRIFT-3705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15200476#comment-15200476
]
Hudson commented on THRIFT-3705:
SUCCESS: Integrated in Thrift-precommit #327 (See
[https://builds.apache.org/job/Thrift-precommit/327/])
THRIFT-3705 Go map has incorrect types when used with forward-defined (jensg:
[https://github.com/apache/thrift/commit/55499b8802d13c41224b1b6922efa76eaa5da133])
* compiler/cpp/src/generate/t_go_generator.cc
> Go map has incorrect types when used with forward-defined types
> ---
>
> Key: THRIFT-3705
> URL: https://issues.apache.org/jira/browse/THRIFT-3705
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
>Reporter: Tyler Treat
>Assignee: Jens Geyer
>Priority: Minor
> Fix For: 0.10.0
>
>
> Generating the following IDL results in Go code which does not compile:
> {code}
> typedef map FooMap
> struct Foo {}
> service Service {
> void foo(1: FooMap fooMap)
> }
> {code}
> ./service.go:278: cannot use _key4 (type *Foo) as type Foo in map index
> ./service.go:278: cannot use _val5 (type *Foo) as type Foo in assignment
> However, if the struct precedes the typedef, the code is generated correctly:
> {code}
> struct Foo {}
> typedef map FooMap
> service Service {
> void foo(1: FooMap fooMap)
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3705) Go map has incorrect types when used with forward-defined types
[
https://issues.apache.org/jira/browse/THRIFT-3705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15198589#comment-15198589
]
Hudson commented on THRIFT-3705:
SUCCESS: Integrated in Thrift-precommit #323 (See
[https://builds.apache.org/job/Thrift-precommit/323/])
THRIFT-3705 Go map has incorrect types when used with forward-defined (jensg:
[https://github.com/apache/thrift/commit/a0519c1018dc57de1a0fb3814e2d97343a477ea2])
* compiler/cpp/src/generate/t_go_generator.cc
> Go map has incorrect types when used with forward-defined types
> ---
>
> Key: THRIFT-3705
> URL: https://issues.apache.org/jira/browse/THRIFT-3705
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
>Reporter: Tyler Treat
>Assignee: Jens Geyer
>Priority: Minor
>
> Generating the following IDL results in Go code which does not compile:
> {code}
> typedef map FooMap
> struct Foo {}
> service Service {
> void foo(1: FooMap fooMap)
> }
> {code}
> ./service.go:278: cannot use _key4 (type *Foo) as type Foo in map index
> ./service.go:278: cannot use _val5 (type *Foo) as type Foo in assignment
> However, if the struct precedes the typedef, the code is generated correctly:
> {code}
> struct Foo {}
> typedef map FooMap
> service Service {
> void foo(1: FooMap fooMap)
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3746) JSON protocol left in incorrect state on read errors
[ https://issues.apache.org/jira/browse/THRIFT-3746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15197749#comment-15197749 ] Hudson commented on THRIFT-3746: SUCCESS: Integrated in Thrift-precommit #322 (See [https://builds.apache.org/job/Thrift-precommit/322/]) THRIFT-3746 JSON protocol left in incorrect state on read errors (tyler.treat: [https://github.com/apache/thrift/commit/7503e55f5cc3ed65e80cf0df1da9e76ba900e103]) * lib/go/thrift/json_protocol.go * lib/go/thrift/simple_json_protocol.go > JSON protocol left in incorrect state on read errors > > > Key: THRIFT-3746 > URL: https://issues.apache.org/jira/browse/THRIFT-3746 > Project: Thrift > Issue Type: Bug > Components: Go - Library >Reporter: Tyler Treat > > This is related to THRIFT-3735, but the problem was not fully addressed > there. The JSON protocol's read buffer needs to be reset to avoid being put > in an invalid state on read errors. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3742) haxe php cli support
[ https://issues.apache.org/jira/browse/THRIFT-3742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15200477#comment-15200477 ] Hudson commented on THRIFT-3742: SUCCESS: Integrated in Thrift-precommit #327 (See [https://builds.apache.org/job/Thrift-precommit/327/]) THRIFT-3742 haxe php cli support Client: Haxe Patch: Oleksii Prudkyi + (jensg: [https://github.com/apache/thrift/commit/1d20a370d25b7154104289bb337ab4375edf19b9]) * test/haxe/src/TestServer.hx * lib/haxe/src/org/apache/thrift/protocol/TProtocol.hx * lib/haxe/test/Makefile.am * lib/haxe/src/org/apache/thrift/protocol/TProtocolDecorator.hx * lib/haxe/README.md * lib/haxe/test/php.hxml * lib/haxe/src/org/apache/thrift/transport/TSocket.hx * lib/haxe/src/org/apache/thrift/protocol/TProtocolUtil.hx * lib/haxe/src/org/apache/thrift/transport/TServerSocket.hx * test/haxe/php.hxml * lib/haxe/src/org/apache/thrift/helper/ZigZag.hx * test/haxe/src/TestClient.hx * tutorial/haxe/Makefile.am * tutorial/haxe/php.hxml * test/haxe/src/TestServerHandler.hx * lib/haxe/src/org/apache/thrift/protocol/TRecursionTracker.hx * test/haxe/Makefile.am > haxe php cli support > > > Key: THRIFT-3742 > URL: https://issues.apache.org/jira/browse/THRIFT-3742 > Project: Thrift > Issue Type: Improvement > Components: Haxe - Library >Affects Versions: 0.10.0, 1.0 >Reporter: Oleksii Prudkyi >Assignee: Oleksii Prudkyi > Fix For: 0.10.0 > > Attachments: THRIFT-3742-haxe-php-cli-support.patch > > > patch is coming soon -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3742) haxe php cli support
[ https://issues.apache.org/jira/browse/THRIFT-3742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15196733#comment-15196733 ] Hudson commented on THRIFT-3742: SUCCESS: Integrated in Thrift-precommit #321 (See [https://builds.apache.org/job/Thrift-precommit/321/]) THRIFT-3742 haxe php cli support Client: Haxe Patch: Oleksii Prudkyi + (jensg: [https://github.com/apache/thrift/commit/35ca130fb4c73a789febbc9e715a45caf692cdc5]) * lib/haxe/src/org/apache/thrift/helper/ZigZag.hx * tutorial/haxe/Makefile.am * lib/haxe/src/org/apache/thrift/protocol/TProtocolDecorator.hx * test/haxe/php.hxml * test/haxe/src/TestServer.hx * test/haxe/src/TestClient.hx * lib/haxe/README.md * lib/haxe/src/org/apache/thrift/protocol/TProtocol.hx * test/haxe/src/TestServerHandler.hx * lib/haxe/test/php.hxml * tutorial/haxe/php.hxml * lib/haxe/src/org/apache/thrift/transport/TServerSocket.hx * lib/haxe/src/org/apache/thrift/protocol/TRecursionTracker.hx * lib/haxe/src/org/apache/thrift/transport/TSocket.hx * test/haxe/Makefile.am * lib/haxe/test/Makefile.am * lib/haxe/src/org/apache/thrift/protocol/TProtocolUtil.hx > haxe php cli support > > > Key: THRIFT-3742 > URL: https://issues.apache.org/jira/browse/THRIFT-3742 > Project: Thrift > Issue Type: Improvement > Components: Haxe - Library >Affects Versions: 0.10.0, 1.0 >Reporter: Oleksii Prudkyi > Fix For: 0.10.0 > > Attachments: THRIFT-3742-haxe-php-cli-support.patch > > > patch is coming soon -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3705) Go map has incorrect types when used with forward-defined types
[
https://issues.apache.org/jira/browse/THRIFT-3705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15196522#comment-15196522
]
Hudson commented on THRIFT-3705:
FAILURE: Integrated in Thrift-precommit #319 (See
[https://builds.apache.org/job/Thrift-precommit/319/])
THRIFT-3705 Go map has incorrect types when used with forward-defined (jensg:
[https://github.com/apache/thrift/commit/c17eefaf80254b0251aa6e97c0ac9290de7198d4])
* compiler/cpp/src/generate/t_go_generator.cc
> Go map has incorrect types when used with forward-defined types
> ---
>
> Key: THRIFT-3705
> URL: https://issues.apache.org/jira/browse/THRIFT-3705
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler
>Reporter: Tyler Treat
>Assignee: Jens Geyer
>Priority: Minor
>
> Generating the following IDL results in Go code which does not compile:
> {code}
> typedef map FooMap
> struct Foo {}
> service Service {
> void foo(1: FooMap fooMap)
> }
> {code}
> ./service.go:278: cannot use _key4 (type *Foo) as type Foo in map index
> ./service.go:278: cannot use _val5 (type *Foo) as type Foo in assignment
> However, if the struct precedes the typedef, the code is generated correctly:
> {code}
> struct Foo {}
> typedef map FooMap
> service Service {
> void foo(1: FooMap fooMap)
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3745) The precision should be 17 for double
[
https://issues.apache.org/jira/browse/THRIFT-3745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15194823#comment-15194823
]
Hudson commented on THRIFT-3745:
FAILURE: Integrated in Thrift-precommit #317 (See
[https://builds.apache.org/job/Thrift-precommit/317/])
THRIFT-3745 The precision should be 17 for double (voipman:
[https://github.com/apache/thrift/commit/77b8fb3fedeaf0cf030fd8e6afc7808fca408513])
* lib/php/lib/Thrift/Protocol/TJSONProtocol.php
THRIFT-3745 The precision should be 17 for double (voipman:
[https://github.com/apache/thrift/commit/afcb57495130315bb016a972d365fe6f2202587e])
* lib/php/test/Test/Thrift/Protocol/TestTJSONProtocol.php
> The precision should be 17 for double
> -
>
> Key: THRIFT-3745
> URL: https://issues.apache.org/jira/browse/THRIFT-3745
> Project: Thrift
> Issue Type: Bug
> Components: PHP - Library
>Affects Versions: 0.9.3
>Reporter: WangYaofu
>Assignee: WangYaofu
> Fix For: 0.10.0
>
>
> The precision is lost when converting double to string.
> E.g:
> $num= 3.1415926535897931;
> $this->trans_->write(json_encode($num));
> The value will be '3.1415926535898' and some precision lost after format
> operation.
> But expected value should be '3.1415926535897931'.
> Solution:
> ini_set("precision",17);
> $this->trans_->write(json_encode($num));
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3744) The precision should be 17 (16 bits need after dot) after dot for double type.
[
https://issues.apache.org/jira/browse/THRIFT-3744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15194777#comment-15194777
]
Hudson commented on THRIFT-3744:
SUCCESS: Integrated in Thrift-precommit #316 (See
[https://builds.apache.org/job/Thrift-precommit/316/])
THRIFT-3744 The precision should be 17 (16 bits need after dot) after (voipman:
[https://github.com/apache/thrift/commit/5a2b9cd39f6088dc5ccc726e7c0d483c5d7470ee])
* lib/d/src/thrift/protocol/json.d
THRIFT-3744 The precision should be 17 (16 bits need after dot) after (voipman:
[https://github.com/apache/thrift/commit/d1212889e9e6fbc8cac1eb461a300fc748dbb6b3])
* lib/d/src/thrift/protocol/json.d
> The precision should be 17 (16 bits need after dot) after dot for double type.
> --
>
> Key: THRIFT-3744
> URL: https://issues.apache.org/jira/browse/THRIFT-3744
> Project: Thrift
> Issue Type: Bug
> Components: D - Library
>Affects Versions: 0.9.3
>Reporter: WangYaofu
>Assignee: WangYaofu
> Fix For: 0.10.0
>
>
> The precision is lost when converting double to string.
> E.g:
> double PI = 3.1415926535897931;
> string value = format("%.16g", PI);
> The value will be '3.141592653589793' and last 1 is lost after format
> operation.
> But expected value should be '3.1415926535897931'.
> Solution:
> string value = format("%.17g", PI);
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3740) Fix haxelib.json classpath
[ https://issues.apache.org/jira/browse/THRIFT-3740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15194766#comment-15194766 ] Hudson commented on THRIFT-3740: SUCCESS: Integrated in Thrift-precommit #315 (See [https://builds.apache.org/job/Thrift-precommit/315/]) THRIFT-3740 Fix haxelib.json classpath Client: Haxe Patch: Oleksii (jensg: [https://github.com/apache/thrift/commit/aadcf34cbf643b5eff1c771047a05a4c77be9d9e]) * lib/haxe/haxelib.json > Fix haxelib.json classpath > --- > > Key: THRIFT-3740 > URL: https://issues.apache.org/jira/browse/THRIFT-3740 > Project: Thrift > Issue Type: Sub-task > Components: Haxe - Library >Affects Versions: 0.9.3 >Reporter: Oleksii Prudkyi >Assignee: Oleksii Prudkyi >Priority: Trivial > Fix For: 0.10.0 > > Attachments: THRIFT-3740-Fix-haxelib.json-add-classpath.patch > > > In it's current form the file gets rejected by the haxelib utility. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-2980) ThriftMemoryBuffer doesn't have a constructor option to take an existing buffer
[
https://issues.apache.org/jira/browse/THRIFT-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15194767#comment-15194767
]
Hudson commented on THRIFT-2980:
SUCCESS: Integrated in Thrift-precommit #315 (See
[https://builds.apache.org/job/Thrift-precommit/315/])
THRIFT-2980 Accept external buffer in thrift_memory_buffer constructor (nsuke:
[https://github.com/apache/thrift/commit/1fa273be5089070532908f159a0ccc38d7f7150c])
* lib/c_glib/src/thrift/c_glib/transport/thrift_memory_buffer.c
* lib/c_glib/src/thrift/c_glib/transport/thrift_memory_buffer.h
* lib/c_glib/test/testmemorybuffer.c
> ThriftMemoryBuffer doesn't have a constructor option to take an existing
> buffer
> ---
>
> Key: THRIFT-2980
> URL: https://issues.apache.org/jira/browse/THRIFT-2980
> Project: Thrift
> Issue Type: Improvement
> Components: C glib - Library
>Reporter: Eugene Tolmachev
>Assignee: Chandler May
> Fix For: 0.10.0
>
>
> If I want to do a straight-up serialization/deserialization sans RPC I'd like
> to be able to read like this C# does:
> bq. Item Deserialize(byte[] bytes) { using (var trans = new
> TMemoryBuffer(bytes)) using (var proto = new TBinaryProtocol(trans)) return
> new Item().Do(item => item.Read(proto)); }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3741) haxe test is broken
[ https://issues.apache.org/jira/browse/THRIFT-3741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15194765#comment-15194765 ] Hudson commented on THRIFT-3741: SUCCESS: Integrated in Thrift-precommit #315 (See [https://builds.apache.org/job/Thrift-precommit/315/]) THRIFT-3741 haxe test is broken Client: Haxe Patch: Oleksii Prudkyi (jensg: [https://github.com/apache/thrift/commit/ccce919abc500c204445b1858bb39b43a4449ee0]) * lib/haxe/src/org/apache/thrift/protocol/TProtocolDecorator.hx > haxe test is broken > --- > > Key: THRIFT-3741 > URL: https://issues.apache.org/jira/browse/THRIFT-3741 > Project: Thrift > Issue Type: Bug > Components: Haxe - Library >Affects Versions: 0.10.0, 1.0 > Environment: linux >Reporter: Oleksii Prudkyi >Assignee: Oleksii Prudkyi > Fix For: 0.10.0 > > Attachments: THRIFT-3741-fix-missing-field.patch > > > make check > ../src/org/apache/thrift/protocol/TProtocolDecorator.hx:37: lines 37-218 : > Field DecrementRecursionDepth needed by org.apache.thrift.protocol.TProtocol > is missing > ../src/org/apache/thrift/protocol/TProtocolDecorator.hx:37: lines 37-218 : > Field IncrementRecursionDepth needed by org.apache.thrift.protocol.TProtocol > is missing -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3734) To compare two string as lowercase.
[
https://issues.apache.org/jira/browse/THRIFT-3734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15194768#comment-15194768
]
Hudson commented on THRIFT-3734:
SUCCESS: Integrated in Thrift-precommit #315 (See
[https://builds.apache.org/job/Thrift-precommit/315/])
follow-up: THRIFT-3734 update test/known_failures.json (nsukeg:
[https://github.com/apache/thrift/commit/e364081f821ecde15c22c7a28d7f76818b816614])
* test/known_failures_Linux.json
> To compare two string as lowercase.
> ---
>
> Key: THRIFT-3734
> URL: https://issues.apache.org/jira/browse/THRIFT-3734
> Project: Thrift
> Issue Type: Bug
> Components: D - Library
>Affects Versions: 0.9.3
>Reporter: WangYaofu
>Assignee: WangYaofu
> Fix For: 0.10.0
>
>
> static bool compToLower(ubyte a, ubyte b) {
> return a == toLower(cast(char)b);
> }
> it looks unexpected result got when parameter a is uppercase and b is
> lowercase.
> if (startsWith!compToLower(split[0], cast(ubyte[])"content-length")) {
> ...
> }
> split[0] is string of 'Content-Length', it contains character with uppercase.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3744) The precision should be 17 (16 bits need after dot) after dot for double type.
[
https://issues.apache.org/jira/browse/THRIFT-3744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15194648#comment-15194648
]
Hudson commented on THRIFT-3744:
FAILURE: Integrated in Thrift-precommit #313 (See
[https://builds.apache.org/job/Thrift-precommit/313/])
THRIFT-3744 The precision should be 17 (16 bits need after dot) after (voipman:
[https://github.com/apache/thrift/commit/5a2b9cd39f6088dc5ccc726e7c0d483c5d7470ee])
* lib/d/src/thrift/protocol/json.d
> The precision should be 17 (16 bits need after dot) after dot for double type.
> --
>
> Key: THRIFT-3744
> URL: https://issues.apache.org/jira/browse/THRIFT-3744
> Project: Thrift
> Issue Type: Bug
> Components: D - Library
>Affects Versions: 0.9.3
>Reporter: WangYaofu
>Assignee: WangYaofu
> Fix For: 0.10.0
>
>
> The precision is lost when converting double to string.
> E.g:
> double PI = 3.1415926535897931;
> string value = format("%.16g", PI);
> The value will be '3.141592653589793' and last 1 is lost after format
> operation.
> But expected value should be '3.1415926535897931'.
> Solution:
> string value = format("%.17g", PI);
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3743) Java JSON protocol left in incorrect state when an exception is thrown during read or write operations
[ https://issues.apache.org/jira/browse/THRIFT-3743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15193966#comment-15193966 ] Hudson commented on THRIFT-3743: SUCCESS: Integrated in Thrift-precommit #312 (See [https://builds.apache.org/job/Thrift-precommit/312/]) THRIFT-3743 Java JSON protocol left in incorrect state when an exception (tyler.treat: [https://github.com/apache/thrift/commit/b1e28acadfcc3ce2b1324744ebce1ad731503dd4]) * lib/java/src/org/apache/thrift/protocol/TJSONProtocol.java * lib/java/src/org/apache/thrift/protocol/TSimpleJSONProtocol.java > Java JSON protocol left in incorrect state when an exception is thrown during > read or write operations > -- > > Key: THRIFT-3743 > URL: https://issues.apache.org/jira/browse/THRIFT-3743 > Project: Thrift > Issue Type: Bug > Components: Java - Library >Reporter: Tyler Treat > > This is the same issue as THRIFT-1473 (Delphi) and THRIFT-3735 (Go) but for > the Java library. > The JSON context stack may be left in an incorrect state when an exception is > thrown during read or write operations. This leads to further errors while > writing/reading the NEXT message, because incorrect characters may be written > or expected. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3737) Improve TSocket isOpen() implementation to give more accurate connection status.
[
https://issues.apache.org/jira/browse/THRIFT-3737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192969#comment-15192969
]
Hudson commented on THRIFT-3737:
SUCCESS: Integrated in Thrift-precommit #308 (See
[https://builds.apache.org/job/Thrift-precommit/308/])
Improve isOpen() to give accurate tcp connection status. (THRIFT-3737)
(cherrotluo:
[https://github.com/apache/thrift/commit/c09968b5ca6e04893059e4799ec8e400b89392d1])
* lib/py/src/transport/TSocket.py
THRIFT-3737 Add isActive method to determine if the connection should be
(cherrotluo:
[https://github.com/apache/thrift/commit/e009ac3b1d5d94ccbd37f528876146abe9b76612])
* lib/py/src/transport/TSocket.py
> Improve TSocket isOpen() implementation to give more accurate connection
> status.
>
>
> Key: THRIFT-3737
> URL: https://issues.apache.org/jira/browse/THRIFT-3737
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
>Reporter: Cherrot Luo
> Labels: patch
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> h2. Description
> Typically isOpen() of TSocket.py in python lib would *ALWAYS* return true,
> even if the underlying TCP connection has been closed or reset by the peer,
> unless you manually invoke its close() method.
> This is because the isOpen method takes a simple but kind of "irresponsible"
> way to judge connection status:
> {code:title=TSocket.py}
> def isOpen(self):
> return self.handle is not None
> {code}
> This may affect the downstream lib/tools' implementation to offer a
> *reliable* transport instance.
> For example, in [happybase|https://github.com/wbolster/happybase] (a
> developer-friendly Python library to interact with Apache HBase), it use
> isOpen() to judge whether it neccessary to reopen the connection in its
> [connection|https://github.com/wbolster/happybase/blob/9cbd718c10a3089f234f1eac1236b631e1f8e7cd/happybase/connection.py#L164]
> and connection pool.
> h2. Fix
> I've sent a github [Pull Request|https://github.com/apache/thrift/pull/945]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3728) http transport for thrift-lua
[ https://issues.apache.org/jira/browse/THRIFT-3728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192720#comment-15192720 ] Hudson commented on THRIFT-3728: SUCCESS: Integrated in Thrift-precommit #307 (See [https://builds.apache.org/job/Thrift-precommit/307/]) THRIFT-3728 http transport for thrift-lua (voipman: [https://github.com/apache/thrift/commit/a4dd37b45afd7236fe47a1ed3e33853e64470823]) * lib/lua/THttpTransport.lua THRIFT-3728 http transport for thrift-lua (voipman: [https://github.com/apache/thrift/commit/962c520262af0421c6cc47a0f04120f8e4d6c164]) * test/tests.json THRIFT-3728 http transport for thrift-lua (voipman: [https://github.com/apache/thrift/commit/ea4b0d8dacfdebbaf4f06261badb9a7e9e454188]) * test/lua/test_basic_client.lua THRIFT-3728 http transport for thrift-lua (voipman: [https://github.com/apache/thrift/commit/93b51547160f7ae7a5d08ad97d40f858c9c6584b]) * test/lua/test_basic_server.lua THRIFT-3728 http transport for thrift-lua (voipman: [https://github.com/apache/thrift/commit/e42fe710c7e92c6099c6adfde0ead54dfa5c070a]) * test/lua/test_basic_client.lua THRIFT-3728 http transport for thrift-lua (voipman: [https://github.com/apache/thrift/commit/c5238fd2df9ca4eb512691f87c9993b4d89b1a54]) * lib/lua/TSocket.lua THRIFT-3728 http transport for thrift-lua (voipman: [https://github.com/apache/thrift/commit/14c14f4cfdcd8357ffb96fc2e3a4d72e2c01ab10]) * lib/lua/THttpTransport.lua THRIFT-3728 http transport for thrift-lua (voipman: [https://github.com/apache/thrift/commit/3991b9bc7cb87999ea33dea63a342a03ea324c17]) * lib/lua/TServer.lua THRIFT-3728 http transport for thrift-lua (voipman: [https://github.com/apache/thrift/commit/ce8d8c9d5c3a196d4bb9e5dfb74e27d9f833c5c5]) * lib/lua/TSocket.lua THRIFT-3728 http transport for thrift-lua (voipman: [https://github.com/apache/thrift/commit/f54e60e11070249275b72a83a1882cc918088c14]) * lib/lua/THttpTransport.lua THRIFT-3728 http transport for thrift-lua (voipman: [https://github.com/apache/thrift/commit/ef2c8a0a516dfd5deda086daf41135680bd3da43]) * lib/lua/THttpTransport.lua THRIFT-3728 http transport for thrift-lua (voipman: [https://github.com/apache/thrift/commit/40a0072547c079b3b0e7ff61ffc4c0e750ecd18b]) * test/tests.json > http transport for thrift-lua > - > > Key: THRIFT-3728 > URL: https://issues.apache.org/jira/browse/THRIFT-3728 > Project: Thrift > Issue Type: Improvement > Components: Lua - Library >Affects Versions: 0.9.3 >Reporter: WangYaofu >Assignee: WangYaofu > Fix For: 0.9.3 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3728) http transport for thrift-lua
[ https://issues.apache.org/jira/browse/THRIFT-3728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192366#comment-15192366 ] Hudson commented on THRIFT-3728: SUCCESS: Integrated in Thrift-precommit #306 (See [https://builds.apache.org/job/Thrift-precommit/306/]) THRIFT-3728 http transport for thrift-lua (voipman: [https://github.com/apache/thrift/commit/a4dd37b45afd7236fe47a1ed3e33853e64470823]) * lib/lua/THttpTransport.lua THRIFT-3728 http transport for thrift-lua (voipman: [https://github.com/apache/thrift/commit/962c520262af0421c6cc47a0f04120f8e4d6c164]) * test/tests.json THRIFT-3728 http transport for thrift-lua (voipman: [https://github.com/apache/thrift/commit/ea4b0d8dacfdebbaf4f06261badb9a7e9e454188]) * test/lua/test_basic_client.lua THRIFT-3728 http transport for thrift-lua (voipman: [https://github.com/apache/thrift/commit/93b51547160f7ae7a5d08ad97d40f858c9c6584b]) * test/lua/test_basic_server.lua THRIFT-3728 http transport for thrift-lua (voipman: [https://github.com/apache/thrift/commit/e42fe710c7e92c6099c6adfde0ead54dfa5c070a]) * test/lua/test_basic_client.lua THRIFT-3728 http transport for thrift-lua (voipman: [https://github.com/apache/thrift/commit/c5238fd2df9ca4eb512691f87c9993b4d89b1a54]) * lib/lua/TSocket.lua THRIFT-3728 http transport for thrift-lua (voipman: [https://github.com/apache/thrift/commit/14c14f4cfdcd8357ffb96fc2e3a4d72e2c01ab10]) * lib/lua/THttpTransport.lua THRIFT-3728 http transport for thrift-lua (voipman: [https://github.com/apache/thrift/commit/3991b9bc7cb87999ea33dea63a342a03ea324c17]) * lib/lua/TServer.lua THRIFT-3728 http transport for thrift-lua (voipman: [https://github.com/apache/thrift/commit/ce8d8c9d5c3a196d4bb9e5dfb74e27d9f833c5c5]) * lib/lua/TSocket.lua THRIFT-3728 http transport for thrift-lua (voipman: [https://github.com/apache/thrift/commit/f54e60e11070249275b72a83a1882cc918088c14]) * lib/lua/THttpTransport.lua THRIFT-3728 http transport for thrift-lua (voipman: [https://github.com/apache/thrift/commit/ef2c8a0a516dfd5deda086daf41135680bd3da43]) * lib/lua/THttpTransport.lua > http transport for thrift-lua > - > > Key: THRIFT-3728 > URL: https://issues.apache.org/jira/browse/THRIFT-3728 > Project: Thrift > Issue Type: Improvement > Components: Lua - Library >Affects Versions: 0.9.3 >Reporter: WangYaofu >Assignee: WangYaofu > Fix For: 0.9.3 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3739) Deprecation warning in codegen/base.d
[
https://issues.apache.org/jira/browse/THRIFT-3739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192308#comment-15192308
]
Hudson commented on THRIFT-3739:
SUCCESS: Integrated in Thrift-precommit #305 (See
[https://builds.apache.org/job/Thrift-precommit/305/])
THRIFT-3739 Deprecation warning in codegen/base.d (nsuke:
[https://github.com/apache/thrift/commit/97f81d508c80a9a0cc2419fbac1a9e29a02dce01])
* lib/d/src/thrift/codegen/base.d
> Deprecation warning in codegen/base.d
> -
>
> Key: THRIFT-3739
> URL: https://issues.apache.org/jira/browse/THRIFT-3739
> Project: Thrift
> Issue Type: Bug
> Components: D - Library
>Affects Versions: 0.9.3
> Environment: dmd 2.070
>Reporter: Aki Sukegawa
>Assignee: Aki Sukegawa
>Priority: Trivial
>
> {quote}
> ../../lib/d/src/thrift/codegen/base.d(502): Deprecation: this is not an lvalue
> {quote}
> https://travis-ci.org/apache/thrift/jobs/113139459#L5997
> It's caused by passing this pointer to "ref" parameter of "readStruct"
> function.
> Making the parameter to auto ref resolves the problem.
> This should be OK because the readStruct function is for internal use only.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3727) Incorrect require paths in Node.js tutorial
[ https://issues.apache.org/jira/browse/THRIFT-3727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192234#comment-15192234 ] Hudson commented on THRIFT-3727: SUCCESS: Integrated in Thrift-precommit #304 (See [https://builds.apache.org/job/Thrift-precommit/304/]) THRIFT-3727 Incorrect require paths in Node.js tutorial (nsuke: [https://github.com/apache/thrift/commit/26e1b9471945386113db1ce180533b5775f2b9cc]) * tutorial/nodejs/NodeClientPromise.js * tutorial/nodejs/NodeClient.js > Incorrect require paths in Node.js tutorial > --- > > Key: THRIFT-3727 > URL: https://issues.apache.org/jira/browse/THRIFT-3727 > Project: Thrift > Issue Type: Bug > Components: Node.js - Library, Tutorial >Reporter: Aki Sukegawa >Assignee: Aki Sukegawa > Fix For: 0.10.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3735) JSON protocol left in incorrect state when an exception is thrown during read or write operations
[ https://issues.apache.org/jira/browse/THRIFT-3735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192235#comment-15192235 ] Hudson commented on THRIFT-3735: SUCCESS: Integrated in Thrift-precommit #304 (See [https://builds.apache.org/job/Thrift-precommit/304/]) THRIFT-3735 JSON protocol left in incorrect state when an exception is (jensg: [https://github.com/apache/thrift/commit/5025a302c6dd877ff045f3db729805f76c785675]) * lib/go/thrift/json_protocol.go * lib/go/thrift/simple_json_protocol.go > JSON protocol left in incorrect state when an exception is thrown during read > or write operations > - > > Key: THRIFT-3735 > URL: https://issues.apache.org/jira/browse/THRIFT-3735 > Project: Thrift > Issue Type: Bug > Components: Go - Library >Reporter: Tyler Treat >Assignee: Tyler Treat > Fix For: 0.10.0 > > > The JSON context stack may be left in an incorrect state when an exception is > thrown during read or write operations. This leads to further errors while > writing/reading the NEXT message, because incorrect characters may be written > or expected. > This is related to THRIFT-1473, but there is an additional issue in that the > bufio.Writer needs to be reset if an error occurs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3734) To compare two string as lowercase.
[
https://issues.apache.org/jira/browse/THRIFT-3734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192236#comment-15192236
]
Hudson commented on THRIFT-3734:
SUCCESS: Integrated in Thrift-precommit #304 (See
[https://builds.apache.org/job/Thrift-precommit/304/])
THRIFT-3734 D To compare two string as lowercase. (nsuke:
[https://github.com/apache/thrift/commit/f9867ed19e2c6d71be45c4753164d3a1aa1989ec])
* lib/d/src/thrift/transport/http.d
> To compare two string as lowercase.
> ---
>
> Key: THRIFT-3734
> URL: https://issues.apache.org/jira/browse/THRIFT-3734
> Project: Thrift
> Issue Type: Bug
> Components: D - Library
>Affects Versions: 0.9.3
>Reporter: WangYaofu
>Assignee: WangYaofu
> Fix For: 0.10.0
>
>
> static bool compToLower(ubyte a, ubyte b) {
> return a == toLower(cast(char)b);
> }
> it looks unexpected result got when parameter a is uppercase and b is
> lowercase.
> if (startsWith!compToLower(split[0], cast(ubyte[])"content-length")) {
> ...
> }
> split[0] is string of 'Content-Length', it contains character with uppercase.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (THRIFT-3714) Thrift.TProtocolException is not defined in js/src/thrift.js
[ https://issues.apache.org/jira/browse/THRIFT-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192232#comment-15192232 ] Hudson commented on THRIFT-3714: SUCCESS: Integrated in Thrift-precommit #304 (See [https://builds.apache.org/job/Thrift-precommit/304/]) THRIFT-3714 Define TProtocolException in js/src/thrift.js (roger: [https://github.com/apache/thrift/commit/f5399b2f55575b23b74076ecf3402f378e1952eb]) * lib/js/src/thrift.js > Thrift.TProtocolException is not defined in js/src/thrift.js > > > Key: THRIFT-3714 > URL: https://issues.apache.org/jira/browse/THRIFT-3714 > Project: Thrift > Issue Type: Bug > Components: JavaScript - Compiler >Affects Versions: 0.9.2 >Reporter: Liyin Tang > Fix For: 0.10.0, 1.0 > > Attachments: thrift-3714.patch > > > THRIFT-809 will throw new Thrift.TProtocolException if a required field is > missing. However, in the js/src/thrift.js, TProtocolException is not defined. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (THRIFT-3733) Socket timeout improvements
[ https://issues.apache.org/jira/browse/THRIFT-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192237#comment-15192237 ] Hudson commented on THRIFT-3733: SUCCESS: Integrated in Thrift-precommit #304 (See [https://builds.apache.org/job/Thrift-precommit/304/]) THRIFT-3733 Socket timeout improvements Client: Delphi Patch: Jens Geyer (jensg: [https://github.com/apache/thrift/commit/6f6aa8a4060e3e8a0c1250fc571da97da3e4f330]) * lib/delphi/src/Thrift.Transport.pas * lib/delphi/test/TestClient.pas THRIFT-3733 Socket timeout improvements Client: Delphi Patch: Jens Geyer (jensg: [https://github.com/apache/thrift/commit/30ed90e0650e30734c9d728c2935d461671a0dc9]) * lib/delphi/src/Thrift.Transport.pas > Socket timeout improvements > --- > > Key: THRIFT-3733 > URL: https://issues.apache.org/jira/browse/THRIFT-3733 > Project: Thrift > Issue Type: Improvement > Components: Delphi - Library >Reporter: Jens Geyer >Assignee: Jens Geyer > Fix For: 0.10.0 > > Attachments: 0001-THRIFT-3733-Socket-timeout-improvements.patch, > 0002-THRIFT-3733-Socket-timeout-improvements.patch > > > The socket timeout handling has room for improvements -- This message was sent by Atlassian JIRA (v6.3.4#6332)
