[jira] [Created] (THRIFT-1605) Cocoa framework
Jake Farrell created THRIFT-1605: Summary: Cocoa framework Key: THRIFT-1605 URL: https://issues.apache.org/jira/browse/THRIFT-1605 Project: Thrift Issue Type: Improvement Components: Cocoa - Library Affects Versions: 0.8, 0.9 Reporter: Jake Farrell Assignee: Jake Farrell Create a cocoa framework for the lib -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-973) Cocoa library won't compile using clang
[ https://issues.apache.org/jira/browse/THRIFT-973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-973. --- Resolution: Fixed Fix Version/s: 0.9 Assignee: HIRANO Satoshi (was: Andrew McGeachie) Fixed as part of the ARC patch in Thrift-1340 Cocoa library won't compile using clang --- Key: THRIFT-973 URL: https://issues.apache.org/jira/browse/THRIFT-973 Project: Thrift Issue Type: Bug Components: Cocoa - Library Reporter: Kevin Ballard Assignee: HIRANO Satoshi Fix For: 0.9 Attachments: thrift.patch The Cocoa library won't compile under Clang because TNSFileHandleTransport.m and TNSStreamTransport.m don't fully conform to the TTransport protocol. Specifically, they're missing the const modifier for the first argument of the write:offset:length: method. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-541) Cocoa code generator doesn't put keywords before all arguments.
[ https://issues.apache.org/jira/browse/THRIFT-541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-541. --- Resolution: Fixed Fix Version/s: 0.9 rebased for trunk and committed. thanks for the patch Cocoa code generator doesn't put keywords before all arguments. --- Key: THRIFT-541 URL: https://issues.apache.org/jira/browse/THRIFT-541 Project: Thrift Issue Type: Improvement Components: Cocoa - Compiler Reporter: Matt Ronge Assignee: Andrew McGeachie Priority: Minor Fix For: 0.9 Attachments: arg_name_fix.patch The compiler doesn't put keywords in front of all args. Per Cocoa coding conventions (http://developer.apple.com/documentation/Cocoa/Conceptual/CodingGuidelines/Articles/NamingMethods.html#//apple_ref/doc/uid/20001282-1001751-BCIJHEDH) all args should have a keyword. Currently this would be generated - (int32_t) calculate: (int32_t) logid : (Work *) w; But this is better - (int32_t) calculate: (int32_t) logid w: (Work *) w; Attached is a very small patch that uses the name of the arg variable as the keyword. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (THRIFT-1574) Apache project branding requirements: DOAP file [PATCH]
[ https://issues.apache.org/jira/browse/THRIFT-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell reopened THRIFT-1574: -- Apache project branding requirements: DOAP file [PATCH] --- Key: THRIFT-1574 URL: https://issues.apache.org/jira/browse/THRIFT-1574 Project: Thrift Issue Type: Improvement Reporter: Shane Curcuru Assignee: Roger Meier Labels: branding Attachments: doap_thrift.rdf Attached. Re: http://www.apache.org/foundation/marks/pmcs See Also: http://projects.apache.org/create.html -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1079) Support i64 in AS3
[ https://issues.apache.org/jira/browse/THRIFT-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13272989#comment-13272989 ] Jake Farrell commented on THRIFT-1079: -- reverted until this can be reworked to not break the release Support i64 in AS3 -- Key: THRIFT-1079 URL: https://issues.apache.org/jira/browse/THRIFT-1079 Project: Thrift Issue Type: Improvement Components: AS3 - Compiler Reporter: Rowan Kerr Assignee: Jake Farrell Priority: Minor Attachments: THRIFT-1079_64_bit_support_in_as3.patch Would be nice to have i64 support for AS3. Although it's not straight forward. Found a previous bit of discussion about AS3 i64 support here: http://mail-archives.apache.org/mod_mbox/incubator-thrift-dev/201002.mbox/%3cdfc1ae6d1002091950s3eb71f6dl1381ea1bece3a...@mail.gmail.com%3e -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1598) Update Haskell generated code to use Text, Hash{Map,Set}, Vector
[
https://issues.apache.org/jira/browse/THRIFT-1598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13272993#comment-13272993
]
Jake Farrell commented on THRIFT-1598:
--
please create a patch and attach with asf inclusion. If you have any questions
see http://thrift.apache.org/docs/HowToContribute/ for submitting patches
Update Haskell generated code to use Text, Hash{Map,Set}, Vector
Key: THRIFT-1598
URL: https://issues.apache.org/jira/browse/THRIFT-1598
Project: Thrift
Issue Type: Improvement
Components: Haskell - Compiler
Affects Versions: 0.9
Reporter: Itai Zukerman
Priority: Minor
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1599) Fixing HTTP client
[ https://issues.apache.org/jira/browse/THRIFT-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13272992#comment-13272992 ] Jake Farrell commented on THRIFT-1599: -- please create a patch and attach with asf inclusion. If you have any questions see http://thrift.apache.org/docs/HowToContribute/ for submitting patches Fixing HTTP client -- Key: THRIFT-1599 URL: https://issues.apache.org/jira/browse/THRIFT-1599 Project: Thrift Issue Type: Bug Components: Ruby - Library Affects Versions: 0.8 Reporter: Tomas Correct way of using Net::HTTP (ruby 1.8.x, 1.9.x) https://github.com/apache/thrift/pull/12 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1544) Create correct Ruby namespace directories
[
https://issues.apache.org/jira/browse/THRIFT-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13273010#comment-13273010
]
Jake Farrell commented on THRIFT-1544:
--
tested on os x lion, got the following error with default system ruby 1.8.7.
thrift/trunk/lib/rb/spec/../test/debug_proto/gen-rb/srv.rb:8:in `require': no
such file to load -- /debug_proto_test_types (LoadError)
Create correct Ruby namespace directories
-
Key: THRIFT-1544
URL: https://issues.apache.org/jira/browse/THRIFT-1544
Project: Thrift
Issue Type: Improvement
Components: Ruby - Compiler
Affects Versions: 0.8
Reporter: Adam Stegman
Assignee: Jake Farrell
Priority: Minor
Labels: compiler, namespaces, patch, ruby
Fix For: 0.9
Attachments: Namespace-generated-Ruby-files-correctly.patch
Creating correct Ruby namespace directories, very similar to how Java creates
package directories. e.g. {noformat}namespace java com.example.my_lib
namespace rb com.example.my_lib{noformat} should both result in
gen-{rb,java}/com/example/my_lib/my_lib_service.{rb,java}.
Patch attached.
See also [THRIFT-474|https://issues.apache.org/jira/browse/THRIFT-474] where
a similar patch was included intermingled with a patch for a different issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1602) PHP C Extension is not Compatible with PHP 5.4
[
https://issues.apache.org/jira/browse/THRIFT-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell closed THRIFT-1602.
Resolution: Duplicate
Fix Version/s: 0.9
Duplicates THRIFT-1577
PHP C Extension is not Compatible with PHP 5.4
--
Key: THRIFT-1602
URL: https://issues.apache.org/jira/browse/THRIFT-1602
Project: Thrift
Issue Type: Bug
Components: PHP - Library
Affects Versions: 0.8
Reporter: Tyler Hobbs
Assignee: Jake Farrell
Fix For: 0.9
When running make with php 5.4, you'll get:
{{...thrift/ext/thrift_protocol/php_thrift_protocol.cpp:95:8: error:
'function_entry' does not name a type}}
This is caused by {{function_entry}} being replaced by
{{zend_function_entry}} https://bugs.php.net/bug.php?id=60016
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1574) Apache project branding requirements: DOAP file [PATCH]
[ https://issues.apache.org/jira/browse/THRIFT-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13270099#comment-13270099 ] Jake Farrell commented on THRIFT-1574: -- I think this should be moved into the website dir as a template for automation so we do not have to manage the version section by hand Apache project branding requirements: DOAP file [PATCH] --- Key: THRIFT-1574 URL: https://issues.apache.org/jira/browse/THRIFT-1574 Project: Thrift Issue Type: Improvement Reporter: Shane Curcuru Assignee: Roger Meier Labels: branding Attachments: doap_thrift.rdf Attached. Re: http://www.apache.org/foundation/marks/pmcs See Also: http://projects.apache.org/create.html -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (THRIFT-1574) Apache project branding requirements: DOAP file [PATCH]
[ https://issues.apache.org/jira/browse/THRIFT-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell reassigned THRIFT-1574: Assignee: Jake Farrell Apache project branding requirements: DOAP file [PATCH] --- Key: THRIFT-1574 URL: https://issues.apache.org/jira/browse/THRIFT-1574 Project: Thrift Issue Type: Improvement Reporter: Shane Curcuru Assignee: Jake Farrell Labels: branding Attachments: doap_thrift.rdf Attached. Re: http://www.apache.org/foundation/marks/pmcs See Also: http://projects.apache.org/create.html -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1357) Erlang Dependency breaks build
[
https://issues.apache.org/jira/browse/THRIFT-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114708#comment-13114708
]
Jake Farrell commented on THRIFT-1357:
--
Peter, this patch does not apply cleanly against trunk. What version was it
made against?
Erlang Dependency breaks build
--
Key: THRIFT-1357
URL: https://issues.apache.org/jira/browse/THRIFT-1357
Project: Thrift
Issue Type: Bug
Components: Erlang - Library
Environment: Apache build Infrastructure based on Ubuntu lucid
{noformat}
ii erlang-base 1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP virtual machine and base applicat
ii erlang-crypto 1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP cryprographic modules
ii erlang-dev 1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP development libraries and headers
ii erlang-eunit1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP module for unit testing
ii erlang-syntax-tools 1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP modules for handling abstract Erl
ii erlang-base 1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP virtual machine and base applicat
ii erlang-crypto 1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP cryprographic modules
ii erlang-dev 1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP development libraries and headers
ii erlang-eunit1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP module for unit testing
ii erlang-syntax-tools 1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP modules for handling abstract Erl
{noformat}
Reporter: Roger Meier
Assignee: Jake Farrell
Attachments: 0001-updated-JSX-version.patch
THRIFT-1227 introduced JSON for erlang,
however the Ubuntu build infrastructur does not support this...
{noformat}
./rebar get-deps
== erl (get-deps)
Pulling jsx from {git,git://github.com/talentdeficit/jsx.git,{tag,v0.9.0}}
Initialized empty Git repository in
/home/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/erl/deps/jsx/.git/
== nicefloats (get-deps)
== jsx (get-deps)
./rebar compile
== nicefloats (compile)
Compiled src/nicefloats.erl
== jsx (compile)
./include/jsx_common.hrl:34: type jsx_opt() undefined
./include/jsx_common.hrl:66: type jsx_parser_result() undefined
./include/jsx_common.hrl:82: type eep0018_array() undefined
./include/jsx_common.hrl:82: type eep0018_object() undefined
./include/jsx_common.hrl:84: type eep0018_term() undefined
./include/jsx_common.hrl:85: type eep0018_key() undefined
./include/jsx_common.hrl:85: type eep0018_term() undefined
./include/jsx_common.hrl:91: type eep0018_string() undefined
./include/jsx_common.hrl:92: type eep0018_number() undefined
./include/jsx_common.hrl:100: type encoder_opt() undefined
./include/jsx_common.hrl:109: type decoder_opt() undefined
./include/jsx_common.hrl:117: type verify_opt() undefined
./include/jsx_common.hrl:123: type format_opt() undefined
make[3]: *** [all] Error 1
{noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1357) Erlang Dependency breaks build
[
https://issues.apache.org/jira/browse/THRIFT-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114723#comment-13114723
]
Jake Farrell commented on THRIFT-1357:
--
Peter, I committed your changes. I am leaving this ticket open until i add the
erlang version check to configure to help guarantee a known env for erlang.
Erlang Dependency breaks build
--
Key: THRIFT-1357
URL: https://issues.apache.org/jira/browse/THRIFT-1357
Project: Thrift
Issue Type: Bug
Components: Erlang - Library
Environment: Apache build Infrastructure based on Ubuntu lucid
{noformat}
ii erlang-base 1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP virtual machine and base applicat
ii erlang-crypto 1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP cryprographic modules
ii erlang-dev 1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP development libraries and headers
ii erlang-eunit1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP module for unit testing
ii erlang-syntax-tools 1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP modules for handling abstract Erl
ii erlang-base 1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP virtual machine and base applicat
ii erlang-crypto 1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP cryprographic modules
ii erlang-dev 1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP development libraries and headers
ii erlang-eunit1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP module for unit testing
ii erlang-syntax-tools 1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP modules for handling abstract Erl
{noformat}
Reporter: Roger Meier
Assignee: Jake Farrell
Attachments:
0001-Fixed-thrift_json_protocol.erl-to-work-with-JSX-v0.9.patch,
0001-updated-JSX-version.patch
THRIFT-1227 introduced JSON for erlang,
however the Ubuntu build infrastructur does not support this...
{noformat}
./rebar get-deps
== erl (get-deps)
Pulling jsx from {git,git://github.com/talentdeficit/jsx.git,{tag,v0.9.0}}
Initialized empty Git repository in
/home/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/erl/deps/jsx/.git/
== nicefloats (get-deps)
== jsx (get-deps)
./rebar compile
== nicefloats (compile)
Compiled src/nicefloats.erl
== jsx (compile)
./include/jsx_common.hrl:34: type jsx_opt() undefined
./include/jsx_common.hrl:66: type jsx_parser_result() undefined
./include/jsx_common.hrl:82: type eep0018_array() undefined
./include/jsx_common.hrl:82: type eep0018_object() undefined
./include/jsx_common.hrl:84: type eep0018_term() undefined
./include/jsx_common.hrl:85: type eep0018_key() undefined
./include/jsx_common.hrl:85: type eep0018_term() undefined
./include/jsx_common.hrl:91: type eep0018_string() undefined
./include/jsx_common.hrl:92: type eep0018_number() undefined
./include/jsx_common.hrl:100: type encoder_opt() undefined
./include/jsx_common.hrl:109: type decoder_opt() undefined
./include/jsx_common.hrl:117: type verify_opt() undefined
./include/jsx_common.hrl:123: type format_opt() undefined
make[3]: *** [all] Error 1
{noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1331) Ruby library deserializes an empty map to nil
[ https://issues.apache.org/jira/browse/THRIFT-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13113468#comment-13113468 ] Jake Farrell commented on THRIFT-1331: -- THRIFT-1355 caused by the should deserialize an empty map to an empty hash test in compact_protocol_spec.rb added in this patch. This test case if failing and breaking the build. Ruby library deserializes an empty map to nil - Key: THRIFT-1331 URL: https://issues.apache.org/jira/browse/THRIFT-1331 Project: Thrift Issue Type: Bug Components: Ruby - Library Affects Versions: 0.7, 0.8 Reporter: Armaan Sarkar Assignee: Armaan Sarkar Fix For: 0.8 Attachments: THRIFT-1331_v1.patch, THRIFT-1331_v2.patch, THRIFT-1331_v3.patch The problem occurs when deserializing an empty map. Instead of deserializing to an empty hash in Ruby, Thrift currently makes it a nil object. This poses a variety of problems and is not the intended/original behavior. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (THRIFT-1357) Erlang Dependency breaks build
[
https://issues.apache.org/jira/browse/THRIFT-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell reassigned THRIFT-1357:
Assignee: Jake Farrell
Erlang Dependency breaks build
--
Key: THRIFT-1357
URL: https://issues.apache.org/jira/browse/THRIFT-1357
Project: Thrift
Issue Type: Bug
Components: Erlang - Library
Environment: Apache build Infrastructure based on Ubuntu lucid
{noformat}
ii erlang-base 1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP virtual machine and base applicat
ii erlang-crypto 1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP cryprographic modules
ii erlang-dev 1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP development libraries and headers
ii erlang-eunit1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP module for unit testing
ii erlang-syntax-tools 1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP modules for handling abstract Erl
ii erlang-base 1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP virtual machine and base applicat
ii erlang-crypto 1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP cryprographic modules
ii erlang-dev 1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP development libraries and headers
ii erlang-eunit1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP module for unit testing
ii erlang-syntax-tools 1:13.b.3-dfsg-2ubuntu2.1
Erlang/OTP modules for handling abstract Erl
{noformat}
Reporter: Roger Meier
Assignee: Jake Farrell
THRIFT-1227 introduced JSON for erlang,
however the Ubuntu build infrastructur does not support this...
{noformat}
./rebar get-deps
== erl (get-deps)
Pulling jsx from {git,git://github.com/talentdeficit/jsx.git,{tag,v0.9.0}}
Initialized empty Git repository in
/home/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/erl/deps/jsx/.git/
== nicefloats (get-deps)
== jsx (get-deps)
./rebar compile
== nicefloats (compile)
Compiled src/nicefloats.erl
== jsx (compile)
./include/jsx_common.hrl:34: type jsx_opt() undefined
./include/jsx_common.hrl:66: type jsx_parser_result() undefined
./include/jsx_common.hrl:82: type eep0018_array() undefined
./include/jsx_common.hrl:82: type eep0018_object() undefined
./include/jsx_common.hrl:84: type eep0018_term() undefined
./include/jsx_common.hrl:85: type eep0018_key() undefined
./include/jsx_common.hrl:85: type eep0018_term() undefined
./include/jsx_common.hrl:91: type eep0018_string() undefined
./include/jsx_common.hrl:92: type eep0018_number() undefined
./include/jsx_common.hrl:100: type encoder_opt() undefined
./include/jsx_common.hrl:109: type decoder_opt() undefined
./include/jsx_common.hrl:117: type verify_opt() undefined
./include/jsx_common.hrl:123: type format_opt() undefined
make[3]: *** [all] Error 1
{noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1355) Running make in lib/rb doesn't build the native extensions
[ https://issues.apache.org/jira/browse/THRIFT-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-1355. Resolution: Fixed Fix Version/s: 0.8 committed Running make in lib/rb doesn't build the native extensions -- Key: THRIFT-1355 URL: https://issues.apache.org/jira/browse/THRIFT-1355 Project: Thrift Issue Type: Bug Components: Ruby - Library Reporter: Takashi Yonebayashi Assignee: Jake Farrell Priority: Minor Fix For: 0.8 Attachments: thrift-1355.patch -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1355) Running make in lib/rb doesn't build the native extensions
[ https://issues.apache.org/jira/browse/THRIFT-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell updated THRIFT-1355: - Attachment: thrift-1355.patch Fixes ruby build Running make in lib/rb doesn't build the native extensions -- Key: THRIFT-1355 URL: https://issues.apache.org/jira/browse/THRIFT-1355 Project: Thrift Issue Type: Bug Components: Ruby - Library Reporter: Takashi Yonebayashi Assignee: Jake Farrell Priority: Minor Fix For: 0.8 Attachments: thrift-1355.patch -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1354) Add rake task to build just the gem file
[ https://issues.apache.org/jira/browse/THRIFT-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell updated THRIFT-1354: - Attachment: thrift-1354.patch Updates ruby build to now build the gem by default and adds a rake task to create the gem make = rake = rake gem Add rake task to build just the gem file Key: THRIFT-1354 URL: https://issues.apache.org/jira/browse/THRIFT-1354 Project: Thrift Issue Type: New Feature Reporter: Jake Farrell Assignee: Jake Farrell Attachments: thrift-1354.patch -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1354) Add rake task to build just the gem file
[ https://issues.apache.org/jira/browse/THRIFT-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-1354. Resolution: Fixed Fix Version/s: 0.8 committed Add rake task to build just the gem file Key: THRIFT-1354 URL: https://issues.apache.org/jira/browse/THRIFT-1354 Project: Thrift Issue Type: New Feature Reporter: Jake Farrell Assignee: Jake Farrell Fix For: 0.8 Attachments: thrift-1354.patch -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1355) Running make in lib/rb doesn't build the native extensions
[ https://issues.apache.org/jira/browse/THRIFT-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13113039#comment-13113039 ] Jake Farrell commented on THRIFT-1355: -- What version is this bug against? I committed a change earlier today which will generate the gem by default when building the rb library Running make in lib/rb doesn't build the native extensions -- Key: THRIFT-1355 URL: https://issues.apache.org/jira/browse/THRIFT-1355 Project: Thrift Issue Type: Bug Components: Ruby - Library Reporter: Takashi Yonebayashi Priority: Minor -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (THRIFT-1355) Running make in lib/rb doesn't build the native extensions
[ https://issues.apache.org/jira/browse/THRIFT-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell reassigned THRIFT-1355: Assignee: Jake Farrell Running make in lib/rb doesn't build the native extensions -- Key: THRIFT-1355 URL: https://issues.apache.org/jira/browse/THRIFT-1355 Project: Thrift Issue Type: Bug Components: Ruby - Library Reporter: Takashi Yonebayashi Assignee: Jake Farrell Priority: Minor -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1355) Running make in lib/rb doesn't build the native extensions
[ https://issues.apache.org/jira/browse/THRIFT-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13113051#comment-13113051 ] Jake Farrell commented on THRIFT-1355: -- Can you attach the error that you are seeing when you run rake build_ext from the lib/rb folder Running make in lib/rb doesn't build the native extensions -- Key: THRIFT-1355 URL: https://issues.apache.org/jira/browse/THRIFT-1355 Project: Thrift Issue Type: Bug Components: Ruby - Library Reporter: Takashi Yonebayashi Assignee: Jake Farrell Priority: Minor -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1350) Go library code does not build as of r60 (most recent release)
[ https://issues.apache.org/jira/browse/THRIFT-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13108193#comment-13108193 ] Jake Farrell commented on THRIFT-1350: -- Kyle, is this in the GO trunk or the latest released version of GO? We ran into a problem like this before where GO changed how they handled a library in their trunk version and broke compatibility with our current release. We opted to keep the driver current with the latest released version of GO and not their trunk. If this is latest released GO version I'll gladly add it. Thanks for the patch, if you have any questions about contributing please see http://wiki.apache.org/thrift/HowToContribute or feel free to email our dev mailing list with any questions at dev@thrift.apache.org Go library code does not build as of r60 (most recent release) -- Key: THRIFT-1350 URL: https://issues.apache.org/jira/browse/THRIFT-1350 Project: Thrift Issue Type: Bug Components: Go - Library Reporter: Kyle Consalus Attachments: patch.diff Go has moved it's URL-handling code into a url package. Also, strings.Split no longer takes a 3rd parameter. Not sure how I attach a patch, but here's a diff: http://pastie.org/2559636 Or, a simple run of gofix should probably handle it. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1350) Go library code does not build as of r60 (most recent release)
[ https://issues.apache.org/jira/browse/THRIFT-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-1350. Resolution: Fixed Fix Version/s: 0.8 Assignee: Kyle Consalus Thanks for the patch, committed Go library code does not build as of r60 (most recent release) -- Key: THRIFT-1350 URL: https://issues.apache.org/jira/browse/THRIFT-1350 Project: Thrift Issue Type: Bug Components: Go - Library Reporter: Kyle Consalus Assignee: Kyle Consalus Fix For: 0.8 Attachments: patch.diff Go has moved it's URL-handling code into a url package. Also, strings.Split no longer takes a 3rd parameter. Not sure how I attach a patch, but here's a diff: http://pastie.org/2559636 Or, a simple run of gofix should probably handle it. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1031) Patch to compile Thrift for vc++ 9.0 and 10.0
[ https://issues.apache.org/jira/browse/THRIFT-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13103835#comment-13103835 ] Jake Farrell commented on THRIFT-1031: -- The introduction of the duplicate set of t_*_generators in the v0_2 patch just add the potential for patches to be missed when new bugs arise within the generators. This functionality should be added into the current generators as an option flag to modify the resulted generator output where necessary. If I misunderstood your comments and this is just for debugging and will not be in the final patch can you please provide it as a separate patch noted as just for debug. Patch to compile Thrift for vc++ 9.0 and 10.0 - Key: THRIFT-1031 URL: https://issues.apache.org/jira/browse/THRIFT-1031 Project: Thrift Issue Type: Improvement Components: C++ - Library Environment: Windows XP 32bit, vc++ 9.0, 10.0 Reporter: James Dickson Priority: Trivial Fix For: 0.8 Attachments: thrift_msvc.patch, thrift_msvc_v0_1.patch, thrift_msvc_v0_2.patch, thrift_msvc_v0_2.patch At our company we need clients running on Windows being able to connect to our linux servers running hypertable. The attached patch enables the parts needed by Hypertable to be compiled on Windows using either the VC++ 9.0 or 10.0 compilers. Having read previous posts about ports using boost::asio we found these to be too intrusive for our needs. This version uses pthreads_win32 and winsock2 and is as designed to be as un-intrusive as is possible to the original unix code base. It is mostly #defines between unix sockets and winsock2 sockets. We also tried to follow the folder structuring of the C# runtime that has visual studio solutions to be consistent. More details are in the README as not all the functionality of the original unix code base is available to windows users. We will add the missing functionality, we just wanted to share what we had as for a Windows based client for us it is sufficient. The patch is based on the latest revision in SVN, we would love feedback and any code reviews. If there is any possibility of this being added to the main trunk then that would be much appreciated, however we don't expect that. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1345) Allow building without tests
[
https://issues.apache.org/jira/browse/THRIFT-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell closed THRIFT-1345.
Resolution: Fixed
Fix Version/s: 0.8
Assignee: Vitali Lovich
The global tests folder may completely be removed with THRIFT-35, at which
point we should possibly consider one of the following:
- removing this patch since --without-${library} would not run the test cases
for that library
- add a per --without-${library}-tests to exclude specific tests
- modify it to disable all client library test cases
Patch committed, thanks.
Allow building without tests
Key: THRIFT-1345
URL: https://issues.apache.org/jira/browse/THRIFT-1345
Project: Thrift
Issue Type: Improvement
Components: Build Process
Affects Versions: 0.7
Reporter: Vitali Lovich
Assignee: Vitali Lovich
Priority: Minor
Fix For: 0.8
Attachments: 0001-Add-option-to-disable-building-tests.patch
allow specifying --without-tests to configure to omit processing/building the
test directories.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-857) tests run by make install fail if generators are disabled
[
https://issues.apache.org/jira/browse/THRIFT-857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell updated THRIFT-857:
Attachment: thrift-857.patch
Bryan, saw this ticket and wanted to wrap it up. Attached is a patch with
removes the --disable-gen-${cpp,java,etc.} from configure and forces the
generator to include all available t_*_generator.cc files. Thoughts?
tests run by make install fail if generators are disabled
---
Key: THRIFT-857
URL: https://issues.apache.org/jira/browse/THRIFT-857
Project: Thrift
Issue Type: Bug
Components: Test Suite
Affects Versions: 0.4
Environment: mac os
Reporter: Bruce Lowekamp
Priority: Minor
Attachments: check-requested-generator.patch,
generator-subnamespace.patch, thrift-857.patch
configuring with generators disabled (configure --disable-gen-java, for
example) produces a failed build because the tests run by make install
require the java, cpp, rb, perl, csharp, and js generators.
I would personally favor either removing those --disble-gen options
altogether, or adding a warning message in the configure --help output that
disabling those generators is not recommended/will cause test failure.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1128) MAC OS X: thrift.h incompatibility with Thrift.h
[
https://issues.apache.org/jira/browse/THRIFT-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell updated THRIFT-1128:
-
Attachment: thrift-1128.patch
My first patch had a typo, updated header install location to
${prefix}/include/thrift/client/c_glib
MAC OS X: thrift.h incompatibility with Thrift.h
Key: THRIFT-1128
URL: https://issues.apache.org/jira/browse/THRIFT-1128
Project: Thrift
Issue Type: Bug
Affects Versions: 0.6
Environment: Mac OS X 10.6.7
Reporter: Mina Naguib
Assignee: Jake Farrell
Labels: C, C++, CPP, Thrift.h, c_glib, thrift.h
Attachments: thrift-1128.patch, thrift-1128.patch
The default filesystem on Mac OS X is case-insensitive
If thrift is compiled with c_glib support, upon install, the thrift.h
installed by c_glib trumps the classical Thrift.h C++ header.
C++ apps afterwards fail to compile (for obvious reasons).
Had to re-compile+install libthrift *without* c_glib support to get back the
original contents of Thrift.h needed for C++ support
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1285) Stable 0.7.0 Windows compiler exe available on the webside is not the good one
[
https://issues.apache.org/jira/browse/THRIFT-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell closed THRIFT-1285.
Resolution: Fixed
Fix Version/s: 0.7
Stable 0.7.0 Windows compiler exe available on the webside is not the good one
--
Key: THRIFT-1285
URL: https://issues.apache.org/jira/browse/THRIFT-1285
Project: Thrift
Issue Type: Bug
Components: Website
Affects Versions: 0.7
Reporter: Raphaël Bartement
Assignee: Jake Farrell
Priority: Blocker
Fix For: 0.7
On the main Thrift web site, in [the download
section|http://thrift.apache.org/download/], the Release link to Thrift
compiler for Windows do not lead to the tagged 0.7.0 stable release version
of the compiler.
I think this is a trunk snapshot binary instead.
Running {{monospacedthrift-0.7.0.exe -version}}
returns {{Thrift version 0.7.0-dev}}.
Before, I tested Java generation.
With this file:
{code:title=Test.thrift}
namespace java org.test
struct Foo {}
{code}
I get:
{code:java|:title=Foo.java}
/**
* Autogenerated by Thrift Compiler (0.7.0-dev)
*
* DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
*/
package org.test;
import org.apache.thrift.scheme.IScheme;
import org.apache.thrift.scheme.SchemeFactory;
import org.apache.thrift.scheme.StandardScheme;
...
{code}
I checked in subversion, the Scheme-related code has been introduced into
the trunk, but is not part of 0.7.x branch and 0.7.0 tag.
Thus, the generator code won't compile with the 0.7.0 java lib.
May you check this binary?
I'd like to use the official stable one.
Thanks.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1332) TSSLTransportParameters class uses hard coded value keyManagerType: SunX509
[ https://issues.apache.org/jira/browse/THRIFT-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-1332. Resolution: Fixed Fix Version/s: 0.8 Assignee: Vladimir Zhilyaev Thanks for the patch, committed. TSSLTransportParameters class uses hard coded value keyManagerType: SunX509 --- Key: THRIFT-1332 URL: https://issues.apache.org/jira/browse/THRIFT-1332 Project: Thrift Issue Type: Improvement Components: Java - Library Affects Versions: 0.6, 0.6.1, 0.7 Reporter: Vladimir Zhilyaev Assignee: Vladimir Zhilyaev Priority: Minor Fix For: 0.8 Attachments: TSSLTransportFactory.java.diff TSSLTransportParameters class uses hard coded value keyManagerType. The value in use: SunX509. This value is valid only for Sun JVM. Proposed solution: use KeyManagerFactory.getDefaultAlgorithm() and TrustManagerFactory.getDefaultAlgorithm(), which return appropriate values for each JVM. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (THRIFT-1285) Stable 0.7.0 Windows compiler exe available on the webside is not the good one
[
https://issues.apache.org/jira/browse/THRIFT-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell reassigned THRIFT-1285:
Assignee: Jake Farrell
Stable 0.7.0 Windows compiler exe available on the webside is not the good one
--
Key: THRIFT-1285
URL: https://issues.apache.org/jira/browse/THRIFT-1285
Project: Thrift
Issue Type: Bug
Components: Website
Affects Versions: 0.7
Reporter: Raphaël Bartement
Assignee: Jake Farrell
Priority: Blocker
On the main Thrift web site, in [the download
section|http://thrift.apache.org/download/], the Release link to Thrift
compiler for Windows do not lead to the tagged 0.7.0 stable release version
of the compiler.
I think this is a trunk snapshot binary instead.
Running {{monospacedthrift-0.7.0.exe -version}}
returns {{Thrift version 0.7.0-dev}}.
Before, I tested Java generation.
With this file:
{code:title=Test.thrift}
namespace java org.test
struct Foo {}
{code}
I get:
{code:java|:title=Foo.java}
/**
* Autogenerated by Thrift Compiler (0.7.0-dev)
*
* DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
*/
package org.test;
import org.apache.thrift.scheme.IScheme;
import org.apache.thrift.scheme.SchemeFactory;
import org.apache.thrift.scheme.StandardScheme;
...
{code}
I checked in subversion, the Scheme-related code has been introduced into
the trunk, but is not part of 0.7.x branch and 0.7.0 tag.
Thus, the generator code won't compile with the 0.7.0 java lib.
May you check this binary?
I'd like to use the official stable one.
Thanks.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1334) Add more info to IllegalStateException
[ https://issues.apache.org/jira/browse/THRIFT-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-1334. Resolution: Fixed Fix Version/s: 0.8 Committed, thanks Dave Add more info to IllegalStateException Key: THRIFT-1334 URL: https://issues.apache.org/jira/browse/THRIFT-1334 Project: Thrift Issue Type: Improvement Components: C++ - Library Reporter: Dave Watson Priority: Minor Fix For: 0.8 Attachments: 0030-Add-more-info-to-IllegalStateException.patch From bb3ebfa1f6483e6cf6ca3e264b24505194155842 Mon Sep 17 00:00:00 2001 From: Joshua Redstone redst...@fb.com Date: Tue, 20 Apr 2010 22:56:15 + Subject: [PATCH 30/33] Add more info to IllegalStateException Summary: Add support for the message field in IllegalStateException Test Plan: ran tests in thrift/lib/cpp/concurrency/test Revert Plan: OK --- lib/cpp/src/concurrency/Exception.h |6 +- lib/cpp/src/concurrency/ThreadManager.cpp |9 ++--- 2 files changed, 11 insertions(+), 4 deletions(-) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1333) Make RWGuard not copyable
[ https://issues.apache.org/jira/browse/THRIFT-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-1333. Resolution: Fixed Fix Version/s: 0.8 Committed, thanks Dave Make RWGuard not copyable --- Key: THRIFT-1333 URL: https://issues.apache.org/jira/browse/THRIFT-1333 Project: Thrift Issue Type: Improvement Components: C++ - Library Reporter: Dave Watson Priority: Minor Fix For: 0.8 Attachments: 0029-Make-RWGuard-not-copyable.patch From aca289c602251bbfe7f6543ce037ac795be273e0 Mon Sep 17 00:00:00 2001 From: Jordan DeLong jdel...@fb.com Date: Tue, 20 Apr 2010 19:35:56 + Subject: [PATCH 29/33] Make RWGuard not copyable Summary: Copying this class would cause its contained mutex to unlock twice. Mark it noncopyable. Test Plan: Compiled [internal fb thing]. Revert Plan: OK --- lib/cpp/src/concurrency/Mutex.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1330) PHP Namespaces no longer generated
[
https://issues.apache.org/jira/browse/THRIFT-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell closed THRIFT-1330.
Resolution: Not A Problem
Assignee: Jake Farrell
the compiler was given a 'namespace' option to not break compatibility with
older versions of php. From thrift --help
namespace: Generate PHP namespaces as defined in PHP = 5.3
thrift --gen php:namespace test.thrift
grep TestNamespace gen-php/test/test_types.php echo Has namespace ||
echo NO NAMESPACE FOUND
namespace TestNamespace;
Has namespace
PHP Namespaces no longer generated
--
Key: THRIFT-1330
URL: https://issues.apache.org/jira/browse/THRIFT-1330
Project: Thrift
Issue Type: Bug
Components: PHP - Compiler
Affects Versions: 0.7, 0.8
Environment: Mac OS X 10.6.8, CentOS 5.6, Ubuntu 11.04
Reporter: B Armstrong
Assignee: Jake Farrell
Priority: Critical
PHP namespaces are not being generated, ever. PHP 5.3 namespace aren't
generated either.
The following will illustrate the bug. This works in Thrift 0.6.*
$ thrift -version
Thrift version 0.7.0
$ cat test.thrift
namespace php TestNamespace
struct ItemX {}
$ thrift --gen php test.thrift
$ grep TestNamespace gen-php/test/test_types.php echo Has namespace ||
echo NO NAMESPACE FOUND
NO NAMESPACE FOUND
$ thrift -version
Thrift version 0.8.0-dev
$ thrift -gen php test.thrift
$ grep TestNamespace gen-php/test/test_types.php echo Has namespace ||
echo NO NAMESPACE FOUND
NO NAMESPACE FOUND
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1330) PHP Namespaces no longer generated
[
https://issues.apache.org/jira/browse/THRIFT-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13099204#comment-13099204
]
Jake Farrell commented on THRIFT-1330:
--
THRIFT-1241 introduced the php namespaces, would make sense to set the NS_ROOT
with older style namespace for php classes 5.3. If you would like to provide
a patch for this that would be great, otherwise i can tackle it after some of
the other tickets i have
PHP Namespaces no longer generated
--
Key: THRIFT-1330
URL: https://issues.apache.org/jira/browse/THRIFT-1330
Project: Thrift
Issue Type: Bug
Components: PHP - Compiler
Affects Versions: 0.7, 0.8
Environment: Mac OS X 10.6.8, CentOS 5.6, Ubuntu 11.04
Reporter: B Armstrong
Assignee: Jake Farrell
Priority: Critical
PHP namespaces are not being generated, ever. PHP 5.3 namespace aren't
generated either.
The following will illustrate the bug. This works in Thrift 0.6.*
$ thrift -version
Thrift version 0.7.0
$ cat test.thrift
namespace php TestNamespace
struct ItemX {}
$ thrift --gen php test.thrift
$ grep TestNamespace gen-php/test/test_types.php echo Has namespace ||
echo NO NAMESPACE FOUND
NO NAMESPACE FOUND
$ thrift -version
Thrift version 0.8.0-dev
$ thrift -gen php test.thrift
$ grep TestNamespace gen-php/test/test_types.php echo Has namespace ||
echo NO NAMESPACE FOUND
NO NAMESPACE FOUND
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (THRIFT-962) Tutorial page on our website is really unhelpful
[ https://issues.apache.org/jira/browse/THRIFT-962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell reassigned THRIFT-962: --- Assignee: Jake Farrell Tutorial page on our website is really unhelpful Key: THRIFT-962 URL: https://issues.apache.org/jira/browse/THRIFT-962 Project: Thrift Issue Type: Task Components: Tutorial, Website Reporter: Bryan Duxbury Assignee: Jake Farrell It's just a weak skeleton. I mean, really, really weak. At the very least, we should point to TRUNK/tutorial/ for where to look at code examples. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1322) OCaml lib fail to compile: Thrift.ml line 305, int vs int32 mismatch
[ https://issues.apache.org/jira/browse/THRIFT-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-1322. Resolution: Duplicate THRIFT-690 applied this same patch to OCaml lib. This is available in trunk since 2011-08-03 04:49:27 OCaml lib fail to compile: Thrift.ml line 305, int vs int32 mismatch Key: THRIFT-1322 URL: https://issues.apache.org/jira/browse/THRIFT-1322 Project: Thrift Issue Type: Bug Components: OCaml - Library Environment: Mac OS 10.6.8, 64bits x86_64 Reporter: Philippe STRAUSS Priority: Blocker Fix For: 0.8 Original Estimate: 20m Remaining Estimate: 20m Between SVN of 20110418 and today, the lib/ocaml has ceased to build. I mean it did build on april 18, not lately. The build die in this way: -- 8 -- philou@air:~/src/thrift-svn/lib/ocaml$ make cd src; make; cd .. ocamlopt -c -thread Thrift.ml File Thrift.ml, line 305, characters 6-8: Error: This pattern matches values of type int but a pattern was expected which matches values of type int32 -- 8 -- The lib/ocaml changes between 20110418 and 20110905 are listed below, and rather thin, should not be a big deal to fix : diff -ur thrift-svn-20110418/lib/ocaml/src/Thrift.ml thrift-svn/lib/ocaml/src/Thrift.ml --- thrift-svn-20110418/lib/ocaml/src/Thrift.ml 2011-04-13 18:38:21.0 +0200 +++ thrift-svn/lib/ocaml/src/Thrift.ml 2011-08-03 16:10:25.0 +0200 @@ -292,6 +292,8 @@ | WRONG_METHOD_NAME | BAD_SEQUENCE_ID | MISSING_RESULT + | INTERNAL_ERROR + | PROTOCOL_ERROR let typ_of_i = function 0l - UNKNOWN @@ -300,6 +302,8 @@ | 3l - WRONG_METHOD_NAME | 4l - BAD_SEQUENCE_ID | 5l - MISSING_RESULT +| 61 - INTERNAL_ERROR +| 71 - PROTOCOL_ERROR | _ - raise Thrift_error;; let typ_to_i = function | UNKNOWN - 0l @@ -308,6 +312,8 @@ | WRONG_METHOD_NAME - 3l | BAD_SEQUENCE_ID - 4l | MISSING_RESULT - 5l +| INTERNAL_ERROR - 61 +| PROTOCOL_ERROR - 71 class t = object (self) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1286) Modernize the Thrift Ruby Library Dev Environment
[ https://issues.apache.org/jira/browse/THRIFT-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-1286. Resolution: Fixed Fix Version/s: (was: 0.7) Updated ruby build with latest patch and configure checks Modernize the Thrift Ruby Library Dev Environment - Key: THRIFT-1286 URL: https://issues.apache.org/jira/browse/THRIFT-1286 Project: Thrift Issue Type: Improvement Components: Ruby - Library Affects Versions: 0.7, 0.8 Reporter: Scott Gonyea Assignee: Jake Farrell Fix For: 0.8 Attachments: thrift-1286.patch, thrift-1286.patch, thrift-1286.patch, thrift-1286.patch, thrift-1286.patch This fixes the ruby libraries environment. This introduces Bundler for managing the development environment, as well as in handling the Gem release process. Echoe is no longer present. The end result is that the development environment is easier to setup and easier to reproduce. Thus, easier to contribute to. This structures the spec folder to better follow conventions RSpec. The RSpec, as used in the ruby library, was using a mix of RSpec 1 and RSpec 2. This brings everything into the land of RSpec 2. Some additional cleanup could definitely be done, but this gets us out of the deprecation warnings and other weird behavior-ings. To run this in CI, however that is done, you'll effectively want the shell script (or whatever) to look like this: which bundle || gem install bundler bundle install bundle exec rake spec Patch should be pulled from: https://github.com/sgonyea/thrift/compare/apache:trunk...1fd22f135700c5d32244c63c164610f52b94619b or up to the commit: https://github.com/sgonyea/thrift/commit/1fd22f135700c5d32244c63c164610f52b94619b -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1303) Twisted tutorial client does not include correct generated path
[ https://issues.apache.org/jira/browse/THRIFT-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-1303. Resolution: Fixed Updated client to include correct generated code path Twisted tutorial client does not include correct generated path --- Key: THRIFT-1303 URL: https://issues.apache.org/jira/browse/THRIFT-1303 Project: Thrift Issue Type: Bug Reporter: Jake Farrell Assignee: Jake Farrell Priority: Minor -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (THRIFT-1303) Twisted tutorial client does not include correct generated path
Twisted tutorial client does not include correct generated path --- Key: THRIFT-1303 URL: https://issues.apache.org/jira/browse/THRIFT-1303 Project: Thrift Issue Type: Bug Reporter: Jake Farrell Assignee: Jake Farrell Priority: Minor -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1296) SSL detection is broken
[
https://issues.apache.org/jira/browse/THRIFT-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell closed THRIFT-1296.
Resolution: Fixed
Flipped around the checks so crypto is looked for first and then used when
checking for ssl, committed
SSL detection is broken
---
Key: THRIFT-1296
URL: https://issues.apache.org/jira/browse/THRIFT-1296
Project: Thrift
Issue Type: Bug
Components: Build Process
Affects Versions: 0.7
Environment: Ubuntu 10.04
Building Thrift against a custom toolchain (not using system
packages/libraries)
Reporter: Diwaker Gupta
Assignee: Jake Farrell
Attachments: THRIFT-1296.patch, thrift-1296.patch
When using shared libraries, libssl has dependencies on libcrypto. The
current autoconf macro for checking SSL doesn't do the job:
{noformat}
configure:23665: checking for SSL_ctrl in -lssl
configure:23690: x86_64-unknown-linux-gnu-g++ -o conftest -O2 -Wall -pipe
-Lsnip -Isnip -O2 -Wall -pipe conftest.cpp -lssl -lrt -lpthread 5
x86_64-unknown-linux-gnu/bin/ld: warning: libcrypto.so.1.0.0, needed by
snip/usr/lib/libssl.so, not found (try using -rpath or -rpath-link)
{noformat}
The following patch fixes this problem:
{noformat}
+--- configure.ac
configure.ac
+@@ -312,7 +312,7 @@ dnl of the POSIX Real-Time Extensions. This seems
necessary on Linux,
+ dnl and we haven't yet found a system where this is a problem.
+ AC_CHECK_LIB(rt, clock_gettime)
+ AC_CHECK_LIB(socket, setsockopt)
+-AC_CHECK_LIB(ssl, SSL_ctrl)
++AC_CHECK_LIB(ssl, SSL_ctrl,[LIBS=-lssl -lcrypto $LIBS],,-lcrypto)
+
+ AC_TYPE_INT16_T
+ AC_TYPE_INT32_T
{noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1299) If SSL is available, 'thrift' binary links against it
[ https://issues.apache.org/jira/browse/THRIFT-1299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-1299. Resolution: Fixed committed If SSL is available, 'thrift' binary links against it - Key: THRIFT-1299 URL: https://issues.apache.org/jira/browse/THRIFT-1299 Project: Thrift Issue Type: Bug Components: Build Process, C++ - Compiler, C++ - Library Affects Versions: 0.7 Reporter: Diwaker Gupta Assignee: Jake Farrell Priority: Minor Attachments: thrift-1299.patch Inspection of compiler/cpp/Makefile and lib/cpp/Makefile reveals that for building both the thrift compiler as well as the C++ libraries, the same set of libraries (in the variable LIBS) are used. When OpenSSL is available, this has the unintended consequence that the thrift compiler links libssl (and potentially libcrypto), even though it doesn't need to. In theory there is no harm in linking against additional shared libraries but it can be an issue in practice. Specifically, if OpenSSL etc are installed in a custom location (such as when building a custom toolchain), the thrift binary will fail to run unless LD_LIBRARY_PATH is set every time thrift needs to run. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1306) Fix stale documentation
[ https://issues.apache.org/jira/browse/THRIFT-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-1306. Resolution: Fixed Assignee: Diwaker Gupta Thanks for the patch, committed Fix stale documentation --- Key: THRIFT-1306 URL: https://issues.apache.org/jira/browse/THRIFT-1306 Project: Thrift Issue Type: Improvement Components: C++ - Library Affects Versions: 0.7 Reporter: Diwaker Gupta Assignee: Diwaker Gupta Priority: Trivial Attachments: THRIFT-1306.patch Fix documentation to match API change. Also format to 80 chars. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1291) Severely outdated config.sub in 0.7 distribution
[
https://issues.apache.org/jira/browse/THRIFT-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell closed THRIFT-1291.
Resolution: Fixed
Tracked down to an issue with my env, migrated off that box and next release
will not have this issue.
Severely outdated config.sub in 0.7 distribution
Key: THRIFT-1291
URL: https://issues.apache.org/jira/browse/THRIFT-1291
Project: Thrift
Issue Type: Bug
Components: Build Process, Deployment
Affects Versions: 0.7
Reporter: Diwaker Gupta
Assignee: Jake Farrell
Attachments: config.sub.0.6, config.sub.0.7
The version of config.sub that is distributed with Thrift 0.7 seems to be
from 2003, whereas the one that shipped with 0.6 is from 2008. This is
breaking Thrift builds for us on non-standard platforms. For instance:
{noformat}
$ bash config.sub.0.6 arm-unknown-linux-uclibcgnueabi
arm-unknown-linux-uclibcgnueabi
$ bash config.sub.0.7 arm-unknown-linux-uclibcgnueabi
Invalid configuration `arm-unknown-linux-uclibcgnueabi': machine
`arm-unknown-linux' not recognized
{noformat}
The first few lines of the files are also instructive:
{noformat}
$ head -n 7 config.sub.0.6
#! /bin/sh
# Configuration validation subroutine script.
# Copyright (C) 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999,
# 2000, 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008
# Free Software Foundation, Inc.
timestamp='2008-01-16'
$ head -n 7 config.sub.0.7
#! /bin/sh
# Configuration validation subroutine script.
# Copyright (C) 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999,
# 2000, 2001, 2002, 2003 Free Software Foundation, Inc.
timestamp='2003-06-18'
{noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1143) Build doesn't detect correct architecture type on 64bit osx
[ https://issues.apache.org/jira/browse/THRIFT-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13093248#comment-13093248 ] Jake Farrell commented on THRIFT-1143: -- Still a known issue with OS X 10.6, distutils still doesnt have a good solution for this either http://bugs.python.org/issue11623 . ARCHFLAGS=-arch x86_64 flag for OS X users is still the best approach to fix when needed, I dont think attaching to GOARCH as initially patched against is the best approach to solving this. Build doesn't detect correct architecture type on 64bit osx --- Key: THRIFT-1143 URL: https://issues.apache.org/jira/browse/THRIFT-1143 Project: Thrift Issue Type: Bug Components: Build Process Affects Versions: 0.5 Environment: OSX Snow leopard 64 bit Reporter: Jonathan Evans Assignee: Jake Farrell Labels: build, mac, osx, x86_64 Attachments: thrift-1143.patch python setup.py install running install running build running build_py running build_ext building 'thrift.protocol.fastbinary' extension gcc-4.2 -fno-strict-aliasing -fno-common -dynamic -DNDEBUG -g -fwrapv -Os -Wall -Wstrict-prototypes -DENABLE_DTRACE -arch i386 -arch ppc -arch x86_64 -pipe -I/System/Library/Frameworks/Python.framework/Versions/2.6/include/python2.6 -c src/protocol/fastbinary.c -o build/temp.macosx-10.6-universal-2.6/src/protocol/fastbinary.o /usr/libexec/gcc/powerpc-apple-darwin10/4.2.1/as: assembler (/usr/bin/../libexec/gcc/darwin/ppc/as or /usr/bin/../local/libexec/gcc/darwin/ppc/as) for architecture ppc not installed Installed assemblers are: /usr/bin/../libexec/gcc/darwin/x86_64/as for architecture x86_64 /usr/bin/../libexec/gcc/darwin/i386/as for architecture i386 src/protocol/fastbinary.c:1203: fatal error: error writing to -: Broken pipe compilation terminated. lipo: can't open input file: /var/folders/t7/t7jaJ7IcGnKFNCMY3G37PU+++TI/-Tmp-//ccP7p7J0.out (No such file or directory) error: command 'gcc-4.2' failed with exit status 1 To fix: export ARCHFLAGS=-arch x86_64 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (THRIFT-1308) libfb303-0.7.0.jar missing in maven repository
[ https://issues.apache.org/jira/browse/THRIFT-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell reassigned THRIFT-1308: Assignee: Jake Farrell libfb303-0.7.0.jar missing in maven repository -- Key: THRIFT-1308 URL: https://issues.apache.org/jira/browse/THRIFT-1308 Project: Thrift Issue Type: Bug Components: Build Process Affects Versions: 0.7 Reporter: Carl Steinbach Assignee: Jake Farrell It looks like libfb303 was published to maven repositories for the 0.6.1 release, but I don't see any libfb303 artifacts available for the 0.7.0 release. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1307) Add compression to Thrift
[ https://issues.apache.org/jira/browse/THRIFT-1307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13093316#comment-13093316 ] Jake Farrell commented on THRIFT-1307: -- The plugin interface was just a thought for 3rd party items like snappy to be able to easily interact with any existing transport. A wrapper transport, like zlib, would be the way to accomplish this right now Add compression to Thrift - Key: THRIFT-1307 URL: https://issues.apache.org/jira/browse/THRIFT-1307 Project: Thrift Issue Type: New Feature Components: Java - Library Reporter: Jerome Boulon Thrift output could be compressed on the fly similar to what Tomcat/Apache are doing. But instead of using Gzip, since performance matter more than the compression ratio, Snappy could be used. Snappy: http://code.google.com/p/snappy/ Snappy is written in C++, but Java bindings are included -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1308) libfb303-0.7.0.jar missing in maven repository
[ https://issues.apache.org/jira/browse/THRIFT-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-1308. Resolution: Fixed Fix Version/s: 0.7 repository.apache.org dependency groupIdorg.apache.thrift/groupId artifactIdlibfb303/artifactId version0.7.0/version typepom/type /dependency libfb303-0.7.0.jar missing in maven repository -- Key: THRIFT-1308 URL: https://issues.apache.org/jira/browse/THRIFT-1308 Project: Thrift Issue Type: Bug Components: Build Process Affects Versions: 0.7 Reporter: Carl Steinbach Assignee: Jake Farrell Fix For: 0.7 It looks like libfb303 was published to maven repositories for the 0.6.1 release, but I don't see any libfb303 artifacts available for the 0.7.0 release. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1257) thrift's dependency scope on javax.servlet:servlet-api should be 'provided'
[
https://issues.apache.org/jira/browse/THRIFT-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell closed THRIFT-1257.
Resolution: Fixed
Updated scope to provided
thrift's dependency scope on javax.servlet:servlet-api should be 'provided'
Key: THRIFT-1257
URL: https://issues.apache.org/jira/browse/THRIFT-1257
Project: Thrift
Issue Type: Dependency upgrade
Components: Java - Library
Affects Versions: 0.6.1
Environment: Tomcat 7.x
Tested on Mac OS X 10.6.8
Reporter: Shashwat Agarwal
Assignee: Jake Farrell
Priority: Minor
Labels: javax.servlet.Servlet, maven, servlet-api, thrift
Fix For: 0.8
Attachments: thrift-1257.patch
libthrift 0.6.1 pom (org.apache.thrift:libthrift-0.6.1) specifies
javax.servlet:servlet-api-2.5 as compulsory dependency. This causes the jar
depending on this libthrift to be skipped by Tomcat with the following error:
{noformat}
INFO:
validateJarFile(/usr/local/apache-tomcat-7.0.2/webapps/mywebapp/WEB-INF/lib/my-service-1.0.0.jar)
- jar not loaded. See Servlet Spec 2.3, section 9.7.2. Offending class:
javax/servlet/Servlet.class
{noformat}
_Workaround_
While including libthrift-0.6.1 as dependency in maven pom, exclude
javax.servlet:servlet-api using exclusions as:
{noformat}
dependency
groupIdorg.apache.thrift/groupId
artifactIdlibthrift/artifactId
version0.6.1/version
exclusions
exclusion
groupIdjavax.servlet/groupId
artifactIdservlet-api/artifactId
/exclusion
/exclusions
/dependency
{noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (THRIFT-1296) SSL detection is broken
[
https://issues.apache.org/jira/browse/THRIFT-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell reassigned THRIFT-1296:
Assignee: Jake Farrell
SSL detection is broken
---
Key: THRIFT-1296
URL: https://issues.apache.org/jira/browse/THRIFT-1296
Project: Thrift
Issue Type: Bug
Components: Build Process
Affects Versions: 0.7
Environment: Ubuntu 10.04
Building Thrift against a custom toolchain (not using system
packages/libraries)
Reporter: Diwaker Gupta
Assignee: Jake Farrell
Attachments: THRIFT-1296.patch
When using shared libraries, libssl has dependencies on libcrypto. The
current autoconf macro for checking SSL doesn't do the job:
{noformat}
configure:23665: checking for SSL_ctrl in -lssl
configure:23690: x86_64-unknown-linux-gnu-g++ -o conftest -O2 -Wall -pipe
-Lsnip -Isnip -O2 -Wall -pipe conftest.cpp -lssl -lrt -lpthread 5
x86_64-unknown-linux-gnu/bin/ld: warning: libcrypto.so.1.0.0, needed by
snip/usr/lib/libssl.so, not found (try using -rpath or -rpath-link)
{noformat}
The following patch fixes this problem:
{noformat}
+--- configure.ac
configure.ac
+@@ -312,7 +312,7 @@ dnl of the POSIX Real-Time Extensions. This seems
necessary on Linux,
+ dnl and we haven't yet found a system where this is a problem.
+ AC_CHECK_LIB(rt, clock_gettime)
+ AC_CHECK_LIB(socket, setsockopt)
+-AC_CHECK_LIB(ssl, SSL_ctrl)
++AC_CHECK_LIB(ssl, SSL_ctrl,[LIBS=-lssl -lcrypto $LIBS],,-lcrypto)
+
+ AC_TYPE_INT16_T
+ AC_TYPE_INT32_T
{noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-406) C++ Test suite cleanup
[ https://issues.apache.org/jira/browse/THRIFT-406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell updated THRIFT-406: Affects Version/s: 0.8 Assignee: (was: Jérémie BORDIER) C++ Test suite cleanup -- Key: THRIFT-406 URL: https://issues.apache.org/jira/browse/THRIFT-406 Project: Thrift Issue Type: Improvement Components: C++ - Library Affects Versions: 0.8 Reporter: Jérémie BORDIER Some unit tests are already ported to boost::unit_test, so let's finish the work, and maybe move them to lib/cpp/test for consistency. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-568) Thrift build on Ubuntu uses site-packages not dist-packages
[ https://issues.apache.org/jira/browse/THRIFT-568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-568. --- Resolution: Fixed Assignee: Jake Farrell This is available from an extra install option you can pass to the make file. Since debian added a patch to setuptools in python-setuptools (0.6c9-0ubuntu4) jaunty an option called --install-layout=deb is available which will install packages into the dist-packages directory. From within the lib/python directory run: make install PYTHON_SETUPUTIL_ARGS=--install-layout=deb Thrift build on Ubuntu uses site-packages not dist-packages --- Key: THRIFT-568 URL: https://issues.apache.org/jira/browse/THRIFT-568 Project: Thrift Issue Type: Bug Components: Python - Library Affects Versions: 0.2 Environment: Ubuntu Server 9.04 Reporter: Lance Weber Assignee: Jake Farrell Priority: Minor When building thrift python libs on ubuntu, it places the files into site-packages instead of dist-utils -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1297) Compiled javascript code does not write falsy values
[
https://issues.apache.org/jira/browse/THRIFT-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13091828#comment-13091828
]
Jake Farrell commented on THRIFT-1297:
--
Is this the same issue as THRIFT-1277 ?
Compiled javascript code does not write falsy values
Key: THRIFT-1297
URL: https://issues.apache.org/jira/browse/THRIFT-1297
Project: Thrift
Issue Type: Bug
Components: JavaScript - Compiler
Affects Versions: 0.7
Environment: Windows 0.7 thrift compiler (pre built)
http://www.apache.org/dyn/closer.cgi?path=/thrift/0.7.0/thrift-0.7.0.exe
Thrift 0.7 compiled on Ubuntu shows same symptoms
Reporter: Joris van der Wel
Priority: Critical
Labels: compiler, javascript, regression
I compiled cassandra.thrift using thrift --gen js:node cassandra.thrift.
When I use this code this results in the following error from cassandra /
thrift:
{code}
{ name: 'TApplicationException', type: 7,
message: 'Required field \'reversed\' was not found in serialized data!
Struct : SliceRange(start:null, finish:null, reversed:false, count:100)' }
{code}
If I look in the generated code, I find
{code}
SliceRange.prototype.write = function(output) {
output.writeStructBegin('SliceRange');
if (this.start) {
output.writeFieldBegin('start', Thrift.Type.STRING, 1);
output.writeString(this.start);
output.writeFieldEnd();
}
if (this.finish) {
output.writeFieldBegin('finish', Thrift.Type.STRING, 2);
output.writeString(this.finish);
output.writeFieldEnd();
}
if (this.reversed) {
output.writeFieldBegin('reversed', Thrift.Type.BOOL, 3);
output.writeBool(this.reversed);
output.writeFieldEnd();
}
if (this.count) {
output.writeFieldBegin('count', Thrift.Type.I32, 4);
output.writeI32(this.count);
output.writeFieldEnd();
}
output.writeFieldStop();
output.writeStructEnd();
return;
};
{code}
this.reversed is false and subsequently does not get sent
If I look at the compiled version that was generated by 0.6.1 I see:
{code}
SliceRange.prototype.write = function(output){
output.writeStructBegin('SliceRange')
if (null != this.start) {
output.writeFieldBegin('start', Thrift.Type.STRING, 1)
output.writeString(this.start)
output.writeFieldEnd()
}
if (null != this.finish) {
output.writeFieldBegin('finish', Thrift.Type.STRING, 2)
output.writeString(this.finish)
output.writeFieldEnd()
}
if (null != this.reversed) {
output.writeFieldBegin('reversed', Thrift.Type.BOOL, 3)
output.writeBool(this.reversed)
output.writeFieldEnd()
}
if (null != this.count) {
output.writeFieldBegin('count', Thrift.Type.I32, 4)
output.writeI32(this.count)
output.writeFieldEnd()
}
output.writeFieldStop()
output.writeStructEnd()
return
}
{code}
null is also not be completely correct, the solution would be:
{code}
...
if (undefined !== this.reversed)
...
{code}
Unless this change was intentional and breaks things because cassandra is
perhaps using an old thrift version?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1286) Modernize the Thrift Ruby Library Dev Environment
[ https://issues.apache.org/jira/browse/THRIFT-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13091005#comment-13091005 ] Jake Farrell commented on THRIFT-1286: -- patch does not apply cleanly. Merging your additions with my patch to make this all play nicely Modernize the Thrift Ruby Library Dev Environment - Key: THRIFT-1286 URL: https://issues.apache.org/jira/browse/THRIFT-1286 Project: Thrift Issue Type: Improvement Components: Ruby - Library Affects Versions: 0.7, 0.8 Reporter: Scott Gonyea Assignee: Jake Farrell Fix For: 0.7, 0.8 Attachments: thrift-1286.patch, thrift-1286.patch This fixes the ruby libraries environment. This introduces Bundler for managing the development environment, as well as in handling the Gem release process. Echoe is no longer present. The end result is that the development environment is easier to setup and easier to reproduce. Thus, easier to contribute to. This structures the spec folder to better follow conventions RSpec. The RSpec, as used in the ruby library, was using a mix of RSpec 1 and RSpec 2. This brings everything into the land of RSpec 2. Some additional cleanup could definitely be done, but this gets us out of the deprecation warnings and other weird behavior-ings. To run this in CI, however that is done, you'll effectively want the shell script (or whatever) to look like this: which bundle || gem install bundler bundle install bundle exec rake spec Patch should be pulled from: https://github.com/sgonyea/thrift/compare/apache:trunk...1fd22f135700c5d32244c63c164610f52b94619b or up to the commit: https://github.com/sgonyea/thrift/commit/1fd22f135700c5d32244c63c164610f52b94619b -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (THRIFT-1291) Severely outdated config.sub in 0.7 distribution
[
https://issues.apache.org/jira/browse/THRIFT-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell reassigned THRIFT-1291:
Assignee: Jake Farrell
Severely outdated config.sub in 0.7 distribution
Key: THRIFT-1291
URL: https://issues.apache.org/jira/browse/THRIFT-1291
Project: Thrift
Issue Type: Bug
Components: Build Process, Deployment
Affects Versions: 0.7
Reporter: Diwaker Gupta
Assignee: Jake Farrell
Attachments: config.sub.0.6, config.sub.0.7
The version of config.sub that is distributed with Thrift 0.7 seems to be
from 2003, whereas the one that shipped with 0.6 is from 2008. This is
breaking Thrift builds for us on non-standard platforms. For instance:
{noformat}
$ bash config.sub.0.6 arm-unknown-linux-uclibcgnueabi
arm-unknown-linux-uclibcgnueabi
$ bash config.sub.0.7 arm-unknown-linux-uclibcgnueabi
Invalid configuration `arm-unknown-linux-uclibcgnueabi': machine
`arm-unknown-linux' not recognized
{noformat}
The first few lines of the files are also instructive:
{noformat}
$ head -n 7 config.sub.0.6
#! /bin/sh
# Configuration validation subroutine script.
# Copyright (C) 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999,
# 2000, 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008
# Free Software Foundation, Inc.
timestamp='2008-01-16'
$ head -n 7 config.sub.0.7
#! /bin/sh
# Configuration validation subroutine script.
# Copyright (C) 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999,
# 2000, 2001, 2002, 2003 Free Software Foundation, Inc.
timestamp='2003-06-18'
{noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1291) Severely outdated config.sub in 0.7 distribution
[
https://issues.apache.org/jira/browse/THRIFT-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13091045#comment-13091045
]
Jake Farrell commented on THRIFT-1291:
--
these files are auto-generated during the release process so they should always
be current. When I made the last two release I used autoconf 2.65 on centos.
0.6.1 shows a timestamp of '2003-06-18'. Something most likely is wrong with my
version on centos. Switching over to os x with autoconf 2.68 yields a correct
timestamp of '2009-04-17'. Will be using os x for future releases so should not
be an issue moving forward.
Severely outdated config.sub in 0.7 distribution
Key: THRIFT-1291
URL: https://issues.apache.org/jira/browse/THRIFT-1291
Project: Thrift
Issue Type: Bug
Components: Build Process, Deployment
Affects Versions: 0.7
Reporter: Diwaker Gupta
Assignee: Jake Farrell
Attachments: config.sub.0.6, config.sub.0.7
The version of config.sub that is distributed with Thrift 0.7 seems to be
from 2003, whereas the one that shipped with 0.6 is from 2008. This is
breaking Thrift builds for us on non-standard platforms. For instance:
{noformat}
$ bash config.sub.0.6 arm-unknown-linux-uclibcgnueabi
arm-unknown-linux-uclibcgnueabi
$ bash config.sub.0.7 arm-unknown-linux-uclibcgnueabi
Invalid configuration `arm-unknown-linux-uclibcgnueabi': machine
`arm-unknown-linux' not recognized
{noformat}
The first few lines of the files are also instructive:
{noformat}
$ head -n 7 config.sub.0.6
#! /bin/sh
# Configuration validation subroutine script.
# Copyright (C) 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999,
# 2000, 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008
# Free Software Foundation, Inc.
timestamp='2008-01-16'
$ head -n 7 config.sub.0.7
#! /bin/sh
# Configuration validation subroutine script.
# Copyright (C) 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999,
# 2000, 2001, 2002, 2003 Free Software Foundation, Inc.
timestamp='2003-06-18'
{noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1286) Modernize the Thrift Ruby Library Dev Environment
[ https://issues.apache.org/jira/browse/THRIFT-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell updated THRIFT-1286: - Attachment: thrift-1286.patch I've been looking into why the rb client changes to rspec2 have been breaking the ci builds. The build servers are not on the latest version of ruby gems and are running rspec 1.3. The configure script checked for spec to be installed, which is available on the ci servers, and then when make check was issued the rb makefile was calling rake spec which caused the build to break since the new rake file depended on rspec2 not rspec 1.3. To solve this the attached patch introduces the bundler gem as a new ruby dependency. This will help ruby client builds with a Gemfile for versioning all the clients dependencies and i've added in the necessary calls in configure to guarantee that bundler is installed before attempting to use any ruby specific build tools (rake, rspec, spec, etc.). Modernize the Thrift Ruby Library Dev Environment - Key: THRIFT-1286 URL: https://issues.apache.org/jira/browse/THRIFT-1286 Project: Thrift Issue Type: Improvement Components: Ruby - Library Affects Versions: 0.7, 0.8 Reporter: Scott Gonyea Fix For: 0.7, 0.8 Attachments: thrift-1286.patch This fixes the ruby libraries environment. This introduces Bundler for managing the development environment, as well as in handling the Gem release process. Echoe is no longer present. The end result is that the development environment is easier to setup and easier to reproduce. Thus, easier to contribute to. This structures the spec folder to better follow conventions RSpec. The RSpec, as used in the ruby library, was using a mix of RSpec 1 and RSpec 2. This brings everything into the land of RSpec 2. Some additional cleanup could definitely be done, but this gets us out of the deprecation warnings and other weird behavior-ings. To run this in CI, however that is done, you'll effectively want the shell script (or whatever) to look like this: which bundle || gem install bundler bundle install bundle exec rake spec Patch should be pulled from: https://github.com/sgonyea/thrift/compare/apache:trunk...1fd22f135700c5d32244c63c164610f52b94619b or up to the commit: https://github.com/sgonyea/thrift/commit/1fd22f135700c5d32244c63c164610f52b94619b -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (THRIFT-1286) Modernize the Thrift Ruby Library Dev Environment
[ https://issues.apache.org/jira/browse/THRIFT-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell reassigned THRIFT-1286: Assignee: Jake Farrell Modernize the Thrift Ruby Library Dev Environment - Key: THRIFT-1286 URL: https://issues.apache.org/jira/browse/THRIFT-1286 Project: Thrift Issue Type: Improvement Components: Ruby - Library Affects Versions: 0.7, 0.8 Reporter: Scott Gonyea Assignee: Jake Farrell Fix For: 0.7, 0.8 Attachments: thrift-1286.patch This fixes the ruby libraries environment. This introduces Bundler for managing the development environment, as well as in handling the Gem release process. Echoe is no longer present. The end result is that the development environment is easier to setup and easier to reproduce. Thus, easier to contribute to. This structures the spec folder to better follow conventions RSpec. The RSpec, as used in the ruby library, was using a mix of RSpec 1 and RSpec 2. This brings everything into the land of RSpec 2. Some additional cleanup could definitely be done, but this gets us out of the deprecation warnings and other weird behavior-ings. To run this in CI, however that is done, you'll effectively want the shell script (or whatever) to look like this: which bundle || gem install bundler bundle install bundle exec rake spec Patch should be pulled from: https://github.com/sgonyea/thrift/compare/apache:trunk...1fd22f135700c5d32244c63c164610f52b94619b or up to the commit: https://github.com/sgonyea/thrift/commit/1fd22f135700c5d32244c63c164610f52b94619b -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1263) publish ruby client to rubygems
[ https://issues.apache.org/jira/browse/THRIFT-1263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13087673#comment-13087673 ] Jake Farrell commented on THRIFT-1263: -- I had seen that, wasnt sure on the best way to handle it yet. I'll come up with a fix for it today -Jake publish ruby client to rubygems --- Key: THRIFT-1263 URL: https://issues.apache.org/jira/browse/THRIFT-1263 Project: Thrift Issue Type: Bug Components: Ruby - Compiler Affects Versions: 0.7 Reporter: Jake Farrell Assignee: Jake Farrell Fix For: 0.8 Attachments: thrift-1263.patch As part of the release process release gem to rubygems.org -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-380) Use setuptools for python build
[
https://issues.apache.org/jira/browse/THRIFT-380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell closed THRIFT-380.
---
Resolution: Fixed
Fix Version/s: 0.8
Added to .7 branch and trunk, client now available via pypi.python.org
Use setuptools for python build
---
Key: THRIFT-380
URL: https://issues.apache.org/jira/browse/THRIFT-380
Project: Thrift
Issue Type: Bug
Components: Python - Library
Reporter: Ben Maurer
Assignee: Jake Farrell
Fix For: 0.8
We should use setuptools for the python build as this allows thrift to be
distributed as an egg file:
{quote}
Index: setup.py
===
--- setup.py (revision 755803)
+++ setup.py (working copy)
@@ -5,9 +5,8 @@
#
# See accompanying file LICENSE or visit the Thrift site at:
# http://developers.facebook.com/thrift/
+from setuptools import setup, Extension
-from distutils.core import setup, Extension
fastbinarymod = Extension('thrift.protocol.fastbinary',
sources = ['src/protocol/fastbinary.c'],
)
{quote}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1128) MAC OS X: thrift.h incompatibility with Thrift.h
[
https://issues.apache.org/jira/browse/THRIFT-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell updated THRIFT-1128:
-
Attachment: thrift-1128.patch
Thoughts on moving the client from ${prefix}/include/thrift to
${prefix}/include/thrift/client/g_libc to avoid collisions on thrift.h ?
MAC OS X: thrift.h incompatibility with Thrift.h
Key: THRIFT-1128
URL: https://issues.apache.org/jira/browse/THRIFT-1128
Project: Thrift
Issue Type: Bug
Affects Versions: 0.6
Environment: Mac OS X 10.6.7
Reporter: Mina Naguib
Labels: C, C++, CPP, Thrift.h, c_glib, thrift.h
Attachments: thrift-1128.patch
The default filesystem on Mac OS X is case-insensitive
If thrift is compiled with c_glib support, upon install, the thrift.h
installed by c_glib trumps the classical Thrift.h C++ header.
C++ apps afterwards fail to compile (for obvious reasons).
Had to re-compile+install libthrift *without* c_glib support to get back the
original contents of Thrift.h needed for C++ support
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1110) Thrift Twisted Timeouts
[ https://issues.apache.org/jira/browse/THRIFT-1110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell updated THRIFT-1110: - Component/s: Python - Library Thrift Twisted Timeouts --- Key: THRIFT-1110 URL: https://issues.apache.org/jira/browse/THRIFT-1110 Project: Thrift Issue Type: Improvement Components: Python - Library Reporter: Dan Di Spaltro Is there any way we could add timeout support to Twisted Thrift bindings? The way you can achieve this is basically errback'ing the deferred, and then when it comes back, it throws an AlreadyCalledError. There are a bunch of ways to fix this, just not sure the best way. Any ideas? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (THRIFT-380) Use setuptools for python build
[
https://issues.apache.org/jira/browse/THRIFT-380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell reassigned THRIFT-380:
---
Assignee: Jake Farrell
Use setuptools for python build
---
Key: THRIFT-380
URL: https://issues.apache.org/jira/browse/THRIFT-380
Project: Thrift
Issue Type: Bug
Components: Python - Library
Reporter: Ben Maurer
Assignee: Jake Farrell
We should use setuptools for the python build as this allows thrift to be
distributed as an egg file:
{quote}
Index: setup.py
===
--- setup.py (revision 755803)
+++ setup.py (working copy)
@@ -5,9 +5,8 @@
#
# See accompanying file LICENSE or visit the Thrift site at:
# http://developers.facebook.com/thrift/
+from setuptools import setup, Extension
-from distutils.core import setup, Extension
fastbinarymod = Extension('thrift.protocol.fastbinary',
sources = ['src/protocol/fastbinary.c'],
)
{quote}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1257) thrift's dependency scope on javax.servlet:servlet-api should be 'provided'
[
https://issues.apache.org/jira/browse/THRIFT-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell updated THRIFT-1257:
-
Component/s: Java - Library
Fix Version/s: 0.8
Assignee: Jake Farrell
thrift's dependency scope on javax.servlet:servlet-api should be 'provided'
Key: THRIFT-1257
URL: https://issues.apache.org/jira/browse/THRIFT-1257
Project: Thrift
Issue Type: Dependency upgrade
Components: Java - Library
Affects Versions: 0.6.1
Environment: Tomcat 7.x
Tested on Mac OS X 10.6.8
Reporter: Shashwat Agarwal
Assignee: Jake Farrell
Priority: Minor
Labels: javax.servlet.Servlet, maven, servlet-api, thrift
Fix For: 0.8
Attachments: thrift-1257.patch
libthrift 0.6.1 pom (org.apache.thrift:libthrift-0.6.1) specifies
javax.servlet:servlet-api-2.5 as compulsory dependency. This causes the jar
depending on this libthrift to be skipped by Tomcat with the following error:
{noformat}
INFO:
validateJarFile(/usr/local/apache-tomcat-7.0.2/webapps/mywebapp/WEB-INF/lib/my-service-1.0.0.jar)
- jar not loaded. See Servlet Spec 2.3, section 9.7.2. Offending class:
javax/servlet/Servlet.class
{noformat}
_Workaround_
While including libthrift-0.6.1 as dependency in maven pom, exclude
javax.servlet:servlet-api using exclusions as:
{noformat}
dependency
groupIdorg.apache.thrift/groupId
artifactIdlibthrift/artifactId
version0.6.1/version
exclusions
exclusion
groupIdjavax.servlet/groupId
artifactIdservlet-api/artifactId
/exclusion
/exclusions
/dependency
{noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1257) thrift's dependency scope on javax.servlet:servlet-api should be 'provided'
[
https://issues.apache.org/jira/browse/THRIFT-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell updated THRIFT-1257:
-
Attachment: thrift-1257.patch
Changes scope of javax.servlet to provided so containers using the
TServlet.java class can provided the desired servlet api
thrift's dependency scope on javax.servlet:servlet-api should be 'provided'
Key: THRIFT-1257
URL: https://issues.apache.org/jira/browse/THRIFT-1257
Project: Thrift
Issue Type: Dependency upgrade
Components: Java - Library
Affects Versions: 0.6.1
Environment: Tomcat 7.x
Tested on Mac OS X 10.6.8
Reporter: Shashwat Agarwal
Priority: Minor
Labels: javax.servlet.Servlet, maven, servlet-api, thrift
Fix For: 0.8
Attachments: thrift-1257.patch
libthrift 0.6.1 pom (org.apache.thrift:libthrift-0.6.1) specifies
javax.servlet:servlet-api-2.5 as compulsory dependency. This causes the jar
depending on this libthrift to be skipped by Tomcat with the following error:
{noformat}
INFO:
validateJarFile(/usr/local/apache-tomcat-7.0.2/webapps/mywebapp/WEB-INF/lib/my-service-1.0.0.jar)
- jar not loaded. See Servlet Spec 2.3, section 9.7.2. Offending class:
javax/servlet/Servlet.class
{noformat}
_Workaround_
While including libthrift-0.6.1 as dependency in maven pom, exclude
javax.servlet:servlet-api using exclusions as:
{noformat}
dependency
groupIdorg.apache.thrift/groupId
artifactIdlibthrift/artifactId
version0.6.1/version
exclusions
exclusion
groupIdjavax.servlet/groupId
artifactIdservlet-api/artifactId
/exclusion
/exclusions
/dependency
{noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1240) TBinarySerializer.php invalid serialization due to TBufferTransport not flushing last chunk of data into TMemoryBuffer
[
https://issues.apache.org/jira/browse/THRIFT-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell updated THRIFT-1240:
-
Fix Version/s: (was: 0.6.1)
0.8
TBinarySerializer.php invalid serialization due to TBufferTransport not
flushing last chunk of data into TMemoryBuffer
--
Key: THRIFT-1240
URL: https://issues.apache.org/jira/browse/THRIFT-1240
Project: Thrift
Issue Type: Bug
Components: PHP - Library
Affects Versions: 0.6.1
Environment: Cent OS and Mac OS 10.5
Reporter: Marimuthu Ponnambalam
Priority: Critical
Labels: TBinarySerializer, invalid, serialization
Fix For: 0.8
Attachments: TBinarySerializer.php, simple.thrift, testsimple.php
Simple Serialization errors out, due to the TBufferTransport not flushing the
data into TMemoryBuffer after $object-write($protocol) in TBinarySerializer.
Please find the error output of my test program below. It fixed after I added
the following line on the serialize method in TBinarySerializer.
$protocol-getTransport()-flush();
This because of TBinaryProtocolAccelerated internally wraps TMemoryBuffer
within TBufferTransport in its constructor.
TBufferTransport write only if the wbuf_ is full (512 bytes) into
TMemoryBuffer. Hence data smaller than 512 will not get written into
TMemoryBuffer. While getting serialized data from TMemoryBuffer it might not
have the last chunk of data which is less than 512 bytes.
This outputs invalid serialized data
TestSchema$ php testsimple.php
Serialized .
mari
Fatal error: Uncaught exception 'TTransportException' with message
'TMemoryBuffer: Could not read 512 bytes from buffer.' in
/Users/mponnambalam/work/eclipse/workspace/thrift0.6.1/lib/php/src/transport/TMemoryBuffer.php
on line 58
TTransportException: TMemoryBuffer: Could not read 512 bytes from buffer. in
/Users/mponnambalam/work/eclipse/workspace/thrift0.6.1/lib/php/src/transport/TMemoryBuffer.php
on line 58
Call Stack:
0.0003 636976 1. {main}()
/Users/mponnambalam/work/eclipse/workspace/TestSchema/testsimple.php:0
0.00431509728 2. TBinarySerializer::deserialize()
/Users/mponnambalam/work/eclipse/workspace/TestSchema/testsimple.php:47
0.00431511808 3. thrift_protocol_read_binary()
/Users/mponnambalam/work/eclipse/workspace/thrift0.6.1/lib/php/src/protocol/TBinarySerializer.php:62
thrift_protoco_read_binary disabled ( I commented extension in
thrift_protocol.ini)
TestSchema$ php testsimple.php
Serialized .
Fatal error: Uncaught exception 'TTransportException' with message
'TMemoryBuffer: Could not read 1 bytes from buffer.' in
/Users/mponnambalam/work/eclipse/workspace/thrift0.6.1/lib/php/src/transport/TMemoryBuffer.php
on line 58
TTransportException: TMemoryBuffer: Could not read 1 bytes from buffer. in
/Users/mponnambalam/work/eclipse/workspace/thrift0.6.1/lib/php/src/transport/TMemoryBuffer.php
on line 58
Call Stack:
0.0003 636976 1. {main}()
/Users/mponnambalam/work/eclipse/workspace/TestSchema/testsimple.php:0
0.00411509944 2. TBinarySerializer::deserialize()
/Users/mponnambalam/work/eclipse/workspace/TestSchema/testsimple.php:47
0.00411512248 3. Person-read()
/Users/mponnambalam/work/eclipse/workspace/thrift0.6.1/lib/php/src/protocol/TBinarySerializer.php:66
0.00411512472 4. TBinaryProtocol-readFieldBegin()
/Users/mponnambalam/work/eclipse/workspace/TestSchema/gen-php/simple/simple_types.php:45
0.00411512472 5. TBinaryProtocol-readByte()
/Users/mponnambalam/work/eclipse/workspace/thrift0.6.1/lib/php/src/protocol/TBinaryProtocol.php:231
0.00411512520 6. TBufferedTransport-readAll()
/Users/mponnambalam/work/eclipse/workspace/thrift0.6.1/lib/php/src/protocol/TBinaryProtocol.php:283
0.00411512568 7. TTransport-readAll()
/Users/mponnambalam/work/eclipse/workspace/thrift0.6.1/lib/php/src/transport/TBufferedTransport.php:109
0.00411512744 8. TMemoryBuffer-read()
/Users/mponnambalam/work/eclipse/workspace/thrift0.6.1/lib/php/src/transport/TTransport.php:87
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (THRIFT-1259) Automate versioning
Automate versioning Key: THRIFT-1259 URL: https://issues.apache.org/jira/browse/THRIFT-1259 Project: Thrift Issue Type: Task Components: Build Process Affects Versions: 0.7 Reporter: Jake Farrell Assignee: Jake Farrell Only a manual process exists for updating the versions for a release. Need to automate this to make generating releases easier. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1252) Segfault in Ruby deserializer
[ https://issues.apache.org/jira/browse/THRIFT-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell updated THRIFT-1252: - Fix Version/s: 0.7 Segfault in Ruby deserializer - Key: THRIFT-1252 URL: https://issues.apache.org/jira/browse/THRIFT-1252 Project: Thrift Issue Type: Bug Components: Ruby - Library Affects Versions: 0.7 Environment: Thrift 0.7.0dev (revision 1152979) Ruby 1.9.2 OS X 10.6, Linux x86_64 Reporter: Ilya Maykov Assignee: Ilya Maykov Fix For: 0.7 Attachments: THRIFT-1252.patch There is a segfault bug in the native Ruby deserializer that was introduced with THRIFT-1189. The @index variable of MemoryBufferTransport is not always correctly updated from native code when GARBAGE_BUFFER_SIZE is exceeded. Will attach the patch shortly. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1233) Remove unused include in generated C++ code
[ https://issues.apache.org/jira/browse/THRIFT-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-1233. Remove unused include in generated C++ code --- Key: THRIFT-1233 URL: https://issues.apache.org/jira/browse/THRIFT-1233 Project: Thrift Issue Type: Improvement Components: C++ - Compiler Environment: Ubuntu 11.04, latest trunk. Reporter: Diwaker Gupta Assignee: alexandre parenteau Priority: Trivial Fix For: 0.7 Attachments: THRIFT-1233.patch, thrift-1233.2.tgz When using cob_style with the CPP generator, the compiler adds an include for TTransportUtils. This include doesn't seem to be used anywhere and creates an unnecessary dependency. It also complicates compiling Thrift generated code on other platforms. Patch available for review here: https://reviews.apache.org/r/1034/ -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1241) php namespace generation
[ https://issues.apache.org/jira/browse/THRIFT-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13068451#comment-13068451 ] Jake Farrell commented on THRIFT-1241: -- Thanks Darius, initial work looks great. Will want to change from namespace53 to just namespace since php5.3+ will have this option available and php5.4 is in rc right now so no sense in defining a specific version in the option. Can you attach this as a patch with asf inclusion please. php namespace generation Key: THRIFT-1241 URL: https://issues.apache.org/jira/browse/THRIFT-1241 Project: Thrift Issue Type: Improvement Components: PHP - Compiler Affects Versions: 0.7 Environment: PHP 5.3 Reporter: Darius Staisiunas Labels: patch Fix For: 0.7 Patch is based mainly on https://issues.apache.org/jira/browse/THRIFT-777, but some more improvements: namespace can be specified with dots '.' like for every other language for example: namespace php com.onego.thrift would generate in php file namespace com\onego\thrift to generate php files with namespaces use: thrift --gen php:namespace53 example.thrift -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1233) Remove unused include in generated C++ code
[ https://issues.apache.org/jira/browse/THRIFT-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13067741#comment-13067741 ] Jake Farrell commented on THRIFT-1233: -- If you have a patch for this please attach it Remove unused include in generated C++ code --- Key: THRIFT-1233 URL: https://issues.apache.org/jira/browse/THRIFT-1233 Project: Thrift Issue Type: Improvement Components: C++ - Compiler Environment: Ubuntu 11.04, latest trunk. Reporter: Diwaker Gupta Assignee: Jake Farrell Priority: Trivial Fix For: 0.7 Attachments: THRIFT-1233.patch When using cob_style with the CPP generator, the compiler adds an include for TTransportUtils. This include doesn't seem to be used anywhere and creates an unnecessary dependency. It also complicates compiling Thrift generated code on other platforms. Patch available for review here: https://reviews.apache.org/r/1034/ -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1233) Remove unused include in generated C++ code
[ https://issues.apache.org/jira/browse/THRIFT-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-1233. Resolution: Fixed Fix Version/s: 0.7 Assignee: Diwaker Gupta (was: Jake Farrell) Committed, thanks for the patch. Remove unused include in generated C++ code --- Key: THRIFT-1233 URL: https://issues.apache.org/jira/browse/THRIFT-1233 Project: Thrift Issue Type: Improvement Components: C++ - Compiler Environment: Ubuntu 11.04, latest trunk. Reporter: Diwaker Gupta Assignee: Diwaker Gupta Priority: Trivial Fix For: 0.7 Attachments: THRIFT-1233.patch When using cob_style with the CPP generator, the compiler adds an include for TTransportUtils. This include doesn't seem to be used anywhere and creates an unnecessary dependency. It also complicates compiling Thrift generated code on other platforms. Patch available for review here: https://reviews.apache.org/r/1034/ -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1233) Remove unused include in generated C++ code
[ https://issues.apache.org/jira/browse/THRIFT-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13064786#comment-13064786 ] Jake Farrell commented on THRIFT-1233: -- Code looks fine, please attach patch for asf inclusion Remove unused include in generated C++ code --- Key: THRIFT-1233 URL: https://issues.apache.org/jira/browse/THRIFT-1233 Project: Thrift Issue Type: Improvement Components: C++ - Compiler Environment: Ubuntu 11.04, latest trunk. Reporter: Diwaker Gupta Assignee: Jake Farrell Priority: Trivial When using cob_style with the CPP generator, the compiler adds an include for TTransportUtils. This include doesn't seem to be used anywhere and creates an unnecessary dependency. It also complicates compiling Thrift generated code on other platforms. Patch available for review here: https://reviews.apache.org/r/1034/ -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1220) TProcessor::process never returns false
[
https://issues.apache.org/jira/browse/THRIFT-1220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell closed THRIFT-1220.
Resolution: Fixed
Fix Version/s: 0.7
Assignee: Diwaker Gupta
Thanks for the patch, committed to trunk
TProcessor::process never returns false
---
Key: THRIFT-1220
URL: https://issues.apache.org/jira/browse/THRIFT-1220
Project: Thrift
Issue Type: Bug
Components: C++ - Compiler
Affects Versions: 0.6
Environment: Ubuntu 11.04, Thrift trunk.
Reporter: Diwaker Gupta
Assignee: Diwaker Gupta
Priority: Minor
Fix For: 0.7
Attachments: THRIFT-1120.patch
The signature of TProcessor::process is
{noformat}
virtual bool process(boost::shared_ptrprotocol::TProtocol in,
boost::shared_ptrprotocol::TProtocol out,
void* connectionContext) = 0;
{noformat}
Presumably, the return value is supposed to indicate success or failure.
Unfortunately the generated C++ code _always_ returns true, even when there
are errors. For instance, if an RPC call is received but no matching function
exists, we return a TException in the response but the 'process' method still
returns true.
The attached patch makes the return values useful.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1017) Cleanup whitespaces in sourcefiles
[ https://issues.apache.org/jira/browse/THRIFT-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-1017. Resolution: Not A Problem Assignee: Jake Farrell Looking through the code base there are no tabs in any source files (.c, .cc, .h, .cs, .java, etc.), the only place i could find tabs where in makefiles. closing as non-issue, if this is a problem please submit a patch or a list of offending files and i will be glad to help with it. Cleanup whitespaces in sourcefiles -- Key: THRIFT-1017 URL: https://issues.apache.org/jira/browse/THRIFT-1017 Project: Thrift Issue Type: Improvement Reporter: Anatol Pomozov Assignee: Jake Farrell Priority: Trivial A couple of simple sed expressions can cleanup a bunch of TABS/incorrect whitespaces in the source files // Replace TAB with whitespaces in source files find -type f -name *.c | xargs sed -i 's/\t/ /g' // We need to cleanup *.h *.cc *.java *.cs files as well // Remove trailing spaces find -type f | xargs sed -i 's/ *$//g' -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-633) Generated code has @Override annotations which won't compile using Apple's JDK 1.5
[ https://issues.apache.org/jira/browse/THRIFT-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13045982#comment-13045982 ] Jake Farrell commented on THRIFT-633: - Toby, have you tried reproducing this against the trunk? THRIFT-1170 should have take care of this with the new java5 option. Generated code has @Override annotations which won't compile using Apple's JDK 1.5 -- Key: THRIFT-633 URL: https://issues.apache.org/jira/browse/THRIFT-633 Project: Thrift Issue Type: Bug Components: Java - Compiler Environment: Mac OS X Tiger/Leopard JDK 1.5 Reporter: Mathias Herberts Apple's JDK 1.5 does not recognize @Override annotation. Tests fail with error: [javac] /private/var/tmp/thrift-trunk/lib/java/gen-java/thrift/test/ComparableUnion.java:251: method does not override a method from its superclass [javac] @Override [javac]^ -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (THRIFT-1194) Java lib does not install artifacts to local dir correctly
Java lib does not install artifacts to local dir correctly
--
Key: THRIFT-1194
URL: https://issues.apache.org/jira/browse/THRIFT-1194
Project: Thrift
Issue Type: Bug
Affects Versions: 0.7
Reporter: Jake Farrell
Assignee: Jake Farrell
when porting over the java lib to be able to build maven artifacts i moved the
build files into a ${build.dir}, this broke the local install. Patch to follow
shortly
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1192) Typo: TProtocol.h tests for HAVE_SYS_PARAM_H_
[ https://issues.apache.org/jira/browse/THRIFT-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-1192. Resolution: Fixed Fix Version/s: 0.7 Assignee: Eric Rannaud added to trunk, thanks for the patch Typo: TProtocol.h tests for HAVE_SYS_PARAM_H_ - Key: THRIFT-1192 URL: https://issues.apache.org/jira/browse/THRIFT-1192 Project: Thrift Issue Type: Bug Affects Versions: 0.6.1, 0.7 Reporter: Eric Rannaud Assignee: Eric Rannaud Fix For: 0.7 Attachments: thrift-have-sys-param-typo.patch TProtocol.h tests for HAVE_SYS_PARAM_H_, which will never be defined, so sys/param.h is never included. Attached is a patch that fixes the typo on HAVE_SYS_PARAM_H, but I actually suspect that sys/param.h is not needed at all in the current codebase, as nobody reported a problem and I can't find any obvious need for it. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-731) configure doesn't check for ant = 1.7
[ https://issues.apache.org/jira/browse/THRIFT-731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-731. --- Resolution: Fixed Assignee: Jake Farrell (was: Harlan Lieberman-Berg) configure doesn't check for ant = 1.7 -- Key: THRIFT-731 URL: https://issues.apache.org/jira/browse/THRIFT-731 Project: Thrift Issue Type: Bug Components: Java - Compiler Reporter: Henry Robinson Assignee: Jake Farrell Priority: Minor Fix For: 0.7 Attachments: Thrift-731.patch, ant.diff, configure.diff ./configure on a machine with ant 1.6 successfully runs, even though it's required for the Java build step - otherwise you get BUILD FAILED /home/henry/thrift-0.2.0/lib/java/build.xml:86: Class org.apache.tools.ant.taskdefs.ConditionTask doesn't support the nested typefound element. Upgrading to ant 1.7.1 fixed the build failure, but would be nice if configure gave a clue. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-731) configure doesn't check for ant = 1.7
[ https://issues.apache.org/jira/browse/THRIFT-731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell updated THRIFT-731: Attachment: Thrift-731.patch New function using part of the previous patches to detect the current version of ant and set WITH_JAVA = no if ant 1.7. Also cleans up the check for included dep packages since they will be auto downloaded if not available with the new build. configure doesn't check for ant = 1.7 -- Key: THRIFT-731 URL: https://issues.apache.org/jira/browse/THRIFT-731 Project: Thrift Issue Type: Bug Components: Java - Compiler Reporter: Henry Robinson Assignee: Harlan Lieberman-Berg Priority: Minor Fix For: 0.7 Attachments: Thrift-731.patch, ant.diff, configure.diff ./configure on a machine with ant 1.6 successfully runs, even though it's required for the Java build step - otherwise you get BUILD FAILED /home/henry/thrift-0.2.0/lib/java/build.xml:86: Class org.apache.tools.ant.taskdefs.ConditionTask doesn't support the nested typefound element. Upgrading to ant 1.7.1 fixed the build failure, but would be nice if configure gave a clue. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-731) configure doesn't check for ant = 1.7
[ https://issues.apache.org/jira/browse/THRIFT-731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13038580#comment-13038580 ] Jake Farrell commented on THRIFT-731: - Sriranjan, Nevo: you can specify which ant, java and javac to use by passing the following to the configure script ./configure ANT=/path/to/bin/ant JAVAC=/path/to/bin/javac JAVA=/path/to/bin/java configure doesn't check for ant = 1.7 -- Key: THRIFT-731 URL: https://issues.apache.org/jira/browse/THRIFT-731 Project: Thrift Issue Type: Bug Components: Java - Compiler Reporter: Henry Robinson Assignee: Harlan Lieberman-Berg Priority: Minor Fix For: 0.7 Attachments: ant.diff, configure.diff ./configure on a machine with ant 1.6 successfully runs, even though it's required for the Java build step - otherwise you get BUILD FAILED /home/henry/thrift-0.2.0/lib/java/build.xml:86: Class org.apache.tools.ant.taskdefs.ConditionTask doesn't support the nested typefound element. Upgrading to ant 1.7.1 fixed the build failure, but would be nice if configure gave a clue. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1067) Tons of bugs in php implementation
[ https://issues.apache.org/jira/browse/THRIFT-1067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13038030#comment-13038030 ] Jake Farrell commented on THRIFT-1067: -- Jeff, THRIFT-985 is open for versioning the php client Tons of bugs in php implementation -- Key: THRIFT-1067 URL: https://issues.apache.org/jira/browse/THRIFT-1067 Project: Thrift Issue Type: Bug Components: PHP - Library Affects Versions: 0.6 Reporter: ruslan.usifov Assignee: ruslan.usifov Fix For: 0.7 Attachments: php20110219.patch PHP version of thrift hold many bugs: 1). Incorrect work with ZTS 2). Hung when work throw thrift framed transport 3). Memleak in protocol_writeMessageBegin 4). Hung when server close connection, and when php code try reuse same connection 5). Impossible pass really long values on 32 bit platforms -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1174) Publish as3 client implementation via Maven for use by flex-mojos users
[ https://issues.apache.org/jira/browse/THRIFT-1174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13036905#comment-13036905 ] Jake Farrell commented on THRIFT-1174: -- got this all working and published to the staging repo with no issues. Generates the pom and swc files based on the current java version. Artifacts uploaded where libthrift-as3-0.7.0-snapshot.pom libthrift-as3-0.7.0-snapshot.swc I'm cleaning up the java/fb303/javascript and as3 build files to share common components and reduce code duplications. Will check the updates into trunk shortly Publish as3 client implementation via Maven for use by flex-mojos users --- Key: THRIFT-1174 URL: https://issues.apache.org/jira/browse/THRIFT-1174 Project: Thrift Issue Type: Improvement Components: Build Process Affects Versions: 0.6.1 Environment: Maven 3.0.3 using central repository Reporter: Justin Florentine Assignee: Jake Farrell Labels: flex, maven Fix For: 0.7 Attachments: pom.xml It would be nice to be able to use the flex-mojos to get the as3 client implementation .swc artifact the same way we can get the .jar artifact for java clients. An example pom that uses this approach with our local repositories should be attached. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1174) Publish as3 client implementation via Maven for use by flex-mojos users
[ https://issues.apache.org/jira/browse/THRIFT-1174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-1174. Resolution: Fixed Added to trunk, next release the libthrift-as3 client will get published to apache maven central with the libthrift and fb303 clients. Publish as3 client implementation via Maven for use by flex-mojos users --- Key: THRIFT-1174 URL: https://issues.apache.org/jira/browse/THRIFT-1174 Project: Thrift Issue Type: Improvement Components: Build Process Affects Versions: 0.6.1 Environment: Maven 3.0.3 using central repository Reporter: Justin Florentine Assignee: Jake Farrell Labels: flex, maven Fix For: 0.7 Attachments: pom.xml It would be nice to be able to use the flex-mojos to get the as3 client implementation .swc artifact the same way we can get the .jar artifact for java clients. An example pom that uses this approach with our local repositories should be attached. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-980) as3: add version Info to the library
[ https://issues.apache.org/jira/browse/THRIFT-980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-980. --- as3: add version Info to the library Key: THRIFT-980 URL: https://issues.apache.org/jira/browse/THRIFT-980 Project: Thrift Issue Type: Sub-task Components: AS3 - Library Reporter: Roger Meier Assignee: Jake Farrell add version info to the library and update http://wiki.apache.org/thrift/HowToVersion -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1174) Publish as3 client implementation via Maven for use by flex-mojos users
[ https://issues.apache.org/jira/browse/THRIFT-1174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13036385#comment-13036385 ] Jake Farrell commented on THRIFT-1174: -- Thanks Justin, should be able to accomplish this similar to how i did the fb303 and libthrift java versions Publish as3 client implementation via Maven for use by flex-mojos users --- Key: THRIFT-1174 URL: https://issues.apache.org/jira/browse/THRIFT-1174 Project: Thrift Issue Type: Improvement Components: Build Process Affects Versions: 0.6.1 Environment: Maven 3.0.3 using central repository Reporter: Justin Florentine Assignee: Jake Farrell Labels: flex, maven Fix For: 0.7 Attachments: pom.xml It would be nice to be able to use the flex-mojos to get the as3 client implementation .swc artifact the same way we can get the .jar artifact for java clients. An example pom that uses this approach with our local repositories should be attached. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (THRIFT-1174) Publish as3 client implementation via Maven for use by flex-mojos users
[ https://issues.apache.org/jira/browse/THRIFT-1174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell reassigned THRIFT-1174: Assignee: Jake Farrell Publish as3 client implementation via Maven for use by flex-mojos users --- Key: THRIFT-1174 URL: https://issues.apache.org/jira/browse/THRIFT-1174 Project: Thrift Issue Type: Improvement Components: Build Process Affects Versions: 0.6.1 Environment: Maven 3.0.3 using central repository Reporter: Justin Florentine Assignee: Jake Farrell Labels: flex, maven Fix For: 0.7 Attachments: pom.xml It would be nice to be able to use the flex-mojos to get the as3 client implementation .swc artifact the same way we can get the .jar artifact for java clients. An example pom that uses this approach with our local repositories should be attached. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (THRIFT-835) Bad AS3 syntax in constructors that set default values
[
https://issues.apache.org/jira/browse/THRIFT-835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell resolved THRIFT-835.
-
Resolution: Fixed
Fix Version/s: 0.7
Assignee: Justin Florentine
Added to trunk, thanks for the patch.
Bad AS3 syntax in constructors that set default values
--
Key: THRIFT-835
URL: https://issues.apache.org/jira/browse/THRIFT-835
Project: Thrift
Issue Type: Bug
Components: AS3 - Compiler
Affects Versions: 0.3
Environment: Any.
Reporter: Justin Florentine
Assignee: Justin Florentine
Fix For: 0.7
Attachments: THRIFT-835.patch
If your thrift definition declares static default values, such as:
struct Chat {
1: MessageType type = EVENT_CHAT,
2: i32 eventId,
3: string message,
4: Date at
}
The generated AS3 object won't compile since the compiler uses the same
function that generates member declarations. Patch is below.
{code}
Index: compiler/cpp/src/generate/t_as3_generator.cc
===
--- compiler/cpp/src/generate/t_as3_generator.cc(revision 981076)
+++ compiler/cpp/src/generate/t_as3_generator.cc(working copy)
@@ -696,7 +696,8 @@
for (m_iter = members.begin(); m_iter != members.end(); ++m_iter) {
t_type* t = get_true_type((*m_iter)-get_type());
if ((*m_iter)-get_value() != NULL) {
- print_const_value(out, this. + (*m_iter)-get_name(), t,
(*m_iter)-get_value(), true, true);
+ indent(out) this._ (*m_iter)-get_name() =
(*m_iter)-get_value()-get_integer() ;
+ endl;
}
}
indent_down();
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-835) Bad AS3 syntax in constructors that set default values
[
https://issues.apache.org/jira/browse/THRIFT-835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell closed THRIFT-835.
---
Bad AS3 syntax in constructors that set default values
--
Key: THRIFT-835
URL: https://issues.apache.org/jira/browse/THRIFT-835
Project: Thrift
Issue Type: Bug
Components: AS3 - Compiler
Affects Versions: 0.3
Environment: Any.
Reporter: Justin Florentine
Assignee: Justin Florentine
Fix For: 0.7
Attachments: THRIFT-835.patch
If your thrift definition declares static default values, such as:
struct Chat {
1: MessageType type = EVENT_CHAT,
2: i32 eventId,
3: string message,
4: Date at
}
The generated AS3 object won't compile since the compiler uses the same
function that generates member declarations. Patch is below.
{code}
Index: compiler/cpp/src/generate/t_as3_generator.cc
===
--- compiler/cpp/src/generate/t_as3_generator.cc(revision 981076)
+++ compiler/cpp/src/generate/t_as3_generator.cc(working copy)
@@ -696,7 +696,8 @@
for (m_iter = members.begin(); m_iter != members.end(); ++m_iter) {
t_type* t = get_true_type((*m_iter)-get_type());
if ((*m_iter)-get_value() != NULL) {
- print_const_value(out, this. + (*m_iter)-get_name(), t,
(*m_iter)-get_value(), true, true);
+ indent(out) this._ (*m_iter)-get_name() =
(*m_iter)-get_value()-get_integer() ;
+ endl;
}
}
indent_down();
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (THRIFT-1163) How can i use multi service in one program?
[
https://issues.apache.org/jira/browse/THRIFT-1163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell resolved THRIFT-1163.
--
Resolution: Not A Problem
Assignee: Jake Farrell
Please ask questions like this to the user or dev mailing list. You are able to
have multiple service blocks within one definition file. The compiler will
generate separate files for each service as shown below.
gen-cpp/
|-- FirstService.cpp
|-- FirstService.h
|-- FirstService_server.skeleton.cpp
|-- SecondService.cpp
|-- SecondService.h
|-- SecondService_server.skeleton.cpp
|-- test_constants.cpp
|-- test_constants.h
|-- test_types.cpp
`-- test_types.h
gen-java/
|-- FirstService.java
`-- SecondService.java
How can i use multi service in one program?
---
Key: THRIFT-1163
URL: https://issues.apache.org/jira/browse/THRIFT-1163
Project: Thrift
Issue Type: Question
Components: C++ - Library
Affects Versions: 0.6.1
Reporter: qiutao
Assignee: Jake Farrell
Labels: features
Fix For: 0.6.1
For example,i have two service like this:
service FirstService
{
string hello()
}
service SecondService
{
string hello()
}
the generated code have two skeleton server file,how can i use them in one
program?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1104) INSTALLDIRS should be included in configure script
[ https://issues.apache.org/jira/browse/THRIFT-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-1104. Resolution: Fixed Thanks for the patch Dmitriy, committed against trunk. INSTALLDIRS should be included in configure script -- Key: THRIFT-1104 URL: https://issues.apache.org/jira/browse/THRIFT-1104 Project: Thrift Issue Type: Bug Components: Build Process Affects Versions: 0.7 Reporter: Dmitriy Kargapolov Assignee: Dmitriy Kargapolov Fix For: 0.7 Attachments: perl_dirs.patch There are two env variables in lib/perl/Makefile.am to run Makefile.PL: INSTALLDIRS and PERL_PREFIX. Second one can be specified in the configure run. But not the INSTALLDIRS. I found no easy way to specify it in the command line during the build. I suggest to add INSTALLDIRS parameter to the configure.ac. It will help to customize build process for various platforms. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1160) Thrift incubator website should redirect to thrift.apache.org
[ https://issues.apache.org/jira/browse/THRIFT-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13028407#comment-13028407 ] Jake Farrell commented on THRIFT-1160: -- modified incubator to redirect back to current thrift site, waiting on cache to clear before closing ticket. Thrift incubator website should redirect to thrift.apache.org - Key: THRIFT-1160 URL: https://issues.apache.org/jira/browse/THRIFT-1160 Project: Thrift Issue Type: Bug Components: Website Reporter: Jeff Whiting Assignee: Jake Farrell Search google for apache thrift. The top link goes to http://incubator.apache.org/thrift/. That site is outdated and not maintained. Clicking on the download link takes you to an older version of thrift (0.5.0). It can be very confusing and has tripped up multiple developers where I work. http://incubator.apache.org/thrift/ should simply be redirected to the current site http://thrift.apache.org to prevent confusion and have people going to the current website. Using a permanent 301 redirect would be the best as it would tell the search engines that the site has moved. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1155) Remove log4j dependency from java client
[ https://issues.apache.org/jira/browse/THRIFT-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-1155. Resolution: Fixed Fix Version/s: 0.7 Removed slf4j-log4j dependency in the java build.xml. Any app using the client can now decide on which logger to use. Remove log4j dependency from java client Key: THRIFT-1155 URL: https://issues.apache.org/jira/browse/THRIFT-1155 Project: Thrift Issue Type: Improvement Affects Versions: 0.6.1, 0.7 Reporter: Jake Farrell Assignee: Jake Farrell Fix For: 0.7 Remove unnecessary dependency on log4j from java client -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-363) Maven Deploy
[ https://issues.apache.org/jira/browse/THRIFT-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13024799#comment-13024799 ] Jake Farrell commented on THRIFT-363: - 0.6.1 artifacts now available from main apache repo (http://repo1.maven.org/maven2) dependency groupIdorg.apache.thrift/groupId artifactIdlibthrift/artifactId version0.6.1/version /dependency Maven Deploy Key: THRIFT-363 URL: https://issues.apache.org/jira/browse/THRIFT-363 Project: Thrift Issue Type: Improvement Components: Java - Library Reporter: Gary Rudolph Assignee: Jake Farrell Fix For: 0.6.1, 0.7 Attachments: THRIFT-363.patch, THRIFT-363.patch, THRIFT-363.patch, THRIFT-363.patch, THRIFT-363.patch, THRIFT-363.patch, THRIFT-363.patch, THRIFT-363.patch, pom.1.patch, thrift-363-0.6.x.patch, thrift-363.patch Please, deploy libthrift into a public maven repository. Preferably, to Maven central, but if not at least the Apache. Maven Central: http://maven.apache.org/guides/mini/guide-central-repository-upload.html Apache Incubator Repository: http://people.apache.org/repo/m2-incubating-repository/ The following is a sample pom.xml: project xmlns=http://maven.apache.org/POM/4.0.0; xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation=http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd; modelVersion4.0.0/modelVersion groupIdorg.facebook.thrift/groupId artifactIdlibthrift/artifactId version0.1-20090310/version packagingjar/packaging nameApache Thrift Library/name urlhttp://incubator.apache.org/thrift//url descriptionThrift is a software framework for scalable cross-language services development. It combines a software stack with a code generation engine to build services that work efficiently and seamlessly between C++, Java, Python, PHP, Ruby, Erlang, Perl, Haskell, C#, Cocoa, Smalltalk, and OCaml/description licenses license nameThe Apache Software License, Version 2.0/name urlhttp://www.apache.org/licenses/LICENSE-2.0.txt/url distributionrepo/distribution /license /licenses scm urlhttp://svn.apache.org/repos/asf/incubator/thrift/trunk/url /scm /project -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1152) Attributes from private to protected
[ https://issues.apache.org/jira/browse/THRIFT-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell updated THRIFT-1152: - Attachment: thrift-1152.patch Changing the TForkingServer children_ from private to protected Attributes from private to protected Key: THRIFT-1152 URL: https://issues.apache.org/jira/browse/THRIFT-1152 Project: Thrift Issue Type: Sub-task Components: PHP - Library Affects Versions: 0.7 Reporter: Simon E Priority: Trivial Attachments: thrift-1152.patch The TForkingServer has an attribute for the childs it creates.. now the problem is: We're having a PHP daemon which uses the TForkingServer so that it handles all connections in a seperate thread. When we have to restart the daemon (code change) the main thread doing serve() would be restartet but all the childs won't (we have persistent connections) stop, so i wan't to extend the class and send a sigterm to all the chils but the childs_ attribute is PRIVATE so it should be PROTECTED i think. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1152) Attributes from private to protected
[ https://issues.apache.org/jira/browse/THRIFT-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-1152. Resolution: Fixed Fix Version/s: 0.7 Assignee: Jake Farrell Attributes from private to protected Key: THRIFT-1152 URL: https://issues.apache.org/jira/browse/THRIFT-1152 Project: Thrift Issue Type: Sub-task Components: PHP - Library Affects Versions: 0.7 Reporter: Simon E Assignee: Jake Farrell Priority: Trivial Fix For: 0.7 Attachments: thrift-1152.patch The TForkingServer has an attribute for the childs it creates.. now the problem is: We're having a PHP daemon which uses the TForkingServer so that it handles all connections in a seperate thread. When we have to restart the daemon (code change) the main thread doing serve() would be restartet but all the childs won't (we have persistent connections) stop, so i wan't to extend the class and send a sigterm to all the chils but the childs_ attribute is PRIVATE so it should be PROTECTED i think. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-322) IHttpHandler for Thrift
[ https://issues.apache.org/jira/browse/THRIFT-322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13022170#comment-13022170 ] Jake Farrell commented on THRIFT-322: - Nils, where you able to find a resolution for the 3rd test case aborting? IHttpHandler for Thrift --- Key: THRIFT-322 URL: https://issues.apache.org/jira/browse/THRIFT-322 Project: Thrift Issue Type: New Feature Components: C# - Library Reporter: Fredrik Hedberg Assignee: Nils Hügelmann Priority: Minor Attachments: thrift-csharp-httphandler-test.diff, thrift-csharp-httphandler.diff, thrift-csharp-httphandler.diffupdated.diff, thrift-csharp-httphandler2.diff, thrift-csharp-httphandler3.diff IHttpHandler for Thrift. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1133) Java and JavaScript tutorial is broken since we have Java maven deployment
[ https://issues.apache.org/jira/browse/THRIFT-1133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-1133. Resolution: Fixed Fix Version/s: 0.7 0.6.1 Updated build.xml in the js test cases folder to now use ant-tasks. Java and JavaScript tutorial is broken since we have Java maven deployment --- Key: THRIFT-1133 URL: https://issues.apache.org/jira/browse/THRIFT-1133 Project: Thrift Issue Type: Bug Components: Tutorial Reporter: Roger Meier Assignee: Jake Farrell Fix For: 0.6.1, 0.7 Attachments: THRIFT-1133_fix_JavaScript_and_Java_Tutorial.patch, thrift-1133-0.6.x.patch, thrift-1133.patch fix Java and JavaScript tutorial -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1114) Maven publish shouldn't require passwords hardcoded in settings.xml
[ https://issues.apache.org/jira/browse/THRIFT-1114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13022208#comment-13022208 ] Jake Farrell commented on THRIFT-1114: -- Current maven gpg plugin does not support encrypted passwords in the ~/.m2/settings.xml file. Ticket: http://jira.codehaus.org/browse/MGPG-31. Looking into what it would take for me to add this to the gpg plugin Maven publish shouldn't require passwords hardcoded in settings.xml --- Key: THRIFT-1114 URL: https://issues.apache.org/jira/browse/THRIFT-1114 Project: Thrift Issue Type: Improvement Reporter: Bryan Duxbury Assignee: Jake Farrell -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (THRIFT-1109) Deploy fb303 along side libthrift to maven repo
[ https://issues.apache.org/jira/browse/THRIFT-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell resolved THRIFT-1109. -- Resolution: Fixed r1095218 Added the ability to publish fb303 library along side libthrift to the apache maven repo. Deploy fb303 along side libthrift to maven repo --- Key: THRIFT-1109 URL: https://issues.apache.org/jira/browse/THRIFT-1109 Project: Thrift Issue Type: Improvement Components: Java - Library Reporter: Jake Farrell Assignee: Jake Farrell Attachments: thrift-1109-0.6.x.thrift, thrift-1109-0.6.x.thrift -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
