[GitHub] thrift pull request: thrift: clean up enum value assignment

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/88#issuecomment-39388481
  
There is no ticket yet, right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2470: Stop THttpHandler from swallowin...

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/100#issuecomment-40643771
  
Thanks for the patch. I'm not so sure if introducing a number of 
dependencies plus another new test project by a coup de main is such a great 
idea, especially if we compare all those changes to the net size of the patch 
itself. Did you run the tests on all relevant platforms or only with Visual 
Studio? I'm just asking, because that's important.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: c# TestServer and TestClient: parameter align...

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/108#issuecomment-41503655
  
Hi Beat, 
is there a JIRA ticket for it? If not, could you create one? 
Thanks,
JensG


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: String Generation With Nested Single Quotes

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/107#issuecomment-41503901
  
Hi,

The problem should already be solved (in a better way, btw) by 
[THRIFT-2495](https://issues.apache.org/jira/browse/THRIFT-2495), so I guess 
that this pull request has become  somewhat obsolete. If not, please reopen 
[THRIFT-2495](https://issues.apache.org/jira/browse/THRIFT-2495) and add a test 
case. 

Appreciating your contribution,
JensG



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-1914 Python: Support for Multiplexing ...

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/82#issuecomment-41959894
  
So this one is obsolete?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Support non-blocking server listening on unix...

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/80#issuecomment-42109977
  
Would you mind to open an associated JIRA ticket? 
For details have a look at http://thrift.apache.org/docs/HowToContribute
Thank you!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: String Generation With Nested Single Quotes

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/107#issuecomment-42110020
  
@cristiancavalli: Ping


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Update README.md

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/115#issuecomment-42110035
  
Would you mind to open an associated JIRA ticket? 
For details have a look at http://thrift.apache.org/docs/HowToContribute
Thank you!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: String Generation With Nested Single Quotes

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/107#issuecomment-42150135
  
Many thanks for catching this. What do we do with this pull request? ;-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Firemonkey

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/121#issuecomment-43379870
  
Great! 

Could you please create a 
[JIRA](https://issues.apache.org/jira/browse/THRIFT) ticket and have a look at 
the [contrib guide](http://thrift.apache.org/docs/HowToContribute), just to 
make sure everything is in place? 

Looking forward to review it!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Firemonkey

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/121#issuecomment-43380754
  
Why are you reformatting the whole code? No wonder the patch is that big.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: 0.9.1 hi ，What time to support python3

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/125#issuecomment-44050508
  
This pull request seems rather invalid, so please close it. 

However, if the patch is in your opinion absolutely correct, you are free 
to file a JIRA ticket for this pull request explaining the details about why 
this pull request is valid and what issue or feature it covers.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Implement Thrift.Protocol.prototype.skip() fo...

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/139#issuecomment-45955651
  
[Could you add an JIRA 
ticket?](http://thrift.apache,.org/docs/HowToContribute)? 
Furthermore, an associated test case would be great as well!
Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Update simple_json_protocol.go

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/134#issuecomment-45955641
  
[Could you add an JIRA 
ticket?](http://thrift.apache,.org/docs/HowToContribute)? 
Furthermore, an associated test case would be great as well!
Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2576 Implement Thrift.Protocol.prototy...

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/141#issuecomment-46114247
  
THRIFT-2576


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: make thrift cocoa lib support TMultiplexedPro...

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/150#issuecomment-47970882
  
Hi guoyalun ,
that's great! 

Could you just file a JIRA ticket and reference it here? 
http://thrift.apache.org/docs/HowToContribute

Thanks!
JensG


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: make thrift cocoa lib support TMultiplexedPro...

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/150#issuecomment-47992574
  
Hi  @guoyalun and @drobakowski,

I'd really like you **both** to agree upon **one** patch set, which will 
finally be committed to the Thrift code base. That way we could involve more 
knowledgeable eyes to look out for problems. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Add basic default hash code method to python,...

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/155#issuecomment-48658641
  
-1

Something's wrong with your proposed changes. You really want to change the 
version of the current Thrift trunk from 1.0.0 back to 0.9.1 which was released 
long time ago? Please double-check your pull request, this can't be right.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Add basic default hash code method to python,...

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/156#issuecomment-48669749
  
Tracked in THRIFT-2621


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Add php:validate option for generating read/w...

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/159#issuecomment-49666018
  
Tracked in THRIFT-2632


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Add basic default hash code method to python,...

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/156#issuecomment-50931303
  
I forgot to reference the pull request in the commit. 
Could you please close it manually? Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-585 Wrap py:twisted calls in maybeDefe...

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/165#issuecomment-51521449
  
Hi @jamesbroadhead, 

> Happy to try to help fix your CI too -- what would be needed?

Build the changes on your machine, then run `make check` to execute the 
test Suite. This should be completed without errors.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: C# - reduce number of server exceptions

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/177#issuecomment-51640422
  
tracked in THRIFT-2654


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Add basic default hash code method to python,...

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/156#issuecomment-52234520
  
@Dustin Spicuzza,

> PYTHONHASHSEED breaks clients using Python < 3.2

is there a way to define PYTHONHASHSEED for older versions as a simple 
constant? I'd like to use PYTHONHASHSEED whenever available, since there's a 
good reason for it. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Add basic default hash code method to python,...

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/156#issuecomment-52238173
  
Yeah, something like this. Right now I can't do it myself, sorry. If you 
want to provide a patch or pull request, someone will take care of it, just 
mention the number of [this ticket](http://tinyurl.com/njcr3mx) in the pull 
request - thanks!

See also http://thrift.apache.org/docs/HowToContribute for further 
information.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Update TCompactProtocol.php

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/212#issuecomment-55305617
  
Tracked in THRIFT-2701. 
Could you please check the Travis report?
https://travis-ci.org/apache/thrift/builds/35028997




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-1040 compiler: typedef lines can now e...

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/211#issuecomment-55326659
  
I forgot to mention the pull request in the commit. Could you close it 
manually?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2644 Haxe support

[Jens-G]

GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/214

THRIFT-2644 Haxe support

Client: Haxe
Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift thrift-2644

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/214.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #214


commit 66f2f4a09672287fe71cf66998120a95869a7334
Author: Jens Geyer 
Date:   2014-07-27T23:25:30Z

THRIFT-2644 Haxe support
Client: Haxe
Patch: Jens Geyer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: C# - reduce number of server exceptions

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/177#issuecomment-56222777
  
I like the idea. But Peek() isn't actually a peek, it is a read operation. 
Let's just take this (theoretical) scenario:

* call `transport.Peek()` to effectively read a Byte
* now call `transport.Read()` instead of `transport.ReadAll()` 
* depending on the Transport used, you may lose the peeked Byte, maybe read 
it later out of band.

I haven't checked the entire code if that is currently the case, but I 
don't like even the possibility of this. To me it would unexpected that Read 
and ReadAll differ that much. 

While we're at it, why don't we implement a real peek operation? Again, I 
like the idea!
  




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Update t_cpp_generator.cc

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/123#issuecomment-57365455
  
@fidelchen : You may find this helpful as well: 
http://thrift.apache.org/docs/HowToContribute 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2753 Haxe support (part 2)

[Jens-G]

GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/229

THRIFT-2753 Haxe support (part 2)

THRIFT-2753 
Misc. Haxe improvements, 
Requires pull request 214 to be merged first.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift thrift-2753

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/229.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #229


commit 17e419f563052a7da84e5d7e45f4c8a53cb99675
Author: Jens Geyer 
Date:   2014-07-27T23:25:30Z

Haxe: Compiler, Library, Tutorial

commit cff089794170cb60b4aa532cdbdc85820e94f538
Author: Jens Geyer 
Date:   2014-07-31T21:17:36Z

multiple fixes
- endianess (network byte order)
- property getter/setter
- socket transport
- class Set

commit ce4d54832b0a22b8644c7c59572fe0902b12da1c
Author: Jens Geyer 
Date:   2014-08-01T23:31:37Z

Merge branch 'master' into haxe

commit ba4db27c6aaac28640c002a4b3dfa5f733791efe
Author: Jens Geyer 
Date:   2014-08-02T22:55:26Z

completed server-side, refactoring

commit ad80a8137b95913a6972d5e6f07747e2bc820f52
Author: Jens Geyer 
Date:   2014-08-02T23:48:13Z

added HIDE project files

commit 3b402afee85438b0c55a192d328f3cbe0220c49c
Author: Jens Geyer 
Date:   2014-08-05T20:18:51Z

Build enhancements
- added README file
- added some rudimentary shell/batch script files,
- revised *.hxml project files

commit 6b6ca94f666e76a3e3836171cd9bff6ca15af079
Author: Jens Geyer 
Date:   2014-08-05T22:24:54Z

improved error handling

commit 08195b5f02db32b54bd5090c3fca93e56374e924
Author: Jens Geyer 
Date:   2014-08-05T22:49:16Z

Merge branch 'master' of https://github.com/apache/thrift into haxe

commit 7f6f196633a8689ba4dddf1b553a1ac95585f8f9
Author: Jens Geyer 
Date:   2014-08-08T21:54:00Z

improvements for flash and js targets

commit 9194bc9e2bdbb42314126d09b1e09fcc6bb5bf01
Author: Jens Geyer 
Date:   2014-08-08T23:08:34Z

Merge branch 'master' into haxe

commit 18a7556f7f3fbc44f5503b38e7187e145fb1efb1
Author: Jens Geyer 
Date:   2014-08-11T15:21:43Z

improved codegen for struct members

commit 05ef10c5a104d2c2aef3e38d0c0f21ba858faeb5
Author: Jens Geyer 
Date:   2014-08-11T23:26:51Z

Server not available for HTML5

commit f51feaaabca5bbde2a07dbee2ff7c963fce3a781
Author: Jens Geyer 
Date:   2014-08-12T16:44:25Z

Replace AS3 onError/onSuccess callback style by "normal" 
function():result/exception style. The AS3 callback style is still available 
via option,

commit 21ce660e360e6b74b0ba2f2d54761c2cb9f0cc2c
Author: Jens Geyer 
Date:   2014-08-12T17:23:38Z

error improvements

commit 5f91f965c4023ae2cd1c79d455dead58156ba350
Author: Jens Geyer 
Date:   2014-08-12T17:41:57Z

Merge branch 'master' into haxe

commit d6440a588092307d410135f223037ec6c6bfa821
Author: Jens Geyer 
Date:   2014-08-12T19:34:42Z

- added test client/server (work in progress)
- improved codegen for list/set/map
- renamed T*Error to T*Exception
- fixed license headers

commit ab2e974c880e21f91057c51c5cc22cf287be7a26
Author: Jens Geyer 
Date:   2014-08-15T17:18:14Z

added test client/server code compiles (C++), not fully tested yet

commit 69dd48828909d2eef0bee1d37b58b7c6df3a01e5
Author: Jens Geyer 
Date:   2014-09-06T00:01:05Z

Merge branch 'master' into haxe

commit 12866fb3a7be20fddcbbe433f07a517164cacb33
Author: Jens Geyer 
Date:   2014-09-06T21:33:39Z

Haxe cross test

commit 25bf6c3adbfd8cc3bf10cf93e1702fc4a71a39c2
Author: Jens Geyer 
Date:   2014-09-07T00:10:23Z

- Int64Map added, can't use ObjectMap for haxe.Int64
- cross-test Client actually tests things now
- updated lib/haxe/README.md

commit 3298a61cfdfddbb77ffc54366d28dcded62a019e
Author: Jens Geyer 
Date:   2014-09-11T23:33:52Z

Makefiles

commit c33864c67414fd532fa3664467c7ae769e1456d8
Author: Jens Geyer 
Date:   2014-09-12T23:36:45Z

Merge branch 'master' of https://github.com/apache/thrift into haxe

commit ab52f076ad68381d9764e34e1910eaa113b40cf7
Author: Jens Geyer 
Date:   2014-09-12T23:48:17Z

Revised README

commit 66f2f4a09672287fe71cf66998120a95869a7334
Author: Jens Geyer 
Date:   2014-07-27T23:25:30Z

THRIFT-2644 Haxe support
Client: Haxe
Patch: Jens Geyer

commit 61a4c96cf39a2b5472e437e3464153b605e5de4d
Author: Jens Geyer 
Date:   2014-09-16T20:49:40Z

THRIFT-2704 generated oneway functions encode as T_CALL not T_ONEWAY

commit 34bcf8a9394fbe0ba1fa8c818a51d7ea597d6ad7
Author: Jens Geyer 
Date:   2014-09-17T21:07:02Z

Merge branch 'master' into haxe

commit 69dcae905dc0459876b1155c619d8deaaf7734d9
Author: Jens Geyer 
Date:   2014-09-17T21:10:49Z

Merge branch 'haxe&#

[GitHub] thrift pull request: D: Fix thrift.internal.traits unittest build.

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/237#issuecomment-57943272
  
Hi, 
[are there already any JIRA 
tickets](http://thrift.apache,org/docs/HowToContribute) for these pull requests?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: D: Fix thrift.internal.traits unittest build.

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/237#issuecomment-58242100
  
Thank you!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Fix PHP TJSONProtocol encode unicode into UTF...

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/244#issuecomment-58563098
  
Hi,

thanks for the patch.

> JSON_UNESCAPED_UNICODE option is only available for PHP 5.4+.

does that mean, the old patch was not suitable because of that problem, but 
this one is? Otherwise please explain.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Fix PHP TJSONProtocol encode unicode into UTF...

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/244#issuecomment-58743421
  
In other words, it is safe to merge this and it will not break older PHP 
versions?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Wrap errors in iostream_transport.go

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/246#issuecomment-58942808
  
tracked in THRIFT-2785


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2806 more whitespace fixups

[Jens-G]

GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/254

THRIFT-2806 more whitespace fixups

Client: Haxe
Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift thrift-2806

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/254.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #254


commit 5f2e349f63cf6d0c827dea87639cc123a9329bc5
Author: Jens Geyer 
Date:   2014-11-09T01:38:11Z

THRIFT-2806 more whitespace fixups
Client: Haxe
Patch: Jens Geyer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: PHP CS Fix

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/252#issuecomment-62287604
  
Hi, could you just open a JIRA ticket? 
http://thrift.apache.org/docs/HowToContribute
Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Go Library - Make remote socket address acces...

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/255#issuecomment-62447225
  
Tracked in THRIFT-2811. Next time please create the ticket yourself. Thank 
you.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Backout

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/259#issuecomment-62473003
  
tracked in THRIFT-2812



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2813 multiple library fixes/improvemen...

[Jens-G]

GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/260

THRIFT-2813 multiple library fixes/improvements

- TSocket ignores timeout on read()
- TFramedTransport throws Eof after first receive cycle
- TFramedTransport .flush() did not invoke the read callback
- incorrect declaration of logDelegate member variable
- added FlashDevelop project files
- added Haxe files to EXTRA_DIST etc.
- added haxelib.json control file for haxelib.org

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift thrift-2813

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/260.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #260


commit b2138d28741c8921392d65f907ec1d3f6973d286
Author: Jens Geyer 
Date:   2014-10-17T23:40:20Z

multiple library fixes/improvements:
- TSocket ignores timeout on read()
- TFramedTransport throws Eof after first receive cycle
- TFramedTransport .flush() did not invoke the read callback
- incorrect declaration of logDelegate member variable
- added FlashDevelop project files
- added Haxe files to EXTRA_DIST etc.
- added haxelib.json control file for haxelib.org




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2814 args/results class not found with...

[Jens-G]

GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/261

THRIFT-2814 args/results class not found without namespaces

The args/results helper classes are not found by the Haxe compiler if no 
namespaces are set in the IDL

Changes:
- one source file per Haxe class
- ensure correctly capitalized names

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift thrift-2814

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/261.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #261


commit fceae91c153c86e146259b3a44fe693d0e467d79
Author: Jens Geyer 
Date:   2014-11-09T22:05:37Z

args/results class not found without namespaces
- one source file per Haxe class
- ensure correctly capitalized names




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Thrift 2815 Haxe: Support for Multiplexing Se...

[Jens-G]

GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/262

Thrift 2815 Haxe: Support for Multiplexing Services on any Transport, 
Protocol and Server

Patch depends on THRIFT-2813 (git source) and THRIFT-2814 (test codegen)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift thrift-2815

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/262.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #262


commit b2138d28741c8921392d65f907ec1d3f6973d286
Author: Jens Geyer 
Date:   2014-10-17T23:40:20Z

multiple library fixes/improvements:
- TSocket ignores timeout on read()
- TFramedTransport throws Eof after first receive cycle
- TFramedTransport .flush() did not invoke the read callback
- incorrect declaration of logDelegate member variable
- added FlashDevelop project files
- added Haxe files to EXTRA_DIST etc.
- added haxelib.json control file for haxelib.org

commit c8c9d6e399bf0ae6d45d54b9a524eaf2d27837cb
Author: Jens Geyer 
Date:   2014-11-09T17:52:48Z

Multiplex protocol on any language




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Fix TSimpleJSONProtocol reading beyond messag...

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/264#issuecomment-62956285
  
Thank you for the contributions!

May I ask two things?
(1) please [add JIRA tickets for both pull 
requests](http://thrift.apache.org/docs/HowToContribute)
(2) for this specific patch, a test case seems a good addition

Thanks again!



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2817 - TSimpleJSONProtocol reads beyon...

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/264#issuecomment-63125348
  
Have a look at the `multiplexed_protocol_test.go` file for an example how 
to achieve that. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2817 - TSimpleJSONProtocol reads beyon...

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/264#issuecomment-63192311
  
The usual makefiles, or what do you mean? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2829 Support haxelib installation via ...

[Jens-G]

GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/268

THRIFT-2829 Support haxelib installation via github



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift thrift-2829

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/268.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #268


commit b2138d28741c8921392d65f907ec1d3f6973d286
Author: Jens Geyer 
Date:   2014-10-17T23:40:20Z

multiple library fixes/improvements:
- TSocket ignores timeout on read()
- TFramedTransport throws Eof after first receive cycle
- TFramedTransport .flush() did not invoke the read callback
- incorrect declaration of logDelegate member variable
- added FlashDevelop project files
- added Haxe files to EXTRA_DIST etc.
- added haxelib.json control file for haxelib.org

commit 6bfefaec6834e134c338a20aeb1ac55ce8305873
Author: Jens Geyer 
Date:   2014-11-09T22:05:37Z

args/results class not found without namespaces
- one source file per Haxe class
- ensure correctly capitalized names

commit 3f6984db86aabb25408ae5a6e64a7a3d9c960a70
Author: Jens Geyer 
Date:   2014-11-09T17:52:48Z

Multiplex protocol on any language

commit 26f5fdc3724873adf9f728b6f3818a1edd52e775
Author: Jens Geyer 
Date:   2014-10-17T23:40:20Z

multiple library fixes/improvements:
- TSocket ignores timeout on read()
- TFramedTransport throws Eof after first receive cycle
- TFramedTransport .flush() did not invoke the read callback
- incorrect declaration of logDelegate member variable
- added FlashDevelop project files
- added Haxe files to EXTRA_DIST etc.
- added haxelib.json control file for haxelib.org

commit cc3e11d8a3040541662980d3ac2cd69ec4fa6bb2
Author: Jens Geyer 
Date:   2014-11-09T22:05:37Z

args/results class not found without namespaces
- one source file per Haxe class
- ensure correctly capitalized names

commit 6aa05f31ae8cc5ea6b4a6220359626c64d20adea
Author: Jens Geyer 
Date:   2014-11-09T17:52:48Z

Multiplex protocol on any language

commit a248817f122541023a9f541607923a2ed86c3c23
Author: Jens Geyer 
Date:   2014-11-10T23:54:05Z

Merge branch 'master' of https://github.com/Jens-G/thrift

commit 087596dcc1e40315c46ff6c77a1651785320152e
Author: Jens Geyer 
Date:   2014-11-11T01:08:45Z

Merge branch 'master' of https://github.com/apache/thrift

commit bc50db3106cbfd6ddf9837e5342b10a1e0f9815d
Author: Jens Geyer 
Date:   2014-11-15T22:31:27Z

Merge branch 'master' of https://github.com/apache/thrift

commit 722594b6f66690e3abb581356526487c0dd8c48a
Author: Jens Geyer 
Date:   2014-11-15T22:06:47Z

THRIFT-2829 Support haxelib installation via github
Client: Haxe
Patch: Jens Geyer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2828 slightly wrong help screen indent...

[Jens-G]

GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/269

THRIFT-2828 slightly wrong help screen indent



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift thrift-2828

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/269.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #269


commit b2138d28741c8921392d65f907ec1d3f6973d286
Author: Jens Geyer 
Date:   2014-10-17T23:40:20Z

multiple library fixes/improvements:
- TSocket ignores timeout on read()
- TFramedTransport throws Eof after first receive cycle
- TFramedTransport .flush() did not invoke the read callback
- incorrect declaration of logDelegate member variable
- added FlashDevelop project files
- added Haxe files to EXTRA_DIST etc.
- added haxelib.json control file for haxelib.org

commit 6bfefaec6834e134c338a20aeb1ac55ce8305873
Author: Jens Geyer 
Date:   2014-11-09T22:05:37Z

args/results class not found without namespaces
- one source file per Haxe class
- ensure correctly capitalized names

commit 3f6984db86aabb25408ae5a6e64a7a3d9c960a70
Author: Jens Geyer 
Date:   2014-11-09T17:52:48Z

Multiplex protocol on any language

commit 26f5fdc3724873adf9f728b6f3818a1edd52e775
Author: Jens Geyer 
Date:   2014-10-17T23:40:20Z

multiple library fixes/improvements:
- TSocket ignores timeout on read()
- TFramedTransport throws Eof after first receive cycle
- TFramedTransport .flush() did not invoke the read callback
- incorrect declaration of logDelegate member variable
- added FlashDevelop project files
- added Haxe files to EXTRA_DIST etc.
- added haxelib.json control file for haxelib.org

commit cc3e11d8a3040541662980d3ac2cd69ec4fa6bb2
Author: Jens Geyer 
Date:   2014-11-09T22:05:37Z

args/results class not found without namespaces
- one source file per Haxe class
- ensure correctly capitalized names

commit 6aa05f31ae8cc5ea6b4a6220359626c64d20adea
Author: Jens Geyer 
Date:   2014-11-09T17:52:48Z

Multiplex protocol on any language

commit a248817f122541023a9f541607923a2ed86c3c23
Author: Jens Geyer 
Date:   2014-11-10T23:54:05Z

Merge branch 'master' of https://github.com/Jens-G/thrift

commit 087596dcc1e40315c46ff6c77a1651785320152e
Author: Jens Geyer 
Date:   2014-11-11T01:08:45Z

Merge branch 'master' of https://github.com/apache/thrift

commit 2d318f7b95351daefd09d6b22fd9b7e0fe238980
Author: Jens Geyer 
Date:   2014-11-14T21:03:39Z

THRIFT-2828 slightly wrong help screen indent
Client: Compiler (general)
Patch: Jens Geyer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2814 args/result classes not found whe...

[Jens-G]

GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/274

THRIFT-2814 args/result classes not found when no namespace is set

Client: Haxe
Patch: Jens Geyer

Fixes all remaining issues regarding proper Haxe class and package names 
capitalization

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift thrift-2814

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/274.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #274


commit d063a3e028d6f7c0ff313008d67f7b7c91469cdf
Author: Jens Geyer 
Date:   2014-11-18T00:48:34Z

THRIFT-2814 args/result classes not found when no namespace is set
Client: Haxe
Patch: Jens Geyer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2814 args/result classes not found whe...

[Jens-G]

Github user Jens-G closed the pull request at:

https://github.com/apache/thrift/pull/274


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2814 args/result classes not found whe...

[Jens-G]

GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/275

THRIFT-2814 args/result classes not found when no namespace is set

Client: Haxe
Patch: Jens Geyer

Fixes remaining issues regarding proper Haxe class and package names 
capitalization.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift thrift-2814

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/275.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #275


commit abdb8b5488caff68375c99bda5d723ce864d3718
Author: Jens Geyer 
Date:   2014-11-18T00:48:34Z

THRIFT-2814 args/result classes not found when no namespace is set
Client: Haxe
Patch: Jens Geyer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Removed unnecessary helper function

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/280#issuecomment-64095161
  
Tracked in THRIFT-2847 
Please have a look at http://thrift.apache.org/docs/HowToContribute


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Removed unnecessary helper function

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/280#issuecomment-64129335
  
You can close it, it has been merged. 
At least theoretically the ASF bot should have auto-closed it anyway.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2861 add buffered transport to Haxe li...

[Jens-G]

GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/292

THRIFT-2861 add buffered transport to Haxe library

Client: Haxe
Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift haxe

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/292.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #292


commit 20360d7654a8bb015038fa0b91af705253b63a99
Author: Jens Geyer 
Date:   2014-11-29T12:28:44Z

THRIFT-2861 add buffered transport
Client: Haxe
Patch: Jens Geyer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2862 Enable RTTI and/or build macros f...

[Jens-G]

GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/293

THRIFT-2862 Enable RTTI and/or build macros for generated code

- adds options to enable RTTI and build macros for generated code
- plus enables buffered transport in the Tutorial code


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift thrift-2862

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/293.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #293


commit 1b72be7e45e0dd455f5a780e1f0d15b4ae1a8c7a
Author: Jens Geyer 
Date:   2014-11-29T18:29:58Z

enabled buffered transport in tutorial code

commit 77bfa7d5c5c76dd752ee5a483225b1e65785ca7b
Author: Jens Geyer 
Date:   2014-11-29T22:13:40Z

THRIFT-2862 Enable RTTI and/or build macros for generated code
Client: Haxe
Patch: Jens Geyer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: fix c++ version zeromq transport, the old ver...

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/315#issuecomment-66708667
  
Hi, 

Firstly, thanks for the patch. 

Could you please ...
 -  [File a JIRA ticket for 
it](http://thrift.apache.org/docs/HowToContribute)
 - Explain the problem in more detail? Especially, why could it not work? 
I'm quite sure the code has been tested before it was committed ... [see here 
for details](https://issues.apache.org/jira/browse/THRIFT-812)

Have fun,
JensG


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2890 binary data may lose bytes with J...

[Jens-G]

GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/319

THRIFT-2890 binary data may lose bytes with JSON transport under specifi...

...c circumstances

Client: Delphi
Patch: Jens Geyer

This patch consists of a ported version of the base64 encoding/decoding 
used in C#. It handles the above case correctly, decodes data more efficiently 
in-place, and removes the dependency to Indy (IdCoderMIME).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift thrift-2890

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/319.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #319


commit fc8c93b16c8c936069685f908dcd54c30bd479cc
Author: Jens Geyer 
Date:   2014-12-13T22:44:23Z

THRIFT-2890 binary data may lose bytes with JSON transport under specific 
circumstances
Client: Delphi
Patch: Jens Geyer

This patch consists of a ported version of the base64 encoding/decoding 
used in C#. It handles the above case correctly, decodes data more efficiently 
in-place, and removes the dependency to Indy (IdCoderMIME).




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2880 Read the network address from the...

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/310#issuecomment-67556936
  
> we can eliminate the need for a separate fork.

I'm not sure how I should read this. Assuming this was just intended as a 
friendly remainder I'll take a look at the patch. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2880 Read the network address from the...

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/310#issuecomment-67557483
  
Isn't that a bit inconsistent to return either one address or the other? 
Why do we have to squash all into one function?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2880 Read the network address from the...

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/310#issuecomment-67561439
  
Ok, just committed this. Could you please close the PR manually? Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: fix c++ version zeromq transport, the old ver...

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/315#issuecomment-67892304
  
Thanks for catching this. 

PS: I created THRIFT-2911 for you. Please try to follow [our few 
guidelines](http://thrift.apache.org/docs/HowToContribute) when submitting the 
next PR. Thank you


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2911 fix c++ version zeromq transport,...

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/339#issuecomment-68178391
  
This is exactly the same patch as in PR #315 which has been [already 
commited to 
trunk](https://github.com/apache/thrift/commit/3e9c3a2af34fb8d2f37880e245e37e19dfb6edfa).
 There is no point in reviewing and committing it again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: 0.6.x

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/338#issuecomment-68206154
  
Hi,

it is not only the merge conflicts, in general I have serious doubts. From 
my knowledge there are no plans to maintain such an old branch any further. You 
are welcome to explain your reasons for this PR on the [dev mailing 
list](https://thrift.apache.org/mailing), but - unless you come up with some 
very convincing reasons - this PR is very unlikely to be accepted. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: 0.6.x

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/338#issuecomment-68206210
  
After looking at your other PRs it becomes even more unlikely. Please close 
this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2878 - Go validation support of requir...

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/304#issuecomment-68257838
  
Hi @cvlchinet, 

good work! Just one thing: What about changing the test case to use the 
existing OptionalRequiredTest.thrift IDL instead of adding a new IDL file? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2919 Haxe test server timeout too larg...

[Jens-G]

GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/340

THRIFT-2919 Haxe test server timeout too large

Client: Haxe
Patch: Jens Geyer

- reduced timeout and made sure the test script waits appropriately
- added test to make sure Haxe >= 3.1.3 is used

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift thrift-2919

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/340.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #340


commit 0bede2fc1266482506c6bd5e75315a06f36ffc56
Author: Jens Geyer 
Date:   2014-12-29T18:46:44Z

THRIFT-2919 Haxe test server timeout too large
Client: Haxe
Patch: Jens Geyer

- reduced timeout and made sure the test script waits appropriately
- added test to make sure Haxe >= 3.1.3 is used




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2886 Integrate binary type in standard...

[Jens-G]

GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/341

THRIFT-2886 Integrate binary type in standard Thrift cross test

For reasons of better maintainability, this PR consists of 5 commits:
- adding testBinary to the ThriftTest.thrift IDL file
- adding full testBinary() support to Delphi
- adding full testBinary() support to C#
- adding full testBinary() support to Haxe
- adding **partial** testBinary() support to: 
  - C_glib
  - C++
  - D
  - Erlang
  - Go
  - Haskell
  - Lua
  - Java/Me
  - JavaScript
  - Node
  - Ocaml
  - Perl
  - PHP
  - Python
  - Ruby

The latter are minimal, server-side implementations only to just satisfy 
`make check`. There have been a number of TODOs added to the sources, these 
should be solved by subsequent tickets.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift thrift-2886-testBinary

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/341.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #341


commit 0d1adeca528f3644162ad56451db8f0873f09641
Author: Jens Geyer 
Date:   2014-12-13T22:39:45Z

THRIFT-2886 Integrate binary type in standard Thrift cross test
Client: Tests
Patch: Jens Geyer

commit da1d3461f2124031f638d1848f0a536f8cc4a585
Author: Jens Geyer 
Date:   2014-12-13T22:40:35Z

THRIFT-2886 Integrate binary type in standard Thrift cross test
Client: C#
Patch: Jens Geyer

commit 2c7e4f423f39f11a46a572dd70082992f8a30030
Author: Jens Geyer 
Date:   2014-12-13T22:42:58Z

THRIFT-2886 Integrate binary type in standard Thrift cross test
Client: Delphi
Patch: Jens Geyer

commit e2142a4cb867fb5ef8db4f90ed9f129707fa9bd7
Author: Jens Geyer 
Date:   2014-12-13T23:29:17Z

THRIFT-2886 Integrate binary type in standard Thrift cross test
Client: Haxe
Patch: Jens Geyer

commit 1886873e376b2dcd8b1c24fb3fd0eb2dc47f0c69
Author: Jens Geyer 
Date:   2014-12-14T02:14:26Z

THRIFT-2886 Integrate binary type in standard Thrift cross test
Client: C_glib, C++, D, Erlang, Go, Haskell, Lua, Java/Me, JavaScript, 
Node, Ocaml, Perl, PHP, Python, Ruby
Patch: Jens Geyer

Minimal server-side implementations and TODO stubs for various languages to 
let "make check" succeeed.
Not contained in this patch and still TODO:
- client side implementations, i.e. calls to testBinary() and appropriate 
tests
- server side hex printout missing for some languages




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Facebook's THeader protocol and transport for...

[Jens-G]

Github user Jens-G commented on a diff in the pull request:

https://github.com/apache/thrift/pull/357#discussion_r2773
  
--- Diff: lib/cpp/src/thrift/protocol/TProtocolTypes.h ---
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#ifndef THRIFT_PROTOCOL_TPROTOCOLTYPES_H_
+#define THRIFT_PROTOCOL_TPROTOCOLTYPES_H_ 1
+
+namespace apache { namespace thrift { namespace protocol {
+
+enum PROTOCOL_TYPES {
+  T_BINARY_PROTOCOL = 0,
+  T_JSON_PROTOCOL = 1,
+  T_COMPACT_PROTOCOL = 2,
+};
--- End diff --

True words. There are a bunch of candidates.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2952 Improve handling of Server.Stop()

[Jens-G]

GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/361

THRIFT-2952 Improve handling of Server.Stop()

Client: C#
Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-2952

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/361.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #361


commit e9a83d68fbca32e3ee4e2fdc19d4189466584514
Author: Jens Geyer 
Date:   2015-01-27T21:08:44Z

THRIFT-2952 Improve handling of Server.Stop()
Client: C#
Patch: Jens Geyer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2953 TNamedPipeServerTransport is not ...

[Jens-G]

GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/362

THRIFT-2953 TNamedPipeServerTransport is not Stop()able

Client: C#
Patch: Jens Geyer


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-2953

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/362.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #362


commit e9a83d68fbca32e3ee4e2fdc19d4189466584514
Author: Jens Geyer 
Date:   2015-01-27T21:08:44Z

THRIFT-2952 Improve handling of Server.Stop()
Client: C#
Patch: Jens Geyer

commit 4b15dacd3ee94a0a7269a6aa820523ba36721bc6
Author: Jens Geyer 
Date:   2015-01-27T23:05:02Z

THRIFT-2953 TNamedPipeServerTransport is not Stop()able
Client: C#
Patch: Jens Geyer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2996 Test for Haxe 3.1.3 or better

[Jens-G]

GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/374

THRIFT-2996 Test for Haxe 3.1.3 or better

Client: Haxe
Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-2996

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/374.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #374


commit ce2a46a631940adafca69fefd3dacbd386c2f3ee
Author: Jens Geyer 
Date:   2015-02-11T01:14:14Z

THRIFT-2996 Test for Haxe 3.1.3 or better
Client: Haxe
Patch: Jens Geyer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Issue with IPv6 an IPv4 on windows machines

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/377#issuecomment-74369726
  
May I ask you to [create a JIRA ticket for 
that](thrift.apache.org/docs/HowToContribute)? 

Thanks,
JensG


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: fix bug for: BadYieldError: yielded unknown o...

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/375#issuecomment-74372045
  
Many thanks for catching this. 
Could you please also provide a test case and [file a JIRA 
ticket](http://thrift.apache.org/docs/HowToContribute)?





---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Issue with IPv6 an IPv4 on windows machines

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/377#issuecomment-74573196
  
Can we do something with #ifdefs to protect against when it is not 
available?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Issue with IPv6 an IPv4 on windows machines

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/377#issuecomment-74975485
  
I just gave it a shot and it doesn't compile. That's more or less what I 
expected, because the compiler still wants to resolve the symbol:

  src/Transport/TSocket.cs(64,18): error CS1061: Type 
`System.Net.Sockets.Socket' does
  not contain a definition for `DualMode' and no extension method 
`DualMode' of type 
  `System.Net.Sockets.Socket' could be found. Are you missing an 
assembly reference?
  



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Issue with IPv6 an IPv4 on windows machines

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/377#issuecomment-75319740
  
I don't have a better idea, so yes. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: add go json annotation 'omitempty' on optiona...

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/380#issuecomment-76064297
  
@all: We have [a nice document over 
here](http://thrift.apache.org/docs/HowToContribute). 
Re this PR: I'm going to review this stuff soon, it's simply a matter of 
time. => Stay tuned :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3022 Compact protocol for Haxe

[Jens-G]

GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/388

THRIFT-3022 Compact protocol for Haxe

Client: Haxe
Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-3022-Compact-Haxe

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/388.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #388


commit c96e2a3b21450271bae185bcc167427704cfcb3c
Author: Jens Geyer 
Date:   2015-03-02T22:37:15Z

THRIFT-3022 Compact protocol for Haxe
Client: Haxe
Patch: Jens Geyer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3025 Change pure Ints into @enums

[Jens-G]

GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/391

THRIFT-3025 Change pure Ints into @enums

Client: Haxe
Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-3025-haxe-enums

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/391.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #391


commit 1a5fe7f73501280568da18ed265d4ec361966b94
Author: Jens Geyer 
Date:   2015-03-05T22:11:45Z

THRIFT-3025 Change pure Ints into @enums
Client: Haxe
Patch: Jens Geyer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3024 User-Agent "BattleNet" used in so...

[Jens-G]

GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/390

THRIFT-3024 User-Agent "BattleNet" used in some Thrift library files

Client: AS3, Haxe
Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-3024-useragent

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/390.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #390


commit d5de49ec3b4aefc3aef5a1044b85bfe78a08b21d
Author: Jens Geyer 
Date:   2015-03-05T22:59:05Z

THRIFT-3024 User-Agent "BattleNet" used in some Thrift library files
Client: AS3, Haxe
Patch: Jens Geyer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3026 TMultiplexedProcessor does not ha...

[Jens-G]

GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/392

THRIFT-3026 TMultiplexedProcessor does not have a constructor

Client: Haxe
Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-3026-multiplex-ctor

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/392.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #392


commit 2be6e1df2184bfd77047641fb4f597d306236aaf
Author: Jens Geyer 
Date:   2015-03-06T01:00:48Z

THRIFT-3026 TMultiplexedProcessor does not have a constructor
Client: Haxe
Patch: Jens Geyer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Multiplexer in Ruby

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/406#issuecomment-84608877
  
Tracked in THRIFT-1125


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3064 added default handler for undecla...

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/414#issuecomment-88221996
  
What was that?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Add compiler/cpp/lex.yythriftl.cc to gitignor...

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/412#issuecomment-89036093
  
Tracked in THRIFT-3074
Please have a look at our [contribution 
guide](http://thrift.apache.org/docs/HowToContribute)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3033 Perl: Support for Multiplexing Se...

[Jens-G]

GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/418

THRIFT-3033 Perl: Support for Multiplexing Services on any Transport, Pr...

...otocol and Server

Client: Perl
Patch: Harry S.  & Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-3033-perl-multiplex

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/418.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #418


commit 375307b362702ec0efde079c69fdbc7b2720094b
Author: Jens Geyer 
Date:   2015-03-30T20:40:44Z

THRIFT-3033 Perl: Support for Multiplexing Services on any Transport, 
Protocol and Server
Client: Perl
Patch: Harry S.  & Jens Geyer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: [THRIFT-3066] fix assert that was assigning

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/420#issuecomment-89252483
  
I forgot to mention the PR in the commit message, please close it manually.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3076 Compatibility with Haxe 3.2.0

[Jens-G]

GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/435

THRIFT-3076 Compatibility with Haxe 3.2.0

Client: Haxe
Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-3076-Haxe320

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/435.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #435


commit fe43fcc3329e300fe7e5efcdbdbf55fa2105c940
Author: Jens Geyer 
Date:   2015-04-02T22:44:27Z

THRIFT-3076 Compatibility with Haxe 3.2.0
Client: Haxe
Patch: Jens Geyer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3650 union (and optionals) serializati...

[Jens-G]

GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/881

THRIFT-3650 union (and optionals) serialization

Contains all fixes for THRIFT-3650, 3652, 3654 and 3656 (4 patches) 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-3650

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/881.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #881


commit 460678316420ae9171ea998cf5c5f9ce9475
Author: Jens Geyer 
Date:   2016-02-21T14:07:51Z

THRIFT-3650 incorrect union serialization Client: Compiler (general) Patch: 
Jens Geyer

commit beab25cb84ae77692417345dbddadfa65cfca385
Author: Jens Geyer 
Date:   2016-02-21T14:14:41Z

THRIFT-3654 incorrect serialization of optionals Client: Haxe Patch: Jens 
Geyer

commit 6a1fb354f24e1e48b4767ec8d54bb66ed984555a
Author: Jens Geyer 
Date:   2016-02-21T14:19:45Z

THRIFT-3652 incorrect serialization of optionals Client: AS3 Patch: Jens 
Geyer

commit 695d5cb7a75f9e2d3625e7c342d6ef5101f5f774
Author: Jens Geyer 
Date:   2016-02-21T14:23:37Z

THRIFT-3656 incorrect serialization of optionals Client: Dart Patch: Jens 
Geyer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: (CSharp) Adding lifecycle management for serv...

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/555#issuecomment-188943128
  
Hi @diogojc, any news here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3709 Comment syntax can produce broken...

[Jens-G]

GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/928

THRIFT-3709 Comment syntax can produce broken code

Client: Compiler(general)
Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-3709

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/928.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #928


commit c33d8ced73c65975706321eb3391cadbb9542532
Author: Jens Geyer 
Date:   2016-03-06T18:14:41Z

THRIFT-3709 Comment syntax can produce broken code
Client: Compiler(general)
Patch: Jens Geyer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3709 Comment syntax can produce broken...

[Jens-G]

Github user Jens-G closed the pull request at:

https://github.com/apache/thrift/pull/928


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3742 haxe php cli support

[Jens-G]

GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/950

THRIFT-3742 haxe php cli support

Client: Haxe
Patch: Oleksii Prudkyi + minor changes from Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-3742

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/950.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #950


commit 3794907ca14bfd13fb9539dda067f3e0c79a6f4b
Author: Jens Geyer 
Date:   2016-03-15T21:04:27Z

THRIFT-3742 haxe php cli support
Client: Haxe
Patch: Oleksii Prudkyi + minor changes from Jens Geyer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3705 Go map has incorrect types when u...

[Jens-G]

GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/951

THRIFT-3705 Go map has incorrect types when used with forward-defined…

… types

Client: Go
Patch: Jens Geyer

Essentially, this is the same patch as Tyler already proposed with his PR. 
I ended up with more or less the same conclusion code-wise, and so I'd like to 
give it another try.

@markerickson-wf 


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-3705

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/951.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #951


commit c17eefaf80254b0251aa6e97c0ac9290de7198d4
Author: Jens Geyer 
Date:   2016-03-15T22:41:59Z

THRIFT-3705 Go map has incorrect types when used with forward-defined types
Client: Go
Patch: Jens Geyer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Sargis/rdr 812/t socket patch

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/956#issuecomment-198588926
  
Please rebase against current master. That PR will never get accepted, as 
it is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3756 Improve requiredness documentatio...

[Jens-G]

GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/961

THRIFT-3756 Improve requiredness documentation

Client: Website
Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-3756

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/961.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #961


commit 472c0cddaad987e030c99ce5fe1ff9d1a92cd5e7
Author: Jens Geyer 
Date:   2016-03-23T22:33:06Z

THRIFT-3756 Improve requiredness documentation
Client: Website
Patch: Jens Geyer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3751 Compiler allows field ids that ar...

[Jens-G]

GitHub user Jens-G opened a pull request:

https://github.com/apache/thrift/pull/964

THRIFT-3751 Compiler allows field ids that are too large for generate…

…d code

Client: Compiler (General)
Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Jens-G/thrift THRIFT-3751

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/964.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #964


commit 157017c352ff713c866778b254df6c6aa00f282f
Author: Jens Geyer 
Date:   2016-03-24T23:34:03Z

THRIFT-3751 Compiler allows field ids that are too large for generated code
Client: Compiler (General)
Patch: Jens Geyer




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3756 Improve requiredness documentatio...

[Jens-G]

Github user Jens-G commented on a diff in the pull request:

https://github.com/apache/thrift/pull/961#discussion_r57957660
  
--- Diff: doc/specs/idl.md ---
@@ -126,8 +126,39 @@ A service provides the interface for a set of 
functionality provided by a Thrift
 
 ### Field Requiredness
 
-[18] FieldReq::=  'required' | 'optional'
+There are two explicit requiredness values, and a third one that is 
applied implicity if neither  *required* nor *optional* are given: *default* 
requiredness.
 
+[18] FieldReq::=  'required' | 'optional' 
+
+The general rules for requiredness are as follows:
+
+ required
+
+- Write: Required fields are always written and are expected to be set.
+- Read: Required fields are always read and are expected to be contained 
in the input stream.
+- Defaults values: are always written
+
+If a required field is missing during read, the expected behaviour is to 
indicate an unsuccessful read operation to the caller, e.g. by throwing an 
exception or returning an error. 
+
+Because of this behaviour, required fields drastically limit the options 
with regard to soft versioning. Because they must be present on read, the 
fields cannot be deprecated. If a required field would be removed (or changed 
to optional), the data are no longer compatible between versions.
+   
+ optional
+
+- Write: Optional fields are only written when they are set
+- Read: Optional fields may, or may not be part of the input stream. 
+- Default values: are written when the isset flag is set
+
+Most language implementations use the recommended pratice of so-called 
"isset" flags to indicate whether a particular optional field is set or not. 
Only fields with this flag set are written, and conversely the flag is only set 
when a field value has been read from the input stream. 
+   
+ default requiredness (implicit)
+
+- Write: Like required, the fields are always written.
+- Read: Like optional, the field may, or may not be part of the input 
stream. 
+- Default values: may not be written
--- End diff --

Actually it is a "may", but you hit an interesting point. There are some 
lengthy discussions in JIRA about the semantics of optional fields, so I tried 
to reflect the current status quo here. There are arguments for both, whether 
an default value should be written or not, and at the very end this depends on 
how "default value" in the Thrift context should be defined. If it means that 
the value is assigned by default, then the only difference would be how the 
field is set. But if "default" implies that any value that equals the default 
should be omitted during serialization, that's something completely different. 
From my understanding, the latter is not really implemented anywhere (think of 
a default value consisting of a struct that contains a list of structs which 
...) so for the sake of having one clear definition, I assume the former, much 
easier semantics is the one intended by the inventor. I admit that I took a bit 
of freedom here. I will add a note to at least point out th
 at this topic is still not finally settled.

More information here:
- https://issues.apache.org/jira/browse/THRIFT-2429
- https://issues.apache.org/jira/browse/THRIFT-1528
- http://lionet.info/asn1c/blog/2010/07/18/thrift-semantics/





---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3774 The generated code should have ex...

[Jens-G]

Github user Jens-G commented on the pull request:

https://github.com/apache/thrift/pull/975#issuecomment-205974086
  
> How can I restart the check process?

Modify the pull request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3467 Go Maps for Thrift Sets Should Ha...

[Jens-G]

Github user Jens-G commented on a diff in the pull request:

https://github.com/apache/thrift/pull/976#discussion_r58624160
  
--- Diff: test/go/src/bin/stress/main.go ---
@@ -201,7 +201,27 @@ func client(protocolFactory thrift.TProtocolFactory) {
atomic.AddInt64(&clicounter, 1)
}
case echoSet:
-   s := map[int8]bool{-10: true, -9: true, -8: true, -7: true, -6: 
true, -5: true, -4: true, -3: true, -2: true, -1: true, 0: true, 1: true, 2: 
true, 3: true, 4: true, 5: true, 6: true, 7: true, 8: true}
+   s := map[int8]struct{}{
+   -10: struct{}{},
+   -9: struct{}{},
+   -8: struct{}{},
+   -7: struct{}{},
+   -6: struct{}{},
+   -5: struct{}{},
+   -4: struct{}{},
+   -3: struct{}{},
+   -2: struct{}{},
+   -1: struct{}{},
+   0: struct{}{},
+   1: struct{}{},
+   2: struct{}{},
+   3: struct{}{},
+   4: struct{}{},
+   5: struct{}{},
+   6: struct{}{},
+   7: struct{}{},
+   8: struct{}{},
+   }
--- End diff --

That's my favourite part of this change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3783: python code generator dose not h...

[Jens-G]

Github user Jens-G commented on a diff in the pull request:

https://github.com/apache/thrift/pull/982#discussion_r58928719
  
--- Diff: compiler/cpp/src/generate/t_py_generator.cc ---
@@ -21,12 +21,19 @@
 #include 
 #include 
 #include 
+#include 
+#include 
 
 #include 
 #include 
 #include 
 #include 
 #include 
+#include 
+#include 
+#include 
+#include 
--- End diff --

We don't want to add boost as a dependency when building the Thrift 
compiler. Sorry.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---