[GitHub] tinkerpop issue #562: TINKERPOP-1626: choose() is buggy in OLAP

2017-02-22 Thread okram 
Github user okram commented on the issue:

https://github.com/apache/tinkerpop/pull/562
  
```
[INFO] 

[INFO] Reactor Summary:
[INFO]
[INFO] Apache TinkerPop ... SUCCESS [  
4.473 s]
[INFO] Apache TinkerPop :: Gremlin Shaded . SUCCESS [  
1.421 s]
[INFO] Apache TinkerPop :: Gremlin Core ... SUCCESS [01:02 
min]
[INFO] Apache TinkerPop :: Gremlin Test ... SUCCESS [ 
10.237 s]
[INFO] Apache TinkerPop :: Gremlin Groovy . SUCCESS [ 
55.630 s]
[INFO] Apache TinkerPop :: Gremlin Groovy Test  SUCCESS [  
4.803 s]
[INFO] Apache TinkerPop :: TinkerGraph Gremlin  SUCCESS [03:06 
min]
[INFO] Apache TinkerPop :: Gremlin Benchmark .. SUCCESS [  
2.969 s]
[INFO] Apache TinkerPop :: Gremlin Driver . SUCCESS [  
9.561 s]
[INFO] Apache TinkerPop :: Neo4j Gremlin .. SUCCESS [  
2.321 s]
[INFO] Apache TinkerPop :: Gremlin Server . SUCCESS [15:04 
min]
[INFO] Apache TinkerPop :: Gremlin Python . SUCCESS [01:53 
min]
[INFO] Apache TinkerPop :: Hadoop Gremlin . SUCCESS [04:40 
min]
[INFO] Apache TinkerPop :: Spark Gremlin .. SUCCESS [13:04 
min]
[INFO] Apache TinkerPop :: Giraph Gremlin . SUCCESS [  
02:29 h]
[INFO] Apache TinkerPop :: Gremlin Console  SUCCESS [01:20 
min]
[INFO] Apache TinkerPop :: Gremlin Archetype .. SUCCESS [  
0.069 s]
[INFO] Apache TinkerPop :: Archetype - TinkerGraph  SUCCESS [  
3.148 s]
[INFO] Apache TinkerPop :: Archetype - Server . SUCCESS [  
8.870 s]
[INFO] 

[INFO] BUILD SUCCESS
[INFO] 

[INFO] Total time: 03:11 h
[INFO] Finished at: 2017-02-22T15:54:05-07:00
[INFO] Final Memory: 143M/1705M
[INFO] 

```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1626) choose() is buggy in OLAP

2017-02-22 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879551#comment-15879551
 ] 

ASF GitHub Bot commented on TINKERPOP-1626:
---

Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/562
  
`docker/build.sh -t -i` succeeded.

VOTE: +1


> choose() is buggy in OLAP
> -
>
> Key: TINKERPOP-1626
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1626
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.3.0
>Reporter: Daniel Kuppitz
>Assignee: Marko A. Rodriguez
>
> Not yet tested in older versions.
> What follows are two queries that only differ in where 
> {{as("p2").select("p1","p2")}} is done. {{p1}} is a person and {{p2}} is 
> (supposed to be) either a person known by {{p1}} or - if {{p1}} doesn't know 
> anybody - the same as {{p1}}.
> *OLTP (all good):*
> {noformat}
> gremlin> g = TinkerFactory.createModern().traversal()
> ==>graphtraversalsource[tinkergraph[vertices:6 edges:6], standard]
> gremlin> g.V().hasLabel("person").as("p1").choose(outE("knows"), 
> out("knows"), identity()).as("p2").select("p1","p2")
> ==>[p1:v[1],p2:v[2]]
> ==>[p1:v[1],p2:v[4]]
> ==>[p1:v[2],p2:v[2]]
> ==>[p1:v[4],p2:v[4]]
> ==>[p1:v[6],p2:v[6]]
> gremlin> g.V().hasLabel("person").as("p1").choose(outE("knows"), 
> out("knows").as("p2").select("p1","p2"), __.as("p2").select("p1","p2"))
> ==>[p1:v[1],p2:v[2]]
> ==>[p1:v[1],p2:v[4]]
> ==>[p1:v[2],p2:v[2]]
> ==>[p1:v[4],p2:v[4]]
> ==>[p1:v[6],p2:v[6]]
> {noformat}
> *OLAP (only works when {{select()}} is done twice - once for each branch):*
> {noformat}
> gremlin> g = g.withComputer()
> ==>graphtraversalsource[tinkergraph[vertices:6 edges:6], graphcomputer]
> gremlin> g.V().hasLabel("person").as("p1").choose(outE("knows"), 
> out("knows"), identity()).as("p2").select("p1","p2")
> ==>[p1:v[1],p2:v[1]]
> ==>[p1:v[1],p2:v[1]]
> gremlin> g.V().hasLabel("person").as("p1").choose(outE("knows"), 
> out("knows").as("p2").select("p1","p2"), __.as("p2").select("p1","p2"))
> ==>[p1:v[2],p2:v[2]]
> ==>[p1:v[4],p2:v[4]]
> ==>[p1:v[6],p2:v[6]]
> ==>[p1:v[1],p2:v[2]]
> ==>[p1:v[1],p2:v[4]]
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] tinkerpop issue #562: TINKERPOP-1626: choose() is buggy in OLAP

2017-02-22 Thread dkuppitz 
Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/562
  
`docker/build.sh -t -i` succeeded.

VOTE: +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #558: TINKERPOP-1631 Improvements to BindingsGremlinPlugin

2017-02-22 Thread dkuppitz 
Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/558
  
VOTE: +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1631) Fix visibility issues with the BindingsGremlinPlugin

2017-02-22 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879321#comment-15879321
 ] 

ASF GitHub Bot commented on TINKERPOP-1631:
---

Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/558
  
VOTE: +1


> Fix visibility issues with the BindingsGremlinPlugin
> 
>
> Key: TINKERPOP-1631
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1631
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: plugin
>Affects Versions: 3.2.3
>Reporter: stephen mallette
>Assignee: stephen mallette
> Fix For: 3.2.5
>
>
> The whole aspect of applying bindings via plugin with the revised plugin 
> system is a little sketchy/inconsistent. 
> * Bindings should always be assigned to global scope because engine scope is 
> always overriden with local bindings.
> * Bindings assigned by {{HadoopGremlinPlugin}} don't seem to want to appear 
> in Gremlin Server.
> * There needs to be some form of mock {{GremlinScriptEngine}} that can be 
> used to test plugins without having to depend on an actual implementation 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] tinkerpop issue #534: TINKERPOP-1566 Kerberos authentication for gremlin-ser...

2017-02-22 Thread spmallette 
Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/534
  
ooo - well noted @robertdale - i'm fine with getting that added to 
`TraversalOpProcessor` at a later date, but it shouldn't be forgotten. maybe 
i'll just add that in when i go to merge this. thanks for the review. just one 
more vote needed!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1566) Kerberos authentication for gremlin-server

2017-02-22 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879319#comment-15879319
 ] 

ASF GitHub Bot commented on TINKERPOP-1566:
---

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/534
  
ooo - well noted @robertdale - i'm fine with getting that added to 
`TraversalOpProcessor` at a later date, but it shouldn't be forgotten. maybe 
i'll just add that in when i go to merge this. thanks for the review. just one 
more vote needed!


> Kerberos authentication for gremlin-server
> --
>
> Key: TINKERPOP-1566
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1566
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: server
>Reporter: Marc de Lignie
>Priority: Minor
>  Labels: security
> Fix For: 3.3.0
>
>
> Gremlin server would benefit from an explicit Kerberos authentication plugin, 
> because preparing and maintaining such a plugin is nontrivial. Also, many 
> other Apache project provide kerberized services.
> In gremlin-console the standard Krb5LoginModule can be configured. 
> Gremlin-server already includes the pluggable Sasl framework that can host 
> the proposed Kerberos authentication plugin. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TINKERPOP-1566) Kerberos authentication for gremlin-server

2017-02-22 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879309#comment-15879309
 ] 

ASF GitHub Bot commented on TINKERPOP-1566:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/534
  
 Tested -secure and non-secure configurations with http/console and server 
logs audit trail.  Note that the string-based requests are logged but bytecode 
is not.  Possibly a future enhancement.

VOTE +1



> Kerberos authentication for gremlin-server
> --
>
> Key: TINKERPOP-1566
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1566
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: server
>Reporter: Marc de Lignie
>Priority: Minor
>  Labels: security
> Fix For: 3.3.0
>
>
> Gremlin server would benefit from an explicit Kerberos authentication plugin, 
> because preparing and maintaining such a plugin is nontrivial. Also, many 
> other Apache project provide kerberized services.
> In gremlin-console the standard Krb5LoginModule can be configured. 
> Gremlin-server already includes the pluggable Sasl framework that can host 
> the proposed Kerberos authentication plugin. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

TinkerPop History on Wikipedia

2017-02-22 Thread Robert Dale 
I tried to add this 100% historically accurate timeline to wikipedia but
some guy keeps reverting my edits. Maybe someone else will have better luck.

== History ==
* 2009-11-05 That was the day Marko invented the traversal machine. He was
standing on the edge of his toilet hanging a clock, the porcelain was wet,
he slipped, hit his head on the sink, and when he came to he had a
revelation! A vision! A picture in his head! A picture of a gremlin! This
is what makes graph traversals possible.
* 2009-11-07 Future Marko visits past Marko, shows him the picture he drew,
and tells him that it works. Marko makes the first commit to TinkerPop
Gremlin.
* 2009-12-25 v0.1 is released
* 2011-05-21 v1.0 is released
* 2012-05-24 v2.0 is released
* 2015-01-16 TinkerPop becomes an Apache Incubator project
* 2015-07-09 v3.0.0-incubating is released
* 2016-05-23 Apache TinkerPop becomes a top-level project
* 2016-07-18 v3.1.3 and v3.2.1 are first Apache TinkerPop releases

I also tried updating the version but that gets reverted too.  I guess
someone is revert-happy today.

Robert Dale

[jira] [Commented] (TINKERPOP-1631) Fix visibility issues with the BindingsGremlinPlugin

2017-02-22 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879045#comment-15879045
 ] 

ASF GitHub Bot commented on TINKERPOP-1631:
---

Github user davebshow commented on the issue:

https://github.com/apache/tinkerpop/pull/558
  
`mvn clean install` passes.

VOTE +1


> Fix visibility issues with the BindingsGremlinPlugin
> 
>
> Key: TINKERPOP-1631
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1631
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: plugin
>Affects Versions: 3.2.3
>Reporter: stephen mallette
>Assignee: stephen mallette
> Fix For: 3.2.5
>
>
> The whole aspect of applying bindings via plugin with the revised plugin 
> system is a little sketchy/inconsistent. 
> * Bindings should always be assigned to global scope because engine scope is 
> always overriden with local bindings.
> * Bindings assigned by {{HadoopGremlinPlugin}} don't seem to want to appear 
> in Gremlin Server.
> * There needs to be some form of mock {{GremlinScriptEngine}} that can be 
> used to test plugins without having to depend on an actual implementation 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] tinkerpop issue #558: TINKERPOP-1631 Improvements to BindingsGremlinPlugin

2017-02-22 Thread davebshow 
Github user davebshow commented on the issue:

https://github.com/apache/tinkerpop/pull/558
  
`mvn clean install` passes.

VOTE +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1637) Expose metrics attributes in string output

2017-02-22 Thread Bob Briody (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879036#comment-15879036
 ] 

Bob Briody commented on TINKERPOP-1637:
---

[~bryncooke] is this specific to the gremlin console output? 

> Expose metrics attributes in string output
> --
>
> Key: TINKERPOP-1637
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1637
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.4
>Reporter: Bryn Cooke
>
> Currently the profile step won't expose metrics attributes in the string 
> output. This means that useful information provided by graph implementations 
> is never output.
> It would be great if the attributes could be output indented under each 
> metric.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TINKERPOP-1614) Improve documentation for Graph.V() and Graph.E() on main docs page

2017-02-22 Thread Bob Briody (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878825#comment-15878825
 ] 

Bob Briody commented on TINKERPOP-1614:
---

Yup, I saw that. I know I'm being fussy but it just seems weird to have to go 
to another page to find such core/foundational/basic info. It should jump out 
in the list of steps. You also can't ctrl+f for it easily now.

> Improve documentation for Graph.V() and Graph.E() on main docs page
> ---
>
> Key: TINKERPOP-1614
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1614
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: documentation
>Reporter: Bob Briody
>Assignee: stephen mallette
> Fix For: 3.2.5
>
>
> I was trying to help someone out on stack overflow recently: 
> http://stackoverflow.com/questions/41638792/dse-graph-get-all-edges-between-two-vertexes.
>  I was on the main TinkerPop3 Docs page looking for some introduction to 
> g.V() that would be good to copy/paste, but couldn't find anything. 
> It seems like there might be a stepping stone missing between "The Traversal" 
> and "Graph Traversal Steps" - a stepping stone about using V and E to 
> seed/start a Traversal.
> The use of IDs should also be discussed there as well.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (TINKERPOP-1637) Expose metrics attributes in string output

2017-02-22 Thread Bryn Cooke (JIRA) 
Bryn Cooke created TINKERPOP-1637:
-

 Summary: Expose metrics attributes in string output
 Key: TINKERPOP-1637
 URL: https://issues.apache.org/jira/browse/TINKERPOP-1637
 Project: TinkerPop
  Issue Type: Improvement
  Components: process
Affects Versions: 3.2.4
Reporter: Bryn Cooke


Currently the profile step won't expose metrics attributes in the string 
output. This means that useful information provided by graph implementations is 
never output.
It would be great if the attributes could be output indented under each metric.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TINKERPOP-1614) Improve documentation for Graph.V() and Graph.E() on main docs page

2017-02-22 Thread Bob Briody (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878780#comment-15878780
 ] 

Bob Briody commented on TINKERPOP-1614:
---

I still think it's kinda weird that there is no reference to 
GraphTraversalSource's V(Object... vertexIds) and E(Object... edgeIds) methods 
in the main reference. I know they are technically not steps but I think it 
would make sense to document them there anyway - and to be clear, it's the 
passing of IDs part I'm really thinking about. 

> Improve documentation for Graph.V() and Graph.E() on main docs page
> ---
>
> Key: TINKERPOP-1614
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1614
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: documentation
>Reporter: Bob Briody
>Assignee: stephen mallette
> Fix For: 3.2.5
>
>
> I was trying to help someone out on stack overflow recently: 
> http://stackoverflow.com/questions/41638792/dse-graph-get-all-edges-between-two-vertexes.
>  I was on the main TinkerPop3 Docs page looking for some introduction to 
> g.V() that would be good to copy/paste, but couldn't find anything. 
> It seems like there might be a stepping stone missing between "The Traversal" 
> and "Graph Traversal Steps" - a stepping stone about using V and E to 
> seed/start a Traversal.
> The use of IDs should also be discussed there as well.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] tinkerpop pull request #562: TINKERPOP-1626: choose() is buggy in OLAP

2017-02-22 Thread okram 
GitHub user okram opened a pull request:

https://github.com/apache/tinkerpop/pull/562

TINKERPOP-1626: choose() is buggy in OLAP

https://issues.apache.org/jira/browse/TINKERPOP-1626

`ComputerAwareStep.EndStep` was using `path.extend()` and not 
`traverser.addLabel()` to append step labels in OLAP and thus, the step label 
data wasn't being recorded because `path.extend()` is an immutable operation. 
Also, updated `PathRetractionStrategy` to look like `LazyBarrierStrategy's` 
recent tweaks to not add a barrier to the end of a traversal -- leave that up 
to `RemoteStrategy`.

VOTE +1.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1626

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/562.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #562


commit 012edf17531f5b4ce979351bdfde504a32437800
Author: Marko A. Rodriguez 
Date:   2017-02-22T16:59:09Z

fixed a bug in OLAP ComputerAwareStep.EndStep where labels were not being 
appended to the traverser correctly. Also, a small optimization tweak to 
PathRetractionStrategy to mirror the barrier-optimization retraction that was 
done earlier on tp32/ around LazyBarrierStrategy.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1635) gremlin-python: Duplicate serialization of element property in PropertySerializer

2017-02-22 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878700#comment-15878700
 ] 

ASF GitHub Bot commented on TINKERPOP-1635:
---

Github user davebshow commented on the issue:

https://github.com/apache/tinkerpop/pull/561
  
Yeah it looks fine to me. It seems that properties are serialized before 
the element dict is "cleaned up". I don't see why you would serialize it again. 
However, I haven't really familiarized myself with the new GraphSON work on 
master yet. Still, I see no reason why we can't merge this. If the code is 
refactored and it is no longer relevant, so be it.


> gremlin-python: Duplicate serialization of element property in 
> PropertySerializer
> -
>
> Key: TINKERPOP-1635
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1635
> Project: TinkerPop
>  Issue Type: Bug
>  Components: language-variant
>Affects Versions: 3.3.0
>Reporter: Florian Hockmann
>Priority: Trivial
>
> The {{PropertySerializer}} in the current master branch of gremlin-python 
> serializes the element property twice:
> {code}
> elementDict = writer.toDict(property.element)
> #...
> "element": writer.toDict(elementDict)
> {code}
> This isn't a problem when the element only contains simple types like strings 
> that aren't serialized by adding a type attribute (like in the unit test for 
> this component). However, all other types like integers for example are 
> serialized two times. So an integer will be serialized to:
> {code}
> {"@type":"g:Int32","@value":{"@type":"g:Int32","@value":1}}
> {code}
> Full example:
> {code}
> >>> p = Property("aKey","aValue", Edge(123, Vertex(1), "edgeLabel", 
> >>> Vertex(2)))
> >>> writer.writeObject(p)
> '{"@type":"g:Property","@value":{"value":"aValue","key":"aKey","element":{"@type":"g:Edge","@value":{"inV":{"@type":"g:Int32","@value":{"@type":"g:Int32","@value":2}},"id":{"@type":"g:Int32","@value":{"@type":"g:Int32","@value":123}},"outV":{"@type":"g:Int32","@value":{"@type":"g:Int32","@value":1}},"label":"edgeLabel"'
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] tinkerpop issue #561: TINKERPOP-1635 Fix duplicate serialization of element ...

2017-02-22 Thread davebshow 
Github user davebshow commented on the issue:

https://github.com/apache/tinkerpop/pull/561
  
Yeah it looks fine to me. It seems that properties are serialized before 
the element dict is "cleaned up". I don't see why you would serialize it again. 
However, I haven't really familiarized myself with the new GraphSON work on 
master yet. Still, I see no reason why we can't merge this. If the code is 
refactored and it is no longer relevant, so be it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Assigned] (TINKERPOP-1626) choose() is buggy in OLAP

2017-02-22 Thread Marko A. Rodriguez (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marko A. Rodriguez reassigned TINKERPOP-1626:
-

Assignee: Marko A. Rodriguez

> choose() is buggy in OLAP
> -
>
> Key: TINKERPOP-1626
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1626
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.3.0
>Reporter: Daniel Kuppitz
>Assignee: Marko A. Rodriguez
>
> Not yet tested in older versions.
> What follows are two queries that only differ in where 
> {{as("p2").select("p1","p2")}} is done. {{p1}} is a person and {{p2}} is 
> (supposed to be) either a person known by {{p1}} or - if {{p1}} doesn't know 
> anybody - the same as {{p1}}.
> *OLTP (all good):*
> {noformat}
> gremlin> g = TinkerFactory.createModern().traversal()
> ==>graphtraversalsource[tinkergraph[vertices:6 edges:6], standard]
> gremlin> g.V().hasLabel("person").as("p1").choose(outE("knows"), 
> out("knows"), identity()).as("p2").select("p1","p2")
> ==>[p1:v[1],p2:v[2]]
> ==>[p1:v[1],p2:v[4]]
> ==>[p1:v[2],p2:v[2]]
> ==>[p1:v[4],p2:v[4]]
> ==>[p1:v[6],p2:v[6]]
> gremlin> g.V().hasLabel("person").as("p1").choose(outE("knows"), 
> out("knows").as("p2").select("p1","p2"), __.as("p2").select("p1","p2"))
> ==>[p1:v[1],p2:v[2]]
> ==>[p1:v[1],p2:v[4]]
> ==>[p1:v[2],p2:v[2]]
> ==>[p1:v[4],p2:v[4]]
> ==>[p1:v[6],p2:v[6]]
> {noformat}
> *OLAP (only works when {{select()}} is done twice - once for each branch):*
> {noformat}
> gremlin> g = g.withComputer()
> ==>graphtraversalsource[tinkergraph[vertices:6 edges:6], graphcomputer]
> gremlin> g.V().hasLabel("person").as("p1").choose(outE("knows"), 
> out("knows"), identity()).as("p2").select("p1","p2")
> ==>[p1:v[1],p2:v[1]]
> ==>[p1:v[1],p2:v[1]]
> gremlin> g.V().hasLabel("person").as("p1").choose(outE("knows"), 
> out("knows").as("p2").select("p1","p2"), __.as("p2").select("p1","p2"))
> ==>[p1:v[2],p2:v[2]]
> ==>[p1:v[4],p2:v[4]]
> ==>[p1:v[6],p2:v[6]]
> ==>[p1:v[1],p2:v[2]]
> ==>[p1:v[1],p2:v[4]]
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TINKERPOP-1626) choose() is buggy in OLAP

2017-02-22 Thread Marko A. Rodriguez (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878538#comment-15878538
 ] 

Marko A. Rodriguez commented on TINKERPOP-1626:
---

Also, [~dkuppitz], again, in the future, when you submit a ticket, please make 
test cases in a corresponding branch.

> choose() is buggy in OLAP
> -
>
> Key: TINKERPOP-1626
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1626
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.3.0
>Reporter: Daniel Kuppitz
>
> Not yet tested in older versions.
> What follows are two queries that only differ in where 
> {{as("p2").select("p1","p2")}} is done. {{p1}} is a person and {{p2}} is 
> (supposed to be) either a person known by {{p1}} or - if {{p1}} doesn't know 
> anybody - the same as {{p1}}.
> *OLTP (all good):*
> {noformat}
> gremlin> g = TinkerFactory.createModern().traversal()
> ==>graphtraversalsource[tinkergraph[vertices:6 edges:6], standard]
> gremlin> g.V().hasLabel("person").as("p1").choose(outE("knows"), 
> out("knows"), identity()).as("p2").select("p1","p2")
> ==>[p1:v[1],p2:v[2]]
> ==>[p1:v[1],p2:v[4]]
> ==>[p1:v[2],p2:v[2]]
> ==>[p1:v[4],p2:v[4]]
> ==>[p1:v[6],p2:v[6]]
> gremlin> g.V().hasLabel("person").as("p1").choose(outE("knows"), 
> out("knows").as("p2").select("p1","p2"), __.as("p2").select("p1","p2"))
> ==>[p1:v[1],p2:v[2]]
> ==>[p1:v[1],p2:v[4]]
> ==>[p1:v[2],p2:v[2]]
> ==>[p1:v[4],p2:v[4]]
> ==>[p1:v[6],p2:v[6]]
> {noformat}
> *OLAP (only works when {{select()}} is done twice - once for each branch):*
> {noformat}
> gremlin> g = g.withComputer()
> ==>graphtraversalsource[tinkergraph[vertices:6 edges:6], graphcomputer]
> gremlin> g.V().hasLabel("person").as("p1").choose(outE("knows"), 
> out("knows"), identity()).as("p2").select("p1","p2")
> ==>[p1:v[1],p2:v[1]]
> ==>[p1:v[1],p2:v[1]]
> gremlin> g.V().hasLabel("person").as("p1").choose(outE("knows"), 
> out("knows").as("p2").select("p1","p2"), __.as("p2").select("p1","p2"))
> ==>[p1:v[2],p2:v[2]]
> ==>[p1:v[4],p2:v[4]]
> ==>[p1:v[6],p2:v[6]]
> ==>[p1:v[1],p2:v[2]]
> ==>[p1:v[1],p2:v[4]]
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TINKERPOP-1626) choose() is buggy in OLAP

2017-02-22 Thread Marko A. Rodriguez (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878532#comment-15878532
 ] 

Marko A. Rodriguez commented on TINKERPOP-1626:
---

If I separate out the {{as('p2')}} via an {{identity()}}, then the results are 
correct. I've seen this behavior before in another step that was buggy in a 
similar way. I forget the solution, but will dig deeper.

{code}
gremlin> g.withComputer().V().hasLabel("person").as("p1").choose(outE("knows"), 
out("knows")).identity().as("p2").select("p1","p2")
==>[p1:v[2],p2:v[2]]
==>[p1:v[4],p2:v[4]]
==>[p1:v[6],p2:v[6]]
==>[p1:v[1],p2:v[2]]
==>[p1:v[1],p2:v[4]]
{code} 

> choose() is buggy in OLAP
> -
>
> Key: TINKERPOP-1626
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1626
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.3.0
>Reporter: Daniel Kuppitz
>
> Not yet tested in older versions.
> What follows are two queries that only differ in where 
> {{as("p2").select("p1","p2")}} is done. {{p1}} is a person and {{p2}} is 
> (supposed to be) either a person known by {{p1}} or - if {{p1}} doesn't know 
> anybody - the same as {{p1}}.
> *OLTP (all good):*
> {noformat}
> gremlin> g = TinkerFactory.createModern().traversal()
> ==>graphtraversalsource[tinkergraph[vertices:6 edges:6], standard]
> gremlin> g.V().hasLabel("person").as("p1").choose(outE("knows"), 
> out("knows"), identity()).as("p2").select("p1","p2")
> ==>[p1:v[1],p2:v[2]]
> ==>[p1:v[1],p2:v[4]]
> ==>[p1:v[2],p2:v[2]]
> ==>[p1:v[4],p2:v[4]]
> ==>[p1:v[6],p2:v[6]]
> gremlin> g.V().hasLabel("person").as("p1").choose(outE("knows"), 
> out("knows").as("p2").select("p1","p2"), __.as("p2").select("p1","p2"))
> ==>[p1:v[1],p2:v[2]]
> ==>[p1:v[1],p2:v[4]]
> ==>[p1:v[2],p2:v[2]]
> ==>[p1:v[4],p2:v[4]]
> ==>[p1:v[6],p2:v[6]]
> {noformat}
> *OLAP (only works when {{select()}} is done twice - once for each branch):*
> {noformat}
> gremlin> g = g.withComputer()
> ==>graphtraversalsource[tinkergraph[vertices:6 edges:6], graphcomputer]
> gremlin> g.V().hasLabel("person").as("p1").choose(outE("knows"), 
> out("knows"), identity()).as("p2").select("p1","p2")
> ==>[p1:v[1],p2:v[1]]
> ==>[p1:v[1],p2:v[1]]
> gremlin> g.V().hasLabel("person").as("p1").choose(outE("knows"), 
> out("knows").as("p2").select("p1","p2"), __.as("p2").select("p1","p2"))
> ==>[p1:v[2],p2:v[2]]
> ==>[p1:v[4],p2:v[4]]
> ==>[p1:v[6],p2:v[6]]
> ==>[p1:v[1],p2:v[2]]
> ==>[p1:v[1],p2:v[4]]
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Closed] (TINKERPOP-1627) LazyBarrierStrategy should not append an end barrier.

2017-02-22 Thread Marko A. Rodriguez (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marko A. Rodriguez closed TINKERPOP-1627.
-
Resolution: Fixed

> LazyBarrierStrategy should not append an end barrier.
> -
>
> Key: TINKERPOP-1627
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1627
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Reporter: Marko A. Rodriguez
>Assignee: Marko A. Rodriguez
> Fix For: 3.2.5
>
>
> {code}
> gremlin> g.V().out().explain()
> ==>Traversal Explanation
> ==
> Original Traversal [GraphStep(vertex,[]), 
> VertexStep(OUT,vertex)]
> ConnectiveStrategy   [D]   [GraphStep(vertex,[]), 
> VertexStep(OUT,vertex)]
> RangeByIsCountStrategy   [O]   [GraphStep(vertex,[]), 
> VertexStep(OUT,vertex)]
> RepeatUnrollStrategy [O]   [GraphStep(vertex,[]), 
> VertexStep(OUT,vertex)]
> MatchPredicateStrategy   [O]   [GraphStep(vertex,[]), 
> VertexStep(OUT,vertex)]
> PathRetractionStrategy   [O]   [GraphStep(vertex,[]), 
> VertexStep(OUT,vertex)]
> IncidentToAdjacentStrategy   [O]   [GraphStep(vertex,[]), 
> VertexStep(OUT,vertex)]
> FilterRankingStrategy[O]   [GraphStep(vertex,[]), 
> VertexStep(OUT,vertex)]
> InlineFilterStrategy [O]   [GraphStep(vertex,[]), 
> VertexStep(OUT,vertex)]
> AdjacentToIncidentStrategy   [O]   [GraphStep(vertex,[]), 
> VertexStep(OUT,vertex)]
> LazyBarrierStrategy  [O]   [GraphStep(vertex,[]), 
> VertexStep(OUT,vertex), NoOpBarrierStep(2500)]
> TinkerGraphCountStrategy [P]   [GraphStep(vertex,[]), 
> VertexStep(OUT,vertex), NoOpBarrierStep(2500)]
> TinkerGraphStepStrategy  [P]   [TinkerGraphStep(vertex,[]), 
> VertexStep(OUT,vertex), NoOpBarrierStep(2500)]
> ProfileStrategy  [F]   [TinkerGraphStep(vertex,[]), 
> VertexStep(OUT,vertex), NoOpBarrierStep(2500)]
> StandardVerificationStrategy [V]   [TinkerGraphStep(vertex,[]), 
> VertexStep(OUT,vertex), NoOpBarrierStep(2500)]
> Final Traversal[TinkerGraphStep(vertex,[]), 
> VertexStep(OUT,vertex), NoOpBarrierStep(2500)]
> {code}
> The only time this is cool is for {{RemoteTraversal}} because you want to 
> barrier as much as you can to reduce over the wire costs. However, 
> {{RemoteStrategy}} should append an end-barrier. No other strategy should do 
> this --- its just wasted clock cycles.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TINKERPOP-1635) gremlin-python: Duplicate serialization of element property in PropertySerializer

2017-02-22 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878261#comment-15878261
 ] 

ASF GitHub Bot commented on TINKERPOP-1635:
---

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/561
  
I'm not sure at this point what will be changed and what won't for 3.3.0 so 
I think it makes sense to fix stuff that isn't right even if it might change 
later. @davebshow does this change look ok to you?


> gremlin-python: Duplicate serialization of element property in 
> PropertySerializer
> -
>
> Key: TINKERPOP-1635
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1635
> Project: TinkerPop
>  Issue Type: Bug
>  Components: language-variant
>Affects Versions: 3.3.0
>Reporter: Florian Hockmann
>Priority: Trivial
>
> The {{PropertySerializer}} in the current master branch of gremlin-python 
> serializes the element property twice:
> {code}
> elementDict = writer.toDict(property.element)
> #...
> "element": writer.toDict(elementDict)
> {code}
> This isn't a problem when the element only contains simple types like strings 
> that aren't serialized by adding a type attribute (like in the unit test for 
> this component). However, all other types like integers for example are 
> serialized two times. So an integer will be serialized to:
> {code}
> {"@type":"g:Int32","@value":{"@type":"g:Int32","@value":1}}
> {code}
> Full example:
> {code}
> >>> p = Property("aKey","aValue", Edge(123, Vertex(1), "edgeLabel", 
> >>> Vertex(2)))
> >>> writer.writeObject(p)
> '{"@type":"g:Property","@value":{"value":"aValue","key":"aKey","element":{"@type":"g:Edge","@value":{"inV":{"@type":"g:Int32","@value":{"@type":"g:Int32","@value":2}},"id":{"@type":"g:Int32","@value":{"@type":"g:Int32","@value":123}},"outV":{"@type":"g:Int32","@value":{"@type":"g:Int32","@value":1}},"label":"edgeLabel"'
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] tinkerpop issue #561: TINKERPOP-1635 Fix duplicate serialization of element ...

2017-02-22 Thread spmallette 
Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/561
  
I'm not sure at this point what will be changed and what won't for 3.3.0 so 
I think it makes sense to fix stuff that isn't right even if it might change 
later. @davebshow does this change look ok to you?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Closed] (TINKERPOP-1614) Improve documentation for Graph.V() and Graph.E() on main docs page

2017-02-22 Thread stephen mallette (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette closed TINKERPOP-1614.
---
   Resolution: Done
Fix Version/s: 3.2.5

There were already docs on "starting a traversal" so I didn't write new ones. I 
added links in "The Traversal" section to the two places where you could get 
more information on those things. I think that by the time you get to "The 
Traversal" (which is primarily a reference section) you should know how to get 
a traversal started, so adding more details there on top of what we already had 
didn't seem necessary.

https://github.com/apache/tinkerpop/commit/e403f633251a95f74415d5888b6b562922dacc29

> Improve documentation for Graph.V() and Graph.E() on main docs page
> ---
>
> Key: TINKERPOP-1614
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1614
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: documentation
>Reporter: Bob Briody
>Assignee: stephen mallette
> Fix For: 3.2.5
>
>
> I was trying to help someone out on stack overflow recently: 
> http://stackoverflow.com/questions/41638792/dse-graph-get-all-edges-between-two-vertexes.
>  I was on the main TinkerPop3 Docs page looking for some introduction to 
> g.V() that would be good to copy/paste, but couldn't find anything. 
> It seems like there might be a stepping stone missing between "The Traversal" 
> and "Graph Traversal Steps" - a stepping stone about using V and E to 
> seed/start a Traversal.
> The use of IDs should also be discussed there as well.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)