[jira] [Comment Edited] (TINKERPOP-1695) Session close over websocket does not reply with confirmation

2017-06-21 Thread Charlie (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16058406#comment-16058406
 ] 

Charlie edited comment on TINKERPOP-1695 at 6/21/17 11:15 PM:
--

Okay. So this doesn't seem to be a Tinkerpop issue. Seems to be an issue with 
the version packaged with JanusGraph. I just tested the script again with a 
clean download of Tinkerpop 3.2.4. 

I guess it turns out I was mistaken that Janus v0.1.1 is on 3.2.4, it's 
actually on 3.2.3. 


was (Author: muskard):
Okay. So this doesn't seem to be a Tinkerpop issue. Seems to be an issue with 
the version packaged with JanusGraph. I just tested the script again with a 
clean download of Tinkerpop 3.2.4. 

> Session close over websocket does not reply with confirmation
> -
>
> Key: TINKERPOP-1695
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1695
> Project: TinkerPop
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.2.3, 3.2.4
> Environment: Ubuntu 14.04
>Reporter: Charlie
>Priority: Minor
> Attachments: pcap_ws.png, screenshot-1.png
>
>
> If you were to open up wireshark and monitor the websocket traffic and run 
> the following in the gremlin console, you will see that a close message will 
> get sent, but no confirmation back that the session actually closed. 
> {code:java}
> gremlin> :remote console tinkerpop.server conf/remote.yaml session
> gremlin> :> g.V().count()
> gremlin> :remote close
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1695) Session close over websocket does not reply with confirmation

2017-06-21 Thread Charlie (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16058406#comment-16058406
 ] 

Charlie commented on TINKERPOP-1695:


Okay. So this doesn't seem to be a Tinkerpop issue. Seems to be an issue with 
the version packaged with JanusGraph. I just tested the script again with a 
clean download of Tinkerpop 3.2.4. 

> Session close over websocket does not reply with confirmation
> -
>
> Key: TINKERPOP-1695
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1695
> Project: TinkerPop
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.2.3, 3.2.4
> Environment: Ubuntu 14.04
>Reporter: Charlie
>Priority: Minor
> Attachments: pcap_ws.png, screenshot-1.png
>
>
> If you were to open up wireshark and monitor the websocket traffic and run 
> the following in the gremlin console, you will see that a close message will 
> get sent, but no confirmation back that the session actually closed. 
> {code:java}
> gremlin> :remote console tinkerpop.server conf/remote.yaml session
> gremlin> :> g.V().count()
> gremlin> :remote close
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (TINKERPOP-1695) Session close over websocket does not reply with confirmation

2017-06-21 Thread Robert Dale (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16058348#comment-16058348
 ] 

Robert Dale edited comment on TINKERPOP-1695 at 6/21/17 10:18 PM:
--

I don't seem to be able to reproduce the issue here.

command-line:
{noformat}
[rdale@mocl99mqm12 apache-tinkerpop-gremlin-console-3.2.4]$ python websocket.py 
First message sent.
Message response: 
{"requestId":"d52ba43b-1c82-4965-abef-918e6bef420a","status":{"message":"","code":200,"attributes":{}},"result":{"data":[0],"meta":{}}}
Close message sent.
Close response: 
{"requestId":"e9a7602a-b7f9-4983-8175-238e1f307776","status":{"message":"","code":204,"attributes":{}},"result":{"data":null,"meta":{}}}
[rdale@mocl99mqm12 apache-tinkerpop-gremlin-console-3.2.4]$ 
{noformat}

server: 

{noformat}
[INFO] Session - Session 8c13e3b8-b322-41e3-81a3-a879e12a0343 closed

{noformat}

!https://issues.apache.org/jira/secure/attachment/12873963/screenshot-1.png!


was (Author: rdale):
I don't seem to be able to reproduce the issue here.

command-line:
{noformat}
[rdale@mocl99mqm12 apache-tinkerpop-gremlin-console-3.2.4]$ python websocket.py 
First message sent.
Message response: 
{"requestId":"d52ba43b-1c82-4965-abef-918e6bef420a","status":{"message":"","code":200,"attributes":{}},"result":{"data":[0],"meta":{}}}
Close message sent.
Close response: 
{"requestId":"e9a7602a-b7f9-4983-8175-238e1f307776","status":{"message":"","code":204,"attributes":{}},"result":{"data":null,"meta":{}}}
[rdale@mocl99mqm12 apache-tinkerpop-gremlin-console-3.2.4]$ 
{noformat}

server: 

{noformat}
[INFO] Session - Session 8c13e3b8-b322-41e3-81a3-a879e12a0343 closed

{noformat}

!screenshot-1.png|thumbnail!

> Session close over websocket does not reply with confirmation
> -
>
> Key: TINKERPOP-1695
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1695
> Project: TinkerPop
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.2.3, 3.2.4
> Environment: Ubuntu 14.04
>Reporter: Charlie
>Priority: Minor
> Attachments: pcap_ws.png, screenshot-1.png
>
>
> If you were to open up wireshark and monitor the websocket traffic and run 
> the following in the gremlin console, you will see that a close message will 
> get sent, but no confirmation back that the session actually closed. 
> {code:java}
> gremlin> :remote console tinkerpop.server conf/remote.yaml session
> gremlin> :> g.V().count()
> gremlin> :remote close
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (TINKERPOP-1695) Session close over websocket does not reply with confirmation

2017-06-21 Thread Robert Dale (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16058348#comment-16058348
 ] 

Robert Dale edited comment on TINKERPOP-1695 at 6/21/17 10:18 PM:
--

I don't seem to be able to reproduce the issue here.

command-line:
{noformat}
[rdale@mocl99mqm12 apache-tinkerpop-gremlin-console-3.2.4]$ python websocket.py 
First message sent.
Message response: 
{"requestId":"d52ba43b-1c82-4965-abef-918e6bef420a","status":{"message":"","code":200,"attributes":{}},"result":{"data":[0],"meta":{}}}
Close message sent.
Close response: 
{"requestId":"e9a7602a-b7f9-4983-8175-238e1f307776","status":{"message":"","code":204,"attributes":{}},"result":{"data":null,"meta":{}}}
[rdale@mocl99mqm12 apache-tinkerpop-gremlin-console-3.2.4]$ 
{noformat}

server: 

{noformat}
[INFO] Session - Session 8c13e3b8-b322-41e3-81a3-a879e12a0343 closed

{noformat}

!screenshot-1.png|thumbnail!


was (Author: rdale):
I don't seem to be able to reproduce the issue here.

command-line:
{noformat}
[rdale@mocl99mqm12 apache-tinkerpop-gremlin-console-3.2.4]$ python websocket.py 
First message sent.
Message response: 
{"requestId":"d52ba43b-1c82-4965-abef-918e6bef420a","status":{"message":"","code":200,"attributes":{}},"result":{"data":[0],"meta":{}}}
Close message sent.
Close response: 
{"requestId":"e9a7602a-b7f9-4983-8175-238e1f307776","status":{"message":"","code":204,"attributes":{}},"result":{"data":null,"meta":{}}}
[rdale@mocl99mqm12 apache-tinkerpop-gremlin-console-3.2.4]$ 
{noformat}

server: 
[INFO] Session - Session 8c13e3b8-b322-41e3-81a3-a879e12a0343 closed



> Session close over websocket does not reply with confirmation
> -
>
> Key: TINKERPOP-1695
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1695
> Project: TinkerPop
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.2.3, 3.2.4
> Environment: Ubuntu 14.04
>Reporter: Charlie
>Priority: Minor
> Attachments: pcap_ws.png, screenshot-1.png
>
>
> If you were to open up wireshark and monitor the websocket traffic and run 
> the following in the gremlin console, you will see that a close message will 
> get sent, but no confirmation back that the session actually closed. 
> {code:java}
> gremlin> :remote console tinkerpop.server conf/remote.yaml session
> gremlin> :> g.V().count()
> gremlin> :remote close
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (TINKERPOP-1695) Session close over websocket does not reply with confirmation

2017-06-21 Thread Robert Dale (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Dale updated TINKERPOP-1695:
---
Attachment: screenshot-1.png

> Session close over websocket does not reply with confirmation
> -
>
> Key: TINKERPOP-1695
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1695
> Project: TinkerPop
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.2.3, 3.2.4
> Environment: Ubuntu 14.04
>Reporter: Charlie
>Priority: Minor
> Attachments: pcap_ws.png, screenshot-1.png
>
>
> If you were to open up wireshark and monitor the websocket traffic and run 
> the following in the gremlin console, you will see that a close message will 
> get sent, but no confirmation back that the session actually closed. 
> {code:java}
> gremlin> :remote console tinkerpop.server conf/remote.yaml session
> gremlin> :> g.V().count()
> gremlin> :remote close
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1695) Session close over websocket does not reply with confirmation

2017-06-21 Thread Robert Dale (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16058348#comment-16058348
 ] 

Robert Dale commented on TINKERPOP-1695:


I don't seem to be able to reproduce the issue here.

command-line:
{noformat}
[rdale@mocl99mqm12 apache-tinkerpop-gremlin-console-3.2.4]$ python websocket.py 
First message sent.
Message response: 
{"requestId":"d52ba43b-1c82-4965-abef-918e6bef420a","status":{"message":"","code":200,"attributes":{}},"result":{"data":[0],"meta":{}}}
Close message sent.
Close response: 
{"requestId":"e9a7602a-b7f9-4983-8175-238e1f307776","status":{"message":"","code":204,"attributes":{}},"result":{"data":null,"meta":{}}}
[rdale@mocl99mqm12 apache-tinkerpop-gremlin-console-3.2.4]$ 
{noformat}

server: 
[INFO] Session - Session 8c13e3b8-b322-41e3-81a3-a879e12a0343 closed



> Session close over websocket does not reply with confirmation
> -
>
> Key: TINKERPOP-1695
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1695
> Project: TinkerPop
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.2.3, 3.2.4
> Environment: Ubuntu 14.04
>Reporter: Charlie
>Priority: Minor
> Attachments: pcap_ws.png, screenshot-1.png
>
>
> If you were to open up wireshark and monitor the websocket traffic and run 
> the following in the gremlin console, you will see that a close message will 
> get sent, but no confirmation back that the session actually closed. 
> {code:java}
> gremlin> :remote console tinkerpop.server conf/remote.yaml session
> gremlin> :> g.V().count()
> gremlin> :remote close
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1695) Session close over websocket does not reply with confirmation

2017-06-21 Thread Charlie (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16058312#comment-16058312
 ] 

Charlie commented on TINKERPOP-1695:


Here is a python example using tornado.

{code:none}
import uuid
from tornado import websocket, ioloop

loop = ioloop.IOLoop()
socket = loop.run_sync(lambda: 
websocket.websocket_connect("ws://127.0.0.1:8182/gremlin"))


first_message = b'\x10application/json{"processor": "session", "requestId": 
"d52ba43b-1c82-4965-abef-918e6bef420a", "args": {"gremlin": "g.V().count()", 
"session": "8c13e3b8-b322-41e3-81a3-a879e12a0343", "language": 
"gremlin-groovy", "bindings": {}, "scriptEvaluationTimeout": 60, "aliases": 
{}}, "op": "eval"}'
close_message = b'\x10application/json{"processor": "session", "requestId": 
"e9a7602a-b7f9-4983-8175-238e1f307776", "args": {"gremlin": null, "session": 
"8c13e3b8-b322-41e3-81a3-a879e12a0343", "language": "gremlin-groovy", 
"bindings": null, "scriptEvaluationTimeout": null, "aliases": {}}, "op": 
"close"}'

# send message so it knows about new session
loop.run_sync(lambda: socket.write_message(first_message, binary=True))

print "First message sent."

# read message, don't care
resp = loop.run_sync(lambda: socket.read_message()) 

print "Message response: %s" % resp

# send close message
loop.run_sync(lambda: socket.write_message(close_message, binary=True))

print "Close message sent."

# Hang here forever since no message is received
resp = loop.run_sync(lambda: socket.read_message()) 

print "Close response: %s" % resp

socket.close()
{code}


> Session close over websocket does not reply with confirmation
> -
>
> Key: TINKERPOP-1695
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1695
> Project: TinkerPop
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.2.3, 3.2.4
> Environment: Ubuntu 14.04
>Reporter: Charlie
>Priority: Minor
> Attachments: pcap_ws.png
>
>
> If you were to open up wireshark and monitor the websocket traffic and run 
> the following in the gremlin console, you will see that a close message will 
> get sent, but no confirmation back that the session actually closed. 
> {code:java}
> gremlin> :remote console tinkerpop.server conf/remote.yaml session
> gremlin> :> g.V().count()
> gremlin> :remote close
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1695) Session close over websocket does not reply with confirmation

2017-06-21 Thread Robert Dale (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16058192#comment-16058192
 ] 

Robert Dale commented on TINKERPOP-1695:


Can you please provide steps to reproduce?  console commands or code is fine.

> Session close over websocket does not reply with confirmation
> -
>
> Key: TINKERPOP-1695
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1695
> Project: TinkerPop
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.2.3, 3.2.4
> Environment: Ubuntu 14.04
>Reporter: Charlie
>Priority: Minor
> Attachments: pcap_ws.png
>
>
> If you were to open up wireshark and monitor the websocket traffic and run 
> the following in the gremlin console, you will see that a close message will 
> get sent, but no confirmation back that the session actually closed. 
> {code:java}
> gremlin> :remote console tinkerpop.server conf/remote.yaml session
> gremlin> :> g.V().count()
> gremlin> :remote close
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (TINKERPOP-1695) Session close over websocket does not reply with confirmation

2017-06-21 Thread Charlie (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16058159#comment-16058159
 ] 

Charlie edited comment on TINKERPOP-1695 at 6/21/17 8:39 PM:
-

Sorry, I wasn't exactly being clear. From what I understand, there's two things 
at play: 1) the websocket connection and 2) the "sessionOpProcessor" session.  
I was attempting to re-use the websocket connection after a close session call 
(op='close' processr='session'), which works. Also, I might have run into 
another bug where closing doesn't actually work, so I'd like to see 
confirmation that my close worked.   What I'd like to see (and almost see, 
except one part):

{code}
client  --> server: socket open
client <--> server: commands (with session set)
client  --> server: op='close' processor='session'
client <--   server: **Confirmation of successful close**
client <--> server: commands (with other session set)
...
client --> server: socket close
client <-- server: socket close
{code}
The "Confirmation of successful close" part is what I'm not seeing.  Even with 
no "other session" commands sent, and waiting a while before websocket close, I 
don't see any confirmation of the close. 

Attached to this report is a screen shot of Wireshark showing what's happening. 
The second to last packet shown is the close message sent from the client. The 
following message is a TCP ack that isn't a websocket frame or with any 
payload. Is this the 'NO CONTENT' message? If so, this won't work with any 
websocket library that expects a response. 

[^pcap_ws.png]


was (Author: muskard):
Sorry, I wasn't exactly being clear. From what I understand, there's two things 
at play: 1) the websocket connection and 2) the "sessionOpProcessor" session.  
I was attempting to re-use the websocket connection after a close session call 
(op='close' processr='session'), which works. Also, I might have run into 
another bug where closing doesn't actually work, so I'd like to see 
confirmation that my close worked.   What I'd like to see (and almost see, 
except one part):

{code}
client  --> server: socket open
client <--> server: commands (with session set)
client  --> server: op='close' processor='session'
client <--   server: **Confirmation of successful close**
client <--> server: commands (with other session set)
...
client --> server: socket close
client <-- server: socket close
{code}
The "Confirmation of successful close" part is what I'm not seeing.  Even with 
no "other session" commands sent, and waiting a while before websocket close, I 
don't see any confirmation of the close. 

Attached to this report is a screen shot of Wireshark showing what's happening. 
The second to last packet shown is the close message sent from the client. The 
following message is a TCP ack that isn't a websocket frame or with any 
payload. Is this the 'NO CONTENT' message? If so, this won't work with any 
websocket library that expects a response. 

!pcap_ws.png|thumbnail!

> Session close over websocket does not reply with confirmation
> -
>
> Key: TINKERPOP-1695
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1695
> Project: TinkerPop
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.2.3, 3.2.4
> Environment: Ubuntu 14.04
>Reporter: Charlie
>Priority: Minor
> Attachments: pcap_ws.png
>
>
> If you were to open up wireshark and monitor the websocket traffic and run 
> the following in the gremlin console, you will see that a close message will 
> get sent, but no confirmation back that the session actually closed. 
> {code:java}
> gremlin> :remote console tinkerpop.server conf/remote.yaml session
> gremlin> :> g.V().count()
> gremlin> :remote close
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1695) Session close over websocket does not reply with confirmation

2017-06-21 Thread Charlie (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16058159#comment-16058159
 ] 

Charlie commented on TINKERPOP-1695:


Sorry, I wasn't exactly being clear. From what I understand, there's two things 
at play: 1) the websocket connection and 2) the "sessionOpProcessor" session.  
I was attempting to re-use the websocket connection after a close session call 
(op='close' processr='session'), which works. Also, I might have run into 
another bug where closing doesn't actually work, so I'd like to see 
confirmation that my close worked.   What I'd like to see (and almost see, 
except one part):

{code}
client  --> server: socket open
client <--> server: commands (with session set)
client  --> server: op='close' processor='session'
client <--   server: **Confirmation of successful close**
client <--> server: commands (with other session set)
...
client --> server: socket close
client <-- server: socket close
{code}
The "Confirmation of successful close" part is what I'm not seeing.  Even with 
no "other session" commands sent, and waiting a while before websocket close, I 
don't see any confirmation of the close. 

Attached to this report is a screen shot of Wireshark showing what's happening. 
The second to last packet shown is the close message sent from the client. The 
following message is a TCP ack that isn't a websocket frame or with any 
payload. Is this the 'NO CONTENT' message? If so, this won't work with any 
websocket library that expects a response. 

!pcap_ws.png|thumbnail!

> Session close over websocket does not reply with confirmation
> -
>
> Key: TINKERPOP-1695
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1695
> Project: TinkerPop
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.2.3, 3.2.4
> Environment: Ubuntu 14.04
>Reporter: Charlie
>Priority: Minor
> Attachments: pcap_ws.png
>
>
> If you were to open up wireshark and monitor the websocket traffic and run 
> the following in the gremlin console, you will see that a close message will 
> get sent, but no confirmation back that the session actually closed. 
> {code:java}
> gremlin> :remote console tinkerpop.server conf/remote.yaml session
> gremlin> :> g.V().count()
> gremlin> :remote close
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (TINKERPOP-1695) Session close over websocket does not reply with confirmation

2017-06-21 Thread Charlie (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Charlie updated TINKERPOP-1695:
---
Attachment: pcap_ws.png

> Session close over websocket does not reply with confirmation
> -
>
> Key: TINKERPOP-1695
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1695
> Project: TinkerPop
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.2.3, 3.2.4
> Environment: Ubuntu 14.04
>Reporter: Charlie
>Priority: Minor
> Attachments: pcap_ws.png
>
>
> If you were to open up wireshark and monitor the websocket traffic and run 
> the following in the gremlin console, you will see that a close message will 
> get sent, but no confirmation back that the session actually closed. 
> {code:java}
> gremlin> :remote console tinkerpop.server conf/remote.yaml session
> gremlin> :> g.V().count()
> gremlin> :remote close
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1695) Session close over websocket does not reply with confirmation

2017-06-21 Thread Robert Dale (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16058013#comment-16058013
 ] 

Robert Dale commented on TINKERPOP-1695:


WebSocket is not HTTP so you won't get back a HTTP 204.

> Session close over websocket does not reply with confirmation
> -
>
> Key: TINKERPOP-1695
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1695
> Project: TinkerPop
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.2.3, 3.2.4
> Environment: Ubuntu 14.04
>Reporter: Charlie
>Priority: Minor
>
> If you were to open up wireshark and monitor the websocket traffic and run 
> the following in the gremlin console, you will see that a close message will 
> get sent, but no confirmation back that the session actually closed. 
> {code:java}
> gremlin> :remote console tinkerpop.server conf/remote.yaml session
> gremlin> :> g.V().count()
> gremlin> :remote close
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1695) Session close over websocket does not reply with confirmation

2017-06-21 Thread Robert Dale (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16058011#comment-16058011
 ] 

Robert Dale commented on TINKERPOP-1695:


I see it working as expected.  Client sends WebSocket Connection Close.  Server 
responds with WebSocket Connection Close.

> Session close over websocket does not reply with confirmation
> -
>
> Key: TINKERPOP-1695
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1695
> Project: TinkerPop
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.2.3, 3.2.4
> Environment: Ubuntu 14.04
>Reporter: Charlie
>Priority: Minor
>
> If you were to open up wireshark and monitor the websocket traffic and run 
> the following in the gremlin console, you will see that a close message will 
> get sent, but no confirmation back that the session actually closed. 
> {code:java}
> gremlin> :remote console tinkerpop.server conf/remote.yaml session
> gremlin> :> g.V().count()
> gremlin> :remote close
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1695) Session close over websocket does not reply with confirmation

2017-06-21 Thread Charlie (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057986#comment-16057986
 ] 

Charlie commented on TINKERPOP-1695:


Well, I'm not sure if I'm supposed to get a HTTP 204 or literally nothing (I 
only get Websocket closed messages on my pcap). It seems from the commit 
message that implemented the fix that I would get back an HTTP message. 

> Session close over websocket does not reply with confirmation
> -
>
> Key: TINKERPOP-1695
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1695
> Project: TinkerPop
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.2.3, 3.2.4
> Environment: Ubuntu 14.04
>Reporter: Charlie
>Priority: Minor
>
> If you were to open up wireshark and monitor the websocket traffic and run 
> the following in the gremlin console, you will see that a close message will 
> get sent, but no confirmation back that the session actually closed. 
> {code:java}
> gremlin> :remote console tinkerpop.server conf/remote.yaml session
> gremlin> :> g.V().count()
> gremlin> :remote close
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1695) Session close over websocket does not reply with confirmation

2017-06-21 Thread stephen mallette (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057762#comment-16057762
 ] 

stephen mallette commented on TINKERPOP-1695:
-

I believe it was and I see the code there that sends the confirmation. Not sure 
why you're not seeing that confirmation message.

> Session close over websocket does not reply with confirmation
> -
>
> Key: TINKERPOP-1695
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1695
> Project: TinkerPop
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.2.3, 3.2.4
> Environment: Ubuntu 14.04
>Reporter: Charlie
>Priority: Minor
>
> If you were to open up wireshark and monitor the websocket traffic and run 
> the following in the gremlin console, you will see that a close message will 
> get sent, but no confirmation back that the session actually closed. 
> {code:java}
> gremlin> :remote console tinkerpop.server conf/remote.yaml session
> gremlin> :> g.V().count()
> gremlin> :remote close
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1695) Session close over websocket does not reply with confirmation

2017-06-21 Thread Charlie (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057759#comment-16057759
 ] 

Charlie commented on TINKERPOP-1695:


TINKERPOP-1544 was supposed to fix this?

> Session close over websocket does not reply with confirmation
> -
>
> Key: TINKERPOP-1695
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1695
> Project: TinkerPop
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.2.3, 3.2.4
> Environment: Ubuntu 14.04
>Reporter: Charlie
>Priority: Minor
>
> If you were to open up wireshark and monitor the websocket traffic and run 
> the following in the gremlin console, you will see that a close message will 
> get sent, but no confirmation back that the session actually closed. 
> {code:java}
> gremlin> :remote console tinkerpop.server conf/remote.yaml session
> gremlin> :> g.V().count()
> gremlin> :remote close
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (TINKERPOP-1696) gremlin-dotnet: GraphSONReader third-party type exposed

2017-06-21 Thread Jorge Bay (JIRA) 
Jorge Bay created TINKERPOP-1696:


 Summary: gremlin-dotnet: GraphSONReader third-party type exposed
 Key: TINKERPOP-1696
 URL: https://issues.apache.org/jira/browse/TINKERPOP-1696
 Project: TinkerPop
  Issue Type: Improvement
  Components: language-variant
Reporter: Jorge Bay
Priority: Minor


On gremlin-dotnet, the {{GraphSONReader}} public class and 
{{IGraphSONDeserializer}} public interface uses {{JToken}} as a parameter, 
which is a type defined in the third-party library Newtonsoft's Json.NET.

{code:java}
public class GraphSONReader {
  public dynamic ToObject(JToken jToken) {
// ... implementation
  }
}
{code}

{code:java}
public interface IGraphSONDeserializer {
  object Objectify(JToken graphsonObject, GraphSONReader reader);
}
{code}

Even though Json.NET is a well-known library, exposing a third-party library 
type is usually not a good idea as it tightly couples both libraries, ie: 
{{IGraphSONDeserializer}} implementers will have to use Json.NET.

As we are dealing with JSON data, there is a benefit in parsing once and access 
the parsed data, like its currently implemented (we should avoid using strings 
and parse multiple times).

I propose using 
[{{dynamic}}|https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/types/using-type-dynamic]
 instead. In C#, an object of type {{dynamic}} is basically a dictionary 
without compile time checks, which is suitable for scenarios like this one.

{code:java}
public class GraphSONReader {
  public dynamic ToObject(dynamic parsedJson) {
// ... implementation
string type = parsedJson["@type"];
// ... get the deserializer for the given type ...
  }
}
{code}

{code:java}
public interface IGraphSONDeserializer {
  object Objectify(dynamic graphsonObject, GraphSONReader reader);
}
{code}




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: [DISCUSS] gremlin-dotnet preview release and merging

2017-06-21 Thread Jorge Bay Gondra 
 I agree that it's in a good shape for a preview release. It's great
contribution by Florian H. and it would be nice to have a release available
to start gathering feedback.

I'll post a few open discussions/issues on JIRA that can be addressed in
the short/mid term but that should not prevent the release to occur. Also,
it would be nice to have a ticket for the issue around the test suite
(desired behaviour, current behaviour, etc) to allow external help from
additional contributors.

Thanks,
Jorge

On Wed, Jun 21, 2017 at 5:28 PM, Stephen Mallette 
wrote:

> I've been shepherding along the gremlin-dotnet GLV and other than being
> hooked into the test suite (which it can't do readily given our current
> testing model) I think it's in pretty nice shape. Both Florian Hockmann and
> Jorge Gondra (contributors to this body of work) would like to see a
> "preview release" published.  I think I would like to see that happen as
> well. I think we could do that release directly from the TINKERPOP-1552
> branch.
>
> I think that we should do the preview release, await any feedback and then
> look to merge TINKERPOP-1552 to tp32/master. We can then make some choices
> about how/when we do an official release. We could keep doing
> preview/milestone releases until the test suite is done. Or we could go the
> complete opposite route and do an official release when we feel
> comfortable. I guess I'm just saying that we don't need to have the test
> suite in place to have this work exist on tp32/master.
>
> Any concerns about any aspects of this? If not, I'll assume lazy consensus
> in the next 72 hours and move forward with the preview release as well as
> the process of getting this work to release branches as described above.
>
> Thanks,
>
> Stephen
>

Re: gremlin-server.bat

2017-06-21 Thread Robert Dale 
':install' is the console command.
'install' is the .bat (and .sh command)

Robert Dale

On Wed, Jun 21, 2017 at 11:13 AM, Stephen Mallette 
wrote:

> Can someone with a windows environment please try this out:
>
> https://stackoverflow.com/q/44645204/1831717
>
> It seems to indicate that the gremlin-server.bat :install doesn't work. I
> suppose this is on 3.3.0 as that change only exists on master.
>

A question regarding vertex identification

2017-06-21 Thread Jack Park 
I am revisiting the tinkerpop universe looking for a system which can
cluster, and which permits me to construct vertex objects in which  I set
the vertex id, and can fetch them back. Ideally, findById and findByLabel
are of interest.

Can someone point me to tinkerpop-based implementations which allow that?

Thanks in adance.
Jack

[jira] [Commented] (TINKERPOP-1552) C# Gremlin Language Variant

2017-06-21 Thread stephen mallette (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057593#comment-16057593
 ] 

stephen mallette commented on TINKERPOP-1552:
-

a separate ticket is fine by me - though i also suggest bringing attention to 
that ticket on the dev list so that folks are aware of it. sometimes important 
issues get lost in all the JIRA traffic. it helps to form a DISCUSS thread just 
so people have a look. there may not be any feedback, but at least the idea 
isn't completely missed.

> C# Gremlin Language Variant
> ---
>
> Key: TINKERPOP-1552
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1552
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: language-variant
>Affects Versions: 3.2.3
>Reporter: Jorge Bay
>Assignee: stephen mallette
>
> It would be nice to have a C# GLV that runs under .NET Framework 4.5+ and 
> .NET Core.
> The maven build could use the Exec Maven Plugin to exec .NET Core's [dotnet 
> test|https://www.microsoft.com/net/core#macos] command.
> Some requirements, from the mailing list (edited):
> {quote}
> 1. The GLV should keep in line with class/method names of the java API
> where possible to ensure consistency of feel across languages.
> 2. There needs to be adequate tests (we're still discussing the approach to
> testing GLVs and i think that needs to be tackled sooner than later as more
> GLVs start to come in). Those tests should produce xunit style output
> unless there is some good reason not to.
> 3. There needs to be adequate documentation (e.g. Reference docs)
> 4. The build/deploy process needs to be bound to maven which might be one of 
> the trickier bits to deal with.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1552) C# Gremlin Language Variant

2017-06-21 Thread Jorge Bay (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057558#comment-16057558
 ] 

Jorge Bay commented on TINKERPOP-1552:
--

+1 on the preview / alpha release.

About exposing third-party types in the C# GLV API vs dynamic, I think we 
should address before going GA (its a breaking change). I can create a 
different ticket for the discussion, makes sense [~Florian Hockmann] / 
[~spmallette] ?

> C# Gremlin Language Variant
> ---
>
> Key: TINKERPOP-1552
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1552
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: language-variant
>Affects Versions: 3.2.3
>Reporter: Jorge Bay
>Assignee: stephen mallette
>
> It would be nice to have a C# GLV that runs under .NET Framework 4.5+ and 
> .NET Core.
> The maven build could use the Exec Maven Plugin to exec .NET Core's [dotnet 
> test|https://www.microsoft.com/net/core#macos] command.
> Some requirements, from the mailing list (edited):
> {quote}
> 1. The GLV should keep in line with class/method names of the java API
> where possible to ensure consistency of feel across languages.
> 2. There needs to be adequate tests (we're still discussing the approach to
> testing GLVs and i think that needs to be tackled sooner than later as more
> GLVs start to come in). Those tests should produce xunit style output
> unless there is some good reason not to.
> 3. There needs to be adequate documentation (e.g. Reference docs)
> 4. The build/deploy process needs to be bound to maven which might be one of 
> the trickier bits to deal with.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1552) C# Gremlin Language Variant

2017-06-21 Thread Florian Hockmann (JIRA) 

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057362#comment-16057362
 ] 

Florian Hockmann commented on TINKERPOP-1552:
-

{quote}
The solution would be to parse the json using Json.NET (as is) but use dynamic 
in our public API, which is a good fit for parsed json.
{quote}
I don't know if using {{dynamic}} for an argument in a public method is a good 
idea as a you then don't really know what you get. When we keep the 
deserializers as they are right know, then we would still be bound to Json.NET. 
We would only hide this fact which makes it more confusing in my opinion. A 
cleaner option would be to just use {{string}}, so that the deserializer can 
deserialize the element completely from GraphSON, but that would of course 
require some additional work that is currently not needed.
I personally think that the approach with {{JToken}} is the best compromise at 
the moment. But I'm of course open to changing that as it is definitely not an 
ideal solution. What do others think about this matter?

{quote}
Can we list the pending items for this GLV to be included on TinkerPop? that 
way we can all help to close this one.
{quote}
At least from my side Gremlin-DotNet is now ready to be published as a _beta_ 
version. For the first official release we probably need the testing framework 
[~spmallette] mentioned. There are some other improvements I have in mind, but 
they really aren't necessary for the first release. So we can track those with 
separate tickets later on.
By the way, I will be on vacation until end of next week. So I can't help with 
any issues until then.

> C# Gremlin Language Variant
> ---
>
> Key: TINKERPOP-1552
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1552
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: language-variant
>Affects Versions: 3.2.3
>Reporter: Jorge Bay
>Assignee: stephen mallette
>
> It would be nice to have a C# GLV that runs under .NET Framework 4.5+ and 
> .NET Core.
> The maven build could use the Exec Maven Plugin to exec .NET Core's [dotnet 
> test|https://www.microsoft.com/net/core#macos] command.
> Some requirements, from the mailing list (edited):
> {quote}
> 1. The GLV should keep in line with class/method names of the java API
> where possible to ensure consistency of feel across languages.
> 2. There needs to be adequate tests (we're still discussing the approach to
> testing GLVs and i think that needs to be tackled sooner than later as more
> GLVs start to come in). Those tests should produce xunit style output
> unless there is some good reason not to.
> 3. There needs to be adequate documentation (e.g. Reference docs)
> 4. The build/deploy process needs to be bound to maven which might be one of 
> the trickier bits to deal with.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)