[jira] [Commented] (TINKERPOP-2056) Use NumberHelper in Compare
[ https://issues.apache.org/jira/browse/TINKERPOP-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640083#comment-16640083 ] ASF GitHub Bot commented on TINKERPOP-2056: --- Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/949 > Use NumberHelper in Compare > --- > > Key: TINKERPOP-2056 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2056 > Project: TinkerPop > Issue Type: Improvement > Components: process >Affects Versions: 3.2.9 >Reporter: Daniel Kuppitz >Assignee: Daniel Kuppitz >Priority: Major > > The {{Compare}} enum doesn't use {{NumberHelper}}. Instead, it converts > numbers of differing types to {{BigDecimal}}s. That's pretty much the slowest > thing we can do. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-2056) Use NumberHelper in Compare
[ https://issues.apache.org/jira/browse/TINKERPOP-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640014#comment-16640014 ] ASF GitHub Bot commented on TINKERPOP-2056: --- Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/949 VOTE +1 > Use NumberHelper in Compare > --- > > Key: TINKERPOP-2056 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2056 > Project: TinkerPop > Issue Type: Improvement > Components: process >Affects Versions: 3.2.9 >Reporter: Daniel Kuppitz >Assignee: Daniel Kuppitz >Priority: Major > > The {{Compare}} enum doesn't use {{NumberHelper}}. Instead, it converts > numbers of differing types to {{BigDecimal}}s. That's pretty much the slowest > thing we can do. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-2056) Use NumberHelper in Compare
[ https://issues.apache.org/jira/browse/TINKERPOP-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16639831#comment-16639831 ] ASF GitHub Bot commented on TINKERPOP-2056: --- Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/949 From what we've seen in previous tests, it should be marginally faster. I haven't run any new tests as this was more about consistency. > Use NumberHelper in Compare > --- > > Key: TINKERPOP-2056 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2056 > Project: TinkerPop > Issue Type: Improvement > Components: process >Affects Versions: 3.2.9 >Reporter: Daniel Kuppitz >Assignee: Daniel Kuppitz >Priority: Major > > The {{Compare}} enum doesn't use {{NumberHelper}}. Instead, it converts > numbers of differing types to {{BigDecimal}}s. That's pretty much the slowest > thing we can do. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-2056) Use NumberHelper in Compare
[ https://issues.apache.org/jira/browse/TINKERPOP-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16639666#comment-16639666 ] ASF GitHub Bot commented on TINKERPOP-2056: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/949 Just pushed a commit 4bdb006c5ee418f27ef7bb8a9330714ce414c50f on the release branches to deal with these pesky tests that sometimes fail in travis: ```text [ERROR] GremlinGroovyScriptEngineTest.shouldAllowsUseToBeExecutedAfterImport:293 » Runtime [ERROR] GremlinGroovyScriptEngineTest.shouldLoadImportsViaDependencyManagerFromDependencyGatheredByUse:279 » Runtime ``` Obviously not related to this change. Did you happen to do any tests to see what this optimization bought us in terms of performance? VOTE +1 > Use NumberHelper in Compare > --- > > Key: TINKERPOP-2056 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2056 > Project: TinkerPop > Issue Type: Improvement > Components: process >Affects Versions: 3.2.9 >Reporter: Daniel Kuppitz >Assignee: Daniel Kuppitz >Priority: Major > > The {{Compare}} enum doesn't use {{NumberHelper}}. Instead, it converts > numbers of differing types to {{BigDecimal}}s. That's pretty much the slowest > thing we can do. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-2056) Use NumberHelper in Compare
[ https://issues.apache.org/jira/browse/TINKERPOP-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638299#comment-16638299 ] ASF GitHub Bot commented on TINKERPOP-2056: --- GitHub user dkuppitz opened a pull request: https://github.com/apache/tinkerpop/pull/949 TINKERPOP-2056 Use NumberHelper in Compare Instead of converting all numbers to `BigDecimal`, `Compare` predicates now use `NumberHelper` for numerical comparisons. `docker/build.sh -t -i -n` passed. VOTE +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-2056 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/949.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #949 commit 8759b39ce83b2165bc1415d1feead005e970a505 Author: Daniel Kuppitz Date: 2018-10-04T14:07:27Z TINKERPOP-2056 Made use of `NumberHelper` in `Compare` predicates. > Use NumberHelper in Compare > --- > > Key: TINKERPOP-2056 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2056 > Project: TinkerPop > Issue Type: Improvement > Components: process >Affects Versions: 3.2.9 >Reporter: Daniel Kuppitz >Assignee: Daniel Kuppitz >Priority: Major > > The {{Compare}} enum doesn't use {{NumberHelper}}. Instead, it converts > numbers of differing types to {{BigDecimal}}s. That's pretty much the slowest > thing we can do. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-2056) Use NumberHelper in Compare
[ https://issues.apache.org/jira/browse/TINKERPOP-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637293#comment-16637293 ] stephen mallette commented on TINKERPOP-2056: - It's breaking to 3.4.0 still though right? I wonder how we should handle this. Don't think we've had a situation where a change was breaking in one version but not another. Maybe use this ticket for the non-breaking part and create a separate ticket with the "breaking" label. That way when we generate release notes they "breaking" label will go with 3.4.0. Sorry - extra stuff, but I think that's the right way to do it. > Use NumberHelper in Compare > --- > > Key: TINKERPOP-2056 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2056 > Project: TinkerPop > Issue Type: Improvement > Components: process >Affects Versions: 3.2.9 >Reporter: Daniel Kuppitz >Assignee: Daniel Kuppitz >Priority: Major > > The {{Compare}} enum doesn't use {{NumberHelper}}. Instead, it converts > numbers of differing types to {{BigDecimal}}s. That's pretty much the slowest > thing we can do. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-2056) Use NumberHelper in Compare
[ https://issues.apache.org/jira/browse/TINKERPOP-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637280#comment-16637280 ] Daniel Kuppitz commented on TINKERPOP-2056: --- Kinda related: {{Contains}} doesn't convert differing number types at all. {noformat} gremlin> g.V().has("age", eq(32L)) ==>v[4] gremlin> g.V().has("age", within(32L, 35L)) gremlin> {noformat} The problem though: This behavior is enforced by the test suite and a change would be breaking. Hence I'm going to include the {{Compare}} changes in the {{tp32}} PR and I will create another PR for {{master/}} that also includes the {{Contains}} changes. > Use NumberHelper in Compare > --- > > Key: TINKERPOP-2056 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2056 > Project: TinkerPop > Issue Type: Improvement > Components: process >Affects Versions: 3.2.9 >Reporter: Daniel Kuppitz >Assignee: Daniel Kuppitz >Priority: Major > > The {{Compare}} enum doesn't use {{NumberHelper}}. Instead, it converts > numbers of differing types to {{BigDecimal}}s. That's pretty much the slowest > thing we can do. -- This message was sent by Atlassian JIRA (v7.6.3#76005)