[GitHub] tinkerpop issue #855: TINKERPOP-1950 Cached global strategy lookups during t...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/855
  
I think `computeIfAbsent()` would have been better :goat: 


---

[GitHub] tinkerpop issue #857: TINKERPOP-1869 Allowed iterate() after profile()

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/857
  
VOTE +1


---

[GitHub] tinkerpop issue #855: TINKERPOP-1950 Cached global strategy lookups during t...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/855
  
Well, you would do use ConcurrentHashMap ;-)
```
static Map LOADED = new ConcurrentHashMap<>();
try {
LOADED.computeIfAbsent(graphOrGraphComputerClass, (unused) -> {

final String graphComputerClassName = null != 
graphOrGraphComputerClass.getDeclaringClass()
? 
graphOrGraphComputerClass.getCanonicalName().replace(
"." + 
graphOrGraphComputerClass.getSimpleName(),
"$" + 
graphOrGraphComputerClass.getSimpleName())
: graphOrGraphComputerClass.getCanonicalName();
try {
Class.forName(graphComputerClassName);
} catch (ClassNotFoundException e) {
throw new RuntimeException(e);
}

// keep track of stuff we already loaded once - stuff in 
this if/statement isn't
// cheap and this
// method gets called a lot, basically every time a new 
traversal gets spun up
// (that includes
// child traversals. perhaps it is possible to just check 
the cache keys for
// this information, but
// it's not clear if this method will be called with 
something not in the cache
// and if it is and
// it results in error, then we'd probably not want to deal 
with this block
// again anyway
return Boolean.TRUE;
});
} catch (Exception e) {
throw new IllegalStateException(e.getCause().getMessage(), 
e.getCause());
}

```



---

[GitHub] tinkerpop issue #844: TINKERPOP-1628 Implement TraversalSelectStep

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/844
  
Finally got docs building again.
VOTE +1


---

[GitHub] tinkerpop issue #862: TINKERPOP-1961 Removed duplication of images in binari...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/862
  
After running `bin/process-docs.sh` the resulting console/server zip files 
no longer contain `docs/` let alone `images`. Is there a different step that 
needs to be run?


---

[GitHub] tinkerpop issue #862: TINKERPOP-1961 Removed duplication of images in binari...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/862
  
I did:
1. `bin/process-docs.sh`
2. `mvn install`
3. `find . -name '*.zip'`
4. `unzip -t 
./gremlin-server/target/apache-tinkerpop-gremlin-server-3.2.9-distribution.zip 
| grep images`
I don't see any images
3. `mvn deploy`
I can see the maven-assembly-plugin rebuild the zip file. Still don't see 
any images in any zips



---

[GitHub] tinkerpop issue #862: TINKERPOP-1961 Removed duplication of images in binari...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/862
  
I walked through the actual release process and this time I do see the 
correct packaging.
VOTE +1


---

[GitHub] tinkerpop issue #869: TINKERPOP-1841 Configure python tests in travis

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/869
  
VOTE +1


---

[GitHub] tinkerpop issue #861: TINKERPOP-1956 Deprecated Order.incr and Order.decr

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/861
  
VOTE +1


---

[GitHub] tinkerpop issue #860: TINKERPOP-1595 Optimize TraversalVertexProgram

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/860
  
VOTE +1


---

[GitHub] tinkerpop issue #864: TINKERPOP-1958 Fixed a bug in TinkerGraphCountStrategy

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/864
  
VOTE +1


---

[GitHub] tinkerpop issue #871: TINKERPOP-1975 Introduced with() step and Configuring ...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/871
  
VOTE +1


---

[GitHub] tinkerpop issue #874: TINKERPOP-1979 Fix math() on OLAP/Spark

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/874
  
VOTE +1


---

[GitHub] tinkerpop issue #876: TINKERPOP-967 Support nested-repeat() structures

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/876
  
VOTE +1


---

[GitHub] tinkerpop issue #886: TINKERPOP-1987 Bump to Spark 2.3.1 and Netty 4.1.25.Fi...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/886
  
@spmallette any idea why the spark test is hanging in travis?


---

[GitHub] tinkerpop issue #892: Tinkerpop 2007

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/892
  
I don't like this patch.  If the regression tests rely on some sort order 
in xml, they're doing it wrong.  If it's the graph being validated, then the 
test should pull it into a graph engine and validate using graph queries.  If 
the xml is being validated, then the test should use xml tools, e.g. xmldiff, 
schema validation, etc.  If the test really requires sort order, which it 
shouldn't because GraphML does not guarantee any order, then it should 
transform the xml with xslt before validating it.

That said, the writer already provides an optional, **deterministic** order 
feature.   If someone doesn't like that order, then someone else won't like 
this order.  So, I think the right solution would be to be able to provide a 
custom comparator as a parameter and let the user create any order they see fit.


---

[GitHub] tinkerpop pull request #904: TINKERPOP-2016 Bumped to Jackson 2.9.6

[robertdale]

GitHub user robertdale opened a pull request:

https://github.com/apache/tinkerpop/pull/904

TINKERPOP-2016 Bumped to Jackson 2.9.6

https://issues.apache.org/jira/browse/TINKERPOP-2016

Bumped to Jackson 2.9.6 for CVE.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-2016

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/904.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #904


commit 1829318f6bfce1bc360818c6a0c34492fa69ec9a
Author: Robert Dale 
Date:   2018-08-02T00:02:14Z

TINKERPOP-2016 Bumped to Jackson 2.9.6




---

[GitHub] tinkerpop issue #904: TINKERPOP-2016 Bumped to Jackson 2.9.6

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/904
  
@spmallette Thanks. 


---

[GitHub] tinkerpop issue #907: Fix Sack Split.

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/907
  
Is there a test that covers this?


---

[GitHub] tinkerpop issue #907: Fix Sack Split.

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/907
  
@RainMark Could you create an issue in Jira and describe the problem?   See 
also [Contributing code 
changes](https://tinkerpop.apache.org/docs/current/dev/developer/#_contributing_code_changes).
 It would be good to see a test case that fails without the change and passes 
with the change but also satisfies the examples in the documentation.

I also want to make sure you're not running into this
- http://tinkerpop.apache.org/docs/current/reference/#sack-step
```
The first example does not use a split operator and as such, the same map 
is propagated to
all traversers (a global data structure). The second example, demonstrates 
how Map.clone()
ensures that each traverser’s sack contains a unique, local sack.
```



---

[GitHub] tinkerpop pull request #912: TINKERPOP-2023 SSL Enhancements

[robertdale]

GitHub user robertdale opened a pull request:

https://github.com/apache/tinkerpop/pull/912

TINKERPOP-2023 SSL Enhancements

https://issues.apache.org/jira/browse/TINKERPOP-2023

Gremlin Server no longer supports automatically creating self-signed 
certificates.

Cluster client no longer trusts all certs by default as this is an insecure 
configuration. (TINKERPOP-2022)
If no trust store is configured, Cluster will use the default CA certs.
To revert to the previous behavior and accept all certs, it must be 
explicitly configured.

Introduces JKS and PKCS12 support. JKS is the legacy Java Key Store. PKCS12 
has better cross-platform support and is gaining in adoption. Be aware that JKS 
is the default on Java 8.  Java 9 and higher use PKCS12 as the default. Both 
Java keytool and OpenSSL tools can create, read, update PKCS12 files.

Other new features include specifying SSL protocols and cipher suites.

The packaged `*-secure.yaml` files now restrict the protocol to `TLSv1.2` 
by default.

The implication of all of the above changes means that the packaged 
`*-secure.yaml` files no longer "just work". Minimally, the server files must 
be configured with a key/cert.

PEM-based configurations are deprecated, to be removed in a future release.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-2023

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/912.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #912


commit 14f99a46cc939d0dcfe0423a3db4611e90b0eb6f
Author: Robert Dale 
Date:   2018-08-12T01:12:50Z

TINKERPOP-2023 new SSL client, server parameters

commit 317e81280ac1a2c1793d610f3e7fc538a00cab67
Author: Robert Dale 
Date:   2018-08-13T01:50:02Z

TINKERPOP-2023 default to TLSv1.2, updated upgrade notes

commit 48347f235fa5b66268591732fe799ad0d14a4f8b
Author: Robert Dale 
Date:   2018-08-13T02:23:33Z

TINKERPOP-2023 updated docs

commit 2da958b03dda0af828e8bccacac029e64c95c1cc
Author: Robert Dale 
Date:   2018-08-13T19:28:40Z

TINKERPOP-2023 added tests and some fixes




---

[GitHub] tinkerpop issue #912: TINKERPOP-2023 SSL Enhancements

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/912
  
Right, when it's security-related, you're given a pass to break anything! 
:rage1: :rage2:  :rage3: :rage4: 

Seriously, the breaking change is only if you relied on the server 
generating self-signed certs or if the client accepted all certs. In the server 
case, you have to configure SSL correctly.  In the client case, you can revert 
to previous behavior with a one line change.  In both cases, I think they are 
trivial enough configuration changes that warrant going back to tp32 to set 
things right.


---

[GitHub] tinkerpop issue #912: TINKERPOP-2023 SSL Enhancements

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/912
  
@k4rthikr That's a little deeper than I want to get into. `sslCipherSuites` 
provides a whitelist. Whitelists are always preferred over blacklists. If this 
one were blacklisted, there are probably 10 others that were missed. I also 
don't want to imply that these are managed and updated by us. There are just 
too many and changes more often than say TLS protocol version. IMO, the scope 
of this work was to set reasonable defaults that made Gremlin Server+Client 
more secure and raise awareness to the user. It will be up to the user to use 
good ciphers, good key lengths, etc.


---

[GitHub] tinkerpop issue #919: String loop to String builder

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/919
  
@otaviojava did you decompile the bytecode to make sure the compiler didn't 
do that automagically?   Otherwise, StringBuilder vars should be final.


---

[GitHub] tinkerpop pull request #919: String loop to String builder

[robertdale]

Github user robertdale commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/919#discussion_r211934120
  
--- Diff: 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalMetrics.java
 ---
@@ -208,14 +208,14 @@ private void handleNestedTraversals(final 
Traversal.Admin traversal, final Mutab
 private void appendMetrics(final Collection 
metrics, final StringBuilder sb, final int indent) {
 // Append each StepMetric's row. indexToLabelMap values are 
ordered by index.
 for (Metrics m : metrics) {
-String rowName = m.getName();
+final StringBuilder metricName = new 
StringBuilder(m.getName());
 
 // Handle indentation
 for (int ii = 0; ii < indent; ii++) {
-rowName = "  " + rowName;
+metricName.insert(0, "  ");
 }
--- End diff --

Would it make sense to put this block before the name then it won't have to 
do inserts?


---

[GitHub] tinkerpop pull request #919: String loop to String builder

[robertdale]

Github user robertdale commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/919#discussion_r211934275
  
--- Diff: 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalMetrics.java
 ---
@@ -286,10 +286,10 @@ private void appendMetrics(final Collection metrics, final St
 private static String padLeft(final String text, final int 
amountToPad) {
 // not sure why this method needed to exist. stupid string format 
stuff and commons utilities wouldn't
 // work for some reason in the context this method was used above.
-String newText = text;
+final StringBuilder newText = new StringBuilder(text);
 for (int ix = 0; ix < amountToPad; ix++) {
-newText = " " + newText;
+newText.insert(0, " ");
 }
--- End diff --

Would it make sense to put this block before `text` then it won't have to 
do inserts?


---

[GitHub] tinkerpop pull request #919: String loop to String builder [master]

[robertdale]

Github user robertdale commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/919#discussion_r211948320
  
--- Diff: 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalMetrics.java
 ---
@@ -208,14 +208,14 @@ private void handleNestedTraversals(final 
Traversal.Admin traversal, final Mutab
 private void appendMetrics(final Collection 
metrics, final StringBuilder sb, final int indent) {
 // Append each StepMetric's row. indexToLabelMap values are 
ordered by index.
 for (Metrics m : metrics) {
-String rowName = m.getName();
+final StringBuilder metricName = new 
StringBuilder(m.getName());
 
 // Handle indentation
 for (int ii = 0; ii < indent; ii++) {
-rowName = "  " + rowName;
+metricName.insert(0, "  ");
 }
--- End diff --

Yes, I get that. What I'm suggesting is that instead of having to `insert` 
data later on thus incurring the cost of array copies, why not put the 
indentation loop first, then everything after can be `append` only.


---

[GitHub] tinkerpop pull request #919: String loop to String builder [tp32]

[robertdale]

Github user robertdale commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/919#discussion_r211952645
  
--- Diff: 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalMetrics.java
 ---
@@ -208,14 +208,14 @@ private void handleNestedTraversals(final 
Traversal.Admin traversal, final Mutab
 private void appendMetrics(final Collection 
metrics, final StringBuilder sb, final int indent) {
 // Append each StepMetric's row. indexToLabelMap values are 
ordered by index.
 for (Metrics m : metrics) {
-String rowName = m.getName();
+final StringBuilder metricName = new 
StringBuilder(m.getName());
 
 // Handle indentation
 for (int ii = 0; ii < indent; ii++) {
-rowName = "  " + rowName;
+metricName.insert(0, "  ");
 }
--- End diff --

Right.


---

[GitHub] tinkerpop issue #919: String loop to String builder [tp32]

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/919
  
@otaviojava was that locally?  the travis build failed due to grapes 
download.


---

[GitHub] tinkerpop issue #919: String loop to String builder [tp32]

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/919
  
Hmm.. it happens on tp32. 


---

[GitHub] tinkerpop issue #919: String loop to String builder [tp32]

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/919
  
Nevermind, still just grapes.


---

[GitHub] tinkerpop issue #914: Do not format and reparse eval timeout arg when evalua...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/914
  
VOTE +1


---

[GitHub] tinkerpop issue #919: String loop to String builder [tp32]

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/919
  
@dkuppitz Will do.


---

[GitHub] tinkerpop pull request #930: TINKERPOP-2032 bump jython-standalone 2.7.1

[robertdale]

GitHub user robertdale opened a pull request:

https://github.com/apache/tinkerpop/pull/930

TINKERPOP-2032 bump jython-standalone 2.7.1

https://snyk.io/vuln/SNYK-JAVA-ORGPYTHON-31451

Overview
org.python:jython-standalone Affected versions of this package are 
vulnerable to Arbitrary Code Execution by sending a serialized function to the 
deserializer, which in turn will execute the code.

References
[CVE](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2016-4000)
[Jython Bug Report](http://bugs.jython.org/issue2454)
[Fix Commit](https://hg.python.org/jython/rev/d06e29d100c0)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-2032

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/930.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #930


commit f70d108e0e9cace79565c658e6bac5c7e9f045ba
Author: Robert Dale 
Date:   2018-09-11T12:35:33Z

TINKERPOP-2032 bump jython-standalone 2.7.1




---

[GitHub] tinkerpop issue #930: TINKERPOP-2032 bump jython-standalone 2.7.1

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/930
  
tp33: `docker/build.sh -i -t -n`  SUCCESS
master: building...


---

[GitHub] tinkerpop issue #930: TINKERPOP-2032 bump jython-standalone 2.7.1

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/930
  
master: `docker/build.sh -i -t -n` BUILD SUCCESS


---

[GitHub] tinkerpop pull request #931: TINKERPOP-2029 ConcurrentModificationException ...

[robertdale]

Github user robertdale commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/931#discussion_r217732616
  
--- Diff: docs/src/upgrade/release-3.4.x.asciidoc ---
@@ -29,6 +29,29 @@ Please see the 
link:https://github.com/apache/tinkerpop/blob/3.4.0/CHANGELOG.asc
 
 === Upgrading for Users
 
+ Changed infix behavior
+
+The infix notation of `and()` and `or()` now supports an arbitrary number 
of traversals and `ConnectiveStrategy` produces a traversal with the correct 
AND and OR semantics. Furthermore,
+previous versions failed to apply 3 or more `and()` steps in an infix 
notation, this is now fixed.
+
+[source,groovy]
+
+gremlin> g.V().has("name","marko").and().has("age", 
lt(30)).or().has("name","josh").and().has("age", gt(30)).and().out("created")
+==>v[1]
+==>v[4]
+
+
+In previous versions the above traversal 
+[source,groovy]
+
+gremlin> 
g.V().repeat(__.in('traverses').repeat(__.in('develops')).emit()).emit().values('name')
+==>stephen
+==>matthias
+==>marko
+
+
+See: 
link:https://issues.apache.org/jira/browse/TINKERPOP-967[TINKERPOP-967]
--- End diff --

There should be a link to this issue as well - 
https://issues.apache.org/jira/browse/TINKERPOP-2029


---

[GitHub] tinkerpop pull request #931: TINKERPOP-2029 ConcurrentModificationException ...

[robertdale]

Github user robertdale commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/931#discussion_r217731843
  
--- Diff: docs/src/upgrade/release-3.4.x.asciidoc ---
@@ -29,6 +29,29 @@ Please see the 
link:https://github.com/apache/tinkerpop/blob/3.4.0/CHANGELOG.asc
 
 === Upgrading for Users
 
+ Changed infix behavior
+
+The infix notation of `and()` and `or()` now supports an arbitrary number 
of traversals and `ConnectiveStrategy` produces a traversal with the correct 
AND and OR semantics. Furthermore,
+previous versions failed to apply 3 or more `and()` steps in an infix 
notation, this is now fixed.
+
--- End diff --

The graph example is good for those familiar with the graph but it's not 
immediately clear what the difference in behavior is. I really like the example 
from the comments. I think it would be good to add here (not necessarily 
verbatim) for clarity. 
```
# BEHAVIOR

Input: a.or.b.and.c.or.d.and.e.or.f.and.g.and.h.or.i

## BEFORE
Output: or(a, or(and(b, c), or(and(d, e), or(and(and(f, g), h), i

## NOW
Output: or(a, and(b, c), and(d, e), and(f, g, h), i)
```



---

[GitHub] tinkerpop pull request #931: TINKERPOP-2029 ConcurrentModificationException ...

[robertdale]

Github user robertdale commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/931#discussion_r217720970
  
--- Diff: docs/src/upgrade/release-3.4.x.asciidoc ---
@@ -29,6 +29,29 @@ Please see the 
link:https://github.com/apache/tinkerpop/blob/3.4.0/CHANGELOG.asc
 
 === Upgrading for Users
 
+ Changed infix behavior
+
+The infix notation of `and()` and `or()` now supports an arbitrary number 
of traversals and `ConnectiveStrategy` produces a traversal with the correct 
AND and OR semantics. Furthermore,
+previous versions failed to apply 3 or more `and()` steps in an infix 
notation, this is now fixed.
+
+[source,groovy]
+
+gremlin> g.V().has("name","marko").and().has("age", 
lt(30)).or().has("name","josh").and().has("age", gt(30)).and().out("created")
+==>v[1]
+==>v[4]
+
+
+In previous versions the above traversal 
--- End diff --

Seems like something more is needed here.


---

[GitHub] tinkerpop pull request #932: TINKERPOP-2033 Maintain order in profile() anno...

[robertdale]

Github user robertdale commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/932#discussion_r217736025
  
--- Diff: 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/gryo/GryoSerializersV3d0.java
 ---
@@ -427,7 +428,12 @@ else if (1 == arguments)
 output.writeString(object.getName());
 output.writeDouble(object.getDuration(TimeUnit.NANOSECONDS) / 
100d);
 kryo.writeObject(output, object.getCounts());
-kryo.writeObject(output, object.getAnnotations());
+
+// annotations is a synchronized LinkedHashMap - get rid of 
the "synch" for serialization as gryo
+// doesn't know how to deserialize that well and LinkedHashMap 
should work with 3.3.x and previous
+final Map annotations = new LinkedHashMap<>();
+object.getAnnotations().forEach(annotations::put);
+kryo.writeObject(output, annotations);
 
 // kryo might have a problem with LinkedHashMap value 
collections. can't recreate it independently but
--- End diff --

Do we not need to worry about this comment?


---

[GitHub] tinkerpop issue #930: TINKERPOP-2032 bump jython-standalone 2.7.1

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/930
  
VOTE +1


---

[GitHub] tinkerpop issue #931: TINKERPOP-2029 ConcurrentModificationException for Inl...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/931
  
VOTE +1


---

[GitHub] tinkerpop issue #932: TINKERPOP-2033 Maintain order in profile() annotations

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/932
  
VOTE +1


---

[GitHub] tinkerpop issue #930: TINKERPOP-2032 bump jython-standalone 2.7.1

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/930
  
Claiming 7-day rule :smile: 


---

[GitHub] tinkerpop issue #935: TINKERPOP-2025 Change to SHA-256/512 and drop SHA-1 fo...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/935
  
VOTE +1


---

[GitHub] tinkerpop issue #934: Apply StringEscapeUtils in GroovyTranslator#convertToS...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/934
  
VOTE +1


---

[GitHub] tinkerpop pull request #939: TINKERPOP-2045 removed duplicate non-indy groov...

[robertdale]

GitHub user robertdale opened a pull request:

https://github.com/apache/tinkerpop/pull/939

TINKERPOP-2045 removed duplicate non-indy groovy core dep

https://issues.apache.org/jira/browse/TINKERPOP-2045

Exclude non-indy transitive dep on groovy core.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-2045

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/939.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #939


commit 6e320daa57a9ec9acb19a213f6dd2081e70e2e26
Author: Robert Dale 
Date:   2018-09-25T11:40:50Z

TINKERPOP-2045 removed duplicate non-indy groovy core dep




---

[GitHub] tinkerpop issue #920: optmizes collection copy with Collections addAll

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/920
  
VOTE +1


---

[GitHub] tinkerpop issue #941: TINKERPOP-2040 Improve flexibility of GroovyTranslator...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/941
  
@spmallette Should have a CHANGELOG entry if not also an upgrade release 
note.


---

[GitHub] tinkerpop issue #944: TINKERPOP-2041 Text Predicates

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/944
  
I would like to see `TP` renamed to `TextP`.


---

[GitHub] tinkerpop issue #941: TINKERPOP-2040 Improve flexibility of GroovyTranslator...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/941
  
VOTE +1


---

[GitHub] tinkerpop issue #942: TINKERPOP-2049 Added with(k) overload

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/942
  
VOTE +1


---

[GitHub] tinkerpop pull request #943: TINKERPOP-2044 Configurable traversal to valida...

[robertdale]

Github user robertdale commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/943#discussion_r221859065
  
--- Diff: 
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Settings.java 
---
@@ -243,6 +243,8 @@ public static Settings from(final Configuration conf) {
 if (connectionPoolConf.containsKey("keepAliveInterval"))
 cpSettings.keepAliveInterval = 
connectionPoolConf.getLong("keepAliveInterval");
 
+if (connectionPoolConf.containsKey("validationRequest"))
+cpSettings.validationRequest = 
connectionPoolConf.getList("validationRequest").stream().map(Object::toString).collect(Collectors.joining(","));
--- End diff --

Why is this `getList()` instead of `getString()`?


---

[GitHub] tinkerpop pull request #943: TINKERPOP-2044 Configurable traversal to valida...

[robertdale]

Github user robertdale commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/943#discussion_r221858009
  
--- Diff: 
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Cluster.java 
---
@@ -575,6 +585,8 @@ SslContext createSSLContext() throws Exception {
 private String trustStore = null;
 private String trustStorePassword = null;
 private String keyStoreType = null;
+private String validationRequest = "''";
+private boolean useBytecodeForValidation = false;
--- End diff --

`useBytecodeForValidation` was added but doesn't appear to be used anywhere 
else.


---

[GitHub] tinkerpop pull request #946: TINKERPOP-2037 removed groovy-sql

[robertdale]

GitHub user robertdale opened a pull request:

https://github.com/apache/tinkerpop/pull/946

TINKERPOP-2037 removed groovy-sql


Removed unused groovy-sql dependency.

https://issues.apache.org/jira/browse/TINKERPOP-2037

`sh docker/build.sh -i -t` BUILD SUCCESS

VOTE +1


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-2037

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/946.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #946


commit 24ca28e08fa8a672f64c93fe95e5ae9ffa06dbee
Author: Robert Dale 
Date:   2018-10-02T16:24:31Z

TINKERPOP-2037 removed groovy-sql




---

[GitHub] tinkerpop issue #942: TINKERPOP-2049 Added with(k) overload

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/942
  
VOTE +1


---

[GitHub] tinkerpop issue #943: TINKERPOP-2044 Configurable traversal to validate host...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/943
  
VOTE +1


---

[GitHub] tinkerpop issue #944: TINKERPOP-2041 Text Predicates

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/944
  
VOTE +1


---

[GitHub] tinkerpop issue #945: TINKERPOP-2053 Support for OptionsStrategy

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/945
  
VOTE +1


---

[GitHub] tinkerpop issue #948: Optimizes Map with enum using the EnumMap implementati...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/948
  
VOTE +1


---

[GitHub] tinkerpop issue #949: TINKERPOP-2056 Use NumberHelper in Compare

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/949
  
VOTE +1


---

[GitHub] tinkerpop pull request #:

[robertdale]

Github user robertdale commented on the pull request:


https://github.com/apache/tinkerpop/commit/a8da47f14f731825d86b0ccaacf8e1187f6d50eb#commitcomment-19394971
  
Looks like cruft leftover from the leading zeroes style. And then obviously 
didn't bother testing beyond 9 lines after the last change. Thanks for fixing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop pull request #399: TINKERPOP-1369 Renamed REST API to HTTP API

[robertdale]

Github user robertdale closed the pull request at:

https://github.com/apache/tinkerpop/pull/399


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #399: TINKERPOP-1369 Renamed REST API to HTTP API

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/399
  
okie dokie


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #439: TINKERPOP-980: added sysv and systemd init scripts

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/439
  
@PommeVerte  do you mind if we move the ubuntu script to a separate pull 
request so this one can move forward?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #439: TINKERPOP-980: added sysv and systemd init scripts

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/439
  
Rebased. Retested.

VOTE +1



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #439: TINKERPOP-980: added sysv and systemd init scripts

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/439
  
@spmallette I pushed the windows changes. can you review?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #482: TINKERPOP-1541: Select should default to Pop.last sema...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/482
  
VOTE: +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop pull request #496: TINKERPOP-1556 allow developers to pass options...

[robertdale]

GitHub user robertdale opened a pull request:

https://github.com/apache/tinkerpop/pull/496

TINKERPOP-1556 allow developers to pass options to docker

This was a much smaller change than I expected. Originally I was adding 
some sysctl settings to the dockerfiles. In the end I discovered I could 
control that and much more from docker itself. So I'm going to go ahead and 
commit this small change.

example:
```
export DOCKER_OPTS="--cpuset-cpus 0-3 --sysctl 
net.ipv6.conf.all.disable_ipv6=1 --sysctl net.ipv6.conf.default.disable_ipv6=1"

./docker/build.sh -t -n -i
```

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1556

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/496.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #496






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #496: TINKERPOP-1556 allow developers to pass options to doc...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/496
  
Technically, neither, not even for the daemon. It's specific to certain 
distribution startup scripts. So there should be no overlap here. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop pull request #498: TINKERPOP-1557 Improve docker build time with t...

[robertdale]

GitHub user robertdale opened a pull request:

https://github.com/apache/tinkerpop/pull/498

TINKERPOP-1557 Improve docker build time with this one weird trick!

Total time went from just over 4 hours to 2:20m. Get back 1:40m of your 
cycles!

Giraph: startup would wait 3s to connect. solution: wait less. There's 
still about 7s for shutting down that can be gained back  per test!

Neo4j: very disk IO heavy. solution: work in memory. this benefits the 
entire build as well. This requires something special below.

In order to build in-memory, you must configure tmpfs with the magical 
directory name `/usr/src/tinkermem`.

example: 

```
export DOCKER_OPTS="--tmpfs 
/usr/src/tinkermem:exec,mode=0755,rw,noatime,size=1000m"
```

You can use `1000m` for typical `-t -i -n` usage.  Use `2000m` if building 
javadoc, asciidocs.
 
I will add some of this to the docker contributing / 
development-environment docs.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1557

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/498.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #498


commit a39c2fa23989bd9874205a4970c7647020eb0c7e
Author: Robert Dale 
Date:   2016-11-17T22:01:47Z

build faster with in-memory fs
make giraph wait less




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #498: TINKERPOP-1557 Improve docker build time with this one...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/498
  
@okram The giraph improvement will help all builds inside or outside of 
docker. That should save you about 1 hour.  I don't know what OS you're on, but 
in Linux you can get some speed improvement if your fs is mounted with noatime 
(and lazytime on newer kernels). For the ultimate speed improvement, you can 
make your changes on the regular fs then copy up to an in-memory fs (e.g. 
tmpfs) and then build there. That should save 20m just on neo4j and several 
more overall. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #498: TINKERPOP-1557 Improve docker build time with this one...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/498
  
There's probably over an hour that can be gained in giraph that's spent in 
waiting for everything to shutdown in each test run (about 6s each). Looks like 
it's zookeper. But I don't really know anything about giraph, zookeeper, 
hadoop.  If someone has a better idea, here's the shutdown sequence:

```
[INFO] org.apache.giraph.comm.netty.NettyClient - stop: Halting netty client
[INFO] org.apache.giraph.comm.netty.NettyClient$2 - stop: reached wait 
threshold, 1 connections closed, releasing resources now.
[INFO] org.apache.giraph.worker.BspServiceWorker - processEvent: Job state 
changed, checking to see if it needs to restart
[INFO] org.apache.giraph.master.BspServiceMaster - setJobState: 
{"_applicationAttemptKey":-1,"_stateKey":"FINISHED","_superstepKey":-1}
[INFO] org.apache.giraph.bsp.BspService - getJobState: Job state already 
exists (/_hadoopBsp/job_local2106675051_0003/_masterJobState)
[INFO] org.apache.giraph.master.BspServiceMaster - cleanup: Notifying 
master its okay to cleanup with 
/_hadoopBsp/job_local2106675051_0003/_cleanedUpDir/0_master
[INFO] org.apache.giraph.master.BspServiceMaster - cleanUpZooKeeper: Node 
/_hadoopBsp/job_local2106675051_0003/_cleanedUpDir already exists, no need to 
create.
[INFO] org.apache.giraph.master.BspServiceMaster - cleanUpZooKeeper: Got 1 
of 2 desired children from /_hadoopBsp/job_local2106675051_0003/_cleanedUpDir
[INFO] org.apache.giraph.master.BspServiceMaster - cleanedUpZooKeeper: 
Waiting for the children of /_hadoopBsp/job_local2106675051_0003/_cleanedUpDir 
to change since only got 1 nodes.
[INFO] org.apache.giraph.comm.netty.NettyClient - stop: Netty client halted
[INFO] org.apache.giraph.utils.LoggerUtils - saveVertices: Starting to save 
6 vertices using 1 threads
[INFO] org.apache.giraph.utils.LoggerUtils - saveVertices: Done saving 
vertices.
[WARN] org.apache.giraph.worker.BspServiceWorker - saveEdges:   
giraph.edgeOutputFormatClass => null [EdgeOutputFormat]  (class)
Make sure that the EdgeOutputFormat is not required.
[INFO] org.apache.giraph.bsp.BspService - process: cleanedUpChildrenChanged 
signaled
[INFO] org.apache.giraph.worker.BspServiceWorker - cleanup: Notifying 
master its okay to cleanup with 
/_hadoopBsp/job_local2106675051_0003/_cleanedUpDir/0_worker
[INFO] org.apache.giraph.master.BspServiceMaster - cleanUpZooKeeper: Got 2 
of 2 desired children from /_hadoopBsp/job_local2106675051_0003/_cleanedUpDir
[INFO] org.apache.giraph.master.BspServiceMaster - cleanup: Removed HDFS 
checkpoint directory (_bsp/_checkpoints//job_local2106675051_0003) with return 
= false since the job HadoopGremlin(Giraph): 
org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest$VertexProgramK@68c9bafc
 succeeded 
[INFO] org.apache.giraph.comm.netty.NettyClient - stop: Halting netty client
[INFO] org.apache.giraph.comm.netty.NettyClient$2 - stop: reached wait 
threshold, 1 connections closed, releasing resources now.
[INFO] org.apache.zookeeper.ZooKeeper - Session: 0x15873a7d0540001 closed
[INFO] org.apache.zookeeper.ClientCnxn$EventThread - EventThread shut down
[INFO] org.apache.giraph.comm.netty.NettyServer - stop: Halting netty server
[INFO] org.apache.giraph.comm.netty.NettyServer - stop: Start releasing 
resources
[INFO] 
org.apache.giraph.job.HaltApplicationUtils$DefaultHaltInstructionsWriter - 
writeHaltInstructions: To halt after next superstep execute: 
'bin/halt-application --zkServer bccc11278890:22181 --zkNode 
/_hadoopBsp/job_local2106675051_0003/_haltComputation'
[INFO] org.apache.giraph.comm.netty.NettyClient - stop: Netty client halted
[INFO] org.apache.giraph.comm.netty.NettyServer - stop: Netty server halted
[INFO] org.apache.giraph.comm.netty.NettyServer - stop: Halting netty server
[INFO] org.apache.giraph.comm.netty.NettyServer - stop: Start releasing 
resources
[INFO] org.apache.giraph.comm.netty.NettyServer - stop: Netty server halted
[INFO] org.apache.giraph.bsp.BspService - process: 
masterElectionChildrenChanged signaled
[INFO] org.apache.zookeeper.ClientCnxn$EventThread - EventThread shut down
[INFO] org.apache.zookeeper.ZooKeeper - Session: 0x15873a7d054 closed
[INFO] org.apache.giraph.master.MasterThread - setup: Took 0.006 seconds.
[INFO] org.apache.giraph.master.MasterThread - input superstep: Took 0.163 
seconds.
[INFO] org.apache.giraph.master.MasterThread - superstep 0: Took 0.034 
seconds.
[INFO] org.apache.giraph.master.MasterThread - shutdown: Took 6.632 seconds.
[INFO] org.apache.giraph.master.MasterThread - total: Took 6.836 seconds.
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your 

[GitHub] tinkerpop issue #498: TINKERPOP-1557 Improve docker build time with this one...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/498
  
@spmallette I concur with @dkuppitz that you don't appear to be using 
tmpfs.  What OS, branches, etc, and how to reproduce the mkdirs issue?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #498: TINKERPOP-1557 Improve docker build time with this one...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/498
  
@spmallette looks like this:
```
Step 5 : CMD sh -c docker/scripts/build.sh -t -i -n
 ---> Running in 3ab3e0b10487
 ---> 1baf7291ec3a
Removing intermediate container 3ab3e0b10487
Successfully built 1baf7291ec3a
Copying source to in-memory tmpfs
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #502: Tweaks for broad JDK8 support

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/502
  
I like the refactoring.  But why go backwards in java version?  Is this for 
source or target compatibility?  If it's source, I can't imagine as a dev you 
don't have the ability to upgrade to something released in the past year. As 
for target, let alone that java 8 should work on java 8,  the CVEs should scare 
anyone enough to not run anything less than the latest.

@okram You commented for using Java 1.8.0_40. Can you recall what/why?

> tinkerpop.xml master pom requires the build to be on Java 1.8.0_40+.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #498: TINKERPOP-1557 Improve docker build time with this one...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/498
  
VOTE: +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #487: TINKERPOP-1399 NumberHelper needs to go into util and ...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/487
  
VOTE: +0.01


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #504: TINKERPOP-1548: Traversals can complete before interru...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/504
  
I've seen this on master.

VOTE: +1



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop pull request #504: TINKERPOP-1548: Traversals can complete before ...

[robertdale]

Github user robertdale commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/504#discussion_r88893084
  
--- Diff: 
gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/TraversalInterruptionComputerTest.java
 ---
@@ -86,7 +97,7 @@ public void shouldRespectThreadInterruptionInVertexStep() 
throws Exception {
 
 // total time for test should not exceed 5 seconds - this prevents 
the test from just hanging and allows
 // it to finish with failure
-assertThat(startedIterating.await(5000, TimeUnit.MILLISECONDS), 
CoreMatchers.is(true));
+assertThat(startedIterating.await(1000, TimeUnit.MILLISECONDS), 
CoreMatchers.is(true));
--- End diff --

Why not just leave this as 5s?  Seems to work against the fix.  What is the 
actual timeout time value? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #457: TINKERPOP-1493 Groovy project doesn't build on Windows

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/457
  
Either one appears to work cleanly. Just update first - `git fetch --all`.
Obviously, make sure you're on your branch `git checkout tp31`.
Then either `git rebase upstream/tp31` or `git merge upstream/tp31`.
Finally, push it back to your repo. `git push` or `git push origin tp31` or 
however it's named.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #446: TINKERPOP-1483: valueMap should always return string k...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/446
  
Can this PR be updated with Map or should it be closed and 
open a new one?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #446: TINKERPOP-1483: valueMap should always return string k...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/446
  
This is interesting. I was unaware of some or didn't understand some 
implementation details. Taking a step back and looking at this again, I wonder 
if the original intent is more correct. Sorry @JPMoresmau  
:smiley:

We have to ask what is the purpose of `Hidden`? And what is the purpose of 
`T.*.getAccessor()`?  Looks like `Has` step internally use `T.*.getAccessor()` 
for equality tests. Is this more of an internal method or should it be exposed?

Ultimately, the question is with what or how do we expect to access `T` 
tokens in a value map?

Given: `map = g.V().valueMap(true).next()`

Access by: `map.get(T.id)`  **or** `map.get(T.id.getAccessor())`?

If the answer is `T.id` then the interface must be 

If the answer is `T.id.getAccessor()` then the interface must be 


In either case, there is no conflict between system-level `T` tokens (e.g. 
`T.id`), as these are either Enum or `Hidden`, and user-level strings (e.g. 
`id`).  




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #446: TINKERPOP-1483: valueMap should always return string k...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/446
  
Thanks for the clarification @dkuppitz 

`./docker/build.sh -t -i -n ` passes

VOTE: +1



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #457: TINKERPOP-1493 Groovy project doesn't build on Windows

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/457
  
I didn't consider that your remote branch was behind. Duh. What should have 
been done is a forced push `git push -f origin tp31` to replace your remote 
branch with your local branch.  Instead git ended up doing a merge and the 
history here looks a little weird because it pulled in all the changes since 
your changes. But git does the right thing and it merges cleanly on tp31.

Build passes on Linux. Can't test on windows.

VOTE: +0.5



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #457: TINKERPOP-1493 Groovy project doesn't build on Windows

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/457
  
@pauljackson It's all good. It's only the history here in the PR that looks 
weird. Since it's just the one commit, it'll be right in git history when it's 
actually merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop pull request #:

[robertdale]

Github user robertdale commented on the pull request:


https://github.com/apache/tinkerpop/commit/4eba658bcb347679eda964c27595e5d3969a199a#commitcomment-19987601
  
In CHANGELOG.asciidoc:
In CHANGELOG.asciidoc on line 49:
1. Isn't it Map?
2. It should be T.id and T.label



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #494: TINKERPOP-1443 - Introduce API check into the build

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/494
  
I'm on Apache Maven 3.3.9 (latest). So I'm ok with downgrading :trollface:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #508: TINKERPOP-1363 Cleanup Docker build script for next ma...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/508
  
Building world `docker/build.sh -t -i -n -d ` passes.
Building docs only `docker/build.sh -d ` passes.
Skimmed reference docs through browser.

VOTE: +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #507: TINKERPOP-1573: Bindings don't work in coalesce

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/507
  
`docker/build.sh -t -i -n` passes.

VOTE: +1



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop pull request #508: TINKERPOP-1363 Cleanup Docker build script for ...

[robertdale]

Github user robertdale commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/508#discussion_r90632990
  
--- Diff: CHANGELOG.asciidoc ---
@@ -26,6 +26,7 @@ 
image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
 TinkerPop 3.3.0 (Release Date: NOT OFFICIALLY RELEASED YET)
 ~~~
 
+* Updated Docker build scripts to include Python dependencies (NOTE: users 
should remove any previously generated TinkerPop Docker images).
--- End diff --

Maybe a reminder to dev list at release time will be sufficient.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #512: TINKERPOP-1570 Bumped to Netty 4.0.42

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/512
  
VOTE: +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop pull request #536: Support SSL client certificate authentication

[robertdale]

GitHub user robertdale opened a pull request:

https://github.com/apache/tinkerpop/pull/536

Support SSL client certificate authentication

Can be used with or without an Authenticator (authentication configuration)

Valid configs look like:

**No client cert auth:**
```
ssl: {
enabled: true,
keyFile: www.example.com.pk8.pem,
keyPassword: changeit,
keyCertChainFile: www.example.com.bundle.pem
}
```
or 
```
ssl: {
enabled: true,
keyFile: www.example.com.pk8.pem,
keyPassword: changeit,
keyCertChainFile: www.example.com.bundle.pem,
needClientAuth: NONE
}
```

**Optional client cert auth:**
```
ssl: {
enabled: true,
keyFile: www.example.com.pk8.pem,
keyPassword: changeit,
keyCertChainFile: www.example.com.bundle.pem,
trustCertChainFile: trusted-clients.cert.pem,
needClientAuth: OPTIONAL
}
```

**Require client cert auth:**

```
ssl: {
enabled: true,
keyFile: www.example.com.pk8.pem,
keyPassword: changeit,
keyCertChainFile: www.example.com.bundle.pem,
trustCertChainFile: trusted-clients.cert.pem,
needClientAuth: REQUIRE
}
```



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1602

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/536.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #536


commit 7462a9f007df86e83a9b6d49c71cb59c2bbc180d
Author: Robert Dale 
Date:   2017-01-17T19:24:00Z

Support SSL client auth

commit 2471a57844731b08600b1e9aef76ee572a517a2d
Author: Robert Dale 
Date:   2017-01-17T19:39:32Z

updated doc for ssl client auth




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #536: Support SSL client certificate authentication

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/536
  
@spmallette before you say it, I know I have to update changelog and update 
docs. :boom: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #536: TINKERPOP-1602 Support SSL client certificate authenti...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/536
  
Just wondering if posting a comment after updating the title will trigger 
JIRA to connect (or however that works).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #536: TINKERPOP-1602 Support SSL client certificate authenti...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/536
  
And it does. Yay. :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #536: TINKERPOP-1602 Support SSL client certificate authenti...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/536
  
If you can point me to a test that starts a gremlin-server with a custom 
config, then I can make that happen.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #536: TINKERPOP-1602 Support SSL client certificate authenti...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/536
  
Looks like I can copy GremlinServerIntegrateTest


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #537: TINKERPOP-1605 gremlin-console 3.2.3 -e can no longer ...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/537
  
Isn't there a distribution verification that does tests?  I know it's 
post-build, but that's better than nothing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #536: TINKERPOP-1602 Support SSL client certificate authenti...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/536
  
Tests added.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---