Re: Older Tomcat 6 archives
Forgot about the archives, I located them in : http://archive.apache.org/dist/tomcat/tomcat-6/ BTW, what about missing localized artifacts tomcat-i18n-xx for Tomcat 6.x in http://repo2.maven.org/maven2/org/apache/tomcat ? Thanks again 2010/9/16 Henri Gomez : > Hi to all, > > I wonder where I could find archives of the previously released Tomcat > 6 binaries ? > > Download links are for the latest 5.5, 6 and 7. > > I take a look at maven repo, > http://repo2.maven.org/maven2/org/apache/tomcat/ and here the > organization of artifacts is pretty strange. > > tomcat-i18n-xx for example are only available for 7.x > > The previous maven location, http://repo2.maven.org/maven2/tomcat/, is > for 5.0/5.5. > > Thanks > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Older Tomcat 6 archives
Hi to all, I wonder where I could find archives of the previously released Tomcat 6 binaries ? Download links are for the latest 5.5, 6 and 7. I take a look at maven repo, http://repo2.maven.org/maven2/org/apache/tomcat/ and here the organization of artifacts is pretty strange. tomcat-i18n-xx for example are only available for 7.x The previous maven location, http://repo2.maven.org/maven2/tomcat/, is for 5.0/5.5. Thanks - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: AsyncListeners and resource injection
On Sep 15, 2010, at 9:58 PM, David Jencks wrote:
> I think this is how AsyncContextImpl creates async listeners (lines 228ff)
>
>@Override
>public T createListener(Class clazz)
>throws ServletException {
>T listener = null;
>try {
> listener = clazz.newInstance();
>} catch (InstantiationException e) {
>ServletException se = new ServletException(e);
>throw se;
>} catch (IllegalAccessException e) {
>ServletException se = new ServletException(e);
>throw se;
>}
>return listener;
>}
>
>
>
> but the 3.0 spec section 15.5 page 179 says
>
> Annotations must be supported on the following container managed classes that
> implement the following interfaces and are declared in the web application
> deployment descriptor or using the annotations defined in Section 8.1,
> “Annotations and pluggability” on page 8-61 or added programmatically.
>
> and includes AsyncListener in the table following.
>
> So shouldn't this be using the instance manager to create the instance so the
> resource injection machinery can do its stuff?
>
>
> Secondly, if you do try to register an AsyncListener with the ServletContext
> so it can be scanned for annotations, aside from not actually scanning it, it
> quickly gets to this code (ApplicationContext lines 1262 ff)
>
>@Override
>public void addListener(T t) {
>if (!context.getState().equals(LifecycleState.STARTING_PREP)) {
>throw new IllegalStateException(
>sm.getString("applicationContext.addListener.ise",
>getContextPath()));
>}
>
>// TODO SERVLET3
>// throw UnsupportedOperationException - if this context was passed to
> the
>// {...@link
> ServletContextListener#contextInitialized(javax.servlet.ServletContextEvent)}
>// method of a {...@link ServletContextListener} that was not declared
>// in web.xml, a web-fragment or annotated with {...@link WebListener}.
>
>boolean match = false;
>if (t instanceof ServletContextAttributeListener ||
>t instanceof ServletRequestListener ||
>t instanceof ServletRequestAttributeListener ||
>t instanceof HttpSessionAttributeListener) {
>context.addApplicationEventListener(t);
>match = true;
>}
>
>if (t instanceof HttpSessionListener
>|| (t instanceof ServletContextListener &&
>newServletContextListenerAllowed)) {
>context.addApplicationLifecycleListener(t);
>match = true;
>}
>
>if (match) return;
>
>throw new IllegalArgumentException(sm.getString(
>"applicationContext.addListener.iae.wrongType",
>t.getClass().getName()));
>
>}
>
>
> which doesn't accept AsyncListeners. (of course it shouldn't do anything
> with then).
>
> Thoughts?
>
> thanks
> david jencks
>
BTW I opened bug 49937 with fixes that work for me for these problems.
david jencks
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49937] New: Problems with AsyncListener and resource injection
https://issues.apache.org/bugzilla/show_bug.cgi?id=49937 Summary: Problems with AsyncListener and resource injection Product: Tomcat 7 Version: trunk Platform: PC Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: djen...@apache.org Created an attachment (id=26031) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26031) propose fix for a couple possible async listener problems I asked about these on the dev list and am proposing some simple fixes in case there's agreement that they are bugs. 1. AsyncListeners are subject to resource injection from annotations, so they should be created using the instance manager. To get the instance manager to the AyncContextImpl I added a getInstanceManager() method to the Context interface. Maybe there's a better way, this interface is currently not very small or simple. 2. various application code can use one of the ServletContext.addListener methods to tell the container to scan for annotations. Just because tomcat doesn't yet actually scan doesn't mean it should throw an exception if you try this. cf servlet 3.0 spec section 15.5 page 179. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
AsyncListeners and resource injection
I think this is how AsyncContextImpl creates async listeners (lines 228ff)
@Override
public T createListener(Class clazz)
throws ServletException {
T listener = null;
try {
listener = clazz.newInstance();
} catch (InstantiationException e) {
ServletException se = new ServletException(e);
throw se;
} catch (IllegalAccessException e) {
ServletException se = new ServletException(e);
throw se;
}
return listener;
}
but the 3.0 spec section 15.5 page 179 says
Annotations must be supported on the following container managed classes that
implement the following interfaces and are declared in the web application
deployment descriptor or using the annotations defined in Section 8.1,
“Annotations and pluggability” on page 8-61 or added programmatically.
and includes AsyncListener in the table following.
So shouldn't this be using the instance manager to create the instance so the
resource injection machinery can do its stuff?
Secondly, if you do try to register an AsyncListener with the ServletContext
so it can be scanned for annotations, aside from not actually scanning it, it
quickly gets to this code (ApplicationContext lines 1262 ff)
@Override
public void addListener(T t) {
if (!context.getState().equals(LifecycleState.STARTING_PREP)) {
throw new IllegalStateException(
sm.getString("applicationContext.addListener.ise",
getContextPath()));
}
// TODO SERVLET3
// throw UnsupportedOperationException - if this context was passed to
the
// {...@link
ServletContextListener#contextInitialized(javax.servlet.ServletContextEvent)}
// method of a {...@link ServletContextListener} that was not declared
// in web.xml, a web-fragment or annotated with {...@link WebListener}.
boolean match = false;
if (t instanceof ServletContextAttributeListener ||
t instanceof ServletRequestListener ||
t instanceof ServletRequestAttributeListener ||
t instanceof HttpSessionAttributeListener) {
context.addApplicationEventListener(t);
match = true;
}
if (t instanceof HttpSessionListener
|| (t instanceof ServletContextListener &&
newServletContextListenerAllowed)) {
context.addApplicationLifecycleListener(t);
match = true;
}
if (match) return;
throw new IllegalArgumentException(sm.getString(
"applicationContext.addListener.iae.wrongType",
t.getClass().getName()));
}
which doesn't accept AsyncListeners. (of course it shouldn't do anything with
them).
Thoughts?
thanks
david jencks
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 42826] Connecting to tomcat failed. Tomcat is probably not started or is listening on the wrong port
https://issues.apache.org/bugzilla/show_bug.cgi?id=42826 --- Comment #2 from zawecha1 2010-09-15 23:53:17 EDT --- workers.properties set recovery_options=3 is fine。 解释： recovery_options属性说明了web server在检测到Tomcat失败后如何进行恢复工作。默认情况下，web server将转发请求给处于负载平衡模式中的另一个Tomcat。属性值为0，说明全部恢复；属性值为1，说明如果在Tomcat接到请求后出现失败状况，则不进行恢复；属性值为2，说明如果在Tomcat发送http头给客户端后出现失败状况，则不进行恢复；属性值为3，说明如果在Tomcat接到请求后出现失败状况或者在Tomcat发送http头给客户端后出现失败状况，则不进行恢复。此属性在jk 1.2.6版本被增加进来，以求避免Tomcat的死机和在支持ajp13的servlet引擎上发生的问题。此属性默认为全部恢复。 因在默认的情况下，JK检测tomcat的工作情况，所以浪费了很多资源，这个资源多到比tomcat正常工作所需的资源的1.6倍还多。如果不检测恢复，则效率高了，处理的请求数可以是原来的2.6倍多，而且tomcat还不死--没响应,反而使出错的数量比检测恢复之后出错的数量还少，性能还加强了，如果原来用这种的集群78台机器，有一阵就挂掉，改成这个配置只要30台机器，一般在同样的时间段内运行无反应或出错的情况比recovery_options使用默认值的少。 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] jdbc-pool 1.0.9.0
On 15 September 2010 14:55, Mark Thomas wrote: > It would be good to get an official release of jdbc-pool up on the > mirrors. If this vote passes, I'll add some appropriate pages to the web > site for docs, downloads etc. > > 1.0.9.0 fixes a small number of bugs reported against 1.0.8.5 both in > Bugzilla and through $work. > > The candidates source and binaries are available here: > http://people.apache.org/~markt/dev/jdbc-pool-v1.0.9.0/ > > According to the release process, the 1.0.9.0 tag is: > [ ] Broken > [ ] Alpha > [ ] Beta > [ ] Stable The tomcat-juli jar has N&L files in the META-INF directory, and the MANIFEST file has Specification and Implementation headers (and source/target JDK) However, none of the other jars contain the N & L files which ought to be present. Nor do the MANIFESTs contain the useful information which is present in the juli jar. It would be useful to have Javadoc in the binary archive. > > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49935] recursive tag calls don't work
https://issues.apache.org/bugzilla/show_bug.cgi?id=49935 Eric Westfall changed: What|Removed |Added CC||ewest...@indiana.edu -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Async refactoring
On 12/09/2010 17:45, Mark Thomas wrote: > Digging into the root causes of [1] it appears that there are a number > of threading / timing issues with the current AsyncContextImpl. Running > the provided test case with ab -n 50 -c 20 triggers the error every > couple of runs. The error appears to occur when the thread where > complete() is called finishes before the thread where startAsync() is > called. > At the moment [2] is in a very rough and ready state and only handles > startAsync() and complete() for the BIO HTTP connector. I wanted to give > folks early sight of this patch so I could incorporate any early feedback. > > I plan to expand the patch to cover dispatch(), timeouts, the other > connectors, passing our test cases and passing the TCK before > committing. I'm not sure how long that will take. I hope to get this > done this week. > > [1] https://issues.apache.org/bugzilla/show_bug.cgi?id=49884 > [2] > http://people.apache.org/~markt/patches/2010-09-12-async-refactoring.patch Just to keep folks in the loop. The latest patch [3] is now available for you to take a look at. It now handles timeouts and passes all our tests cases. It even does pretty well with the TCK. In further testing of [1] I came across an edge case that required adding a lock to the SocketWrapper. Without this requests could get lost and end up timing out when they should have been processed. Performance-wise this doesn't appear to add any noticeable cost. My plan is still to get this fully working for BIO HTTP before extending it to the other connectors. Still on the to do list for BIO HTTP are: - checking dispatches work (need to add some test cases for this) - fixing timeouts (I know these are broken) - error handling (largely commented out at the moment) I don't want to commit this incrementally since that will just trigger a deluge of failed test reports from Gump and buildbot. If folks would prefer a more incremental approach and can live with the nags for a few weeks, I'm happy to commit rather than provide patches for review. Mark [3] http://people.apache.org/~markt/patches/2010-09-15-async-refactoring.patch - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49935] recursive tag calls don't work
https://issues.apache.org/bugzilla/show_bug.cgi?id=49935 --- Comment #1 from Peter Giles 2010-09-15 18:28:01 EDT --- Created an attachment (id=26029) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26029) image showing how the page renders on other versions of Tomcat -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49935] New: recursive tag calls don't work
https://issues.apache.org/bugzilla/show_bug.cgi?id=49935 Summary: recursive tag calls don't work Product: Tomcat 5 Version: 5.5.30 Platform: PC OS/Version: Linux Status: NEW Severity: major Priority: P2 Component: Jasper AssignedTo: dev@tomcat.apache.org ReportedBy: gil...@u.washington.edu Created an attachment (id=26028) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26028) web app demonstrating the issue If a tag calls itself recursively, it doesn't work in Tomcat 5.5.30. This has been observed on Linux, but (for whatever reasons) may not manifest on other operating systems. I specifically reproduced the issue using java version "1.6.0_20" Java(TM) SE Runtime Environment (build 1.6.0_20-b02) Java HotSpot(TM) 64-Bit Server VM (build 16.3-b01, mixed mode) I'm attaching a simple war that renders (at the context root) a page with a recursive table structure on other versions of Tomcat (I tried 5.5.28 & 6.0.29), but not in 5.5.30. Similar tag calls in our application have resulted in the following stack trace on this Tomcat version: 2010-09-15 00:07:43,031 [http-8080-Processor24] ERROR org.apache.catalina.core.ContainerBase.[Catalina].[localhost].[/kr-dev].[jsp] - Servlet.service() for servlet jsp threw exception java.io.FileNotFoundException: no such file: /java/servers/apache-tomcat-5.5.30/work/Catalina/localhost/kr-dev/org/apache/jsp/tag/web/kr/rowDisplay_tag$Helper.class at org.apache.jasper.compiler.SmapUtil$SDEInstaller.(SmapUtil.java:253) at org.apache.jasper.compiler.SmapUtil$SDEInstaller.install(SmapUtil.java:241) at org.apache.jasper.compiler.SmapUtil.installSmap(SmapUtil.java:165) at org.apache.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java:466) at org.apache.jasper.compiler.Compiler.compile(Compiler.java:319) at org.apache.jasper.compiler.Compiler.compile(Compiler.java:298) at org.apache.jasper.compiler.Compiler.compile(Compiler.java:286) at org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:565) at org.apache.jasper.servlet.JspServletWrapper.loadTagFile(JspServletWrapper.java:207) at org.apache.jasper.compiler.TagFileProcessor.loadTagFile(TagFileProcessor.java:566) at org.apache.jasper.compiler.TagFileProcessor.access$000(TagFileProcessor.java:50) at org.apache.jasper.compiler.TagFileProcessor$TagFileLoaderVisitor.visit(TagFileProcessor.java:617) at org.apache.jasper.compiler.Node$CustomTag.accept(Node.java:1442) at org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2166) at org.apache.jasper.compiler.Node$Visitor.visitBody(Node.java:2216) at org.apache.jasper.compiler.TagFileProcessor$TagFileLoaderVisitor.visit(TagFileProcessor.java:621) at org.apache.jasper.compiler.Node$CustomTag.accept(Node.java:1442) at org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2166) at org.apache.jasper.compiler.Node$Visitor.visitBody(Node.java:2216) at org.apache.jasper.compiler.TagFileProcessor$TagFileLoaderVisitor.visit(TagFileProcessor.java:621) at org.apache.jasper.compiler.Node$CustomTag.accept(Node.java:1442) at org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2166) at org.apache.jasper.compiler.Node$Visitor.visitBody(Node.java:2216) at org.apache.jasper.compiler.Node$Visitor.visit(Node.java:) at org.apache.jasper.compiler.Node$Root.accept(Node.java:457) at org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2166) at org.apache.jasper.compiler.TagFileProcessor.loadTagFiles(TagFileProcessor.java:635) at org.apache.jasper.compiler.Compiler.generateJava(Compiler.java:200) at org.apache.jasper.compiler.Compiler.compile(Compiler.java:317) at org.apache.jasper.compiler.Compiler.compile(Compiler.java:298) at org.apache.jasper.compiler.Compiler.compile(Compiler.java:286) at org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:565) at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:309) at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:308) at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:259) at javax.servlet.http.HttpServlet.service(HttpServlet.java:729) ... -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Attempting to run tomcat 7 in eclipse.
On 15/09/2010 22:07, Wesley Acheson wrote: > Okay a last questions in this case. Also please note works pretty > hetic at the moment. If theres multiple changes to be made it may take > some time. No problem. We are all volunteers here. > On Wed, Sep 15, 2010 at 9:56 PM, Mark Thomas wrote: >> On 15/09/2010 20:44, Wesley Acheson wrote: > 6 I received an error that two jar files were missing "c:\usr\share\java\wsdl4j-1.6.1\wsdl4j-1.6.1.jar" and "c:\usr\share\java\jaxrpc-1.1-rc4\geronimo-spec-jaxrpc-1.1-rc4.jar" >> That is for an optional module. I normally exclude that part of the >> source tree. Or you can run the full build and you'll get the modules. >> > Whats the target for full build? Is this not contradicted by your below > answer? ant release 7 Downloaded those two jar files from a maven repository and placed in the set location. >> The script will handle that. You need the "extras-webservices-prepare" >> target. This is the minimum target to get those libs. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Attempting to run tomcat 7 in eclipse.
On 15/09/2010 22:32, Wesley Acheson wrote: >> 2 Tried "ant download" as per http://tomcat.apache.org/tomcat-7.0-doc/building.html#Building%20Tomcat. Apparently there is no target called "download" >> Already fixed in svn. > > In trunk? because I just tried a fresh checkout doesn't seem to have > that target. No, the docs have already been fixed to remove references to that target. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Attempting to run tomcat 7 in eclipse.
> >>> 2 Tried "ant download" as per >>> http://tomcat.apache.org/tomcat-7.0-doc/building.html#Building%20Tomcat. >>> Apparently there is no target called "download" > Already fixed in svn. In trunk? because I just tried a fresh checkout doesn't seem to have that target. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Attempting to run tomcat 7 in eclipse.
Okay a last questions in this case. Also please note works pretty hetic at the moment. If theres multiple changes to be made it may take some time. On Wed, Sep 15, 2010 at 9:56 PM, Mark Thomas wrote: > On 15/09/2010 20:44, Wesley Acheson wrote: >>> 6 I received an error that two jar files were missing >>> "c:\usr\share\java\wsdl4j-1.6.1\wsdl4j-1.6.1.jar" and >>> "c:\usr\share\java\jaxrpc-1.1-rc4\geronimo-spec-jaxrpc-1.1-rc4.jar" > That is for an optional module. I normally exclude that part of the > source tree. Or you can run the full build and you'll get the modules. > Whats the target for full build? Is this not contradicted by your below answer? >>> 7 Downloaded those two jar files from a maven repository and placed in >>> the set location. > The script will handle that. You need the "extras-webservices-prepare" > target. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Draft blog entry for review
It may be worth showing some code as well on how to start tomcat and use JMX to configure it. Maybe in a separate post. Costin On Wed, Sep 15, 2010 at 1:10 PM, Sylvain Laurent wrote: > you could add a word on persistence of the JMX configuration. As far as I > understand, the modifications done through JMX are not persisted, is that > correct ? > > Sylvain > > On 15 sept. 2010, at 17:07, Mark Thomas wrote: > > > As I mention recently, JMX is now looking pretty good. I have drafted a > > blog entry [1] on this topic that I'd like to publish later this week. > > Review / feedback welcome. > > > > Mark > > > > [1] > > > https://blogs.apache.org/preview/tomcat/?previewEntry=tomcat_7_trunk_and_jmx > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > > For additional commands, e-mail: dev-h...@tomcat.apache.org > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
Re: Draft blog entry for review
you could add a word on persistence of the JMX configuration. As far as I understand, the modifications done through JMX are not persisted, is that correct ? Sylvain On 15 sept. 2010, at 17:07, Mark Thomas wrote: > As I mention recently, JMX is now looking pretty good. I have drafted a > blog entry [1] on this topic that I'd like to publish later this week. > Review / feedback welcome. > > Mark > > [1] > https://blogs.apache.org/preview/tomcat/?previewEntry=tomcat_7_trunk_and_jmx > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Catching throwable.
On 11/09/2010 00:45, Wesley Acheson wrote: > I'm looking through the source now where I'm seeing a lot of > Throwables caught. I was always told this was bad practice is there a > reason for this? Some I could understand but there seems to be places > where throwable is caught even though the javadocs say it throws an > exception. And by your handling of the throwable it looks like you > know what to expect the throwable to be. > > Just getting my head arround it. Usually as a short-cut. Sometimes it is reasonable, sometimes not. I thought we had caught all the ones that mattered in a bug fix a few months ago. There may be some left. ExceptionUtils is the way to handle them. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Attempting to run tomcat 7 in eclipse.
On 15/09/2010 20:44, Wesley Acheson wrote: > Was there something wrong with this question? Nope. Answers in-line. >> I think the documentation in tomcat 7 about building tomcat is >> incorrect or out of date. Yep. >> 1 Checkout from http://svn.apache.org/repos/asf/tomcat/trunk. This was >> the location given to me on the mailing list. Correct. >> 2 Tried "ant download" as per >> http://tomcat.apache.org/tomcat-7.0-doc/building.html#Building%20Tomcat. >> Apparently there is no target called "download" Already fixed in svn. >> 3 Tried the following ant targets in the following order >> "download-compile" "download-test-compile", "download-dist", >> "download-validate". Finally ant with no arguments. That's the one. >> 4 Renamed "eclipse.project" and "eclipse.classpath" to ".project" and >> ".eclipse". Need to add that. >> 5 Launched eclipse, added in classpath variables, as per documentation >> >> 6 I received an error that two jar files were missing >> "c:\usr\share\java\wsdl4j-1.6.1\wsdl4j-1.6.1.jar" and >> "c:\usr\share\java\jaxrpc-1.1-rc4\geronimo-spec-jaxrpc-1.1-rc4.jar" That is for an optional module. I normally exclude that part of the source tree. Or you can run the full build and you'll get the modules. >> 7 Downloaded those two jar files from a maven repository and placed in >> the set location. The script will handle that. You need the "extras-webservices-prepare" target. >> Now I'm stuck the instructions say 'enter >> "org.apache.catalina.startup.Catalina" as the main class, "start" as >> program arguments, and "-Dcatalina.home=..." (with the name of your >> build directory) as VM arguments.' >> >> However there doesn't seem to be a main method in Catalina.java, I've >> changed this to "org.apache.catalina.startup.Bootstrap" is that >> correct? It appears to launch. Yep. I deleted the main method from Catalina. >> So there are the following definite problems with the documentation. >> The main class is wrong. The ant targets are wrong. Possibly missing a >> step for downloading jars (Though I suspect thats just a badly >> configured classpath). >> >> Is this the "correct" way to run TC7? Do you want a bug on this? If >> you let me know where the documentation is I'll enter a patch >> (assuming documentation is in SVN). Yes, yes, yes. http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/building.xml?view=log You may also want to take a look at http://svn.apache.org/viewvc/tomcat/trunk/BUILDING.txt?view=log Everything required to build Tomcat from source is in svn. You can also do it from a source bundle if you wish. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Attempting to run tomcat 7 in eclipse.
Was there something wrong with this question? Or the one about catching throwable, okay I might not be the most knowledgeable but I'm trying to help, in general. On Tue, Sep 14, 2010 at 11:10 AM, Wesley Acheson wrote: > Hi > > I think the documentation in tomcat 7 about building tomcat is > incorrect or out of date. > > I've tried to get it running in eclipse using the following steps. > > 1 Checkout from http://svn.apache.org/repos/asf/tomcat/trunk. This was > the location given to me on the mailing list. > > 2 Tried "ant download" as per > http://tomcat.apache.org/tomcat-7.0-doc/building.html#Building%20Tomcat. > Apparently there is no target called "download" > > 3 Tried the following ant targets in the following order > "download-compile" "download-test-compile", "download-dist", > "download-validate". Finally ant with no arguments. > > 4 Renamed "eclipse.project" and "eclipse.classpath" to ".project" and > ".eclipse". > > 5 Launched eclipse, added in classpath variables, as per documentation > > 6 I received an error that two jar files were missing > "c:\usr\share\java\wsdl4j-1.6.1\wsdl4j-1.6.1.jar" and > "c:\usr\share\java\jaxrpc-1.1-rc4\geronimo-spec-jaxrpc-1.1-rc4.jar" > > 7 Downloaded those two jar files from a maven repository and placed in > the set location. > > Now I'm stuck the instructions say 'enter > "org.apache.catalina.startup.Catalina" as the main class, "start" as > program arguments, and "-Dcatalina.home=..." (with the name of your > build directory) as VM arguments.' > > STOP PRESS > > However there doesn't seem to be a main method in Catalina.java, I've > changed this to "org.apache.catalina.startup.Bootstrap" is that > correct? It appears to launch. > > So there are the following definite problems with the documentation. > The main class is wrong. The ant targets are wrong. Possibly missing a > step for downloading jars (Though I suspect thats just a badly > configured classpath). > > Is this the "correct" way to run TC7? Do you want a bug on this? If > you let me know where the documentation is I'll enter a patch > (assuming documentation is in SVN). > > Regards, > > Wesley > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: JSP:includes parameter passing vulnerability
Thanks for your replay. Will do. Moving conversation to user list. Michael Coates OWASP On 9/15/10 11:59 AM, Tim Funk wrote: > There is no issue. If there is a typo in the developer code, there is > a typo in the code. And sometimes typos cause security issues. As a > general rule, any code which is user provided should validated and > output escaped. > > This is a topic which should be discussed on the user list. > > -Tim > > On 9/15/2010 2:36 PM, Michael Coates wrote: >> >> Tomcat list, >> >> >> It seems to me that the method used to request parameters from an >> included jsp file should not "fail over" to the URL if the jsp:include >> does not provide the parameter. > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: JSP:includes parameter passing vulnerability
There is no issue. If there is a typo in the developer code, there is a typo in the code. And sometimes typos cause security issues. As a general rule, any code which is user provided should validated and output escaped. This is a topic which should be discussed on the user list. -Tim On 9/15/2010 2:36 PM, Michael Coates wrote: Tomcat list, It seems to me that the method used to request parameters from an included jsp file should not "fail over" to the URL if the jsp:include does not provide the parameter. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [ANN] Apache Tomcat Connectors 1.2.30 released
On 09/15/2010 05:10 PM, William A. Rowe Jr. wrote: On 9/14/2010 5:48 PM, Rainer Jung wrote: Sounds like consensus suggests a next connector release, then branch 1.2.x for maintenance, and axe ancient servers and connection code such as ajp12 from the post-1.2 trunk for some future 1.3 connector releases. Thanks all. OK, so we can create 1.2.x branch from which further 1.2.xx releases will be cut, and promote a trunk to 1.3.x But the tcnative connector and similar could also have version resources for identification. tcnative has that from day one (version in .rc file) (although maintained by hand, rather then from tcn_version.h) Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Draft blog entry for review
Looks good. It would be really cool to supplement this with a YouTube video of a screen walking through the steps laid out while playing with JConsole. -Tim On 9/15/2010 11:07 AM, Mark Thomas wrote: As I mention recently, JMX is now looking pretty good. I have drafted a blog entry [1] on this topic that I'd like to publish later this week. Review / feedback welcome. Mark [1] https://blogs.apache.org/preview/tomcat/?previewEntry=tomcat_7_trunk_and_jmx - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49234] JMX Descriptor Modifications
https://issues.apache.org/bugzilla/show_bug.cgi?id=49234 --- Comment #95 from Mark Thomas 2010-09-15 11:33:48 EDT --- Now might be a good time to resolve this issue as FIXED and move to using separate issues for any future improvements. That would keep this issue as an archive of your GSOC work. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [ANN] Apache Tomcat Connectors 1.2.30 released
On 9/14/2010 5:48 PM, Rainer Jung wrote: > On 14.09.2010 01:14, William A. Rowe Jr. wrote: >> On 9/13/2010 6:11 PM, Tim Whittington wrote: >>> I agree with this approach. >>> >>> I'd like to get a 1.2.31 release out sometime to release the ISAPI >>> Redirector log rotation though, before we start on 1.3. >> >> Just to make sure there is no confusion, I'm speaking of dropping apache-1.3, >> prior to 1.2.31, or a fresh trunk/ for connectors-1.3 work. > > I agree on the latter, i.e. not removing the old cruft in the 1.2.x release > series, but > soon starting a mod_jk 1.3.x series with removed cruft. I'm fine with doing > 1.2.31 before > branching if e.g. Tim can finish what he wants to add in a few weeks. Sounds like consensus suggests a next connector release, then branch 1.2.x for maintenance, and axe ancient servers and connection code such as ajp12 from the post-1.2 trunk for some future 1.3 connector releases. Thanks all. I will still ignore dll/so module versioning for the ancients, e.g. apache 1.3 on win32 has been strongly discouraged for a decade, and jk_nt_service is long abandoned :) But the tcnative connector and similar could also have version resources for identification. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Draft blog entry for review
As I mention recently, JMX is now looking pretty good. I have drafted a blog entry [1] on this topic that I'd like to publish later this week. Review / feedback welcome. Mark [1] https://blogs.apache.org/preview/tomcat/?previewEntry=tomcat_7_trunk_and_jmx - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48584] Error or ACCESS_VIOLATION on shutdown
https://issues.apache.org/bugzilla/show_bug.cgi?id=48584 Peter changed: What|Removed |Added Version|1.1.19 |1.1.20 OS/Version|Windows XP |Windows 7 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] jdbc-pool 1.0.9.0
On 15/09/2010 14:55, Mark Thomas wrote: > It would be good to get an official release of jdbc-pool up on the > mirrors. If this vote passes, I'll add some appropriate pages to the web > site for docs, downloads etc. > > 1.0.9.0 fixes a small number of bugs reported against 1.0.8.5 both in > Bugzilla and through $work. > > The candidates source and binaries are available here: > http://people.apache.org/~markt/dev/jdbc-pool-v1.0.9.0/ > > According to the release process, the 1.0.9.0 tag is: > [ ] Broken > [ ] Alpha > [ ] Beta > [X] Stable All files have LICENSE & NOTICE Good sigs Key in web of trust Tests all pass -src.zip != -src.tar.gz zip contains an additional empty directory -> Not an issue. -src.zip != svn tag Eclipse files not included in -src.zip -> Not an issue. sign.sh not included in -src.zip -> Not an issue. Auto-generated META-INF not included in tag -> Not an issue. It might be nice to clean things up so that an export of the tag was completely identical to the src download but I don't view any of the above as show stoppers. $work as been shipping jdbc-pool as the default connection pool in a number of products (rather than DBCP) for some time with relatively few reported issues. All of the issues reported through $work and through Bugzilla have been fixed in this release. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r997341 - /tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/interceptor/
Author: markt Date: Wed Sep 15 14:03:13 2010 New Revision: 997341 URL: http://svn.apache.org/viewvc?rev=997341&view=rev Log: Remove empty dir Removed: tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/interceptor/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[VOTE] jdbc-pool 1.0.9.0
It would be good to get an official release of jdbc-pool up on the mirrors. If this vote passes, I'll add some appropriate pages to the web site for docs, downloads etc. 1.0.9.0 fixes a small number of bugs reported against 1.0.8.5 both in Bugzilla and through $work. The candidates source and binaries are available here: http://people.apache.org/~markt/dev/jdbc-pool-v1.0.9.0/ According to the release process, the 1.0.9.0 tag is: [ ] Broken [ ] Alpha [ ] Beta [ ] Stable - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r997332 - /tomcat/tags/JDBC_POOL_1_0_9_0/
Author: markt Date: Wed Sep 15 13:41:18 2010 New Revision: 997332 URL: http://svn.apache.org/viewvc?rev=997332&view=rev Log: Tag 1.0.9.0 Added: tomcat/tags/JDBC_POOL_1_0_9_0/ (props changed) - copied from r997331, tomcat/trunk/modules/jdbc-pool/ Propchange: tomcat/tags/JDBC_POOL_1_0_9_0/ -- --- svn:ignore (added) +++ svn:ignore Wed Sep 15 13:41:18 2010 @@ -0,0 +1,3 @@ +build.properties +includes +output Propchange: tomcat/tags/JDBC_POOL_1_0_9_0/ -- svn:mergeinfo = /tomcat/tc6.0.x/trunk/modules/jdbc-pool:742915 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r997331 - /tomcat/trunk/modules/jdbc-pool/build.xml
Author: markt Date: Wed Sep 15 13:39:08 2010 New Revision: 997331 URL: http://svn.apache.org/viewvc?rev=997331&view=rev Log: Fix niggle Modified: tomcat/trunk/modules/jdbc-pool/build.xml Modified: tomcat/trunk/modules/jdbc-pool/build.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/build.xml?rev=997331&r1=997330&r2=997331&view=diff == --- tomcat/trunk/modules/jdbc-pool/build.xml (original) +++ tomcat/trunk/modules/jdbc-pool/build.xml Wed Sep 15 13:39:08 2010 @@ -33,7 +33,7 @@ - + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r997329 - /tomcat/trunk/modules/jdbc-pool/build.xml
Author: markt Date: Wed Sep 15 13:34:42 2010 New Revision: 997329 URL: http://svn.apache.org/viewvc?rev=997329&view=rev Log: Include the suffix in the version number Modified: tomcat/trunk/modules/jdbc-pool/build.xml Modified: tomcat/trunk/modules/jdbc-pool/build.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/build.xml?rev=997329&r1=997328&r2=997329&view=diff == --- tomcat/trunk/modules/jdbc-pool/build.xml (original) +++ tomcat/trunk/modules/jdbc-pool/build.xml Wed Sep 15 13:34:42 2010 @@ -33,7 +33,7 @@ - + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r997326 - /tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
Author: markt
Date: Wed Sep 15 13:29:47 2010
New Revision: 997326
URL: http://svn.apache.org/viewvc?rev=997326&view=rev
Log:
Fix Javadoc
Modified:
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
Modified:
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java?rev=997326&r1=997325&r2=997326&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
Wed Sep 15 13:29:47 2010
@@ -604,7 +604,7 @@ public class ConnectionPool {
/**
* Creates a JDBC connection and tries to connect to the database.
* @param now timestamp of when this was called
- * @param con the previous pooled connection - argument not used
+ * @param notUsed Argument not used
* @return a PooledConnection that has been connected
* @throws SQLException
*/
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49584] Borrowers Getting Stuck
https://issues.apache.org/bugzilla/show_bug.cgi?id=49584 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #2 from Mark Thomas 2010-09-15 09:26:22 EDT --- Fixed in trunk and will be included in 1.0.9.0 onwards -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r997323 - /tomcat/trunk/modules/jdbc-pool/doc/changelog.xml
Author: markt Date: Wed Sep 15 13:26:12 2010 New Revision: 997323 URL: http://svn.apache.org/viewvc?rev=997323&view=rev Log: Update changelog Modified: tomcat/trunk/modules/jdbc-pool/doc/changelog.xml Modified: tomcat/trunk/modules/jdbc-pool/doc/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/doc/changelog.xml?rev=997323&r1=997322&r2=997323&view=diff == --- tomcat/trunk/modules/jdbc-pool/doc/changelog.xml (original) +++ tomcat/trunk/modules/jdbc-pool/doc/changelog.xml Wed Sep 15 13:26:12 2010 @@ -31,6 +31,9 @@ + 997321 Ensure threads borrowing connections do not + get stuck waiting for a new connection if a connection is released in + another thread. (markt) 995432 Make interceptor class names, property names and property values tolerant of whitespace by trimming the values before use. (markt) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r997321 - /tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
Author: markt
Date: Wed Sep 15 13:24:14 2010
New Revision: 997321
URL: http://svn.apache.org/viewvc?rev=997321&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49584
Move the offering of a new thread on release from the abandoned connection code
to the release code to eliminate the possibility of a blocked thread on release.
Modified:
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
Modified:
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java?rev=997321&r1=997320&r2=997321&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
Wed Sep 15 13:24:14 2010
@@ -466,9 +466,6 @@ public class ConnectionPool {
}
//release the connection
release(con);
-//we've asynchronously reduced the number of connections
-//we could have threads stuck in idle.poll(timeout) that will
never be notified
-if (waitcount.get()>0) idle.offer(new
PooledConnection(poolProperties,this));
} finally {
con.unlock();
}
@@ -517,6 +514,12 @@ public class ConnectionPool {
} finally {
con.unlock();
}
+// we've asynchronously reduced the number of connections
+// we could have threads stuck in idle.poll(timeout) that will never be
+// notified
+if (waitcount.get() > 0) {
+idle.offer(new PooledConnection(poolProperties, this));
+}
}
/**
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [ANN] Apache Tomcat Connectors 1.2.30 released
Why? The fact that the ASF has retired httpd-1.3 doesn't mean that the world has stopped using it, or *will* stop using it before the next connectors release. On Sep 13, 2010, at 5:15 PM, William A. Rowe Jr. wrote: > On 3/1/2010 4:45 AM, Mladen Turk wrote: >> The Apache Tomcat team announces the immediate availability of >> Apache Tomcat Connectors 1.2.30 stable. > > With this release, following the retirement of httpd-1.3 from all maintenance, > would this be a good time to declare this the final native/apache-1.3/ > connector > and remove that tree from svn at this point, prior to any 1.3.31 release? > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[RESULT] Re: [VOTE] Release Tomcat 5.5.31 Build
On Sep 8, 2010, at 10:50 AM, Jim Jagielski wrote: > The builds for Tomcat 5.5.31 are ready for testing and approval. > The candidates binaries are available here: > > http://people.apache.org/~jim/tomcat-5.5/ > > According to the release process, the 5.5.31 build corresponding to the > tag TOMCAT_5_5_31 [1] is: > > [ ] Broken > [ ] Alpha > [ ] Beta > [ ] Stable > +++ > > 1. http://svn.apache.org/viewvc/tomcat/tc5.5.x/tags/TOMCAT_5_5_31/ > +1-Stable: jim, rainer, mladen, markt Once I finish jury duty I will push and announce the release! Thx to all. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49584] Borrowers Getting Stuck
https://issues.apache.org/bugzilla/show_bug.cgi?id=49584 --- Comment #1 from Mark Thomas 2010-09-15 07:43:12 EDT --- (In reply to comment #0) > There is also an issue with connection create failing causing the pool size to > be incremented but not decremented. In the borrowConnection method the pool > size is incremented. However, if an exception occurs in the createConnection > method releaseConnection can be called with a null argument and the pool size > is not decremented. I've looked at the code and I can't see a code path where con could be null. I refactored the code to make this clearer. I'll look at the other issue next. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r997291 - /tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
Author: markt
Date: Wed Sep 15 11:42:55 2010
New Revision: 997291
URL: http://svn.apache.org/viewvc?rev=997291&view=rev
Log:
Address a concern raised in
https://issues.apache.org/bugzilla/show_bug.cgi?id=49584
Re-factor code to clarify con is never null when release is called.
Modified:
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
Modified:
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java?rev=997291&r1=997290&r2=997291&view=diff
==
---
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
Wed Sep 15 11:42:55 2010
@@ -605,12 +605,13 @@ public class ConnectionPool {
* @return a PooledConnection that has been connected
* @throws SQLException
*/
-protected PooledConnection createConnection(long now, PooledConnection
con) throws SQLException {
+protected PooledConnection createConnection(long now,
+PooledConnection notUsed) throws SQLException {
//no connections where available we'll create one
+PooledConnection con = create();
boolean error = false;
try {
//connect and validate the connection
-con = create();
con.lock();
con.connect();
if (con.validate(PooledConnection.VALIDATE_INIT)) {
@@ -640,6 +641,7 @@ public class ConnectionPool {
throw ex;
}
} finally {
+// con can never be null here
if (error ) {
release(con);
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49890] Nio Selector issue on linux platform
https://issues.apache.org/bugzilla/show_bug.cgi?id=49890 Andrey Timofeev changed: What|Removed |Added Priority|P2 |P3 Severity|normal |major -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
