[Bug 56529] NoSuchElementException for attribute with empty string in custom tag
https://issues.apache.org/bugzilla/show_bug.cgi?id=56529 --- Comment #4 from Violeta Georgieva --- Small correction: the fix is in 8.0.8 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Update of "ContributorsGroup" by KonstantinKolinko
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "ContributorsGroup" page has been changed by KonstantinKolinko: https://wiki.apache.org/tomcat/ContributorsGroup?action=diff&rev1=23&rev2=24 Comment: Add CoreyNorthcutt to contributors group * GaryBriggs * SiegfriedGoeschl * OgnjenBlagojevic + * CoreyNorthcutt - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1594870 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/naming/ContextAccessController.java webapps/docs/changelog.xml
Author: markt
Date: Thu May 15 11:30:46 2014
New Revision: 1594870
URL: http://svn.apache.org/r1594870
Log:
Require RuntimePermission when introducing a new token. (kkolinko)
Modified:
tomcat/tc6.0.x/trunk/ (props changed)
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/java/org/apache/naming/ContextAccessController.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
Propchange: tomcat/tc6.0.x/trunk/
--
Merged /tomcat/trunk:r1589763,1589837,1589842,1589980,1590648,1594229
Merged /tomcat/tc7.0.x/trunk:r1588997,1589851,1589997,1590028,1590651,1594230
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1594870&r1=1594869&r2=1594870&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Thu May 15 11:30:46 2014
@@ -28,11 +28,6 @@ None
PATCHES PROPOSED TO BACKPORT:
[ New proposals should be added at the end of the list ]
-* Require RuntimePermission when introducing a new token.
- https://svn.apache.org/r1594230
- +1: kkolinko, remm, markt
- -1:
-
PATCHES/ISSUES THAT ARE STALLED:
Modified:
tomcat/tc6.0.x/trunk/java/org/apache/naming/ContextAccessController.java
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/naming/ContextAccessController.java?rev=1594870&r1=1594869&r2=1594870&view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/naming/ContextAccessController.java
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/naming/ContextAccessController.java
Thu May 15 11:30:46 2014
@@ -55,6 +55,12 @@ public class ContextAccessController {
* @param token Security token
*/
public static void setSecurityToken(Object name, Object token) {
+SecurityManager sm = System.getSecurityManager();
+if (sm != null) {
+sm.checkPermission(new RuntimePermission(
+ContextAccessController.class.getName()
++ ".setSecurityToken"));
+}
if ((!securityTokens.containsKey(name)) && (token != null)) {
securityTokens.put(name, token);
}
Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=1594870&r1=1594869&r2=1594870&view=diff
==
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Thu May 15 11:30:46 2014
@@ -115,8 +115,8 @@
when running under a security manager. (markt)
-Make the naming context tokens for containers more robust.
-(markt/kkolinko)
+Make the naming context tokens for containers more robust. Require
+RuntimePermission when introducing a new token. (markt/kkolinko)
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1595230 - in /tomcat/trunk/test: org/apache/jasper/compiler/TestGenerator.java webapp/WEB-INF/bugs.tld webapp/bug5nnnn/bug56529.jsp
Author: violetagg
Date: Fri May 16 15:24:08 2014
New Revision: 1595230
URL: http://svn.apache.org/r1595230
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56529
Test case for attributes with empty string values in custom tags.
Added:
tomcat/trunk/test/webapp/bug5/bug56529.jsp (with props)
Modified:
tomcat/trunk/test/org/apache/jasper/compiler/TestGenerator.java
tomcat/trunk/test/webapp/WEB-INF/bugs.tld
Modified: tomcat/trunk/test/org/apache/jasper/compiler/TestGenerator.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/jasper/compiler/TestGenerator.java?rev=1595230&r1=1595229&r2=1595230&view=diff
==
--- tomcat/trunk/test/org/apache/jasper/compiler/TestGenerator.java (original)
+++ tomcat/trunk/test/org/apache/jasper/compiler/TestGenerator.java Fri May 16
15:24:08 2014
@@ -18,6 +18,7 @@
package org.apache.jasper.compiler;
import java.io.File;
+import java.io.IOException;
import java.util.Date;
import java.util.HashMap;
import java.util.List;
@@ -33,6 +34,7 @@ import javax.servlet.jsp.tagext.Variable
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
+import org.junit.Assert;
import org.junit.Test;
import org.apache.catalina.WebResourceRoot;
@@ -256,4 +258,57 @@ public class TestGenerator extends Tomca
private static void assertEcho(String result, String expected) {
assertTrue(result.indexOf("" + expected + "") > 0);
}
+
+@Test
+public void testBug56529() throws Exception {
+Tomcat tomcat = getTomcatInstance();
+
+File appDir = new File("test/webapp");
+// app dir is relative to server home
+tomcat.addWebapp(null, "/test", appDir.getAbsolutePath());
+
+tomcat.start();
+
+ByteChunk bc = new ByteChunk();
+int rc = getUrl("http://localhost:"; + getPort() +
+"/test/bug5/bug56529.jsp", bc, null);
+Assert.assertEquals(HttpServletResponse.SC_OK, rc);
+ }
+
+public static class Bug56529 extends TagSupport {
+
+private static final long serialVersionUID = 1L;
+
+private String attribute1 = null;
+
+private String attribute2 = null;
+
+public void setAttribute1(String attribute1) {
+this.attribute1 = attribute1;
+}
+
+public String getAttribute1() {
+return attribute1;
+}
+
+public void setAttribute2(String attribute2) {
+this.attribute2 = attribute2;
+}
+
+public String getAttribute2() {
+return attribute2;
+}
+
+@Override
+public int doEndTag() throws JspException {
+try {
+pageContext.getOut().println("attribute1: " + attribute1);
+pageContext.getOut().println("attribute2: " + attribute2);
+} catch (IOException e) {
+throw new JspException(e);
+}
+return EVAL_PAGE;
+}
+
+}
}
Modified: tomcat/trunk/test/webapp/WEB-INF/bugs.tld
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/webapp/WEB-INF/bugs.tld?rev=1595230&r1=1595229&r2=1595230&view=diff
==
--- tomcat/trunk/test/webapp/WEB-INF/bugs.tld (original)
+++ tomcat/trunk/test/webapp/WEB-INF/bugs.tld Fri May 16 15:24:08 2014
@@ -65,6 +65,20 @@
AT_END
+
+Bug56529
+org.apache.jasper.compiler.TestGenerator$Bug56529
+JSP
+
+ attribute1
+ true
+ true
+
+
+ attribute2
+ true
+
+
bug49555
org.apache.el.TesterFunctions$Inner$Class
Added: tomcat/trunk/test/webapp/bug5/bug56529.jsp
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/webapp/bug5/bug56529.jsp?rev=1595230&view=auto
==
--- tomcat/trunk/test/webapp/bug5/bug56529.jsp (added)
+++ tomcat/trunk/test/webapp/bug5/bug56529.jsp Fri May 16 15:24:08 2014
@@ -0,0 +1,24 @@
+<%--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+--%>
+<%@ taglib uri="http://tomcat.apache.org/bugs"; prefix="bugs" %
[GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-test : Tomcat 8.x, a web server implementing the Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.native.src.tgz. -DEBUG- Dependency on commons-daemon exists, no need to add for property tomcat-native.tar.gz. -DEBUG- Dependency on tomcat-trunk exists, no need to add for property tomcat-dbcp.home. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/build/logs The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/gump_work/build_tomcat-trunk_tomcat-trunk-test.html Work Name: build_tomcat-trunk_tomcat-trunk-test (Type: Build) Work ended in a state of : Failed Elapsed: 21 mins 58 secs Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.12-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140508-native-src.tar.gz -Dexamples.sources.skip=true -Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps -Djdt.jar=/srv/gump/packages/eclipse/plugins/P20140317-1600/ecj-P20140317-1600.jar -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20140508.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140508-native-src.tar.gz -Dexecute.test.nio=false -Dtest.accesslog=true -Dcommons-pool.home=/srv/gump/public/workspace/apache-com mons/pool -Dcommons-dbcp.home=/srv/gump/public/workspace/apache-commons/dbcp -Dexecute.test.nio2=false -Dexecute.test.bio=true -Deasymock.jar=/srv/gump/public/workspace/easymock/easymock/target/easymock-3.3-SNAPSHOT.jar -Dhamcrest.jar=/srv/gump/public/workspace/hamcrest/hamcrest-java/build/hamcrest-core-20140508.jar -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servle t-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-jni.jar:/srv/gump/public/workspace/tomcat -trunk/output/build/lib/tomcat-spdy.jar:/s
svn commit: r1595366 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/compiler/Validator.java
Author: kkolinko
Date: Fri May 16 22:02:47 2014
New Revision: 1595366
URL: http://svn.apache.org/r1595366
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56529
Merged r1595289 from tomcat/trunk:
Review of r1595174:
1. Call iterator() once. It creates an object, so it is better do not waste
such calls.
2. Style issues:
- "" does not make sense as 'generic' default for textAttributeValue. It makes
sense for this specific case only.
- 3 spaces indent -> 4 spaces
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/Validator.java
Propchange: tomcat/tc7.0.x/trunk/
--
Merged /tomcat/trunk:r1595289
Modified: tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/Validator.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/Validator.java?rev=1595366&r1=1595365&r2=1595366&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/Validator.java
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/Validator.java Fri May
16 22:02:47 2014
@@ -1124,12 +1124,16 @@ class Validator {
// When attribute is not an expression,
// contains its textual value with \$ and \# escaping removed.
-String textAttributeValue = "";
+String textAttributeValue;
if (!elExpression && el != null) {
// Should be a single Text node
- if(el.iterator().hasNext()) {
- textAttributeValue = ((ELNode.Text)
el.iterator().next()).getText();
- }
+Iterator it = el.iterator();
+if (it.hasNext()) {
+textAttributeValue = ((ELNode.Text) it.next())
+.getText();
+} else {
+textAttributeValue = "";
+}
} else {
textAttributeValue = xmlAttributeValue;
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1595379 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko Date: Fri May 16 22:40:00 2014 New Revision: 1595379 URL: http://svn.apache.org/r1595379 Log: proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1595379&r1=1595378&r2=1595379&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Fri May 16 22:40:00 2014 @@ -33,6 +33,12 @@ PATCHES PROPOSED TO BACKPORT: in custom tags. Patch provided by Hariprasad Manchi. http://svn.apache.org/viewvc?view=revision&revision=1595174 +1: markt, fhanik, remm + +1: kkolinko (additional patch below) + -1: + + Additional patch: + http://svn.apache.org/viewvc?view=revision&revision=1595366 + +1: kkolinko -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1595359 - /tomcat/trunk/webapps/docs/changelog.xml
Author: kkolinko Date: Fri May 16 21:31:00 2014 New Revision: 1595359 URL: http://svn.apache.org/r1595359 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56526 Followup to r1595331: correct version number in changelog. (Tomcat 8.0.8 has been tagged an hour earlier). Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1595359&r1=1595358&r2=1595359&view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Fri May 16 21:31:00 2014 @@ -44,6 +44,17 @@ They eventually become mixed with the numbered issues. (I.e., numbered issues to not "pop up" wrt. others). --> + + + + +56526: Improved the StuckThreadDetectionValve to +optionally interrupt stuck threads to attempt to unblock them. +(slaurent) + + + + @@ -52,11 +63,6 @@ HttpSessionBindingListener.valueUnbound() uses the correct class loader when the SingleSignOn valve is used. (markt) - -56526: Improved the StuckThreadDetectionValve to -optionally interrupt stuck threads to attempt to unblock them. -(slaurent) - - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1595339 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: remm Date: Fri May 16 20:33:15 2014 New Revision: 1595339 URL: http://svn.apache.org/r1595339 Log: Vote. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1595339&r1=1595338&r2=1595339&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Fri May 16 20:33:15 2014 @@ -32,7 +32,7 @@ PATCHES PROPOSED TO BACKPORT: Fix NoSuchElementException while handling attributes with empty string value in custom tags. Patch provided by Hariprasad Manchi. http://svn.apache.org/viewvc?view=revision&revision=1595174 - +1: markt, fhanik + +1: markt, fhanik, remm -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56529] NoSuchElementException for attribute with empty string in custom tag
https://issues.apache.org/bugzilla/show_bug.cgi?id=56529 --- Comment #1 from Hariprasad Manchi --- Created attachment 31629 --> https://issues.apache.org/bugzilla/attachment.cgi?id=31629&action=edit sample web application to see the exception. Try to load the loginex.jsp. You will see the exception. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot success in ASF Buildbot on tomcat-trunk
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/78 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/trunk] 1594950 Blamelist: markt Build succeeded! sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1595367 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/jasper/compiler/TestGenerator.java test/webapp-3.0/WEB-INF/bugs.tld test/webapp-3.0/bug5nnnn/bug56529.jsp
Author: kkolinko
Date: Fri May 16 22:14:56 2014
New Revision: 1595367
URL: http://svn.apache.org/r1595367
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56529
Test case for attributes with empty string values in custom tags.
It is backport of r1595230 r1595365 from tomcat/trunk.
Added:
tomcat/tc7.0.x/trunk/test/webapp-3.0/bug5/bug56529.jsp
- copied unchanged from r1595365,
tomcat/trunk/test/webapp/bug5/bug56529.jsp
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/test/org/apache/jasper/compiler/TestGenerator.java
tomcat/tc7.0.x/trunk/test/webapp-3.0/WEB-INF/bugs.tld
Propchange: tomcat/tc7.0.x/trunk/
--
Merged /tomcat/trunk:r1595230,1595365
Modified:
tomcat/tc7.0.x/trunk/test/org/apache/jasper/compiler/TestGenerator.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/org/apache/jasper/compiler/TestGenerator.java?rev=1595367&r1=1595366&r2=1595367&view=diff
==
--- tomcat/tc7.0.x/trunk/test/org/apache/jasper/compiler/TestGenerator.java
(original)
+++ tomcat/tc7.0.x/trunk/test/org/apache/jasper/compiler/TestGenerator.java Fri
May 16 22:14:56 2014
@@ -18,6 +18,7 @@
package org.apache.jasper.compiler;
import java.io.File;
+import java.io.IOException;
import java.util.Date;
import java.util.HashMap;
import java.util.List;
@@ -33,6 +34,7 @@ import javax.servlet.jsp.tagext.Variable
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
+import org.junit.Assert;
import org.junit.Test;
import org.apache.catalina.core.StandardContext;
@@ -251,4 +253,63 @@ public class TestGenerator extends Tomca
private static void assertEcho(String result, String expected) {
assertTrue(result.indexOf("" + expected + "") > 0);
}
+
+@Test
+public void testBug56529() throws Exception {
+Tomcat tomcat = getTomcatInstance();
+
+File appDir = new File("test/webapp-3.0");
+// app dir is relative to server home
+tomcat.addWebapp(null, "/test", appDir.getAbsolutePath());
+
+tomcat.start();
+
+ByteChunk bc = new ByteChunk();
+int rc = getUrl("http://localhost:"; + getPort() +
+"/test/bug5/bug56529.jsp", bc, null);
+Assert.assertEquals(HttpServletResponse.SC_OK, rc);
+String response = bc.toStringInternal();
+Assert.assertTrue(response,
+response.contains("[1:attribute1: '', attribute2: '']"));
+Assert.assertTrue(response,
+response.contains("[2:attribute1: '', attribute2: '']"));
+ }
+
+public static class Bug56529 extends TagSupport {
+
+private static final long serialVersionUID = 1L;
+
+private String attribute1 = null;
+
+private String attribute2 = null;
+
+public void setAttribute1(String attribute1) {
+this.attribute1 = attribute1;
+}
+
+public String getAttribute1() {
+return attribute1;
+}
+
+public void setAttribute2(String attribute2) {
+this.attribute2 = attribute2;
+}
+
+public String getAttribute2() {
+return attribute2;
+}
+
+@Override
+public int doEndTag() throws JspException {
+try {
+pageContext.getOut().print(
+"attribute1: '" + attribute1 + "', " + "attribute2: '"
++ attribute2 + "'");
+} catch (IOException e) {
+throw new JspException(e);
+}
+return EVAL_PAGE;
+}
+
+}
}
Modified: tomcat/tc7.0.x/trunk/test/webapp-3.0/WEB-INF/bugs.tld
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/webapp-3.0/WEB-INF/bugs.tld?rev=1595367&r1=1595366&r2=1595367&view=diff
==
--- tomcat/tc7.0.x/trunk/test/webapp-3.0/WEB-INF/bugs.tld (original)
+++ tomcat/tc7.0.x/trunk/test/webapp-3.0/WEB-INF/bugs.tld Fri May 16 22:14:56
2014
@@ -67,6 +67,20 @@
AT_END
+
+Bug56529
+org.apache.jasper.compiler.TestGenerator$Bug56529
+JSP
+
+ attribute1
+ true
+ true
+
+
+ attribute2
+ true
+
+
bug49555
org.apache.el.TesterFunctions$Inner$Class
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56526] New option to interrupt stuck threads
https://issues.apache.org/bugzilla/show_bug.cgi?id=56526 --- Comment #3 from Konstantin Kolinko --- Small correction: the fix is in 8.0.9. (Tomcat 8.0.8 was tagged an hour earlier - r1595294) I updated the changelog file. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Commented] (MTOMCAT-238) Parameter staticContextDocbase cant be used
[ https://issues.apache.org/jira/browse/MTOMCAT-238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13993794#comment-13993794 ] Hudson commented on MTOMCAT-238: SUCCESS: Integrated in TomcatMavenPlugin-mvn3.x #275 (See [https://builds.apache.org/job/TomcatMavenPlugin-mvn3.x/275/]) [MTOMCAT-238] Parameter staticContextDocbase cant be used Submitted by Sylvain Guillopé (olamy: http://svn.apache.org/viewvc/?view=rev&rev=1590540) * /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java > Parameter staticContextDocbase cant be used > --- > > Key: MTOMCAT-238 > URL: https://issues.apache.org/jira/browse/MTOMCAT-238 > Project: Apache Tomcat Maven Plugin > Issue Type: Bug > Components: tomcat6, tomcat7 >Affects Versions: 2.0-beta-1, 2.1 >Reporter: Michal Franc >Assignee: Olivier Lamy (*$^¨%`£) > Fix For: 3.0 > > Attachments: AbstractRunMojo.java, tomcat7-maven-plugin-2.2.diff, > tomcat7-maven-plugin-2.2.jar.zip > > > Attribute staticContextDocbase leads to IllegalArgumentException > org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo#createStaticContext > is context created from container and at the and added again to server which > leads to java.lang.IllegalArgumentException: addChild: Child name '/' is not > unique -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1595365 - in /tomcat/trunk/test: org/apache/jasper/compiler/TestGenerator.java webapp/bug5nnnn/bug56529.jsp
Author: kkolinko
Date: Fri May 16 21:58:42 2014
New Revision: 1595365
URL: http://svn.apache.org/r1595365
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56529
Followup to r1595230
Minor improvement to the testcase: check the actual response produced by test
JSP page.
Modified:
tomcat/trunk/test/org/apache/jasper/compiler/TestGenerator.java
tomcat/trunk/test/webapp/bug5/bug56529.jsp
Modified: tomcat/trunk/test/org/apache/jasper/compiler/TestGenerator.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/jasper/compiler/TestGenerator.java?rev=1595365&r1=1595364&r2=1595365&view=diff
==
--- tomcat/trunk/test/org/apache/jasper/compiler/TestGenerator.java (original)
+++ tomcat/trunk/test/org/apache/jasper/compiler/TestGenerator.java Fri May 16
21:58:42 2014
@@ -273,6 +273,11 @@ public class TestGenerator extends Tomca
int rc = getUrl("http://localhost:"; + getPort() +
"/test/bug5/bug56529.jsp", bc, null);
Assert.assertEquals(HttpServletResponse.SC_OK, rc);
+String response = bc.toStringInternal();
+Assert.assertTrue(response,
+response.contains("[1:attribute1: '', attribute2: '']"));
+Assert.assertTrue(response,
+response.contains("[2:attribute1: '', attribute2: '']"));
}
public static class Bug56529 extends TagSupport {
@@ -302,8 +307,9 @@ public class TestGenerator extends Tomca
@Override
public int doEndTag() throws JspException {
try {
-pageContext.getOut().println("attribute1: " + attribute1);
-pageContext.getOut().println("attribute2: " + attribute2);
+pageContext.getOut().print(
+"attribute1: '" + attribute1 + "', " + "attribute2: '"
++ attribute2 + "'");
} catch (IOException e) {
throw new JspException(e);
}
Modified: tomcat/trunk/test/webapp/bug5/bug56529.jsp
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/webapp/bug5/bug56529.jsp?rev=1595365&r1=1595364&r2=1595365&view=diff
==
--- tomcat/trunk/test/webapp/bug5/bug56529.jsp (original)
+++ tomcat/trunk/test/webapp/bug5/bug56529.jsp Fri May 16 21:58:42 2014
@@ -15,10 +15,10 @@
limitations under the License.
--%>
<%@ taglib uri="http://tomcat.apache.org/bugs"; prefix="bugs" %>
-
+[1:
-
+]
-
+[2:
-
+]
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1594874 - in /tomcat/tc6.0.x/tags/TOMCAT_6_0_40: ./ build.properties.default
Author: markt Date: Thu May 15 11:35:44 2014 New Revision: 1594874 URL: http://svn.apache.org/r1594874 Log: Tag 6.0.40 Added: tomcat/tc6.0.x/tags/TOMCAT_6_0_40/ (props changed) - copied from r1594872, tomcat/tc6.0.x/trunk/ Modified: tomcat/tc6.0.x/tags/TOMCAT_6_0_40/build.properties.default Propchange: tomcat/tc6.0.x/tags/TOMCAT_6_0_40/ -- --- svn:ignore (added) +++ svn:ignore Thu May 15 11:35:44 2014 @@ -0,0 +1,7 @@ +.classpath +.project +.settings +output +build.properties +work +logs Propchange: tomcat/tc6.0.x/tags/TOMCAT_6_0_40/ -- --- svn:mergeinfo (added) +++ svn:mergeinfo Thu May 15 11:35:44 2014 @@ -0,0 +1,2 @@ +/tomcat/tc7.0.x/trunk:1224802,1243045,1298635,1304471,1311997,1312007,1331772,1333164,1333176,1354866,1371298,1371302,1371620,1402110,1413553,1413557,1413563,1430083,1438415,1447013,1484919,1486877,1500065,1503852,1505844,1513151,1521040,1526470,1536524,1539176-1539177,1544469,1544473,1552805,1558894,1558917,1561368,1561382,1561386,1561552,1561561,1561636,1561641,1561643,1561737,1562748,1564317,1568922,1570163,1577328,1577464-1577465,1578814,1586659,1586897,1586960,1588199,1588997,1589740,1589851,1589997,1590019,1590028,1590337,1590492,1590651,1590838,1590845,1590848,1590912,1593262,1593288,1593371,1593835,1594230 +/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,656018,666232,673796,673820,677910,683969,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,713953,714002,718360,719119,719124,719602,719626,719628,720046,720069,721040,721286,721708,721886,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,746425,747834,747863,748344,750258,750291,750921,751286-751287,751289,751295,752323,753039,757335,757774,758249,758365,758596,758616,758664,759074,761601,762868,762929,762936-762937,763166,763183,763193,763228,763262,763298,763302,763325,763599,763611,763654,763681,763706,764985,764997,765662,768335,769979,770716,770 809,770876,772872,776921,776924,776935,776945,777464,777466,777576,777625,778379,778523-778524,781528,781779,782145,782791,783316,783696,783724,783756,783762,783766,783863,783934,784453,784602,784614,785381,785688,785768,785859,786468,786487,786490,786496,786667,787627,787770,787985,789389,790405,791041,791184,791194,791224,791243,791326,791328,791789,792740,793372,793757,793882,793981,794082,794673,794822,795043,795152,795210,795457,795466,797168,797425,797596,797607,802727,802940,804462,804544,804734,805153,809131,809603,810916,810977,812125,812137,812432,813001,813013,813866,814180,814708,814876,815972,816252,817442,817822,819339,819361,820110,820132,820874,820954,821397,828196,828201,828210,828225,828759,830378-830379,830999,831106,831774,831785,831828,831850,831860,832214,832218,833121,833545,834047,835036,835336,836405,881396,881412,883130,883134,883146,883165,883177,883362,883565,884341,885038,885231,885241,885260,885901,885991,886019,888072,889363,889606,889716,890139,890265 ,890349-890350,890417,891185-891187,891583,892198,892341,892415,892464,892555,892812,892814,892817,892843,892887,893321,893493,894580,894586,894805,894831,895013,895045,895057,895191,895392,895703,896370,896384,897380-897381,897776,898126,898256,898468,898527,898555,898558,898718,898836,898906,899284,899348,899420,899653,899769-899770,899783,899788,899792,899916,899918-899919,899935,899949,903916,905020,905151,905722,905728,905735,907311,907513,907538,907652,907819,907825,907864,908002,908721,908754,908759,909097,909206,909212,909525,909636,909869,909875,909887,910266,910370,910442,910471,910485,910974,915226,915737,915861,916097,916141,916157,916170,917598,917633,918093,918489,918594,918684,918787,918792,918799,918803,918885,919851,919914,920025,920055,920298,920449,920596,920824,920840,921444,922010,926716,927062,927621,928482,928695,928732,928798,931709,932357,932967,935105,935983,939491,939551,940064,941356,941463,943112,944409,944416,945231,945808,945835,945841,946686,948057,95 0164,950596,950614,950851,950905,951615,953434,954435,955648,955655,956832,957130,957830,958192,960701,961948,962865,962872,962881,962900,963106,963865,963868,964614,966177-966178,966292,966692,966863,981815,988448,991837,993042,1001955,1002185,1002263,1002274,1002349,1002359,1002362,1002481,1002514,1003461,1003481,1003488,1003556,1003572,1003581,1003861,1004393,1004409,1004415,1004868-1004869,1004912,1005452,1005467,1005647,1005802,1022120,1022134,1022323,1022415,1022606,1022623,1024224,1024251,1026042,1026784,1026912,1026920,1029767,1033415,1033448,1033842,1033897,103
svn commit: r5358 [2/2] - in /dev/tomcat/tomcat-8/v8.0.7: ./ bin/ bin/embed/ bin/extras/ src/
Added: dev/tomcat/tomcat-8/v8.0.7/src/apache-tomcat-8.0.7-src.tar.gz.md5 == --- dev/tomcat/tomcat-8/v8.0.7/src/apache-tomcat-8.0.7-src.tar.gz.md5 (added) +++ dev/tomcat/tomcat-8/v8.0.7/src/apache-tomcat-8.0.7-src.tar.gz.md5 Thu May 15 15:59:53 2014 @@ -0,0 +1 @@ +e7d600547ecb6386496dd743ebc52a5a *apache-tomcat-8.0.7-src.tar.gz \ No newline at end of file Added: dev/tomcat/tomcat-8/v8.0.7/src/apache-tomcat-8.0.7-src.zip == Binary file - no diff available. Propchange: dev/tomcat/tomcat-8/v8.0.7/src/apache-tomcat-8.0.7-src.zip -- svn:mime-type = application/octet-stream Added: dev/tomcat/tomcat-8/v8.0.7/src/apache-tomcat-8.0.7-src.zip.asc == --- dev/tomcat/tomcat-8/v8.0.7/src/apache-tomcat-8.0.7-src.zip.asc (added) +++ dev/tomcat/tomcat-8/v8.0.7/src/apache-tomcat-8.0.7-src.zip.asc Thu May 15 15:59:53 2014 @@ -0,0 +1,17 @@ +-BEGIN PGP SIGNATURE- +Version: GnuPG v1.4.9 (MingW32) + +iQIcBAABAgAGBQJTdNtbAAoJEBDAHFovYFnnDNQQALxNGzlI2rmk3QVExBSpLdIT +D7QhgjIQa2AIsJSb/DuoLRbbo+YCTS/VXzgRdKQNUdlbOmCrjxnUNxoSxo55Qnkz +1uUUHBgKaAZ63a5dSi05YGiHtiukx/6svsfFEuzt7BdVzAG977+LkRZ5dWu26rNH +OE8e9XhGzxUaeQUwXSZur9Z1dcf04+v3Vl5NIkTWxB2azOapMGD6c8QgrkEU6eBB +izBwszsdvDe6OY2o3U/+xEjVSrvJye0NVl1Zw6LUS2Iwmv108ibC+VGUB6Qgn1Yq +lS5qhOs/J4KWCzKjKz1RJtTz/jjbCsYar4hW2YkEm9av3251WKi/0Nd2RXbb2lBY +BWOvzJu8JPVtGHxY6YFquFhAu3mH6dU7eHPxIafl+IcMD8c4hhEPeLtxx8UfO+jc +cis7J/iDDoes0wxtcci1Tdm+nDWzP7eV+0t9X/3JenTXKx/Q6O4gZbtHoTKsyusw +QvcAQwUXcCdmsQkpd4xz5kcHf6JoLJU8RYCodd4TqWQPj4NIB7W3/uYhlPt7CbMu +LQwJHmppJnxkNE+d+P8bYCEl/f25GuPEHJwrMv9xDB5P3tABmT5rpbNh0ZnZy9QQ ++kHEXFwM+hlHV75WXXsPI40xSIYuGi4BiiDwZEIMSgqVF5E5BP0t+jJl8EyuXpoy +/sSQuLL8HNzSTbKQfVis +=1AHU +-END PGP SIGNATURE- Added: dev/tomcat/tomcat-8/v8.0.7/src/apache-tomcat-8.0.7-src.zip.md5 == --- dev/tomcat/tomcat-8/v8.0.7/src/apache-tomcat-8.0.7-src.zip.md5 (added) +++ dev/tomcat/tomcat-8/v8.0.7/src/apache-tomcat-8.0.7-src.zip.md5 Thu May 15 15:59:53 2014 @@ -0,0 +1 @@ +55d28925ca5bf8b6c671d0bc46170275 *apache-tomcat-8.0.7-src.zip \ No newline at end of file - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[VOTE] Release Apache Tomcat 8.0.8
The proposed Apache Tomcat 8.0.8 release is now available for voting. The main changes since 8.0.6 are: - Fix BZ 56529 a regression in the fix for BZ 56481 - Fix regression that broke Tomcat's copy of DBCP - Small number of additional fixes The main changes since 8.0.5 are: - Further NIO2 fixes which is now considered BETA - Extend and improve memory leak protection and fix a few leaks that crept in during the various refactorings - Lots of general bug fixes It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.8/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1013/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_8/ The proposed 8.0.8 release is: [ ] Broken - do not release [ ] Alpha - go ahead and release as 8.0.8 (alpha) [ ] Beta - go ahead and release as 8.0.8 (beta) [ ] Stable - go ahead and release as 8.0.8 (stable) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1594939 - in /tomcat/tc8.0.x/tags/TOMCAT_8_0_7: ./ build.properties.default
Author: markt Date: Thu May 15 15:03:34 2014 New Revision: 1594939 URL: http://svn.apache.org/r1594939 Log: Tag 8.0.7 Added: tomcat/tc8.0.x/tags/TOMCAT_8_0_7/ - copied from r1594938, tomcat/trunk/ Modified: tomcat/tc8.0.x/tags/TOMCAT_8_0_7/build.properties.default Modified: tomcat/tc8.0.x/tags/TOMCAT_8_0_7/build.properties.default URL: http://svn.apache.org/viewvc/tomcat/tc8.0.x/tags/TOMCAT_8_0_7/build.properties.default?rev=1594939&r1=1594938&r2=1594939&view=diff == --- tomcat/tc8.0.x/tags/TOMCAT_8_0_7/build.properties.default (original) +++ tomcat/tc8.0.x/tags/TOMCAT_8_0_7/build.properties.default Thu May 15 15:03:34 2014 @@ -27,7 +27,7 @@ version.major=8 version.minor=0 version.build=6 version.patch=0 -version.suffix=-dev +version.suffix= # - Build control flags - # Note enabling validation uses Checkstyle which is LGPL licensed - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56283] Add support for Java 8 to Jasper
https://issues.apache.org/bugzilla/show_bug.cgi?id=56283 --- Comment #5 from Robbie Gibson --- Created attachment 31624 --> https://issues.apache.org/bugzilla/attachment.cgi?id=31624&action=edit Failing JSP (doesn't compile with a Java 8 JDK and source/target version 1.6) The version of ECJ supplied with 7.0.53 fails to compile JSP files that reference class files containing default methods under the following conditions: - compilerSourceVersion/compilerTargetVersion < 1.8 - JRE_HOME >= jdk1.8.0 Attachment has a minimal test case It looks like it might be Eclipse bug 390889 which is fixed in 4.4M7 https://bugs.eclipse.org/bugs/show_bug.cgi?id=390889 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[VOTE] Release Apache Tomcat 6.0.40
The proposed Apache Tomcat 6.0.40 release candidate is now available for voting. The main changes since 6.0.39 are: - Add support for using ecj-P20140317-1600.jar to use Java 8 syntax in JSPs - Update native library to 1.1.30 - Various improvements to XML processing along with a number of bug fixes. Full details are in the change log. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-6/v6.0.40/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1012/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc6.0.x/tags/TOMCAT_6_0_40 The proposed 6.0.40 release is: [ ] Broken - do not release [ ] Stable - go ahead and release as 6.0.40 Stable Cheers, Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56516] VariableInfo doesn't handle scope changes correctly
https://issues.apache.org/bugzilla/show_bug.cgi?id=56516 --- Comment #4 from Mark Thomas --- (In reply to Konstantin Kolinko from comment #3) > Re: r1594715 > > I think this report is invalid. I'm leaning towards that conclusion. > For 2.,3. declaration of variables is illustrated in ch.JSP.9.4.4 "Actions" > page "1-196" (234 of 594). This is probably the clearest argument against the fix applied in r1594715. It is a stronger argument than JSP.1.8 > It also says: > "Their visibility is affected by other constructs, for example scriptlets." I'm not sure what that means for the current approach that ensures variables are only declared once when multiple instances of the same tag are used. I'm going to revert this patch, resolve this issue as INVALID and write up the problem for the JSP EG to discuss. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56536] HttpSessionBindingListener.valueUnbound uses wrong classloader when SingleSignOn valve is used
https://issues.apache.org/bugzilla/show_bug.cgi?id=56536 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Mark Thomas --- This has been fixed in trunk for 8.0.8 onwards and in 7.0.x for 7.0.54 onwards. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56526] New option to interrupt stuck threads
https://issues.apache.org/bugzilla/show_bug.cgi?id=56526 --- Comment #2 from Sylvain Laurent --- committed r1595331 on tomcat 8 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56399] Re-factor request/response recycling so Coyote and Catalina objects are recycled simultaneously
https://issues.apache.org/bugzilla/show_bug.cgi?id=56399 --- Comment #6 from Konstantin Kolinko --- Created attachment 31633 --> https://issues.apache.org/bugzilla/attachment.cgi?id=31633&action=edit Do not use exception for flow control (2014-05-16_tc8_CoyoteAdapter.patch) (In reply to comment #5) Patch that changes the implementation to do not use an exception for flow control. I did not manage to commit it before 8.0.8 tag. I will wait awhile (a day or two) before proceeding with it. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56530] WebappClassLoader.loadClass synchronization issue due to coarse lock at WebappClassLoader instance level instead of been by class name
https://issues.apache.org/bugzilla/show_bug.cgi?id=56530 Mark Thomas changed: What|Removed |Added Component|Catalina|Catalina Version|7.0.53 |trunk Product|Tomcat 7|Tomcat 8 Target Milestone|--- | Severity|major |enhancement --- Comment #6 from Mark Thomas --- Again, please provide the full stack trace. It might tell us something it doesn't tell you. Tomcat 7 has to run on Java 6 and experience to date has been that synchronizing on anything other than the method leads to problems for a small number if users. Tomcat 8 is where there is scope to revisit parallel loading. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r5366 [2/2] - in /dev/tomcat/tomcat-8/v8.0.8: ./ bin/ bin/embed/ bin/extras/ src/
Added: dev/tomcat/tomcat-8/v8.0.8/src/apache-tomcat-8.0.8-src.tar.gz.md5 == --- dev/tomcat/tomcat-8/v8.0.8/src/apache-tomcat-8.0.8-src.tar.gz.md5 (added) +++ dev/tomcat/tomcat-8/v8.0.8/src/apache-tomcat-8.0.8-src.tar.gz.md5 Fri May 16 19:45:16 2014 @@ -0,0 +1 @@ +013003918905ad1cda783abd495b532f *apache-tomcat-8.0.8-src.tar.gz \ No newline at end of file Added: dev/tomcat/tomcat-8/v8.0.8/src/apache-tomcat-8.0.8-src.zip == Binary file - no diff available. Propchange: dev/tomcat/tomcat-8/v8.0.8/src/apache-tomcat-8.0.8-src.zip -- svn:mime-type = application/octet-stream Added: dev/tomcat/tomcat-8/v8.0.8/src/apache-tomcat-8.0.8-src.zip.asc == --- dev/tomcat/tomcat-8/v8.0.8/src/apache-tomcat-8.0.8-src.zip.asc (added) +++ dev/tomcat/tomcat-8/v8.0.8/src/apache-tomcat-8.0.8-src.zip.asc Fri May 16 19:45:16 2014 @@ -0,0 +1,17 @@ +-BEGIN PGP SIGNATURE- +Version: GnuPG v1.4.9 (MingW32) + +iQIcBAABAgAGBQJTdlyaAAoJEBDAHFovYFnn8JQP/RjkMm+/bwM3FMnhXijKuc/Z +iA6LMciwUmffAREL/GrbBBtOTjN8YbMnStijxu7mcZp4DUAVMdCWMHNK6YwYBrZC +x9vQZ64RrQckpJu+MpERvHRORpT7At9YMHsq9++jhswrJPCwYu1I0LbEKtr6MYej +CrRLG04q2mC/zpH+hz3qVWY1H7iKHjyTf9a1eR43Y8uL2SZkNMRUen97t1FlbGmt +pD0KnWKlMpWml75XEW5C9sXFnyLbnkvVRSlvovn8YvfZa1t0RKuuEgflHs2uhp6A +6HFHoIljsdubI+wtrvTcPlXMYwKWyJGxosiE1a+SJIK6JI/TFuw+q5N4SrVDliFF +oq/a8hpZ+LYRx+863Nqc00tnF18gK6zvJoZOKMnZSjuI1Cz8HTDhyOQP+58668bH +gxqxj2zWuhRXx62uspLSEflB+13aTu1fejWg6pAfeHo38dm1VyybDl1MHYuWF/+G +uEiDGqG4k9aBYezFBjLoOm40HnsUalzncqzCa09N+0QQlkKfcomA9W62e0o962h1 +lIhsmxhSWJqQk9srRzyQ/X8ltZaIz23Tr3aC6u1TtIUBQX82yPhiLWGHEw5/8dgR +AVqpOgm6oCG7wf3zoZespT0TMnUwJ5LJPNuyXWZFVBTCqo7lGuHlaXvrprhD5ry0 +/7Za4HZkCWnvypUkgPa4 +=DJPK +-END PGP SIGNATURE- Added: dev/tomcat/tomcat-8/v8.0.8/src/apache-tomcat-8.0.8-src.zip.md5 == --- dev/tomcat/tomcat-8/v8.0.8/src/apache-tomcat-8.0.8-src.zip.md5 (added) +++ dev/tomcat/tomcat-8/v8.0.8/src/apache-tomcat-8.0.8-src.zip.md5 Fri May 16 19:45:16 2014 @@ -0,0 +1 @@ +12443f5df2eddb50f99cfa1fa7e4cf0c *apache-tomcat-8.0.8-src.zip \ No newline at end of file - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1595331 - in /tomcat/trunk: java/org/apache/catalina/valves/ test/org/apache/catalina/valves/ webapps/docs/ webapps/docs/config/
Author: slaurent
Date: Fri May 16 20:05:08 2014
New Revision: 1595331
URL: http://svn.apache.org/r1595331
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56526
Improved StuckThreadDetectionValve to allow to interrupt stuck threads.
Added:
tomcat/trunk/test/org/apache/catalina/valves/TestStuckThreadDetectionValve.java
Modified:
tomcat/trunk/java/org/apache/catalina/valves/LocalStrings.properties
tomcat/trunk/java/org/apache/catalina/valves/StuckThreadDetectionValve.java
tomcat/trunk/webapps/docs/changelog.xml
tomcat/trunk/webapps/docs/config/valve.xml
Modified: tomcat/trunk/java/org/apache/catalina/valves/LocalStrings.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/LocalStrings.properties?rev=1595331&r1=1595330&r2=1595331&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/valves/LocalStrings.properties
(original)
+++ tomcat/trunk/java/org/apache/catalina/valves/LocalStrings.properties Fri
May 16 20:05:08 2014
@@ -52,6 +52,7 @@ sslValve.invalidProvider=The SSL provide
#Stuck thread detection Valve
stuckThreadDetectionValve.notifyStuckThreadDetected=Thread "{0}" (id={6}) has
been active for {1} milliseconds (since {2}) to serve the same request for {4}
and may be stuck (configured threshold for this StuckThreadDetectionValve is
{5} seconds). There is/are {3} thread(s) in total that are monitored by this
Valve and may be stuck.
stuckThreadDetectionValve.notifyStuckThreadCompleted=Thread "{0}" (id={3}) was
previously reported to be stuck but has completed. It was active for
approximately {1} milliseconds.{2,choice,0#|0< There is/are still {2} thread(s)
that are monitored by this Valve and may be stuck.}
+stuckThreadDetectionValve.notifyStuckThreadInterrupted=Thread "{0}" (id={5})
has been interrupted because it was active for {1} milliseconds (since {2}) to
serve the same request for {3} and was probably stuck (configured interruption
threshold for this StuckThreadDetectionValve is {4} seconds).
# HTTP status reports
# All status codes registered with IANA can be found at
Modified:
tomcat/trunk/java/org/apache/catalina/valves/StuckThreadDetectionValve.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/StuckThreadDetectionValve.java?rev=1595331&r1=1595330&r2=1595331&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/valves/StuckThreadDetectionValve.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/valves/StuckThreadDetectionValve.java
Fri May 16 20:05:08 2014
@@ -23,7 +23,9 @@ import java.util.List;
import java.util.Queue;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.ConcurrentLinkedQueue;
+import java.util.concurrent.Semaphore;
import java.util.concurrent.atomic.AtomicInteger;
+import java.util.concurrent.atomic.AtomicLong;
import javax.servlet.ServletException;
@@ -57,11 +59,21 @@ public class StuckThreadDetectionValve e
private final AtomicInteger stuckCount = new AtomicInteger(0);
/**
+ * Keeps count of the number of stuck threads that have been interruoted
+ */
+private AtomicLong interruptedThreadsCount = new AtomicLong();
+
+/**
* In seconds. Default 600 (10 minutes).
*/
private int threshold = 600;
/**
+ * In seconds. Default is -1 to disable interruption.
+ */
+private int interruptThreadThreshold;
+
+/**
* The only references we keep to actual running Thread objects are in
* this Map (which is automatically cleaned in invoke()s finally clause).
* That way, Threads can be GC'ed, eventhough the Valve still thinks they
@@ -76,7 +88,7 @@ public class StuckThreadDetectionValve e
new ConcurrentLinkedQueue<>();
/**
- * Specify the threshold (in seconds) used when checking for stuck threads.
+ * Specifies the threshold (in seconds) used when checking for stuck
threads.
* If <=0, the detection is disabled. The default is 600 seconds.
*
* @param threshold
@@ -95,6 +107,22 @@ public class StuckThreadDetectionValve e
}
+public int getInterruptThreadThreshold() {
+return interruptThreadThreshold;
+}
+
+/**
+ * Specifies the threshold (in seconds) before stuck threads are
interrupted.
+ * If <=0, the interruption is disabled. The default is -1.
+ * If >=0, the value must actually be >= threshold.
+ *
+ * @param interruptThreadThreshold
+ *The new thread interruption threshold in seconds
+ */
+public void setInterruptThreadThreshold(int interruptThreadThreshold) {
+this.interruptThreadThreshold = interruptThreadThreshold;
+}
+
/**
* Required to enable async support.
*/
@@ -173,7 +201,7 @@ public class StuckThreadDetectionValve e
request
svn commit: r1595320 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: fhanik Date: Fri May 16 19:32:00 2014 New Revision: 1595320 URL: http://svn.apache.org/r1595320 Log: Votes Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1595320&r1=1595319&r2=1595320&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Fri May 16 19:32:00 2014 @@ -32,7 +32,7 @@ PATCHES PROPOSED TO BACKPORT: Fix NoSuchElementException while handling attributes with empty string value in custom tags. Patch provided by Hariprasad Manchi. http://svn.apache.org/viewvc?view=revision&revision=1595174 - +1: markt + +1: markt, fhanik -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1595291 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/session/StandardSession.java webapps/docs/changelog.xml
Author: markt
Date: Fri May 16 18:32:25 2014
New Revision: 1595291
URL: http://svn.apache.org/r1595291
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56536
Ensure that HttpSessionBindingListener.valueUnbound() uses the correct class
loader when the SingleSignOn valve is used.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/session/StandardSession.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
Propchange: tomcat/tc7.0.x/trunk/
--
Merged /tomcat/trunk:r1595285
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/catalina/session/StandardSession.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/session/StandardSession.java?rev=1595291&r1=1595290&r2=1595291&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/catalina/session/StandardSession.java
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/session/StandardSession.java
Fri May 16 18:32:25 2014
@@ -864,11 +864,32 @@ public class StandardSession implements
// Unbind any objects associated with this session
String keys[] = keys();
-for (int i = 0; i < keys.length; i++)
-removeAttributeInternal(keys[i], notify);
-
+if (oldTccl != null) {
+if (Globals.IS_SECURITY_ENABLED) {
+PrivilegedAction pa = new PrivilegedSetTccl(
+context.getLoader().getClassLoader());
+AccessController.doPrivileged(pa);
+} else {
+Thread.currentThread().setContextClassLoader(
+context.getLoader().getClassLoader());
+}
+}
+try {
+for (int i = 0; i < keys.length; i++) {
+removeAttributeInternal(keys[i], notify);
+}
+} finally {
+if (oldTccl != null) {
+if (Globals.IS_SECURITY_ENABLED) {
+PrivilegedAction pa =
+new PrivilegedSetTccl(oldTccl);
+AccessController.doPrivileged(pa);
+} else {
+Thread.currentThread().setContextClassLoader(oldTccl);
+}
+}
+}
}
-
}
Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1595291&r1=1595290&r2=1595291&view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Fri May 16 18:32:25 2014
@@ -187,6 +187,11 @@
associated with failed user logins at debug level rather than error
level. (markt)
+
+ 56536: Ensure that
+ HttpSessionBindingListener.valueUnbound() uses the correct
+ class loader when the SingleSignOn valve is used. (markt)
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1595294 - in /tomcat/tc8.0.x/tags/TOMCAT_8_0_8: ./ build.properties.default
Author: markt Date: Fri May 16 18:39:30 2014 New Revision: 1595294 URL: http://svn.apache.org/r1595294 Log: Tag 8.0.8 Added: tomcat/tc8.0.x/tags/TOMCAT_8_0_8/ - copied from r1595293, tomcat/trunk/ Modified: tomcat/tc8.0.x/tags/TOMCAT_8_0_8/build.properties.default Modified: tomcat/tc8.0.x/tags/TOMCAT_8_0_8/build.properties.default URL: http://svn.apache.org/viewvc/tomcat/tc8.0.x/tags/TOMCAT_8_0_8/build.properties.default?rev=1595294&r1=1595293&r2=1595294&view=diff == --- tomcat/tc8.0.x/tags/TOMCAT_8_0_8/build.properties.default (original) +++ tomcat/tc8.0.x/tags/TOMCAT_8_0_8/build.properties.default Fri May 16 18:39:30 2014 @@ -27,7 +27,7 @@ version.major=8 version.minor=0 version.build=8 version.patch=0 -version.suffix=-dev +version.suffix= # - Build control flags - # Note enabling validation uses Checkstyle which is LGPL licensed - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1595293 - /tomcat/trunk/webapps/docs/changelog.xml
Author: markt Date: Fri May 16 18:38:16 2014 New Revision: 1595293 URL: http://svn.apache.org/r1595293 Log: Whitespace Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1595293&r1=1595292&r2=1595293&view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Fri May 16 18:38:16 2014 @@ -50,7 +50,7 @@ 56536: Ensure that HttpSessionBindingListener.valueUnbound() uses the correct - class loader when the SingleSignOn valve is used. (markt) + class loader when the SingleSignOn valve is used. (markt) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1595297 - in /tomcat/trunk: build.properties.default res/maven/mvn.properties.default
Author: markt Date: Fri May 16 18:40:29 2014 New Revision: 1595297 URL: http://svn.apache.org/r1595297 Log: Prep for next release Modified: tomcat/trunk/build.properties.default tomcat/trunk/res/maven/mvn.properties.default Modified: tomcat/trunk/build.properties.default URL: http://svn.apache.org/viewvc/tomcat/trunk/build.properties.default?rev=1595297&r1=1595296&r2=1595297&view=diff == --- tomcat/trunk/build.properties.default (original) +++ tomcat/trunk/build.properties.default Fri May 16 18:40:29 2014 @@ -25,7 +25,7 @@ # - Version Control Flags - version.major=8 version.minor=0 -version.build=8 +version.build=9 version.patch=0 version.suffix=-dev Modified: tomcat/trunk/res/maven/mvn.properties.default URL: http://svn.apache.org/viewvc/tomcat/trunk/res/maven/mvn.properties.default?rev=1595297&r1=1595296&r2=1595297&view=diff == --- tomcat/trunk/res/maven/mvn.properties.default (original) +++ tomcat/trunk/res/maven/mvn.properties.default Fri May 16 18:40:29 2014 @@ -35,7 +35,7 @@ maven.asf.release.repo.url=https://repos maven.asf.release.repo.repositoryId=apache.releases # Release version info -maven.asf.release.deploy.version=8.0.8 +maven.asf.release.deploy.version=8.0.9 #Where do we load the libraries from tomcat.lib.path=../../output/build/lib - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1595231 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Fri May 16 15:25:40 2014 New Revision: 1595231 URL: http://svn.apache.org/r1595231 Log: Prposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1595231&r1=1595230&r2=1595231&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Fri May 16 15:25:40 2014 @@ -28,6 +28,13 @@ None PATCHES PROPOSED TO BACKPORT: [ New proposals should be added at the end of the list ] +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56529 + Fix NoSuchElementException while handling attributes with empty string value + in custom tags. Patch provided by Hariprasad Manchi. + http://svn.apache.org/viewvc?view=revision&revision=1595174 + +1: markt + -1: + PATCHES/ISSUES THAT ARE STALLED: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: apis @asf
My recollection of history (no doubt biased and inaccurate)…. Geronimo originally needed maven-accessible and plausibly maven-metadata'd jars, and tomcat was extremely maven-unfriendly at the time (and wasn't set up to easily consume maven artfiacts). I think we (geronimo) copied the first one (servlet 2.3??), and I think I recall adding the stuff for at least one of the later versions myself. Later on Geronimo needed osgi bundles… If there's any interest in trying to minimize the number of places spec api code is kept I still sort of like the idea of it all being in one place, maybe we could investigate something like giving any other-project committer with interest in working on a spec jar commit rights in geronimo. I don't think spec jar releases have ever been a big timing/delay problem. thanks david jencks On May 16, 2014, at 7:32 AM, Mark Thomas wrote: > On 16/05/2014 07:59, Romain Manni-Bucau wrote: >> Hello guys, >> >> Hope I didnt miss a thread dealing with it, if so please just redirect me. >> >> Tomcat made the choice to do its own API jars. That's not a big deal >> by itself but wonder why not putting them with all "EE" api jars of >> Apache, ie in geronimo specs subproject: >> http://svn.apache.org/repos/asf/geronimo/specs/trunk/ > > I suspect it stems from the fact the Tomcat was originally the reference > implementation for a number of those. > >> It concerns mainly: >> * el >> * websocket >> * jsp >> * servlet >> >> Just to give you a bit more background, this question doesn't come >> from nowhere. In TomEE we use geronimo API for almost everything >> excepted some tomcat provided apis (servlet, jsp) until today. But >> since recent Tomcat 7 got - thanks to Tomcat 8 - a refactoring of EL >> part, geronimo-el and tomcat-el were no more compatible. In other >> words TomEE was broken cause AstValue was refactored and method >> matching more dedicated to BeanELResolver in tomcat but not in >> geronimo. > > Doesn't that simply mean that the refactoring in Tomcat has exposed a > bug in the Geronimo EL API? > >> Wonder if we should/can try to get something consistent accross ASF. > > Assuming that Geronimo is using the Tomcat implementations I wonder why > the project felt the need to produce their own API JARs. Or are they > just (old?) copies taken from Tomcat originally? > >> wdyt? > > From experience with re-using components from Commons, Tomcat would > almost certainly want to keep a local copy - even if that was an svn > copy of some common version - else releases can start to experience > noticeable delays waiting on a release of a dependency. > > Mark > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56530] WebappClassLoader.loadClass synchronization issue due to coarse lock at WebappClassLoader instance level instead of been by class name
https://issues.apache.org/bugzilla/show_bug.cgi?id=56530 Sebastien Tardif changed: What|Removed |Added CC||sebtar...@ncf.ca OS||All --- Comment #1 from Sebastien Tardif --- The same exact application didn't have the issue with GlassFish 3.x latest. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot failure in ASF Buildbot on tomcat-trunk
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/76 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/trunk] 1594811 Blamelist: markt BUILD FAILED: failed compile_1 sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56516] VariableInfo doesn't handle scope changes correctly
https://issues.apache.org/bugzilla/show_bug.cgi?id=56516 --- Comment #7 from Remy Maucherat --- I also think this is invalid, although I am not the biggest expert on JSPs. The Javadoc for scopes says: /** * Scope information that scripting variable is visible only within the * start/end tags. */ public static final int NESTED = 0; /** * Scope information that scripting variable is visible after start tag. */ public static final int AT_BEGIN = 1; /** * Scope information that scripting variable is visible after end tag. */ public static final int AT_END = 2; So for NESTED, declaring at the beginning cannot be right, and Konstantin's example should probably work. For the other two, it's about the same, there's nothing which indicates the variable should be visible before the tag, and since the scriptlets nesting is not visible, there's no solution to that. Note: In the example given, the scope is 1 (AT_BEGIN). -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot exception in ASF Buildbot on tomcat-trunk
The Buildbot has detected a build exception on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/79 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/trunk] 1595171 Blamelist: violetagg BUILD FAILED: exception compile_1 upload_2 sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56536] HttpSessionBindingListener.valueUnbound uses wrong classloader when SingleSignOn valve is used
https://issues.apache.org/bugzilla/show_bug.cgi?id=56536 --- Comment #3 from Mark Thomas --- Scratch that. It isn't that bad. Most of these methods are triggered by web app code so the class loader is already correct. I still think extending the coverage will have undesirable side-effects. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1595289 - /tomcat/trunk/java/org/apache/jasper/compiler/Validator.java
Author: kkolinko
Date: Fri May 16 18:31:33 2014
New Revision: 1595289
URL: http://svn.apache.org/r1595289
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56529
Review of r1595174:
1. Call iterator() once. It creates an object, so it is better do not waste
such calls.
2. Style issues:
- "" does not make sense as 'generic' default for textAttributeValue. It makes
sense for this specific case only.
- 3 spaces indent -> 4 spaces
Modified:
tomcat/trunk/java/org/apache/jasper/compiler/Validator.java
Modified: tomcat/trunk/java/org/apache/jasper/compiler/Validator.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/Validator.java?rev=1595289&r1=1595288&r2=1595289&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/compiler/Validator.java (original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/Validator.java Fri May 16
18:31:33 2014
@@ -1124,12 +1124,16 @@ class Validator {
// When attribute is not an expression,
// contains its textual value with \$ and \# escaping removed.
-String textAttributeValue = "";
+String textAttributeValue;
if (!elExpression && el != null) {
// Should be a single Text node
- if(el.iterator().hasNext()) {
- textAttributeValue = ((ELNode.Text)
el.iterator().next()).getText();
- }
+Iterator it = el.iterator();
+if (it.hasNext()) {
+textAttributeValue = ((ELNode.Text) it.next())
+.getText();
+} else {
+textAttributeValue = "";
+}
} else {
textAttributeValue = xmlAttributeValue;
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1595285 - in /tomcat/trunk: java/org/apache/catalina/session/StandardSession.java webapps/docs/changelog.xml
Author: markt
Date: Fri May 16 18:27:25 2014
New Revision: 1595285
URL: http://svn.apache.org/r1595285
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56536
Ensure that HttpSessionBindingListener.valueUnbound() uses the correct class
loader when the SingleSignOn valve is used.
Modified:
tomcat/trunk/java/org/apache/catalina/session/StandardSession.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/catalina/session/StandardSession.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/session/StandardSession.java?rev=1595285&r1=1595284&r2=1595285&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/session/StandardSession.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/session/StandardSession.java Fri May
16 18:27:25 2014
@@ -826,10 +826,10 @@ public class StandardSession implements
// The call to expire() may not have been triggered by the webapp.
// Make sure the webapp's class loader is set when calling the
// listeners
-ClassLoader oldContextClassLoader = null;
-try {
-oldContextClassLoader =
context.bind(Globals.IS_SECURITY_ENABLED, null);
-if (notify) {
+if (notify) {
+ClassLoader oldContextClassLoader = null;
+try {
+oldContextClassLoader =
context.bind(Globals.IS_SECURITY_ENABLED, null);
Object listeners[] =
context.getApplicationLifecycleListeners();
if (listeners != null && listeners.length > 0) {
HttpSessionEvent event =
@@ -859,9 +859,9 @@ public class StandardSession implements
}
}
}
+} finally {
+context.unbind(Globals.IS_SECURITY_ENABLED,
oldContextClassLoader);
}
-} finally {
-context.unbind(Globals.IS_SECURITY_ENABLED,
oldContextClassLoader);
}
if (ACTIVITY_CHECK) {
@@ -894,9 +894,15 @@ public class StandardSession implements
// Unbind any objects associated with this session
String keys[] = keys();
-for (int i = 0; i < keys.length; i++)
-removeAttributeInternal(keys[i], notify);
-
+ClassLoader oldContextClassLoader = null;
+try {
+oldContextClassLoader =
context.bind(Globals.IS_SECURITY_ENABLED, null);
+for (int i = 0; i < keys.length; i++) {
+removeAttributeInternal(keys[i], notify);
+}
+} finally {
+context.unbind(Globals.IS_SECURITY_ENABLED,
oldContextClassLoader);
+}
}
}
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1595285&r1=1595284&r2=1595285&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Fri May 16 18:27:25 2014
@@ -45,6 +45,15 @@
issues to not "pop up" wrt. others).
-->
+
+
+
+ 56536: Ensure that
+ HttpSessionBindingListener.valueUnbound() uses the correct
+ class loader when the SingleSignOn valve is used. (markt)
+
+
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56536] HttpSessionBindingListener.valueUnbound uses wrong classloader when SingleSignOn valve is used
https://issues.apache.org/bugzilla/show_bug.cgi?id=56536 Mark Thomas changed: What|Removed |Added OS||All --- Comment #2 from Mark Thomas --- Hmm. The problem is wider than that. There are a number of places where the application listener is called with the wrong class loader. Simply extending the use of the webapp class loader will cause container listeners to be fired with the wrong listener. A more fine-grained approach is required. I'm taking a look now. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r5364 - /dev/tomcat/tomcat-8/v8.0.7/
Author: markt Date: Fri May 16 17:28:04 2014 New Revision: 5364 Log: Drop 8.0.7 Removed: dev/tomcat/tomcat-8/v8.0.7/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r5357 - /dev/tomcat/tomcat-8/v8.0.6/
Author: markt Date: Thu May 15 15:06:04 2014 New Revision: 5357 Log: Drop cancelled 8.0.6 release Removed: dev/tomcat/tomcat-8/v8.0.6/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.6
Seems https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.6/ is private as I do get a "Not Found" -- Jeanfrancois On 2014-05-14, 7:39 AM, Mark Thomas wrote: The proposed Apache Tomcat 8.0.6 release is now available for voting. The main changes since 8.0.5 are: - Further NIO2 fixes which is now considered BETA - Extend and improve memory leak protection and fix a few leaks that crept in during the various refactorings - Lots of general bug fixes It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.6/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1011/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_6/ The proposed 8.0.6 release is: [ ] Broken - do not release [ ] Alpha - go ahead and release as 8.0.6 (alpha) [ ] Beta - go ahead and release as 8.0.6 (beta) [ ] Stable - go ahead and release as 8.0.6 (stable) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56529] NoSuchElementException for attribute with empty string in custom tag
https://issues.apache.org/bugzilla/show_bug.cgi?id=56529 Violeta Georgieva changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Violeta Georgieva --- Thanks for the report and the patch. This has been fixed in trunk for 8.0.7 and in 7.0.x for 7.0.54 onwards. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.6
Hi, 2014-05-16 11:51 GMT+03:00 Violeta Georgieva : > > 2014-05-15 17:40 GMT+03:00 Violeta Georgieva : > > > > > > > Hi, > > > > 2014-05-14 14:39 GMT+03:00 Mark Thomas : > > > > > > > > The proposed Apache Tomcat 8.0.6 release is now available for voting. > > > > > > The main changes since 8.0.5 are: > > > - Further NIO2 fixes which is now considered BETA > > > - Extend and improve memory leak protection and fix a few leaks that > > > crept in during the various refactorings > > > - Lots of general bug fixes > > > > > > > > > It can be obtained from: > > > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.6/ > > > The Maven staging repo is: > > > https://repository.apache.org/content/repositories/orgapachetomcat-1011/ > > > The svn tag is: > > > http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_6/ > > > > > > The proposed 8.0.6 release is: > > > [ ] Broken - do not release > > > [ ] Alpha - go ahead and release as 8.0.6 (alpha) > > > [ ] Beta - go ahead and release as 8.0.6 (beta) > > > [ ] Stable - go ahead and release as 8.0.6 (stable) > > > > I see a regression in Jasper. (may be this revision 1590842) > > I'll try to extract a simple example. It is about where the body is missing. > > I'm attaching the test case. > Request it like this http://localhost:8080/tags/test.jsp The root cause was different - a problem with attributes in custom tags that have empty string as value. The issue was also reported with Bug 56529. Fix is available with r1595171. Regards Violeta > > > According to the spec the value of the attribute would be "". > > > > java.util.NoSuchElementException > > at java.util.ArrayList$Itr.next(ArrayList.java:834) > > at org.apache.jasper.compiler.Validator$ValidateVisitor.checkXmlAttributes(Validator.java:1130) > > at org.apache.jasper.compiler.Validator$ValidateVisitor.visit(Validator.java:879) > > at org.apache.jasper.compiler.Node$CustomTag.accept(Node.java:1521) > > at org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2361) > > at org.apache.jasper.compiler.Node$Visitor.visitBody(Node.java:2413) > > at org.apache.jasper.compiler.Node$Visitor.visit(Node.java:2419) > > at org.apache.jasper.compiler.Node$Root.accept(Node.java:464) > > at org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2361) > > at org.apache.jasper.compiler.Validator.validateExDirectives(Validator.java:1837) > > at org.apache.jasper.compiler.Compiler.generateJava(Compiler.java:217) > > at org.apache.jasper.compiler.Compiler.compile(Compiler.java:356) > > at org.apache.jasper.compiler.Compiler.compile(Compiler.java:336) > > at org.apache.jasper.compiler.Compiler.compile(Compiler.java:323) > > at org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:564) > > at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:357) > > at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:403) > > at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:347) > > at javax.servlet.http.HttpServlet.service(HttpServlet.java:725) > > at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:301) > > at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) > > at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52) > > at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:239) > > > > > > Regards > > Violeta
[Bug 56516] VariableInfo doesn't handle scope changes correctly
https://issues.apache.org/bugzilla/show_bug.cgi?id=56516 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #5 from Mark Thomas --- Specification issue: https://java.net/jira/browse/JSP-42 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: apis @asf
Hi svn copy would be at least a nice solution to avoid kind of forks For sure would be great to aligned it both impl. I think geronimo is the place since most of project are using these APIs (tomee, openejb, openwebbeans, bval, jcs soon, openjpa, ...) about the bug the type parameter resolution is not done in resolver where before invoke was passing correct types. Didnt check the spec about it. Not sure the work needed to go this way, any idea how we can go further? Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-05-16 16:32 GMT+02:00 Mark Thomas : > On 16/05/2014 07:59, Romain Manni-Bucau wrote: >> Hello guys, >> >> Hope I didnt miss a thread dealing with it, if so please just redirect me. >> >> Tomcat made the choice to do its own API jars. That's not a big deal >> by itself but wonder why not putting them with all "EE" api jars of >> Apache, ie in geronimo specs subproject: >> http://svn.apache.org/repos/asf/geronimo/specs/trunk/ > > I suspect it stems from the fact the Tomcat was originally the reference > implementation for a number of those. > >> It concerns mainly: >> * el >> * websocket >> * jsp >> * servlet >> >> Just to give you a bit more background, this question doesn't come >> from nowhere. In TomEE we use geronimo API for almost everything >> excepted some tomcat provided apis (servlet, jsp) until today. But >> since recent Tomcat 7 got - thanks to Tomcat 8 - a refactoring of EL >> part, geronimo-el and tomcat-el were no more compatible. In other >> words TomEE was broken cause AstValue was refactored and method >> matching more dedicated to BeanELResolver in tomcat but not in >> geronimo. > > Doesn't that simply mean that the refactoring in Tomcat has exposed a > bug in the Geronimo EL API? > >> Wonder if we should/can try to get something consistent accross ASF. > > Assuming that Geronimo is using the Tomcat implementations I wonder why > the project felt the need to produce their own API JARs. Or are they > just (old?) copies taken from Tomcat originally? > >> wdyt? > > From experience with re-using components from Commons, Tomcat would > almost certainly want to keep a local copy - even if that was an svn > copy of some common version - else releases can start to experience > noticeable delays waiting on a release of a dependency. > > Mark > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56529] NoSuchElementException for attribute with empty string in custom tag
https://issues.apache.org/bugzilla/show_bug.cgi?id=56529 Violeta Georgieva changed: What|Removed |Added Attachment #31628|0 |1 is patch|| -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56530] WebappClassLoader.loadClass synchronization issue due to coarse lock at WebappClassLoader instance level instead of been by class name
https://issues.apache.org/bugzilla/show_bug.cgi?id=56530 --- Comment #2 from Sebastien Tardif --- The same issues happen to others -> https://groups.google.com/forum/#!topic/optiq-dev/amCEv1psDrI -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1595171 - in /tomcat/trunk: java/org/apache/jasper/compiler/Validator.java webapps/docs/changelog.xml
Author: violetagg
Date: Fri May 16 12:07:08 2014
New Revision: 1595171
URL: http://svn.apache.org/r1595171
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56529
Fixed NoSuchElementException while handling attributes with empty string value
in custom tags. Patch provided by Hariprasad Manchi.
Modified:
tomcat/trunk/java/org/apache/jasper/compiler/Validator.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/jasper/compiler/Validator.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/Validator.java?rev=1595171&r1=1595170&r2=1595171&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/compiler/Validator.java (original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/Validator.java Fri May 16
12:07:08 2014
@@ -1124,14 +1124,15 @@ class Validator {
// When attribute is not an expression,
// contains its textual value with \$ and \# escaping removed.
-String textAttributeValue;
+String textAttributeValue = "";
if (!elExpression && el != null) {
// Should be a single Text node
-textAttributeValue = ((ELNode.Text)
el.iterator().next()).getText();
+ if(el.iterator().hasNext()) {
+ textAttributeValue = ((ELNode.Text)
el.iterator().next()).getText();
+ }
} else {
textAttributeValue = xmlAttributeValue;
}
-
for (int j = 0; tldAttrs != null && j < tldAttrs.length; j++) {
if (attrs.getLocalName(i).equals(tldAttrs[j].getName())
&& (attrs.getURI(i) == null
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1595171&r1=1595170&r2=1595171&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Fri May 16 12:07:08 2014
@@ -70,6 +70,11 @@
place such as a null string being coerced to an empty
string. (markt)
+
+56529: Avoid NoSuchElementException while
handling
+attributes with empty string value in custom tags. Patch provided by
+Hariprasad Manchi. (violetagg)
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56529] New: NoSuchElementException for attribute with empty string in custom tag
https://issues.apache.org/bugzilla/show_bug.cgi?id=56529 Bug ID: 56529 Summary: NoSuchElementException for attribute with empty string in custom tag Product: Tomcat 8 Version: trunk Hardware: PC Status: NEW Severity: normal Priority: P2 Component: Jasper Assignee: dev@tomcat.apache.org Reporter: hariprasad...@gmail.com Created attachment 31628 --> https://issues.apache.org/bugzilla/attachment.cgi?id=31628&action=edit patch for Validator.java Hi team, I was verifying the fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=56481 and found one issue with respect to custom tag libraries. A tld has an attribute which could be an empty string. Example is below. Here 'indicator' attribute is provided as "". However, while compiling this in jsp resulted in the following exception: message Unable to compile class for JSP description The server encountered an internal error that prevented it from fulfilling this request. exception org.apache.jasper.JasperException: Unable to compile class for JSP org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:579) org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:357) org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:403) org.apache.jasper.servlet.JspServlet.service(JspServlet.java:347) javax.servlet.http.HttpServlet.service(HttpServlet.java:725) root cause java.util.NoSuchElementException java.util.ArrayList$Itr.next(ArrayList.java:834) org.apache.jasper.compiler.Validator$ValidateVisitor.checkXmlAttributes(Validator.java:1132) org.apache.jasper.compiler.Validator$ValidateVisitor.visit(Validator.java:879) org.apache.jasper.compiler.Node$CustomTag.accept(Node.java:1521) org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2361) org.apache.jasper.compiler.Node$Visitor.visitBody(Node.java:2413) org.apache.jasper.compiler.Node$Visitor.visit(Node.java:2419) org.apache.jasper.compiler.Node$Root.accept(Node.java:464) org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2361) org.apache.jasper.compiler.Validator.validateExDirectives(Validator.java:1840) org.apache.jasper.compiler.Compiler.generateJava(Compiler.java:217) org.apache.jasper.compiler.Compiler.compile(Compiler.java:356) org.apache.jasper.compiler.Compiler.compile(Compiler.java:336) org.apache.jasper.compiler.Compiler.compile(Compiler.java:323) org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:564) org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:357) org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:403) org.apache.jasper.servlet.JspServlet.service(JspServlet.java:347) javax.servlet.http.HttpServlet.service(HttpServlet.java:725) note The full stack trace of the root cause is available in the Apache Tomcat/@VERSION@ logs. By looking into the source of Validator.java I observed that for the empty string we get the ELNode iterator but there isn't a check to see if the element has next node or not. The call ((ELNode.Text) el.iterator().next()).getText(); results in the above exception. I added a test to see if the element has next node and it worked fine. Attached is the patch for your reference. Regards, Hariprasad -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.6
On 16/05/2014 13:42, Jeanfrancois Arcand wrote: > Seems > > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.6/ > > is private as I do get a "Not Found" I'd already dropped 8.0.6 in favour of 8.0.7. Looks like we will need a 8.0.8. Mark > > -- Jeanfrancois > > On 2014-05-14, 7:39 AM, Mark Thomas wrote: >> The proposed Apache Tomcat 8.0.6 release is now available for voting. >> >> The main changes since 8.0.5 are: >> - Further NIO2 fixes which is now considered BETA >> - Extend and improve memory leak protection and fix a few leaks that >>crept in during the various refactorings >> - Lots of general bug fixes >> >> >> It can be obtained from: >> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.6/ >> The Maven staging repo is: >> https://repository.apache.org/content/repositories/orgapachetomcat-1011/ >> The svn tag is: >> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_6/ >> >> The proposed 8.0.6 release is: >> [ ] Broken - do not release >> [ ] Alpha - go ahead and release as 8.0.6 (alpha) >> [ ] Beta - go ahead and release as 8.0.6 (beta) >> [ ] Stable - go ahead and release as 8.0.6 (stable) >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >> For additional commands, e-mail: dev-h...@tomcat.apache.org >> > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1595246 - /tomcat/trunk/webapps/docs/changelog.xml
Author: markt Date: Fri May 16 15:54:57 2014 New Revision: 1595246 URL: http://svn.apache.org/r1595246 Log: Update changelog Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1595246&r1=1595245&r2=1595246&view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Fri May 16 15:54:57 2014 @@ -44,7 +44,18 @@ They eventually become mixed with the numbered issues. (I.e., numbered issues to not "pop up" wrt. others). --> - + + + + +56529: Avoid NoSuchElementException while handling +attributes with empty string value in custom tags. Patch provided by +Hariprasad Manchi. (violetagg) + + + + + @@ -70,11 +81,6 @@ place such as a null string being coerced to an empty string. (markt) - -56529: Avoid NoSuchElementException while handling -attributes with empty string value in custom tags. Patch provided by -Hariprasad Manchi. (violetagg) - @@ -86,7 +92,7 @@ - + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56530] WebappClassLoader.loadClass synchronization issue due to coarse lock at WebappClassLoader instance level instead of been by class name
https://issues.apache.org/bugzilla/show_bug.cgi?id=56530 --- Comment #3 from Mark Thomas --- The partial stack trace is largely useless since it does not show what the critical thread (http-bio-31680-exec-41) is doing. When considering any proposed changes, keep this in mind: http://svn.apache.org/viewvc?view=revision&revision=927565 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.6
Hi, 2014-05-14 14:39 GMT+03:00 Mark Thomas : > > The proposed Apache Tomcat 8.0.6 release is now available for voting. > > The main changes since 8.0.5 are: > - Further NIO2 fixes which is now considered BETA > - Extend and improve memory leak protection and fix a few leaks that > crept in during the various refactorings > - Lots of general bug fixes > > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.6/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1011/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_6/ > > The proposed 8.0.6 release is: > [ ] Broken - do not release > [ ] Alpha - go ahead and release as 8.0.6 (alpha) > [ ] Beta - go ahead and release as 8.0.6 (beta) > [ ] Stable - go ahead and release as 8.0.6 (stable) I see a regression in Jasper. (may be this revision 1590842) I'll try to extract a simple example. It is about where the body is missing. According to the spec the value of the attribute would be "". java.util.NoSuchElementException at java.util.ArrayList$Itr.next(ArrayList.java:834) at org.apache.jasper.compiler.Validator$ValidateVisitor.checkXmlAttributes(Validator.java:1130) at org.apache.jasper.compiler.Validator$ValidateVisitor.visit(Validator.java:879) at org.apache.jasper.compiler.Node$CustomTag.accept(Node.java:1521) at org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2361) at org.apache.jasper.compiler.Node$Visitor.visitBody(Node.java:2413) at org.apache.jasper.compiler.Node$Visitor.visit(Node.java:2419) at org.apache.jasper.compiler.Node$Root.accept(Node.java:464) at org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2361) at org.apache.jasper.compiler.Validator.validateExDirectives(Validator.java:1837) at org.apache.jasper.compiler.Compiler.generateJava(Compiler.java:217) at org.apache.jasper.compiler.Compiler.compile(Compiler.java:356) at org.apache.jasper.compiler.Compiler.compile(Compiler.java:336) at org.apache.jasper.compiler.Compiler.compile(Compiler.java:323) at org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:564) at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:357) at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:403) at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:347) at javax.servlet.http.HttpServlet.service(HttpServlet.java:725) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:301) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:239) Regards Violeta
[jira] [Commented] (MTOMCAT-127) tomcat:run - Configuring Logging with JULI
[ https://issues.apache.org/jira/browse/MTOMCAT-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999844#comment-13999844 ] Alex Wajda commented on MTOMCAT-127: I am also voting for resolving the issue. We use embedded Tomcat for our integration testing on TeamCity which parses the build log, extracting errors and warnings in Log4J format, but it doesn't seem to understand the java logging output format. It would be very helpful to be able to customize the Tomcat output for better integration with different (not just TeamCity) automated building tools. > tomcat:run - Configuring Logging with JULI > --- > > Key: MTOMCAT-127 > URL: https://issues.apache.org/jira/browse/MTOMCAT-127 > Project: Apache Tomcat Maven Plugin > Issue Type: New Feature > Components: tomcat6, tomcat7 >Affects Versions: 2.0 >Reporter: Cédric Couralet >Assignee: Olivier Lamy (*$^¨%`£) >Priority: Minor > Fix For: backlog > > Attachments: mtomcat-127.zip > > > The configuration for a custom logging.properties is not taken into account > with the tomcat6-7:run goal. > From what I've seen, the reason is that the configuration for > java.util.logging is done before setting the system properties in the same > class loader. > I think it could be fixed by putting a call to > LogManager.getLogManager().readConfiguration(); right after setting the > system properties. I'm not confident enough on the possible side effects to > say it is the best solution. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: apis @asf
On 16/05/2014 07:59, Romain Manni-Bucau wrote: > Hello guys, > > Hope I didnt miss a thread dealing with it, if so please just redirect me. > > Tomcat made the choice to do its own API jars. That's not a big deal > by itself but wonder why not putting them with all "EE" api jars of > Apache, ie in geronimo specs subproject: > http://svn.apache.org/repos/asf/geronimo/specs/trunk/ I suspect it stems from the fact the Tomcat was originally the reference implementation for a number of those. > It concerns mainly: > * el > * websocket > * jsp > * servlet > > Just to give you a bit more background, this question doesn't come > from nowhere. In TomEE we use geronimo API for almost everything > excepted some tomcat provided apis (servlet, jsp) until today. But > since recent Tomcat 7 got - thanks to Tomcat 8 - a refactoring of EL > part, geronimo-el and tomcat-el were no more compatible. In other > words TomEE was broken cause AstValue was refactored and method > matching more dedicated to BeanELResolver in tomcat but not in > geronimo. Doesn't that simply mean that the refactoring in Tomcat has exposed a bug in the Geronimo EL API? > Wonder if we should/can try to get something consistent accross ASF. Assuming that Geronimo is using the Tomcat implementations I wonder why the project felt the need to produce their own API JARs. Or are they just (old?) copies taken from Tomcat originally? > wdyt? >From experience with re-using components from Commons, Tomcat would almost certainly want to keep a local copy - even if that was an svn copy of some common version - else releases can start to experience noticeable delays waiting on a release of a dependency. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.6
2014-05-16 14:42 GMT+02:00 Jeanfrancois Arcand : > Seems > > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.6/ > > is private as I do get a "Not Found" > > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.7/ But I would have waited a bit for some more testing. Rémy
svn commit: r1594924 - in /tomcat/trunk: java/org/apache/catalina/connector/CoyoteAdapter.java webapps/docs/changelog.xml
Author: kkolinko
Date: Thu May 15 14:17:05 2014
New Revision: 1594924
URL: http://svn.apache.org/r1594924
Log:
Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=56399
Simplify. Reduce logging level.
Update changelog (this change was omitted from 8.0.6).
Modified:
tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java?rev=1594924&r1=1594923&r2=1594924&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java Thu May
15 14:17:05 2014
@@ -665,18 +665,16 @@ public class CoyoteAdapter implements Ad
Request request = (Request) req.getNote(ADAPTER_NOTES);
Response response = (Response) res.getNote(ADAPTER_NOTES);
try {
-if (request != null) {
-if (request.getContext() != null || request.getHost() != null)
-throw new RecycleRequiredException();
-}
-if (response != null) {
-if (response.getContentWritten() != 0)
-throw new RecycleRequiredException();
+if (request != null && request.getHost() != null) {
+throw new RecycleRequiredException();
+}
+if (response != null && response.getContentWritten() != 0) {
+throw new RecycleRequiredException();
}
} catch (RecycleRequiredException e) {
String message = sm.getString("coyoteAdapter.checkRecycled");
if (connector.getState().isAvailable()) {
-log.warn(message, e);
+log.info(message, e);
} else {
// There may be some aborted requests.
// When connector shuts down, the request and response will not
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1594924&r1=1594923&r2=1594924&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Thu May 15 14:17:05 2014
@@ -54,6 +54,14 @@
+
+
+
+56399: Assert that both Coyote and Catalina request objects
+have been properly recycled. (kkolinko)
+
+
+
@@ -246,10 +254,6 @@
56348: Fix slow asynchronous read when read was performed on
a non-container thread. (markt)
-
-56399: Assert that both Coyote and Catalina request objects
-have been properly recycled. (kkolinko)
-
56416: Correct documentation for default value of socket
linger for the AJP and HTTP connectors. (markt)
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1594943 - in /tomcat/tc6.0.x/trunk: build.properties.default res/maven/mvn.properties.default
Author: markt Date: Thu May 15 15:13:11 2014 New Revision: 1594943 URL: http://svn.apache.org/r1594943 Log: Prep for next release Modified: tomcat/tc6.0.x/trunk/build.properties.default tomcat/tc6.0.x/trunk/res/maven/mvn.properties.default Modified: tomcat/tc6.0.x/trunk/build.properties.default URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/build.properties.default?rev=1594943&r1=1594942&r2=1594943&view=diff == --- tomcat/tc6.0.x/trunk/build.properties.default (original) +++ tomcat/tc6.0.x/trunk/build.properties.default Thu May 15 15:13:11 2014 @@ -25,7 +25,7 @@ # - Version Control Flags - version.major=6 version.minor=0 -version.build=40 +version.build=41 version.patch=0 version.suffix=-dev Modified: tomcat/tc6.0.x/trunk/res/maven/mvn.properties.default URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/res/maven/mvn.properties.default?rev=1594943&r1=1594942&r2=1594943&view=diff == --- tomcat/tc6.0.x/trunk/res/maven/mvn.properties.default (original) +++ tomcat/tc6.0.x/trunk/res/maven/mvn.properties.default Thu May 15 15:13:11 2014 @@ -35,7 +35,7 @@ maven.asf.release.repo.url=https://repos maven.asf.release.repo.repositoryId=apache.releases # Release version info -maven.asf.release.deploy.version=6.0.40 +maven.asf.release.deploy.version=6.0.41 #Where do we load the libraries from tomcat.lib.path=../../output/build/lib - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1594942 - in /tomcat/trunk: build.properties.default res/maven/mvn.properties.default
Author: markt Date: Thu May 15 15:12:41 2014 New Revision: 1594942 URL: http://svn.apache.org/r1594942 Log: Prep for next release Modified: tomcat/trunk/build.properties.default tomcat/trunk/res/maven/mvn.properties.default Modified: tomcat/trunk/build.properties.default URL: http://svn.apache.org/viewvc/tomcat/trunk/build.properties.default?rev=1594942&r1=1594941&r2=1594942&view=diff == --- tomcat/trunk/build.properties.default (original) +++ tomcat/trunk/build.properties.default Thu May 15 15:12:41 2014 @@ -25,7 +25,7 @@ # - Version Control Flags - version.major=8 version.minor=0 -version.build=6 +version.build=7 version.patch=0 version.suffix=-dev Modified: tomcat/trunk/res/maven/mvn.properties.default URL: http://svn.apache.org/viewvc/tomcat/trunk/res/maven/mvn.properties.default?rev=1594942&r1=1594941&r2=1594942&view=diff == --- tomcat/trunk/res/maven/mvn.properties.default (original) +++ tomcat/trunk/res/maven/mvn.properties.default Thu May 15 15:12:41 2014 @@ -35,7 +35,7 @@ maven.asf.release.repo.url=https://repos maven.asf.release.repo.repositoryId=apache.releases # Release version info -maven.asf.release.deploy.version=8.0.6 +maven.asf.release.deploy.version=8.0.7 #Where do we load the libraries from tomcat.lib.path=../../output/build/lib - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56530] WebappClassLoader.loadClass synchronization issue due to coarse lock at WebappClassLoader instance level instead of been by class name
https://issues.apache.org/bugzilla/show_bug.cgi?id=56530 --- Comment #4 from Sebastien Tardif --- Thanks for the link. It does mentions for an attempt to provide parallel classloading for Tomcat 7 but that doesn't seem to have happened. http-bio-31680-exec-41 is running loading a class. Any of the stack below will come to that state at some point. So you can pick anyone as a representative of http-bio-31680-exec-41. My application does work, it's just 15x slower than with GlassFish. The thread dump was provided to show that we do have different code doing class lookup, about different classes, all waiting. The code triggering loading is not custom but JDK JAXB. My understanding is that the problem is well understood, so a use case is not adding anything here. Everybody know it's creating problems, that doesn't look good, but it have been declared too hard to fix, and so progress stopped 4 years ago. Previous deadlock issues may have been related to Java JDK version before 7 -> http://docs.oracle.com/javase/7/docs/technotes/guides/lang/cl-mt.html Optimized class loader -> https://github.com/jboss-modules/jboss-modules/blob/master/src/main/java/org/jboss/modules/ConcurrentClassLoader.java Java 7 was release July 28, 2011. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56516] VariableInfo doesn't handle scope changes correctly
https://issues.apache.org/bugzilla/show_bug.cgi?id=56516 --- Comment #6 from ad...@moparisthebest.com --- I also tend to agree that declaring the variable once at the beginning *probably* isn't the right solution, however I think the way this is currently handled is still wrong. Right now the variable is only declared once, but in whatever scope it is used in first, so if it's in a small scope at the beginning and you declare the tag anywhere else later it breaks. I think a better behavior would be to declare it everytime the tag is used, so if people need to put smaller scopes around their tags it's at least a decent work around. I also don't know exactly why variables aren't just declared whenever VariableInfo.getDeclare() is true, it is always in my test case, yet it never gets declared a second time. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56536] New: HttpSessionBindingListener.valueUnbound uses wrong classloader when SingleSignOn valve is used
https://issues.apache.org/bugzilla/show_bug.cgi?id=56536 Bug ID: 56536 Summary: HttpSessionBindingListener.valueUnbound uses wrong classloader when SingleSignOn valve is used Product: Tomcat 7 Version: 7.0.52 Hardware: PC Status: NEW Severity: normal Priority: P2 Component: Catalina Assignee: dev@tomcat.apache.org Reporter: maar...@vanhulsentop.nl Created attachment 31630 --> https://issues.apache.org/bugzilla/attachment.cgi?id=31630&action=edit Reproduction war (including sources inside) We are encountering an issue with the call to the valueUnbound listener of our application. We rely on the SingleSignOn valve (org.apache.catalina.authenticator.SingleSignOn) to invalidate all user sessions for all web applications when the user chooses to logout (session invalidate) on one webapp. It seems that the valueUnboud is always called with the WebappClassLoader of the application where the original Session.invalidate was called. In the SingleSignOn scenario this is not always the webappclassloader. I have added reproduction steps and .wars below. It seems that the HttpSessionListener methods _are_ being called with the correct classloader from org.apache.catalina.session.StandardSession.expire(boolean). The expire method holds functionality to set the classloader to the webapp classloader, and restore it after calling. In the patch i have moved the classloader restore code down. This makes that also the valueUnbound calls are now done using the right webappclassloader. But i am not sure if this is valid as also a number of internal calls are being executed in the process. I will add the patch in the comments as i can only add a single attachment it seems. = Reproduction = I have created a very small demo project (code to be found in the war). == Preparation == - Use a Tomcat 7 runtime. - Make sure you can login with a user that gets role 'test' by editing /conf/tomcat-users.xml. - Make sure SingleSignOn valve is enabled in server.xml - Place SingleSignOut.war in /webapps/ - Make a copy of this /webapps/SingleSignOut.war to /webapps/SingleSignOut2.war (now you have two web applications that expect a user with role test, and answer to a request on / and on /logout) == Running the repro == - Go to http://localhost:8080/SingleSignOut/ - login: test/test - Go to http://localhost:8080/SingleSignOut2/ - No login needed - Go to http://localhost:8080/SingleSignOut2/logout - See the following log on stdout: Calling session invalidate from /SingleSignOut2 using classloader WebappClassLoader context: /SingleSignOut2 delegate: false repositories: /WEB-INF/classes/ --> Parent Classloader: org.apache.catalina.loader.StandardClassLoader@7a1f0683 /SingleSignOut VALUE UNBOUND using classloader WebappClassLoader context: /SingleSignOut2 delegate: false repositories: /WEB-INF/classes/ --> Parent Classloader: org.apache.catalina.loader.StandardClassLoader@7a1f0683 /SingleSignOut2 VALUE UNBOUND using classloader WebappClassLoader context: /SingleSignOut2 delegate: false repositories: /WEB-INF/classes/ --> Parent Classloader: org.apache.catalina.loader.StandardClassLoader@7a1f0683 - Observe that the value unboud for /SingleSignOut is being called with the classloader for /SingleSignOut2! -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56481] Cannot differentiate between the package name and class name in tomcat 8.0.5
https://issues.apache.org/bugzilla/show_bug.cgi?id=56481 --- Comment #6 from Hariprasad Manchi --- Thanks for addressing this issue. I tested it successfully; it's been resolved now. Regards, Hariprasad -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56530] New: WebappClassLoader.loadClass synchronization issue due to coarse lock at WebappClassLoader instance level instead of been by class name
https://issues.apache.org/bugzilla/show_bug.cgi?id=56530 Bug ID: 56530 Summary: WebappClassLoader.loadClass synchronization issue due to coarse lock at WebappClassLoader instance level instead of been by class name Product: Tomcat 7 Version: 7.0.53 Hardware: PC Status: NEW Severity: major Priority: P2 Component: Catalina Assignee: dev@tomcat.apache.org Reporter: sebtar...@ncf.ca I'm having some visible performance issue related to the use of method synchronized loadClass(String name, boolean resolve) in WebappClassLoader I see that the author or at least some of the author(s) of the class WebappClassLoader got the idea in other cases of a more specialize lock than WebappClassLoader instance. Should we just lock here using the name of the class we are looking for? Also we should probably make the distinction between read and write. The scenario here, is classic cache factory synchronization. So we could just copy the right locking pattern from other sources. My partial threads stack dump: 2014-05-14 12:36:01 Full thread dump Java HotSpot(TM) 64-Bit Server VM (20.45-b01 mixed mode): "http-bio-31680-exec-57" - Thread t@124 java.lang.Thread.State: BLOCKED at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1605) - waiting to lock <264d40df> (a org.apache.catalina.loader.WebappClassLoader) owned by "http-bio-31680-exec-41" t@108 at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1571) at com.sun.xml.internal.bind.v2.model.nav.ReflectionNavigator.findClass(ReflectionNavigator.java:505) ... "http-bio-31680-exec-56" - Thread t@123 java.lang.Thread.State: BLOCKED at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1605) - waiting to lock <264d40df> (a org.apache.catalina.loader.WebappClassLoader) owned by "http-bio-31680-exec-41" t@108 at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1571) at com.sun.xml.internal.bind.v2.model.nav.ReflectionNavigator.findClass(ReflectionNavigator.java:505) "http-bio-31680-exec-55" - Thread t@122 java.lang.Thread.State: BLOCKED at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1605) - waiting to lock <264d40df> (a org.apache.catalina.loader.WebappClassLoader) owned by "http-bio-31680-exec-41" t@108 at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1571) at com.sun.xml.internal.bind.v2.model.nav.ReflectionNavigator.findClass(ReflectionNavigator.java:505) Locked ownable synchronizers: - locked <444b3957> (a java.util.concurrent.locks.ReentrantLock$NonfairSync) "http-bio-31680-exec-54" - Thread t@121 java.lang.Thread.State: BLOCKED at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1605) - waiting to lock <264d40df> (a org.apache.catalina.loader.WebappClassLoader) owned by "http-bio-31680-exec-41" t@108 at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1571) at com.sun.org.apache.xerces.internal.utils.ObjectFactory.findProviderClass(ObjectFactory.java:358) "http-bio-31680-exec-53" - Thread t@120 java.lang.Thread.State: BLOCKED at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1605) - waiting to lock <264d40df> (a org.apache.catalina.loader.WebappClassLoader) owned by "http-bio-31680-exec-41" t@108 at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1571) at com.sun.xml.internal.bind.v2.model.nav.ReflectionNavigator.findClass(ReflectionNavigator.java:505) "http-bio-31680-exec-52" - Thread t@119 java.lang.Thread.State: BLOCKED at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1605) - waiting to lock <264d40df> (a org.apache.catalina.loader.WebappClassLoader) owned by "http-bio-31680-exec-41" t@108 at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1571) at com.sun.xml.internal.bind.v2.model.nav.ReflectionNavigator.findClass(ReflectionNavigator.java:505) "http-bio-31680-exec-51" - Thread t@118 java.lang.Thread.State: BLOCKED at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1605) - waiting to lock <264d40df> (a org.apache.catalina.loader.WebappClassLoader) owned by "http-bio-31680-exec-41" t@108 at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1571) at javax.xml.parsers.FactoryFinder.getProviderClass(FactoryFinder.java:119) "http-bio-31680-exec-50" - Thread t@117 java.lang.Thread.State: BLOCKED at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1605) - waiting to lock <264d40df> (a org.apache.catalina.loader.WebappClas
[Bug 56536] HttpSessionBindingListener.valueUnbound uses wrong classloader when SingleSignOn valve is used
https://issues.apache.org/bugzilla/show_bug.cgi?id=56536 --- Comment #1 from Maarten van Hulsentop --- Created attachment 31631 --> https://issues.apache.org/bugzilla/attachment.cgi?id=31631&action=edit Patch where the restoring of the old classloader is deferred. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Commented] (MTOMCAT-127) tomcat:run - Configuring Logging with JULI
[ https://issues.apache.org/jira/browse/MTOMCAT-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999858#comment-13999858 ] Alex Wajda commented on MTOMCAT-127: I tried plugin versions 2.0, 2.1 and 2.2 and different approaches to route logging to an alternative logging framework (e.g. log4j via slf4j): http://stackoverflow.com/a/20476354/96766 http://stackoverflow.com/a/20476229/96766 and finally http://stackoverflow.com/a/5274/96766 Neither worked. > tomcat:run - Configuring Logging with JULI > --- > > Key: MTOMCAT-127 > URL: https://issues.apache.org/jira/browse/MTOMCAT-127 > Project: Apache Tomcat Maven Plugin > Issue Type: New Feature > Components: tomcat6, tomcat7 >Affects Versions: 2.0 >Reporter: Cédric Couralet >Assignee: Olivier Lamy (*$^¨%`£) >Priority: Minor > Fix For: backlog > > Attachments: mtomcat-127.zip > > > The configuration for a custom logging.properties is not taken into account > with the tomcat6-7:run goal. > From what I've seen, the reason is that the configuration for > java.util.logging is done before setting the system properties in the same > class loader. > I think it could be fixed by putting a call to > LogManager.getLogManager().readConfiguration(); right after setting the > system properties. I'm not confident enough on the possible side effects to > say it is the best solution. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
apis @asf
Hello guys, Hope I didnt miss a thread dealing with it, if so please just redirect me. Tomcat made the choice to do its own API jars. That's not a big deal by itself but wonder why not putting them with all "EE" api jars of Apache, ie in geronimo specs subproject: http://svn.apache.org/repos/asf/geronimo/specs/trunk/ It concerns mainly: * el * websocket * jsp * servlet Just to give you a bit more background, this question doesn't come from nowhere. In TomEE we use geronimo API for almost everything excepted some tomcat provided apis (servlet, jsp) until today. But since recent Tomcat 7 got - thanks to Tomcat 8 - a refactoring of EL part, geronimo-el and tomcat-el were no more compatible. In other words TomEE was broken cause AstValue was refactored and method matching more dedicated to BeanELResolver in tomcat but not in geronimo. Wonder if we should/can try to get something consistent accross ASF. wdyt? Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1593257 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/catalina/startup/ test/org/apache/catalina/core/
Author: markt
Date: Thu May 8 13:02:26 2014
New Revision: 1593257
URL: http://svn.apache.org/r1593257
Log:
Make naming context tokens for containers more robust by using a separate object
Modified:
tomcat/trunk/java/org/apache/catalina/Context.java
tomcat/trunk/java/org/apache/catalina/Server.java
tomcat/trunk/java/org/apache/catalina/core/NamingContextListener.java
tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
tomcat/trunk/java/org/apache/catalina/core/StandardServer.java
tomcat/trunk/java/org/apache/catalina/startup/FailedContext.java
tomcat/trunk/test/org/apache/catalina/core/TesterContext.java
Modified: tomcat/trunk/java/org/apache/catalina/Context.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/Context.java?rev=1593257&r1=1593256&r2=1593257&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/Context.java (original)
+++ tomcat/trunk/java/org/apache/catalina/Context.java Thu May 8 13:02:26 2014
@@ -1632,4 +1632,10 @@ public interface Context extends Contain
* The class loader to restore as the thread context class loader
*/
public void unbind(boolean usePrivilegedAction, ClassLoader
originalClassLoader);
+
+/**
+ * Obtain the token necessary for operations on the associated JNDI naming
+ * context.
+ */
+public Object getNamingToken();
}
Modified: tomcat/trunk/java/org/apache/catalina/Server.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/Server.java?rev=1593257&r1=1593256&r2=1593257&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/Server.java (original)
+++ tomcat/trunk/java/org/apache/catalina/Server.java Thu May 8 13:02:26 2014
@@ -206,4 +206,11 @@ public interface Server extends Lifecycl
* @param service The Service to be removed
*/
public void removeService(Service service);
+
+
+/**
+ * Obtain the token necessary for operations on the associated JNDI naming
+ * context.
+ */
+public Object getNamingToken();
}
Modified: tomcat/trunk/java/org/apache/catalina/core/NamingContextListener.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/NamingContextListener.java?rev=1593257&r1=1593256&r2=1593257&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/NamingContextListener.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/core/NamingContextListener.java Thu
May 8 13:02:26 2014
@@ -100,6 +100,10 @@ public class NamingContextListener
*/
protected Object container = null;
+/**
+ * Token for configuring associated JNDI context.
+ */
+private Object token = null;
/**
* Initialized flag.
@@ -214,8 +218,10 @@ public class NamingContextListener
if (container instanceof Context) {
namingResources = ((Context) container).getNamingResources();
logger = log;
+token = ((Context) container).getNamingToken();
} else if (container instanceof Server) {
namingResources = ((Server) container).getGlobalNamingResources();
+token = ((Server) container).getNamingToken();
} else {
return;
}
@@ -231,8 +237,9 @@ public class NamingContextListener
} catch (NamingException e) {
// Never happens
}
-ContextAccessController.setSecurityToken(getName(), container);
-ContextBindings.bindContext(container, namingContext, container);
+ContextAccessController.setSecurityToken(getName(), token);
+ContextAccessController.setSecurityToken(container, token);
+ContextBindings.bindContext(container, namingContext, token);
if( log.isDebugEnabled() ) {
log.debug("Bound " + container );
}
@@ -242,7 +249,7 @@ public class NamingContextListener
getExceptionOnFailedWrite());
// Setting the context in read/write mode
-ContextAccessController.setWritable(getName(), container);
+ContextAccessController.setWritable(getName(), token);
try {
createNamingContext();
@@ -258,9 +265,8 @@ public class NamingContextListener
// Setting the context in read only mode
ContextAccessController.setReadOnly(getName());
try {
-ContextBindings.bindClassLoader
-(container, container,
- ((Context) container).getLoader().getClassLoader());
+ContextBindings.bindClassLoader(container, token,
+((Context)
container).getLoader().getClassLoader());
[Bug 56530] WebappClassLoader.loadClass synchronization issue due to coarse lock at WebappClassLoader instance level instead of been by class name
https://issues.apache.org/bugzilla/show_bug.cgi?id=56530 --- Comment #5 from Sebastien Tardif --- The implementation of GlassFish "working" on JDK 6, is avoiding "systematic" synchronization on the instance, and so that seems to have been enough to be fast, see http://grepcode.com/file/repo1.maven.org/maven2/org.glassfish.web/war-util/3.0/org/glassfish/web/loader/WebappClassLoader.java In other words, they have at least tried to synchronized the smaller block as possible in all cases, and also with dubious construct, used some optimization similar to read/write lock. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[VOTE][CANCELLED] Release Apache Tomcat 8.0.6
On 14/05/2014 12:39, Mark Thomas wrote: > The proposed Apache Tomcat 8.0.6 release is now available for voting. > > The main changes since 8.0.5 are: > - Further NIO2 fixes which is now considered BETA > - Extend and improve memory leak protection and fix a few leaks that > crept in during the various refactorings > - Lots of general bug fixes > > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.6/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1011/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_6/ > > The proposed 8.0.6 release is: > [X] Broken - do not release DBCP is broken due to a missing file. 8.0.7 will follow shortly. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1594811 - in /tomcat/trunk: java/org/apache/jasper/compiler/Generator.java webapps/docs/changelog.xml
Author: markt
Date: Thu May 15 08:04:40 2014
New Revision: 1594811
URL: http://svn.apache.org/r1594811
Log:
Revert fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=56516
Modified:
tomcat/trunk/java/org/apache/jasper/compiler/Generator.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/jasper/compiler/Generator.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/Generator.java?rev=1594811&r1=1594810&r2=1594811&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/compiler/Generator.java (original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/Generator.java Thu May 15
08:04:40 2014
@@ -351,7 +351,7 @@ class Generator {
page.visit(new TagHandlerPoolVisitor(tagHandlerPoolNames));
}
-private void declareScriptingVars(Node.Nodes page)
+private void declareTemporaryScriptingVars(Node.Nodes page)
throws JasperException {
class ScriptingVarVisitor extends Node.Visitor {
@@ -364,13 +364,6 @@ class Generator {
@Override
public void visit(Node.CustomTag n) throws JasperException {
-// Declare scripting variables so they are visible to the
entire
-// page.
-declareScriptingVars(n, VariableInfo.AT_BEGIN);
-declareScriptingVars(n, VariableInfo.AT_END);
-declareScriptingVars(n, VariableInfo.NESTED);
-
-// Declare temporary scripting variables
// XXX - Actually there is no need to declare those
// "_jspx_" + varName + "_" + nestingLevel variables when we
are
// inside a JspFragment.
@@ -421,42 +414,6 @@ class Generator {
visitBody(n);
}
-
-private void declareScriptingVars(Node.CustomTag n, int scope) {
-
-List vec = n.getScriptingVars(scope);
-if (vec != null) {
-for (int i = 0; i < vec.size(); i++) {
-Object elem = vec.get(i);
-if (elem instanceof VariableInfo) {
-VariableInfo varInfo = (VariableInfo) elem;
-if (varInfo.getDeclare()) {
-out.printin(varInfo.getClassName());
-out.print(" ");
-out.print(varInfo.getVarName());
-out.println(" = null;");
-}
-} else {
-TagVariableInfo tagVarInfo = (TagVariableInfo)
elem;
-if (tagVarInfo.getDeclare()) {
-String varName = tagVarInfo.getNameGiven();
-if (varName == null) {
-varName =
n.getTagData().getAttributeString(
-tagVarInfo.getNameFromAttribute());
-} else if (tagVarInfo.getNameFromAttribute()
!= null) {
-// alias
-continue;
-}
-out.printin(tagVarInfo.getClassName());
-out.print(" ");
-out.print(varName);
-out.println(" = null;");
-}
-}
-}
-}
-}
-
}
page.visit(new ScriptingVarVisitor());
@@ -710,7 +667,7 @@ class Generator {
out.printil("javax.servlet.jsp.PageContext _jspx_page_context =
null;");
out.println();
-declareScriptingVars(page);
+declareTemporaryScriptingVars(page);
out.println();
out.printil("try {");
@@ -2278,7 +2235,8 @@ class Generator {
out.println(n.getQName());
n.setBeginJavaLine(out.getJavaLine());
-// Save AT_BEGIN scripting variables
+// Declare AT_BEGIN scripting variables
+declareScriptingVars(n, VariableInfo.AT_BEGIN);
saveScriptingVars(n, VariableInfo.AT_BEGIN);
String tagHandlerClassName = tagHandlerClass.getCanonicalName();
@@ -2333,7 +2291,8 @@ class Generator {
out.println(" != javax.servlet.jsp.tagext.Tag.SKIP_BODY) {");
out.pushIndent();
-// Save NESTED scripting variables
+// Declare NESTED scripting variables
+declareScriptingVars(n, VariableInfo.NESTED);
saveScriptingVars(n, VariableInfo.NESTED);
if (n.implementsBodyTag()) {
@@ -2520,8 +2479,9 @@ class Generator {
out.printil("}");
}
-// synchronize AT
[Bug 56060] Request parameter is intermittently missing
https://issues.apache.org/bugzilla/show_bug.cgi?id=56060 --- Comment #3 from Jess Holle --- I had one such case -- and it was traced down to another thread making calls against a ServletRequest object. There are all sorts of nasty race conditions around this -- ServletRequest objects are explicitly not guaranteed to be thread safe by the serlvet spec and Tomcat's most certainly are not. So I'd first be absolutely certain that you're making no use of ServletRequest objects from other threads than the request handling threads. [And if you absolutely must, then you'll need to be super careful to do all sorts of things just right -- and I'd assume you didn't...] And as others have stated, Bugzilla is not a support forum. Asking about the bug on the mailing lists would be more appropriate than adding comments to it. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1594944 - /tomcat/tc8.0.x/tags/TOMCAT_8_0_7/
Author: markt Date: Thu May 15 15:13:58 2014 New Revision: 1594944 URL: http://svn.apache.org/r1594944 Log: Need to retag 8.0.7 with correct version info Removed: tomcat/tc8.0.x/tags/TOMCAT_8_0_7/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1594931 - in /tomcat/trunk: SVN-MERGE.txt java/org/apache/tomcat/dbcp/dbcp2/LocalStrings.properties webapps/docs/changelog.xml
Author: markt Date: Thu May 15 14:36:46 2014 New Revision: 1594931 URL: http://svn.apache.org/r1594931 Log: Copy missing resources file from Apache Commons DBCP 2 to packaged renamed copy of DBCP 2 Added: tomcat/trunk/java/org/apache/tomcat/dbcp/dbcp2/LocalStrings.properties - copied unchanged from r1594514, commons/proper/dbcp/trunk/src/main/resources/org/apache/commons/dbcp2/LocalStrings.properties Modified: tomcat/trunk/SVN-MERGE.txt tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/SVN-MERGE.txt URL: http://svn.apache.org/viewvc/tomcat/trunk/SVN-MERGE.txt?rev=1594931&r1=1594930&r2=1594931&view=diff == --- tomcat/trunk/SVN-MERGE.txt (original) +++ tomcat/trunk/SVN-MERGE.txt Thu May 15 14:36:46 2014 @@ -34,6 +34,8 @@ org.apache.tomcat.util.bcel is copied fr DBCP org.apache.tomcat.dbcp.dbcp2 is copied from: /commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2 +and +/commons/proper/dbcp/trunk/src/main/resources/org/apache/commons/dbcp2 org.apache.tomcat.dbcp.pool2 is copied from: /commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2 Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1594931&r1=1594930&r2=1594931&view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Thu May 15 14:36:46 2014 @@ -72,6 +72,14 @@ + + + +Copy missing resources file from Apache Commons DBCP 2 to packaged +renamed copy of DBCP 2. (markt) + + + @@ -427,7 +435,7 @@ Javadoc fixes and some code clean up. (markt) -Switch to including Apache Commons DBCP via a package renamed svn copy +Switch to including Apache Commons DBCP via a package renamed svn copy rather than building from a source release for consistency with other Commons packages and to allow faster releases to fix DBCP related issues. (markt) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1594436 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ webapps/docs/
On 14/05/2014 07:48, Rémy Maucherat wrote: > 2014-05-14 2:44 GMT+02:00 : > >> Author: kkolinko >> Date: Wed May 14 00:44:33 2014 >> New Revision: 1594436 >> >> URL: http://svn.apache.org/r1594436 >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56399 >> When recycling a Coyote request, ensure that Catalina request have been >> recycled. >> > > This shouldn't cause regressions (cosmetic or performance). So this needs > to be refined, and shouldn't be committed for now. > > I'll have to -1 this commit until it doesn't cause issues. The code can be > left in instead, but the calls to getAdapter().checkRecycled(request, > response) could be disabled with a system property flag. Konstantin, (bcc'd directly as list mail still seems to be delayed by 8-12 hours) It looks like I am going to need to tag a new 8.0.x release as DBCP is currently broken. Please can you revert this commit as per Remy's veto ASAP so I can tag 8.0.7 without this change present. If r1594436 isn't reverted by the time I come to tag 8.0.7 I will revert it myself (but I'd rather not have to do that). Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1594945 - in /tomcat/tc8.0.x/tags/TOMCAT_8_0_7: ./ build.properties.default
Author: markt Date: Thu May 15 15:14:39 2014 New Revision: 1594945 URL: http://svn.apache.org/r1594945 Log: Tag 8.0.7 Added: tomcat/tc8.0.x/tags/TOMCAT_8_0_7/ - copied from r1594944, tomcat/trunk/ Modified: tomcat/tc8.0.x/tags/TOMCAT_8_0_7/build.properties.default Modified: tomcat/tc8.0.x/tags/TOMCAT_8_0_7/build.properties.default URL: http://svn.apache.org/viewvc/tomcat/tc8.0.x/tags/TOMCAT_8_0_7/build.properties.default?rev=1594945&r1=1594944&r2=1594945&view=diff == --- tomcat/tc8.0.x/tags/TOMCAT_8_0_7/build.properties.default (original) +++ tomcat/tc8.0.x/tags/TOMCAT_8_0_7/build.properties.default Thu May 15 15:14:39 2014 @@ -27,7 +27,7 @@ version.major=8 version.minor=0 version.build=7 version.patch=0 -version.suffix=-dev +version.suffix= # - Build control flags - # Note enabling validation uses Checkstyle which is LGPL licensed - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56529] NoSuchElementException for attribute with empty string in custom tag
https://issues.apache.org/bugzilla/show_bug.cgi?id=56529 Hariprasad Manchi changed: What|Removed |Added OS||All --- Comment #2 from Hariprasad Manchi --- I have also attached a sample web application to reproduce the issue. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot exception in ASF Buildbot on tomcat-7-trunk
The Buildbot has detected a build exception on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/68 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/tc7.0.x/trunk] 1595174 Blamelist: violetagg BUILD FAILED: exception compile_1 upload_2 sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56399] Re-factor request/response recycling so Coyote and Catalina objects are recycled simultaneously
https://issues.apache.org/bugzilla/show_bug.cgi?id=56399 --- Comment #5 from Konstantin Kolinko --- In reply to Mark's e-mail on "Re: r1594436" 2014-05-14 12:02 GMT+04:00 Mark Thomas: > Why is an exception being used for flow control? Surely a boolean flag > would be better here especially as this is being called on every > request. Ack. In some sense those are remnants of older code that I had before simplifying the bits. I do not think those slow down things (as throwing the exceptions is an unexpected use case). I still think that exceptions are needed for the log statements, but we can generate the exceptions only when the log messages are actually written out. As I mentioned in comment 4, it would be better with separate message texts for unrecycled request vs. unrecycled response. (BTW, The mailing list still fails as a place for discussions. This particular message was delayed by 48 hours). 2014-05-14 12:02 GMT+04:00 Mark Thomas: > I remain of the view that a better solution would be to recycle both > pairs of request and response objects at the same time. The idea of "to create a new Recyclable interface in Coyote" (from Comment 0) is not doable. The "notes" in coyote request are opaque. The CoyoteAdapter.ADAPTER_NOTES constant is defined in Catalina only. (In coyote it is mentioned in javadoc for coyote.Request#setNote()). Thus a better solutions looks to introduce some method into Adapter interface. (Or rename and adapt the "checkRecycled()" or "log()" one). Will the recycling driven by Coyote or by Catalina? Will some code from Catalina be removed or simplified? Will the need to recycle accompanied by some action? Will it be possible to backport the changes to earlier versions? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1595174 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/compiler/Validator.java webapps/docs/changelog.xml
Author: violetagg
Date: Fri May 16 12:19:05 2014
New Revision: 1595174
URL: http://svn.apache.org/r1595174
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56529
Merged revision 1595171 from tomcat/trunk:
Fixed NoSuchElementException while handling attributes with empty string value
in custom tags. Patch provided by Hariprasad Manchi.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/Validator.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
Propchange: tomcat/tc7.0.x/trunk/
--
Merged /tomcat/trunk:r1595171
Modified: tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/Validator.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/Validator.java?rev=1595174&r1=1595173&r2=1595174&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/Validator.java
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/Validator.java Fri May
16 12:19:05 2014
@@ -1124,14 +1124,15 @@ class Validator {
// When attribute is not an expression,
// contains its textual value with \$ and \# escaping removed.
-String textAttributeValue;
+String textAttributeValue = "";
if (!elExpression && el != null) {
// Should be a single Text node
-textAttributeValue = ((ELNode.Text)
el.iterator().next()).getText();
+ if(el.iterator().hasNext()) {
+ textAttributeValue = ((ELNode.Text)
el.iterator().next()).getText();
+ }
} else {
textAttributeValue = xmlAttributeValue;
}
-
for (int j = 0; tldAttrs != null && j < tldAttrs.length; j++) {
if (attrs.getLocalName(i).equals(tldAttrs[j].getName())
&& (attrs.getURI(i) == null
Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1595174&r1=1595173&r2=1595174&view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Fri May 16 12:19:05 2014
@@ -215,6 +215,11 @@
by { in order for the back-slash escaping to take effect.
(markt)
+
+56529: Avoid NoSuchElementException while
handling
+attributes with empty string value in custom tags. Patch provided by
+Hariprasad Manchi. (violetagg)
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1594950 - in /tomcat/trunk: build.properties.default res/maven/mvn.properties.default
Author: markt Date: Thu May 15 15:31:52 2014 New Revision: 1594950 URL: http://svn.apache.org/r1594950 Log: Prep for next release Modified: tomcat/trunk/build.properties.default tomcat/trunk/res/maven/mvn.properties.default Modified: tomcat/trunk/build.properties.default URL: http://svn.apache.org/viewvc/tomcat/trunk/build.properties.default?rev=1594950&r1=1594949&r2=1594950&view=diff == --- tomcat/trunk/build.properties.default (original) +++ tomcat/trunk/build.properties.default Thu May 15 15:31:52 2014 @@ -25,7 +25,7 @@ # - Version Control Flags - version.major=8 version.minor=0 -version.build=7 +version.build=8 version.patch=0 version.suffix=-dev Modified: tomcat/trunk/res/maven/mvn.properties.default URL: http://svn.apache.org/viewvc/tomcat/trunk/res/maven/mvn.properties.default?rev=1594950&r1=1594949&r2=1594950&view=diff == --- tomcat/trunk/res/maven/mvn.properties.default (original) +++ tomcat/trunk/res/maven/mvn.properties.default Thu May 15 15:31:52 2014 @@ -35,7 +35,7 @@ maven.asf.release.repo.url=https://repos maven.asf.release.repo.repositoryId=apache.releases # Release version info -maven.asf.release.deploy.version=8.0.7 +maven.asf.release.deploy.version=8.0.8 #Where do we load the libraries from tomcat.lib.path=../../output/build/lib - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56399] Re-factor request/response recycling so Coyote and Catalina objects are recycled simultaneously
https://issues.apache.org/bugzilla/show_bug.cgi?id=56399 --- Comment #4 from Konstantin Kolinko --- (In reply to Remy Maucherat from comment #3) > The commit could be improved (besides trying to identify the problem with > the test): > - no apparent benefit of logging a stacktrace since it does not give any > additional info; if this is done for visibility in logs then I disagree with > that trick The goal here is to protect against unexpected bugs in request handling, as leaking unrecycled request or response has rather bad consequences. The stack trace is needed for us to identify problem code, as there are a dozen of ways in how processor recycling can be triggered. I expect such bugs to be rare and hard to reproduce, thus a stack trace is helpful. As the original cause of the problem is not some condition under administrator's control, but rather some problem in Tomcat code, I agree that using "warning" log level here is a nuisance. That is my fault. I will reduce the logging level to "info". It can be further reduced by help of UserDataHelper, but that strikes me as premature optimization. > - checking the request should be enough (although I would like to get info > if this is meant to try to detect bad async access too, in which case > checking the response commit state is a good idea) The request check can be simplified to check getHost() only. It essentially means that request line has been read and request has been run through Mapper. The response check essentially means that response.outputbuffer has not been recycled. The call returns a sum of two counters. In general request check should be enough. If request check was OK but response one fails, then maybe a) mapping failed (host==null), but some response was written. b) some broken webapp is still holding a reference to response object and is writing some data. As b) is more likely, maybe the response check fail should be treated differently, as it is likely a problem in web application code, not in Tomcat. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1593356 - in /tomcat/trunk: java/org/apache/catalina/core/NamingContextListener.java webapps/docs/changelog.xml
Author: kkolinko
Date: Thu May 8 18:01:35 2014
New Revision: 1593356
URL: http://svn.apache.org/r1593356
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56472#c1
Per my comment on that issue, always set 'NamingContextListener.initialized'
field to 'true'
so that its cleanup on configure_stop event is not skipped.
Modified:
tomcat/trunk/java/org/apache/catalina/core/NamingContextListener.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/catalina/core/NamingContextListener.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/NamingContextListener.java?rev=1593356&r1=1593355&r2=1593356&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/NamingContextListener.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/core/NamingContextListener.java Thu
May 8 18:01:35 2014
@@ -231,98 +231,105 @@ public class NamingContextListener
if (initialized)
return;
-Hashtable contextEnv = new Hashtable<>();
try {
-namingContext = new NamingContext(contextEnv, getName());
-} catch (NamingException e) {
-// Never happens
-}
-ContextAccessController.setSecurityToken(getName(), token);
-ContextAccessController.setSecurityToken(container, token);
-ContextBindings.bindContext(container, namingContext, token);
-if( log.isDebugEnabled() ) {
-log.debug("Bound " + container );
-}
-
-// Configure write when read-only behaviour
-namingContext.setExceptionOnFailedWrite(
-getExceptionOnFailedWrite());
-
-// Setting the context in read/write mode
-ContextAccessController.setWritable(getName(), token);
+Hashtable contextEnv = new Hashtable<>();
+try {
+namingContext = new NamingContext(contextEnv, getName());
+} catch (NamingException e) {
+// Never happens
+}
+ContextAccessController.setSecurityToken(getName(), token);
+ContextAccessController.setSecurityToken(container, token);
+ContextBindings.bindContext(container, namingContext, token);
+if( log.isDebugEnabled() ) {
+log.debug("Bound " + container );
+}
-try {
-createNamingContext();
-} catch (NamingException e) {
-logger.error
-(sm.getString("naming.namingContextCreationFailed", e));
-}
+// Configure write when read-only behaviour
+namingContext.setExceptionOnFailedWrite(
+getExceptionOnFailedWrite());
-namingResources.addPropertyChangeListener(this);
+// Setting the context in read/write mode
+ContextAccessController.setWritable(getName(), token);
-// Binding the naming context to the class loader
-if (container instanceof Context) {
-// Setting the context in read only mode
-ContextAccessController.setReadOnly(getName());
try {
-ContextBindings.bindClassLoader(container, token,
-((Context)
container).getLoader().getClassLoader());
+createNamingContext();
} catch (NamingException e) {
-logger.error(sm.getString("naming.bindFailed", e));
+logger.error
+(sm.getString("naming.namingContextCreationFailed",
e));
}
-}
-if (container instanceof Server) {
-org.apache.naming.factory.ResourceLinkFactory.setGlobalContext
-(namingContext);
-try {
-ContextBindings.bindClassLoader(container, token,
-this.getClass().getClassLoader());
-} catch (NamingException e) {
-logger.error(sm.getString("naming.bindFailed", e));
+namingResources.addPropertyChangeListener(this);
+
+// Binding the naming context to the class loader
+if (container instanceof Context) {
+// Setting the context in read only mode
+ContextAccessController.setReadOnly(getName());
+try {
+ContextBindings.bindClassLoader(container, token,
+((Context)
container).getLoader().getClassLoader());
+} catch (NamingException e) {
+logger.error(sm.getString("naming.bindFailed", e));
+}
}
-
[jira] [Commented] (MTOMCAT-256) Adding maxPostSize to the tomcat connector
[ https://issues.apache.org/jira/browse/MTOMCAT-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13993795#comment-13993795 ] Hudson commented on MTOMCAT-256: SUCCESS: Integrated in TomcatMavenPlugin-mvn3.x #275 (See [https://builds.apache.org/job/TomcatMavenPlugin-mvn3.x/275/]) [MTOMCAT-256] Adding maxPostSize to the tomcat connector Submitted by Matthias Günther (olamy: http://svn.apache.org/viewvc/?view=rev&rev=1558942) * /tomcat/maven-plugin/trunk/src/site/apt/executable-war-jar.apt.vm * /tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/AbstractRunMojo.java * /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractRunMojo.java * /tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7Runner.java * /tomcat/maven-plugin/trunk/tomcat7-war-runner/src/main/java/org/apache/tomcat/maven/runner/Tomcat7RunnerCli.java > Adding maxPostSize to the tomcat connector > -- > > Key: MTOMCAT-256 > URL: https://issues.apache.org/jira/browse/MTOMCAT-256 > Project: Apache Tomcat Maven Plugin > Issue Type: New Feature > Components: tomcat6, tomcat7 >Reporter: Matthias Günther >Assignee: Olivier Lamy (*$^¨%`£) > Fix For: 3.0 > > Attachments: add_param_max_post_size.patch > > > For a project we exceeded the default maxPostSize of the Tomcat's connector > and could not submit our form data. To fix this we just added the parameter > maxPostSize to the tomcat maven plugin and it run as expected. > With the attached patch it will be possible to set the maxPostSize within the > tomcat-maven-plugin configuration. > I used the git trunk (2.3-SNAPSHOT) for the feature implementation. -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot exception in ASF Buildbot on tomcat-trunk
The Buildbot has detected a build exception on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/40 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/trunk] 1593032 Blamelist: remm BUILD FAILED: exception upload_2 sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Time for 6.0.40
The 6.0.x changelog is looking rather long and I have some stuff coming up at $work that would benefit from a 6.0.x release so I plan to start this just as soon as the remaining patch in the status file gets a third vote. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
