Re: Regarding files generated by "JJTree"

[sangeeta lal]

Dear Martin, Mark, Konstantin and dev team,

I highly appreciate you inputs and time. Its a great help for my project.



Thank You
Sangeeta

On Fri, May 20, 2016 at 5:38 PM, Konstantin Kolinko 
wrote:

> 2016-05-20 13:01 GMT+03:00 sangeeta lal :
> > Dear Sir,
> >
> > *Thanks for your reply!*
> >
> > Could you please tell me,  if there is any listing about all the  auto-
> > generated files. I have manually identified 59 files in the folder "
> > *tomcat\java\org\apache\el\parser*" which are auto generated.
>
> ELParser.jjt is the source.
>
> ELParser.java was generated.
> Some helper classes (Node.java, SimpleNode.java, ..) are generated /
> provided by the tool.
>
> The Ast* files - a stub was generated, but the rest is written by a
> human developer.
>
> ELParser.html is a report from generation tool.
>
>
> Java CC site has a manual, with examples.
> https://javacc.java.net/doc/docindex.html
> https://javacc.java.net/doc/JJTree.html
>
> In short, JavaCC is a lexical parser that can perform some Java code
> when some lexical element is encountered. Coupling it with JJTree
> turns that Java code into code that produces a tree of Node elements.
>
> The behaviour of those nodes it then programmed by a human.  My
> understanding is that by default those Ast classes have only a
> constructor, but no other methods.  Some methods are declared in
> SimpleNode class and can be overridden in specific classes, e.g.
> AstIdentifier overrides setImage().
>
> Some of default classes were edited by adding additional methods. E.g.
> methods with an EvaluationContext argument in SimpleNode class were
> added.
>
>
> > I have following two questions:
> >
> > 1. Can tomcat project have auto-generated files in some other folder
> also?
> > 2. Is the "JavaCC" only tool which is used to auto-generate the files ?
> or
> > there are some other tools as well?
> >
>
> There are some classes from other projects that are preprocessed (by
> renaming the packages) and recompiled.
>
> All versions of Tomcat do so for Apache Commons Logging library when
> it is built as an "extras" package.
>
> See  textual replacement, with
>
>  dir="${tomcat.extras}/logging/commons-logging-${commons-logging.version}-src/src/main/java/org/apache/commons"
> encoding="ISO-8859-1">
>value="org.apache.juli" />
> 
>
>
>
> Older versions of Tomcat also did so for Apache Commons Pool and
> Apache Commons DBCP libraries, but Tomcat 8.0 and later has an own
> copy of those libraries in it source tree.
>
>
> This is about *.java files. There is also documentation (xml -> html),
> javadoc (java -> html).
>
>
> The mailing list rules:
> http://tomcat.apache.org/lists.html#tomcat-users
> -> 6. Top-posting is bad.
>
>
> Best regards,
> Konstantin Kolinko
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


-- 
Regards...
Sangeeta
Assistant Professor
CSE Department @JIIT Noida

[Bug 59564] HttpServletRequest.getPart() always returns null with HTTP/2

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59564

--- Comment #2 from Thad Humphries  ---
Rats. I was afraid that's what I'd be told. Is something wrong with my
connector? The cert is self-signed. Does that matter?

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 52952] Improve ExtensionValidator handling for embedded scenarios

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=52952

Abdessamed MANSOURI  changed:

   What|Removed |Added

  Attachment #33813|0   |1
is obsolete||

--- Comment #7 from Abdessamed MANSOURI  ---
Created attachment 33858
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=33858=edit
Patch

I made ExtensionValidator non static and added it to the Server, then from
Context i get it back by walking through the hiararchy.

I made also a global validator which belongs to the JVM, the idea is, if we
couldn't get back the ExtensionValidator registred in the server we use this
global validator (i don't want the server to suffer from NPE).

I have no idea how to write the unit case for ExtensionValidator (currently
there's not test case) because available Extension and ManifestResource are
different from JVM to other.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 59604] Invalid url-pattern in servlet mapping on s390x

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59604

Dave  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 59604] Invalid url-pattern in servlet mapping on s390x

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59604

--- Comment #4 from Dave  ---
Both versions (8.0.33 and 7.0.67) were deployed as-is without any changes,
using the same JAVA_HOME.  7.0.67 runs OK without any problem.

Note: 
z/OS shell is EBCDIC-based but it can support ASCII shell scripts (e.g.,
Tomcat's startup.sh, etc.).  Below is my "init" script to set up the automatic
conversion. 

#!/bin/sh   
export CATALINA_HOME=/u/aes/apache-tomcat-8.0.33
export JAVA_HOME=/usr/lpp/java/J8.0_64  
export _BPXK_AUTOCVT=ON 
chtag -t -c ISO8859-1 $CATALINA_HOME/bin/*.sh

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1744790 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/loader/WebappClassLoaderBase.java

[markt]

Author: markt
Date: Fri May 20 19:36:24 2016
New Revision: 1744790

URL: http://svn.apache.org/viewvc?rev=1744790=rev
Log:
Remove the ResourceBundle memory leak protection since I am as sure as I can be 
that the original report was a false positive. The reasons I think this are:
- The GC roots related to ResourceBundle were all weak references.
- I can no longer produce the leak with the same (newer version) test 
application and Java the original 1.7. If it was a GC bug it is fixed in any 
version of Java that Tomcat 8.5 will use.
- We have a better understanding of JVM bugs that make some GC roots not 
visible in profilers like YourKit.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)

tomcat/tc8.5.x/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri May 20 19:36:24 2016
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501,1741677
 
,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760
+/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501,1741677
 
,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786

Modified: 
tomcat/tc8.5.x/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java?rev=1744790=1744789=1744790=diff
==
--- 
tomcat/tc8.5.x/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java 
(original)
+++ 
tomcat/tc8.5.x/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java 
Fri May 20 19:36:24 2016
@@ -23,7 +23,6 @@ import java.io.InputStream;
 import java.lang.instrument.ClassFileTransformer;
 import java.lang.instrument.IllegalClassFormatException;
 import java.lang.ref.Reference;
-import java.lang.ref.WeakReference;
 import java.lang.reflect.Field;
 import java.lang.reflect.Method;
 import java.net.URI;
@@ -52,8 +51,6 @@ import java.util.LinkedHashSet;
 import java.util.List;
 import java.util.Map;
 import java.util.Map.Entry;
-import 

svn commit: r1744786 - /tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java

[markt]

Author: markt
Date: Fri May 20 19:13:09 2016
New Revision: 1744786

URL: http://svn.apache.org/viewvc?rev=1744786=rev
Log:
Remove the ResourceBundle memory leak protection since I am as sure as I can be 
that the original report was a false positive. The reasons I think this are:
- The GC roots related to ResourceBundle were all weak references.
- I can no longer produce the leak with the same (newer version) test 
application and Java the original 1.8. If it was a GC bug it is fixed in any 
version of Java that Tomcat 9 will use.
- We have a better understanding of JVM bugs that make some GC roots not 
visible in profilers like YourKit.

Modified:
tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java

Modified: 
tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java?rev=1744786=1744785=1744786=diff
==
--- tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java Fri 
May 20 19:13:09 2016
@@ -23,7 +23,6 @@ import java.io.InputStream;
 import java.lang.instrument.ClassFileTransformer;
 import java.lang.instrument.IllegalClassFormatException;
 import java.lang.ref.Reference;
-import java.lang.ref.WeakReference;
 import java.lang.reflect.Field;
 import java.lang.reflect.Method;
 import java.net.URI;
@@ -52,8 +51,6 @@ import java.util.LinkedHashSet;
 import java.util.List;
 import java.util.Map;
 import java.util.Map.Entry;
-import java.util.ResourceBundle;
-import java.util.Set;
 import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.CopyOnWriteArrayList;
 import java.util.concurrent.ThreadPoolExecutor;
@@ -77,7 +74,6 @@ import org.apache.tomcat.InstrumentableC
 import org.apache.tomcat.util.ExceptionUtils;
 import org.apache.tomcat.util.IntrospectionUtils;
 import org.apache.tomcat.util.compat.JreCompat;
-import org.apache.tomcat.util.compat.JreVendor;
 import org.apache.tomcat.util.res.StringManager;
 
 /**
@@ -1526,13 +1522,6 @@ public abstract class WebappClassLoaderB
 org.apache.juli.logging.LogFactory.release(this);
 }
 
-// Clear the resource bundle cache
-// This shouldn't be necessary, the cache uses weak references but
-// it has caused leaks. Oddly, using the leak detection code in
-// standard host allows the class loader to be GC'd. This has been seen
-// on Sun but not IBM JREs. Maybe a bug in Sun's GC impl?
-clearReferencesResourceBundles();
-
 // Clear the classloader reference in the VM's bean introspector
 java.beans.Introspector.flushCaches();
 
@@ -2143,94 +2132,6 @@ public abstract class WebappClassLoaderB
 }
 }
 
-
-/**
- * Clear the {@link ResourceBundle} cache of any bundles loaded by this
- * class loader or any class loader where this loader is a parent class
- * loader. Whilst {@link ResourceBundle#clearCache()} could be used there
- * are complications around the
- * {@link org.apache.jasper.servlet.JasperLoader} that mean a reflection
- * based approach is more likely to be complete.
- *
- * The ResourceBundle is using WeakReferences so it shouldn't be pinning 
the
- * class loader in memory. However, it is. Therefore clear out the
- * references.
- */
-private void clearReferencesResourceBundles() {
-// Get a reference to the cache
-try {
-Field cacheListField =
-ResourceBundle.class.getDeclaredField("cacheList");
-cacheListField.setAccessible(true);
-
-// Java 6 uses ConcurrentMap
-// Java 5 uses SoftCache extends Abstract Map
-// So use Map and it *should* work with both
-Map cacheList = (Map) cacheListField.get(null);
-
-// Get the keys (loader references are in the key)
-Set keys = cacheList.keySet();
-
-Field loaderRefField = null;
-
-// Iterate over the keys looking at the loader instances
-Iterator keysIter = keys.iterator();
-
-int countRemoved = 0;
-
-while (keysIter.hasNext()) {
-Object key = keysIter.next();
-
-if (loaderRefField == null) {
-loaderRefField =
-key.getClass().getDeclaredField("loaderRef");
-loaderRefField.setAccessible(true);
-}
-WeakReference loaderRef =
-(WeakReference) loaderRefField.get(key);
-
-ClassLoader loader = (ClassLoader) loaderRef.get();
-
-while (loader != null && loader != this) {
-loader = loader.getParent();
-}
-
-if (loader != null) {
- 

[Bug 59608] Manifest scanning should handle errors in resolving entries

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59608

Remy Maucherat  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Remy Maucherat  ---
Only one URL error was caught and logged, I also prefer catching everything
there. Errors will be logged as debug with the offending JAR URL.
Included in 9M7, 8.5.3 and 8.0.36.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1744763 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/util/scan/StandardJarScanner.java webapps/docs/changelog.xml

[remm]

Author: remm
Date: Fri May 20 15:57:29 2016
New Revision: 1744763

URL: http://svn.apache.org/viewvc?rev=1744763=rev
Log:
59608: A lot of URL based errors can occur while processing a JAR manifest 
classpath, so consistently ignore and log as debug all of them.

Modified:
tomcat/tc8.0.x/trunk/   (props changed)

tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri May 20 15:57:29 2016
@@ -1,2 +1,2 @@
 /tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 
666387,1666494,1666496,1666552,1666569,1666579,137,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679716,1680034,1680246,1681056,1681123,1681138,1681280,1681283,1681286,1681450,1681697,1681699,1681701,1681729,1681770,1681779,1681793,1681807,1681837-1681838,1681854,1681862,1681958,1682028,1682033,1682311,1682315,1682317,1682320,1682324,1682330,1682842,1684172,1684366,1684383,1684526-168452
 

svn commit: r1744762 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/scan/StandardJarScanner.java webapps/docs/changelog.xml

[remm]

Author: remm
Date: Fri May 20 15:56:57 2016
New Revision: 1744762

URL: http://svn.apache.org/viewvc?rev=1744762=rev
Log:
59608: A lot of URL based errors can occur while processing a JAR manifest 
classpath, so consistently ignore and log as debug all of them.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)

tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri May 20 15:56:57 2016
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501,1741677
 
,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713
+/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501,1741677
 
,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760

Modified: 
tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java?rev=1744762=1744761=1744762=diff
==
--- 
tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java 
(original)
+++ 
tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java 
Fri May 20 15:56:57 2016
@@ -20,7 +20,6 @@ import java.io.File;
 import java.io.IOException;
 import java.net.MalformedURLException;
 import java.net.URI;
-import java.net.URISyntaxException;
 import java.net.URL;
 import java.net.URLClassLoader;
 import java.util.Arrays;
@@ -383,27 +382,27 @@ public class StandardJarScanner implemen
 continue;
 }
 URL jarURL = jar.getJarFileURL();
-URI jarURI;
+URL classPathEntryURL;
 try {
-jarURI = jarURL.toURI();
-} catch (URISyntaxException e) {
+URI jarURI = jarURL.toURI();
+/*
+ * Note: Resolving the relative URLs from the manifest has 
the
+ *   potential to 

svn commit: r1744760 - in /tomcat/trunk: java/org/apache/tomcat/util/scan/StandardJarScanner.java webapps/docs/changelog.xml

[remm]

Author: remm
Date: Fri May 20 15:51:07 2016
New Revision: 1744760

URL: http://svn.apache.org/viewvc?rev=1744760=rev
Log:
59608: A lot of URL based errors can occur while processing a JAR manifest 
classpath, so consistently ignore and log as debug all of them.

Modified:
tomcat/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java?rev=1744760=1744759=1744760=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java Fri 
May 20 15:51:07 2016
@@ -20,7 +20,6 @@ import java.io.File;
 import java.io.IOException;
 import java.net.MalformedURLException;
 import java.net.URI;
-import java.net.URISyntaxException;
 import java.net.URL;
 import java.net.URLClassLoader;
 import java.util.Arrays;
@@ -383,27 +382,27 @@ public class StandardJarScanner implemen
 continue;
 }
 URL jarURL = jar.getJarFileURL();
-URI jarURI;
+URL classPathEntryURL;
 try {
-jarURI = jarURL.toURI();
-} catch (URISyntaxException e) {
+URI jarURI = jarURL.toURI();
+/*
+ * Note: Resolving the relative URLs from the manifest has 
the
+ *   potential to introduce security concerns. 
However, since
+ *   only JARs provided by the container and NOT those 
provided
+ *   by web applications are processed, there should 
be no
+ *   issues.
+ *   If this feature is ever extended to include JARs 
provided
+ *   by web applications, checks should be added to 
ensure that
+ *   any relative URL does not step outside the web 
application.
+ */
+URI classPathEntryURI = jarURI.resolve(classPathEntry);
+classPathEntryURL = classPathEntryURI.toURL();
+} catch (Exception e) {
 if (log.isDebugEnabled()) {
-log.debug(sm.getString("jarScan.invalidUri", jarURL));
+log.debug(sm.getString("jarScan.invalidUri", jarURL), 
e);
 }
 continue;
 }
-/*
- * Note: Resolving the relative URLs from the manifest has the
- *   potential to introduce security concerns. However, 
since
- *   only JARs provided by the container and NOT those 
provided
- *   by web applications are processed, there should be no
- *   issues.
- *   If this feature is ever extended to include JARs 
provided
- *   by web applications, checks should be added to ensure 
that
- *   any relative URL does not step outside the web 
application.
- */
-URI classPathEntryURI = jarURI.resolve(classPathEntry);
-URL classPathEntryURL = classPathEntryURI.toURL();
 classPathUrlsToProcess.add(classPathEntryURL);
 }
 }

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1744760=1744759=1744760=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Fri May 20 15:51:07 2016
@@ -66,6 +66,11 @@
 rather than known memory leaks. It had been disabled by default with no
 increase in the reports of memory leaks for some time. (markt)
   
+  
+59608: Skip over any invalid Class-Path 
attribute
+from JAR manifests. Log errors at debug level due to many bad 
libraries.
+(remm)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Early Access builds of JDK 9 b118 & JDK 9 with Project Jigsaw, b118 (#4987) are available on java.net

[Rory O'Donnell]

Thanks Mark!


> On 20 May 2016, at 14:51, Mark Thomas  wrote:
> 
>> On 19/05/2016 11:05, Rory O'Donnell wrote:
>> Hi Mark,
>> 
>> I just had some time to review your email in detail, can you log bugs
>> for items
>> 3,4 and 5 and send me the JI numbers ?
> 
> See in-line.
> 
> Many thanks,
> 
> Mark
> 
>>> 3. Memory leak in sun.rmi.transport.GC
>>> http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-May/040893.html
> 
> JI-9038057
> 
>>> 4. API to trace RMI Target memory leaks without resorting to reflection
>>> (I accept that this is unlikely but If you don't ask...)
>>> http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-May/040855.html
> 
> JI-9038059
> 
>>> 5. Rare memory leak in sun.security.pkcs11.SunPKCS11 poller thread
>>> http://mail.openjdk.java.net/pipermail/security-dev/2016-May/013841.html
> 
> Looks like someone created a bug for this:
> https://bugs.openjdk.java.net/browse/JDK-8156841
> 
> 

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 57130] Allow digest.sh to accept password from a file or from stdin

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=57130

--- Comment #6 from Coty Sutherland  ---
Bump; It's been a while since this RFE has gotten any attention. Have you had a
chance to take a look and provide further feedback?

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Early Access builds of JDK 9 b118 & JDK 9 with Project Jigsaw, b118 (#4987) are available on java.net

[Mark Thomas]

On 19/05/2016 11:05, Rory O'Donnell wrote:
> Hi Mark,
> 
> I just had some time to review your email in detail, can you log bugs
> for items
> 3,4 and 5 and send me the JI numbers ?

See in-line.

Many thanks,

Mark

>> 3. Memory leak in sun.rmi.transport.GC
>> http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-May/040893.html

JI-9038057

>> 4. API to trace RMI Target memory leaks without resorting to reflection
>> (I accept that this is unlikely but If you don't ask...)
>> http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-May/040855.html

JI-9038059

>> 5. Rare memory leak in sun.security.pkcs11.SunPKCS11 poller thread
>> http://mail.openjdk.java.net/pipermail/security-dev/2016-May/013841.html

Looks like someone created a bug for this:
https://bugs.openjdk.java.net/browse/JDK-8156841



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 59564] HttpServletRequest.getPart() always returns null with HTTP/2

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59564

Remy Maucherat  changed:

   What|Removed |Added

 OS||All
 Status|NEW |NEEDINFO

--- Comment #1 from Remy Maucherat  ---
This works for me (can't sat anything else really).

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: memory leak in Tomcat 8.0.9

[Martin Grigorov]

Hi,


On Fri, May 20, 2016 at 2:55 PM, Sanka, Ambica  wrote:

> Support Team,
>
> We have been using Tomcat 8.0.9 for our applications. We noticed below
> memo= ry leak error and out tomcat could not stopped. We had to kill the
> process = manually. I was reading articles in the internet and this got
> address after=  tomcat 6. But we found error in higher versions. We are not
> sure where to = fix this? Below is the error we are getting
>
> 2016-05-19 14:03:31,161 [localhost-startStop-2] WARN
> org.apache.catalina.l=
>
> oader.WebappClassLoader- The web application [/fmDirectoryService] appears
> = to have started a thread named [Thread-6] but has failed to stop it. This
> i= s very likely to create a memory leak. Stack trace of thread:
>
> java.lang.Thread.sleep(Native Method)
>
> net.atpco.cluster.support.BaseLocator$AdminTask.run(BaseLocator.java:141)
>
> 2016-05-19 14:03:31,197 [localhost-startStop-2] INFO
> org.apache.catalina.c=
>
> ore.ContainerBase.[Catalina].[localhost].[/fmbootstrap]- Destroying Spring
> = FrameworkServlet 'dispatcherServlet'
>
> 2016-05-19 14:03:31,210 [localhost-startStop-2] INFO
> org.apache.catalina.c=
>
> ore.ContainerBase.[Catalina].[localhost].[/fmbootstrap]- Closing Spring
> roo= t WebApplicationContext
>
> 2016-05-19 14:03:31,210 [localhost-startStop-2] INFO
> org.springframework.b=
>
> oot.context.embedded.AnnotationConfigEmbeddedWebApplicationContext-
> Closing=
> org.springframework.boot.context.embedded.AnnotationConfigEmbeddedWebAppli=
>
> cationContext@5e119034 org.springframework.boot.context.embedded.Ann cationContext@5e119034
> %3cmailto:org.springframework.boot.context.embedded.Ann>=
>
> otationConfigEmbeddedWebApplicationContext@5e119034>: startup date [Thu
> May=
>
> 19 08:17:39 EDT 2016]; root of context hierarchy May 19, 2016 2:03:31 PM
> com.mongodb.util.management.jmx.JMXMBeanServer unre= gisterMBean
>
> WARNING: Unable to register MBean
> org.mongodb.driver:type=3DConnectionPool,=
>
> clusterId=3D1,host=3Dlocalhost,port=3D27017
>
> javax.management.InstanceNotFoundException:
> org.mongodb.driver:type=3DConne=
>
> ctionPool,clusterId=3D1,host=3Dlocalhost,port=3D27017
>
> at
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getMBean(D=
>
> efaultMBeanServerInterceptor.java:1095)
>
> at
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.exclusiveU=
>
> nregisterMBean(DefaultMBeanServerInterceptor.java:427)
>
> at
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.unregister=
>
> MBean(DefaultMBeanServerInterceptor.java:415)
>
> at
> com.sun.jmx.mbeanserver.JmxMBeanServer.unregisterMBean(JmxMBeanS=
>
> erver.java:546)
>
> at
> com.mongodb.util.management.jmx.JMXMBeanServer.unregisterMBean(J=
>
> MXMBeanServer.java:52)
>
> at
> com.mongodb.JMXConnectionPoolListener.connectionPoolClosed(JMXCo=
>
> nnectionPoolListener.java:68)
>
> at
> com.mongodb.PooledConnectionProvider.close(PooledConnectionProvi=
>
> der.java:107)
>
>
>
> Any kind of help is appreciated.
>

To get some free support please ask at us...@tomcat.apache.org mailing list.
Also please update to latest version of Tomcat (8.0.35) and try again.


>
> Thanks
>
> Ambica.
>
>

memory leak in Tomcat 8.0.9

[Sanka, Ambica]

Support Team,

We have been using Tomcat 8.0.9 for our applications. We noticed below memo= ry 
leak error and out tomcat could not stopped. We had to kill the process = 
manually. I was reading articles in the internet and this got address after=  
tomcat 6. But we found error in higher versions. We are not sure where to = fix 
this? Below is the error we are getting

2016-05-19 14:03:31,161 [localhost-startStop-2] WARN  org.apache.catalina.l=

oader.WebappClassLoader- The web application [/fmDirectoryService] appears = to 
have started a thread named [Thread-6] but has failed to stop it. This i= s 
very likely to create a memory leak. Stack trace of thread:

java.lang.Thread.sleep(Native Method)

net.atpco.cluster.support.BaseLocator$AdminTask.run(BaseLocator.java:141)

2016-05-19 14:03:31,197 [localhost-startStop-2] INFO  org.apache.catalina.c=

ore.ContainerBase.[Catalina].[localhost].[/fmbootstrap]- Destroying Spring = 
FrameworkServlet 'dispatcherServlet'

2016-05-19 14:03:31,210 [localhost-startStop-2] INFO  org.apache.catalina.c=

ore.ContainerBase.[Catalina].[localhost].[/fmbootstrap]- Closing Spring roo= t 
WebApplicationContext

2016-05-19 14:03:31,210 [localhost-startStop-2] INFO  org.springframework.b=

oot.context.embedded.AnnotationConfigEmbeddedWebApplicationContext- Closing=  
org.springframework.boot.context.embedded.AnnotationConfigEmbeddedWebAppli=

cationContext@5e119034=

otationConfigEmbeddedWebApplicationContext@5e119034>: startup date [Thu May=

19 08:17:39 EDT 2016]; root of context hierarchy May 19, 2016 2:03:31 PM 
com.mongodb.util.management.jmx.JMXMBeanServer unre= gisterMBean

WARNING: Unable to register MBean org.mongodb.driver:type=3DConnectionPool,=

clusterId=3D1,host=3Dlocalhost,port=3D27017

javax.management.InstanceNotFoundException: org.mongodb.driver:type=3DConne=

ctionPool,clusterId=3D1,host=3Dlocalhost,port=3D27017

at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getMBean(D=

efaultMBeanServerInterceptor.java:1095)

at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.exclusiveU=

nregisterMBean(DefaultMBeanServerInterceptor.java:427)

at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.unregister=

MBean(DefaultMBeanServerInterceptor.java:415)

at com.sun.jmx.mbeanserver.JmxMBeanServer.unregisterMBean(JmxMBeanS=

erver.java:546)

at com.mongodb.util.management.jmx.JMXMBeanServer.unregisterMBean(J=

MXMBeanServer.java:52)

at com.mongodb.JMXConnectionPoolListener.connectionPoolClosed(JMXCo=

nnectionPoolListener.java:68)

at com.mongodb.PooledConnectionProvider.close(PooledConnectionProvi=

der.java:107)



Any kind of help is appreciated.

Thanks

Ambica.

[Bug 59608] New: Manifest scanning should handle errors in resolving entries

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59608

Bug ID: 59608
   Summary: Manifest scanning should handle errors in resolving
entries
   Product: Tomcat 8
   Version: 8.0.35
  Hardware: PC
OS: Linux
Status: NEW
  Severity: regression
  Priority: P2
 Component: Util
  Assignee: dev@tomcat.apache.org
  Reporter: andreas.k...@gmail.com

https://bz.apache.org/bugzilla/show_bug.cgi?id=59226 added scanning of the
Class-Path JAR manifest entries (Yay!). 

Unfortunately this now broke my Tomcat setup when updating from 8.0.33 to
8.0.35, I now see these errors in the logs:

20-May-2016 12:15:39.467 INFO [localhost-startStop-1]
org.apache.catalina.startup.HostConfig.deployDirectory Deploying web
application directory /opt/collaborne/j2ee-server/webapps/manager
20-May-2016 12:15:39.494 SEVERE [localhost-startStop-1]
org.apache.catalina.core.ContainerBase.addChildInternal ContainerBase.addChild:
start: 
 org.apache.catalina.LifecycleException: Failed to start component
[StandardEngine[Catalina].StandardHost[localhost].StandardContext[/manager]]
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:153)
at
org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:725)
at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:701)
at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:717)
at
org.apache.catalina.startup.HostConfig.deployDirectory(HostConfig.java:1092)
at
org.apache.catalina.startup.HostConfig$DeployDirectory.run(HostConfig.java:1834)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.IllegalArgumentException: Illegal character in path at
index 0: \
at java.net.URI.create(URI.java:852)
at java.net.URI.resolve(URI.java:1036)
at
org.apache.tomcat.util.scan.StandardJarScanner.processManifest(StandardJarScanner.java:400)
at
org.apache.tomcat.util.scan.StandardJarScanner.process(StandardJarScanner.java:324)
at
org.apache.tomcat.util.scan.StandardJarScanner.scan(StandardJarScanner.java:273)
at
org.apache.catalina.startup.ContextConfig.processJarsForWebFragments(ContextConfig.java:1887)
at
org.apache.catalina.startup.ContextConfig.webConfig(ContextConfig.java:1127)
at
org.apache.catalina.startup.ContextConfig.configureStart(ContextConfig.java:779)
at
org.apache.catalina.startup.ContextConfig.lifecycleEvent(ContextConfig.java:306)
at
org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:95)
at
org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:90)
at
org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5171)
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:147)
... 10 more
Caused by: java.net.URISyntaxException: Illegal character in path at index 0: \
at java.net.URI$Parser.fail(URI.java:2848)
at java.net.URI$Parser.checkChars(URI.java:3021)
at java.net.URI$Parser.parseHierarchical(URI.java:3105)
at java.net.URI$Parser.parse(URI.java:3063)
at java.net.URI.(URI.java:588)
at java.net.URI.create(URI.java:850)
... 22 more

20-May-2016 12:15:39.494 SEVERE [localhost-startStop-1]
org.apache.catalina.startup.HostConfig.deployDirectory Error deploying web
application directory /opt/collaborne/j2ee-server/webapps/manager
 java.lang.IllegalStateException: ContainerBase.addChild: start:
org.apache.catalina.LifecycleException: Failed to start component
[StandardEngine[Catalina].StandardHost[localhost].StandardContext[/manager]]
at
org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:729)
at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:701)
at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:717)
at
org.apache.catalina.startup.HostConfig.deployDirectory(HostConfig.java:1092)
at
org.apache.catalina.startup.HostConfig$DeployDirectory.run(HostConfig.java:1834)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)

20-May-2016 12:15:39.495 INFO [localhost-startStop-1]
org.apache.catalina.startup.HostConfig.deployDirectory Deployment of web
application directory /opt/collaborne/j2ee-server/webapps/manager has finished
in 27 ms

svn commit: r1744725 - in /tomcat/site/trunk: docs/bugreport.html docs/lists.html xdocs/bugreport.xml xdocs/lists.xml

[kkolinko]

Author: kkolinko
Date: Fri May 20 12:30:13 2016
New Revision: 1744725

URL: http://svn.apache.org/viewvc?rev=1744725=rev
Log:
Add Tomcat 8.5

Modified:
tomcat/site/trunk/docs/bugreport.html
tomcat/site/trunk/docs/lists.html
tomcat/site/trunk/xdocs/bugreport.xml
tomcat/site/trunk/xdocs/lists.xml

Modified: tomcat/site/trunk/docs/bugreport.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/bugreport.html?rev=1744725=1744724=1744725=diff
==
--- tomcat/site/trunk/docs/bugreport.html (original)
+++ tomcat/site/trunk/docs/bugreport.html Fri May 20 12:30:13 2016
@@ -479,7 +479,7 @@ problem you are having before reporting
  
 
 Tomcat 9, Tomcat 8, Tomcat 7 and
- Tomcat 6  Tomcat 9.0.x, 8.0.x, 7.0.x and 6.0.x
+ Tomcat 6  Tomcat 9.0.x, 8.5.x or 8.0.x, 7.0.x and 
6.0.x
  
 
 Tomcat Connectors  Integration of Tomcat with other Web 
servers
@@ -607,6 +607,20 @@ problem you are having before reporting
 
 
   
+Tomcat 8.5
+  
+http://tomcat.apache.org/tomcat-8.5-doc/changelog.html;>changelog.html
+  
+  
+http://svn.apache.org/repos/asf/tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml;>changelog.xml
+  
+  none
+
+
+
+
+
+  
 Tomcat 8.0
   
 http://tomcat.apache.org/tomcat-8.0-doc/changelog.html;>changelog.html
@@ -741,7 +755,7 @@ problem you are having before reporting
   tomcat-jdbc.jar.
 
 
-This pool implementation is available with Tomcat 7 and
+This pool implementation is available with Tomcat 7 and later and
   it comes from jdbc-pool project that
   is part of Tomcat Modules.
   This library is developed alongside the main Tomcat.
@@ -805,7 +819,7 @@ bug in your web application.
 Tomcat 9  Tomcat 9.0.x and tomcat.apache.org web site
  
 
-Tomcat 8  Tomcat 8.0.x
+Tomcat 8  Tomcat 8.5.x and 8.0.x
  
 
 Tomcat 7  Tomcat 7.0.x

Modified: tomcat/site/trunk/docs/lists.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/lists.html?rev=1744725=1744724=1744725=diff
==
--- tomcat/site/trunk/docs/lists.html (original)
+++ tomcat/site/trunk/docs/lists.html Fri May 20 12:30:13 2016
@@ -343,7 +343,7 @@ Tomcat questions to Eric or Rick themsel
 
   
 When asking questions on the list, please state your exact Tomcat version
-  (which is three numbers, 8.0.xx or 7.0.yy), your operating system, and
+  (which is three numbers, 8.5.xx, 8.0.yy or 7.0.zz), your operating system, 
and
   essential bits of your configuration.
   
   

Modified: tomcat/site/trunk/xdocs/bugreport.xml
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/bugreport.xml?rev=1744725=1744724=1744725=diff
==
--- tomcat/site/trunk/xdocs/bugreport.xml (original)
+++ tomcat/site/trunk/xdocs/bugreport.xml Fri May 20 12:30:13 2016
@@ -143,7 +143,7 @@ problem you are having before reporting
 Here is a quick list of supported products:
 
  Tomcat 9, Tomcat 8, Tomcat 7 and
- Tomcat 6  Tomcat 9.0.x, 8.0.x, 7.0.x and 6.0.x
+ Tomcat 6  Tomcat 9.0.x, 8.5.x or 8.0.x, 7.0.x and 
6.0.x
  Tomcat Connectors  Integration of Tomcat with 
other Web servers
  Tomcat Native  APR based native HTTP and AJP 
connectors for Tomcat
  Tomcat Modules  Additional Tomcat components
@@ -216,6 +216,17 @@ problem you are having before reporting
 
 
 
+  Tomcat 8.5
+  
+http://tomcat.apache.org/tomcat-8.5-doc/changelog.html;>changelog.html
+  
+  
+http://svn.apache.org/repos/asf/tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml;>changelog.xml
+  
+  none
+
+
+
   Tomcat 8.0
   
 http://tomcat.apache.org/tomcat-8.0-doc/changelog.html;>changelog.html
@@ -314,7 +325,7 @@ problem you are having before reporting
   JDBC Database Pool implementation 
   tomcat-jdbc.jar.
 
-This pool implementation is available with Tomcat 7 and
+This pool implementation is available with Tomcat 7 and later and
   it comes from jdbc-pool project that
   is part of Tomcat Modules.
   This library is developed alongside the main Tomcat.
@@ -358,7 +369,7 @@ bug in your web application.
 Product. Here is a list of supported products:
 
  Tomcat 9  Tomcat 9.0.x and tomcat.apache.org web 
site
- Tomcat 8  Tomcat 8.0.x
+ Tomcat 8  Tomcat 8.5.x and 8.0.x
  Tomcat 7  Tomcat 7.0.x
  Tomcat 6  Tomcat 6.0.x
  Tomcat Connectors  Integration of Tomcat with other 
Web servers.

Modified: tomcat/site/trunk/xdocs/lists.xml
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/lists.xml?rev=1744725=1744724=1744725=diff

Re: Regarding files generated by "JJTree"

[Konstantin Kolinko]

2016-05-20 13:01 GMT+03:00 sangeeta lal :
> Dear Sir,
>
> *Thanks for your reply!*
>
> Could you please tell me,  if there is any listing about all the  auto-
> generated files. I have manually identified 59 files in the folder "
> *tomcat\java\org\apache\el\parser*" which are auto generated.

ELParser.jjt is the source.

ELParser.java was generated.
Some helper classes (Node.java, SimpleNode.java, ..) are generated /
provided by the tool.

The Ast* files - a stub was generated, but the rest is written by a
human developer.

ELParser.html is a report from generation tool.


Java CC site has a manual, with examples.
https://javacc.java.net/doc/docindex.html
https://javacc.java.net/doc/JJTree.html

In short, JavaCC is a lexical parser that can perform some Java code
when some lexical element is encountered. Coupling it with JJTree
turns that Java code into code that produces a tree of Node elements.

The behaviour of those nodes it then programmed by a human.  My
understanding is that by default those Ast classes have only a
constructor, but no other methods.  Some methods are declared in
SimpleNode class and can be overridden in specific classes, e.g.
AstIdentifier overrides setImage().

Some of default classes were edited by adding additional methods. E.g.
methods with an EvaluationContext argument in SimpleNode class were
added.


> I have following two questions:
>
> 1. Can tomcat project have auto-generated files in some other folder also?
> 2. Is the "JavaCC" only tool which is used to auto-generate the files ? or
> there are some other tools as well?
>

There are some classes from other projects that are preprocessed (by
renaming the packages) and recompiled.

All versions of Tomcat do so for Apache Commons Logging library when
it is built as an "extras" package.

See 
  




Older versions of Tomcat also did so for Apache Commons Pool and
Apache Commons DBCP libraries, but Tomcat 8.0 and later has an own
copy of those libraries in it source tree.


This is about *.java files. There is also documentation (xml -> html),
javadoc (java -> html).


The mailing list rules:
http://tomcat.apache.org/lists.html#tomcat-users
-> 6. Top-posting is bad.


Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 59604] Invalid url-pattern in servlet mapping on s390x

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59604

--- Comment #3 from Konstantin Kolinko  ---
Note that it succeeded in parsing XML markup (the tag of ''), but
contents of the tag is parsed as garbage. This is rather odd. Those patterns
are English as well.


Maybe those web.xml files were processed, overwrittem, broken by some tool?

Note that server.xml was processed correctly, otherwise the server wouldn't
start. Though a difference is that server.xml uses attributes to configure
values, while web.xml uses plain text content wrapped by elements.


Maybe try a different XML parser implementation. E.g. place a recent copy of
Apache Xerces-J into "endorsed" directory. From your logs its location is:

-Djava.endorsed.dirs=/u/aes/apache-tomcat-8.0.33/endorsed



Some (unrelated) oddity in the logs:

VersionLoggerListener.log Command line argument: -Djava.class.path=.

VersionLoggerListener.log Command line argument:
-Djava.class.path=/u/aes/apache-tomcat-8.0.33/bin/bootstrap.jar:/u/aes/apache-tomcat-8.0.33/bin/tomcat-juli.jar

Where the first incorrect value of "-Djava.class.path" argument comes from?



Note that such questions are normally asked on the users mailing list. You need
help from fellow users to help find the root cause here.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Regarding files generated by "JJTree"

[Mark Thomas]

On 20/05/2016 12:23, Martin Grigorov wrote:
> Hi,
> 
> I guess your question is related to
> http://markmail.org/message/kw4erakv272hsy3o where someone else already
> told you about JavaCC.
> AFAIK JavaCC is the only tool used by Tomcat that generates classes.

Martin is correct.

Note: There was a brief time where we looked at using a JavaCC based
parser for HTTP headers but the performance was poor.

> The number of classes depends on the parser rules so it could be N today
> and M tomorrow.

Indeed. It is unlikely to change in any given major version once there
is a stable release since the El specification won't change but
occasionally, bug fixes do change the parser rules.

> Just grep the sources for this header and use the returned number.

+1.

Mark


> 
> 
> On Fri, May 20, 2016 at 12:01 PM, sangeeta lal 
> wrote:
> 
>> Dear Sir,
>>
>> *Thanks for your reply!*
>>
>> Could you please tell me,  if there is any listing about all the  auto-
>> generated files. I have manually identified 59 files in the folder "
>> *tomcat\java\org\apache\el\parser*" which are auto generated.
>>
>> I have following two questions:
>>
>> 1. Can tomcat project have auto-generated files in some other folder also?
>> 2. Is the "JavaCC" only tool which is used to auto-generate the files ? or
>> there are some other tools as well?
>>
>>
>> I highly *appreciate your help* and time!
>>
>> Thank You
>> Sangeeta
>>
>> On Fri, May 20, 2016 at 3:14 PM, Martin Grigorov 
>> wrote:
>>
>>> Hello Sangeeta,
>>>
>>> Yes, those files are auto-generated by a tool: https://javacc.java.net/.
>>>
>>>
>>> On Fri, May 20, 2016 at 11:41 AM, sangeeta lal 
>>> wrote:
>>>
 Dear Dev Team,

 Can anyone please give me little information about these files?

 Thank You

 On Thu, May 19, 2016 at 8:22 PM, sangeeta lal >>
 wrote:

>
> Dear Dev Team,
>
>
> I am Sangeeta. I am a PhD Scholar in the area of automated software
> engineering. I am currently studying source code of Apache Tomcat
 project.
> While studying the source code. I noticed a folder in Apache Tomcat
 project
> consisting of 58 files having following line written in them:
>
>
> "/* *Generated By:JJTree: Do not edit this line.
>>> AstLambdaExpression.java
> Version 4.3 */"*
>
>
> Can anyone please explain me little about the meaning of this line?
>> Are
> all such files  generated by this tool have no contribution from the
 human
> developers?
>
> I highly appreciate your help!
>
> Thanks You
> Sangeeta
>
> --
> Regards...
> Sangeeta
> Assistant Professor
> CSE Department @JIIT Noida
>
>


 --
 Regards...
 Sangeeta
 Assistant Professor
 CSE Department @JIIT Noida

>>>
>>
>>
>>
>> --
>> Regards...
>> Sangeeta
>> Assistant Professor
>> CSE Department @JIIT Noida
>>
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Regarding files generated by "JJTree"

[Martin Grigorov]

Hi,

I guess your question is related to
http://markmail.org/message/kw4erakv272hsy3o where someone else already
told you about JavaCC.
AFAIK JavaCC is the only tool used by Tomcat that generates classes.
The number of classes depends on the parser rules so it could be N today
and M tomorrow.
Just grep the sources for this header and use the returned number.


On Fri, May 20, 2016 at 12:01 PM, sangeeta lal 
wrote:

> Dear Sir,
>
> *Thanks for your reply!*
>
> Could you please tell me,  if there is any listing about all the  auto-
> generated files. I have manually identified 59 files in the folder "
> *tomcat\java\org\apache\el\parser*" which are auto generated.
>
> I have following two questions:
>
> 1. Can tomcat project have auto-generated files in some other folder also?
> 2. Is the "JavaCC" only tool which is used to auto-generate the files ? or
> there are some other tools as well?
>
>
> I highly *appreciate your help* and time!
>
> Thank You
> Sangeeta
>
> On Fri, May 20, 2016 at 3:14 PM, Martin Grigorov 
> wrote:
>
> > Hello Sangeeta,
> >
> > Yes, those files are auto-generated by a tool: https://javacc.java.net/.
> >
> >
> > On Fri, May 20, 2016 at 11:41 AM, sangeeta lal 
> > wrote:
> >
> > > Dear Dev Team,
> > >
> > > Can anyone please give me little information about these files?
> > >
> > > Thank You
> > >
> > > On Thu, May 19, 2016 at 8:22 PM, sangeeta lal  >
> > > wrote:
> > >
> > > >
> > > > Dear Dev Team,
> > > >
> > > >
> > > > I am Sangeeta. I am a PhD Scholar in the area of automated software
> > > > engineering. I am currently studying source code of Apache Tomcat
> > > project.
> > > > While studying the source code. I noticed a folder in Apache Tomcat
> > > project
> > > > consisting of 58 files having following line written in them:
> > > >
> > > >
> > > > "/* *Generated By:JJTree: Do not edit this line.
> > AstLambdaExpression.java
> > > > Version 4.3 */"*
> > > >
> > > >
> > > > Can anyone please explain me little about the meaning of this line?
> Are
> > > > all such files  generated by this tool have no contribution from the
> > > human
> > > > developers?
> > > >
> > > > I highly appreciate your help!
> > > >
> > > > Thanks You
> > > > Sangeeta
> > > >
> > > > --
> > > > Regards...
> > > > Sangeeta
> > > > Assistant Professor
> > > > CSE Department @JIIT Noida
> > > >
> > > >
> > >
> > >
> > > --
> > > Regards...
> > > Sangeeta
> > > Assistant Professor
> > > CSE Department @JIIT Noida
> > >
> >
>
>
>
> --
> Regards...
> Sangeeta
> Assistant Professor
> CSE Department @JIIT Noida
>

svn commit: r1744714 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/core/ java/org/apache/catalina/loader/ test/org/apache/catalina/loader/ webapps/docs/ webapps/docs/config/

[markt]

Author: markt
Date: Fri May 20 11:19:32 2016
New Revision: 1744714

URL: http://svn.apache.org/viewvc?rev=1744714=rev
Log:
Remove clearReferencesStatic option

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/StandardContext.java
tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/mbeans-descriptors.xml

tomcat/tc8.5.x/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java

tomcat/tc8.5.x/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderWeaving.java
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml
tomcat/tc8.5.x/trunk/webapps/docs/config/context.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri May 20 11:19:32 2016
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501,1741677
 
,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705
+/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501,1741677
 
,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713

Modified: 
tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/StandardContext.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/StandardContext.java?rev=1744714=1744713=1744714=diff
==
--- tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/StandardContext.java 
(original)
+++ tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/StandardContext.java Fri 
May 20 11:19:32 2016
@@ -714,20 +714,6 @@ public class StandardContext extends Con
 private boolean clearReferencesRmiTargets = true;
 
 /**
- * Should Tomcat attempt to null out any static or final fields from loaded
- * classes when a web application is stopped as a work around for apparent
- * garbage collection bugs and application coding errors? There have been
- * some issues reported with log4j when this option is true. Applications
- * without memory leaks using recent JVMs should operate correctly with 
this
- * option set to false. If not specified, the default value of
- * false will be used.
- *
- * 

svn commit: r1744713 - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/catalina/loader/ test/org/apache/catalina/loader/ webapps/docs/ webapps/docs/config/

[markt]

Author: markt
Date: Fri May 20 11:18:55 2016
New Revision: 1744713

URL: http://svn.apache.org/viewvc?rev=1744713=rev
Log:
Remove clearReferencesStatic option

Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
tomcat/trunk/java/org/apache/catalina/core/mbeans-descriptors.xml
tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java

tomcat/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderWeaving.java
tomcat/trunk/webapps/docs/changelog.xml
tomcat/trunk/webapps/docs/config/context.xml

Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardContext.java?rev=1744713=1744712=1744713=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/StandardContext.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardContext.java Fri May 20 
11:18:55 2016
@@ -713,20 +713,6 @@ public class StandardContext extends Con
 private boolean clearReferencesRmiTargets = true;
 
 /**
- * Should Tomcat attempt to null out any static or final fields from loaded
- * classes when a web application is stopped as a work around for apparent
- * garbage collection bugs and application coding errors? There have been
- * some issues reported with log4j when this option is true. Applications
- * without memory leaks using recent JVMs should operate correctly with 
this
- * option set to false. If not specified, the default value of
- * false will be used.
- *
- * @deprecated This option will be removed in Tomcat 8.5
- */
-@Deprecated
-private boolean clearReferencesStatic = false;
-
-/**
  * Should Tomcat attempt to terminate threads that have been started by the
  * web application? Stopping threads is performed via the deprecated (for
  * good reason) Thread.stop() method and is likely to result 
in
@@ -2593,38 +2579,6 @@ public class StandardContext extends Con
 
 
 /**
- * @return the clearReferencesStatic flag for this Context.
- *
- * @deprecated This option will be removed in Tomcat 8.5
- */
-@Deprecated
-public boolean getClearReferencesStatic() {
-
-return (this.clearReferencesStatic);
-
-}
-
-
-/**
- * Set the clearReferencesStatic feature for this Context.
- *
- * @param clearReferencesStatic The new flag value
- *
- * @deprecated This option will be removed in Tomcat 8.5
- */
-@Deprecated
-public void setClearReferencesStatic(boolean clearReferencesStatic) {
-
-boolean oldClearReferencesStatic = this.clearReferencesStatic;
-this.clearReferencesStatic = clearReferencesStatic;
-support.firePropertyChange("clearReferencesStatic",
-   oldClearReferencesStatic,
-   this.clearReferencesStatic);
-
-}
-
-
-/**
  * @return the clearReferencesStopThreads flag for this Context.
  */
 public boolean getClearReferencesStopThreads() {
@@ -5077,8 +5031,6 @@ public class StandardContext extends Con
 // created.
 setClassLoaderProperty("clearReferencesRmiTargets",
 getClearReferencesRmiTargets());
-setClassLoaderProperty("clearReferencesStatic",
-getClearReferencesStatic());
 setClassLoaderProperty("clearReferencesStopThreads",
 getClearReferencesStopThreads());
 setClassLoaderProperty("clearReferencesStopTimerThreads",

Modified: tomcat/trunk/java/org/apache/catalina/core/mbeans-descriptors.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/mbeans-descriptors.xml?rev=1744713=1744712=1744713=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/mbeans-descriptors.xml (original)
+++ tomcat/trunk/java/org/apache/catalina/core/mbeans-descriptors.xml Fri May 
20 11:18:55 2016
@@ -86,10 +86,6 @@
description="Should Tomcat look for memory leaks in RMI Targets 
and clear them if found as a work around for application coding errors?"
type="boolean"/>
 
-
-
 

Modified: 
tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java?rev=1744713=1744712=1744713=diff
==
--- tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java Fri 
May 20 11:18:55 2016
@@ -26,7 +26,6 @@ import java.lang.ref.Reference;
 import java.lang.ref.WeakReference;
 import 

svn commit: r1744709 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/ java/org/apache/catalina/loader/ test/org/apache/catalina/loader/ webapps/docs/config/

[markt]

Author: markt
Date: Fri May 20 11:10:18 2016
New Revision: 1744709

URL: http://svn.apache.org/viewvc?rev=1744709=rev
Log:
Deprecate clearReferencesStatic

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardContext.java
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/mbeans-descriptors.xml

tomcat/tc7.0.x/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java

tomcat/tc7.0.x/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderWeaving.java
tomcat/tc7.0.x/trunk/webapps/docs/config/context.xml

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri May 20 11:10:18 2016
@@ -1,3 +1,3 @@
 
/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988,1667553
 
-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702739,1702742,1702
 
744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1725974,1726171-1
 
726173,1726175,1726179-1726182,1726190-1726191,1726195-1726200,1726203,1726226,1726576,1726630,1726992,1727029,1727037,1727671,1727676,1727900,1728028,1728092,1728439,1728449,1729186,1729362,1731009,1731303,1731867,1731872,1731874,1731876,1731885,1731947,1731955,1731959,1731977,1731984,1732360,1732490,1732672,1732902,1733166,1733603,1733619,1733735,1733752,1733764,1733915,1733941,1733964,1734115,1734133,1734261,1734421,1734531,1736286,1737967,1738173,1738182,1738992,1739039,1739089-1739091,1739294,1739777,1739821,1739981,1740513,1740726,1741019,1741162,1741217,1743647,1743681,1744152,1744272
-/tomcat/tc8.5.x/trunk:1735579,1736839,1737199,1737966,1738042,1738044,1738162,1738165,1738178,1739157,1739173,1739177,1739476,1740132,1740521,1740536,1740804,1740811,1740981,1741165,1741174,1741182,1741191,1741203,1741209,1741226,1741233,1741410,1742277,1743118,1743126,1743139-1743140,1743718,1743722,1743724,1744059,1744127,1744151,1744232,1744377,1744687,1744698

svn commit: r1744707 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/core/ java/org/apache/catalina/loader/ test/org/apache/catalina/loader/ webapps/docs/config/

[markt]

Author: markt
Date: Fri May 20 11:05:30 2016
New Revision: 1744707

URL: http://svn.apache.org/viewvc?rev=1744707=rev
Log:
Deprecate clearReferencesStatic

Modified:
tomcat/tc8.0.x/trunk/   (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/catalina/core/StandardContext.java
tomcat/tc8.0.x/trunk/java/org/apache/catalina/core/mbeans-descriptors.xml

tomcat/tc8.0.x/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java

tomcat/tc8.0.x/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderWeaving.java
tomcat/tc8.0.x/trunk/webapps/docs/config/context.xml

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri May 20 11:05:30 2016
@@ -1,2 +1,2 @@
 /tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 
666387,1666494,1666496,1666552,1666569,1666579,137,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679716,1680034,1680246,1681056,1681123,1681138,1681280,1681283,1681286,1681450,1681697,1681699,1681701,1681729,1681770,1681779,1681793,1681807,1681837-1681838,1681854,1681862,1681958,1682028,1682033,1682311,1682315,1682317,1682320,1682324,1682330,1682842,1684172,1684366,1684383,1684526-168452
 

svn commit: r1744706 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/core/ java/org/apache/catalina/loader/ test/org/apache/catalina/loader/ webapps/docs/config/

[markt]

Author: markt
Date: Fri May 20 11:05:13 2016
New Revision: 1744706

URL: http://svn.apache.org/viewvc?rev=1744706=rev
Log:
Deprecate clearReferencesStatic

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/StandardContext.java
tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/mbeans-descriptors.xml

tomcat/tc8.5.x/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java

tomcat/tc8.5.x/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderWeaving.java
tomcat/tc8.5.x/trunk/webapps/docs/config/context.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri May 20 11:05:13 2016
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501,1741677
 
,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697
+/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501,1741677
 
,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705

Modified: 
tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/StandardContext.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/StandardContext.java?rev=1744706=1744705=1744706=diff
==
--- tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/StandardContext.java 
(original)
+++ tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/StandardContext.java Fri 
May 20 11:05:13 2016
@@ -721,7 +721,10 @@ public class StandardContext extends Con
  * without memory leaks using recent JVMs should operate correctly with 
this
  * option set to false. If not specified, the default value of
  * false will be used.
+ *
+ * @deprecated This option will be removed in Tomcat 8.5
  */
+@Deprecated
 private boolean clearReferencesStatic = false;
 
 /**
@@ -2592,7 +2595,10 @@ public class StandardContext extends Con
 
 /**
  * @return the clearReferencesStatic flag for this Context.
+ *
+ * @deprecated This option will be removed in Tomcat 8.5
  */
+@Deprecated
 public boolean getClearReferencesStatic() {
 
 return 

svn commit: r1744705 - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/catalina/loader/ test/org/apache/catalina/loader/ webapps/docs/config/

[markt]

Author: markt
Date: Fri May 20 11:04:47 2016
New Revision: 1744705

URL: http://svn.apache.org/viewvc?rev=1744705=rev
Log:
Deprecate clearReferencesStatic

Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
tomcat/trunk/java/org/apache/catalina/core/mbeans-descriptors.xml
tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java

tomcat/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderWeaving.java
tomcat/trunk/webapps/docs/config/context.xml

Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardContext.java?rev=1744705=1744704=1744705=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/StandardContext.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardContext.java Fri May 20 
11:04:47 2016
@@ -720,7 +720,10 @@ public class StandardContext extends Con
  * without memory leaks using recent JVMs should operate correctly with 
this
  * option set to false. If not specified, the default value of
  * false will be used.
+ *
+ * @deprecated This option will be removed in Tomcat 8.5
  */
+@Deprecated
 private boolean clearReferencesStatic = false;
 
 /**
@@ -2591,7 +2594,10 @@ public class StandardContext extends Con
 
 /**
  * @return the clearReferencesStatic flag for this Context.
+ *
+ * @deprecated This option will be removed in Tomcat 8.5
  */
+@Deprecated
 public boolean getClearReferencesStatic() {
 
 return (this.clearReferencesStatic);
@@ -2603,7 +2609,10 @@ public class StandardContext extends Con
  * Set the clearReferencesStatic feature for this Context.
  *
  * @param clearReferencesStatic The new flag value
+ *
+ * @deprecated This option will be removed in Tomcat 8.5
  */
+@Deprecated
 public void setClearReferencesStatic(boolean clearReferencesStatic) {
 
 boolean oldClearReferencesStatic = this.clearReferencesStatic;

Modified: tomcat/trunk/java/org/apache/catalina/core/mbeans-descriptors.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/mbeans-descriptors.xml?rev=1744705=1744704=1744705=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/mbeans-descriptors.xml (original)
+++ tomcat/trunk/java/org/apache/catalina/core/mbeans-descriptors.xml Fri May 
20 11:04:47 2016
@@ -87,7 +87,7 @@
type="boolean"/>
 
 
 
 http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java?rev=1744705=1744704=1744705=diff
==
--- tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java Fri 
May 20 11:04:47 2016
@@ -343,7 +343,10 @@ public abstract class WebappClassLoaderB
  * without memory leaks using recent JVMs should operate correctly with 
this
  * option set to false. If not specified, the default value of
  * false will be used.
+ *
+ * @deprecated This option will be removed in Tomcat 8.5
  */
+@Deprecated
 private boolean clearReferencesStatic = false;
 
 /**
@@ -543,7 +546,10 @@ public abstract class WebappClassLoaderB
  * Return the clearReferencesStatic flag for this Context.
  * @return true if the classloader should attempt to set to 
null
  *static final fields in loaded classes
+ *
+ * @deprecated This option will be removed in Tomcat 8.5
  */
+@Deprecated
 public boolean getClearReferencesStatic() {
 return (this.clearReferencesStatic);
 }
@@ -553,7 +559,10 @@ public abstract class WebappClassLoaderB
  * Set the clearReferencesStatic feature for this Context.
  *
  * @param clearReferencesStatic The new flag value
+ *
+ * @deprecated This option will be removed in Tomcat 8.5
  */
+@Deprecated
 public void setClearReferencesStatic(boolean clearReferencesStatic) {
 this.clearReferencesStatic = clearReferencesStatic;
 }

Modified: 
tomcat/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderWeaving.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderWeaving.java?rev=1744705=1744704=1744705=diff
==
--- 
tomcat/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderWeaving.java 
(original)
+++ 
tomcat/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderWeaving.java 
Fri May 20 11:04:47 2016
@@ -239,6 +239,7 @@ public class TestWebappClassLoaderWeavin
 
 }
 
+@SuppressWarnings("deprecation")
 @Test

svn commit: r1744703 - /tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java

[markt]

Author: markt
Date: Fri May 20 10:58:17 2016
New Revision: 1744703

URL: http://svn.apache.org/viewvc?rev=1744703=rev
Log:
Fix typo

Modified:
tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java

Modified: 
tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java?rev=1744703=1744702=1744703=diff
==
--- tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoaderBase.java Fri 
May 20 10:58:17 2016
@@ -2317,7 +2317,7 @@ public abstract class WebappClassLoaderB
  * based approach is more likely to be complete.
  *
  * The ResourceBundle is using WeakReferences so it shouldn't be pinning 
the
- * class loader in memory. However, it is. Therefore clear ou the
+ * class loader in memory. However, it is. Therefore clear out the
  * references.
  */
 private void clearReferencesResourceBundles() {



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1744702 - in /tomcat/tc7.0.x/trunk: ./ modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java webapps/docs/changelog.xml

[markt]

Author: markt
Date: Fri May 20 10:57:27 2016
New Revision: 1744702

URL: http://svn.apache.org/viewvc?rev=1744702=rev
Log:
Fix a memory leak with the pool cleaner thread that retained a reference to the 
web application class loader for the first web application to use a connection 
pool.

Modified:
tomcat/tc7.0.x/trunk/   (props changed)

tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri May 20 10:57:27 2016
@@ -1,3 +1,3 @@
 
/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988,1667553
 
-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702739,1702742,1702
 
744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1725974,1726171-1
 
726173,1726175,1726179-1726182,1726190-1726191,1726195-1726200,1726203,1726226,1726576,1726630,1726992,1727029,1727037,1727671,1727676,1727900,1728028,1728092,1728439,1728449,1729186,1729362,1731009,1731303,1731867,1731872,1731874,1731876,1731885,1731947,1731955,1731959,1731977,1731984,1732360,1732490,1732672,1732902,1733166,1733603,1733619,1733735,1733752,1733764,1733915,1733941,1733964,1734115,1734133,1734261,1734421,1734531,1736286,1737967,1738173,1738182,1738992,1739039,1739089-1739091,1739294,1739777,1739821,1739981,1740513,1740726,1741019,1741162,1741217,1743647,1743681,1744152,1744272
-/tomcat/tc8.5.x/trunk:1735579,1736839,1737199,1737966,1738042,1738044,1738162,1738165,1738178,1739157,1739173,1739177,1739476,1740132,1740521,1740536,1740804,1740811,1740981,1741165,1741174,1741182,1741191,1741203,1741209,1741226,1741233,1741410,1742277,1743118,1743126,1743139-1743140,1743718,1743722,1743724,1744059,1744127,1744151,1744232,1744377,1744687

svn commit: r1744699 - in /tomcat/tc8.0.x/trunk: ./ modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java webapps/docs/changelog.xml

[markt]

Author: markt
Date: Fri May 20 10:54:52 2016
New Revision: 1744699

URL: http://svn.apache.org/viewvc?rev=1744699=rev
Log:
Fix a memory leak with the pool cleaner thread that retained a reference to the 
web application class loader for the first web application to use a connection 
pool.

Modified:
tomcat/tc8.0.x/trunk/   (props changed)

tomcat/tc8.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri May 20 10:54:52 2016
@@ -1,2 +1,2 @@
 /tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 
666387,1666494,1666496,1666552,1666569,1666579,137,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679716,1680034,1680246,1681056,1681123,1681138,1681280,1681283,1681286,1681450,1681697,1681699,1681701,1681729,1681770,1681779,1681793,1681807,1681837-1681838,1681854,1681862,1681958,1682028,1682033,1682311,1682315,1682317,1682320,1682324,1682330,1682842,1684172,1684366,1684383,1684526-168452
 

svn commit: r1744698 - in /tomcat/tc8.5.x/trunk: ./ modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java webapps/docs/changelog.xml

[markt]

Author: markt
Date: Fri May 20 10:54:10 2016
New Revision: 1744698

URL: http://svn.apache.org/viewvc?rev=1744698=rev
Log:
Fix a memory leak with the pool cleaner thread that retained a reference to the 
web application class loader for the first web application to use a connection 
pool.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)

tomcat/tc8.5.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri May 20 10:54:10 2016
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501,1741677
 
,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684
+/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501,1741677
 
,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697

Modified: 
tomcat/tc8.5.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java?rev=1744698=1744697=1744698=diff
==
--- 
tomcat/tc8.5.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
 (original)
+++ 
tomcat/tc8.5.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
 Fri May 20 10:54:10 2016
@@ -20,6 +20,8 @@ import java.lang.ref.WeakReference;
 import java.lang.reflect.Constructor;
 import java.lang.reflect.InvocationHandler;
 import java.lang.reflect.Proxy;
+import java.security.AccessController;
+import java.security.PrivilegedAction;
 import java.sql.Connection;
 import java.sql.SQLException;
 import java.util.Collections;
@@ -1289,9 +1291,12 @@ public class ConnectionPool {
 ClassLoader loader = 
Thread.currentThread().getContextClassLoader();
 try {
 
Thread.currentThread().setContextClassLoader(ConnectionPool.class.getClassLoader());
-poolCleanTimer = new Timer("Tomcat JDBC Pool Cleaner["+ 

svn commit: r1744697 - in /tomcat/trunk: modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java webapps/docs/changelog.xml

[markt]

Author: markt
Date: Fri May 20 10:51:05 2016
New Revision: 1744697

URL: http://svn.apache.org/viewvc?rev=1744697=rev
Log:
Fix a memory leak with the pool cleaner thread that retained a reference to the 
web application class loader for the first web application to use a connection 
pool.

Modified:

tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java?rev=1744697=1744696=1744697=diff
==
--- 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
 (original)
+++ 
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
 Fri May 20 10:51:05 2016
@@ -20,6 +20,8 @@ import java.lang.ref.WeakReference;
 import java.lang.reflect.Constructor;
 import java.lang.reflect.InvocationHandler;
 import java.lang.reflect.Proxy;
+import java.security.AccessController;
+import java.security.PrivilegedAction;
 import java.sql.Connection;
 import java.sql.SQLException;
 import java.util.Collections;
@@ -1289,9 +1291,12 @@ public class ConnectionPool {
 ClassLoader loader = 
Thread.currentThread().getContextClassLoader();
 try {
 
Thread.currentThread().setContextClassLoader(ConnectionPool.class.getClassLoader());
-poolCleanTimer = new Timer("Tomcat JDBC Pool Cleaner["+ 
System.identityHashCode(ConnectionPool.class.getClassLoader()) + ":"+
-   System.currentTimeMillis() + "]", 
true);
-}finally {
+// Create the timer thread in a PrivilegedAction so that a
+// reference to the web application class loader is not created
+// via Thread.inheritedAccessControlContext
+PrivilegedAction pa = new PrivilegedNewTimer();
+poolCleanTimer = AccessController.doPrivileged(pa);
+} finally {
 Thread.currentThread().setContextClassLoader(loader);
 }
 }
@@ -1312,6 +1317,14 @@ public class ConnectionPool {
 }
 }
 
+private static class PrivilegedNewTimer implements PrivilegedAction 
{
+@Override
+public Timer run() {
+return new Timer("Tomcat JDBC Pool Cleaner["+ 
System.identityHashCode(ConnectionPool.class.getClassLoader()) + ":"+
+System.currentTimeMillis() + "]", true);
+}
+}
+
 public static Set getPoolCleaners() {
 return Collections.unmodifiableSet(cleaners);
 }

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1744697=1744696=1744697=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Fri May 20 10:51:05 2016
@@ -87,6 +87,15 @@
   
 
   
+  
+
+  
+Fix a memory leak with the pool cleaner thread that retained a 
reference
+to the web application class loader for the first web application to 
use
+a connection pool. (markt)
+  
+
+  
   
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1744693 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

[markt]

Author: markt
Date: Fri May 20 10:38:45 2016
New Revision: 1744693

URL: http://svn.apache.org/viewvc?rev=1744693=rev
Log:
Correct location in changelog

Modified:
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1744693=1744692=1744693=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Fri May 20 10:38:45 2016
@@ -133,19 +133,23 @@
   
 
   
-  
+  
 
   
-Ensure that a client disconnection triggers the error handling for the
-associated WebSocket end point. (markt)
-  
-  
 Fix a memory leak in the expression language implementation that caused
 the class loader of the first web application to use expressions to be
 pinned in memory. (markt)
   
 
   
+  
+
+  
+Ensure that a client disconnection triggers the error handling for the
+associated WebSocket end point. (markt)
+  
+
+  
   
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1744692 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/el/parser/ELParser.java webapps/docs/changelog.xml

[markt]

Author: markt
Date: Fri May 20 10:37:43 2016
New Revision: 1744692

URL: http://svn.apache.org/viewvc?rev=1744692=rev
Log:
Fix an EL memory leak.
Note: This fix requires changing generated code. A bug has been raised with 
JavaCC:
https://java.net/jira/browse/JAVACC-293

Modified:
tomcat/tc6.0.x/trunk/   (props changed)
tomcat/tc6.0.x/trunk/java/org/apache/el/parser/ELParser.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc6.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri May 20 10:37:43 2016
@@ -1,4 +1,4 @@
-/tomcat/tc7.0.x/trunk:1190476,1224802,1243045,1298635,1304471,1311997,1312007,1331772,1333164,1333176,1348992,1354866,1371298,1371302,1371620,1402110,1409014,1413553,1413557,1413563,1430083,1438415,1446641-1446660,1447013,1453106,1453119,1484919,1486877,1500065,1503852,1505844,1513151,1521040,1526470,1536524,1539176-1539177,1544469,1544473,1552805,1558894,1558917,1561368,1561382,1561386,1561552,1561561,1561636,1561641,1561643,1561737,1562748,1564317,1568922,1570163,1577328,1577464-1577465,1578814,1586659,1586897,1586960,1588199,1588997,1589740,1589851,1589997,1590019,1590028,1590337,1590492,1590651,1590838,1590845,1590848,1590912,1593262,1593288,1593371,1593835,1594230,1595174,1595366,1600956,1601333,1601856,1601909,1609079,1609606,1617364,1617374,1617433,1617457-1617458,1624249,1626579,1627420,1627469,1632586,1637686,1637711,1640675,1642045,1643515,1643540,1643572,1643585-1643586,1643642,1643647,1644019,1648817,1656301,1658815,1659523,1659564,1664001,1664176,1665087,1666968,1666989
 
,1668541,1668635,1669802,1676557,1681183,1681841,1681865,1681867,1685829,1693109,1694293,1694433,1694875,1696381,1701945,1710353,1712656,1713873,1714000,1714005,1714540,1715213,1716221,1716417,1717107,1717210,1717212,1720236,1720398,1720443,1720464,1721814,1721883,1722645,1722801,1723151,1724435,1724553,1724675,1724797,1724806,1725931,1726631,1726808,1726813,1726815,1726817,1726819,1726917,1726919,1726922-1726924,1727031,1727034,1727043,1727158,1727672,1727903,1728450,1729363,1731010,1731119,1731956,1731978,1732362,1732674-1732675,1733942,1734116,1734134,1734532,1737249,1737253,1737968,1738049,1738186,1739778,1741178,1741184,1741193,1741211,1741218,1741228,1741235,1742281,1743121,1743142,1743649,1744061,1744129,1744155,1744241,1744383
+/tomcat/tc7.0.x/trunk:1190476,1224802,1243045,1298635,1304471,1311997,1312007,1331772,1333164,1333176,1348992,1354866,1371298,1371302,1371620,1402110,1409014,1413553,1413557,1413563,1430083,1438415,1446641-1446660,1447013,1453106,1453119,1484919,1486877,1500065,1503852,1505844,1513151,1521040,1526470,1536524,1539176-1539177,1544469,1544473,1552805,1558894,1558917,1561368,1561382,1561386,1561552,1561561,1561636,1561641,1561643,1561737,1562748,1564317,1568922,1570163,1577328,1577464-1577465,1578814,1586659,1586897,1586960,1588199,1588997,1589740,1589851,1589997,1590019,1590028,1590337,1590492,1590651,1590838,1590845,1590848,1590912,1593262,1593288,1593371,1593835,1594230,1595174,1595366,1600956,1601333,1601856,1601909,1609079,1609606,1617364,1617374,1617433,1617457-1617458,1624249,1626579,1627420,1627469,1632586,1637686,1637711,1640675,1642045,1643515,1643540,1643572,1643585-1643586,1643642,1643647,1644019,1648817,1656301,1658815,1659523,1659564,1664001,1664176,1665087,1666968,1666989
 
,1668541,1668635,1669802,1676557,1681183,1681841,1681865,1681867,1685829,1693109,1694293,1694433,1694875,1696381,1701945,1710353,1712656,1713873,1714000,1714005,1714540,1715213,1716221,1716417,1717107,1717210,1717212,1720236,1720398,1720443,1720464,1721814,1721883,1722645,1722801,1723151,1724435,1724553,1724675,1724797,1724806,1725931,1726631,1726808,1726813,1726815,1726817,1726819,1726917,1726919,1726922-1726924,1727031,1727034,1727043,1727158,1727672,1727903,1728450,1729363,1731010,1731119,1731956,1731978,1732362,1732674-1732675,1733942,1734116,1734134,1734532,1737249,1737253,1737968,1738049,1738186,1739778,1741178,1741184,1741193,1741211,1741218,1741228,1741235,1742281,1743121,1743142,1743649,1744061,1744129,1744155,1744241,1744383,1744689
 
/tomcat/tc8.0.x/trunk:1637685,1637709,1640674,1641726,1641729-1641730,1643513,1643539,1643571,1643581-1643582,1644018,1648816,1656300,1658801-1658803,1658811,1659522,1663997,1664175,1665086,1666967,1666988,1668634,1669801,1676556,1681182,1681840,1681864,1685827,1689921,1693108,1694291,1694427,1694873,1696379,1701944,1710347,1712618,1712655,1713872,1713998,1714004,1714538,1715207,1715866,1716216-1716217,1716414,1717208-1717209,1720235,1720396,1720442,1720463,1721813,1721882,1722800,1723130,1724434,1724674,1724792,1724803,1725929,1725963-1725965,1725970,1725974,1726172,1726175,1726179-1726182,1726195-1726198,1726200,1726203,1726226,1726576,1726630,1727029,1727037,1727671,1727900,1728449,1729362,1731009,1731955,1731977,1732360,1732672,1733941,1734115,1734133,1734531,1737967,1738173,1739777,1741217,1743647,1744152

svn commit: r1744689 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/el/parser/ELParser.java webapps/docs/changelog.xml

[markt]

Author: markt
Date: Fri May 20 10:34:50 2016
New Revision: 1744689

URL: http://svn.apache.org/viewvc?rev=1744689=rev
Log:
Fix an EL memory leak.
Note: This fix requires changing generated code. A bug has been raised with 
JavaCC:
https://java.net/jira/browse/JAVACC-293

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/el/parser/ELParser.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri May 20 10:34:50 2016
@@ -1,3 +1,3 @@
 
/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988,1667553
 
-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702739,1702742,1702
 
744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1725974,1726171-1
 
726173,1726175,1726179-1726182,1726190-1726191,1726195-1726200,1726203,1726226,1726576,1726630,1726992,1727029,1727037,1727671,1727676,1727900,1728028,1728092,1728439,1728449,1729186,1729362,1731009,1731303,1731867,1731872,1731874,1731876,1731885,1731947,1731955,1731959,1731977,1731984,1732360,1732490,1732672,1732902,1733166,1733603,1733619,1733735,1733752,1733764,1733915,1733941,1733964,1734115,1734133,1734261,1734421,1734531,1736286,1737967,1738173,1738182,1738992,1739039,1739089-1739091,1739294,1739777,1739821,1739981,1740513,1740726,1741019,1741162,1741217,1743647,1743681,1744152,1744272
-/tomcat/tc8.5.x/trunk:1735579,1736839,1737199,1737966,1738042,1738044,1738162,1738165,1738178,1739157,1739173,1739177,1739476,1740132,1740521,1740536,1740804,1740811,1740981,1741165,1741174,1741182,1741191,1741203,1741209,1741226,1741233,1741410,1742277,1743118,1743126,1743139-1743140,1743718,1743722,1743724,1744059,1744127,1744151,1744232,1744377

svn commit: r1744688 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/el/parser/ELParser.java webapps/docs/changelog.xml

[markt]

Author: markt
Date: Fri May 20 10:28:53 2016
New Revision: 1744688

URL: http://svn.apache.org/viewvc?rev=1744688=rev
Log:
Fix an EL memory leak.
Note: This fix requires changing generated code. A bug has been raised with 
JavaCC:
https://java.net/jira/browse/JAVACC-293

Modified:
tomcat/tc8.0.x/trunk/   (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/el/parser/ELParser.java
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri May 20 10:28:53 2016
@@ -1,2 +1,2 @@
 /tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 
666387,1666494,1666496,1666552,1666569,1666579,137,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679716,1680034,1680246,1681056,1681123,1681138,1681280,1681283,1681286,1681450,1681697,1681699,1681701,1681729,1681770,1681779,1681793,1681807,1681837-1681838,1681854,1681862,1681958,1682028,1682033,1682311,1682315,1682317,1682320,1682324,1682330,1682842,1684172,1684366,1684383,1684526-168452
 

svn commit: r1744687 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/el/parser/ELParser.java webapps/docs/changelog.xml

[markt]

Author: markt
Date: Fri May 20 10:24:12 2016
New Revision: 1744687

URL: http://svn.apache.org/viewvc?rev=1744687=rev
Log:
Fix an EL memory leak.
Note: This fix requires changing generated code. A bug has been raised with 
JavaCC:
https://java.net/jira/browse/JAVACC-293

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/java/org/apache/el/parser/ELParser.java
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri May 20 10:24:12 2016
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501,1741677
 
,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432
+/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501,1741677
 
,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684

Modified: tomcat/tc8.5.x/trunk/java/org/apache/el/parser/ELParser.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/el/parser/ELParser.java?rev=1744687=1744686=1744687=diff
==
--- tomcat/tc8.5.x/trunk/java/org/apache/el/parser/ELParser.java (original)
+++ tomcat/tc8.5.x/trunk/java/org/apache/el/parser/ELParser.java Fri May 20 
10:24:12 2016
@@ -2963,7 +2963,16 @@ public class ELParser/*@bgen(jjtree)*/im
 throw generateParseException();
   }
 
-  static private final class LookaheadSuccess extends java.lang.Error { }
+  static private final class LookaheadSuccess extends java.lang.Error {
+  /*
+   * Over-ridden to avoid memory leak via Throwable.backtrace
+   * https://java.net/jira/browse/JAVACC-293
+   */
+@Override
+public synchronized Throwable fillInStackTrace() {
+return this;
+}
+  }
   final private LookaheadSuccess jj_ls = new LookaheadSuccess();
   private boolean jj_scan_token(int kind) {
 if (jj_scanpos == jj_lastpos) {

Modified: tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml?rev=1744687=1744686=1744687=diff
==
--- tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml 

svn commit: r1744684 - in /tomcat/trunk: java/org/apache/el/parser/ELParser.java webapps/docs/changelog.xml

[markt]

Author: markt
Date: Fri May 20 10:16:35 2016
New Revision: 1744684

URL: http://svn.apache.org/viewvc?rev=1744684=rev
Log:
Fix an EL memory leak.
Note: This fix requires changing generated code. A bug has been raised with 
JavaCC:
https://java.net/jira/browse/JAVACC-293

Modified:
tomcat/trunk/java/org/apache/el/parser/ELParser.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/el/parser/ELParser.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/el/parser/ELParser.java?rev=1744684=1744683=1744684=diff
==
--- tomcat/trunk/java/org/apache/el/parser/ELParser.java (original)
+++ tomcat/trunk/java/org/apache/el/parser/ELParser.java Fri May 20 10:16:35 
2016
@@ -2963,7 +2963,16 @@ public class ELParser/*@bgen(jjtree)*/im
 throw generateParseException();
   }
 
-  static private final class LookaheadSuccess extends java.lang.Error { }
+  static private final class LookaheadSuccess extends java.lang.Error {
+  /*
+   * Over-ridden to avoid memory leak via Throwable.backtrace
+   * https://java.net/jira/browse/JAVACC-293
+   */
+@Override
+public synchronized Throwable fillInStackTrace() {
+return this;
+}
+  }
   final private LookaheadSuccess jj_ls = new LookaheadSuccess();
   private boolean jj_scan_token(int kind) {
 if (jj_scanpos == jj_lastpos) {

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1744684=1744683=1744684=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Fri May 20 10:16:35 2016
@@ -80,6 +80,11 @@
 59567: Fix NPE scanning webapps for TLDs when an exploded
 JAR has an empty WEB-INF/classes/META-INF folder. (remm)
   
+  
+Fix a memory leak in the expression language implementation that caused
+the class loader of the first web application to use expressions to be
+pinned in memory. (markt)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Regarding files generated by "JJTree"

[sangeeta lal]

Dear Sir,

*Thanks for your reply!*

Could you please tell me,  if there is any listing about all the  auto-
generated files. I have manually identified 59 files in the folder "
*tomcat\java\org\apache\el\parser*" which are auto generated.

I have following two questions:

1. Can tomcat project have auto-generated files in some other folder also?
2. Is the "JavaCC" only tool which is used to auto-generate the files ? or
there are some other tools as well?


I highly *appreciate your help* and time!

Thank You
Sangeeta

On Fri, May 20, 2016 at 3:14 PM, Martin Grigorov 
wrote:

> Hello Sangeeta,
>
> Yes, those files are auto-generated by a tool: https://javacc.java.net/.
>
>
> On Fri, May 20, 2016 at 11:41 AM, sangeeta lal 
> wrote:
>
> > Dear Dev Team,
> >
> > Can anyone please give me little information about these files?
> >
> > Thank You
> >
> > On Thu, May 19, 2016 at 8:22 PM, sangeeta lal 
> > wrote:
> >
> > >
> > > Dear Dev Team,
> > >
> > >
> > > I am Sangeeta. I am a PhD Scholar in the area of automated software
> > > engineering. I am currently studying source code of Apache Tomcat
> > project.
> > > While studying the source code. I noticed a folder in Apache Tomcat
> > project
> > > consisting of 58 files having following line written in them:
> > >
> > >
> > > "/* *Generated By:JJTree: Do not edit this line.
> AstLambdaExpression.java
> > > Version 4.3 */"*
> > >
> > >
> > > Can anyone please explain me little about the meaning of this line? Are
> > > all such files  generated by this tool have no contribution from the
> > human
> > > developers?
> > >
> > > I highly appreciate your help!
> > >
> > > Thanks You
> > > Sangeeta
> > >
> > > --
> > > Regards...
> > > Sangeeta
> > > Assistant Professor
> > > CSE Department @JIIT Noida
> > >
> > >
> >
> >
> > --
> > Regards...
> > Sangeeta
> > Assistant Professor
> > CSE Department @JIIT Noida
> >
>



-- 
Regards...
Sangeeta
Assistant Professor
CSE Department @JIIT Noida

Re: Regarding files generated by "JJTree"

[Martin Grigorov]

Hello Sangeeta,

Yes, those files are auto-generated by a tool: https://javacc.java.net/.


On Fri, May 20, 2016 at 11:41 AM, sangeeta lal 
wrote:

> Dear Dev Team,
>
> Can anyone please give me little information about these files?
>
> Thank You
>
> On Thu, May 19, 2016 at 8:22 PM, sangeeta lal 
> wrote:
>
> >
> > Dear Dev Team,
> >
> >
> > I am Sangeeta. I am a PhD Scholar in the area of automated software
> > engineering. I am currently studying source code of Apache Tomcat
> project.
> > While studying the source code. I noticed a folder in Apache Tomcat
> project
> > consisting of 58 files having following line written in them:
> >
> >
> > "/* *Generated By:JJTree: Do not edit this line. AstLambdaExpression.java
> > Version 4.3 */"*
> >
> >
> > Can anyone please explain me little about the meaning of this line? Are
> > all such files  generated by this tool have no contribution from the
> human
> > developers?
> >
> > I highly appreciate your help!
> >
> > Thanks You
> > Sangeeta
> >
> > --
> > Regards...
> > Sangeeta
> > Assistant Professor
> > CSE Department @JIIT Noida
> >
> >
>
>
> --
> Regards...
> Sangeeta
> Assistant Professor
> CSE Department @JIIT Noida
>

Re: Regarding files generated by "JJTree"

[sangeeta lal]

Dear Dev Team,

Can anyone please give me little information about these files?

Thank You

On Thu, May 19, 2016 at 8:22 PM, sangeeta lal 
wrote:

>
> Dear Dev Team,
>
>
> I am Sangeeta. I am a PhD Scholar in the area of automated software
> engineering. I am currently studying source code of Apache Tomcat project.
> While studying the source code. I noticed a folder in Apache Tomcat project
> consisting of 58 files having following line written in them:
>
>
> "/* *Generated By:JJTree: Do not edit this line. AstLambdaExpression.java
> Version 4.3 */"*
>
>
> Can anyone please explain me little about the meaning of this line? Are
> all such files  generated by this tool have no contribution from the human
> developers?
>
> I highly appreciate your help!
>
> Thanks You
> Sangeeta
>
> --
> Regards...
> Sangeeta
> Assistant Professor
> CSE Department @JIIT Noida
>
>


-- 
Regards...
Sangeeta
Assistant Professor
CSE Department @JIIT Noida

[Bug 59604] Invalid url-pattern in servlet mapping on s390x

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59604

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #2 from Mark Thomas  ---
That looks like some form of encoding problem. Tomcat 7.0.x uses ISO-8859-1 for
web.xml whereas Tomcat 8.0.x uses UTF-8.

Given that the contents of the files are correct for the given encoding this
looks like a JVM issue on your OS.

As far as I am aware, none of the Tomcat committers have access to a z/OS
system for testing. You are going to have to debug this one on your own unless
you can provide one of us with access to a test system.

Interesting... conf/web.xml is still using ISO-8859-1. That should be UTF-8.
Although I don't think it will help in your case it is worth changing to see if
it does.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[jira] [Comment Edited] (MTOMCAT-276) Could not properly stop Tomcat when integration tests are failing

[Christos Karalis (JIRA)]

[ 
https://issues.apache.org/jira/browse/MTOMCAT-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15293011#comment-15293011
 ] 

Christos Karalis edited comment on MTOMCAT-276 at 5/20/16 8:40 AM:
---

i´ve had the same the issue but was mostly due to the false configuration of 
maven-failsafe-plugin probably taken from another example from web. The proper 
configuration is : 
{code:xml}

  
integration-test

  integration-test

  
  
verify

  verify

  

{code}
 instead of 
{code:xml}

  
integration-test

  integration-test
  verify

  

{code}



was (Author: ckar):
i´ve had the same the issue but was mostly due to the false configuration of 
maven-failsafe-plugin probably taken from another example from web. The proper 
configuration is : 

  
integration-test

  integration-test

  
  
verify

  verify

  

 instead of 

  
integration-test

  integration-test
  verify

  


> Could not properly stop Tomcat when integration tests are failing
> -
>
> Key: MTOMCAT-276
> URL: https://issues.apache.org/jira/browse/MTOMCAT-276
> Project: Apache Tomcat Maven Plugin
>  Issue Type: Bug
>  Components: tomcat7
>Affects Versions: 2.2
>Reporter: vigi
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Minor
>  Labels: integration-test, integration-tests, maven, tomcat
>
> When running integration tests with the Maven Tomcat plugin 2.2 and if the 
> tests are failing, Tomcat generates a nasty error while trying to be stopped.
> Everything is fine if the tests pass. Here is the stacktrace:
> ERROR: IllegalAccessException for stop method in class 
> org.apache.tomcat.maven.plugin.tomcat7.run.ExtendedTomcat
> java.lang.reflect.InvocationTargetException
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:606)
>   at 
> org.apache.tomcat.maven.common.run.EmbeddedRegistry.shutdownAll(EmbeddedRegistry.java:110)
>   at 
> org.apache.tomcat.maven.common.run.EmbeddedRegistry$1.run(EmbeddedRegistry.java:69)
> Caused by: org.apache.catalina.LifecycleException: Failed to stop component 
> [StandardServer[-1]]
>   at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:236)
>   at org.apache.catalina.startup.Tomcat.stop(Tomcat.java:351)
>   ... 6 more
> Caused by: org.apache.catalina.LifecycleException: Failed to stop component 
> [StandardService[Tomcat]]
>   at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:236)
>   at 
> org.apache.catalina.core.StandardServer.stopInternal(StandardServer.java:753)
>   at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:232)
>   ... 7 more
> Caused by: org.apache.catalina.LifecycleException: Failed to stop component 
> [StandardEngine[Tomcat]]
>   at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:236)
>   at 
> org.apache.catalina.core.StandardService.stopInternal(StandardService.java:502)
>   at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:232)
>   ... 9 more
> Caused by: java.lang.NoClassDefFoundError: 
> org/apache/catalina/core/ContainerBase$StopChild
>   at 
> org.apache.catalina.core.ContainerBase.stopInternal(ContainerBase.java:1173)
>   at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:232)
>   ... 11 more
> Caused by: java.lang.ClassNotFoundException: 
> org.apache.catalina.core.ContainerBase$StopChild
>   at 
> org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:50)
>   at 
> org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass(ClassRealm.java:259)
>   at 
> org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:235)
>   at 
> org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:227)
>   ... 13 more



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[jira] [Commented] (MTOMCAT-276) Could not properly stop Tomcat when integration tests are failing

[Christos Karalis (JIRA)]

[ 
https://issues.apache.org/jira/browse/MTOMCAT-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15293011#comment-15293011
 ] 

Christos Karalis commented on MTOMCAT-276:
--

i´ve had the same the issue but was mostly due to the false configuration of 
maven-failsafe-plugin probably taken from another example from web. The proper 
configuration is : 

  
integration-test

  integration-test

  
  
verify

  verify

  

 instead of 

  
integration-test

  integration-test
  verify

  


> Could not properly stop Tomcat when integration tests are failing
> -
>
> Key: MTOMCAT-276
> URL: https://issues.apache.org/jira/browse/MTOMCAT-276
> Project: Apache Tomcat Maven Plugin
>  Issue Type: Bug
>  Components: tomcat7
>Affects Versions: 2.2
>Reporter: vigi
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Minor
>  Labels: integration-test, integration-tests, maven, tomcat
>
> When running integration tests with the Maven Tomcat plugin 2.2 and if the 
> tests are failing, Tomcat generates a nasty error while trying to be stopped.
> Everything is fine if the tests pass. Here is the stacktrace:
> ERROR: IllegalAccessException for stop method in class 
> org.apache.tomcat.maven.plugin.tomcat7.run.ExtendedTomcat
> java.lang.reflect.InvocationTargetException
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:606)
>   at 
> org.apache.tomcat.maven.common.run.EmbeddedRegistry.shutdownAll(EmbeddedRegistry.java:110)
>   at 
> org.apache.tomcat.maven.common.run.EmbeddedRegistry$1.run(EmbeddedRegistry.java:69)
> Caused by: org.apache.catalina.LifecycleException: Failed to stop component 
> [StandardServer[-1]]
>   at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:236)
>   at org.apache.catalina.startup.Tomcat.stop(Tomcat.java:351)
>   ... 6 more
> Caused by: org.apache.catalina.LifecycleException: Failed to stop component 
> [StandardService[Tomcat]]
>   at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:236)
>   at 
> org.apache.catalina.core.StandardServer.stopInternal(StandardServer.java:753)
>   at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:232)
>   ... 7 more
> Caused by: org.apache.catalina.LifecycleException: Failed to stop component 
> [StandardEngine[Tomcat]]
>   at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:236)
>   at 
> org.apache.catalina.core.StandardService.stopInternal(StandardService.java:502)
>   at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:232)
>   ... 9 more
> Caused by: java.lang.NoClassDefFoundError: 
> org/apache/catalina/core/ContainerBase$StopChild
>   at 
> org.apache.catalina.core.ContainerBase.stopInternal(ContainerBase.java:1173)
>   at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:232)
>   ... 11 more
> Caused by: java.lang.ClassNotFoundException: 
> org.apache.catalina.core.ContainerBase$StopChild
>   at 
> org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:50)
>   at 
> org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass(ClassRealm.java:259)
>   at 
> org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:235)
>   at 
> org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:227)
>   ... 13 more



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 59606] Tomcat experiences a NullPointerException and does not work if a JAR without a manifest is on the class path

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59606

Remy Maucherat  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #2 from Remy Maucherat  ---


*** This bug has been marked as a duplicate of bug 59566 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 59566] NPE from StandardJarScanner for JARs without a manifest

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59566

Remy Maucherat  changed:

   What|Removed |Added

 CC||alexand...@gmx.net

--- Comment #2 from Remy Maucherat  ---
*** Bug 59606 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 59606] Tomcat experiences a NullPointerException and does not work if a JAR without a manifest is on the class path

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59606

Alexander Veit  changed:

   What|Removed |Added

Summary|Tomcat experiences a|Tomcat experiences a
   |NullPointerException and|NullPointerException and
   |does not work if JAR|does not work if a JAR
   |without a manifest is on|without a manifest is on
   |the class path  |the class path

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 59606] Tomcat experiences a NullPointerException and does not work if JAR without a manifest is on the class path

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59606

--- Comment #1 from Alexander Veit  ---
The problem might be related to
https://bz.apache.org/bugzilla/show_bug.cgi?id=59226.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 59606] New: Tomcat experiences a NullPointerException and does not work if JAR without a manifest is on the class path

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59606

Bug ID: 59606
   Summary: Tomcat experiences a NullPointerException and does not
work if JAR without a manifest is on the class path
   Product: Tomcat 8
   Version: 8.0.35
  Hardware: PC
OS: Windows NT
Status: NEW
  Severity: critical
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: alexand...@gmx.net

If a JAR without a manifest (e.g. http://spnego.sourceforge.net/) is on the
class path a NullPointerException occurs at startup.  Tomcat serves blank pages
afterwards.

INFO   | jvm 1| 2016/05/20 08:48:52 |
org.apache.catalina.LifecycleException: Failed to start component
[StandardEngine[Catalina].StandardHost[localhost].StandardContext[]]
INFO   | jvm 1| 2016/05/20 08:48:52 | at
org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:153)
INFO   | jvm 1| 2016/05/20 08:48:52 | at
org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:725)
INFO   | jvm 1| 2016/05/20 08:48:52 | at
org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:701)
INFO   | jvm 1| 2016/05/20 08:48:52 | at
org.apache.catalina.core.StandardHost.addChild(StandardHost.java:717)
INFO   | jvm 1| 2016/05/20 08:48:52 | at
org.apache.catalina.startup.HostConfig.deployDirectory(HostConfig.java:1092)
INFO   | jvm 1| 2016/05/20 08:48:52 | at
org.apache.catalina.startup.HostConfig$DeployDirectory.run(HostConfig.java:1834)
INFO   | jvm 1| 2016/05/20 08:48:52 | at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
INFO   | jvm 1| 2016/05/20 08:48:52 | at
java.util.concurrent.FutureTask.run(FutureTask.java:266)
INFO   | jvm 1| 2016/05/20 08:48:52 | at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
INFO   | jvm 1| 2016/05/20 08:48:52 | at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
INFO   | jvm 1| 2016/05/20 08:48:52 | at
java.lang.Thread.run(Thread.java:745)
INFO   | jvm 1| 2016/05/20 08:48:52 | Caused by:
java.lang.NullPointerException
INFO   | jvm 1| 2016/05/20 08:48:52 | at
org.apache.tomcat.util.scan.StandardJarScanner.processManifest(StandardJarScanner.java:369)
INFO   | jvm 1| 2016/05/20 08:48:52 | at
org.apache.tomcat.util.scan.StandardJarScanner.process(StandardJarScanner.java:324)
INFO   | jvm 1| 2016/05/20 08:48:52 | at
org.apache.tomcat.util.scan.StandardJarScanner.scan(StandardJarScanner.java:273)
INFO   | jvm 1| 2016/05/20 08:48:52 | at
org.apache.catalina.startup.ContextConfig.processJarsForWebFragments(ContextConfig.java:1887)
INFO   | jvm 1| 2016/05/20 08:48:52 | at
org.apache.catalina.startup.ContextConfig.webConfig(ContextConfig.java:1127)
INFO   | jvm 1| 2016/05/20 08:48:52 | at
org.apache.catalina.startup.ContextConfig.configureStart(ContextConfig.java:779)
INFO   | jvm 1| 2016/05/20 08:48:52 | at
org.apache.catalina.startup.ContextConfig.lifecycleEvent(ContextConfig.java:306)
INFO   | jvm 1| 2016/05/20 08:48:52 | at
org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:95)
INFO   | jvm 1| 2016/05/20 08:48:52 | at
org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:90)
INFO   | jvm 1| 2016/05/20 08:48:52 | at
org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5171)
INFO   | jvm 1| 2016/05/20 08:48:52 | at
org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:147)
INFO   | jvm 1| 2016/05/20 08:48:52 | ... 10 more

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org