Which IDE?
Commiters, patch authors. Do you use an IDE to modify tomcat source code? If you do which one? Asking again in releation to bug 50001. Trying to see what ide's should be supported. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Which IDE?
On 26/09/2010 19:08, Wesley Acheson wrote: > Commiters, patch authors. > > Do you use an IDE to modify tomcat source code? Yes. > If you do which one? Eclipse for Java. Visual Studio (rarely) for C code. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Which IDE?
On Sun, Sep 26, 2010 at 8:13 PM, Mark Thomas wrote: > On 26/09/2010 19:08, Wesley Acheson wrote: >> Commiters, patch authors. >> >> Do you use an IDE to modify tomcat source code? > > Yes. > >> If you do which one? > > Eclipse for Java. Really do you use the formatter for the code? If so we could use your settings. > Visual Studio (rarely) for C code. > > Mark > I've no idea on how to put in IDE specific files for Visual Studio. Wes - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Which IDE?
On 26/09/2010 19:38, Wesley Acheson wrote: > On Sun, Sep 26, 2010 at 8:13 PM, Mark Thomas wrote: >> On 26/09/2010 19:08, Wesley Acheson wrote: >>> Commiters, patch authors. >>> >>> Do you use an IDE to modify tomcat source code? >> >> Yes. >> >>> If you do which one? >> >> Eclipse for Java. > > Really do you use the formatter for the code? If so we could use your > settings. No. Applying the code formatter makes too many changes and adds far to much noise to the commits. The only change I make to default Eclipse settings is to switch from tabs to spaces. Mark > > >> Visual Studio (rarely) for C code. >> >> Mark >> > > I've no idea on how to put in IDE specific files for Visual Studio. > > Wes > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Which IDE?
On Sun, Sep 26, 2010 at 8:44 PM, Mark Thomas wrote: > On 26/09/2010 19:38, Wesley Acheson wrote: >> On Sun, Sep 26, 2010 at 8:13 PM, Mark Thomas wrote: >>> On 26/09/2010 19:08, Wesley Acheson wrote: Commiters, patch authors. Do you use an IDE to modify tomcat source code? >>> >>> Yes. >>> If you do which one? >>> >>> Eclipse for Java. >> >> Really do you use the formatter for the code? If so we could use your >> settings. > > No. Applying the code formatter makes too many changes and adds far to > much noise to the commits. Only the once though if everyone (the commiters especially) has the same format. Which is really nice. Its a big noise but its a big noise once. Wes > > The only change I make to default Eclipse settings is to switch from > tabs to spaces. > > Mark > >> >> >>> Visual Studio (rarely) for C code. >>> >>> Mark >>> >> >> I've no idea on how to put in IDE specific files for Visual Studio. >> >> Wes >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >> For additional commands, e-mail: dev-h...@tomcat.apache.org >> > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Which IDE?
On 26/09/2010 19:47, Wesley Acheson wrote: > Which is really nice. Its a big noise but its a big noise once. Which persists in the file's history making diffs that span the format change almost impossible to decipher. Small gradual changes is the approach the project has taken to date. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Which IDE?
On 26/09/2010 19:57, Mark Thomas wrote: > On 26/09/2010 19:47, Wesley Acheson wrote: >> Which is really nice. Its a big noise but its a big noise once. > > Which persists in the file's history making diffs that span the format > change almost impossible to decipher. Small gradual changes is the > approach the project has taken to date. There's a lot of code in Tomcat that's been around for a long time. There's a few places where cosmetic changes would help readability, and plenty more when extensive/detailed commenting (by someone who understands what that code intends to do, and actually does) would help. I'd rather see that as a priority, than applying a common code style, in the foreseeable. p 0x62590808.asc Description: application/pgp-keys signature.asc Description: OpenPGP digital signature
Re: Which IDE?
On Sun, Sep 26, 2010 at 10:26 PM, Pid wrote: > On 26/09/2010 19:57, Mark Thomas wrote: >> On 26/09/2010 19:47, Wesley Acheson wrote: >>> Which is really nice. Its a big noise but its a big noise once. >> >> Which persists in the file's history making diffs that span the format >> change almost impossible to decipher. Small gradual changes is the >> approach the project has taken to date. > > There's a lot of code in Tomcat that's been around for a long time. > > There's a few places where cosmetic changes would help readability, and > plenty more when extensive/detailed commenting (by someone who > understands what that code intends to do, and actually does) would help. > > I'd rather see that as a priority, than applying a common code style, in > the foreseeable. > > > p > Understood. The reason I was thinking it was important is to try to lower the bar. So to speak the easier you make it for people to contribute the more likely you are to get contributions. I also agree with Marks statement above I just didn't think of it at the time. And yes that would be more helpful. Though I'm sure everyone just helps in the way they can. Wes - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Which IDE?
On Sep 26, 2010, at 11:08 AM, Wesley Acheson wrote: > Commiters, patch authors. > > Do you use an IDE to modify tomcat source code? > > If you do which one? IDEA > > Asking again in releation to bug 50001. Trying to see what ide's > should be supported. My experience with IDE specific files is that checking them into svn usually causes far more problems that it solves. Maybe you'll be lucky and solve more than you cause. If I'm the only IDEA user I'd appreciate your not putting IDEA specific files in svn. thanks david jencks > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Which IDE?
On Mon, Sep 27, 2010 at 12:18 AM, David Jencks wrote: > > On Sep 26, 2010, at 11:08 AM, Wesley Acheson wrote: > >> Commiters, patch authors. >> >> Do you use an IDE to modify tomcat source code? >> >> If you do which one? > > IDEA >> >> Asking again in releation to bug 50001. Trying to see what ide's >> should be supported. > > My experience with IDE specific files is that checking them into svn usually > causes far more problems that it solves. Maybe you'll be lucky and solve > more than you cause. If I'm the only IDEA user I'd appreciate your not > putting IDEA specific files in svn. > > thanks > david jencks > 1. I wasn't intending in putting anything where it would automatically be used. 2. I was hoping to munge files. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
