RE: Decommission of wicket-datetime
Decommissioning is probably a good thing. I know I sometimes get confused between extensions/dateTime as to which one I'm using. But IIRC extensions uses java.util.date and datetime uses joda. How are you going to rectify that part of the merge? Thanks, Tom Burton -Original Message- From: Andrea Del Bene [mailto:an.delb...@gmail.com] Sent: Friday, February 06, 2015 6:54 AM To: dev@wicket.apache.org Subject: Re: Decommission of wicket-datetime Yes of course :) ... and move the remaining YUI packages to wicketstuff-yui ? Sven On 06.02.2015 16:22, Andrea Del Bene wrote: I see. Also the two DateTextField have no functional difference. This is in short what I would do: Remove: /wicket-datetime/src/main/java/org/apache/wicket/datetime/DateConverter.java Move to wicket-utils: /wicket-datetime/src/main/java/org/apache/wicket/datetime/PatternDateConverter.java /wicket-datetime/src/main/java/org/apache/wicket/datetime/StyleDateConverter.java Move to wicket-extensions: /wicket-datetime/src/main/java/org/apache/wicket/datetime/markup/html/basic/DateLabel.java Merge wicket-datetime DateTextField into the existing wicket-extensions DateTextField. The first one has a DateConverter as constructor parameter which is used internally instead of a more generic IConverterDate. it would be nice to have single component with the same constructors of the existing two. What do you think?
[GitHub] wicket pull request: WICKET-5828 PageProvider not serializable
Github user asfgit closed the pull request at: https://github.com/apache/wicket/pull/89 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket pull request: WICKET-5828 PageProvider not serializable
Github user martin-g commented on the pull request: https://github.com/apache/wicket/pull/89#issuecomment-73305327 Thank you, Tobias! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] wicket pull request: WICKET-5828 PageProvider not serializable
GitHub user klopfdreh opened a pull request: https://github.com/apache/wicket/pull/89 WICKET-5828 PageProvider not serializable You can merge this pull request into a Git repository by running: $ git pull https://github.com/klopfdreh/wicket WICKET-5828 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/wicket/pull/89.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #89 commit b7630fd160e6e710f1ed7cae72c65758b926d9ce Author: klopfdreh klopfdreh@tobiass-mbp Date: 2015-02-06T19:40:13Z WICKET-5828 PageProvider not serializable --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: Decommission of wicket-datetime
I'm OK with that :) On Fri, Feb 6, 2015 at 5:44 PM, Andrea Del Bene an.delb...@gmail.com wrote: I half agree with this. We should move yui to wicketstuff but I'd rather move the rest of datetime (few classes) under wicket-util. One thing Maybe it make sense to move org.apache.wicket.extensions.yui to wicketstuff but leave org.apache.wicket.datetime as is? On Fri, Feb 6, 2015 at 1:21 PM, Emond Papegaaij emond.papega...@topicus.nl wrote: -- WBR Maxim aka solomax
Re: Decommission of wicket-datetime
Please be more detailed when you have to say something. Which classes ? Why do you want to keep them around ? Such minor useful things. Thank you! Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Fri, Feb 6, 2015 at 1:45 PM, Maxim Solodovnik solomax...@gmail.com wrote: I'm OK with that :) On Fri, Feb 6, 2015 at 5:44 PM, Andrea Del Bene an.delb...@gmail.com wrote: I half agree with this. We should move yui to wicketstuff but I'd rather move the rest of datetime (few classes) under wicket-util. One thing Maybe it make sense to move org.apache.wicket.extensions.yui to wicketstuff but leave org.apache.wicket.datetime as is? On Fri, Feb 6, 2015 at 1:21 PM, Emond Papegaaij emond.papega...@topicus.nl wrote: -- WBR Maxim aka solomax
Re: Decommission of wicket-datetime
I half agree with this. We should move yui to wicketstuff but I'd rather move the rest of datetime (few classes) under wicket-util. One thing Maybe it make sense to move org.apache.wicket.extensions.yui to wicketstuff but leave org.apache.wicket.datetime as is? On Fri, Feb 6, 2015 at 1:21 PM, Emond Papegaaij emond.papega...@topicus.nl wrote:
Re: Decommission of wicket-datetime
Yes of course :) ... and move the remaining YUI packages to wicketstuff-yui ? Sven On 06.02.2015 16:22, Andrea Del Bene wrote: I see. Also the two DateTextField have no functional difference. This is in short what I would do: Remove: /wicket-datetime/src/main/java/org/apache/wicket/datetime/DateConverter.java Move to wicket-utils: /wicket-datetime/src/main/java/org/apache/wicket/datetime/PatternDateConverter.java /wicket-datetime/src/main/java/org/apache/wicket/datetime/StyleDateConverter.java Move to wicket-extensions: /wicket-datetime/src/main/java/org/apache/wicket/datetime/markup/html/basic/DateLabel.java Merge wicket-datetime DateTextField into the existing wicket-extensions DateTextField. The first one has a DateConverter as constructor parameter which is used internally instead of a more generic IConverterDate. it would be nice to have single component with the same constructors of the existing two. What do you think?
Re: Decommission of wicket-datetime
... and move the remaining YUI packages to wicketstuff-yui ? Sven On 06.02.2015 16:22, Andrea Del Bene wrote: I see. Also the two DateTextField have no functional difference. This is in short what I would do: Remove: /wicket-datetime/src/main/java/org/apache/wicket/datetime/DateConverter.java Move to wicket-utils: /wicket-datetime/src/main/java/org/apache/wicket/datetime/PatternDateConverter.java /wicket-datetime/src/main/java/org/apache/wicket/datetime/StyleDateConverter.java Move to wicket-extensions: /wicket-datetime/src/main/java/org/apache/wicket/datetime/markup/html/basic/DateLabel.java Merge wicket-datetime DateTextField into the existing wicket-extensions DateTextField. The first one has a DateConverter as constructor parameter which is used internally instead of a more generic IConverterDate. it would be nice to have single component with the same constructors of the existing two. What do you think? On 06/02/15 14:24, Sebastien wrote: Hi devs, Actually Wicket jQuery UI's DatePicker extends org.apache.wicket. *extensions*.markup.html.form.DateTextField By the way, Wicket Utils already have org.apache.wicket.*util*.convert.converter.DateConverter. I did not check the differences.. DateLabel PatternDateConverter are probably convenient. I didn't know they exists so I write them for my work purpose, I suppose many users did the same... So why not moving them to *wicket-extensions* as well... Best regards, Sebastien. On Fri, Feb 6, 2015 at 2:02 PM, Sven Meier s...@meiers.net wrote:
Re: Decommission of wicket-datetime
Those who are not inside org.apache.wicket.extensions.yui :-). Five classes: /wicket-datetime/src/main/java/org/apache/wicket/datetime/DateConverter.java /wicket-datetime/src/main/java/org/apache/wicket/datetime/PatternDateConverter.java /wicket-datetime/src/main/java/org/apache/wicket/datetime/StyleDateConverter.java /wicket-datetime/src/main/java/org/apache/wicket/datetime/markup/html/basic/DateLabel.java /wicket-datetime/src/main/java/org/apache/wicket/datetime/markup/html/form/DateTextField.java I see no reason to externalize them in a wicketstuff module. They have nothing to do with yui. Maybe the last two classes should go in the core module under org.apache.wicket.markup.html. Please be more detailed when you have to say something. Which classes ? Why do you want to keep them around ? Such minor useful things. Thank you! Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Fri, Feb 6, 2015 at 1:45 PM, Maxim Solodovnik solomax...@gmail.com wrote: I'm OK with that :) On Fri, Feb 6, 2015 at 5:44 PM, Andrea Del Bene an.delb...@gmail.com wrote: I half agree with this. We should move yui to wicketstuff but I'd rather move the rest of datetime (few classes) under wicket-util. One thing Maybe it make sense to move org.apache.wicket.extensions.yui to wicketstuff but leave org.apache.wicket.datetime as is? On Fri, Feb 6, 2015 at 1:21 PM, Emond Papegaaij emond.papega...@topicus.nl wrote: -- WBR Maxim aka solomax
Re: Decommission of wicket-datetime
I agree Additionally wicket-jquery-ui extends DateTextField to provide date picker On Fri, Feb 6, 2015 at 6:56 PM, Andrea Del Bene an.delb...@gmail.com wrote: Those who are not inside org.apache.wicket.extensions.yui :-). Five classes: /wicket-datetime/src/main/java/org/apache/wicket/ datetime/DateConverter.java /wicket-datetime/src/main/java/org/apache/wicket/ datetime/PatternDateConverter.java /wicket-datetime/src/main/java/org/apache/wicket/ datetime/StyleDateConverter.java /wicket-datetime/src/main/java/org/apache/wicket/ datetime/markup/html/basic/DateLabel.java /wicket-datetime/src/main/java/org/apache/wicket/ datetime/markup/html/form/DateTextField.java I see no reason to externalize them in a wicketstuff module. They have nothing to do with yui. Maybe the last two classes should go in the core module under org.apache.wicket.markup.html. Please be more detailed when you have to say something. Which classes ? Why do you want to keep them around ? Such minor useful things. Thank you! Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Fri, Feb 6, 2015 at 1:45 PM, Maxim Solodovnik solomax...@gmail.com wrote: I'm OK with that :) On Fri, Feb 6, 2015 at 5:44 PM, Andrea Del Bene an.delb...@gmail.com wrote: I half agree with this. We should move yui to wicketstuff but I'd rather move the rest of datetime (few classes) under wicket-util. One thing Maybe it make sense to move org.apache.wicket.extensions.yui to wicketstuff but leave org.apache.wicket.datetime as is? On Fri, Feb 6, 2015 at 1:21 PM, Emond Papegaaij emond.papega...@topicus.nl wrote: -- WBR Maxim aka solomax -- WBR Maxim aka solomax
Re: Decommission of wicket-datetime
Hi Andrea, IMHO the components belong into wicket-extensions. Note that we already have a DateTextField there. Regards Sven On 06.02.2015 13:56, Andrea Del Bene wrote: Those who are not inside org.apache.wicket.extensions.yui :-). Five classes: /wicket-datetime/src/main/java/org/apache/wicket/datetime/DateConverter.java /wicket-datetime/src/main/java/org/apache/wicket/datetime/PatternDateConverter.java /wicket-datetime/src/main/java/org/apache/wicket/datetime/StyleDateConverter.java /wicket-datetime/src/main/java/org/apache/wicket/datetime/markup/html/basic/DateLabel.java /wicket-datetime/src/main/java/org/apache/wicket/datetime/markup/html/form/DateTextField.java I see no reason to externalize them in a wicketstuff module. They have nothing to do with yui. Maybe the last two classes should go in the core module under org.apache.wicket.markup.html. Please be more detailed when you have to say something. Which classes ? Why do you want to keep them around ? Such minor useful things. Thank you! Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Fri, Feb 6, 2015 at 1:45 PM, Maxim Solodovnik solomax...@gmail.com wrote: I'm OK with that :) On Fri, Feb 6, 2015 at 5:44 PM, Andrea Del Bene an.delb...@gmail.com wrote: I half agree with this. We should move yui to wicketstuff but I'd rather move the rest of datetime (few classes) under wicket-util. One thing Maybe it make sense to move org.apache.wicket.extensions.yui to wicketstuff but leave org.apache.wicket.datetime as is? On Fri, Feb 6, 2015 at 1:21 PM, Emond Papegaaij emond.papega...@topicus.nl wrote: -- WBR Maxim aka solomax
Re: Decommission of wicket-datetime
Hi devs, Actually Wicket jQuery UI's DatePicker extends org.apache.wicket. *extensions*.markup.html.form.DateTextField By the way, Wicket Utils already have org.apache.wicket.*util*.convert.converter.DateConverter. I did not check the differences.. DateLabel PatternDateConverter are probably convenient. I didn't know they exists so I write them for my work purpose, I suppose many users did the same... So why not moving them to *wicket-extensions* as well... Best regards, Sebastien. On Fri, Feb 6, 2015 at 2:02 PM, Sven Meier s...@meiers.net wrote: Hi Andrea, IMHO the components belong into wicket-extensions. Note that we already have a DateTextField there. Regards Sven On 06.02.2015 13:56, Andrea Del Bene wrote: Those who are not inside org.apache.wicket.extensions.yui :-). Five classes: /wicket-datetime/src/main/java/org/apache/wicket/datetime/DateConverter.java /wicket-datetime/src/main/java/org/apache/wicket/ datetime/PatternDateConverter.java /wicket-datetime/src/main/java/org/apache/wicket/ datetime/StyleDateConverter.java /wicket-datetime/src/main/java/org/apache/wicket/ datetime/markup/html/basic/DateLabel.java /wicket-datetime/src/main/java/org/apache/wicket/ datetime/markup/html/form/DateTextField.java I see no reason to externalize them in a wicketstuff module. They have nothing to do with yui. Maybe the last two classes should go in the core module under org.apache.wicket.markup.html. Please be more detailed when you have to say something. Which classes ? Why do you want to keep them around ? Such minor useful things. Thank you! Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Fri, Feb 6, 2015 at 1:45 PM, Maxim Solodovnik solomax...@gmail.com wrote: I'm OK with that :) On Fri, Feb 6, 2015 at 5:44 PM, Andrea Del Bene an.delb...@gmail.com wrote: I half agree with this. We should move yui to wicketstuff but I'd rather move the rest of datetime (few classes) under wicket-util. One thing Maybe it make sense to move org.apache.wicket.extensions.yui to wicketstuff but leave org.apache.wicket.datetime as is? On Fri, Feb 6, 2015 at 1:21 PM, Emond Papegaaij emond.papega...@topicus.nl wrote: -- WBR Maxim aka solomax
Re: Decommission of wicket-datetime
I see. Also the two DateTextField have no functional difference. This is in short what I would do: Remove: /wicket-datetime/src/main/java/org/apache/wicket/datetime/DateConverter.java Move to wicket-utils: /wicket-datetime/src/main/java/org/apache/wicket/datetime/PatternDateConverter.java /wicket-datetime/src/main/java/org/apache/wicket/datetime/StyleDateConverter.java Move to wicket-extensions: /wicket-datetime/src/main/java/org/apache/wicket/datetime/markup/html/basic/DateLabel.java Merge wicket-datetime DateTextField into the existing wicket-extensions DateTextField. The first one has a DateConverter as constructor parameter which is used internally instead of a more generic IConverterDate. it would be nice to have single component with the same constructors of the existing two. What do you think? On 06/02/15 14:24, Sebastien wrote: Hi devs, Actually Wicket jQuery UI's DatePicker extends org.apache.wicket. *extensions*.markup.html.form.DateTextField By the way, Wicket Utils already have org.apache.wicket.*util*.convert.converter.DateConverter. I did not check the differences.. DateLabel PatternDateConverter are probably convenient. I didn't know they exists so I write them for my work purpose, I suppose many users did the same... So why not moving them to *wicket-extensions* as well... Best regards, Sebastien. On Fri, Feb 6, 2015 at 2:02 PM, Sven Meier s...@meiers.net wrote:
